Re: [E-devel] E SVN: barbieri IN trunk/THEMES/detourious: bits images
Hello. On Tue, 2011-11-22 at 20:09, Lucas De Marchi wrote: On Tue, Nov 22, 2011 at 7:05 PM, Stefan Schmidt ste...@datenfreihafen.org wrote: set for mixer and connman in detorious is the to small contrast Small contrast? Are we talking about the same icons? For me it looks almost like black in a light gray. OK, forget it. I failed here. :) Mixer was muted when looking at it and connman was not running. n this case the icons are more or less greyed out. Makes sense. I just failed to recognize this. See the attached image how it looked to me. Very much missing contrast. Anyway, failed here. All good. :) regards Stefan Schmidt attachment: shelf-old.png-- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E_FM eeze mount compiling but not working (more info)
On Wed, 23 Nov 2011 09:50:32 +1100 Jochen Schröder cycoma...@gmail.com wrote: On 19/11/11 21:08, Mike Blumenkrantz wrote: On Sat, 19 Nov 2011 21:05:07 +1100 Jochen Schrödercycoma...@gmail.com wrote: On 19/11/11 18:59, Mike Blumenkrantz wrote: On Sat, 19 Nov 2011 18:54:47 +1100 Jochen Schrödercycoma...@gmail.com wrote: On 11/18/2011 08:29 PM, Mike Blumenkrantz wrote: On Fri, 18 Nov 2011 20:20:21 +1100 Jochen Schrödercycoma...@gmail.comwrote: On 18/11/11 16:48, Jochen Schröder wrote: On 18/11/11 15:56, Mike Blumenkrantz wrote: On Fri, 18 Nov 2011 15:50:09 +1100 Jochen Schrödercycoma...@gmail.comwrote: On 18/11/11 15:46, Mike Blumenkrantz wrote: On Fri, 18 Nov 2011 15:43:23 +1100 Jochen Schrödercycoma...@gmail.comwrote: On 18/11/11 13:16, Mike Blumenkrantz wrote: On Fri, 18 Nov 2011 09:18:50 +1100 Jochen Schrödercycoma...@gmail.comwrote: Hi all, I'm still trying to get eeze mount to work in E_FM. I have build eeze with libmount support (2.19.1). And I am building E17 with ./configure --disable-mount-hal --disable-mount-udisks, here is the relevant configure output: Preferred Backends: * device..: eeze * hal_mount...: no * udisks_mount: no * eeze_mount..: yes Additionally I have uncommented the following line in sysactions.conf # uncomment this line to enable eeze mounting for users user: someuser allow: /bin/mount /bin/umount /usr/bin/eject When plugging in a device on the usb port nothing appears on the desktop or in the file menu. xsession-errrors reports some dbus error (attached). This system is debian sid. This seems to be the same problem that was reported here: http://osdir.com/ml/enlightenment-development-linux-ui/2011-08/msg00503.html Additionally, when logging out E waits until the logout now, wait longer dialogue shows up (however I have not 100% confirmed that this is related). Cheers Jochen hmm definitely strange since it looks like your devices are being properly detected. please start your e with EINA_LOG_LEVELS=efm:5 and post back your xsession log again. Not sure I'm doing the right thing. Using a .xsession with: export EINA_LOG_LEVELS=efm:5 exect /opt/e17/bin/enlightenment_start and starting with startx should work right? Not much more information unfortunately (xsession-errors attached) Cheers Jochen yeah you did it properly. not seeing any attempts to mount anything though, does your log include the times when you tried? You mean when I plug and unplug the usb disk? I can't mount because the device never appears anywhere, i.e. no icon on the desktop or in the files menu. Cheers Jochen hmm update e now and see if you get the scanner connected message in your log with the log level enabled Ok will do I just updated from svn and recompiled all of EFL. Attached is the xsession-error log when e is compiled with eeze mount only and I plug in a usb disk. EINA_LOG_LEVELS=efm:5 is set (at least it's in env) okay, update e again (just e) and see what happens Had to update all efl because of some compile error. Anyway still no icon when E is compiled with eeze-mount only. xsession-errors attached (it has a restart of e in it because I wanted to try if it appears). this log is using udisks. Sorry too many xsession-error files flying around. This one should be correct. it's not, or you didn't start efm. OK I think I'm getting closer to find out what is going on. I assume you were looking for some line like: INF2163:efm e_fm_main_eeze.c:530 _scanner_delay() Attempting scanner connection In my xsession-error file? I think I've figured out why this did not appear in my files. When I start E for the very first time I also see this message, however when I log out and back in, there is no such message. The problem seems to be a eeze_scanner process (owned by root) that remains running after logging out of E. When I kill the process after logging out and log back in I do see the above message in my logs again. So somehow e_fm can't connect to the already running process. I still do not see any icons appear on the desktop once I plug in a usb drive. new .xsession-errors file attached, with the above line. Hope this helps figuring out what the problem is. I didn't forget about this, just haven't been doing anything e-related for a couple days. I have some testing to do on my side before I get back to you though. -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes
Re: [E-devel] E SVN: discomfitor IN trunk: FORMATTING/ecrustify PROTO/azy PROTO/azy/doc PROTO/azy/src/bin PROTO/azy/src/include PROTO/azy/src/lib PROTO/azy/src/tests PROTO/azy/src/tests/identi.ca PROT
On Wed, 23 Nov 2011 00:40:51 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: change of email address: this is going to be ugly Author: discomfitor Date: 2011-11-23 00:40:50 -0800 (Wed, 23 Nov 2011) New Revision: 65531 Trac: http://trac.enlightenment.org/e/changeset/65531 Modified: trunk/FORMATTING/ecrustify/configure.ac trunk/PROTO/azy/AUTHORS trunk/PROTO/azy/configure.ac trunk/PROTO/azy/doc/azy.dox.in trunk/PROTO/azy/src/bin/azy.c trunk/PROTO/azy/src/bin/azy.h trunk/PROTO/azy/src/bin/azy_parser.yre trunk/PROTO/azy/src/bin/azy_parser_lib.c trunk/PROTO/azy/src/bin/azy_parser_lib.h trunk/PROTO/azy/src/bin/main.c trunk/PROTO/azy/src/include/Azy.h trunk/PROTO/azy/src/include/azy_private.h trunk/PROTO/azy/src/lib/azy_client.c trunk/PROTO/azy/src/lib/azy_client_events.c trunk/PROTO/azy/src/lib/azy_content.c trunk/PROTO/azy/src/lib/azy_content_json.c trunk/PROTO/azy/src/lib/azy_content_xml.cpp trunk/PROTO/azy/src/lib/azy_events.c trunk/PROTO/azy/src/lib/azy_lib.c trunk/PROTO/azy/src/lib/azy_net.c trunk/PROTO/azy/src/lib/azy_rss.c trunk/PROTO/azy/src/lib/azy_rss_item.c trunk/PROTO/azy/src/lib/azy_server.c trunk/PROTO/azy/src/lib/azy_server_events.c trunk/PROTO/azy/src/lib/azy_server_module.c trunk/PROTO/azy/src/lib/azy_utils.c trunk/PROTO/azy/src/lib/azy_value.c trunk/PROTO/azy/src/tests/client.c trunk/PROTO/azy/src/tests/identi.ca/get.c trunk/PROTO/azy/src/tests/identi.ca/identi.ca.azy trunk/PROTO/azy/src/tests/rss/rss.c trunk/PROTO/azy/src/tests/server.c trunk/PROTO/azy/src/tests/stress_client.c trunk/PROTO/azy/src/tests/test.azy trunk/PROTO/azy/src/tests/unit/t001_content.c trunk/PROTO/email/AUTHORS trunk/PROTO/email/email.c trunk/PROTO/email/email_private.h trunk/PROTO/email/pop_list.c trunk/PROTO/email/pop_login.c trunk/PROTO/esskyuehl/AUTHORS trunk/PROTO/esskyuehl/configure.ac trunk/PROTO/esskyuehl/doc/esskyuehl.dox.in trunk/PROTO/esskyuehl/src/lib/esql.c trunk/PROTO/esskyuehl/src/lib/esql_connect.c trunk/PROTO/esskyuehl/src/lib/esql_convert.c trunk/PROTO/esskyuehl/src/lib/esql_events.c trunk/PROTO/esskyuehl/src/lib/esql_pool.c trunk/PROTO/esskyuehl/src/lib/esql_private.h trunk/PROTO/esskyuehl/src/lib/esql_query.c trunk/PROTO/esskyuehl/src/lib/esql_res.c trunk/PROTO/esskyuehl/src/lib/mysql/esql_mysql_backend.c trunk/PROTO/esskyuehl/src/lib/postgresql/esql_postgresql_backend.c trunk/PROTO/esskyuehl/src/tests/basic_pool.c trunk/PROTO/esskyuehl/src/tests/basic_query.c trunk/PROTO/ev/AUTHORS trunk/PROTO/ev/ev.c trunk/PROTO/eyesight/AUTHORS trunk/devs/discomfitor/geany_tagger.sh trunk/devs/discomfitor/info.txt trunk/e/AUTHORS trunk/e/src/modules/notification/AUTHORS trunk/ecore/AUTHORS trunk/ecore/src/lib/ecore/Ecore.h trunk/edje/AUTHORS trunk/eet/AUTHORS trunk/eet/src/lib/Eet.h trunk/eeze/AUTHORS trunk/elementary/AUTHORS effective immediately, please use this address. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E_FM eeze mount compiling but not working (more info)
On 23/11/2011 09:14, Mike Blumenkrantz wrote: On Wed, 23 Nov 2011 09:50:32 +1100 Jochen Schröder cycoma...@gmail.com wrote: OK I think I'm getting closer to find out what is going on. I assume you were looking for some line like: INF2163:efm e_fm_main_eeze.c:530 _scanner_delay() Attempting scanner connection In my xsession-error file? I think I've figured out why this did not appear in my files. When I start E for the very first time I also see this message, however when I log out and back in, there is no such message. The problem seems to be a eeze_scanner process (owned by root) that remains running after logging out of E. When I kill the process after logging out and log back in I do see the above message in my logs again. So somehow e_fm can't connect to the already running process. I still do not see any icons appear on the desktop once I plug in a usb drive. new .xsession-errors file attached, with the above line. Hope this helps figuring out what the problem is. I didn't forget about this, just haven't been doing anything e-related for a couple days. I have some testing to do on my side before I get back to you though. Theres a time where stripping quotes gets really necessary. attachment: guillaume_friloux.vcf signature.asc Description: OpenPGP digital signature -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] yet another edje group inherit bug
On Fri, 18 Nov 2011 16:17:54 -0500 Mike Blumenkrantz m...@zentific.com said: programs don't inherit properly. if you make a program with the same name as an inherited program that targets the same part as the inherited program, edje_cc will not compile the edc. that'll now be fuuxed mate :) -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] yet another edje group inherit bug
On Wed, 23 Nov 2011 19:43:16 +0900 Carsten Haitzler (The Rasterman) ras...@rasterman.com wrote: On Fri, 18 Nov 2011 16:17:54 -0500 Mike Blumenkrantz m...@zentific.com said: programs don't inherit properly. if you make a program with the same name as an inherited program that targets the same part as the inherited program, edje_cc will not compile the edc. that'll now be fuuxed mate :) so...you broke it further? also does this fix similar cases in script blocks? -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] yet another edje group inherit bug
On Wed, 23 Nov 2011 05:47:32 -0500 Michael Blumenkrantz michael.blumenkra...@gmail.com said: On Wed, 23 Nov 2011 19:43:16 +0900 Carsten Haitzler (The Rasterman) ras...@rasterman.com wrote: On Fri, 18 Nov 2011 16:17:54 -0500 Mike Blumenkrantz m...@zentific.com said: programs don't inherit properly. if you make a program with the same name as an inherited program that targets the same part as the inherited program, edje_cc will not compile the edc. that'll now be fuuxed mate :) so...you broke it further? also does this fix similar cases in script blocks? for inherited programs its a very good idea to not go change them, if you do, it'll override single fields, but targets are now just appended. if you don't list new targets then it wont add any. there is no keyword to reset the list. i didn't look at script blocks. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] yet another edje group inherit bug
On Wed, 23 Nov 2011 20:01:33 +0900 Carsten Haitzler (The Rasterman) ras...@rasterman.com wrote: On Wed, 23 Nov 2011 05:47:32 -0500 Michael Blumenkrantz michael.blumenkra...@gmail.com said: On Wed, 23 Nov 2011 19:43:16 +0900 Carsten Haitzler (The Rasterman) ras...@rasterman.com wrote: On Fri, 18 Nov 2011 16:17:54 -0500 Mike Blumenkrantz m...@zentific.com said: programs don't inherit properly. if you make a program with the same name as an inherited program that targets the same part as the inherited program, edje_cc will not compile the edc. that'll now be fuuxed mate :) so...you broke it further? also does this fix similar cases in script blocks? for inherited programs its a very good idea to not go change them, if you do, it'll override single fields, but targets are now just appended. if you don't list new targets then it wont add any. there is no keyword to reset the list. i didn't look at script blocks. hmmm appending targets is annoying... cedric was picking at script blocks, so maybe talk to him about it -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] yet another edje group inherit bug
On Wed, 23 Nov 2011 06:05:03 -0500 Michael Blumenkrantz michael.blumenkra...@gmail.com said: On Wed, 23 Nov 2011 20:01:33 +0900 Carsten Haitzler (The Rasterman) ras...@rasterman.com wrote: On Wed, 23 Nov 2011 05:47:32 -0500 Michael Blumenkrantz michael.blumenkra...@gmail.com said: On Wed, 23 Nov 2011 19:43:16 +0900 Carsten Haitzler (The Rasterman) ras...@rasterman.com wrote: On Fri, 18 Nov 2011 16:17:54 -0500 Mike Blumenkrantz m...@zentific.com said: programs don't inherit properly. if you make a program with the same name as an inherited program that targets the same part as the inherited program, edje_cc will not compile the edc. that'll now be fuuxed mate :) so...you broke it further? also does this fix similar cases in script blocks? for inherited programs its a very good idea to not go change them, if you do, it'll override single fields, but targets are now just appended. if you don't list new targets then it wont add any. there is no keyword to reset the list. i didn't look at script blocks. hmmm appending targets is annoying... well what should it do? u have to be able to remove, append, clear etc. then - if u say nothing it should inherit the previous target list. as there is no facility to clear or remove... it just appends targets. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Add new elementary widget 'Multibuttonentry'
2011/11/23 GoUn Lee gouni@samsung.com: Dear Developers, I added a new widget called “Multibuttonentry which could be used as contact button in App This widget allows a user to insert a text button. text button is inserted by pressing the Enter key If there is no space in the current row, the new button is entered in the next row. If the button is clicked, it will become focused. And focused button can be removed by pressing the backspace key. when items are added over 1 lines, if Multibuttonentry lost focus, it becase shrink mode (made it as 1 line) Please review it's APIs and functionalities. I didn't review the code and I don't have time for that now, but a quick look at the patch already tells me that documentation is poor. + /** +* Set the guide text +* +* @param obj The multibuttonentry object +* @param label The guide text string +* +* @ingroup Multibuttonentry +*/ + EAPI void elm_multibuttonentry_guide_text_set(Evas_Object *obj, const char *guidetext) EINA_ARG_NONNULL(1); I can see in the function name that this function sets the guide text. But what is the guide text? What does it do? Why do I want to set it? For new widgets, having clear documentation also helps with the review. It makes it clear what the intention of each function, and the whole widget, is, so that we can read the code and match it to that intention, finding possible problems in things that without knowing any better, would look just fine. Thank you, Goun -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/edje/src/bin
2011/11/23 Enlightenment SVN no-re...@enlightenment.org:
Log:
aaah allow type to be set on group inherit or part inherit... you just
really shouldnt set it to a different type as its not very sensible.
Author: raster
Date: 2011-11-23 02:38:43 -0800 (Wed, 23 Nov 2011)
New Revision: 65534
Trac: http://trac.enlightenment.org/e/changeset/65534
Modified:
trunk/edje/src/bin/edje_cc_handlers.c
Modified: trunk/edje/src/bin/edje_cc_handlers.c
===
--- trunk/edje/src/bin/edje_cc_handlers.c 2011-11-23 08:49:47 UTC (rev
65533)
+++ trunk/edje/src/bin/edje_cc_handlers.c 2011-11-23 10:38:43 UTC (rev
65534)
@@ -2965,13 +2965,6 @@
EXTERNAL, EDJE_PART_TYPE_EXTERNAL,
PROXY, EDJE_PART_TYPE_PROXY,
NULL);
-
- if (current_part-default_desc || current_part-other.desc_count 0)
- {
- ERR(%s: Error. parse error %s:%i. You can't change the part type in
inherited group. (part: %s),
- progname, file_in, line - 1, current_part-name);
- exit(-1);
- }
}
Can't we check if the type doesn't match and give an error in that case?
/**
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch][Ecore][Win32] Some Issues
Dear All, Hello~
There are some issues as following
1) Key combination like Ctrl + a, Alt +a does not work properly.
2) event-keyname: should be lower case
3) event-modifiers: should be handled - This is used on the Entry of
elementary_test. EX: Ctrl+A should work for selecting all
4) ecore_win32_event_char_get(); is not called when key is released,
So, the event ECORE_EVENT_KEY_UP with character does not occur.
5) Tab key does not work properly on the Entry of elementary_test.
6) Improper Null check in _ecore_win32_event_char_get(); It returns 1
always.. Maybe there is a better solution than my patch.
7) VK_PROCESSKY was not handled. When you click button the VK_PROCESSKY comes.
I think attached patch would be resolved these issues.
Please check the patch and give any feedbacks. Thanks
Sincerely,
Shinwoo Kim.
Index: src/lib/ecore_win32/ecore_win32_private.h
===
--- src/lib/ecore_win32/ecore_win32_private.h (revision 65535)
+++ src/lib/ecore_win32/ecore_win32_private.h (working copy)
@@ -135,7 +135,7 @@ extern Ecore_Win32_Window *_ecore_win32_event_last
void _ecore_win32_event_handle_key_press(Ecore_Win32_Callback_Data *msg, int is_keystroke);
-void _ecore_win32_event_handle_key_release(Ecore_Win32_Callback_Data *msg, int is_keystroke);
+void _ecore_win32_event_handle_key_release(Ecore_Win32_Callback_Data *msg);
void _ecore_win32_event_handle_button_press(Ecore_Win32_Callback_Data *msg, int button);
void _ecore_win32_event_handle_button_release(Ecore_Win32_Callback_Data *msg, int button);
void _ecore_win32_event_handle_motion_notify(Ecore_Win32_Callback_Data *msg);
Index: src/lib/ecore_win32/ecore_win32.c
===
--- src/lib/ecore_win32/ecore_win32.c (revision 65535)
+++ src/lib/ecore_win32/ecore_win32.c (working copy)
@@ -88,13 +88,14 @@ _ecore_win32_window_procedure(HWND window,
_ecore_win32_event_handle_key_press(data, 1);
return 0;
case WM_CHAR:
+ case WM_SYSCHAR:
INF(char message);
_ecore_win32_event_handle_key_press(data, 0);
return 0;
case WM_KEYUP:
case WM_SYSKEYUP:
INF(keyup message);
- _ecore_win32_event_handle_key_release(data, 1);
+ _ecore_win32_event_handle_key_release(data);
return 0;
case WM_SETFOCUS:
INF(setfocus message);
Index: src/lib/ecore_win32/ecore_win32_event.c
===
--- src/lib/ecore_win32/ecore_win32_event.c (revision 65535)
+++ src/lib/ecore_win32/ecore_win32_event.c (working copy)
@@ -4,6 +4,7 @@
#include stdlib.h
#include stdio.h /* for printf */
+#include ctype.h /* for tolower */
#define WIN32_LEAN_AND_MEAN
#include windows.h
@@ -107,12 +108,19 @@ _ecore_win32_event_handle_key_press(Ecore_Win32_Ca
_ecore_win32_event_last_time = e-timestamp;
+ SHORT res;
+ res = GetKeyState(VK_SHIFT);
+ if (res 0x8000) e-modifiers = 1;
+ res = GetKeyState(VK_CONTROL);
+ if (res 0x8000) e-modifiers = 2;
+ res = GetKeyState(VK_MENU);
+ if (res 0x8000) e-modifiers = 4;
+
ecore_event_add(ECORE_EVENT_KEY_DOWN, e, _ecore_win32_event_free_key_down, NULL);
}
void
-_ecore_win32_event_handle_key_release(Ecore_Win32_Callback_Data *msg,
- intis_keystroke)
+_ecore_win32_event_handle_key_release(Ecore_Win32_Callback_Data *msg)
{
Ecore_Event_Key *e;
@@ -121,22 +129,14 @@ void
e = (Ecore_Event_Key *)calloc(1, sizeof(Ecore_Event_Key));
if (!e) return;
- if (is_keystroke)
+ if (!_ecore_win32_event_keystroke_get(LOWORD(msg-window_param),
+ msg-data_param 0x0100,
+ EINA_FALSE,
+ (char **)e-keyname,
+ (char **)e-key,
+ (char **)e-string))
{
-if (!_ecore_win32_event_keystroke_get(LOWORD(msg-window_param),
- msg-data_param 0x0100,
- EINA_FALSE,
- (char **)e-keyname,
- (char **)e-key,
- (char **)e-string))
- {
- free(e);
- return;
- }
- }
- else
- {
-if (!_ecore_win32_event_char_get(LOWORD(msg-window_param),
+if(!_ecore_win32_event_char_get(LOWORD(msg-window_param),
(char **)e-keyname,
(char **)e-key,
(char **)e-string))
@@ -157,7 +157,16 @@ void
_ecore_win32_event_last_time = e-timestamp;
+ SHORT res;
+ res = GetKeyState(VK_SHIFT);
+ if (res 0x8000) e-modifiers = 1;
+ res = GetKeyState(VK_CONTROL);
+ if (res 0x8000) e-modifiers = 2;
+ res = GetKeyState(VK_MENU);
+ if (res 0x8000) e-modifiers = 4;
+
Re: [E-devel] [Patch][Ecore][Win32] Some Issues
Hey On Wed, 23 Nov 2011, cnook wrote: Dear All, Hello~ There are some issues as following 1) Key combination like Ctrl + a, Alt +a does not work properly. 2) event-keyname: should be lower case 3) event-modifiers: should be handled - This is used on the Entry of elementary_test. EX: Ctrl+A should work for selecting all 4) ecore_win32_event_char_get(); is not called when key is released, So, the event ECORE_EVENT_KEY_UP with character does not occur. 5) Tab key does not work properly on the Entry of elementary_test. 6) Improper Null check in _ecore_win32_event_char_get(); It returns 1 always.. Maybe there is a better solution than my patch. 7) VK_PROCESSKY was not handled. When you click button the VK_PROCESSKY comes. I think attached patch would be resolved these issues. Please check the patch and give any feedbacks. Thanks looking at the code (i'm at work right now) : ECORE_EVENT_MODIFIER_* (in Ecore_Input.h) values must be used. declare variables at the beginning of the scope I think that the modifier must be set when the key is pressed. TCHAR is useless, i'm working in ANSI, not UNICODE for windows. strcmp(*keyname, ) : **keyname == '\0' anyway, i'll have to check that thanks Vincent -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: barbieri IN trunk/THEMES/detourious: bits images
On Tue, Nov 22, 2011 at 10:14 PM, Carsten Haitzler ras...@rasterman.com wrote: On Tue, 22 Nov 2011 17:27:54 -0200 Gustavo Sverzut Barbieri barbi...@profusion.mobi said: On Tue, Nov 22, 2011 at 4:31 AM, Carsten Haitzler ras...@rasterman.com wrote: On Sun, 13 Nov 2011 14:25:51 -0200 Gustavo Sverzut Barbieri barbi...@profusion.mobi said: On Sun, Nov 13, 2011 at 1:35 PM, hannes.janet...@gmail.com hannes.janet...@googlemail.com wrote: On Sun, Nov 13, 2011 at 4:15 PM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: On Sun, Nov 13, 2011 at 9:57 AM, hannes.janet...@gmail.com hannes.janet...@googlemail.com wrote: On Sun, Nov 13, 2011 at 8:47 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: THEMES/detorious: try a simpler pager. Couple of people reported that they found the pager a bit strange, I also felt the same, then I'm trying a new one that is more clean in the design. Pager is usually quite small and holds windows, possibly lots of them (xterms side by side), in this case all those details were cluttering the results. Replaced the sunken border with a single line at left and right, the focused background is a plain rectangle with the focused color. This should look fine in both inset and plain styles. Windows have no detail. Unfocused are semi-transparent, focused is opaque. Just focused window have icon, and the icon should be at least 16x16. If you dislike it, feel free to revert. the desk image needs a top and/or bottom separator when having more than one row or when used in pager popup, otherwise I'm ok it. In pager popup I'm missing the icons for orientation, imo there should check r65132. See if it's any better. yup, looks good now. somewhere the clipping of windows to desk got lost though fixed in r65133. thanks do people like the new pager look? still not 100% satisfied, I'm out of ideas WRT to it, but so far my impression is that it is TOO COMPLEX and needs simplifying. See below. yeah - the shadow just doesn't work there unless you start making all the elements look 3d too. open to ideas, the shadow thing was more a way to provide contrast. This one I did not talk to Marina, will ask her input today. battery is ok i guess, though if u want it like that, maybe battery should be vertical so it uses less horizontal space? or battery gadget needs to appropriately rotate battery (use different edje groups maybe) based on shelf size (if very thin then make it horizontal like now but fill the shelf height)? the default looks were all fitting into a square, so this is not coming out too well i think. what do people think? the reasoning behind horizontal battery is that it's on an horizontal shelf, so you have more empty space around it in vertical area, that is more constrained. I can ask marina to draw new version (actually just the charging icon needs to keep unrotated), but IMO horizontal is visually better as it feels less cluttered. well it looks like a lot of wasted space above/below if the battery gadget became twice as wide instead and had the battery fill the area... it'd match better but it'd just be huge then. the battery there would look right on the kind of panel that macos has where its much smaller than the shelf AND your battery fills the panel height, not half of it. if we had a 16 pixel high shelf and it filled.. it'd be good. space is good, gives eyes a rest. Anyway, if you wish the rotation I can ask for new images. Just don't think having more dark will help. See connman's wired, it's in the same lines. i'm thinking maybe battery should be inset like the inset look of the pager/ibar etc. I have a strong dislike for inset. It adds too much visual noise to the shelf, that is already usually small. Right now I'm okay with it just for the systray, because we need it for a solid background due xwindow reparenting. well the pager, ibox, ibar, systray and tasks all are inset by default. as the battery is basically a lump of black (well dark grey) it simply would match the visual style if also inset. just the battery icon - not the whole gadget inside an inset frame. just the battery icon. :) Could we change pager, ibox, ibar to plain? I did not notice they were like that by default. Also, likely it's better to have the theme to specify how it likes it? Or at least a default = theme-chooses, with specific to override it (ie: tasks) as for the internal slot inside the battery... got it... but would totally defeat the purpose of the icon :-( BTW, I'll try to find a way to remove the visual weight of the inset box. if you have a shelf without insets it looks way cleaner, see the attached screenshot. Even if you make all status (battery, connman, bluetooth, mixer) share the same inset box, you can see from ibar it's not as clean. well as it is there, it stands out as
[E-devel] Problem with list
Hi, I have some problem... I have a list, each item has a icon, but I would like that each icon was leaning (no spaces) with each other.. I made some changes in the theme to do that, but I found a problem. The function _fix_items (inside elm_list.c) always is called and follow code is executed: mw = mh = -1; elm_coords_finger_size_adjust(1, mw, 1, mh); edje_object_size_min_restricted_calc(VIEW(it), mw, mh, mw, mh); elm_coords_finger_size_adjust(1, mw, 1, mh); evas_object_size_hint_min_set(VIEW(it), mw, mh); evas_object_show(VIEW(it)); The efl always change my size_hint_mim to the value bigger than my icon size, so spaces will add between icons... How can I fix this!? Regards, -- Guilherme Silveira E-mail: xgu...@gmail.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Problem with framebuffer and tslib
On Sat, Nov 19, 2011 at 1:46 AM, Carsten Haitzler ras...@rasterman.com wrote: On Fri, 18 Nov 2011 13:46:31 -0200 Guilherme Silveira xgu...@gmail.com said: already reported by paulo benatto. antognolli said he'll try fix it. Should be fixed in http://trac.enlightenment.org/e/changeset/65539 Let me know if it still doesn't work. Hi all, I'm cross-compiling EFL to blackfin, and I'm using framebuffer and tslib to touch screen... Some days ago I was using release version, but told me to update to trunk version... Now I'm having some problems with touch.. I verified in the code my problem... I put some debugs and I saw that ecore was receiving events from tslib, but this events have not arrived in evas lib. In the file ecore_input_evas/ecore_input_evas.c has a function called by _ecore_event_evas_mouse_button, this function is executed and should emit event to evas, but in the beginning of function we have follow verification: lookup = _ecore_event_window_match(e-event_window); if (!lookup) return ECORE_CALLBACK_RENEW; What happened that e-event_window is NULL, so lookup var is NULL too, so the function is returned! For this reason the event doesn't arrive in the evas. I tried to know why event_window was NULL... I look up for a code that create variable e (Ecore_Event_Mouse_Button type) and I found this file ecore_fb/ecore_fb_ts.c in the function _ecore_fb_ts_fd_handler and the member event_window of Ecore_Event_Mouse_Button was not setted... I looked in the release version what was changed, and this code was very similar... The big difference was in this commit http://trac.enlightenment.org/e/browser/trunk/ecore/src/lib/ecore_evas/ecore_evas_fb.c?rev=64447 the function evas_event_feed_mouse_down is no longer called in the _ecore_evas_event_mouse_button_down function, and how the event to be emitted depends of _ecore_event_evas_mouse_button function it doesn't called anymore. Regards, -- Guilherme Santos E-mail: xgu...@gmail.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler) ras...@rasterman.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel Regards, -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] SVN Regressions
Version of Libcurl in use here is: 7.19.7-1ubuntu1.1 On Wed, Nov 23, 2011 at 8:30 AM, Cedric BAIL cedric.b...@free.fr wrote: On Wed, Nov 23, 2011 at 1:20 AM, Carsten Haitzler ras...@rasterman.com wrote: On Tue, 22 Nov 2011 11:05:55 -0600 Jeff Hoogland jeffhoogl...@linux.com said: There are currently two SVN regressions that are preventing me from pushing out the most recent SVN pulls to my Bodhi users. They are: E's Screenshot Upload no longer works. The latest working SVN revision (which we currently use) is 63667. just uploaded: http://www.enlightenment.org/ss/e-4ecc3b57ac1171.71863071.jpg so are u keeping the shot module ALONE stuck at 63667? or everything? or all of e? or??? fyi - right now i'm not caring about e17 bugs at all UNLESS its a bug in efl (for 1.1). :) so i'm trying to narrow down if this is an ecore_con issue or not, but it works for me. I have a bet on this one. What is the version of libcurl and what are your compile option of libcurl ? And did you try with an older version of libcurl ? -- Cedric BAIL -- ~Jeff Hoogland http://jeffhoogland.com/ Thoughts on Technology http://jeffhoogland.blogspot.com/, Tech Blog Bodhi Linux http://bodhilinux.com/, Enlightenment for your Desktop -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] API break on ecore_fb_input
Hello guys,
Recently I sent this change to ecore_fb_input:
http://trac.enlightenment.org/e/changeset/64447
It changes
ecore_fb_input_device_open(const char *dev)
to
ecore_fb_input_device_open(void *window, const char *dev)
Sorry, I didn't notice that this API was public at that time, but I
also think that it isn't used outside of Ecore. Anyway, I would like
to fix this break before the release.
The options are either reverting this commit (and others related to
it), or applying the attached patch, which would make that function
have the previous signature, but introduces a new function:
So, any objections that I apply this patch now? Or should I just revert it?
--
Rafael Antognolli
ProFUSION embedded systems
http://profusion.mobi
diff --git a/ChangeLog b/ChangeLog
index 36790b5..e05a2b1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -343,3 +343,6 @@
* Fix setting override state to only hide if it should be
visible at that point in x back end support
+2011-11-23 Rafael Antognolli
+
+* Add ecore_fb_input_device_window_set().
diff --git a/src/lib/ecore_evas/ecore_evas_fb.c b/src/lib/ecore_evas/ecore_evas_fb.c
index 77d9153..3ee913e 100644
--- a/src/lib/ecore_evas/ecore_evas_fb.c
+++ b/src/lib/ecore_evas/ecore_evas_fb.c
@@ -208,8 +208,9 @@ _ecore_evas_fb_init(Ecore_Evas *ee, int w, int h)
continue;
snprintf(device_path, 256, /dev/input/%s, input_entry-d_name);
-if (!(device = ecore_fb_input_device_open(ee, device_path)))
+if (!(device = ecore_fb_input_device_open(device_path)))
continue;
+ecore_fb_input_device_window_set(device, ee);
caps = ecore_fb_input_device_cap_get(device);
diff --git a/src/lib/ecore_fb/Ecore_Fb.h b/src/lib/ecore_fb/Ecore_Fb.h
index 37b9e1e..069cccd 100644
--- a/src/lib/ecore_fb/Ecore_Fb.h
+++ b/src/lib/ecore_fb/Ecore_Fb.h
@@ -70,7 +70,7 @@ EAPI void ecore_fb_callback_gain_set(void (*func) (void *da
EAPI void ecore_fb_callback_lose_set(void (*func) (void *data), void *data);
/* ecore_fb_li.c */
-EAPI Ecore_Fb_Input_Device*ecore_fb_input_device_open(void *window, const char *dev);
+EAPI Ecore_Fb_Input_Device*ecore_fb_input_device_open(const char *dev);
EAPI void ecore_fb_input_device_close(Ecore_Fb_Input_Device *dev);
EAPI void ecore_fb_input_device_listen(Ecore_Fb_Input_Device *dev, Eina_Bool listen);
EAPI const char *ecore_fb_input_device_name_get(Ecore_Fb_Input_Device *dev);
@@ -78,6 +78,7 @@ EAPI Ecore_Fb_Input_Device_Cap ecore_fb_input_device_cap_get(Ecore_Fb_Input_Devi
EAPI void ecore_fb_input_device_axis_size_set(Ecore_Fb_Input_Device *dev, int w, int h);
EAPI void ecore_fb_input_threshold_click_set(Ecore_Fb_Input_Device *dev, double threshold);
EAPI doubleecore_fb_input_threshold_click_get(Ecore_Fb_Input_Device *dev);
+EAPI void ecore_fb_input_device_window_set(Ecore_Fb_Input_Device *dev, void *window);
/* ecore_fb.c */
diff --git a/src/lib/ecore_fb/ecore_fb_li.c b/src/lib/ecore_fb/ecore_fb_li.c
index 0b0900c..970869b 100644
--- a/src/lib/ecore_fb/ecore_fb_li.c
+++ b/src/lib/ecore_fb/ecore_fb_li.c
@@ -452,6 +452,42 @@ ecore_fb_input_device_listen(Ecore_Fb_Input_Device *dev, Eina_Bool listen)
#endif
/**
+ * @brief Associates an input device with the given @ref Ecore_Evas.
+ *
+ * @param dev The input being associated with an @ref Ecore_Evas (not @c NULL).
+ * @param window The window which this input is being associated to.
+ * @c NULL will remove any previous association.
+ *
+ * Events generated by this device will have a pointer to @p window. If this @p
+ * window is registered with ecore_event_window_register() or
+ * ecore_evas_input_event_register(), respective evas events will be delivered
+ * by the ecore_input_evas system. An example can be seen in the following code:
+ *
+ * @code
+ * Ecore_Evas *ee = ecore_evas_new(NULL, 0, 0, 800, 600, NULL);
+ *
+ * ecore_evas_input_event_register(ee);
+ *
+ * device = ecore_fb_input_device_open(device_path);
+ * if (device)
+ * ecore_fb_input_device_window_set(device, ee);
+ *
+ * @endcode
+ *
+ * On the previous code, all input captured on the mentioned device will be
+ * delivered to the @Ecore_Evas @c ee.
+ *
+ * @since 1.1
+ */
+EAPI void
+ecore_fb_input_device_window_set(Ecore_Fb_Input_Device *dev, void *window)
+{
+ if (!dev) return;
+
+ dev-window = window;
+}
+
+/**
* @brief Open an input device.
*
* @param dev The device to open.
@@ -461,7 +497,7 @@ ecore_fb_input_device_listen(Ecore_Fb_Input_Device *dev, Eina_Bool listen)
* object for it, or returns @c NULL on failure.
*/
EAPI Ecore_Fb_Input_Device *
-ecore_fb_input_device_open(void *ee, const char *dev)
+ecore_fb_input_device_open(const char *dev)
{
Ecore_Fb_Input_Device *device;
unsigned long event_type_bitmask[EV_CNT / 32 + 1];
@@ -525,7
[E-devel] Ecore --disable-largefile doesn't.
Ecore --disable-largefile doesn't. As far as I can tell, the reason is this in ecore/src/lib/ecore_file/ecore_file_private.h - #ifndef _FILE_OFFSET_BITS # define _FILE_OFFSET_BITS 64 #endif I think that just turns on large file support, no matter what the AC_SYS_LARGEFILE configure macro tells it to do. Eina does the same thing, but without that define anywhere and --disable-largefile works fine there. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Ecore --disable-largefile doesn't.
On Thu, 24 Nov 2011, David Seikel wrote: Ecore --disable-largefile doesn't. As far as I can tell, the reason is this in ecore/src/lib/ecore_file/ecore_file_private.h - #ifndef _FILE_OFFSET_BITS # define _FILE_OFFSET_BITS 64 #endif I think that just turns on large file support, no matter what the AC_SYS_LARGEFILE configure macro tells it to do. Eina does the same thing, but without that define anywhere and --disable-largefile works fine there. the usual, people keep overload what configure detects. fixed in svn Vincent -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Ecore --disable-largefile doesn't.
On 11/24/2011 07:39 AM, David Seikel wrote: Ecore --disable-largefile doesn't. As far as I can tell, the reason is What is the point of the option? Seems like bloat to me, why not delete it? thanks, Mike -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Ecore --disable-largefile doesn't.
On Thu, 24 Nov 2011 09:31:09 +0900 Mike McCormack mj.mccorm...@samsung.com wrote: On 11/24/2011 07:39 AM, David Seikel wrote: Ecore --disable-largefile doesn't. As far as I can tell, the reason is What is the point of the option? Seems like bloat to me, why not delete it? So I can remove a few more bytes from my embedded project that does not need large file support, since the largest file is the 10MB OS itself. Anything with the word large in it seems like a good target to remove. B-) -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][Ecore][Win32] Some Issues
Thanks for your response! I'll refine with ECORE_EVENT_MODIFIER_*. And TCHAR is already there.. Anyhow, I'll remove it. Thank you~ :) 2011/11/23 Vincent Torri vto...@univ-evry.fr Hey On Wed, 23 Nov 2011, cnook wrote: Dear All, Hello~ There are some issues as following 1) Key combination like Ctrl + a, Alt +a does not work properly. 2) event-keyname: should be lower case 3) event-modifiers: should be handled - This is used on the Entry of elementary_test. EX: Ctrl+A should work for selecting all 4) ecore_win32_event_char_get(); is not called when key is released, So, the event ECORE_EVENT_KEY_UP with character does not occur. 5) Tab key does not work properly on the Entry of elementary_test. 6) Improper Null check in _ecore_win32_event_char_get(); It returns 1 always.. Maybe there is a better solution than my patch. 7) VK_PROCESSKY was not handled. When you click button the VK_PROCESSKY comes. I think attached patch would be resolved these issues. Please check the patch and give any feedbacks. Thanks looking at the code (i'm at work right now) : ECORE_EVENT_MODIFIER_* (in Ecore_Input.h) values must be used. declare variables at the beginning of the scope I think that the modifier must be set when the key is pressed. TCHAR is useless, i'm working in ANSI, not UNICODE for windows. strcmp(*keyname, ) : **keyname == '\0' anyway, i'll have to check that thanks Vincent -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Ecore --disable-largefile doesn't.
So I can remove a few more bytes from my embedded project that does not need large file support, since the largest file is the 10MB OS itself. Anything with the word large in it seems like a good target to remove. B-) Presumably you've disabled large file support in your libc and/or kernel, so the build should detect that, and the option should be unnecessary. thanks, Mike -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Ecore --disable-largefile doesn't.
On Thu, 24 Nov 2011 10:14:33 +0900 Mike McCormack mj.mccorm...@samsung.com wrote: So I can remove a few more bytes from my embedded project that does not need large file support, since the largest file is the 10MB OS itself. Anything with the word large in it seems like a good target to remove. B-) Presumably you've disabled large file support in your libc and/or kernel, so the build should detect that, and the option should be unnecessary. That's the theory, in practice it does not work that way. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/edje/src/bin
On Wed, 23 Nov 2011 10:32:51 -0200 Iván Briano (Sachiel) sachi...@gmail.com
said:
2011/11/23 Enlightenment SVN no-re...@enlightenment.org:
Log:
aaah allow type to be set on group inherit or part inherit... you just
really shouldnt set it to a different type as its not very sensible.
Author: raster
Date: 2011-11-23 02:38:43 -0800 (Wed, 23 Nov 2011)
New Revision: 65534
Trac: http://trac.enlightenment.org/e/changeset/65534
Modified:
trunk/edje/src/bin/edje_cc_handlers.c
Modified: trunk/edje/src/bin/edje_cc_handlers.c
===
--- trunk/edje/src/bin/edje_cc_handlers.c 2011-11-23 08:49:47 UTC
(rev 65533) +++ trunk/edje/src/bin/edje_cc_handlers.c 2011-11-23
10:38:43 UTC (rev 65534) @@ -2965,13 +2965,6 @@
EXTERNAL, EDJE_PART_TYPE_EXTERNAL,
PROXY, EDJE_PART_TYPE_PROXY,
NULL);
-
- if (current_part-default_desc || current_part-other.desc_count 0)
- {
- ERR(%s: Error. parse error %s:%i. You can't change the part type
in inherited group. (part: %s),
- progname, file_in, line - 1, current_part-name);
- exit(-1);
- }
}
Can't we check if the type doesn't match and give an error in that case?
we can... except this would break the intial type setting as the struct is
newly alloced with 0's all thru... and so u couldnt know the difference between
initial set of type and a later change in type. :) we'd need to go add more
info/fllags and what not to know its been inherited etc.
--
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: mike_m IN trunk/elementary: . data/objects data/themes data/themes/widgets src/bin src/lib
On 11/24/2011 10:10 AM, Michael Blumenkrantz wrote: umm...unless I'm mistaken this was not given NEARLY enough time to be reviewed on the list. and as you are an author, you cannot self-review... Sorry to rush. My judgement is that this will go in one way or the other at some point. It has been around internally for one year, is in constant use, etc. It's not a prototype that somebody thought up yesterday and is suddenly pushing today. IMO, it should have been upstreamed and committed much sooner, so I'm a bit impatient to get the damn thing merged. Sorry to step on your toes. I'll do my best to make sure that the review comments are addressed. Mike -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: mike_m IN trunk/elementary: . data/objects data/themes data/themes/widgets src/bin src/lib
On Thu, 24 Nov 2011 10:35:09 +0900 Mike McCormack mj.mccorm...@samsung.com wrote: On 11/24/2011 10:10 AM, Michael Blumenkrantz wrote: umm...unless I'm mistaken this was not given NEARLY enough time to be reviewed on the list. and as you are an author, you cannot self-review... Sorry to rush. My judgement is that this will go in one way or the other at some point. It has been around internally for one year, is in constant use, etc. It's not a prototype that somebody thought up yesterday and is suddenly pushing today. IMO, it should have been upstreamed and committed much sooner, so I'm a bit impatient to get the damn thing merged. Sorry to step on your toes. I'll do my best to make sure that the review comments are addressed. Mike I understand your position, but if this is the case then it should never have been submitted to the mailing list to begin with. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/devs/seoz
yay! thank you mike. Daniel Juyung Seo (SeoZ) On Thu, Nov 24, 2011 at 11:06 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: good news for seoz as well! Author: discomfitor Date: 2011-11-23 18:06:02 -0800 (Wed, 23 Nov 2011) New Revision: 65552 Trac: http://trac.enlightenment.org/e/changeset/65552 Modified: trunk/devs/seoz/TODO Modified: trunk/devs/seoz/TODO === --- trunk/devs/seoz/TODO 2011-11-24 02:03:16 UTC (rev 65551) +++ trunk/devs/seoz/TODO 2011-11-24 02:06:02 UTC (rev 65552) @@ -21,7 +21,6 @@ - Add performance test application. - Tooltip 'Big Icon Tooltip', 'Insanely Big Icon Tooltip' - discomfitor. - There is a bug with this pager where sometimes when you are using it, the widgets will all become unfocused and you cannot focus them again and then the pager is stuck open. - discomfitor. - - entry's select_all() function is broken or at least it is not working in that pager. - discomfitor. - Check elm_panel top and bottom orient. - discomfitor. - Add dnd for toolbar items. - discomfitor -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/devs/hermet
good news. but how... and when... was it fixed? Daniel Juyung Seo (SeoZ) On Thu, Nov 24, 2011 at 11:03 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: I guess this got fixed at some point Author: discomfitor Date: 2011-11-23 18:03:16 -0800 (Wed, 23 Nov 2011) New Revision: 65551 Trac: http://trac.enlightenment.org/e/changeset/65551 Modified: trunk/devs/hermet/TODO Modified: trunk/devs/hermet/TODO === --- trunk/devs/hermet/TODO 2011-11-24 01:06:45 UTC (rev 65550) +++ trunk/devs/hermet/TODO 2011-11-24 02:03:16 UTC (rev 65551) @@ -31,5 +31,3 @@ naviframe - need to block the style set while transiton is going on elementary - consider partmap and additional content_set/get/unset parts - -pager - mouseover problem -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/devs/hermet
On Thu, 24 Nov 2011 11:07:56 +0900 Daniel Juyung Seo seojuyu...@gmail.com wrote: good news. but how... and when... was it fixed? Daniel Juyung Seo (SeoZ) On Thu, Nov 24, 2011 at 11:03 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: I guess this got fixed at some point Author: discomfitor Date: 2011-11-23 18:03:16 -0800 (Wed, 23 Nov 2011) New Revision: 65551 Trac: http://trac.enlightenment.org/e/changeset/65551 Modified: trunk/devs/hermet/TODO a mystery that will surely go unsolved forever due to laziness -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: mike_m IN trunk/elementary: . data/objects data/themes data/themes/widgets src/bin src/lib
This is not right. GoUn Lee sent a patch to mailing list for the code review and this is not reviewed enough on the mailing list. And I don't think one year internal around means this code is correct and does not have to be reviewed enough even I know it works. Impatient mike! Anyhow, I disagree with this decision. Once this happens, we can't guarantee this will not happen again. And GoUn will lose her chance to be reviewed her code enough by open source e-developers. Daniel Juyung Seo (SeoZ) On Thu, Nov 24, 2011 at 10:42 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Thu, 24 Nov 2011 10:35:09 +0900 Mike McCormack mj.mccorm...@samsung.com wrote: On 11/24/2011 10:10 AM, Michael Blumenkrantz wrote: umm...unless I'm mistaken this was not given NEARLY enough time to be reviewed on the list. and as you are an author, you cannot self-review... Sorry to rush. My judgement is that this will go in one way or the other at some point. It has been around internally for one year, is in constant use, etc. It's not a prototype that somebody thought up yesterday and is suddenly pushing today. IMO, it should have been upstreamed and committed much sooner, so I'm a bit impatient to get the damn thing merged. Sorry to step on your toes. I'll do my best to make sure that the review comments are addressed. Mike I understand your position, but if this is the case then it should never have been submitted to the mailing list to begin with. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: mike_m IN trunk/elementary: . data/objects data/themes data/themes/widgets src/bin src/lib
On 11/24/2011 11:12 AM, Daniel Juyung Seo wrote: This is not right. GoUn Lee sent a patch to mailing list for the code review and this is not reviewed enough on the mailing list. And I don't think one year internal around means this code is correct and does not have to be reviewed enough even I know it works. Impatient mike! Anyhow, I disagree with this decision. Once this happens, we can't guarantee this will not happen again. And GoUn will lose her chance to be reviewed her code enough by open source e-developers. Goun is only the internal maintainer of this code, not the original author. It has be contributed to by many people internally, which I have tried to reflect in the commit message. Most code committed to EFL (say 90%) is not reviewed on the mailing list. Has code review suddenly become a priority? :-) thanks, Mike -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: mike_m IN trunk/elementary: . data/objects data/themes data/themes/widgets src/bin src/lib
On Thu, 24 Nov 2011 11:33:22 +0900 Mike McCormack mj.mccorm...@samsung.com wrote: On 11/24/2011 11:12 AM, Daniel Juyung Seo wrote: This is not right. GoUn Lee sent a patch to mailing list for the code review and this is not reviewed enough on the mailing list. And I don't think one year internal around means this code is correct and does not have to be reviewed enough even I know it works. Impatient mike! Anyhow, I disagree with this decision. Once this happens, we can't guarantee this will not happen again. And GoUn will lose her chance to be reviewed her code enough by open source e-developers. Goun is only the internal maintainer of this code, not the original author. It has be contributed to by many people internally, which I have tried to reflect in the commit message. Most code committed to EFL (say 90%) is not reviewed on the mailing list. Has code review suddenly become a priority? :-) thanks, Mike The point is that this was submitted for review and then committed after people spent time reading through the code without giving sufficient time for actual review. This wastes peoples' time and will likely demotivate future reviews. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: mike_m IN trunk/elementary: . data/objects data/themes data/themes/widgets src/bin src/lib
2011/11/24 Michael Blumenkrantz michael.blumenkra...@gmail.com: On Thu, 24 Nov 2011 11:33:22 +0900 Mike McCormack mj.mccorm...@samsung.com wrote: On 11/24/2011 11:12 AM, Daniel Juyung Seo wrote: This is not right. GoUn Lee sent a patch to mailing list for the code review and this is not reviewed enough on the mailing list. And I don't think one year internal around means this code is correct and does not have to be reviewed enough even I know it works. Impatient mike! Anyhow, I disagree with this decision. Once this happens, we can't guarantee this will not happen again. And GoUn will lose her chance to be reviewed her code enough by open source e-developers. Goun is only the internal maintainer of this code, not the original author. It has be contributed to by many people internally, which I have tried to reflect in the commit message. Most code committed to EFL (say 90%) is not reviewed on the mailing list. Has code review suddenly become a priority? :-) thanks, Mike The point is that this was submitted for review and then committed after people spent time reading through the code without giving sufficient time for actual review. This wastes peoples' time and will likely demotivate future reviews. And I would like to see the improvements in documentation I asked for. Code can and will be reviewed in svn, but letting crappy documentation in only adds to the work that should be done but no one wants to. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: mike_m IN trunk/elementary: . data/objects data/themes data/themes/widgets src/bin src/lib
On Thu, Nov 24, 2011 at 11:33 AM, Mike McCormack mj.mccorm...@samsung.com wrote: On 11/24/2011 11:12 AM, Daniel Juyung Seo wrote: This is not right. GoUn Lee sent a patch to mailing list for the code review and this is not reviewed enough on the mailing list. And I don't think one year internal around means this code is correct and does not have to be reviewed enough even I know it works. Impatient mike! Anyhow, I disagree with this decision. Once this happens, we can't guarantee this will not happen again. And GoUn will lose her chance to be reviewed her code enough by open source e-developers. Goun is only the internal maintainer of this code, not the original author. She has been maintained this code for about 10 months. And she changed a lot. Talking about the original author is meaningless anymore. She maintains it. It has be contributed to by many people internally, which I have tried to reflect in the commit message. Most code committed to EFL (say 90%) is not reviewed on the mailing list. Has code review suddenly become a priority? :-) Committed code without review was done by committer and the person has a responsibility for the code. The code for review on the mailing list has to be review enough. This is not a sudden issue. It was already there. DID YOU REVIEW THE CODE? thanks, Mike -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel Daniel Juyung Seo (SeoZ) -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: mike_m IN trunk/elementary: . data/objects data/themes data/themes/widgets src/bin src/lib
On Thu, 24 Nov 2011 02:41:42 + Iván Briano (Sachiel) sachi...@gmail.com wrote: 2011/11/24 Michael Blumenkrantz michael.blumenkra...@gmail.com: On Thu, 24 Nov 2011 11:33:22 +0900 Mike McCormack mj.mccorm...@samsung.com wrote: On 11/24/2011 11:12 AM, Daniel Juyung Seo wrote: This is not right. GoUn Lee sent a patch to mailing list for the code review and this is not reviewed enough on the mailing list. And I don't think one year internal around means this code is correct and does not have to be reviewed enough even I know it works. Impatient mike! Anyhow, I disagree with this decision. Once this happens, we can't guarantee this will not happen again. And GoUn will lose her chance to be reviewed her code enough by open source e-developers. Goun is only the internal maintainer of this code, not the original author. It has be contributed to by many people internally, which I have tried to reflect in the commit message. Most code committed to EFL (say 90%) is not reviewed on the mailing list. Has code review suddenly become a priority? :-) thanks, Mike The point is that this was submitted for review and then committed after people spent time reading through the code without giving sufficient time for actual review. This wastes peoples' time and will likely demotivate future reviews. And I would like to see the improvements in documentation I asked for. Code can and will be reviewed in svn, but letting crappy documentation in only adds to the work that should be done but no one wants to. I actually like documenting stuff. B-) But elementary is not my area, don't know enough about it. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Add new elementary widget 'Multibuttonentry'
Sorry for the wrong documentation. and I've attached patch file again that includes removed documentation in header file. I'll modify documentation more and send it later. Guidetext is to set the text literally.. If user set a guide text through elm_multibuttonentry_guide_text_set(), Guidetext shows up when Multibuttonentry which is not added button is unfocused. instead of showing entry to provide guide message. such as, if I set the guidetext as Tap to add recipient in Multibuttonentry, User could recognize how do I act to insert button in Multibuttonentry when it's unfocused. But, This function is optional, If user don't want, doesn't need to be necessarily. Please review it's APIs and fouctionalities again. I'd appreciate any comments on this. Thank you, Goun --- Original Message --- Sender : Iv?n Briano (Sachiel)sachi...@gmail.com Date : Nov 23, 2011 21:29 (GMT+09:00) Title : Re: [E-devel] [Patch] Add new elementary widget 'Multibuttonentry' 2011/11/23 GoUn Lee : Dear Developers, I added a new widget called “Multibuttonentry which could be used as contact button in App This widget allows a user to insert a text button. text button is inserted by pressing the Enter key If there is no space in the current row, the new button is entered in the next row. If the button is clicked, it will become focused. And focused button can be removed by pressing the backspace key. when items are added over 1 lines, if Multibuttonentry lost focus, it becase shrink mode (made it as 1 line) Please review it's APIs and functionalities. I didn't review the code and I don't have time for that now, but a quick look at the patch already tells me that documentation is poor. + /** +* Set the guide text +* +* @param obj The multibuttonentry object +* @param label The guide text string +* +* @ingroup Multibuttonentry +*/ + EAPI void elm_multibuttonentry_guide_text_set(Evas_Object *obj, const char *guidetext) EINA_ARG_NONNULL(1); I can see in the function name that this function sets the guide text. But what is the guide text? What does it do? Why do I want to set it? For new widgets, having clear documentation also helps with the review. It makes it clear what the intention of each function, and the whole widget, is, so that we can read the code and match it to that intention, finding possible problems in things that without knowing any better, would look just fine. Thank you, Goun -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel elc_multibuttonentry.patch.txt Description: Binary data -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Add new elementary widget 'Multibuttonentry'
On 11/24/2011 01:34 PM, GoUn Lee wrote: Sorry for the wrong documentation. and I've attached patch file again that includes removed documentation in header file. I'll modify documentation more and send it later. Please provide a patch against the current SVN that fixes the documentation, not removes it. thanks, Mike -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/edje/src/bin
On Thu, 24 Nov 2011 11:12:06 +0900 Jaehwan Kim jaehwan.kim@gmail.com said:
2011년 11월 24일 목요일에 Carsten Haitzler님이 작성:
On Wed, 23 Nov 2011 10:32:51 -0200 Iván Briano (Sachiel)
sachi...@gmail.com javascript:;
said:
2011/11/23 Enlightenment SVN no-re...@enlightenment.org javascript:;
:
Log:
aaah allow type to be set on group inherit or part inherit... you just
really shouldnt set it to a different type as its not very sensible.
Author: raster
Date: 2011-11-23 02:38:43 -0800 (Wed, 23 Nov 2011)
New Revision: 65534
Trac: http://trac.enlightenment.org/e/changeset/65534
Modified:
trunk/edje/src/bin/edje_cc_handlers.c
Modified: trunk/edje/src/bin/edje_cc_handlers.c
===
--- trunk/edje/src/bin/edje_cc_handlers.c 2011-11-23 08:49:47 UTC
(rev 65533) +++ trunk/edje/src/bin/edje_cc_handlers.c 2011-11-23
10:38:43 UTC (rev 65534) @@ -2965,13 +2965,6 @@
EXTERNAL, EDJE_PART_TYPE_EXTERNAL,
PROXY, EDJE_PART_TYPE_PROXY,
NULL);
-
- if (current_part-default_desc || current_part-other.desc_count
0)
- {
-ERR(%s: Error. parse error %s:%i. You can't change the part
type
in inherited group. (part: %s),
-progname, file_in, line - 1, current_part-name);
-exit(-1);
- }
}
Can't we check if the type doesn't match and give an error in that case?
we can... except this would break the intial type setting as the struct is
newly alloced with 0's all thru... and so u couldnt know the difference
between
initial set of type and a later change in type. :) we'd need to go add more
info/fllags and what not to know its been inherited etc.
It needs to remove old description and alloc new description,
because the part has different description structure as type.
I'm working for this job. I'll upload the patch.
yeah - so right now its just a bad idea to use a different type... it wont
complain at compile time..but it'll create edje files that are bad.
--
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] API break on ecore_fb_input
On Wed, 23 Nov 2011 15:32:14 -0200 Rafael Antognolli antogno...@profusion.mobi said: apply this patch i think. we do need to make sure we don't break api and as such this patch does fix that. Hello guys, Recently I sent this change to ecore_fb_input: http://trac.enlightenment.org/e/changeset/64447 It changes ecore_fb_input_device_open(const char *dev) to ecore_fb_input_device_open(void *window, const char *dev) Sorry, I didn't notice that this API was public at that time, but I also think that it isn't used outside of Ecore. Anyway, I would like to fix this break before the release. The options are either reverting this commit (and others related to it), or applying the attached patch, which would make that function have the previous signature, but introduces a new function: So, any objections that I apply this patch now? Or should I just revert it? -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Problem with list
On Wed, 23 Nov 2011 14:25:47 -0200 Guilherme Silveira xgu...@gmail.com said: Hi, I have some problem... I have a list, each item has a icon, but I would like that each icon was leaning (no spaces) with each other.. I made some changes in the theme to do that, but I found a problem. The function _fix_items (inside elm_list.c) always is called and follow code is executed: mw = mh = -1; elm_coords_finger_size_adjust(1, mw, 1, mh); edje_object_size_min_restricted_calc(VIEW(it), mw, mh, mw, mh); elm_coords_finger_size_adjust(1, mw, 1, mh); evas_object_size_hint_min_set(VIEW(it), mw, mh); evas_object_show(VIEW(it)); The efl always change my size_hint_mim to the value bigger than my icon size, so spaces will add between icons... How can I fix this!? elm is enforcing policy - that is all elements to be clicked by a user are at LEAST a finger in size.. so they are hittable. it stays at a bigger size because this policy is being enforces to keep usability for users. if you are making a desktop app (mouse+kbd driven) you really want to be using a desktop config setup - look at elementary_config - there is a standard profile. this also drops finger size to something like 5 which is appropriate there. Regards, -- Guilherme Silveira E-mail: xgu...@gmail.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Problem with list
yeah we can set finger size as well. and.. genlist has a display only mode which means items do not need to consider finger_size. once you use genlist and call elm_genlist_item_display_only_mode_set(), you can achieve your goal. but list does not have this feature because elm_list is supposed to have the items with the same layouts. if this policy is changed, i will consider adding display_only feature to list. how do you think others? Daniel Juyung Seo (SeoZ) On Thu, Nov 24, 2011 at 4:32 PM, Carsten Haitzler ras...@rasterman.com wrote: On Wed, 23 Nov 2011 14:25:47 -0200 Guilherme Silveira xgu...@gmail.com said: Hi, I have some problem... I have a list, each item has a icon, but I would like that each icon was leaning (no spaces) with each other.. I made some changes in the theme to do that, but I found a problem. The function _fix_items (inside elm_list.c) always is called and follow code is executed: mw = mh = -1; elm_coords_finger_size_adjust(1, mw, 1, mh); edje_object_size_min_restricted_calc(VIEW(it), mw, mh, mw, mh); elm_coords_finger_size_adjust(1, mw, 1, mh); evas_object_size_hint_min_set(VIEW(it), mw, mh); evas_object_show(VIEW(it)); The efl always change my size_hint_mim to the value bigger than my icon size, so spaces will add between icons... How can I fix this!? elm is enforcing policy - that is all elements to be clicked by a user are at LEAST a finger in size.. so they are hittable. it stays at a bigger size because this policy is being enforces to keep usability for users. if you are making a desktop app (mouse+kbd driven) you really want to be using a desktop config setup - look at elementary_config - there is a standard profile. this also drops finger size to something like 5 which is appropriate there. Regards, -- Guilherme Silveira E-mail: xgu...@gmail.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler) ras...@rasterman.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
