Re: [Flightgear-devel] Autopilot changes
On 2 Oct 2009, at 01:14, Jacob Burbach wrote: I must be losing my mind then, I had both Ki and Kd in pid-controller without errors previously, and changing the values certainly had an effect. The values haven't had any affect, before or after my change. I haven't checked the full history. If, in the past, those values had an effect, we need to define which version / revision of xmlauto.cxx you're talking about more specifically! See here: http://cvs.flightgear.org/viewvc/source/src/Autopilot/xmlauto.cxx?view=log#rev1.43 I do notice from the log, that it was Torsten's change of March this year that introduced the false positive warnings, prior to that I guess the warnings were 'correct', though at log-level INFO, and therefore invisible to most people. At least as early as revision 1.36 (February this year) there is no support for Ki or Kd. Going back to revision 1.28 (February 2008!) there is again no support... I wouldn't like to say you are losing your mind, but maybe this parameters worked in FG 1.0? (I have no idea about that...) On another note, theres a bug in FGAutoBrake::postInit. It's using _weightOnWheelsNode without checking if it is actually a valid pointer. With atc aircraft it's null, and causes a segfault. Ack, thought I'd caught all of those, thanks. James -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] Autopilot changes
In recent cvs I get errors about having Ki or Kd in my pid controllers config. This is unfortunate, as tuning of those values stabilized my autopilot considerably. I wonder if someone can explain what changes are going on in that area of code. Are Ki and Kd forever gone, and what path should I take for tuning autopilot to work in new/modified system? cheers! -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Autopilot changes
On 1 Oct 2009, at 17:54, Jacob Burbach wrote: In recent cvs I get errors about having Ki or Kd in my pid controllers config. This is unfortunate, as tuning of those values stabilized my autopilot considerably. I wonder if someone can explain what changes are going on in that area of code. Are Ki and Kd forever gone, and what path should I take for tuning autopilot to work in new/modified system? I made some changes to this code, to remove spurious warnings (previously the code warning about every property ...) I tested the code and it seems to work okay for me - so maybe your problem is unrelated, or maybe not. Can you provide the errors you see, and the relevant autopilot XML file, please? Regards, James -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Autopilot changes
Will get error such as malformed autopilot definition - unrecognized config node:Ki in section Heading Bug Hold Failed to load autopilot configuration: /path/to/autopilot.xml:XMLAuto: unrecognized config node:Ki Removing Ki, it will then complain about Kd. Can remove Ki and Kd and it will work, but obviously the autopilot won't work so well anymore. Looking in xmlauto.cxx I can see Ki is available in a pi-simple-controller, but Kd seems to be gone completely. So for now I guess I'm stuck, all I can do is remove all references to Ki and Kd, and deal with an unstable/inaccurate autopilot. Is the autopilot stuff undergoing some major changes, did I catch it in a bad state? Where did Ki and Kd go? cheers -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Autopilot changes
Jacob Burbach wrote: In recent cvs I get errors about having Ki or Kd in my pid controllers config. This is unfortunate, as tuning of those values stabilized my autopilot considerably. I wonder if someone can explain what changes are going on in that area of code. Are Ki and Kd forever gone, and what path should I take for tuning autopilot to work in new/modified system? cheers! -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel I also get this odd error. The AP is unusable without it here. This is the error I get: Failed to load autopilot configuration: /home/michael/root/FGData/Aircraft/f-14b/f-14b-AFCS.xml:XMLAuto: unrecognized config node:Ki -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Autopilot changes
On 1 Oct 2009, at 22:41, Michael Smith wrote: This is the error I get: Failed to load autopilot configuration: /home/michael/root/FGData/Aircraft/f-14b/f-14b-AFCS.xml:XMLAuto: unrecognized config node:Ki There seems to be some confusion here. My changes do *not* change the functional behaviour of the autopilot at all - I have no explanation for any differences in behaviour. All I've done is fix the XML parsing code to *correctly* report about properties that are ignored. Specifically, PID controllers do NOT (before or after my commit) read Ki or Kd properties. Prior to my commit, the warning about those properties would have been lost in warnings about all the other, genuine properties. After my commit, only the genuine warnings show up. Because these are real problems, I 'promoted' the warning from SG_INFO to SG_ALERT, in the hope that authors would see the warnings and fix their XML files. (Note all this is assuming I didn't screw up and subtly break the code somehow - but if I did, it's very subtle, or no autopilot would work at all - and the ones I've tried (B1900, Aerostar, 777) are working as before for me. I'm happy to look at an autopilot XML file and comment on the validity of it, with respect to the parsing code. I hope that helps. Regards, James -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Autopilot changes
On Thu, Oct 1, 2009 at 6:54 PM, Jacob Burbach jmburb...@gmail.com wrote: In recent cvs I get errors about having Ki or Kd in my pid controllers config. This is unfortunate, as tuning of those values stabilized my autopilot considerably. I wonder if someone can explain what changes are going on in that area of code. Are Ki and Kd forever gone, and what path should I take for tuning autopilot to work in new/modified system? As far as I can tell, Kd never existed. Ki only exists (and continues to work) in pi-simple-controller while the pid-controller uses Kp for all coefficients. -- Csaba/Jester -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Autopilot changes
I must be losing my mind then, I had both Ki and Kd in pid-controller without errors previously, and changing the values certainly had an effect. On another note, theres a bug in FGAutoBrake::postInit. It's using _weightOnWheelsNode without checking if it is actually a valid pointer. With atc aircraft it's null, and causes a segfault. cheers -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
