vmware2 build fails on -current today

2001-11-20 Thread CHOI Junho


Hi,

Due to recent change on pmap.[ch], vmware2 build fails... Can somebody
fix this?

I am using -current built yesterday(11/19).

-- 
 +++ Any opinions in this posting are my own and not those of my employers +++
 CHOI Junho [sleeping now]http://www.kr.FreeBSD.org/~cjh
 [while sleeping] cjh @ kr.FreeBSD.ORG cjh @ FreeBSD.ORG cjh @ wdb.co.kr
 Korea FreeBSD Users Group www.kr.FreeBSD.org   Web Data Bankwww.wdb.co.kr


===  Cleaning for rpm-3.0.6_5
===  Cleaning for autoconf213-2.13.000227
===  Cleaning for automake14-1.4.5
===  Cleaning for gettext-0.10.35
===  Cleaning for gmake-3.79.1
===  Cleaning for imake-4.1.0
===  Cleaning for libtool-1.3.4_2
===  Cleaning for m4-1.4_1
===  Cleaning for popt-1.5.1
===  Cleaning for linux_base-6.1
===  Cleaning for rtc-2001.09.16.1
===  Cleaning for freetype2-2.0.5
===  Cleaning for XFree86-libraries-4.1.0
===  Cleaning for vmware2-2.0.4.1142
===  Extracting for vmware2-2.0.4.1142
 Checksum OK for VMware-2.0.4-1142.tar.gz.
 Checksum OK for vmmon-freebsd-0.98.tar.gz.
 Checksum OK for vmnet-freebsd-0.21.tar.gz.
===   vmware2-2.0.4.1142 depends on shared library: X11.6 - found
/usr/bin/tar -xf 
/usr/ports/emulators/vmware2/work/vmware-distrib/lib/modules/source/vmmon.tar -C 
/usr/ports/emulators/vmware2/work/vmware-distrib
/usr/bin/tar -xf 
/usr/ports/emulators/vmware2/work/vmware-distrib/lib/modules/source/vmnet.tar -C 
/usr/ports/emulators/vmware2/work/vmware-distrib
/usr/bin/gunzip -f 
/usr/ports/emulators/vmware2/work/vmware-distrib/man/man1/vmware.1.gz
===  Patching for vmware2-2.0.4.1142
/usr/bin/perl -i -ne 'if (m{^Index: vmnet-only/userif\.c$}..m{^Index: 
vmnet-only/vm_oui\.h$}) { next unless m{^Index: vmnet-only/vm_oui\.h$} } print' 
/usr/ports/emulators/vmware2/work/vmnet-freebsd.diff
/bin/cp -R /usr/ports/emulators/vmware2/work/vmmon-only 
/usr/ports/emulators/vmware2/work/vmware-distrib/
/usr/bin/patch -d /usr/ports/emulators/vmware2/work/vmware-distrib --forward --quiet 
-E -p0  /usr/ports/emulators/vmware2/work/vmmon-freebsd.diff
/bin/cp -R /usr/ports/emulators/vmware2/work/vmnet-only 
/usr/ports/emulators/vmware2/work/vmware-distrib/
/usr/bin/patch -d /usr/ports/emulators/vmware2/work/vmware-distrib --forward --quiet 
-E -p0  /usr/ports/emulators/vmware2/work/vmnet-freebsd.diff
===  Applying FreeBSD patches for vmware2-2.0.4.1142
cat /usr/ports/emulators/vmware2/files/kse.patch | (cd 
/usr/ports/emulators/vmware2/work/vmware-distrib  patch)  /dev/null 21
/bin/cp /usr/ports/emulators/vmware2/files/Makefile 
/usr/ports/emulators/vmware2/work/vmware-distrib
/bin/cp /usr/ports/emulators/vmware2/files/Makefile.vmmon 
/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/Makefile
/bin/rm -rf /usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/linux/
/usr/bin/perl -i -pe 's,i386(/linux/linux_ioctl\.h),compat$1,'  
/usr/ports/emulators/vmware2/work/vmware-distrib/vmnet-only/freebsd/vmnet_linux.c
/usr/bin/perl -i -pe 's,sys/select\.h,sys/selinfo.h,'  
/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/freebsd/*.c
cd /usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/freebsd  
/usr/bin/touch bus_if.h device_if.h
/usr/bin/perl -i -pe 's,machine/ioctl_fd\.h,sys/fdcio.h,'  
/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/freebsd/*.c  
/usr/ports/emulators/vmware2/work/vmware-distrib/vmware-distrib/vmmon-only/freebsd/*.c
Can't open 
/usr/ports/emulators/vmware2/work/vmware-distrib/vmware-distrib/vmmon-only/freebsd/*.c:
 No such file or directory,  line 2872.
===  Configuring for vmware2-2.0.4.1142
=== vmmon-only
make -f Makefile.FreeBSD SMP=YES clean  make -f Makefile.FreeBSD SMP=YES
rm -f setdef0.c setdef1.c setdefs.h setdef0.o setdef1.o vmmon_smp.ko vmmon_smp.ko 
vmmon_smp.kld memtrack.o phystrack.o task.o vmx86.o driver.o hostif.o linux_emu.o 
vmnet_linux.o @ machine symb.tmp tmp.o
Warning: Object directory not changed from original 
/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only
@ - /usr/src/sys
machine - /usr/src/sys/i386/include
cc -O -pipe -march=pentiumpro -march=pentiumpro 
-I/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/include 
-I/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/common 
-I/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/freebsd 
-I/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/export/include -I/sys 
-I/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/../vmnet-only/freebsd/ 
-DCDEV_MAJOR_=200 -DSMP -DAPIC_IO  -D_KERNEL -Wall -Wredundant-decls -Wnested-externs 
-Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  
-fformat-extensions -ansi -DKLD_MODULE -nostdinc -I-  
-I/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/include 
-I/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/common 
-I/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/freebsd 
-I/usr/ports/emulators/vmware2/work/vmware-distrib/vmmon-only/export/include -I/sys 

Re: building cvsup from ports

2001-11-20 Thread Mark Murray

 There is already a patch in PR ports/30899.  It is OK to commit it
 IF you can test it first on a FreeBSD 4.x system (any architecture)
 and also a -current Alpha system.

Cool! Thank you!

M

 
 John
 
 Mark Murray wrote:
  John
  
  I have a patch (courtesy of Brian Somers) that fixes M3. I believe
  he has submitted it to you.
  
  May I/We commit it?
  
  M
  
  Hello all,
 Sounds like a silly place to post this but...here goes.  I'm getting errors
  compiling cvsup from ports.  The ports tree installed is the default coming
  with the 11/12/01 snapshot.  I want would use CVS, but I don't know how (and
  yet I call my self a computer science student).  It complains about nfs/nfs.h
  not existing (I checked, it doesn't).  This is the first thing I have built
  from ports except X in -current, so all of the dependencies besides X were
  built with this port during make install.  I remeber seeing this post on
  stable a while ago, but can't find the message for the life or me.  The error
  is appended for amusment to those individuals who understand such things.
  
  regards,
  Galen Sampson
  
  # cd /usr/ports/net/cvsup
  # make install
  To build this port without X11 (and without the GUI), define WITHOUT_X11.
  ===  Extracting for cvsup-16.1e
   Checksum OK for cvsup-snap-16.1e.tar.gz.
  ===   cvsup-16.1e depends on file:
  /usr/local/lib/m3/FreeBSD4/libm3formsvbt.so.7 - not found
  ===Verifying install for /usr/local/lib/m3/FreeBSD4/libm3formsvbt.so.7 in
  /usr/ports/lang/pm3-forms
  ===  Extracting for pm3-forms-1.1.15
   No MD5 checksum file.
  ===   pm3-forms-1.1.15 depends on file:
  /usr/local/lib/m3/FreeBSD4/libm3vbtkit.so.7 - not found
  ===Verifying install for /usr/local/lib/m3/FreeBSD4/libm3vbtkit.so.7 in
  /usr/ports/lang/pm3-gui
  ===  Extracting for pm3-gui-1.1.15
   No MD5 checksum file.
  ===   pm3-gui-1.1.15 depends on file: /usr/local/lib/m3/FreeBSD4/libm3tcp.so.7
  - not found
  ===Verifying install for /usr/local/lib/m3/FreeBSD4/libm3tcp.so.7 in
 /usr/ports/lang/pm3-net
  ===  Extracting for pm3-net-1.1.15
   No MD5 checksum file.
  ===   pm3-net-1.1.15 depends on file: /usr/local/lib/m3/FreeBSD4/libm3.so.7 -
  not found
  ===Verifying install for /usr/local/lib/m3/FreeBSD4/libm3.so.7 in
  /usr/ports/lang/pm3-base
  ===  Installing for pm3-base-1.1.15
  cd boot-FreeBSD4/m3core/FreeBSD4; gmake -f make.boot CC=cc CFLAGS=-O -pipe 
  AS=as ASFLAGS= AR=ar ARFLAGS=rv RANLIB=touch EXTRALIBS=-lm
  LDFLAGS=
  gmake[1]: Entering directory
  `/usr/ports/lang/pm3-base/work/pm3-1.1.15/boot-FreeBSD4/m3core/FreeBSD4'
  cc -O -pipe-c -o RTHeapDepC.o RTHeapDepC.c
  RTHeapDepC.c:101: nfs/nfs.h: No such file or directory
  RTHeapDepC.c: In function `mount':
  RTHeapDepC.c:719: dereferencing pointer to incomplete type
  RTHeapDepC.c:719: dereferencing pointer to incomplete type
  RTHeapDepC.c:720: dereferencing pointer to incomplete type
  RTHeapDepC.c:720: dereferencing pointer to incomplete type
  RTHeapDepC.c:721: dereferencing pointer to incomplete type
  RTHeapDepC.c:721: dereferencing pointer to incomplete type
  gmake[1]: *** [RTHeapDepC.o] Error 1
  gmake[1]: Leaving directory
  `/usr/ports/lang/pm3-base/work/pm3-1.1.15/boot-FreeBSD4/m3core/FreeBSD4'
  gmake: *** [boot] Error 2
  *** Error code 2
  
  Stop in /usr/ports/lang/pm3-base.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-base.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-base.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-net.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-net.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-net.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-net.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-net.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-net.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-net.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-gui.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-gui.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-gui.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-gui.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-gui.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-gui.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-gui.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-forms.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-forms.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-forms.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-forms.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-forms.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-forms.
  *** Error code 1
  
  Stop in /usr/ports/lang/pm3-forms.
  *** Error code 1
  
  Stop in /usr/ports/net/cvsup.
  *** Error code 1
  
  Stop in /usr/ports/net/cvsup.
  *** Error code 1
  
  Stop in /usr/ports/net/cvsup.
  *** Error code 1
  
  Stop in /usr/ports/net/cvsup.
  *** Error code 1
  
  Stop in /usr/ports/net/cvsup.
  *** Error code 1
  
  Stop in /usr/ports/net/cvsup.
  *** Error 

Re: misc/15421 (was: Re: initgroups)

2001-11-20 Thread Ruslan Ermilov

On Mon, Nov 19, 2001 at 10:28:55PM +0600, Max Khon wrote:
 hi, there!
 
 On Mon, Nov 19, 2001 at 06:19:50PM +0200, Ruslan Ermilov wrote:
 
   Can setgroups return a positive number?  If so, you've just changed
   the semantics of the funtion; before, it used to return 0 on 0 or a
   positive number.
   
  No.  setgroups() is a syscall, and as such returns either 0 or -1.
  
   Also, is removing the _warn() really the only thing you want to
   accomplish?  It should probably be seperate.
   
  I have intended to commit the below patch for almost a year now,
  just haven't had enough time to actually fo it.  NetBSD runs with
  this fix since 1999.
  
  Index: initgroups.c
  ===
  RCS file: /home/ncvs/src/lib/libc/gen/initgroups.c,v
  retrieving revision 1.4
  diff -u -p -r1.4 initgroups.c
  --- initgroups.c2001/08/29 13:52:26 1.4
  +++ initgroups.c2001/11/19 16:16:11
  @@ -56,12 +56,6 @@ initgroups(uname, agroup)
  int groups[NGROUPS], ngroups;
   
  ngroups = NGROUPS;
  -   if (getgrouplist(uname, agroup, groups, ngroups)  0)
  -   warnx(%s is in too many groups, using first %d,
  -   uname, ngroups);
  -   if (setgroups(ngroups, groups)  0) {
  -   _warn(setgroups);
  -   return (-1);
  -   }
  -   return (0);
  +   getgrouplist(uname, agroup, groups, ngroups);
  +   return (setgroups(ngroups, groups);

There's a missing closing parenthesis above, sorry.

  Index: initgroups.3
[...]

 I asked tobez (he is an originator and he took responsibility on this PR)
 and he said that src/ must be audited also -- he said that some initgroups()
 callers do not print error message because initgroups() did this
 previously.
 
 I'll try to do this before this weekend and I will post combined patch
 to audit@
 
While this is indeed a good thing to do, this is completely unrelated to
the above mentioned problem, and should be done separately.  Here's the
list of src/ files that do not check the return value of initgroups(3),
and may need to be fixed, but some of them explicitly ignore the result
to indicate the fact they consider this error non-fatal.

libexec/ftpd/ftpd.c
libexec/rexecd/rexecd.c
usr.bin/calendar/calendar.c
usr.sbin/inetd/inetd.c


Cheers,
-- 
Ruslan Ermilov  Oracle Developer/DBA,
[EMAIL PROTECTED]   Sunbay Software AG,
[EMAIL PROTECTED]  FreeBSD committer,
+380.652.512.251Simferopol, Ukraine

http://www.FreeBSD.org  The Power To Serve
http://www.oracle.com   Enabling The Information Age

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: misc/15421 (was: Re: initgroups)

2001-11-20 Thread Anton Berezin

On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote:
 On Mon, Nov 19, 2001 at 10:28:55PM +0600, Max Khon wrote:

  I asked tobez (he is an originator and he took responsibility on
  this PR) and he said that src/ must be audited also -- he said that
  some initgroups() callers do not print error message because
  initgroups() did this previously.
  
  I'll try to do this before this weekend and I will post combined
  patch to audit@

 While this is indeed a good thing to do, this is completely unrelated to
 the above mentioned problem, and should be done separately.  Here's the
 list of src/ files that do not check the return value of initgroups(3),
 and may need to be fixed, but some of them explicitly ignore the result
 to indicate the fact they consider this error non-fatal.

 libexec/ftpd/ftpd.c
 libexec/rexecd/rexecd.c
 usr.bin/calendar/calendar.c
 usr.sbin/inetd/inetd.c

There used to be *many* more problematic files.  Please see

http://www.freebsd.org/cgi/getmsg.cgi?fetch=801566+0+/usr/local/www/db/text/2001/freebsd-stable/20010722.freebsd-stable

To my knowledge, only printjob.c was fixed, though I have not looked
into every file in the list since then.

But as I said in the private message, I do not feel strongly about this,
and I think that the fix can be safely committed.  I do not think these
things are quite unrelated, though.  :-)

Cheers,
\Anton.
-- 
| Anton Berezin|  FreeBSD: The power to serve |
| catpipe Systems ApS   _ _ |_ |   http://www.FreeBSD.org |
| [EMAIL PROTECTED](_(_||  |[EMAIL PROTECTED] | 
| +45 7021 0050| Private: [EMAIL PROTECTED] |

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: misc/15421 (was: Re: initgroups)

2001-11-20 Thread Ruslan Ermilov

On Tue, Nov 20, 2001 at 03:12:50PM +0100, Anton Berezin wrote:
 On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote:
  On Mon, Nov 19, 2001 at 10:28:55PM +0600, Max Khon wrote:
 
   I asked tobez (he is an originator and he took responsibility on
   this PR) and he said that src/ must be audited also -- he said that
   some initgroups() callers do not print error message because
   initgroups() did this previously.
   
   I'll try to do this before this weekend and I will post combined
   patch to audit@
 
  While this is indeed a good thing to do, this is completely unrelated to
  the above mentioned problem, and should be done separately.  Here's the
  list of src/ files that do not check the return value of initgroups(3),
  and may need to be fixed, but some of them explicitly ignore the result
  to indicate the fact they consider this error non-fatal.
 
  libexec/ftpd/ftpd.c
  libexec/rexecd/rexecd.c
  usr.bin/calendar/calendar.c
  usr.sbin/inetd/inetd.c
 
 There used to be *many* more problematic files.  Please see
 
 
http://www.freebsd.org/cgi/getmsg.cgi?fetch=801566+0+/usr/local/www/db/text/2001/freebsd-stable/20010722.freebsd-stable
 
 To my knowledge, only printjob.c was fixed, though I have not looked
 into every file in the list since then.
 
Yes, but I specifically left contrib/ and crypto/ files, and files that
do not check the result of other calls like setgrp() etc.

 But as I said in the private message, I do not feel strongly about this,
 and I think that the fix can be safely committed.  I do not think these
 things are quite unrelated, though.  :-)
 
Not checking the return value is always BAD except when (not) done
intentionally (flagged by a(void)ing the return value of a function),
whether or not a function in question prints some diagnostic output
on standard error; that's why I still think these problems are in
fact unrelated.  :-)


Cheers,
-- 
Ruslan Ermilov  Oracle Developer/DBA,
[EMAIL PROTECTED]   Sunbay Software AG,
[EMAIL PROTECTED]  FreeBSD committer,
+380.652.512.251Simferopol, Ukraine

http://www.FreeBSD.org  The Power To Serve
http://www.oracle.com   Enabling The Information Age

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: misc/15421 (was: Re: initgroups)

2001-11-20 Thread Anton Berezin

On Tue, Nov 20, 2001 at 04:27:03PM +0200, Ruslan Ermilov wrote:
 On Tue, Nov 20, 2001 at 03:12:50PM +0100, Anton Berezin wrote:
  On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote:

   While this is indeed a good thing to do, this is completely
   unrelated to the above mentioned problem, and should be done
   separately.  Here's the list of src/ files that do not check the
   return value of initgroups(3), and may need to be fixed, but some
   of them explicitly ignore the result to indicate the fact they
   consider this error non-fatal.

   libexec/ftpd/ftpd.c
   libexec/rexecd/rexecd.c
   usr.bin/calendar/calendar.c
   usr.sbin/inetd/inetd.c
  
  There used to be *many* more problematic files.  Please see
  
  
http://www.freebsd.org/cgi/getmsg.cgi?fetch=801566+0+/usr/local/www/db/text/2001/freebsd-stable/20010722.freebsd-stable
  
  To my knowledge, only printjob.c was fixed, though I have not looked
  into every file in the list since then.

 Yes, but I specifically left contrib/ and crypto/ files, and files that
 do not check the result of other calls like setgrp() etc.

We do not want to omit contrib/ files, since the whole hoopla started
because of the contrib/cvs/.

  But as I said in the private message, I do not feel strongly about
  this, and I think that the fix can be safely committed.  I do not
  think these things are quite unrelated, though.  :-)

 Not checking the return value is always BAD except when (not) done
 intentionally (flagged by a(void)ing the return value of a function),
 whether or not a function in question prints some diagnostic output on
 standard error; that's why I still think these problems are in fact
 unrelated.  :-)

In this case your own version of the fix should be modified from

+   getgrouplist(uname, agroup, groups, ngroups);
+   return (setgroups(ngroups, groups);

to

+   (void) getgrouplist(uname, agroup, groups, ngroups);
+   return (setgroups(ngroups, groups);

, to be pedantic. :-)

The point I am trying to (not very strongly) make is that we at least
have some indication that there is a problem with the current behavior
(with the exception of the daemons with closed/redirected to /dev/null
stderr).  By (rightfully) fixing initgroups(), we loose even this
precious little diagnostic we have.  That's why initgroups() fix and the
code audit are probably best done at the same time - unless we can
guarantee the audit part will not be forgotten.

Cheers,
$Anton.
-- 
| Anton Berezin|  FreeBSD: The power to serve |
| catpipe Systems ApS   _ _ |_ |   http://www.FreeBSD.org |
| [EMAIL PROTECTED](_(_||  |[EMAIL PROTECTED] | 
| +45 7021 0050| Private: [EMAIL PROTECTED] |

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: vmware2 build fails on -current today

2001-11-20 Thread Munehiro Matsuda

From: CHOI Junho [EMAIL PROTECTED]
Date: 20 Nov 2001 17:49:47 +0900
::
::Hi,
::
::Due to recent change on pmap.[ch], vmware2 build fails... Can somebody
::fix this?
::
::I am using -current built yesterday(11/19).

I don't have patch for it, but you could changed the line in hostif.c,
from:
  pt_entry_t pteptr = (pt_entry_t)vtopte(addr);

to:
  pt_entry_t *pteptr = vtopte(addr);

to get it compile.

Hope this helps,
  Haro
=--
   _ _Munehiro (haro) Matsuda
 -|- /_\  |_|_|   Business Incubation Dept., Kubota Corp.
 /|\ |_|  |_|_|   1-3 Nihonbashi-Muromachi 3-Chome
  Chuo-ku Tokyo 103-8310, Japan
  Tel: +81-3-3245-3318  Fax: +81-3-3245-3315
  Email: [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: misc/15421 (was: Re: initgroups)

2001-11-20 Thread Ruslan Ermilov

On Tue, Nov 20, 2001 at 03:43:52PM +0100, Anton Berezin wrote:
 On Tue, Nov 20, 2001 at 04:27:03PM +0200, Ruslan Ermilov wrote:
  On Tue, Nov 20, 2001 at 03:12:50PM +0100, Anton Berezin wrote:
   On Tue, Nov 20, 2001 at 03:02:39PM +0200, Ruslan Ermilov wrote:
 
While this is indeed a good thing to do, this is completely
unrelated to the above mentioned problem, and should be done
separately.  Here's the list of src/ files that do not check the
return value of initgroups(3), and may need to be fixed, but some
of them explicitly ignore the result to indicate the fact they
consider this error non-fatal.
 
libexec/ftpd/ftpd.c
libexec/rexecd/rexecd.c
usr.bin/calendar/calendar.c
usr.sbin/inetd/inetd.c
   
   There used to be *many* more problematic files.  Please see
   
   
http://www.freebsd.org/cgi/getmsg.cgi?fetch=801566+0+/usr/local/www/db/text/2001/freebsd-stable/20010722.freebsd-stable
   
   To my knowledge, only printjob.c was fixed, though I have not looked
   into every file in the list since then.
 
  Yes, but I specifically left contrib/ and crypto/ files, and files that
  do not check the result of other calls like setgrp() etc.
 
 We do not want to omit contrib/ files, since the whole hoopla started
 because of the contrib/cvs/.
 
   But as I said in the private message, I do not feel strongly about
   this, and I think that the fix can be safely committed.  I do not
   think these things are quite unrelated, though.  :-)
 
  Not checking the return value is always BAD except when (not) done
  intentionally (flagged by a(void)ing the return value of a function),
  whether or not a function in question prints some diagnostic output on
  standard error; that's why I still think these problems are in fact
  unrelated.  :-)
 
 In this case your own version of the fix should be modified from
 
 +   getgrouplist(uname, agroup, groups, ngroups);
 +   return (setgroups(ngroups, groups);
 
 to
 
 +   (void) getgrouplist(uname, agroup, groups, ngroups);
 +   return (setgroups(ngroups, groups);
 
 , to be pedantic. :-)
 
Not actually, because getgrouplist(3) is special in that -1 is not
actually an error, but an indication that the resulting array was
too small to hold all groups.  :-)

 The point I am trying to (not very strongly) make is that we at least
 have some indication that there is a problem with the current behavior
 (with the exception of the daemons with closed/redirected to /dev/null
 stderr).  By (rightfully) fixing initgroups(), we loose even this
 precious little diagnostic we have.  That's why initgroups() fix and the
 code audit are probably best done at the same time - unless we can
 guarantee the audit part will not be forgotten.
 
Sure, you can just change the synopsis of your PR.  :-)


Cheers,
-- 
Ruslan Ermilov  Oracle Developer/DBA,
[EMAIL PROTECTED]   Sunbay Software AG,
[EMAIL PROTECTED]  FreeBSD committer,
+380.652.512.251Simferopol, Ukraine

http://www.FreeBSD.org  The Power To Serve
http://www.oracle.com   Enabling The Information Age

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



RE: Sysinstall is still horribly broken.

2001-11-20 Thread Makoto Matsushita


jhb Err, well, when we run fsck on an existing partition, we
jhb shouldn't say 'fsck /dev/ad0s1a', we should use 'fsck_ffs
jhb /dev/ad0s1a'.  Does that make sense now?  We shouldn't be calling
jhb fsck_4.2bsd for these filesystems because they aren't 4.2BSD file
jhb systems per se, they are FFS, possibly with softupdates.

That's make sence to me.  We only run fsck to FFS, so it's safe to
change 'fsck' to 'fsck_ffs'.

jhb With devfs /dev should have all existing disks and partitions.
jhb At least if you open the device it will create it for you if it
jhb is valid.  We should always use the devfs /dev if it is present
jhb and fall back to /mnt/dev from the CD if it is not.

Maybe we can try to put mount_devfs and mount devfs to /mnt/dev.

-- -
Makoto `MAR' Matsushita

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



RE: Sysinstall is still horribly broken.

2001-11-20 Thread Makoto Matsushita


matusita Maybe we can try to put mount_devfs and mount devfs to /mnt/dev.

Moreover, sysinstall requires devfs on /mnt/dev only if trying to
mount filesystems.  I've made a patch to do that (and more), and test
now (yes, *right now*).

If it seems fine for me, I'll post a patch.  Current my patch
includes:

- Use fsck_ffs instead of fsck.  As a result, we don't need 'fsck'
  program anymore, and we don't need 'fsck_4.2bsd' or other links to fsck_ffs.
- Use devfs for /mnt/dev (if sysinstall runs as init).  sysinstall
  mounts it, then runs fsck/newfs  mounts filesystems.  All goes
  well, umount devfs on /mnt/dev (if mounted).

-- -
Makoto `MAR' Matsushita

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: vmware fails on -current

2001-11-20 Thread Hellmuth Michaelis

From the keyboard of Georg-W. Koltermann:
 At Sun, 18 Nov 2001 09:37:12 +0100 (MET),
 Hellmuth Michaelis wrote:
  
  Thought i update my current this morning and ran into two problem with
  vmware:
  
  1) when starting vmware, vmware.sh aborts with
  
 vmware.sh: cannot create /compat/linux/dev/vmnet1: no such device
 or address
 
 Hi Hellmuth,
 
 that can be fixed with using /dev/vmnet1 instead of the /compat device
 in /usr/local/etc/rc.d/vmware.sh.  I needed this change since about
 two months now, IIRC.

Today i got it to compile and run:

- apply the patch from Munehiro Matsuda to hostif.c, this makes the vmware2
  port compile under -current as of today

- as described above, use /dev/vmnet1 instead of /compat/linux/dev/vmnet1
  in /usr/local/etc/rc.d/vmware.sh

- replace /compat/linux/dev/vmnet1 with a symlink to /dev/vmnet1
  (perhaps the previous step would be unnecessary by this one)

After this, vmware comes up and then complains about not able to use
/dev/rtc (/dev/rtc is present in /compat/linux and is kld-loaded) but
then continues to start up and runs.

One thing which looks funny to me is this that the vmnet1 device files
have different minor numbers:

ROOT@bert/root ll /usr/compat/linux/dev/vmnet1-BAK /dev/vmnet1
crw---  1 root  wheel  149, 0x0081 Nov 20 18:50 /dev/vmnet1
crw-rw-rw-  1 root  wheel  149, 0x00010001 Nov 20 18:42 
/usr/compat/linux/dev/vmnet1-BAK

(where /usr/compat/linux/dev/vmnet1-BAK is from the vmware2 port install
 and moved from vmnet1 to vmnet1-BAK before the new symlink was made).

hellmuth
-- 
Hellmuth MichaelisTel   +49 40 55 97 47-70
HCS Hanseatischer Computerservice GmbHFax   +49 40 55 97 47-77
Oldesloer Strasse 97-99   Mail  hm [at] hcs.de
D-22457 Hamburg   WWW   http://www.hcs.de

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: vmware fails on -current

2001-11-20 Thread Vladimir B. Grebenschikov

Hellmuth Michaelis writes:

  Today i got it to compile and run:
  
  - apply the patch from Munehiro Matsuda to hostif.c, this makes the vmware2
port compile under -current as of today
  
  - as described above, use /dev/vmnet1 instead of /compat/linux/dev/vmnet1
in /usr/local/etc/rc.d/vmware.sh
  
  - replace /compat/linux/dev/vmnet1 with a symlink to /dev/vmnet1
(perhaps the previous step would be unnecessary by this one)
  
  After this, vmware comes up and then complains about not able to use
  /dev/rtc (/dev/rtc is present in /compat/linux and is kld-loaded) but
  then continues to start up and runs.
  
  One thing which looks funny to me is this that the vmnet1 device files
  have different minor numbers:
  
  ROOT@bert/root ll /usr/compat/linux/dev/vmnet1-BAK /dev/vmnet1
  crw---  1 root  wheel  149, 0x0081 Nov 20 18:50 /dev/vmnet1
  crw-rw-rw-  1 root  wheel  149, 0x00010001 Nov 20 18:42 
 /usr/compat/linux/dev/vmnet1-BAK
  
  (where /usr/compat/linux/dev/vmnet1-BAK is from the vmware2 port install
   and moved from vmnet1 to vmnet1-BAK before the new symlink was made).
 

After all, after block disk devices was removed wmvare stops support
plain disks :(. Do anybody have solution for it ?
 
  hellmuth
  -- 
  Hellmuth MichaelisTel   +49 40 55 97 47-70
  HCS Hanseatischer Computerservice GmbHFax   +49 40 55 97 47-77
  Oldesloer Strasse 97-99   Mail  hm [at] hcs.de
  D-22457 Hamburg   WWW   http://www.hcs.de
 
--
TSB Russian Express, Moscow
Vladimir B. Grebenschikov, [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



AMERICAN LANGUAGE CENTER

2001-11-20 Thread ALC











  


Call Now!  C. 
Visit Today!  .

156-00-00, 159-57-34, 
274-22-15 

   
  

, ,  


  


  
 :





LOWEST CHARGES plus HIGHEST GRATIFICATION


Moscow, Russia






-




To unsubscribe, please click or copy and paste the following address
into your browser:
http://em5000.com/unsub.php?client=twisted_solo=alc_a&[EMAIL PROTECTED]














ACPI problems on -current

2001-11-20 Thread Wesley Morgan

I am running -current with NEWCARD on a thinkpad x20. The system has
a builtin 3com ethernet card that attaches on the xl driver, and I have a
wavelan card. Neither network card functions when the ACPI module is
loaded, but work perfectly with no acpi.

Anyone have any ideas what the problem may be? The error messages I see
from the wavelan card seem to indicate an interrupt problem, but it gets
the same irq w/o the module and works fine.


WNM

-- 
   _ __ ___   ___ ___ ___
  Wesley N Morgan   _ __ ___ | _ ) __|   \
  [EMAIL PROTECTED] _ __ | _ \._ \ |) |
  FreeBSD: The Power To Serve  _ |___/___/___/
  6bone: 3ffe:1ce3:7::b4ff:fe53:c297
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: vmware2 build fails on -current today

2001-11-20 Thread CHOI Junho

 MM == Munehiro Matsuda [EMAIL PROTECTED] writes:

MM From: CHOI Junho [EMAIL PROTECTED]
MM Date: 20 Nov 2001 17:49:47 +0900
 
 Hi,
 
 Due to recent change on pmap.[ch], vmware2 build fails... Can somebody
 fix this?
MM I don't have patch for it, but you could changed the line in hostif.c,
MM from:
MM pt_entry_t pteptr = (pt_entry_t)vtopte(addr);

MM to:
MM pt_entry_t *pteptr = vtopte(addr);

MM to get it compile.

MM Hope this helps,

That's it. Thanks!

MM Haro

-- 
 +++ Any opinions in this posting are my own and not those of my employers +++
 CHOI Junho [sleeping now]http://www.kr.FreeBSD.org/~cjh
 [while sleeping] cjh @ kr.FreeBSD.ORG cjh @ FreeBSD.ORG cjh @ wdb.co.kr
 Korea FreeBSD Users Group www.kr.FreeBSD.org   Web Data Bankwww.wdb.co.kr

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: ACPI problems on -current

2001-11-20 Thread Warner Losh

In message [EMAIL PROTECTED] Wesley Morgan writes:
: Anyone have any ideas what the problem may be? The error messages I see
: from the wavelan card seem to indicate an interrupt problem, but it gets
: the same irq w/o the module and works fine.

With all due respect, this report is too vague to do anything useful
with.

At the very least, we need the error messages, and likely a full boot
-v dmesg to even begin to track down the problem.

Warner

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: ACPI problems on -current

2001-11-20 Thread Wesley Morgan

I placed the verbose boot dmesg's at

www.chemikals.org/acpi

and

www.chemikals.org/no-acpi

Thanks in advance for any help rendered!


On Tue, 20 Nov 2001, Warner Losh wrote:

 In message [EMAIL PROTECTED] Wesley Morgan writes:
 : Anyone have any ideas what the problem may be? The error messages I see
 : from the wavelan card seem to indicate an interrupt problem, but it gets
 : the same irq w/o the module and works fine.

 With all due respect, this report is too vague to do anything useful
 with.

 At the very least, we need the error messages, and likely a full boot
 -v dmesg to even begin to track down the problem.

 Warner

 To Unsubscribe: send mail to [EMAIL PROTECTED]
 with unsubscribe freebsd-mobile in the body of the message


-- 
   _ __ ___   ___ ___ ___
  Wesley N Morgan   _ __ ___ | _ ) __|   \
  [EMAIL PROTECTED] _ __ | _ \._ \ |) |
  FreeBSD: The Power To Serve  _ |___/___/___/
  6bone: 3ffe:1ce3:7::b4ff:fe53:c297
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message