[Freeciv-Dev] [bug #14230] add new server state S_S_SAVEGAME to prevent changing of the ruleset after a savegame was loaded
Follow-up Comment #8, bug #14230 (project freeciv): it is even easier (and shorter) - the variable game.info.is_new_game defines if the game was started once upon a time. This reduces the patch to a oneliner ... I will send some fallout of the first try as extra tickets. (file #6664) ___ Additional Item Attachment: File name: 0001-restrict-change-of-the-rulesetdir-if-the-game-was-sta.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?14230 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14304] add comments to explain the server states
URL: http://gna.org/bugs/?14304 Summary: add comments to explain the server states Project: Freeciv Submitted by: syntron Submitted on: Sonntag 13.09.2009 um 14:53 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: None ___ Details: see summary; some comments to explain the working of the server states. _No_ code changes! ___ File Attachments: --- Date: Sonntag 13.09.2009 um 14:53 Name: 0001-add-comments-to-explain-the-server-states.diff Size: 1kB By: syntron http://gna.org/bugs/download.php?file_id=6665 ___ Reply to this item at: http://gna.org/bugs/?14304 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14306] save all settings in the savegame
URL: http://gna.org/bugs/?14306 Summary: save all settings in the savegame Project: Freeciv Submitted by: syntron Submitted on: Sonntag 13.09.2009 um 14:53 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: None ___ Details: save missing server settings in the savegame: * compress * compresstype * startpos ___ File Attachments: --- Date: Sonntag 13.09.2009 um 14:53 Name: 0001-save-all-settings-in-the-savegame.diff Size: 3kB By: syntron http://gna.org/bugs/download.php?file_id=6667 ___ Reply to this item at: http://gna.org/bugs/?14306 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14308] remove string format code for server messages
URL: http://gna.org/bugs/?14308 Summary: remove string format code for server messages Project: Freeciv Submitted by: syntron Submitted on: Sonntag 13.09.2009 um 17:55 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.2.0 ___ Details: remove string format code for server messages example: set aifill 10 show changed -- All options with non-default values + means you may change the option = means the option is on its default value -- Optionvalue (min,max) description -- aifill+ [c fg=red]10 [/c] (0,30) Limited number of AI players -- ___ File Attachments: --- Date: Sonntag 13.09.2009 um 17:55 Name: 0001-remove-string-format-code-for-server-messages.diff Size: 1kB By: syntron http://gna.org/bugs/download.php?file_id=6669 ___ Reply to this item at: http://gna.org/bugs/?14308 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1296] restructure basic notify functions
URL: http://gna.org/patch/?1296 Summary: restructure basic notify functions Project: Freeciv Submitted by: syntron Submitted on: Sonntag 13.09.2009 um 18:09 Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: this patch includes a cleanup of the notify_* functions. * the new function fill_packet_chat_msg() is used to generate the struct packet_chat_msg * vnotify_conn() is replaced by notify_conn_packet() As all the notify_* functions now have the message as struct packet_chat_msg this can directly be used for offline events (patch #1280) ___ File Attachments: --- Date: Sonntag 13.09.2009 um 18:09 Name: 0001-restructure-basic-notify-functions.diff Size: 8kB By: syntron http://gna.org/patch/download.php?file_id=6671 ___ Reply to this item at: http://gna.org/patch/?1296 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1280] add offline events
Follow-up Comment #5, patch #1280 (project freeciv): complete rewrite of the offline events code; in the first patches I did only applied the patches by book to mainline. This patch includes the chat messages as well as other cleanups of the code. It depends on patch #1296. add offline events * if a player is not connected events are saved and send if he reconnects * all messages are saved (game events as well as chat messages) * default: events of 1 turns are saved based on patches for longturn by book: git-svn-id: https://pagema.net/svn/lt-civser...@4345 81e79487-72da-0310-8e13-94f5ef8dd271 git-svn-id: https://pagema.net/svn/lt-civser...@4324 81e79487-72da-0310-8e13-94f5ef8dd271 (file #6672) ___ Additional Item Attachment: File name: 0002-add-offline-events.diff Size:21 KB ___ Reply to this item at: http://gna.org/patch/?1280 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1281] add server setting for the number of turns offline events are saved
Follow-up Comment #3, patch #1281 (project freeciv): rewrite of the server settings part of the offline event patch (patch #1280) add server setting for offline events * offlineturns: the number of turns offline events are saved * offlineevents: the number of offline events saved * offlinechat: (dis)allow offline chat messages (file #6673) ___ Additional Item Attachment: File name: 0003-add-server-setting-for-offline-events.diff Size:9 KB ___ Reply to this item at: http://gna.org/patch/?1281 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1285] add offline chat
Follow-up Comment #4, patch #1285 (project freeciv): the server option offlinechat is included in patch #1281 ___ Reply to this item at: http://gna.org/patch/?1285 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1297] ignore command
URL: http://gna.org/patch/?1297 Summary: ignore command Project: Freeciv Submitted by: syntron Submitted on: Sonntag 13.09.2009 um 18:17 Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: add an ignore command. It can be used by a player to ignore chat messages by other players. Patch by: book Adapted to mainline by: Matthias Pfafferodt syntron git-svn-id: https://pagema.net/svn/lt-civser...@4387 81e79487-72da-0310-8e13-94f5ef8dd271 ___ File Attachments: --- Date: Sonntag 13.09.2009 um 18:17 Name: 0004-ignore-command.diff Size: 15kB By: syntron http://gna.org/patch/download.php?file_id=6674 ___ Reply to this item at: http://gna.org/patch/?1297 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1297] ignore command
Follow-up Comment #1, patch #1297 (project freeciv): this patch is based on patch #1280 but could be applied separately (only small changes needed) ___ Reply to this item at: http://gna.org/patch/?1297 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Towards 2.2
Am Thursday 10 September 2009 15:42:56 schrieb Marko Lindqvist: 2009/9/5 Marko Lindqvist cazf...@gmail.com: Ruleset format freeze: Do we need to make any changes to ruleset format before 2.2 is released? Let me know of any such patches or plans. Ruleset format freeze means that people can start making rulesets against current freeciv codebase knowing that their ruleset will be 2.2 compatible. Nobody commented that they have patches or plans for patches changing ruleset format. We can declare ruleset format frozen? Possible patches which changes the ruleset are the tech upkeep (https://gna.org/patch/index.php?1264) and the variable city radii (https://gna.org/patch/?1235). While the first one could be ready for 2.2 (for testing; the right numbers have to be found) the second one changes a basic game principle and needs some discussion. I'm fine if both wait for 2.3 ... -- Matthias Pfafferodt - http://www.mapfa.de Matthias.Pfafferodt at mapfa.de ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13465] wrong savename used for savefile name generation
Follow-up Comment #3, bug #13465 (project freeciv): add updated version of the patch which uses game.info.is_new_game; also include a version for S2_1 (file #6675, file #6676) ___ Additional Item Attachment: File name: 0001-add-clientset-command-for-settings-from-the-civclie.diff Size:8 KB File name: 0001--S2_1-add-clientset-command-for-settings-from-the.diff Size:8 KB ___ Reply to this item at: http://gna.org/bugs/?13465 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1266] add option to restrict the use of road and rails for enemies
Follow-up Comment #4, patch #1266 (project freeciv): It seems that you are saving value to savegame as game.restrictinfra, but trying to load value game.info.restrictinfra. Have you tested this? I updated the patch. I test if the effect is working; normally this does not include a save/reload test ... Also, as new value is added to game.info, network protocol is changed. Capstr must be changed accordingly. I try to remember and write this into the note to the patch. For local testing this results in a not appling patch so I do not include this change. changes: * check if the tile is owned by a player (file #6677) ___ Additional Item Attachment: File name: 0001-add-option-to-restrict-the-use-of-road-and-rails-for.diff Size:6 KB ___ Reply to this item at: http://gna.org/patch/?1266 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14308] remove string format code for server messages
Follow-up Comment #1, bug #14308 (project freeciv): This is my mistake... How about to put that featured_text_to_plain_text() call directly in conn_write() to prevent all this kind of problems? ___ Reply to this item at: http://gna.org/bugs/?14308 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1296] restructure basic notify functions
Follow-up Comment #1, patch #1296 (project freeciv):
It looks a good patch. But I noticed an error in notify_conn_packet(): if
one connection is not allowed to receive the tile coordinates, then the
coordinates in the packets are set to -1 (which is right), but then, if the
next connection of the list is allowed to see that tile, the packet
coordinates are not computed back.
Also, I'm not sure about:
if (packet-x != -1 packet-y != -1) {
ptile = map_pos_to_tile(packet-x, packet-y);
} else {
assert(!is_normal_map_pos(-1, -1));
ptile = NULL;
}
I would have done:
if (is_normal_map_pos(packet-x, packet-y)) {
ptile = map_pos_to_tile(packet-x, packet-y);
} else {
ptile = NULL;
}
like in client side.
___
Reply to this item at:
http://gna.org/patch/?1296
___
Message posté via/par Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1252] cleanup of load_ruleset_game()
Follow-up Comment #11, patch #1252 (project freeciv): updated patch attached changes: * set RS_MAX_UPGRADE_VETERAN_LOSS to MAX_VET_LEVELS (= 10) * adapted civ1/civ2 ruleset (file #6678) ___ Additional Item Attachment: File name: 0001-cleanup-of-load_ruleset_game.diff Size:33 KB ___ Reply to this item at: http://gna.org/patch/?1252 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14308] remove string format code for server messages
Follow-up Comment #2, bug #14308 (project freeciv): This is my mistake... How about to put that featured_text_to_plain_text() call directly in conn_write() to prevent all this kind of problems? OK, I updated the patch. Is there a way to _not_ use two buffers? (file #6679) ___ Additional Item Attachment: File name: 0001-remove-string-format-code-for-server-messages.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?14308 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1199] free allocated memory (settings patch series)
Follow-up Comment #2, patch #1199 (project freeciv): I have update the entire settings patch series and also rebased it to the current trunk. This changes of this patch are included there they is needed. ___ Reply to this item at: http://gna.org/patch/?1199 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14311] no way to reset the server if a savegmae was loaded
URL: http://gna.org/bugs/?14311 Summary: no way to reset the server if a savegmae was loaded Project: Freeciv Submitted by: syntron Submitted on: Sonntag 13.09.2009 um 22:34 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: None ___ Details: the server can be reset within a game using the end command; this is not possible if a savegame was loaded ___ Reply to this item at: http://gna.org/bugs/?14311 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13867] [patch 01/07] get game settings via wrapper functions
Follow-up Comment #8, bug #13867 (project freeciv):
rebased version of the patch:
get game settings via wrapper functions
* cleanup naming:
- definition: struct setting {};
- data: struct setting settings[];
- pointer: struct setting *pset;
- functions: setting_*()
* remove 'extern' flag from settings
* define (and use) iterating macro for settings
(file #6681)
___
Additional Item Attachment:
File name: 0001-get-game-settings-via-wrapper-functions.diff Size:40 KB
___
Reply to this item at:
http://gna.org/bugs/?13867
___
Nachricht geschickt von/durch Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13868] [patch 02/07] use an union in the struct setting
Follow-up Comment #1, bug #13868 (project freeciv): rebased version of the patch: use an union in the struct setting * change the wrapper functions * protect the union by asserts (file #6682) ___ Additional Item Attachment: File name: 0002-use-an-union-in-the-struct-setting.diff Size:12 KB ___ Reply to this item at: http://gna.org/bugs/?13868 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions
Follow-up Comment #2, bug #13869 (project freeciv): rebased version of the patch: simplify validation functions - use union bisval - use pointer in the callback functions (file #6683) ___ Additional Item Attachment: File name: 0003-simplify-validation-functions.diff Size:21 KB ___ Reply to this item at: http://gna.org/bugs/?13869 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13871] [patch 05/07] add settting action callback function
Follow-up Comment #1, bug #13871 (project freeciv): rebased version of the patch: add settting action callback function (file #6685) ___ Additional Item Attachment: File name: 0005-add-settting-action-callback-function.diff Size:38 KB ___ Reply to this item at: http://gna.org/bugs/?13871 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13872] [patch 06/07] move sset_is_to_client() to settings.c
Follow-up Comment #2, bug #13872 (project freeciv): rebased version of the patch: move sset_is_to_client() to settings.c * rename it to setting_is_to_client() * remove 'static' flag (file #6686) ___ Additional Item Attachment: File name: 0006-move-sset_is_to_client-to-settings.c.diff Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?13872 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1197] save game settings in game.ruleset
Follow-up Comment #3, patch #1197 (project freeciv): this is a duplicate of bug #13873 ___ Reply to this item at: http://gna.org/patch/?1197 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1200] game settings can be locked by the ruleset
Follow-up Comment #1, patch #1200 (project freeciv): rebased version of the patch: game settings can be locked by the ruleset (file #6688) ___ Additional Item Attachment: File name: 0008-game-settings-can-be-locked-by-the-ruleset.diff Size:9 KB ___ Reply to this item at: http://gna.org/patch/?1200 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1299] setting.lock only allowed if the settings is defined for the ruleset
URL: http://gna.org/patch/?1299 Summary: setting.lock only allowed if the settings is defined for the ruleset Project: Freeciv Submitted by: syntron Submitted on: Sonntag 13.09.2009 um 22:52 Category: general Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: None ___ Details: setting.lock only allowed if the settings is defined for the ruleset * new function secfile_has_entry() ___ File Attachments: --- Date: Sonntag 13.09.2009 um 22:52 Name: 0011--setting-.lock-only-allowed-if-the-settings-is-define.diff Size: 4kB By: syntron http://gna.org/patch/download.php?file_id=6691 ___ Reply to this item at: http://gna.org/patch/?1299 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1300] add 'show locked' command
URL: http://gna.org/patch/?1300 Summary: add 'show locked' command Project: Freeciv Submitted by: syntron Submitted on: Sonntag 13.09.2009 um 22:54 Category: general Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: None ___ Details: see summary ___ File Attachments: --- Date: Sonntag 13.09.2009 um 22:54 Name: 0012-add-show-locked-command.diff Size: 3kB By: syntron http://gna.org/patch/download.php?file_id=6692 ___ Reply to this item at: http://gna.org/patch/?1300 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1284] update reset command
Follow-up Comment #2, patch #1284 (project freeciv): rebased version of the patch * does _not_ need S_S_SAVEGAME anymore (file #6693) ___ Additional Item Attachment: File name: 0013-update-reset-command.diff Size:13 KB ___ Reply to this item at: http://gna.org/patch/?1284 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1301] settings patch series
URL: http://gna.org/patch/?1301 Summary: settings patch series Project: Freeciv Submitted by: syntron Submitted on: Sonntag 13.09.2009 um 22:58 Category: general Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: None ___ Details: this patch includes all 13 parts of the settings patch series [01/13] bug #13867 - get game settings via wrapper functions [02/13] bug #13868 - use an union in the struct setting [03/13] bug #13869 - simplify validation functions [04/13] bug #13870 - extra functions to check and update settings [05/13] bug #13871 - add settting action callback function [06/13] bug #13872 - move sset_is_to_client() to settings.c [07/13] bug #13873 - save game settings in game.ruleset [08/13] patch #1200 - game settings can be locked by the ruleset [09/13] patch #1198 - show changed game settings after reset and rulesetdir [10/13] patch #1298 - Documentation of the setting changes in the ruleset [11/13] patch #1299 - setting.lock only allowed if the settings is defined for the ruleset [12/13] patch #1300 - add 'show locked' command [13/13] patch #1284 - update reset command ___ File Attachments: --- Date: Sonntag 13.09.2009 um 22:58 Name: settings.diff Size: 122kB By: syntron http://gna.org/patch/download.php?file_id=6694 ___ Reply to this item at: http://gna.org/patch/?1301 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1224] implement the city radius as variable save in the city struct
Follow-up Comment #1, patch #1224 (project freeciv): add change from patch #1233 into this patch as the change belongs here (file #6695) ___ Additional Item Attachment: File name: 0001-implement-the-city-radius-as-variable-save-in-the-cit.diff Size:77 KB ___ Reply to this item at: http://gna.org/patch/?1224 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1233] [fix] missing change to the default lua script
Follow-up Comment #2, patch #1233 (project freeciv): it belongs into the patch #1224; I have updated this patch so this one can be closed ___ Reply to this item at: http://gna.org/patch/?1233 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1235] variable city radii
Follow-up Comment #2, patch #1235 (project freeciv): patch #1233 is now included in patch #1224 ___ Reply to this item at: http://gna.org/patch/?1235 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14137] Ruleset string issues batch from Sini
Follow-up Comment #1, bug #14137 (project freeciv): I created a patch to update most of the reported points. This changes the rulesets and the translations have to be updated. reported by Sini Ruohomaa sini.ruoho...@cs.helsinki.fi on the freeciv-i18n list. (file #6696) ___ Additional Item Attachment: File name: 0001-update-translations.diff Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?14137 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14308] remove string format code for server messages
Follow-up Comment #3, bug #14308 (project freeciv): Is there a way to not use two buffers? I don't think so... ___ Reply to this item at: http://gna.org/bugs/?14308 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14313] Wish: continued exploration over known territory
URL: http://gna.org/bugs/?14313 Summary: Wish: continued exploration over known territory Project: Freeciv Submitted by: kudra Submitted on: Monday 09/14/2009 at 00:13 Category: None Severity: 1 - Wish Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: None ___ Details: If you have previously explored an area, and later new cities were built (which you can see by the border lines), you need to move a unit manually through the area in order to discover cities which have been built. It would be nice if the standard 'x' explore function would send units over areas that have previously been discovered. The priority should be to examine undiscovered areas, but once all such areas within reach have been explored, it would be nice to have the explorer unit(s) retrace areas. I imagine this could be done most simply by going to areas where we are aware of a border but not the name of the cities within the border. A more complicated solution would be to keep track of when a territory was last explored, and update the oldest knowledge first. ___ Reply to this item at: http://gna.org/bugs/?14313 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14314] Server segfaults when loading a game
URL:
http://gna.org/bugs/?14314
Summary: Server segfaults when loading a game
Project: Freeciv
Submitted by: None
Submitted on: Monday 09/14/2009 at 02:31 CEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email: goswin-...@web.de
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release: None
___
Details:
Hi,
attached is a game with the galactic rules set from the forum and no fog of
war (I think that is causing the segfault). The serve segfaults after (in
maphand.c):
void map_change_seen(struct tile *ptile, struct player *pplayer, int change,
enum vision_layer vlayer)
{
struct player_tile *plrtile = map_get_player_tile(ptile, pplayer);
The problem is that pplayer-private_map is NULL at this point so the
player_tile returned is 0x420 (just the tile offset) and the access to it a
few lines down segfaults.
I changes the map_get_playe_tile() function to allocate a map when missing
and that stops the segfaults but I'm not sure what side effects that has:
struct player_tile *map_get_player_tile(const struct tile *ptile,
const struct player *pplayer)
{
if (pplayer-private_map == NULL) {
freelog(LOG_DEBUG, map_get_player_tile() called before player has map,
allocating);
player_map_allocate(pplayer);
}
return pplayer-private_map + tile_index(ptile);
}
As a side node, loading a fresh games with zero moves done works fine. But
after a few moves the segfault comes.
MfG
Goswin
___
File Attachments:
---
Date: Monday 09/14/2009 at 02:31 CEST Name: no-fog.sav.bz2 Size: 29kB By:
None
http://gna.org/bugs/download.php?file_id=6698
___
Reply to this item at:
http://gna.org/bugs/?14314
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14315] Unneccessary popups when civil disorder gets fixed by governer
URL: http://gna.org/bugs/?14315 Summary: Unneccessary popups when civil disorder gets fixed by governer Project: Freeciv Submitted by: None Submitted on: Monday 09/14/2009 at 04:04 CEST Category: client-gtk-2.0 Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: goswin-...@web.de Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: None ___ Details: Hi, I have configure the gtk client to pop up when a city has civil disorder because of the risk to being a democracy. I'm also using the city governer. Now when a city has civil disorder I get a popup even if the governer emidiatly fixes the situation. I would like to only get a popup if the governer can not fix the civil disorder. MfG Goswin ___ Reply to this item at: http://gna.org/bugs/?14315 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
