[Freeciv-Dev] [patch #4997] [Metaticket] Get rid of action_enabler_append_hard()
Update of patch #4997 (project freeciv): Depends on: = patch #4671 ___ Follow-up Comment #1: Added patch #4671 (move the source tile limits to the ruleset) as a dependency. In patch #4995 Emmet Hikory persia wrote: _I'm unsure whether having that in a requirements vector is better: it makes it easier to write help or set the action dialog content in the UI for humans, but the AI will still benefit from hardcoding here (because it's not worth checking for a unit that can create an embassy or where it might go unless there is a lack of embassy with the target), but the current AI is omniscient, so doesn't really care about embassies, making this matter less._ Depends on the AI's knowledge source. An AI that has hard coded knowledge that creating an embassy when one already exists is pointless won't need it. An AI that get its (initial) domain knowledge from the rules will benefit from it. _Also, the fix affects also freeciv-manual, which might not be what we want_ It isn't. I could have introduced a new argument read only (perhaps change save_script?) to make it work as wanted in freeciv-manual. Based on how unpopular action_enabler_append_hard() appears to be the least invasive solution (only loading it when playing) looked better. ___ Reply to this item at: http://gna.org/patch/?4997 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4995] Make the source tile limit on spy actions a hard action enabler requirement
Update of patch #4995 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Follow-up Comment #9: _the above is merely discussion_ Since I'm closing this I replied in patch #4997. ___ Reply to this item at: http://gna.org/patch/?4995 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4671] Move limits on what terrain a spy action can be done from to the ruleset
Update of patch #4671 (project freeciv): Summary: Move limits on what terrain a spy action can be done from to action enablers = Move limits on what terrain a spy action can be done from to the ruleset ___ Reply to this item at: http://gna.org/patch/?4671 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4997] [Metaticket] Get rid of action_enabler_append_hard()
Follow-up Comment #2, patch #4997 (project freeciv): My apologies for any confusion: the *current* AI is omniscient, so there's no increase of want for embassy creation based on other conditions (like relations with the other player, wish to understand the techs / money / map / units of the other player, etc.). The current AI also has hardcoded knowledge that embassies are player-scoped, so doesn't bother considering an embassy if one exists. A different AI could certainly not have this knowledge, but there are performance benefits to understanding that embassies are player-scoped, whereas most other actions are city- or unit-scoped, so I imagine that other AIs would also embed this knowledge, either in code, or in datasets used for initial knowledge definition. For humans, it's a UI question: establishing an embassy in a city owned by a player with whom one already has an embassy should be indicated to be useless in the UI (and possibly disabled): I'm unsure how having this in the ruleset vs. the code makes a difference. Now, if embassies were moved to city-scope (so that if one has an embassy, and the city is conquered, one loses that embassy and gains an embassy with the conquering player), then the above no longer applies, but unless that is a real plan today, it would be sensible to deal with a hardcoded restriction during that effort (as there are so many other hardcoded assumptions one needs to adjust for such a change). ___ Reply to this item at: http://gna.org/patch/?4997 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22404] tech_upkeep uninitialized in player_tech_upkeep()
Follow-up Comment #3, bug #22404 (project freeciv): If my original patch is to be used, it should be changed at least to initialize with 0.0 instead of 0 and drop assignment of 0.0 from default case. I would be happy with your solution then. ___ Reply to this item at: http://gna.org/bugs/?22404 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22216] trunk server crashes in execute_orders()
Update of bug #22216 (project freeciv): Status:None = Ready For Test Assigned to: pepeto = None ___ Follow-up Comment #4: I won't be able to commit the patch before a while. Feel free to manage this ticket. ___ Reply to this item at: http://gna.org/bugs/?22216 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7751] Tracking release 2.5.0-beta1
Update of task #7751 (project freeciv): Should be Finished on: Sun 05 Jan 2014 22:00:00 GMT = Mon 21 Jul 2014 00:00:00 BST Status:None = Done Percent Complete: 0% = 100% Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/task/?7751 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22403] Self-rootreq techs fail sanitycheck
Follow-up Comment #1, bug #22403 (project freeciv): Do you think the server should allow self-rootreq techs (in which case the code should be changed)? Or do you think the server do right by rejecting self-rootreq techs (in which case the multiplayer ruleset should be changed)? ___ Reply to this item at: http://gna.org/bugs/?22403 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22403] Self-rootreq techs fail sanitycheck
Follow-up Comment #2, bug #22403 (project freeciv): The former -- they're supposed to be a standard supported technique for things like alternative tech trees, special script-granted techs and so on. ___ Reply to this item at: http://gna.org/bugs/?22403 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5000] Remove obsolete move_cost constants
Update of patch #5000 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5000 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4872] [metaticket] Help updates for 2.6.0
Update of patch #4872 (project freeciv): Depends on: = patch #4993 ___ Reply to this item at: http://gna.org/patch/?4872 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4972] Validate ruleset supplied specialist names
Update of patch #4972 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4972 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] mac os 2.4.2 build
Ryan P.C. McQuen writes: i was wondering if packages would be built for the 2.4.x series and if i could help in some way. :) None of the current maintainers have Mac OS X, so we don't currently plan to release any new Mac OS X packages, I'm afraid. If you want to help, refreshing http://www.freeciv.org/wiki/Install-MacOSX with clear and up-to-date instructions for people seeking to run Freeciv on the Mac OS would be a very useful start! I've tweaked it slightly based on conversations with Mac users, but really I haven't got a clue about Macs. I guess that preparing .dmg style packages like we used to have (and being able to prepare new ones on demand when we make releases) would also be useful? (If they are still a thing on current versions of the Mac OS, and easier to use than MacPorts?) (The old ones we had seemed to depend on the version of the Mac OS running on the maintainer's machine at a minimum, though, which didn't seem ideal.) ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4968] Infracache to calculate value of extras, and not separately for roads and bases
Update of patch #4968 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4968 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22180] Player style not set, causing crash when (auto)saving the game
Update of bug #22180 (project freeciv): Category:None = general Summary: Server crashes after first turn in a new game. = Player style not set, causing crash when (auto)saving the game ___ Follow-up Comment #27: Do you happen to use custom ruleset with animals enabled? I just noticed that creation of their nation leaves style unset, leaving to this same error with savegames. At the moment I'm assuming this to be separate issue, so I'll open new ticket about the Animal Kingdom crash not to pollute this ticket with unrelated stuff. Otherwise I've still not been able to reproduce this. As some similar bugs were fixed just before these reports (since the change that caused code to break in various places had gone in a bit earlier), the exact freeciv revision is important. Original reporter already said that it was r25125 (which already had all the fixes so far), but was that the case with freeciv-web too? ___ Reply to this item at: http://gna.org/bugs/?22180 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22412] Player style not set for animal nation
URL: http://gna.org/bugs/?22412 Summary: Player style not set for animal nation Project: Freeciv Submitted by: cazfi Submitted on: Fri 01 Aug 2014 12:00:37 AM EEST Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: Like with bug #21853 and bug #22180, one more case of nation creation leaves national style unset; creation of animal nation. Fix attached ___ File Attachments: --- Date: Fri 01 Aug 2014 12:00:37 AM EEST Name: AnimalStyle.patch Size: 450B By: cazfi http://gna.org/bugs/download.php?file_id=21607 ___ Reply to this item at: http://gna.org/bugs/?22412 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5005] Require gettext-0.14
URL: http://gna.org/patch/?5005 Summary: Require gettext-0.14 Project: Freeciv Submitted by: cazfi Submitted on: Fri 01 Aug 2014 12:32:12 AM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Make gettext version 0.14 the minimum requirement. Versions between old minimum 0.10.35 and 0.14 provide many reasons to bump the minimum version, but the reason I want to take the final step from 0.13 to 0.14 is: * Special feature for Farsi (Persian): Translators can insert an 'I' flag into numeric format directives in format strings. Its effect is that, on glibc systems, the number is generated with the locale dependent set of special digits instead of the usual ASCII digits. We don't have active Farsi translator at the moment, but when new translators activate, they start working on the stable branch of the time, and we can't bump the requirement in stable branch. In case we get new Farsi translator during the 2.6 cycle, let's have this feature secured. Gettext-0.14 is already over a decade old (released Jan-04), so the requirement is still low even with this increase. ___ File Attachments: --- Date: Fri 01 Aug 2014 12:32:12 AM EEST Name: Gettext014.patch Size: 4kB By: cazfi http://gna.org/patch/download.php?file_id=21608 ___ Reply to this item at: http://gna.org/patch/?5005 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4747] Make client settings code to understand that 2.6 is followed by 3.0
Update of patch #4747 (project freeciv): Planned Release: = 2.6.0 ___ Follow-up Comment #3: Patch to remaining problem. When minor version number = 90, the config file is (MAJOR+1).0 See task #4759 for discussion about such version numbering. (file #21609) ___ Additional Item Attachment: File name: ClientConfig30.patch Size:0 KB ___ Reply to this item at: http://gna.org/patch/?4747 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4759] Setting TRUNK for 3.0 development
Follow-up Comment #5, patch #4759 (project freeciv): Now I think 2.90.99 - leaving space for bumps in minor version number during the development in case we want to make snapshots (short-cycle) builds (I'm not saying we will, but having the option does not hurt) ___ Reply to this item at: http://gna.org/patch/?4759 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4747] Make client settings code to understand that 2.6 is followed by 3.0
Follow-up Comment #4, patch #4747 (project freeciv): See task #4759 for discussion about such version numbering. patch #4759, not task. ___ Reply to this item at: http://gna.org/patch/?4747 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4372] Animal Kingdom
Follow-up Comment #1, patch #4372 (project freeciv): Updated against svn: - Replaced city_style with style in animals.ruleset - Dropped changes to nations/POTFILES.skip and ruledit/POTFILES.skip (file #21610) ___ Additional Item Attachment: File name: AnimalKingdom-2.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?4372 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22413] --enable-gitrev and version as GITREV2
URL: http://gna.org/bugs/?22413 Summary: --enable-gitrev and version as GITREV2 Project: Freeciv Submitted by: cazfi Submitted on: Fri 01 Aug 2014 02:22:00 AM EEST Category: bootstrap Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.0, 2.6.0 ___ Details: Sed magic does not replace GITREV2 tag with correct string. Fix attached. ___ File Attachments: --- Date: Fri 01 Aug 2014 02:22:00 AM EEST Name: Gitrev2.patch Size: 697B By: cazfi http://gna.org/bugs/download.php?file_id=21611 ___ Reply to this item at: http://gna.org/bugs/?22413 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20723] Enabling multiple luasql backends broken on S2_5 trunk
Update of bug #20723 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #6: The LuaSQL docs indicate that an equivalent set of 'require' statements inside Lua can end up with a 'luasql' table containing multiple drivers simultaneously. (That site does not respond, but I found some documentation from luasql git) No, the example shows how 'require' is used to open *multiple* tables, not *one* where everything works. So first step is obviously opening all the tables. That's easy. Ideally I would then like to combine the tables in to one, but that's not very easy, at least to be done right. So I think it's sufficient for now to use multiple tables in database.lua too. Patch attached. I don't currently have good setup to test this, so I'd be grateful if someone else could do some testing on this. (file #21612) ___ Additional Item Attachment: File name: MultibackendLuasql.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?20723 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4835] Sdl2-client Coding Style corrections
Follow-up Comment #5, patch #4835 (project freeciv): - Next patch (to be committed after 36h) (file #21613) ___ Additional Item Attachment: File name: DialogsCoding.patch.bz2Size:8 KB ___ Reply to this item at: http://gna.org/patch/?4835 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
