[Freeciv-Dev] [bug #22787] Changing the theme does not work

2014-10-12 Thread Marko Lindqvist
Follow-up Comment #1, bug #22787 (project freeciv):

With another theme it partly works - seems like the problem is our lack of
complete theme reset - if the new theme does not define something, that part
remains from the old theme instead of changing to global default.

___

Reply to this item at:

  http://gna.org/bugs/?22787

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5356] multiplayer ruleset: Explain what goes on with tech giving in script.lua

2014-10-12 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5356

 Summary: multiplayer ruleset: Explain what goes on with tech
giving in script.lua
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 12 Oct 2014 09:01:41 AM UTC
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add comments documenting how shared research interacts with the free techs
from Darwin's Voyage and Philosophy to script.lua.

See bug #22782 for talk about changing it.



___

File Attachments:


---
Date: Sun 12 Oct 2014 09:01:41 AM UTC  Name:
0001-multiplayer-ruleset-Explain-what-goes-on-with-tech-g.patch  Size: 2kB  
By: sveinung

http://gna.org/patch/download.php?file_id=22606

___

Reply to this item at:

  http://gna.org/patch/?5356

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size

2014-10-12 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, bug #22782 (project freeciv):

Darwin's voyage has the opposite effect on shared techs: It will only work for
one of the players that share tech.

___

Reply to this item at:

  http://gna.org/bugs/?22782

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5357] common/tech.c: player_invention_reachable call cost is exponential with deep technology trees: fixed with memoization

2014-10-12 Thread anonymous
URL:
  http://gna.org/patch/?5357

 Summary: common/tech.c: player_invention_reachable call cost
is exponential with deep technology trees: fixed with memoization
 Project: Freeciv
Submitted by: None
Submitted on: Sun 12 Oct 2014 09:05:06 AM UTC
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: aloril+free...@iki.fi
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Originally player_invention_reachable has exponential cost.
When technology tree is too deep, for example 10 additional layers, it takes
too long time. With enough levels over that it practically never returns.

This uses memoization to cache recursive result. Memoization table is
calculated from scratch at every call and discarded when function returns.
Converts call cost from exponential to linear.




___

File Attachments:


---
Date: Sun 12 Oct 2014 09:05:06 AM UTC  Name: tech.patch  Size: 5kB   By: None

http://gna.org/patch/download.php?file_id=22607

___

Reply to this item at:

  http://gna.org/patch/?5357

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22159] Gtk2 research report redraw slow with experimental ruleset

2014-10-12 Thread Jacob Nevins
Follow-up Comment #9, bug #22159 (project freeciv):

Patch #5357 helps with this.

___

Reply to this item at:

  http://gna.org/bugs/?22159

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5358] multiplayer ruleset: Inform embassies about techs gained from Lua.

2014-10-12 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5358

 Summary: multiplayer ruleset: Inform embassies about techs
gained from Lua.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 12 Oct 2014 09:27:37 AM UTC
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 2.5.0

___

Details:

Foreign embassies are noticed when the tech source is a hut. Notice them when
the tech source is Darwin's Voyage and Philosophy too.



___

File Attachments:


---
Date: Sun 12 Oct 2014 09:27:37 AM UTC  Name:
0002-multiplayer-ruleset-Inform-embassies-about-techs-gai.patch  Size: 3kB  
By: sveinung

http://gna.org/patch/download.php?file_id=22609

___

Reply to this item at:

  http://gna.org/patch/?5358

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5356] multiplayer ruleset: Explain what goes on with tech giving in script.lua

2014-10-12 Thread Sveinung Kvilhaugsvik
Update of patch #5356 (project freeciv):

 Planned Release:   2.6.0 = 2.6.0, 2.5.0   


___

Reply to this item at:

  http://gna.org/patch/?5356

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22788] multiplayer ruleset: Techs are given both by Lua script and ruleset

2014-10-12 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/bugs/?22788

 Summary: multiplayer ruleset: Techs are given both by Lua
script and ruleset
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 12 Oct 2014 09:30:48 AM UTC
Category: rulesets
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:






___

Reply to this item at:

  http://gna.org/bugs/?22788

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22651] The freeciv-gtk2 client crashed when trying to connect to freeciv-gtk3 server

2014-10-12 Thread Jacob Nevins
Update of bug #22651 (project freeciv):

  Status:   Duplicate = None   
 Open/Closed:  Closed = Open   

___

Follow-up Comment #8:

 I just repeated the crash in comment #4: with freeciv-2.5.0 beta1
 seems 100% reproducible.
Can you post the backtrace, so we can confirm it's the same thing?
Last entry in freeciv-gtk2.RPT file, or whole file will do.

 Main outstanding question is why did changing the locale have 
 any correlation with this networking bug
It's a thread bug, so inherently intermittent; I can believe a locale change
perturbing it into happening. I suspect the other bug you refer to (bug
#22448) is uninitialised data of some sort, so similar excuse.

___

Reply to this item at:

  http://gna.org/bugs/?22651

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22789] Deep technology tree goals not working correctly

2014-10-12 Thread Jacob Nevins
Update of bug #22789 (project freeciv):

 Release:   2.5 beta1 = 2.5.0-beta1


___

Reply to this item at:

  http://gna.org/bugs/?22789

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22159] Gtk2 research report redraw slow with experimental ruleset

2014-10-12 Thread Jacob Nevins
Follow-up Comment #10, bug #22159 (project freeciv):

Comment #2:
 Bug here: if a long term goal is defined, freeciv is not 
 able to find the next short term goal, leaving it empty.
This is now tracked separately as bug #22789.

___

Reply to this item at:

  http://gna.org/bugs/?22159

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5345] Gtk clients: Action selection dialog: Store button id for all actions

2014-10-12 Thread Sveinung Kvilhaugsvik
Update of patch #5345 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5345

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5353] Gtk clients: Support changing the tool tip of a choice dialog button.

2014-10-12 Thread Sveinung Kvilhaugsvik
Update of patch #5353 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5353

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5354] Qt client: Generate the Help Build Wonder label text in one place.

2014-10-12 Thread Sveinung Kvilhaugsvik
Update of patch #5354 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5354

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22678] Gtk3 ugliness (Windows)

2014-10-12 Thread Jacob Nevins
Follow-up Comment #10, bug #22678 (project freeciv):

 Here is a screenshot of gtk3 3.14.2 to compare.
That looks like it's not even trying to use custom Freeciv theming, so is not
directly comparable to my screenshots.
(If you're the same person as bug #22787 comment 1, this is the Adwaita
theme, yes?)

___

Reply to this item at:

  http://gna.org/bugs/?22678

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22651] The freeciv-gtk2 client crashed when trying to connect to freeciv-gtk3 server

2014-10-12 Thread anonymous
Follow-up Comment #9, bug #22651 (project freeciv):

You already did the backtrace for gtk2, so here's the one for gtk3.


C:Program FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe caused an Access
Violation at location 004eb453 in module C:Program
FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe Reading from location 03abf640.

Registers:
eax=03abf640 ebx=0022f8cc ecx=0022f100 edx=03abf640 esi= edi=0022f2cc
eip=004eb453 esp=0022f1c0 ebp=0022f288 iopl=0 nv up ei pl nz na po nc
cs=001b  ss=0023  ds=0023  es=0023  fs=003b  gs= efl=00010206

Call stack:
004EB453  C:Program FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe:004EB453 
WinMain  /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
0045B1D6  C:Program FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe:0045B1D6 
WinMain  /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
0042E1B8  C:Program FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe:0042E1B8 
WinMain  /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
010A183A  C:Program FilesFreeciv-2.5.0-beta1-gtk3libgdk-3-0.dll:010A183ADwarf
Error: found dwarf version '49664', this reader only handles version 2
information.  gdk_threads_set_lock_functions
685FA30E  C:Program
FilesFreeciv-2.5.0-beta1-gtk3libglib-2.0-0.dll:685FA30EDwarf Error: found
dwarf version '1346', this reader only handles version 2 information. 
g_child_watch_add
685F81D3  C:Program FilesFreeciv-2.5.0-beta1-gtk3libglib-2.0-0.dll:685F81D3 
g_source_is_destroyed
685F8C0A  C:Program FilesFreeciv-2.5.0-beta1-gtk3libglib-2.0-0.dll:685F8C0A 
g_main_context_dispatch
685F8DE5  C:Program FilesFreeciv-2.5.0-beta1-gtk3libglib-2.0-0.dll:685F8DE5 
g_main_context_dispatch
685F91D4  C:Program FilesFreeciv-2.5.0-beta1-gtk3libglib-2.0-0.dll:685F91D4 
g_main_loop_run
665538C2  C:Program FilesFreeciv-2.5.0-beta1-gtk3libgtk-3-0.dll:665538C2BFD
2.13.90 20030111 assertion fail ../../src/bfd/libbfd.c:584Dwarf Error: found
dwarf version '834', this reader only handles version 2 information. 
gtk_main
004055D3  C:Program FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe:004055D3 
WinMain  /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
00407320  C:Program FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe:00407320 
WinMain  /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
0040235B  C:Program FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe:0040235B 
console_main 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:318
00402418  C:Program FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe:00402418 
WinMain  /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
00401AD6  C:Program FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe:00401AD6
004010DB  C:Program FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe:004010DB
00401158  C:Program FilesFreeciv-2.5.0-beta1-gtk3freeciv-gtk3.exe:00401158
77E6F32B  C:WINDOWSsystem32kernel32.dll:77E6F32B  ProcessIdToSessionId


___

Reply to this item at:

  http://gna.org/bugs/?22651

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22792] LAN scan has never worked for me on Ubuntu Linux

2014-10-12 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?22792

 Summary: LAN scan has never worked for me on Ubuntu Linux
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 12 Oct 2014 14:15:00 BST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_4 r26761
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

I don't recall seeing the LAN scan feature working with any version of
Freeciv, on Linux, ever (or at least since I've been using Ubuntu).

My current Ubuntu version is 12.04 (but I've used older LTS versions such as
10.04). Testing with Freeciv head-of-S2_4 r26761 (but as I say, I've never
seen it work with an older or newer version).

This may well be something peculiar to my configuration, so some details:
* I believe network stack is IPv6-capable but it certainly has no connectivity
(so only link-local/localhost stuff should work?)
* I use two machines, both currently running Ubuntu 12.04:
** one (desktop) which may or may not have a local network interface (eth0),
and basically always has a ppp0 Internet connection and is running a
forwarding firewall (and has been this way forever). (THis is an unusual
configuration; most people have a router to manage their Internet
connection.)
** one (netbook) which is in a classic client setup, usually with wired or
wireless network connectivity (including firewall)

Normally client and server run on the same machine (am I right to expect this
case to work?), but I can't get any joy even if they don't.

(Disclaimer: I know little about broadcast/multicast/UDP and how it's meant to
be used.)



Here's what I see when I follow the steps in patch #5361. (I believe udp/4555
and udp/4556 are the relevant ports for this feature, and
default_multicast_group_ipv4 is 225.1.1.1.)
FAOD, this was all on the desktop machine, with ppp0 but without eth0
connectivity; but adding eth0 or doing it on the netbook or putting
client/server on different machines seems to make little difference.

 1. Start server

No error messages on server console. netstat -a --ip -n shows:


udp0  0 0.0.0.0:45550.0.0.0:* 



netstat -g -n gains this additional line on the desktop:


ppp01  225.1.1.1


(Hmm. Only joining multicast group on a single interface, and that being an
unhelpful one? On my netbook this line mentions eth0.)

 2. Start client

No change.

 3. Connect to Network Game
 4. Wait a couple of seconds for server to appear in Local Area Network
-tab (open by default) 

Step 4 never happens. No error messages from client.


udp0  0 0.0.0.0:45550.0.0.0:* 

udp0  0 0.0.0.0:45560.0.0.0:* 




ppp02  225.1.1.1


(similar but with eth0 on the netbook)



Vague theory (just formed):

We're somehow attaching the LAN-scan magic to a single random interface when
maybe we should be attaching it to more.

On my desktop machine it ends up on the Internet interface, ppp0. On my
netbook it ends up on eth0. Maybe that explains why they can't see each other?
Perhaps if my setup were more conventional (both machines only having eth0)
it would happen to work?

Maybe not attaching it to lo explains why client/server on the same machine
can't see each other?




___

Reply to this item at:

  http://gna.org/bugs/?22792

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21004] Game announcement multicast over IPv6 not working to another node.

2014-10-12 Thread Jacob Nevins
Follow-up Comment #6, bug #21004 (project freeciv):

 LAN announcement has never worked for me in Linux?
 Have you open bug about the announcement issue?
Finally raised as bug #22792.

___

Reply to this item at:

  http://gna.org/bugs/?21004

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22792] LAN scan has never worked for me on Ubuntu Linux

2014-10-12 Thread Marko Lindqvist
Follow-up Comment #1, bug #22792 (project freeciv):

Indeed, the IPv6 side even has a TODO comment: /* TODO: Interface selection */

___

Reply to this item at:

  http://gna.org/bugs/?22792

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19840] Multicast fails without active connection

2014-10-12 Thread Jacob Nevins
Follow-up Comment #4, bug #19840 (project freeciv):

Confirm this can still happen with S2_4 r26761.

In my case I took away internet connectivity (via ppp0) but still had an
active physical connection to a local network via eth0, and it had another
machine on it. This is a scenario that ought to work correctly.

___

Reply to this item at:

  http://gna.org/bugs/?19840

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22792] LAN scan has never worked for me on Ubuntu Linux

2014-10-12 Thread Jacob Nevins
Follow-up Comment #2, bug #22792 (project freeciv):

I tried getting rid of the ppp0 interface on my desktop machine to see if the
desktop and laptop could find each other, but the desktop started exhibiting
bug #19840 despite having local connectivity via eth0. (IP_ADD_MEMBERSHIP
(225.1.1.1) failed / lanserver scan sendto failed)

Is it trying to use the interface which has the default route, or something?
(Still not looked at the code.)

___

Reply to this item at:

  http://gna.org/bugs/?22792

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19840] Multicast fails without active connection

2014-10-12 Thread Jacob Nevins
Follow-up Comment #5, bug #19840 (project freeciv):

(It also happens on my netbook when I have no physical connectivity at all --
network cable unplugged and no wireless. This is more like the OP's setup, and
perhaps more forgivable, although it might still be nice if server/client both
on localhost could find each other. For more details of my setup see bug
#22792.)

___

Reply to this item at:

  http://gna.org/bugs/?19840

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5362] Client API: add action_selection_target_unit()

2014-10-12 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5362

 Summary: Client API: add action_selection_target_unit()
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 12 Oct 2014 01:43:03 PM UTC
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

It is already possible to get the actor unit and target city by using
action_selection_target_city() and action_selection_actor_unit(). Make it
possible to get the target unit as well.




___

File Attachments:


---
Date: Sun 12 Oct 2014 01:43:03 PM UTC  Name:
0005-Client-API-Make-getters-complete-by-adding-action_se.patch  Size: 9kB  
By: sveinung

http://gna.org/patch/download.php?file_id=22613

___

Reply to this item at:

  http://gna.org/patch/?5362

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5363] Client: Receive background updates to action selection dialogs.

2014-10-12 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5363

 Summary: Client: Receive background updates to action
selection dialogs.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 12 Oct 2014 01:44:18 PM UTC
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

This is needed so the Help Build Wonder action can continue being updated
when it is controlled by action enablers.

No background updates are asked for. No client support is added.



___

File Attachments:


---
Date: Sun 12 Oct 2014 01:44:18 PM UTC  Name:
0006-Client-Receive-background-updates-to-action-selectio.patch  Size: 9kB  
By: sveinung

http://gna.org/patch/download.php?file_id=22614

___

Reply to this item at:

  http://gna.org/patch/?5363

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5363] Client: Receive background updates to action selection dialogs.

2014-10-12 Thread Sveinung Kvilhaugsvik
Update of patch #5363 (project freeciv):

  Depends on: = patch #5362


___

Reply to this item at:

  http://gna.org/patch/?5363

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22793] Some comments/docs still claim ruleset (etc) files use ISO8859-1 encoding

2014-10-12 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?22793

 Summary: Some comments/docs still claim ruleset (etc) files
use ISO8859-1 encoding
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 12 Oct 2014 14:46:10 BST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.4.4, 2.5.0, 2.6.0

___

Details:

Various docs, comments, and messages imply that ruleset files are in
ISO8859-1/latin1 encoding.

This hasn't been true for over a decade (r8170, PR#9976). It's all UTF-8 now.

Patch in preparation:
* Fix/remove outdated comments
* Fix doc/HACKING, plus a few unrelated things I spotted on the way past
(still a lot of work needed)
* Describe *_ENCODING variable functions + defaults more fully in man pages
* Fix a translatable message mentioning latin1




___

Reply to this item at:

  http://gna.org/bugs/?22793

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5363] Client: Receive background updates to action selection dialogs.

2014-10-12 Thread Sveinung Kvilhaugsvik
Update of patch #5363 (project freeciv):

  Depends on: = patch #5261


___

Reply to this item at:

  http://gna.org/patch/?5363

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5364] Ask for background updates to action selection dialogs on diplstate change.

2014-10-12 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5364

 Summary: Ask for background updates to action selection
dialogs on diplstate change.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 12 Oct 2014 01:48:40 PM UTC
Category: client
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

The state change most likely to cause a difference in enabled actions is if
the diplomatic state to a target's owner changes. Ask for a background update
when an action selection dialog is open and the diplomatic relation to the
target's owner changes.



___

File Attachments:


---
Date: Sun 12 Oct 2014 01:48:40 PM UTC  Name:
0007-Ask-for-background-updates-to-action-selection-dialo.patch  Size: 3kB  
By: sveinung

http://gna.org/patch/download.php?file_id=22615

___

Reply to this item at:

  http://gna.org/patch/?5364

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks

2014-10-12 Thread Jacob Nevins
Follow-up Comment #13, bug #22381 (project freeciv):

Raised bug #22794 to resolve whether this should be reverted or modified.
Please discuss / make proposals there.

___

Reply to this item at:

  http://gna.org/bugs/?22381

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5367] Consider move_rate when picking a transport in transporter_for_unit()

2014-10-12 Thread Jacob Nevins
URL:
  http://gna.org/patch/?5367

 Summary: Consider move_rate when picking a transport in
transporter_for_unit()
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 12 Oct 2014 14:58:04 BST
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0-beta2, 2.6.0

___

Details:

From patch #4982:
 Out of interest, was there a reason for removing transporter
 moves left as a selection criterion (added in bug #22189)?
 I think it should still be there if only as a tiebreaker.
 Sorry, I can't remember. It may be a mistake.




___

Reply to this item at:

  http://gna.org/patch/?5367

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4982] Better transporter_for_unit()

2014-10-12 Thread Jacob Nevins
Follow-up Comment #5, patch #4982 (project freeciv):

 Sorry, I can't remember. It may be a mistake.
Raised patch #5367 to rectify.

___

Reply to this item at:

  http://gna.org/patch/?4982

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5367] Consider move_rate when picking a transport in transporter_for_unit()

2014-10-12 Thread Jacob Nevins
Follow-up Comment #1, patch #5367 (project freeciv):

Hm, it requires a little thought, due to nested transporters. The move rate of
the outermost transport is clearly important (and checking that will be better
than nothing), but perhaps inner ones should be considered too.

___

Reply to this item at:

  http://gna.org/patch/?5367

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5367] Consider move_rate when picking a transport in base_transporter_for_unit()

2014-10-12 Thread Jacob Nevins
Update of patch #5367 (project freeciv):

 Summary: Consider move_rate when picking a transport in
transporter_for_unit() = Consider move_rate when picking a transport in
base_transporter_for_unit()


___

Reply to this item at:

  http://gna.org/patch/?5367

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22678] Gtk3 ugliness (Windows)

2014-10-12 Thread anonymous
Follow-up Comment #11, bug #22678 (project freeciv):

Yes - the screenshot in  comment #9: is Adwaita theme.
I have now managed to swap themes in the client to the freeciv theme. It seems
the ugliness in the gtk3 client is definitely in the freeciv theme not within
gtk3 itself.

Here is a screenshot from the same client as  comment #9: but using freeciv
theme.

What you don't see here is how much better the flags look in Adwaita. I will
try to do a side by side comparison


(file #22618)
___

Additional Item Attachment:

File name: main-win-gtk314-freeciv-theme.JPG Size:136 KB


___

Reply to this item at:

  http://gna.org/bugs/?22678

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22795] Server ask to remove unknown unit during alliance break up

2014-10-12 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/bugs/?22795

 Summary: Server ask to remove unknown unit during alliance
break up
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 12 Oct 2014 02:24:57 PM UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: TRUNK
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

After breaking an alliance the following back trace appears:

1: Server wants us to remove unit id 104, but we don't know about this unit!
2: Backtrace:
2: 0: ./client/freeciv-qt(backtrace_print+0x22) [0x643f12]
2: 1: ./client/freeciv-qt(vdo_log+0x76) [0x648d36]
2: 2: ./client/freeciv-qt(do_log+0x7b) [0x648dcb]
2: 3: ./client/freeciv-qt(handle_unit_remove+0x159) [0x4b08e9]
2: 4: ./client/freeciv-qt(client_handle_packet+0x551) [0x4bafc1]
2: 5: ./client/freeciv-qt(client_packet_input+0x6a) [0x48372a]
2: 6: ./client/freeciv-qt(input_from_server+0x6c) [0x489d9c]
2: 7:
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN11QMetaObject8activateEP7QObjectiiPPv+0x77d)
[0x7f4d08a988ed]
2: 8:
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN15QSocketNotifier9activatedEiNS_14QPrivateSignalE+0x3e)
[0x7f4d08b16b9e]
2: 9:
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN15QSocketNotifier5eventEP6QEvent+0x4b)
[0x7f4d08aa5dfb]
2:10:
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent+0x8c)
[0x7f4d08083f3c]
2:11:
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN12QApplication6notifyEP7QObjectP6QEvent+0x3a0)
[0x7f4d08089380]
2:12:
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN16QCoreApplication14notifyInternalEP7QObjectP6QEvent+0xdb)
[0x7f4d08a69efb]
2:13: /usr/lib/x86_64-linux-gnu/libQt5Core.so.5(+0x32dbe5)
[0x7f4d08ac1be5]
2:14:
/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_context_dispatch+0x24d)
[0x7f4d04392c5d]
2:15: /lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x49f48) [0x7f4d04392f48]
2:16:
/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_context_iteration+0x2c)
[0x7f4d04392ffc]
2:17:
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN20QEventDispatcherGlib13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE+0x57)
[0x7f4d08ac1517]
2:18:
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE+0x112)
[0x7f4d08a67732]
2:19:
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN16QCoreApplication4execEv+0x9c)
[0x7f4d08a6f1ac]
2:20: ./client/freeciv-qt(_ZN9fc_client4mainEP12QApplication+0x202)
[0x469832]
2:21: ./client/freeciv-qt(_Z11qtg_ui_mainiPPc+0x10d) [0x46a57d]
2:22: ./client/freeciv-qt(client_main+0x327) [0x483cd7]
2:23: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)
[0x7f4d0717fb45]
2:24: ./client/freeciv-qt() [0x46993d]




___

Reply to this item at:

  http://gna.org/bugs/?22795

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22678] Gtk3 ugliness (Windows)

2014-10-12 Thread anonymous
Follow-up Comment #12, bug #22678 (project freeciv):

Here is a comparison of the same pick nation window in the same gtk3 client
using two different themes (freeciv and adwaita).

see attached nations-compare-in-different-themes.JPG

The Adwaita theme has a far clearer and sharper image for both flags and
cities than the freeciv theme.



(file #22619)
___

Additional Item Attachment:

File name: nations-compare-in-different-themes.JPG Size:122 KB


___

Reply to this item at:

  http://gna.org/bugs/?22678

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18440] IP_ADD_MEMBERSHIP (225.1.1.1) failed on Windows

2014-10-12 Thread anonymous
Follow-up Comment #7, bug #18440 (project freeciv):

This bug is also seen at http://gna.org/bugs/?22448#comment10
with crosser build freeciv-win32-2.5.99-dev-r25830 

and

http://gna.org/bugs/?22448#comment16
a user compiled freeciv 2.5.0-beta1+ on windows

___

Reply to this item at:

  http://gna.org/bugs/?18440

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22678] Gtk3 ugliness (Windows)

2014-10-12 Thread Jacob Nevins
Follow-up Comment #13, bug #22678 (project freeciv):

Can you post again as a lossless format like .PNG? The JPEG compression
artifacts make it hard to see what you're talking about.

___

Reply to this item at:

  http://gna.org/bugs/?22678

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [task #7752] Qt-programs for Windows

2014-10-12 Thread Christian Prochaska
Follow-up Comment #2, task #7752 (project freeciv):

First test version using Qt 5.3.2 built from source with the attached patches:
http://download.gna.org/freeciv/packages/windows/testing/Freeciv-2.5.0-beta1+-win32-qt-20141012-setup.exe

For some reason, on Windows the 'info_label::paint()' function is called
before indicator icons have been created, so I modified the function a bit to
avoid a crash when starting the client (patch also attached), but this might
not be the proper fix.

I've uploaded the gnuwin32 build environment with Qt at
http://download.gna.org/freeciv/packages/windows/gnuwin32/testing/gnuwin32-2014-10-12.7z


(file #22620, file #22621, file #22622)
___

Additional Item Attachment:

File name: qt_5_3_2.diff  Size:4 KB
File name: gui_qt_info_label.diff Size:0 KB
File name: win32_qt_installer-S2_5.diff   Size:21 KB


___

Reply to this item at:

  http://gna.org/task/?7752

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22796] freeciv-manual 2.5.0-beta1 bugs

2014-10-12 Thread Frank
URL:
  http://gna.org/bugs/?22796

 Summary: freeciv-manual 2.5.0-beta1 bugs
 Project: Freeciv
Submitted by: dunnoob
Submitted on: Sun 12 Oct 2014 22:25:11 UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.0-beta1
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

0 freeciv-manual -h lists -- --help as GUI help option.
  freeciv-manual -- --help fails with unknown option --.
0 freeciv-manual ends up in a dead loop or very long loop
  of assertion failures. verbatim
in is_nation_pickable() [../../../../common/nation.c::206]:
assertion '!is_server()' failed. /verbatim
0 freeciv-manual -d 3 -l deleteme.log reports that the dead
  or long loop begins immediately after MANUAL_TERRAIN for
  MANUAL_BUILDINGS; manual4.html is created, but empty.
0 The manual parts 1..3 consist of some odd mixture of HTML
  and MediaWiki markup (no USE_HTML in civmanual.c line 83).
  No new bug, that was already odd for 2.3/2.4.
0 Ignoring the Wiki markup the manual parts 1+2 (all server
  commands+options) are fine, and ignoring the missing PNGs
  parts 3..5 were also interesting in 2.3/2.4.  But part 6
  (MANUAL_GOV) is messy.  There is a FIXME in line 472 for
  MANUAL_GOV.

Suggested fix for (1) after looking in common/fc_cmdhelp.h,
replace the 2nd TRUE by FALSE in tools/civmanual.c line 617:
verbatim
-cmdhelp_display(help, TRUE, TRUE, TRUE);
+cmdhelp_display(help, TRUE, FALSE, TRUE);
/verbatim





___

Reply to this item at:

  http://gna.org/bugs/?22796

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22796] freeciv-manual 2.5.0-beta1 bugs

2014-10-12 Thread Frank
Follow-up Comment #1, bug #22796 (project freeciv):

So far for UIs without preview, entering my own submit until readable dead
loop now:

0 freeciv-manual -h lists -- --help as GUI help option.  freeciv-manual --
--help fails with unknown option --.
0 freeciv-manual ends up in a dead loop or very long loop of assertion
failures. verbatim
in is_nation_pickable() [../../../../common/nation.c::206]:
assertion '!is_server()' failed. /verbatim
0 freeciv-manual -d 3 -l deleteme.log reports that the dead or long loop
begins immediately after MANUAL_TERRAIN for MANUAL_BUILDINGS; manual4.html is
created, but empty.
0 The manual parts 1..3 consist of some odd mixture of HTML and MediaWiki
markup (no USE_HTML in civmanual.c line 83). No new bug, that was already odd
for 2.3/2.4.
0 Ignoring the Wiki markup the manual parts 1+2 (all server commands+options)
are fine, and ignoring the missing PNGs parts 3..5 were also interesting in
2.3/2.4.  But part 6 (MANUAL_GOV) is messy.  There is a FIXME in line 472
for MANUAL_GOV.

Suggested fix for (1) after looking in common/fc_cmdhelp.h, replace the 2nd
TRUE by FALSE in tools/civmanual.c line 617:
verbatim
-cmdhelp_display(help, TRUE, TRUE, TRUE);
+cmdhelp_display(help, TRUE, FALSE, TRUE);
/verbatim


___

Reply to this item at:

  http://gna.org/bugs/?22796

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22796] freeciv-manual 2.5.0-beta1 bugs

2014-10-12 Thread Frank
Follow-up Comment #2, bug #22796 (project freeciv):

Third attempt:

0 freeciv-manual -h lists -- --help as GUI help option. freeciv-manual --
--help fails with unknown option --.
0 freeciv-manual ends up in a dead loop or very long loop of assertion
failures. 
in is_nation_pickable() [../../../../common/nation.c::206]:
assertion '!is_server()' failed. 
0 freeciv-manual -d 3 -l deleteme.log reports that the dead or long loop
begins immediately after MANUAL_TERRAIN for MANUAL_BUILDINGS; manual4.html is
created, but empty.
0 The manual parts 1..3 consist of some odd mixture of HTML and MediaWiki
markup (no USE_HTML in civmanual.c line 83). No new bug, that was already odd
for 2.3/2.4.
0 Ignoring the Wiki markup the manual parts 1+2 (all server commands+options)
are fine, and ignoring the missing PNGs parts 3..5 were also interesting in
2.3/2.4.  But part 6 (MANUAL_GOV) is messy.  There is a FIXME in line 472
for MANUAL_GOV.

Suggested fix for (1) after looking in common/fc_cmdhelp.h, replace the 2nd
TRUE by FALSE in tools/civmanual.c line 617:

-cmdhelp_display(help, TRUE, TRUE, TRUE);
+cmdhelp_display(help, TRUE, FALSE, TRUE);



___

Reply to this item at:

  http://gna.org/bugs/?22796

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev