[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ >Thanks for your contribution. I added your patch to my PR. On my system I ran >into a minor issue. >Some C99 types like uint8_t were not defined and I had to >include stdint.h. This change is not enough; there is still warning: ``` ipa_pwd_ntlm.c: In function 'encode_nt_key': ipa_pwd_ntlm.c:58:5: warning: implicit declaration of function 'strlen' [-Wimplicit-function-declaration] il = strlen(newPasswd); ^ ipa_pwd_ntlm.c:58:10: warning: incompatible implicit declaration of built-in function 'strlen' il = strlen(newPasswd); ^ ``` The latest version is a small improvement; but there are still problems/small issues because this PR was created with intention to use tox. I know you are busy. So I wrote client-only implementation from scratch. This PR is superseded by #494 """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-281606346 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ Also I added section to FreeIPA wiki: http://www.freeipa.org/page/V4/Build_system_refactoring#Packager_-_client_only_build """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-281692728 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/70554938d4f9ba5b347cd4bc8001428e905198e4 https://fedorahosted.org/freeipa/changeset/41d7ae54fafc6deb602e1a990eaec37c6ae4880b https://fedorahosted.org/freeipa/changeset/20c1eb9844223d892da47da1ea10662d37953ff8 https://fedorahosted.org/freeipa/changeset/2747f2ad782c7640ecc6949098f0d43411182255 """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-281689932 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (22/02/17 06:16), Simo Sorce wrote: >So this is the reasoning and why I am approving this PR and not #494. > >When you build all components, including server bits, tests are installed, >therefore when we build just client bits tets that are relevant to client bits >also need to be installed for consistency. > >Any switch should default to the same behavior regardless of whether server >build is enabled. It is confusing if the --with[out]-[ipa]tests switch changes >default based on a different switch passed to configure. > >As far as I understand this PR maintains the same default for either server or >client only builds, so it gets my approval. > Neither of python packages which I mention in #494 package unit test in fedora. So there is not a reason to package them by default for client only build. And integration tests require server therefore must not be installed by default with client-only build. Result: This PR has wrong default for instalation of ipatests with client-only build. LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-281687875 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server simo5 commented: """ So this is the reasoning and why I am approving this PR and not #494. When you build all components, including server bits, tests are installed, therefore when we build just client bits tets that are relevant to client bits also need to be installed for consistency. Any switch should default to the same behavior regardless of whether server build is enabled. It is confusing if the --with[out]-[ipa]tests switch changes default based on a different switch passed to configure. As far as I understand this PR maintains the same default for either server or client only builds, so it gets my approval. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-281680804 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ >Thanks for your contribution. I added your patch to my PR. On my system I ran >into a minor issue. >Some C99 types like uint8_t were not defined and I had to >include stdint.h. This change is not enough; there is still warning: ``` ipa_pwd_ntlm.c: In function 'encode_nt_key': ipa_pwd_ntlm.c:58:5: warning: implicit declaration of function 'strlen' [-Wimplicit-function-declaration] il = strlen(newPasswd); ^ ipa_pwd_ntlm.c:58:10: warning: incompatible implicit declaration of built-in function 'strlen' il = strlen(newPasswd); ^ ``` >By the way I'm just going to ignore your snidely and snarky comment. No problem. I am going to forget that my proposal for compromise was ignored for 12 days. The latest version is a small improvement; but there are still problems/small issues because this PR was created with intention to use tox. I know you are busy. So I wrote client-only implementation from scratch. This PR is superseded by #494 """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-281606346 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ The PR works and the `--without-ipatests` option omits the ipatests directory. However, #494 doesn't install extra dependencies with `mock --without=server`. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-281621714 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ Now ```-without-ipatests``` argument for @lslebodn """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-281478186 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ Now ```-without-ipatests``` argument for @lslebodn """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-281478186 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ Thanks for your contribution. I added your patch to my PR. On my system I ran into a minor issue. Some C99 types like ```uint8_t``` were not defined and I had to include ```stdint.h```. By the way I'm just going to ignore your snidely and snarky comment. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280687364 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ It looks like @tiran does not want to move this PR forward. So here is a link to patch which does not misuse client-only build and add configure time option to install ipatests. https://paste.fedoraproject.org/paste/~u7iDljnMTvinxmLFoc25V5M1UNdIGYhyRLivL9gydE=/ As part of this work I found out that 4 dependencies can be simply moved to server only build: `libuuid`, `DIRSRV`, `libsss_idmap`, `libsss_nss_idmap`. Result => Client only build require less C-dependencies. LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280675665 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (17/02/17 01:12), Petr Vobornik wrote: >I still fail to see why we should care about `make dist` with `configure >--disable-server` this is not a combination of options which should be used >together, there is no point in it except theoretical exercise. > `make dist` works >> then I will need to send PR to fix client-only build and it will not install >> ipatests with --disable-server. > >Why? The main problem with `client-only` build and `ipatests` is that there are not test for it. * all integration test assume that server will be installed first and not that server is already available somewhere. * unit test should be run as part of build (e.g. `make check`) So there is not any reason to install `ipatests` for client only build. Client only build was tested just in downstream :-( LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280621474 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ I still fail to see why we should care about `make dist` with `configure --disable-server` this is not a combination of options which should be used together, there is no point in it except theoretical exercise. > then I will need to send PR to fix client-only build and it will not install > ipatests with --disable-server. Why? """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280596786 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ I have to validate client-only Python wheel packages any way. We can just reuse the same infrastructure to test client-only RPMs later. See PR #475. By the way, validation of Python wheels is the main reason I must have ```ipatests``` in the build. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280587392 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server martbab commented: """ Well you won't, and they were not tested automatically before AFAIK (checked with FreeIPA 4.2.0 sources). We can agree that they *should* be, but since this eventuality was never considered before the build refactoring happened I guess we should first restore the original behavior, and then decide whether the client-only build should run those few unit tests during build. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280582586 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ I have one very important question: Without ipatests, how are you going to automatically test client-only builds? """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280580037 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (16/02/17 02:30), Christian Heimes wrote: >Lukas, you are wasting both my and your precious time with a needless >bike-shedding discussion about semantics. The ```--disable-server``` option >skips all parts of the build process that are only relevant for server and not >relevant for client. ```ipatests``` is relevant for both, therefore it stays. > It's not bikeshadig. You are adding HACKs to freeipa build system. If this PR will be pushed with cuurent state then I will need to send PR to fix client-only build and it will not install ipatests with --disable-server. I proposed you a compromise few times. Thank you very much for ignoring it. LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280433054 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ ACK, I'm fine with pushing this PR. `make install` does install ipatests for client-only build, other server-related packages are omitted. Server build work like before and isn't affected by this PR. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280326722 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ Lukas, you are wasting both my and your precious time with a needless bike-shedding discussion about semantics. The ```--disable-server``` option skips all parts of the build process that are only relevant for server and not relevant for client. ```ipatests``` is relevant for both, therefore it stays. I told you that I need ```ipatests``` to run tests as part of my build process. It is not yet part of the upstream FreeIPA build process. I also told you that I will provide another PR that will take care of it and add client-only tests. This PR acts as a foundation for both my container build processes and the future PR. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280293802 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (16/02/17 00:57), Christian Heimes wrote: >You are missing the point. Obviously tests are an important part of building. >I can't test the client bits when ipatests is not available. > You missed that the name of this PR is "Client-only builds with --disable-server" So this PR *MUST* implement client-only build. Your use-case is different and you need to realize that freeIPA does not have a *unit* test for client bits. All client parts are tested by integration tests which require server. >Let's do small, incremental improvements. I need the client-only builds ASAP >(EOW, next week tops) for some container stuff. Client-only RPMs can be >implemented later in beta phase for 4.5. > I have never requested anything related to "Client-only RPMs" I always mentioned "make install" Let's do the correct change from semantic POV. If you want to install tests with client-only build then please add new configure time option for this purpose And do not misuse option "--disable-server" Misusing options is a bad/hacky approch and we need to clean hacks from freeIPA and not create new one. LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280277782 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ You are missing the point. Obviously tests are an important part of building. I can't test the client bits when ipatests is not available. Let's do small, incremental improvements. I need the client-only builds ASAP (EOW, next week tops) for some container stuff. Client-only RPMs can be implemented later in beta phase for 4.5. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-280271921 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (14/02/17 02:29), Christian Heimes wrote: >I'm following a different design and development philosophy. In my experience >an iterative approach with small, incremental improvements is often better and >faster than striving for 100% perfect PRs. Large and feature complete PRs take >more time than evolutionary steps. > I have never wrote anythig against this philosophy. All small chages can make sense from semantical point of view. Misussing names/options for different use-case just create a big mess and confuse other people. >Please review this PR under three viewpoints: > >* Does it contribute to resolving ticket >https://fedorahosted.org/freeipa/ticket/6517 ? client only build and --disable-server is the same thing (at least from "make install" POV) I have never required changes to spec file. >* Does it enable future changes to solve the ticket? If you will not install ipatests (if there is a way to not install ipatest) then it will enable future changes to solve the ticket. Because solving ticket6517 would be just writing right spec file. ATM it does not enable future changes to solve the ticket. >* Does it break any code or feature that is currently present? [1] Yes, it install server related options even though they should not be installed Summary: You should realize that the name of PR is "Client-only builds with --disable-server" and your use-case is not pure client only build. LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279693909 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ I'm following a different design and development philosophy. In my experience an iterative approach with small, incremental improvements is often better and faster than striving for 100% perfect PRs. Large and feature complete PRs take more time than evolutionary steps. Your object regarding semantics is valid for the ticket, but not necessarily valid for this PR as this PR only addresses a part of the problem. I don't dispute that your proposed changes to the spec file are necessary. However I argue for a separate PR. I'm not an expert in RPM packaging and I'd rather let somebody else figure out the appropriate way to deal with client-only packaging. ipatests is yet another problem that should be solved in a third PR. Ticket https://fedorahosted.org/freeipa/ticket/6517 does not, in fact it should not be solved in one PR. Please review this PR under three viewpoints: * Does it contribute to resolving ticket https://fedorahosted.org/freeipa/ticket/6517 ? * Does it enable future changes to solve the ticket? * Does it break any code or feature that is currently present? [1] [1] client-only packaging is currently not available """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279669097 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (13/02/17 05:05), Christian Heimes wrote: >I'm following the development principals of **minimum viable product**. This >PR solves a critical use case for me. With the PR I can build FreeIPA client >packages in a lean and clean build container. Without the >```--disable-server``` flag I'm forced to bloat my build env with lots of >additional dependencies and then throw away all the extra stuff. > My comments are about semantic of this option. `--disable-server` should disable all parts which depends on server. I know that your use case is a little bit different but I do not like misusing of `--disable-server` for different use-cases (from semantic POV) That's the reason why I proposed compromise/alternative solution for installing `ipatests` which needn't be tight together with `--disable-server`. >My changes don't solve https://fedorahosted.org/freeipa/ticket/6517 to its >full extend. The PR provides enough of >https://fedorahosted.org/freeipa/ticket/6517 to enable me to finish some time >critical as soon as possible. RPM packaging changes and ipatests improvements >for client-only builds can be implemented another time. I consider these >changes sugar coating (aka stretch goals). > One more time; it will be solved with my proposed change to `ipatests` + small tweak to spec file (due to python2/3 changes) That is exactly way how I tested it. A little bit hacky way but works for testing: https://paste.fedoraproject.org/556868/48699519 LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279405767 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ I'm following the development principals of **minimum viable product**. This PR solves a critical use case for me. With the PR I can build FreeIPA client packages in a lean and clean build container. Without the ```--disable-server``` flag I'm forced to bloat my build env with lots of additional dependencies and then throw away all the extra stuff. My changes don't solve https://fedorahosted.org/freeipa/ticket/6517 to its full extend. The PR provides enough of https://fedorahosted.org/freeipa/ticket/6517 to enable me to finish some time critical as soon as possible. RPM packaging changes and ipatests improvements for client-only builds can be implemented another time. I consider these changes sugar coating (aka stretch goals). """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279387199 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (13/02/17 04:32), Christian Heimes wrote: >No, the test runner should either detect missing packages and skip tests >automatically, or should grow an option to load and execute client tests only. >It's a separate issue. > I have a different opinion. It is not a separate issue. For me, the name of configure option is crystall clear. It should not install anything related to daemon part; even thought it is test. Maybe we can add another option to install tests (--with-tests?? +default yes) It would work for your use-case and still allow old `CLIENT_ONLY` build (equivalent to 4.4) Or you can propose another compromise. LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279381495 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ No, the test runner should either detect missing packages and skip tests automatically, or should grow an option to load and execute client tests only. It's a separate issue. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279376400 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (13/02/17 03:56), Christian Heimes wrote: >Two reasons > >1. ```make install``` >2. I need ipatests to be part of the build process in order to get a Python >package for tox later. > OK, thank you for explanation. Then we should install just tests from directory `ipatests` which does not require daemon for execution. LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279368656 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ Two reasons 1. ```make install``` 2. I need ipatests to be part of the build process in order to get a Python package for tox later. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279367184 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (13/02/17 03:08), Christian Heimes wrote: >Packaging is a different issue. The PR does not provide RPM packaging for >client-only build. It merely implements configuration and building without >server components. > I mentioned old version of `CLIENT_ONLY` build because I consider it as a referential implementation. And `ipa tests` were not installed in 4.4 for client only build. >For client-only builds I need ipatests to run part of the test suite to verify >client code. Test suites ```test_ipapython, test_ipalib, test_pkcs10``` >without ```test_ipalib.test_rpc``` work without ```ipaserver```. > I expected a little bit more details. Do you need to run `make install` and then run tests in installed directory? Or how do you want to "run part of the test suite". Because if you needn't run "make install" for your use-case then my proposed patch would work. BTW `ipatests` will still be part of tarball and/or git. You can run them even thought they will not be installed with `make install` LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279362399 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ Packaging is a different issue. The PR does not provide RPM packaging for client-only build. It merely implements configuration and building without server components. For client-only builds I need ipatests to run part of the test suite to verify client code. Test suites ```test_ipapython, test_ipalib, test_pkcs10``` without ```test_ipalib.test_rpc``` work without ```ipaserver```. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279357147 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (13/02/17 01:25), Christian Heimes wrote: >@lslebodn it works even better without your proposed changes. Parts >```ipatests``` work fine for ```--disable-server``` builds. I need the package >to run tests. > The old version (4.4) of `CLIENT_ONLY` build did not package ipatests. Could you describe a reason/use-case for installing `ipatests` without server? LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279349836 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ @lslebodn it works even better without your proposed changes. Parts ```ipatests``` work fine for ```--disable-server``` builds. I need the package to run tests. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279333838 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ It works quite good with the following change ``` diff --git a/Makefile.am b/Makefile.am index 311f6121f..13e5a87b0 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,13 +1,13 @@ ACLOCAL_AMFLAGS = -I m4 if ENABLE_SERVER -SERVER_SUBDIRS = daemons init install ipaserver +SERVER_SUBDIRS = daemons init install ipaserver ipatests else SERVER_SUBDIRS = endif IPACLIENT_SUBDIRS = ipaclient ipalib ipapython SUBDIRS = asn1 util client contrib po \ - $(IPACLIENT_SUBDIRS) ipaplatform ipatests $(SERVER_SUBDIRS) + $(IPACLIENT_SUBDIRS) ipaplatform $(SERVER_SUBDIRS) MOSTLYCLEANFILES = ipasetup.pyc ipasetup.pyo \ ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-279003293 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ In the latest version, ```--disable-server``` does not affect ```make dist```. It only changes the components that are built by ```make``` and installed by ```make install```. ```--disable-server ``` is already documented at http://www.freeipa.org/page/V4/Build_system_refactoring#Configuration . After the PR has landed, I'll update the table. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-278953837 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (10/02/17 06:11), Petr Vobornik wrote: >I still think that this use case needs to be documented in >http://www.freeipa.org/page/V4/Build_system_refactoring#How_to_Use . > >IMHO `make dist` can fail with --disable-server. Use case for `make dist` is >releasing and there is no point to do release without server bitw. But make >sure to document it and test that `make dist` works without it ;) . > Petr FYI: make dist should include all files into tarball even though configure was invoked with parameter --disable-server. LS """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-278952140 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ I still think that this use case needs to be documented in http://www.freeipa.org/page/V4/Build_system_refactoring#How_to_Use . IMHO `make dist` can fail with --disable-server. Use case for `make dist` is releasing and there is no point to do release without server bitw. But make sure to document it and test that `make dist` works without it ;) . """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-278950622 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ I followed @lslebodn advice and changed the PR a bit. I now generate all Makefiles again to fix the ```make dist``` issue. Some of the Makefile are not working correctly because some vars are declared empty (e.g. header locations, libs and so on). Since they are not included in ```SUBDIRS```, they are not used in ```make```. ```make dist``` uses ```DIST_SUBDIRS``` and does not depend on the missing vars. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-278598712 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ Server build works now, but there's still the `make dist` issue discussed above. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-278592125 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ @tomaskrizek @lslebodn Although I don't need ```make dist```, you made me aware of a bug in ```Makefile.am```. automake and ```+=``` do not mix well. I moved the list into a new var ```SERVER_SUBDIRS```. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-278416196 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ @tiran Do you need `make dist` for anything? I'm not aware of any plans to release client-only IPA sources, so I don't think it's needed. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-278413427 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ See inline comment and issue above; otherwise LGTM. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-278405529 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ `make dist` failed if configure was executed with `--disable-server` ``` make[3]: Leaving directory '/workdir/freeipa/po' make[2]: Leaving directory '/workdir/freeipa/po' (cd daemons && make top_distdir=../freeipa-4.4.90.dev201702081623+git9da17b545 distdir=../freeipa-4.4.90.dev201702081623+git9da17b545/daemons \ am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) make[2]: Entering directory '/workdir/freeipa/daemons' make[2]: *** No rule to make target 'distdir'. Stop. make[2]: Leaving directory '/workdir/freeipa/daemons' make[1]: *** [Makefile:707: distdir] Error 1 make[1]: Leaving directory '/workdir/freeipa' make: *** [Makefile:806: dist] Error 2 ``` Do we care? """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-278377302 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ @lslebodn I think you misunderstood me. The PR adds a new build flavor that ignores and skips the any server-related steps of the build process. The fact that this PR ignores the server part is actually a a **feature**. :) The last version of the patch now skips ```ipaserver``` subdir completely, too. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-273148073 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ I fine with ignoring python related parts; but it should be documented. But you might ask other freeIPA developers. (maybe on freeipa-devel) """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-273135814 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ @lslebodn I like the idea to move the server related header and lib detection to a separate m4 file. In server-less mode, I plan to ignore the Python server part completely. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-273130643 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ I think it would be simpler to read the code without to many `AM_COND_IF()`. IMHO it would be simpler to move C-related part to separate file (e.g. `server_daemons.m4`) an conditionally include the file with `m4_include`. I checked it very briefly; I might miss something. How do you want to handle python server part? """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-273126212 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ I'm not really experienced with autotools, so I do not want to ack this PR without someone else taking a look. I'm also not sure about the best practices in this area. Perhaps @lslebodn could share his opinion on this change? """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-273124050 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ Nit-pick: A build does not produce any files outside the build environment. Of course **make install** produces the files -- unless you change the prefix with ```./configure --prefix```. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-271901278 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ The extra dependencies are indeed not necessary with this change. However, `make install` produces directories like `/usr/lib/python2.7/site-packages/ipaserver`, `/usr/lib/python2.7/site-packages/ipatests`, ... I don't think these should be present when doing a client-only build. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-271895769 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ The PR only affects ```make install```, Python packaging and integration efforts. The goal is to reduce the amount of necessary build dependencies for installation and packaging of Python wheels or for developers that are only interested to build ipa-client locally. At the moment it is not possible to build FreeIPA without Samba, talloc, tevent, 389 DS, systemd and a couple of more packages. The dependency tree is rather heavy. These dependencies are not relevant for clients, though. I haven't touched RPM builds deliberately. RPM spec can be adjusted in a subsequent PR. It's not relevant for me. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-271879617 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ Could you please extend [V4/Build system refactoring](http://www.freeipa.org/page/V4/Build_system_refactoring) to include steps describing how to perform client-only build? Also, is this supposed to build the freeipa-client rpm package? I wasn't able to build the rpm (``` *** No rule to make target 'distdir'. Stop.```). Or does it only support make + make install? When I tried to do this it also produced ipaserver and ipatests directories. It was probably a misconfiguration on my side. Please provide instructions on how to do a proper client-only build. """ See the full comment at https://github.com/freeipa/freeipa/pull/364#issuecomment-271871528 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
