Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 410s] ar: `u' modifier ignored since `D' is the default (see `U') [ 410s] libtool: link: ranlib .libs/libtransceiver_common.a [ 410s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 410s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 411s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 411s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 411s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 411s] collect2: error: ld returned 1 exit status [ 411s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 411s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 411s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 411s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 411s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 411s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 411s] make[1]: *** [Makefile:444: all] Error 2 [ 411s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 411s] dh_auto_build: make -j1 returned exit code 2 [ 411s] make: *** [debian/rules:6: build] Error 255 [ 411s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 411s] [ 411s] lamb14 failed "build osmo-trx_1.1.1.dsc" at Fri Aug 16 04:53:25 UTC 2019. [ 411s] [ 411s] ### VM INTERACTION START ### [ 414s] [ 395.438678] sysrq: SysRq : Power Off [ 414s] [ 395.450255] reboot: Power down [ 414s] ### VM INTERACTION END ### [ 414s] [ 414s] lamb14 failed "build osmo-trx_1.1.1.dsc" at Fri Aug 16 04:53:29 UTC 2019. [ 414s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 490s] ar: `u' modifier ignored since `D' is the default (see `U') [ 490s] libtool: link: ranlib .libs/libtransceiver_common.a [ 490s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 490s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 491s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 491s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 491s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 491s] collect2: error: ld returned 1 exit status [ 491s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 491s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 491s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 491s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 491s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 491s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 491s] make[1]: *** [Makefile:444: all] Error 2 [ 491s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 491s] dh_auto_build: make -j1 returned exit code 2 [ 491s] make: *** [debian/rules:6: build] Error 255 [ 491s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 491s] [ 491s] lamb56 failed "build osmo-trx_1.1.1.dsc" at Fri Aug 16 04:52:06 UTC 2019. [ 491s] [ 491s] ### VM INTERACTION START ### [ 494s] [ 475.018740] sysrq: SysRq : Power Off [ 494s] [ 475.025302] reboot: Power down [ 494s] ### VM INTERACTION END ### [ 494s] [ 494s] lamb56 failed "build osmo-trx_1.1.1.dsc" at Fri Aug 16 04:52:10 UTC 2019. [ 494s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...osmo-sgsn[master]: gprs_gmm.c: Fix typo in log message
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15189 ) Change subject: gprs_gmm.c: Fix typo in log message .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I357f0af89f5d14d304c3e889a49a5f6c23b7fb7a Gerrit-Change-Number: 15189 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 16 Aug 2019 01:01:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: introduce a connection state
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/15181 to look at the new patch set (#5). Change subject: iu_client: introduce a connection state .. iu_client: introduce a connection state When the SCCP stack indicate a disconnect, save this in the UE connection to allow the application to free() the instance later. Change-Id: I77e01724be05ac488a4685ba367b7a71985b54e3 --- M include/osmocom/ranap/iu_client.h M src/iu_client.c 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/81/15181/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I77e01724be05ac488a4685ba367b7a71985b54e3 Gerrit-Change-Number: 15181 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: gprs_gmm.c: Fix typo in log message
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15189 ) Change subject: gprs_gmm.c: Fix typo in log message .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I357f0af89f5d14d304c3e889a49a5f6c23b7fb7a Gerrit-Change-Number: 15189 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 16 Aug 2019 00:26:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gprs_gmm: Avoid spaces in fsm events and enum strings
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15212 ) Change subject: gprs_gmm: Avoid spaces in fsm events and enum strings .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I16ede8bf8352b09bc772fd7b43fad2c2274b3ec1 Gerrit-Change-Number: 15212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 16 Aug 2019 00:13:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 ) Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported .. Patch Set 3: IMHO: remove the case ..._Iu and add a comment to the enum _Iu it's unsupported. I don't like the ifdef0 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac Gerrit-Change-Number: 15184 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: lynxis lazus Gerrit-Comment-Date: Fri, 16 Aug 2019 00:09:30 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect in...
lynxis lazus has removed a vote on this change. Change subject: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indication .. Removed Code-Review-2 by lynxis lazus -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420 Gerrit-Change-Number: 15182 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: deleteVote
Change in ...osmo-iuh[master]: iu_client: introduce a connection state
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/15181 to look at the new patch set (#4). Change subject: iu_client: introduce a connection state .. iu_client: introduce a connection state When the SCCP stack indicate a disconnect, save this in the UE connection to allow the application to free() the instance later. Change-Id: I77e01724be05ac488a4685ba367b7a71985b54e3 --- M include/osmocom/ranap/iu_client.h M src/iu_client.c 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/81/15181/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I77e01724be05ac488a4685ba367b7a71985b54e3 Gerrit-Change-Number: 15181 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect in...
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/15182 to look at the new patch set (#6). Change subject: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indication .. iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indication Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420 --- M src/iu_client.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/82/15182/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420 Gerrit-Change-Number: 15182 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: ensure UE is not NULL on CO primitives
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15178 ) Change subject: iu_client: ensure UE is not NULL on CO primitives .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/15178/1/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15178/1/src/iu_client.c@801 PS1, Line 801: if (!ue) > right. this patch is in the wrong order. there is a commit for that. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I63222fda6778417b1c986cb05772fecc51c43bb5 Gerrit-Change-Number: 15178 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 16 Aug 2019 00:01:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: set rc early
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15179 ) Change subject: iu_client: sccp_sap_up: set rc early .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/15179/1/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15179/1/src/iu_client.c@768 PS1, Line 768: int rc = -1; > Ok, then better rebse and put this patch before the other one, or merge them. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Idd803774612719df144bef569fb734289aa31282 Gerrit-Change-Number: 15179 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 16 Aug 2019 00:00:37 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-msc[master]: libvlr/vlr.c: cosmetic: move message_type assignment
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/15226
Change subject: libvlr/vlr.c: cosmetic: move message_type assignment
..
libvlr/vlr.c: cosmetic: move message_type assignment
Change-Id: Ice7f98597b54f03069375fac56fb162f2669e7f0
---
M src/libvlr/vlr.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/26/15226/1
diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 625b699..de61ba5 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -680,6 +680,7 @@
{
struct osmo_gsup_message gsup_msg = {
.message_class = OSMO_GSUP_MESSAGE_CLASS_SUBSCRIBER_MANAGEMENT,
+ .message_type = OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST,
};
uint8_t imei_enc[GSM23003_IMEI_NUM_DIGITS+2]; /* +2: IE header */
int len;
@@ -694,7 +695,6 @@
gsup_msg.imei_enc_len = len;
/* Send CHECK_IMEI_REQUEST */
- gsup_msg.message_type = OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST;
OSMO_STRLCPY_ARRAY(gsup_msg.imsi, vsub->imsi);
return gsup_client_mux_tx(vsub->vlr->gcm, _msg);
}
@@ -704,9 +704,9 @@
{
struct osmo_gsup_message gsup_msg = {
.message_class = OSMO_GSUP_MESSAGE_CLASS_SUBSCRIBER_MANAGEMENT,
+ .message_type = OSMO_GSUP_MSGT_AUTH_FAIL_REPORT,
};
- gsup_msg.message_type = OSMO_GSUP_MSGT_AUTH_FAIL_REPORT;
OSMO_STRLCPY_ARRAY(gsup_msg.imsi, vsub->imsi);
return gsup_client_mux_tx(vsub->vlr->gcm, _msg);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15226
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ice7f98597b54f03069375fac56fb162f2669e7f0
Gerrit-Change-Number: 15226
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in ...osmo-ttcn3-hacks[master]: sgsn: Add test to verify duplicate DeactPDPCtx crashing osmo-sgsn
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15225 ) Change subject: sgsn: Add test to verify duplicate DeactPDPCtx crashing osmo-sgsn .. Patch Set 1: Don't merge yet, it will make osmo-sgsn crash. Proper solution to this bug still WIP. I want to add an extra test too proving it can be done with 1 DeleteCtxReq + any other message by swapping the order they are answered. More information: https://osmocom.org/issues/3956?issue_count=137#note-13 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie1cc9fdf91b18b0b7fb3d5fb33b6dcf6f46a393f Gerrit-Change-Number: 15225 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 15 Aug 2019 16:14:04 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: Add test to verify duplicate DeactPDPCtx crashing osmo-sgsn
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15225
Change subject: sgsn: Add test to verify duplicate DeactPDPCtx crashing
osmo-sgsn
..
sgsn: Add test to verify duplicate DeactPDPCtx crashing osmo-sgsn
osmo-sgsn sends 2 DeletePdpCtxReq on gtp, Confirmation received on first
one frees cbp associatd to pdp and the second one accesses the already
freed cbp.
Related: OS#3956
Change-Id: Ie1cc9fdf91b18b0b7fb3d5fb33b6dcf6f46a393f
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/25/15225/1
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 03c9d05..581d838 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1126,6 +1126,44 @@
}
}
+/* Test MS sending a duplicate Deact PDP Ctx (OS#3956). */
+private function f_TC_attach_pdp_act_deact_dup(charstring id) runs on
BSSGP_ConnHdlr {
+ var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));
+ var Gtp1cUnitdata g_ud;
+ var integer i;
+ var OCT1 cause_regular_deact := '24'O;
+
+ /* first perform regular attach + PDP context act */
+ f_TC_attach(id);
+ f_pdp_ctx_act(apars);
+
+ f_send_l3_gmm_llc(ts_SM_DEACT_PDP_REQ_MO(apars.tid,
cause_regular_deact, false, omit), 0);
+ f_send_l3_gmm_llc(ts_SM_DEACT_PDP_REQ_MO(apars.tid,
cause_regular_deact, false, omit), 0);
+
+ for (i := 0; i < 2; i := i+1) {
+ GTP.receive(tr_GTPC_MsgType(?, deletePDPContextRequest,
apars.ggsn_tei_c)) -> value g_ud {
+ var integer seq_nr :=
oct2int(g_ud.gtpc.opt_part.sequenceNumber);
+ log("Received deletePDPContextResponse " & int2str(i) &
", seq_nr=" & int2str(seq_nr));
+ GTP.send(ts_GTPC_DeletePdpResp(g_ud.peer, seq_nr,
apars.sgsn_tei_c, '7F'O));
+ }
+ }
+
+ alt {
+ [] BSSGP[0].receive(tr_BD_L3_MT(tr_SM_DEACT_PDP_ACCEPT_MT(apars.tid))) {
+ setverdict(pass);
+ }
+ [] as_xid(apars, 0);
+ }
+
+ setverdict(pass);
+}
+testcase TC_attach_pdp_act_deact_dup() runs on test_CT {
+ var BSSGP_ConnHdlr vc_conn;
+ f_init();
+ vc_conn := f_start_handler(refers(f_TC_attach_pdp_act_deact_dup),
testcasename(), g_gb, 46);
+ vc_conn.done;
+}
+
/* Table 10.5.156/3GPP TS 24.008 */
template (value) QoSV t_QosDefault := {
@@ -2486,6 +2524,7 @@
execute( TC_attach_pdp_act_ggsn_reject() );
execute( TC_attach_pdp_act_user_deact_mo() );
execute( TC_attach_pdp_act_user_deact_mt() );
+ execute( TC_attach_pdp_act_deact_dup() );
execute( TC_attach_second_attempt() );
execute( TC_attach_restart_ctr_echo() );
execute( TC_attach_restart_ctr_create() );
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15225
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie1cc9fdf91b18b0b7fb3d5fb33b6dcf6f46a393f
Gerrit-Change-Number: 15225
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in ...osmo-ttcn3-hacks[master]: BSC_Tests: Change test-expectation of TC_paging_resp_unsol
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15208 ) Change subject: BSC_Tests: Change test-expectation of TC_paging_resp_unsol .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5562cbf61a2aa42e6950860bc0f9c6c20c61a9fe Gerrit-Change-Number: 15208 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 15:56:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15221 ) Change subject: sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I625574fc42fc915ba483db3bb406922ad6df370d Gerrit-Change-Number: 15221 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 15:56:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: msc_a: switch RAN type back to SGs when a CSFB-Call is cleared
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15222 ) Change subject: msc_a: switch RAN type back to SGs when a CSFB-Call is cleared .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I104adecb0645b81b90ee230c57bf8b463c9e7045 Gerrit-Change-Number: 15222 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 15:55:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bsc[master]: gsm_08_08.c: always pick first msc for unsolicit paging responses
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15209 ) Change subject: gsm_08_08.c: always pick first msc for unsolicit paging responses .. Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/15209/1/src/osmo-bsc/gsm_08_08.c File src/osmo-bsc/gsm_08_08.c: https://gerrit.osmocom.org/#/c/15209/1/src/osmo-bsc/gsm_08_08.c@328 PS1, Line 328: LOGP(DMSC, LOGL_ERROR, "Got paged but no subscriber found, will now (blindly) deliver the paging response to the first configured MSC!\n"); > s/Got paged/Got Paging Response ? ACK https://gerrit.osmocom.org/#/c/15209/1/src/osmo-bsc/gsm_08_08.c@349 PS1, Line 349: LOGL_ERROR this is not an error condition, but a perfectly normal situation in the context of CSFB. It should be INFO, maximum. https://gerrit.osmocom.org/#/c/15209/1/src/osmo-bsc/gsm_08_08.c@358 PS1, Line 358: * blindly. */ > This entire code looks like weird legacy bsc-nat stuff, I've never used > osmo-bsc with more than one […] the code is unrelated to bsc-nat. OsmoBSC once was extended to talk to multiple MSC so you can have a "remote" normal BSC and a local one in case your backhaul fails, or in case you want to route some subscribers locally onboard a vessel. That use case has disappeared now, we could remove it. But we must not change the VTY syntax while doing it. In any case that's unrelated to the current patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7f091ed1bbc2afe12656e42031e122144eeb6826 Gerrit-Change-Number: 15209 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-CC: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 15:55:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gprs_gmm.c: Use osmo_rai_name() in log line
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15224 ) Change subject: gprs_gmm.c: Use osmo_rai_name() in log line .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ieab9b7696c93de9a5d3d42f614072a6f2181e37d Gerrit-Change-Number: 15224 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 15 Aug 2019 14:37:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...meta-telephony[201705]: libosmocore: Package osmo-config-merge
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/15223 ) Change subject: libosmocore: Package osmo-config-merge .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/15223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: Iefab4ac2c37591413d384edc860427dd8fc64c83 Gerrit-Change-Number: 15223 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 13:31:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gprs_gmm.c: Use osmo_rai_name() in log line
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/15224
Change subject: gprs_gmm.c: Use osmo_rai_name() in log line
..
gprs_gmm.c: Use osmo_rai_name() in log line
Change-Id: Ieab9b7696c93de9a5d3d42f614072a6f2181e37d
---
M src/gprs/gprs_gmm.c
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/24/15224/1
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index dd19ce8..e906814 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1825,9 +1825,8 @@
{
/* We cannot use the mmctx */
LOGMMCTXP(LOGL_INFO, mmctx,
- "The MM context cannot be used, RA: %03d-%0*d-%d-%d\n",
- mmctx->ra.mcc, mmctx->ra.mnc_3_digits, mmctx->ra.mnc,
- mmctx->ra.lac, mmctx->ra.rac);
+ "The MM context cannot be used, RA: %s\n",
+ osmo_rai_name(>ra));
/* mmctx is set to NULL and gprs_llgmm_unassign(llme) will be
called below, let's make sure we don't keep dangling llme
pointers in mmctx (OS#3957). */
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15224
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ieab9b7696c93de9a5d3d42f614072a6f2181e37d
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in ...meta-telephony[201705]: libosmocore: Package osmo-config-merge
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/meta-telephony/+/15223
Change subject: libosmocore: Package osmo-config-merge
..
libosmocore: Package osmo-config-merge
Related: rt#27399
Change-Id: Iefab4ac2c37591413d384edc860427dd8fc64c83
---
M recipes-osmocom/libosmocore/libosmocore_git.bb
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/23/15223/1
diff --git a/recipes-osmocom/libosmocore/libosmocore_git.bb
b/recipes-osmocom/libosmocore/libosmocore_git.bb
index 3a417f0..f43f296 100644
--- a/recipes-osmocom/libosmocore/libosmocore_git.bb
+++ b/recipes-osmocom/libosmocore/libosmocore_git.bb
@@ -4,9 +4,9 @@
SRCREV = "c996d652f974f803653ce66d27d60675c1f77c2e"
SRC_URI = "git://git.osmocom.org/libosmocore.git;protocol=git;nobranch=1"
PV = "1.2.0+gitr${SRCPV}"
-PR = "${INC_PR}.0"
+PR = "${INC_PR}.1"
-PACKAGES =+ "libosmoctrl libosmocodec libosmogb libosmogsm libosmovty
osmo-arfcn osmo-auc-gen"
+PACKAGES =+ "libosmoctrl libosmocodec libosmogb libosmogsm libosmovty
osmo-arfcn osmo-auc-gen osmo-config-merge"
FILES_libosmoctrl = "${libdir}/libosmoctrl${SOLIBS}"
FILES_libosmocodec = "${libdir}/libosmocodec${SOLIBS}"
FILES_libosmogb = "${libdir}/libosmogb${SOLIBS}"
@@ -14,6 +14,7 @@
FILES_libosmovty = "${libdir}/libosmovty${SOLIBS}"
FILES_osmo-arfcn = "${bindir}/osmo-arfcn"
FILES_osmo-auc-gen = "${bindir}/osmo-auc-gen"
+FILES_osmo-config-merge = "${bindir}/osmo-config-merge"
# Requires fix for upgrades
RREPLACES_libosmocore = "DONOTREPLACElibosmocore"
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/15223
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: Iefab4ac2c37591413d384edc860427dd8fc64c83
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
Change in ...osmo-msc[master]: msc_a: switch RAN type back to SGs when a CSFB-Call is cleared
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15222 ) Change subject: msc_a: switch RAN type back to SGs when a CSFB-Call is cleared .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/15222/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15222/1//COMMIT_MSG@10 PS1, Line 10: cleared. However, at the moment the MSC will not change the "does not change" seems more clear, as in "prior to this patch". -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I104adecb0645b81b90ee230c57bf8b463c9e7045 Gerrit-Change-Number: 15222 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 13:24:51 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15221 ) Change subject: sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I625574fc42fc915ba483db3bb406922ad6df370d Gerrit-Change-Number: 15221 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 13:23:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: MSC_Tests: do not send an SGsAP-MO-CSFB-INDICATION when testing MT-Call
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15220 ) Change subject: MSC_Tests: do not send an SGsAP-MO-CSFB-INDICATION when testing MT-Call .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2e9fda4fe97866c4cbc77224ba1930ca81411fd6 Gerrit-Change-Number: 15220 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 13:22:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: msc_a: switch RAN type back to SGs when a CSFB-Call is cleared
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15222 Change subject: msc_a: switch RAN type back to SGs when a CSFB-Call is cleared .. msc_a: switch RAN type back to SGs when a CSFB-Call is cleared When a CSFB call is over the MS changes back to LTE after the call is cleared. However, at the moment the MSC will not change the cs.attached_via_ran flag. This may cause problems with the next call. Lets make sure that if there is an SGs association present, the ran type is set back to SGs when the call is cleared. Related: SYS#4624 Change-Id: I104adecb0645b81b90ee230c57bf8b463c9e7045 --- M src/libmsc/msc_a.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/22/15222/1 diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index bd69eed..553761f 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -754,6 +754,11 @@ }; msc_a_get(msc_a, MSC_A_USE_WAIT_CLEAR_COMPLETE); msc_a_ran_down(msc_a, MSC_ROLE_I, ); + + /* The connection is cleared. The MS will now go back to 4G, + Switch the RAN type back to SGS. */ + if (vsub && vsub->sgs_fsm->state == SGS_UE_ST_ASSOCIATED) + vsub->cs.attached_via_ran = OSMO_RAT_EUTRAN_SGS; } if (vsub) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I104adecb0645b81b90ee230c57bf8b463c9e7045 Gerrit-Change-Number: 15222 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
Change in ...osmo-msc[master]: sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/15221
Change subject: sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return
..
sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return
When the VLR/MSC receives an SGsAP-MO-CSFB-INDICATION message it sets
the RAN type back to SGs. This is wrong, the message
SGsAP-MO-CSFB-INDICATION has just an informative character. It informs
the VLR that the UE has initiated an MO CSFB call (service request).
Change-Id: I625574fc42fc915ba483db3bb406922ad6df370d
Related: SYS#4624
---
M src/libmsc/sgs_iface.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/21/15221/1
diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index 53ab853..b12991c 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -886,9 +886,10 @@
{
struct vlr_subscr *vsub;
- /* The MME informs us with this message that the UE has returned back
-* to the 4G network, so we use the SGs interface again for further
-* communication with the UE. */
+ /* The MME informs us with this message that the UE has initiated a
+* service request for MO CS fallback. There is not much we can do with
+* this information, however, we can check if the subscriber actually
+* exists in the VLR and if there are any lingering connections open.*/
vsub = vlr_subscr_find_by_imsi(gsm_network->vlr, imsi, __func__);
if (!vsub)
@@ -897,7 +898,6 @@
/* Check for lingering connections */
subscr_conn_toss(vsub);
- vsub->cs.attached_via_ran = OSMO_RAT_EUTRAN_SGS;
vlr_subscr_put(vsub, __func__);
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15221
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I625574fc42fc915ba483db3bb406922ad6df370d
Gerrit-Change-Number: 15221
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
Change in ...osmo-ttcn3-hacks[master]: MSC_Tests: do not send an SGsAP-MO-CSFB-INDICATION when testing MT-Call
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15220 Change subject: MSC_Tests: do not send an SGsAP-MO-CSFB-INDICATION when testing MT-Call .. MSC_Tests: do not send an SGsAP-MO-CSFB-INDICATION when testing MT-Call The TTCN3 tests MSC_Tests.TC_bssap_lu_sgsap_lu_and_mt_call and MSC_Tests.TC_sgsap_lu_and_mt_call initate an MT-CSFB call for testing purposes, but they also send an SGsAP-MO-CSFB-INDICATION to make the MS come back to LTE. This is wrong. SGsAP-MO-CSFB-INDICATION just informs the VLR that the UE has initiated a MO CSFB call on the LTE side. On MT CSFB calls this message should not appear. Lets remove it. Related: SYS#4624 Change-Id: I2e9fda4fe97866c4cbc77224ba1930ca81411fd6 --- M msc/MSC_Tests.ttcn 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/15220/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index c463dd5..7499456 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -4980,9 +4980,6 @@ /* Make sure that subscriber is still present and the SGs association is in tact (ref-counting) */ f_ctrl_get_exp(IPA_CTRL, "fsm.SGs-UE.id.imsi:" & hex2str(g_pars.imsi) & ".state", "SGs-ASSOCIATED"); - /* Finally simulate the return of the UE to the 4G network */ - SGsAP.send(ts_SGsAP_MO_CSFB_IND(pars.imsi)); - /* Test for successful return by triggering a paging, when the paging * request is received via SGs, we can be sure that the MSC/VLR has * recognized that the UE is now back on 4G */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2e9fda4fe97866c4cbc77224ba1930ca81411fd6 Gerrit-Change-Number: 15220 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
Change in ...osmo-sgsn[master]: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY
pespin has uploaded a new patch set (#2) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/12009 ) Change subject: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY .. gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY When a MS MM state is READY its exact location is known (PCU). On Gb, T3314 (aka TS 23.060 "READY timer") sets the MM state from READY to STANDBY, where only the RA is known. Introduce a second set of timer variables, because state timer can run while another packet state timer is timing out. Related: OS#1941 Change-Id: I4ce23ebe50d141076c20c9c56990b7103cd25e55 --- M include/osmocom/sgsn/gprs_sgsn.h M src/gprs/gprs_gmm.c M src/gprs/gprs_sgsn.c M src/gprs/sgsn_vty.c M tests/test_nodes.vty 5 files changed, 96 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/09/12009/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/12009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4ce23ebe50d141076c20c9c56990b7103cd25e55 Gerrit-Change-Number: 12009 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect in...
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15182 ) Change subject: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indication .. Patch Set 5: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420 Gerrit-Change-Number: 15182 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 12:30:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ggsn[master]: build: switch AC_CANONICAL_TARGET for AC_CANONICAL_HOST
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15219 ) Change subject: build: switch AC_CANONICAL_TARGET for AC_CANONICAL_HOST .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I6dc505888b42cfb686043470d3a3548c24cbe1f7 Gerrit-Change-Number: 15219 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 12:18:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ggsn[master]: build: switch AC_CANONICAL_TARGET for AC_CANONICAL_HOST
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15219 Change subject: build: switch AC_CANONICAL_TARGET for AC_CANONICAL_HOST .. build: switch AC_CANONICAL_TARGET for AC_CANONICAL_HOST $target/$target_os is never used, so AC_CANONICAL_TARGET is useless. $host is, so employ AC_CANONICAL_HOST. Change-Id: I6dc505888b42cfb686043470d3a3548c24cbe1f7 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/19/15219/1 diff --git a/configure.ac b/configure.ac index 4c39681..c8bfae9 100644 --- a/configure.ac +++ b/configure.ac @@ -7,7 +7,7 @@ AC_CONFIG_AUX_DIR([.]) AC_CONFIG_TESTDIR(tests) -AC_CANONICAL_TARGET +AC_CANONICAL_HOST dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I6dc505888b42cfb686043470d3a3548c24cbe1f7 Gerrit-Change-Number: 15219 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
Hello fixeria, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 to look at the new patch set (#3). Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported .. gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac --- M include/osmocom/sgsn/gprs_sgsn.h M src/gprs/sgsn_libgtp.c 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/84/15184/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac Gerrit-Change-Number: 15184 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: Replace own timer infra with libosmocore osmo_tdef
Hello fixeria, neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15214 to look at the new patch set (#2). Change subject: Replace own timer infra with libosmocore osmo_tdef .. Replace own timer infra with libosmocore osmo_tdef Change-Id: Ia0cf5f0a49737fbc419e2ccc86312d01c6e0056e --- M include/osmocom/sgsn/sgsn.h M src/gprs/gprs_gmm.c M src/gprs/gprs_gmm_attach.c M src/gprs/sgsn_vty.c 4 files changed, 127 insertions(+), 126 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/14/15214/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia0cf5f0a49737fbc419e2ccc86312d01c6e0056e Gerrit-Change-Number: 15214 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: gprs_gmm: Avoid spaces in fsm events and enum strings
Hello neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15212 to look at the new patch set (#2). Change subject: gprs_gmm: Avoid spaces in fsm events and enum strings .. gprs_gmm: Avoid spaces in fsm events and enum strings FSM doesn't expect receiving event names containing spaces (log lines generated are confusing). Similar for enums, it's better using code names to match easily and make log lines more clear. Change-Id: I16ede8bf8352b09bc772fd7b43fad2c2274b3ec1 --- M src/gprs/gprs_gmm.c M src/gprs/gprs_gmm_attach.c 2 files changed, 17 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/12/15212/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I16ede8bf8352b09bc772fd7b43fad2c2274b3ec1 Gerrit-Change-Number: 15212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: gprs_gmm.c: Call mmctx_set_(p)mm_state only on related ran_type
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15186 to look at the new patch set (#3). Change subject: gprs_gmm.c: Call mmctx_set_(p)mm_state only on related ran_type .. gprs_gmm.c: Call mmctx_set_(p)mm_state only on related ran_type For new readers it's very confusing why PMM states and MM states are in the same enum, but handled with different functions, and sometimes called one right after the other with different enums. Calling them when on a different ran_type makes the function early return, so let's better conditionally call the function to make it clear in the flow when the function is expected to do something. Change-Id: I65ad9e180177bc9fc7c4a037cd85cfe33b161f73 --- M src/gprs/gprs_gmm.c 1 file changed, 27 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/86/15186/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I65ad9e180177bc9fc7c4a037cd85cfe33b161f73 Gerrit-Change-Number: 15186 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: neels Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: Introduce and use log macros when no mm ctx available
Hello neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15211 to look at the new patch set (#2). Change subject: Introduce and use log macros when no mm ctx available .. Introduce and use log macros when no mm ctx available Change-Id: Iba22060d8646bc8ec6227684ccb91d98cb4c7be2 --- M include/osmocom/sgsn/gprs_llc.h M include/osmocom/sgsn/gprs_sgsn.h M src/gprs/gprs_gmm.c M src/gprs/gprs_llc.c 4 files changed, 46 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/11/15211/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iba22060d8646bc8ec6227684ccb91d98cb4c7be2 Gerrit-Change-Number: 15211 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: gprs_gmm: Introduce assert to guard against unexpected condition
Hello lynxis lazus, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15167 to look at the new patch set (#3). Change subject: gprs_gmm: Introduce assert to guard against unexpected condition .. gprs_gmm: Introduce assert to guard against unexpected condition This may well be the culprit of OS#3957, were already freed llme is accessed from mmctx context later on, upon some timer is triggered in mmctx. Related: OS#3957 Change-Id: I8e1eaeb9b3ebee8e45704b4fe007190c7db609e4 --- M src/gprs/gprs_gmm.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/67/15167/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8e1eaeb9b3ebee8e45704b4fe007190c7db609e4 Gerrit-Change-Number: 15167 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: tests: Verify that timers can be set over VTY
Hello fixeria, neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15213 to look at the new patch set (#2). Change subject: tests: Verify that timers can be set over VTY .. tests: Verify that timers can be set over VTY Change-Id: I486fc2a56e235a539836894d2042c1ca6e514ab9 --- M tests/vty_test_runner.py 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/13/15213/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I486fc2a56e235a539836894d2042c1ca6e514ab9 Gerrit-Change-Number: 15213 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 ) Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp .. Patch Set 5: See last comment: https://osmocom.org/issues/3956#note-12 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def Gerrit-Change-Number: 13929 Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-CC: neels Gerrit-Comment-Date: Thu, 15 Aug 2019 10:56:34 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 )
Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp
..
Patch Set 5: Code-Review-2
(1 comment)
https://gerrit.osmocom.org/#/c/13929/5/src/gprs/sgsn_libgtp.c
File src/gprs/sgsn_libgtp.c:
https://gerrit.osmocom.org/#/c/13929/5/src/gprs/sgsn_libgtp.c@549
PS5, Line 549: if (!pdp) {
That's for sure not the correct fix. It's fine receiving a null pdp, because we
anyway need to free the cbp stuff.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/13929
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def
Gerrit-Change-Number: 13929
Gerrit-PatchSet: 5
Gerrit-Owner: keith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-CC: fixeria
Gerrit-CC: laforge
Gerrit-CC: neels
Gerrit-Comment-Date: Thu, 15 Aug 2019 10:11:49 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Introduce and use log macros when no mm ctx available
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15211 ) Change subject: Introduce and use log macros when no mm ctx available .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iba22060d8646bc8ec6227684ccb91d98cb4c7be2 Gerrit-Change-Number: 15211 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 09:59:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gprs_gmm.c: Flag mmctx_set_(p)mm_state() functions static
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15185 ) Change subject: gprs_gmm.c: Flag mmctx_set_(p)mm_state() functions static .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I061144b6994ee40d5b32eb321dd4f3d3786d028d Gerrit-Change-Number: 15185 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 15 Aug 2019 09:56:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gprs_gmm.c: Use correct function to set MM_IDLE state during cleanup
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15183 ) Change subject: gprs_gmm.c: Use correct function to set MM_IDLE state during cleanup .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic6912269d0d69c86f19e57f3271ebda1328e968f Gerrit-Change-Number: 15183 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Thu, 15 Aug 2019 09:56:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 ) Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3b53a530ab25434e2b2f4d80ad70a8a5f22bfcac Gerrit-Change-Number: 15184 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 15 Aug 2019 09:56:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: start-testsuite.sh: Add commented-out section for using custom TITAN
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192 ) Change subject: start-testsuite.sh: Add commented-out section for using custom TITAN .. start-testsuite.sh: Add commented-out section for using custom TITAN Sometimes it's useful to test with a non-installed locally-compiled version of Eclipse TITAN. This adds an example on how to do that. Change-Id: I6a8c26becff868a3d2fcd3a01e2c03adfc748e0a --- M start-testsuite.sh 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/start-testsuite.sh b/start-testsuite.sh index 54332bb..e5bc756 100755 --- a/start-testsuite.sh +++ b/start-testsuite.sh @@ -36,8 +36,16 @@ TEST=$3 fi +# this is an example for using a non-installed custom (e.g. git master) TITAN +#TTCN3_DIR="/home/laforge/projects/git/titan/titan.core/Install" +#export TTCN3_DIR +#TITAN_LIBRARY_PATH="$TTCN3_DIR/lib" +#TTCN3_BIN_DIR="$TTCN3_DIR/bin" + +# below is for the debian packages +TTCN3_BIN_DIR="/usr/bin" TITAN_LIBRARY_PATH="/usr/lib/titan:/usr/ttcn3/lib" -LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$SUITE_DIR:$TITAN_LIBRARY_PATH" ttcn3_start $SUITE $CFG $TEST +LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$SUITE_DIR:$TITAN_LIBRARY_PATH" "$TTCN3_BIN_DIR/ttcn3_start" $SUITE $CFG $TEST expected="$SUITE_DIR/expected-results.xml" if [ ! -f "$expected" ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a8c26becff868a3d2fcd3a01e2c03adfc748e0a Gerrit-Change-Number: 15192 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in ...osmo-ttcn3-hacks[master]: library: Add S1AP Templates
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15195 )
Change subject: library: Add S1AP Templates
..
library: Add S1AP Templates
Change-Id: I148b33eb5074d3549e7cd533af2cbf90f1c6d23f
---
A library/s1ap/S1AP_Templates.ttcn
1 file changed, 907 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn
new file mode 100644
index 000..6c5dbce
--- /dev/null
+++ b/library/s1ap/S1AP_Templates.ttcn
@@ -0,0 +1,907 @@
+/* S1AP Templates in TTCN-3
+ * (C) 2019 Harald Welte
+ * All rights reserved.
+ *
+ * Released under the terms of GNU General Public License, Version 2 or
+ * (at your option) any later version.
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+module S1AP_Templates {
+
+import from S1AP_IEs all;
+import from S1AP_CommonDataTypes all;
+import from S1AP_Constants all;
+import from S1AP_Containers all;
+import from S1AP_PDU_Contents all;
+import from S1AP_PDU_Descriptions all;
+
+/*
+ * non-UE related
+
*/
+
+/*
+ * 9.1.8 Management Messages
+
*/
+
+/* 9.1.8.4 S1 SETUP REQUEST */
+template (value) S1AP_PDU
+ts_S1AP_SetupReq(template (value) Global_ENB_ID p_global_ENB_ID,
+template (value) SupportedTAs p_supportedTAs,
+template (value) PagingDRX p_pagingDRXs) := {
+ initiatingMessage := {
+ procedureCode := id_S1Setup,
+ criticality := reject,
+ value_ := {
+ S1SetupRequest := {
+ protocolIEs := {
+ {
+ id :=
S1AP_Constants.id_Global_ENB_ID,
+ criticality := ignore,
+ value_ := { Global_ENB_ID :=
p_global_ENB_ID }
+ }, {
+ id :=
S1AP_Constants.id_SupportedTAs,
+ criticality := reject,
+ value_ := {SupportedTAs :=
p_supportedTAs}
+ } /* HACK: work around nextepc bug
+ , {
+ id :=
S1AP_Constants.id_pagingDRX,
+ criticality := ignore,
+ value_ := {PagingDRX :=
p_pagingDRXs}
+ } */
+ }
+ }
+ }
+ }
+}
+template (present) S1AP_PDU
+tr_S1AP_SetupReq(template (present) Global_ENB_ID p_global_ENB_ID := ?,
+template (present) SupportedTAs p_supportedTAs := ?,
+template (present) PagingDRX p_pagingDRXs := ?) := {
+ initiatingMessage := {
+ procedureCode := id_S1Setup,
+ criticality := reject,
+ value_ := {
+ S1SetupRequest := {
+ protocolIEs := {
+ {
+ id :=
S1AP_Constants.id_Global_ENB_ID,
+ criticality := ignore,
+ value_ := { Global_ENB_ID :=
p_global_ENB_ID }
+ }, {
+ id :=
S1AP_Constants.id_SupportedTAs,
+ criticality := reject,
+ value_ := {SupportedTAs :=
p_supportedTAs}
+ }, *
+ }
+ }
+ }
+ }
+}
+
+/* 9.1.8.5 S1 SETUP RESPONSE */
+template (value) S1AP_PDU
+ts_S1AP_SetupResp(template (value) ServedGUMMEIs served_gummeis,
+ template (value) RelativeMMECapacity rel_mme_capacity) := {
+ successfulOutcome := {
+ procedureCode := id_S1Setup,
+ criticality := reject,
+ value_ := {
+ S1SetupResponse := {
+ protocolIEs := {
+ {
+ id :=
S1AP_Constants.id_ServedGUMMEIs,
+ criticality := reject,
+
Change in ...osmo-ttcn3-hacks[master]: mme: initial skeleton for MME / SGsAP tetss
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15193 )
Change subject: mme: initial skeleton for MME / SGsAP tetss
..
mme: initial skeleton for MME / SGsAP tetss
Change-Id: Idbd54838daaf12a3253dc4278de75eaaaf31
---
M library/SGsAP_Emulation.ttcn
A mme/MME_Tests.ttcn
A mme/MME_Tests_SGsAP.ttcn
A mme/gen_links.sh
A mme/regen_makefile.sh
5 files changed, 385 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/SGsAP_Emulation.ttcn b/library/SGsAP_Emulation.ttcn
index f91e076..6cd1052 100644
--- a/library/SGsAP_Emulation.ttcn
+++ b/library/SGsAP_Emulation.ttcn
@@ -47,6 +47,12 @@
inout PDU_SGsAP, PDU_ML3_MS_NW, PDU_ML3_NW_MS;
} with { extension "internal" };
+/* global test port e.g. for non-imsi/conn specific messages */
+type port SGsAP_PT message {
+ inout PDU_SGsAP;
+} with { extension "internal" };
+
+
/* represents a single SGsAP Association */
type record AssociationData {
SGsAP_ConnHdlr comp_ref,
@@ -66,6 +72,8 @@
var ExpectData SgsapExpectTable[8];
/* procedure based port to register for incoming connections */
port SGsAPEM_PROC_PT SGsAP_PROC;
+ /* test port for unit data messages */
+ port SGsAP_PT SGsAP_UNIT;
var charstring g_sgsap_id;
var integer g_sgsap_conn_id := -1;
diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn
new file mode 100644
index 000..3ba0677
--- /dev/null
+++ b/mme/MME_Tests.ttcn
@@ -0,0 +1,118 @@
+/* MME (Mobility Management Engine) test suite in TTCN-3
+ * (C) 2019 Harald Welte
+ * All rights reserved.
+ *
+ * Released under the terms of GNU General Public License, Version 2 or
+ * (at your option) any later version.
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+module MME_Tests {
+
+import from SGsAP_Types all;
+import from SGsAP_Templates all;
+import from SGsAP_Emulation all;
+
+import from L3_Templates all;
+import from DNS_Helpers all;
+
+friend module MME_Tests_SGsAP;
+
+type component MTC_CT {
+ var SGsAP_Emulation_CT vc_SGsAP;
+ port SGsAP_PT SGsAP_UNIT;
+ port SGsAPEM_PROC_PT SGsAP_PROC;
+}
+
+type component ConnHdlr extends SGsAP_ConnHdlr {
+ var ConnHdlrPars g_pars;
+ timer g_Tguard := 30.0;
+}
+
+type record ConnHdlrPars {
+ hexstring imsi
+}
+
+modulepar {
+ charstring mp_sgs_local_ip := "127.0.0.1";
+ integer mp_sgs_local_port := 29118;
+ charstring mp_vlr_name := "vlr.example.net";
+ charstring mp_mme_name :=
"mmec01.mmegi0001.mme.epc.mnc070.mcc901.3gppnetwork.org";
+}
+
+/* send incoming unit data messages (like reset) to global SGsAP_UNIT port */
+friend function ForwardUnitdataCallback(PDU_SGsAP msg)
+runs on SGsAP_Emulation_CT return template PDU_SGsAP {
+ SGsAP_UNIT.send(msg);
+ return omit;
+}
+
+friend function f_init_sgsap(charstring id) runs on MTC_CT {
+ id := id & "-SGsAP";
+ var SGsAPOps ops := {
+ create_cb := refers(SGsAP_Emulation.ExpectedCreateCallback),
+ unitdata_cb := refers(ForwardUnitdataCallback)
+ }
+ var SGsAP_conn_parameters pars := {
+ remote_ip := "",
+ remote_sctp_port := -1,
+ local_ip := mp_sgs_local_ip,
+ local_sctp_port := mp_sgs_local_port
+ }
+
+ vc_SGsAP := SGsAP_Emulation_CT.create(id);
+ map(vc_SGsAP:SGsAP, system:SGsAP_CODEC_PT);
+ connect(vc_SGsAP:SGsAP_PROC, self:SGsAP_PROC);
+ connect(vc_SGsAP:SGsAP_UNIT, self:SGsAP_UNIT);
+ vc_SGsAP.start(SGsAP_Emulation.main(ops, pars, id));
+}
+
+/* generate parameters for a connection handler */
+friend function f_init_pars(integer imsi_suffix)
+runs on MTC_CT return ConnHdlrPars {
+ var ConnHdlrPars pars := {
+ imsi := f_gen_imsi(imsi_suffix)
+ };
+ return pars;
+}
+
+type function void_fn(ConnHdlrPars pars) runs on ConnHdlr;
+
+/* start a connection handler with given parameters */
+friend function f_start_handler_with_pars(void_fn fn, ConnHdlrPars pars,
integer s1ap_idx := 0)
+runs on MTC_CT return ConnHdlr {
+ var ConnHdlr vc_conn;
+ var charstring id := testcasename() & int2str(s1ap_idx);
+
+ vc_conn := ConnHdlr.create(id);
+ /* SGsAP part */
+ connect(vc_conn:SGsAP, vc_SGsAP:SGsAP_CLIENT);
+ connect(vc_conn:SGsAP_PROC, vc_SGsAP:SGsAP_PROC);
+
+ /* We cannot use vc_conn.start(f_init_handler(fn, id, pars)); as we
cannot have
+* a stand-alone 'derefers()' call, see
https://www.eclipse.org/forums/index.php/t/1091364/ */
+ vc_conn.start(derefers(fn)(pars));
+ return vc_conn;
+}
+
+/* altstep for the global guard timer */
+private altstep as_Tguard()runs on ConnHdlr {
+ [] g_Tguard.timeout {
+ setverdict(fail, "Tguard timeout");
+ mtc.stop;
+
Change in ...osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 ) Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/13929/5/src/gprs/sgsn_libgtp.c File src/gprs/sgsn_libgtp.c: https://gerrit.osmocom.org/#/c/13929/5/src/gprs/sgsn_libgtp.c@543 PS5, Line 543: struct sgsn_pdp_ctx *pctx = cbp; > I wish I knew why there's a pdp_t *and* a separate sgsn_pdp_ctx because the 'pdp_t' represents a libgtp library data structure and the sgsn_pdp_ctx is the data structure of the application. You cannot expect the library to contain all the application-layer context or vice-versa... -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def Gerrit-Change-Number: 13929 Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-CC: neels Gerrit-Comment-Date: Thu, 15 Aug 2019 09:47:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Replace own timer infra with libosmocore osmo_tdef
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/15214 )
Change subject: Replace own timer infra with libosmocore osmo_tdef
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/15214/1/src/gprs/gprs_gmm_attach.c
File src/gprs/gprs_gmm_attach.c:
https://gerrit.osmocom.org/#/c/15214/1/src/gprs/gprs_gmm_attach.c@15
PS1, Line 15: static const struct osmo_tdef_state_timeout
gmm_attach_fsm_timeouts[] = {
> -1: you *have* to explicitly use an array size of [32] to be safe. […]
Would be great having a define for that ;)
I actually looked in the doc while writing the patch because I saw some code
with the 32 in there, but I didn't find it :(
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15214
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia0cf5f0a49737fbc419e2ccc86312d01c6e0056e
Gerrit-Change-Number: 15214
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Thu, 15 Aug 2019 09:35:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
Gerrit-MessageType: comment
Change in ...libosmocore[master]: osmo_tdef_get(): allow passing -1 as default timeout
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15218 ) Change subject: osmo_tdef_get(): allow passing -1 as default timeout .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie61c3c85069916336e6dbd91a2c16f7634816417 Gerrit-Change-Number: 15218 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 09:33:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gprs_gmm: Avoid spaces in fsm events and enum strings
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/15212 )
Change subject: gprs_gmm: Avoid spaces in fsm events and enum strings
..
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm.c
File src/gprs/gprs_gmm.c:
https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm.c@110
PS1, Line 110: { PMM_DETACHED, "PMM_DETACH" },
> maybe while at it fix to "PMM_DETACHED" (or what Vadim said)
I'll use OSMO_VALUE_STRING, thanks.
https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm_attach.c
File src/gprs/gprs_gmm_attach.c:
https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm_attach.c@328
PS1, Line 328: { E_VLR_ANSWERED, "VLR_ANSWERED"},
> (this could also use OSMO_VALUE_STRING(); IMHO it's an advantage to print
> exactly the event names as […]
ACK
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15212
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I16ede8bf8352b09bc772fd7b43fad2c2274b3ec1
Gerrit-Change-Number: 15212
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-CC: fixeria
Gerrit-Comment-Date: Thu, 15 Aug 2019 09:30:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Introduce and use log macros when no mm ctx available
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15211 ) Change subject: Introduce and use log macros when no mm ctx available .. Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/15211/1/include/osmocom/sgsn/gprs_sgsn.h File include/osmocom/sgsn/gprs_sgsn.h: https://gerrit.osmocom.org/#/c/15211/1/include/osmocom/sgsn/gprs_sgsn.h@264 PS1, Line 264: #define LOGIUP(level, ue, fmt, args...) \ > (cosmetic) […] Yes I also noticed that. Fine, I'll try to change the order for new macros. https://gerrit.osmocom.org/#/c/15211/1/include/osmocom/sgsn/gprs_sgsn.h@284 PS1, Line 284: > (in osmo-msc and -bsc I named the logging macros more like LOG_HO and > LOG_MSC_A, for readability. […] That depends on the project. I still to currently used one here, and it takes less space too. https://gerrit.osmocom.org/#/c/15211/1/src/gprs/gprs_gmm.c File src/gprs/gprs_gmm.c: https://gerrit.osmocom.org/#/c/15211/1/src/gprs/gprs_gmm.c@185 PS1, Line 185: LOGIUP(LOGL_NOTICE, ctx, "Cannot find mm ctx for IU event %d\n", type); \ > (we have a value string for those events, see ranap_iu_event_type_str() from > iu_client. […] Probably deserves a different patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iba22060d8646bc8ec6227684ccb91d98cb4c7be2 Gerrit-Change-Number: 15211 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 15 Aug 2019 09:29:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gprs_gmm: Introduce assert to guard against unexpected condition
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15167 ) Change subject: gprs_gmm: Introduce assert to guard against unexpected condition .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15167/2/src/gprs/gprs_gmm.c File src/gprs/gprs_gmm.c: https://gerrit.osmocom.org/#/c/15167/2/src/gprs/gprs_gmm.c@1747 PS2, Line 1747: mmctx->ran_type == MM_CTX_T_GERAN_Gb > I'm also confused. […] This is an assert I add to try to catch keith's osmo-sgsn isntance crashing (we started debugging it in OsmoDevCon). I don't want to directly workaround the issue, I really want osmo-sgsn to assert and exit in this situation, so we can make sure this is the condition he's hitting. Since lots of subscribers are using the sgsn at that time, it's impossible otherwise to find out. Killing osmo-sgsn here is not a big issue since anyway it would crash later on due to the bug we spotted. Regarding the assert condition: If ran_type is MM_CTX_T_UTRAN_Iu, it's perfectly fine to have a null llme, so I really want to check in the Gb case (because anyway that's what's deployed in the setup where we saw the crash). I want to make sure that "it doesn't happen that llme is NULL when on Gb", and the condition expresses so. The expression I'm using is exactly the same you are proposing. But Ok, I'll change it if you think it's simpler. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8e1eaeb9b3ebee8e45704b4fe007190c7db609e4 Gerrit-Change-Number: 15167 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 15 Aug 2019 09:16:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 12: (1 comment) https://gerrit.osmocom.org/#/c/15120/12/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/15120/12/src/libmsc/msc_vty.c@296 PS12, Line 296: call-waiting > BTW: if I am not mistaken, in commercial networks this parameter is stored in > the HLR, for each subs […] +1 :) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 12 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 15 Aug 2019 07:49:06 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 12: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/15120/12/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/15120/12/src/libmsc/msc_vty.c@296 PS12, Line 296: call-waiting BTW: if I am not mistaken, in commercial networks this parameter is stored in the HLR, for each subscriber individually. Subscribers can manage Call Waiting using special SS (Supplementary Services) commands: *#43# - check the service activation status, *43# - activate Call Waiting, #43# - deactivate. I am fine with having this parameter here, but some day we would need to have a proper SS support ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 12 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 15 Aug 2019 07:42:57 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmocore[master]: add vty logp command to echo on all log targets
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14986 ) Change subject: add vty logp command to echo on all log targets .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ife5dc8999174c74e0d133729284fe526d6eaf8d9 Gerrit-Change-Number: 14986 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 15 Aug 2019 07:03:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmocore[master]: osmo_tdef_get(): allow passing -1 as default timeout
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15218 ) Change subject: osmo_tdef_get(): allow passing -1 as default timeout .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/15218/2/src/tdef.c File src/tdef.c: https://gerrit.osmocom.org/#/c/15218/2/src/tdef.c@186 PS2, Line 186: osmo_tdef_get Alternatively, you could add another function without that optional parameter, so it would simply crash the process if (t == NULL), while this function would always return the val_if_not_present. Just an idea. The current approach also looks good. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie61c3c85069916336e6dbd91a2c16f7634816417 Gerrit-Change-Number: 15218 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 15 Aug 2019 07:00:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
