Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 394s] ar: `u' modifier ignored since `D' is the default (see `U') [ 394s] libtool: link: ranlib .libs/libtransceiver_common.a [ 394s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 394s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 394s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 394s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 394s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 394s] collect2: error: ld returned 1 exit status [ 394s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 394s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 394s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 394s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 394s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 394s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 394s] make[1]: *** [Makefile:444: all] Error 2 [ 394s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 394s] dh_auto_build: make -j1 returned exit code 2 [ 394s] make: *** [debian/rules:6: build] Error 255 [ 394s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 394s] [ 394s] lamb17 failed "build osmo-trx_1.1.1.dsc" at Thu Aug 22 03:55:33 UTC 2019. [ 394s] [ 394s] ### VM INTERACTION START ### [ 397s] [ 379.431231] sysrq: SysRq : Power Off [ 397s] [ 379.440660] reboot: Power down [ 397s] ### VM INTERACTION END ### [ 397s] [ 397s] lamb17 failed "build osmo-trx_1.1.1.dsc" at Thu Aug 22 03:55:35 UTC 2019. [ 397s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 253s] ar: `u' modifier ignored since `D' is the default (see `U') [ 253s] libtool: link: ranlib .libs/libtransceiver_common.a [ 253s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 253s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 254s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 254s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 254s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 254s] collect2: error: ld returned 1 exit status [ 254s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 254s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 254s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 254s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 254s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 254s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 254s] make[1]: *** [Makefile:444: all] Error 2 [ 254s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 254s] dh_auto_build: make -j1 returned exit code 2 [ 254s] make: *** [debian/rules:6: build] Error 255 [ 254s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 254s] [ 254s] build84 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Thu Aug 22 03:53:33 UTC 2019. [ 254s] [ 254s] ### VM INTERACTION START ### [ 257s] [ 244.902740] sysrq: SysRq : Power Off [ 257s] [ 244.904730] reboot: Power down [ 257s] ### VM INTERACTION END ### [ 257s] [ 257s] build84 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Thu Aug 22 03:53:36 UTC 2019. [ 257s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 396s] ar: `u' modifier ignored since `D' is the default (see `U') [ 396s] libtool: link: ranlib .libs/libtransceiver_common.a [ 396s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 396s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 397s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 397s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 397s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 397s] collect2: error: ld returned 1 exit status [ 397s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 397s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 397s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 397s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 397s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 397s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 397s] make[1]: *** [Makefile:444: all] Error 2 [ 397s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 397s] dh_auto_build: make -j1 returned exit code 2 [ 397s] make: *** [debian/rules:6: build] Error 255 [ 397s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 397s] [ 397s] lamb17 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Thu Aug 22 01:45:01 UTC 2019. [ 397s] [ 397s] ### VM INTERACTION START ### [ 400s] [ 381.761690] sysrq: SysRq : Power Off [ 400s] [ 381.769739] reboot: Power down [ 400s] ### VM INTERACTION END ### [ 400s] [ 400s] lamb17 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Thu Aug 22 01:45:04 UTC 2019. [ 400s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 394s] ar: `u' modifier ignored since `D' is the default (see `U') [ 394s] libtool: link: ranlib .libs/libtransceiver_common.a [ 394s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 394s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 394s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 394s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 394s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 394s] collect2: error: ld returned 1 exit status [ 394s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 394s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 394s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 394s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 394s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 394s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 394s] make[1]: *** [Makefile:444: all] Error 2 [ 394s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 394s] dh_auto_build: make -j1 returned exit code 2 [ 394s] make: *** [debian/rules:6: build] Error 255 [ 394s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 395s] [ 395s] lamb05 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Thu Aug 22 01:44:09 UTC 2019. [ 395s] [ 395s] ### VM INTERACTION START ### [ 398s] [ 380.302326] sysrq: SysRq : Power Off [ 398s] [ 380.310297] reboot: Power down [ 398s] ### VM INTERACTION END ### [ 398s] [ 398s] lamb05 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Thu Aug 22 01:44:13 UTC 2019. [ 398s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 226s] ar: `u' modifier ignored since `D' is the default (see `U') [ 226s] libtool: link: ranlib .libs/libtransceiver_common.a [ 226s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 226s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 226s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 226s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 226s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 226s] collect2: error: ld returned 1 exit status [ 226s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 226s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 226s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 226s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 226s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 226s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 226s] make[1]: *** [Makefile:444: all] Error 2 [ 226s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 226s] dh_auto_build: make -j1 returned exit code 2 [ 226s] make: *** [debian/rules:6: build] Error 255 [ 226s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 226s] [ 226s] build79 failed "build osmo-trx_1.1.1.dsc" at Wed Aug 21 23:40:02 UTC 2019. [ 226s] [ 226s] ### VM INTERACTION START ### [ 229s] [ 217.738136] sysrq: SysRq : Power Off [ 229s] [ 217.739790] reboot: Power down [ 229s] ### VM INTERACTION END ### [ 229s] [ 229s] build79 failed "build osmo-trx_1.1.1.dsc" at Wed Aug 21 23:40:05 UTC 2019. [ 229s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 398s] ar: `u' modifier ignored since `D' is the default (see `U') [ 398s] libtool: link: ranlib .libs/libtransceiver_common.a [ 398s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 398s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 399s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 399s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 399s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 399s] collect2: error: ld returned 1 exit status [ 399s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 399s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 399s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 399s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 399s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 399s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 399s] make[1]: *** [Makefile:444: all] Error 2 [ 399s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 399s] dh_auto_build: make -j1 returned exit code 2 [ 399s] make: *** [debian/rules:6: build] Error 255 [ 399s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 399s] [ 399s] lamb07 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Wed Aug 21 23:38:43 UTC 2019. [ 399s] [ 399s] ### VM INTERACTION START ### [ 402s] [ 384.721553] sysrq: SysRq : Power Off [ 402s] [ 384.728767] reboot: Power down [ 402s] ### VM INTERACTION END ### [ 402s] [ 402s] lamb07 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Wed Aug 21 23:38:46 UTC 2019. [ 402s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64
Package network:osmocom:latest/osmo-gsm-manuals failed to build in
Debian_Unstable/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest osmo-gsm-manuals
Last lines of build log:
[ 299s] asciidoc: control_if.adoc: line 115: evaluating:
{set2:target:test-usermanual__53.png}
[ 299s] asciidoc: control_if.adoc: line 121: filtering: "/usr/bin/python2"
"./build/filter-wrapper.py" mscgen -o
"/usr/src/packages/BUILD/tests/test-usermanual__53.png" -Tpng -
[ 299s] asciidoc: control_if.adoc: line 131: evaluating:
{counter2:target-number}
[ 299s] asciidoc: control_if.adoc: line 131: evaluating:
{set2:target:test-usermanual__54.png}
[ 299s] asciidoc: control_if.adoc: line 136: filtering: "/usr/bin/python2"
"./build/filter-wrapper.py" mscgen -o
"/usr/src/packages/BUILD/tests/test-usermanual__54.png" -Tpng -
[ 299s] asciidoc: include: /usr/src/packages/BUILD/common/chapters/abis.adoc
[ 299s] asciidoc: test-usermanual.adoc: line 31: reading:
/usr/src/packages/BUILD/common/chapters/abis.adoc
[ 299s] asciidoc: include:
/usr/src/packages/BUILD/common/chapters/spectrum.adoc
[ 299s] asciidoc: test-usermanual.adoc: line 32: reading:
/usr/src/packages/BUILD/common/chapters/spectrum.adoc
[ 299s]
[ 299s] make[3]: *** [../build/Makefile.asciidoc.inc:69: test-usermanual.pdf]
Error 1
[ 299s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[ 299s] make[2]: *** [Makefile:438: all-recursive] Error 1
[ 299s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 299s] make[1]: *** [Makefile:362: all] Error 2
[ 299s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 299s] dh_auto_build: make -j1 returned exit code 2
[ 299s] make: *** [debian/rules:5: binary] Error 255
[ 299s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess
returned exit status 2
[ 299s]
[ 299s] lamb62 failed "build osmo-gsm-manuals-dev_0.2.0.dsc" at Wed Aug 21
23:30:34 UTC 2019.
[ 299s]
[ 299s] ### VM INTERACTION START ###
[ 302s] [ 285.895177] sysrq: SysRq : Power Off
[ 302s] [ 285.904283] reboot: Power down
[ 303s] ### VM INTERACTION END ###
[ 303s]
[ 303s] lamb62 failed "build osmo-gsm-manuals-dev_0.2.0.dsc" at Wed Aug 21
23:30:38 UTC 2019.
[ 303s]
--
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 844s] ar: `u' modifier ignored since `D' is the default (see `U') [ 844s] libtool: link: ranlib .libs/libtransceiver_common.a [ 844s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 844s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 845s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 845s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 845s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 845s] collect2: error: ld returned 1 exit status [ 845s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 845s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 845s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 845s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 845s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 845s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 845s] make[1]: *** [Makefile:444: all] Error 2 [ 845s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 845s] dh_auto_build: make -j1 returned exit code 2 [ 845s] make: *** [debian/rules:6: build] Error 255 [ 845s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 845s] [ 845s] cloud123 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Wed Aug 21 22:34:11 UTC 2019. [ 845s] [ 845s] ### VM INTERACTION START ### [ 849s] [ 740.053224] sysrq: SysRq : Power Off [ 849s] [ 740.090192] reboot: Power down [ 850s] ### VM INTERACTION END ### [ 850s] [ 850s] cloud123 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Wed Aug 21 22:34:17 UTC 2019. [ 850s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 515s] ar: `u' modifier ignored since `D' is the default (see `U') [ 515s] libtool: link: ranlib .libs/libtransceiver_common.a [ 515s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 515s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 515s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 516s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 516s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 516s] collect2: error: ld returned 1 exit status [ 516s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 516s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 516s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 516s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 516s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 516s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 516s] make[1]: *** [Makefile:444: all] Error 2 [ 516s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 516s] dh_auto_build: make -j1 returned exit code 2 [ 516s] make: *** [debian/rules:6: build] Error 255 [ 516s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 516s] [ 516s] build34 failed "build osmo-trx_1.1.1.dsc" at Wed Aug 21 22:26:44 UTC 2019. [ 516s] [ 516s] ### VM INTERACTION START ### [ 519s] [ 494.229093] sysrq: SysRq : Power Off [ 519s] [ 494.232653] reboot: Power down [ 520s] ### VM INTERACTION END ### [ 520s] [ 520s] build34 failed "build osmo-trx_1.1.1.dsc" at Wed Aug 21 22:26:49 UTC 2019. [ 520s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...osmo-mgw[master]: fix crashes: don't assert on incoming RTP packet size
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/15242 to look at the new patch set (#3). Change subject: fix crashes: don't assert on incoming RTP packet size .. fix crashes: don't assert on incoming RTP packet size Remove various OSMO_ASSERT() on size of incoming packets. Doing an assert on incoming data is a DoS attack vector, absolute no-go. Instead, return -EINVAL and keep running. Change some return values to be able to distinguish successful operation from invalid RTP sizes. In rtp_data_net(), make sure to return negative if the RTP packet was invalid. Some of the error return codes implemented here will only be used in upcoming patch Iba115a0b1d74e7cefba5dcdd777e98ddea9eba8c. Change-Id: I6bc6ee950ce07bcc2c585c30fad02b81153bdde2 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 32 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/42/15242/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc6ee950ce07bcc2c585c30fad02b81153bdde2 Gerrit-Change-Number: 15242 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-mgw[master]: fix crashes: don't assert on incoming RTP packet size
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15242 ) Change subject: fix crashes: don't assert on incoming RTP packet size .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/15242/2/src/libosmo-mgcp/mgcp_network.c File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/#/c/15242/2/src/libosmo-mgcp/mgcp_network.c@752 PS2, Line 752: static int amr_oa_check(char *data, int len) > non-related. […] if you return true or false, it always says whether octet-aligned is on or off. I need a third value saying that the RTP header was invalid, so ... should add an api doc https://gerrit.osmocom.org/#/c/15242/2/src/libosmo-mgcp/mgcp_network.c@1363 PS2, Line 1363: if (((bool)oa) != conn_src->end.codec->param.amr_octet_aligned) > non-related change. it is related: instead of asserting on invalid header size, I need to handle that error by returning -1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc6ee950ce07bcc2c585c30fad02b81153bdde2 Gerrit-Change-Number: 15242 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 20:49:36 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...libosmocore[master]: fix: vty crash by logging to killed telnet session
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/15265
Change subject: fix: vty crash by logging to killed telnet session
..
fix: vty crash by logging to killed telnet session
When a telnet session dies (e.g. killall telnet) and also has logging enabled,
the closing of the telnet session logs to the killed telnet session and
segfaults: the vty->obuf is already NULL.
In vty_out(), guard against this situation by not composing an output if
vty->obuf is NULL.
Also guard all buffer_*() functions against a NULL buffer argument, which
should catch all other hypothetical code paths trying to add to a closed
vty->obuf.
Related: OS#4164
Change-Id: Idca3f54dc986abf6784790c12e69e02bdf77cb41
---
M src/vty/buffer.c
M src/vty/vty.c
2 files changed, 35 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/15265/1
diff --git a/src/vty/buffer.c b/src/vty/buffer.c
index e68e3a2..486aafb 100644
--- a/src/vty/buffer.c
+++ b/src/vty/buffer.c
@@ -92,6 +92,8 @@
/* Free buffer. */
void buffer_free(struct buffer *b)
{
+ if (!b)
+ return;
buffer_reset(b);
talloc_free(b);
}
@@ -104,6 +106,9 @@
char *s;
char *p;
+ if (!b)
+ return NULL;
+
for (data = b->head; data; data = data->next)
totlen += data->cp - data->sp;
if (!(s = _talloc_zero(tall_vty_ctx, (totlen + 1), "buffer_getstr")))
@@ -120,7 +125,7 @@
/* Return 1 if buffer is empty. */
int buffer_empty(struct buffer *b)
{
- return (b->head == NULL);
+ return (!b || b->head == NULL);
}
/* Clear and free all allocated data. */
@@ -129,6 +134,9 @@
struct buffer_data *data;
struct buffer_data *next;
+ if (!b)
+ return;
+
for (data = b->head; data; data = next) {
next = data->next;
BUFFER_DATA_FREE(data);
@@ -141,6 +149,9 @@
{
struct buffer_data *d;
+ if (!b)
+ return NULL;
+
d = _talloc_zero(b,
offsetof(struct buffer_data, data[b->size]),
"buffer_add");
@@ -161,9 +172,14 @@
/* Write data to buffer. */
void buffer_put(struct buffer *b, const void *p, size_t size)
{
- struct buffer_data *data = b->tail;
+ struct buffer_data *data;
const char *ptr = p;
+ if (!b)
+ return;
+
+ data = b->tail;
+
/* We use even last one byte of data buffer. */
while (size) {
size_t chunk;
@@ -185,12 +201,16 @@
/* Insert character into the buffer. */
void buffer_putc(struct buffer *b, unsigned char c)
{
+ if (!b)
+ return;
buffer_put(b, , 1);
}
/* Put string to the buffer. */
void buffer_putstr(struct buffer *b, const char *c)
{
+ if (!b)
+ return;
buffer_put(b, c, strlen(c));
}
@@ -202,7 +222,7 @@
struct buffer_data *head;
size_t head_sp;
- if (!b->head)
+ if (!b || !b->head)
return BUFFER_EMPTY;
head_sp = (head = b->head)->sp;
/* Flush all data. */
@@ -395,6 +415,9 @@
size_t iovcnt = 0;
size_t nbyte = 0;
+ if (!b)
+ return BUFFER_EMPTY;
+
for (d = b->head; d && (iovcnt < MAX_CHUNKS) && (nbyte < MAX_FLUSH);
d = d->next, iovcnt++) {
iov[iovcnt].iov_base = d->data + d->sp;
@@ -440,6 +463,8 @@
{
ssize_t nbytes;
+ if (!b)
+ return BUFFER_ERROR;
#if 0
/* Should we attempt to drain any previously buffered data? This could
help reduce latency in pushing out the data if we are stuck in a long-running
thread that is preventing the main select loop from calling the flush thread...
*/
diff --git a/src/vty/vty.c b/src/vty/vty.c
index a96d86c..27e35fe 100644
--- a/src/vty/vty.c
+++ b/src/vty/vty.c
@@ -260,6 +260,13 @@
vprintf(format, ap);
} else {
va_list args;
+
+ if (!vty->obuf) {
+ /* There is no output buffer. This can happen from
logging to a telnet session, during cleanup
+* of this same (killed) telnet session. See OS#4146. */
+ return 0;
+ }
+
/* Try to write to initial buffer. */
va_copy(args, ap);
len = vsnprintf(buf, sizeof buf, format, args);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15265
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idca3f54dc986abf6784790c12e69e02bdf77cb41
Gerrit-Change-Number: 15265
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in ...osmo-sgsn[master]: gprs_gmm.c: Print value_string of reject cause
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15263 Change subject: gprs_gmm.c: Print value_string of reject cause .. gprs_gmm.c: Print value_string of reject cause Change-Id: I71d9abcf7e3a836c475b7adbb95a82580e41ae6d --- M src/gprs/gprs_gmm.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/63/15263/1 diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c index dccec2b..1d8ec57 100644 --- a/src/gprs/gprs_gmm.c +++ b/src/gprs/gprs_gmm.c @@ -2455,7 +2455,8 @@ struct gsm48_hdr *gh; uint8_t transaction_id = tid ^ 0x8; /* flip */ - LOGMMCTXP(LOGL_NOTICE, mm, "<- ACTIVATE PDP CONTEXT REJ(cause=%u)\n", cause); + LOGMMCTXP(LOGL_NOTICE, mm, "<- ACTIVATE PDP CONTEXT REJ: %s\n", + get_value_string(gsm48_gsm_cause_names, cause)); rate_ctr_inc(>rate_ctrs->ctr[CTR_PDP_ACTIVATE_REJECT]); mmctx2msgid(msg, mm); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I71d9abcf7e3a836c475b7adbb95a82580e41ae6d Gerrit-Change-Number: 15263 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in ...osmo-sgsn[master]: gprs_gmm.c: Add spec document to function documentation
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/15264
Change subject: gprs_gmm.c: Add spec document to function documentation
..
gprs_gmm.c: Add spec document to function documentation
Change-Id: Ibb89499e9c1ab588336df34fde26faf3fbf2c72c
---
M src/gprs/gprs_gmm.c
1 file changed, 16 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/64/15264/1
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index 1d8ec57..e44b3ec 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -674,7 +674,7 @@
return false;
}
-/* 3GPP TS 24.008 Section 9.4.9: Authentication and Ciphering Request */
+/* 3GPP TS 24.008 § 9.4.9: Authentication and Ciphering Request */
int gsm48_tx_gmm_auth_ciph_req(struct sgsn_mm_ctx *mm,
const struct osmo_auth_vector *vec,
uint8_t key_seq, bool force_standby)
@@ -742,7 +742,7 @@
return gsm48_gmm_sendmsg(msg, 1, mm, false);
}
-/* Section 9.4.11: Authentication and Ciphering Reject */
+/* 3GPP TS 24.008 § 9.4.11: Authentication and Ciphering Reject */
static int gsm48_tx_gmm_auth_ciph_rej(struct sgsn_mm_ctx *mm)
{
struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 AUTH CIPH REJ");
@@ -815,7 +815,7 @@
return OSMO_AUTH_TYPE_NONE;
}
-/* Section 9.4.10: Authentication and Ciphering Response */
+/* 3GPP TS 24.008 § 9.4.10: Authentication and Ciphering Response */
static int gsm48_rx_gmm_auth_ciph_resp(struct sgsn_mm_ctx *ctx,
struct msgb *msg)
{
@@ -892,7 +892,7 @@
return osmo_fsm_inst_dispatch(ctx->gmm_att_req.fsm,
E_AUTH_RESP_RECV_SUCCESS, NULL);
}
-/* Section 9.4.10: Authentication and Ciphering Failure */
+/* 3GPP TS 24.008 § 9.4.10: Authentication and Ciphering Failure */
static int gsm48_rx_gmm_auth_ciph_fail(struct sgsn_mm_ctx *ctx,
struct msgb *msg)
{
@@ -1357,7 +1357,7 @@
ctx->gmm_state = GMM_COMMON_PROC_INIT;
}
-/* Section 9.4.1 Attach request */
+/* 3GPP TS 24.008 § 9.4.1 Attach request */
static int gsm48_rx_gmm_att_req(struct sgsn_mm_ctx *ctx, struct msgb *msg,
struct gprs_llc_llme *llme)
{
@@ -1569,7 +1569,7 @@
return !!memcmp(gh_a, gh_b, GMM_ATTACH_REQ_LEN);
}
-/* Section 4.7.4.1 / 9.4.5.2 MO Detach request */
+/* 3GPP TS 24.008 § 4.7.4.1 / 9.4.5.2 MO Detach request */
static int gsm48_rx_gmm_det_req(struct sgsn_mm_ctx *ctx, struct msgb *msg)
{
struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_gmmh(msg);
@@ -1707,7 +1707,7 @@
}
}
-/* 3GPP TS 24.008 Section 4.7.13.4 Service request procedure not accepted by
the
+/* 3GPP TS 24.008 § 4.7.13.4 Service request procedure not accepted by the
* network. Returns true if MS has active PDP contexts in pdp_status */
bool pdp_status_has_active_nsapis(const uint8_t *pdp_status, const size_t
pdp_status_len)
{
@@ -1919,7 +1919,7 @@
return rc;
}
-/* 3GPP TS 24.008 Section 9.4.20 Service request.
+/* 3GPP TS 24.008 § 9.4.20 Service request.
* In Iu, a UE in PMM-IDLE mode can use GSM48_MT_GMM_SERVICE_REQ to switch back
* to PMM-CONNECTED mode. */
static int gsm48_rx_gmm_service_req(struct sgsn_mm_ctx *ctx, struct msgb *msg)
@@ -2009,7 +2009,7 @@
process_ms_ctx_status(ctx, pdp_status);
- /* 3GPP TS 24.008 Section 4.7.13.4 Service request procedure not
+ /* 3GPP TS 24.008 § 4.7.13.4 Service request procedure not
* accepted by the network. Cause #40. If MS has PDP Contexts in
* Active state in pdp_status but there is no PDP contexts on
* SGSN side then Reject with the cause will force the mobile to
@@ -2403,7 +2403,7 @@
}
#endif
-/* Section 9.5.2: Activate PDP Context Accept */
+/* 3GPP TS 24.008 § 9.5.2: Activate PDP Context Accept */
int gsm48_tx_gsm_act_pdp_acc(struct sgsn_pdp_ctx *pdp)
{
struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 PDP ACC");
@@ -2447,7 +2447,7 @@
return gsm48_gmm_sendmsg(msg, 0, pdp->mm, true);
}
-/* Section 9.5.3: Activate PDP Context reject */
+/* 3GPP TS 24.008 § 9.5.3: Activate PDP Context reject */
int gsm48_tx_gsm_act_pdp_rej(struct sgsn_mm_ctx *mm, uint8_t tid,
uint8_t cause, uint8_t pco_len, uint8_t *pco_v)
{
@@ -2472,7 +2472,7 @@
return gsm48_gmm_sendmsg(msg, 0, mm, true);
}
-/* Section 9.5.8: Deactivate PDP Context Request */
+/* 3GPP TS 24.008 § 9.5.8: Deactivate PDP Context Request */
static int _gsm48_tx_gsm_deact_pdp_req(struct sgsn_mm_ctx *mm, uint8_t tid,
uint8_t sm_cause, bool teardown)
{
@@ -2502,7 +2502,7 @@
return _gsm48_tx_gsm_deact_pdp_req(pdp->mm, pdp->ti, sm_cause,
teardown);
}
-/* Section 9.5.9: Deactivate PDP Context Accept */
Change in ...osmo-ttcn3-hacks[master]: ggsn: Add missing v4v6 tests in expected-results.xml
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15260 Change subject: ggsn: Add missing v4v6 tests in expected-results.xml .. ggsn: Add missing v4v6 tests in expected-results.xml Change-Id: I80598fad57b8e7172ac073ebe2b3445e5ab132f0 --- M ggsn_tests/expected-results.xml 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/15260/1 diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml index c60a804..445d566 100644 --- a/ggsn_tests/expected-results.xml +++ b/ggsn_tests/expected-results.xml @@ -19,6 +19,13 @@ + + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I80598fad57b8e7172ac073ebe2b3445e5ab132f0 Gerrit-Change-Number: 15260 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in ...osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp46_act_deact_apn4
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15262
Change subject: ggsn: Introduce test TC_pdp46_act_deact_apn4
..
ggsn: Introduce test TC_pdp46_act_deact_apn4
Related osmo-ggsn.git libgtp fix: I6c6215a4ce478afabc78ffaf5ffb0cf829e41226
Related: OS#4154
Change-Id: Ia1893e0c181307ac1ceb07ee5f496507f7a603c8
---
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/expected-results.xml
2 files changed, 26 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/62/15262/1
diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 31c1056..ae92626 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -247,7 +247,7 @@
}
/* send a PDP context activation */
- function f_pdp_ctx_act(inout PdpContext ctx) runs on GT_CT {
+ function f_pdp_ctx_act(inout PdpContext ctx, OCT1 exp_cause := '80'O)
runs on GT_CT {
var Gtp1cUnitdata ud;
var default d;
@@ -260,7 +260,7 @@
alt {
[] GTPC.receive(tr_GTPC_MsgType(g_peer_c,
createPDPContextResponse, ctx.teic)) -> value ud {
var CreatePDPContextResponse cpr :=
ud.gtpc.gtpc_pdu.createPDPContextResponse;
- if (cpr.cause.causevalue == '80'O) {
+ if (exp_cause == '80'O and exp_cause ==
cpr.cause.causevalue) {
/* Check if EUA type corresponds to
requested type */
if (match(ctx.eua, t_EuaIPv4(?)) and
not match(cpr.endUserAddress,
tr_EuaIPv4(?))){
@@ -292,6 +292,12 @@
ctx.eua := cpr.endUserAddress;
ctx.pco_neg := cpr.protConfigOptions;
setverdict(pass);
+ } else if (exp_cause != '80'O and exp_cause ==
cpr.cause.causevalue) {
+ if (ispresent(cpr.endUserAddress)) {
+ log("EUA received on
createPDPContextResponse cause=" & oct2str(cpr.cause.causevalue));
+ setverdict(fail);
+ }
+ setverdict(pass);
} else {
setverdict(fail);
}
@@ -1287,6 +1293,22 @@
f_pdp_ctx_del(ctxA, '1'B);
}
+ /* Test IPv4v6 context activation for dynamic IPv4v6 EUA on a v4-only
APN */
+ testcase TC_pdp46_act_deact_apn4() runs on GT_CT {
+ f_init();
+ /* A typical MS first attempts v4v6, and if rejected, then
tries v4 and v6 separetly */
+ var PdpContext ctx46 :=
valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet,
valueof(t_EuaIPv4Dynv6Dyn)));
+ f_pdp_ctx_act(ctx46, 'DC'O); /* Cause: Unknown PDP address or
PDP type */
+
+ var PdpContext ctx4 :=
valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet,
valueof(t_EuaIPv4Dyn)));
+ f_pdp_ctx_act(ctx4, '80'O); /* Normal accept cause */
+
+ var PdpContext ctx6 :=
valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet,
valueof(t_EuaIPv6Dyn)));
+ f_pdp_ctx_act(ctx6, 'DC'O); /* Cause: Unknown PDP address or
PDP type */
+
+ f_pdp_ctx_del(ctx4, '1'B);
+ }
+
/* Send a duplicate echo req. osmo-ggsn maintains a queue for sent
responses (60 seconds): If same delete req is sent and duplicate is
detected, saved duplicate response should be sent back. */
@@ -1332,6 +1354,7 @@
execute(TC_pdp46_act_deact_pcodns6());
execute(TC_pdp46_act_deact_gtpu_access());
execute(TC_pdp46_clients_interact());
+ execute(TC_pdp46_act_deact_apn4());
execute(TC_echo_req_resp());
execute(TC_act_deact_retrans_duplicate());
diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml
index e57a7df..374cde0 100644
--- a/ggsn_tests/expected-results.xml
+++ b/ggsn_tests/expected-results.xml
@@ -21,6 +21,7 @@
+
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15262
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia1893e0c181307ac1ceb07ee5f496507f7a603c8
Gerrit-Change-Number: 15262
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in ...osmo-ttcn3-hacks[master]: ggsn: Update test xfail->pass in expected-results.xml
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15261 Change subject: ggsn: Update test xfail->pass in expected-results.xml .. ggsn: Update test xfail->pass in expected-results.xml Commit below fixed the test but forgot to update this file. Fixes: 8e7a396656f8d32c44254de0c65f26c6a2c833f2 Change-Id: Ia5006c9258de9b442b32ae92ae75ef08670de7cf --- M ggsn_tests/expected-results.xml 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/15261/1 diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml index 445d566..e57a7df 100644 --- a/ggsn_tests/expected-results.xml +++ b/ggsn_tests/expected-results.xml @@ -8,12 +8,7 @@ - -Secondary DNS IPv4 PCO option not found - GGSN_Tests.ttcn:MASKED GGSN_Tests control part - GGSN_Tests.ttcn:MASKED TC_pdp4_act_deact_with_separate_dns testcase - - + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5006c9258de9b442b32ae92ae75ef08670de7cf Gerrit-Change-Number: 15261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in ...osmo-ggsn[master]: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/15259
Change subject: libgtp: announce pdp ctx deletion upon CreatePdpCtx being
rejected
..
libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected
The libgtp application may have already allocated related resources
associated to the pdp context, so we need to signal its deletion in
order to let the application free the resources.
This should fix the duplication of pdp contexts seen in osmo-ggsn when
"show pdp-context" related VTY commands are used.
It was spotted due to some MS requesting a v4v6 context on a
v4-only APN, where first v4 address was allocated, and then upon v6
allocation create_context_ind() called
gtp_create_context_resp(GTPCAUSE_MISSING_APN) but the first address was
not freed. Upon receiving the callback, osmo-ggsn should now free the
related resources.
Related: OS#4154
Change-Id: I6c6215a4ce478afabc78ffaf5ffb0cf829e41226
---
M ggsn/ggsn.c
M gtp/gtp.c
2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/59/15259/1
diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c
index 95371a2..d71855d 100644
--- a/ggsn/ggsn.c
+++ b/ggsn/ggsn.c
@@ -386,7 +386,7 @@
LOGPPDP(LOGL_ERROR, pdp, "Cannot find/free IP Pool
member\n");
}
- if (apn->cfg.gtpu_mode == APN_GTPU_MODE_KERNEL_GTP) {
+ if (apn && apn->cfg.gtpu_mode == APN_GTPU_MODE_KERNEL_GTP) {
if (gtp_kernel_tunnel_del(pdp, apn->tun.cfg.dev_name)) {
LOGPPDP(LOGL_ERROR, pdp, "Cannot delete tunnel from
kernel:%s\n",
strerror(errno));
diff --git a/gtp/gtp.c b/gtp/gtp.c
index 94c3245..becedd2 100644
--- a/gtp/gtp.c
+++ b/gtp/gtp.c
@@ -1296,9 +1296,8 @@
/* Now send off a reply to the peer */
gtp_create_pdp_resp(gsn, pdp->version, pdp, cause);
- if (cause != GTPCAUSE_ACC_REQ) {
- pdp_freepdp(pdp);
- }
+ if (cause != GTPCAUSE_ACC_REQ)
+ gtp_freepdp(gsn, pdp);
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15259
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I6c6215a4ce478afabc78ffaf5ffb0cf829e41226
Gerrit-Change-Number: 15259
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in ...osmo-sgsn[master]: vty: Introduce cs7-instance-iu
pespin has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/15239 )
Change subject: vty: Introduce cs7-instance-iu
..
vty: Introduce cs7-instance-iu
Similar to what we already have in osmo-msc.
Change-Id: Iaa9e1d06dd0430848ef4f7498a3c15d13f899904
---
M doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg
M doc/manuals/vty/sgsn_vty_reference.xml
M include/osmocom/sgsn/sgsn.h
M src/gprs/sgsn_main.c
M src/gprs/sgsn_vty.c
5 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
diff --git a/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg
b/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg
index a18d76a..f60c076 100644
--- a/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg
+++ b/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg
@@ -21,6 +21,7 @@
auth-policy remote
gsup remote-ip 127.0.0.1
gsup remote-port 4222
+ cs7-instance-iu 0
!
ns
timer tns-block 3
diff --git a/doc/manuals/vty/sgsn_vty_reference.xml
b/doc/manuals/vty/sgsn_vty_reference.xml
index c3f91cf..38e21c2 100644
--- a/doc/manuals/vty/sgsn_vty_reference.xml
+++ b/doc/manuals/vty/sgsn_vty_reference.xml
@@ -2502,6 +2502,12 @@
+
+
+
+
+
+
diff --git a/include/osmocom/sgsn/sgsn.h b/include/osmocom/sgsn/sgsn.h
index 6e4f5ca..78803c7 100644
--- a/include/osmocom/sgsn/sgsn.h
+++ b/include/osmocom/sgsn/sgsn.h
@@ -112,6 +112,7 @@
#if BUILD_IU
struct {
enum ranap_nsap_addr_enc rab_assign_addr_enc;
+ uint32_t cs7_instance;
} iu;
#endif
diff --git a/src/gprs/sgsn_main.c b/src/gprs/sgsn_main.c
index 5979886..4232e23 100644
--- a/src/gprs/sgsn_main.c
+++ b/src/gprs/sgsn_main.c
@@ -500,7 +500,9 @@
#if BUILD_IU
/* Note that these are mostly defaults and can be overriden from the
VTY */
- sccp = osmo_sccp_simple_client_on_ss7_id(tall_sgsn_ctx, 0, "OsmoSGSN",
+ sccp = osmo_sccp_simple_client_on_ss7_id(tall_sgsn_ctx,
+sgsn->cfg.iu.cs7_instance,
+"OsmoSGSN",
(23 << 3) + 4,
OSMO_SS7_ASP_PROT_M3UA,
0, NULL,
diff --git a/src/gprs/sgsn_vty.c b/src/gprs/sgsn_vty.c
index 6698691..68d3a77 100644
--- a/src/gprs/sgsn_vty.c
+++ b/src/gprs/sgsn_vty.c
@@ -289,6 +289,8 @@
vty_out(vty, " no compression v42bis%s", VTY_NEWLINE);
#ifdef BUILD_IU
+ vty_out(vty, " cs7-instance-iu %u%s", g_cfg->iu.cs7_instance,
+ VTY_NEWLINE);
ranap_iu_vty_config_write(vty, " ");
#endif
@@ -1378,6 +1380,17 @@
return CMD_SUCCESS;
}
+#if BUILD_IU
+DEFUN(cfg_sgsn_cs7_instance_iu,
+ cfg_sgsn_cs7_instance_iu_cmd,
+ "cs7-instance-iu <0-15>",
+ "Set SS7 to be used by the Iu-Interface.\n" "SS7 instance reference
number (default: 0)\n")
+{
+ g_cfg->iu.cs7_instance = atoi(argv[0]);
+ return CMD_SUCCESS;
+}
+#endif
+
int sgsn_vty_init(struct sgsn_config *cfg)
{
g_cfg = cfg;
@@ -1441,6 +1454,7 @@
install_element(SGSN_NODE, _comp_v42bisp_cmd);
#ifdef BUILD_IU
+ install_element(SGSN_NODE, _sgsn_cs7_instance_iu_cmd);
ranap_iu_vty_init(SGSN_NODE, _cfg->iu.rab_assign_addr_enc);
#endif
return 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15239
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iaa9e1d06dd0430848ef4f7498a3c15d13f899904
Gerrit-Change-Number: 15239
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: neels
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always run verbose asciidoc
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15030 ) Change subject: Makefile.asciidoc.inc: always run verbose asciidoc .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I2cbd2985645ecdecc7851849be6a9a95d4b3246e Gerrit-Change-Number: 15030 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 13:09:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ci[master]: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15029 ) Change subject: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8775d45b4dc1a5a46e2ba042fc7ee7d9f10f18cc Gerrit-Change-Number: 15029 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 13:08:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: vty: Introduce cs7-instance-iu
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15239 ) Change subject: vty: Introduce cs7-instance-iu .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iaa9e1d06dd0430848ef4f7498a3c15d13f899904 Gerrit-Change-Number: 15239 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 12:01:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ci[master]: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK
osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-ci/+/15029 )
Change subject: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK
..
gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK
The asciidoc warnings check fails the build if asciidoc prints a warning
while building the documentation. We had this enabled by default, but
since OBS uses various asciidoc versions, we could get unexpected build
failures (different asciidoc versions print different warnings).
Now that it is disabled by default, explicitly enable it for jenkins
again.
Related: OS#4140
Depends: Iac993a0d1b17205397a1f1ef1a7bd3f9df739e36 (osmo-gsm-manuals)
Change-Id: I8775d45b4dc1a5a46e2ba042fc7ee7d9f10f18cc
---
M jobs/gerrit-verifications.yml
M jobs/master-builds.yml
2 files changed, 26 insertions(+), 16 deletions(-)
Approvals:
osmith: Looks good to me, approved; Verified
diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index 0b983dd..cb370e9 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -20,7 +20,7 @@
combination_filter: ''
sequential: false
# most common build invocation
-cmd: ./contrib/jenkins.sh
+cmd: ASCIIDOC_WARNINGS_CHECK=1 ./contrib/jenkins.sh
repos_url: 'ssh://jenk...@gerrit.osmocom.org:29418/{repos}'
gerrit_project: '{repos}'
@@ -46,7 +46,7 @@
- libosmo-abis
- libosmo-netif
- libosmo-sccp:
- cmd: WITH_MANUALS=1 ./contrib/jenkins.sh
+ cmd: WITH_MANUALS=1 ASCIIDOC_WARNINGS_CHECK=1 ./contrib/jenkins.sh
- libosmocore:
a1_name: arch
@@ -81,6 +81,7 @@
-e PATH="$PATH:/build_bin" \
-e OSMOPY_DEBUG_TCP_SOCKETS="1" \
-e WITH_MANUALS="1" \
+ -e ASCIIDOC_WARNINGS_CHECK="1" \
-w /build -i -u build \
-v "$PWD:/build" \
-v "$HOME/bin:/build_bin" \
@@ -102,6 +103,7 @@
-e PATH="$PATH:/build_bin" \
-e OSMOPY_DEBUG_TCP_SOCKETS="1" \
-e WITH_MANUALS="1" \
+ -e ASCIIDOC_WARNINGS_CHECK="1" \
-w /build -i -u build \
-v "$PWD:/build" -v "$HOME/bin:/build_bin" \
osmocom:amd64 /build/contrib/jenkins.sh
@@ -124,7 +126,7 @@
(FIRMWARE_VERSION == "litecell15" && BTS_MODEL == "lc15" &&
WITH_MANUALS == "0") ||
(FIRMWARE_VERSION == "oc2g" && BTS_MODEL == "oc2g" && WITH_MANUALS
== "0") ||
(FIRMWARE_VERSION == "oc2g-next" && BTS_MODEL == "oc2g" &&
WITH_MANUALS == "0")
- cmd: './contrib/jenkins_bts_model.sh "$BTS_MODEL"'
+ cmd: ASCIIDOC_WARNINGS_CHECK="1" './contrib/jenkins_bts_model.sh
"$BTS_MODEL"'
- osmo-ggsn:
a1_name: GTP
@@ -134,12 +136,12 @@
combination_filter: >
(GTP == "--enable-gtp-linux" && WITH_MANUALS == "0") ||
(GTP == "--disable-gtp-linux" && WITH_MANUALS == "1")
- cmd: ./contrib/jenkins.sh
+ cmd: ASCIIDOC_WARNINGS_CHECK=1 ./contrib/jenkins.sh
- osmo-gsm-manuals
- osmo-hlr:
- cmd: WITH_MANUALS=1 ./contrib/jenkins.sh
+ cmd: WITH_MANUALS=1 ASCIIDOC_WARNINGS_CHECK=1 ./contrib/jenkins.sh
- osmo-iuh:
cmd: WITH_MANUALS=1 ./contrib/jenkins.sh
@@ -154,6 +156,7 @@
-e PATH="$PATH:/build_bin" \
-e OSMOPY_DEBUG_TCP_SOCKETS="1" \
-e WITH_MANUALS="1" \
+ -e ASCIIDOC_WARNINGS_CHECK="1" \
-w /build -i -u build \
-v "$PWD:/build" -v "$HOME/bin:/build_bin" \
osmocom:amd64 /build/contrib/jenkins.sh
@@ -178,6 +181,7 @@
-e PARALLEL_MAKE="$PARALLEL_MAKE" \
-e IU="$IU" \
-e WITH_MANUALS="$WITH_MANUALS" \
+ -e ASCIIDOC_WARNINGS_CHECK="1" \
-e PATH="$PATH:/build_bin" \
-e OSMOPY_DEBUG_TCP_SOCKETS="1" \
-w /build -u build \
@@ -225,6 +229,7 @@
-e PARALLEL_MAKE="$PARALLEL_MAKE" \
-e IU="$IU" \
-e WITH_MANUALS="$WITH_MANUALS" \
+ -e ASCIIDOC_WARNINGS_CHECK="1" \
-e PATH="$PATH:/build_bin" \
-e OSMOPY_DEBUG_TCP_SOCKETS="1" \
-w /build -i -u build \
@@ -232,7 +237,7 @@
osmocom:amd64 /build/contrib/jenkins.sh
- osmo-sip-connector:
- cmd: WITH_MANUALS=1 ./contrib/jenkins.sh
+ cmd: WITH_MANUALS=1 ASCIIDOC_WARNINGS_CHECK=1 ./contrib/jenkins.sh
- osmo-trx:
a1_name: INSTR
@@ -246,7 +251,7 @@
(INSTR == "--with-sse" && WITH_MANUALS == "1")
- osmocom-bb:
- cmd: WITH_MANUALS=1 ./contrib/jenkins.sh
+ cmd: WITH_MANUALS=1 ASCIIDOC_WARNINGS_CHECK=1 ./contrib/jenkins.sh
- osmo-tetra
- osmo-sysmon
- osmo-remsim
diff --git
Change in ...osmo-ci[master]: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15029 ) Change subject: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK .. Patch Set 2: Code-Review+2 Commit message updated to make it more clear. Re-applying +2 from previous reviews. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8775d45b4dc1a5a46e2ba042fc7ee7d9f10f18cc Gerrit-Change-Number: 15029 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 11:46:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ci[master]: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK
Hello pespin, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/15029 to look at the new patch set (#2). Change subject: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK .. gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK The asciidoc warnings check fails the build if asciidoc prints a warning while building the documentation. We had this enabled by default, but since OBS uses various asciidoc versions, we could get unexpected build failures (different asciidoc versions print different warnings). Now that it is disabled by default, explicitly enable it for jenkins again. Related: OS#4140 Depends: Iac993a0d1b17205397a1f1ef1a7bd3f9df739e36 (osmo-gsm-manuals) Change-Id: I8775d45b4dc1a5a46e2ba042fc7ee7d9f10f18cc --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 26 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/29/15029/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8775d45b4dc1a5a46e2ba042fc7ee7d9f10f18cc Gerrit-Change-Number: 15029 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: warnings check not default
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15031 ) Change subject: Makefile.asciidoc.inc: warnings check not default .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15031/1/build/Makefile.asciidoc.inc File build/Makefile.asciidoc.inc: https://gerrit.osmocom.org/#/c/15031/1/build/Makefile.asciidoc.inc@79 PS1, Line 79: if [ -n "$$ASCIIDOC_WARNINGS_CHECK" ]; then \ > I guess the ratioanle is that "make check" currently only relates to whether > our unit tests pass. Before this patch, ./configure --enable-manuals and "make check" would always check the manuals too. That is due to how automake works, it finds the "check" rule and runs it in the subdirectory. With the patch, this behavior is overwritten and now the checks only run with "ASCIIDOC_WARNINGS_CHECK=1 make check". > I'm sure that some years down the road asciidoc has more warnings than today, > and you wouldn't be able to pass a "make check" anymore, which in turn makes > people believe that the software is somehow broken. Yes, the warnings changing being asciidoc versions is the reason why I created the patch. Not only some years down the road, but also in OBS where we have various distros and asciidoc versions, some may print additional warnings that let the documentation check fail. The new logic is that we don't check for the documentation warnings in OBS or other regular builds, just in jenkins where we have one specific asciidoc version. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iac993a0d1b17205397a1f1ef1a7bd3f9df739e36 Gerrit-Change-Number: 15031 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 11:32:30 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always run verbose asciidoc
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15030 ) Change subject: Makefile.asciidoc.inc: always run verbose asciidoc .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15030/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15030/1//COMMIT_MSG@15 PS1, Line 15: This prevents losing the error message in case asciidoc or a2x fail > I don't really understand what you mean in the paragraph. While analyzing OS#4131 (leveloffset attribute warning), I saw once in the logs that asciidoc running with a2x failed. But we were not running a2x with -vv, so there was no error message. Then the Makefile ran asciidoc as standalone to find the error, and then it did not fail anymore. Another example that I experienced at some point is, that a2x may fail for a reason unrelated to asciidoc. Then we run asciidoc as standalone and it reports that everything went okay. This is confusing and makes it harder to find the actual error message. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I2cbd2985645ecdecc7851849be6a9a95d4b3246e Gerrit-Change-Number: 15030 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 11:24:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-ci[master]: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15029 ) Change subject: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK .. Patch Set 1: Code-Review+2 Thanks, that's what I was missing (and would be great to have in the commit log for future reference) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8775d45b4dc1a5a46e2ba042fc7ee7d9f10f18cc Gerrit-Change-Number: 15029 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 11:24:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ci[master]: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15029 ) Change subject: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK .. Patch Set 1: > Patch Set 1: > > Does warn checking (if warns are found) mean job will fail? Yes. > Why do we have it disabled by default but we seem to enable it everywhere > here? Or it's because we don't enable it in OBS? I lack some explanation > regarding those matters. We don't want to have this check enabled in OBS, because we are building for different distros with different asciidoc versions. These may throw different warnings than the asciidoc version installed in jenkins, and then unexpectedly fail the build because of a warning that jenkins did not report. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8775d45b4dc1a5a46e2ba042fc7ee7d9f10f18cc Gerrit-Change-Number: 15029 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 11:20:19 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-trx[master]: Drop old setPriority related code
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/15258
Change subject: Drop old setPriority related code
..
Drop old setPriority related code
This code is not needed anymore since we are setting SCHED_RR scheduler
with a real time priority in main thread during startup, so all threads
will inherit same rt priority, which should be enough to keep the
process working reliably even on high system loads (from non rt
processes).
osmo-trx was tested to be reliable during test with stress-ng as
explained in related ticket below.
Related: OS#2344
Change-Id: I3a88946dd71e9aeeaac9d19d396e2236c302b608
---
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
M Transceiver52M/device/common/radioDevice.h
M Transceiver52M/device/lms/LMSDevice.h
M Transceiver52M/device/uhd/UHDDevice.cpp
M Transceiver52M/device/uhd/UHDDevice.h
M Transceiver52M/device/usrp1/USRPDevice.h
M Transceiver52M/radioInterface.h
8 files changed, 0 insertions(+), 32 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/58/15258/1
diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index 4da1876..2d5c04e 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -1126,8 +1126,6 @@
snprintf(thread_name, 16, "RxUpper%zu", num);
set_selfthread_name(thread_name);
- trx->setPriority(0.42);
-
while (1) {
trx->driveReceiveFIFO(num);
pthread_testcancel();
@@ -1139,8 +1137,6 @@
{
set_selfthread_name("RxLower");
- transceiver->setPriority(0.45);
-
while (1) {
transceiver->driveReceiveRadio();
pthread_testcancel();
@@ -1152,8 +1148,6 @@
{
set_selfthread_name("TxLower");
- transceiver->setPriority(0.44);
-
while (1) {
transceiver->driveTxFIFO();
pthread_testcancel();
@@ -1190,8 +1184,6 @@
snprintf(thread_name, 16, "TxUpper%zu", num);
set_selfthread_name(thread_name);
- trx->setPriority(0.40);
-
while (1) {
trx->driveTxPriorityQueue(num);
pthread_testcancel();
diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h
index 18dc5f2..1a4d28f 100644
--- a/Transceiver52M/Transceiver.h
+++ b/Transceiver52M/Transceiver.h
@@ -247,9 +247,6 @@
void reset();
- /** set priority on current thread */
- void setPriority(float prio = 0.5) { mRadioInterface->setPriority(prio); }
-
void logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi);
};
diff --git a/Transceiver52M/device/common/radioDevice.h
b/Transceiver52M/device/common/radioDevice.h
index cd378a8..e637611 100644
--- a/Transceiver52M/device/common/radioDevice.h
+++ b/Transceiver52M/device/common/radioDevice.h
@@ -70,9 +70,6 @@
/** Get the Tx window type */
virtual enum TxWindowType getWindowType()=0;
- /** Enable thread priority */
- virtual void setPriority(float prio = 0.5) = 0;
-
/**
Read samples from the radio.
@param buf preallocated buf to contain read result
diff --git a/Transceiver52M/device/lms/LMSDevice.h
b/Transceiver52M/device/lms/LMSDevice.h
index bc79f97..47bac94 100644
--- a/Transceiver52M/device/lms/LMSDevice.h
+++ b/Transceiver52M/device/lms/LMSDevice.h
@@ -85,10 +85,6 @@
/** Stop the LMS */
bool stop();
- /** Set priority not supported */
- void setPriority(float prio = 0.5) {
- }
-
enum TxWindowType getWindowType() {
return TX_WINDOW_LMS1;
}
diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp
b/Transceiver52M/device/uhd/UHDDevice.cpp
index 8bb94d6..5b38df4 100644
--- a/Transceiver52M/device/uhd/UHDDevice.cpp
+++ b/Transceiver52M/device/uhd/UHDDevice.cpp
@@ -125,7 +125,6 @@
void *async_event_loop(uhd_device *dev)
{
set_selfthread_name("UHDAsyncEvent");
- dev->setPriority(0.43);
while (1) {
dev->recv_async_msg();
@@ -643,12 +642,6 @@
return true;
}
-void uhd_device::setPriority(float prio)
-{
- uhd::set_thread_priority_safe(prio);
- return;
-}
-
int uhd_device::check_rx_md_err(uhd::rx_metadata_t , ssize_t num_smpls)
{
if (!num_smpls) {
diff --git a/Transceiver52M/device/uhd/UHDDevice.h
b/Transceiver52M/device/uhd/UHDDevice.h
index d5a6348..944578a 100644
--- a/Transceiver52M/device/uhd/UHDDevice.h
+++ b/Transceiver52M/device/uhd/UHDDevice.h
@@ -71,7 +71,6 @@
bool start();
bool stop();
bool restart();
- void setPriority(float prio);
enum TxWindowType getWindowType() { return tx_window; }
int readSamples(std::vector , int len, bool *overrun,
diff --git a/Transceiver52M/device/usrp1/USRPDevice.h
b/Transceiver52M/device/usrp1/USRPDevice.h
index 9a2426c..4123c7d 100644
--- a/Transceiver52M/device/usrp1/USRPDevice.h
+++ b/Transceiver52M/device/usrp1/USRPDevice.h
@@ -107,9 +107,6 @@
/** Stop the USRP */
bool stop();
- /** Set priority not supported */
- void setPriority(float
Change in ...osmo-trx[master]: lms: Use define LOG_LEVEL_CRITICIAL instead of value
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15257 ) Change subject: lms: Use define LOG_LEVEL_CRITICIAL instead of value .. Patch Set 1: the define is only available in Logger.h, but not yet in C API. See https://github.com/myriadrf/LimeSuite/pull/275 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie5bb99a76580c5780a24f190682700c5e69b3d85 Gerrit-Change-Number: 15257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 10:06:41 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-trx[master]: lms: Use define LOG_LEVEL_CRITICIAL instead of value
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/15257
Change subject: lms: Use define LOG_LEVEL_CRITICIAL instead of value
..
lms: Use define LOG_LEVEL_CRITICIAL instead of value
Change-Id: Ie5bb99a76580c5780a24f190682700c5e69b3d85
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/57/15257/1
diff --git a/Transceiver52M/device/lms/LMSDevice.cpp
b/Transceiver52M/device/lms/LMSDevice.cpp
index f55b555..d4e8640 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -81,7 +81,7 @@
{
/* map lime specific log levels */
static const int lvl_map[5] = {
- [0] = LOGL_FATAL,
+ [LOG_LEVEL_CRITICAL] = LOGL_FATAL,
[LMS_LOG_ERROR] = LOGL_ERROR,
[LMS_LOG_WARNING] = LOGL_NOTICE,
[LMS_LOG_INFO] = LOGL_INFO,
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15257
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ie5bb99a76580c5780a24f190682700c5e69b3d85
Gerrit-Change-Number: 15257
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in ...osmo-sgsn[master]: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY
pespin has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/12009 )
Change subject: gprs/gprs_gmm: implement T3314. Timeout to reset MM state
READY->STANDBY
..
gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY
When a MS MM state is READY its exact location is known (PCU).
On Gb, T3314 (aka TS 23.060 "READY timer") sets the MM state from
READY to STANDBY, where only the RA is known.
Introduce a second set of timer variables, because state timer
can run while another packet state timer is timing out.
Related: OS#1941
Change-Id: I4ce23ebe50d141076c20c9c56990b7103cd25e55
---
M include/osmocom/sgsn/gprs_sgsn.h
M src/gprs/gprs_gmm.c
M src/gprs/gprs_sgsn.c
M src/gprs/sgsn_vty.c
M tests/test_nodes.vty
5 files changed, 98 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/include/osmocom/sgsn/gprs_sgsn.h b/include/osmocom/sgsn/gprs_sgsn.h
index 9753ea2..336155c 100644
--- a/include/osmocom/sgsn/gprs_sgsn.h
+++ b/include/osmocom/sgsn/gprs_sgsn.h
@@ -156,6 +156,10 @@
struct gprs_llc_llme*llme;
uint32_ttlli;
uint32_ttlli_new;
+
+ /* timer for mm state. state=READY: T3314 (aka TS 23.060 "READY
timer") */
+ struct osmo_timer_list state_timer;
+ unsigned intstate_T;/* T number but
only used for pmm_states */
} gb;
struct {
int new_key;
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index db8defc..f7aff73 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -137,6 +137,57 @@
}
}
+static void mmctx_set_mm_state(struct sgsn_mm_ctx *ctx, enum gprs_pmm_state
state);
+static void mmctx_state_timer_cb(void *_mm)
+{
+ struct sgsn_mm_ctx *mm = _mm;
+
+ switch (mm->gb.state_T) {
+ case 3314:
+ switch (mm->pmm_state) {
+ case MM_READY:
+ LOGMMCTXP(LOGL_INFO, mm, "T3314 expired\n");
+ mmctx_set_mm_state(mm, MM_STANDBY);
+ break;
+ default:
+ LOGMMCTXP(LOGL_ERROR, mm, "T3314 expired in state %s !=
MM_READY\n",
+ get_value_string(gprs_pmm_state_names,
mm->pmm_state));
+ break;
+ }
+ break;
+ default:
+ LOGMMCTXP(LOGL_ERROR, mm, "state timer expired in unknown mode
%u\n",
+ mm->gb.state_T);
+ break;
+ }
+}
+
+static void mmctx_state_timer_start(struct sgsn_mm_ctx *mm, unsigned int T)
+{
+ unsigned long seconds;
+
+ if (mm->gb.state_T && mm->gb.state_T != T)
+ LOGMMCTXP(LOGL_ERROR, mm, "Attempting to start timer %u but %u
is active!\n",
+ T, mm->gb.state_T);
+
+ mm->gb.state_T = T;
+ mm->gb.state_timer.data = mm;
+ mm->gb.state_timer.cb = _state_timer_cb;
+
+ seconds = osmo_tdef_get(sgsn->cfg.T_defs, T, OSMO_TDEF_S, -1);
+ osmo_timer_schedule(>gb.state_timer, seconds, 0);
+}
+
+static void mmctx_state_timer_stop(struct sgsn_mm_ctx *mm, unsigned int T)
+{
+ if (mm->gb.state_T == T)
+ osmo_timer_del(>gb.state_timer);
+ else
+ LOGMMCTXP(LOGL_ERROR, mm, "Attempting to stop timer %u but %u
is active!\n",
+ T, mm->gb.state_T);
+ mm->gb.state_T = 0;
+}
+
static void mmctx_set_pmm_state(struct sgsn_mm_ctx *ctx, enum gprs_pmm_state
state)
{
OSMO_ASSERT(ctx->ran_type == MM_CTX_T_UTRAN_Iu);
@@ -173,6 +224,24 @@
get_value_string(gprs_pmm_state_names, ctx->pmm_state),
get_value_string(gprs_pmm_state_names, state));
+ switch (state) {
+ case MM_READY:
+ /* on expiration, T3314 moves mm state back to MM_STANDBY */
+ mmctx_state_timer_start(ctx, 3314);
+ break;
+ case MM_IDLE:
+ if (ctx->pmm_state == MM_READY)
+ mmctx_state_timer_stop(ctx, 3314);
+ break;
+ case MM_STANDBY:
+ if (ctx->pmm_state == MM_READY)
+ mmctx_state_timer_stop(ctx, 3314);
+ break;
+ default:
+ /* when changing to state != MM_READY */
+ break;
+ }
+
ctx->pmm_state = state;
}
@@ -2968,6 +3037,21 @@
return rc;
}
+/* Update the MM context state */
+static void gsm0408_gprs_notify_pdu_gb(struct sgsn_mm_ctx *mmctx)
+{
+ switch (mmctx->pmm_state) {
+ case MM_STANDBY:
+ mmctx_set_mm_state(mmctx, MM_READY);
+ break;
+ case MM_READY: /* RE-arm the
Change in ...osmo-sgsn[master]: examples: Add osmo-sgsn_custom-sccp.cfg
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15238 ) Change subject: examples: Add osmo-sgsn_custom-sccp.cfg .. examples: Add osmo-sgsn_custom-sccp.cfg Change-Id: Id3a3ccbf168fbbc28153cbf7f0249294eee34d3d --- A doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg 1 file changed, 38 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg b/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg new file mode 100644 index 000..a18d76a --- /dev/null +++ b/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg @@ -0,0 +1,38 @@ +! +! Osmocom SGSN configuration +! +! +line vty + no login +! +cs7 instance 0 + point-code 0.23.4 + asp asp-clnt-OsmoSGSN-A 2905 0 m3ua + remote-ip 172.18.8.200 ! where to reach the STP + as as-clnt-OsmoSGSN-A m3ua + asp asp-clnt-OsmoSGSN-A + routing-key 3 0.23.4 +sgsn + gtp local-ip 127.0.0.1 + ggsn 0 remote-ip 127.0.0.2 + ggsn 0 gtp-version 1 + ggsn 0 echo-interval 60 + authentication required + auth-policy remote + gsup remote-ip 127.0.0.1 + gsup remote-port 4222 +! +ns + timer tns-block 3 + timer tns-block-retries 3 + timer tns-reset 3 + timer tns-reset-retries 3 + timer tns-test 30 + timer tns-alive 3 + timer tns-alive-retries 10 + encapsulation udp local-ip 127.0.0.1 + encapsulation udp local-port 23000 + encapsulation framerelay-gre enabled 0 +! +bssgp +! -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id3a3ccbf168fbbc28153cbf7f0249294eee34d3d Gerrit-Change-Number: 15238 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in ...osmo-sgsn[master]: Replace own timer infra with libosmocore osmo_tdef
pespin has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/15214 )
Change subject: Replace own timer infra with libosmocore osmo_tdef
..
Replace own timer infra with libosmocore osmo_tdef
VTY command "show timer" is also available now.
Change-Id: Ia0cf5f0a49737fbc419e2ccc86312d01c6e0056e
---
M include/osmocom/sgsn/sgsn.h
M src/gprs/gprs_gmm.c
M src/gprs/gprs_gmm_attach.c
M src/gprs/sgsn_vty.c
M tests/sgsn/sgsn_test.c
5 files changed, 132 insertions(+), 126 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/include/osmocom/sgsn/sgsn.h b/include/osmocom/sgsn/sgsn.h
index 0a6ea29..6e4f5ca 100644
--- a/include/osmocom/sgsn/sgsn.h
+++ b/include/osmocom/sgsn/sgsn.h
@@ -86,20 +86,8 @@
/* CDR configuration */
struct sgsn_cdr cdr;
- struct {
- int T3312;
- int T3322;
- int T3350;
- int T3360;
- int T3370;
- int T3313;
- int T3314;
- int T3316;
- int T3385;
- int T3386;
- int T3395;
- int T3397;
- } timers;
+ /* Timer defintions */
+ struct osmo_tdef *T_defs;
int dynamic_lookup;
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index b8b0116..db8defc 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -40,6 +40,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -235,12 +236,15 @@
static void mmctx_timer_cb(void *_mm);
-static void mmctx_timer_start(struct sgsn_mm_ctx *mm, unsigned int T,
- unsigned int seconds)
+static void mmctx_timer_start(struct sgsn_mm_ctx *mm, unsigned int T)
{
+ unsigned long seconds;
if (osmo_timer_pending(>timer))
LOGMMCTXP(LOGL_ERROR, mm, "Starting MM timer %u while old "
"timer %u pending\n", T, mm->T);
+
+ seconds = osmo_tdef_get(sgsn->cfg.T_defs, T, OSMO_TDEF_S, -1);
+
mm->T = T;
mm->num_T_exp = 0;
@@ -259,7 +263,11 @@
time_t gprs_max_time_to_idle(void)
{
- return sgsn->cfg.timers.T3314 + (sgsn->cfg.timers.T3312 + 4 * 60);
+ unsigned long T3314, T3312;
+
+ T3314 = osmo_tdef_get(sgsn->cfg.T_defs, 3314, OSMO_TDEF_S, -1);
+ T3312 = osmo_tdef_get(sgsn->cfg.T_defs, 3312, OSMO_TDEF_S, -1);
+ return T3314 + (T3312 + 4 * 60);
}
/* Send a message through the underlying layer.
@@ -449,6 +457,7 @@
struct gsm48_hdr *gh;
struct gsm48_attach_ack *aa;
uint8_t *mid;
+ unsigned long t;
#if 0
uint8_t *ptsig;
#endif
@@ -465,7 +474,8 @@
aa = (struct gsm48_attach_ack *) msgb_put(msg, sizeof(*aa));
aa->force_stby = 0; /* not indicated */
aa->att_result = 1; /* GPRS only */
- aa->ra_upd_timer = gprs_secs_to_tmr_floor(sgsn->cfg.timers.T3312);
+ t = osmo_tdef_get(sgsn->cfg.T_defs, 3312, OSMO_TDEF_S, -1);
+ aa->ra_upd_timer = gprs_secs_to_tmr_floor(t);
aa->radio_prio = 4; /* lowest */
gsm48_encode_ra(>ra_id, >ra);
@@ -482,8 +492,8 @@
* (fixed 44s, default value, GSM 04.08, table 11.4a) to safely limit
* the inactivity time READY->STANDBY.
*/
- msgb_tv_put(msg, GSM48_IE_GMM_TIMER_READY,
- gprs_secs_to_tmr_floor(sgsn->cfg.timers.T3314));
+ t = osmo_tdef_get(sgsn->cfg.T_defs, 3314, OSMO_TDEF_S, -1);
+ msgb_tv_put(msg, GSM48_IE_GMM_TIMER_READY, gprs_secs_to_tmr_floor(t));
#ifdef PTMSI_ALLOC
/* Optional: Allocated P-TMSI */
@@ -1019,12 +1029,12 @@
/* Request IMSI and IMEI from the MS if they are unknown */
if (!strlen(ctx->imei)) {
ctx->t3370_id_type = GSM_MI_TYPE_IMEI;
- mmctx_timer_start(ctx, 3370, sgsn->cfg.timers.T3370);
+ mmctx_timer_start(ctx, 3370);
return gsm48_tx_gmm_id_req(ctx, GSM_MI_TYPE_IMEI);
}
if (!strlen(ctx->imsi)) {
ctx->t3370_id_type = GSM_MI_TYPE_IMSI;
- mmctx_timer_start(ctx, 3370, sgsn->cfg.timers.T3370);
+ mmctx_timer_start(ctx, 3370);
return gsm48_tx_gmm_id_req(ctx, GSM_MI_TYPE_IMSI);
}
@@ -1047,7 +1057,7 @@
&& !sgsn_mm_ctx_is_authenticated(ctx)) {
struct gsm_auth_tuple *at = >auth_triplet;
- mmctx_timer_start(ctx, 3360, sgsn->cfg.timers.T3360);
+ mmctx_timer_start(ctx, 3360);
return gsm48_tx_gmm_auth_ciph_req(ctx, >vec, at->key_seq,
false);
}
@@ -1086,7 +1096,7 @@
extract_subscr_hlr(ctx);
#ifdef PTMSI_ALLOC
/* Start T3350 and re-transmit up to 5 times until ATTACH
Change in ...osmo-sgsn[master]: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/12009 ) Change subject: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY .. Patch Set 4: Code-Review+2 +2, re-adding the vote from laforge after including the missing breaks catched by osmith. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/12009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4ce23ebe50d141076c20c9c56990b7103cd25e55 Gerrit-Change-Number: 12009 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 09:07:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: tests: Introduce vty-transcript-test tests
pespin has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/15215 )
Change subject: tests: Introduce vty-transcript-test tests
..
tests: Introduce vty-transcript-test tests
Add a few commands to make sure it's working fine, and print all
available timers with default values.
Change-Id: Ifd092b9561d49be1f62769d95ba49f6e4aeb4066
---
M tests/Makefile.am
A tests/test_nodes.vty
2 files changed, 89 insertions(+), 5 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
neels: Looks good to me, approved
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 035cfb0..6c392af 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -33,6 +33,7 @@
$(TESTSUITE) \
vty_test_runner.py \
ctrl_test_runner.py \
+ test_nodes.vty \
$(NULL)
TESTSUITE = $(srcdir)/testsuite
@@ -43,16 +44,38 @@
if ENABLE_EXT_TESTS
python-tests: $(BUILT_SOURCES)
- osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v
- osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v
- $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v
- $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v
- rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart
$(top_builddir)/gtphub_restart_count
+ $(MAKE) vty-test
+ $(MAKE) ctrl-python-test
else
python-tests: $(BUILT_SOURCES)
echo "Not running python-based tests (determined at configure-time)"
endif
+vty-python-test: $(BUILT_SOURCES)
+ osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v
+ osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v
+ $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v
+ rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart
$(top_builddir)/gtphub_restart_count
+
+# To update the VTY script from current application behavior,
+# pass -u to vty_script_runner.py by doing:
+# make vty-transcript-test U=-u
+vty-transcript-test:
+ osmo_verify_transcript_vty.py -v \
+ -n OsmoSGSN -p 4245 \
+ -r "$(top_builddir)/src/gprs/osmo-sgsn -c
$(top_srcdir)/doc/examples/osmo-sgsn/osmo-sgsn.cfg" \
+ $(U) $${T:-$(srcdir)/*.vty}
+ rm -f $(builddir)/sms.db $(builddir)/gsn_restart
+
+# don't run multiple tests concurrently so that the ports don't conflict
+vty-test:
+ $(MAKE) vty-python-test
+ $(MAKE) vty-transcript-test
+
+ctrl-python-test: $(BUILT_SOURCES)
+ $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v
+ rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart
$(top_builddir)/gtphub_restart_count
+
check-local: atconfig $(TESTSUITE)
$(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS)
$(MAKE) $(AM_MAKEFLAGS) python-tests
diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty
new file mode 100644
index 000..630094f
--- /dev/null
+++ b/tests/test_nodes.vty
@@ -0,0 +1,61 @@
+OsmoSGSN> enable
+OsmoSGSN# show timer
+T3312 = 600 s Periodic RA Update timer (s) (default: 600 s)
+T3313 = 30 s Waiting for paging response timer (s) (default: 30 s)
+T3314 = 44 s Force to STANDBY on expiry timer (s) (default: 44 s)
+T3316 = 44 s AA-Ready timer (s) (default: 44 s)
+T3322 = 6 sDetach request -> accept timer (s) (default: 6 s)
+T3350 = 6 sWaiting for ATT/RAU/TMSI_COMPL timer (s) (default: 6 s)
+T3360 = 6 sWaiting for AUTH/CIPH response timer (s) (default: 6 s)
+T3370 = 6 sWaiting for IDENTITY response timer (s) (default: 6 s)
+T3385 = 8 sWait for ACT PDP CTX REQ timer (s) (default: 8 s)
+T3386 = 8 sWait for MODIFY PDP CTX ACK timer (s) (default: 8 s)
+T3395 = 8 sWait for DEACT PDP CTX ACK timer (s) (default: 8 s)
+T3397 = 8 sWait for DEACT AA PDP CTX ACK timer (s) (default: 8 s)
+OsmoSGSN# configure terminal
+OsmoSGSN(config)# list
+...
+ sgsn
+ ctrl
+...
+ ns
+ bssgp
+...
+
+OsmoSGSN(config)# sgsn
+OsmoSGSN(config-sgsn)# list
+...
+ gtp local-ip A.B.C.D
+ ggsn <0-255> remote-ip A.B.C.D
+ ggsn <0-255> gtp-version (0|1)
+ ggsn <0-255> echo-interval <1-36000>
+ ggsn <0-255> no echo-interval
+ imsi-acl (add|del) IMSI
+ auth-policy (accept-all|closed|acl-only|remote)
+ authentication (optional|required)
+ encryption (GEA0|GEA1|GEA2|GEA3|GEA4)
+ gsup ipa-name NAME
+ gsup remote-ip A.B.C.D
+ gsup remote-port <0-65535>
+ gsup oap-id <0-65535>
+ gsup oap-k K
+ gsup oap-opc OPC
+ apn APNAME ggsn <0-255>
+ apn APNAME imsi-prefix IMSIPRE ggsn <0-255>
+ access-point-name NAME
+ no access-point-name NAME
+ cdr filename NAME
+ no cdr filename
+ cdr trap
+ no cdr trap
+ cdr interval <1-2147483647>
+ ggsn dynamic
+ grx-dns-add A.B.C.D
+ timer [T] [(<0-2147483647>|default)]
+ no compression rfc1144
+ compression rfc1144 active slots <1-256>
+ compression rfc1144 passive
+ no compression v42bis
+ compression v42bis active
Change in ...osmo-sgsn[master]: gprs_gmm.c: Use osmo_rai_name() in log line
pespin has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/15224 )
Change subject: gprs_gmm.c: Use osmo_rai_name() in log line
..
gprs_gmm.c: Use osmo_rai_name() in log line
Change-Id: Ieab9b7696c93de9a5d3d42f614072a6f2181e37d
---
M src/gprs/gprs_gmm.c
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
lynxis lazus: Looks good to me, approved
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index f7aff73..dccec2b 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1827,9 +1827,8 @@
{
/* We cannot use the mmctx */
LOGMMCTXP(LOGL_INFO, mmctx,
- "The MM context cannot be used, RA: %03d-%0*d-%d-%d\n",
- mmctx->ra.mcc, mmctx->ra.mnc_3_digits, mmctx->ra.mnc,
- mmctx->ra.lac, mmctx->ra.rac);
+ "The MM context cannot be used, RA: %s\n",
+ osmo_rai_name(>ra));
/* mmctx is set to NULL and gprs_llgmm_unassign(llme) will be
called below, let's make sure we don't keep dangling llme
pointers in mmctx (OS#3957). */
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15224
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ieab9b7696c93de9a5d3d42f614072a6f2181e37d
Gerrit-Change-Number: 15224
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...osmo-sgsn[master]: Replace own timer infra with libosmocore osmo_tdef
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15214 ) Change subject: Replace own timer infra with libosmocore osmo_tdef .. Patch Set 4: Code-Review+2 +2, it was already reviewed by more people before last fixup changes -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia0cf5f0a49737fbc419e2ccc86312d01c6e0056e Gerrit-Change-Number: 15214 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 09:06:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ci[master]: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15029 ) Change subject: gerrit, master builds: use ASCIIDOC_WARNINGS_CHECK .. Patch Set 1: Does warn checking (if warns are found) mean job will fail? Why do we have it disabled by default but we seem to enable it everywhere here? Or it's because we don't enable it in OBS? I lack some explanation regarding those matters. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/15029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8775d45b4dc1a5a46e2ba042fc7ee7d9f10f18cc Gerrit-Change-Number: 15029 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 09:02:52 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 833s] ar: `u' modifier ignored since `D' is the default (see `U') [ 833s] libtool: link: ranlib .libs/libtransceiver_common.a [ 833s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 833s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 834s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 834s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 834s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 834s] collect2: error: ld returned 1 exit status [ 834s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 834s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 834s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 834s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 834s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 834s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 834s] make[1]: *** [Makefile:444: all] Error 2 [ 834s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 834s] dh_auto_build: make -j1 returned exit code 2 [ 834s] make: *** [debian/rules:6: build] Error 255 [ 834s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 834s] [ 834s] lamb62 failed "build osmo-trx_1.1.1.dsc" at Wed Aug 21 07:39:11 UTC 2019. [ 834s] [ 834s] ### VM INTERACTION START ### [ 837s] [ 815.362399] sysrq: SysRq : Power Off [ 837s] [ 815.396635] reboot: Power down [ 837s] ### VM INTERACTION END ### [ 837s] [ 837s] lamb62 failed "build osmo-trx_1.1.1.dsc" at Wed Aug 21 07:39:15 UTC 2019. [ 837s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 649s] ar: `u' modifier ignored since `D' is the default (see `U') [ 649s] libtool: link: ranlib .libs/libtransceiver_common.a [ 649s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 649s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 649s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 650s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 650s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 650s] collect2: error: ld returned 1 exit status [ 650s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 650s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 650s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 650s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 650s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 650s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 650s] make[1]: *** [Makefile:444: all] Error 2 [ 650s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 650s] dh_auto_build: make -j1 returned exit code 2 [ 650s] make: *** [debian/rules:6: build] Error 255 [ 650s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 650s] [ 650s] lamb51 failed "build osmo-trx_1.1.1.dsc" at Wed Aug 21 07:30:34 UTC 2019. [ 650s] [ 650s] ### VM INTERACTION START ### [ 653s] [ 588.211715] sysrq: SysRq : Power Off [ 653s] [ 588.218246] reboot: Power down [ 653s] ### VM INTERACTION END ### [ 653s] [ 653s] lamb51 failed "build osmo-trx_1.1.1.dsc" at Wed Aug 21 07:30:37 UTC 2019. [ 653s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 495s] ar: `u' modifier ignored since `D' is the default (see `U') [ 495s] libtool: link: ranlib .libs/libtransceiver_common.a [ 495s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 495s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 495s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 496s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 496s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 496s] collect2: error: ld returned 1 exit status [ 496s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 496s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 496s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 496s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 496s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 496s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 496s] make[1]: *** [Makefile:444: all] Error 2 [ 496s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 496s] dh_auto_build: make -j1 returned exit code 2 [ 496s] make: *** [debian/rules:6: build] Error 255 [ 496s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 496s] [ 496s] lamb62 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Wed Aug 21 07:17:59 UTC 2019. [ 496s] [ 496s] ### VM INTERACTION START ### [ 499s] [ 477.98] sysrq: SysRq : Power Off [ 499s] [ 477.684788] reboot: Power down [ 499s] ### VM INTERACTION END ### [ 499s] [ 499s] lamb62 failed "build osmo-trx_1.1.1.1.3eed8.dsc" at Wed Aug 21 07:18:02 UTC 2019. [ 499s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...osmo-sgsn[master]: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/12009 ) Change subject: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/12009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4ce23ebe50d141076c20c9c56990b7103cd25e55 Gerrit-Change-Number: 12009 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 21 Aug 2019 06:00:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
