[L] Change in pysim[master]: Initial support for eUICC

[laforge]

Attention is currently required from: dexter, fixeria, laforge.

Hello Jenkins Builder, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/34852?usp=email

to look at the new patch set (#8).

The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder


Change subject: Initial support for eUICC
..

Initial support for eUICC

This just adds basic support for the ISD-R application and its
associated STORE DATA command which is used for the ES10x interfaces
between off-card entities and the on-card ISD-R.

Change-Id: Ieab37b083e25d3f36c20f6e9ed3e4bdfdd14a42a
Closes: OS#5637
---
M docs/shell.rst
M pySim-shell.py
A pySim/euicc.py
M pySim/global_platform.py
4 files changed, 565 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/52/34852/8
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34852?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieab37b083e25d3f36c20f6e9ed3e4bdfdd14a42a
Gerrit-Change-Number: 34852
Gerrit-PatchSet: 8
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-CC: fixeria 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-MessageType: newpatchset

[L] Change in pysim[master]: Initial support for eUICC

[laforge]

Attention is currently required from: dexter, fixeria.

Hello Jenkins Builder, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/34852?usp=email

to look at the new patch set (#7).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder


Change subject: Initial support for eUICC
..

Initial support for eUICC

This just adds basic support for the ISD-R application and its
associated STORE DATA command which is used for the ES10x interfaces
between off-card entities and the on-card ISD-R.

Change-Id: Ieab37b083e25d3f36c20f6e9ed3e4bdfdd14a42a
Closes: OS#5637
---
M docs/shell.rst
M pySim-shell.py
A pySim/euicc.py
M pySim/global_platform.py
4 files changed, 565 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/52/34852/7
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34852?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieab37b083e25d3f36c20f6e9ed3e4bdfdd14a42a
Gerrit-Change-Number: 34852
Gerrit-PatchSet: 7
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-CC: fixeria 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-MessageType: newpatchset

[L] Change in pysim[master]: Initial support for eUICC

[laforge]

Attention is currently required from: dexter, fixeria.

Hello Jenkins Builder, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/34852?usp=email

to look at the new patch set (#6).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder


Change subject: Initial support for eUICC
..

Initial support for eUICC

This just adds basic support for the ISD-R application and its
associated STORE DATA command which is used for the ES10x interfaces
between off-card entities and the on-card ISD-R.

Change-Id: Ieab37b083e25d3f36c20f6e9ed3e4bdfdd14a42a
Closes: OS#5637
---
M docs/shell.rst
M pySim-shell.py
A pySim/euicc.py
M pySim/global_platform.py
4 files changed, 459 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/52/34852/6
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34852?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieab37b083e25d3f36c20f6e9ed3e4bdfdd14a42a
Gerrit-Change-Number: 34852
Gerrit-PatchSet: 6
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-CC: fixeria 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-MessageType: newpatchset

[S] Change in pysim[master]: docs: Fix command reference for 'apdu' command

[laforge]

laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/pysim/+/34878?usp=email )


Change subject: docs: Fix command reference for 'apdu' command
..

docs: Fix command reference for 'apdu' command

This fixes the below error during build of the documentation:

pysim/docs/shell.rst:349: ERROR: "" has no 
attribute "apdu_cmd_parser"

Change-Id: If89b66a45ea18b5a3fc56bf77b05e679463da5a8
---
M docs/shell.rst
1 file changed, 14 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/78/34878/1

diff --git a/docs/shell.rst b/docs/shell.rst
index 73b988a..dea0bb4 100644
--- a/docs/shell.rst
+++ b/docs/shell.rst
@@ -342,7 +342,7 @@
 
 .. argparse::
:module: pySim-shell
-   :func: PySimCommands.apdu_cmd_parser
+   :func: PysimApp.apdu_cmd_parser




--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34878?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If89b66a45ea18b5a3fc56bf77b05e679463da5a8
Gerrit-Change-Number: 34878
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-MessageType: newchange

[M] Change in pysim[master]: pySim-shell: Include current logical channel in prompt

[laforge]

Attention is currently required from: fixeria, laforge.

Hello Jenkins Builder, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/34850?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed:
Code-Review+2 by fixeria, Verified+1 by Jenkins Builder

The change is no longer submittable: Code-Review and Verified are unsatisfied 
now.


Change subject: pySim-shell: Include current logical channel in prompt
..

pySim-shell: Include current logical channel in prompt

Now that pySim-shell can switch between logical channels, let's state
the currently used logical channel in the prompt.

Change-Id: I45781a6fba205eeb4ac7f58d5cb642b7131bdd88
Related: OS#6230
---
M docs/shell.rst
M docs/suci-tutorial.rst
M pySim-shell.py
3 files changed, 49 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/50/34850/3
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34850?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I45781a6fba205eeb4ac7f58d5cb642b7131bdd88
Gerrit-Change-Number: 34850
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-MessageType: newpatchset

[M] Change in osmo-ttcn3-hacks[master]: GTPv2: Declare GTP2C_Cause as enum

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34877?usp=email )


Change subject: GTPv2: Declare GTP2C_Cause as enum
..

GTPv2: Declare GTP2C_Cause as enum

Change-Id: Id26f59274d7a8813b64b9b4b7c5c39cc12d5a0ac
---
M library/GTPv2_Templates.ttcn
M pgw/PGW_Tests.ttcn
2 files changed, 56 insertions(+), 26 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/77/34877/1

diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn
index 753774d..6bd3ba6 100644
--- a/library/GTPv2_Templates.ttcn
+++ b/library/GTPv2_Templates.ttcn
@@ -147,28 +147,37 @@


 /* 8.4-1 */
-/*
 type enumerated GTP2C_Cause {
Local_Detach(2),
Complete_Detach (3),
RAT_changed_from_3GPP_to_Non_3GPP   (4),
ISR_deactivation(5),
-   Error_Ind_from_RNC_eNB_SGSN_MME (5),
+   Error_Ind_from_RNC_eNB_SGSN_MME (6),
IMSI_Detach_Only(7),
Reactivation_Required   (8),
-}
-*/
-
-const integer c_GTP2C_Cause_LocalDetach := 1;
+   PDN_reconnection_to_APN_disallowed  (9),
+   Access_changed_from_Non_3GPP_to_3GPP(10),
+   PDN_connection_inactivity_timer_expires (11),
+   PGW_not_responding  (12),
+   Network_Failure (13),
+   QoS_parameter_mismatch  (14),
+   EPS_to_5GS_Mobility (15),
+   Request_accepted(16),
+   Request_accepted_partially  (17),
+   New_PDN_type_due_to_network_preference  (18),
+   New_PDN_type_due_to_single_address_bearer_only (19),
+   /* ... */
+   Context_Not_Found   (64)
+} with { variant "FIELDLENGTH(8)" encode "RAW" };

 /* 8.4 */
-template (value) Cause ts_GTP2C_Cause(template (value) OCT1 cause,
+template (value) Cause ts_GTP2C_Cause(template (value) GTP2C_Cause cause,
  template (value) BIT1 cs) := {
elementIdentifier := '02'O,
lengthIndicator := 0, /* overwritten */
instance := ''B,
spare := ''B,
-   causeValue := cause,
+   causeValue := int2oct(enum2int(valueof(cause)), 1),
cS := cs,
bCE := '0'B,
pCE := '0'B,
@@ -178,12 +187,24 @@
instanceOfOffendingIE := omit,
spare3 := omit
 }
-template (present) Cause tr_GTP2C_Cause(template (present) OCT1 cause) := {
+private function enum2int_GTP2C_Cause_tmpl(template GTP2C_Cause inp) return 
template integer
+{
+   if (istemplatekind(inp, "omit")) {
+   return omit;
+   } else if (istemplatekind(inp, "*")) {
+   return *;
+   } else if (istemplatekind(inp, "?")) {
+   return ?;
+   } else {
+   return enum2int(valueof(inp));
+   }
+}
+template (present) Cause tr_GTP2C_Cause(template (present) GTP2C_Cause cause) 
:= {
elementIdentifier := '02'O,
lengthIndicator := ?,
instance := ?,
spare := ''B,
-   causeValue := cause,
+   causeValue := int2oct_tmpl(enum2int_GTP2C_Cause_tmpl(cause), 1),
cS := ?,
bCE := ?,
pCE := ?,
@@ -193,7 +214,7 @@
instanceOfOffendingIE := *,
spare3 := *
 }
-private function fs_GTP2C_Cause(template (omit) OCT1 cause, template (value) 
BIT1 cs) return
+private function fs_GTP2C_Cause(template (omit) GTP2C_Cause cause, template 
(value) BIT1 cs) return
 template (omit) Cause {
if (istemplatekind(cause, "omit")) {
return omit;
@@ -201,7 +222,7 @@
return ts_GTP2C_Cause(cause, cs);
}
 }
-private function fr_GTP2C_Cause(template OCT1 cause) return
+private function fr_GTP2C_Cause(template GTP2C_Cause cause) return
 template Cause {
if (istemplatekind(cause, "omit")) {
return omit;
@@ -793,7 +814,7 @@
   template (value) PDN_AddressAllocation addr) :=
 ts_PDU_GTP2C(''O, '00'O, '21'O, {
createSessionResponse := {
-   cause := ts_GTP2C_Cause(int2oct(16, 1), '0'B),
+   cause := ts_GTP2C_Cause(Request_accepted, '0'B),
changeReportingAction := omit,
cSG_InformationReportingAction := omit,
heNBInformationReporting := omit,
@@ -824,7 +845,7 @@
 template (present) PDU_GTPCv2
 tr_GTP2C_CreateSessionResp(template (present) OCT4 d_teid := ?,
   template (present) OCT3 seq := ?,
-  template (present) OCT1 cause := ?,
+  template (present) GTP2C_Cause cause := ?,
   template FullyQualifiedTEID_List fteids := *,
   template PDN_AddressAllocation addr := *,
 

[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx MIP6-Feature-Vector in s6b AAR msg

[pespin]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder


Change subject: epdg: Tx MIP6-Feature-Vector in s6b AAR msg
..

epdg: Tx MIP6-Feature-Vector in s6b AAR msg

This AVP is actually mandatory as per Table 9.1.2.2.1 in TS 29.273.

Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774
---
M epdg/EPDG_Tests.ttcn
M library/DIAMETER_ts29_273_Templates.ttcn
2 files changed, 22 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/75/34875/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774
Gerrit-Change-Number: 34875
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx MIP6-Feature-Vector in s6b AAR msg

[pespin]

Attention is currently required from: pespin.

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder


Change subject: epdg: Tx MIP6-Feature-Vector in s6b AAR msg
..

epdg: Tx MIP6-Feature-Vector in s6b AAR msg

This AVP is actually mandatory as per Table 9.1.2.2.1 in TS 29.273.

Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774
---
M epdg/EPDG_Tests.ttcn
M library/DIAMETER_ts29_273_Templates.ttcn
2 files changed, 23 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/75/34875/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774
Gerrit-Change-Number: 34875
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

[M] Change in osmo-ttcn3-hacks[master]: Introduce DIAMETER_rfc5447_Templates.ttcn

[pespin]

Attention is currently required from: pespin.

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder


Change subject: Introduce DIAMETER_rfc5447_Templates.ttcn
..

Introduce DIAMETER_rfc5447_Templates.ttcn

Add templates for RFC 5447 MIP6-Feature-Vector.
This AVP is a bitmask which as only a few bits defined in RFC 5447, with
other interfaces using this AVP adding interface-specific bits in the
spec of each interface.

The templates are added in a new separate file with the aim of start
splitting the tons of AVPs originating from different specs in order to
be able to quickly identify them and avoid confusion.

Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1
---
M epdg/gen_links.sh
A library/DIAMETER_rfc5447_Templates.ttcn
2 files changed, 60 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/74/34874/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1
Gerrit-Change-Number: 34874
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx Service-Selection in s6b AAR msg

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34876?usp=email )


Change subject: epdg: Tx Service-Selection in s6b AAR msg
..

epdg: Tx Service-Selection in s6b AAR msg

This AVP is actually mandatory as per Table 9.1.2.2.1 in TS 29.273.

Change-Id: I86d01a0f5148e98b7faebbe0e3d7617a6c90b559
---
M epdg/EPDG_Tests.ttcn
M library/DIAMETER_ts29_273_Templates.ttcn
2 files changed, 19 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/76/34876/1

diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn
index 5710d0c..580d4d4 100644
--- a/epdg/EPDG_Tests.ttcn
+++ b/epdg/EPDG_Tests.ttcn
@@ -114,6 +114,7 @@

 type record EPDG_ConnHdlrPars {
hexstring imsi,
+   charstring apn,
charstring ue_ip,

/* TEI (Data) local side */
@@ -143,6 +144,7 @@
 runs on MTC_CT return EPDG_ConnHdlrPars {
var EPDG_ConnHdlrPars pars := {
imsi := f_gen_imsi(imsi_suffix),
+   apn := "internet",
ue_ip := "192.168.123.50",
teid := ''O,
teic := ''O,
@@ -375,7 +377,9 @@
 */
f_epdg_connhldr_S6b_expect_eteid(ete_id);

-   S6b.send(ts_DIA_S6b_AAR(g_pars.imsi, 
int2oct(DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED, 8), hbh_id := hbh_id, 
ete_id := ete_id));
+   S6b.send(ts_DIA_S6b_AAR(g_pars.imsi,
+   
int2oct(DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED, 8),
+   g_pars.apn, hbh_id := hbh_id, ete_id := 
ete_id));
alt {
[] S6b.receive(tr_DIA_S6b_AAA) -> value rx_dia {}
[] S6b.receive(PDU_DIAMETER:?) -> value rx_dia {
diff --git a/library/DIAMETER_ts29_273_Templates.ttcn 
b/library/DIAMETER_ts29_273_Templates.ttcn
index 3daf299..38355e7 100644
--- a/library/DIAMETER_ts29_273_Templates.ttcn
+++ b/library/DIAMETER_ts29_273_Templates.ttcn
@@ -207,6 +207,7 @@
 template (value) PDU_DIAMETER
 ts_DIA_S6b_AAR(template (value) hexstring imsi,
   template (value) MIPv6_NONE_MIP6_Feature_Vector mip6_feat_vec,
+  template (value) charstring apn,
   template (value) octetstring sess_id := c_def_sess_id,
   template (value) charstring orig_host := "pgw.localdomain",
   template (value) charstring orig_realm := "localdomain",
@@ -227,7 +228,8 @@
ts_AVP_DestinationRealm(dest_realm),
ts_AVP_AuthRequestType(AUTHORIZE_ONLY),
ts_AVP_UserNameImsi(valueof(imsi)),
-   ts_AVP_MIP6FeatureVector(mip6_feat_vec)
+   ts_AVP_MIP6FeatureVector(mip6_feat_vec),
+   ts_AVP_ServiceSelection(valueof(apn))
/* TODO: Lots other optional */
});


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34876?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I86d01a0f5148e98b7faebbe0e3d7617a6c90b559
Gerrit-Change-Number: 34876
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

[S] Change in osmo-msc[master]: vlr_sgs: fix VTY setting for SGs counter.

[fixeria]

Attention is currently required from: dexter, laforge, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/34871?usp=email )

Change subject: vlr_sgs: fix VTY setting for SGs counter.
..


Patch Set 1: Code-Review+2

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-msc/+/34871/comment/c0090ec1_4fd89661
PS1, Line 10: setting is nevers stored. The reason for this is that OsmoMSC 
uses the
never



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34871?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I0358c1ec0026c37fda6db1f3af3145393df25cfd
Gerrit-Change-Number: 34871
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 23 Oct 2023 16:32:11 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx MIP6-Feature-Vector in s6b AAR msg

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email )


Change subject: epdg: Tx MIP6-Feature-Vector in s6b AAR msg
..

epdg: Tx MIP6-Feature-Vector in s6b AAR msg

This AVP is actually mandatory as per Table 9.1.2.2.1 in TS 29.273.

Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774
---
M epdg/EPDG_Tests.ttcn
M library/DIAMETER_ts29_273_Templates.ttcn
2 files changed, 19 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/75/34875/1

diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn
index 396ca0e..5710d0c 100644
--- a/epdg/EPDG_Tests.ttcn
+++ b/epdg/EPDG_Tests.ttcn
@@ -375,7 +375,7 @@
 */
f_epdg_connhldr_S6b_expect_eteid(ete_id);

-   S6b.send(ts_DIA_S6b_AAR(g_pars.imsi, hbh_id := hbh_id, ete_id := 
ete_id));
+   S6b.send(ts_DIA_S6b_AAR(g_pars.imsi, 
int2oct(DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED, 8), hbh_id := hbh_id, 
ete_id := ete_id));
alt {
[] S6b.receive(tr_DIA_S6b_AAA) -> value rx_dia {}
[] S6b.receive(PDU_DIAMETER:?) -> value rx_dia {
diff --git a/library/DIAMETER_ts29_273_Templates.ttcn 
b/library/DIAMETER_ts29_273_Templates.ttcn
index ee0cd89..3daf299 100644
--- a/library/DIAMETER_ts29_273_Templates.ttcn
+++ b/library/DIAMETER_ts29_273_Templates.ttcn
@@ -24,7 +24,11 @@
 const uint32_t c_DIAMETER_3GPP_S6b_AID := 16777272;

 /* 5.2.3.3 MIP6-Feature-Vector bits */
-const uint64_t MIP6_INTEGRATED := '0001'H;
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_PMIP6_SUPPORTED := 
hex2int('0100'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_ASSIGN_LOCAL_IP := 
hex2int('0800'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_MIP4_SUPPORTED :=  
hex2int('1000'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_OPTIMIZED_IDLE_MODE_MOBILITY 
:= hex2int('2000'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED := 
hex2int('4000'H);

 /***
  * SWx 3GPP TS 29.273 section 8
@@ -202,7 +206,7 @@
  /* TS 29.273 9.2.2.5.1 AA-Request (AAR) */
 template (value) PDU_DIAMETER
 ts_DIA_S6b_AAR(template (value) hexstring imsi,
-  template (value) MIPv6_NONE_MIP6_Feature_Vector feat_vec,
+  template (value) MIPv6_NONE_MIP6_Feature_Vector mip6_feat_vec,
   template (value) octetstring sess_id := c_def_sess_id,
   template (value) charstring orig_host := "pgw.localdomain",
   template (value) charstring orig_realm := "localdomain",
@@ -223,7 +227,7 @@
ts_AVP_DestinationRealm(dest_realm),
ts_AVP_AuthRequestType(AUTHORIZE_ONLY),
ts_AVP_UserNameImsi(valueof(imsi)),
-   ts_AVP_MIP6FeatureVector()
+   ts_AVP_MIP6FeatureVector(mip6_feat_vec)
/* TODO: Lots other optional */
});


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774
Gerrit-Change-Number: 34875
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

[M] Change in osmo-ttcn3-hacks[master]: DIAMETER_Types: Generate fields from RFC 5447

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34873?usp=email )


Change subject: DIAMETER_Types: Generate fields from RFC 5447
..

DIAMETER_Types: Generate fields from RFC 5447

S6b Diameter interface (TS 29.273 section 9) uses the
MIP6-Feature-Vector, which according to TS 29.273 9.2.3.2.3 is defined
in RFC 5447.

Related: OS#6229
Change-Id: I478eff657d876d4ec9a5a1906cab48fbe1b9
---
M library/DIAMETER_Types.ttcn
M library/regen-DIAMETER_Types_ttcn.sh
2 files changed, 109 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/73/34873/1

diff --git a/library/DIAMETER_Types.ttcn b/library/DIAMETER_Types.ttcn
index ee2910b..3a7b3b6 100644
--- a/library/DIAMETER_Types.ttcn
+++ b/library/DIAMETER_Types.ttcn
@@ -4,7 +4,7 @@
 //   //
 ///
 // Generated with command:
-// AVP.sh Base_IETF_RFC3588.ddf BaseTypes_IETF_RFC3588.ddf 
AAAInterface_3GPP_TS29272_f10.ddf GxInterface_PCC_3GPP_TS29212_f10.ddf 
S6Interfaces_3GPP_TS29336_f00.ddf MobileIPv6_HA_IETF_RFC5778.ddf 
RxInterface_PCC_3GPP_TS29214_f20.ddf NetworkAccessServer_IETF_RFC4005.ddf 
CreditControl_IETF_RFC4006.ddf CxDxInterface_3GPP_TS29229_c30.ddf 
GiSGiInterface_3GPP_TS29061_d70.ddf ChargingApplications_3GPP_TS32299_d90.ddf
+// AVP.sh Base_IETF_RFC3588.ddf BaseTypes_IETF_RFC3588.ddf 
AAAInterface_3GPP_TS29272_f10.ddf GxInterface_PCC_3GPP_TS29212_f10.ddf 
S6Interfaces_3GPP_TS29336_f00.ddf MobileIPv6_HA_IETF_RFC5778.ddf 
RxInterface_PCC_3GPP_TS29214_f20.ddf NetworkAccessServer_IETF_RFC4005.ddf 
CreditControl_IETF_RFC4006.ddf CxDxInterface_3GPP_TS29229_c30.ddf 
GiSGiInterface_3GPP_TS29061_d70.ddf ChargingApplications_3GPP_TS32299_d90.ddf 
MobileIPv6_NAS_IETF_RFC5447.ddf
 module DIAMETER_Types {
 /**
 * Copyright (c) 2000-2019 Ericsson Telecom AB
@@ -8294,8 +8294,73 @@
 type AVP_Unsigned32 DCA_3GPP_Volume_Quota_Threshold


-// STATISTICS: 1121 AVP descriptors found
-// STATISTICS: 1121 AVP type definitions matching AVP descriptors found
+/**
+* Copyright (c) 2000-2019 Ericsson Telecom AB
+* All rights reserved. This program and the accompanying materials
+* are made available under the terms of the Eclipse Public License v2.0
+* which accompanies this distribution, and is available at
+* https://www.eclipse.org/org/documents/epl-2.0/EPL-2.0.html
+*
+* Contributors:
+*   Roland Gecse - initial implementation and initial documentation
+*   Akos Pernek
+*   Antal Wuh.Hen.Chang
+*   Attila Fulop
+*   Balazs Barcsik
+*   Bence Molnar
+*   Csaba Koppany
+*   David Juhasz
+*   Eduard Czimbalmos
+*   Elemer Lelik
+*   Endre Kiss
+*   Endre Kulcsar
+*   Gabor Szalai
+*   Gabor Tatarka
+*   Gergely Futo
+*   Istvan Sandor
+*   Krisztian Pandi
+*   Kulcsár Endre
+*   Laszlo Tamas Zeke
+*   Norbert Pinter
+*   Roland Gecse
+*   Tibor Bende
+*   Tibor Szabo
+*   Timea Moder
+*   Zoltan Medve
+*   Zsolt Nandor Torok
+*   Zsolt Szalai
+**/
+//
+//  File:   MobileIPv6_NAS_IETF_RFC5447.ddf
+//  Description:DDF for Mobile IPv6 according to RFC 5447
+//  Rev:R55A
+//  Prodnr: CNL113462
+///
+
+// APPLICATION-NAME: MIPv6
+// APPLICATION-REVISION: RFC5447
+
+// RFC 5447 4.2.1
+// AVP: MIP6-Agent-Info (486)
+type AVP_Grouped MIPv6_NONE_MIP6_Agent_Info
+
+// RFC 5447 4.2.2
+// AVP: MIP6-Home-Agent-Address (334)
+type AVP_Address MIPv6_NONE_MIP6_Home_Agent_Address
+
+// RFC 5447 4.2.3
+// AVP: MIP6-Home-Agent-Host (348)
+type AVP_Grouped MIPv6_NONE_MIP6_Home_Agent_Host
+
+// RFC 5447 4.2.4
+// AVP: MIP6-Home-Link-Prefix (125)
+type AVP_OctetString MIPv6_NONE_MIP6_Home_Link_Prefix
+
+// RFC 5447 4.2.5
+// AVP: MIP6-Feature-Vector (124)
+type AVP_Unsigned64 MIPv6_NONE_MIP6_Feature_Vector
+// STATISTICS: 1126 AVP descriptors found
+// STATISTICS: 1126 AVP type definitions matching AVP descriptors found
 // STATISTICS:  duplicate AVP definitions deleted
 type enumerated Command_Code {
  Abort_Session (274), Accounting (271), Capabilities_Exchange (257), 
Device_Watchdog (280), Disconnect_Peer (282), Re_Auth (258), 
Session_Termination (275), Experimental1 (16777214), Experimental2 (16777215) , 
Update_Location (316), Cancel_Location (317), Authentication_Information (318), 
Insert_Subscriber_Data (319), Delete_Subscriber_Data (320), Purge_UE (321), 
Reset (322), Notify (323), ME_Identity_Check (324), Update_VCSG_Location 
(8388638), Cancel_VCSG_Location (8388642), Credit_Control (272), TDF_Session 
(8388637), Subscriber_Information (8388641), Configuration_Information 
(8388718), Reporting_Information (8388719), 

[L] Change in osmo-ttcn3-hacks[master]: library/DIAMETER: Split TS 29.273 templates into its own file

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34872?usp=email )


Change subject: library/DIAMETER: Split TS 29.273 templates into its own file
..

library/DIAMETER: Split TS 29.273 templates into its own file

The templates are added in a new separate file with the aim of starting
splitting the tons of AVPs originating from different specs in order to
be able to quickly identify them and avoid confusion.

Change-Id: I77f917404dd70559b2b2cc62199ed70289ab0825
---
M epdg/EPDG_Tests.ttcn
M epdg/gen_links.sh
M library/DIAMETER_Templates.ttcn
A library/DIAMETER_ts29_273_Templates.ttcn
4 files changed, 264 insertions(+), 228 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/72/34872/1

diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn
index 76fd45e..396ca0e 100644
--- a/epdg/EPDG_Tests.ttcn
+++ b/epdg/EPDG_Tests.ttcn
@@ -12,6 +12,7 @@

 import from DIAMETER_Types all;
 import from DIAMETER_Templates all;
+import from DIAMETER_ts29_273_Templates all;
 import from DIAMETER_Emulation all;

 import from GTPv2_Types all;
diff --git a/epdg/gen_links.sh b/epdg/gen_links.sh
index 326d82e..b464203 100755
--- a/epdg/gen_links.sh
+++ b/epdg/gen_links.sh
@@ -41,7 +41,8 @@
 FILES="Misc_Helpers.ttcn General_Types.ttcn GSM_Types.ttcn Osmocom_Types.ttcn 
Native_Functions.ttcn Native_FunctionDefs.cc "
 FILES+="Osmocom_CTRL_Types.ttcn "
 FILES+="L3_Common.ttcn "
-FILES+="DIAMETER_Types.ttcn DIAMETER_CodecPort.ttcn 
DIAMETER_CodecPort_CtrlFunct.ttcn DIAMETER_CodecPort_CtrlFunctDef.cc 
DIAMETER_Emulation.ttcn DIAMETER_Templates.ttcn "
+FILES+="DIAMETER_Types.ttcn DIAMETER_CodecPort.ttcn 
DIAMETER_CodecPort_CtrlFunct.ttcn DIAMETER_CodecPort_CtrlFunctDef.cc 
DIAMETER_Emulation.ttcn "
+FILES+="DIAMETER_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn "
 FILES+="IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn 
IPA_CodecPort_CtrlFunctDef.cc
 IPA_Emulation.ttcnpp "
 FILES+="GSUP_Types.ttcn GSUP_Emulation.ttcn "
diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn
index f46bf37..3b4590e 100644
--- a/library/DIAMETER_Templates.ttcn
+++ b/library/DIAMETER_Templates.ttcn
@@ -125,10 +125,6 @@
 const uint32_t c_DIAMETER_3GPP_S6_AID := 16777251;
 const uint32_t c_DIAMETER_3GPP_S13_AID := 16777252;
 const uint32_t c_DIAMETER_3GPP_S7_AID := 16777308;
-/* 3GPP TS 29.273 Section 8.2 */
-const uint32_t c_DIAMETER_3GPP_SWx_AID := 16777265;
-/* 3GPP TS 29.273 Section 9 */
-const uint32_t c_DIAMETER_3GPP_S6b_AID := 16777272;

 const octetstring c_def_sess_id := char2oct("ttcn3.session");

@@ -2306,227 +2302,4 @@
}
 }

-/***
- * SWx 3GPP TS 29.273 section 8
- ***/
-
-/* SIP-Auth-Data-Item , 3GPP TS 29.273 8.2.3.9 */
-template (present) GenericAVP tr_AVP_3GPP_SIPAuthDataItem(template (present) 
uint32_t num := ?) := {
-   avp := {
-   avp_header := 
tr_DIA_Hdr_3GPP(c_AVP_Code_CxDx_3GPP_SIP_Auth_Data_Item),
-   avp_data := {
-   avp_CxDx_3GPP_SIP_Auth_Data_Item := superset(
-   //tr_AVP_3GPP_SIPItemNumber(num), /* Optional */
-   tr_AVP_3GPP_SIPAuthScheme(?)//, /* Optional */
-   //tr_AVP_3GPP_SIPAuthenticate(?), /* Optional */
-   //tr_AVP_3GPP_SIPAuthorization(?), /* Optional 
*/
-   //tr_AVP_3GPP_SIPAuthContext(?), /* Optional */
-   //tr_AVP_3GPP_ConfidentialityKey(?), /* 
Optional */
-   //tr_AVP_3GPP_IntegrityKey(?) /* Optional */
-   /* TODO:
-   [ SIP-Digest-Authenticate ]
-   [ Framed-IP-Address ]
-   [ Framed-IPv6-Prefix ]
-   [ Framed-Interface-Id ]
-   [ Line-Identifier ]
-   *[AVP]
-   */
-   )
-   }
-   }
-}
-template (value) GenericAVP ts_AVP_3GPP_SIPAuthDataItem(uint32_t num, OCT16 
rand, OCT16 ik, OCT16 ck, OCT16 autn, OCT14 auts) := {
-   avp := {
-   avp_header := 
ts_DIA_Hdr_3GPP(c_AVP_Code_CxDx_3GPP_SIP_Auth_Data_Item),
-   avp_data := {
-   avp_CxDx_3GPP_SIP_Auth_Data_Item := {
-   ts_AVP_3GPP_SIPItemNumber(num),
-   
ts_AVP_3GPP_SIPAuthScheme(char2oct("Digest-AKAv1-MD5")),
-   ts_AVP_3GPP_SIPAuthenticate(rand & autn),
-   ts_AVP_3GPP_SIPAuthorization(rand & auts),
-   ts_AVP_3GPP_SIPAuthContext(char2oct("foobar")),
-   ts_AVP_3GPP_ConfidentialityKey(ck),
- 

[M] Change in osmo-ttcn3-hacks[master]: Introduce DIAMETER_rfc5447_Templates.ttcn

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email )


Change subject: Introduce DIAMETER_rfc5447_Templates.ttcn
..

Introduce DIAMETER_rfc5447_Templates.ttcn

Add templates for RFC 5447 MIP6-Feature-Vector.
This AVP is a bitmask which as only a few bits defined in RFC 5447, with
other interfaces using this AVP adding interface-specific bits in the
spec of each interface.

The templates are added in a new separate file with the aim of start
splitting the tons of AVPs originating from different specs in order to
be able to quickly identify them and avoid confusion.

Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1
---
M epdg/gen_links.sh
A library/DIAMETER_rfc5447_Templates.ttcn
M library/DIAMETER_ts29_273_Templates.ttcn
3 files changed, 67 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/74/34874/1

diff --git a/epdg/gen_links.sh b/epdg/gen_links.sh
index b464203..bc9d90e 100755
--- a/epdg/gen_links.sh
+++ b/epdg/gen_links.sh
@@ -42,7 +42,7 @@
 FILES+="Osmocom_CTRL_Types.ttcn "
 FILES+="L3_Common.ttcn "
 FILES+="DIAMETER_Types.ttcn DIAMETER_CodecPort.ttcn 
DIAMETER_CodecPort_CtrlFunct.ttcn DIAMETER_CodecPort_CtrlFunctDef.cc 
DIAMETER_Emulation.ttcn "
-FILES+="DIAMETER_Templates.ttcn DIAMETER_ts29_273_Templates.ttcn "
+FILES+="DIAMETER_Templates.ttcn DIAMETER_rfc5447_Templates.ttcn 
DIAMETER_ts29_273_Templates.ttcn "
 FILES+="IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn 
IPA_CodecPort_CtrlFunctDef.cc
 IPA_Emulation.ttcnpp "
 FILES+="GSUP_Types.ttcn GSUP_Emulation.ttcn "
diff --git a/library/DIAMETER_rfc5447_Templates.ttcn 
b/library/DIAMETER_rfc5447_Templates.ttcn
new file mode 100644
index 000..4c119c7
--- /dev/null
+++ b/library/DIAMETER_rfc5447_Templates.ttcn
@@ -0,0 +1,41 @@
+module DIAMETER_rfc5447_Templates {
+
+/* (C) 2023 by sysmocom s.f.m.c. GmbH https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34874?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0fc646e5354d78283a2f3e1b9bb9c4688cf744a1
Gerrit-Change-Number: 34874
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

[M] Change in osmo-msc[master]: manuals: add section about the SGs interface.

[fixeria]

Attention is currently required from: dexter, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email )

Change subject: manuals: add section about the SGs interface.
..


Patch Set 1:

(5 comments)

File doc/manuals/chapters/running.adoc:

https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/39c9ce3f_49db50ec
PS1, Line 78: see section <>
missing dot at the end of sentence


File doc/manuals/chapters/sgs.adoc:

https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/197f15aa_7a614d0b
PS1, Line 5: It's
Its (not it is)


https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/bf031fab_4426e89d
PS1, Line 31: ts5, ts6-2, ts7, ts11, ts14, ts15
cosmetic: use \` text \` for `highlighting`


https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/92ec4377_526ea070
PS1, Line 50: show sgs-connections
cosmetic: use \` text \` for `highlighting`


https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/cc441d2b_84506370
PS1, Line 51: OsmoMSC
missing dot



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic7c17511ee19cb7f6d5069b27beb661ecb4b0be8
Gerrit-Change-Number: 34870
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 23 Oct 2023 16:22:39 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmo-msc[master]: running: fix link to MNCC for External Call Control

[fixeria]

Attention is currently required from: dexter, laforge, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/34869?usp=email )

Change subject: running: fix link to MNCC for External Call Control
..


Patch Set 1: Code-Review-1

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-msc/+/34869/comment/42055048_4edf411d
PS1, Line 11: outdated
Not sure what you mean by "outdated" here. Label `mncc` points to the MNCC 
chapter, explaining what MNCC is all about. Label `mncc-external` explains the 
aspects of using an external MNCC handler. I see no problem here. Maybe the 
chapter name is confusing?



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34869?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I5b0fd848e6b28bf670d9994da8a56cb613158290
Gerrit-Change-Number: 34869
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 23 Oct 2023 16:08:15 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in osmo-msc[master]: manuals: add section about the SGs interface.

[laforge]

Attention is currently required from: dexter, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email )

Change subject: manuals: add section about the SGs interface.
..


Patch Set 1:

(3 comments)

File doc/manuals/chapters/sgs.adoc:

https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/f66de8d8_e1f96e55
PS1, Line 4: SGs/SGsAP
The interface is called SGs.  The application layer protocol for it is SGsAP.  
SO if you want to mention both and stay correct, you'd have to phrase it like 
"offers a SGs interface using the SGsAP protocol" or the like.


https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/4794f557_2275e5d8
PS1, Line 5: LTE/EPC
you used "2G (GERAN)" before, then here it would make sense to use the same 
format e.g. "4G (EUTRAN)" or if needed "4G (EUTRAN/LTE)"


https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/861d2b51_9da779e3
PS1, Line 44: In case multiple instances of OsmoMSC run in parallel, it is 
advised to use a
: different vlr-name for each instance
you might want to add that they of course need to be bound to different IP 
addresses.  btw: the vlr-name is usually the DNS name for the IP address of 
that VLR/MSC, so they should agree.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic7c17511ee19cb7f6d5069b27beb661ecb4b0be8
Gerrit-Change-Number: 34870
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 23 Oct 2023 16:07:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-msc[master]: manuals: add section about the SGs interface.

[dexter]

dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email )


Change subject: manuals: add section about the SGs interface.
..

manuals: add section about the SGs interface.

The SGs interface is currently only casually mentioned in the chapter
running, even though the SGs interface is a prominent and often
requested feature. Let's give the SGs interface its own section so that
users can find the info about it quicker.

Related: OS#6008
Change-Id: Ic7c17511ee19cb7f6d5069b27beb661ecb4b0be8
---
M doc/manuals/chapters/running.adoc
A doc/manuals/chapters/sgs.adoc
M doc/manuals/osmomsc-usermanual.adoc
3 files changed, 70 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/70/34870/1

diff --git a/doc/manuals/chapters/running.adoc 
b/doc/manuals/chapters/running.adoc
index 0db5761..1fa5540 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -74,15 +74,8 @@

 More on MNCC in <>.

-The SGs interface by default listens on 0.0.0.0:29118. Configure a different 
IP and/or port for each osmo-msc instance.
-You may also want to configure different VLR names:
-
-
-sgs
- local-ip 127.0.0.1
- local-port 29118
- vlr-name vlr.example.net
-
+The SGs interface by default listens on 0.0.0.0:29118 (SCTP). Each instance of 
OsmoMSC must use a different IP address
+and/or port. For details about the configuration of the SGs interface, see 
section <>

 For the following links, OsmoMSC acts as a client and does not listen/bind to a
 specific interface, and will hence not encounter conflicts for multiple 
instances
diff --git a/doc/manuals/chapters/sgs.adoc b/doc/manuals/chapters/sgs.adoc
new file mode 100644
index 000..4ce4360
--- /dev/null
+++ b/doc/manuals/chapters/sgs.adoc
@@ -0,0 +1,51 @@
+[[sgs]]
+== SGs interface
+
+OsmoMSC offers an SGs/SGsAP interface. The SGs interface is an optional
+interface between a 2G (GERAN) / 3G (UTRAN) MSC and an LTE/EPC MME. It's 
purpose
+is to facilitate both CSFB (Circuit-Switched Fall Back) and SMSoS (SMS over 
SGs).
+It is used for Mobility management (MM) and paging procedures between the EPS
+(Evolved Packet Services) and CS (Circuit Switched) domain.
+
+=== VTY configuration
+
+The SGs interface implementation in OsmoMSC is automatically active and 
requires
+only minimal configuration. When no specific configuration is provided OsmoMSC
+will listen on 0.0.0.0:29118 (SCTP) for incoming connections.
+
+This is sufficient in the most configurations, but in larger installations,
+where services are either tied to specific interfaces and/or more instances of
+OsmoMSC run in parallel, a custom configuration is necessary.
+
+The user has the option to configure the IP address and the SCTP port and also
+the vlr-name that OsmoMSC uses to identify itself towards the MME.
+
+
+sgs
+ local-ip 127.0.0.1
+ local-port 29118
+ vlr-name vlr.example.net
+
+
+In order to fine tune the behavior of the SGs interface the user also has
+control over the relevant timers (ts5, ts6-2, ts7, ts11, ts14, ts15) and
+counters (ns7, ns11). Each timer and counter has to be configured separately.
+In the following example we change the value of ts and ns11.
+
+
+sgs
+ timer ts7 23
+ counter ns11 100
+
+
+
+[NOTE]
+
+In case multiple instances of OsmoMSC run in parallel, it is advised to use a
+different vlr-name for each instance.
+
+
+=== Connection monitoring
+
+The user can use the VTY command "show sgs-connections" to list the MMEs that
+are currently connected to OsmoMSC
diff --git a/doc/manuals/osmomsc-usermanual.adoc 
b/doc/manuals/osmomsc-usermanual.adoc
index ad55e53..45be140 100644
--- a/doc/manuals/osmomsc-usermanual.adoc
+++ b/doc/manuals/osmomsc-usermanual.adoc
@@ -38,6 +38,8 @@

 include::./common/chapters/mgwpool.adoc[]

+include::{srcdir}/chapters/sgs.adoc[]
+
 include::./common/chapters/control_if.adoc[]

 include::./common/chapters/gsup.adoc[]

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic7c17511ee19cb7f6d5069b27beb661ecb4b0be8
Gerrit-Change-Number: 34870
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-MessageType: newchange

[S] Change in osmo-msc[master]: vlr_sgs: fix VTY setting for SGs counter.

[dexter]

dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/34871?usp=email )


Change subject: vlr_sgs: fix VTY setting for SGs counter.
..

vlr_sgs: fix VTY setting for SGs counter.

When trying to modify the value of an SGs counter (eg. ns11), then the
setting is nevers stored. The reason for this is that OsmoMSC uses the
wrong string table to compare the user input.

Related: OS#6008
Change-Id: I0358c1ec0026c37fda6db1f3af3145393df25cfd
---
M include/osmocom/msc/vlr_sgs.h
1 file changed, 15 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/71/34871/1

diff --git a/include/osmocom/msc/vlr_sgs.h b/include/osmocom/msc/vlr_sgs.h
index 7231449..aade5d3 100644
--- a/include/osmocom/msc/vlr_sgs.h
+++ b/include/osmocom/msc/vlr_sgs.h
@@ -69,7 +69,7 @@
 extern const struct value_string sgs_state_counter_names[];
 static inline const char *vlr_sgs_state_counter_name(enum vlr_sgs_state_ctr Ns)
 {
-   return get_value_string(sgs_state_timer_names, Ns);
+   return get_value_string(sgs_state_counter_names, Ns);
 }

 /* This callback function is called when an SGs location update is complete */

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34871?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I0358c1ec0026c37fda6db1f3af3145393df25cfd
Gerrit-Change-Number: 34871
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-MessageType: newchange

[S] Change in osmo-msc[master]: running: fix link to MNCC for External Call Control

[dexter]

dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/34869?usp=email )


Change subject: running: fix link to MNCC for External Call Control
..

running: fix link to MNCC for External Call Control

The label of the section 18 "MNCC for External Call Control" is
reachable under the label <> and not under <>,
which seems to be outdated.

Change-Id: I5b0fd848e6b28bf670d9994da8a56cb613158290
---
M doc/manuals/chapters/running.adoc
1 file changed, 14 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/69/34869/1

diff --git a/doc/manuals/chapters/running.adoc 
b/doc/manuals/chapters/running.adoc
index d6e734b..0db5761 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -72,7 +72,7 @@
  mncc external /tmp/mncc_socket
 

-More on MNCC in <>.
+More on MNCC in <>.

 The SGs interface by default listens on 0.0.0.0:29118. Configure a different 
IP and/or port for each osmo-msc instance.
 You may also want to configure different VLR names:

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34869?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I5b0fd848e6b28bf670d9994da8a56cb613158290
Gerrit-Change-Number: 34869
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-MessageType: newchange

[S] Change in osmo-bsc[master]: neighbor_ident: Use ctrl_interface_setup2() instead of ctrl_interface...

[pespin]

Attention is currently required from: arehbein.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/34868?usp=email )

Change subject: neighbor_ident: Use ctrl_interface_setup2() instead of 
ctrl_interface_setup_dynip2() (deprecated)
..


Patch Set 1: Code-Review-1

(1 comment)

File src/osmo-bsc/neighbor_ident.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34868/comment/0bb11b16_9ff29e0e
PS1, Line 492:  return ctrl_interface_setup2(net, net->neigh_ctrl.port, NULL, 
_LAST_CTRL_NODE_NEIGHBOR);
I'm not sure this is correct, because this is a separate CTRL interface with 
specific needs (now deprecated).

With this patch you would be applying the same IP address as for the general 
CTRL interface, which is unexpected here. I don't see net->neigh_ctrl.addr 
being passed here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34868?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I612401b5bac5650e65d3bb4df09fd0310175ffa6
Gerrit-Change-Number: 34868
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: msuraev 
Gerrit-Attention: arehbein 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:54:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-bsc[master]: neighbor_ident: Use ctrl_interface_setup2() instead of ctrl_interface...

[pespin]

Attention is currently required from: arehbein.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/34868?usp=email )

Change subject: neighbor_ident: Use ctrl_interface_setup2() instead of 
ctrl_interface_setup_dynip2() (deprecated)
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34868?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I612401b5bac5650e65d3bb4df09fd0310175ffa6
Gerrit-Change-Number: 34868
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: msuraev 
Gerrit-Attention: arehbein 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:53:07 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-bsc[master]: neighbor_ident: Use ctrl_interface_setup2() instead of ctrl_interface...

[arehbein]

Attention is currently required from: pespin.

arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/34868?usp=email )

Change subject: neighbor_ident: Use ctrl_interface_setup2() instead of 
ctrl_interface_setup_dynip2() (deprecated)
..


Patch Set 1:

(1 comment)

This change is ready for review.

Patchset:

PS1:
Hi,

not sure if this wasn't changed on purpose ( @msur...@sysmocom.de worked on 
this this, but it's related to an issue I was assigned due to the similarity).

Should I abandon this or activate the patch?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34868?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I612401b5bac5650e65d3bb4df09fd0310175ffa6
Gerrit-Change-Number: 34868
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein 
Gerrit-Reviewer: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-CC: msuraev 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:52:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: GSUP_Types: Add EDPG_Tunnel messages

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34832?usp=email )

Change subject: GSUP_Types: Add EDPG_Tunnel messages
..

GSUP_Types: Add EDPG_Tunnel messages

Change-Id: Iadba149e6d299e5e666b2debdc23a00d37e78da5
---
M library/GSUP_Types.ttcn
1 file changed, 40 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved




diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index 739dcbc..c3563bc 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -138,7 +138,11 @@
OSMO_GSUP_MSGT_E_CLOSE  ('01000111'B),
OSMO_GSUP_MSGT_E_ABORT  ('01001011'B),

-   OSMO_GSUP_MSGT_E_ROUTING_ERROR  ('01001110'B)
+   OSMO_GSUP_MSGT_E_ROUTING_ERROR  ('01001110'B),
+
+   OSMO_GSUP_MSGT_EPDG_TUNNEL_REQUEST  ('0101'B),
+   OSMO_GSUP_MSGT_EPDG_TUNNEL_ERROR('01010001'B),
+   OSMO_GSUP_MSGT_EPDG_TUNNEL_RESULT   ('01010010'B)
 } with { variant "FIELDLENGTH(8)" };

 type enumerated GSUP_CancelType {
@@ -687,6 +691,32 @@
tr_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_ERROR, f_gen_tr_ies(imsi, cause := 
cause, destination_name := destination_name));


+/* EPDG Tunnel */
+template (value) GSUP_PDU ts_GSUP_EPDGTunnel_REQ(hexstring imsi, GSUP_CnDomain 
dom := OSMO_GSUP_CN_DOMAIN_PS,
+template (omit) octetstring 
source_name := omit) :=
+   ts_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_REQUEST, f_gen_ts_ies(imsi, dom := 
dom,
+
source_name := source_name));
+
+template (present) GSUP_PDU tr_GSUP_EPDGTunnel_REQ(template (present) 
hexstring imsi := ?) :=
+   tr_GSUP_IMSI(OSMO_GSUP_MSGT_EPDG_TUNNEL_REQUEST, imsi);
+
+template (value) GSUP_PDU ts_GSUP_EPDGTunnel_RES(hexstring imsi, octetstring 
destination_name := ''O) :=
+   ts_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_RESULT, { 
valueof(ts_GSUP_IE_IMSI(imsi)),
+   
valueof(ts_GSUP_IE_Destination_Name(destination_name))});
+
+template (present) GSUP_PDU tr_GSUP_EPDGTunnel_RES(template (present) 
hexstring imsi, template octetstring destination_name := omit) :=
+   tr_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_RESULT, f_gen_tr_ies(imsi, 
destination_name := destination_name));
+
+template (value) GSUP_PDU ts_GSUP_EPDGTunnel_ERR(hexstring imsi, integer 
cause) :=
+   ts_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_ERROR, {
+   valueof(ts_GSUP_IE_IMSI(imsi)), 
valueof(ts_GSUP_IE_Cause(cause)) });
+
+template (present) GSUP_PDU tr_GSUP_EPDGTunnel_ERR(template (present) 
hexstring imsi, template (present) integer cause := ?,
+   template octetstring destination_name := omit) :=
+   tr_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_ERROR,
+   f_gen_tr_ies(imsi, cause := cause, destination_name := 
destination_name));
+
+
 template (value) GSUP_IE ts_GSUP_IE_CancelType(GSUP_CancelType ctype) := {
tag := OSMO_GSUP_CANCEL_TYPE_IE,
len := 0, /* overwritten */

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34832?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadba149e6d299e5e666b2debdc23a00d37e78da5
Gerrit-Change-Number: 34832
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[L] Change in ...osmo-epdg[master]: Initial S6b support

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email )

Change subject: Initial S6b support
..

Initial S6b support

So far only the Rx of AAR msg and Tx of AAA is supported.
This allows already going forward during the session creation, where PGW
sends AAR to the AAA server and expects AAA message.

Related: OS#6229
Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
---
M config/sys.config
A src/aaa_diameter_s6b.erl
A src/aaa_diameter_s6b_cb.erl
M src/osmo_epdg_sup.erl
4 files changed, 305 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  lynxis lazus: Looks good to me, approved




diff --git a/config/sys.config b/config/sys.config
index 1b89e86..630a057 100755
--- a/config/sys.config
+++ b/config/sys.config
@@ -5,15 +5,22 @@
   [% GSUP Server connection parameters
{gsup_local_ip, "0.0.0.0"},
{gsup_local_port, 4222},
-   % Diameter Connection parameters
+   % Diameter SWx Connection parameters
{diameter_remote_ip, "127.0.0.1"},
{diameter_remote_port, 3868},
{diameter_proto, sctp},
-   % Diameter Server parameters
{vendor_id, 0},
{origin_host, "epdg.localdomain"},
{origin_realm, "localdomain"},
{context_id, "epdg@localdomain"},
+   % Diameter s6b Connection parameters
+   {dia_s6b_local_ip, "127.0.0.10"},
+   {dia_s6b_local_port, 3868},
+   {dia_s6b_proto, sctp},
+   {dia_s6b_vendor_id, 0},
+   {dia_s6b_origin_host, "aaa.localdomain"},
+   {dia_s6b_origin_realm, "localdomain"},
+   {dia_s6b_context_id, "aaa@localdomain"},
% GTPv2C Connection parameters
{gtpc_local_ip, "127.0.0.2"},
{gtpc_local_port, 2123},
diff --git a/src/aaa_diameter_s6b.erl b/src/aaa_diameter_s6b.erl
new file mode 100644
index 000..4ee0219
--- /dev/null
+++ b/src/aaa_diameter_s6b.erl
@@ -0,0 +1,203 @@
+% S6b: AAA side
+%
+% 3GPP TS 29.273 section 9
+%
+% (C) 2023 by sysmocom - s.f.m.c. GmbH 
+% Author: Pau Espin Pedrol 
+%
+% All Rights Reserved
+%
+% This program is free software; you can redistribute it and/or modify
+% it under the terms of the GNU Affero General Public License as
+% published by the Free Software Foundation; either version 3 of the
+% License, or (at your option) any later version.
+%
+% This program is distributed in the hope that it will be useful,
+% but WITHOUT ANY WARRANTY; without even the implied warranty of
+% MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+% GNU General Public License for more details.
+%
+% You should have received a copy of the GNU Affero General Public License
+% along with this program.  If not, see .
+%
+% Additional Permission under GNU AGPL version 3 section 7:
+%
+% If you modify this Program, or any covered work, by linking or
+% combining it with runtime libraries of Erlang/OTP as released by
+% Ericsson on http://www.erlang.org (or a modified version of these
+% libraries), containing parts covered by the terms of the Erlang Public
+% License (http://www.erlang.org/EPLICENSE), the licensors of this
+% Program grant you additional permission to convey the resulting work
+% without the need to license the runtime libraries of Erlang/OTP under
+% the GNU Affero General Public License. Corresponding Source for a
+% non-source form of such a combination shall include the source code
+% for the parts of the runtime libraries of Erlang/OTP used as well as
+% that of the covered work.
+
+
+-module(aaa_diameter_s6b).
+-author('Pau Espin Pedrol ').
+
+-behaviour(gen_server).
+
+-include_lib("diameter_3gpp_ts29_273_s6b.hrl").
+-include_lib("diameter/include/diameter_gen_base_rfc6733.hrl").
+
+%% API Function Exports
+-export([start_link/0]).
+-export([start/0, stop/0, terminate/2]).
+%% gen_server Function Exports
+-export([init/1, handle_call/3, handle_cast/2, handle_info/2]).
+-export([code_change/3]).
+-export([multimedia_auth_request/6]).
+-export([server_assignment_request/3]).
+-export([test/0, test/1]).
+
+%% Diameter Application Definitions
+-define(SERVER, ?MODULE).
+-define(SVC_NAME, ?MODULE).
+-define(APP_ALIAS, ?MODULE).
+-define(CALLBACK_MOD, aaa_diameter_s6b_cb).
+-define(DIAMETER_DICT_S6b, diameter_3gpp_ts29_273_s6b).
+-define(ENV_APP_NAME, osmo_epdg).
+-define(ENV_DEFAULT_SESSION_ID, "aaa@localdomain").
+-define(ENV_DEFAULT_ORIG_REALM, "localdomain").
+-define(ENV_DEFAULT_ORIG_HOST, "aaa.localdomain").
+-define(ENV_DEFAULT_VENDOR_ID, 0).
+-define(ENV_DEFAULT_DIAMETER_PROTO, sctp).
+-define(ENV_DEFAULT_DIAMETER_REMOTE_IP, "127.0.0.10").
+-define(ENV_DEFAULT_DIAMETER_REMOTE_PORT, 3868).
+
+-define(VENDOR_ID_3GPP, 10415).
+-define(VENDOR_ID_3GPP2, 5535).
+-define(VENDOR_ID_ETSI, 13019).
+-define(DIAMETER_APP_ID_S6b, ?DIAMETER_DICT_S6b:id()).
+%% The service configuration. As in the server example, a client
+%% supporting multiple Diameter applications may or may not want to
+%% configure a common callback module on all applications.

[S] Change in docker-playground[master]: ttcn3-epdg-test: Update config file to set up GTPv2C socket

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/34834?usp=email )

Change subject: ttcn3-epdg-test: Update config file to set up GTPv2C socket
..

ttcn3-epdg-test: Update config file to set up GTPv2C socket

Depends: osmo-epdg.git I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Depends: osmo-ttcn3-hacks.git I8f18c927b1897806233cc9d049c25694c1e639d4
Change-Id: I05ae2d87e16cef9772bc5c3690f687e5ecbd5f51
---
M ttcn3-epdg-test/osmo-epdg.config
1 file changed, 19 insertions(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified
  laforge: Looks good to me, approved




diff --git a/ttcn3-epdg-test/osmo-epdg.config b/ttcn3-epdg-test/osmo-epdg.config
index ac8828a..8036b2c 100644
--- a/ttcn3-epdg-test/osmo-epdg.config
+++ b/ttcn3-epdg-test/osmo-epdg.config
@@ -14,5 +14,12 @@
{vendor_id, 0},
{origin_host, "epdg.localdomain"},
{origin_realm, "localdomain"},
-   {context_id, "epdg@localdomain"}]}
+   {context_id, "epdg@localdomain"},
+   % GTPv2C Connection parameters
+   {gtpc_local_ip, "172.18.10.20"},
+   {gtpc_local_port, 2123},
+   {gtpc_remote_ip, "172.18.10.103"},
+   {gtpc_remote_port, 2123}
+  ]
+ }
 ].

--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34834?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I05ae2d87e16cef9772bc5c3690f687e5ecbd5f51
Gerrit-Change-Number: 34834
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[M] Change in osmo-ttcn3-hacks[master]: epdg: Test GTPv2C CreateSession triggerd by EPDG_Tunnel Req

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34833?usp=email )

 (

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: epdg: Test GTPv2C CreateSession triggerd by EPDG_Tunnel Req
..

epdg: Test GTPv2C CreateSession triggerd by EPDG_Tunnel Req

Change-Id: I8f18c927b1897806233cc9d049c25694c1e639d4
---
M epdg/EPDG_Tests.ttcn
1 file changed, 84 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve




diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn
index f93b77b..3a0c3a6 100644
--- a/epdg/EPDG_Tests.ttcn
+++ b/epdg/EPDG_Tests.ttcn
@@ -2,6 +2,7 @@

 import from Misc_Helpers all;
 import from General_Types all;
+import from Native_Functions all;
 import from Osmocom_Types all;
 import from L3_Common all;

@@ -13,6 +14,8 @@
 import from DIAMETER_Templates all;
 import from DIAMETER_Emulation all;

+import from GTPv2_Types all;
+import from GTPv2_Templates all;
 import from GTPv2_Emulation all;

 modulepar {
@@ -108,6 +111,17 @@

 type record EPDG_ConnHdlrPars {
hexstring imsi,
+   charstring ue_ip,
+
+   /* TEI (Data) local side */
+   OCT4 teid,
+   /* TEI (Control) local side */
+   OCT4 teic,
+   /* TEI (Data) remote side */
+   OCT4 teid_remote optional,
+   /* TEI (Control) remote side */
+   OCT4 teic_remote optional,
+
AuthVector vec optional
 };

@@ -122,11 +136,15 @@
}
 }

-
 private function f_init_pars(integer imsi_suffix := 1)
 runs on MTC_CT return EPDG_ConnHdlrPars {
var EPDG_ConnHdlrPars pars := {
imsi := f_gen_imsi(imsi_suffix),
+   ue_ip := "192.168.123.50",
+   teid := ''O,
+   teic := ''O,
+   teid_remote := omit,
+   teic_remote := omit,
vec := f_gen_auth_vec_3g()
};
return pars;
@@ -231,7 +249,7 @@
use_gtpu_daemon := false /* TODO: maybe use, set to true */
};

-   vc_GTP2 := GTPv2_Emulation_CT.create("GTP2_EM");
+   vc_GTP2 := GTPv2_Emulation_CT.create(id & "-GTPV2");
map(vc_GTP2:GTP2C, system:GTP2C);
connect(vc_GTP2:TEID0, self:TEID0);
vc_GTP2.start(GTPv2_Emulation.main(cfg));
@@ -255,6 +273,9 @@
/* tell GSUP dispatcher to send this IMSI to us */
f_create_gsup_expect(hex2str(g_pars.imsi));

+   /* tell GTPv2 dispatcher to send this IMSI to us */
+   f_gtp2_register_imsi(g_pars.imsi);
+
fn.apply(id);
 }

@@ -266,9 +287,14 @@

vc_conn := EPDG_ConnHdlr.create(id);

+   /* GSUP */
connect(vc_conn:GSUP, vc_GSUP:GSUP_CLIENT);
connect(vc_conn:GSUP_PROC, vc_GSUP:GSUP_PROC);

+   /* GTP2 */
+   connect(vc_conn:GTP2, vc_GTP2:CLIENT);
+   connect(vc_conn:GTP2_PROC, vc_GTP2:CLIENT_PROC);
+
/* SWx */
vc_conn_swx := DIAMETER_ConnHdlr_CT.create(id);
connect(vc_conn_swx:DIAMETER, vc_SWx:DIAMETER_CLIENT);
@@ -336,6 +362,36 @@
}
 }

+/* Diameter SWx SAR + SAA. */
+private altstep as_GTP2C_CreateSession_success() runs on EPDG_ConnHdlr {
+   var PDU_GTPCv2 rx_msg;
+   var template (value) FullyQualifiedTEID fteid_c_ie, fteid_u_ie;
+   var template (value) PDN_AddressAllocation paa;
+
+   [] GTP2.receive(tr_GTP2C_CreateSessionReq(g_pars.imsi)) -> value rx_msg 
{
+   /* TODO: parse TEIC and TEID and store it in 
g_pars.remote_tei{c,d} */
+
+   /* allocate + register TEID-C on local side */
+   g_pars.teic := f_gtp2_allocate_teid();
+   g_pars.teid := g_pars.teic;
+
+   fteid_c_ie := ts_GTP2C_FTEID(FTEID_IF_S2b_ePDG_GTPC, 
g_pars.teic, 0,
+   f_inet_addr(mp_s2b_local_ip), omit);
+   fteid_u_ie := ts_GTP2C_FTEID(FTEID_IF_S2bU_ePDG_GTPU, 
g_pars.teid, 2,
+   f_inet_addr(mp_s2b_local_ip), omit);
+   paa := ts_GTP2C_PdnAddrAlloc_v4(f_inet_addr(g_pars.ue_ip));
+   GTP2.send(ts_GTP2C_CreateSessionResp({ fteid_c_ie }, paa));
+   setverdict(pass);
+   }
+   [] GTP2.receive(PDU_GTPCv2:?) -> value rx_msg {
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
log2str("Unexpected GTP2C msg rx: ", rx_msg));
+   }
+}
+private function f_GTP2C_CreateSession_success() runs on EPDG_ConnHdlr {
+   f_gtp2_register_udmsg('20'O);
+   as_GTP2C_CreateSession_success();
+}
+
 /* GSUP AuthInfo Req + Resp, triggers SWx MAR + MAA. */
 private function f_GSUP_AI_success() runs on EPDG_ConnHdlr {
var GSUP_PDU rx_gsup;
@@ -363,7 +419,7 @@
var template octetstring destination_name := *;
GSUP.send(ts_GSUP_UL_REQ(g_pars.imsi));

[S] Change in osmo-ttcn3-hacks[master]: GSUP_Types: Add EDPG_Tunnel messages

[pespin]

Attention is currently required from: fixeria, lynxis lazus, osmith.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34832?usp=email )

Change subject: GSUP_Types: Add EDPG_Tunnel messages
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34832?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadba149e6d299e5e666b2debdc23a00d37e78da5
Gerrit-Change-Number: 34832
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:46:14 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: Fix sysmocom copyright typo

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34863?usp=email )

Change subject: Fix sysmocom copyright typo
..

Fix sysmocom copyright typo

Change-Id: Ia6a3748ac3eb7c5587ed978d60afd315dae07a3c
---
M dia/diameter_3gpp_ts29_273.dia
M dia/diameter_3gpp_ts29_273_swx.dia
M dia/diameter_etsi_es283_035.dia
M dia/diameter_rfc5580.dia
M dia/diameter_rfc8583.dia
M src/epdg_diameter_swx.erl
6 files changed, 15 insertions(+), 6 deletions(-)

Approvals:
  lynxis lazus: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/dia/diameter_3gpp_ts29_273.dia b/dia/diameter_3gpp_ts29_273.dia
index ac22a53..e22cc0d 100644
--- a/dia/diameter_3gpp_ts29_273.dia
+++ b/dia/diameter_3gpp_ts29_273.dia
@@ -1,7 +1,7 @@
 ;;
 ;; %CopyrightBegin%
 ;;
-;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 
+;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH 
 ;; Author: Alexander Couzens 
 ;;
 ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15
diff --git a/dia/diameter_3gpp_ts29_273_swx.dia 
b/dia/diameter_3gpp_ts29_273_swx.dia
index d6d446c..1e86dee 100644
--- a/dia/diameter_3gpp_ts29_273_swx.dia
+++ b/dia/diameter_3gpp_ts29_273_swx.dia
@@ -1,7 +1,7 @@
 ;;
 ;; %CopyrightBegin%
 ;;
-;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 
+;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH 
 ;; Author: Alexander Couzens 
 ;;
 ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15
diff --git a/dia/diameter_etsi_es283_035.dia b/dia/diameter_etsi_es283_035.dia
index c1e4e5e..c0baff2 100644
--- a/dia/diameter_etsi_es283_035.dia
+++ b/dia/diameter_etsi_es283_035.dia
@@ -1,7 +1,7 @@
 ;;
 ;; %CopyrightBegin%
 ;;
-;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 
+;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH 
 ;; Author: Alexander Couzens 
 ;;
 ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15
diff --git a/dia/diameter_rfc5580.dia b/dia/diameter_rfc5580.dia
index bfc851a..9a41bd7 100644
--- a/dia/diameter_rfc5580.dia
+++ b/dia/diameter_rfc5580.dia
@@ -1,7 +1,7 @@
 ;;
 ;; %CopyrightBegin%
 ;;
-;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 
+;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH 
 ;; Author: Alexander Couzens 
 ;;
 ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15
diff --git a/dia/diameter_rfc8583.dia b/dia/diameter_rfc8583.dia
index cfde5e5..59df542 100644
--- a/dia/diameter_rfc8583.dia
+++ b/dia/diameter_rfc8583.dia
@@ -1,7 +1,7 @@
 ;;
 ;; %CopyrightBegin%
 ;;
-;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 
+;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH 
 ;; Author: Alexander Couzens 
 ;;
 ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15
diff --git a/src/epdg_diameter_swx.erl b/src/epdg_diameter_swx.erl
index dadfa65..c278206 100644
--- a/src/epdg_diameter_swx.erl
+++ b/src/epdg_diameter_swx.erl
@@ -2,7 +2,7 @@
 %
 % TS 29.273
 %
-% (C) 2023 by sysmocom - s.m.f.c. GmbH 
+% (C) 2023 by sysmocom - s.f.m.c. GmbH 
 % Author: Alexander Couzens 
 %
 % All Rights Reserved

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34863?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia6a3748ac3eb7c5587ed978d60afd315dae07a3c
Gerrit-Change-Number: 34863
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[L] Change in ...osmo-epdg[master]: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email )

Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
..

Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp

Initial GTPv2C infrastructure to send GTPv2C CreateSession Request upon
receival of GSUP EPDG_Tunnel Request, and answer with EPDG_Tunnel
Resp/err when creating the session fails.

Related: OS#6046
Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
---
M config/sys.config
M rebar.config
M rebar.lock
A src/epdg_gtpc_s2b.erl
M src/gsup_server.erl
M src/osmo_epdg.app.src
M src/osmo_epdg_sup.erl
7 files changed, 320 insertions(+), 7 deletions(-)

Approvals:
  lynxis lazus: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/config/sys.config b/config/sys.config
index 8d751b9..1b89e86 100755
--- a/config/sys.config
+++ b/config/sys.config
@@ -13,7 +13,13 @@
{vendor_id, 0},
{origin_host, "epdg.localdomain"},
{origin_realm, "localdomain"},
-   {context_id, "epdg@localdomain"}]},
+   {context_id, "epdg@localdomain"},
+   % GTPv2C Connection parameters
+   {gtpc_local_ip, "127.0.0.2"},
+   {gtpc_local_port, 2123},
+   {gtpc_remote_ip, "127.0.0.1"},
+   {gtpc_remote_port, 2123}
+  ]},
  %% ===
  %% SASL config
  %% ===
diff --git a/rebar.config b/rebar.config
index 03e0e7c..d834c32 100644
--- a/rebar.config
+++ b/rebar.config
@@ -4,6 +4,7 @@

 {deps, [
{lager, {git, "https://github.com/erlang-lager/lager;, {tag, "3.9.2"}}},
+   {gtplib, "3.2.0"},
{osmo_ss7, {git, "https://gitea.osmocom.org/erlang/osmo_ss7;, {ref, 
"9f294d3612f998860004820d1d85b4264721577b"}}},
{osmo_gsup,  {git, "https://gitea.osmocom.org/erlang/osmo_gsup;, {ref, 
"07672d8ab1608aa9c9e50ca035521876558fcd42"}}}
 ]}.
diff --git a/rebar.lock b/rebar.lock
index 4aeafea..8f00ea6 100644
--- a/rebar.lock
+++ b/rebar.lock
@@ -1,16 +1,18 @@
 {"1.2.0",
-[{<<"epcap">>,
+[{<<"cut">>,{pkg,<<"cut">>,<<"1.0.3">>},1},
+ {<<"epcap">>,
   {git,"https://github.com/msantos/epcap;,
{ref,"d5c03caf608c1369e68cfed0a606d3eb82ddfd21"}},
   1},
  {<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},1},
+ {<<"gtplib">>,{pkg,<<"gtplib">>,<<"3.2.0">>},0},
  {<<"lager">>,
   {git,"https://github.com/erlang-lager/lager;,
{ref,"459a3b2cdd9eadd29e5a7ce5c43932f5ccd6eb88"}},
   0},
  {<<"osmo_gsup">>,
   {git,"https://gitea.osmocom.org/erlang/osmo_gsup;,
-   {ref,"07672d8ab1608aa9c9e50ca035521876558fcd42"}},
+   {ref,"e23f118e6e8f7ee1247db34e4cb79e4cecdb0947"}},
   0},
  {<<"osmo_ss7">>,
   {git,"https://gitea.osmocom.org/erlang/osmo_ss7;,
@@ -23,10 +25,17 @@
  {<<"pkt">>,
   {git,"https://github.com/msantos/pkt;,
{ref,"67a4a14f596fded5ad5f2d8f94318faa8ad2c288"}},
-  1}]}.
+  1},
+ {<<"ppplib">>,{pkg,<<"ppplib">>,<<"1.0.0">>},1}]}.
 [
 {pkg_hash,[
- {<<"goldrush">>, 
<<"F06E5D5F1277DA5C413E84D5A2924174182FB108DABB39D5EC548B27424CD106">>}]},
+ {<<"cut">>, 
<<"1577F2F3BC0F2BF3B97903B7426F8A3D79523687B6A444D0F59A095EF69A0E81">>},
+ {<<"goldrush">>, 
<<"F06E5D5F1277DA5C413E84D5A2924174182FB108DABB39D5EC548B27424CD106">>},
+ {<<"gtplib">>, 
<<"41E8E14BE21DD6E08B2CBB9D708BCF8FDD47CA49D7FFA480219CAB29F5AE2760">>},
+ {<<"ppplib">>, 
<<"F9EC2690532BAF590277A305A2276FCFAD0285557E102F8A2FCAF1BF081A">>}]},
 {pkg_hash_ext,[
- {<<"goldrush">>, 
<<"99CB4128CFFCB3227581E5D4D803D5413FA643F4EB96523F77D9E6937D994CEB">>}]}
+ {<<"cut">>, 
<<"1A4A25DB2B7C5565FD28B314A4EEB898B1ED3CAFFA1AB09149345FB5731ED04B">>},
+ {<<"goldrush">>, 
<<"99CB4128CFFCB3227581E5D4D803D5413FA643F4EB96523F77D9E6937D994CEB">>},
+ {<<"gtplib">>, 
<<"264626E6993C17B00CA3C083B9BF23D16B88BEEDDDE35F62C954832C21B57AEF">>},
+ {<<"ppplib">>, 
<<"32440D630F55DD29F849847DD8F15F69175FDDC210AA88517AC8AD2854CD6FA1">>}]}
 ].
diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl
new file mode 100644
index 000..82985a5
--- /dev/null
+++ b/src/epdg_gtpc_s2b.erl
@@ -0,0 +1,252 @@
+% S2b: GTPv2C towards PGW
+%
+% 3GPP TS 29.274
+%
+% (C) 2023 by sysmocom - s.f.m.c. GmbH 
+% Author: Pau Espin Pedrol 
+%
+% All Rights Reserved
+%
+% This program is free software; you can redistribute it and/or modify
+% it under the terms of the GNU Affero General Public License as
+% published by the Free Software Foundation; either version 3 of the
+% License, or (at your option) any later version.
+%
+% This program is distributed in the hope that it will be useful,
+% but WITHOUT ANY WARRANTY; without even the implied warranty of
+% MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+% GNU General Public License for more details.
+%
+% You should have received a copy of the GNU Affero General Public License
+% along with this program.  If not, see .
+%
+% Additional Permission under GNU AGPL version 3 section 7:
+%
+% If you modify 

[L] Change in ...osmo-epdg[master]: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp

[lynxis lazus]

Attention is currently required from: fixeria, laforge, pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email )

Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
..


Patch Set 4: Code-Review+2

(1 comment)

File src/epdg_gtpc_s2b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/742d93f6_0d73bfc9
PS4, Line 60: %% TODO: make APN configurable? get it from HSS?
> But I think it is not yet defined how we pass that to osmo-epdg through the 
> CEAI GSUP interface. […]
It should be passed on at least on the Location Update Request. Even the 
strongswan already know this at the time of Auth-Req. I would include it into 
the Location Update Request.
Lets fix this later not in this review.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:41:40 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: lynxis lazus 
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: Initial S6b support

[lynxis lazus]

Attention is currently required from: pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email )

Change subject: Initial S6b support
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
Gerrit-Change-Number: 34858
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:43:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email )

Change subject: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 
5777)
..

diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)

S6b interface HSS<->PGW is defined in TS 28.273 section 9.

TS 28.273 depends on some types defined in RFC 5777, which was missing
so far.

Some enumareated types in RFC 5777 whose enums fields are declared in
yet other dependent RFCs are left with a dummy value, as TODO for the
future if they are ever needed.

Related: OS#6229
Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc
---
A dia/diameter_3gpp_ts29_273_s6b.dia
A dia/diameter_rfc5777.dia
2 files changed, 553 insertions(+), 0 deletions(-)

Approvals:
  lynxis lazus: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/dia/diameter_3gpp_ts29_273_s6b.dia 
b/dia/diameter_3gpp_ts29_273_s6b.dia
new file mode 100644
index 000..b009e20
--- /dev/null
+++ b/dia/diameter_3gpp_ts29_273_s6b.dia
@@ -0,0 +1,166 @@
+;;
+;; %CopyrightBegin%
+;;
+;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH 
+;; Author: Pau Espin Pedrol 
+;;
+;; This resembles 3GPP TS 29.273 version 17.6.0 Release 17
+;;
+;; Licensed under the Apache License, Version 2.0 (the "License");
+;; you may not use this file except in compliance with the License.
+;; You may obtain a copy of the License at
+;;
+;; http://www.apache.org/licenses/LICENSE-2.0
+;;
+;; Unless required by applicable law or agreed to in writing, software
+;; distributed under the License is distributed on an "AS IS" BASIS,
+;; WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+;; See the License for the specific language governing permissions and
+;; limitations under the License.
+;;
+;; %CopyrightEnd%
+;;
+
+;;
+;; Edits:
+;;
+;;
+
+
+@id 16777272
+@name   diameter_3gpp_ts29_273_s6b
+;;@prefix diameter_3gpp
+@vendor 10415 3GPP
+
+@inherits diameter_gen_base_rfc6733
+@inherits diameter_3gpp_base
+@inherits diameter_3gpp_break_circles
+@inherits diameter_3gpp_ts29_212
+@inherits diameter_3gpp_ts29_214
+@inherits diameter_3gpp_ts29_229
+@inherits diameter_3gpp_ts29_272
+@inherits diameter_3gpp_ts29_273
+@inherits diameter_3gpp_ts32_299
+@inherits diameter_etsi_es283_034
+@inherits diameter_rfc4006_cc
+@inherits diameter_rfc5447
+@inherits diameter_rfc5580
+@inherits diameter_rfc5777
+@inherits diameter_rfc5778
+@inherits diameter_rfc7683
+@inherits diameter_rfc7944
+@inherits diameter_rfc8583
+
+@messages
+
+;; 9. S6b
+;; 9.2.2.2.1 AA-Request (AAR)
+
+   AAR ::= < Diameter Header: 265, REQ, PXY >
+   < Session-Id >
+   { Auth-Application-Id }
+   { Origin-Host }
+   { Origin-Realm }
+   { Destination-Realm }
+   { Auth-Request-Type }
+   [ User-Name ]
+   [ MIP6-Agent-Info ]
+   [ MIP6-Feature-Vector ]
+   [ Visited-Network-Identifier ]
+   [ QoS-Capability ]
+   [ Service-Selection ]
+   [ OC-Supported-Features ]
+   [ Origination-Time-Stamp ]
+   [ Maximum-Wait-Time ]
+   *[ Supported-Features ]
+   [ Emergency-Services ]
+   *[ AVP ]
+
+;; 9.2.2.2.2 AA-Answer (AAA)
+   AAA ::= < Diameter Header: 265, PXY >
+   < Session-Id >
+   { Auth-Application-Id }
+   { Auth-Request-Type }
+   { Result-Code }
+   { Origin-Host }
+   { Origin-Realm }
+   [ MIP6-Feature-Vector ]
+   [ Session-Timeout ]
+   [ APN-Configuration ]
+   [ QoS-Resources ]
+   [ AN-Trusted ]
+   *[ Redirect-Host ]
+   [ Trace-Info ]
+   [ OC-Supported-Features ]
+   [ OC-OLR ]
+   *[ Load ]
+
+;; 9.2.2.3.1 Session-Termination-Request (STR)
+;; 9.2.2.4.3 Session-Termination-Request (STR)
+   STR ::= < Diameter Header: 275, REQ, PXY >
+   < Session-Id >
+   { Auth-Application-Id }
+   { Origin-Host }
+   { Origin-Realm }
+   { Destination-Realm }
+   { Termination-Cause }
+   [ User-Name ]
+   [ OC-Supported-Features ]
+   *[ AVP ]
+
+;; 9.2.2.3.2 Session-Termination-Answer (STA)
+;; 9.2.2.4.4 Session-Termination-Answer (STA)
+   STA ::= < Diameter Header: 275, PXY >
+   < Session-Id >
+   { Result-Code }
+   { Origin-Host }
+   { Origin-Realm }
+   [ OC-Supported-Features ]
+   [ OC-OLR ]
+   *[ Load ]
+   *[ AVP ]
+
+;; 9.2.2.4.1 Abort-Session-Request (ASR)
+   ASR ::= < Diameter Header: 274, REQ, PXY >
+   < Session-Id >
+   { Origin-Host 

[M] Change in osmocom-bb[master]: ASCI: Add option to join voice group/broadcast calls without valid SIM

[pespin]

Attention is currently required from: jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34866?usp=email )

Change subject: ASCI: Add option to join voice group/broadcast calls without 
valid SIM
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34866?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I6ea851a8cb015ff685b985335968c6184beca816
Gerrit-Change-Number: 34866
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:44:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Use correct mobile identiy in TALKER INDICATION message

[pespin]

Attention is currently required from: jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34865?usp=email )

Change subject: ASCI: Use correct mobile identiy in TALKER INDICATION message
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34865?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I299604a0e12d91e9133b70757826ac9637da0e3e
Gerrit-Change-Number: 34865
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:42:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)

[lynxis lazus]

Attention is currently required from: pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email )

Change subject: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 
5777)
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc
Gerrit-Change-Number: 34857
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:42:04 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: Initial S6b support

[pespin]

Attention is currently required from: lynxis lazus.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email )

Change subject: Initial S6b support
..


Patch Set 2:

(2 comments)

File src/aaa_diameter_s6b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858/comment/c8c2408b_dc21ac06
PS2, Line 138: % APN is optional and should be []
> old code?
Could be, I'm just submitting initial code base to have something answering, we 
can clean up later once everything is in place, with smaller incremental 
patches improving the code base.


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858/comment/80e3de58_54b8e056
PS2, Line 148: SessionId = 
diameter:session_id(application:get_env(?ENV_APP_NAME, origin_host, 
?ENV_DEFAULT_ORIG_HOST)).
> It looks you're missing something here.
Yes, because AAA initiated procedures are not yet implemented here, only 
AAR+AAA initiated by PGW. We can add missing procedures as follow up, I'm for 
now fosucing on adding initial socket handling for each interface and 
implementing the minimum subset I need to go forward in a single ttcn3 test.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
Gerrit-Change-Number: 34858
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: lynxis lazus 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:38:46 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus 
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp

[pespin]

Attention is currently required from: fixeria, laforge, lynxis lazus.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email )

Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
..


Patch Set 4:

(3 comments)

Patchset:

PS4:
> Isn't there a GTPv2 ping/pong or keepalive? […]
It's not yet there. For now I'm focusing on adding the barebones of each 
interface to have 1 test case passing, so that it's easier then to 
incrementally add features in parallel by several people.


File src/epdg_gtpc_s2b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/00151048_4754f0f1
PS4, Line 10: % This program is free software; you can redistribute it and/or 
modify
> In general on this project: We should have a separate discussion about the 
> license. […]
Ack, I'm simply extending whatever code I found there.


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/9bb889b9_8b7d5e77
PS4, Line 60: %% TODO: make APN configurable? get it from HSS?
> The UE sends the APN when connecting to the ePDG within the IKEv2. […]
But I think it is not yet defined how we pass that to osmo-epdg through the 
CEAI GSUP interface. We can add those missing bits as a follow-up.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:35:53 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus 
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email )

Change subject: Makefile: run 'rebar3 clean' upon make clean
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553
Gerrit-Change-Number: 34841
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:33:14 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email )

Change subject: Makefile: run 'rebar3 clean' upon make clean
..

Makefile: run 'rebar3 clean' upon make clean

Otherwise the diameter files generated during compile in include/ and
src/ are not removed.

Change-Id: I771860f965499bb754c13385819845ef23f33553
---
M Makefile
1 file changed, 20 insertions(+), 0 deletions(-)

Approvals:
  lynxis lazus: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve




diff --git a/Makefile b/Makefile
index b2fe66f..0470458 100644
--- a/Makefile
+++ b/Makefile
@@ -14,4 +14,12 @@
rebar3 eunit

 clean:
+# Avoid running rebar3 clean if _build doesn't exist, since it would try
+# to fetch deps from the Internet and that may not be avaialble when in
+# OBS build.
+ifneq ("$(wildcard _build/.*)", "")
+   rebar3 clean
rm -rf _build/
+else
+   rm -f src/diameter_*.erl
+endif

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553
Gerrit-Change-Number: 34841
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmocom-bb[master]: ASCI: Use correct mobile identiy in TALKER INDICATION message

[fixeria]

Attention is currently required from: jolly.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34865?usp=email )

Change subject: ASCI: Use correct mobile identiy in TALKER INDICATION message
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34865?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I299604a0e12d91e9133b70757826ac9637da0e3e
Gerrit-Change-Number: 34865
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Mon, 23 Oct 2023 13:12:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Correctly set and store 'uplink-release-local' flag

[fixeria]

Attention is currently required from: jolly.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34867?usp=email )

Change subject: ASCI: Correctly set and store 'uplink-release-local' flag
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34867?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I6af44f0dd7ff842de633587fb0dcbe78126d30e1
Gerrit-Change-Number: 34867
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Mon, 23 Oct 2023 13:15:20 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in osmocom-bb[master]: ASCI: Add option to join voice group/broadcast calls without valid SIM

[fixeria]

Attention is currently required from: jolly.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34866?usp=email )

Change subject: ASCI: Add option to join voice group/broadcast calls without 
valid SIM
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34866?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I6ea851a8cb015ff685b985335968c6184beca816
Gerrit-Change-Number: 34866
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Mon, 23 Oct 2023 13:14:56 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: Initial S6b support

[lynxis lazus]

Attention is currently required from: pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email )

Change subject: Initial S6b support
..


Patch Set 2:

(2 comments)

File src/aaa_diameter_s6b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858/comment/8b82f6f8_c96ac25c
PS2, Line 138: % APN is optional and should be []
old code?


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858/comment/422af289_dd60ec07
PS2, Line 148: SessionId = 
diameter:session_id(application:get_env(?ENV_APP_NAME, origin_host, 
?ENV_DEFAULT_ORIG_HOST)).
It looks you're missing something here.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
Gerrit-Change-Number: 34858
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: lynxis lazus 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 13:07:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmocom-bb[master]: ASCI: Handle rejection of voice group/broadcast call correctly

[fixeria]

Attention is currently required from: jolly.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34864?usp=email )

Change subject: ASCI: Handle rejection of voice group/broadcast call correctly
..


Patch Set 1: Code-Review+1

(2 comments)

File src/host/layer23/src/mobile/gsm44068_gcc_bcc.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34864/comment/facb702f_f37df590
PS1, Line 1228: NULL state
copy-paste?


https://gerrit.osmocom.org/c/osmocom-bb/+/34864/comment/88f58a78_ced4f0a7
PS1, Line 1231: %d)
`0x%02x`



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34864?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I605387c6be409ef0e67caf7b9e2a83e1032b45f1
Gerrit-Change-Number: 34864
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Mon, 23 Oct 2023 13:10:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Correctly set and store 'uplink-release-local' flag

[jolly]

jolly has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34867?usp=email )


Change subject: ASCI: Correctly set and store 'uplink-release-local' flag
..

ASCI: Correctly set and store 'uplink-release-local' flag

Also this option is enabled by default and show in the VTY if it is
disabled.

Change-Id: I6af44f0dd7ff842de633587fb0dcbe78126d30e1
Related: OS#5364
---
M src/host/layer23/src/common/settings.c
M src/host/layer23/src/mobile/vty_interface.c
2 files changed, 16 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/67/34867/1

diff --git a/src/host/layer23/src/common/settings.c 
b/src/host/layer23/src/common/settings.c
index 395d239..e79a6a1 100644
--- a/src/host/layer23/src/common/settings.c
+++ b/src/host/layer23/src/common/settings.c
@@ -116,6 +116,8 @@

INIT_LLIST_HEAD(>abbrev);

+   set->uplink_release_local = true;
+
return 0;
 }

diff --git a/src/host/layer23/src/mobile/vty_interface.c 
b/src/host/layer23/src/mobile/vty_interface.c
index 7611c0f..aaf01bd 100644
--- a/src/host/layer23/src/mobile/vty_interface.c
+++ b/src/host/layer23/src/mobile/vty_interface.c
@@ -1326,7 +1326,7 @@
set->any_timeout, VTY_NEWLINE);
if (!l23_vty_hide_default || !set->uplink_release_local)
vty_out(vty, " %suplink-release-local%s",
-   (set->uplink_release_local) ? "no " : "", VTY_NEWLINE);
+   (!set->uplink_release_local) ? "no " : "", VTY_NEWLINE);
if (!l23_vty_hide_default || set->asci_allow_any)
vty_out(vty, " %sasci-allow-any%s",
(set->asci_allow_any) ? "" : "no ", VTY_NEWLINE);

--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34867?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I6af44f0dd7ff842de633587fb0dcbe78126d30e1
Gerrit-Change-Number: 34867
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-MessageType: newchange

[M] Change in osmocom-bb[master]: ASCI: Handle rejection of voice group/broadcast call correctly

[jolly]

jolly has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34864?usp=email )


Change subject: ASCI: Handle rejection of voice group/broadcast call correctly
..

ASCI: Handle rejection of voice group/broadcast call correctly

If joining a call gets rejected, the call must not be released, instead
it must return to U3 state (incoming call), because the call still
exists in the cell and it might possible to join it later.

If a call notification is gone, a new event is used in the state machine
to release incoming call.

Change-Id: I605387c6be409ef0e67caf7b9e2a83e1032b45f1
Related: OS#5364
---
M src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
1 file changed, 43 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/64/34864/1

diff --git a/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c 
b/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
index 0cef1c3..a061cf0 100644
--- a/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
+++ b/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c
@@ -138,10 +138,11 @@
VGCS_GCC_EV_DI_CONNECT, /* network indicates connect */
VGCS_GCC_EV_TIMEOUT,/* several timeout events */
VGCS_GCC_EV_SETUP_IND,  /* notification of ongoing call 
received */
+   VGCS_GCC_EV_REL_IND,/* notification of call being 
gone */
VGCS_GCC_EV_JOIN_GC_REQ,/* user wants to join ongoing 
call */
VGCS_GCC_EV_JOIN_GC_CNF,/* MM confirms joining ongoing 
call */
VGCS_GCC_EV_ABORT_REQ,  /* user rejects or leaves call 
*/
-   VGCS_GCC_EV_ABORT_IND,  /* MM indicates call gone / 
channel released or failed */
+   VGCS_GCC_EV_ABORT_IND,  /* MM indicates channel 
released or failed */
VGCS_GCC_EV_TALK_REQ,   /* user wants to talk */
VGCS_GCC_EV_TALK_CNF,   /* MM confirms talk */
VGCS_GCC_EV_TALK_REJ,   /* MM rejects talk */
@@ -162,6 +163,7 @@
OSMO_VALUE_STRING(VGCS_GCC_EV_DI_CONNECT),
OSMO_VALUE_STRING(VGCS_GCC_EV_TIMEOUT),
OSMO_VALUE_STRING(VGCS_GCC_EV_SETUP_IND),
+   OSMO_VALUE_STRING(VGCS_GCC_EV_REL_IND),
OSMO_VALUE_STRING(VGCS_GCC_EV_JOIN_GC_REQ),
OSMO_VALUE_STRING(VGCS_GCC_EV_JOIN_GC_CNF),
OSMO_VALUE_STRING(VGCS_GCC_EV_ABORT_REQ),
@@ -1104,7 +1106,7 @@
/* Change to GROUP CALL PRESENT state. */
osmo_fsm_inst_state_chg(fi, VGCS_GCC_ST_U3_GROUP_CALL_PRESENT, 
0, 0);
break;
-   case VGCS_GCC_EV_ABORT_IND:
+   case VGCS_GCC_EV_REL_IND:
/* The MM layer indicates that group channel is gone. */
LOG_GCC(trans, LOGL_INFO, "Group call notification is gone.\n");
/* Change to NULL state. */
@@ -1165,12 +1167,12 @@
/* Free transaction. */
trans_free(trans);
break;
-   case VGCS_GCC_EV_ABORT_IND:
+   case VGCS_GCC_EV_REL_IND:
/* The notified call is gone. */
LOG_GCC(trans, LOGL_INFO, "Received call from network is 
gone.\n");
/* Change to NULL state. */
osmo_fsm_inst_state_chg(fi, VGCS_GCC_ST_U0_NULL, 0, 0);
-   /* Notify termination at VTY. (No cause, because notification 
is gone.) */
+   /* Notify termination at VTY. */
vgcs_vty_notify(trans, "Released\n");
/* Free transaction. */
trans_free(trans);
@@ -1193,6 +1195,7 @@
 static void vgcs_gcc_fsm_u4_action(struct osmo_fsm_inst *fi, uint32_t event, 
void *data)
 {
struct gsm_trans *trans = fi->priv;
+   uint8_t *cause = data;

switch (event) {
case VGCS_GCC_EV_JOIN_GC_CNF:
@@ -1209,16 +1212,24 @@
/* Free transaction. */
trans_free(trans);
break;
-   case VGCS_GCC_EV_ABORT_IND:
+   case VGCS_GCC_EV_REL_IND:
/* The notified call is gone. */
LOG_GCC(trans, LOGL_INFO, "Received call from network is 
gone.\n");
/* Change to NULL state. */
osmo_fsm_inst_state_chg(fi, VGCS_GCC_ST_U0_NULL, 0, 0);
-   /* Notify termination at VTY. (No cause, because notification 
is gone.) */
+   /* Notify termination at VTY. */
vgcs_vty_notify(trans, "Released\n");
/* Free transaction. */
trans_free(trans);
break;
+   case VGCS_GCC_EV_ABORT_IND:
+   /* The notified call is gone. */
+   LOG_GCC(trans, LOGL_INFO, "Call rejected.\n");
+   /* Change to NULL state. */
+   osmo_fsm_inst_state_chg(fi, VGCS_GCC_ST_U3_GROUP_CALL_PRESENT, 
0, 0);
+   /* Notify 

[M] Change in osmocom-bb[master]: ASCI: Add option to join voice group/broadcast calls without valid SIM

[jolly]

jolly has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34866?usp=email )


Change subject: ASCI: Add option to join voice group/broadcast calls without 
valid SIM
..

ASCI: Add option to join voice group/broadcast calls without valid SIM

This option must be enabled in the VTY and is disabled by default.

Calls can be joined when service is limited or normal. With that option
enabled, calls can be joined even with invalid SIM.

Talking is allowed when service is normal. With that option enabled,
talking is always allowed. It depends on the network, if it accepts the
talker.

Change-Id: I6ea851a8cb015ff685b985335968c6184beca816
Related: OS#5364
---
M src/host/layer23/include/osmocom/bb/common/settings.h
M src/host/layer23/src/mobile/gsm48_mm.c
M src/host/layer23/src/mobile/vty_interface.c
3 files changed, 75 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/66/34866/1

diff --git a/src/host/layer23/include/osmocom/bb/common/settings.h 
b/src/host/layer23/include/osmocom/bb/common/settings.h
index 884578b..3b9473f 100644
--- a/src/host/layer23/include/osmocom/bb/common/settings.h
+++ b/src/host/layer23/include/osmocom/bb/common/settings.h
@@ -191,6 +191,7 @@

/* ASCI settings */
booluplink_release_local;
+   boolasci_allow_any;
 };

 struct gsm_settings_abbrev {
diff --git a/src/host/layer23/src/mobile/gsm48_mm.c 
b/src/host/layer23/src/mobile/gsm48_mm.c
index 5e02659..378cd2d 100644
--- a/src/host/layer23/src/mobile/gsm48_mm.c
+++ b/src/host/layer23/src/mobile/gsm48_mm.c
@@ -61,7 +61,9 @@
 static int gsm48_mm_loc_upd_normal(struct osmocom_ms *ms, struct msgb *msg);
 static int gsm48_mm_loc_upd_periodic(struct osmocom_ms *ms, struct msgb *msg);
 static int gsm48_mm_loc_upd(struct osmocom_ms *ms, struct msgb *msg);
+static int gsm48_mm_group_reject(struct osmocom_ms *ms, struct msgb *msg);
 static int gsm48_mm_group_rel_req(struct osmocom_ms *ms, struct msgb *msg);
+static int gsm48_mm_uplink_reject(struct osmocom_ms *ms, struct msgb *msg);
 
 /*
  * notes
@@ -3805,9 +3807,13 @@
 static int gsm48_mm_group_req(struct osmocom_ms *ms, struct msgb *msg)
 {
struct gsm48_mmlayer *mm = >mmlayer;
+   struct gsm_settings *set = >settings;
struct gsm48_mmxx_hdr *mmh = (struct gsm48_mmxx_hdr *)msg->data;
struct msgb *nmsg;

+   if (mm->substate == GSM48_MM_SST_NO_IMSI && !set->asci_allow_any)
+   return gsm48_mm_group_reject(ms, msg);
+
LOGP(DMM, LOGL_INFO, "Request for joining a group call, trying to 
establish group receive mode.\n");

/* Store infos about group/broadcast call. */
@@ -3881,6 +3887,7 @@
 static int gsm48_mm_group_rel_ind(struct osmocom_ms *ms, struct msgb *msg)
 {
struct gsm48_mmlayer *mm = >mmlayer;
+   struct gsm_subscriber *subscr = >subscr;
struct gsm48_rr_hdr *rrh = (struct gsm48_rr_hdr *)msg->data;
uint16_t msg_type;
struct msgb *nmsg;
@@ -3892,8 +3899,10 @@
mm->vgcs.enabled = false;

/* Change mode back to normal or limited service. */
-   if (mm->substate == GSM48_MM_SST_RX_VGCS_LIMITED)
-   new_mm_state(mm, GSM48_MM_ST_MM_IDLE, 
GSM48_MM_SST_LIMITED_SERVICE);
+   if (mm->substate == GSM48_MM_SST_RX_VGCS_LIMITED) {
+   new_mm_state(mm, GSM48_MM_ST_MM_IDLE, (subscr->sim_valid) ? 
GSM48_MM_SST_LIMITED_SERVICE
+ : 
GSM48_MM_SST_NO_IMSI);
+   }
if (mm->substate == GSM48_MM_SST_RX_VGCS_NORMAL)
new_mm_state(mm, GSM48_MM_ST_MM_IDLE, 
GSM48_MM_SST_NORMAL_SERVICE);

@@ -3932,6 +3941,7 @@
 static int gsm48_mm_group_rel_req(struct osmocom_ms *ms, struct msgb *msg)
 {
struct gsm48_mmlayer *mm = >mmlayer;
+   struct gsm_subscriber *subscr = >subscr;
struct msgb *nmsg;

LOGP(DMM, LOGL_INFO, "Request to release group call in receive or 
transmit mode.\n");
@@ -3940,8 +3950,10 @@
mm->vgcs.enabled = false;

/* Change mode back to normal or limited service. */
-   if (mm->substate == GSM48_MM_SST_RX_VGCS_LIMITED)
-   new_mm_state(mm, GSM48_MM_ST_MM_IDLE, 
GSM48_MM_SST_LIMITED_SERVICE);
+   if (mm->substate == GSM48_MM_SST_RX_VGCS_LIMITED) {
+   new_mm_state(mm, GSM48_MM_ST_MM_IDLE, (subscr->sim_valid) ? 
GSM48_MM_SST_LIMITED_SERVICE
+ : 
GSM48_MM_SST_NO_IMSI);
+   }
if (mm->substate == GSM48_MM_SST_RX_VGCS_NORMAL)
new_mm_state(mm, GSM48_MM_ST_MM_IDLE, 
GSM48_MM_SST_NORMAL_SERVICE);

@@ -3960,8 +3972,12 @@
 static int gsm48_mm_uplink_req(struct osmocom_ms *ms, struct msgb *msg)
 {
struct gsm48_mmlayer *mm = >mmlayer;
+   struct gsm_settings *set = >settings;
struct msgb 

[S] Change in osmocom-bb[master]: ASCI: Use correct mobile identiy in TALKER INDICATION message

[jolly]

jolly has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34865?usp=email )


Change subject: ASCI: Use correct mobile identiy in TALKER INDICATION message
..

ASCI: Use correct mobile identiy in TALKER INDICATION message

Use TMSI only if valid in the current location area. If the MS moves to
a different location area and joins a group call before location update,
TMSI is not valid. Then use IMSI instead. If no IMSI/TSMI is available,
send mobile identity without IMSI/TMSI.

Change-Id: I299604a0e12d91e9133b70757826ac9637da0e3e
Related: OS#5364
---
M src/host/layer23/src/mobile/gsm48_rr.c
1 file changed, 29 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/65/34865/1

diff --git a/src/host/layer23/src/mobile/gsm48_rr.c 
b/src/host/layer23/src/mobile/gsm48_rr.c
index 3200412..b898090 100644
--- a/src/host/layer23/src/mobile/gsm48_rr.c
+++ b/src/host/layer23/src/mobile/gsm48_rr.c
@@ -2085,6 +2085,8 @@
 static int gsm48_rr_tx_talker_indication(struct osmocom_ms *ms)
 {
struct gsm48_rrlayer *rr = >rrlayer;
+   struct gsm_subscriber *subscr = >subscr;
+   struct gsm322_cellsel *cs = >cellsel;
struct msgb *nmsg;
struct gsm48_hdr *gh;
struct gsm48_talker_indication *ti;
@@ -2103,8 +2105,18 @@
/* classmark 2 */
ti->cm2_len = sizeof(ti->cm2);
gsm48_rr_enc_cm2(ms, >cm2, rr->cd_now.arfcn);
-   /* mobile identity (Use TMSI if available.) */
-   gsm48_encode_mi_lv(ms, nmsg, GSM_MI_TYPE_TMSI, false);
+
+   /* mobile identity */
+   if (ms->subscr.tmsi != GSM_RESERVED_TMSI && (osmo_lai_cmp(>lai, 
>sel_cgi.lai) == 0)) {
+   gsm48_encode_mi_lv(ms, nmsg, GSM_MI_TYPE_TMSI, false);
+   LOGP(DRR, LOGL_INFO, "Sending TALKER INDICATION with TMSI.\n");
+   } else if (subscr->imsi[0]) {
+   gsm48_encode_mi_lv(ms, nmsg, GSM_MI_TYPE_IMSI, false);
+   LOGP(DRR, LOGL_INFO, "Sending TALKER INDICATION with IMSI.\n");
+   } else {
+   gsm48_encode_mi_lv(ms, nmsg, GSM_MI_TYPE_NONE, false);
+   LOGP(DRR, LOGL_INFO, "Sending TALKER INDICATION without 
TMSI/IMSI.\n");
+   }

/* start establishmnet */
return gsm48_send_rsl(ms, RSL_MT_EST_REQ, nmsg, 0);

--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34865?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I299604a0e12d91e9133b70757826ac9637da0e3e
Gerrit-Change-Number: 34865
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-MessageType: newchange

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean

[lynxis lazus]

Attention is currently required from: pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email )

Change subject: Makefile: run 'rebar3 clean' upon make clean
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553
Gerrit-Change-Number: 34841
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 12:49:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp

[lynxis lazus]

Attention is currently required from: fixeria, laforge, pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email )

Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
..


Patch Set 4:

(3 comments)

Patchset:

PS4:
Isn't there a GTPv2 ping/pong or keepalive?

I think we need to implement this procedure.


File src/epdg_gtpc_s2b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/ca2ca488_6b71c28a
PS4, Line 10: % This program is free software; you can redistribute it and/or 
modify
In general on this project: We should have a separate discussion about the 
license. I don't know if we're compatible here with AGPL.


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/5bb9a8af_1d83d1d9
PS4, Line 60: %% TODO: make APN configurable? get it from HSS?
The UE sends the APN when connecting to the ePDG within the IKEv2.
It's part of the identity.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 13:01:17 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: Fix sysmocom copyright typo

[lynxis lazus]

Attention is currently required from: pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34863?usp=email )

Change subject: Fix sysmocom copyright typo
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34863?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia6a3748ac3eb7c5587ed978d60afd315dae07a3c
Gerrit-Change-Number: 34863
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 13:02:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: Fix sysmocom copyright typo

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34863?usp=email )


Change subject: Fix sysmocom copyright typo
..

Fix sysmocom copyright typo

Change-Id: Ia6a3748ac3eb7c5587ed978d60afd315dae07a3c
---
M dia/diameter_3gpp_ts29_273.dia
M dia/diameter_3gpp_ts29_273_swx.dia
M dia/diameter_etsi_es283_035.dia
M dia/diameter_rfc5580.dia
M dia/diameter_rfc8583.dia
M src/epdg_diameter_swx.erl
6 files changed, 15 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/63/34863/1

diff --git a/dia/diameter_3gpp_ts29_273.dia b/dia/diameter_3gpp_ts29_273.dia
index ac22a53..e22cc0d 100644
--- a/dia/diameter_3gpp_ts29_273.dia
+++ b/dia/diameter_3gpp_ts29_273.dia
@@ -1,7 +1,7 @@
 ;;
 ;; %CopyrightBegin%
 ;;
-;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 
+;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH 
 ;; Author: Alexander Couzens 
 ;;
 ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15
diff --git a/dia/diameter_3gpp_ts29_273_swx.dia 
b/dia/diameter_3gpp_ts29_273_swx.dia
index d6d446c..1e86dee 100644
--- a/dia/diameter_3gpp_ts29_273_swx.dia
+++ b/dia/diameter_3gpp_ts29_273_swx.dia
@@ -1,7 +1,7 @@
 ;;
 ;; %CopyrightBegin%
 ;;
-;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 
+;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH 
 ;; Author: Alexander Couzens 
 ;;
 ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15
diff --git a/dia/diameter_etsi_es283_035.dia b/dia/diameter_etsi_es283_035.dia
index c1e4e5e..c0baff2 100644
--- a/dia/diameter_etsi_es283_035.dia
+++ b/dia/diameter_etsi_es283_035.dia
@@ -1,7 +1,7 @@
 ;;
 ;; %CopyrightBegin%
 ;;
-;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 
+;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH 
 ;; Author: Alexander Couzens 
 ;;
 ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15
diff --git a/dia/diameter_rfc5580.dia b/dia/diameter_rfc5580.dia
index bfc851a..9a41bd7 100644
--- a/dia/diameter_rfc5580.dia
+++ b/dia/diameter_rfc5580.dia
@@ -1,7 +1,7 @@
 ;;
 ;; %CopyrightBegin%
 ;;
-;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 
+;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH 
 ;; Author: Alexander Couzens 
 ;;
 ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15
diff --git a/dia/diameter_rfc8583.dia b/dia/diameter_rfc8583.dia
index cfde5e5..59df542 100644
--- a/dia/diameter_rfc8583.dia
+++ b/dia/diameter_rfc8583.dia
@@ -1,7 +1,7 @@
 ;;
 ;; %CopyrightBegin%
 ;;
-;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 
+;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH 
 ;; Author: Alexander Couzens 
 ;;
 ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15
diff --git a/src/epdg_diameter_swx.erl b/src/epdg_diameter_swx.erl
index dadfa65..c278206 100644
--- a/src/epdg_diameter_swx.erl
+++ b/src/epdg_diameter_swx.erl
@@ -2,7 +2,7 @@
 %
 % TS 29.273
 %
-% (C) 2023 by sysmocom - s.m.f.c. GmbH 
+% (C) 2023 by sysmocom - s.f.m.c. GmbH 
 % Author: Alexander Couzens 
 %
 % All Rights Reserved

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34863?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia6a3748ac3eb7c5587ed978d60afd315dae07a3c
Gerrit-Change-Number: 34863
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

[L] Change in ...osmo-epdg[master]: Initial S6b support

[pespin]

Attention is currently required from: pespin.

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder


Change subject: Initial S6b support
..

Initial S6b support

So far only the Rx of AAR msg and Tx of AAA is supported.
This allows already going forward during the session creation, where PGW
sends AAR to the AAA server and expects AAA message.

Related: OS#6229
Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
---
M config/sys.config
A src/aaa_diameter_s6b.erl
A src/aaa_diameter_s6b_cb.erl
M src/osmo_epdg_sup.erl
4 files changed, 305 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/58/34858/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
Gerrit-Change-Number: 34858
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

[L] Change in ...osmo-epdg[master]: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp

[pespin]

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin.

Hello Jenkins Builder, fixeria, laforge, lynxis lazus,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email

to look at the new patch set (#4).

The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified-1 by Jenkins 
Builder


Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
..

Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp

Initial GTPv2C infrastructure to send GTPv2C CreateSession Request upon
receival of GSUP EPDG_Tunnel Request, and answer with EPDG_Tunnel
Resp/err when creating the session fails.

Related: OS#6046
Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
---
M config/sys.config
M rebar.config
M rebar.lock
A src/epdg_gtpc_s2b.erl
M src/gsup_server.erl
M src/osmo_epdg.app.src
M src/osmo_epdg_sup.erl
7 files changed, 320 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/04/34804/4
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Attention: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

[S] Change in docker-playground[master]: ttcn3-epdg: Configure S6b interface

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/docker-playground/+/34862?usp=email )


Change subject: ttcn3-epdg: Configure S6b interface
..

ttcn3-epdg: Configure S6b interface

Configure the newly added S6b interface on both TTCN3 emulation code as
well as osmo-epdg.

Depends: osmo-ttcn3-hacks.git Change-Id 
Ia50698a3f6f5ed8251486b84c09f84edfd6d3951
Depends: osmo-epdg.git Change-Id Ia2b138317cb291a95882853f5403949c5e6a5a1b
Change-Id: I1145ee1068a2fdd2fe8d3e48b80c8e6c1fcb50ad
---
M ttcn3-epdg-test/EPDG_Tests.cfg
M ttcn3-epdg-test/osmo-epdg.config
2 files changed, 23 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/62/34862/1

diff --git a/ttcn3-epdg-test/EPDG_Tests.cfg b/ttcn3-epdg-test/EPDG_Tests.cfg
index f05a819..2a39b67 100644
--- a/ttcn3-epdg-test/EPDG_Tests.cfg
+++ b/ttcn3-epdg-test/EPDG_Tests.cfg
@@ -13,6 +13,7 @@
 EPDG_Tests.mp_s2b_local_ip := "172.18.10.103"

 EPDG_Tests.mp_gsup_remote_ip := "172.18.10.20"
+EPDG_Tests.mp_s6b_remote_ip := "172.18.10.20"
 EPDG_Tests.mp_s2b_remote_ip := "172.18.10.20"

 [MAIN_CONTROLLER]
diff --git a/ttcn3-epdg-test/osmo-epdg.config b/ttcn3-epdg-test/osmo-epdg.config
index 8036b2c..0aa9807 100644
--- a/ttcn3-epdg-test/osmo-epdg.config
+++ b/ttcn3-epdg-test/osmo-epdg.config
@@ -10,11 +10,18 @@
{diameter_remote_ip, "172.18.10.103"},
{diameter_remote_port, 3868},
{diameter_proto, sctp},
-   % Diameter Server parameters
{vendor_id, 0},
{origin_host, "epdg.localdomain"},
{origin_realm, "localdomain"},
{context_id, "epdg@localdomain"},
+   % Diameter s6b Connection parameters
+   {dia_s6b_local_ip, "172.18.10.20"},
+   {dia_s6b_local_port, 3869},
+   {dia_s6b_proto, sctp},
+   {dia_s6b_vendor_id, 0},
+   {dia_s6b_origin_host, "aaa.localdomain"},
+   {dia_s6b_origin_realm, "localdomain"},
+   {dia_s6b_context_id, "aaa@localdomain"},
% GTPv2C Connection parameters
{gtpc_local_ip, "172.18.10.20"},
{gtpc_local_port, 2123},

--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34862?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I1145ee1068a2fdd2fe8d3e48b80c8e6c1fcb50ad
Gerrit-Change-Number: 34862
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

[L] Change in ...osmo-epdg[master]: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)

[pespin]

Attention is currently required from: pespin.

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder


Change subject: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 
5777)
..

diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)

S6b interface HSS<->PGW is defined in TS 28.273 section 9.

TS 28.273 depends on some types defined in RFC 5777, which was missing
so far.

Some enumareated types in RFC 5777 whose enums fields are declared in
yet other dependent RFCs are left with a dummy value, as TODO for the
future if they are ever needed.

Related: OS#6229
Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc
---
A dia/diameter_3gpp_ts29_273_s6b.dia
A dia/diameter_rfc5777.dia
2 files changed, 553 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/57/34857/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc
Gerrit-Change-Number: 34857
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

[M] Change in osmo-ttcn3-hacks[master]: DIAMETER_Templates: Add S6b AAR and AAA message templates

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34860?usp=email )


Change subject: DIAMETER_Templates: Add S6b AAR and AAA message templates
..

DIAMETER_Templates: Add S6b AAR and AAA message templates

Related: OS#6229
Change-Id: I302d9a94e6ffbb62b6db81e1b14484355e55ebe5
---
M library/DIAMETER_Templates.ttcn
1 file changed, 97 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/60/34860/1

diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn
index f909b5f..f46bf37 100644
--- a/library/DIAMETER_Templates.ttcn
+++ b/library/DIAMETER_Templates.ttcn
@@ -127,6 +127,8 @@
 const uint32_t c_DIAMETER_3GPP_S7_AID := 16777308;
 /* 3GPP TS 29.273 Section 8.2 */
 const uint32_t c_DIAMETER_3GPP_SWx_AID := 16777265;
+/* 3GPP TS 29.273 Section 9 */
+const uint32_t c_DIAMETER_3GPP_S6b_AID := 16777272;

 const octetstring c_def_sess_id := char2oct("ttcn3.session");

@@ -1518,6 +1520,34 @@
}
 }

+/* RFC6733 8.7.  Auth-Request-Type AVP */
+template (value) GenericAVP ts_AVP_AuthRequestType(BASE_NONE_Auth_Request_Type 
auth_req_type) := {
+   avp := {
+   avp_header := 
ts_DIA_Hdr(c_AVP_Code_BASE_NONE_Auth_Request_Type, ''B),
+   avp_data := {
+   avp_BASE_NONE_Auth_Request_Type := auth_req_type
+   }
+   }
+}/*
+private function f_tr_AVP_AuthRequestType(template (present) 
BASE_NONE_Auth_Request_Type auth_req_type)
+return template (present) BASE_NONE_Auth_Request_Type {
+   if (istemplatekind(auth_req_type, "?")) {
+   return ?;
+   } else {
+   var template (present) BASE_NONE_Auth_Request_Type c;
+   c := int2oct(enum2int(valueof(auth_req_type)), 4);
+   return c;
+   }
+}*/
+template (present) GenericAVP tr_AVP_AuthRequestType(template (present) 
BASE_NONE_Auth_Request_Type auth_req_type) := {
+   avp := {
+   avp_header := 
tr_DIA_Hdr(c_AVP_Code_BASE_NONE_Auth_Request_Type),
+   avp_data := {
+   avp_BASE_NONE_Auth_Request_Type := auth_req_type
+   }
+   }
+}
+

 /* 5.3.1 Capabilities Exchange Request */
 template (value) PDU_DIAMETER
@@ -2276,9 +2306,9 @@
}
 }

-/*
- * SWx 3GPP TS 29.273
- */
+/***
+ * SWx 3GPP TS 29.273 section 8
+ ***/

 /* SIP-Auth-Data-Item , 3GPP TS 29.273 8.2.3.9 */
 template (present) GenericAVP tr_AVP_3GPP_SIPAuthDataItem(template (present) 
uint32_t num := ?) := {
@@ -2445,4 +2475,58 @@
 */
});

+/***
+ * S6b 3GPP TS 29.273 section 9
+ ***/
+
+ /* TS 29.273 9.2.2.5.1 AA-Request (AAR) */
+template (value) PDU_DIAMETER
+ts_DIA_S6b_AAR(template (value) hexstring imsi,
+  template (value) octetstring sess_id := c_def_sess_id,
+  template (value) charstring orig_host := "pgw.localdomain",
+  template (value) charstring orig_realm := "localdomain",
+  template (value) charstring dest_realm := "localdomain",
+  template (value) UINT32 hbh_id := ''O,
+  template (value) UINT32 ete_id := ''O) :=
+   ts_DIAMETER(flags := '1100'B,
+   cmd_code := Authorize_Authenticate,
+   app_id := int2oct(c_DIAMETER_3GPP_S6b_AID, 4),
+   hbh_id := hbh_id,
+   ete_id := ete_id,
+   avps := {
+   ts_AVP_SessionId(sess_id),
+   /* Optional: DRMP, */
+   ts_AVP_AuthAppId(int2oct(c_DIAMETER_3GPP_S6b_AID, 4)),
+   ts_AVP_OriginHost(orig_host),
+   ts_AVP_OriginRealm(orig_realm),
+   ts_AVP_DestinationRealm(dest_realm),
+   ts_AVP_AuthRequestType(AUTHORIZE_ONLY),
+   ts_AVP_UserNameImsi(valueof(imsi))
+   /* TODO: Lots other optional */
+   });
+
+/* TS 29.273 9.2.2.2.2 AA-Answer (AAA) */
+template (present) PDU_DIAMETER
+tr_DIA_S6b_AAA(template (present) octetstring sess_id := ?,
+  template (present) charstring orig_host :=  ?,
+  template (present) charstring orig_realm := ?,
+  template (present) charstring dest_realm := ?,
+  template (present) UINT32 hbh_id := ?,
+  template (present) UINT32 ete_id := ?,
+  template (present) CxDx_3GPP_Server_Assignment_Type 
server_ass_type := ?,
+  template (present) charstring service_selection := ?) :=
+   tr_DIAMETER(flags := '0???'B,
+   cmd_code := Authorize_Authenticate,
+   app_id := 

[L] Change in ...osmo-epdg[master]: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email )

Change subject: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 
5777)
..


Patch Set 1:

(1 comment)

File dia/diameter_3gpp_ts29_273_s6b.dia:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12018):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857/comment/cc7898ce_d6110cf8
PS1, Line 4: ;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 

's.m.f.c.' may be misspelled - perhaps 's.f.m.c.'?



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc
Gerrit-Change-Number: 34857
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 23 Oct 2023 12:35:58 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: epdg: Emulate PGW tx AAR and rx AAA in S6b interface

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34861?usp=email )


Change subject: epdg: Emulate PGW tx AAR and rx AAA in S6b interface
..

epdg: Emulate PGW tx AAR and rx AAA in S6b interface

Related: OS#6229
Change-Id: Ia50698a3f6f5ed8251486b84c09f84edfd6d3951
---
M epdg/EPDG_Tests.ttcn
1 file changed, 42 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/61/34861/1

diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn
index 3a0c3a6..76fd45e 100644
--- a/epdg/EPDG_Tests.ttcn
+++ b/epdg/EPDG_Tests.ttcn
@@ -32,6 +32,8 @@
/* our emulated PGW (Diameter S6b) */
charstring mp_s6b_local_ip := "127.0.0.100";
integer mp_s6b_local_port := 3869;
+   charstring mp_s6b_remote_ip := "127.0.0.1";
+   integer mp_s6b_remote_port := 3869;

/* our emulated PGW (GTPv2C S2b) */
charstring mp_s2b_local_ip := "127.0.0.100";
@@ -212,14 +214,14 @@

/* S6b setup: */
pars := {
-   remote_ip := "",
-   remote_sctp_port := -1, /* server mode */
+   remote_ip := mp_s6b_remote_ip,
+   remote_sctp_port := mp_s6b_remote_port, /* client mode */
local_ip := mp_s6b_local_ip,
local_sctp_port := mp_s6b_local_port,
-   origin_host := "hss." & mp_diam_realm,
+   origin_host := "pgw." & mp_diam_realm,
origin_realm := mp_diam_realm,
-   auth_app_id := omit,
-   vendor_app_id := c_DIAMETER_3GPP_S6_AID
+   auth_app_id := c_DIAMETER_3GPP_S6b_AID,
+   vendor_app_id := c_DIAMETER_3GPP_S6b_AID
};
vc_S6b := DIAMETER_Emulation_CT.create(id);
map(vc_S6b:DIAMETER, system:DIAMETER_CODEC_PT);
@@ -228,8 +230,7 @@
vc_S6b.start(DIAMETER_Emulation.main(ops, pars, id));

f_diameter_wait_capability(SWx_UNIT);
-   // FIXME: osmo-epdg doesn't connect to S6b yet.
-   //f_diameter_wait_capability(S6b_UNIT);
+   f_diameter_wait_capability(S6b_UNIT);

/* Give some time for our emulation to get out of SUSPECT list of SUT 
(3 watchdog ping-pongs):
 * RFC6733 sec 5.1
@@ -362,6 +363,26 @@
}
 }

+/* Send AAR as PGW to AAA server, expect back AAA */
+private function f_S6b_AA_success() runs on EPDG_ConnHdlr {
+   var PDU_DIAMETER rx_dia;
+   var UINT32 hbh_id := f_rnd_octstring(4);
+   var UINT32 ete_id := f_rnd_octstring(4);
+
+   /* Unlike AAR, AAA contains no IMSI. Register ete_id in 
DIAMETER_Emulation,
+* so AIA is forwarded back to us in DIAMETER port instead of 
MTC_CT.DIAMETER_UNIT.
+*/
+   f_epdg_connhldr_S6b_expect_eteid(ete_id);
+
+   S6b.send(ts_DIA_S6b_AAR(g_pars.imsi, hbh_id := hbh_id, ete_id := 
ete_id));
+   alt {
+   [] S6b.receive(tr_DIA_S6b_AAA) -> value rx_dia {}
+   [] S6b.receive(PDU_DIAMETER:?) -> value rx_dia {
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
log2str("Unexpected Diameter S6b msg rx: ", rx_dia));
+   }
+   }
+}
+
 /* Diameter SWx SAR + SAA. */
 private altstep as_GTP2C_CreateSession_success() runs on EPDG_ConnHdlr {
var PDU_GTPCv2 rx_msg;
@@ -375,11 +396,15 @@
g_pars.teic := f_gtp2_allocate_teid();
g_pars.teid := g_pars.teic;

+   /* Upon rx of CreateSession, emulate PGW asking the AAA server. 
*/
+   f_S6b_AA_success();
+
fteid_c_ie := ts_GTP2C_FTEID(FTEID_IF_S2b_ePDG_GTPC, 
g_pars.teic, 0,
f_inet_addr(mp_s2b_local_ip), omit);
fteid_u_ie := ts_GTP2C_FTEID(FTEID_IF_S2bU_ePDG_GTPU, 
g_pars.teid, 2,
f_inet_addr(mp_s2b_local_ip), omit);
paa := ts_GTP2C_PdnAddrAlloc_v4(f_inet_addr(g_pars.ue_ip));
+
GTP2.send(ts_GTP2C_CreateSessionResp({ fteid_c_ie }, paa));
setverdict(pass);
}

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34861?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia50698a3f6f5ed8251486b84c09f84edfd6d3951
Gerrit-Change-Number: 34861
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

[L] Change in ...osmo-epdg[master]: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp

[Jenkins Builder]

Attention is currently required from: lynxis lazus, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email )

Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
..


Patch Set 3:

(1 comment)

File src/epdg_gtpc_s2b.erl:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12017):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/24d562e3_99a55aa2
PS3, Line 5: % (C) 2023 by sysmocom - s.m.f.c. GmbH 
's.m.f.c.' may be misspelled - perhaps 's.f.m.c.'?



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Mon, 23 Oct 2023 12:35:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: Initial S6b support

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email )


Change subject: Initial S6b support
..

Initial S6b support

So far only the Rx of AAR msg and Tx of AAA is supported.
This allows already going forward during the session creation, where PGW
sends AAR to the AAA server and expects AAA message.

Related: OS#6229
Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
---
M config/sys.config
A src/aaa_diameter_s6b.erl
A src/aaa_diameter_s6b_cb.erl
M src/osmo_epdg_sup.erl
4 files changed, 305 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/58/34858/1

diff --git a/config/sys.config b/config/sys.config
index 1b89e86..630a057 100755
--- a/config/sys.config
+++ b/config/sys.config
@@ -5,15 +5,22 @@
   [% GSUP Server connection parameters
{gsup_local_ip, "0.0.0.0"},
{gsup_local_port, 4222},
-   % Diameter Connection parameters
+   % Diameter SWx Connection parameters
{diameter_remote_ip, "127.0.0.1"},
{diameter_remote_port, 3868},
{diameter_proto, sctp},
-   % Diameter Server parameters
{vendor_id, 0},
{origin_host, "epdg.localdomain"},
{origin_realm, "localdomain"},
{context_id, "epdg@localdomain"},
+   % Diameter s6b Connection parameters
+   {dia_s6b_local_ip, "127.0.0.10"},
+   {dia_s6b_local_port, 3868},
+   {dia_s6b_proto, sctp},
+   {dia_s6b_vendor_id, 0},
+   {dia_s6b_origin_host, "aaa.localdomain"},
+   {dia_s6b_origin_realm, "localdomain"},
+   {dia_s6b_context_id, "aaa@localdomain"},
% GTPv2C Connection parameters
{gtpc_local_ip, "127.0.0.2"},
{gtpc_local_port, 2123},
diff --git a/src/aaa_diameter_s6b.erl b/src/aaa_diameter_s6b.erl
new file mode 100644
index 000..1348e70
--- /dev/null
+++ b/src/aaa_diameter_s6b.erl
@@ -0,0 +1,203 @@
+% S6b: AAA side
+%
+% 3GPP TS 29.273 section 9
+%
+% (C) 2023 by sysmocom - s.m.f.c. GmbH 
+% Author: Pau Espin Pedrol 
+%
+% All Rights Reserved
+%
+% This program is free software; you can redistribute it and/or modify
+% it under the terms of the GNU Affero General Public License as
+% published by the Free Software Foundation; either version 3 of the
+% License, or (at your option) any later version.
+%
+% This program is distributed in the hope that it will be useful,
+% but WITHOUT ANY WARRANTY; without even the implied warranty of
+% MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+% GNU General Public License for more details.
+%
+% You should have received a copy of the GNU Affero General Public License
+% along with this program.  If not, see .
+%
+% Additional Permission under GNU AGPL version 3 section 7:
+%
+% If you modify this Program, or any covered work, by linking or
+% combining it with runtime libraries of Erlang/OTP as released by
+% Ericsson on http://www.erlang.org (or a modified version of these
+% libraries), containing parts covered by the terms of the Erlang Public
+% License (http://www.erlang.org/EPLICENSE), the licensors of this
+% Program grant you additional permission to convey the resulting work
+% without the need to license the runtime libraries of Erlang/OTP under
+% the GNU Affero General Public License. Corresponding Source for a
+% non-source form of such a combination shall include the source code
+% for the parts of the runtime libraries of Erlang/OTP used as well as
+% that of the covered work.
+
+
+-module(aaa_diameter_s6b).
+-author('Pau Espin Pedrol ').
+
+-behaviour(gen_server).
+
+-include_lib("diameter_3gpp_ts29_273_s6b.hrl").
+-include_lib("diameter/include/diameter_gen_base_rfc6733.hrl").
+
+%% API Function Exports
+-export([start_link/0]).
+-export([start/0, stop/0, terminate/2]).
+%% gen_server Function Exports
+-export([init/1, handle_call/3, handle_cast/2, handle_info/2]).
+-export([code_change/3]).
+-export([multimedia_auth_request/6]).
+-export([server_assignment_request/3]).
+-export([test/0, test/1]).
+
+%% Diameter Application Definitions
+-define(SERVER, ?MODULE).
+-define(SVC_NAME, ?MODULE).
+-define(APP_ALIAS, ?MODULE).
+-define(CALLBACK_MOD, aaa_diameter_s6b_cb).
+-define(DIAMETER_DICT_S6b, diameter_3gpp_ts29_273_s6b).
+-define(ENV_APP_NAME, osmo_epdg).
+-define(ENV_DEFAULT_SESSION_ID, "aaa@localdomain").
+-define(ENV_DEFAULT_ORIG_REALM, "localdomain").
+-define(ENV_DEFAULT_ORIG_HOST, "aaa.localdomain").
+-define(ENV_DEFAULT_VENDOR_ID, 0).
+-define(ENV_DEFAULT_DIAMETER_PROTO, sctp).
+-define(ENV_DEFAULT_DIAMETER_REMOTE_IP, "127.0.0.10").
+-define(ENV_DEFAULT_DIAMETER_REMOTE_PORT, 3868).
+
+-define(VENDOR_ID_3GPP, 10415).
+-define(VENDOR_ID_3GPP2, 5535).
+-define(VENDOR_ID_ETSI, 13019).
+-define(DIAMETER_APP_ID_S6b, ?DIAMETER_DICT_S6b:id()).
+%% The service configuration. As in the server example, a client
+%% supporting multiple Diameter applications may or may not want to
+%% configure a common callback module on all 

[L] Change in ...osmo-epdg[master]: Initial S6b support

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email )

Change subject: Initial S6b support
..


Patch Set 1:

(1 comment)

File src/aaa_diameter_s6b.erl:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12016):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858/comment/5befadd7_4a1caf21
PS1, Line 5: % (C) 2023 by sysmocom - s.m.f.c. GmbH 
's.m.f.c.' may be misspelled - perhaps 's.f.m.c.'?



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
Gerrit-Change-Number: 34858
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 23 Oct 2023 12:35:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email )


Change subject: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 
5777)
..

diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)

S6b interface HSS<->PGW is defined in TS 28.273 section 9.

TS 28.273 depends on some types defined in RFC 5777, which was missing
so far.

Some enumareated types in RFC 5777 whose enums fields are declared in
yet other dependent RFCs are left with a dummy value, as TODO for the
future if they are ever needed.

Related: OS#6229
Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc
---
A dia/diameter_3gpp_ts29_273_s6b.dia
A dia/diameter_rfc5777.dia
2 files changed, 553 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/57/34857/1

diff --git a/dia/diameter_3gpp_ts29_273_s6b.dia 
b/dia/diameter_3gpp_ts29_273_s6b.dia
new file mode 100644
index 000..790a43d
--- /dev/null
+++ b/dia/diameter_3gpp_ts29_273_s6b.dia
@@ -0,0 +1,166 @@
+;;
+;; %CopyrightBegin%
+;;
+;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH 
+;; Author: Pau Espin Pedrol 
+;;
+;; This resembles 3GPP TS 29.273 version 17.6.0 Release 17
+;;
+;; Licensed under the Apache License, Version 2.0 (the "License");
+;; you may not use this file except in compliance with the License.
+;; You may obtain a copy of the License at
+;;
+;; http://www.apache.org/licenses/LICENSE-2.0
+;;
+;; Unless required by applicable law or agreed to in writing, software
+;; distributed under the License is distributed on an "AS IS" BASIS,
+;; WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+;; See the License for the specific language governing permissions and
+;; limitations under the License.
+;;
+;; %CopyrightEnd%
+;;
+
+;;
+;; Edits:
+;;
+;;
+
+
+@id 16777272
+@name   diameter_3gpp_ts29_273_s6b
+;;@prefix diameter_3gpp
+@vendor 10415 3GPP
+
+@inherits diameter_gen_base_rfc6733
+@inherits diameter_3gpp_base
+@inherits diameter_3gpp_break_circles
+@inherits diameter_3gpp_ts29_212
+@inherits diameter_3gpp_ts29_214
+@inherits diameter_3gpp_ts29_229
+@inherits diameter_3gpp_ts29_272
+@inherits diameter_3gpp_ts29_273
+@inherits diameter_3gpp_ts32_299
+@inherits diameter_etsi_es283_034
+@inherits diameter_rfc4006_cc
+@inherits diameter_rfc5447
+@inherits diameter_rfc5580
+@inherits diameter_rfc5777
+@inherits diameter_rfc5778
+@inherits diameter_rfc7683
+@inherits diameter_rfc7944
+@inherits diameter_rfc8583
+
+@messages
+
+;; 9. S6b
+;; 9.2.2.2.1 AA-Request (AAR)
+
+   AAR ::= < Diameter Header: 265, REQ, PXY >
+   < Session-Id >
+   { Auth-Application-Id }
+   { Origin-Host }
+   { Origin-Realm }
+   { Destination-Realm }
+   { Auth-Request-Type }
+   [ User-Name ]
+   [ MIP6-Agent-Info ]
+   [ MIP6-Feature-Vector ]
+   [ Visited-Network-Identifier ]
+   [ QoS-Capability ]
+   [ Service-Selection ]
+   [ OC-Supported-Features ]
+   [ Origination-Time-Stamp ]
+   [ Maximum-Wait-Time ]
+   *[ Supported-Features ]
+   [ Emergency-Services ]
+   *[ AVP ]
+
+;; 9.2.2.2.2 AA-Answer (AAA)
+   AAA ::= < Diameter Header: 265, PXY >
+   < Session-Id >
+   { Auth-Application-Id }
+   { Auth-Request-Type }
+   { Result-Code }
+   { Origin-Host }
+   { Origin-Realm }
+   [ MIP6-Feature-Vector ]
+   [ Session-Timeout ]
+   [ APN-Configuration ]
+   [ QoS-Resources ]
+   [ AN-Trusted ]
+   *[ Redirect-Host ]
+   [ Trace-Info ]
+   [ OC-Supported-Features ]
+   [ OC-OLR ]
+   *[ Load ]
+
+;; 9.2.2.3.1 Session-Termination-Request (STR)
+;; 9.2.2.4.3 Session-Termination-Request (STR)
+   STR ::= < Diameter Header: 275, REQ, PXY >
+   < Session-Id >
+   { Auth-Application-Id }
+   { Origin-Host }
+   { Origin-Realm }
+   { Destination-Realm }
+   { Termination-Cause }
+   [ User-Name ]
+   [ OC-Supported-Features ]
+   *[ AVP ]
+
+;; 9.2.2.3.2 Session-Termination-Answer (STA)
+;; 9.2.2.4.4 Session-Termination-Answer (STA)
+   STA ::= < Diameter Header: 275, PXY >
+   < Session-Id >
+   { Result-Code }
+   { Origin-Host }
+   { Origin-Realm }
+   [ OC-Supported-Features ]
+   [ OC-OLR ]
+   *[ Load ]
+   *[ AVP ]
+
+;; 9.2.2.4.1 Abort-Session-Request (ASR)
+   ASR ::= < Diameter Header: 274, REQ, PXY >
+   < Session-Id >
+   { 

[S] Change in ...osmo-epdg[master]: WIP

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34859?usp=email )


Change subject: WIP
..

WIP

Change-Id: I88cb82cc245da7da1c5f04fc20dc529110c34c51
---
M rebar.config
1 file changed, 10 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/59/34859/1

diff --git a/rebar.config b/rebar.config
index d834c32..83923b8 100644
--- a/rebar.config
+++ b/rebar.config
@@ -6,7 +6,7 @@
{lager, {git, "https://github.com/erlang-lager/lager;, {tag, "3.9.2"}}},
{gtplib, "3.2.0"},
{osmo_ss7, {git, "https://gitea.osmocom.org/erlang/osmo_ss7;, {ref, 
"9f294d3612f998860004820d1d85b4264721577b"}}},
-   {osmo_gsup,  {git, "https://gitea.osmocom.org/erlang/osmo_gsup;, {ref, 
"07672d8ab1608aa9c9e50ca035521876558fcd42"}}}
+   {osmo_gsup,  {git, "https://gitea.osmocom.org/erlang/osmo_gsup;, {ref, 
"e23f118e6e8f7ee1247db34e4cb79e4cecdb0947"}}}
 ]}.

 {minimum_otp_vsn, "20.3"}.

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34859?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I88cb82cc245da7da1c5f04fc20dc529110c34c51
Gerrit-Change-Number: 34859
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

[S] Change in pysim[master]: prevent SimCardCommands.select_adf_by_aid bypassing lchan

[laforge]

Attention is currently required from: fixeria.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34849?usp=email )

Change subject: prevent SimCardCommands.select_adf_by_aid bypassing lchan
..


Patch Set 2:

(1 comment)

File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/34849/comment/86a1eaea_77077d00
PS1, Line 149: SimCardCommands
> `Optional[SimCardCommands]` as it can be `None`
Done



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34849?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idf05c297e6a2e24ca539408b8912e348c0782bb4
Gerrit-Change-Number: 34849
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 23 Oct 2023 11:47:49 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

[S] Change in pysim[master]: prevent SimCardCommands.select_adf_by_aid bypassing lchan

[laforge]

Attention is currently required from: fixeria, laforge.

Hello Jenkins Builder, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/34849?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder


Change subject: prevent SimCardCommands.select_adf_by_aid bypassing lchan
..

prevent SimCardCommands.select_adf_by_aid bypassing lchan

Now that pySim-shell is aware of logical channels and issues almost
all of its APDUs on the currently selected channel, we must also make
sure that ADF selection by AID (implemented by the CardBase class)
issues the SELECT on the respective logical channel.

Before this patch, SELECT ADF by AID would always be issued on the
primary logical channel (0), irrespective of the currently active
RuntimeLchan.

Change-Id: Idf05c297e6a2e24ca539408b8912e348c0782bb4
Related: OS#6230
---
M pySim/cards.py
M pySim/runtime.py
2 files changed, 26 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/49/34849/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34849?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idf05c297e6a2e24ca539408b8912e348c0782bb4
Gerrit-Change-Number: 34849
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-MessageType: newpatchset

[S] Change in pysim[master]: pySim-shell: Include current logical channel in prompt

[laforge]

Attention is currently required from: laforge.

Hello Jenkins Builder, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/34850?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: pySim-shell: Include current logical channel in prompt
..

pySim-shell: Include current logical channel in prompt

Now that pySim-shell can switch between logical channels, let's state
the currently used logical channel in the prompt.

Change-Id: I45781a6fba205eeb4ac7f58d5cb642b7131bdd88
Related: OS#6230
---
M pySim-shell.py
1 file changed, 14 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/50/34850/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34850?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I45781a6fba205eeb4ac7f58d5cb642b7131bdd88
Gerrit-Change-Number: 34850
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: laforge 
Gerrit-MessageType: newpatchset

[S] Change in pysim[master]: transport: print reader device/number on init

[laforge]

Attention is currently required from: dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34686?usp=email )

Change subject: transport: print reader device/number on init
..


Patch Set 10:

(1 comment)

Patchset:

PS10:
> I wonder if we could have a command line option like --verbose. […]
I don't like the --verbose idea - at leat not for this particular topic.  The 
information like which card reader is used, the ATR of the card, ... should be 
printed by default to the user.  We just want a way to disable 
non-deterministic bits during tests.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34686?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5c08995fcd55bd9bb173adc2acd9722e438a164b
Gerrit-Change-Number: 34686
Gerrit-PatchSet: 10
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-CC: fixeria 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 23 Oct 2023 11:43:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Comment-In-Reply-To: dexter 
Gerrit-MessageType: comment

[L] Change in pysim[master]: Initial support for eUICC

[laforge]

Attention is currently required from: dexter, fixeria.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34852?usp=email )

Change subject: Initial support for eUICC
..


Patch Set 4:

(1 comment)

This change is ready for review.

File pySim/euicc.py:

https://gerrit.osmocom.org/c/pysim/+/34852/comment/553936ae_7350e8e9
PS4, Line 181: cmd_do_len
> unused?
thanks. that was a result of copy+paste



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34852?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieab37b083e25d3f36c20f6e9ed3e4bdfdd14a42a
Gerrit-Change-Number: 34852
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-CC: fixeria 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 23 Oct 2023 11:47:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat, part 2

[osmith]

osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email )

Change subject: scripts/repo-install-test: fix sftp compat, part 2
..

scripts/repo-install-test: fix sftp compat, part 2

Copy files inside repo-install-test, instead of copying the directory
again. Otherwise it creates a /repo-install-test/repo-install-test/ path
inside qemu and then fails to run the script inside the directory:

Fix for:
  sh: 0: cannot open /repo-install-test/run-inside-env.sh: No such file

Fixes: a7791217 ("scripts/repo-install-test: fix sftp compat")
Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11
---
M scripts/repo-install-test.sh
1 file changed, 18 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved




diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh
index 98f0176..7bef5bf 100755
--- a/scripts/repo-install-test.sh
+++ b/scripts/repo-install-test.sh
@@ -154,7 +154,7 @@

qemu_ssh rm -rf /repo-install-test/
qemu_ssh mkdir /repo-install-test
-   qemu_scp -r "$TEST_DIR" "root@127.0.0.1:/repo-install-test"
+   qemu_scp -r "$TEST_DIR"/* "root@127.0.0.1:/repo-install-test"

TIMEOUT="1h" qemu_ssh sh -ex /repo-install-test/run-inside-env.sh
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11
Gerrit-Change-Number: 34856
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat, part 2

[pespin]

Attention is currently required from: fixeria, osmith.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email )

Change subject: scripts/repo-install-test: fix sftp compat, part 2
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11
Gerrit-Change-Number: 34856
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 23 Oct 2023 11:23:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean

[osmith]

Attention is currently required from: pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email )

Change subject: Makefile: run 'rebar3 clean' upon make clean
..


Patch Set 3: Code-Review+1

(1 comment)

File Makefile:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841/comment/90a22bd4_b2f1690f
PS2, Line 17: #
> Insert a space after # in each line to make it more readable?
Done



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553
Gerrit-Change-Number: 34841
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 11:12:44 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith 
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean

[osmith]

Attention is currently required from: pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email )

Change subject: Makefile: run 'rebar3 clean' upon make clean
..


Patch Set 2: Code-Review+1

(1 comment)

File Makefile:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841/comment/ec1105b9_819ebe94
PS2, Line 17: #
Insert a space after # in each line to make it more readable?



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553
Gerrit-Change-Number: 34841
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 11:11:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean

[pespin]

Attention is currently required from: osmith, pespin.

Hello Jenkins Builder, osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder


Change subject: Makefile: run 'rebar3 clean' upon make clean
..

Makefile: run 'rebar3 clean' upon make clean

Otherwise the diameter files generated during compile in include/ and
src/ are not removed.

Change-Id: I771860f965499bb754c13385819845ef23f33553
---
M Makefile
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/41/34841/3
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553
Gerrit-Change-Number: 34841
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-Attention: osmith 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat, part 2

[osmith]

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email )


Change subject: scripts/repo-install-test: fix sftp compat, part 2
..

scripts/repo-install-test: fix sftp compat, part 2

Copy files inside repo-install-test, instead of copying the directory
again. Otherwise it creates a /repo-install-test/repo-install-test/ path
inside qemu and then fails to run the script inside the directory:

Fix for:
  sh: 0: cannot open /repo-install-test/run-inside-env.sh: No such file

Fixes: a7791217 ("scripts/repo-install-test: fix sftp compat")
Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11
---
M scripts/repo-install-test.sh
1 file changed, 18 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/56/34856/1

diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh
index 98f0176..7bef5bf 100755
--- a/scripts/repo-install-test.sh
+++ b/scripts/repo-install-test.sh
@@ -154,7 +154,7 @@

qemu_ssh rm -rf /repo-install-test/
qemu_ssh mkdir /repo-install-test
-   qemu_scp -r "$TEST_DIR" "root@127.0.0.1:/repo-install-test"
+   qemu_scp -r "$TEST_DIR"/* "root@127.0.0.1:/repo-install-test"

TIMEOUT="1h" qemu_ssh sh -ex /repo-install-test/run-inside-env.sh
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11
Gerrit-Change-Number: 34856
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-MessageType: newchange

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean

[pespin]

Attention is currently required from: pespin.

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder


Change subject: Makefile: run 'rebar3 clean' upon make clean
..

Makefile: run 'rebar3 clean' upon make clean

Otherwise the diameter files generated during compile in include/ and
src/ are not removed.

Change-Id: I771860f965499bb754c13385819845ef23f33553
---
M Makefile
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/41/34841/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553
Gerrit-Change-Number: 34841
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

[M] Change in osmo-pcu[master]: pcuif_proto: drop support for PCUIF v10

[osmith]

Attention is currently required from: dexter, fixeria.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email )

Change subject: pcuif_proto: drop support for PCUIF v10
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8
Gerrit-Change-Number: 34706
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 23 Oct 2023 10:33:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-pcu[master]: pcu_l1_if: signal BTS model via PCUIF

[pespin]

Attention is currently required from: dexter, fixeria, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email )

Change subject: pcu_l1_if: signal BTS model via PCUIF
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047
Gerrit-Change-Number: 34647
Gerrit-PatchSet: 5
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 23 Oct 2023 10:21:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in osmo-pcu[master]: pcuif_proto: drop support for PCUIF v10

[pespin]

Attention is currently required from: dexter, fixeria, osmith.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email )

Change subject: pcuif_proto: drop support for PCUIF v10
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8
Gerrit-Change-Number: 34706
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 23 Oct 2023 10:19:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in osmo-bts[master]: pcuif_proto: signal BTS model via PCUIF

[Jenkins Builder]

Attention is currently required from: osmith, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email )

Change subject: pcuif_proto: signal BTS model via PCUIF
..


Patch Set 6:

(2 comments)

File src/common/pcu_sock.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12005):
https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/bd7c27e0_11d17df1
PS6, Line 235: static enum gsm_pcuif_bts_model bts_model_from_variant(enum 
gsm_bts_type_variant variant) {
open brace '{' following function definitions go on the next line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12005):
https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/e0a784a2_30e4fff6
PS6, Line 247:  return PCU_IF_BTS_MODEL_TRX;
code indent should use tabs where possible



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib51238a0e09d4484a539a7f822864189872698b6
Gerrit-Change-Number: 34648
Gerrit-PatchSet: 6
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: osmith 
Gerrit-Attention: osmith 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 10:16:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmo-pcu[master]: pcu_l1_if: signal BTS model via PCUIF

[dexter]

Attention is currently required from: fixeria, laforge, pespin.

Hello Jenkins Builder, fixeria, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email

to look at the new patch set (#5).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder


Change subject: pcu_l1_if: signal BTS model via PCUIF
..

pcu_l1_if: signal BTS model via PCUIF

At the moment the PCU has no way of knowing with which BTS model it is
used with. However, some BTS models may require slightly different
behaviour by the PCU, depending on which BTS model is used. So, lets add
an additional bts_model field to struct gsm_pcu_if_info_ind in order to
convey the exact BTS model to the PCU and store this information in
struct gprs_rlcmac_bts

Related: OS#6191
Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047
---
M include/osmocom/pcu/pcuif_proto.h
M src/bts.h
M src/pcu_l1_if.cpp
3 files changed, 47 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/47/34647/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047
Gerrit-Change-Number: 34647
Gerrit-PatchSet: 5
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-MessageType: newpatchset

[M] Change in osmo-bts[master]: pcuif_proto: signal BTS model via PCUIF

[dexter]

Attention is currently required from: osmith, pespin.

Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email

to look at the new patch set (#6).

The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder


Change subject: pcuif_proto: signal BTS model via PCUIF
..

pcuif_proto: signal BTS model via PCUIF

At the moment the PCU has no way of knowing with which BTS model it is
used with. However, some BTS models may require slightly different
behaviour by the PCU, depending on which BTS model is used. So, lets add
an additional bts_model field to struct gsm_pcu_if_info_ind in order to
convey the exact BTS model to the PCU.

Related: OS#6191
Depends: osmo-pcu.git I48eb75f65ab54fdec41ef913e24c1f18cd4a4047
Change-Id: Ib51238a0e09d4484a539a7f822864189872698b6
---
M include/osmo-bts/pcuif_proto.h
M src/common/pcu_sock.c
2 files changed, 50 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/48/34648/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib51238a0e09d4484a539a7f822864189872698b6
Gerrit-Change-Number: 34648
Gerrit-PatchSet: 6
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: osmith 
Gerrit-Attention: osmith 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

[M] Change in osmo-bts[master]: pcuif_proto: signal BTS model via PCUIF

[dexter]

Attention is currently required from: osmith, pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email )

Change subject: pcuif_proto: signal BTS model via PCUIF
..


Patch Set 6:

(1 comment)

File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/b5a321db_f4f35b4b
PS4, Line 239:  break;
> break after return is not needed
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib51238a0e09d4484a539a7f822864189872698b6
Gerrit-Change-Number: 34648
Gerrit-PatchSet: 6
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: osmith 
Gerrit-Attention: osmith 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 10:13:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith 
Gerrit-MessageType: comment

[S] Change in osmo-pcu[master]: pcu_l1_if: signal BTS model via PCUIF

[dexter]

Attention is currently required from: fixeria, laforge, pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email )

Change subject: pcu_l1_if: signal BTS model via PCUIF
..


Patch Set 5:

(1 comment)

File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/34647/comment/6d618392_05bc6a3d
PS4, Line 806:  { PCU_IF_BTS_MODEL_TRX, "osmo-trx" },
> I'd vote for osmo-bts-trx
I think that makes sense. I think we should rename the others too.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047
Gerrit-Change-Number: 34647
Gerrit-PatchSet: 5
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 23 Oct 2023 10:13:49 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support

[fixeria]

Attention is currently required from: jolly, laforge.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email )

Change subject: ASCI: Add System Information 10 support
..


Patch Set 7: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3
Gerrit-Change-Number: 34626
Gerrit-PatchSet: 7
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Mon, 23 Oct 2023 09:54:51 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: socket.c: Fix compilation with --disable-libsctp

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34855?usp=email )

Change subject: socket.c: Fix compilation with --disable-libsctp
..

socket.c: Fix compilation with --disable-libsctp

Fixes: 64ba9edf173cc16f9d94c94a423a8b7a5904efaf
Related: OS#6234
Change-Id: I988d01461822d18b7350a6e69e3b504f7fd5b84f
---
M src/core/socket.c
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Hoernchen: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/src/core/socket.c b/src/core/socket.c
index 2de3131..fa5fb88 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -1257,6 +1257,7 @@
return osmo_sock_init(ss->sa_family, type, proto, host, port, flags);
 }

+#ifdef HAVE_LIBSCTP
 /*! Add addresses to the multi-address (SCTP) socket active binding set
  *  \param[in] sfd The multi-address (SCTP) socket
  *  \param[in] addrs array of char pointers (strings), each containing local 
host name or IP address in string form
@@ -1408,6 +1409,7 @@
freeaddrinfo(res[i]);
return rc;
 }
+#endif /* HAVE_LIBSCTP */

 static int sockaddr_equal(const struct sockaddr *a,
  const struct sockaddr *b, unsigned int len)

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34855?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I988d01461822d18b7350a6e69e3b504f7fd5b84f
Gerrit-Change-Number: 34855
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmo-bsc[master]: pcuif_proto: clean up last remains of old PCUIF v10

[dexter]

Attention is currently required from: dexter, fixeria.

Hello Jenkins Builder, fixeria, osmith, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/34708?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: pcuif_proto: clean up last remains of old PCUIF v10
..

pcuif_proto: clean up last remains of old PCUIF v10

There are still some remains that are related to the old PCUIF v10
protocol version. Let's clean those up.

Related: OS#5927
Depends: osmo-pcu.git I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8
Change-Id: Iebb3a634fee680bdc3636a61f3ccaa1e97e54a64
---
M include/osmocom/bsc/pcuif_proto.h
M src/osmo-bsc/pcu_sock.c
2 files changed, 14 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/08/34708/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34708?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iebb3a634fee680bdc3636a61f3ccaa1e97e54a64
Gerrit-Change-Number: 34708
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-MessageType: newpatchset

[M] Change in osmo-pcu[master]: pcuif_proto: drop support for PCUIF v10

[dexter]

Attention is currently required from: fixeria, osmith, pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email )

Change subject: pcuif_proto: drop support for PCUIF v10
..


Patch Set 3:

(2 comments)

File include/osmocom/pcu/pcuif_proto.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/34706/comment/d7fef340_d6a631c3
PS1, Line 16: #define PCU_IF_MSG_DATA_CNF   0x01/* (deprecated) */
> What's the problem in having gaps? Those numbers are not used in the new 
> version of the protocol, so […]
I really se no problem with with having gaps. (I tend to say that we should 
leave it as it is now)


File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/34706/comment/d94997b0_dfbcf972
PS2, Line 744: if (info_ind->version == 0x0a) {
> I think you need to remove this too?
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8
Gerrit-Change-Number: 34706
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 23 Oct 2023 09:46:46 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Comment-In-Reply-To: dexter 
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: socket.c: Fix compilation with --disable-libsctp

[Hoernchen]

Attention is currently required from: pespin.

Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34855?usp=email )

Change subject: socket.c: Fix compilation with --disable-libsctp
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34855?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I988d01461822d18b7350a6e69e3b504f7fd5b84f
Gerrit-Change-Number: 34855
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 23 Oct 2023 09:41:56 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support

[pespin]

Attention is currently required from: fixeria, jolly, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email )

Change subject: ASCI: Add System Information 10 support
..


Patch Set 7: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3
Gerrit-Change-Number: 34626
Gerrit-PatchSet: 7
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 23 Oct 2023 09:33:48 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in osmo-pcu[master]: pcuif_proto: drop support for PCUIF v10

[dexter]

Attention is currently required from: fixeria, osmith, pespin.

Hello Jenkins Builder, fixeria, osmith, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed:
Code-Review+1 by osmith, Code-Review+1 by pespin, Code-Review-1 by fixeria, 
Verified+1 by Jenkins Builder


Change subject: pcuif_proto: drop support for PCUIF v10
..

pcuif_proto: drop support for PCUIF v10

We now use PCUIF v11 in the TTCN3 tests exclusively and also osmo-bts
and osmo-bsc only support PCUIF v11. There is no longer a need to
maintain a backward compatibility to PCUIF v10 in osmo-pcu.

Related: OS#5927
Change-Id: I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8
---
M include/osmocom/pcu/pcuif_proto.h
M src/bts.cpp
M src/gprs_rlcmac.c
M src/pcu_l1_if.cpp
M tests/app_info/AppInfoTest.err
5 files changed, 34 insertions(+), 123 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/06/34706/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8
Gerrit-Change-Number: 34706
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-MessageType: newpatchset

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support

[jolly]

Attention is currently required from: fixeria, laforge, pespin.

jolly has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email )

Change subject: ASCI: Add System Information 10 support
..


Patch Set 6:

(4 comments)

File src/osmo-bsc/system_information.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/743c260f_8c3fd8c2
PS6, Line 1420: int gsm_generate_si10(uint8_t *data, size_t len, const struct 
gsm_subscriber_connection *conn)
> "struct gsm48_system_information_type_10 *data" ?
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/348557ed_bc99cfa9
PS6, Line 1424: struct gsm_bts *s_bts = conn->lchan->ts->trx->bts;
> Can conn->lchan be null? […]
It can't, because in NULL case, gsm_generate_si10() is not called. This is 
checked right before calling gsm_generate_si10() in si10_update().


File src/osmo-bsc/vgcs_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/fee0e98d_1f0b1955
PS6, Line 70: #define SI10_TIMER3, 0
> AFAIU this is no longer used.
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/3c3afaf9_58b09456
PS6, Line 71: #define SI10_LENGTH   21
> this length should be in the same header where the API is used, and probably 
> be documented in the AP […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3
Gerrit-Change-Number: 34626
Gerrit-PatchSet: 6
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 23 Oct 2023 09:31:45 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support

[jolly]

Attention is currently required from: fixeria, jolly, laforge.

Hello Jenkins Builder, fixeria, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email

to look at the new patch set (#7).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder


Change subject: ASCI: Add System Information 10 support
..

ASCI: Add System Information 10 support

For each BTS, an SI 10 is generated with the informations about all
neighbor BTS that have the same group/broadcast call.

The SI 10 will only define neighbor cells within the same BSC, because
it does not know about neighbor cells within other BSCs.

When multiple channels are used for a group/broadcast call, the SI 10
is generated after all channels have been activated. Subsequent channel
activations result in an update of SI 10 on all channels.

Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3
---
M include/osmocom/bsc/system_information.h
M src/osmo-bsc/system_information.c
M src/osmo-bsc/vgcs_fsm.c
3 files changed, 331 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/26/34626/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3
Gerrit-Change-Number: 34626
Gerrit-PatchSet: 7
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-MessageType: newpatchset

[S] Change in pysim[master]: transport: move init message into concrete classes

[osmith]

Attention is currently required from: dexter, laforge.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34853?usp=email )

Change subject: transport: move init message into concrete classes
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34853?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0a6dd7deb79a5f3e42b29094a1cf2535075fa430
Gerrit-Change-Number: 34853
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Attention: laforge 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 23 Oct 2023 09:31:20 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in pysim[master]: transport: move argument parser setup into concrete classes

[osmith]

Attention is currently required from: dexter, laforge.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34854?usp=email )

Change subject: transport: move argument parser setup into concrete classes
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34854?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I22c32aa81ca0588e3314c3ff4546f6e5092c11df
Gerrit-Change-Number: 34854
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Attention: laforge 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 23 Oct 2023 09:31:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: socket.c: Fix compilation with --disable-libsctp

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34855?usp=email )


Change subject: socket.c: Fix compilation with --disable-libsctp
..

socket.c: Fix compilation with --disable-libsctp

Fixes: 64ba9edf173cc16f9d94c94a423a8b7a5904efaf
Related: OS#6234
Change-Id: I988d01461822d18b7350a6e69e3b504f7fd5b84f
---
M src/core/socket.c
1 file changed, 13 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/55/34855/1

diff --git a/src/core/socket.c b/src/core/socket.c
index 2de3131..fa5fb88 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -1257,6 +1257,7 @@
return osmo_sock_init(ss->sa_family, type, proto, host, port, flags);
 }

+#ifdef HAVE_LIBSCTP
 /*! Add addresses to the multi-address (SCTP) socket active binding set
  *  \param[in] sfd The multi-address (SCTP) socket
  *  \param[in] addrs array of char pointers (strings), each containing local 
host name or IP address in string form
@@ -1408,6 +1409,7 @@
freeaddrinfo(res[i]);
return rc;
 }
+#endif /* HAVE_LIBSCTP */

 static int sockaddr_equal(const struct sockaddr *a,
  const struct sockaddr *b, unsigned int len)

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34855?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I988d01461822d18b7350a6e69e3b504f7fd5b84f
Gerrit-Change-Number: 34855
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

[M] Change in osmo-ttcn3-hacks[master]: library: deduplicate f_logp

[osmith]

osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email )

Change subject: library: deduplicate f_logp
..

library: deduplicate f_logp

Change-Id: Ie84a8a75e9f162fcbef0d07d0bc75e47a5303fa3
---
M bsc/BSC_Tests.ttcn
M hnbgw/HNBGW_Tests.ttcn
M hnodeb/HNB_Tests.ttcn
M library/Osmocom_VTY_Functions.ttcn
M smlc/SMLC_Tests.ttcn
M upf/UPF_Tests.ttcn
6 files changed, 19 insertions(+), 42 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve




diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 426109a..57b44e0 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1129,16 +1129,6 @@
  "sccp-timer iar " & int2str(g_bsc_sccp_timer_iar)});
 }

-friend function f_logp(TELNETasp_PT pt, charstring log_msg)
-{
-   // log on TTCN3 log output
-   log(log_msg);
-   // log in stderr log
-   if (pt.checkstate("Mapped")) {
-   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & 
log_msg);
-   }
-}
-
 private function f_sysinfo_seen(integer rsl_idx, RSL_Message rsl) runs on 
test_CT
 {
if (rsl_idx >= lengthof(g_system_information)) {
diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index c3849b8..4afb8dd 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -349,14 +349,6 @@
}
 }

-friend function f_logp(TELNETasp_PT pt, charstring log_msg)
-{
-   // log on TTCN3 log output
-   log(log_msg);
-   // log in stderr log
-   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg);
-}
-
 function f_init_vty(charstring id := "foo") runs on test_CT {
if (HNBGWVTY.checkstate("Mapped")) {
/* skip initialization if already executed once */
diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn
index 6d1ddc5..df7a04c 100644
--- a/hnodeb/HNB_Tests.ttcn
+++ b/hnodeb/HNB_Tests.ttcn
@@ -95,14 +95,6 @@
}
 }

-friend function f_logp(TELNETasp_PT pt, charstring log_msg)
-{
-   // log on TTCN3 log output
-   log(log_msg);
-   // log in stderr log
-   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg);
-}
-
 function f_init_vty(charstring id := "foo") runs on test_CT {
if (HNBVTY.checkstate("Mapped")) {
/* skip initialization if already executed once */
diff --git a/library/Osmocom_VTY_Functions.ttcn 
b/library/Osmocom_VTY_Functions.ttcn
index a448b8b..3dd0429 100644
--- a/library/Osmocom_VTY_Functions.ttcn
+++ b/library/Osmocom_VTY_Functions.ttcn
@@ -363,4 +363,14 @@
mtc.stop;
 }

+public function f_logp(TELNETasp_PT pt, charstring log_msg)
+{
+   // log on TTCN3 log output
+   log(log_msg);
+   // log in stderr log
+   if (pt.checkstate("Mapped")) {
+   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & 
log_msg);
+   }
+}
+
 }
diff --git a/smlc/SMLC_Tests.ttcn b/smlc/SMLC_Tests.ttcn
index 5324d1c..2a50666 100644
--- a/smlc/SMLC_Tests.ttcn
+++ b/smlc/SMLC_Tests.ttcn
@@ -156,14 +156,6 @@
}
 }

-private function f_logp(TELNETasp_PT pt, charstring log_msg)
-{
-   // log on TTCN3 log output
-   log(log_msg);
-   // log in stderr log
-   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg);
-}
-
 /* global initialization function
  * \param nr_bts Number of BTSs we should start/bring up
  * \param handler_mode Start an RSL_Emulation_CT component (true) or not 
(false).
diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn
index 7dc01bb..140e81b 100644
--- a/upf/UPF_Tests.ttcn
+++ b/upf/UPF_Tests.ttcn
@@ -68,14 +68,6 @@
}
 }

-friend function f_logp(TELNETasp_PT pt, charstring log_msg)
-{
-   // log on TTCN3 log output
-   log(log_msg);
-   // log in stderr log
-   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg);
-}
-
 private function f_get_name_val(out charstring val, charstring str, charstring 
name, charstring sep := ":", charstring delim := " ") return boolean {
var charstring labl := name & sep;
var integer namepos := f_strstr(str, labl);

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie84a8a75e9f162fcbef0d07d0bc75e47a5303fa3
Gerrit-Change-Number: 34838
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-MessageType: merged

[S] Change in pysim[master]: transport: print reader device/number on init

[dexter]

Attention is currently required from: laforge.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34686?usp=email )

Change subject: transport: print reader device/number on init
..


Patch Set 10:

(1 comment)

Patchset:

PS10:
> the problem here is that this makes sense for the normal user, but doens't 
> make sense in our test se […]
I wonder if we could have a command line option like --verbose. There is 
probably also use for it in other places. When --verbose is enabled. 
pySim-shell could also start with debug=true

I have now moved the messages into the concrete classes: 
https://gerrit.osmocom.org/c/pysim/+/34853 (I will re-add the verbosity later)



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34686?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5c08995fcd55bd9bb173adc2acd9722e438a164b
Gerrit-Change-Number: 34686
Gerrit-PatchSet: 10
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-CC: fixeria 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Mon, 23 Oct 2023 09:15:25 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment