[L] Change in osmo-ttcn3-hacks[master]: asterisk: Implement support to handle 2nd REGISTER through ipsec

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36856?usp=email )

Change subject: asterisk: Implement support to handle 2nd REGISTER through ipsec
..


Patch Set 1:

(1 comment)

File asterisk/regen_makefile.sh:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16174):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36856/comment/7d1b72d0_de998c1c
PS1, Line 26: sed -i -e '/^LINUX_LIBS/ s/$/ -lutil/' Makefile
adding a line without newline at end of file



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36856?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic042422788ee406f5b71ca3878bc5617e5455579
Gerrit-Change-Number: 36856
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 16 May 2024 19:02:17 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: docs: add acknowledgement to nlnet for fording this project

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36847?usp=email )

Change subject: docs: add acknowledgement to nlnet for fording this project
..


Patch Set 1:

(1 comment)

File docs/manuals/chapters/acknowledgement.adoc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16160):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36847/comment/e5c21ff5_dc408203
PS1, Line 3:
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36847?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ic822a25bc680acf978e5f45be13e7a9f4d70f229
Gerrit-Change-Number: 36847
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 16 May 2024 13:42:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in pysim[master]: pySim/cat: Fix contruct for Address class/IE

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/36839?usp=email )

Change subject: pySim/cat: Fix contruct for Address class/IE
..


Patch Set 1:

(1 comment)

File smpp_ota_apdu2.py:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16143):
https://gerrit.osmocom.org/c/pysim/+/36839/comment/24981309_89352c25
PS1, Line 97:
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36839?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idf8326298cab7ebc68b09c7e829bfc2061222f51
Gerrit-Change-Number: 36839
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 16 May 2024 06:34:07 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: docs: add basic manual of the osmo-epdg

[Jenkins Builder]

Attention is currently required from: pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email )

Change subject: docs: add basic manual of the osmo-epdg
..


Patch Set 4:

(1 comment)

File docs/manuals/chapters/strongswan.adoc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16102):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/896b4bd7_9485f28e
PS4, Line 24: In the default configuration of osmo-epdg, strongSwan will use 
Linux kernel to handle ESP to
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I596b6a351b7356aefa7e69f95521bc4012b9264b
Gerrit-Change-Number: 36783
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel 
Gerrit-CC: pespin 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 14 May 2024 15:20:11 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: docs: add basic manual of the osmo-epdg

[Jenkins Builder]

Attention is currently required from: lynxis lazus.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email )

Change subject: docs: add basic manual of the osmo-epdg
..


Patch Set 3:

(1 comment)

File docs/manuals/chapters/strongswan.adoc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16101):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/5865aad6_a960cae8
PS3, Line 24: In the default configuration of osmo-epdg, strongSwan will use 
Linux kernel to handle ESP to
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I596b6a351b7356aefa7e69f95521bc4012b9264b
Gerrit-Change-Number: 36783
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel 
Gerrit-CC: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Tue, 14 May 2024 14:44:42 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: Omit octet 3a in mobile-terminating setup requests if speech version ...

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email )

Change subject: Omit octet 3a in mobile-terminating setup requests if speech 
version is GSM-FR only
..


Patch Set 1:

(1 comment)

File src/gsm/gsm48_ie.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16054):
https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/af277dc6_87732f13
PS1, Line 331:  if(bcap->speech_ver[1] >= 0 || (bcap->speech_ver[0] & 
0x0f) != 0x00) {
space required before the open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b
Gerrit-Change-Number: 36784
Gerrit-PatchSet: 1
Gerrit-Owner: nt2mku 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sun, 12 May 2024 19:36:24 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: docs: add basic manual of the osmo-epdg

[Jenkins Builder]

Attention is currently required from: lynxis lazus.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email )

Change subject: docs: add basic manual of the osmo-epdg
..


Patch Set 2:

(13 comments)

File docs/manuals/chapters/osmo-epdg.adoc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/2d324c9d_8138e4ff
PS2, Line 48: key,default,description
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/c1f9da01_9340149d
PS2, Line 69: key,default,description
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/d6207441_45cc36cc
PS2, Line 88: key,default,description
trailing whitespace


File docs/manuals/ue-connects.msc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/80f20227_351549a8
PS2, Line 8:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/2f79d31d_3ae91e8f
PS2, Line 14:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/e51d77f4_f2050a1c
PS2, Line 20:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/7cd1ec41_60d758ac
PS2, Line 22:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/c147b8cf_a7a89ffb
PS2, Line 25:
trailing whitespace


File docs/manuals/ue-connects2.msc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/1429b417_873ac754
PS2, Line 7:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/683162e5_baae663a
PS2, Line 13:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/9948f5f7_6619249a
PS2, Line 17:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/c2acf9ad_1cae12b6
PS2, Line 20: 
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16053):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/044c7a51_7900c475
PS2, Line 26:
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I596b6a351b7356aefa7e69f95521bc4012b9264b
Gerrit-Change-Number: 36783
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel 
Gerrit-CC: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Sat, 11 May 2024 18:25:09 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: docs: add basic manual of the osmo-epdg

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email )

Change subject: docs: add basic manual of the osmo-epdg
..


Patch Set 1:

(13 comments)

File docs/manuals/chapters/osmo-epdg.adoc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/fcf4d292_a5ed4faf
PS1, Line 48: key,default,description
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/e4411747_d83e9029
PS1, Line 69: key,default,description
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/dc8c8f23_7d9897f3
PS1, Line 88: key,default,description
trailing whitespace


File docs/manuals/ue-connects.msc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/8ff69cc0_f4b06ef3
PS1, Line 8:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/97b7bd63_4d55069d
PS1, Line 14:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/1a2bf5d8_b514cd32
PS1, Line 20:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/ef87a115_25d2474c
PS1, Line 22:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/352d40e9_14a90b8a
PS1, Line 25:
trailing whitespace


File docs/manuals/ue-connects2.msc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/93c071cb_c62296d1
PS1, Line 7:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/9ebf41f0_94786f77 
PS1, Line 13:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/4a74bdab_22269efe
PS1, Line 17:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/61e2763e_9649f3c1
PS1, Line 20:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16052):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/70b9e32c_6bab37be
PS1, Line 26:
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I596b6a351b7356aefa7e69f95521bc4012b9264b
Gerrit-Change-Number: 36783
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sat, 11 May 2024 17:29:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-ttcn3-hacks[master]: HTTP_Adaptor: allow keeping an HTTP client connection

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36646?usp=email )

Change subject: HTTP_Adaptor: allow keeping an HTTP client connection
..


Patch Set 1:

(1 comment)

File library/HTTP_Adapter.ttcn:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15829):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36646/comment/5c877b87_dbb53125
PS1, Line 188:  /* In case the caller didn't specifiy a client_id, we will 
create a new connection. */
'specifiy' may be misspelled - perhaps 'specify'?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36646?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic6994c504143820dde498c1a2bad2ad6a523dd70
Gerrit-Change-Number: 36646
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 25 Apr 2024 16:05:58 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd

[Jenkins Builder]

Attention is currently required from: dexter.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email )

Change subject: IPAd_Tests: add testsuite for an IPAd
..


Patch Set 6:

(13 comments)

File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c4d5dc85_6c182049
PS6, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a275a220_d72a48b9
PS6, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/8a831858_332e05dd
PS6, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9ef18c1c_6756d903
PS6, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/3c08f20c_36885163
PS6, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bb1033d0_5d965f7b
PS6, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/pki/issued/alttest.crt:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9353f380_895823f7
PS6, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c337e41d_247096ca
PS6, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/27532674_f568db7a
PS6, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/fe629262_354221c4
PS6, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/19826810_778efda4
PS6, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/edb942d3_408a61fb
PS6, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/vars:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/264e6d6f_f935b4f2
PS6, Line 30: #
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d
Gerrit-Change-Number: 36229
Gerrit-PatchSet: 6
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Tue, 23 Apr 2024 10:19:40 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-ttcn3-hacks[master]: ipad: add an extra certificate+bundle for host "testsuite"

[Jenkins Builder]

Attention is currently required from: dexter.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email )

Change subject: ipad: add an extra certificate+bundle for host "testsuite"
..


Patch Set 3:

(12 comments)

File ipad/example_ca/pki/certs_by_serial/1D1B580C1B235125A87BE06C70121913.pem:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/9d332259_ec8175ba
PS3, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/9208d852_24e56b4c
PS3, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/9907abf0_5f53c20c
PS3, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/72b015f5_a6f7f542
PS3, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/62041970_fd5c822c
PS3, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/1de452cf_4a858aef
PS3, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/pki/issued/testsuite.crt:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/848c428e_fa9727e7
PS3, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/c0482b2b_63ccc54b
PS3, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/476d2c94_a030dd84
PS3, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/298ab1dc_57c435b2
PS3, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/e1dd91f7_a8cf369b
PS3, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15765):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/3885f348_4ac5e119
PS3, Line 49: X509v3 Subject Alternative Name:
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2d4ba8b710b9cf518b90c7f7acc8982350705531
Gerrit-Change-Number: 36621
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Tue, 23 Apr 2024 10:19:02 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd

[Jenkins Builder]

Attention is currently required from: dexter, fixeria.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email )

Change subject: IPAd_Tests: add testsuite for an IPAd
..


Patch Set 5:

(13 comments)

File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/5a161917_a58bb9d5
PS5, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9025cf30_b1249639
PS5, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/75cc4002_38733a7b
PS5, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/24e0a23a_b199fa47
PS5, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/26cc0cb4_a63970e1
PS5, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9044f961_d610206d
PS5, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/pki/issued/alttest.crt:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/7dfaf612_3391979f
PS5, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/2e3fee0b_ce09d594
PS5, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/aae267dd_75eaed38
PS5, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a672ad5e_d9af6bb8
PS5, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/f3b87cae_8d35d19e
PS5, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/44fb7ab7_ba30aa5b
PS5, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/vars:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/343257f2_ab7ed785
PS5, Line 30: #
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d
Gerrit-Change-Number: 36229
Gerrit-PatchSet: 5
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria 
Gerrit-CC: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:49:48 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-ttcn3-hacks[master]: ipad: add an extra certificate+bundle for host "testsuite"

[Jenkins Builder]

Attention is currently required from: dexter.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email )

Change subject: ipad: add an extra certificate+bundle for host "testsuite"
..


Patch Set 2:

(12 comments)

File ipad/example_ca/pki/certs_by_serial/1D1B580C1B235125A87BE06C70121913.pem:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/82a43e78_badafbcd
PS2, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/78fe499a_f1ae02fd
PS2, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/30dd9d90_779f6a56
PS2, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/d8a1ecf5_46651129
PS2, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/f999520c_fbe73190
PS2, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/180f1117_52903eb7
PS2, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/pki/issued/testsuite.crt:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/4dcfbb61_922a0173
PS2, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/3b2592ca_840bef84
PS2, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/f27cc486_84f0ef37
PS2, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/c05fccf5_35169050
PS2, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/ba71fe30_fc1b49e4
PS2, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15757):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/39b51160_ad3243a2
PS2, Line 49: X509v3 Subject Alternative Name:
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2d4ba8b710b9cf518b90c7f7acc8982350705531
Gerrit-Change-Number: 36621
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:49:39 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd

[Jenkins Builder]

Attention is currently required from: dexter, fixeria.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email )

Change subject: IPAd_Tests: add testsuite for an IPAd
..


Patch Set 4:

(13 comments)

File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a1d62da6_d35b4741
PS4, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/4f8fb4b1_c4ac3746
PS4, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/4c59fe19_6f75bc1a
PS4, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/e4207886_caa80bfd
PS4, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9d02d153_0c5273ff
PS4, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/d0a83ad2_2ee2f6cd
PS4, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/pki/issued/alttest.crt:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a27780f8_06c7fafd
PS4, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/cb75132f_57d051b5
PS4, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/e1b3411b_6aa3ee1d
PS4, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/dfb8e8cc_35b98e36
PS4, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/41fa99c8_03890521
PS4, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/5659d7a2_a7efea2e
PS4, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/vars:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/ccdbee97_166b7e3a
PS4, Line 30: #
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d
Gerrit-Change-Number: 36229
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria 
Gerrit-CC: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:46:14 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-ttcn3-hacks[master]: ipad: add an extra certificate+bundle for host "testsuite"

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email )

Change subject: ipad: add an extra certificate+bundle for host "testsuite"
..


Patch Set 1:

(12 comments)

File ipad/example_ca/pki/certs_by_serial/1D1B580C1B235125A87BE06C70121913.pem:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/65afb5ac_64be4f11
PS1, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/2cbcb8dd_2ee74ee2
PS1, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/2d172c36_30af8b28
PS1, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/b5a7618f_1821d6c5
PS1, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/d70a1323_623b5811
PS1, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/9c52b731_795dd96d
PS1, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/pki/issued/testsuite.crt:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/5ef8fce9_b6e6cfe3
PS1, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/12176ab5_596e98aa
PS1, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/592d290a_d7879a1c
PS1, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/12092587_5c1289a2
PS1, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/0cba66c0_2039b756
PS1, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15749):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621/comment/f206cb65_6ecbb19f
PS1, Line 49: X509v3 Subject Alternative Name:
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36621?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2d4ba8b710b9cf518b90c7f7acc8982350705531
Gerrit-Change-Number: 36621
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:46:00 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd

[Jenkins Builder]

Attention is currently required from: dexter, fixeria, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email )

Change subject: IPAd_Tests: add testsuite for an IPAd
..


Patch Set 3:

(13 comments)

File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/f46796ca_8b6a8d1a
PS3, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bcfd9ef2_60a0e3e2
PS3, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/410f5f26_c1ed6163
PS3, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/7e0621e1_f6312244
PS3, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bc53f7b7_c376abec
PS3, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/ec9aabe9_d84e4cd8
PS3, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/pki/issued/alttest.crt:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/78c41c43_a2cf1997
PS3, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/45165c80_b77f38ed
PS3, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/0024ee70_b84ac930
PS3, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/e6ec6b7d_d1c727b5
PS3, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/37ac2261_2bb8b4c0
PS3, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/de9e96c7_30a219f0
PS3, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/vars:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/28191ddc_37fe8440
PS3, Line 30: #
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d
Gerrit-Change-Number: 36229
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria 
Gerrit-CC: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Fri, 19 Apr 2024 11:56:22 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-hnbgw[master]: use json to decode counters from nftables

[Jenkins Builder]

Attention is currently required from: neels.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485?usp=email )

Change subject: use json to decode counters from nftables
..


Patch Set 5:

(2 comments)

File src/osmo-hnbgw/nft_kpi.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15524):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485/comment/1cbefed0_686fda1e
PS5, Line 266:  json_array_foreach (nftables, i, item) {
space prohibited between function name and open parenthesis '('


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15524):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485/comment/c433aa74_85485d32
PS5, Line 294:  json_array_foreach (expr, j, expr_item) {
space prohibited between function name and open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id4e7fa017c31945388a010d8581715d71482116b
Gerrit-Change-Number: 36485
Gerrit-PatchSet: 5
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-CC: osmith 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Wed, 03 Apr 2024 00:53:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd

[Jenkins Builder]

Attention is currently required from: fixeria, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email )

Change subject: IPAd_Tests: add testsuite for an IPAd
..


Patch Set 2:

(13 comments)

File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/3c2b16e3_87433f68
PS2, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/db33ca48_1211c8d9
PS2, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/f9b9c8e9_8432387a
PS2, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/1316252e_4e71078f
PS2, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c388ae46_201855b1
PS2, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a912d025_4a9bf22c
PS2, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/pki/issued/alttest.crt:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/fb1c5389_b62ff3a8
PS2, Line 36: X509v3 Basic Constraints:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/ce983c85_69a19cd5
PS2, Line 38: X509v3 Subject Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/f2e9c9cc_3e5508d7
PS2, Line 40: X509v3 Authority Key Identifier:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/88b3d449_8b787c58
PS2, Line 45: X509v3 Extended Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/579ed89c_ea7b59d0
PS2, Line 47: X509v3 Key Usage:
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/4e767527_7c73be92
PS2, Line 49: X509v3 Subject Alternative Name:
trailing whitespace


File ipad/example_ca/vars:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/d6e62e11_9e47a4a6
PS2, Line 30: #
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d
Gerrit-Change-Number: 36229
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria 
Gerrit-CC: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 02 Apr 2024 15:07:04 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-ttcn3-hacks[master]: Introduce Asterisk_Tests testsuite

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36490?usp=email )

Change subject: Introduce Asterisk_Tests testsuite
..


Patch Set 1:

(1 comment)

File library/SIP_Templates.ttcn:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15493):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36490/comment/9a182294_fe18ac56
PS1, Line 528: /* Expect during first REGISTER when authorization is requried: 
*/
'requried' may be misspelled - perhaps 'required'?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36490?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I66f776d5df6fb5dc488d9e589b84a6b2385406e8
Gerrit-Change-Number: 36490
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 28 Mar 2024 20:21:20 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-hnbgw[master]: use json to decode counters from nftables

[Jenkins Builder]

Attention is currently required from: neels.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485?usp=email )

Change subject: use json to decode counters from nftables
..


Patch Set 4:

(2 comments)

File src/osmo-hnbgw/nft_kpi.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15489):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485/comment/440cb2eb_4da76159
PS4, Line 266:  json_array_foreach (nftables, i, item) {
space prohibited between function name and open parenthesis '('


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15489):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485/comment/46adcedb_e8c91e24
PS4, Line 294:  json_array_foreach (expr, j, expr_item) {
space prohibited between function name and open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id4e7fa017c31945388a010d8581715d71482116b
Gerrit-Change-Number: 36485
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 28 Mar 2024 15:21:25 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-hnbgw[master]: use json to decode counters from nftables

[Jenkins Builder]

Attention is currently required from: neels.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485?usp=email )

Change subject: use json to decode counters from nftables
..


Patch Set 3:

(2 comments)

File src/osmo-hnbgw/nft_kpi.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15486):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485/comment/9b8a4186_13126240
PS3, Line 266:  json_array_foreach (nftables, i, item) {
space prohibited between function name and open parenthesis '('


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15486):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485/comment/ce27fe6c_95a4e951
PS3, Line 294:  json_array_foreach (expr, j, expr_item) {
space prohibited between function name and open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id4e7fa017c31945388a010d8581715d71482116b
Gerrit-Change-Number: 36485
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 28 Mar 2024 15:00:50 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-hnbgw[master]: use json to decode counters from nftables

[Jenkins Builder]

Attention is currently required from: neels.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485?usp=email )

Change subject: use json to decode counters from nftables
..


Patch Set 2:

(2 comments)

File src/osmo-hnbgw/nft_kpi.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15477):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485/comment/c6d17c27_557d122d
PS2, Line 266:  json_array_foreach (nftables, i, item) {
space prohibited between function name and open parenthesis '('


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15477):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485/comment/ef649c34_b6c04499
PS2, Line 294:  json_array_foreach (expr, j, expr_item) {
space prohibited between function name and open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id4e7fa017c31945388a010d8581715d71482116b
Gerrit-Change-Number: 36485
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 28 Mar 2024 02:47:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-hnbgw[master]: use json to decode counters from nftables

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485?usp=email )

Change subject: use json to decode counters from nftables
..


Patch Set 1:

(2 comments)

File src/osmo-hnbgw/nft_kpi.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15475):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485/comment/a499530c_d95520ab
PS1, Line 266:  json_array_foreach (nftables, i, item) {
space prohibited between function name and open parenthesis '('


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15475):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485/comment/9f3d3d71_2c6def1a
PS1, Line 294:  json_array_foreach (expr, j, expr_item) {
space prohibited between function name and open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36485?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id4e7fa017c31945388a010d8581715d71482116b
Gerrit-Change-Number: 36485
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 27 Mar 2024 21:57:25 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmo-hnbgw[master]: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej()

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email )

Change subject: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej()
..


Patch Set 2:

(2 comments)

File src/osmo-hnbgw/hnbgw_hnbap.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15469):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481/comment/8c93ee17_7cd64d0d
PS2, Line 279:  (const char 
*)ue_id->choice.iMSI.buf,
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15469):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481/comment/02102c28_9757617a
PS2, Line 279:  (const char 
*)ue_id->choice.iMSI.buf,
please, no spaces at the start of a line



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I2e00968cbf686f78f5c9655e899963f2b84dd78b
Gerrit-Change-Number: 36481
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 27 Mar 2024 20:49:52 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmo-hnbgw[master]: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej()

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email )

Change subject: HNBAP: Support IMSI identity type in hnbgw_tx_ue_register_rej()
..


Patch Set 1:

(2 comments)

File src/osmo-hnbgw/hnbgw_hnbap.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15467):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481/comment/bb3602e0_8403a509
PS1, Line 277:  (const char 
*)ue_id->choice.iMSI.buf,
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15467):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481/comment/61055a53_2ce82423
PS1, Line 277:  (const char 
*)ue_id->choice.iMSI.buf,
please, no spaces at the start of a line



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36481?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I2e00968cbf686f78f5c9655e899963f2b84dd78b
Gerrit-Change-Number: 36481
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 27 Mar 2024 20:47:47 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-trx[master]: ms: add config file

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/36373?usp=email )

Change subject: ms: add config file
..


Patch Set 1:

(1 comment)

File Transceiver52M/ms/mssdr_vty.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15283):
https://gerrit.osmocom.org/c/osmo-trx/+/36373/comment/c96a0196_5f378439
PS1, Line 264: }
adding a line without newline at end of file



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36373?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ibd432f7abbd00065a59104d2c006b676d5db7b47
Gerrit-Change-Number: 36373
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Mar 2024 18:48:29 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-mgw[master]: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io

[Jenkins Builder]

Attention is currently required from: dexter, neels, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email )

Change subject: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io
..


Patch Set 2:

(2 comments)

File src/libosmo-mgcp/mgcp_network.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15268):
https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/f7c56fe8_9c236406
PS2, Line 1051: LOGP(DRTP, LOGL_DEBUG, "sending %i bytes length packet 
to %s ...\n", msgb_length(msg),
Use %d instead of %i


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15268):
https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/b868110d_ab313800
PS2, Line 1492: proto = (iofd == conn_src->end.rtp)? MGCP_PROTO_RTP : 
MGCP_PROTO_RTCP;
spaces required around that '?' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I8471960d5d8088a70cf105f2f40dfa5d5458169a
Gerrit-Change-Number: 36363
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Wed, 20 Mar 2024 11:44:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-mgw[master]: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email )

Change subject: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io
..


Patch Set 1:

(2 comments)

File src/libosmo-mgcp/mgcp_network.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15252):
https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/1d6b142a_74778328
PS1, Line 1051: LOGP(DRTP, LOGL_DEBUG, "sending %i bytes length packet 
to %s ...\n", msgb_length(msg),
Use %d instead of %i


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15252):
https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/9c7a5c75_fc5863d1
PS1, Line 1492: proto = (iofd == conn_src->end.rtp)? MGCP_PROTO_RTP : 
MGCP_PROTO_RTCP;
spaces required around that '?' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I8471960d5d8088a70cf105f2f40dfa5d5458169a
Gerrit-Change-Number: 36363
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 19 Mar 2024 20:23:07 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-mgw[master]: Change msgb ownership in processing of received msgb

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email )

Change subject: Change msgb ownership in processing of received msgb
..


Patch Set 1:

(1 comment)

File src/libosmo-mgcp/mgcp_network.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15248):
https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/892eaba7_ce3f0f8c
PS1, Line 1285: else
else is not generally useful after a break or return



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6a331f3c6b2eb51ea312ac6ef8c357185ddb79cf
Gerrit-Change-Number: 36361
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 19 Mar 2024 18:03:00 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmo-netif[master]: docs: various osmux API documentation updates

[Jenkins Builder]

Attention is currently required from: fixeria, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email )

Change subject: docs: various osmux API documentation updates
..


Patch Set 4:

(2 comments)

File src/osmux.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15240):
https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/0f7310e1_31e75eb2
PS4, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \
Macros starting with if should be enclosed by a do - while loop to avoid 
possible if/else logic defects


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15240):
https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/52357ae3_7bbb3e8a
PS4, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \
macros should not use a trailing semicolon



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I5af0133322ddd5345a13380f1c007474c0bea117
Gerrit-Change-Number: 36299
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Tue, 19 Mar 2024 13:21:21 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmo-pfcp[master]: add osmo_pfcp_ip_addrs_get

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email )

Change subject: add osmo_pfcp_ip_addrs_get
..


Patch Set 1:

(2 comments)

File src/libosmo-pfcp/pfcp_msg.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15227):
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348/comment/16ff848d_a378cb8f
PS1, Line 539:  else
else is not generally useful after a break or return


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15227):
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348/comment/1b09a9b1_c02216d7
PS1, Line 545:  else
else is not generally useful after a break or return



--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I4338a83f26ef2443f90cf835621e73aed5eac521
Gerrit-Change-Number: 36348
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 19 Mar 2024 03:47:32 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bts[master]: common: Add RTP related rate counters

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/36323?usp=email )

Change subject: common: Add RTP related rate counters
..


Patch Set 1:

(3 comments)

File src/common/bts.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15184):
https://gerrit.osmocom.org/c/osmo-bts/+/36323/comment/b0858e4e_d83f68e2
PS1, Line 111:  [BTS_CTR_RTP_RX_DROP_LOOPBACK] ={"rtp:rx:drop:loopback", "Total 
number of received RTP packets dropped during loopback"},
spaces required around that '=' (ctx:WxV)


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15184):
https://gerrit.osmocom.org/c/osmo-bts/+/36323/comment/4680428b_0d443bb0
PS1, Line 112:  [BTS_CTR_RTP_RX_DROP_OVERFLOW] ={"rtp:rx:drop:overflow", "Total 
number of received RTP packets dropped during DL queue overflow"},
spaces required around that '=' (ctx:WxV)


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15184):
https://gerrit.osmocom.org/c/osmo-bts/+/36323/comment/ddc79c66_e83dec45
PS1, Line 113:  [BTS_CTR_RTP_RX_DROP_V110_DEC] ={"rtp:rx:drop:v110_dec", "Total 
number of received RTP packets dropped during V.110 decode"},
spaces required around that '=' (ctx:WxV)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36323?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ide674bde10b0e4b501d6a48947b983090342dfec
Gerrit-Change-Number: 36323
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sun, 17 Mar 2024 08:44:39 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bts[master]: osmo-bts-virtual: Port over to osmo_io

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email )

Change subject: osmo-bts-virtual: Port over to osmo_io
..


Patch Set 1:

(1 comment)

File src/osmo-bts-virtual/osmo_mcast_sock.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15182):
https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/acf4374a_e8b4bd72
PS1, Line 30: mcast_server_sock_setup(void *ctx, const char* tx_mcast_group, 
uint16_t tx_mcast_port, bool loopback)
"foo* bar" should be "foo *bar"



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icfe42da00fd446c38090055e2baa5d5e0ae5b70c
Gerrit-Change-Number: 36317
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sat, 16 Mar 2024 18:07:52 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmo-upf[master]: manual: 'Running': tweak, mention 'tunmap' and 'tunend'

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email )

Change subject: manual: 'Running': tweak, mention 'tunmap' and 'tunend'
..


Patch Set 2:

(1 comment)

File doc/manuals/chapters/running.adoc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15168):
https://gerrit.osmocom.org/c/osmo-upf/+/35666/comment/a197aeb0_786a5dfb
PS2, Line 91: * The netfilter framework and nftables is used for `tunmap`: GTP 
tunnel proxying,
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27
Gerrit-Change-Number: 35666
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 15 Mar 2024 20:18:59 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-hnbgw[master]: RAB activation/modification/release statistics

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311?usp=email )

Change subject: RAB activation/modification/release statistics
..


Patch Set 1:

(3 comments)

File src/osmo-hnbgw/kpi_ranap.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15162):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311/comment/955a0106_36a27be7
PS1, Line 123:  if (release_list_ie-> id != 
RANAP_ProtocolIE_ID_id_RAB_ReleaseItem)
spaces prohibited around that '->' (ctx:VxW)


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15162):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311/comment/2e41c302_778b3058
PS1, Line 276:  if (failed_list_ie-> id != 
RANAP_ProtocolIE_ID_id_RAB_FailedItem)
spaces prohibited around that '->' (ctx:VxW)


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15162):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311/comment/a2127a10_803cc54d
PS1, Line 322:  if (failed_list_ie-> id != 
RANAP_ProtocolIE_ID_id_RAB_FailedItem)
spaces prohibited around that '->' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I198fa37699e22380909764de6a0522ac79aa1d39
Gerrit-Change-Number: 36311
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 15 Mar 2024 19:32:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in ...osmo-epdg[master]: Propagate SWx PPR as SWm Authorization Update towards ePDG

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36305?usp=email )

Change subject: Propagate SWx PPR as SWm Authorization Update towards ePDG
..


Patch Set 1:

(1 comment)

File src/aaa_ue_fsm.erl:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15152):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36305/comment/e7dc5a41_e658fd5b
PS1, Line 346: %% SWx PPA was already answered immediatelly when PPR 
was received, nothing to do here.
'immediatelly' may be misspelled - perhaps 'immediately'?



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36305?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I4fe309ac54c61f134dbd471486c7d1a70731c9bb
Gerrit-Change-Number: 36305
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 15 Mar 2024 15:28:08 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmo-netif[master]: docs: various osmux API documentation updates

[Jenkins Builder]

Attention is currently required from: laforge.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email )

Change subject: docs: various osmux API documentation updates
..


Patch Set 3:

(2 comments)

File src/osmux.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15142):
https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/09483d54_0c908c82
PS3, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \
Macros starting with if should be enclosed by a do - while loop to avoid 
possible if/else logic defects


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15142):
https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/36385511_226b8868
PS3, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \
macros should not use a trailing semicolon



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I5af0133322ddd5345a13380f1c007474c0bea117
Gerrit-Change-Number: 36299
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Fri, 15 Mar 2024 13:17:15 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmo-netif[master]: doc: various osmux API documentation updates

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email )

Change subject: doc: various osmux API documentation updates
..


Patch Set 1:

(2 comments)

File src/osmux.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15133):
https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/0e4f2b3e_ec96c2d6
PS1, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \
Macros starting with if should be enclosed by a do - while loop to avoid 
possible if/else logic defects


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15133):
https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/356daf0a_afa94cb1
PS1, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \
macros should not use a trailing semicolon



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I5af0133322ddd5345a13380f1c007474c0bea117
Gerrit-Change-Number: 36299
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 15 Mar 2024 13:08:04 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmo-netif[master]: docs: Use \defgroup and avoid repeated boilerplate text

[Jenkins Builder]

Attention is currently required from: laforge.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/36291?usp=email )

Change subject: docs: Use \defgroup and avoid repeated boilerplate text
..


Patch Set 2:

(1 comment)

File src/stream.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15129):
https://gerrit.osmocom.org/c/libosmo-netif/+/36291/comment/5c27ef7c_103e39e1
PS2, Line 55: /*! \addtogroup stream
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36291?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I1196c3b035f495c5dbaa4d47ce3f79a08d0727f2
Gerrit-Change-Number: 36291
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Fri, 15 Mar 2024 09:04:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmo-netif[master]: docs: Use \defgroup and avoid repeated boilerplate text

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/36291?usp=email )

Change subject: docs: Use \defgroup and avoid repeated boilerplate text
..


Patch Set 1:

(1 comment)

File src/stream.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15121):
https://gerrit.osmocom.org/c/libosmo-netif/+/36291/comment/fb14ee1a_f948eb48
PS1, Line 55: /*! \addtogroup stream
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36291?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I1196c3b035f495c5dbaa4d47ce3f79a08d0727f2
Gerrit-Change-Number: 36291
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 14 Mar 2024 21:50:24 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmo-abis[rel-1.4.2]: input/ipaccess: Make sure to say "TCP keepalive"

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/36277?usp=email )

Change subject: input/ipaccess: Make sure to say "TCP keepalive"
..


Patch Set 1:

(4 comments)

File src/input/ipaccess.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15104):
https://gerrit.osmocom.org/c/libosmo-abis/+/36277/comment/9c068a5a_74423f2f
PS1, Line 650: if (ret < 0) {
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15104):
https://gerrit.osmocom.org/c/libosmo-abis/+/36277/comment/cbd9e4b6_ccbcb37f
PS1, Line 650: if (ret < 0) {
please, no spaces at the start of a line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15104):
https://gerrit.osmocom.org/c/libosmo-abis/+/36277/comment/18633243_14cdac52
PS1, Line 652:  "Failed to set TCP user timoeut: 
%s\n",
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15104):
https://gerrit.osmocom.org/c/libosmo-abis/+/36277/comment/8ce2f52b_c29a6a15
PS1, Line 652:  "Failed to set TCP user timoeut: 
%s\n",
please, no spaces at the start of a line



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36277?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: rel-1.4.2
Gerrit-Change-Id: I01cbda27eb7826eb11f44e034d746b7c39b399a4
Gerrit-Change-Number: 36277
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 14 Mar 2024 17:14:52 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: jenkins.sh: use available Makefile, clean before building

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36264?usp=email )

Change subject: jenkins.sh: use available Makefile, clean before building
..


Patch Set 1:

(1 comment)

File contrib/jenkins.sh:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15078):
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36264/comment/03dacf3d_88306a44
PS1, Line 5: make check
adding a line without newline at end of file



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36264?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Id3f2d71c184cf387fa178d5138d401686a8d0a63
Gerrit-Change-Number: 36264
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 13 Mar 2024 19:10:14 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in libosmo-pfcp[master]: add missing GPLv2 license text as COPYING file

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36214?usp=email )

Change subject: add missing GPLv2 license text as COPYING file
..


Patch Set 1:

(4 comments)

File COPYING:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14965):
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36214/comment/97314ca9_476e684e
PS1, Line 5:  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Do not include the paragraph about writing to the Free Software Foundation's 
mailing address from the sample GPL notice. The FSF has changed addresses in 
the past, and may do so again. This Osmocom project should already include a 
copy of the (A)GPL.


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14965):
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36214/comment/2c204bad_72a0c2ac
PS1, Line 253: Software Foundation, write to the Free Software Foundation; we 
sometimes
Do not include the paragraph about writing to the Free Software Foundation's 
mailing address from the sample GPL notice. The FSF has changed addresses in 
the past, and may do so again. This Osmocom project should already include a 
copy of the (A)GPL.


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14965):
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36214/comment/d5ba4894_ee04a14d
PS1, Line 307: with this program; if not, write to the Free Software 
Foundation, Inc.,
Do not include the paragraph about writing to the Free Software Foundation's 
mailing address from the sample GPL notice. The FSF has changed addresses in 
the past, and may do so again. This Osmocom project should already include a 
copy of the (A)GPL.


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14965):
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36214/comment/4061ec46_c41fc898
PS1, Line 308: 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
Do not include the paragraph about writing to the Free Software Foundation's 
mailing address from the sample GPL notice. The FSF has changed addresses in 
the past, and may do so again. This Osmocom project should already include a 
copy of the (A)GPL.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/36214?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I33a57492d9f3ca409d5d1bd77a07ec746c668e80
Gerrit-Change-Number: 36214
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 08 Mar 2024 13:44:25 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-ttcn3-hacks[master]: DIAMETER_Types: Generate types for 3GPP TS 29.273

[Jenkins Builder]

Attention is currently required from: pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email )

Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273
..


Patch Set 2:

(36 comments)

File library/DIAMETER_Types.ttcn:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e195df18_3f29a13b 
PS2, Line 2387: // Dependant applications
'Dependant' may be misspelled - perhaps 'Dependent'?


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/afe15e86_2065ecc4
PS2, Line 2399: type AVP_Grouped AAA_3GPP_Non_3GPP_User_Data
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/85d27377_9ab96daf
PS2, Line 2436: type AVP_UTF8String AAA_3GPP_ANID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/46e9d5ed_5aa134fd
PS2, Line 2440: type AVP_Grouped AAA_3GPP_Trace_Info
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/5a69ee20_0535fba7
PS2, Line 2444: type AVP_OctetString AAA_3GPP_MIP_FA_RK
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/a0d1bb65_4e31e901
PS2, Line 2448: type AVP_Unsigned32 AAA_3GPP_MIP_FA_RK_SPI
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/2bf8288f_e2e6ffa3
PS2, Line 2452: type AVP_Unsigned32 AAA_3GPP_PPR_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/f28f145d_2739a0bb
PS2, Line 2456: type AVP_Grouped AAA_3GPP_WLAN_Identifier
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/09135bb1_70da4f3d
PS2, Line 2460: type AVP_Grouped AAA_3GPP_TWAN_Access_Info
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/8078937c_78072de9
PS2, Line 2464: type AVP_Unsigned32 AAA_3GPP_Access_Authorization_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/0d820c90_c76d1a3b
PS2, Line 2468: type AVP_Unsigned32 AAA_3GPP_TWAN_Default_APN_Context_Id
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/88e61c3a_2dacc328
PS2, Line 2482: type AVP_OctetString AAA_3GPP_Full_Network_Name
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/2639f06b_bd99e3ee
PS2, Line 2486: type AVP_OctetString AAA_3GPP_Short_Network_Name
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/4333bfe2_2001736d
PS2, Line 2490: type AVP_Unsigned32 AAA_3GPP_AAA_Failure_Indication
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/c42f219f_1accb0aa
PS2, Line 2504: type AVP_Unsigned32 AAA_3GPP_DER_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/ad1011e4_434e3818
PS2, Line 2508: type AVP_Unsigned32 AAA_3GPP_DEA_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e8d1aa3e_baa8b0f1
PS2, Line 2512: type AVP_Unsigned32 AAA_3GPP_RAR_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/48c9cf2b_d8ed1ee6
PS2, Line 2516: type AVP_Unsigned32 AAA_3GPP_DER_S6b_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/a3b808be_fd86ca5c
PS2, Line 2520: type AVP_UTF8String AAA_3GPP_SSID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/6ed15b6d_21d67d0d
PS2, Line 2524: type AVP_UTF8String AAA_3GPP_HESSID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https

[L] Change in osmo-ttcn3-hacks[master]: DIAMETER_Types: Generate types for 3GPP TS 29.273

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email )

Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273
..


Patch Set 1:

(36 comments)

File library/DIAMETER_Types.ttcn:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/40468ccd_49762597
PS1, Line 1821: // Dependant applications
'Dependant' may be misspelled - perhaps 'Dependent'?


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/8d113e68_4552c4f1
PS1, Line 1832: type AVP_Grouped AAA_3GPP_Non_3GPP_User_Data
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e07425e6_6ddead09
PS1, Line 1869: type AVP_UTF8String AAA_3GPP_ANID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/6a1a2272_e926d8e6
PS1, Line 1873: type AVP_Grouped AAA_3GPP_Trace_Info
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/08b7bc4d_cf0d880d
PS1, Line 1877: type AVP_OctetString AAA_3GPP_MIP_FA_RK
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/21005e2d_a6a2dd9b
PS1, Line 1881: type AVP_Unsigned32 AAA_3GPP_MIP_FA_RK_SPI
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/d40df8ed_b394320f 
PS1, Line 1885: type AVP_Unsigned32 AAA_3GPP_PPR_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e23d9418_09fed780
PS1, Line 1889: type AVP_Grouped AAA_3GPP_WLAN_Identifier
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/14c5d19d_f80614fa
PS1, Line 1893: type AVP_Grouped AAA_3GPP_TWAN_Access_Info
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/bd595ba2_d0e7c959
PS1, Line 1897: type AVP_Unsigned32 AAA_3GPP_Access_Authorization_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/c177361e_f635be18
PS1, Line 1901: type AVP_Unsigned32 AAA_3GPP_TWAN_Default_APN_Context_Id
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/87abfb17_ce9a1212
PS1, Line 1915: type AVP_OctetString AAA_3GPP_Full_Network_Name
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/67ebde4f_a3626979 
PS1, Line 1919: type AVP_OctetString AAA_3GPP_Short_Network_Name
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/273b763b_52bcc352
PS1, Line 1923: type AVP_Unsigned32 AAA_3GPP_AAA_Failure_Indication
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/27e14ff3_33edb0d7
PS1, Line 1937: type AVP_Unsigned32 AAA_3GPP_DER_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/38282507_204bbc45
PS1, Line 1941: type AVP_Unsigned32 AAA_3GPP_DEA_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/f6bf5465_5e500075
PS1, Line 1945: type AVP_Unsigned32 AAA_3GPP_RAR_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/414d75cb_415be9b2
PS1, Line 1949: type AVP_Unsigned32 AAA_3GPP_DER_S6b_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/1fa43b5b_01126e52
PS1, Line 1953: type AVP_UTF8String AAA_3GPP_SSID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/9c84c94e_c62557c8
PS1, Line 1957: type AVP_UTF8String AAA_3GPP_HESSID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks

[XL] Change in osmo-ttcn3-hacks[master]: library: add SGP.32 and SGP.22 ASN.1 specification, encoder and templ...

[Jenkins Builder]

Attention is currently required from: dexter.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email )

Change subject: library: add SGP.32 and SGP.22 ASN.1 specification, encoder and 
templates
..


Patch Set 2:

(2 comments)

File library/euicc/PKIX1Explicit88.asn:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14845):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154/comment/e4303732_01ba3e05
PS2, Line 553:videotex (8) }
trailing whitespace


File library/euicc/SGP32Definitions.asn:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14845):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154/comment/a881ff9a_94326576
PS2, Line 22: CancelSessionResponse, CancelSessionResponseOk,
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9df8caa98aeb6953a738660a758c92249832d780
Gerrit-Change-Number: 36154
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:28:21 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmo-netif[master]: stream_{client,server} example: Cleanup on exit

[Jenkins Builder]

Attention is currently required from: jolly.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email )

Change subject: stream_{client,server} example: Cleanup on exit
..


Patch Set 3:

(2 comments)

File examples/stream-client.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14798):
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/fabaeedb_1b267c79
PS3, Line 172:  while(!quit) {
space required before the open parenthesis '('


File examples/stream-server.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14798):
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/e6a5e513_f02b083f
PS3, Line 189:  while(!quit) {
space required before the open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 3
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Fri, 01 Mar 2024 07:45:04 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmo-netif[master]: stream_{client,server} example: Cleanup on exit

[Jenkins Builder]

Attention is currently required from: jolly.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email )

Change subject: stream_{client,server} example: Cleanup on exit
..


Patch Set 3:

(2 comments)

File examples/stream-client.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14780):
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/79bec3b0_8133845d
PS3, Line 172:  while(!quit) {
space required before the open parenthesis '('


File examples/stream-server.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14780):
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/3146a486_4688a15e
PS3, Line 189:  while(!quit) {
space required before the open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 3
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Thu, 29 Feb 2024 15:13:21 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmo-netif[master]: stream_{client,server} example: Cleanup on exit

[Jenkins Builder]

Attention is currently required from: jolly.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email )

Change subject: stream_{client,server} example: Cleanup on exit
..


Patch Set 3:

(2 comments)

File examples/stream-client.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14770):
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/8583882a_f24a09ae
PS3, Line 172:  while(!quit) {
space required before the open parenthesis '('


File examples/stream-server.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14770):
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/1fedd62a_0abb63f2
PS3, Line 189:  while(!quit) {
space required before the open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 3
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Thu, 29 Feb 2024 12:57:44 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmo-netif[master]: stream_{client,server} example: Cleanup on exit

[Jenkins Builder]

Attention is currently required from: jolly.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email )

Change subject: stream_{client,server} example: Cleanup on exit
..


Patch Set 2:

(2 comments)

File examples/stream-client.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14763):
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/746197db_cdde96dc
PS2, Line 172:  while(!quit) {
space required before the open parenthesis '('


File examples/stream-server.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14763):
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/3474d14c_20325324
PS2, Line 189:  while(!quit) {
space required before the open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 2
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Thu, 29 Feb 2024 12:50:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmo-netif[master]: stream_{client,server} example: Cleanup on exit

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email )

Change subject: stream_{client,server} example: Cleanup on exit
..


Patch Set 1:

(2 comments)

File examples/stream-client.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14753):
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/012d5f51_9c9e8ac0
PS1, Line 172:  while(!quit) {
space required before the open parenthesis '('


File examples/stream-server.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14753):
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/8004315e_484954f5
PS1, Line 189:  while(!quit) {
space required before the open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 29 Feb 2024 08:29:58 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-bsc[master]: ctrl: Add lchan show to all ctrl levels

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/36084?usp=email )

Change subject: ctrl: Add lchan show to all ctrl levels
..


Patch Set 2:

(1 comment)

File src/osmo-bsc/bsc_ctrl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14667):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/c33c3843_03e9e9be
PS2, Line 848:  if (!strlen(bts_dump)) {
braces {} are not necessary for single statement blocks



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36084?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I23c1a7e6f6679e3964e359fb202ffe6781a07e8a
Gerrit-Change-Number: 36084
Gerrit-PatchSet: 2
Gerrit-Owner: matanp 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 24 Feb 2024 14:43:58 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-bsc[master]: ctrl: Add lchan show to all ctrl levels

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/36084?usp=email )

Change subject: ctrl: Add lchan show to all ctrl levels
..


Patch Set 1:

(12 comments)

File src/osmo-bsc/bsc_ctrl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/2c999516_794f6dee
PS1, Line 848:  if (!strlen(bts_dump)) {
braces {} are not necessary for single statement blocks


File src/osmo-bsc/bts_ctrl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/736e9b6d_36f243f4
PS1, Line 1490: if (!dump) {
braces {} are not necessary for single statement blocks


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/1a09a2f6_ddf99b5c
PS1, Line 1497: if (!trx_dump) {
braces {} are not necessary for single statement blocks


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/c1940d64_49523a36
PS1, Line 1500: if (!strlen(trx_dump)) {
braces {} are not necessary for single statement blocks


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/13ee2fd0_b6065d52
PS1, Line 1504: if (!dump) {
braces {} are not necessary for single statement blocks


File src/osmo-bsc/bts_trx_ctrl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/95a1656f_55f9a5a3
PS1, Line 107:  if (!dump) {
braces {} are not necessary for single statement blocks


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/14d12fd3_ba918595
PS1, Line 113:  if (!ts_dump) {
braces {} are not necessary for single statement blocks


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/20863877_8be44e47
PS1, Line 116:  if (!strlen(ts_dump)) {
braces {} are not necessary for single statement blocks


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/8e41ae50_bc3ebdbd
PS1, Line 120:  if (!dump) {
braces {} are not necessary for single statement blocks


File src/osmo-bsc/bts_trx_ts_ctrl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/317405df_94726d75
PS1, Line 104:  if (!dump) {
braces {} are not necessary for single statement blocks


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/133e4a99_88f9d9cd
PS1, Line 110:  if (!lchan_dump) {
braces {} are not necessary for single statement blocks


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666):
https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/a6b83fc2_272fca44
PS1, Line 114:  if (!dump) {
braces {} are not necessary for single statement blocks



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36084?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I23c1a7e6f6679e3964e359fb202ffe6781a07e8a
Gerrit-Change-Number: 36084
Gerrit-PatchSet: 1
Gerrit-Owner: matanp 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sat, 24 Feb 2024 14:40:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmo-hnbgw[master]: [cosmetic] re-order hnbgw.c to group code in major blocks

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36080?usp=email )

Change subject: [cosmetic] re-order hnbgw.c to group code in major blocks
..


Patch Set 1:

(1 comment)

File src/osmo-hnbgw/hnbgw.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14663):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36080/comment/8face840_2bd10288
PS1, Line 272:  * SCTP Socket / stream handling
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36080?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ia7ce60e6f80d10b7712de1aa6d8a30dd61690dcc
Gerrit-Change-Number: 36080
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sat, 24 Feb 2024 11:40:12 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmo-abis[master]: [cosmetic] Don't break lines shorter than 120 chars

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/36039?usp=email )

Change subject: [cosmetic] Don't break lines shorter than 120 chars
..


Patch Set 1:

(2 comments)

File src/input/ipaccess.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14551):
https://gerrit.osmocom.org/c/libosmo-abis/+/36039/comment/5aa1ca29_37cb5335
PS1, Line 628: ret = setsockopt(fd, IPPROTO_TCP, 
TCP_USER_TIMEOUT, , sizeof(val));
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14551):
https://gerrit.osmocom.org/c/libosmo-abis/+/36039/comment/53430816_91732fea
PS1, Line 628: ret = setsockopt(fd, IPPROTO_TCP, 
TCP_USER_TIMEOUT, , sizeof(val));
please, no spaces at the start of a line



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36039?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I0595ee899639d0eb798eb8d9372793db36f05b7a
Gerrit-Change-Number: 36039
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 21 Feb 2024 16:52:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmo-abis[master]: input/ipaccess: Always log with context, if we have any

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/36037?usp=email )

Change subject: input/ipaccess: Always log with context, if we have any
..


Patch Set 1:

(3 comments)

File src/input/ipaccess.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14549):
https://gerrit.osmocom.org/c/libosmo-abis/+/36037/comment/3325de40_0ebc380f
PS1, Line 600:  LOGPIL(line, DLINP, LOGL_NOTICE, "Keepalive is 
set: %i\n", ret);
Use %d instead of %i


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14549):
https://gerrit.osmocom.org/c/libosmo-abis/+/36037/comment/48b6c74f_113543b1
PS1, Line 979:  " port=%u msg_type=%u\n", link->port, msg_type);
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14549):
https://gerrit.osmocom.org/c/libosmo-abis/+/36037/comment/bae5aeff_140570d9
PS1, Line 1072: "OML connecting to %s:%u\n", 
line->ops->cfg.ipa.addr, IPA_TCP_PORT_OML);
code indent should use tabs where possible



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36037?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I5cd84c2d69c0db3be296cb5d9a62720f7b2c827e
Gerrit-Change-Number: 36037
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 21 Feb 2024 16:44:13 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bsc[master]: ctrl: Add lchan show

[Jenkins Builder]

Attention is currently required from: matanp.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email )

Change subject: ctrl: Add lchan show
..


Patch Set 2:

(2 comments)

File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14513):
https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/287ede40_77c66f3c
PS2, Line 74:  *
please, no space before tabs


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14513):
https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/f9d27ace_b7c0a32b
PS2, Line 75:  *
please, no space before tabs



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da
Gerrit-Change-Number: 36019
Gerrit-PatchSet: 2
Gerrit-Owner: matanp 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: matanp 
Gerrit-Comment-Date: Tue, 20 Feb 2024 09:29:48 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bsc[master]: ctrl: Add lchan show

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email )

Change subject: ctrl: Add lchan show
..


Patch Set 1:

(2 comments)

File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14512):
https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/fcd6389a_24fc8c1a
PS1, Line 74:  *
please, no space before tabs


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14512):
https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/63e73020_1dcda1a7
PS1, Line 125:  lchan->conn ? 1: 0, lchan_state_name(lchan),
spaces required around that ':' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da
Gerrit-Change-Number: 36019
Gerrit-PatchSet: 1
Gerrit-Owner: matanp 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 20 Feb 2024 09:27:04 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in pysim[master]: utils: Add function to verify Luhn check digits and to sanitize ICCIDs

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/36009?usp=email )

Change subject: utils: Add function to verify Luhn check digits and to sanitize 
ICCIDs
..


Patch Set 1:

(1 comment)

File tests/test_utils.py:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14478):
https://gerrit.osmocom.org/c/pysim/+/36009/comment/930018f8_33eb9a92
PS1, Line 251: # 19 digits without correct luhn; we expect chck digit 
to be added
'chck' may be misspelled - perhaps 'check'?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36009?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7812420cf97984dd834fca6a38c5e5ae113243cb
Gerrit-Change-Number: 36009
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sun, 18 Feb 2024 18:49:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmocom-bb[master]: mobile: init TCH state earlier (on receipt of CC ALERTING)

[Jenkins Builder]

Attention is currently required from: fixeria, jolly.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email )

Change subject: mobile: init TCH state earlier (on receipt of CC ALERTING)
..


Patch Set 3:

(1 comment)

File src/host/layer23/src/mobile/tch.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14233):
https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/34784643_03abba9b
PS3, Line 62:   } else {
else is not generally useful after a break or return



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Idd32c823639cc1fd77fcefe7e260e31a85ec
Gerrit-Change-Number: 35739
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Mon, 05 Feb 2024 20:10:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmocom-bb[master]: mobile: init TCH state earlier (on receipt of CC ALERTING)

[Jenkins Builder]

Attention is currently required from: jolly, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email )

Change subject: mobile: init TCH state earlier (on receipt of CC ALERTING)
..


Patch Set 2:

(1 comment)

File src/host/layer23/src/mobile/tch.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14222):
https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/600ec3bf_a84d7ae4
PS2, Line 62:   } else {
else is not generally useful after a break or return



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Idd32c823639cc1fd77fcefe7e260e31a85ec
Gerrit-Change-Number: 35739
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 05 Feb 2024 18:06:33 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: [HACK] trxcon/l1sched: warn about incomplete UL PDTCH transmissions

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/35768?usp=email )

Change subject: [HACK] trxcon/l1sched: warn about incomplete UL PDTCH 
transmissions
..


Patch Set 1:

(1 comment)

File src/host/trxcon/src/sched_trx.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13977):
https://gerrit.osmocom.org/c/osmocom-bb/+/35768/comment/24da1436_54105de5
PS1, Line 516: #if 1
Consider removing the #if 1 and its #endif



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35768?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id485c919ca87a9edfb8bc974d73fb88638bfc510
Gerrit-Change-Number: 35768
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 01 Feb 2024 17:37:02 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bsc[master]: ctrl: Split bts_trx_ts_ctrl from bts_trx_ctrl

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/35746?usp=email )

Change subject: ctrl: Split bts_trx_ts_ctrl from bts_trx_ctrl
..


Patch Set 1:

(2 comments)

File src/osmo-bsc/bts_trx_ts_ctrl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13929):
https://gerrit.osmocom.org/c/osmo-bsc/+/35746/comment/6fb0171c_f435514b
PS1, Line 34:   if (gsm_arfcn2band_rc(arfcn, ) < 0) {
braces {} are not necessary for single statement blocks


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13929):
https://gerrit.osmocom.org/c/osmo-bsc/+/35746/comment/d5141d3b_6709adbb
PS1, Line 67:   if (gsm_arfcn2band_rc(arfcn, ) < 0) {
braces {} are not necessary for single statement blocks



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35746?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9840bddd4eae409bc8373912d54b6bbfc9fc1c1a
Gerrit-Change-Number: 35746
Gerrit-PatchSet: 1
Gerrit-Owner: matanp 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 30 Jan 2024 15:07:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-sip-connector[master]: verbosely log MNCC and SDP

[Jenkins Builder]

Attention is currently required from: fixeria, laforge, neels, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308?usp=email )

Change subject: verbosely log MNCC and SDP
..


Patch Set 4:

(1 comment)

File src/mncc.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13836):
https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308/comment/69a6a3c1_5ec33812
PS4, Line 1101: log_mncc("rx ", (void*)buf, rc);
"(foo*)" should be "(foo *)"



--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ie923117929c6b79b1eb61e5a9f02a169edabc599
Gerrit-Change-Number: 35308
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Thu, 25 Jan 2024 01:53:30 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-sip-connector[master]: verbosely log MNCC and SDP

[Jenkins Builder]

Attention is currently required from: fixeria, laforge, neels, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308?usp=email )

Change subject: verbosely log MNCC and SDP
..


Patch Set 3:

(1 comment)

File src/mncc.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13835):
https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308/comment/b4ef1540_cb206d88
PS3, Line 1103: log_mncc("rx ", (void*)buf, rc);
"(foo*)" should be "(foo *)"



--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ie923117929c6b79b1eb61e5a9f02a169edabc599
Gerrit-Change-Number: 35308
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Thu, 25 Jan 2024 01:52:07 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bts[master]: osmo-bts-trx: add test VTY command to send arbitrary TRXC messages

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/35654?usp=email )

Change subject: osmo-bts-trx: add test VTY command to send arbitrary TRXC 
messages
..


Patch Set 1:

(1 comment)

File src/osmo-bts-trx/trx_vty.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13787):
https://gerrit.osmocom.org/c/osmo-bts/+/35654/comment/54cc0aaa_0671ae4d
PS1, Line 212:  vty_out(vty, "%% Cound not find TRX%s", VTY_NEWLINE);
'Cound' may be misspelled - perhaps 'Could'?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35654?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iabc9b702e5f1513187e24f45d9ffe06ea940c3ec
Gerrit-Change-Number: 35654
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 22 Jan 2024 20:54:36 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in pysim[master]: New pySim.esim.x509_cert module for X.509 certificate handling

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/35633?usp=email )

Change subject: New pySim.esim.x509_cert module for X.509 certificate handling
..


Patch Set 1:

(1 comment)

File pySim/esim/x509_cert.py:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13732):
https://gerrit.osmocom.org/c/pysim/+/35633/comment/5576d013_74e7d5b8
PS1, Line 1: # Implementation of X.509 certificate handling in GSMA eSIM
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35633?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia8cc2dac02fcd96624dc6d9348f103373eeeb614
Gerrit-Change-Number: 35633
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 19 Jan 2024 20:32:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: tests/gsm0408: add two more samples to bcap_tests[]

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35615?usp=email )

Change subject: tests/gsm0408: add two more samples to bcap_tests[]
..


Patch Set 1:

(2 comments)

File tests/gsm0408/gsm0408_test.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13686):
https://gerrit.osmocom.org/c/libosmocore/+/35615/comment/59acb632_f5381be3
PS1, Line 63:   .speech_ver[0]= -1,
spaces required around that '=' (ctx:VxW)


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13686):
https://gerrit.osmocom.org/c/libosmocore/+/35615/comment/a645b47c_4d1f9a6d
PS1, Line 85:   .speech_ver[0]= -1,
spaces required around that '=' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35615?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4fc519c02b4fad8b0f40fa649d9de14b1183d10d
Gerrit-Change-Number: 35615
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 18 Jan 2024 18:47:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmocom-bb[master]: mobile: init/deinit GAPK I/O based on CC transaction events

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email )

Change subject: mobile: init/deinit GAPK I/O based on CC transaction events
..


Patch Set 1:

(1 comment)

File src/host/layer23/src/mobile/tch.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13601):
https://gerrit.osmocom.org/c/osmocom-bb/+/35579/comment/033142d3_6384c596
PS1, Line 122:  else /* TODO: tch_recv_data() */
else is not generally useful after a break or return



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I28f87f6a6de673611aa02a24e8985aee23d4498b
Gerrit-Change-Number: 35579
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 15 Jan 2024 18:39:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in osmocom-bb[master]: [WIP] mobile: integrate V.110 TA & soft-UART from libosmocore

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/35582?usp=email )

Change subject: [WIP] mobile: integrate V.110 TA & soft-UART from libosmocore
..


Patch Set 1:

(2 comments)

File src/host/layer23/src/mobile/tch.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13596):
https://gerrit.osmocom.org/c/osmocom-bb/+/35582/comment/c2e92626_aa6f6018
PS1, Line 171:  else
else is not generally useful after a break or return


File src/host/layer23/src/mobile/tch_data.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13596):
https://gerrit.osmocom.org/c/osmocom-bb/+/35582/comment/31cccf2a_fa5fc9fe
PS1, Line 315: #if 1
Consider removing the #if 1 and its #endif



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35582?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7ac9c0e5010730fa4d8bc7a7a3c7ff85e11731c0
Gerrit-Change-Number: 35582
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 15 Jan 2024 18:39:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmo-abis[master]: Add support for sending and receiving Sa bits, as well as some line s...

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/35563?usp=email )

Change subject: Add support for sending and receiving Sa bits, as well as some 
line signals
..


Patch Set 1:

(16 comments)

File src/input/e1d.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/7b982e26_e313cb4a
PS1, Line 81: struct e1inp_line *e1i_line;
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/e28bf67a_4d3119ee
PS1, Line 81: struct e1inp_line *e1i_line;
please, no spaces at the start of a line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/1ac5acb5_44812c23
PS1, Line 83: /* iterate over global list of e1 lines */
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/f862f0ce_22934153
PS1, Line 84: llist_for_each_entry(e1i_line, _line_list, list) {
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/1b88b87b_ca1b8a42
PS1, Line 84: llist_for_each_entry(e1i_line, _line_list, list) {
please, no spaces at the start of a line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/a78ab10b_a566a23e
PS1, Line 85: if (e1i_line->port_nr == port_nr)
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/3b721756_ef6c9939
PS1, Line 85: if (e1i_line->port_nr == port_nr)
please, no spaces at the start of a line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/0ec7ecb0_2feb1a06
PS1, Line 86: return e1i_line;
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/4710df86_4e0b3bae
PS1, Line 86: return e1i_line;
please, no spaces at the start of a line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/77be6ac8_cbb9ec1f
PS1, Line 87: }
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/b25f9f9f_9e3abb27
PS1, Line 87: }
please, no spaces at the start of a line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/f3d77ce6_8e329110
PS1, Line 88: return NULL;
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/38a4cfa3_21f021c3
PS1, Line 88: return NULL;
please, no spaces at the start of a line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/b132a521_bb3d0d2f
PS1, Line 97: memset(, 0, sizeof(isd));
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/47b5f222_598163f5
PS1, Line 97: memset(, 0, sizeof(isd));
please, no spaces at the start of a line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):
https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/a54b8dc4_89ae6d0e
PS1, Line 106:  switch (event) {
switch and case should be at the same indent



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35563?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ie7643693c2daac99f5747591decd60e982b8052a
Gerrit-Change-Number: 35563
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sun, 14 Jan 2024 15:17:33 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmocom-bb[master]: layer23/ccch_scan: use osmo_mobile_identity API

[Jenkins Builder]

Attention is currently required from: jolly, laforge, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email )

Change subject: layer23/ccch_scan: use osmo_mobile_identity API
..


Patch Set 5:

(2 comments)

File src/host/layer23/src/misc/app_ccch_scan.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13509):
https://gerrit.osmocom.org/c/osmocom-bb/+/33317/comment/37029ff5_11dfc8a6
PS5, Line 309:  LOGP(DRR, LOGL_NOTICE, "Paging1: %s chan %s to M(TMSI-0x%08x) 
\n",
unnecessary whitespace before a quoted newline


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13509):
https://gerrit.osmocom.org/c/osmocom-bb/+/33317/comment/afa8d962_3431c8f0
PS5, Line 313:  LOGP(DRR, LOGL_NOTICE, "Paging2: %s chan %s to M(TMSI-0x%08x) 
\n",
unnecessary whitespace before a quoted newline



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ida67adaa61689c55505a89e1a1bebde041c91139
Gerrit-Change-Number: 33317
Gerrit-PatchSet: 5
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: jolly 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Mon, 08 Jan 2024 15:45:36 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[XL] Change in pysim[master]: Initial proof-of-concept SM-DP+ for GSMA consumer eSIM RSP

[Jenkins Builder]

Attention is currently required from: dexter, fixeria, lynxis lazus.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/35461?usp=email )

Change subject: Initial proof-of-concept SM-DP+ for GSMA consumer eSIM RSP
..


Patch Set 10:

(1 comment)

File docs/osmo-smdpp.rst:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13488):
https://gerrit.osmocom.org/c/pysim/+/35461/comment/0a44c5aa_03117f5a
PS10, Line 7: At least at this point, it is intended to be used for reasearch 
and development, and not as a
'reasearch' may be misspelled - perhaps 'research'?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35461?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6232847432dc6920cd2bd08c84d7099c29ca1c11
Gerrit-Change-Number: 35461
Gerrit-PatchSet: 10
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Sun, 07 Jan 2024 19:42:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[XL] Change in pysim[master]: Initial work on a SM-DP+ for GSMA consumer eSIM RSP

[Jenkins Builder]

Attention is currently required from: laforge.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/35461?usp=email )

Change subject: Initial work on a SM-DP+ for GSMA consumer eSIM RSP
..


Patch Set 3:

(1 comment)

File tests/test_esim_bsp.py:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13460):
https://gerrit.osmocom.org/c/pysim/+/35461/comment/8faf1298_248eb5f2
PS3, Line 73: """This test verifies whether some fully 
encoded/encrypted/MACed bound profile pacakge can be properly
'pacakge' may be misspelled - perhaps 'package'?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35461?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6232847432dc6920cd2bd08c84d7099c29ca1c11
Gerrit-Change-Number: 35461
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Fri, 05 Jan 2024 22:57:51 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[L] Change in pysim[master]: Add pySim.esim.bsp module implementing BSP (BPP Protection Protocol)

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/35488?usp=email )

Change subject: Add pySim.esim.bsp module implementing BSP (BPP Protection 
Protocol)
..


Patch Set 1:

(1 comment)

File tests/test_esim_bsp.py:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13443):
https://gerrit.osmocom.org/c/pysim/+/35488/comment/132897de_8d33a91b
PS1, Line 36: test vectors to verify our implemenation is in agreement with 
that other implementation."""
'implemenation' may be misspelled - perhaps 'implementation'?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35488?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic461936f2e68e1e6f7faab33d06acf3063e261e7
Gerrit-Change-Number: 35488
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 04 Jan 2024 20:51:35 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

[Jenkins Builder]

Attention is currently required from: laforge, neels, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email )

Change subject: ecu: force alignment of member data in struct osmo_ecu_state
..


Patch Set 6:

(1 comment)

File src/codec/ecu_fr.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13397):
https://gerrit.osmocom.org/c/libosmocore/+/35212/comment/5bf2c239_a3f747a3
PS6, Line 300: return (struct fr_ecu_state *)container_of(st, struct 
fr_ecu_state, ecu_state);
please, no spaces at the start of a line



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I28672856e8e8f47e04ffe09ee3e07b577108cdc7
Gerrit-Change-Number: 35212
Gerrit-PatchSet: 6
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 02 Jan 2024 11:27:55 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: core: osmo_tdef_fsm_inst_state_chg(): allow millisecond precision

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35466?usp=email )

Change subject: core: osmo_tdef_fsm_inst_state_chg(): allow millisecond 
precision
..


Patch Set 1:

(1 comment)

File src/core/tdef.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13374):
https://gerrit.osmocom.org/c/libosmocore/+/35466/comment/00af44ad_e87856ed
PS1, Line 347:  const struct osmo_tdef *tdef = 
osmo_tdef_get_entry((struct osmo_tdef*)tdefs, t->T);
"(foo*)" should be "(foo *)"



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35466?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4c4ee89e7e32e86f74cd215f5cbfa44ace5426c1
Gerrit-Change-Number: 35466
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 29 Dec 2023 21:39:50 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-mgw[master]: mgw, client: add fmtp string to ptmap: allow all possible fmtp

[Jenkins Builder]

Attention is currently required from: laforge, neels, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email )

Change subject: mgw, client: add fmtp string to ptmap: allow all possible fmtp
..


Patch Set 14:

(1 comment)

File src/libosmo-mgcp/mgcp_sdp.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13276):
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/3a474c8c_b94548aa
PS14, Line 593: else if (codec->param_present) {
else should follow close brace '}'



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: If58590bda8627519ff07e0b6f43aa47a274f052b
Gerrit-Change-Number: 34900
Gerrit-PatchSet: 14
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: dexter 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Sat, 23 Dec 2023 06:35:15 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-mgw[master]: add fmtp.h

[Jenkins Builder]

Attention is currently required from: neels.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/35434?usp=email )

Change subject: add fmtp.h
..


Patch Set 3:

(1 comment)

File include/osmocom/mgcp_client/fmtp.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13273):
https://gerrit.osmocom.org/c/osmo-mgw/+/35434/comment/81a7cb7c_857b31c9
PS3, Line 29:   ((VAL) ? OSMO_SDP_VAL_AMR_OCTET_ALIGN_1 : 
OSMO_SDP_VAL_AMR_OCTET_ALIGN_0 )
space prohibited before that close parenthesis ')'



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35434?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I3eaea353dbd98c19212199b564342d0ac16cbc07
Gerrit-Change-Number: 35434
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels 
Gerrit-Comment-Date: Sat, 23 Dec 2023 06:29:05 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-mgw[master]: mgw, client: add fmtp string to ptmap: allow all possible fmtp

[Jenkins Builder]

Attention is currently required from: laforge, neels, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email )

Change subject: mgw, client: add fmtp string to ptmap: allow all possible fmtp
..


Patch Set 13:

(1 comment)

File src/libosmo-mgcp/mgcp_sdp.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13267):
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/4397d89a_389650be
PS13, Line 593: else if (codec->param_present) {
else should follow close brace '}'



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: If58590bda8627519ff07e0b6f43aa47a274f052b
Gerrit-Change-Number: 34900
Gerrit-PatchSet: 13
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: dexter 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Sat, 23 Dec 2023 06:28:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-mgw[master]: add fmtp.h

[Jenkins Builder]

Attention is currently required from: neels.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/35434?usp=email )

Change subject: add fmtp.h
..


Patch Set 2:

(1 comment)

File include/osmocom/mgcp_client/fmtp.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13255):
https://gerrit.osmocom.org/c/osmo-mgw/+/35434/comment/538a44e3_68b428fa
PS2, Line 29:   ((VAL) ? OSMO_SDP_VAL_AMR_OCTET_ALIGN_1 : 
OSMO_SDP_VAL_AMR_OCTET_ALIGN_0 )
space prohibited before that close parenthesis ')'



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35434?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I3eaea353dbd98c19212199b564342d0ac16cbc07
Gerrit-Change-Number: 35434
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels 
Gerrit-Comment-Date: Sat, 23 Dec 2023 06:24:06 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-mgw[master]: mgw, client: add fmtp string to ptmap: allow all possible fmtp

[Jenkins Builder]

Attention is currently required from: laforge, neels, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email )

Change subject: mgw, client: add fmtp string to ptmap: allow all possible fmtp
..


Patch Set 12:

(1 comment)

File src/libosmo-mgcp/mgcp_sdp.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13253):
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/400728de_d80e3335
PS12, Line 593: else if (codec->param_present) {
else should follow close brace '}'



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: If58590bda8627519ff07e0b6f43aa47a274f052b
Gerrit-Change-Number: 34900
Gerrit-PatchSet: 12
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: dexter 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Sat, 23 Dec 2023 06:23:36 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-mgw[master]: mgw, client: add fmtp string to ptmap: allow all possible fmtp

[Jenkins Builder]

Attention is currently required from: laforge, neels, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email )

Change subject: mgw, client: add fmtp string to ptmap: allow all possible fmtp
..


Patch Set 11:

(1 comment)

File src/libosmo-mgcp/mgcp_sdp.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13248):
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/6575baae_a0b9895b
PS11, Line 593: else if (codec->param_present) {
else should follow close brace '}'



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: If58590bda8627519ff07e0b6f43aa47a274f052b
Gerrit-Change-Number: 34900
Gerrit-PatchSet: 11
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: dexter 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Sat, 23 Dec 2023 06:06:45 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-mgw[master]: add fmtp.h

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/35434?usp=email )

Change subject: add fmtp.h
..


Patch Set 1:

(1 comment)

File include/osmocom/mgcp_client/fmtp.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13239):
https://gerrit.osmocom.org/c/osmo-mgw/+/35434/comment/8043bf92_17c27568
PS1, Line 29:   ((VAL) ? OSMO_SDP_VAL_AMR_OCTET_ALIGN_1 : 
OSMO_SDP_VAL_AMR_OCTET_ALIGN_0 )
space prohibited before that close parenthesis ')'



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35434?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I3eaea353dbd98c19212199b564342d0ac16cbc07
Gerrit-Change-Number: 35434
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sat, 23 Dec 2023 06:06:21 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in pysim[master]: fix encode/decode of xPLMNwAcT

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/35415?usp=email )

Change subject: fix encode/decode of xPLMNwAcT
..


Patch Set 1:

(1 comment)

File pySim/utils.py:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13207):
https://gerrit.osmocom.org/c/pysim/+/35415/comment/7b3c566e_f4d98986
PS1, Line 497: # only the simple single-bit ones
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35415?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I398ac2a2527bd11e9c652e49fa46d6ca8d334b88
Gerrit-Change-Number: 35415
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 21 Dec 2023 19:27:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bts[master]: Add GSMTAP encapsulation of RLP frames in CSD NT mode

[Jenkins Builder]

Attention is currently required from: laforge, osmith.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/35124?usp=email )

Change subject: Add GSMTAP encapsulation of RLP frames in CSD NT mode
..


Patch Set 7:

(2 comments)

File src/common/l1sap.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13154):
https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/45c2a135_173a4b22
PS7, Line 1889: } else {
else is not generally useful after a break or return


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13154):
https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/2e4f9a18_c2d3b502
PS7, Line 1903: } else {
else is not generally useful after a break or return



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35124?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6a258458822bcb3fe7290a9b9b3d104beecda219
Gerrit-Change-Number: 35124
Gerrit-PatchSet: 7
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: osmith 
Gerrit-Attention: osmith 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Sun, 17 Dec 2023 11:11:05 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-iuh[master]: iu_client: Handle empty CR and InitialUE Message in DATA.ind

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-iuh/+/35354?usp=email )

Change subject: iu_client: Handle empty CR and InitialUE Message in DATA.ind
..


Patch Set 1:

(6 comments)

File src/iu_client.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):
https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/fd14000f_ecaae644
PS1, Line 180: static void ue_conn_sccp_addr_add(uint32_t conn_id, const struct 
osmo_sccp_addr *calling_addr) {
open brace '{' following function definitions go on the next line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):
https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/97e6f0cc_25602fd3
PS1, Line 189: static const struct osmo_sccp_addr 
*ue_conn_sccp_addr_find(uint32_t conn_id) {
open brace '{' following function definitions go on the next line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):
https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/74971f2e_620ebf20
PS1, Line 192:  if (entry->conn_id == conn_id) {
braces {} are not necessary for single statement blocks


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):
https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/1dacde76_ef20c1c5
PS1, Line 199: static void ue_conn_sccp_addr_del(uint32_t conn_id) {
open brace '{' following function definitions go on the next line


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):
https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/affd1729_5e710e86
PS1, Line 931:   "N-DATA.ind for unknown conn_id 
(%u)\n", conn_id);
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099):
https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/b846dfaf_cd407be3
PS1, Line 931:   "N-DATA.ind for unknown conn_id 
(%u)\n", conn_id);
please, no space before tabs



--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/35354?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I749ede737b9ac15bca37bbb16f3988b0db1125c1
Gerrit-Change-Number: 35354
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 13 Dec 2023 16:42:15 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

[Jenkins Builder]

Attention is currently required from: laforge, neels, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email )

Change subject: ecu: force alignment of member data in struct osmo_ecu_state
..


Patch Set 4:

(1 comment)

File src/codec/ecu_fr.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13097):
https://gerrit.osmocom.org/c/libosmocore/+/35212/comment/66145869_dbff51aa
PS4, Line 294:  return (struct osmo_ecu_state*) fr;
"(foo*)" should be "(foo *)"



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I28672856e8e8f47e04ffe09ee3e07b577108cdc7
Gerrit-Change-Number: 35212
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Wed, 13 Dec 2023 13:48:54 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

[Jenkins Builder]

Attention is currently required from: laforge, neels, pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email )

Change subject: ecu: force alignment of member data in struct osmo_ecu_state
..


Patch Set 3:

(1 comment)

File src/codec/ecu_fr.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13096):
https://gerrit.osmocom.org/c/libosmocore/+/35212/comment/c3fdbdc1_eba31939
PS3, Line 294:  return (struct osmo_ecu_state*) fr;
"(foo*)" should be "(foo *)"



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I28672856e8e8f47e04ffe09ee3e07b577108cdc7
Gerrit-Change-Number: 35212
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Wed, 13 Dec 2023 13:47:54 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-sip-connector[master]: verbosely log MNCC and SDP

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308?usp=email )

Change subject: verbosely log MNCC and SDP
..


Patch Set 1:

(2 comments)

File src/mncc.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13025):
https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308/comment/c30ebc52_7f460b99
PS1, Line 1072: gsm_mncc = (void*)buf;
"(foo*)" should be "(foo *)"


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13025):
https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308/comment/9ed2d2db_edebbbc8
PS1, Line 1077: gsm_mncc_rtp = (void*)buf;
"(foo*)" should be "(foo *)"



--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ie923117929c6b79b1eb61e5a9f02a169edabc599
Gerrit-Change-Number: 35308
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sun, 10 Dec 2023 06:41:44 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: tests/soft_uart: cosmetic: improve readability of the test output

[Jenkins Builder]

Attention is currently required from: fixeria.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35296?usp=email )

Change subject: tests/soft_uart: cosmetic: improve readability of the test 
output
..


Patch Set 2:

(1 comment)

File tests/soft_uart/soft_uart_test.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13001):
https://gerrit.osmocom.org/c/libosmocore/+/35296/comment/6adc0bab_b6cad6db
PS2, Line 30:   } while(0)
space required before the open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35296?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icf5410f0b292d41532e0cbd17e6ca0509c76cbd5
Gerrit-Change-Number: 35296
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Sat, 09 Dec 2023 08:26:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: tests/soft_uart: cosmetic: improve readability of the test output

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35296?usp=email )

Change subject: tests/soft_uart: cosmetic: improve readability of the test 
output
..


Patch Set 1:

(1 comment)

File tests/soft_uart/soft_uart_test.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12992):
https://gerrit.osmocom.org/c/libosmocore/+/35296/comment/726dd4e0_ef07e24f
PS1, Line 30:   } while(0)
space required before the open parenthesis '('



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35296?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icf5410f0b292d41532e0cbd17e6ca0509c76cbd5
Gerrit-Change-Number: 35296
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 08 Dec 2023 22:03:55 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-mgw[master]: client: move some items to internal header

[Jenkins Builder]

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/35246?usp=email )

Change subject: client: move some items to internal header
..


Patch Set 1:

(3 comments)

File include/osmocom/mgcp_client/mgcp_client_internal.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12884):
https://gerrit.osmocom.org/c/osmo-mgw/+/35246/comment/48def2e0_67592516
PS1, Line 49: typedef void (* mgcp_response_cb_t )(struct mgcp_response 
*response, void *priv);
do not add new typedefs


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12884):
https://gerrit.osmocom.org/c/osmo-mgw/+/35246/comment/00755ee2_57a16d45
PS1, Line 49: typedef void (* mgcp_response_cb_t )(struct mgcp_response 
*response, void *priv);
space prohibited after that '*' (ctx:BxW)


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12884):
https://gerrit.osmocom.org/c/osmo-mgw/+/35246/comment/1753938f_2a065949
PS1, Line 49: typedef void (* mgcp_response_cb_t )(struct mgcp_response 
*response, void *priv);
space prohibited before that close parenthesis ')'



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35246?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6d8bdda5c2ffa236e94a0b6111de4dbfac923187
Gerrit-Change-Number: 35246
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 07 Dec 2023 03:35:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bsc[master]: Make BSSGP timing data configurable

[Jenkins Builder]

Attention is currently required from: arehbein.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email )

Change subject: Make BSSGP timing data configurable
..


Patch Set 7:

(1 comment)

File src/osmo-bsc/bts_vty.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12814):
https://gerrit.osmocom.org/c/osmo-bsc/+/31882/comment/8ee42d42_0fc43b4c
PS7, Line 1754: if (osmo_tdef_set(bts_bssgp->tdefs, 
tdef_params->tdef_id, (val * tdef_params->factor)? : 1, tdef_params->unit) < 0)
spaces required around that '?' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id4779f033b5eb1742462d4efc28a0398645acfe6
Gerrit-Change-Number: 31882
Gerrit-PatchSet: 7
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Attention: arehbein 
Gerrit-Comment-Date: Tue, 05 Dec 2023 08:57:23 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload

[Jenkins Builder]

Attention is currently required from: fixeria, jolly, laforge.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email )

Change subject: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without 
L3 payload
..


Patch Set 6:

(1 comment)

File src/common/rsl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12721):
https://gerrit.osmocom.org/c/osmo-bts/+/35082/comment/f624a0bf_62a63d35
PS6, Line 3841: /* Reject inital establishment without 
L3 info. */
'inital' may be misspelled - perhaps 'initial'?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6819b51a876b8743c2d4a04165b7900723a1631c
Gerrit-Change-Number: 35082
Gerrit-PatchSet: 6
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 29 Nov 2023 18:45:47 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

[Jenkins Builder]

Attention is currently required from: arehbein, daniel.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email )

Change subject: osmo_io: Remove union in struct osmo_io_ops
..


Patch Set 3:

(1 comment)

File src/core/osmo_io.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12714):
https://gerrit.osmocom.org/c/libosmocore/+/35079/comment/ebf6c5e6_a0b1fc97
PS3, Line 388: static bool iofd_read_callback_set(struct osmo_io_fd* iofd)
"foo* bar" should be "foo *bar"



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I138d57843edc29000530bb7896bcb239002ecbec
Gerrit-Change-Number: 35079
Gerrit-PatchSet: 3
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein 
Gerrit-Attention: arehbein 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Wed, 29 Nov 2023 17:59:08 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bts[master]: Add GSMTAP encapsulation of RLP frames in CSD NT mode

[Jenkins Builder]

Attention is currently required from: fixeria, laforge.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/35124?usp=email )

Change subject: Add GSMTAP encapsulation of RLP frames in CSD NT mode
..


Patch Set 6:

(2 comments)

File src/common/l1sap.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12698):
https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/21244cd8_c8b32077
PS6, Line 1879: } else {
else is not generally useful after a break or return


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12698):
https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/8f7b8427_f0815275
PS6, Line 1893: } else {
else is not generally useful after a break or return



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35124?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6a258458822bcb3fe7290a9b9b3d104beecda219
Gerrit-Change-Number: 35124
Gerrit-PatchSet: 6
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Tue, 28 Nov 2023 22:12:21 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bts[master]: Add GSMTAP encapsulation of RLP frames in CSD NT mode

[Jenkins Builder]

Attention is currently required from: fixeria, laforge.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/35124?usp=email )

Change subject: Add GSMTAP encapsulation of RLP frames in CSD NT mode
..


Patch Set 5:

(2 comments)

File src/common/l1sap.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12695):
https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/cad0efa7_87105560
PS5, Line 1879: } else {
else is not generally useful after a break or return


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12695):
https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/5bdef780_58ff2f99
PS5, Line 1893: } else {
else is not generally useful after a break or return



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35124?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6a258458822bcb3fe7290a9b9b3d104beecda219
Gerrit-Change-Number: 35124
Gerrit-PatchSet: 5
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Tue, 28 Nov 2023 22:00:45 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bsc[master]: Make BSSGP timing data configurable

[Jenkins Builder]

Attention is currently required from: arehbein.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email )

Change subject: Make BSSGP timing data configurable
..


Patch Set 6:

(1 comment)

File src/osmo-bsc/bts_vty.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12664):
https://gerrit.osmocom.org/c/osmo-bsc/+/31882/comment/82cb6fbd_e52e7353
PS6, Line 1755: if (osmo_tdef_set(bts_bssgp->tdefs, 
tdef_params->tdef_id, (val * tdef_params->factor)? : 1, tdef_params->unit) < 0)
spaces required around that '?' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id4779f033b5eb1742462d4efc28a0398645acfe6
Gerrit-Change-Number: 31882
Gerrit-PatchSet: 6
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Attention: arehbein 
Gerrit-Comment-Date: Tue, 28 Nov 2023 10:02:34 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[M] Change in osmo-bsc[master]: Make BSSGP timing data configurable

[Jenkins Builder]

Attention is currently required from: arehbein.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email )

Change subject: Make BSSGP timing data configurable
..


Patch Set 5:

(1 comment)

File src/osmo-bsc/bts_vty.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12662):
https://gerrit.osmocom.org/c/osmo-bsc/+/31882/comment/ca036c67_466958e6
PS5, Line 1755: if (osmo_tdef_set(bts_bssgp->tdefs, 
tdef_params->tdef_id, (val * tdef_params->factor)? : 1, tdef_params->unit) < 0)
spaces required around that '?' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id4779f033b5eb1742462d4efc28a0398645acfe6
Gerrit-Change-Number: 31882
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Attention: arehbein 
Gerrit-Comment-Date: Tue, 28 Nov 2023 09:48:44 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment