[Gimp-developer] Fwd: guadec-list Digest, Vol 2, Issue 17
Hi, Given the number of Germans around, I thought this might tempt one or two late-comers: Forwarded message: From: Frank Rehberger [EMAIL PROTECTED] Subject: Caravan: Karlsruhe - Hamburg - Kristiansand To: [EMAIL PROTECTED] Hi, we (2 guys from Berlin and 3 from Hamburg) are travelling from LinuxTag by train to Hamburg on Saturday (June 26th) evening. We continue travelling by car from Hamburg to GUADEC. Seats in car are vacant. You are welcome to join us in train from Karlsruhe to Hamburg at 26th June: departure Karlsruhe: 19:01 ICE-502 arrival Mannheim: 19:24 departure Mannheim: 19:31, ICE-592 arrival Göttingen: 21:58 departure Göttingen: 22:03 ICE-782 arrival Hamburg: 00:06 total time: 5 hours Next day in the morning we continue travelling by car from Hamburg to Kristiansand to GUADEC, taking ferry from Hiltshals to Kristiansand. http://www.colorline.com/ Seats in car are vacant: 27.6. Hamburg-Hiltshals-Kristiansand: 2 seats vacant 1.7. Kristiansand-Hiltshals-Hamburg-Berlin: 1 seat vacant. costs for gas and ferry will be shared. If you want to join the caravan, give me a note. Regards, Frank -- Frank Rehberger [EMAIL PROTECTED] GNOME Deutschland The Twelve Networking Truths - http://www.faqs.org/rfcs/rfc1925.html -- Dave Neary Lyon, France ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] preview widgets, wiedermal
Hi, Quoting William Skaggs [EMAIL PROTECTED]: I know that everybody dreads another go-around on this topic, but it really needs to happen in the near future. Maybe, since it has proven so difficult to come to a consensus by email, this can be put on the list as something to be settled at GimpCon. To my knowledge, Ernst (who has written the only preview widget currently out there) won't be at the conference. David Odin will be, though - and he had started working on a preview widget before the 2.0 release, but hasn't had time since then to work on the GIMP. Does this mean that you're going to be in Norway? Cheers, Dave. -- Dave Neary Lyon, France ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
[Gimp-developer] [PATCH] Make Gimpressionist PDB-friendly
The intent of this patch is to make gimpressionist PDB-friendly. To do so
it:
1. Implements the non-interactive running logic.
2. Adds another PDB function, this time accepting a (Gimpressionist)
preset to use as an argument.
Consider it as a special gift for me just in time for GimpCon.
Regards,
Shlomi Fish
--
Shlomi Fish[EMAIL PROTECTED]
Home Page: http://shlomif.il.eu.org/
You are banished! You are banished! You are banished!
Hey? I'm just kidding!--- vanilla/gimp/plug-ins/gimpressionist/presets.c 2004-05-28 19:36:52.538631904
+0300
+++ gimp/plug-ins/gimpressionist/presets.c 2004-06-23 15:32:39.509130992 +0300
@@ -278,6 +278,37 @@
return 0;
}
+int select_preset(char * preset)
+{
+int ret = SELECT_PRESET_OK;
+/* I'm copying this behavior as is. As it seems applying the
+ * factury_defaults preset does nothing, which I'm not sure
+ * if that was what the author intended.
+ * -- Shlomi Fish
+ */
+if (strcmp (preset, factory_defaults))
+ {
+gchar *rel = g_build_filename (Presets, preset, NULL);
+gchar *abs = findfile (rel);
+
+g_free (rel);
+
+if (abs)
+ {
+if (loadpreset (abs))
+ {
+ret = SELECT_PRESET_LOAD_FAILED;
+ }
+g_free (abs);
+ }
+else
+ {
+ret = SELECT_PRESET_FILE_NOT_FOUND;
+ }
+ }
+return ret;
+}
+
static void applypreset(GtkWidget *w, GtkTreeSelection *selection)
{
GtkTreeIter iter;
@@ -289,19 +320,7 @@
gtk_tree_model_get (model, iter, 0, preset, -1);
- if (strcmp (preset, factory_defaults))
- {
- gchar *rel = g_build_filename (Presets, preset, NULL);
- gchar *abs = findfile (rel);
-
- g_free (rel);
-
- if (abs)
-{
- loadpreset (abs);
- g_free (abs);
-}
- }
+ select_preset(preset);
restorevals ();
--- vanilla/gimp/plug-ins/gimpressionist/gimpressionist.h 2004-05-28
19:36:52.474641632 +0300
+++ gimp/plug-ins/gimpressionist/gimpressionist.h 2004-06-23 15:31:52.672251280
+0300
@@ -182,3 +182,12 @@
void create_sizemap_dialog(void);
double getsiz(double x, double y, int from);
+
+enum SELECT_PRESET_RETURN_VALUES
+{
+SELECT_PRESET_OK = 0,
+SELECT_PRESET_FILE_NOT_FOUND = -1,
+SELECT_PRESET_LOAD_FAILED = -2,
+};
+
+int select_preset(char * preset);
--- vanilla/gimp/plug-ins/gimpressionist/gimp.c 2004-05-28 19:36:52.467642696 +0300
+++ gimp/plug-ins/gimpressionist/gimp.c 2004-06-23 17:36:24.064427024 +0300
@@ -89,6 +89,8 @@
MAIN()
+#define USE_PRESET_PROC_NAME plug_in_gimpressionist_use_preset
+
static void
query(void)
{
@@ -99,6 +101,15 @@
{ GIMP_PDB_DRAWABLE, drawable, Input drawable },
};
+ static GimpParamDef use_preset_args[] =
+ {
+{ GIMP_PDB_INT32,run_mode, Interactive},
+{ GIMP_PDB_IMAGE,image, Input image},
+{ GIMP_PDB_DRAWABLE, drawable, Input drawable },
+{ GIMP_PDB_STRING, preset,Preset Name},
+ };
+
+
gimp_install_procedure (PLUG_IN_NAME,
Performs various artistic operations on an image,
Performs various artistic operations on an image,
@@ -110,6 +121,19 @@
GIMP_PLUGIN,
G_N_ELEMENTS (args), 0,
args, NULL);
+
+ gimp_install_procedure (USE_PRESET_PROC_NAME,
+ Performs various artistic operations on an image using a
preset,
+ Performs various artistic operations on an image using a
preset,
+ Shlomi Fish [EMAIL PROTECTED],
+ Shlomi Fish,
+ v0.2, June 2004,
+ N_(_GIMPressionist by Preset...),
+ RGB*, GRAY*,
+ GIMP_PLUGIN,
+ G_N_ELEMENTS (use_preset_args), 0,
+ use_preset_args, NULL);
+
gimp_plugin_menu_register (PLUG_IN_NAME,
N_(Image/Filters/Artistic));
@@ -132,9 +156,18 @@
static GimpParam values[1];
GimpRunModerun_mode;
GimpPDBStatusType status;
+ gboolean with_specified_preset;
status = GIMP_PDB_SUCCESS;
run_mode = param[0].data.d_int32;
+ if (!strcmp(name, USE_PRESET_PROC_NAME))
+{
+ with_specified_preset = TRUE;
+}
+ else
+{
+ with_specified_preset = FALSE;
+}
values[0].type = GIMP_PDB_STATUS;
values[0].data.d_status = status;
@@ -153,15 +186,27 @@
switch (run_mode)
{
+/*
+ * Note: there's a limitation here. Running this plug-in before the
+ * interactive plug-in was run will cause it
Re: [Gimp-developer] [PATCH] Make Gimpressionist PDB-friendly
Hi, Shlomi Fish [EMAIL PROTECTED] writes: The intent of this patch is to make gimpressionist PDB-friendly. To do so it: 1. Implements the non-interactive running logic. 2. Adds another PDB function, this time accepting a (Gimpressionist) preset to use as an argument. Consider it as a special gift for me just in time for GimpCon. Very nice. Would you mind to open a bug report for this and attach the patch there? That ensures that it isn't forgotten. I will be offline for the next days and I don't expect to find time to apply patches until GIMPCon is over. Sven ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [PATCH] Make Gimpressionist PDB-friendly
On Wednesday 23 June 2004 19:47, Sven Neumann wrote: Hi, Shlomi Fish [EMAIL PROTECTED] writes: The intent of this patch is to make gimpressionist PDB-friendly. To do so it: 1. Implements the non-interactive running logic. 2. Adds another PDB function, this time accepting a (Gimpressionist) preset to use as an argument. Consider it as a special gift for me just in time for GimpCon. Very nice. Would you mind to open a bug report for this and attach the patch there? That ensures that it isn't forgotten. Sure thing. I will be offline for the next days and I don't expect to find time to apply patches until GIMPCon is over. OK. Sven and everyone - enjoy the conference! Regards, Shlomi Fish Sven ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer -- - Shlomi Fish [EMAIL PROTECTED] Homepage:http://shlomif.il.eu.org/ Knuth is not God! It took him two days to build the Roman Empire. ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] preview widgets, wiedermal
Dave Neary wrote: To my knowledge, Ernst (who has written the only preview widget currently out there) won't be at the conference. David Odin will be, though - and he had started working on a preview widget before the 2.0 release, but hasn't had time since then to work on the GIMP. Does this mean that you're going to be in Norway? No, unfortunately. Really my motivation is that I want to add previews to a few plug-ins, and feel like I would be wasting my time if I do it before there is a policy in place. So I am just trying to promote settling this in any way I can. My personal feeling is that it would be best to work from the preview widget developed by Shawn Amundson and Ernst Lippe. It certainly has some issues, but I think they are fixable, and it would be a shame to waste the huge amount of effort Ernst put into it. I've been working with Ernst's code, and can put it into CVS if that would be useful. (It is GPL'ed, and almost follows the Hackordnung. It is also very well documented.) But really I can live with any policy, even one that says that each plug-in should handle previewing on its own. Best, -- Bill __ __ __ __ Sent via the KillerWebMail system at primate.ucdavis.edu __ __ __ __ Sent via the KillerWebMail system at primate.ucdavis.edu ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] preview widgets, wiedermal
Hi Bill, William Skaggs wrote: My personal feeling is that it would be best to work from the preview widget developed by Shawn Amundson and Ernst Lippe. It certainly has some issues, but I think they are fixable, and it would be a shame to waste the huge amount of effort Ernst put into it. I've been working with Ernst's code, and can put it into CVS if that would be useful. I agree with you on this. And currently the blockage to Ernst's code getting committed seems more personality than technical. I'm not sure what Sven thinks of committing this into the main CVS, perhaps you could attach your modified version of Ernst's widget to the relevant bugzilla report, so that we can have a look at it? It would certainly be worth getting the few people who have been working on this (yourself, Geert, David Odin and Ernst) into a virtual room to hammer out any issues... Cheers, Dave. -- David Neary, Lyon, France E-Mail: [EMAIL PROTECTED] ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
Re: [Gimp-developer] preview widgets, wiedermal
Hi, David Neary [EMAIL PROTECTED] writes: My personal feeling is that it would be best to work from the preview widget developed by Shawn Amundson and Ernst Lippe. It certainly has some issues, but I think they are fixable, and it would be a shame to waste the huge amount of effort Ernst put into it. I've been working with Ernst's code, and can put it into CVS if that would be useful. I agree with you on this. And currently the blockage to Ernst's code getting committed seems more personality than technical. My reasons for not liking the API proposed by Ernst are completely technical. After GIMPCon I will certainly find the time to summarize the problems once more. I am sure we can use quite a lot of the work that Ernst has been doing but I don't think the proposed API should be put into CVS as is. After all it's a public API that we will have to live with for quite some time. Sven ___ Gimp-developer mailing list [EMAIL PROTECTED] http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer
