Re: [PR] ARTEMIS-4814 Make direct binding lookup time constant [activemq-artemis]
clebertsuconic commented on PR #4972: URL: https://github.com/apache/activemq-artemis/pull/4972#issuecomment-2163705211 at least the -Ptests testsuite (complete one) ran fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4814 Make direct binding lookup time constant [activemq-artemis]
joshb1050 commented on code in PR #4972:
URL: https://github.com/apache/activemq-artemis/pull/4972#discussion_r1636884171
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/SimpleAddressManager.java:
##
@@ -160,15 +172,7 @@ public Collection getMatchingBindings(final
SimpleString address) throw
@Override
public Collection getDirectBindings(final SimpleString address)
throws Exception {
SimpleString realAddress = CompositeAddress.extractAddressName(address);
- Collection bindings = new ArrayList<>();
-
- nameMap.forEach((bindingUniqueName, bindingAddressPair) -> {
- if (bindingAddressPair.getA().getAddress().equals(realAddress)) {
-bindings.add(bindingAddressPair.getA());
- }
- });
-
- return bindings;
+ return new ArrayList<>(directBindingMap.getOrDefault(realAddress,
Collections.emptyList()));
Review Comment:
It's a copy operation, and works efficiently internally (at least in JDK
17). We could do a null check instead and return a new list if null, but this
has to be a defensive copy since the tests will otherwise fail.
```
public ArrayList(Collection c) {
Object[] a = c.toArray();
if ((size = a.length) != 0) {
if (c.getClass() == ArrayList.class) {
elementData = a;
} else {
elementData = Arrays.copyOf(a, size, Object[].class);
}
} else {
// replace with empty array.
elementData = EMPTY_ELEMENTDATA;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4814 Make direct binding lookup time constant [activemq-artemis]
tabish121 commented on code in PR #4972:
URL: https://github.com/apache/activemq-artemis/pull/4972#discussion_r1636813616
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/SimpleAddressManager.java:
##
@@ -160,15 +172,7 @@ public Collection getMatchingBindings(final
SimpleString address) throw
@Override
public Collection getDirectBindings(final SimpleString address)
throws Exception {
SimpleString realAddress = CompositeAddress.extractAddressName(address);
- Collection bindings = new ArrayList<>();
-
- nameMap.forEach((bindingUniqueName, bindingAddressPair) -> {
- if (bindingAddressPair.getA().getAddress().equals(realAddress)) {
-bindings.add(bindingAddressPair.getA());
- }
- });
-
- return bindings;
+ return new ArrayList<>(directBindingMap.getOrDefault(realAddress,
Collections.emptyList()));
Review Comment:
It seems rather odd to return a new ArrayList that's wrapping a potentially
immutable empty list. This should probably be made a bit smarter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4814 Make direct binding lookup time constant [activemq-artemis]
clebertsuconic commented on PR #4972: URL: https://github.com/apache/activemq-artemis/pull/4972#issuecomment-2163510246 @joshb1050 there's a complete test suite that you can run with -Ptests. The CI in Jenkins runs a limited version of the test suite for basic validation. For more through verification I run the entire test suite but I wouldn't have reousrces for such a long process in the public CI from GitHub. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4814 Make direct binding lookup time constant [activemq-artemis]
joshb1050 commented on PR #4972: URL: https://github.com/apache/activemq-artemis/pull/4972#issuecomment-2163134836 @clebertsuconic I believe I have fixed, though I wasn't able to see all of those test failures when running locally (and it shows me as the CI passing as well). This is needed because each time one connection disconnects, say, with a few thousand consumers, the `TempQueueCleanerUpper` needs to clean each of these up, and it invokes `getDirectBindings` for each—so then this ends up being `O(k * n)` where `k` is the number of queues on the server and `n` is the number of consumers on the connection. It completely stops the server from functioning, and seems to be a blocker for any setup that has a few hundred thousand plus temp queues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4814 Make direct binding lookup time constant [activemq-artemis]
clebertsuconic commented on PR #4972: URL: https://github.com/apache/activemq-artemis/pull/4972#issuecomment-2162952912 Why you need this optimization? are you querying the queue every time you produce? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4814 Make direct binding lookup time constant [activemq-artemis]
clebertsuconic commented on PR #4972: URL: https://github.com/apache/activemq-artemis/pull/4972#issuecomment-2162952102 there are a few test failures: Test / org.apache.activemq.artemis.tests.integration.cli.AddressCommandTest.testForceDeleteAddressWhenExistsQueues Test / org.apache.activemq.artemis.tests.integration.addressing.TwoWaysRemoveAddressTest.testDeadLock Test / org.apache.activemq.artemis.tests.integration.ra.ActiveMQMessageHandlerTest.testSimpleMessageReceivedOnQueueManyMessagesAndInterruptTimeout Test / org.objectweb.jtests.jms.conform.session.TopicSessionTest.testUnsubscribe Test / org.objectweb.jtests.jms.conform.session.TopicSessionTest.testCreateSubscriber_1 Test / org.objectweb.jtests.jms.conform.session.TopicSessionTest.testCreateSubscriber_2 Test / org.objectweb.jtests.jms.conform.session.TopicSessionTest.testDurableSubscriber Test / org.objectweb.jtests.jms.conform.session.TopicSessionTest.testCreateDurableSubscriber_1 Test / org.objectweb.jtests.jms.conform.session.TopicSessionTest.testCreateDurableSubscriber_2 Test / org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateTemporaryTopicOnQueueSession Test / org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateQueueOnTopicSession Test / org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateBrowserOnTopicSession Test / org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testUnsubscribeOnQueueSession Test / org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateTemporaryQueueOnTopicSession Test / org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateDurableSubscriberOnQueueSession Test / org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateDurableConnectionConsumerOnQueueConnection Test / org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateTopicOnQueueSession Test / org.objectweb.jtests.jms.conform.topic.TemporaryTopicTest.testTemporaryTopic Test / org.apache.activemq.artemis.tests.integration.amqp.connect.AMQPFederationAddressPolicyTest.testFederationHandlesAddressDeletedAndConsumerRecreates Test / org.apache.activemq.artemis.tests.integration.amqp.connect.AMQPFederationAddressPolicyTest.testRemoteBrokerClosesFederationReceiverAfterAddressRemoved Test / org.apache.activemq.artemis.tests.integration.cluster.distribution.SimpleSymmetricClusterTest.testDeleteAddress Test / org.apache.activemq.artemis.tests.integration.cluster.distribution.SymmetricClusterWithDiscoveryTest.testStartStopServers Why you need this optimization? Are you constantly querying for the destination on a producer or consumer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4795 enforce queue filter when sending to FQQN [activemq-artemis]
clebertsuconic merged PR #4958: URL: https://github.com/apache/activemq-artemis/pull/4958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4813 Large Message in replication / sync could lose part of the body [activemq-artemis]
clebertsuconic merged PR #4971: URL: https://github.com/apache/activemq-artemis/pull/4971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
joshb1050 commented on PR #18: URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2162027006 @andytaylor Up to you—whichever makes most sense. Thanks for tackling! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4814 Make direct binding lookup time constant [activemq-artemis]
joshb1050 opened a new pull request, #4972: URL: https://github.com/apache/activemq-artemis/pull/4972 Currently, with 500K+ queues, the cleanup step of TempQueueCleanerUpper requires invoking WildcardAddressManager#getDirectBindings, which is O(k) in the number of queues. From method profiling, this can consume up to 95% of our CPU time when needing to clean up many of these. Add a new map to keep track of the direct bindings, and add a test assertion that fails if we don't properly remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4809 Allow configuring intermediateMessageReferences size [activemq-artemis]
joshb1050 commented on PR #4966: URL: https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2161730473 @jbertram thank you—it's strange since I did run `mvn checkstyle:check` and `mvn -Pdev install` and both passed with the checkstyle error. It's also unclear given that `check` passed for 2 of the 3 failures. I have corrected the latest one that I see on CI though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4813 Large Message in replication / sync could lose part of the body [activemq-artemis]
clebertsuconic opened a new pull request, #4971: URL: https://github.com/apache/activemq-artemis/pull/4971 This is a regressio after ARTEMIS-4784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4809 Allow configuring intermediateMessageReferences size [activemq-artemis]
jbertram commented on PR #4966: URL: https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2161671151 For what it's worth you can run checkstyle locally using: ``` mvn -Pdev install ``` See the [hacking guide](https://activemq.apache.org/components/artemis/documentation/hacking-guide/#using-the-dev-profile) for more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4809 Allow configuring intermediateMessageReferences size [activemq-artemis]
joshb1050 commented on PR #4966: URL: https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2161654314 Checkstyle is fixed now as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4809 Allow configuring intermediateMessageReferences size [activemq-artemis]
joshb1050 commented on code in PR #4966:
URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1635514337
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##
@@ -1604,6 +1619,10 @@ public void decode(ActiveMQBuffer buffer, boolean
tryCompatible) {
prefetchPageMessages = BufferHelper.readNullableInteger(buffer);
}
+ if (buffer.readableBytes() > 0) {
+ intermediateMessageBufferInitialSize =
BufferHelper.readNullableInteger(buffer);
+ }
+
Review Comment:
Missed that—done now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4809 Allow configuring intermediateMessageReferences size [activemq-artemis]
joshb1050 commented on code in PR #4966: URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1635514051 ## artemis-server/src/main/resources/schema/artemis-configuration.xsd: ## @@ -4457,6 +4457,15 @@ + Review Comment: This is done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4809 Allow configuring intermediateMessageReferences size [activemq-artemis]
jbertram commented on code in PR #4966: URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1635493471 ## artemis-server/src/main/resources/schema/artemis-configuration.xsd: ## @@ -4457,6 +4457,15 @@ + Review Comment: Specify the default value here as with the other elements (i.e. `8192`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4809 Allow configuring intermediateMessageReferences size [activemq-artemis]
jbertram commented on code in PR #4966: URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1635493471 ## artemis-server/src/main/resources/schema/artemis-configuration.xsd: ## @@ -4457,6 +4457,15 @@ + Review Comment: Specify the default value here as with the other elements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4809 Allow configuring intermediateMessageReferences size [activemq-artemis]
jbertram commented on code in PR #4966:
URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1635492310
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##
@@ -1604,6 +1619,10 @@ public void decode(ActiveMQBuffer buffer, boolean
tryCompatible) {
prefetchPageMessages = BufferHelper.readNullableInteger(buffer);
}
+ if (buffer.readableBytes() > 0) {
+ intermediateMessageBufferInitialSize =
BufferHelper.readNullableInteger(buffer);
+ }
+
Review Comment:
Notice the comment below. This code should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4811 upgrade Netty to 4.1.111.Final [activemq-artemis]
jbertram merged PR #4969: URL: https://github.com/apache/activemq-artemis/pull/4969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4811 upgrade Netty to 4.1.110.Final [activemq-artemis]
jbertram commented on PR #4969: URL: https://github.com/apache/activemq-artemis/pull/4969#issuecomment-2161463400 Actually 4.1.111.Final has already been released so just update your PR and this problem should go away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4811 upgrade Netty to 4.1.110.Final [activemq-artemis]
jbertram commented on PR #4969: URL: https://github.com/apache/activemq-artemis/pull/4969#issuecomment-2161456131 Looks like we may need to wait for 4.1.111.Final in order to get https://github.com/netty/netty/issues/14080. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4812 Avoid IntObject accumulation after Page is set as complete [activemq-artemis]
clebertsuconic merged PR #4970: URL: https://github.com/apache/activemq-artemis/pull/4970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] AMQ-9506: Upgrade to Jackson 2.17.1 [activemq]
jbonofre merged PR #1231: URL: https://github.com/apache/activemq/pull/1231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4812 Avoid IntObject accumulation after Page is set as complete [activemq-artemis]
clebertsuconic opened a new pull request, #4970: URL: https://github.com/apache/activemq-artemis/pull/4970 this could lead to OME if a lazy consumer is there for a long time with all pages being removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] AMQ-9498: Upgrade to xbean 4.25 [activemq]
jbonofre merged PR #1229: URL: https://github.com/apache/activemq/pull/1229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix dead links in activemq classic documentation [activemq-website]
jbonofre merged PR #129: URL: https://github.com/apache/activemq-website/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] Upgrade owasp dependency check [activemq]
jbonofre merged PR #1236: URL: https://github.com/apache/activemq/pull/1236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 add tests & remove refs [activemq-artemis]
tabish121 merged PR #4967: URL: https://github.com/apache/activemq-artemis/pull/4967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4809 Allow configuring intermediateMessageReferences size [activemq-artemis]
joshb1050 commented on PR #4966: URL: https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2159000754 Thanks @jbertram! I have updated my PR to make this configurable on a per-address basis and via XML as well. I have also added tests for the functionality. Please let me know if there is a different approach I should be taking here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4811 upgrade Netty to 4.1.110.Final [activemq-artemis]
ehsavoie opened a new pull request, #4969: URL: https://github.com/apache/activemq-artemis/pull/4969 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4800 simplify QueueConfiguration API [activemq-artemis]
tabish121 merged PR #4964: URL: https://github.com/apache/activemq-artemis/pull/4964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
andytaylor commented on PR #18: URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2158283290 I have made it configurable and this time actually use it, I can reopen this or raise a new PR, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4545 Allow node ID to be configured [activemq-artemis]
gtully commented on PR #4951: URL: https://github.com/apache/activemq-artemis/pull/4951#issuecomment-2158260584 > @gtully Do you know of any current test that demonstrates (or at least includes) having to wait for a lease expiry for the JDBC case? https://github.com/apache/activemq-artemis/blob/362dbd11ac132e66f7bce99eb0fb4aa020346210/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcLeaseLockTest.java#L218 that looks like it should have to wait. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4545 Allow node ID to be configured [activemq-artemis]
AntonRoskvist commented on PR #4951: URL: https://github.com/apache/activemq-artemis/pull/4951#issuecomment-2158137960 @gtully Do you know of any current test that demonstrates (or at least includes) having to wait for a lease expiry for the JDBC case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] NO-JIRA add transformer to bridge properties config test [activemq-artemis]
gtully merged PR #4968: URL: https://github.com/apache/activemq-artemis/pull/4968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] NO-JIRA add transformer to bridge properties config test [activemq-artemis]
gtully opened a new pull request, #4968: URL: https://github.com/apache/activemq-artemis/pull/4968 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] Fix dead links in activemq classic documentation [activemq-website]
gurpartap0306 opened a new pull request, #129: URL: https://github.com/apache/activemq-website/pull/129 This commit fix the dead links in activemq classic documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] NO-JIRA Implement CALL expression in filters [activemq-artemis]
Hathoute commented on PR #4962: URL: https://github.com/apache/activemq-artemis/pull/4962#issuecomment-2156518720 Yes, the loading mecanism should be the same as what's been done for plugins. I just assumed it used reflection to instantiate plugin classes. As for how this should be used, I would say also something similar to plugins; having jars in classpath and a broker config that declares the class names to load. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4809 Allow configuring intermediateMessageReferences size [activemq-artemis]
jbertram commented on PR #4966: URL: https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2155625196 Thanks for the PR! I think this would be better as an address-setting so you could easily configure large swaths of queues. Right now there's no way to configure this via `broker.xml`. It can only be configured if you're directly creating the queue(s) programmatically. Lastly, there's no tests or documentation for this new setting. Tests are mandatory to ensure the functionality works properly and to mitigate future regressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4800 simplify QueueConfiguration API [activemq-artemis]
tabish121 commented on PR #4964: URL: https://github.com/apache/activemq-artemis/pull/4964#issuecomment-2155566464 This looks good,I looked for awhile and didn't see any missed references. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 add tests & remove refs [activemq-artemis]
jbertram commented on PR #4967: URL: https://github.com/apache/activemq-artemis/pull/4967#issuecomment-218579 This is a follow-up from #4959 to address some comments from @gemmellr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4796 add tests & remove refs [activemq-artemis]
jbertram opened a new pull request, #4967: URL: https://github.com/apache/activemq-artemis/pull/4967 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4809 Allow configuring intermediateMessageReferences size [activemq-artemis]
joshb1050 opened a new pull request, #4966: URL: https://github.com/apache/activemq-artemis/pull/4966 In some setups, there could be a few hundred thousand queues that are created due to many consumers that are connecting. However, most of these are empty and stay empty for the entire day since there aren't necessarily messages to be sent. The 8K `intermediateMessageReferences` instantiates an `64KB` buffer (`Object[]`). This means we have large allocation and live heap that ultimately remains empty for almost the entire day. In this commit, we introduce `intermediate-message-buffer-initial-size`, which defaults to the current value of `8192`. It can be set programmatically via `QueueConfiguration#setIntermediateMessageBufferInitialSize(int)`. Note that this must be a power of 2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4545 Allow node ID to be configured [activemq-artemis]
AntonRoskvist commented on PR #4951: URL: https://github.com/apache/activemq-artemis/pull/4951#issuecomment-2155417744 Thanks for your feedback @gtully If I am not mistaken the first case should be addressed already, where the coordination-id takes precedence over the configured nodeID. It should be verified by: `org.apache.activemq.artemis.tests.integration.replication.LockManagerReplicationTest#testPrimaryPeers()` let me know if I misunderstood though. I will take a look at the JDBC case, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] NO-JIRA Implement CALL expression in filters [activemq-artemis]
jbertram commented on PR #4962: URL: https://github.com/apache/activemq-artemis/pull/4962#issuecomment-2155085167 Generally speaking, I'm not opposed to having some sort of pluggable server-side filtering for queues, but I think it would be better to avoid reflection and instead create an interface that is implemented (e.g. as with existing plugins, transformers, etc.). Also, it would be good to have a canonical use-case to help users (and developers) conceptualize how this ability might be used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] NO-JIRA Implement CALL expression in filters [activemq-artemis]
Hathoute closed pull request #4962: NO-JIRA Implement CALL expression in filters URL: https://github.com/apache/activemq-artemis/pull/4962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] NO-JIRA Implement CALL expression in filters [activemq-artemis]
Hathoute commented on PR #4962: URL: https://github.com/apache/activemq-artemis/pull/4962#issuecomment-2155060229 For future people interested in this feature, you can hack? your way using just plugins. I'll close the MR for now, but I will be happy to continue discussing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] NO-JIRA Implement CALL expression in filters [activemq-artemis]
Hathoute commented on PR #4962: URL: https://github.com/apache/activemq-artemis/pull/4962#issuecomment-2155041259 I do agree that this could be a bad idea, that's why I tried discussing it in the users mailbox. This PR is just an attempt I did before starting the discussion. I believe it is the responsibility of the broker admin to verify that a custom filter is trusted before adding it, just like plugins, with the only difference that filters can receive external user input. Now if the filter does not correctly validate its input, that's another issue... Also, existing filters (XPath for example) can also have a performance impact if not used correctly, yet any user is allowed to use them. Again, I agree it might not be a good idea to move forward if we are not being extremely careful with the implementation, and perfectly implementing this will probably take too much effort, which in the end won't be worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4798 Use original message to calculate the Mirror SNF size in calculations [activemq-artemis]
clebertsuconic merged PR #4961: URL: https://github.com/apache/activemq-artemis/pull/4961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4305 Zero persistence does not work in kubernetes [activemq-artemis]
jbertram commented on PR #4899: URL: https://github.com/apache/activemq-artemis/pull/4899#issuecomment-2155033417 I believe the use-case here only involves cluster nodes and the core connections between them. Therefore, I don't think AMQP is in view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4305 Zero persistence does not work in kubernetes [activemq-artemis]
clebertsuconic commented on PR #4899: URL: https://github.com/apache/activemq-artemis/pull/4899#issuecomment-2155022268 If this is an issue in Core, it will be an issue in AMQP as well. we should make sure AMQP also takes care of this? WDYT @jbertram @gemmellr @gtully @tabish121 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4802 - Fixing the use of depricating tags master,slave,check-… [activemq-artemis-examples]
gemmellr closed pull request #10: ARTEMIS-4802 - Fixing the use of depricating tags master,slave,check-… URL: https://github.com/apache/activemq-artemis-examples/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4802 - Fixing the use of depricating tags master,slave,check-… [activemq-artemis-examples]
gemmellr commented on PR #10: URL: https://github.com/apache/activemq-artemis-examples/pull/10#issuecomment-2155016832 I rebased your changes to the _development_ branch as per [CONTRIBUTING.md](https://github.com/apache/activemq-artemis-examples/blob/main/CONTRIBUTING.md), and I dropped the readme change as I'll make a general improvement around that separately). Pushed in https://github.com/apache/activemq-artemis-examples/commit/b8662f9a29d0579249d0239fd79f93fe4be99139. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4305 Zero persistence does not work in kubernetes [activemq-artemis]
iiliev2 commented on code in PR #4899:
URL: https://github.com/apache/activemq-artemis/pull/4899#discussion_r1631317798
##
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java:
##
@@ -421,6 +434,34 @@ private void doBufferReceived(final Packet packet) {
}
}
+ private boolean isCorrectPing(Packet packet) {
+ if (packet.getType() != PING) {
+ return true;
Review Comment:
Commenting this line out will effectively disable the fix. This will cause
the new test `ZeroPersistenceSymmetricalClusterTest` to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4305 Zero persistence does not work in kubernetes [activemq-artemis]
iiliev2 commented on code in PR #4899:
URL: https://github.com/apache/activemq-artemis/pull/4899#discussion_r1631319204
##
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java:
##
@@ -408,10 +416,15 @@ public void endOfBatch(Object connectionID) {
}
private void doBufferReceived(final Packet packet) {
+ if (isHealthy && !isCorrectPing(packet)) {
+ isHealthy = false;
Review Comment:
Commenting this line out will effectively disable the fix. This will cause
the new test `ZeroPersistenceSymmetricalClusterTest` to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4305 Zero persistence does not work in kubernetes [activemq-artemis]
iiliev2 commented on code in PR #4899:
URL: https://github.com/apache/activemq-artemis/pull/4899#discussion_r1631317798
##
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java:
##
@@ -421,6 +434,34 @@ private void doBufferReceived(final Packet packet) {
}
}
+ private boolean isCorrectPing(Packet packet) {
+ if (packet.getType() != PING) {
+ return true;
Review Comment:
Commenting this line out will effectively disable the fix. This will cause
the new test `ZeroPersistenceSymmetricalClusterTest` to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] NO-JIRA Implement CALL expression in filters [activemq-artemis]
clebertsuconic commented on PR #4962: URL: https://github.com/apache/activemq-artemis/pull/4962#issuecomment-2154974856 This is definitely not a good thing IMO. it's already difficult to manage situations where the broker by itself has had issues in the past, now having the user being able to call stuff.. makes things even worse. Say you filter Queue.messageCounter() on the filter...now you have a deadlock, starvation , performance issue... and there's no way to control or debug what is going on. Even worse this is difficult to support and has security concerns. I feel bad you made a very complex implementation on this.. but testing something like this gets even bigger and opens space for more problems in the end. I'm not sure how we would manage this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4797 Destroy Netty connection if exception and inactive [activemq-artemis]
joshb1050 commented on PR #4960: URL: https://github.com/apache/activemq-artemis/pull/4960#issuecomment-2154967424 @gemmellr That's possible...though I don't know how else to handle this. The `connectionDestroyed` listener needs to be called for these but they aren't, and we leak memory in the case where the exception callback is called first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] NO-JIRA Implement CALL expression in filters [activemq-artemis]
gemmellr commented on PR #4962: URL: https://github.com/apache/activemq-artemis/pull/4962#issuecomment-2154948134 Possibly, though then another concern might be around which users are allowed to use which methods, depending on what they do...then also what are allowed/safe arguments to those methods, depending on what they do. In all I still don't think this is a great idea to add, as presented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4797 Destroy Netty connection if exception and inactive [activemq-artemis]
gemmellr commented on PR #4960: URL: https://github.com/apache/activemq-artemis/pull/4960#issuecomment-2154908286 Your Jira and PR comments are aimed at Acceptor behaviour, and you note on the Jira that you are using Openwire clients...however the changed bits are also used by the Artemis Core client. I'm not familiar with this code, but it seems to me like the change could result in the connectionDestroyed listener callback being called for clients when it wouldnt currently be, after the connectionException listener callback could already have been called, potentially causing a double-failover or other weirdness? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
gemmellr commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2154566142 Same general review comment as last time. There are still several references to toSimpleString (outside compatibility tests). There is now-unused deprecated stuff that isn't tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4799 Fix broker connection receiver attach handling [activemq-artemis]
gemmellr merged PR #4963: URL: https://github.com/apache/activemq-artemis/pull/4963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4802 - Fixing the use of depricating tags master,slave,check-… [activemq-artemis-examples]
susinda opened a new pull request, #10: URL: https://github.com/apache/activemq-artemis-examples/pull/10 Fixing the use of deprecating tags master, slave, check-for-live-server in ha/replicated-failback sample with their new values primary, backup and check-for-active-server -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4801 Fix issue with caching address query results [activemq-artemis]
clebertsuconic merged PR #4965: URL: https://github.com/apache/activemq-artemis/pull/4965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4801 Fix issue with caching address query results [activemq-artemis]
tabish121 opened a new pull request, #4965: URL: https://github.com/apache/activemq-artemis/pull/4965 When caching address query results the remote session can be blocked forever from creating links on an address if the "does not exist" value is cached since it is never updated again and will always report "does not exist" even if the address is added manually via management later. The cache state can cause other issues for long running sessions as well and should be removed to avoid attach failures for cases where the current broker state could allow the attach to succeed but the cached entry won't allow it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4800 simplify QueueConfiguration API [activemq-artemis]
jbertram opened a new pull request, #4964: URL: https://github.com/apache/activemq-artemis/pull/4964 This commit does the following: - deprecate all QueueConfiguration ctors - add `of` static factory methods for all the deprecated ctors - replace any uses of the normal ctors with the `of` counterparts This makes the code more concise and readable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4799 Fix broker connection receiver attach handling [activemq-artemis]
tabish121 opened a new pull request, #4963: URL: https://github.com/apache/activemq-artemis/pull/4963 The receiver attach in broker connection does not wait for the remote attach to arrive before creating the broker side receiver plumbing which leads to the broker treating the remote sender as an anonymous relay when it is not and should not be. Await the remote attach in response to the attach sent by the broker connection to finish the link setup but use the locally defined target address vs the remote to route the incoming messages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-3686: Adding example showing how to do telemetry support [activemq-artemis]
svanschalkwyk commented on PR #3895: URL: https://github.com/apache/activemq-artemis/pull/3895#issuecomment-2152905592 Is there an example of this working? Should a specific plugin be installed for this to work? using Docker with image:apache/activemq-artemis:2.33.0 I have ` OTEL_SERVICE_NAME: activemq-service OTEL_TRACES_EXPORTER: otlp OTEL_METRICS_EXPORTER: otlp OTEL_LOGS_EXPORTER: none OTEL_EXPORTER_OTLP_ENDPOINT: http://otel-collector:4317 OTEL_EXPORTER_OTLP_TRACES_ENDPOINT: http://otel-collector:4317` No issues in startup (missing jars etc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] NO-JIRA Implement CALL expression in filters [activemq-artemis]
Hathoute commented on PR #4962: URL: https://github.com/apache/activemq-artemis/pull/4962#issuecomment-2152883116 Can't we mitigate this risk by having a config where we map a function name to the factory method, and validate methods at broker startup? I'm thinking of some sort of whitelist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
clebertsuconic commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2152869890 lets merge and review? otherwise you will keep rebasing forever -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
clebertsuconic merged PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
jbertram commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2152810047 I rebased and changed as many of the remaining references to deprecated methods that I could. There are a handful of references to deprecated methods in the compatibility tests, but those must remain due to the fact that those tests are actually using older versions that don't have the new methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] NO-JIRA Implement CALL expression in filters [activemq-artemis]
gemmellr commented on PR #4962: URL: https://github.com/apache/activemq-artemis/pull/4962#issuecomment-2152766079 It doesnt seem like a good idea to me to add something like this to the broker, it is a runtime-user-input-configurable RCE mechanism. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
gemmellr commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2151907691 The change should probably be rebased to current main, which has already added new use of the now-deprecated bits that this misses switching over. From doing a grep, there also looks to remain a number of other existing uses of toSimpleString that perhaps should be updated also. Feels like we should be unit testing any otherwise-unused deprecated bits, but it doesnt appear like either of the two SimpleStringTest classes do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] NO-JIRA Implement CALL expression in filters [activemq-artemis]
Hathoute opened a new pull request, #4962: URL: https://github.com/apache/activemq-artemis/pull/4962 An attempt to implement custom filters by using keyword CALL, as discussed in the [users mailbox](https://lists.apache.org/thread/8nfk874zf87jg1hrjn8m78x1kdt0j58n) This PR is not intended to be merged, and only serves to discuss this feature request and potentially identify implementation details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4798 Use original message to calculate the Mirror SNF size in calculations [activemq-artemis]
clebertsuconic commented on PR #4961: URL: https://github.com/apache/activemq-artemis/pull/4961#issuecomment-2151129118 there is a test failure I need to investigate.. a negative counter in the address size on BrokerInSyncTest::testLVQ there could be something else in there.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
clebertsuconic commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150845722 We can merge it I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
jbertram commented on code in PR #4959:
URL: https://github.com/apache/activemq-artemis/pull/4959#discussion_r1628281605
##
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java:
##
@@ -56,20 +56,37 @@ public final class SimpleString implements CharSequence,
Serializable, Comparabl
* @param string String used to instantiate a SimpleString.
* @return A new SimpleString
*/
- public static SimpleString toSimpleString(final String string) {
+ public static SimpleString of(final String string) {
if (string == null) {
return null;
}
return new SimpleString(string);
}
- public static SimpleString toSimpleString(final String string,
StringSimpleStringPool pool) {
+ public static SimpleString of(final String string, StringSimpleStringPool
pool) {
if (pool == null) {
- return toSimpleString(string);
+ return of(string);
}
return pool.getOrCreate(string);
}
+ public static SimpleString of(final byte[] data) {
+ return new SimpleString(data);
+ }
+
+ public static SimpleString of(final char c) {
+ return new SimpleString(c);
+ }
+
+ @Deprecated(forRemoval = true)
+ public static SimpleString toSimpleString(final String string) {
+ return of(string);
+ }
+
+ @Deprecated(forRemoval = true)
+ public static SimpleString toSimpleString(final String string,
StringSimpleStringPool pool) {
+ return of(string, pool);
+ }
Review Comment:
I fleshed out the JavaDoc on both the old and new methods as well as
deprecating the constructors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
jbertram commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150671313 That said, if we can remove `SimpleString` completely I'm good with that too. Of course, this PR is not mutually exclusive with that objective. Consider it a stop-gap on the way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
jbertram commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150668986 As far as I'm aware, the "of" naming convention was introduced in 2008 in the second edition of Joshua Block's _Effective Java_. He identified it as a way to draw attention to static factories and adhere to common naming conventions. It is a more concise version of `valueOf` which is also used prolifically throughout the Java API. It's an industry standard at this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
tabish121 commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150593808 > > I don't really like the name "of" but that's just my personal taste probably... (of kind of kicks my OCD.. being a preposition, I feel like of what? :) > > but as I said.. that's my personal preference only... > > but I don't want to get in the way.. I will get used to it :) and I'm +1 to merge it.. and you should probably merge it soon before you have to rebase it. > > +1 from me. > > I presume it comes from the trend of Map.of(..) etc factory helpers. I dont mind it, though I personally wouldnt have changed it here given I'd rather SimpleString vanish, along with all the realted conversions and the byte doubling etc etc that come with it. Agreed with Robbie on the name, it matches some Collections APIs etc and isn't hard to grok plus its just less verbose. But I'd also like to see an effort towards removing the SimpleString to simplify working with the broker internals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
gemmellr commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150579148 > I don't really like the name "of" but that's just my personal taste probably... (of kind of kicks my OCD.. being a preposition, I feel like of what? :) > > but as I said.. that's my personal preference only... > > but I don't want to get in the way.. I will get used to it :) and I'm +1 to merge it.. and you should probably merge it soon before you have to rebase it. > > +1 from me. I presume it comes from the trend of Map.of(..) etc factory helpers. I dont mind it, though I personally wouldnt have changed it here given I'd rather SimpleString vanish, along with all the realted conversions and the byte doubling etc etc that come with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
clebertsuconic commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150554643 I don't really like the name "of" but that's just my personal taste probably... (of kind of kicks my OCD.. being a preposition, I feel like of what? :) but as I said.. that's my personal preference only... but I don't want to get in the way.. I will get used to it :) and I'm +1 to merge it.. and you should probably merge it soon before you have to rebase it. +1 from me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
clebertsuconic commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150545961 I wouldn't mind seeing SimpleString gone. Change the packets in Core to send char[] ... and be gone! But that would require a lot of testing.. especially around the pools on reading? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4798 Use original message to calculate the Mirror SNF size in calculations [activemq-artemis]
clebertsuconic opened a new pull request, #4961: URL: https://github.com/apache/activemq-artemis/pull/4961 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4797 Destroy Netty connection if exception and inactive [activemq-artemis]
joshb1050 commented on PR #4960: URL: https://github.com/apache/activemq-artemis/pull/4960#issuecomment-2150387876 I am running this swapped into the environment in which this was originally detected and it has not appeared to leak any memory so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[PR] ARTEMIS-4797 Destroy Netty connection if exception and inactive [activemq-artemis]
joshb1050 opened a new pull request, #4960: URL: https://github.com/apache/activemq-artemis/pull/4960 If an exception is caught before the channel is deemed inactive, the reference to the Netty connection will not get destroyed and will leak memory in `NettyAcceptor`. This commit adds a flag when an exception is encountered so that the connection is still destroyed in this case when the channel becomes inactive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
joshb1050 commented on PR #18: URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2150302868 The tricky piece of this is the WAR is provided separately and so we have to run a custom shader to shade it. However it doesn't rewrite the JMX domain as part of the shading process as it's just a string in a TS file. I think what's unexpected is the JMXDomain is configurable as one says but the console doesn't pick up on it, hence the confusion. Custom compilation does work changing the hardcoded value and we could do that if that's the best approach forward. Thanks for looking at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
gemmellr commented on PR #18: URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2150011256 Well, from the JIRA I think it actually _is_ configurable on the broker (unclear why)...but seems like either noone has ever used that, or used it together with the console at the same time, or changed the console to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
andytaylor commented on PR #18: URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2149772044 For some reason I thought the domain was configurable so I think I agree. I will close this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
andytaylor closed pull request #18: ARTEMIS-4780 - Allow JMX Domain to be discoverable URL: https://github.com/apache/activemq-artemis-console/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4780 - Allow JMX Domain to be discoverable [activemq-artemis-console]
gemmellr commented on PR #18: URL: https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2149643584 This feels off. The whole point of the domain in the object name is to avoid clashing, as some other component could easily have broker= in its mbean names. I see from JIRA that this is coming up due to shading the broker. Presumably the console bits should be shaded too in that case? Is there a way the value could be taken from a file, such that shading it could [be made to] update that also? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4545 Allow node ID to be configured [activemq-artemis]
gtully commented on PR #4951: URL: https://github.com/apache/activemq-artemis/pull/4951#issuecomment-2149588357 Another use case is jdbc, it currently uses a new uuid as the node id, it too could benefit from a shared identity, allowing a restart/reconnect of an existing lock owner to retain a valid lease. At the moment, any restart results in a a full lease expiry because the node id is not consistent. If the nodeid is configured through this logic then we can avoid the change https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcNodeManager.java#L70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
gemmellr commented on PR #4959: URL: https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2149585374 Bigger 'SimpleString API simplication': deletion? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4796 simplify SimpleString API [activemq-artemis]
gemmellr commented on code in PR #4959:
URL: https://github.com/apache/activemq-artemis/pull/4959#discussion_r1627254132
##
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java:
##
@@ -56,20 +56,37 @@ public final class SimpleString implements CharSequence,
Serializable, Comparabl
* @param string String used to instantiate a SimpleString.
* @return A new SimpleString
*/
- public static SimpleString toSimpleString(final String string) {
+ public static SimpleString of(final String string) {
if (string == null) {
return null;
}
return new SimpleString(string);
}
- public static SimpleString toSimpleString(final String string,
StringSimpleStringPool pool) {
+ public static SimpleString of(final String string, StringSimpleStringPool
pool) {
if (pool == null) {
- return toSimpleString(string);
+ return of(string);
}
return pool.getOrCreate(string);
}
+ public static SimpleString of(final byte[] data) {
+ return new SimpleString(data);
+ }
+
+ public static SimpleString of(final char c) {
+ return new SimpleString(c);
+ }
+
+ @Deprecated(forRemoval = true)
+ public static SimpleString toSimpleString(final String string) {
+ return of(string);
+ }
+
+ @Deprecated(forRemoval = true)
+ public static SimpleString toSimpleString(final String string,
StringSimpleStringPool pool) {
+ return of(string, pool);
+ }
Review Comment:
In this type of change its typical to have javadoc @ deprecated as well,
indicating the replacement that should be used instead. E.g here the
constructor is not deprecated (related question: should it also be?), so
someone might notice the deprecation and switch to the constructor instead
rather than the new 'of'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4545 Allow node ID to be configured [activemq-artemis]
gtully commented on PR #4951: URL: https://github.com/apache/activemq-artemis/pull/4951#issuecomment-2149567599 Have you seen: https://github.com/apache/activemq-artemis/blob/576622571a839720d83d800b12a7f2b2448b30d9/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationPrimaryActivation.java#L171 with the zk locker we can have peer brokers that coordinate on a shared node id. it is called the coordinator-id in the zk activation config, but ends up as the node-id. With the potential for unknown backups with replication, the node id has to be reset. However this new config could make it simpler for pure peers, where there is no replication b/c the it is non persistent or uses a shared store. I guess we need to allow these to coexist or document that they must be used independently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4702 only run command needs custom JVM settings [activemq-artemis]
gtully commented on code in PR #4885:
URL: https://github.com/apache/activemq-artemis/pull/4885#discussion_r1627495954
##
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile:
##
@@ -36,7 +36,7 @@ ARTEMIS_INSTANCE_ETC_URI='${artemis.instance.etc.uri}'
HAWTIO_ROLE='${role}'
# Java Opts
-if [ -z "$JAVA_ARGS" ]; then
+if [ -z "$JAVA_ARGS" ] && [ "$1" = "run" ]; then
Review Comment:
There is a related problem with the log4j2 config, see:
https://issues.apache.org/jira/browse/ARTEMIS-4785
in that case, we need to keep the logging just for the broker run and not
for any other command. the comment on that jira has lots of good info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4760 creating MQTT consumer should work if auto-create-queues is false [activemq-artemis]
gemmellr merged PR #4955: URL: https://github.com/apache/activemq-artemis/pull/4955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
