Re: Sporadic errors during compilation, Checking type argument 0 of type 'java.util.Arrays.ArrayList, no default constructor.
Finally I find the solution!
In my dto I declared a property of type class X in which I declared an enum
in this manner:
public enum Type {
SHORT (S),
MEDIUM (M),
LONG (L);
private String code;
private Type(String code) {
this.code = code;
}
public String getCode() {
return code;
}
}
When I replaced the enum with constants all the strange behaviors of the
gwt rpc generator disappeared.
I dit not test more in depth to find the right declaration of the enum, but
now I know that this was the cause.
I could only point out to the GWT team that maybe it would be better to
improve the error messages to help the developer to find the right field
not compliant to the serialization policies.
Best regards
Marcello De Marco
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Static files not deploying to appspot
I have a gwt app that contains some static image files. I put them under war/img and everything works fine locally. I'm using Eclipse and use the deploy command to move everything over to the appspot server for deployment. However, after I deploy the app to the appspot server in Eclipse, I get an error that the img directory doesn't exist. It doesn't seem like it's being copied over. I would do this manually if I could, but I don't know how to access appspot aside from the deploy command. I asked this a few days ago and didn't get a response. Is there a better forum to ask this question? How would I pursue this with Google? Thanks! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: XMLParser Problems
Hi Andy: Thanks for the post above. I did not see this the other day. you need to ask the child for the next sibling not the parent. node = node.getNextSibling(); By the way, the Totoe project using xpath works nicely. It take some to get to know how to use it. On Wednesday, March 20, 2013 11:24:23 AM UTC-5, Andy King wrote: I don't know of any way to use XPath against the GWT XML library, but that's not to say that you can't do so. In my work with it I just walk through the Document object and extract the elements and attributes into my own structure. If you know the structure of your XML ahead of time then this is really very easy. Andy -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Static files not deploying to appspot
There's a forum dedicated to the Google Plugin for Eclipse: https://groups.google.com/d/forum/google-plugin-eclipse though they'd tell you there to use StackOverflow. Or, as it's an issue with AppEngine (not GWT proper), maybe ask on the AppEngine group https://groups.google.com/forum/#!forum/google-appengine, or again StackOverflow (this is the official channel, per https://developers.google.com/appengine/community) On Thursday, March 28, 2013 4:47:48 PM UTC+1, Dan Schreiber wrote: I have a gwt app that contains some static image files. I put them under war/img and everything works fine locally. I'm using Eclipse and use the deploy command to move everything over to the appspot server for deployment. However, after I deploy the app to the appspot server in Eclipse, I get an error that the img directory doesn't exist. It doesn't seem like it's being copied over. I would do this manually if I could, but I don't know how to access appspot aside from the deploy command. I asked this a few days ago and didn't get a response. Is there a better forum to ask this question? How would I pursue this with Google? Thanks! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Diagnose GWT DMP Plugin crashes on Chrome
No luck. Just ran into this again. Restarting Chrome, again, fixed it. On Wednesday, March 27, 2013 2:28:50 PM UTC-4, Michael Prentice wrote: OK, I'll give that a shot with: *-XX:MaxPermSize=384m* Thanks a lot. On Wednesday, March 27, 2013 10:03:08 AM UTC-4, xsee wrote: Try setting your maxPermSize in the VM args section of your launch config (mine is at 384). This keeps my Chrome plugin running all day with no problems on a medium sized project. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
choix d'une API GWT
bonjour tous le monde je voudrai créer une interface web en utilisant GWT, et je suis entrain de rechercher une API qui me permet de construire une interface qui donne la main à un utilisateur à l'aide d'un panel de widget qui sera afficher de dessiner un graphe qui simule un reseau (principe drag and drop des composants reseau) merci de me proposer une API et de m'aider ça fait plus que deux semaines que je fait les recherches mais je n'ai rien récolter n'importe quel type d'aide peut m'aider dans mon stage de pfe. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: PlaceController constructor Deprecated
use com.google.web.bindery.event.shared.EventBus to avoid Depricated API
http://www.techiesinfo.com
On Friday, September 9, 2011 5:16:17 AM UTC-7, Fabricio Pizzichillo wrote:
Hello friends.
I use GIN to implement dependency injection.
I upgraded to version 2.4.0 and I encounter a problem when I bind (
EventBus.class).To (SimpleEventBus.class). In (Singleton.class);
The log says Deferred binding result type '
com.google.gwt.event.shared.EventBus' should not be abstract
This happens when I change the imported packages of import
com.google.gwt.event.shared.EventBus;
com.google.gwt.event.shared.SimpleEventBus import, to import
com.google.web.bindery.event.shared.EventBus;
import com.google.web.bindery.event.shared.SimpleEventBus;.
I made this change because the constructor of the class PlaceController
is deprecated
@ Deprecated
public PlaceController (com.google.gwt.event.shared.EventBus eventBus)
{
this ((EventBus) eventBus);
}
Any idea how to solve it?
Thanks and greetings!
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Login + CRUD example
Hi folks, After lots and lots of research, I haven't found any good example of a gwt application with a login module + crud module. I've followed the basic gwt examples but I wasn't able to convert it to a more complex application, like a one with login + crud modules. Do you know where or how can I find some gwt source example of a login module + crud module with JSON? Thanks in advance. Best regards. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: eclipse 4.2
I had the same problem. That installer seems to be for Android developers. But I found a zip on https://developers.google.com/eclipse/docs/install-from-zip which worked fine. Hope that helps! :-) On Thursday, 7 March 2013 02:12:39 UTC+1, Elaine Toscano wrote: When I install GWT on eclipse 4.2 I do not get the blue *Web Application Project *button.* *Or the New menu item for the same.* *How do I verify my install on 4.2? thanks ET.* * -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
new version of Closure Compiler
Hi, Is it possible to integrate the latest version of Closure Compiler into GWT compiler. The existing one constantly crashing with Internal compiler error while it optimize our project. or Is there a way to test the latest version of the Closure Compiler with GWT output of our project. Thanks -Kirill -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Can't deploy my project anymore
I am having the same problem (stack trace below). I am using JDK 1.6.0_43, and I have deleted the gwt-unitCache folder. This is my first GWT application and the first time I am trying to deploy, so I do not have a build.xml file to execute. Please help!!! Plug-in Provider: Google Plug-in Name: Plug-in ID: org.eclipse java.lang.NoClassDefFoundError: org/eclipse/jdt/launching/IJavaLaunchConfigurationConstants at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.getGWTProjectClasspath(DeployModuleAction.java:364) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.createBuildScript(DeployModuleAction.java:150) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.access$1(DeployModuleAction.java:131) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction$1.run(DeployModuleAction.java:103) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121) Full stack trace (to see full context): java.lang.reflect.InvocationTargetException at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction$1.run(DeployModuleAction.java:114) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121) Caused by: java.lang.NoClassDefFoundError: org/eclipse/jdt/launching/IJavaLaunchConfigurationConstants at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.getGWTProjectClasspath(DeployModuleAction.java:364) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.createBuildScript(DeployModuleAction.java:150) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.access$1(DeployModuleAction.java:131) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction$1.run(DeployModuleAction.java:103) ... 1 more On Wednesday, 20 March 2013 18:12:36 UTC+1, JoyaleXandre wrote: Yes, I removed the gwt-cache folder. I managed to compile my war file by executing the build.xml ant file manually. But I liked more when the deploy button was generating the xml for me. Now, I need to update it manually. Le mercredi 20 mars 2013 13:06:24 UTC-4, Juan Pablo Gardella a écrit : Did you remove gwt-cache directories? 2013/3/20 Juan Carlos Aranda aran...@gmail.com Do you fix the problem??? I have the same problem and not find the solution. I install Eclipse, Gwt plugin and Designer. Now my app not deploy. Saludos. Thanks. El lunes, 18 de marzo de 2013 14:38:02 UTC-6, JoyaleXandre escribió: Hi everybody, Since friday I can't deploy my project anymore. Went I start the war generation with the deploy button I instantly get an error *message saying*: Designer error occured. Select Details for more information. See the Error Log for more information. Reason: Parse error or internal Designer error, *The stack trace is this: * Plug-in Provider: Google Plug-in Name: Plug-in ID: org.eclipse java.lang.**NoClassDefFoundError: org/eclipse/jdt/launching/** IJavaLaunchConfigurationConsta**nts at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.**getGWTProjectClasspath(** DeployModuleAction.java:364) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.**createBuildScript(**DeployModuleAction.java:150) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.access$1(**DeployModuleAction.java:131) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction$1.run(**DeployModuleAction.java:103) at org.eclipse.jface.operation.**ModalContext$** ModalContextThread.run(**ModalContext.java:121) Full stack trace (to see full context): java.lang.reflect.**InvocationTargetException at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction$1.run(**DeployModuleAction.java:114) at org.eclipse.jface.operation.**ModalContext$** ModalContextThread.run(**ModalContext.java:121) Caused by: java.lang.**NoClassDefFoundError: org/eclipse/jdt/launching/ **IJavaLaunchConfigurationConsta**nts at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.**getGWTProjectClasspath(** DeployModuleAction.java:364) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.**createBuildScript(**DeployModuleAction.java:150) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.access$1(**DeployModuleAction.java:131) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction$1.run(**DeployModuleAction.java:103) ... 1 more I completely uninstalled the Google Plugin and reinstalled it. I still get this error. My last chance is probably to reinstall Eclipse from scratch, but I would like to avoid reinstalling and configuring all my dev envirronnement. Can somebody help me please. Am I the only one who got this problem since I tried to update the Google Plugin? --
Re: CellTable - Adding a Button to a Column
FYI DocumentDetailsDTO is not a GWT type, it is a data object defined by the person who wrote the application. That is, it is a ListDataProvider: http://google-web-toolkit.googlecode.com/svn/javadoc/latest/com/google/gwt/view/client/ListDataProvider.html On Tuesday, January 22, 2013 6:50:29 AM UTC-5, jabir ahmed wrote: Why does it say DocumentDetailsDTO cannot be resolved to a type is DocumentDetailsDTO deprecated or removed in gwt2.5.0 SDK? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: What is current state/fix of/for deprecated PlaceController constructor
use com.google.web.bindery.event.shared.EventBus to avoid Depricated API http://www.techiesinfo.com On Tuesday, November 8, 2011 1:13:31 AM UTC-8, tanteanni wrote: I just updated to gwt 2.4 - to get the data grid (very nice). but no my PlaceController construction is deprecated. I read around here but can't find a good solution for this issuehttp://code.google.com/p/google-web-toolkit/issues/detail?id=6653. (is it even an issue?): if i update my PlaceController construction (in GinModule), all Activity's start()-methods start to cry (they wan't the old EventBus). They get their EventBus via ActivityManager, but the ActivityManagers are also constructed with new EventBus. So it seems it's a Problem of AbstractActivity isn't it? For he Moment i have decided to keep the deprecated constructor (good idea?). But what would be the long term solution for this? Will there be a fix? Or is there already a fix? thx in advance -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT 2.5 dev mode unable to refresh
Before reloading, just simply clear the browser's cookies, it'll happen every times. 在 2013年2月26日星期二UTC+8上午7时55分53秒，Craig Mitchell写道： I've noticed this error when our app opens a new browser window that loads the GWT app up again (not seen the error when refreshing). Happens in IE9 and Chrome. However, if I just restart my server and then refresh the page, it will then work okay. And even more strangely, sometimes the problem doesn't occur at all for days, then it will come back again. I was trying to figure out if it is because of the generated war/your app/*.rpc files, but so far no success. On Wednesday, 5 December 2012 07:21:24 UTC+11, Ben St. Pierre wrote: No ideas? On Tuesday, November 13, 2012 4:52:03 PM UTC-7, Ben St. Pierre wrote: Hi guys, After upgrading to to GWT 2.5 I am unable to refresh my dev mode. It initially loads fine but reloading (in any browser causes the rpc mechanism to throw this error... Caused by: com.google.gwt.user.client.rpc.SerializationException: java.lang.RuntimeException: Unable to find class com.google.gwt.user.client.rpc.core.java.util.ArrayList_FieldSerializer Any idea what would cause this? As I said again it loads the first time in dev mode but then fails after a refresh (even with no code changes). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
validateOnly gwt compile
Hey, I looked at the validateOnly compiler option in GWT and i dont see a whole lot of information on what this actually does on the web. The GWT documentation says the below -validateOnly Validate all source code, but do not compile Does this mean that if ValidateOnly compile succeeds then the normal compile is *guaranteed *to succeed? (with regards to memory and finding any issues that GWT compile would) Is there any information on this option? a article/paper or something? Thanks!! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: JAXB GWT How I can use JAXB generated classes on client side
Hi man, Sorry for the later answer. You have this exception because Gwt Compiler try to find these classes in your Module.gwt.xml. Example : source path=client/ (folder client) When you have generated your classes with you file XSD, a class ObjectFactory.java was also generated, and this class use : javax.xml.namespace.QName ; javax.xml.bind.JAXBElementT If your ObjectFactory.java is in the folder client, when GWT Compiler try to build, you have this exception ! So the answer is to put your ObjectFactory.java in a folder who is not referenced in you Module.gwt.xml, in my example not in the folder client, more like server because I have only this folder referenced in Module.gwt.xml. The Second answer is you cant use ObjectFactory.java in the client side, because of this ! Best regards. Le mercredi 14 juillet 2010 17:29:16 UTC+2, Alberto Rugnone a écrit : Hi all, I have to use classes with jaxb annotation on client side, but GWT compiler refuse to work throwing following exception No source code is available for type javax.xml.namespace.QName No source code is available for type javax.xml.bind.JAXBElementT etc... someone can help me Thank you very much in advanced -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: choix d'une API GWT
Hi, take a look at gwt-dnd : http://code.google.com/p/gwt-dnd/ You should send your questions in english. --- Si tu veux des réponses tu devrais envoyer tes questions en anglais. Regards. 2013/3/28 Ksouri Chaouki chaoukikso...@gmail.com bonjour tous le monde je voudrai créer une interface web en utilisant GWT, et je suis entrain de rechercher une API qui me permet de construire une interface qui donne la main à un utilisateur à l'aide d'un panel de widget qui sera afficher de dessiner un graphe qui simule un reseau (principe drag and drop des composants reseau) merci de me proposer une API et de m'aider ça fait plus que deux semaines que je fait les recherches mais je n'ai rien récolter n'importe quel type d'aide peut m'aider dans mon stage de pfe. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Login + CRUD example
It's old, but you can see https://groups.google.com/forum/?fromgroups#!topic/google-web-toolkit/fkbowz5-5do 2013/3/26 Robson Braga robsonselze...@gmail.com Hi folks, After lots and lots of research, I haven't found any good example of a gwt application with a login module + crud module. I've followed the basic gwt examples but I wasn't able to convert it to a more complex application, like a one with login + crud modules. Do you know where or how can I find some gwt source example of a login module + crud module with JSON? Thanks in advance. Best regards. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Literal Array Creation in JSNI
Hallo,
within my GWT Application I try to execute the following method:
@Override
public native void drawChart(Element parent)/*-{
var series = [{
data: [ { x: 0, y: 40 }, { x: 1, y: 49 } ],
color: 'steelblue',
name: 'Dataset_1'
}];
var graph = new $wnd.Rickshaw.Graph( {
element: parent,
width: 600,
height: 200,
series: series,
renderer: 'bar'
});
graph.render();
}-*/;
The series array initialized at the beginning of the implementation is
passed to the Rickshaw.Graph constructor.
The Rickshaw module tests whether the input object *series *is of *type
Array* and - *fails*.
if (!(series instanceof Array)) throw
I have no explanation for that behavior. I thought it's native JavaScript
code, executed within the browser, so that there should be
no difference. But indeed, the array created in the method above does not
pass that instanceof check.
Any help is appreciated.
tomsn
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT Sticky Sessions
Hi there
from my experience ... you are barking at the wrong tree so to speak.
it's a long time that I'm not using GWT anymore (not my choice, but i had
to) but i don't think that it's GWT's problem
to check the jsessionid you could use the Chrome's developer tools o
firefox - firebug and look at the network tab there you should see the
headers sent to the back-end (the jsessionid should be present in a cookie
or in the request).
anyway you said mod_jk that says to me that you have an Apache HTTPD before
the Tomcat
I usually use mod_proxy_ajp (which i would recommend, but about that we
could talk some other time)
a very important thing when implementing load balancing it's the jvmRoute
parameter on the tomcat.
In every tomcat you shold edit in the server.xml the line saying
Engine name=Catalina defaultHost=localhost
adding the an attribute jvmRoute, with a string at your discretion but
different for every server.
Engine name=Catalina defaultHost=localhost jvmRoute=t1
Engine name=Catalina defaultHost=localhost jvmRoute=t2
...
that makes the Tomcat add that little string at the end of the jsessionid (*
jsessionid*=AS348AF929FK219CKA9FK3B79870H would become
*jsessionid*=AS348AF929FK219CKA9FK3B79870H.t1
on the first server t1 and so on).
that little string there says to the Apache on which node the session was
created and therefore where it should send the request.
from what I've understand from reading this
http://blogs.encodo.ch/news/view_article.php?id=18 looks like the jvmRoute
value should be the same as the worker name or/and vice-versa.
that's about it, hope it helped
See ya
On Wednesday, March 27, 2013 3:32:25 PM UTC+1, xsee wrote:
You don't even need a filter or set the cookie yourself. Just make a call
to getSession(true) and it will automagically be set in the Cookies.
Typically, you will have some sort of 'initialization' RPC in your module
entry point. This is usually a good place to create the session by calling
getLocalThreadRequest().getSession(true). Once your RPC returns, go check
your cookies in the browser and you will see the jsessionid there. No need
for special filters or any of the rest of it.
On Wednesday, January 23, 2008 4:57:41 AM UTC-7, jas_tat wrote:
Hi All,
I fixed my problem. Does anyone know how I can pass a plain,
unencoded, jsessionid with all http POST requests which the GWT client
frontend makes?
In the end I used a servlet filter in order to set a jsessionid as a
cookie for every http response my GWT application made:
import java.io.IOException;
import javax.servlet.*;
import javax.servlet.http.*;
import org.apache.log4j.Logger;
public class JsessionidSetter implements Filter
{
public static Logger log = Logger.getLogger(JsessionidSetter
.class);
public void init(FilterConfig arg0) throws ServletException
{
}
public void destroy()
{
}
public void doFilter(ServletRequest req, ServletResponse res,
FilterChain chain) throws IOException, ServletException
{
HttpServletResponse response = (HttpServletResponse) res;
HttpSession session =
((HttpServletRequest)req).getSession(true);
response.addCookie(new Cookie(JSESSIONID,
session.getId()));
chain.doFilter(req, res);
}
}
With supporting xml in my web.xml:
filter
filter-nameJsessionidSetter/filter-name
filter-classJsessionidSetter/filter-class
/filter
filter-mapping
filter-nameJsessionidSetter/filter-name
url-pattern/*/url-pattern
/filter-mapping
Thank you all for your comments anyway!
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Need some help with Totoe and XML
I'n not sure I understand what your trying to do, but before I put an XPath in code, I often try it out wit XPE (http://sourceforge.net/projects/xpe/). I've found this a great tool for exploring option and getting it right before try it out in my program. On Wednesday, March 27, 2013 11:01:14 AM UTC-4, skippy wrote: I have this XML: I need to get at Group Name=ACCT00305” and at all the children and values like this: ACCT000 31MEB0009 NAME055 Miss Taylor R Williams REMT000 1 REMT001 BANTMEK Data Group Name=ACCT00305 ITEM ACCT000 31MEB0009/ACCT000 NAME055 Miss Taylor R Williams/NAME055 REMT000 1/REMT000 REMT001 BANTMEK/REMT001 NAME002 987-00-0082/NAME002 REMT027 vlst vitm code=' ' desc='NONE' / /vlst /REMT027 REMT018 vlst vitm code=' ' desc='NONE' / /vlst /REMT018 /ITEM ITEM ACCT000 31MEB0009/ACCT000 NAME055 Mr. Taylor R Brown/NAME055 REMT000 2/REMT000 REMT001 GIP5/REMT001 NAME002 /NAME002 REMT027 vlst vitm code=' ' desc='NONE' / /vlst /REMT027 REMT018 vlst vitm code=' ' desc='NONE' / /vlst /REMT018 /ITEM ITEM ACCT000 31MEB0009/ACCT000 NAME055 Mrs. Jamie N Walker/NAME055 REMT000 5/REMT000 REMT001 BROWTJK/REMT001 NAME002 /NAME002 REMT027 vlst vitm code=' ' desc='NONE' / /vlst /REMT027 REMT018 vlst vitm code=' ' desc='NONE' / /vlst /REMT018 /ITEM ITEM ACCT000 31MEB0009/ACCT000 NAME055 Miss Pat G Wilson/NAME055 REMT000 00010/REMT000 REMT001 TAYLOAK/REMT001 NAME002 /NAME002 REMT027 TAvlst vitm code='TA' desc='Receive Tax Letters' / /vlst /REMT027 REMT018 vlst vitm code=' ' desc='NONE' / /vlst /REMT018 /ITEM /Group /Data Alan B. Lehman IT Architect Specialist FIS Wealth Management Solutions Phone: 414-815-2049 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Are VerticalPanel and HorizontalPanel (informally) deprecated in GWT 2.0?
That's a great question. I would like to know where this stands today. On Saturday, March 13, 2010 7:10:19 AM UTC-5, Δημήτρης Μενούνος wrote: I hope not! There is nothing wrong with using Components backed by tables. Especially in the context of building complex web-app UIs, where floated divs won't cut it. So we are left with absolute positioning and / or tables. Absolute layout can be more precise but also perform worse. Personally I use a mixture of both. On Mar 12, 11:53 pm, Marty Hall javahac...@gmail.com wrote: Now that we have LayoutPanel and its derivatives, are we supposed to eschew VerticalPanel and HorizontalPanel because they use HTML tables behind the scenes? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Literal Array Creation in JSNI
On Thursday, March 28, 2013 8:08:14 PM UTC+1, tomsn wrote:
Hallo,
within my GWT Application I try to execute the following method:
@Override
public native void drawChart(Element parent)/*-{
var series = [{
data: [ { x: 0, y: 40 }, { x: 1, y: 49 } ],
color: 'steelblue',
name: 'Dataset_1'
}];
var graph = new $wnd.Rickshaw.Graph( {
element: parent,
width: 600,
height: 200,
series: series,
renderer: 'bar'
});
graph.render();
}-*/;
The series array initialized at the beginning of the implementation is
passed to the Rickshaw.Graph constructor.
The Rickshaw module tests whether the input object *series *is of *type
Array* and - *fails*.
if (!(series instanceof Array)) throw
I have no explanation for that behavior. I thought it's native JavaScript
code, executed within the browser, so that there should be
no difference. But indeed, the array created in the method above does not
pass that instanceof check.
GWT code runs in an iframe, so its Array is not the same as the Array in
$wnd, which is why instanceof Array fails.
Rickshaw.Graph is simply broken.
See
https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Array/isArray
and
http://perfectionkills.com/instanceof-considered-harmful-or-how-to-write-a-robust-isarray/
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT Beginner's Tutorial
I really have enjoyed Marty Hall's slides and tutorials. The one that I have been using lately is http://www.slideshare.net/martyhall/gwt-tutorial-laying-out-windows-with-panels-part-ii-composite-panels (GWT 2.5 from May 2012). But you can find all of his GWT training slides here: http://www.slideshare.net/martyhall/tag/gwt This is great stuff for beginners who are just getting into GWT! On Friday, June 8, 2007 3:17:31 AM UTC-4, mP wrote: On Jun 8, 5:15 am, Marty Hall javahac...@gmail.com wrote: On Jun 6, 5:32 pm, Sanjiv Jivan sanjiv.ji...@gmail.com wrote: I still think that Big learning curve listed as a disadvantage is not an accurate statement, certainly not for Java developers. Even if I was attending a Tapestry class, I wouldn't want to see one of the first slides say that it has a big learning curve ;) Maybe after the class the audience can decide if GWT is their cup of tea. Well, the tact I take is to *not* try to be an advocate for a particular technology, but rather summarize what I think are the pros and the cons as accurately as possible at the beginning. Besides, I think in the long run people will be more satisfied if they have realistic expectations at the beginning. The single most common course I teach is on JSF, and I get so many requests for JSF training courses that I can hardly keep up. (A course Down Under in Sydney is next: yay!). Dont come you wont like it here :) But you should see all the negatives I cite about JSF early on. I am much harsher than I am with GWT. In general, I think it is unhelpful to potential developers if you cite the advantages without also citing the disadvantages. Anyhow, back to big learning curve, I still think this is true. With most other Ajax tools, developers start with what they already know (xhtml, JavaScript, maybe JSP custom tags) and add in a few things. With GWT, they have to think in a whole new way, and they have to learn a new class for each xhtml form element that they already knew. Now, I think this is *more* productive in the medium and long term, but, still, my empirical observation is that people who start with GWT take longer to get going *initially* than they do with other Ajax tools. Instead of denying this initial ramp up time, I think it is better to argue that it is well worth it in the medium to long term. Or even in the just-a-bit-longer-than-short term. :-) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Problem with the function editRecord in a DynamicForm (SmartGwt)
This functionality works fine even for Date type fields. You can see this
by clicking any row in the grid which calls editRecord(..) on the form.
http://www.smartclient.com/smartgwt/showcase/#featured_pattern_reuse
If you're still having problems then post your question on the SmartGWT
forum including a minimal test case :
http://forums.smartclient.com/forumdisplay.php?f=14
Thanks,
Sanjiv
On Mon, Mar 25, 2013 at 5:58 AM, sahli.sabr...@gmail.com wrote:
i have in the GUI, a ListGrid and a DynamicForm. When i click on an
element in the listGrid, i have to display the values of the edited record
on the Dynamic form,
for this, i use the EditRecord(Record r) of the dynamicForm
public void updateInstanceDetailTabPane(Record record){
this.editionForm.editRecord(record);
}
it works however for the fields of type Date , the values displayed are
the date of today and not the reel value of the field.
My question is where is the problem and how can i display the values of
type date with their reel values?
thank you,
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an
email to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Change RemoteServiceServlet so gwt.codeserver.port works wit...
Matthew Dempsky has posted comments on this change. Change subject: Change RemoteServiceServlet so gwt.codeserver.port works with more subclasses. .. Patch Set 1: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2360 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib47db371b78eabb1a139948744279b36aa306bc1 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Moves GWTTestCase to Impl#setUncaughtExceptionHandlerForTest.
Goktug Gokdogan has abandoned this change. Change subject: Moves GWTTestCase to Impl#setUncaughtExceptionHandlerForTest. .. Abandoned Submitted. -- To view, visit https://gwt-review.googlesource.com/2190 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8d32c6f4ff4cbcd55f238116b8bcc4c8685d6f35 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Changes StackTraceDeobfuscator to abstract and provide vario...
Goktug Gokdogan has abandoned this change. Change subject: Changes StackTraceDeobfuscator to abstract and provide various factory methods. .. Abandoned Submitted. -- To view, visit https://gwt-review.googlesource.com/2270 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Moves c.g.gwt.logging to common StackTraceDeobfuscator.
Goktug Gokdogan has posted comments on this change. Change subject: Moves c.g.gwt.logging to common StackTraceDeobfuscator. .. Patch Set 1: (1 comment) File user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java Line 125: TestSetValidator.rethrowException(caught); I agree but I don't want to single this one out as this is the pattern in all rpc tests. -- To view, visit https://gwt-review.googlesource.com/2300 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44bee6a3abdf550831f6f9263a8c6e3c807ca063 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Update JDT to 3.8.1
Thomas Broyer has abandoned this change. Change subject: Update JDT to 3.8.1 .. Abandoned Superseded by If7d533adcb953de614ea071cfd7e57560b664ce0 -- To view, visit https://gwt-review.googlesource.com/1861 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Idd5ec3f05176b053d5aace6a8b165d021ec7e0dc Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ugrade JDT to 3.8.3.
Thomas Broyer has posted comments on this change. Change subject: Ugrade JDT to 3.8.3. .. Patch Set 1: (1 comment) File dev/core/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java Line 24: import com.google.gwt.dev.util.collect.HashMap; AFAICT, it used to be; c.g.g.dev.util.collect.HashMap being more memory-efficient thatn java.util.HashMap. But maybe this is no longer the case with newer JDKs… I suppose you can track memory utilization of the various Google builds and check whether it makes a significant difference? (it would be great if we could get rid of customizations on our dependencies) -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ugrade JDT to 3.8.3.
Matthew Dempsky has posted comments on this change.
Change subject: Ugrade JDT to 3.8.3.
..
Patch Set 1:
(5 comments)
Commit Message
Line 9: Fixed an error in RequestFactory that resulted in a class
implementing a generic interface twice with
Can you elaborate on what this issue is? E.g., what's an example generated
class and its type hierarchy that causes the error?
Also, is this something we could split into a separate commit, or does it
need to happen simultaneously with the JDT bump?
File dev/build.xml
Line 60: include
name=eclipse/jdtCompilerAdapter-3.8.3.v20130121-145325.jar / !--
extracted from eclipse/org.eclipse.jdt.core_3.8.3.v20130121-145325.jar --
I don't think these extracted from comments add any value, so I'd just
omit it. It would be more useful to mention them in the
tools/eclipse/README file.
File dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java
Line 84: while ((idx = separatorIdx(className)) = 0) {
What's the purpose of this change? Doesn't BinaryName.getClassName()
already skip over all dots anyway, so the only separator characters left
will be $?
Line 196: options.originalSourceLevel = options.sourceLevel =
ClassFileConstants.JDK1_6;
I'd break this into two assignments.
File
dev/core/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java
Line 24: import com.google.gwt.dev.util.collect.HashMap;
In my opinion, no. :)
--
To view, visit https://gwt-review.googlesource.com/2361
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ugrade JDT to 3.8.3.
Matthew Dempsky has posted comments on this change. Change subject: Ugrade JDT to 3.8.3. .. Patch Set 1: (1 comment) File dev/core/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java Line 24: import com.google.gwt.dev.util.collect.HashMap; I agree with Thomas. We should benchmark if it doesn't make a measurable difference, we should get rid of the customization if that's the only reason for us to have this file. I expect by now more time has been spent optimizing the JDK's HashMap than has been spent on com.google.gwt.dev.util.collect.HashMap. :) -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ugrade JDT to 3.8.3.
Thomas Broyer has posted comments on this change.
Change subject: Ugrade JDT to 3.8.3.
..
Patch Set 1:
(2 comments)
Commit Message
Line 9: Fixed an error in RequestFactory that resulted in a class
implementing a generic interface twice with
Can you elaborate on what this issue is? E.g., what's an example
generated class and its type hierarchy that causes the error?
The RequestFactoryGenerator can generate a class that
extends AbstractRequestFooProxy implements InstanceRequestBarProxy,
FooProxy
but AbstractRequestX already `implements InstanceRequestBaseProxy, X` ;
the type arguments of InstanceRequest are conflicting.
The change here is to add a type argument to AbstractRequest:
AbstractRequestP extends BaseProxy, X … implements InstanceRequestP,
X
Also, is this something we could split into a separate commit, or does it
need to happen simultaneously with the JDT bump?
It can be split in its own change (and should, IMO)
File dev/build.xml
Line 110: zipfileset
src=${gwt.tools.lib}/eclipse/jdtCompilerAdapter-3.8.3.v20130121-145325.jar
/ !-- extracted from
eclipse/org.eclipse.jdt.core_3.8.3.v20130121-145325.jar --
Is this needed if the org.eclipse.jdt.core that jdtCompilerAdapter is
extracted from is already in there? (the line above)
--
To view, visit https://gwt-review.googlesource.com/2361
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ugrade JDT to 3.8.3.
Matthew Dempsky has posted comments on this change. Change subject: Ugrade JDT to 3.8.3. .. Patch Set 1: (1 comment) Commit Message Line 9: Fixed an error in RequestFactory that resulted in a class implementing a generic interface twice with I think I'm getting lost in the generics, but it sounds like you understand and agree with the change. :) My only concern then is whether this change could break user code somehow, but it sounds like it's technically wrong already. Roberto, can you split the RequestFactory changes into a separate CL/review that we land first? -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: RequestFactoryGenerator generated invalid java classes.
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/2370
Change subject: RequestFactoryGenerator generated invalid java classes.
..
RequestFactoryGenerator generated invalid java classes.
In some cases RequestFactoryGenerator generated classes that implemented
the same generic
interface twice with different generic parameters. For example:
class X extends AbstractRequestResultType
implements InstanceRequestBarProxy, ResultType { ... }
where AbstractRequest is defined in the library as follows:
class AbstractRequestX implements InstanceRequestBaseProxy, X {... }
Althogh the code is not valid java the GWT compiler would ignore the error
and generate
woirking code; but newer versions of the JDT reject the code.
The change here is to add a type argument to AbstractRequest:
AbstractRequestP extends BaseProxy, X … implements InstanceRequestP,
X
Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc
---
M
user/src/com/google/web/bindery/requestfactory/gwt/rebind/RequestFactoryGenerator.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
M
user/src/com/google/web/bindery/requestfactory/vm/InProcessRequestContext.java
4 files changed, 26 insertions(+), 20 deletions(-)
diff --git
a/user/src/com/google/web/bindery/requestfactory/gwt/rebind/RequestFactoryGenerator.java
b/user/src/com/google/web/bindery/requestfactory/gwt/rebind/RequestFactoryGenerator.java
index 7bbd30a..99e45c7 100644
---
a/user/src/com/google/web/bindery/requestfactory/gwt/rebind/RequestFactoryGenerator.java
+++
b/user/src/com/google/web/bindery/requestfactory/gwt/rebind/RequestFactoryGenerator.java
@@ -47,6 +47,7 @@
import com.google.web.bindery.requestfactory.gwt.rebind.model.ModelVisitor;
import
com.google.web.bindery.requestfactory.gwt.rebind.model.RequestFactoryModel;
import
com.google.web.bindery.requestfactory.gwt.rebind.model.RequestMethod;
+import com.google.web.bindery.requestfactory.shared.BaseProxy;
import com.google.web.bindery.requestfactory.shared.EntityProxyId;
import com.google.web.bindery.requestfactory.shared.JsonRpcContent;
import com.google.web.bindery.requestfactory.shared.impl.AbstractRequest;
@@ -375,10 +376,13 @@
sw.println(public %s %s %s(%s) {, typeParameterDeclaration,
jmethod.getReturnType()
.getParameterizedQualifiedSourceName(), jmethod.getName(),
parameterDeclaration);
sw.indent();
+
// The implements clause covers InstanceRequest
-// class X extends AbstractRequestReturn implements
RequestReturn {
-sw.println(class X extends %s%s implements %s {,
AbstractRequest.class
-.getCanonicalName(),
request.getDataType().getParameterizedQualifiedSourceName(),
+// class X extends AbstractRequestFooProxy, Return implements
RequestReturn {
+sw.println(class X extends %s%s, %s implements %s {,
AbstractRequest.class
+.getCanonicalName(), request.getInstanceType() == null ?
+BaseProxy.class.getCanonicalName() :
request.getInstanceType().getQualifiedSourceName(),
+request.getDataType().getParameterizedQualifiedSourceName(),
jmethod.getReturnType().getParameterizedQualifiedSourceName());
sw.indent();
diff --git
a/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java
b/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java
index ea36479..71cd66f 100644
---
a/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java
+++
b/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java
@@ -33,10 +33,12 @@
/**
* Abstract implementation of {@link Request}. Each request stores a
* {@link DeltaValueStoreJsonImpl}.
- *
+ *
+ * @param P proxy type
* @param T return type
*/
-public abstract class AbstractRequestT implements RequestT,
InstanceRequestBaseProxy, T {
+public abstract class AbstractRequestP extends BaseProxy, T implements
+RequestT, InstanceRequestP, T {
/**
* Used by generated subtypes.
@@ -84,10 +86,10 @@
}
/**
- * This method comes from the {@link InstanceRequest} interface. Instance
- * methods place the instance in the first parameter slot.
+ * This method comes from the {@link InstanceRequest}
+ * interface. Instance methods place the instance in the first parameter
slot.
*/
- public RequestT using(BaseProxy instanceObject) {
+ public RequestT using(P instanceObject) {
getRequestData().getOrderedParameters()[0] = instanceObject;
/*
* Instance methods enqueue themselves when their using() method is
called.
diff --git
a/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
[gwt-contrib] Change in gwt[master]: RequestFactoryGenerator generated invalid java classes.
Matthew Dempsky has posted comments on this change. Change subject: RequestFactoryGenerator generated invalid java classes. .. Patch Set 1: Code-Review+1 LGTM, but trim the trailing whitespace from the CL description. -- To view, visit https://gwt-review.googlesource.com/2370 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Move flaky non-hermetic test case into its own test suite.
Matthew Dempsky has abandoned this change. Change subject: Move flaky non-hermetic test case into its own test suite. .. Abandoned Submitted. -- To view, visit https://gwt-review.googlesource.com/2340 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id6509d0c2a2ad302e3523ded60c5e33c699ec3d4 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: RequestFactoryGenerator generated invalid java classes.
Thomas Broyer has posted comments on this change. Change subject: RequestFactoryGenerator generated invalid java classes. .. Patch Set 1: (2 comments) File user/src/com/google/web/bindery/requestfactory/gwt/rebind/RequestFactoryGenerator.java Line 383: .getCanonicalName(), request.getInstanceType() == null ? Can we make this more readable with one argument per line (stick a // at the end of the lines to prevent auto-format from messing with it if you like) File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java Line 40: public abstract class AbstractRequestP extends BaseProxy, T implements What do you think about introducing a new: class AbstractInstanceRequestP extends BaseProxy, T extends AbstractRequestT implements InstanceRequestP, T ? -- To view, visit https://gwt-review.googlesource.com/2370 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ugrade JDT to 3.8.3.
Roberto Lublinerman has uploaded a new patch set (#2). Change subject: Ugrade JDT to 3.8.3. .. Ugrade JDT to 3.8.3. Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Review-Link: https://gwt-review.googlesource.com/#/c/2361/ --- M dev/build.xml M dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java M dev/core/test/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsCheckerTest.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java M eclipse/dev/.classpath M eclipse/dev/compiler/.classpath M user/super/com/google/gwt/emul/java/lang/Enum.java 10 files changed, 1,889 insertions(+), 1,577 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ugrade JDT to 3.8.3.
Roberto Lublinerman has posted comments on this change.
Change subject: Ugrade JDT to 3.8.3.
..
Patch Set 1:
(6 comments)
Commit Message
Line 9: Fixed an error in RequestFactory that resulted in a class
implementing a generic interface twice with
Done
File dev/build.xml
Line 60: include
name=eclipse/jdtCompilerAdapter-3.8.3.v20130121-145325.jar / !--
extracted from eclipse/org.eclipse.jdt.core_3.8.3.v20130121-145325.jar --
Done
Line 110: zipfileset
src=${gwt.tools.lib}/eclipse/jdtCompilerAdapter-3.8.3.v20130121-145325.jar
/ !-- extracted from
eclipse/org.eclipse.jdt.core_3.8.3.v20130121-145325.jar --
I am not sure. It is inside the jdt.core jar as a jar file. By having it
extracted its contents will be included.
File dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java
Line 84: while ((idx = separatorIdx(className)) = 0) {
Java 7 now has different signatures for inner classes when the outer class
is generic. E.g. for
class OuterA {
class Inner {
}
}
the signature used to by L...Outer$Inner and now is L...OuterTA;.Inner
My mistake it does not apply to binary class names. Reverted.
Line 196: options.originalSourceLevel = options.sourceLevel =
ClassFileConstants.JDK1_6;
Done
File
dev/core/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java
Line 24: import com.google.gwt.dev.util.collect.HashMap;
I'll run some experiments and let you know the results.
--
To view, visit https://gwt-review.googlesource.com/2361
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: RequestFactoryGenerator generated invalid java classes.
Hello Matthew Dempsky,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2370
to look at the new patch set (#2).
Change subject: RequestFactoryGenerator generated invalid java classes.
..
RequestFactoryGenerator generated invalid java classes.
In some cases RequestFactoryGenerator generated classes that implemented
the same generic
interface twice with different generic parameters. For example:
class X extends AbstractRequestResultType
implements InstanceRequestBarProxy, ResultType { ... }
where AbstractRequest is defined in the library as follows:
class AbstractRequestX implements InstanceRequestBaseProxy, X {... }
Althogh the code is not valid java the GWT compiler would ignore the error
and generate
woirking code; but newer versions of the JDT reject the code.
The change here is to add a type argument to AbstractRequest:
AbstractRequestP extends BaseProxy, X … implements InstanceRequestP,
X
Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc
Review-Link: https://gwt-review.googlesource.com/#/c/2370/
---
M
user/src/com/google/web/bindery/requestfactory/gwt/rebind/RequestFactoryGenerator.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
M
user/src/com/google/web/bindery/requestfactory/vm/InProcessRequestContext.java
4 files changed, 27 insertions(+), 20 deletions(-)
--
To view, visit https://gwt-review.googlesource.com/2370
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: RequestFactoryGenerator generated invalid java classes.
Roberto Lublinerman has posted comments on this change. Change subject: RequestFactoryGenerator generated invalid java classes. .. Patch Set 1: (2 comments) File user/src/com/google/web/bindery/requestfactory/gwt/rebind/RequestFactoryGenerator.java Line 383: .getCanonicalName(), request.getInstanceType() == null ? Done File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java Line 40: public abstract class AbstractRequestP extends BaseProxy, T implements I am not sure about the impact. I am completely unfamiliar with the code and I wouldn't know for example if the code in InProcessRequestContext:148 needs an AbstractRequest or and AbstractInstanceRequest. I propose that we'll go as it is and then you can take over and make it better. -- To view, visit https://gwt-review.googlesource.com/2370 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: RequestFactoryGenerator generated invalid java classes.
Hello Matthew Dempsky,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2370
to look at the new patch set (#3).
Change subject: RequestFactoryGenerator generated invalid java classes.
..
RequestFactoryGenerator generated invalid java classes.
In some cases RequestFactoryGenerator generated classes that implemented
the same generic
interface twice with different generic parameters. For example:
class X extends AbstractRequestResultType
implements InstanceRequestBarProxy, ResultType { ... }
where AbstractRequest is defined in the library as follows:
class AbstractRequestX implements InstanceRequestBaseProxy, X {... }
Althogh the code is not valid java the GWT compiler would ignore the error
and generate
woirking code; but newer versions of the JDT reject the code.
The change here is to add a type argument to AbstractRequest:
AbstractRequestP extends BaseProxy, X … implements InstanceRequestP,
X
Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc
Review-Link: https://gwt-review.googlesource.com/#/c/2370/
---
M
user/src/com/google/web/bindery/requestfactory/gwt/rebind/RequestFactoryGenerator.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
M
user/src/com/google/web/bindery/requestfactory/vm/InProcessRequestContext.java
4 files changed, 27 insertions(+), 20 deletions(-)
--
To view, visit https://gwt-review.googlesource.com/2370
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: RequestFactoryGenerator generated invalid java classes.
Hello Matthew Dempsky,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2370
to look at the new patch set (#4).
Change subject: RequestFactoryGenerator generated invalid java classes.
..
RequestFactoryGenerator generated invalid java classes.
In some cases RequestFactoryGenerator generated classes that implemented
the same generic
interface twice with different generic parameters. For example:
class X extends AbstractRequestResultType
implements InstanceRequestBarProxy, ResultType { ... }
where AbstractRequest is defined in the library as follows:
class AbstractRequestX implements InstanceRequestBaseProxy, X {... }
Althogh the code is not valid java the GWT compiler would ignore the error
and generate
working code; but newer versions of the JDT reject the code.
The change here is to add a type argument to AbstractRequest:
AbstractRequestP extends BaseProxy, X … implements InstanceRequestP,
X
Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc
Review-Link: https://gwt-review.googlesource.com/#/c/2370/
---
M
user/src/com/google/web/bindery/requestfactory/gwt/rebind/RequestFactoryGenerator.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
M
user/src/com/google/web/bindery/requestfactory/vm/InProcessRequestContext.java
4 files changed, 27 insertions(+), 20 deletions(-)
--
To view, visit https://gwt-review.googlesource.com/2370
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Ugrade JDT to 3.8.3.
Thomas Broyer has posted comments on this change.
Change subject: Ugrade JDT to 3.8.3.
..
Patch Set 1:
(1 comment)
File dev/build.xml
Line 110: zipfileset
src=${gwt.tools.lib}/eclipse/jdtCompilerAdapter-3.8.3.v20130121-145325.jar
/ !-- extracted from
eclipse/org.eclipse.jdt.core_3.8.3.v20130121-145325.jar --
Oh, it's a JAR within a JAR? OK then.
--
To view, visit https://gwt-review.googlesource.com/2361
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: RequestFactoryGenerator generated invalid java classes.
Hello Matthew Dempsky,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2370
to look at the new patch set (#5).
Change subject: RequestFactoryGenerator generated invalid java classes.
..
RequestFactoryGenerator generated invalid java classes.
In some cases RequestFactoryGenerator generated classes that implemented
the same generic
interface twice with different generic parameters. For example:
class X extends AbstractRequestResultType
implements InstanceRequestBarProxy, ResultType { ... }
where AbstractRequest is defined in the library as follows:
class AbstractRequestX implements InstanceRequestBaseProxy, X {... }
Although the code is not valid java the GWT compiler would ignore the error
and generate
working code; but newer versions of the JDT reject the code.
The change here is to add a type argument to AbstractRequest:
AbstractRequestP extends BaseProxy, X … implements InstanceRequestP,
X
Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc
Review-Link: https://gwt-review.googlesource.com/#/c/2370/
---
M
user/src/com/google/web/bindery/requestfactory/gwt/rebind/RequestFactoryGenerator.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequest.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
M
user/src/com/google/web/bindery/requestfactory/vm/InProcessRequestContext.java
4 files changed, 27 insertions(+), 20 deletions(-)
--
To view, visit https://gwt-review.googlesource.com/2370
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: RequestFactoryGenerator generated invalid java classes.
Thomas Broyer has posted comments on this change. Change subject: RequestFactoryGenerator generated invalid java classes. .. Patch Set 5: Code-Review+1 I'll evaluate later on whether AbstractInstanceRequest is worth it, when I'll be back to working on RF et al. -- To view, visit https://gwt-review.googlesource.com/2370 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: RequestFactoryGenerator generated invalid java classes.
Brian Slesinsky has posted comments on this change. Change subject: RequestFactoryGenerator generated invalid java classes. .. Patch Set 5: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2370 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a604ef63f05bbecd8bfed60255f74682607fcc Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Refactors c.g.gwt.junit to use common SerializableThrowable ...
Goktug Gokdogan has posted comments on this change. Change subject: Refactors c.g.gwt.junit to use common SerializableThrowable StacktraceDeobfuscator. .. Patch Set 2: (1 comment) File user/src/com/google/gwt/junit/JUnitMessageQueue.java Line 468: !result.isExceptionOf(Error.class) I named this isExceptionOf but can change it to isException if that reads better. -- To view, visit https://gwt-review.googlesource.com/2290 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e1021bc99ac88ea6d9d47c3d23c83e79a896213 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Moves c.g.gwt.logging to common StackTraceDeobfuscator.
Goktug Gokdogan has abandoned this change. Change subject: Moves c.g.gwt.logging to common StackTraceDeobfuscator. .. Abandoned Submitted. -- To view, visit https://gwt-review.googlesource.com/2300 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I44bee6a3abdf550831f6f9263a8c6e3c807ca063 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes obsolute way of identifying test classes in module.
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2371
Change subject: Removes obsolute way of identifying test classes in module.
..
Removes obsolute way of identifying test classes in module.
Actually, I hope this is obsolute because I couldn't find any use cases.
Change-Id: I765ac2274336e78707c1975b1eb6fab6ac27d30b
---
M user/src/com/google/gwt/junit/rebind/GWTRunnerProxyGenerator.java
1 file changed, 5 insertions(+), 36 deletions(-)
diff --git
a/user/src/com/google/gwt/junit/rebind/GWTRunnerProxyGenerator.java
b/user/src/com/google/gwt/junit/rebind/GWTRunnerProxyGenerator.java
index 574ae25..adc139f 100644
--- a/user/src/com/google/gwt/junit/rebind/GWTRunnerProxyGenerator.java
+++ b/user/src/com/google/gwt/junit/rebind/GWTRunnerProxyGenerator.java
@@ -28,6 +28,7 @@
import com.google.gwt.core.ext.typeinfo.JType;
import com.google.gwt.core.ext.typeinfo.NotFoundException;
import com.google.gwt.core.ext.typeinfo.TypeOracle;
+import com.google.gwt.junit.JUnitFatalLaunchException;
import com.google.gwt.junit.client.GWTTestCase;
import com.google.gwt.junit.client.GWTTestCase.TestModuleInfo;
import com.google.gwt.junit.client.impl.GWTRunnerProxy;
@@ -41,7 +42,6 @@
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Set;
-import java.util.TreeSet;
/**
* This class generates a JSNI based {@link GWTRunnerProxy} implementation.
@@ -114,7 +114,7 @@
SourceWriter sourceWriter =
getSourceWriter(logger, context, packageName, generatedBaseClass,
null, null);
if (sourceWriter != null) {
- writeMethodCreateTestAccessor(logger, context, moduleName,
sourceWriter);
+ writeMethodCreateTestAccessor(sourceWriter, getTestClasses(logger,
context, moduleName));
sourceWriter.commit(logger);
}
@@ -156,9 +156,7 @@
* }-{@literal*}/;
* /pre
*/
- private void writeMethodCreateTestAccessor(
- TreeLogger logger, GeneratorContext context, String moduleName,
SourceWriter sw) {
-SetJClassType testClasses = getTestClasses(logger, context,
moduleName);
+ private void writeMethodCreateTestAccessor(SourceWriter sw,
SetJClassType testClasses) {
sw.println(public native final %s createTestAccessor() /*-{,
JSNI_TEST_ACCESSOR);
sw.indent();
sw.println(return {);
@@ -199,9 +197,8 @@
TestModuleInfo moduleInfo = GWTTestCase.getTestsForModule(moduleName);
SetTestInfo moduleTests = (moduleInfo == null) ? null :
moduleInfo.getTests();
if (moduleTests == null || moduleTests.isEmpty()) {
- // Fall back to pulling in all types in the module.
- JClassType[] allTestTypes =
getAllPossibleTestTypes(context.getTypeOracle());
- return getTestTypesForModule(logger, moduleName, allTestTypes);
+ logger.log(TreeLogger.ERROR, No tests found in module);
+ throw new JUnitFatalLaunchException();
} else {
SetJClassType testClasses = new LinkedHashSetJClassType();
for (TestInfo testInfo : moduleTests) {
@@ -240,34 +237,6 @@
composerFactory.addImplementedInterface(interfaceName);
}
return composerFactory.createSourceWriter(ctx, printWriter);
- }
-
- private SetJClassType getTestTypesForModule(
- TreeLogger logger, String moduleName, JClassType[] allTestTypes) {
-// Must use sorted set to prevent nondeterminism.
-SetJClassType testClasses = new TreeSetJClassType();
-for (JClassType classType : allTestTypes) {
- if (!classType.isPublic() || classType.isAbstract() |
| !classType.isDefaultInstantiable()) {
-continue;
- }
-
- String className = getPackagePrefix(classType) +
classType.getName().replace('.', '$');
-
- try {
-Class? testClass = Class.forName(className);
-GWTTestCase instantiated = (GWTTestCase) testClass.newInstance();
-if (!moduleName.equals(instantiated.getModuleName())) {
- continue;
-}
- } catch (Throwable e) {
-logger.log(TreeLogger.INFO, Error determining if test class ' +
className
-+ ' is a part of the current module; skipping; expect
subsequent errors
-+ if this test class is run, e);
-continue;
- }
- testClasses.add(classType);
-}
-return testClasses;
}
private static ListJMethod getTestMethods(JClassType requestedClass) {
--
To view, visit https://gwt-review.googlesource.com/2371
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I765ac2274336e78707c1975b1eb6fab6ac27d30b
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group
[gwt-contrib] Change in gwt[master]: Refactors c.g.gwt.logging to use SerializableThrowable.
Goktug Gokdogan has posted comments on this change.
Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
..
Patch Set 1:
(8 comments)
File user/src/com/google/gwt/logging/impl/FormatterImpl.java
Line 48:* @deprecated Use {@link
Throwable#printStackTrace(PrintStream)} instead.
Done
File user/src/com/google/gwt/logging/impl/StackTracePrintStream.java
Line 25: public class StackTracePrintStream extends PrintStream {
Thanks, I liked the idea of explicit stating which methods that all data
will flow through and are meant to be overridden. I added those two methods
and marked the rest as final. Also documented them in the class javadoc. It
looks better now.
File user/src/com/google/gwt/logging/server/JsonLogRecordServerUtil.java
Line 80: return new Throwable(cause) {
Done
File
user/src/com/google/gwt/user/client/rpc/core/java/util/logging/LogRecord_CustomFieldSerializer.java
Line 36: SerializableThrowable thrown = (SerializableThrowable)
reader.readObject();
With protocol mismatch do you mean the case where client and server
versions doesn't match?
In that case how the rest of the system will work and why would we get a
ClassCastException? Other serialization/deserialization related to logging
rpc will also fail right?
Perhaps I didn't get what you mean.
File
user/src/com/google/gwt/user/server/rpc/core/java/util/logging/LogRecord_ServerCustomFieldSerializer.java
Line 35
I have no other information then the related change; which says:
Adds pre-deserialization type checking for values in GWT RPC messages.
The server will now avoid deserializing types that mismatch the RPC
method that is being invoked, reducing the chance that an erroneous
message will cause uncaught deserialization errors on the server.
It looks like it is for better error messaging. I think LogRecord should
not be sent from server to client in the first place. Anyway, I can revert
my change if you don't feel comfortable.
File user/test/com/google/gwt/logging/LoggingTest.gwt.xml
Line 17: inherits name='com.google.gwt.junit.JUnit'/
My bad. Removed.
File user/test/com/google/gwt/logging/client/StackTracePrintStreamTest.java
Line 31: StringBuilder stackTraceBuilder = new StringBuilder();
Done
Line 34: StringBuilder expectedStackTraceBuilder = new StringBuilder();
Done
--
To view, visit https://gwt-review.googlesource.com/2310
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeee26a9b36cbe40bd1cf0942da8fae39179e985
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Refactors c.g.gwt.logging to use SerializableThrowable.
Goktug Gokdogan has uploaded a new patch set (#2). Change subject: Refactors c.g.gwt.logging to use SerializableThrowable. .. Refactors c.g.gwt.logging to use SerializableThrowable. Change-Id: Ifeee26a9b36cbe40bd1cf0942da8fae39179e985 Review-Link: https://gwt-review.googlesource.com/#/c/2310/ --- M user/src/com/google/gwt/logging/client/HtmlLogFormatter.java M user/src/com/google/gwt/logging/client/TextLogFormatter.java M user/src/com/google/gwt/logging/impl/FormatterImpl.java A user/src/com/google/gwt/logging/impl/StackTracePrintStream.java M user/src/com/google/gwt/logging/server/JsonLogRecordServerUtil.java M user/src/com/google/gwt/user/client/rpc/core/java/util/logging/LogRecord_CustomFieldSerializer.java D user/src/com/google/gwt/user/server/rpc/core/java/util/logging/LogRecord_ServerCustomFieldSerializer.java M user/super/com/google/gwt/emul/java/lang/Throwable.java M user/super/com/google/gwt/emul/java/util/logging/Level.java M user/super/com/google/gwt/emul/java/util/logging/LogRecord.java A user/test/com/google/gwt/logging/LoggingSuite.java A user/test/com/google/gwt/logging/client/StackTracePrintStreamTest.java 12 files changed, 280 insertions(+), 209 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2310 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifeee26a9b36cbe40bd1cf0942da8fae39179e985 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes obsolute way of identifying test classes in module.
Brian Slesinsky has posted comments on this change. Change subject: Removes obsolute way of identifying test classes in module. .. Patch Set 1: (3 comments) Commit Message Line 7: Removes obsolute way of identifying test classes in module. obsolete (and below) File user/src/com/google/gwt/junit/rebind/GWTRunnerProxyGenerator.java Line 200: logger.log(TreeLogger.ERROR, No tests found in module); Could you add the module name to the message? Line 201: throw new JUnitFatalLaunchException(); Is this okay to throw here? I thought generators were only supposed to throw UnableToCompleteException. -- To view, visit https://gwt-review.googlesource.com/2371 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I765ac2274336e78707c1975b1eb6fab6ac27d30b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Refactors c.g.gwt.junit to use common SerializableThrowable ...
Brian Slesinsky has posted comments on this change.
Change subject: Refactors c.g.gwt.junit to use common SerializableThrowable
StacktraceDeobfuscator.
..
Patch Set 2: Code-Review+1
(8 comments)
Seems okay, after nits.
Commit Message
Line 9: - Gets rid of dublicate code in junit for deobfuscation of stack
traces
duplicate
File user/src/com/google/gwt/junit/server/JUnitHostImpl.java
Line 171: System.err.println(Cannot deobfuscate stack trace:);
At first I misread this as saying that the obfuscated stack trace follows,
but actually it's the exception that we got while attempting to deobfuscate
a stack trace.
To clear this up, how about:
Unable to deobfuscate a stack trace due to an error:
File user/test/com/google/gwt/junit/TestResultWithExpectedFailures.java
Line 83: String msg = e + \n(Asserted exception is reported below
via 'cause by');
Actual exception seems clearer than Asserted exception
s/cause by/caused by/
File user/test/com/google/gwt/junit/client/DefaultExceptionAsserter.java
Line 30: public void assertException(Throwable throwable, ExpectedFailure
annotation) {
s/throwable/actual/
Line 32:
assertTrue(getExceptionMessage(throwable).contains(annotation.withMessage()));
add a message:
The test threw an exception without the expected message
File user/test/com/google/gwt/junit/client/ExceptionAsserter.java
Line 24: public interface ExceptionAsserter {
ExceptionChecker seems like a better name?
Line 26: void assertException(Throwable throwable, ExpectedFailure
annotation);
This could be called check and the first argument could be actual:
void check(Throwable actual, ExpectedFailure annotation);
But by analogy with assertEquals(), perhaps the expected part should come
first and the actual part second:
void check(ExpectedFailure annotation, Throwable actual);
File user/test/com/google/gwt/junit/client/GWTTestCaseTest.java
Line 98: // We loose some type information if class meta data is not
available, setting expected failure
s/loose/lose/
--
To view, visit https://gwt-review.googlesource.com/2290
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1021bc99ac88ea6d9d47c3d23c83e79a896213
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
