Re: PDF document generation from gwt pages
We are about to release ClientIO. A GWT Module that will allow client side file generation. Inculded PDF and Excel. You can see it in action here : http://eemi2010.github.io/ext4j/#!ClientIO. Click on export to PDF and/or Excel Should be part of the Flash4j 4.1 release coming soon 2013/4/10 ramzi.yass...@gmail.com ramzi.yass...@gmail.com This is more of a best practice question and seeing what solutions exist out there. We use gwt as our web framework to show custom/dynamic reports on the web, and we are always asked to provide a PDF version of the report. In the past we have used HTML unit to scrap the generated HTML page that gwt renders and do an HTML to PDF transformation on the server side using a licensed third party tool. Anyone in this group had to face this issue? Any recommendations? Using a unit test framework to solve this production problem does not seem legit. Thanks in advance, -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Google Web Toolkit Developer Plugin - Install problem
Hello, i have a problem with the installation of GWT Developer Plugin for Chrome. I can't install, theres a message Diese Anwendung wird auf diesem Computer nicht unterstützt. Die Installation wurde deaktiviert.. This means, that my computer is not supported. Can you help me please? Thanks Moe -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Code splittingmysteries
I just downgraded to GWT 2.4 and my left over fragment disappeared :(...
(initial load was almost the same)
Strange - or 2.4. had a code splitting involved bug or 2.5. has one...
On Mon, Mar 25, 2013 at 4:03 PM, Ed Bras post2edb...@gmail.com wrote:
BTW: a corresponding issue in the issue tracker:
https://code.google.com/p/google-web-toolkit/issues/detail?id=7874
Let's hope more people are experiencing the same problem (and vote the
issue) such that the dev team put it on their priority list.
On Wed, Mar 20, 2013 at 3:22 PM, Ashton Thomas ash...@acrinta.com wrote:
I would also be interested in any updates to this as I am currently
working on the async aspect or my app. (I wouldn't even know how to
identify anomalies due to a lack of experience here)
I also remembrer having the same questions with soyc
-at
On Wednesday, March 20, 2013 7:53:11 AM UTC-4, Ed wrote:
After upgrading from 2.5.0 to 2.5.1 all of a sudden my code splitting
result is different:
+ Code fragments are bundles together which weren't before.
+ I have a left over fragment, which was 0 (see attachment).
What changed concerning code splitting? Can't find any in the release
notes.
A few observations:
1) All my components have a singleton facade that contains a method to
create the package protected controller implementation that is called
through split point (GWT.runAsync()).
In this way I have a LoginControllerDefault that is present in the left
over, but this package protected controller ONLY appears in the LoginFacade.
In the same way I have SubscribeControllerControllerD**efault that
appears only in SubscribeControllerFacade...
What suprised me is that they appear both in the same code split, namely
#30 (see screenshot attachment).
No idea why.
I moved the creation of LoginControllerDefault from the Facade
directly (see below for code snippets) in to the runAsync, but that had
no effect.
I also removed the LoginControllerDefault completely which had little
effect on the left-over
When I read the soyc report (automatically build during maven nightly
build), It doesn't really help me. This page is hard to understand, like
this page:
soycReport/compile-report/**leftoverStatus-0.html
Even worse, from this page you can go deeper to see why a class is in
a certain split point but that results in a page not found (404).
That is, the following page isn't present. BTW: the page also resulted
in a 404 in previous GWT releases.
soycReport/compile-report/**methodDependencies-total-0.
**html
Why?
I played with the nr of fragmentCount, but that has little effect, see
the attached screenshots:
+ fragmentCount = 6: screenshot with 4 splits points.
+ fragmentCount = 8: screenshot with 6 splits points.
+ fragmentCount = 10: screenshot with 7 splits points.
Below a code snippet that shows how I create the controllers in split
point #30 (see screenshot). It concerns the creation of the
LoginControllerDefault and SubscribeInfoControllerDefault**.
Note: I don't find it the most elegant code solution, but before I
passed in a Creator interface that was used in GWT.runAsync(), but that
didn't work (big left over). I posted that in the forum and it was
mentioned that it could be that it is because the code removal is run after
the split point code, and that is probably why it doesn't work and that Ray
still have a look in to code split code that need to be optimized.
How to solve/analyze these issues?
What are your experiences?
Any suggestions are more then welcome as I am out of ideas and find it
hard to solve this, but it frustrates me ;)
Loading and creating the the Login and SubscribeInfo controller:
-
The code snippet that is called by the LoginControllerBuilder to load
the Login controller:
public void create(final AsyncCallbackLoginController callback) {
getLazyLoader().**createInCodeSplitGeneral30(**LoginController.class,
callback);
}
The controller loading code (in other class):
public T void createInCodeSplitGeneral30(**final ClassT type, final
AsyncCallbackT callback, final SimpleMediator mediator) {
GWT.runAsync(new RunAsyncCallback() {
public void onSuccess() {
callback.onSuccess(**createCodeSplitGeneral30(type, mediator));
}
public void onFailure(final Throwable reason) {
callback.onFailure(reason);
}
});
}
@SuppressWarnings(unchecked)
private T T createCodeSplitGeneral30(final ClassT type, final
SimpleMediator mediator) {
if (isType(type, LoginController.class)) {
return (T) LoginFacade.getInstance().**createController();
}
else if (isType(type, SubscribeController.class)) {
return (T) SubscribeFacade.getInstance().**createController();
}
else {
throw GenExpClass.**createExceptionVarMsg(**getClass(), ERR_ID +
Gn30, type);
}
}
--
You received this message because you are subscribed to a topic in the
Google Groups Google Web Toolkit group.
To unsubscribe from this topic,
Junit test, this.getThreadLocalRequest() always return null
In normal user interaction through browser, in my servlet SearchServiceImpl which extends RemoteServiceServlet, calling this.getThreadLocalRequest() inside a method of SearchServiceImpl can return the request. but in JUnit test, if calling a method of SearchServiceImpl which includes this.getThreadLocalRequest() it always returns null !! So how to JUnit test these method in SearchServiceImpl which extends RemoteServiceServlet? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Is there a set of best practices for implementing nested presenters/view?
I wouldn't use these MVP patterns like gwtp before understanding well the different View patterns, start reading here: http://martinfowler.com/eaaDev/SupervisingPresenter.html (martin fowler). Every situation is different, and simple adding a tool like gwtp might not work for you, even worse, might result in awkward buggy code. If you understand well the theory, you can always use (parts) these framework, but to my experience, if you understand well the patterns, you will not use them (anymore) and make things yourself as it's not a lot of coding. Personally I don't think I would use nested presenters, I did that in the past, but didn't like it. I use kind of Autonomous views - All my widgets extend from lightweight IsWidget objects that construct the actual Widget (builder pattern). I have good experience with it, like and results in good unit testing (I wrote something about that some time ago in this forum). Op woensdag 10 april 2013 01:30:55 UTC+2 schreef Mohammad Al-Quraian het volgende: I did my own way of nesting presenters and now I hit a design issue, should the nested presenter have a reference to the nesting presenter? Is there a better design than this? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Is there a set of best practices for implementing nested presenters/view?
Yeah, I don't have any intentions in using any more frameworks. Let me ask you this, let's say that you have a page which has multiple panels and in each panel there are multiple widgets. How would you go about implementing that yourself? I'm especially interested in the case that you wanted for some of these widget to communicate with each other. In my design, I made a 'father' presenter that has a few 'children' presenters, the idea here is that these presenters can communicate with each other directly (father to children and vice versa), with the father having the overall control. Of course, each presenter controls its own view and nobody knows about this view. Isn't that a good way of handling things or is it complicated? On Wed, Apr 10, 2013 at 10:22 AM, Ed post2edb...@gmail.com wrote: I wouldn't use these MVP patterns like gwtp before understanding well the different View patterns, start reading here: http://martinfowler.com/eaaDev/SupervisingPresenter.html (martin fowler). Every situation is different, and simple adding a tool like gwtp might not work for you, even worse, might result in awkward buggy code. If you understand well the theory, you can always use (parts) these framework, but to my experience, if you understand well the patterns, you will not use them (anymore) and make things yourself as it's not a lot of coding. Personally I don't think I would use nested presenters, I did that in the past, but didn't like it. I use kind of Autonomous views - All my widgets extend from lightweight IsWidget objects that construct the actual Widget (builder pattern). I have good experience with it, like and results in good unit testing (I wrote something about that some time ago in this forum). Op woensdag 10 april 2013 01:30:55 UTC+2 schreef Mohammad Al-Quraian het volgende: I did my own way of nesting presenters and now I hit a design issue, should the nested presenter have a reference to the nesting presenter? Is there a better design than this? -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/cfj3qqhufKc/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Google Web Toolkit Developer Plugin - Install problem
Sorry, I forgot my PC specs. Windows 8 with the newes version of chrome. Am Mittwoch, 10. April 2013 07:27:36 UTC+2 schrieb Moe: Hello, i have a problem with the installation of GWT Developer Plugin for Chrome. I can't install, theres a message Diese Anwendung wird auf diesem Computer nicht unterstützt. Die Installation wurde deaktiviert.. This means, that my computer is not supported. Can you help me please? Thanks Moe -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: RequestFactory: .with causes NPE on server if returned value is null
Please open an issue. I don't have time to do it right now but
(tentatively) reproducing the issue is really easy in the current RF test
suite
(com.google.web.bindery.requestfactory.gwt.client.RequestFactoryTest#testNullEntityProxyResult),
so no need to attach a repro case (just link to this thread).
On Tuesday, April 9, 2013 10:51:19 AM UTC+2, Gordan Krešić wrote:
In pretty basic RF scenario, I'm fetching one EntityProxy from server:
myRequestContext.search(url).with(path1, path2).to(...).fire()
MyRequestContext.java:
@Service(ModelService.class)
public interface MyRequestContext extends RequestContext {
RequestModelProxy search(String url);
}
ModelService.search(String url) returns valid Model object *or* null if
not found.
Problem is, if search returns null value, .with(...) part in my client
request causes NPE on server:
09.04.2013. 10:34:48
com.google.web.bindery.requestfactory.server.RequestFactoryServlet doPost
SEVERE: Unexpected error
java.lang.NullPointerException
at
com.google.web.bindery.requestfactory.server.Resolver.addPathsToResolution(Resolver.java:488)
at
com.google.web.bindery.requestfactory.server.Resolver.resolveClientValue(Resolver.java:406)
at
com.google.web.bindery.requestfactory.server.SimpleRequestProcessor.processInvocationMessages(SimpleRequestProcessor.java:491)
at
com.google.web.bindery.requestfactory.server.SimpleRequestProcessor.process(SimpleRequestProcessor.java:233)
at
com.google.web.bindery.requestfactory.server.SimpleRequestProcessor.process(SimpleRequestProcessor.java:135)
at
com.google.web.bindery.requestfactory.server.RequestFactoryServlet.doPost(RequestFactoryServlet.java:133)
(...)
If I omit .with(...) part, request goes ok, giving me null or ModelProxy
instance (but without paths).
My current workaround is dumb but straightforward - two-phase search:
first without paths and if return value is not-null then I repeat same
request with paths. Where is the problem and is there a better workaround?
GWT is 2.5.1
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Google Web Toolkit Developer Plugin - Install problem
See https://code.google.com/p/google-web-toolkit/issues/detail?id=7778 On Wednesday, April 10, 2013 10:16:20 AM UTC+2, Moe wrote: Sorry, I forgot my PC specs. Windows 8 with the newes version of chrome. Am Mittwoch, 10. April 2013 07:27:36 UTC+2 schrieb Moe: Hello, i have a problem with the installation of GWT Developer Plugin for Chrome. I can't install, theres a message Diese Anwendung wird auf diesem Computer nicht unterstützt. Die Installation wurde deaktiviert.. This means, that my computer is not supported. Can you help me please? Thanks Moe -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Is there a set of best practices for implementing nested presenters/view?
Let me give you some idea's from what I use now, and which I like after trying/playing many things in the last 7 years with gwt: + Well defined overall functionality, like login, productInfo are contained in a component. The component has a Controller, View, if required a Presenter and always a Facade. The facade hide's all internal things and is the class that others use to communicate with the component. This setup has many advantages like clear, pushing events instead of pulling to overcome a Handler web that results in memory leaks, good unit testable as all required things like presenter, controller, view, widgets... etc.. are created through the facade and the facade is mocked through the GWTBridge during unit testing. + All controllers are lazy loaded through code splitting and hold in a central controller storage. + The View composes widget, not more, not less and take care that it keeps this responsibility during development as developers often put too much widget things in a view such that the view's become messy and hard to test. + In the View you use hardcore OO design and use things like HeaderPanel, ProductContainer, Product, StatusButton, etc... I can't stress enough the OO design, as if you do, you will see that flow's and coding becomes logic and stays maintenable such that it's easy and natural to add functionality. Yes, you probably complain that you get a lot of small objects, and the code often takes longer to understand, but that's OO, but the advantage of optimal reuse of small pieces of functionality. + Use standard patterns like factory, singleton, visitor, service, builder patterns, such that others can more easily understand the code. + Use lightweight widget (builders) that extend from IsWidget (ProductContainer extends from IsWidget), that contains logical and can easily be tested. + If these widget (builders) need to communicate with eachother I use a Communicate interface (or Informer interface) that is public but contained in the Widget itself. I't s usualy injected throug the constructor and required. + The Composer (father in your story) implements mostly all Communicator interfaces and delegates it to others, like: bubble it up to the controller, or let another widget do something. It all depends on the responsibility of every widget/component. For example: in my case, only the controller is allowed to communicate to the backend, such that only the controller contains Async callbacks. + Use a lot of Characteristic interfaces like HasId, HasEmpty, HasSize (just like GWT does), as this makes coding a lot easier as the Communicators are basically composed of these smaller interfaces... + The number of if conditions and static methods is a measurement for your OO coding. The more if statement, and static method usage, the less your are coding OO (this comes from the OO books). Anyway: I often use Singleton classes instead of static utility classes. The nice things of these singleton classes is that you can change their implementation through deferred binding. Example: CmsKeyNames that contains all cms keys, or CmsFactory (factory pattern). Too often I started with static methods and then needed other return value's under certain conditions (other app), which is hard when using static method as you can't do anything with it.. Changing them can be a pain. + etc Yes, it all results in more coding... but that's why people often complain that Java is a very verbose language ;) Especially when you want to correctly code OO. Above setup is especially friendly for long running app's that need to be changed in such a way that it stays maintenable and changes don't become too expensive. Above just came up, which I think contains some things you can use. Good luck. On Wed, Apr 10, 2013 at 9:35 AM, Mohammad Al Quraian m4des...@gmail.comwrote: Yeah, I don't have any intentions in using any more frameworks. Let me ask you this, let's say that you have a page which has multiple panels and in each panel there are multiple widgets. How would you go about implementing that yourself? I'm especially interested in the case that you wanted for some of these widget to communicate with each other. In my design, I made a 'father' presenter that has a few 'children' presenters, the idea here is that these presenters can communicate with each other directly (father to children and vice versa), with the father having the overall control. Of course, each presenter controls its own view and nobody knows about this view. Isn't that a good way of handling things or is it complicated? On Wed, Apr 10, 2013 at 10:22 AM, Ed post2edb...@gmail.com wrote: I wouldn't use these MVP patterns like gwtp before understanding well the different View patterns, start reading here: http://martinfowler.com/eaaDev/SupervisingPresenter.html (martin fowler). Every situation is different, and simple adding a tool like gwtp might not work for you, even worse, might result in
Re: Google Web Toolkit Developer Plugin - Install problem
Thank you very much. I will check it in the evening. Am Mittwoch, 10. April 2013 10:28:12 UTC+2 schrieb Thomas Broyer: See https://code.google.com/p/google-web-toolkit/issues/detail?id=7778 On Wednesday, April 10, 2013 10:16:20 AM UTC+2, Moe wrote: Sorry, I forgot my PC specs. Windows 8 with the newes version of chrome. Am Mittwoch, 10. April 2013 07:27:36 UTC+2 schrieb Moe: Hello, i have a problem with the installation of GWT Developer Plugin for Chrome. I can't install, theres a message Diese Anwendung wird auf diesem Computer nicht unterstützt. Die Installation wurde deaktiviert.. This means, that my computer is not supported. Can you help me please? Thanks Moe -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Is there a set of best practices for implementing nested presenters/view?
Wow, that's a lot to digest, I need some time for that. Thank you very much. Just a quick Q, controllers, views, presenters and facades are all different things? Also, wouldn't you consider facades a form of presenters? If not then what is the difference? I really like your input and hope more people contribute to this discussion. Thansks On Wed, Apr 10, 2013 at 11:49 AM, Ed Bras post2edb...@gmail.com wrote: Let me give you some idea's from what I use now, and which I like after trying/playing many things in the last 7 years with gwt: + Well defined overall functionality, like login, productInfo are contained in a component. The component has a Controller, View, if required a Presenter and always a Facade. The facade hide's all internal things and is the class that others use to communicate with the component. This setup has many advantages like clear, pushing events instead of pulling to overcome a Handler web that results in memory leaks, good unit testable as all required things like presenter, controller, view, widgets... etc.. are created through the facade and the facade is mocked through the GWTBridge during unit testing. + All controllers are lazy loaded through code splitting and hold in a central controller storage. + The View composes widget, not more, not less and take care that it keeps this responsibility during development as developers often put too much widget things in a view such that the view's become messy and hard to test. + In the View you use hardcore OO design and use things like HeaderPanel, ProductContainer, Product, StatusButton, etc... I can't stress enough the OO design, as if you do, you will see that flow's and coding becomes logic and stays maintenable such that it's easy and natural to add functionality. Yes, you probably complain that you get a lot of small objects, and the code often takes longer to understand, but that's OO, but the advantage of optimal reuse of small pieces of functionality. + Use standard patterns like factory, singleton, visitor, service, builder patterns, such that others can more easily understand the code. + Use lightweight widget (builders) that extend from IsWidget (ProductContainer extends from IsWidget), that contains logical and can easily be tested. + If these widget (builders) need to communicate with eachother I use a Communicate interface (or Informer interface) that is public but contained in the Widget itself. I't s usualy injected throug the constructor and required. + The Composer (father in your story) implements mostly all Communicator interfaces and delegates it to others, like: bubble it up to the controller, or let another widget do something. It all depends on the responsibility of every widget/component. For example: in my case, only the controller is allowed to communicate to the backend, such that only the controller contains Async callbacks. + Use a lot of Characteristic interfaces like HasId, HasEmpty, HasSize (just like GWT does), as this makes coding a lot easier as the Communicators are basically composed of these smaller interfaces... + The number of if conditions and static methods is a measurement for your OO coding. The more if statement, and static method usage, the less your are coding OO (this comes from the OO books). Anyway: I often use Singleton classes instead of static utility classes. The nice things of these singleton classes is that you can change their implementation through deferred binding. Example: CmsKeyNames that contains all cms keys, or CmsFactory (factory pattern). Too often I started with static methods and then needed other return value's under certain conditions (other app), which is hard when using static method as you can't do anything with it.. Changing them can be a pain. + etc Yes, it all results in more coding... but that's why people often complain that Java is a very verbose language ;) Especially when you want to correctly code OO. Above setup is especially friendly for long running app's that need to be changed in such a way that it stays maintenable and changes don't become too expensive. Above just came up, which I think contains some things you can use. Good luck. On Wed, Apr 10, 2013 at 9:35 AM, Mohammad Al Quraian m4des...@gmail.comwrote: Yeah, I don't have any intentions in using any more frameworks. Let me ask you this, let's say that you have a page which has multiple panels and in each panel there are multiple widgets. How would you go about implementing that yourself? I'm especially interested in the case that you wanted for some of these widget to communicate with each other. In my design, I made a 'father' presenter that has a few 'children' presenters, the idea here is that these presenters can communicate with each other directly (father to children and vice versa), with the father having the overall control. Of course, each presenter controls its own view and
Re: Repainting a canvas - clear or create new object?
Isn't this what I'm doing if I save everything that is not dragged to an image an draw this static image behind the drag context? If not, could you be more specific? 2013/4/9 David Durham david.durham...@gmail.com There's a trick where you layer Canvas elements on top of each other, because you don't necessarily want to redraw everything, only what's changed. I have an example (though no source code available yet): http://gdldemo.appspot.com/ On Fri, Apr 5, 2013 at 11:45 AM, Thad thad.humphr...@gmail.com wrote: Without timing this, I can't say for sure. However I suspect ctx.clearRect(0, 0, clientWidth(), clientHeight()) is faster as it calls clearRect on the JavaScriptObject while creating a new Canvas requires the DOM to create a new object. On Wednesday, April 3, 2013 10:13:34 AM UTC-4, membersound wrote: Hi, when a Canvas is often cleared and redrawn (for example during a drag and drop action): would it be better to call ctx.clearRect(0, 0, clientWidth(), clientHeight())? Or just create a new Canvas by Canvas.createIfSupported() and replace the currently drawn canvas by the new one? Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/MXGRDjc6toQ/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Is there a set of best practices for implementing nested presenters/view?
Just a quick Q, controllers, views, presenters and facades are all different things? Yes, different. Facades have nothing to do with presenters, controllers in this case. Facades are just stupid things that form the central access to something, in my case: the component. I use the component facade for example: 1) To create the controller, view, presenter, etc.. as the facade is mocked during testing such that I can inject mocked controllers/views/widgets/ 2) App flow methods, for example the method HeaderMenuFacade contains the method afterSuccessLogin(String), such that it get informed by another component, like the LoginFacade, that a login with was performed with success. The HeaderMenuFacade now delegates this to the controller ( if loaded), such that it can update the header menu... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Repainting a canvas - clear or create new object?
How do you stack multiple canvas onto each other?
I tried the following, which only placed them below each other so that both
are visible at a time.
.layer1 {
z-index: 1;
left: 0;
top: 0;
}
.layer2 {
z-index: 0;
left: 0;
top: 0;
}
gwt:AbsolutePanel
c:Canvas styleName={style.layer1} /
c:Canvas styleName={style.layer2} /
/gwt:AbsolutePanel
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: clear browser cache automatically?
Hi, thanks! Now which solution is better? Am Mittwoch, 3. April 2013 14:06:07 UTC+2 schrieb ocaner: script src=m1/m1.nocache.js?version=1.0.1/script Does it have to be the attribute version and does its value have to change on every deployment? If so, I'd prefer the filter because then I can forget it... .-) Magnus -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
moveable areas as in iGoogle?
Hi, how can one realize such moveable areas, which can be placed with drag drop at predefined positions, such as in iGoogle? Is there a tutorial? Thanks Magnus -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
How to globally catch all exceptions?
Hi, how could one best catch all exceptions within the application that occur and are not handled anywhere? Would it just require a try-catch block in the onModuleLoad()? Or maybe an extra Servlet? Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: moveable areas as in iGoogle?
You need some kind of drag drop functionality. You can either use the built-in GWT drag drop support (which is based on the HTML5 drag drop API [1]), or use the always handy gwt-dnd [2]. Do note that HTML5 dd API is about moving data, not actual widgets, but it can be used also in that way, instead with gwt-dnd you really move things around. See the showcase [3], in which you can find some useful samples that may work for you. [1] http://www.html5rocks.com/en/tutorials/dnd/basics/ [2] http://code.google.com/p/gwt-dnd/ [3] https://gwt-dnd.appspot.com/#InsertPanelExample On Wednesday, April 10, 2013 12:33:33 PM UTC+2, Magnus wrote: Hi, how can one realize such moveable areas, which can be placed with drag drop at predefined positions, such as in iGoogle? Is there a tutorial? Thanks Magnus -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: How to globally catch all exceptions?
Use the GWT.setUncaughtExceptionHandler() [1]. [1] http://google-web-toolkit.googlecode.com/svn/javadoc/latest/com/google/gwt/core/client/GWT.html#setUncaughtExceptionHandler%28com.google.gwt.core.client.GWT.UncaughtExceptionHandler%29 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Repainting a canvas - clear or create new object?
If you don't want the lower layer to show through, you need to fill the
upper layer with an opaque (alpha 1.0) color.
The transparency of canvas is a good think at least for one of my apps. I
have three Canvas, all stacked in an AbsolutePanel. The lowest Canvas holds
an image (a PNG that was converted on the server from a scanned TIFF). The
next layer holds objects the user has drawn on the Canvas. The top-most
layer is the interactive drawing layer, where I track mouse down, move, and
up. (There's also a fourth Canvas that is not on screen. I use this for
testing if clicks on the AbsolutePanel are clicks on a current object.)
On Wednesday, April 10, 2013 6:01:58 AM UTC-4, membersound wrote:
How do you stack multiple canvas onto each other?
I tried the following, which only placed them below each other so that
both are visible at a time.
.layer1 {
z-index: 1;
left: 0;
top: 0;
}
.layer2 {
z-index: 0;
left: 0;
top: 0;
}
gwt:AbsolutePanel
c:Canvas styleName={style.layer1} /
c:Canvas styleName={style.layer2} /
/gwt:AbsolutePanel
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Is there a set of best practices for implementing nested presenters/view?
One more things that popped up: + Use WidgetDisplayer interface with methods like show(IsWiget) (or multiple widgets) and isShowing(IsWidget). This is used by the Views to show their content, such that you abstract the location (and how) it's content is shown. You often specify these WidgetDisplayers through the constructor such that the creator (Component facade) decides how/where something is displayed. I found this very nice and it results in flexibiltiy when you want to change the display and you don't need to touch the views. In this way you can easily use different WidgetDisplay implementations for different displayes like a mobile or desktop web display. I have DisplayFacade (a singleton ofcourse) that contains all the WidgetDisplay implementations. It's located in it's own package and all WidgetDisplay implementations are packages protected, together with a HtmlConnector that determines the locations on the html display. I almost always show my content through animation, like Fade In and Fade out (nice user experience) which you can nicely put in these WidgetDisplayers (or HtmlConnector)... Works like a Charm... (and the story continues ;) ) just my 50 cents... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Removing obfuscation from a stack trace.
The symbolmaps are created in shark_sencha_prototype/symbolMaps, I can see them there. However any value I try to specify for param-namesymbolMaps/param-name still results in an obfuscated stack trace. I attached eclipse to Tomcat and whenever RemoteLoggingServiceImpl.logOnServer() is invoked, deobfusactor is null. Breaking on the other methods that might set the symbol directory and instantiating deobfusactor never get tripped. Does anyone know what code is responsible for reading param-namesymbolMaps/param-name? I'd love to step through that to see what is happening. On Tuesday, April 9, 2013 4:06:23 PM UTC+1, Flying-w wrote: I've implemented server side logging of client side exceptions, by making the following changes in gwt.xml: set-property name=compiler.stackMode value=emulated / set-configuration-property name=compiler.emulatedStack.recordLineNumbers value=true / set-configuration-property name=compiler.emulatedStack.recordFileNames value=true / A custom implementation SimpleRemoteLogHandler provides the handler to relay the messages to the server. And a servlet: servlet servlet-nameremoteLogging/servlet-name servlet-classcom.google.gwt.logging.server.RemoteLoggingServiceImpl/servlet-class init-param param-namesymbolMaps/param-name param-valueshark_sencha_prototype/symbolMaps/param-value /init-param /servlet servlet-mapping servlet-nameremoteLogging/servlet-name url-pattern/shark_sencha_prototype/remote_logging/url-pattern /servlet-mapping When an exception occurs (for example an operation on a null string), the stack trace below is typical of what shows up. I was expecting RemoteLoggingServiceImpl to fully remote the obfuscation, however is this as good as it gets? It feels like there should me more, as it's doing nothing more than mirroring what can also be reported on the client concerning the exception. com.google.gwt.core.client.JavaScriptException: (TypeError): Cannot call method 'Bl' of null Unknown.he(StackTraceCreator.java:174) Unknown.Oc(StackTraceCreator.java:501) Unknown.uS(Exceptions.java:29) Unknown.Zid(JobsTab.java:293) Unknown.Kfd(CategoryTabs.java:81) ... Thanks Simon -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Problem with TabSelector Widget.
I have a TabSelector Wedgit that I am adding and removing different
objects based on the users navigation. The problem is that the
objects that I remove are still around and catching event from the
bus.
Is there a way to distroy the objects after removing them from the
tabSelector?
Thanks
public void handleSelectedLinkTab(String linkTabName)
{
this.remove(1);
int groupIndex = rmHomeTab.getSelectedGroupIndex();
int acctIndex = rmHomeTab.getSelectedAccountIndex();
if (Characteristics.equals(linkTabName))
{
this.add(v4PageGeneratorTab,linkTabName, false);
v4PageGeneratorTab.launchLinkTab(groupIndex,
acctIndex,linkTabName);
}else if (Holdings By Category.equals(linkTabName))
{
this.add(holdingsByCategoryTab,linkTabName, false);
holdingsByCategoryTab.processGoEvent(groupIndex,
acctIndex);
}else if (Recipients - All.equals(linkTabName))
{
this.add(v4PageGeneratorTab,linkTabName, false);
v4PageGeneratorTab.launchLinkTab(groupIndex,
acctIndex,linkTabName);
}
this.selectTab(1);
}
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT Developer Plugin on Safari 5.1 (OS X Lion 10.7) doesn't load
Hi, I've been trying to get familiar with the source to see if I can pitch in and help out (with the plugin that is). I noticed that in the Makefile in jni/mac, it looks like gwt-webkit.h gets generated from com.google.gwt.dev.shell.mac.LowLevelSaf (which presumably has some JNI stuff) But I can't for the life of me find LowLevelSaf. Apologies if I've missed something obvious. -Mike On Wednesday, 20 July 2011 12:28:21 UTC-7, Eric B. Ridge wrote: Is there a trick to get the currently-available-for-Safari plugin to work with Safari 5.1/OS X 10.7? Safari refuses to load it, and I can find no indication as to why. (fortunately, I keep around a copy of Safari 4.0.5 so I can keep working.) Any insight will be greatly appreciated! eric -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Removing obfuscation from a stack trace.
RemoteLoggingServiceImpl does not read any init parameters from your
web.xml.
You should do something like:
public class MyRemoteLoggingService extends RemoteLoggingServiceImpl {
@Override
public void init() throws ServletException {
super.init();
setSymbolMapsDirectory(getServletContext().getRealPath('/WEB-INF/deploy/app/symbolMaps'));
}
}
If you don't want to hardcode the path then you can read it from your
init-param web.xml entry instead
(getServletContext().getInitParameter(name))
-- J.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Problem with TabSelector Widget.
The base object is DecoratedTabPanel
On Apr 10, 10:48 am, skippy al.leh...@fisglobal.com wrote:
I have aTabSelectorWedgit that I am adding and removing different
objects based on the users navigation. The problem is that the
objects that I remove are still around and catching event from the
bus.
Is there a way to distroy the objects after removing them from thetabSelector?
Thanks
public void handleSelectedLinkTab(String linkTabName)
{
this.remove(1);
int groupIndex = rmHomeTab.getSelectedGroupIndex();
int acctIndex = rmHomeTab.getSelectedAccountIndex();
if (Characteristics.equals(linkTabName))
{
this.add(v4PageGeneratorTab,linkTabName, false);
v4PageGeneratorTab.launchLinkTab(groupIndex,
acctIndex,linkTabName);
}else if (Holdings By Category.equals(linkTabName))
{
this.add(holdingsByCategoryTab,linkTabName, false);
holdingsByCategoryTab.processGoEvent(groupIndex,
acctIndex);
}else if (Recipients - All.equals(linkTabName))
{
this.add(v4PageGeneratorTab,linkTabName, false);
v4PageGeneratorTab.launchLinkTab(groupIndex,
acctIndex,linkTabName);
}
this.selectTab(1);
}
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Problem with DecoratedTabPanel.
I have a DecoratedTabPanel that I am adding and removing different
objects based on the users navigation. The problem is that after the
object is removed they are still around and catching event from the
bus.
Is there a way to distroy the objects after removing them from the
DecoratedTabPanel?
Thanks
public void handleSelectedLinkTab(String linkTabName)
{
this.remove(1);
int groupIndex = rmHomeTab.getSelectedGroupIndex();
int acctIndex = rmHomeTab.getSelectedAccountIndex();
if (Characteristics.equals(linkTabName))
{
this.add(v4PageGeneratorTab,linkTabName, false);
v4PageGeneratorTab.launchLinkTab(groupIndex,
acctIndex,linkTabName);
}else if (Holdings By Category.equals(linkTabName))
{
this.add(holdingsByCategoryTab,linkTabName, false);
holdingsByCategoryTab.processGoEvent(groupIndex,
acctIndex);
}else if (Recipients - All.equals(linkTabName))
{
this.add(v4PageGeneratorTab,linkTabName, false);
v4PageGeneratorTab.launchLinkTab(groupIndex,
acctIndex,linkTabName);
}
this.selectTab(1);
}
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Problem with DecoratedTabPanel.
Store the HandlerRegistration instance you get from the event bus and call HandlerRegistration.removeHandler() when your widget is removed from the DOM. You can override Widget.onLoad() and Widget.onUnload() to add/remove your event handlers. -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Eclipse Junu 64 bit version
Is there a GWT Plug-in for this version and does this effect the browser plug-in for debugging? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
How does GWT work with App Engine backends?
Hi All, I'm trying to find some documentation on how to get GWT working with an App Engine backend. The sample code GWT generates is enough to get servlets up and running, but not much else. The available documentation from Google has helped me to properly configure backends.xml, and I can see the backend instance on my App Engine dashboard. From here on I'm stuck. thanks, Chris -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
How to detect emailid in text box and put cross symbol
Hi, I am very new to GWT. I want to design a form like Gmail mail compose window. I have a text area where I enter lots of email id's. What I want is when user enters one email id , it automatically makes it look like a textbox with cross icon besides it, same as it happens in Gmail. Any pointers regarding this would be really helpful. Is there a component like that available? If not then how can I extend it? Please help. Thanks, Anshu -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: moveable areas as in iGoogle?
If you want to use a thirdparty api to do it, GXT has it ready to go. http://www.sencha.com/examples/#ExamplePlace:portallayout Brandon On Wednesday, April 10, 2013 3:33:33 AM UTC-7, Magnus wrote: Hi, how can one realize such moveable areas, which can be placed with drag drop at predefined positions, such as in iGoogle? Is there a tutorial? Thanks Magnus -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to find '.gwt.xml' on your classpath (again)
Do you know if the Project.gwt.xml is ont he client side? ./project/client/Project.gwt.xml Screenshot your directory layout and post it here. On Monday, April 8, 2013 10:45:50 PM UTC-7, Andy King wrote: I am at my wits end with this problem ... I've looked at suggested solutions, but none have worked. Here is the (all-too-familiar) error that I see in the GWT Development Mode window: [DEBUG] [fosterapet] - Loading inherited module 'fosterapet' [ERROR] [fosterapet] - Unable to find 'fosterapet.gwt.xml' on your classpath; could be a typo, or maybe you forgot to include a classpath entry for source? [ERROR] [fosterapet] - Failed to load module 'fosterapet' from user agent 'Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.43 Safari/537.31' at 127.0.0.1:51716 The project that is referenced in this error, fosterapet, is unrelated to the project that I'm working on ... I don't want to inherit the gwt.xml file from the fosterapet project. I have the new project on two machines, and it works without a problem on one of the machines. On the machine that gives the above error I have even deleted the entire project (deleting the contents on disk), deleted the run configuration for the project, and imported the project from SVN. I then right-clicked on the project (in Eclipse) and selected Run As - Web Application, and get the same error. I just don't know where the reference to the fosterapet project is coming from. I've searched all files under the project directory using grep, and there doesn't appear to be any mention of fosterapet. Note that there is no gwt-unitCache directory when I try to run the project for the first time. Perhaps there's something in the browser (Chrome) that is cached? I am so sorry to ask what seems to be a question that has been answered many times before. The only difference that I see in my situation is that the referenced file is not something that I even want in this project. I really appreciate any help that is offered! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: UIBundle XML not seeing CSS styles
Another option: Css Resources https://github.com/branflake2267/Archetypes/blob/master/archetypes/gwt-css/src/main/java/org/gonevertical/project/client/resources/Resources.java CSS Injection https://github.com/branflake2267/Archetypes/blob/master/archetypes/gwt-css/src/main/java/org/gonevertical/project/client/ProjectEntryPoint.java#L17 UiBinder https://github.com/branflake2267/Archetypes/blob/master/archetypes/gwt-css/src/main/java/org/gonevertical/project/client/application/LayoutWidget.ui.xml Sample the project: https://github.com/branflake2267/Archetypes/tree/master/archetypes/gwt-css Brandon On Monday, April 8, 2013 11:36:58 AM UTC-7, brec wrote: Thanks, Jens! (In case you saw my earlier response, since deleted -- that was due to a typo in implementing your correction.) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Problems trying to run MobileWebApp.
I'm having so many issues running this sample app, I was able to run it using the maven command line with some problems but it works. When I import it to eclipse I encounter many problems for example: HTTP ERROR: 500 No realm RequestURI=/MobileWebApp.html *Powered by Jetty://* I wish that someone would try to fix and update this sample app because it is very comprehensive and covers many aspects of GWT. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to find '.gwt.xml' on your classpath (again)
Well, I found a solution, although I don't know why the original project doesn't work. The fact that the project ran with no problem on one machine, but had problems on the other machine, seemed to point to a difference in configuration. I renamed the .html file, TimeToPlay.html, to TimeToPlay2.html, and changed the run configuration to point to it. This was successful, and the application now runs. If I change the name (an run configuration) back to TimeToPlay.html then it appears that a different html file is being picked up ... I just can't figure out where it's coming from. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Identify or get around popup blockers
This is how to do it without native JavaScript: First, create an empty window with the name mySiperPuperTarget. This must be called synchronously i.e. not from any callback: Window.open(, mySuperPuperTarget, ); Now, you can use the mySuperPuperTarget as a target name for your form and submit the from: FormElement.as(form.getElement()).setTarget(mySuperPuperTarget); The result of the submission will go to the new window. Since the new window is open in a sync call, there will be no popup blocker triggered. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Linker bug with useSourceMaps
I'm trying to fix a bug (
https://code.google.com/p/google-web-toolkit/issues/detail?id=8100
), and I could use some expert advice. I'm a long time GWT user (7
years), but only recently started hacking the internals, and I need
help on this one.
Background:
SelectionScriptLinker.splitPrimaryJavaScript attempts to check whether
the property compiler.useSourceMaps is true and if it is, the
method avoids splitting the javascript into chunks (which would
destroy the accuracy of the line numbers in the source map).
The Problem:
This method tries to get the property value from
LinkerContext.getProperties, which is not a PropertyOracle, and hence
it can't return the correct property value for the current
permutation. In fact, it will return a null value unless the property
has a static value for all permutations (e.g. set-property
name=compiler.useSourceMaps value=true/)
However, something like
set-property name=compiler.useSourceMaps value=true
when-property-is name=user.agent value=safari/
/set-property
will not work because SelectionScriptLinker.splitPrimaryJavaScript can
only read static property values.
Could someone advise me on how to fix this bug?
Here's is there relevant source code for quick reference:
public static String splitPrimaryJavaScript(StatementRanges ranges,
String js,
int charsPerChunk, String scriptChunkSeparator, LinkerContext
context) {
boolean useSourceMaps = false;
for (SelectionProperty prop : context.getProperties()) {
if (USE_SOURCE_MAPS_PROPERTY.equals(prop.getName())) {
String str = prop.tryGetValue();
useSourceMaps = str == null ? false :
Boolean.parseBoolean(str);
break;
}
}
// TODO(cromwellian) enable chunking with sourcemaps
if (charsPerChunk 0 || ranges == null || useSourceMaps) {
return js;
}
...
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups
Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Thomas Broyer has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: IIRC, this new behavior is also consistent with @Inject in google-gin which again makes sense to me. But this causes code-bloats because the compiler cannot optimize the same as with non-JSNI methods; at least that was the case some time ago, maybe it has changed): https://code.google.com/p/google-gin/issues/detail?id=35 -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: add StringBuffer/Builder.reverse
Daniel Kurka has posted comments on this change. Change subject: add StringBuffer/Builder.reverse .. Patch Set 1: (1 comment) File user/test/com/google/gwt/emultest/java/lang/StringBufferTest.java Line 276: assertEquals(\uD801\uDC00abce, new StringBuffer(ecba\uD801\uDC00).reverse().toString()); those are all invalid strings since surrogates can only appear in pairs and the first surrogate has to be in the range 0xD800 - 0xDBFF while the second has to be in the range 0xDC00 - 0xDFFF. This is why the standard values can only be in the range 0x000 - 0xD7FF and 0xE000 - 0x. -- To view, visit https://gwt-review.googlesource.com/2431 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: add StringBuffer/Builder.reverse
Daniel Kurka has uploaded a new patch set (#2). Change subject: add StringBuffer/Builder.reverse .. add StringBuffer/Builder.reverse fixes ISSUE 449 Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Review-Link: https://gwt-review.googlesource.com/#/c/2431/ --- M user/src/com/google/gwt/core/client/impl/StringBufferImpl.java M user/src/com/google/gwt/core/client/impl/StringBufferImplAppend.java M user/src/com/google/gwt/core/client/impl/StringBufferImplArrayBase.java M user/super/com/google/gwt/emul/java/lang/StringBuffer.java M user/super/com/google/gwt/emul/java/lang/StringBuilder.java M user/test/com/google/gwt/emultest/java/lang/StringBufferTest.java 6 files changed, 94 insertions(+), 2 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2431 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: add StringBuffer/Builder.reverse
Daniel Kurka has uploaded a new patch set (#3). Change subject: add StringBuffer/Builder.reverse .. add StringBuffer/Builder.reverse fixes ISSUE 449 Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Review-Link: https://gwt-review.googlesource.com/#/c/2431/ --- M user/src/com/google/gwt/core/client/impl/StringBufferImpl.java M user/src/com/google/gwt/core/client/impl/StringBufferImplAppend.java M user/src/com/google/gwt/core/client/impl/StringBufferImplArrayBase.java M user/super/com/google/gwt/emul/java/lang/StringBuffer.java M user/super/com/google/gwt/emul/java/lang/StringBuilder.java M user/test/com/google/gwt/emultest/java/lang/StringBufferTest.java 6 files changed, 93 insertions(+), 2 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2431 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Prevent dev mode breakage when lots of jso classes are used.
John Ahlroos has uploaded a new patch set (#3). Change subject: Prevent dev mode breakage when lots of jso classes are used. .. Prevent dev mode breakage when lots of jso classes are used. Elemental introduces a lot of native classes that can cause dev mode to swell and break. Fixes issue 7481, as well as an unfiled bug whereby jsni calls on Class objects cause a dev mode security exception when trying to set accessibility on Class constructor. Rietveld: http://gwt-code-reviews.appspot.com/1801804/ Change-Id: I0c703d592556c500e338f95469b2db13f8024627 Author: John Ahlroos j...@vaadin.com --- M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java M dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java 2 files changed, 24 insertions(+), 15 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c703d592556c500e338f95469b2db13f8024627 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Nelson ja...@wetheinter.net Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Prevent dev mode breakage when lots of jso classes are used.
John Ahlroos has posted comments on this change. Change subject: Prevent dev mode breakage when lots of jso classes are used. .. Patch Set 3: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c703d592556c500e338f95469b2db13f8024627 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Nelson ja...@wetheinter.net Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Widget Iterator now throws NoSuchElementExceptions correctly.
Daniel Kurka has uploaded a new patch set (#4). Change subject: Widget Iterator now throws NoSuchElementExceptions correctly. .. Widget Iterator now throws NoSuchElementExceptions correctly. Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f Review-Link: https://gwt-review.googlesource.com/#/c/2440/ --- M user/src/com/google/gwt/user/client/ui/WidgetCollection.java M user/test/com/google/gwt/user/client/ui/WidgetCollectionTest.java 2 files changed, 89 insertions(+), 5 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Widget Iterator now throws NoSuchElementExceptions correctly.
Daniel Kurka has uploaded a new patch set (#5). Change subject: Widget Iterator now throws NoSuchElementExceptions correctly. .. Widget Iterator now throws NoSuchElementExceptions correctly. Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f Review-Link: https://gwt-review.googlesource.com/#/c/2440/ --- M user/src/com/google/gwt/user/client/ui/WidgetCollection.java M user/test/com/google/gwt/user/client/ui/WidgetCollectionTest.java 2 files changed, 88 insertions(+), 5 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
John Ahlroos has uploaded a new patch set (#3). Change subject: Workaround for resolving mouse button on mouse move in Firefox .. Workaround for resolving mouse button on mouse move in Firefox Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa --- M user/src/com/google/gwt/dom/client/DOMImplMozilla.java 1 file changed, 26 insertions(+), 0 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2330 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...
Daniel Kurka has posted comments on this change. Change subject: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration .. Patch Set 1: Hi Julien, I can't find you on the CLA-SIGNERS list: https://code.google.com/p/google-web-toolkit/source/browse/CLA-SIGNERS Did you already submit a CLA? -Daniel -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Daniel Kurka has posted comments on this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Patch Set 2: Hello Christian, I could not find you on the CLA signers list: https://code.google.com/p/google-web-toolkit/source/browse/CLA-SIGNERS Could you submit a cla using one of this two this form (whichever suites you): https://developers.google.com/web-toolkit/makinggwtbetter#clas -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner christ...@quelltextlich.at Gerrit-Reviewer: Christian Aistleitner christ...@quelltextlich.at Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...
Julien Dramaix has posted comments on this change. Change subject: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration .. Patch Set 1: I signed the following one : https://developers.google.com/open-source/cla/individual?hl=fr -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: set target and source level to 1.6 for JSP compilation
Daniel Kurka has abandoned this change. Change subject: set target and source level to 1.6 for JSP compilation .. Abandoned Submitted -- To view, visit https://gwt-review.googlesource.com/2201 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Idd3d751c5eb2008a7a1e51536580d56a0fb3603f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: fixing possible NPE in on CellWidget.onBrowserEvent if cell ...
Daniel Kurka has abandoned this change. Change subject: fixing possible NPE in on CellWidget.onBrowserEvent if cell does not consume any events fixes issue 7649 .. Abandoned Submitted -- To view, visit https://gwt-review.googlesource.com/1721 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6d9b4979d7b68e7ff8fa652ab54635d2cc690fd9 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: add StringBuffer/Builder.reverse
Goktug Gokdogan has posted comments on this change. Change subject: add StringBuffer/Builder.reverse .. Patch Set 3: (1 comment) File user/src/com/google/gwt/core/client/impl/StringBufferImpl.java Line 46: buffer[i] = origBuffer[length - 1 - i]; toCharArray copies the string using charAt behind the scenes. If you use s.charAt(length-1-i) here, you can get rid of the extra copy. -- To view, visit https://gwt-review.googlesource.com/2431 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Goktug Gokdogan has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: I think there are optimization steps in JS which can reduce the code bloat. Roberto, can you take a look and see if this ends up causing any significant amount increase in the final output? -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Widget Iterator now throws NoSuchElementExceptions correctly.
Goktug Gokdogan has posted comments on this change. Change subject: Widget Iterator now throws NoSuchElementExceptions correctly. .. Patch Set 5: Code-Review+1 (1 comment) File user/test/com/google/gwt/user/client/ui/WidgetCollectionTest.java Line 173: } Test cases look pretty good. Usually it is best to have separate tests for different cases so that you have better reporting from test failures. Also Google practice is using testMethod_testScenario as the test name (e.g. testIterator_doubleRemove) but I'm not sure if GWT uses the same convention. -- To view, visit https://gwt-review.googlesource.com/2440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Roberto Lublinerman has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: The JsInliner should take care of this case. Methods that are called in only one place (like the *__native one in this case) are inlined. The only drawback is that this happens quite late. I'll have a look and make sure it is properly inlined and see if we it makes us miss some optimization opportunities. -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Thomas Broyer has posted comments on this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Patch Set 2: Daniel, isn't the CLA process handled by Gerrit now? (BTW, CLA-SIGNERS is manually-edited and I believe there's a list inside Google with more people than those listed in this file; see the last commit: Bradley added in June when he actually signed the CLA in February) -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner christ...@quelltextlich.at Gerrit-Reviewer: Christian Aistleitner christ...@quelltextlich.at Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Thomas Broyer has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: A simple fix is to only use the JSNI method if the method is private. And in that case, also emit a warning that we only support this scenario for backwards compatibility (see Brian and Matthew comments; though there are already cases which violates the least-surprise principle Brian points out: JSR303 –not stripped-down profile that Dagger implements, despite being more sensible IMO– does allow @Inject-ing private classes/ctors/fields/methods) and will remove it in a future release. BTW, have you tried updating the existing code that uses privates using a script/whatever? -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: set target and source level to 1.6 for JSP compilation
Thomas Broyer has posted comments on this change. Change subject: set target and source level to 1.6 for JSP compilation .. Patch Set 2: So Daniel, how does it feel to be on the other side now? ;-) -- To view, visit https://gwt-review.googlesource.com/2201 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd3d751c5eb2008a7a1e51536580d56a0fb3603f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Roberto Lublinerman has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: The existing code is already fixed. The question remains whether we want to allow private @UiHandlers and @UiFields as a feature or not. I am neutral in that respect. Should we take a vote? -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Goktug Gokdogan has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: Actually we discussed this internally and we have an agreement on our side to add the support as a feature. I'm keeping the thread up to date and would like to hear if you still have any concerns: 1. In UiBinder, the xml is more like a part of the view class itself that is extracted out to make it more declarative and it can be considered as internal. From that point of view, we are not really violating the semantics of the private (at least as not much as in @inject case.) 2. UiFields are nearly always only used in the class itself. When we don't declare them private, then it is difficult to discover if they are used or not as the IDE will not point that out. 3. Tools are already aware of the fact that methods with annotations are usually used by magic and provides easy ways to configure as this is kind of a common practice in java. -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Linker bug with useSourceMaps
Okay, I found a pretty good solution. Solved the problem by adding a
method isSourceMapsEnabled to CompilationResult, which gets passed all
the way from Link to SelectionScriptLinker. The value is set in Link
via the permutation's property oracles. I tested this and it works
well!
Now, how can I contribute this patch? Long time user, first time
contributor. I signed the CLA many years ago, but haven't submitted
anything until now.
Are the instructions on
https://developers.google.com/web-toolkit/makinggwtbetter
still valid?
I'm a little confused because that document says Upload the patch to
the Rietveld instance at http://gwt-code-reviews.appspot.com/; whereas
I'm seeing all the messages in this group coming from a system called
Gerrit at https://gwt-review.googlesource.com/
On Apr 10, 2:39 am, Alex Epshteyn alexander.epsht...@gmail.com
wrote:
I'm trying to fix a bug
(https://code.google.com/p/google-web-toolkit/issues/detail?id=8100
), and I could use some expert advice. I'm a long time GWT user (7
years), but only recently started hacking the internals, and I need
help on this one.
Background:
SelectionScriptLinker.splitPrimaryJavaScript attempts to check whether
the property compiler.useSourceMaps is true and if it is, the
method avoids splitting the javascript into chunks (which would
destroy the accuracy of the line numbers in the source map).
The Problem:
This method tries to get the property value from
LinkerContext.getProperties, which is not a PropertyOracle, and hence
it can't return the correct property value for the current
permutation. In fact, it will return a null value unless the property
has a static value for all permutations (e.g. set-property
name=compiler.useSourceMaps value=true/)
However, something like
set-property name=compiler.useSourceMaps value=true
when-property-is name=user.agent value=safari/
/set-property
will not work because SelectionScriptLinker.splitPrimaryJavaScript can
only read static property values.
Could someone advise me on how to fix this bug?
Here's is there relevant source code for quick reference:
public static String splitPrimaryJavaScript(StatementRanges ranges,
String js,
int charsPerChunk, String scriptChunkSeparator, LinkerContext
context) {
boolean useSourceMaps = false;
for (SelectionProperty prop : context.getProperties()) {
if (USE_SOURCE_MAPS_PROPERTY.equals(prop.getName())) {
String str = prop.tryGetValue();
useSourceMaps = str == null ? false :
Boolean.parseBoolean(str);
break;
}
}
// TODO(cromwellian) enable chunking with sourcemaps
if (charsPerChunk 0 || ranges == null || useSourceMaps) {
return js;
}
...
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups
Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Linker bug with useSourceMaps
On Wed, Apr 10, 2013 at 12:22 PM, Alex Epshteyn alexander.epsht...@gmail.com wrote: Thanks Thomas! Is it possible to still use SVN by any chance? We'll continue accepting patches from Rietveld, just it's a bit more work for us to merge them. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Brian Slesinsky has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: I agree that we should indirect through JSNI only if the method is actually private. This could be a performance issue in devmode because it adds a round trip between the browser and the JVM. (Is there some way to avoid the round trip?) I think it's simpler to not change the spec but I will defer to people who use UiBinder more. -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Linker bug with useSourceMaps
Gotcha. I will certainly have more than one patch to contribute now that I've really dived into the GWT compiler internals, so I might as well start working with the new git-based system to make things easier for everyone. I've already made quite a few other enhancements and bug fixes to the whole web mode exceptions reporting toolchain, which are going into the next release of my product, TypeRacer, and I'm eager to contribute those back to GWT. I'll probably write up a blog post about my experiments and enhancements in the coming weeks. Anyways, could you guys provide me with some command line examples of the whole process using git, starting from checking out the code to submitting a patch for review? Thanks in advance. I'm eager to get started! On Wed, Apr 10, 2013 at 3:39 PM, Matthew Dempsky mdemp...@google.comwrote: On Wed, Apr 10, 2013 at 12:22 PM, Alex Epshteyn alexander.epsht...@gmail.com wrote: Thanks Thomas! Is it possible to still use SVN by any chance? We'll continue accepting patches from Rietveld, just it's a bit more work for us to merge them. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit-contributors/QaHTo59D_GY/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Linker bug with useSourceMaps
On Wednesday, April 10, 2013 9:22:18 PM UTC+2, Alex Epshteyn wrote: Thanks Thomas! Is it possible to still use SVN by any chance? I haven't made the leap over to git yet as I'm still using an older version of IntelliJ without git support. If not, could you help me out with some command-line examples of how to submit my patch using git and Gerrit. It's actually rather easy (this is for Linux/Mac, adapt for Windows if needed): 1. svn checkout http://google-web-toolkit.googlecode.com/svn/tools/ tools/ # dependencies are here until we move to Maven 2. git clone https://gwt.googlesource.com/gwt 3. cd gwt 4. One-time setup specific to Gerrit: download https://gwt-review.googlesource.com/tools/hooks/commit-msg into .git/hooks/commit-msg and make sure the file is executable (chmod +x) 5. You're ready to hack; below is standard Git: 1. git checkout -b feature-branche master # create a branch off of master for your feature You'll then use git branch to list your branches, and git checkout my-branch to switch branches. 2. …hack hack hack… 3. Use git status, git add and git commit to commit your files (add --help for help); or try git gui or git citool for a GUI (that's what I use) With Gerrit, each commit will be reviewed independently, so unless you really mean to have 2 commits, you'll git commit --amend your one and only commit for a given feature/fix (first create a commit with git commit, then if you need to update it, use git commit --amend). Only use this locally (before you git push, see below) or when working with commits under review in Gerrit. Updating a review is just a matter of amending the commit and pushing it again. 6. To push your commit for review: git push origin feature-branch:refs/for/master If you're on the feature-branch, your can also use git push origin HEAD:refs/for/master (HEAD corresponds to the currently checked out commit); refs/for/master means this is intended to be merged into master Note: you'll have to generate a password from the Gerrit web UI to be able to push. 7. Last, but not least, to stay up-to-date: 1. git checkout master 2. git pull 3. Note: do only ever git pull when on the master branch. 4. If you need update a branch to a newer master (because there's been changes that would conflict with your changes) 1. git checkout my-branch 2. git rebase master Git will tell you if there are conflicts and should tell you what to do. Hint: git mergetool to resolve conflicts, then git rebase --continue when done. 8. Once your change has been merged (or if you want to delete your work): 1. git branch -D my-branch# generally done from master -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Avoid implicit inter-dependencies between DOM, History, Wind...
Goktug Gokdogan has abandoned this change. Change subject: Avoid implicit inter-dependencies between DOM, History, Window and Widgets through BaseListenerWrapper by moving things to where they're used. .. Abandoned Submitted. -- To view, visit https://gwt-review.googlesource.com/1241 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I44ea5f26c96716879b2a23331cafc26a63644e89 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Linker bug with useSourceMaps
Thanks Thomas! I appreciate it. I'll give it a try! On Wed, Apr 10, 2013 at 5:01 PM, Thomas Broyer t.bro...@gmail.com wrote: On Wednesday, April 10, 2013 9:22:18 PM UTC+2, Alex Epshteyn wrote: Thanks Thomas! Is it possible to still use SVN by any chance? I haven't made the leap over to git yet as I'm still using an older version of IntelliJ without git support. If not, could you help me out with some command-line examples of how to submit my patch using git and Gerrit. It's actually rather easy (this is for Linux/Mac, adapt for Windows if needed): 1. svn checkout http://google-web-toolkit.googlecode.com/svn/tools/tools/ # dependencies are here until we move to Maven 2. git clone https://gwt.googlesource.com/gwt 3. cd gwt 4. One-time setup specific to Gerrit: download https://gwt-review.googlesource.com/tools/hooks/commit-msg into .git/hooks/commit-msg and make sure the file is executable (chmod +x) 5. You're ready to hack; below is standard Git: 1. git checkout -b feature-branche master # create a branch off of master for your feature You'll then use git branch to list your branches, and git checkout my-branch to switch branches. 2. …hack hack hack… 3. Use git status, git add and git commit to commit your files (add --help for help); or try git gui or git citool for a GUI (that's what I use) With Gerrit, each commit will be reviewed independently, so unless you really mean to have 2 commits, you'll git commit --amend your one and only commit for a given feature/fix (first create a commit with git commit, then if you need to update it, use git commit --amend). Only use this locally (before you git push, see below) or when working with commits under review in Gerrit. Updating a review is just a matter of amending the commit and pushing it again. 6. To push your commit for review: git push origin feature-branch:refs/for/master If you're on the feature-branch, your can also use git push origin HEAD:refs/for/master (HEAD corresponds to the currently checked out commit); refs/for/master means this is intended to be merged into master Note: you'll have to generate a password from the Gerrit web UI to be able to push. 7. Last, but not least, to stay up-to-date: 1. git checkout master 2. git pull 3. Note: do only ever git pull when on the master branch. 4. If you need update a branch to a newer master (because there's been changes that would conflict with your changes) 1. git checkout my-branch 2. git rebase master Git will tell you if there are conflicts and should tell you what to do. Hint: git mergetool to resolve conflicts, then git rebase --continue when done. 8. Once your change has been merged (or if you want to delete your work): 1. git branch -D my-branch# generally done from master -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit-contributors/QaHTo59D_GY/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Prevent dev mode breakage when lots of jso classes are used.
Brian Slesinsky has posted comments on this change. Change subject: Prevent dev mode breakage when lots of jso classes are used. .. Patch Set 3: (3 comments) File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java Line 343: return (classId 16) | memberId; How hard would it be to bump this to 17? That's the fundamental issue, right? File dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java Line 41: private HashMapInteger, Member memberByMemberId; I don't see why you changed this to a HashMap. If we're looking things up by small non-negative integers allocated starting from zero, it seems like an ArrayList should work fine? Line 85: int id = memberById.indexOf(m); Should we instead assert that the name doesn't exist in the map? When is it okay to call this method with a name that we already added? Also, not seeing 'm'. Does this code compile? -- To view, visit https://gwt-review.googlesource.com/2210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c703d592556c500e338f95469b2db13f8024627 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Nelson ja...@wetheinter.net Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Linker bug with useSourceMaps
If you are on Windows or Mac OS I would recommend http://www.sourcetreeapp.com/ as git frontend (its free). -- J. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Prevent dev mode breakage when lots of jso classes are used.
James Nelson has posted comments on this change. Change subject: Prevent dev mode breakage when lots of jso classes are used. .. Patch Set 3: Code-Review-1 (3 comments) This patch doesn't actually fix the underlying issue; the code I uploaded had errors, but even after fixing them and passing the related test, inheriting elemental still causes JavaScriptObject$ to swell to over 80,000 members and overflow the integer used to hold class+memberId. File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java Line 343: return (classId 16) | memberId; Yes, this is the _actual_ issue; though JavaScriptObject$ is already up to 80,000 items, so it's conceivable that 17 won't be enough for any jsni-heavy libraries that take elemental as well. There's a couple of places I've seen already that use (id 0x) to differentiate between class and member id... Since this is dev mode, couldn't we just upgrade to long and give memberId and classId each 25 bits? So long as we keep the value under 2^53 (max floating point in js), it should be safe to pass them into js as doubles, pull them out as long, and avoid overflow completely. File dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java Line 41: private HashMapInteger, Member memberByMemberId; Ya, ArrayList is preferable, this review was cobbled together from a different patch, and I screwed it up. :-/ Line 85: int id = memberById.indexOf(m); This method is only called once per DispatchClassInfo object, during lazyInitTargetMembers(); we should, rightly so, make the check against the the name-to-int map (and use the array list as originally designed). Also, embarassingly enough, this code in fact, does not compile. I can upload a fixed copy that will pass DispatchClassInfoTest, but will still die as soon as Elemental is inherited. The real problem isn't anything to do with the collections used here, but rather it is in the use of a single integer to contain both class id and member id; as soon as we pull in elemental, com.google.gwt.core.client.JavaScriptObject$ has 80,000+ members in it (all jso methods), so when we create a dispId of (clsId 16 | memberId), the memberId overflows into classId, causing indexOOB and indeterminism galore. The class that blows up most regularly is PotentialElement, and its dispatch map is full of elemental methods. It can be seen reliably by a) inheriting elemental.Elemental, then b) setting a breakpoint on line 177 of c.g.g.dev.shell.Jsni (at: member = dispatchInfo.getClassInfoByDispId(dispId).getMember(dispId); You will have to continue about ten times before PotentialElement shows up, but when it does, you can trace through and see how packing two 16 bit integers together causes the overflow (expecting clsId=10, getting 11). Since it's unlikely (I guess) that we can change the use of int dispId to long dispId, the only workable alternative is to make DispatchClassInfoOracle return classId and memberId separately, or to put in special workarounds for members of JavaScriptObject$ (as no other object should have more than 0xfff members). -- To view, visit https://gwt-review.googlesource.com/2210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c703d592556c500e338f95469b2db13f8024627 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Nelson ja...@wetheinter.net Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
