[gwt-contrib] Linker bug with useSourceMaps
I'm trying to fix a bug (
https://code.google.com/p/google-web-toolkit/issues/detail?id=8100
), and I could use some expert advice. I'm a long time GWT user (7
years), but only recently started hacking the internals, and I need
help on this one.
Background:
SelectionScriptLinker.splitPrimaryJavaScript attempts to check whether
the property compiler.useSourceMaps is true and if it is, the
method avoids splitting the javascript into chunks (which would
destroy the accuracy of the line numbers in the source map).
The Problem:
This method tries to get the property value from
LinkerContext.getProperties, which is not a PropertyOracle, and hence
it can't return the correct property value for the current
permutation. In fact, it will return a null value unless the property
has a static value for all permutations (e.g. set-property
name=compiler.useSourceMaps value=true/)
However, something like
set-property name=compiler.useSourceMaps value=true
when-property-is name=user.agent value=safari/
/set-property
will not work because SelectionScriptLinker.splitPrimaryJavaScript can
only read static property values.
Could someone advise me on how to fix this bug?
Here's is there relevant source code for quick reference:
public static String splitPrimaryJavaScript(StatementRanges ranges,
String js,
int charsPerChunk, String scriptChunkSeparator, LinkerContext
context) {
boolean useSourceMaps = false;
for (SelectionProperty prop : context.getProperties()) {
if (USE_SOURCE_MAPS_PROPERTY.equals(prop.getName())) {
String str = prop.tryGetValue();
useSourceMaps = str == null ? false :
Boolean.parseBoolean(str);
break;
}
}
// TODO(cromwellian) enable chunking with sourcemaps
if (charsPerChunk 0 || ranges == null || useSourceMaps) {
return js;
}
...
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups
Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Thomas Broyer has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: IIRC, this new behavior is also consistent with @Inject in google-gin which again makes sense to me. But this causes code-bloats because the compiler cannot optimize the same as with non-JSNI methods; at least that was the case some time ago, maybe it has changed): https://code.google.com/p/google-gin/issues/detail?id=35 -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: add StringBuffer/Builder.reverse
Daniel Kurka has posted comments on this change. Change subject: add StringBuffer/Builder.reverse .. Patch Set 1: (1 comment) File user/test/com/google/gwt/emultest/java/lang/StringBufferTest.java Line 276: assertEquals(\uD801\uDC00abce, new StringBuffer(ecba\uD801\uDC00).reverse().toString()); those are all invalid strings since surrogates can only appear in pairs and the first surrogate has to be in the range 0xD800 - 0xDBFF while the second has to be in the range 0xDC00 - 0xDFFF. This is why the standard values can only be in the range 0x000 - 0xD7FF and 0xE000 - 0x. -- To view, visit https://gwt-review.googlesource.com/2431 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: add StringBuffer/Builder.reverse
Daniel Kurka has uploaded a new patch set (#2). Change subject: add StringBuffer/Builder.reverse .. add StringBuffer/Builder.reverse fixes ISSUE 449 Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Review-Link: https://gwt-review.googlesource.com/#/c/2431/ --- M user/src/com/google/gwt/core/client/impl/StringBufferImpl.java M user/src/com/google/gwt/core/client/impl/StringBufferImplAppend.java M user/src/com/google/gwt/core/client/impl/StringBufferImplArrayBase.java M user/super/com/google/gwt/emul/java/lang/StringBuffer.java M user/super/com/google/gwt/emul/java/lang/StringBuilder.java M user/test/com/google/gwt/emultest/java/lang/StringBufferTest.java 6 files changed, 94 insertions(+), 2 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2431 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: add StringBuffer/Builder.reverse
Daniel Kurka has uploaded a new patch set (#3). Change subject: add StringBuffer/Builder.reverse .. add StringBuffer/Builder.reverse fixes ISSUE 449 Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Review-Link: https://gwt-review.googlesource.com/#/c/2431/ --- M user/src/com/google/gwt/core/client/impl/StringBufferImpl.java M user/src/com/google/gwt/core/client/impl/StringBufferImplAppend.java M user/src/com/google/gwt/core/client/impl/StringBufferImplArrayBase.java M user/super/com/google/gwt/emul/java/lang/StringBuffer.java M user/super/com/google/gwt/emul/java/lang/StringBuilder.java M user/test/com/google/gwt/emultest/java/lang/StringBufferTest.java 6 files changed, 93 insertions(+), 2 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2431 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Prevent dev mode breakage when lots of jso classes are used.
John Ahlroos has uploaded a new patch set (#3). Change subject: Prevent dev mode breakage when lots of jso classes are used. .. Prevent dev mode breakage when lots of jso classes are used. Elemental introduces a lot of native classes that can cause dev mode to swell and break. Fixes issue 7481, as well as an unfiled bug whereby jsni calls on Class objects cause a dev mode security exception when trying to set accessibility on Class constructor. Rietveld: http://gwt-code-reviews.appspot.com/1801804/ Change-Id: I0c703d592556c500e338f95469b2db13f8024627 Author: John Ahlroos j...@vaadin.com --- M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java M dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java 2 files changed, 24 insertions(+), 15 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c703d592556c500e338f95469b2db13f8024627 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Nelson ja...@wetheinter.net Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Prevent dev mode breakage when lots of jso classes are used.
John Ahlroos has posted comments on this change. Change subject: Prevent dev mode breakage when lots of jso classes are used. .. Patch Set 3: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c703d592556c500e338f95469b2db13f8024627 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Nelson ja...@wetheinter.net Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Widget Iterator now throws NoSuchElementExceptions correctly.
Daniel Kurka has uploaded a new patch set (#4). Change subject: Widget Iterator now throws NoSuchElementExceptions correctly. .. Widget Iterator now throws NoSuchElementExceptions correctly. Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f Review-Link: https://gwt-review.googlesource.com/#/c/2440/ --- M user/src/com/google/gwt/user/client/ui/WidgetCollection.java M user/test/com/google/gwt/user/client/ui/WidgetCollectionTest.java 2 files changed, 89 insertions(+), 5 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Widget Iterator now throws NoSuchElementExceptions correctly.
Daniel Kurka has uploaded a new patch set (#5). Change subject: Widget Iterator now throws NoSuchElementExceptions correctly. .. Widget Iterator now throws NoSuchElementExceptions correctly. Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f Review-Link: https://gwt-review.googlesource.com/#/c/2440/ --- M user/src/com/google/gwt/user/client/ui/WidgetCollection.java M user/test/com/google/gwt/user/client/ui/WidgetCollectionTest.java 2 files changed, 88 insertions(+), 5 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
John Ahlroos has uploaded a new patch set (#3). Change subject: Workaround for resolving mouse button on mouse move in Firefox .. Workaround for resolving mouse button on mouse move in Firefox Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa --- M user/src/com/google/gwt/dom/client/DOMImplMozilla.java 1 file changed, 26 insertions(+), 0 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2330 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...
Daniel Kurka has posted comments on this change. Change subject: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration .. Patch Set 1: Hi Julien, I can't find you on the CLA-SIGNERS list: https://code.google.com/p/google-web-toolkit/source/browse/CLA-SIGNERS Did you already submit a CLA? -Daniel -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Daniel Kurka has posted comments on this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Patch Set 2: Hello Christian, I could not find you on the CLA signers list: https://code.google.com/p/google-web-toolkit/source/browse/CLA-SIGNERS Could you submit a cla using one of this two this form (whichever suites you): https://developers.google.com/web-toolkit/makinggwtbetter#clas -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner christ...@quelltextlich.at Gerrit-Reviewer: Christian Aistleitner christ...@quelltextlich.at Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...
Julien Dramaix has posted comments on this change. Change subject: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration .. Patch Set 1: I signed the following one : https://developers.google.com/open-source/cla/individual?hl=fr -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: set target and source level to 1.6 for JSP compilation
Daniel Kurka has abandoned this change. Change subject: set target and source level to 1.6 for JSP compilation .. Abandoned Submitted -- To view, visit https://gwt-review.googlesource.com/2201 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Idd3d751c5eb2008a7a1e51536580d56a0fb3603f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: fixing possible NPE in on CellWidget.onBrowserEvent if cell ...
Daniel Kurka has abandoned this change. Change subject: fixing possible NPE in on CellWidget.onBrowserEvent if cell does not consume any events fixes issue 7649 .. Abandoned Submitted -- To view, visit https://gwt-review.googlesource.com/1721 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6d9b4979d7b68e7ff8fa652ab54635d2cc690fd9 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: add StringBuffer/Builder.reverse
Goktug Gokdogan has posted comments on this change. Change subject: add StringBuffer/Builder.reverse .. Patch Set 3: (1 comment) File user/src/com/google/gwt/core/client/impl/StringBufferImpl.java Line 46: buffer[i] = origBuffer[length - 1 - i]; toCharArray copies the string using charAt behind the scenes. If you use s.charAt(length-1-i) here, you can get rid of the extra copy. -- To view, visit https://gwt-review.googlesource.com/2431 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Goktug Gokdogan has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: I think there are optimization steps in JS which can reduce the code bloat. Roberto, can you take a look and see if this ends up causing any significant amount increase in the final output? -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Widget Iterator now throws NoSuchElementExceptions correctly.
Goktug Gokdogan has posted comments on this change. Change subject: Widget Iterator now throws NoSuchElementExceptions correctly. .. Patch Set 5: Code-Review+1 (1 comment) File user/test/com/google/gwt/user/client/ui/WidgetCollectionTest.java Line 173: } Test cases look pretty good. Usually it is best to have separate tests for different cases so that you have better reporting from test failures. Also Google practice is using testMethod_testScenario as the test name (e.g. testIterator_doubleRemove) but I'm not sure if GWT uses the same convention. -- To view, visit https://gwt-review.googlesource.com/2440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07fd1507226a185b94ae1e85b6eb0235ec370a9f Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Roberto Lublinerman has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: The JsInliner should take care of this case. Methods that are called in only one place (like the *__native one in this case) are inlined. The only drawback is that this happens quite late. I'll have a look and make sure it is properly inlined and see if we it makes us miss some optimization opportunities. -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Thomas Broyer has posted comments on this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Patch Set 2: Daniel, isn't the CLA process handled by Gerrit now? (BTW, CLA-SIGNERS is manually-edited and I believe there's a list inside Google with more people than those listed in this file; see the last commit: Bradley added in June when he actually signed the CLA in February) -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner christ...@quelltextlich.at Gerrit-Reviewer: Christian Aistleitner christ...@quelltextlich.at Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Thomas Broyer has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: A simple fix is to only use the JSNI method if the method is private. And in that case, also emit a warning that we only support this scenario for backwards compatibility (see Brian and Matthew comments; though there are already cases which violates the least-surprise principle Brian points out: JSR303 –not stripped-down profile that Dagger implements, despite being more sensible IMO– does allow @Inject-ing private classes/ctors/fields/methods) and will remove it in a future release. BTW, have you tried updating the existing code that uses privates using a script/whatever? -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: set target and source level to 1.6 for JSP compilation
Thomas Broyer has posted comments on this change. Change subject: set target and source level to 1.6 for JSP compilation .. Patch Set 2: So Daniel, how does it feel to be on the other side now? ;-) -- To view, visit https://gwt-review.googlesource.com/2201 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd3d751c5eb2008a7a1e51536580d56a0fb3603f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Roberto Lublinerman has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: The existing code is already fixed. The question remains whether we want to allow private @UiHandlers and @UiFields as a feature or not. I am neutral in that respect. Should we take a vote? -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Goktug Gokdogan has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: Actually we discussed this internally and we have an agreement on our side to add the support as a feature. I'm keeping the thread up to date and would like to hear if you still have any concerns: 1. In UiBinder, the xml is more like a part of the view class itself that is extracted out to make it more declarative and it can be considered as internal. From that point of view, we are not really violating the semantics of the private (at least as not much as in @inject case.) 2. UiFields are nearly always only used in the class itself. When we don't declare them private, then it is difficult to discover if they are used or not as the IDE will not point that out. 3. Tools are already aware of the fact that methods with annotations are usually used by magic and provides easy ways to configure as this is kind of a common practice in java. -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Linker bug with useSourceMaps
Okay, I found a pretty good solution. Solved the problem by adding a
method isSourceMapsEnabled to CompilationResult, which gets passed all
the way from Link to SelectionScriptLinker. The value is set in Link
via the permutation's property oracles. I tested this and it works
well!
Now, how can I contribute this patch? Long time user, first time
contributor. I signed the CLA many years ago, but haven't submitted
anything until now.
Are the instructions on
https://developers.google.com/web-toolkit/makinggwtbetter
still valid?
I'm a little confused because that document says Upload the patch to
the Rietveld instance at http://gwt-code-reviews.appspot.com/; whereas
I'm seeing all the messages in this group coming from a system called
Gerrit at https://gwt-review.googlesource.com/
On Apr 10, 2:39 am, Alex Epshteyn alexander.epsht...@gmail.com
wrote:
I'm trying to fix a bug
(https://code.google.com/p/google-web-toolkit/issues/detail?id=8100
), and I could use some expert advice. I'm a long time GWT user (7
years), but only recently started hacking the internals, and I need
help on this one.
Background:
SelectionScriptLinker.splitPrimaryJavaScript attempts to check whether
the property compiler.useSourceMaps is true and if it is, the
method avoids splitting the javascript into chunks (which would
destroy the accuracy of the line numbers in the source map).
The Problem:
This method tries to get the property value from
LinkerContext.getProperties, which is not a PropertyOracle, and hence
it can't return the correct property value for the current
permutation. In fact, it will return a null value unless the property
has a static value for all permutations (e.g. set-property
name=compiler.useSourceMaps value=true/)
However, something like
set-property name=compiler.useSourceMaps value=true
when-property-is name=user.agent value=safari/
/set-property
will not work because SelectionScriptLinker.splitPrimaryJavaScript can
only read static property values.
Could someone advise me on how to fix this bug?
Here's is there relevant source code for quick reference:
public static String splitPrimaryJavaScript(StatementRanges ranges,
String js,
int charsPerChunk, String scriptChunkSeparator, LinkerContext
context) {
boolean useSourceMaps = false;
for (SelectionProperty prop : context.getProperties()) {
if (USE_SOURCE_MAPS_PROPERTY.equals(prop.getName())) {
String str = prop.tryGetValue();
useSourceMaps = str == null ? false :
Boolean.parseBoolean(str);
break;
}
}
// TODO(cromwellian) enable chunking with sourcemaps
if (charsPerChunk 0 || ranges == null || useSourceMaps) {
return js;
}
...
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups
Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Linker bug with useSourceMaps
On Wed, Apr 10, 2013 at 12:22 PM, Alex Epshteyn alexander.epsht...@gmail.com wrote: Thanks Thomas! Is it possible to still use SVN by any chance? We'll continue accepting patches from Rietveld, just it's a bit more work for us to merge them. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow @UIHandler annotated methods to be private.
Brian Slesinsky has posted comments on this change. Change subject: Allow @UIHandler annotated methods to be private. .. Patch Set 2: I agree that we should indirect through JSNI only if the method is actually private. This could be a performance issue in devmode because it adds a round trip between the browser and the JVM. (Is there some way to avoid the round trip?) I think it's simpler to not change the spec but I will defer to people who use UiBinder more. -- To view, visit https://gwt-review.googlesource.com/2450 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Linker bug with useSourceMaps
Gotcha. I will certainly have more than one patch to contribute now that I've really dived into the GWT compiler internals, so I might as well start working with the new git-based system to make things easier for everyone. I've already made quite a few other enhancements and bug fixes to the whole web mode exceptions reporting toolchain, which are going into the next release of my product, TypeRacer, and I'm eager to contribute those back to GWT. I'll probably write up a blog post about my experiments and enhancements in the coming weeks. Anyways, could you guys provide me with some command line examples of the whole process using git, starting from checking out the code to submitting a patch for review? Thanks in advance. I'm eager to get started! On Wed, Apr 10, 2013 at 3:39 PM, Matthew Dempsky mdemp...@google.comwrote: On Wed, Apr 10, 2013 at 12:22 PM, Alex Epshteyn alexander.epsht...@gmail.com wrote: Thanks Thomas! Is it possible to still use SVN by any chance? We'll continue accepting patches from Rietveld, just it's a bit more work for us to merge them. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit-contributors/QaHTo59D_GY/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Linker bug with useSourceMaps
On Wednesday, April 10, 2013 9:22:18 PM UTC+2, Alex Epshteyn wrote: Thanks Thomas! Is it possible to still use SVN by any chance? I haven't made the leap over to git yet as I'm still using an older version of IntelliJ without git support. If not, could you help me out with some command-line examples of how to submit my patch using git and Gerrit. It's actually rather easy (this is for Linux/Mac, adapt for Windows if needed): 1. svn checkout http://google-web-toolkit.googlecode.com/svn/tools/ tools/ # dependencies are here until we move to Maven 2. git clone https://gwt.googlesource.com/gwt 3. cd gwt 4. One-time setup specific to Gerrit: download https://gwt-review.googlesource.com/tools/hooks/commit-msg into .git/hooks/commit-msg and make sure the file is executable (chmod +x) 5. You're ready to hack; below is standard Git: 1. git checkout -b feature-branche master # create a branch off of master for your feature You'll then use git branch to list your branches, and git checkout my-branch to switch branches. 2. …hack hack hack… 3. Use git status, git add and git commit to commit your files (add --help for help); or try git gui or git citool for a GUI (that's what I use) With Gerrit, each commit will be reviewed independently, so unless you really mean to have 2 commits, you'll git commit --amend your one and only commit for a given feature/fix (first create a commit with git commit, then if you need to update it, use git commit --amend). Only use this locally (before you git push, see below) or when working with commits under review in Gerrit. Updating a review is just a matter of amending the commit and pushing it again. 6. To push your commit for review: git push origin feature-branch:refs/for/master If you're on the feature-branch, your can also use git push origin HEAD:refs/for/master (HEAD corresponds to the currently checked out commit); refs/for/master means this is intended to be merged into master Note: you'll have to generate a password from the Gerrit web UI to be able to push. 7. Last, but not least, to stay up-to-date: 1. git checkout master 2. git pull 3. Note: do only ever git pull when on the master branch. 4. If you need update a branch to a newer master (because there's been changes that would conflict with your changes) 1. git checkout my-branch 2. git rebase master Git will tell you if there are conflicts and should tell you what to do. Hint: git mergetool to resolve conflicts, then git rebase --continue when done. 8. Once your change has been merged (or if you want to delete your work): 1. git branch -D my-branch# generally done from master -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Avoid implicit inter-dependencies between DOM, History, Wind...
Goktug Gokdogan has abandoned this change. Change subject: Avoid implicit inter-dependencies between DOM, History, Window and Widgets through BaseListenerWrapper by moving things to where they're used. .. Abandoned Submitted. -- To view, visit https://gwt-review.googlesource.com/1241 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I44ea5f26c96716879b2a23331cafc26a63644e89 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Linker bug with useSourceMaps
Thanks Thomas! I appreciate it. I'll give it a try! On Wed, Apr 10, 2013 at 5:01 PM, Thomas Broyer t.bro...@gmail.com wrote: On Wednesday, April 10, 2013 9:22:18 PM UTC+2, Alex Epshteyn wrote: Thanks Thomas! Is it possible to still use SVN by any chance? I haven't made the leap over to git yet as I'm still using an older version of IntelliJ without git support. If not, could you help me out with some command-line examples of how to submit my patch using git and Gerrit. It's actually rather easy (this is for Linux/Mac, adapt for Windows if needed): 1. svn checkout http://google-web-toolkit.googlecode.com/svn/tools/tools/ # dependencies are here until we move to Maven 2. git clone https://gwt.googlesource.com/gwt 3. cd gwt 4. One-time setup specific to Gerrit: download https://gwt-review.googlesource.com/tools/hooks/commit-msg into .git/hooks/commit-msg and make sure the file is executable (chmod +x) 5. You're ready to hack; below is standard Git: 1. git checkout -b feature-branche master # create a branch off of master for your feature You'll then use git branch to list your branches, and git checkout my-branch to switch branches. 2. …hack hack hack… 3. Use git status, git add and git commit to commit your files (add --help for help); or try git gui or git citool for a GUI (that's what I use) With Gerrit, each commit will be reviewed independently, so unless you really mean to have 2 commits, you'll git commit --amend your one and only commit for a given feature/fix (first create a commit with git commit, then if you need to update it, use git commit --amend). Only use this locally (before you git push, see below) or when working with commits under review in Gerrit. Updating a review is just a matter of amending the commit and pushing it again. 6. To push your commit for review: git push origin feature-branch:refs/for/master If you're on the feature-branch, your can also use git push origin HEAD:refs/for/master (HEAD corresponds to the currently checked out commit); refs/for/master means this is intended to be merged into master Note: you'll have to generate a password from the Gerrit web UI to be able to push. 7. Last, but not least, to stay up-to-date: 1. git checkout master 2. git pull 3. Note: do only ever git pull when on the master branch. 4. If you need update a branch to a newer master (because there's been changes that would conflict with your changes) 1. git checkout my-branch 2. git rebase master Git will tell you if there are conflicts and should tell you what to do. Hint: git mergetool to resolve conflicts, then git rebase --continue when done. 8. Once your change has been merged (or if you want to delete your work): 1. git branch -D my-branch# generally done from master -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit-contributors/QaHTo59D_GY/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Prevent dev mode breakage when lots of jso classes are used.
Brian Slesinsky has posted comments on this change. Change subject: Prevent dev mode breakage when lots of jso classes are used. .. Patch Set 3: (3 comments) File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java Line 343: return (classId 16) | memberId; How hard would it be to bump this to 17? That's the fundamental issue, right? File dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java Line 41: private HashMapInteger, Member memberByMemberId; I don't see why you changed this to a HashMap. If we're looking things up by small non-negative integers allocated starting from zero, it seems like an ArrayList should work fine? Line 85: int id = memberById.indexOf(m); Should we instead assert that the name doesn't exist in the map? When is it okay to call this method with a name that we already added? Also, not seeing 'm'. Does this code compile? -- To view, visit https://gwt-review.googlesource.com/2210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c703d592556c500e338f95469b2db13f8024627 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Nelson ja...@wetheinter.net Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Linker bug with useSourceMaps
If you are on Windows or Mac OS I would recommend http://www.sourcetreeapp.com/ as git frontend (its free). -- J. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Prevent dev mode breakage when lots of jso classes are used.
James Nelson has posted comments on this change. Change subject: Prevent dev mode breakage when lots of jso classes are used. .. Patch Set 3: Code-Review-1 (3 comments) This patch doesn't actually fix the underlying issue; the code I uploaded had errors, but even after fixing them and passing the related test, inheriting elemental still causes JavaScriptObject$ to swell to over 80,000 members and overflow the integer used to hold class+memberId. File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java Line 343: return (classId 16) | memberId; Yes, this is the _actual_ issue; though JavaScriptObject$ is already up to 80,000 items, so it's conceivable that 17 won't be enough for any jsni-heavy libraries that take elemental as well. There's a couple of places I've seen already that use (id 0x) to differentiate between class and member id... Since this is dev mode, couldn't we just upgrade to long and give memberId and classId each 25 bits? So long as we keep the value under 2^53 (max floating point in js), it should be safe to pass them into js as doubles, pull them out as long, and avoid overflow completely. File dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java Line 41: private HashMapInteger, Member memberByMemberId; Ya, ArrayList is preferable, this review was cobbled together from a different patch, and I screwed it up. :-/ Line 85: int id = memberById.indexOf(m); This method is only called once per DispatchClassInfo object, during lazyInitTargetMembers(); we should, rightly so, make the check against the the name-to-int map (and use the array list as originally designed). Also, embarassingly enough, this code in fact, does not compile. I can upload a fixed copy that will pass DispatchClassInfoTest, but will still die as soon as Elemental is inherited. The real problem isn't anything to do with the collections used here, but rather it is in the use of a single integer to contain both class id and member id; as soon as we pull in elemental, com.google.gwt.core.client.JavaScriptObject$ has 80,000+ members in it (all jso methods), so when we create a dispId of (clsId 16 | memberId), the memberId overflows into classId, causing indexOOB and indeterminism galore. The class that blows up most regularly is PotentialElement, and its dispatch map is full of elemental methods. It can be seen reliably by a) inheriting elemental.Elemental, then b) setting a breakpoint on line 177 of c.g.g.dev.shell.Jsni (at: member = dispatchInfo.getClassInfoByDispId(dispId).getMember(dispId); You will have to continue about ten times before PotentialElement shows up, but when it does, you can trace through and see how packing two 16 bit integers together causes the overflow (expecting clsId=10, getting 11). Since it's unlikely (I guess) that we can change the use of int dispId to long dispId, the only workable alternative is to make DispatchClassInfoOracle return classId and memberId separately, or to put in special workarounds for members of JavaScriptObject$ (as no other object should have more than 0xfff members). -- To view, visit https://gwt-review.googlesource.com/2210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c703d592556c500e338f95469b2db13f8024627 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Nelson ja...@wetheinter.net Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: James Nelson ja...@wetheinter.net Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
