[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=423195=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-423195 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 16/Apr/20 02:21 Start Date: 16/Apr/20 02:21 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 423195) Time Spent: 5h 50m (was: 5h 40m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 5h 50m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=423194=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-423194 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 16/Apr/20 02:20 Start Date: 16/Apr/20 02:20 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-614375921 I was thinking about... I need this as part of this release. the change you made here wouldn't break the compatibility if released now... but it would break if released later. up till now we didn't have any other type of large messages... so if we release now, the byte(2) on PagedMessages would make a lot of sense... if we released later, we would have to deal with previous versions where you may have AMQPLargeMessage with byte(1), while this PR is expecting byte(2). so, I am merging this now. Besides I have a full pass on this PR as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 423194) Time Spent: 5h 40m (was: 5.5h) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 5h 40m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=420979=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-420979 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 12/Apr/20 18:57 Start Date: 12/Apr/20 18:57 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-612660737 I will try to add the missing tests in the next days This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 420979) Time Spent: 5.5h (was: 5h 20m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 5.5h > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=416058=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-416058 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 04/Apr/20 22:17 Start Date: 04/Apr/20 22:17 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-609096425 I see that this one is a kind of major perf improvement on paging, but I still want to add some more tests on binary compatibility of PagedMessage decoding that I see we currently don't cover on tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 416058) Time Spent: 5h 20m (was: 5h 10m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 5h 20m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=414527=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414527 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 02/Apr/20 08:13 Start Date: 02/Apr/20 08:13 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607692028 I've rebased against master: the logic should be correct, but I would like to add some unit tests around the introduced logic too :) Let me know if the logic seems sound This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 414527) Time Spent: 5h 10m (was: 5h) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 5h 10m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=414526=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414526
]
ASF GitHub Bot logged work on ARTEMIS-2676:
---
Author: ASF GitHub Bot
Created on: 02/Apr/20 08:12
Start Date: 02/Apr/20 08:12
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#discussion_r401919551
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
##
@@ -376,29 +395,38 @@ private static ChannelBufferWrapper wrapWhole(ByteBuffer
fileBuffer) {
final int endPosition = fileBuffer.position() +
encodedSize;
//this check must be performed upfront decoding
if (fileBuffer.remaining() >= (encodedSize + 1) &&
fileBuffer.get(endPosition) == Page.END_BYTE) {
-final PagedMessageImpl msg = new
PagedMessageImpl(encodedSize, storageManager);
fileBufferWrapper.setIndex(fileBuffer.position(),
endPosition);
-msg.decode(fileBufferWrapper);
-fileBuffer.position(endPosition + 1);
-assert fileBuffer.get(endPosition) == Page.END_BYTE :
"decoding cannot change end byte";
-msg.initMessage(storage);
-assert msg.getMessage() instanceof LargeServerMessage
&& ((LargeServerMessage)msg.getMessage()).getStorageManager() != null ||
!(msg.getMessage() instanceof LargeServerMessage);
-if (logger.isTraceEnabled()) {
- logger.tracef("Reading message %s on pageId=%d for
address=%s", msg, pageId, storeName);
+final boolean skipMessage;
+if (onlyLargeMessages) {
+ skipMessage =
!PagedMessageImpl.isLargeMessage(fileBufferWrapper);
+} else {
+ skipMessage = false;
}
-messages.add(msg);
+if (!skipMessage) {
+ final PagedMessageImpl msg = new
PagedMessageImpl(encodedSize, storageManager);
+ msg.decode(fileBufferWrapper);
+ assert fileBuffer.get(endPosition) == Page.END_BYTE
: "decoding cannot change end byte";
+ msg.initMessage(storage);
Review comment:
@clebertsuconic I see that sometime we use storage and sometime the member
storage manager stored on the Page...any idea which one would be the most
correct to use?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 414526)
Time Spent: 5h (was: 4h 50m)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> --
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.11.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=414149=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414149 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 01/Apr/20 16:39 Start Date: 01/Apr/20 16:39 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607356882 I've pushed the changed on `usage` count on https://github.com/apache/activemq-artemis/pull/3055 + some of the enhancements on the test I have here: so please don't merge this yet. I will rebase over master when https://github.com/apache/activemq-artemis/pull/3055 will be merged This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 414149) Time Spent: 4h 50m (was: 4h 40m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 4h 50m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=414145=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414145 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 01/Apr/20 16:33 Start Date: 01/Apr/20 16:33 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607356882 I've pushed the changed on `usage` count on https://github.com/apache/activemq-artemis/pull/3055 + some of the enhancements on the test I have here: so please don't merge this yet. I will rebase over master wehn https://github.com/apache/activemq-artemis/pull/3055 will be merged This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 414145) Time Spent: 4h 40m (was: 4.5h) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 4h 40m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=414104=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414104 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 01/Apr/20 15:46 Start Date: 01/Apr/20 15:46 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607329180 @clebertsuconic I've tried to come up with a test to cover AMQP large and standard messages: let me know if the way I create and write `AMQPLargeMessage` is wrong. While working on it I've found a test failure on the new test `AmqpPageTest::testLargeMessagePageWithNIO` while checking `Assert.assertEquals(largeMessages ? 1 : 0, pagedMessage.getMessage().getUsage());` I have pushed a change trying to fix this, but maybe the `assert` is just wrong for AMQP, while it's valid only for Core large messages. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 414104) Time Spent: 4.5h (was: 4h 20m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 4.5h > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413926=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413926
]
ASF GitHub Bot logged work on ARTEMIS-2676:
---
Author: ASF GitHub Bot
Created on: 01/Apr/20 09:32
Start Date: 01/Apr/20 09:32
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607084834
@clebertsuconic I see on `PagedMessageImpl` this check:
```java
public boolean isLargeMessage() {
return message instanceof ICoreMessage &&
((ICoreMessage)message).isLargeMessage();
}
```
and
```java
@Override
public void encode(final ActiveMQBuffer buffer) {
buffer.writeLong(transactionID);
boolean isLargeMessage = isLargeMessage();
buffer.writeBoolean(isLargeMessage);
```
why we cannot fix check/encode/decode to correctly write the
`isLargeMessage` prefix field in an OO way without doing it ad-hoc if is Core
as it is now?
The only part to take care is to warn users to not upgrade the broker if
there are paged large messages (with AMQP).
I've added a new commit that tries to minimize the changes and that is
taking this route: I will add some tests to validate this new behaviour:
please, let me know how it looks :+1:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 413926)
Time Spent: 4h 20m (was: 4h 10m)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> --
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.11.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413883=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413883
]
ASF GitHub Bot logged work on ARTEMIS-2676:
---
Author: ASF GitHub Bot
Created on: 01/Apr/20 08:28
Start Date: 01/Apr/20 08:28
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607084834
@clebertsuconic I see on `PagedMessageImpl` this check:
```java
public boolean isLargeMessage() {
return message instanceof ICoreMessage &&
((ICoreMessage)message).isLargeMessage();
}
```
and
```java
@Override
public void encode(final ActiveMQBuffer buffer) {
buffer.writeLong(transactionID);
boolean isLargeMessage = isLargeMessage();
buffer.writeBoolean(isLargeMessage);
```
why we cannot fix check/encode/decode to correctly write the
`isLargeMessage` prefix field in an OO way without doing it ad-hoc if is Core
as it is now?
The only part to take care is to warn users to not upgrade the broker if
there are paged large messages (with AMQP).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 413883)
Time Spent: 4h 10m (was: 4h)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> --
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.11.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413882=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413882
]
ASF GitHub Bot logged work on ARTEMIS-2676:
---
Author: ASF GitHub Bot
Created on: 01/Apr/20 08:28
Start Date: 01/Apr/20 08:28
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607084834
@clebertsuconic I see on `PagedMessageImpl` this check:
```java
public boolean isLargeMessage() {
return message instanceof ICoreMessage &&
((ICoreMessage)message).isLargeMessage();
}
```
and
```java
@Override
public void encode(final ActiveMQBuffer buffer) {
buffer.writeLong(transactionID);
boolean isLargeMessage = isLargeMessage();
buffer.writeBoolean(isLargeMessage);
```
why we cannot fix check/encode/decode to correctly write the
`isLargeMessage` prefix field in an OO way without doing it ad-hoc if is Core
as it is now?
The only part to take care is to warn users to not upgrade the broker if
there are paged messages (with AMQP).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 413882)
Time Spent: 4h (was: 3h 50m)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> --
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.11.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413880=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413880
]
ASF GitHub Bot logged work on ARTEMIS-2676:
---
Author: ASF GitHub Bot
Created on: 01/Apr/20 08:26
Start Date: 01/Apr/20 08:26
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607084834
@clebertsuconic I see on `PagedMessageImpl` this check:
```java
public boolean isLargeMessage() {
return message instanceof ICoreMessage &&
((ICoreMessage)message).isLargeMessage();
}
```
and
```java
@Override
public void encode(final ActiveMQBuffer buffer) {
buffer.writeLong(transactionID);
boolean isLargeMessage = isLargeMessage();
buffer.writeBoolean(isLargeMessage);
```
why we cannot fix check/encode/decode to correctly write the
`isLargeMessage` prefix field in an OO way without doing it ad-hoc if is Core
as it is now?
I'm aware that's a breaking change eh, just guessing if we can do it
properly somehow
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 413880)
Time Spent: 3h 50m (was: 3h 40m)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> --
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.11.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413845=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413845
]
ASF GitHub Bot logged work on ARTEMIS-2676:
---
Author: ASF GitHub Bot
Created on: 01/Apr/20 07:44
Start Date: 01/Apr/20 07:44
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607084834
@clebertsuconic I see on `PagedMessageImpl` this check:
```java
public boolean isLargeMessage() {
return message instanceof ICoreMessage &&
((ICoreMessage)message).isLargeMessage();
}
```
and
```java
@Override
public void encode(final ActiveMQBuffer buffer) {
buffer.writeLong(transactionID);
boolean isLargeMessage = isLargeMessage();
buffer.writeBoolean(isLargeMessage);
```
why we cannot fix check/encode/decode to correctly write the
`isLargeMessage` prefix field in an OO way without doing it ad-hoc if is Core
as it is now?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 413845)
Time Spent: 3h 40m (was: 3.5h)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> --
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.11.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413838=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413838
]
ASF GitHub Bot logged work on ARTEMIS-2676:
---
Author: ASF GitHub Bot
Created on: 01/Apr/20 07:35
Start Date: 01/Apr/20 07:35
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607084834
@clebertsuconic I see on `PagedMessageImpl` this check:
```java
public boolean isLargeMessage() {
return message instanceof ICoreMessage &&
((ICoreMessage)message).isLargeMessage();
}
```
and
```java
@Override
public void encode(final ActiveMQBuffer buffer) {
buffer.writeLong(transactionID);
boolean isLargeMessage = isLargeMessage();
buffer.writeBoolean(isLargeMessage);
```
why we cannot modify the check/encode/decode to correctly write the
`isLargeMessage` prefix field in an OO way without doing it ad-hoc if is Core
as it is now?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 413838)
Time Spent: 3.5h (was: 3h 20m)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> --
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.11.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413836=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413836
]
ASF GitHub Bot logged work on ARTEMIS-2676:
---
Author: ASF GitHub Bot
Created on: 01/Apr/20 07:34
Start Date: 01/Apr/20 07:34
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607084834
@clebertsuconic I see on `PagedMessageImpl` this check:
```java
public boolean isLargeMessage() {
return message instanceof ICoreMessage &&
((ICoreMessage)message).isLargeMessage();
}
```
and
```
@Override
public void encode(final ActiveMQBuffer buffer) {
buffer.writeLong(transactionID);
boolean isLargeMessage = isLargeMessage();
buffer.writeBoolean(isLargeMessage);
```
why we cannot modify the check/encode/decode to correctly write the
`isLargeMessage` prefix field?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 413836)
Time Spent: 3h 10m (was: 3h)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> --
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.11.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413837=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413837
]
ASF GitHub Bot logged work on ARTEMIS-2676:
---
Author: ASF GitHub Bot
Created on: 01/Apr/20 07:34
Start Date: 01/Apr/20 07:34
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-607084834
@clebertsuconic I see on `PagedMessageImpl` this check:
```java
public boolean isLargeMessage() {
return message instanceof ICoreMessage &&
((ICoreMessage)message).isLargeMessage();
}
```
and
```java
@Override
public void encode(final ActiveMQBuffer buffer) {
buffer.writeLong(transactionID);
boolean isLargeMessage = isLargeMessage();
buffer.writeBoolean(isLargeMessage);
```
why we cannot modify the check/encode/decode to correctly write the
`isLargeMessage` prefix field?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 413837)
Time Spent: 3h 20m (was: 3h 10m)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> --
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.11.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413565=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413565
]
ASF GitHub Bot logged work on ARTEMIS-2676:
---
Author: ASF GitHub Bot
Created on: 31/Mar/20 22:26
Start Date: 31/Mar/20 22:26
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on issue #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-606911209
I could fix the rebasing, however your implementation is not valid.
Up until CoreMessages, we used a special record type on paging, only used
for Large Messages.
With AMQP, I didn't use that record at all. instead I used the Persister
from the AMQP Protocol. So, you would have to check the Persister Type, at the
proper record position.
Besides, the following implementation is not self documented... if things
change this will likely introduce bugs (lack of encapsulation of this rule):
```
public static boolean isLargeMessage(ActiveMQBuffer buffer) {
// skip transactionID
final boolean isLargeMessage = buffer.getByte(buffer.readerIndex() +
Long.BYTES) != 0;
return isLargeMessage;
}
```
You would need to encapsulate this through PagePosition for Core Records, or
check the Persister, and do the proper encapsulation if you really want to
implement such feature.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 413565)
Time Spent: 3h (was: 2h 50m)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> --
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.11.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413564=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413564 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 31/Mar/20 22:23 Start Date: 31/Mar/20 22:23 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-606912942 Look at the AMQPLargeMessagePersister. you would need to check that record but please you would need to have the proper operations on the OO model not much about OO here, but about organizing the code in such way we can find the operation when we need it. I think it's valid to check if the record is for Paging, but you would have to do it in an organized way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 413564) Time Spent: 2h 50m (was: 2h 40m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413562=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413562
]
ASF GitHub Bot logged work on ARTEMIS-2676:
---
Author: ASF GitHub Bot
Created on: 31/Mar/20 22:22
Start Date: 31/Mar/20 22:22
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on issue #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-606911209
I could fix the rebasing, however your implementation is not valid.
Up until CoreMessages, we used a special record type on paging, only used
for Large Messages.
With AMQP, I didn't use that record at all. instead I used the Persister
from the AMQP Protocol. So, you would have to check the Persister Type, ad the
proper record position.
Besides, the following implementation is not self documented... if things
change this will likely introduce bugs (lack of encapsulation of this rule):
```
public static boolean isLargeMessage(ActiveMQBuffer buffer) {
// skip transactionID
final boolean isLargeMessage = buffer.getByte(buffer.readerIndex() +
Long.BYTES) != 0;
return isLargeMessage;
}
```
You would need to encapsulate this through PagePosition for Core Records, or
check the Persister, and do the proper encapsulation if you really want to
implement such feature.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 413562)
Time Spent: 2h 40m (was: 2.5h)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> --
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.11.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413499=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413499 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 31/Mar/20 20:15 Start Date: 31/Mar/20 20:15 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-606850755 @clebertsuconic yep, there has been some new changes around that part recently, so tomorrow will take care of rebasing ;) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 413499) Time Spent: 2.5h (was: 2h 20m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413486=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413486 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 31/Mar/20 19:58 Start Date: 31/Mar/20 19:58 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-606842960 @franz1981 there's a conflict with master. can you rebase it please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 413486) Time Spent: 2h 20m (was: 2h 10m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408839=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408839 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 24/Mar/20 15:07 Start Date: 24/Mar/20 15:07 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603280293 @clebertsuconic has confirmed that `Message::usageDown` is meant to be used just on large messages and it has no meaningful effects on non large messages: it means that I can left the logic as I've implemented in this PR. I will add some doc around `Message::usageUp/usageDown` to explain explicitely that to avoid future misuses. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408839) Time Spent: 2h 10m (was: 2h) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408810=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408810 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 24/Mar/20 14:44 Start Date: 24/Mar/20 14:44 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603280293 @clebertsuconic has confirmed that `Message::usageDown` is menat to be used just on large messages and it has no meaningful effects on non large messages: it means that I can left the logic as I've implemented in this PR. I will add some doc around `Message::usageUp/usageDown` to explain explicitely that to avoid future misuses. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408810) Time Spent: 2h (was: 1h 50m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408635=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408635 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 24/Mar/20 10:03 Start Date: 24/Mar/20 10:03 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603143665 @clebertsuconic I need some help to understand the impact of this change I've made on `Page::delete`: : - before: was calling `Message::usageDown` on each message - now: it's calling `Message::usageDown` only for large messages I see that ddd8ed440226fa9099f894fa0dd5c1e03614b7da has introduced `usageDown` to be triggered on any message while before `decrementDelayDeletionCount` was just called on large messages, was it correct?  It's ok if I'm calling it just on large messages? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408635) Time Spent: 1h 50m (was: 1h 40m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408633=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408633 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 24/Mar/20 10:02 Start Date: 24/Mar/20 10:02 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603143665 @clebertsuconic I need some help to understand the impact of this change I've made on `Page::delete`: : - before: was calling `Message::usageDown` on each message - now: it's calling `Message::usageDown` only for large messages I see that ddd8ed440226fa9099f894fa0dd5c1e03614b7da has introduced `usageDown` to be triggered on any message while before `decrementDelayDeletionCount()` was just called on large messages, was it correct?  It's ok if I'm calling it just for large messages? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408633) Time Spent: 1.5h (was: 1h 20m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408634=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408634 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 24/Mar/20 10:02 Start Date: 24/Mar/20 10:02 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603143665 @clebertsuconic I need some help to understand the impact of this change I've made on `Page::delete`: : - before: was calling `Message::usageDown` on each message - now: it's calling `Message::usageDown` only for large messages I see that ddd8ed440226fa9099f894fa0dd5c1e03614b7da has introduced `usageDown` to be triggered on any message while before `decrementDelayDeletionCount()` was just called on large messages, was it correct?  It's ok if I'm calling it just on large messages? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408634) Time Spent: 1h 40m (was: 1.5h) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408632=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408632 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 24/Mar/20 10:01 Start Date: 24/Mar/20 10:01 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603143665 @clebertsuconic I need some help to understand the impact of this change I've made on `Page::delete`: : - before: was calling `Message::usageDown` on each message - now: it's calling `Message::usageDown` only for large messages I see that ddd8ed440226fa9099f894fa0dd5c1e03614b7da has introduced `usageDown` to be triggered on ANY message, was it correct?  It's ok if I'm calling it just for large messages? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408632) Time Spent: 1h 20m (was: 1h 10m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408598=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408598 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 24/Mar/20 08:49 Start Date: 24/Mar/20 08:49 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603100401 I've run the CI tests and this change seems to work fine yay Perf-wise and on stability is a nice improvement over the original version, although not perfect: ideally we should skip reading the Page at all, but now we save a lot of CPU time and heap space by saving useless message decoding :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408598) Time Spent: 1h 10m (was: 1h) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408594=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408594 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 24/Mar/20 08:34 Start Date: 24/Mar/20 08:34 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603100401 I've run the CI tests and this change seems to work fine :+1 Perf-wise and on stability is a nice improvement over the original version, although not perfect: ideally we should skip reading the Page at all, but now we save a lot of CPU time and heap space by saving useless message decoding :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408594) Time Spent: 1h (was: 50m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408590=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408590 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 24/Mar/20 08:31 Start Date: 24/Mar/20 08:31 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603100401 I've run the CI tests and this change seems to work fine :+1 Perf-wise is a nice improvement over the original version, although not perfect: ideally we should skip reading the Page at all, but now we save a lot of CPU time and heap space by saving useless message decoding :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408590) Time Spent: 50m (was: 40m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408317=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408317 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 23/Mar/20 21:05 Start Date: 23/Mar/20 21:05 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-602855737 Sure bud, there is no hurry and this change should be simpler enough to be rebased against your when you have done ;) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408317) Time Spent: 40m (was: 0.5h) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408299=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408299 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 23/Mar/20 20:54 Start Date: 23/Mar/20 20:54 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-602850622 If you could please wait my PR to be merged first? I'm changing around these methods also.. and I wanted to have a version closer to what we have now as I'm cherry-picking to a production branch based on a previous version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408299) Time Spent: 0.5h (was: 20m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408064=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408064 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 23/Mar/20 17:07 Start Date: 23/Mar/20 17:07 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-602733268 I'm planning to add another commit to try save completely reading the `Page`, or I should just send another pr for this. @wy96f @clebertsuconic seems that I cannot assign reviewers, so I'm calling out directly ;) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408064) Time Spent: 20m (was: 10m) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2676) PageCursorProviderImpl::cleanup can save decoding pages without large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408063=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408063 ] ASF GitHub Bot logged work on ARTEMIS-2676: --- Author: ASF GitHub Bot Created on: 23/Mar/20 17:06 Start Date: 23/Mar/20 17:06 Worklog Time Spent: 10m Work Description: franz1981 commented on pull request #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044 PageCurosrProviderImpl::cleanup is calling PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not present in the PageCache), just to trigger large messages delete. The decoding phase could be skipped and possibly the page read as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 408063) Remaining Estimate: 0h Time Spent: 10m > PageCursorProviderImpl::cleanup can save decoding pages without large messages > -- > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.11.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
