[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235032#comment-15235032
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit 6dc514738f97bd265ac01ee36c1b081adf834c3b in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6dc5147 ]

Merge release branch 4.8 to master

* 4.8:
  CLOUDSTACK-9297: delete snapshot without id is failing with Unable to 
determine the storage pool of the snapshot


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235031#comment-15235031
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit 713c2f5dccd891f8f988d9dc7dbbb4b7ca23214f in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=713c2f5 ]

Merge release branch 4.7 to 4.8

* 4.7:
  CLOUDSTACK-9297: delete snapshot without id is failing with Unable to 
determine the storage pool of the snapshot


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235023#comment-15235023
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit 158d196c056b53002b417c195bd96fcc343c382d in cloudstack's branch 
refs/heads/4.8 from [~mike-tutkowski]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=158d196 ]

CLOUDSTACK-9297: delete snapshot without id is failing with Unable to determine 
the storage pool of the snapshot

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235029#comment-15235029
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit f33b4a1b687775e435baf292d9d49c0f0a418538 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f33b4a1 ]

Merge pull request #1441 from mike-tutkowski/4.7

CLOUDSTACK-9297 - Reworked logic in StorageSystemSnapshotStrategy and 
XenserverSnapshotStrategyThe ticket this PR fixes was opened because 
KVM-specific code had been added to the StorageSystemSnapshotStrategy class and 
that class' canHandle method was only prepared to handle managed storage being 
used with XenServer (and a case was hit for KVM that triggered a 
CloudRuntimeException to be thrown).

To solve the problem, I moved the KVM logic to the default snapshot strategy 
class, which is (unfortunately) named XenserverSnapshotStrategy.

I plan to rename XenserverSnapshotStrategy to something like 
DefaultSnapshotStrategy in 4.9.

My guess is that when XenserverSnapshotStrategy was originally written, it was 
written only for XenServer, but has since that time had its usage increased to 
support other hypervisors (with non-managed storage).

* pr/1441:
  CLOUDSTACK-9297: delete snapshot without id is failing with Unable to 
determine the storage pool of the snapshot

Signed-off-by: Will Stevens 


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235028#comment-15235028
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit 158d196c056b53002b417c195bd96fcc343c382d in cloudstack's branch 
refs/heads/master from [~mike-tutkowski]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=158d196 ]

CLOUDSTACK-9297: delete snapshot without id is failing with Unable to determine 
the storage pool of the snapshot

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235024#comment-15235024
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit f33b4a1b687775e435baf292d9d49c0f0a418538 in cloudstack's branch 
refs/heads/4.8 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f33b4a1 ]

Merge pull request #1441 from mike-tutkowski/4.7

CLOUDSTACK-9297 - Reworked logic in StorageSystemSnapshotStrategy and 
XenserverSnapshotStrategyThe ticket this PR fixes was opened because 
KVM-specific code had been added to the StorageSystemSnapshotStrategy class and 
that class' canHandle method was only prepared to handle managed storage being 
used with XenServer (and a case was hit for KVM that triggered a 
CloudRuntimeException to be thrown).

To solve the problem, I moved the KVM logic to the default snapshot strategy 
class, which is (unfortunately) named XenserverSnapshotStrategy.

I plan to rename XenserverSnapshotStrategy to something like 
DefaultSnapshotStrategy in 4.9.

My guess is that when XenserverSnapshotStrategy was originally written, it was 
written only for XenServer, but has since that time had its usage increased to 
support other hypervisors (with non-managed storage).

* pr/1441:
  CLOUDSTACK-9297: delete snapshot without id is failing with Unable to 
determine the storage pool of the snapshot

Signed-off-by: Will Stevens 


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235030#comment-15235030
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit f33b4a1b687775e435baf292d9d49c0f0a418538 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f33b4a1 ]

Merge pull request #1441 from mike-tutkowski/4.7

CLOUDSTACK-9297 - Reworked logic in StorageSystemSnapshotStrategy and 
XenserverSnapshotStrategyThe ticket this PR fixes was opened because 
KVM-specific code had been added to the StorageSystemSnapshotStrategy class and 
that class' canHandle method was only prepared to handle managed storage being 
used with XenServer (and a case was hit for KVM that triggered a 
CloudRuntimeException to be thrown).

To solve the problem, I moved the KVM logic to the default snapshot strategy 
class, which is (unfortunately) named XenserverSnapshotStrategy.

I plan to rename XenserverSnapshotStrategy to something like 
DefaultSnapshotStrategy in 4.9.

My guess is that when XenserverSnapshotStrategy was originally written, it was 
written only for XenServer, but has since that time had its usage increased to 
support other hypervisors (with non-managed storage).

* pr/1441:
  CLOUDSTACK-9297: delete snapshot without id is failing with Unable to 
determine the storage pool of the snapshot

Signed-off-by: Will Stevens 


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235026#comment-15235026
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit 713c2f5dccd891f8f988d9dc7dbbb4b7ca23214f in cloudstack's branch 
refs/heads/4.8 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=713c2f5 ]

Merge release branch 4.7 to 4.8

* 4.7:
  CLOUDSTACK-9297: delete snapshot without id is failing with Unable to 
determine the storage pool of the snapshot


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235025#comment-15235025
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit f33b4a1b687775e435baf292d9d49c0f0a418538 in cloudstack's branch 
refs/heads/4.8 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f33b4a1 ]

Merge pull request #1441 from mike-tutkowski/4.7

CLOUDSTACK-9297 - Reworked logic in StorageSystemSnapshotStrategy and 
XenserverSnapshotStrategyThe ticket this PR fixes was opened because 
KVM-specific code had been added to the StorageSystemSnapshotStrategy class and 
that class' canHandle method was only prepared to handle managed storage being 
used with XenServer (and a case was hit for KVM that triggered a 
CloudRuntimeException to be thrown).

To solve the problem, I moved the KVM logic to the default snapshot strategy 
class, which is (unfortunately) named XenserverSnapshotStrategy.

I plan to rename XenserverSnapshotStrategy to something like 
DefaultSnapshotStrategy in 4.9.

My guess is that when XenserverSnapshotStrategy was originally written, it was 
written only for XenServer, but has since that time had its usage increased to 
support other hypervisors (with non-managed storage).

* pr/1441:
  CLOUDSTACK-9297: delete snapshot without id is failing with Unable to 
determine the storage pool of the snapshot

Signed-off-by: Will Stevens 


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235021#comment-15235021
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1441


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235018#comment-15235018
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit 158d196c056b53002b417c195bd96fcc343c382d in cloudstack's branch 
refs/heads/4.7 from [~mike-tutkowski]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=158d196 ]

CLOUDSTACK-9297: delete snapshot without id is failing with Unable to determine 
the storage pool of the snapshot

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235020#comment-15235020
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit f33b4a1b687775e435baf292d9d49c0f0a418538 in cloudstack's branch 
refs/heads/4.7 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f33b4a1 ]

Merge pull request #1441 from mike-tutkowski/4.7

CLOUDSTACK-9297 - Reworked logic in StorageSystemSnapshotStrategy and 
XenserverSnapshotStrategyThe ticket this PR fixes was opened because 
KVM-specific code had been added to the StorageSystemSnapshotStrategy class and 
that class' canHandle method was only prepared to handle managed storage being 
used with XenServer (and a case was hit for KVM that triggered a 
CloudRuntimeException to be thrown).

To solve the problem, I moved the KVM logic to the default snapshot strategy 
class, which is (unfortunately) named XenserverSnapshotStrategy.

I plan to rename XenserverSnapshotStrategy to something like 
DefaultSnapshotStrategy in 4.9.

My guess is that when XenserverSnapshotStrategy was originally written, it was 
written only for XenServer, but has since that time had its usage increased to 
support other hypervisors (with non-managed storage).

* pr/1441:
  CLOUDSTACK-9297: delete snapshot without id is failing with Unable to 
determine the storage pool of the snapshot

Signed-off-by: Will Stevens 


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235019#comment-15235019
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-

Commit f33b4a1b687775e435baf292d9d49c0f0a418538 in cloudstack's branch 
refs/heads/4.7 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f33b4a1 ]

Merge pull request #1441 from mike-tutkowski/4.7

CLOUDSTACK-9297 - Reworked logic in StorageSystemSnapshotStrategy and 
XenserverSnapshotStrategyThe ticket this PR fixes was opened because 
KVM-specific code had been added to the StorageSystemSnapshotStrategy class and 
that class' canHandle method was only prepared to handle managed storage being 
used with XenServer (and a case was hit for KVM that triggered a 
CloudRuntimeException to be thrown).

To solve the problem, I moved the KVM logic to the default snapshot strategy 
class, which is (unfortunately) named XenserverSnapshotStrategy.

I plan to rename XenserverSnapshotStrategy to something like 
DefaultSnapshotStrategy in 4.9.

My guess is that when XenserverSnapshotStrategy was originally written, it was 
written only for XenServer, but has since that time had its usage increased to 
support other hypervisors (with non-managed storage).

* pr/1441:
  CLOUDSTACK-9297: delete snapshot without id is failing with Unable to 
determine the storage pool of the snapshot

Signed-off-by: Will Stevens 


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232255#comment-15232255
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-207452373
  
It's all set to go. :-)

On Apr 8, 2016, at 7:09 AM, Rafael Weing?rtner 
> wrote:


@swill no final comments ;)

-
You are receiving this because you were mentioned.
Reply to this email directly or view it on 
GitHub



> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232153#comment-15232153
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-207425226
  
@swill no final comments ;)


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232152#comment-15232152
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-207424478
  
It looks like I have two LGTM on this PR and the tests are passing.  This 
one is ready?  Any final comments?


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230732#comment-15230732
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-207031562
  
@mike-tutkowski, @swill I am ok with that


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230729#comment-15230729
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-207031227
  
Thanks for the comments @rafaelweingartner and @ustcweizhou.

Since canHandle is part of the infrastructure, we decided this particular 
PR isn't the place to change such a thing. Perhaps a future PR.


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230505#comment-15230505
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-206981924
  
@swill, all of my enquiries here were answered. My only complaint was about 
the method name "canHandle"; it misled me during my first and second look at 
this PR.I would prefer something like "getStorageStrategyPriority".

The code looks good to me though. LGTM ;)




> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230502#comment-15230502
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-206981349
  
@DaanHoogland I have some issues with networking when using redundant VRs 
in my environment.   I consistently have this type of issue, and it is 
unrelated to the actual code.  If it is not clear if the issue is the 
environment or the PR, I rerun the CI to validate again.  In this case I am 
confident it is my environment.  I was experimenting with running 3 stacks all 
in parallel and have found that is not realistic.


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230488#comment-15230488
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-206978195
  
@swill you have a failure, why do you want an LGTM, seems to me it didn't 
pass the tests


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230319#comment-15230319
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-206932399
  
I think this is ready pending a code review.  Can someone who has spent 
some time reviewing this PR with Mike please give me the go ahead on this PR.  
@rafaelweingartner, you have been the most active reviewing this PR, are you 
happy with the state of this PR?


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230298#comment-15230298
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-206925982
  





## CI RESULTS

### 84/85 TESTS PASSED

The only failed test is a test that often fails in my environment and is 
unrelated to this change.


**Associated Uploads**

**`test_network_2NUDW1`:**

* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1441/test_network_2NUDW1/results.txt)

**`test_vpc_routers_CHF744`:**

* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1441/test_vpc_routers_CHF744/results.txt)


Uploads will be available until `2016-06-07 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/swill/upr).*




> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226934#comment-15226934
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-205949475
  
Thanks, Will!

On Apr 5, 2016, at 12:35 PM, Will Stevens 
> wrote:


I will get CI run against this PR as soon as I have my CI reinstalled. 
Thanks @mike-tutkowski

-
You are receiving this because you were mentioned.
Reply to this email directly or view it on 
GitHub



> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226871#comment-15226871
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-205937640
  
I will get CI run against this PR as soon as I have my CI reinstalled.  
Thanks @mike-tutkowski 


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204926#comment-15204926
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1441#discussion_r56880597
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -279,7 +282,52 @@ public boolean deleteSnapshot(Long snapshotId) {
 
 @Override
 public boolean revertSnapshot(SnapshotInfo snapshot) {
-throw new CloudRuntimeException("revert Snapshot is not 
supported");
+if (canHandle(snapshot,SnapshotOperation.REVERT) == 
StrategyPriority.CANT_HANDLE) {
--- End diff --

Hi @DaanHoogland, this was only my first doubt (question). After that, 
@mike-tutkowski  and I exchanged some other messages and then I understood the 
method. I see why a boolean return would not suffice all of its needs.

I was misled by the name of the method. Every time I see a method name that 
starts with "can/has/is", I think that it will return a boolean value. 

The code of this PR is OK for me; I would only suggest a name change on 
that "canHandle" method to a more descriptive one.


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203990#comment-15203990
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1441#discussion_r56801490
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -279,7 +282,52 @@ public boolean deleteSnapshot(Long snapshotId) {
 
 @Override
 public boolean revertSnapshot(SnapshotInfo snapshot) {
-throw new CloudRuntimeException("revert Snapshot is not 
supported");
+if (canHandle(snapshot,SnapshotOperation.REVERT) == 
StrategyPriority.CANT_HANDLE) {
--- End diff --

@rafaelweingartner if you consider changing a canHandle() method take care. 
These are called over all types of resources and should not break contract as 
to not confuse any Orchestrators in the system.


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203402#comment-15203402
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user alexandrelimassantana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1441#discussion_r56768712
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
 ---
@@ -440,41 +400,28 @@ private void markAsBackedUp(SnapshotObject 
snapshotObj) {
 
 @Override
 public StrategyPriority canHandle(Snapshot snapshot, SnapshotOperation 
op) {
-long volumeId = snapshot.getVolumeId();
-VolumeVO volumeVO = _volumeDao.findById(volumeId);
 if (SnapshotOperation.REVERT.equals(op)) {
-if (volumeVO != null && 
ImageFormat.QCOW2.equals(volumeVO.getFormat()))
-return StrategyPriority.DEFAULT;
-else
-return StrategyPriority.CANT_HANDLE;
+return StrategyPriority.CANT_HANDLE;
 }
 
--- End diff --

Good work on rewritting the logic to a slimmer state.

Wouldn't be it more readable if you turn lines 407-422 into a boolean 
function which would return true if "supportsStorageSystemSnapshots". Snap this 
chunk of code could prove useful on creating unit tests and documentation as 
this segment clearly aims to check this condition solely.


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199571#comment-15199571
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197892051
  
@mike-tutkowski  could you fix the PR title and improve its description (a 
brief description of the problem and solution would do)?

Additionally, what about some unit tests to "canHandle" method? I also 
recommend to change that method return, a boolean return is more intuitive in 
my opinion; I also believe that a Java doc to that method would be appreciated.


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197484#comment-15197484
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197376318
  
Perhaps I'll rename it in 4.9 (probably not a good idea to do so in 4.7 and 
then move the name change up to 4.8 and 4.9).


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199728#comment-15199728
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197935023
  
@mike-tutkowski thanks for the improvements on PR title and description. 
I understand the point of throwing an exception and I really like that 
approach.

About the suggested change on “canHandle” method, I still did not see the 
need to use the enum. If you were using more than 2 values as its returns, it 
would be something I would understand; but you only use two values that could 
be represented as a “true” or “false”.

Could you elaborate a little bit more?
I also did not understand this sentence:
“I see returning true as your revert was successful and returning false as 
it failed (but it was OK for you to ask us to revert because canHandle properly 
told you that you could do so)”





> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1523#comment-1523
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197992182
  
got it @mike-tutkowski


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199758#comment-15199758
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197942848
  
The canHandle method is used by CloudStack's snapshot infrastructure to 
determine which snapshot strategy to use.

For example, StorageSystemSnapshotStrategy returns either 
StrategyPriority.HIGHEST or StrategyPriority.CANT_HANDLE whereas 
XenserverSnapshotStrategy returns StrategyPriority.DEFAULT or 
StrategyPriority.CANT_HANDLE.

That being the case, there are at least three options in play (and other 
people can write custom snapshot strategies that they don't even check into the 
CloudStack repo, so we can't easily just change the interface where canHandle 
is declared).

As for this sentence:

“I see returning true as your revert was successful and returning false as 
it failed (but it was OK for you to ask us to revert because canHandle properly 
told you that you could do so)”

That was in regards to the revertSnapshot method. It sounds like you agree 
with the exception being thrown there.


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199935#comment-15199935
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197975991
  
CloudStack iterates over all known snapshot strategies and asks each if it 
can handle a particular situation (take, delete, revert) for a volume or volume 
snapshot.

One with a priority higher than the others is selected.

If you can't handle the particular use case, you return CANT_HANDLE.

On Mar 17, 2016, at 12:49 PM, Rafael Weing?rtner 
> wrote:


Ok @mike-tutkowski, now I believe I 
understand a little bit more of the code.

You are reusing a method that already exist and returns the 
StrategyPriority (you did not create that method to suffice your code). I was 
misled by the name of the method, when I first saw it, I thought that the 
method was used solely to check if it can or cannot proceed with the snapshot 
when in fact it is used to do much more.

I believe "getSnapshotStrategy" would be a more suitable name.

Now that I understand what we have there, I am ok with that conditional as 
it
is.

-
You are receiving this because you were mentioned.
Reply to this email directly or view it on 
GitHub



> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199780#comment-15199780
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197948544
  
I understand that your point that some other classes can overwrite that 
method and may return other elements of the enum. However, I do not see 
anything else in the code that used the “canHandle” method return that uses the 
returned value. I mean, it is used in the “revertSnapshot” method at line 285, 
but it only checks if the return is equal to “StrategyPriority.CANT_HANDLE” and 
then throws an exception if it is. To me, that is the same as if the method 
were returning a boolean value.


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199560#comment-15199560
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1441#discussion_r56507303
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -279,7 +282,52 @@ public boolean deleteSnapshot(Long snapshotId) {
 
 @Override
 public boolean revertSnapshot(SnapshotInfo snapshot) {
-throw new CloudRuntimeException("revert Snapshot is not 
supported");
+if (canHandle(snapshot,SnapshotOperation.REVERT) == 
StrategyPriority.CANT_HANDLE) {
--- End diff --

What about changing this "canHandle" method to return a boolean if the 
snapshot can be handled, instead of a enum value?


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199697#comment-15199697
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197929660
  
Hi @rafaelweingartner Thanks for the comments.

Just wanted to point out that if the revertSnapshot method is invoked, then 
that is actually a failure of the canHandle method to inform the calling code 
to not call the revertSnapshot method, so that's why the decision was made to 
throw an exception.

I see returning true as your revert was successful and returning false as 
it failed (but it was OK for you to ask us to revert because canHandle properly 
told you that you could do so).


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197476#comment-15197476
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197375495
  
Thanks, @ustcweizhou!


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199803#comment-15199803
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197952462
  
Maybe we're looking at different code?

I see the canHandle method being used from 
StorageStrategyFactoryImpl.getSnapshotStrategy.

It has a method, bestMatch, that it makes use of to pick a snapshot 
strategy with the ordinal value.


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197478#comment-15197478
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197375867
  
Ideally, at some point in the future, we should rename 
XenserverSnapshotStrategy to something more generic (maybe 
DefaultSnapshotStrategy or something).


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199893#comment-15199893
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197970382
  
Ok @mike-tutkowski, now I believe I understand a little bit more of the 
code.

You are reusing a method that already exist and returns the 
StrategyPriority (you did not create that method to suffice your code). I was 
misled by the name of the method, when I first saw it, I thought that the 
method was used solely to check if it can or cannot proceed with the snapshot 
when in fact it is used to do much more.

I believe "getSnapshotStrategy" would be a more suitable name.

Now that I understand what we have there, I am ok with that conditional as 
it
 is.


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196811#comment-15196811
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1441#issuecomment-197164602
  
tested on KVM, it is good.
so XenserverSnapshotStrategy LGTM.



> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Mike Tutkowski (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196766#comment-15196766
 ] 

Mike Tutkowski commented on CLOUDSTACK-9297:


[~weizhou] Any chance you might have a bit of time to test PR 1441?

Here are the changes:

https://github.com/apache/cloudstack/pull/1441/files


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196764#comment-15196764
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9297:


GitHub user mike-tutkowski opened a pull request:

https://github.com/apache/cloudstack/pull/1441

CLOUDSTACK-9297: delete snapshot without id is failing with Unable to…

… determine the storage pool of the snapshot

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-tutkowski/cloudstack 4.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1441


commit 87079c56e4cc11b2a1bed817bd8c9b14c9bd3d29
Author: Mike Tutkowski 
Date:   2016-03-16T04:56:51Z

CLOUDSTACK-9297: delete snapshot without id is failing with Unable to 
determine the storage pool of the snapshot




> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.7.0, 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Mike Tutkowski (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195373#comment-15195373
 ] 

Mike Tutkowski commented on CLOUDSTACK-9297:


Hi,

I should be able to do so today. I've been at a customer site in Canada the 
past 1/2 week and didn't have a lot of available time.

I'll update this ticket later today once the PR is open.

Thanks for your patience,
Mike

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[JIRA]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194838#comment-15194838
 ] 

Özhan Rüzgar Karaman commented on CLOUDSTACK-9297:
--

Hi [~mike-tutkowski], did you find any time to create PR, we like to see this 
bugfix on any new upcoming release ;) 

by the way thanks to [~mike-tutkowski] and [~weizhou] for great work on this 
issue :)

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Mike Tutkowski (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185695#comment-15185695
 ] 

Mike Tutkowski commented on CLOUDSTACK-9297:


Great - thanks, [~weizhou]!

I can open a PR for this against 4.7.

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Wei Zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185004#comment-15185004
 ] 

Wei Zhou commented on CLOUDSTACK-9297:
--

I think we can commit to 4.7, then merge forward.



> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Wei Zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185001#comment-15185001
 ] 

Wei Zhou commented on CLOUDSTACK-9297:
--

[~mike-tutkowski] Mike, I have pasted the codes which works fine for me in the 
comments of your commit.

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Mike Tutkowski (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184973#comment-15184973
 ] 

Mike Tutkowski commented on CLOUDSTACK-9297:


Thanks [~weizhou]

Once you are OK with the code, I can open a PR.

Did we decide 4.7 is the release to introduce this fix (and then merge forward 
to subsequent branches)?

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Wei Zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184741#comment-15184741
 ] 

Wei Zhou commented on CLOUDSTACK-9297:
--

[~ozhank] Hi, please see my comments in 
https://github.com/mike-tutkowski/cloudstack/commit/bb207558a590fd648f8c3e95e840c10b5d3ed9ba



> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[JIRA]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184739#comment-15184739
 ] 

Özhan Rüzgar Karaman commented on CLOUDSTACK-9297:
--

Hi [~weizhou] , could you take a look at Mike's code when you are available, it 
could be great that if we could test and then add the code fix to 4.7 and 4.8 
and future 4.9 branches :)

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[JIRA]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177455#comment-15177455
 ] 

Özhan Rüzgar Karaman commented on CLOUDSTACK-9297:
--

We are planning to use revertSnapshot on KVM so we will wait for final fix code 
to test on our environment, thanks for all effort and replies

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Mike Tutkowski (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176484#comment-15176484
 ] 

Mike Tutkowski commented on CLOUDSTACK-9297:


Also, yes, it is weird sounding to put KVM code in a file named after 
XenServer, but that XenServer naming is actually not entirely accurate. We 
might want to change that going forward, as well.

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Mike Tutkowski (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176482#comment-15176482
 ] 

Mike Tutkowski commented on CLOUDSTACK-9297:


[~weizhou] Can you take a look at this code and see what you think? It's 
currently off of master, but I can put it into 4.7 and 4.8, too.

https://github.com/mike-tutkowski/cloudstack/commit/bb207558a590fd648f8c3e95e840c10b5d3ed9ba

[~ozhank] If you are using the revert capability of KVM volume snapshots, then 
please disregard my comments about removing the StorageSystemSnapshotStrategy 
class from your JAR file as, apparently, that revert code is currently placed 
there (it should be in XenserverSnapshotStrategy, which is part of my 
recommended code changes I'm showing Wei).

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Tutkowski, Mike (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176425#comment-15176425
 ] 

Tutkowski, Mike commented on CLOUDSTACK-9297:
-

Sounds good – thanks

Sent from my iPhone



> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Wei Zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176415#comment-15176415
 ] 

Wei Zhou commented on CLOUDSTACK-9297:
--

4.6 is out of date, maybe 4.7 or later ?



> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Tutkowski, Mike (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176394#comment-15176394
 ] 

Tutkowski, Mike commented on CLOUDSTACK-9297:
-

Yes, we can move that to the snapshot strategy you refer to, Wei. That logic 
should not be in this snapshot strategy.

Are we still patching 4.6?

If so, I can put the code in that release and merge forward to subsequent 
releases.

Sent from my iPhone



> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Wei Zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176354#comment-15176354
 ] 

Wei Zhou commented on CLOUDSTACK-9297:
--

Mike's change looks good to me, except the revertSnapshot (it will break the 
revertSnapshot on KVM).



> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Wei Zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176346#comment-15176346
 ] 

Wei Zhou commented on CLOUDSTACK-9297:
--

[~mike-tutkowski] Mike, the revertSnapshot is enabled for KVM now. so, we'd 
better move the implementation of RevertSnapshot from 
StorageSystemSnapshotStrategy.java to XenserverSnapshotStrategy.java ?

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Mike Tutkowski (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176081#comment-15176081
 ] 

Mike Tutkowski commented on CLOUDSTACK-9297:


[~ozhank] Technically, if you're OK with updating a JAR file, you don't even 
need to wait for a code fix for this.

You can navigate to your cloud-engine-storage-snapshot JAR file (mine is called 
cloud-engine-storage-snapshot-4.8.0.jar), remove the 
StorageSystemSnapshotStrategy.class file, then reboot the management server.

Just an FYI: JAR files are ZIP files, so any software that can open a ZIP file 
can open a JAR file.

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Mike Tutkowski (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176027#comment-15176027
 ] 

Mike Tutkowski commented on CLOUDSTACK-9297:


This is what I think we should change the code to (starting in 4.6 and going 
through 4.9).

Context reminder: This SnapshotStrategy is only intended to be used with volume 
snapshots that reside on primary storage (not our traditional volume snapshots).

This SnapshotStrategy should not handle any reverts.

We should try to get the storage pool ID from the cloud.snapshot_store_ref 
table using the ID of the snapshot and the store_role of "PRIMARY".

In the situation of this issue, null would be assigned to snapshotStore and we 
would defer deletion to another SnapshotStrategy.

@Override
public StrategyPriority canHandle(Snapshot snapshot, SnapshotOperation op) {
if (SnapshotOperation.REVERT.equals(op)) {
return StrategyPriority.CANT_HANDLE;
}

final long storagePoolId;

SnapshotDataStoreVO snapshotStore = 
_snapshotStoreDao.findBySnapshot(snapshot.getId(), DataStoreRole.Primary);

if (snapshotStore != null) {
storagePoolId = snapshotStore.getDataStoreId();
}
else {
return StrategyPriority.CANT_HANDLE;
}

DataStore dataStore = _dataStoreMgr.getDataStore(storagePoolId, 
DataStoreRole.Primary);

Map mapCapabilities = 
dataStore.getDriver().getCapabilities();

if (mapCapabilities != null) {
String value = 
mapCapabilities.get(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT.toString());
Boolean supportsStorageSystemSnapshots = new Boolean(value);

if (supportsStorageSystemSnapshots) {
return StrategyPriority.HIGHEST;
}
}

return StrategyPriority.CANT_HANDLE;
}

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Mike Tutkowski (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175928#comment-15175928
 ] 

Mike Tutkowski commented on CLOUDSTACK-9297:


Yes, thank you, Wei.

I should have used "IncludingRemoved" here.

Beyond that, though, I actually did not intend on the 
StorageSystemSnapshotStrategy's delete to be used for standard volume snapshots 
(only for volume snapshots that exists on primary storage...in which case, the 
delete works fine even when the source volume is gone).

I should change the code to check if the snapshot to delete exists on primary 
storage. If not, return StrategyPriority.CANT_HANDLE.

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Wei Zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175440#comment-15175440
 ] 

Wei Zhou commented on CLOUDSTACK-9297:
--

this makes more sense to me.

{code}
diff --git 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
 b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/Stora
index d1470e4..088fe38 100644
--- 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
+++ 
b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
@@ -456,8 +456,10 @@ public class StorageSystemSnapshotStrategy extends 
SnapshotStrategyBase {

 if (snapshotStore != null) {
 storagePoolId = snapshotStore.getDataStoreId();
-}
-else {
+} else if (SnapshotOperation.DELETE.equals(op)) {
+volumeVO = _volumeDao.findByIdIncludingRemoved(volumeId);
+storagePoolId = volumeVO.getPoolId();
+} else {
 throw new CloudRuntimeException("Unable to determine the 
storage pool of the snapshot");
 }
 }
{code}

> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[Wei Zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175327#comment-15175327
 ] 

Wei Zhou commented on CLOUDSTACK-9297:
--

we have two solutions to fix it.

1. 
{code}
diff --git 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
 b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/Stora
index d1470e4..ae1be51 100644
--- 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
+++ 
b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
@@ -449,21 +449,8 @@ public class StorageSystemSnapshotStrategy extends 
SnapshotStrategyBase {
 return StrategyPriority.CANT_HANDLE;
 }

-long storagePoolId;
-
-if (volumeVO == null) {
-SnapshotDataStoreVO snapshotStore = 
_snapshotStoreDao.findBySnapshot(snapshot.getId(), DataStoreRole.Primary);
-
-if (snapshotStore != null) {
-storagePoolId = snapshotStore.getDataStoreId();
-}
-else {
-throw new CloudRuntimeException("Unable to determine the 
storage pool of the snapshot");
-}
-}
-else {
-storagePoolId = volumeVO.getPoolId();
-}
+volumeVO = _volumeDao.findByIdIncludingRemoved(volumeId);
+long storagePoolId = volumeVO.getPoolId();

 DataStore dataStore = _dataStoreMgr.getDataStore(storagePoolId, 
DataStoreRole.Primary);
{code}

2. 
{code}
diff --git 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
 b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/Stora
index d1470e4..14b3d60 100644
--- 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
+++ 
b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
@@ -458,7 +458,8 @@ public class StorageSystemSnapshotStrategy extends 
SnapshotStrategyBase {
 storagePoolId = snapshotStore.getDataStoreId();
 }
 else {
-throw new CloudRuntimeException("Unable to determine the 
storage pool of the snapshot");
+volumeVO = _volumeDao.findByIdIncludingRemoved(volumeId);
+storagePoolId = volumeVO.getPoolId();
 }
 }
 else {
{code}

[~mike-tutkowski] you are the author of StorageSystemSnapshotStrategy.java. can 
you have a look ?


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> ---
>
> Key: CLOUDSTACK-9297
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.8.0
> Environment: Ubuntu 14.04.3 management + kvm
>Reporter: Özhan Rüzgar Karaman
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9297) delete snapshot without id is failing with Unable to determine the storage pool of the snapshot

[JIRA]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168873#comment-15168873
 ] 

Özhan Rüzgar Karaman commented on CLOUDSTACK-9297:
--

Hi;
We noticed an issue at delete snapshot function/api for ACS 4.8 and also 4.6, 
when you took some snapshots and you delete its related vm you could not delete 
remaining snapshots. When you try to delete snapshot you receive exception like 
"Error Message : Unable to determine the storage pool of the snapshot."

We checked the management server logs and received exception is below:

2016-02-24 11:37:15,107 ERROR [c.c.a.ApiAsyncJobDispatcher] 
(API-Job-Executor-31:ctx-d769e109 job-1336) (logid:dabf8e11) Unexpected 
exception while 
executing org.apache.cloudstack.api.command.user.snapshot.DeleteSnapshotCmd
com.cloud.utils.exception.CloudRuntimeException: Unable to determine the 
storage pool of the snapshot
at 
org.apache.cloudstack.storage.snapshot.StorageSystemSnapshotStrategy.canHandle(StorageSystemSnapshotStrategy.java:461)
at 
org.apache.cloudstack.storage.helper.StorageStrategyFactoryImpl$3.canHandle(StorageStrategyFactoryImpl.java:72)
at 
org.apache.cloudstack.storage.helper.StorageStrategyFactoryImpl$3.canHandle(StorageStrategyFactoryImpl.java:69)
at 
org.apache.cloudstack.storage.helper.StorageStrategyFactoryImpl.bestMatch(StorageStrategyFactoryImpl.java:95)
at 
org.apache.cloudstack.storage.helper.StorageStrategyFactoryImpl.getSnapshotStrategy(StorageStrategyFactoryImpl.java:69)
at 
com.cloud.storage.snapshot.SnapshotManagerImpl.deleteSnapshot(SnapshotManagerImpl.java:444)
at sun.reflect.GeneratedMethodAccessor722.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
at 
org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
at 
com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
at 
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
at com.sun.proxy.$Proxy187.deleteSnapshot(Unknown Source)
at 
org.apache.cloudstack.api.command.user.snapshot.DeleteSnapshotCmd.execute(DeleteSnapshotCmd.java:103)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
at 
com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:108)
at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:554)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at 
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:502)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
 

To generate this issue, you could use the test cases below:

Test Case 1:
A new vm was created. (NewVM01)
NewVM01 has stopped and took its snapshot. (NewVM01Snap01)
We took 3 more snapshots. (NewVM01Snap02, NewVM01Snap03, NewVM01Snap04)
We delete NewVM01Snap02 snapshot successfully.
We delete NewVM01 vm successfully.
We delete NewVM01Snap01 snapshot successfully.
Then