[GitHub] [flink] lsyldliu commented on issue #11482: [FLINK-16581][table] Minibatch deduplication lack state TTL bug fix
lsyldliu commented on issue #11482: [FLINK-16581][table] Minibatch deduplication lack state TTL bug fix URL: https://github.com/apache/flink/pull/11482#issuecomment-603655279 > Hi @lsyldliu , we have some discussion on JIRA. sorry，I didn't noitce that This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397622942 ## File path: docs/index.md ## @@ -0,0 +1,53 @@ +--- +title: "Stateful Functions - An Apache Flink® Project" +nav-pos: 0 +nav-title: ' Home' +nav-parent_id: root +--- + + +## A Framework for Stateful Distributed Applications Review comment: I think this sub-title is redundant. The contents of this section can sit right under the main title of this homepage, as a brief intro. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11500: [FLINK-16749][k8s] Support to set node selector for jobmanager and taskmanager pod
flinkbot edited a comment on issue #11500: [FLINK-16749][k8s] Support to set node selector for jobmanager and taskmanager pod URL: https://github.com/apache/flink/pull/11500#issuecomment-603249602 ## CI report: * cb64b4dc39e134accc8a172dcfa7a401820c672f Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154787753) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6579) * 047024394fbb562aba7d5cfb5e5941725e4b3801 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155014690) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6602) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11448: [FLINK-16666][python][table] Support new Python dependency configuration options in flink-java, flink-streaming-java and flink-table.
flinkbot edited a comment on issue #11448: [FLINK-1][python][table] Support new Python dependency configuration options in flink-java, flink-streaming-java and flink-table. URL: https://github.com/apache/flink/pull/11448#issuecomment-601042255 ## CI report: * cc79d224138b05cd18a1b221217a588cf65a5a72 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154988429) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6598) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397622642 ## File path: docs/index.md ## @@ -0,0 +1,53 @@ +--- +title: "Stateful Functions - An Apache Flink® Project" Review comment: Would it be better to rename this title to be, `Apache Flink Stateful Functions Documentation`, to be more consistent with how the Flink docs look?:  I also like how the Flink docs home page has a line providing the meta information of the docs build: `This documentation is for Apache Flink version xxx. These pages were built at yyy`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11440: [FLINK-16647][table-runtime-blink][hive] Miss file extension when ins…
flinkbot edited a comment on issue #11440: [FLINK-16647][table-runtime-blink][hive] Miss file extension when ins… URL: https://github.com/apache/flink/pull/11440#issuecomment-600593420 ## CI report: * 75499741faf565a3af7c70f5a04c01a411eb372e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154527068) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6497) * aa6489490c288329135f46be3a4369301b1eba28 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11455: [FLINK-16098] [chinese-translation, Documentation] Translate "Overvie…
flinkbot edited a comment on issue #11455: [FLINK-16098] [chinese-translation, Documentation] Translate "Overvie… URL: https://github.com/apache/flink/pull/11455#issuecomment-601267029 ## CI report: * 7635c5129b1c9babc332f9c6eac07e65445f Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6567) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11486: [FLINK-16712][task] Refactor StreamTask to construct final fields
flinkbot edited a comment on issue #11486: [FLINK-16712][task] Refactor StreamTask to construct final fields URL: https://github.com/apache/flink/pull/11486#issuecomment-602377929 ## CI report: * 502f33e71092027ca04a464a213378af173f5fa5 UNKNOWN * 9d88662d7b4ba04fde20491e72d18a522d17d8ee Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154984059) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6595) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11496: [FLINK-16743][table] Introduce datagen, print, blackhole connectors
flinkbot edited a comment on issue #11496: [FLINK-16743][table] Introduce datagen, print, blackhole connectors URL: https://github.com/apache/flink/pull/11496#issuecomment-603106096 ## CI report: * 012c84d9b7a031d25adff5f8cfb11d444631ebcf Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154984090) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6597) * e117f7e1167d948d31ff78047e00382cfc989978 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155014673) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6601) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11455: [FLINK-16098] [chinese-translation, Documentation] Translate "Overvie…
JingsongLi commented on issue #11455: [FLINK-16098] [chinese-translation, Documentation] Translate "Overvie… URL: https://github.com/apache/flink/pull/11455#issuecomment-603651467 @flinkbot run travis @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11500: [FLINK-16749][k8s] Support to set node selector for jobmanager and taskmanager pod
flinkbot edited a comment on issue #11500: [FLINK-16749][k8s] Support to set node selector for jobmanager and taskmanager pod URL: https://github.com/apache/flink/pull/11500#issuecomment-603249602 ## CI report: * cb64b4dc39e134accc8a172dcfa7a401820c672f Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154787753) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6579) * 047024394fbb562aba7d5cfb5e5941725e4b3801 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11496: [FLINK-16743][table] Introduce datagen, print, blackhole connectors
flinkbot edited a comment on issue #11496: [FLINK-16743][table] Introduce datagen, print, blackhole connectors URL: https://github.com/apache/flink/pull/11496#issuecomment-603106096 ## CI report: * 012c84d9b7a031d25adff5f8cfb11d444631ebcf Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154984090) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6597) * e117f7e1167d948d31ff78047e00382cfc989978 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero URL: https://github.com/apache/flink/pull/11351#discussion_r397618266 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java ## @@ -56,6 +57,10 @@ protected final SingleInputGate inputGate; + protected long currentCheckpointId = -1; + + protected ChannelState channelState = ChannelState.CONSUMING; Review comment: For the case of `LocalInputChannel`, the current problem is that when the subparition view notifies the data available, then the respective local channel would be added into gate data queue. When the gate pools buffer from such local channel, it should be aware whether this local channel was already blocked by `CheckpointBarrierAligner` or not. If blocked, it should not return this buffer to upper component to avoid caching. Another option to solve this issue is to avoid adding local channel into gate queue via tagging the blocked state in `ResultSubpartitionView`. We already added this state in `NetworkSequenceViewReader` for remote channel. If we can migrate this state into `ResultSubpartitionView` level, then we can make reuse of this state for both remote and local channels. And I think it should be transparent to do the similar things either in `NetworkSequenceViewReader` or `ResultSubpartitionView`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-16767) Failed to read Hive table with RegexSerDe
Rui Li created FLINK-16767: -- Summary: Failed to read Hive table with RegexSerDe Key: FLINK-16767 URL: https://issues.apache.org/jira/browse/FLINK-16767 Project: Flink Issue Type: Bug Components: Connectors / Hive Affects Versions: 1.10.0 Reporter: Rui Li -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port
StateFun Documentation to Jekyll
URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397612645
##
File path: docs/_config.yml
##
@@ -0,0 +1,98 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#--
+# VARIABLES
+#--
+# Variables specified in this file can be used in the documentation via:
+# {{ site.CONFIG_KEY }}
+#--
+
+# This are the version referenced in the docs. Please only use these variables
+# to reference a specific Flink version, because this is the only place where
+# we change the version for the complete docs when forking of a release branch
+# etc.
+# The full version string as referenced in Maven (e.g. 1.2.1)
+version: "2.0-SNAPSHOT"
Review comment:
Current master is `2.1-SNAPSHOT`
```suggestion
version: "2.1-SNAPSHOT"
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port
StateFun Documentation to Jekyll
URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397615411
##
File path: docs/_layouts/plain.html
##
@@ -0,0 +1,78 @@
+---
+layout: base
+---
+
+
+{%- assign active_pages = site.array -%}
+{%- assign active = page -%}
+
+{%- for i in (1..10) -%}
+ {%- assign active_pages = active_pages | push: active -%}
+ {%- if active.nav-parent_id -%}
+{%- assign next = site.pages_by_language[page.language] | where: "nav-id"
, active.nav-parent_id -%}
+{%- if next.size > 0 -%}
+ {%- assign active = next[0] -%}
+{%- else -%}
+ {%- break -%}
+{%- endif -%}
+ {%- else -%}
+{%- break -%}
+ {%- endif -%}
+{%- endfor -%}
+
+{% assign active_pages = active_pages | reverse %}
+
+
+{%- for p in active_pages %}
+ {% capture title %}{% if p.nav-title %}{{ p.nav-title }}{% else %}{{ p.title
}}{% endif %}{% endcapture -%}
+ {%- if forloop.last == true %}
+{{ title }}
+ {%- elsif p.nav-show_overview %}
+{{ title }}
+ {%- else %}
+{{ title }}
+ {%- endif -%}
+{%- endfor %}
+
+
+{{ page.title }}{% if page.is_beta %} Beta{%
endif %}
+{% if site.show_outdated_warning %}
+
+ {%- if page.language == "en" %}
+This documentation is for an out-of-date version of Apache Flink.
We recommend you use https://ci.apache.org/projects/flink/flink-docs-stable/;>the latest
stable version.
Review comment:
```suggestion
This documentation is for an out-of-date version of Apache Flink
Stateful Functions. We recommend you use https://ci.apache.org/projects/flink/flink-statefun-docs-stable/;>the
latest stable version.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port
StateFun Documentation to Jekyll
URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397614108
##
File path: docs/_includes/sidenav.html
##
@@ -0,0 +1,185 @@
+
+
+{%- comment -%}
+==
+Extract the active nav IDs.
+==
+{%- endcomment -%}
+
+{%- assign active_nav_ids = site.array -%}
+{%- assign parent_id = page.nav-parent_id -%}
+
+{%- for i in (1..10) -%}
+ {%- if parent_id -%}
+{%- assign active_nav_ids = active_nav_ids | push: parent_id -%}
+{%- assign current = (site.pages_by_language[page.language] | where:
"nav-id" , parent_id | sort: "nav-pos") -%}
+{%- if current.size > 0 -%}
+ {%- assign parent_id = current[0].nav-parent_id -%}
+{%- else -%}
+ {%- break -%}
+{%- endif -%}
+ {%- else -%}
+{%- break -%}
+ {%- endif -%}
+{%- endfor -%}
+
+{%- if page.language == "en" -%}
+ {%- capture baseurl_i18n -%}{{ site.baseurl }}{%- endcapture -%}
+{%- else if page.language == "zh" -%}
+ {%- capture baseurl_i18n -%}{{ site.baseurl }}/{{ page.language }}{%-
endcapture -%}
+{%- endif -%}
+
+{%- comment -%}
+==
+Build the nested list from nav-id and nav-parent_id relations.
+==
+This builds a nested list from all pages. The fields used to determine the
+structure are:
+
+- 'nav-id' => ID of this page. Other pages can use this ID as their
+ parent ID.
+- 'nav-parent_id' => ID of the parent. This page will be listed under
+ the page with id 'nav-parent_id'.
+
+Level 0 is made up of all pages, which have nav-parent_id set to 'root'.
+
+The 'title' of the page is used as the default link text. You can
+override this via 'nav-title'. The relative position per navigational
+level is determined by 'nav-pos'.
+{%- endcomment -%}
+
+{%- assign elementsPosStack = site.array -%}
+{%- assign posStack = site.array -%}
+
+{%- assign elements = site.array -%}
+{%- assign all_pages_by_nav_parent = (site.pages_by_language[page.language] |
where_exp: "item", "item.nav-parent_id != nil" | group_by: "nav-parent_id") -%}
+{%- assign children = (all_pages_by_nav_parent | where: "name" , "root") -%}
+{%- assign children = (children[0].items | sort: "nav-pos") -%}
+{%- if children.size > 0 -%}
+ {%- assign elements = elements | push: children -%}
+{%- endif -%}
+
+{%- assign elementsPos = 0 -%}
+{%- assign pos = 0 -%}
+
+
+ v{{
site.version_title }}
Review comment:
I think we need to decide what we want put here as the logo.
It is definitely a bit weird looking at it now, that we're using the Flink
squirrel logo here, because at first glance it looks like `Apache Flink
v2.0-SNAPSHOT`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port
StateFun Documentation to Jekyll
URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397615466
##
File path: docs/_layouts/plain.html
##
@@ -0,0 +1,78 @@
+---
+layout: base
+---
+
+
+{%- assign active_pages = site.array -%}
+{%- assign active = page -%}
+
+{%- for i in (1..10) -%}
+ {%- assign active_pages = active_pages | push: active -%}
+ {%- if active.nav-parent_id -%}
+{%- assign next = site.pages_by_language[page.language] | where: "nav-id"
, active.nav-parent_id -%}
+{%- if next.size > 0 -%}
+ {%- assign active = next[0] -%}
+{%- else -%}
+ {%- break -%}
+{%- endif -%}
+ {%- else -%}
+{%- break -%}
+ {%- endif -%}
+{%- endfor -%}
+
+{% assign active_pages = active_pages | reverse %}
+
+
+{%- for p in active_pages %}
+ {% capture title %}{% if p.nav-title %}{{ p.nav-title }}{% else %}{{ p.title
}}{% endif %}{% endcapture -%}
+ {%- if forloop.last == true %}
+{{ title }}
+ {%- elsif p.nav-show_overview %}
+{{ title }}
+ {%- else %}
+{{ title }}
+ {%- endif -%}
+{%- endfor %}
+
+
+{{ page.title }}{% if page.is_beta %} Beta{%
endif %}
+{% if site.show_outdated_warning %}
+
+ {%- if page.language == "en" %}
+This documentation is for an out-of-date version of Apache Flink.
We recommend you use https://ci.apache.org/projects/flink/flink-docs-stable/;>the latest
stable version.
+ {%- else if page.language == "zh" %}
+本文档是 Apache Flink 的旧版本。建议访问 https://ci.apache.org/projects/flink/flink-docs-stable/zh;>最新的稳定版本。
Review comment:
```suggestion
本文档是 Apache Flink Stateful Functions 的旧版本。建议访问 https://ci.apache.org/projects/flink/flink-statefun-docs-stable/zh;>最新的稳定版本。
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port
StateFun Documentation to Jekyll
URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397615211
##
File path: docs/_layouts/base.html
##
@@ -0,0 +1,118 @@
+
+
+
+
+
+
+
+
+Apache Flink {{ site.version_title }} Documentation: {{ page.title
}}
+
+
+
+
+
+https://maxcdn.bootstrapcdn.com/bootstrap/3.3.4/css/bootstrap.min.css;>
+
+
+
+
+{% if page.mathjax %}
+
+MathJax.Hub.Config({
+tex2jax: {
+ inlineMath: [['$','$'], ['\\(','\\)']] },
+TeX: {
+ equationNumbers: { autoNumber: "AMS" } }
+});
+
+https://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML";>
+
+{% endif %}
+
+
+
+
+
+{% if site.show_outdated_warning %}
+
+ {% if page.language == "en" %}
+This documentation is for an out-of-date version of Apache Flink. We
recommend you use https://ci.apache.org/projects/flink/flink-docs-stable/;>the latest
stable version.
+ {% else if page.language == "zh" %}
+本文档是 Apache Flink 的旧版本。建议访问 https://ci.apache.org/projects/flink/flink-docs-stable/zh;>最新的稳定版本。
Review comment:
```suggestion
本文档是 Apache Flink Stateful Functions 的旧版本。建议访问 https://ci.apache.org/projects/flink/flink-statefun-docs-stable/zh;>最新的稳定版本。
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397612063 ## File path: docs/README.md ## @@ -0,0 +1,157 @@ +This README gives an overview of how to build and contribute to the documentation of Apache Flink. Review comment: Could you rename the mentions of `Apache Flink` here as appropriate to mention `Stateful Functions` instead? In general the references in this README needs to be adjusted. ```suggestion This README gives an overview of how to build and contribute to the documentation of Stateful Functions. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port
StateFun Documentation to Jekyll
URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397614727
##
File path: docs/_layouts/base.html
##
@@ -0,0 +1,118 @@
+
+
+
+
+
+
+
+
+Apache Flink {{ site.version_title }} Documentation: {{ page.title
}}
Review comment:
```suggestion
Apache Flink Stateful Functions {{ site.version_title }}
Documentation: {{ page.title }}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397612481 ## File path: docs/README.md ## @@ -0,0 +1,157 @@ +This README gives an overview of how to build and contribute to the documentation of Apache Flink. + +The documentation is included with the source of Apache Flink in order to ensure that you always Review comment: ```suggestion The documentation is included with the source of Stateful Functions in order to ensure that you always ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port
StateFun Documentation to Jekyll
URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397615103
##
File path: docs/_layouts/base.html
##
@@ -0,0 +1,118 @@
+
+
+
+
+
+
+
+
+Apache Flink {{ site.version_title }} Documentation: {{ page.title
}}
+
+
+
+
+
+https://maxcdn.bootstrapcdn.com/bootstrap/3.3.4/css/bootstrap.min.css;>
+
+
+
+
+{% if page.mathjax %}
+
+MathJax.Hub.Config({
+tex2jax: {
+ inlineMath: [['$','$'], ['\\(','\\)']] },
+TeX: {
+ equationNumbers: { autoNumber: "AMS" } }
+});
+
+https://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML";>
+
+{% endif %}
+
+
+
+
+
+{% if site.show_outdated_warning %}
+
+ {% if page.language == "en" %}
+This documentation is for an out-of-date version of Apache Flink. We
recommend you use https://ci.apache.org/projects/flink/flink-docs-stable/;>the latest
stable version.
Review comment:
```suggestion
This documentation is for an out-of-date version of Apache Flink
Stateful Functions. We recommend you use https://ci.apache.org/projects/flink/flink-statefun-docs-stable/;>the
latest stable version.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port
StateFun Documentation to Jekyll
URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397614983
##
File path: docs/_layouts/base.html
##
@@ -0,0 +1,118 @@
+
+
+
+
+
+
+
+
+Apache Flink {{ site.version_title }} Documentation: {{ page.title
}}
+
Review comment:
Consider switching to Stateful Functions favicon
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397613180 ## File path: docs/_config_dev_zh.yml ## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License + +exclude: Review comment: Actually, maybe leave it as is in case we do want to add Chinese docs in the future :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll
tzulitai commented on a change in pull request #73: [FLINK-16758][docs] Port StateFun Documentation to Jekyll URL: https://github.com/apache/flink-statefun/pull/73#discussion_r397613018 ## File path: docs/_config_dev_zh.yml ## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License + +exclude: Review comment: Can this file be deleted? We don't have Chinese docs right now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11440: [FLINK-16647][table-runtime-blink][hive] Miss file extension when ins…
JingsongLi commented on issue #11440: [FLINK-16647][table-runtime-blink][hive] Miss file extension when ins… URL: https://github.com/apache/flink/pull/11440#issuecomment-603648514 Hi @lirui-apache , can you rebase to trigger travis? And please create a pull request for release-1.10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11440: [FLINK-16647][table-runtime-blink][hive] Miss file extension when ins…
JingsongLi commented on issue #11440: [FLINK-16647][table-runtime-blink][hive] Miss file extension when ins… URL: https://github.com/apache/flink/pull/11440#issuecomment-603647945 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] JingsongLi closed pull request #11391: [FLINK-16098] [chinese-translation, Documentation] Translate "Overview" page of "Hive Integration" into Chinese
JingsongLi closed pull request #11391: [FLINK-16098] [chinese-translation, Documentation] Translate "Overview" page of "Hive Integration" into Chinese URL: https://github.com/apache/flink/pull/11391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (FLINK-16478) add restApi to modify loglevel
[ https://issues.apache.org/jira/browse/FLINK-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066397#comment-17066397 ] Canbin Zheng edited comment on FLINK-16478 at 3/25/20, 5:24 AM: Thanks for creating this issue, [~xiaodao]. Some of the users on our platform are asking for this feature and I think it helps a lot for the users to debug online problems. Internally we are planning to support it via WEBUI/rest API. Do you have an implementation plan on this ticket? Maybe we could work together. was (Author: felixzheng): Thanks for creating this issue, [~xiaodao]. Some of the users on our platform are asking for this feature and I think it helps a lot for the users to debug online problems. Internally we are planning to support it via WEBUI/rest API. Do you have an implementation on this ticket? Maybe we could work together. > add restApi to modify loglevel > --- > > Key: FLINK-16478 > URL: https://issues.apache.org/jira/browse/FLINK-16478 > Project: Flink > Issue Type: Improvement > Components: Runtime / REST >Reporter: xiaodao >Priority: Minor > > sometimes we may need to change loglevel to get more information to resolved > bug, now we need to stop it and modify conf/log4j.properties and resubmit it > ,i think it's better to add rest api to modify loglevel. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-16478) add restApi to modify loglevel
[ https://issues.apache.org/jira/browse/FLINK-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066397#comment-17066397 ] Canbin Zheng commented on FLINK-16478: -- Thanks for creating this issue, [~xiaodao]. Some of the users on our platform are asking for this feature and I think it helps a lot for the users to debug online problems. Internally we are planning to support it via WEBUI/rest API. Do you have an implementation on this ticket? Maybe we could work together. > add restApi to modify loglevel > --- > > Key: FLINK-16478 > URL: https://issues.apache.org/jira/browse/FLINK-16478 > Project: Flink > Issue Type: Improvement > Components: Runtime / REST >Reporter: xiaodao >Priority: Minor > > sometimes we may need to change loglevel to get more information to resolved > bug, now we need to stop it and modify conf/log4j.properties and resubmit it > ,i think it's better to add rest api to modify loglevel. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FLINK-15579) UpsertStreamTableSink should work on batch mode
[
https://issues.apache.org/jira/browse/FLINK-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee resolved FLINK-15579.
--
Resolution: Fixed
master:
56424794c291b9115080005220a17963048c3621
d38a010c55ad78f4e421d581ec72a96a79324dfe
> UpsertStreamTableSink should work on batch mode
> ---
>
> Key: FLINK-15579
> URL: https://issues.apache.org/jira/browse/FLINK-15579
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.9.2, 1.10.0
>Reporter: Shu Li Zheng
>Assignee: Shu Li Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Because JDBCTableSourceSinkFactory.createStreamTableSink() create
> JDBCUpsertTableSink. But BatchExecSink can not work with
> UpsertStreamTableSink.
> {code:scala}
> override protected def translateToPlanInternal(
> planner: BatchPlanner): Transformation[Any] = {
> val resultTransformation = sink match {
> case _: RetractStreamTableSink[T] | _: UpsertStreamTableSink[T] =>
> throw new TableException("RetractStreamTableSink and
> UpsertStreamTableSink is not" +
> " supported in Batch environment.")
> {code}
> DDL like:
> CREATE TABLE USER_RESULT(
> NAME VARCHAR,
> CITY VARCHAR,
> SCORE BIGINT
> ) WITH (
> 'connector.type' = 'jdbc',
> 'connector.url' = '',
> 'connector.table' = '',
> 'connector.driver' = 'com.mysql.cj.jdbc.Driver',
> 'connector.username' = 'root',
> 'connector.password' = '',
> 'connector.write.flush.interval' = '1s')
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] JingsongLi commented on issue #11045: [FLINK-15579][table-planner-blink] Support UpsertStreamTableSink on Blink batch mode.
JingsongLi commented on issue #11045: [FLINK-15579][table-planner-blink] Support UpsertStreamTableSink on Blink batch mode. URL: https://github.com/apache/flink/pull/11045#issuecomment-603644314 Keep commit in https://github.com/apache/flink/pull/11490 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-15579) UpsertStreamTableSink should work on batch mode
[
https://issues.apache.org/jira/browse/FLINK-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee updated FLINK-15579:
-
Fix Version/s: 1.11.0
> UpsertStreamTableSink should work on batch mode
> ---
>
> Key: FLINK-15579
> URL: https://issues.apache.org/jira/browse/FLINK-15579
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.9.2, 1.10.0
>Reporter: Shu Li Zheng
>Assignee: Shu Li Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Because JDBCTableSourceSinkFactory.createStreamTableSink() create
> JDBCUpsertTableSink. But BatchExecSink can not work with
> UpsertStreamTableSink.
> {code:scala}
> override protected def translateToPlanInternal(
> planner: BatchPlanner): Transformation[Any] = {
> val resultTransformation = sink match {
> case _: RetractStreamTableSink[T] | _: UpsertStreamTableSink[T] =>
> throw new TableException("RetractStreamTableSink and
> UpsertStreamTableSink is not" +
> " supported in Batch environment.")
> {code}
> DDL like:
> CREATE TABLE USER_RESULT(
> NAME VARCHAR,
> CITY VARCHAR,
> SCORE BIGINT
> ) WITH (
> 'connector.type' = 'jdbc',
> 'connector.url' = '',
> 'connector.table' = '',
> 'connector.driver' = 'com.mysql.cj.jdbc.Driver',
> 'connector.username' = 'root',
> 'connector.password' = '',
> 'connector.write.flush.interval' = '1s')
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #11496: [FLINK-16743][table] Introduce datagen, print, blackhole connectors
flinkbot edited a comment on issue #11496: [FLINK-16743][table] Introduce datagen, print, blackhole connectors URL: https://github.com/apache/flink/pull/11496#issuecomment-603106096 ## CI report: * 012c84d9b7a031d25adff5f8cfb11d444631ebcf Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154984090) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6597) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] JingsongLi closed pull request #11045: [FLINK-15579][table-planner-blink] Support UpsertStreamTableSink on Blink batch mode.
JingsongLi closed pull request #11045: [FLINK-15579][table-planner-blink] Support UpsertStreamTableSink on Blink batch mode. URL: https://github.com/apache/flink/pull/11045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11500: [FLINK-16749][k8s] Support to set node selector for jobmanager and taskmanager pod
wangyang0918 commented on issue #11500: [FLINK-16749][k8s] Support to set node selector for jobmanager and taskmanager pod URL: https://github.com/apache/flink/pull/11500#issuecomment-603644181 @tillrohrmann Thanks for your comments. I have rebased on the latest master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] JingsongLi merged pull request #11490: [FLINK-15579][table-planner-blink] UpsertStreamTableSink should work on batch mode
JingsongLi merged pull request #11490: [FLINK-15579][table-planner-blink] UpsertStreamTableSink should work on batch mode URL: https://github.com/apache/flink/pull/11490 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero URL: https://github.com/apache/flink/pull/11351#discussion_r397610517 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java ## @@ -56,6 +57,10 @@ protected final SingleInputGate inputGate; + protected long currentCheckpointId = -1; + + protected ChannelState channelState = ChannelState.CONSUMING; Review comment: I considered discarding these two states in `InputChannel` level to unify reuse the states inside `CheckpointBarrierAligner`. Regarding the `RemoteInputChannel` case, these two states are used for avoiding unnecessary notification for upstream side if the unblock is triggered by other channels. One possible option is to pass the boolean array of blocked channels` from `CheckpointBarrierAligner` while calling `notifyCheckpointCompletedOrCanceled`. In `CheckpointedInputGate` and `UnionInputGate` level, they can also pass the maintained `offsetIndex` to dedicated `SingleInputGate`, then the single gate can judge whether the respective `RemoteInputChannel` is actually blocked or not to notify the upstream side if necessary. Regarding the `LocalInputChannel` case, we can consider it separately. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11489: [FLINK-15640][k8s] Support to set labels for jobmanager and taskmanager pod
flinkbot edited a comment on issue #11489: [FLINK-15640][k8s] Support to set labels for jobmanager and taskmanager pod URL: https://github.com/apache/flink/pull/11489#issuecomment-602514343 ## CI report: * 496e0c34c6cdc9c6a4b1bf6a72df71328c2580e8 UNKNOWN * 5fc814200599cb0f4b8042b8d264e338c94ad2d3 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154971684) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6592) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11490: [FLINK-15579][table-planner-blink] UpsertStreamTableSink should work on batch mode
flinkbot edited a comment on issue #11490: [FLINK-15579][table-planner-blink] UpsertStreamTableSink should work on batch mode URL: https://github.com/apache/flink/pull/11490#issuecomment-602532446 ## CI report: * d93b01c3f96fe9ed8638f7a054ded19e97677d60 UNKNOWN * 6cb6fbc43e0aaf290e74a101ca38313584d1cfe5 UNKNOWN * 3d3ddb474eace1680157c2ccb826b8e6d8c593d0 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154984069) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6596) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11448: [FLINK-16666][python][table] Support new Python dependency configuration options in flink-java, flink-streaming-java and flink-table.
flinkbot edited a comment on issue #11448: [FLINK-1][python][table] Support new Python dependency configuration options in flink-java, flink-streaming-java and flink-table. URL: https://github.com/apache/flink/pull/11448#issuecomment-601042255 ## CI report: * cc79d224138b05cd18a1b221217a588cf65a5a72 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154988429) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6598) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-16760) Support the yaml file submission for native Kubernetes integration
[
https://issues.apache.org/jira/browse/FLINK-16760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yang Wang updated FLINK-16760:
--
Description:
Currently, the native K8s integration is friendly and convenient to the Flink
users, especially they have some experience of YARN deployment. The submission
command and process are very similar and could be integrated into their
existing deployer(i.e. job lifecycle management system).
However, if you are a K8s user and prefer the K8s way to start the Flink
cluster(regarding it as a application). Then yaml way is more appropriate.
What's the difference between standalone on K8s[1] and this ticket?
# Dynamic resource allocation
# Do not need to create taskmanager deployment yaml. Since the taskmanagers
will be allocated by Flink ResourceManager dynamically on demand. The
configmap, jobmanager deployment, service still need to be created manually.
# Service account needs to be prepared beforehand[2].
# Some scripts(flink-console.sh, jobmanager.sh, etc.) needs to be updated to
use native K8s entrypoint
{{org.apache.flink.kubernetes.entrypoint.KubernetesSessionClusterEntrypoint}}
Do we have the alternative option?
A possible way is using a K8s job(yaml file) to run the
{{kubernetes-session.sh}} to start the Flink cluster. This is just moving the
submission from local machine to K8s cluster.
[1].
[https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/kubernetes.html]
[2].
[https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/native_kubernetes.html#rbac]
was:
Currently, the native K8s integration is friendly and convenient to the Flink
users, especially they have some experience of YARN deployment. The submission
command and process are very similar and could be integrated into their
existing deployer(i.e. job lifecycle management system).
However, if you are a K8s user and prefer the K8s way to start the Flink
cluster(regarding it as a application). Then yaml way is more appropriate.
What's the difference between standalone on K8s[1] and this ticket?
# Dynamic resource allocation
# Do not need to create taskmanager deployment yaml. Since the taskmanagers
will be allocated by Flink ResourceManager dynamically on demand.
# Service account needs to be prepared beforehand[2].
# Some scripts(flink-console.sh, jobmanager.sh, etc.) needs to be updated to
use native K8s entrypoint
{{org.apache.flink.kubernetes.entrypoint.KubernetesSessionClusterEntrypoint}}
Do we have the alternative option?
A possible way is using a K8s job(yaml file) to run the
{{kubernetes-session.sh}} to start the Flink cluster. This is just moving the
submission from local machine to K8s cluster.
[1].
[https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/kubernetes.html]
[2].
[https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/native_kubernetes.html#rbac]
> Support the yaml file submission for native Kubernetes integration
> --
>
> Key: FLINK-16760
> URL: https://issues.apache.org/jira/browse/FLINK-16760
> Project: Flink
> Issue Type: New Feature
> Components: Deployment / Kubernetes, Deployment / Scripts
>Reporter: Yang Wang
>Priority: Major
>
> Currently, the native K8s integration is friendly and convenient to the Flink
> users, especially they have some experience of YARN deployment. The
> submission command and process are very similar and could be integrated into
> their existing deployer(i.e. job lifecycle management system).
> However, if you are a K8s user and prefer the K8s way to start the Flink
> cluster(regarding it as a application). Then yaml way is more appropriate.
>
> What's the difference between standalone on K8s[1] and this ticket?
> # Dynamic resource allocation
> # Do not need to create taskmanager deployment yaml. Since the taskmanagers
> will be allocated by Flink ResourceManager dynamically on demand. The
> configmap, jobmanager deployment, service still need to be created manually.
> # Service account needs to be prepared beforehand[2].
> # Some scripts(flink-console.sh, jobmanager.sh, etc.) needs to be updated to
> use native K8s entrypoint
> {{org.apache.flink.kubernetes.entrypoint.KubernetesSessionClusterEntrypoint}}
>
> Do we have the alternative option?
> A possible way is using a K8s job(yaml file) to run the
> {{kubernetes-session.sh}} to start the Flink cluster. This is just moving the
> submission from local machine to K8s cluster.
>
> [1].
> [https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/kubernetes.html]
> [2].
> [https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/native_kubernetes.html#rbac]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-16478) add restApi to modify loglevel
[ https://issues.apache.org/jira/browse/FLINK-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066380#comment-17066380 ] Yang Wang commented on FLINK-16478: --- [~xiaodao] I think it is indeed a useful feature. [~chesnay] What do you think about this? > add restApi to modify loglevel > --- > > Key: FLINK-16478 > URL: https://issues.apache.org/jira/browse/FLINK-16478 > Project: Flink > Issue Type: Improvement > Components: Runtime / REST >Reporter: xiaodao >Priority: Minor > > sometimes we may need to change loglevel to get more information to resolved > bug, now we need to stop it and modify conf/log4j.properties and resubmit it > ,i think it's better to add rest api to modify loglevel. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397606034
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##
@@ -397,6 +409,17 @@ public void notifyBufferDestroyed() {
// Nothing to do actually.
}
+ @Override
+ public void onExactlyOnceCheckpointCompletedOrCanceled(long
checkpointId) {
+ synchronized (bufferQueue) {
+ if (!isBlockedByCheckpoint(checkpointId)) {
Review comment:
```
if (isBlockedByCheckpoint(checkpointId)) {
notifyResumeConsumption()
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397605870
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##
@@ -397,6 +409,17 @@ public void notifyBufferDestroyed() {
// Nothing to do actually.
}
+ @Override
+ public void onExactlyOnceCheckpointCompletedOrCanceled(long
checkpointId) {
+ synchronized (bufferQueue) {
Review comment:
why need to synchronized `bufferQueue`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11486: [FLINK-16712][task] Refactor StreamTask to construct final fields
flinkbot edited a comment on issue #11486: [FLINK-16712][task] Refactor StreamTask to construct final fields URL: https://github.com/apache/flink/pull/11486#issuecomment-602377929 ## CI report: * 502f33e71092027ca04a464a213378af173f5fa5 UNKNOWN * 9d88662d7b4ba04fde20491e72d18a522d17d8ee Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154984059) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6595) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (FLINK-16758) Port StateFun Documentation to Jekyll
[ https://issues.apache.org/jira/browse/FLINK-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-16758: --- Assignee: Seth Wiesman > Port StateFun Documentation to Jekyll > -- > > Key: FLINK-16758 > URL: https://issues.apache.org/jira/browse/FLINK-16758 > Project: Flink > Issue Type: Improvement > Components: Stateful Functions >Reporter: Seth Wiesman >Assignee: Seth Wiesman >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Replace the statefun sphinx doc infra with the same jekyll infra we use for > flink docs and flink web. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FLINK-16752) Ridesharing example doesn't start
[ https://issues.apache.org/jira/browse/FLINK-16752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-16752. --- Fix Version/s: statefun-2.0 Assignee: Igal Shilman Resolution: Fixed Fixed. master - 67b75ebd5dcd9d2d3b585395bad735a58eceb844 release-2.0 - 61d660971a0049af97f17993c50cd7ca9e7b1c40 > Ridesharing example doesn't start > - > > Key: FLINK-16752 > URL: https://issues.apache.org/jira/browse/FLINK-16752 > Project: Flink > Issue Type: Bug > Components: Stateful Functions >Reporter: Igal Shilman >Assignee: Igal Shilman >Priority: Major > Labels: pull-request-available > Fix For: statefun-2.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The ridesharing simulator doesn't start, after changing the parent from > spring-boot to statefun. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397603167
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierTracker.java
##
@@ -230,8 +227,7 @@ public long getAlignmentDurationNanos() {
}
@Override
- public void checkpointSizeLimitExceeded(long maxBufferedBytes) throws
Exception {
- throw new UnsupportedOperationException("This should never
happened as this class doesn't block any data");
+ public void registerInputGate(CheckpointedInputGate inputGate) {
Review comment:
we can avoid introducing the interface method and this empty implementation
by https://github.com/apache/flink/pull/11351/files#r397602529
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397602529
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##
@@ -318,6 +326,16 @@ public long getAlignmentDurationNanos() {
}
}
+ public void registerInputGate(CheckpointedInputGate inputGate) {
Review comment:
Another option is passing `inputGate` in constructor instead to avoid
exposing another methods outside. Otherwise in tests if someone constructs the
`CheckpointBarrierAligner`, but forgets to register gate afterwards, then the
gates are actually touched in the internal related processes to bring
unexpected behaviors.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL
flinkbot edited a comment on issue #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL URL: https://github.com/apache/flink/pull/11340#issuecomment-596050968 ## CI report: * 1e95f02cc2803e695eb28597de8f7344362826fd UNKNOWN * f38af5e48e36464e94a14cb7b10e7fc740081618 UNKNOWN * c7327ee006337e8ed7b4aab89ce4ba15aff0c576 UNKNOWN * 94065848cbf7d4eb25d53a09eece3a6618b649ab Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154984013) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6594) * 69e3b9539a25a42e4cd8fb7a891a59a98e36abb4 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155009079) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6599) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397601809
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##
@@ -318,6 +326,16 @@ public long getAlignmentDurationNanos() {
}
}
+ public void registerInputGate(CheckpointedInputGate inputGate) {
+ inputGates.add(checkNotNull(inputGate));
+ }
+
+ public void notifyCheckpointCompletedOrCanceled(long checkpointId) {
Review comment:
We might need to adjust this method naming, because it is not indicating for
the checkpoint really completed (the async checkpoint process).
`notifyUnblockInputChannels`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai closed pull request #71: [hotfix] Make the namespace to match GreetStatefulFunction
tzulitai closed pull request #71: [hotfix] Make the namespace to match GreetStatefulFunction URL: https://github.com/apache/flink-statefun/pull/71 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink-statefun] tzulitai closed pull request #70: [FLINK-16752] Fix Ridesharing example
tzulitai closed pull request #70: [FLINK-16752] Fix Ridesharing example URL: https://github.com/apache/flink-statefun/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397600950
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##
@@ -172,10 +178,9 @@ else if (barrierId > currentCheckpointId) {
}
releaseBlocksAndResetBarriers();
- notifyCheckpoint(receivedBarrier, bufferedBytes,
latestAlignmentDurationNanos);
- return true;
+ notifyCheckpoint(receivedBarrier,
latestAlignmentDurationNanos);
+ notifyCheckpointCompletedOrCanceled(barrierId);
Review comment:
I am considering the call sequence for `notifyCheckpoint` and
`notifyCheckpointCompletedOrCanceled`.
`notifyCheckpoint` might take some time for local IO operations I guess. If
we can `notifyCheckpointCompletedOrCanceled` beforehand to unblock upstream to
send data, then it might get benefit for performance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request #72: [FLINK-16757] Reuse Helm Charts
tzulitai commented on a change in pull request #72: [FLINK-16757] Reuse Helm Charts URL: https://github.com/apache/flink-statefun/pull/72#discussion_r397599882 ## File path: tools/k8s/Chart.yaml ## @@ -0,0 +1,21 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +apiVersion: v2 +name: statefun-k8s +description: A Helm chart for a Stateful function pplication deployed on Kubernetes +type: application +version: 2.0.0 Review comment: is this the StateFun version? This should match the branch version, i.e. `2.1-SNAPSHOT` on master. Will also need to update `tools/releasing/update_branch_version` to update this string as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397599694
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##
@@ -318,6 +326,16 @@ public long getAlignmentDurationNanos() {
}
}
+ public void registerInputGate(CheckpointedInputGate inputGate) {
+ inputGates.add(checkNotNull(inputGate));
+ }
+
+ public void notifyCheckpointCompletedOrCanceled(long checkpointId) {
Review comment:
nit: should be private method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397599479
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##
@@ -214,7 +219,7 @@ protected void onBarrier(int channelIndex) throws
IOException {
}
@Override
- public boolean processCancellationBarrier(CancelCheckpointMarker
cancelBarrier) throws Exception {
+ public void processCancellationBarrier(CancelCheckpointMarker
cancelBarrier) throws Exception {
Review comment:
Refer to this idea
https://github.com/apache/flink/pull/11351/files#r397598435, we can also avoid
calling `notifyCheckpointCompletedOrCanceled` in five paths.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11482: [FLINK-16581][table] Minibatch deduplication lack state TTL bug fix
JingsongLi commented on issue #11482: [FLINK-16581][table] Minibatch deduplication lack state TTL bug fix URL: https://github.com/apache/flink/pull/11482#issuecomment-603629538 Hi @lsyldliu , we have some discussion on JIRA. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397599068
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##
@@ -157,7 +162,8 @@ else if (barrierId > currentCheckpointId) {
else {
Review comment:
we can also reduce this path for simple by
https://github.com/apache/flink/pull/11351/files#r397598435
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397598886
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##
@@ -100,21 +105,20 @@ public boolean isBlocked(int channelIndex) {
}
@Override
- public boolean processBarrier(CheckpointBarrier receivedBarrier, int
channelIndex, long bufferedBytes) throws Exception {
+ public void processBarrier(CheckpointBarrier receivedBarrier, int
channelIndex) throws Exception {
final long barrierId = receivedBarrier.getId();
// fast path for single channel cases
if (totalNumberOfInputChannels == 1) {
if (barrierId > currentCheckpointId) {
// new checkpoint
currentCheckpointId = barrierId;
- notifyCheckpoint(receivedBarrier,
bufferedBytes, latestAlignmentDurationNanos);
+ notifyCheckpoint(receivedBarrier,
latestAlignmentDurationNanos);
}
- return false;
+ notifyCheckpointCompletedOrCanceled(barrierId);
Review comment:
For the case of `totalNumberOfInputChannels == 1`, it should be handled
separately for fast path. Then I suggest moving this path as a separate method
to make #processBarrier seem shorter, and also it can be reused by below
`processCancellationBarrier` if providing a function argument.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397598985
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##
@@ -140,14 +144,15 @@ else if (barrierId > currentCheckpointId) {
// abort the current checkpoint
releaseBlocksAndResetBarriers();
- checkpointAborted = true;
+
notifyCheckpointCompletedOrCanceled(currentCheckpointId);
// begin a new checkpoint
beginNewAlignment(barrierId, channelIndex,
receivedBarrier.getTimestamp());
}
else {
Review comment:
we can reduce this path for simple by
https://github.com/apache/flink/pull/11351/files#r397598435
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (FLINK-16765) Replace all BatchTableEnvironment to StreamTableEnvironment in the document of PyFlink
[ https://issues.apache.org/jira/browse/FLINK-16765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066368#comment-17066368 ] yuwenbing commented on FLINK-16765: --- I want to take this issue，Can someone assign it to me? > Replace all BatchTableEnvironment to StreamTableEnvironment in the document > of PyFlink > -- > > Key: FLINK-16765 > URL: https://issues.apache.org/jira/browse/FLINK-16765 > Project: Flink > Issue Type: Improvement > Components: API / Python, Documentation >Reporter: Hequn Cheng >Priority: Major > Fix For: 1.10.1, 1.11.0 > > > For example, in the > [tutorial|https://ci.apache.org/projects/flink/flink-docs-master/getting-started/walkthroughs/python_table_api.html], > replace the BatchTableEnvironment to StreamTableEnvironment. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime] Solve the potential deadlock problem when reducing exclusive buffers to zero
zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397598435
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##
@@ -100,21 +105,20 @@ public boolean isBlocked(int channelIndex) {
}
@Override
- public boolean processBarrier(CheckpointBarrier receivedBarrier, int
channelIndex, long bufferedBytes) throws Exception {
+ public void processBarrier(CheckpointBarrier receivedBarrier, int
channelIndex) throws Exception {
final long barrierId = receivedBarrier.getId();
// fast path for single channel cases
if (totalNumberOfInputChannels == 1) {
if (barrierId > currentCheckpointId) {
// new checkpoint
currentCheckpointId = barrierId;
- notifyCheckpoint(receivedBarrier,
bufferedBytes, latestAlignmentDurationNanos);
+ notifyCheckpoint(receivedBarrier,
latestAlignmentDurationNanos);
}
- return false;
+ notifyCheckpointCompletedOrCanceled(barrierId);
Review comment:
There are five paths for calling `notifyCheckpointCompletedOrCanceled` in
this method, then it is a bit hard to trace every path and analysis whether it
needs this call. In contrast, we can analysis this issue from a reverse way to
make it easy. E.g. only two paths (begin new alignment and under current
alignment) do not need the notify call, so we can make a boolean tag only for
these two paths, and handle the unified notification at the end of this method.
In detail, we can define a boolean `shouldNotify = true` at the beginning of
this method and also set the `notifyCheckpointId = currentCheckpointId`. Then
tag this boolean as false in below two paths, and finally call
`notifyCheckpointCompletedOrCanceled` at the end of this method if
`shouldNotify = true`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL
flinkbot edited a comment on issue #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL URL: https://github.com/apache/flink/pull/11340#issuecomment-596050968 ## CI report: * 1e95f02cc2803e695eb28597de8f7344362826fd UNKNOWN * f38af5e48e36464e94a14cb7b10e7fc740081618 UNKNOWN * c7327ee006337e8ed7b4aab89ce4ba15aff0c576 UNKNOWN * 86dbe92a4f11afbf5ae78eacebdc508862c24dd6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154031270) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6383) * 94065848cbf7d4eb25d53a09eece3a6618b649ab Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154984013) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6594) * 69e3b9539a25a42e4cd8fb7a891a59a98e36abb4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-16766) Support create StreamTableEnvironment without passing StreamExecutionEnvironment
Hequn Cheng created FLINK-16766: --- Summary: Support create StreamTableEnvironment without passing StreamExecutionEnvironment Key: FLINK-16766 URL: https://issues.apache.org/jira/browse/FLINK-16766 Project: Flink Issue Type: Improvement Components: API / Python Reporter: Hequn Cheng Fix For: 1.9.3, 1.10.1, 1.11.0 Currently, when we create a BatchTableEnvironment, the ExecutionEnvironment is an optional parameter, while for the StreamTableEnvironment, the ExecutionEnvironment is not optional. We should make them consistent -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink-statefun] tzulitai commented on issue #71: [hotfix] Make the namespace to match GreetStatefulFunction
tzulitai commented on issue #71: [hotfix] Make the namespace to match GreetStatefulFunction URL: https://github.com/apache/flink-statefun/pull/71#issuecomment-603627811 LGTM, merging ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] lsyldliu commented on issue #11482: [FLINK-16581][table] Minibatch deduplication lack state TTL bug fix
lsyldliu commented on issue #11482: [FLINK-16581][table] Minibatch deduplication lack state TTL bug fix URL: https://github.com/apache/flink/pull/11482#issuecomment-603627569 @wuchong can you help me review the code? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL
danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL URL: https://github.com/apache/flink/pull/11340#discussion_r397596055 ## File path: flink-table/flink-table-planner-blink/pom.xml ## @@ -326,6 +320,8 @@ under the License. com.fasterxml.jackson.core:jackson-databind com.fasterxml.jackson.core:jackson-annotations commons-codec:commons-codec + org.apache.commons:commons-lang3 Review comment: Yes, thanks for the reminder. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on issue #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL
danny0405 commented on issue #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL URL: https://github.com/apache/flink/pull/11340#issuecomment-603626160 > Please do not force push. Otherwise, it's hard to find what changes amony 3000+ code changes... Sure, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-16765) Replace all BatchTableEnvironment to StreamTableEnvironment in the document of PyFlink
Hequn Cheng created FLINK-16765: --- Summary: Replace all BatchTableEnvironment to StreamTableEnvironment in the document of PyFlink Key: FLINK-16765 URL: https://issues.apache.org/jira/browse/FLINK-16765 Project: Flink Issue Type: Improvement Components: API / Python, Documentation Reporter: Hequn Cheng Fix For: 1.10.1, 1.11.0 For example, in the [tutorial|https://ci.apache.org/projects/flink/flink-docs-master/getting-started/walkthroughs/python_table_api.html], replace the BatchTableEnvironment to StreamTableEnvironment. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #11490: [FLINK-15579][table-planner-blink] UpsertStreamTableSink should work on batch mode
flinkbot edited a comment on issue #11490: [FLINK-15579][table-planner-blink] UpsertStreamTableSink should work on batch mode URL: https://github.com/apache/flink/pull/11490#issuecomment-602532446 ## CI report: * d93b01c3f96fe9ed8638f7a054ded19e97677d60 UNKNOWN * 6cb6fbc43e0aaf290e74a101ca38313584d1cfe5 UNKNOWN * 3d3ddb474eace1680157c2ccb826b8e6d8c593d0 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154984069) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6596) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11448: [FLINK-16666][python][table] Support new Python dependency configuration options in flink-java, flink-streaming-java and flink-table.
flinkbot edited a comment on issue #11448: [FLINK-1][python][table] Support new Python dependency configuration options in flink-java, flink-streaming-java and flink-table. URL: https://github.com/apache/flink/pull/11448#issuecomment-601042255 ## CI report: * 85f27b8a822d23e5d06ea6eb851617ce6197105a Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154566210) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6518) * cc79d224138b05cd18a1b221217a588cf65a5a72 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154988429) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6598) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-16763) Should not use BatchTableEnvironment for Python UDF in the document of flink-1.10
[ https://issues.apache.org/jira/browse/FLINK-16763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-16763: Component/s: Documentation > Should not use BatchTableEnvironment for Python UDF in the document of > flink-1.10 > - > > Key: FLINK-16763 > URL: https://issues.apache.org/jira/browse/FLINK-16763 > Project: Flink > Issue Type: Improvement > Components: API / Python, Documentation >Reporter: Hequn Cheng >Priority: Major > Fix For: 1.10.1 > > > Currently, for flink-1.10, Python UDF is not supported in old planner under > batch mode, so we should not use BatchTableEnvironment as an example for > Python UDF in the document[1] of flink-1.10. The problem may also exist in > other places in the document and should be checked. > [1] > https://ci.apache.org/projects/flink/flink-docs-release-1.10/dev/table/python/python_udfs.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #11448: [FLINK-16666][python][table] Support new Python dependency configuration options in flink-java, flink-streaming-java and flink-table.
flinkbot edited a comment on issue #11448: [FLINK-1][python][table] Support new Python dependency configuration options in flink-java, flink-streaming-java and flink-table. URL: https://github.com/apache/flink/pull/11448#issuecomment-601042255 ## CI report: * 85f27b8a822d23e5d06ea6eb851617ce6197105a Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154566210) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6518) * cc79d224138b05cd18a1b221217a588cf65a5a72 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-16764) Kafka topic discovery
pine zhao created FLINK-16764: - Summary: Kafka topic discovery Key: FLINK-16764 URL: https://issues.apache.org/jira/browse/FLINK-16764 Project: Flink Issue Type: Improvement Components: Connectors / Kafka Affects Versions: 1.10.0 Reporter: pine zhao Flink Kafka Consumer is also capable of discovering topics, based on pattern matching on the topic names using regular expressions。but i need customize discovering strategy,now it's not work,so i have to download the source code of connectors and change them 。We need customize KafkaTopicsDescriptor -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] Myasuka commented on a change in pull request #11491: [FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
Myasuka commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r397587352
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
##
@@ -640,4 +639,17 @@ private static void checkStateMappingCompleteness(
return subtaskKeyedStateHandles;
}
+
+ private static >
OperatorStateRepartitioner nonRescalingPartitioner(String logStateName) {
Review comment:
I think there is no UT or IT to cover this method currently in this PR (e.g.
throw expected exception).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on a change in pull request #11491: [FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
Myasuka commented on a change in pull request #11491: [FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata URL: https://github.com/apache/flink/pull/11491#discussion_r397364337 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PrioritizedOperatorSubtaskState.java ## @@ -60,20 +63,28 @@ /** List of prioritized snapshot alternatives for raw keyed state. */ private final List> prioritizedRawKeyedState; + private final List> inputChannelState; + + private final List> resultSubpartitionState; + Review comment: Why not using `prioritizedInputChannelState` and `prioritizedResultSubpartitionState`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] Myasuka commented on a change in pull request #11491: [FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
Myasuka commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r397374878
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
##
@@ -302,88 +326,63 @@ private void reDistributeKeyedStates(
subManagedKeyedState =
operatorState.getState(subTaskIndex).getManagedKeyedState().asList();
subRawKeyedState =
operatorState.getState(subTaskIndex).getRawKeyedState().asList();
} else {
- subManagedKeyedState = Collections.emptyList();
- subRawKeyedState = Collections.emptyList();
+ subManagedKeyedState = emptyList();
+ subRawKeyedState = emptyList();
}
} else {
subManagedKeyedState =
getManagedKeyedStateHandles(operatorState,
keyGroupPartitions.get(subTaskIndex));
subRawKeyedState =
getRawKeyedStateHandles(operatorState, keyGroupPartitions.get(subTaskIndex));
}
if (subManagedKeyedState.isEmpty() &&
subRawKeyedState.isEmpty()) {
- return new Tuple2<>(Collections.emptyList(),
Collections.emptyList());
+ return new Tuple2<>(emptyList(), emptyList());
} else {
return new Tuple2<>(subManagedKeyedState,
subRawKeyedState);
}
}
- public static void reDistributePartitionableStates(
- List oldOperatorStates,
- int newParallelism,
- List newOperatorIDs,
- Map>
newManagedOperatorStates,
- Map>
newRawOperatorStates) {
+ public static Map>
reDistributePartitionableStates(
+ List oldOperatorStates,
+ int newParallelism,
+ List newOperatorIDs,
+ Function>
extracthandle,
Review comment:
```suggestion
Function>
extractHandle,
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on a change in pull request #11491: [FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
Myasuka commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r397384347
##
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/OperatorSnapshotUtil.java
##
@@ -79,6 +81,28 @@ public static void writeStateHandle(OperatorSubtaskState
state, String path) thr
dos.writeInt(-1);
}
+ Collection
inputChannelStateHandles = state.getInputChannelState();
+ if (inputChannelStateHandles != null) {
+ dos.writeInt(inputChannelStateHandles.size());
+ for (InputChannelStateHandle
inputChannelStateHandle : inputChannelStateHandles) {
+
MetadataV3Serializer.INSTANCE.serializeInputChannelStateHandle(inputChannelStateHandle,
dos);
+ }
+ } else {
+ // this means no states, not even an empty list
+ dos.writeInt(-1);
+ }
+
+ Collection
resultSubpartitionStateHandles = state.getResultSubpartitionState();
Review comment:
Since `state.getResultSubpartitionState()` would always return a collection
instead of `null`, the condition to judge whether
`resultSubpartitionStateHandles` is `null` is meaningless. Moreover, we could
remove the line of `dos.writeInt(-1);`
This could be applied to other state snapshot in this class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on a change in pull request #11491: [FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
Myasuka commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r397379698
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
##
@@ -640,4 +639,17 @@ private static void checkStateMappingCompleteness(
return subtaskKeyedStateHandles;
}
+
+ private static >
OperatorStateRepartitioner nonRescalingPartitioner(String logStateName) {
+ return (previousParallelSubtaskStates, oldParallelism,
newParallelism) -> {
+ Preconditions.checkArgument(
+ oldParallelism == newParallelism ||
+ previousParallelSubtaskStates.stream()
+ .flatMap(s -> s.stream().map(l
-> l.getOffsets()))
+ .allMatch(List::isEmpty),
+ String.format("rescaling not supported for %s
state (old: %d, %d)", logStateName, oldParallelism, newParallelism));
Review comment:
```suggestion
String.format("rescaling not supported for %s
state (old: %d, new: %d)", logStateName, oldParallelism, newParallelism));
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Myasuka commented on a change in pull request #11491: [FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
Myasuka commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r397583510
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/OperatorSnapshotFutures.java
##
@@ -105,41 +126,51 @@ public void setOperatorStateRawFuture(
this.operatorStateRawFuture = operatorStateRawFuture;
}
- public void cancel() throws Exception {
- Exception exception = null;
+ @Nonnull
+ public RunnableFuture>
getInputChannelStateFuture() {
+ return inputChannelStateFuture;
+ }
- try {
-
StateUtil.discardStateFuture(getKeyedStateManagedFuture());
- } catch (Exception e) {
- exception = new Exception("Could not properly cancel
managed keyed state future.", e);
- }
+ public void setInputChannelStateFuture(@Nonnull
RunnableFuture>
inputChannelStateFuture) {
+ this.inputChannelStateFuture = inputChannelStateFuture;
+ }
- try {
-
StateUtil.discardStateFuture(getOperatorStateManagedFuture());
- } catch (Exception e) {
- exception = ExceptionUtils.firstOrSuppressed(
- new Exception("Could not properly cancel
managed operator state future.", e),
- exception);
- }
+ @Nonnull
+ public RunnableFuture>
getResultSubpartitionStateFuture() {
+ return resultSubpartitionStateFuture;
+ }
- try {
- StateUtil.discardStateFuture(getKeyedStateRawFuture());
- } catch (Exception e) {
- exception = ExceptionUtils.firstOrSuppressed(
- new Exception("Could not properly cancel raw
keyed state future.", e),
- exception);
- }
+ public void setResultSubpartitionStateFuture(@Nonnull
RunnableFuture>
resultSubpartitionStateFuture) {
+ this.resultSubpartitionStateFuture =
resultSubpartitionStateFuture;
+ }
- try {
-
StateUtil.discardStateFuture(getOperatorStateRawFuture());
- } catch (Exception e) {
- exception = ExceptionUtils.firstOrSuppressed(
- new Exception("Could not properly cancel raw
operator state future.", e),
- exception);
+ public void cancel() throws Exception {
+ List, String>>
pairs = new ArrayList<>();
+ pairs.add(new Tuple2<>(getKeyedStateManagedFuture(), "managed
keyed"));
+ pairs.add(new Tuple2<>(getKeyedStateRawFuture(), "managed
operator"));
+ pairs.add(new Tuple2<>(getOperatorStateManagedFuture(), "raw
keyed"));
+ pairs.add(new Tuple2<>(getOperatorStateRawFuture(), "raw
operator"));
+ pairs.add(new Tuple2<>(getInputChannelStateFuture(), "input
channel"));
+ pairs.add(new Tuple2<>(getResultSubpartitionStateFuture(),
"result subpartition"));
+ try (Closer closer = Closer.create()) {
+ for (Tuple2,
String> pair : pairs) {
+ closer.register(() -> {
+ try {
+ discardStateFuture(pair.f0);
+ } catch (Exception e) {
+ throw new
RuntimeException(String.format("Could not properly cancel %s state future",
pair.f1), e);
+ }
+ });
+ }
}
+ }
- if (exception != null) {
- throw exception;
- }
+ public Future[] getAllFutures() {
Review comment:
Why not return `inputChannelStateFuture` and `resultSubpartitionStateFuture`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (FLINK-16763) Should not use BatchTableEnvironment for Python UDF in the document of flink-1.10
Hequn Cheng created FLINK-16763: --- Summary: Should not use BatchTableEnvironment for Python UDF in the document of flink-1.10 Key: FLINK-16763 URL: https://issues.apache.org/jira/browse/FLINK-16763 Project: Flink Issue Type: Improvement Components: API / Python Reporter: Hequn Cheng Fix For: 1.10.1 Currently, for flink-1.10, Python UDF is not supported in old planner under batch mode, so we should not use BatchTableEnvironment as an example for Python UDF in the document[1] of flink-1.10. The problem may also exist in other places in the document and should be checked. [1] https://ci.apache.org/projects/flink/flink-docs-release-1.10/dev/table/python/python_udfs.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] WeiZhong94 commented on issue #11448: [FLINK-16666][python][table] Support new Python dependency configuration options in flink-java, flink-streaming-java and flink-table.
WeiZhong94 commented on issue #11448: [FLINK-1][python][table] Support new Python dependency configuration options in flink-java, flink-streaming-java and flink-table. URL: https://github.com/apache/flink/pull/11448#issuecomment-603616435 @dianfu Thanks for your comments! I have remove the unnecessary space. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11496: [FLINK-16743][table] Introduce datagen, print, blackhole connectors
flinkbot edited a comment on issue #11496: [FLINK-16743][table] Introduce datagen, print, blackhole connectors URL: https://github.com/apache/flink/pull/11496#issuecomment-603106096 ## CI report: * 3f843f0d386e256e7f660fd683e46f2bda53c608 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6565) * 012c84d9b7a031d25adff5f8cfb11d444631ebcf Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154984090) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6597) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11490: [FLINK-15579][table-planner-blink] UpsertStreamTableSink should work on batch mode
flinkbot edited a comment on issue #11490: [FLINK-15579][table-planner-blink] UpsertStreamTableSink should work on batch mode URL: https://github.com/apache/flink/pull/11490#issuecomment-602532446 ## CI report: * d93b01c3f96fe9ed8638f7a054ded19e97677d60 UNKNOWN * a31b51afd3c07d42d9b37c27beb3e9ce03ef79f8 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154712033) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6550) * 6cb6fbc43e0aaf290e74a101ca38313584d1cfe5 UNKNOWN * 3d3ddb474eace1680157c2ccb826b8e6d8c593d0 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154984069) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6596) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11489: [FLINK-15640][k8s] Support to set labels for jobmanager and taskmanager pod
flinkbot edited a comment on issue #11489: [FLINK-15640][k8s] Support to set labels for jobmanager and taskmanager pod URL: https://github.com/apache/flink/pull/11489#issuecomment-602514343 ## CI report: * 496e0c34c6cdc9c6a4b1bf6a72df71328c2580e8 UNKNOWN * 5fc814200599cb0f4b8042b8d264e338c94ad2d3 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154971684) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6592) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11486: [FLINK-16712][task] Refactor StreamTask to construct final fields
flinkbot edited a comment on issue #11486: [FLINK-16712][task] Refactor StreamTask to construct final fields URL: https://github.com/apache/flink/pull/11486#issuecomment-602377929 ## CI report: * 3e6dc74c58a913e0242e127da0e9504e9e0c44d4 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154733949) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6561) * 502f33e71092027ca04a464a213378af173f5fa5 UNKNOWN * 9d88662d7b4ba04fde20491e72d18a522d17d8ee Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154984059) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6595) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL
flinkbot edited a comment on issue #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL URL: https://github.com/apache/flink/pull/11340#issuecomment-596050968 ## CI report: * 1e95f02cc2803e695eb28597de8f7344362826fd UNKNOWN * f38af5e48e36464e94a14cb7b10e7fc740081618 UNKNOWN * c7327ee006337e8ed7b4aab89ce4ba15aff0c576 UNKNOWN * 86dbe92a4f11afbf5ae78eacebdc508862c24dd6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154031270) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6383) * 94065848cbf7d4eb25d53a09eece3a6618b649ab Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154984013) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6594) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-16762) Relocation Beam dependency of PyFlink
sunjincheng created FLINK-16762: --- Summary: Relocation Beam dependency of PyFlink Key: FLINK-16762 URL: https://issues.apache.org/jira/browse/FLINK-16762 Project: Flink Issue Type: Improvement Components: API / Python Affects Versions: 1.10.0 Reporter: sunjincheng Some users may already use beam on their own cluster, which may cause the conflict between the beam jar package carried by pyflink and the jar of the user cluster beam to a certain extent. So, I would like to relocation the Beam dependency of PyFlink. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FLINK-16759) HiveModuleTest failed to compile on release-1.10
[
https://issues.apache.org/jira/browse/FLINK-16759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee resolved FLINK-16759.
--
Resolution: Fixed
release-1.10: 572717dbc35369d29441c2ad4eb0ba73aa803ee0
> HiveModuleTest failed to compile on release-1.10
>
>
> Key: FLINK-16759
> URL: https://issues.apache.org/jira/browse/FLINK-16759
> Project: Flink
> Issue Type: Bug
> Components: Build System, Connectors / Hive
>Reporter: Dian Fu
>Assignee: Jingsong Lee
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The cron task of release-1.10 failed to compile with the following exception:
> {code}
> 23:36:45.190 [ERROR]
> /home/travis/build/apache/flink/flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/module/hive/HiveModuleTest.java:[158,45]
> constructor HiveModule in class
> org.apache.flink.table.module.hive.HiveModule cannot be applied to given
> types;
> required: java.lang.String
> found: no arguments
> reason: actual and formal argument lists differ in length
> {code}
> instance: [https://api.travis-ci.org/v3/job/666450476/log.txt]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] JingsongLi merged pull request #11503: [FLINK-16759][hive] HiveModuleTest failed to compile on release-1.10
JingsongLi merged pull request #11503: [FLINK-16759][hive] HiveModuleTest failed to compile on release-1.10 URL: https://github.com/apache/flink/pull/11503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-16720) Maven gets stuck downloading artifacts on Azure
[
https://issues.apache.org/jira/browse/FLINK-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066345#comment-17066345
]
Zhijiang commented on FLINK-16720:
--
[~rmetzger], thanks for the correction. It is indeed the issue of
TaskExecutorTest.testSlotAcceptance from main stack. I should be more careful.
> Maven gets stuck downloading artifacts on Azure
> ---
>
> Key: FLINK-16720
> URL: https://issues.apache.org/jira/browse/FLINK-16720
> Project: Flink
> Issue Type: Bug
> Components: Build System / Azure Pipelines
>Affects Versions: 1.11.0
>Reporter: Robert Metzger
>Priority: Critical
> Labels: test-stability
> Fix For: 1.11.0
>
>
> Logs:
> https://dev.azure.com/rmetzger/Flink/_build/results?buildId=6509=logs=fc5181b0-e452-5c8f-68de-1097947f6483=27d1d645-cbce-54e2-51c4-d8b45fe24607
> {code}
> 2020-03-23T08:43:28.4128014Z [INFO]
>
> 2020-03-23T08:43:28.4128557Z [INFO] Building flink-avro-confluent-registry
> 1.11-SNAPSHOT
> 2020-03-23T08:43:28.4129129Z [INFO]
>
> 2020-03-23T08:48:47.6591333Z
> ==
> 2020-03-23T08:48:47.6594540Z Maven produced no output for 300 seconds.
> 2020-03-23T08:48:47.6595164Z
> ==
> 2020-03-23T08:48:47.6605370Z
> ==
> 2020-03-23T08:48:47.6605803Z The following Java processes are running (JPS)
> 2020-03-23T08:48:47.6606173Z
> ==
> 2020-03-23T08:48:47.7710037Z 920 Jps
> 2020-03-23T08:48:47.7778561Z 238 Launcher
> 2020-03-23T08:48:47.9270289Z
> ==
> 2020-03-23T08:48:47.9270832Z Printing stack trace of Java process 967
> 2020-03-23T08:48:47.9271199Z
> ==
> 2020-03-23T08:48:48.0165945Z 967: No such process
> 2020-03-23T08:48:48.0218260Z
> ==
> 2020-03-23T08:48:48.0218736Z Printing stack trace of Java process 238
> 2020-03-23T08:48:48.0219075Z
> ==
> 2020-03-23T08:48:48.3404066Z 2020-03-23 08:48:48
> 2020-03-23T08:48:48.3404828Z Full thread dump OpenJDK 64-Bit Server VM
> (25.242-b08 mixed mode):
> 2020-03-23T08:48:48.3405064Z
> 2020-03-23T08:48:48.3405445Z "Attach Listener" #370 daemon prio=9 os_prio=0
> tid=0x7fe130001000 nid=0x452 waiting on condition [0x]
> 2020-03-23T08:48:48.3405868Zjava.lang.Thread.State: RUNNABLE
> 2020-03-23T08:48:48.3411202Z
> 2020-03-23T08:48:48.3413171Z "resolver-5" #105 daemon prio=5 os_prio=0
> tid=0x7fe1ec2ad800 nid=0x177 waiting on condition [0x7fe1872d9000]
> 2020-03-23T08:48:48.3414175Zjava.lang.Thread.State: WAITING (parking)
> 2020-03-23T08:48:48.3414560Z at sun.misc.Unsafe.park(Native Method)
> 2020-03-23T08:48:48.3415451Z - parking to wait for <0x0003d5a9f828> (a
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 2020-03-23T08:48:48.3416180Z at
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> 2020-03-23T08:48:48.3416825Z at
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> 2020-03-23T08:48:48.3417602Z at
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
> 2020-03-23T08:48:48.3418250Z at
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074)
> 2020-03-23T08:48:48.3418930Z at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> 2020-03-23T08:48:48.3419900Z at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 2020-03-23T08:48:48.3420395Z at java.lang.Thread.run(Thread.java:748)
> 2020-03-23T08:48:48.3420648Z
> 2020-03-23T08:48:48.3421424Z "resolver-4" #104 daemon prio=5 os_prio=0
> tid=0x7fe1ec2ad000 nid=0x176 waiting on condition [0x7fe1863dd000]
> 2020-03-23T08:48:48.3421914Zjava.lang.Thread.State: WAITING (parking)
> 2020-03-23T08:48:48.3422233Z at sun.misc.Unsafe.park(Native Method)
> 2020-03-23T08:48:48.3422919Z - parking to wait for <0x0003d5a9f828> (a
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 2020-03-23T08:48:48.3423447Z at
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> 2020-03-23T08:48:48.3424141Z at
[GitHub] [flink] flinkbot edited a comment on issue #11490: [FLINK-15579][table-planner-blink] UpsertStreamTableSink should work on batch mode
flinkbot edited a comment on issue #11490: [FLINK-15579][table-planner-blink] UpsertStreamTableSink should work on batch mode URL: https://github.com/apache/flink/pull/11490#issuecomment-602532446 ## CI report: * d93b01c3f96fe9ed8638f7a054ded19e97677d60 UNKNOWN * a31b51afd3c07d42d9b37c27beb3e9ce03ef79f8 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154712033) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6550) * 6cb6fbc43e0aaf290e74a101ca38313584d1cfe5 UNKNOWN * 3d3ddb474eace1680157c2ccb826b8e6d8c593d0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11486: [FLINK-16712][task] Refactor StreamTask to construct final fields
flinkbot edited a comment on issue #11486: [FLINK-16712][task] Refactor StreamTask to construct final fields URL: https://github.com/apache/flink/pull/11486#issuecomment-602377929 ## CI report: * 3e6dc74c58a913e0242e127da0e9504e9e0c44d4 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154733949) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6561) * 502f33e71092027ca04a464a213378af173f5fa5 UNKNOWN * 9d88662d7b4ba04fde20491e72d18a522d17d8ee UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11496: [FLINK-16743][table] Introduce datagen, print, blackhole connectors
flinkbot edited a comment on issue #11496: [FLINK-16743][table] Introduce datagen, print, blackhole connectors URL: https://github.com/apache/flink/pull/11496#issuecomment-603106096 ## CI report: * 3f843f0d386e256e7f660fd683e46f2bda53c608 Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6565) * 012c84d9b7a031d25adff5f8cfb11d444631ebcf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11503: [FLINK-16759][hive] HiveModuleTest failed to compile on release-1.10
flinkbot commented on issue #11503: [FLINK-16759][hive] HiveModuleTest failed to compile on release-1.10 URL: https://github.com/apache/flink/pull/11503#issuecomment-603611103 ## CI report: * ddcab70218a9e66cee6cfd1698098285b65f979d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL
flinkbot edited a comment on issue #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL URL: https://github.com/apache/flink/pull/11340#issuecomment-596050968 ## CI report: * 1e95f02cc2803e695eb28597de8f7344362826fd UNKNOWN * f38af5e48e36464e94a14cb7b10e7fc740081618 UNKNOWN * c7327ee006337e8ed7b4aab89ce4ba15aff0c576 UNKNOWN * 86dbe92a4f11afbf5ae78eacebdc508862c24dd6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154031270) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6383) * 94065848cbf7d4eb25d53a09eece3a6618b649ab UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] leonardBang commented on issue #11396: [FLINK-16170][connectors/elasticsearch]SearchTemplateRequest ClassNotFoundException when use flink-sql-connector-elasticsearch7
leonardBang commented on issue #11396: [FLINK-16170][connectors/elasticsearch]SearchTemplateRequest ClassNotFoundException when use flink-sql-connector-elasticsearch7 URL: https://github.com/apache/flink/pull/11396#issuecomment-603609514 > Hi @leonardBang , could you open another PR for release-1.10? There is some conflicts when cherry-picking it there. Also would be great if you can verify the e2e for that. okay, I'll open a PR for release-1.10, and the conflicts comes from master branch have some new improvements on es connector while release-1.10 lacked. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
