[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256558#comment-16256558
 ] 

ASF subversion and git services commented on GEODE-3967:


Commit 0ef35790a07b937d76f19acd2fd907ec98686b0e in geode's branch 
refs/heads/feature/GEM-883 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0ef3579 ]

GEODE-3967: isConcurrencyConflict is set for 3 notifyTimestampsToGateways


> if put hits concurrent modification exception should still notify serial 
> gateway sender
> ---
>
> Key: GEODE-3967
> URL: https://issues.apache.org/jira/browse/GEODE-3967
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>
> In serial gateway sender, the event arrives at secondary will be put into 
> unprocessedMap and wait for event from primary queue to distribute over, then 
> remove it from the unprocessedMap.
> If the put at primary member (member with primary queue) failed with CME, the 
> event in unprocessedMap will never be removed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3937) Fix NPE when executing removeFromDisk

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256557#comment-16256557
 ] 

ASF GitHub Bot commented on GEODE-3937:
---

dineshpune2006 commented on issue #1002: GEODE-3937:Fix NPE when executing 
removeFromDisk
URL: https://github.com/apache/geode/pull/1002#issuecomment-345159280
 
 
   any comment?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix NPE when executing  removeFromDisk
> --
>
> Key: GEODE-3937
> URL: https://issues.apache.org/jira/browse/GEODE-3937
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: dinesh akhand
>Priority: Trivial
>
> While executing the test case or clearQueueTestOnly method. we can see 
> exception
> [vm4] java.lang.NullPointerException
> [vm4] at 
> org.apache.geode.internal.cache.entries.DiskEntry$Helper.removeFromDisk(DiskEntry.java:1519)
> [vm4] at 
> org.apache.geode.internal.cache.entries.AbstractOplogDiskRegionEntry.removePhase1(AbstractOplogDiskRegionEntry.java:50)
> [vm4] at 
> org.apache.geode.internal.cache.entries.AbstractRegionEntry.destroy(AbstractRegionEntry.java:914)
> [vm4] at 
> org.apache.geode.internal.cache.AbstractRegionMap.destroyEntry(AbstractRegionMap.java:3100)
> [vm4] at 
> org.apache.geode.internal.cache.AbstractRegionMap.destroy(AbstractRegionMap.java:1429)
> [vm4] at 
> org.apache.geode.internal.cache.LocalRegion.mapDestroy(LocalRegion.java:6465)
> [vm4] at 
> org.apache.geode.internal.cache.LocalRegion.mapDestroy(LocalRegion.java:6439)
> [vm4] at 
> org.apache.geode.internal.cache.BucketRegion.basicDestroy(BucketRegion.java:1167)
> [vm4] at 
> org.apache.geode.internal.cache.AbstractBucketRegionQueue.basicDestroy(AbstractBucketRegionQueue.java:352)
> [vm4] at 
> org.apache.geode.internal.cache.BucketRegionQueue.basicDestroy(BucketRegionQueue.java:366)
> [vm4] at 
> org.apache.geode.internal.cache.LocalRegion.validatedDestroy(LocalRegion.java:1101)
> [vm4] at 
> org.apache.geode.internal.cache.DistributedRegion.validatedDestroy(DistributedRegion.java:942)
> [vm4] at 
> org.apache.geode.internal.cache.LocalRegion.destroy(LocalRegion.java:1086)
> [vm4] at 
> org.apache.geode.internal.cache.AbstractRegion.destroy(AbstractRegion.java:315)
> [vm4] at 
> org.apache.geode.internal.cache.LocalRegion.remove(LocalRegion.java:8870)
> [vm4] at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.clearPartitionedRegion(ParallelGatewaySenderQueue.java:1820)
> [vm4] at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.clearQueue(ParallelGatewaySenderQueue.java:1795)
> [vm4] at 
> org.apache.geode.internal.cache.wan.parallel.ConcurrentParallelGatewaySenderQueue.clearQueue(ConcurrentParallelGatewaySenderQueue.java:236)
> [vm4] at 
> org.apache.geode.internal.cache.wan.WANTestBase.clearGatewaySender(WANTestBase.java:256)
> [vm4] at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueOverflowDUnitTest.lambda$8(ParallelGatewaySenderQueueOverflowDUnitTest.java:96)
> [vm4] at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueOverflowDUnitTest$$Lambda$42/144498586.run(Unknown
>  Source)
> [vm4] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256508#comment-16256508
 ] 

ASF subversion and git services commented on GEODE-3967:


Commit 744c74dbaf2a348d67e06ee34b7d4c2ad9b01da2 in geode's branch 
refs/heads/feature/GEM-883 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=744c74d ]

GEODE-3967: add more trace


> if put hits concurrent modification exception should still notify serial 
> gateway sender
> ---
>
> Key: GEODE-3967
> URL: https://issues.apache.org/jira/browse/GEODE-3967
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>
> In serial gateway sender, the event arrives at secondary will be put into 
> unprocessedMap and wait for event from primary queue to distribute over, then 
> remove it from the unprocessedMap.
> If the put at primary member (member with primary queue) failed with CME, the 
> event in unprocessedMap will never be removed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256306#comment-16256306
 ] 

ASF subversion and git services commented on GEODE-3967:


Commit 42aec6af306ce00836d3f38eeb22e0c504259a19 in geode's branch 
refs/heads/feature/GEM-883 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=42aec6a ]

GEODE-3967: add a case for invalidate


> if put hits concurrent modification exception should still notify serial 
> gateway sender
> ---
>
> Key: GEODE-3967
> URL: https://issues.apache.org/jira/browse/GEODE-3967
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>
> In serial gateway sender, the event arrives at secondary will be put into 
> unprocessedMap and wait for event from primary queue to distribute over, then 
> remove it from the unprocessedMap.
> If the put at primary member (member with primary queue) failed with CME, the 
> event in unprocessedMap will never be removed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3624) Update exceptions to more closely match standard exception interface

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256289#comment-16256289
 ] 

ASF subversion and git services commented on GEODE-3624:


Commit ad33bbbc7baaa3ea00d5c4161460f7aef827cac5 in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=ad33bbb ]

GEODE-3624: Fix Windows 32-bit build


> Update exceptions to more closely match standard exception interface
> 
>
> Key: GEODE-3624
> URL: https://issues.apache.org/jira/browse/GEODE-3624
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: David Kimura
>
> Native client library should follow standard exception interface for any 
> thrown exceptions.  This means one less custom interface that a customer or 
> developer needs to understand.
> {noformat}
> namespace apache {
> namespace geode {
> namespace client {
> class Exception : public std::exception {...};
> class IllegalArgumentException : public Exception {...};
> class TransactionException : public Exception {...};
> class RollbackException : public TransactionException {...};
> // NO - class IllegalArgumentException : public Exception, public
> std::invalid_argument {...};
> // NO - class IllegalArgumentException : public std::invalid_argument {...};
> // NO - class IllegalArgumentException : public Exception, public
> TransactionException {...};
> }
> }
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3624) Update exceptions to more closely match standard exception interface

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256274#comment-16256274
 ] 

ASF subversion and git services commented on GEODE-3624:


Commit e03704686a3d9e855c3e94a1a8064424222a4c68 in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=e037046 ]

GEODE-3624: Add boost patch to fix Solaris builds


> Update exceptions to more closely match standard exception interface
> 
>
> Key: GEODE-3624
> URL: https://issues.apache.org/jira/browse/GEODE-3624
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: David Kimura
>
> Native client library should follow standard exception interface for any 
> thrown exceptions.  This means one less custom interface that a customer or 
> developer needs to understand.
> {noformat}
> namespace apache {
> namespace geode {
> namespace client {
> class Exception : public std::exception {...};
> class IllegalArgumentException : public Exception {...};
> class TransactionException : public Exception {...};
> class RollbackException : public TransactionException {...};
> // NO - class IllegalArgumentException : public Exception, public
> std::invalid_argument {...};
> // NO - class IllegalArgumentException : public std::invalid_argument {...};
> // NO - class IllegalArgumentException : public Exception, public
> TransactionException {...};
> }
> }
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3624) Update exceptions to more closely match standard exception interface

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256225#comment-16256225
 ] 

ASF subversion and git services commented on GEODE-3624:


Commit 8d8e9a7ee089b1c871d0db308e8277a1ae4bd5ae in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=8d8e9a7 ]

GEODE-3624: Update C++ client exceptions to implement std::exception interface 
(#152)



> Update exceptions to more closely match standard exception interface
> 
>
> Key: GEODE-3624
> URL: https://issues.apache.org/jira/browse/GEODE-3624
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: David Kimura
>
> Native client library should follow standard exception interface for any 
> thrown exceptions.  This means one less custom interface that a customer or 
> developer needs to understand.
> {noformat}
> namespace apache {
> namespace geode {
> namespace client {
> class Exception : public std::exception {...};
> class IllegalArgumentException : public Exception {...};
> class TransactionException : public Exception {...};
> class RollbackException : public TransactionException {...};
> // NO - class IllegalArgumentException : public Exception, public
> std::invalid_argument {...};
> // NO - class IllegalArgumentException : public std::invalid_argument {...};
> // NO - class IllegalArgumentException : public Exception, public
> TransactionException {...};
> }
> }
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3987) Enforce the uniqueness of a single gateway-receiver per member

[JIRA]

 [ 
https://issues.apache.org/jira/browse/GEODE-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Juan José Ramos Cassella reassigned GEODE-3987:
---

Assignee: Juan José Ramos Cassella

> Enforce the uniqueness of a single gateway-receiver per member
> --
>
> Key: GEODE-3987
> URL: https://issues.apache.org/jira/browse/GEODE-3987
> Project: Geode
>  Issue Type: Bug
>Reporter: Juan José Ramos Cassella
>Assignee: Juan José Ramos Cassella
>
> Within the documentation, both in [Configure Gateway 
> Receivers|http://geode.apache.org/docs/guide/13/topologies_and_comm/multi_site_configuration/setting_up_a_multisite_system.html#setting_up_a_multisite_system__section_E3A44F85359046C7ADD12861D261637B]
>  and [gfsh create 
> gateway-receiver|http://geode.apache.org/docs/guide/13/tools_modules/gfsh/command-pages/create.html#topic_a4x_pb1_dk],
>  we state that only one {{gateway-receiver}} is allowed per member. However, 
> there is no enforcement of this rule within the code nor within the schema 
> for the {{cache.xml}} file, so the user might end up having more than one 
> {{gateway-receiver}} per host.
> It's unknown which {{gateway-receiver}} is going to be used after a restart, 
> making it hard to configure firewall rules between clusters, if any. The 
> following exception is also printed in the logs whenever we try to register 
> (only the first one is succesfull) the MBean for the {{gateway-receiver}}:
> {noformat}
> [warning 2017/11/16 15:27:46.156 PST host1-server1  Processor1> tid=0x44] javax.management.InstanceAlreadyExistsException: 
> GemFire:service=GatewayReceiver,type=Member,member=host1-server1
> org.apache.geode.management.ManagementException: 
> javax.management.InstanceAlreadyExistsException: 
> GemFire:service=GatewayReceiver,type=Member,member=host1-server1
>   at 
> org.apache.geode.management.internal.MBeanJMXAdapter.registerMBean(MBeanJMXAdapter.java:110)
>   at 
> org.apache.geode.management.internal.SystemManagementService.registerInternalMBean(SystemManagementService.java:368)
>   at 
> org.apache.geode.management.internal.beans.ManagementAdapter.createGatewayReceiverMBean(ManagementAdapter.java:471)
>   at 
> org.apache.geode.management.internal.beans.ManagementAdapter.handleGatewayReceiverStart(ManagementAdapter.java:493)
>   at 
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:134)
>   at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2175)
>   at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:562)
>   at 
> org.apache.geode.internal.cache.wan.GatewayReceiverImpl.start(GatewayReceiverImpl.java:194)
>   at 
> org.apache.geode.internal.cache.wan.GatewayReceiverFactoryImpl.create(GatewayReceiverFactoryImpl.java:141)
>   at 
> org.apache.geode.management.internal.cli.functions.GatewayReceiverCreateFunction.createGatewayReceiver(GatewayReceiverCreateFunction.java:164)
>   at 
> org.apache.geode.management.internal.cli.functions.GatewayReceiverCreateFunction.execute(GatewayReceiverCreateFunction.java:63)
>   at 
> org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:186)
>   at 
> org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:374)
>   at 
> org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:440)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:668)
>   at 
> org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1114)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: javax.management.InstanceAlreadyExistsException: 
> GemFire:service=GatewayReceiver,type=Member,member=host1-server1
>   at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:437)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(DefaultMBeanServerInterceptor.java:1898)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:966)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:900)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:324)
>   at 
> 

[jira] [Created] (GEODE-3987) Enforce the uniqueness of a single gateway-receiver per member

[JIRA]

Juan José Ramos Cassella created GEODE-3987:
---

 Summary: Enforce the uniqueness of a single gateway-receiver per 
member
 Key: GEODE-3987
 URL: https://issues.apache.org/jira/browse/GEODE-3987
 Project: Geode
  Issue Type: Bug
Reporter: Juan José Ramos Cassella


Within the documentation, both in [Configure Gateway 
Receivers|http://geode.apache.org/docs/guide/13/topologies_and_comm/multi_site_configuration/setting_up_a_multisite_system.html#setting_up_a_multisite_system__section_E3A44F85359046C7ADD12861D261637B]
 and [gfsh create 
gateway-receiver|http://geode.apache.org/docs/guide/13/tools_modules/gfsh/command-pages/create.html#topic_a4x_pb1_dk],
 we state that only one {{gateway-receiver}} is allowed per member. However, 
there is no enforcement of this rule within the code nor within the schema for 
the {{cache.xml}} file, so the user might end up having more than one 
{{gateway-receiver}} per host.
It's unknown which {{gateway-receiver}} is going to be used after a restart, 
making it hard to configure firewall rules between clusters, if any. The 
following exception is also printed in the logs whenever we try to register 
(only the first one is succesfull) the MBean for the {{gateway-receiver}}:

{noformat}
[warning 2017/11/16 15:27:46.156 PST host1-server1  tid=0x44] javax.management.InstanceAlreadyExistsException: 
GemFire:service=GatewayReceiver,type=Member,member=host1-server1
org.apache.geode.management.ManagementException: 
javax.management.InstanceAlreadyExistsException: 
GemFire:service=GatewayReceiver,type=Member,member=host1-server1
at 
org.apache.geode.management.internal.MBeanJMXAdapter.registerMBean(MBeanJMXAdapter.java:110)
at 
org.apache.geode.management.internal.SystemManagementService.registerInternalMBean(SystemManagementService.java:368)
at 
org.apache.geode.management.internal.beans.ManagementAdapter.createGatewayReceiverMBean(ManagementAdapter.java:471)
at 
org.apache.geode.management.internal.beans.ManagementAdapter.handleGatewayReceiverStart(ManagementAdapter.java:493)
at 
org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:134)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2175)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:562)
at 
org.apache.geode.internal.cache.wan.GatewayReceiverImpl.start(GatewayReceiverImpl.java:194)
at 
org.apache.geode.internal.cache.wan.GatewayReceiverFactoryImpl.create(GatewayReceiverFactoryImpl.java:141)
at 
org.apache.geode.management.internal.cli.functions.GatewayReceiverCreateFunction.createGatewayReceiver(GatewayReceiverCreateFunction.java:164)
at 
org.apache.geode.management.internal.cli.functions.GatewayReceiverCreateFunction.execute(GatewayReceiverCreateFunction.java:63)
at 
org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:186)
at 
org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:374)
at 
org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:440)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at 
org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:668)
at 
org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1114)
at java.lang.Thread.run(Thread.java:745)
Caused by: javax.management.InstanceAlreadyExistsException: 
GemFire:service=GatewayReceiver,type=Member,member=host1-server1
at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:437)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(DefaultMBeanServerInterceptor.java:1898)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:966)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:900)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:324)
at 
com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
at 
org.apache.geode.management.internal.MBeanJMXAdapter.registerMBean(MBeanJMXAdapter.java:105)
... 18 more
{noformat}

The fix implies:

. Change the {{maxOccurs}} attribute from {{unbounded}} to {{1}} in the 
{{cache-1.0.xsd}} file.
. Add the validation to the 

[jira] [Commented] (GEODE-3977) .NET QueryService templating should match usage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256108#comment-16256108
 ] 

ASF GitHub Bot commented on GEODE-3977:
---

pivotal-jbarrett commented on a change in pull request #155: GEODE-3977: 
QueryService template args removed
URL: https://github.com/apache/geode-native/pull/155#discussion_r151561520
 
 

 ##
 File path: clicache/integration-test/PutGetTestsN.cs
 ##
 @@ -318,9 +318,9 @@ public void DoRunQuery()
   }
   else
   {
-QueryService qs = null;
-qs = 
CacheHelper.DCache.GetPoolManager().Find(m_region.Attributes.PoolName).GetQueryService();
-Query qry = qs.NewQuery("SELECT * FROM " + m_region.FullPath);
+QueryService qs = null;
+qs = 
CacheHelper.DCache.GetPoolManager().Find(m_region.Attributes.PoolName).GetQueryService();
 
 Review comment:
   Nit - clean things like this where declared on one line and assigned on the 
line below.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> .NET QueryService templating should match usage
> ---
>
> Key: GEODE-3977
> URL: https://issues.apache.org/jira/browse/GEODE-3977
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> QueryService uses generics
>  generic
>   //generic
>   Query^ QueryService::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3977) .NET QueryService templating should match usage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256107#comment-16256107
 ] 

ASF GitHub Bot commented on GEODE-3977:
---

pivotal-jbarrett commented on a change in pull request #155: GEODE-3977: 
QueryService template args removed
URL: https://github.com/apache/geode-native/pull/155#discussion_r151561593
 
 

 ##
 File path: clicache/integration-test/PutGetTestsN.cs
 ##
 @@ -318,9 +318,9 @@ public void DoRunQuery()
   }
   else
   {
-QueryService qs = null;
-qs = 
CacheHelper.DCache.GetPoolManager().Find(m_region.Attributes.PoolName).GetQueryService();
-Query qry = qs.NewQuery("SELECT * FROM " + m_region.FullPath);
+QueryService qs = null;
+qs = 
CacheHelper.DCache.GetPoolManager().Find(m_region.Attributes.PoolName).GetQueryService();
+Query qry = qs.NewQuery("SELECT * FROM " + 
m_region.FullPath);
 
 Review comment:
   Nit - Use `var` on the left hand side.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> .NET QueryService templating should match usage
> ---
>
> Key: GEODE-3977
> URL: https://issues.apache.org/jira/browse/GEODE-3977
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> QueryService uses generics
>  generic
>   //generic
>   Query^ QueryService::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3977) .NET QueryService templating should match usage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256097#comment-16256097
 ] 

ASF GitHub Bot commented on GEODE-3977:
---

mhansonp opened a new pull request #155: GEODE-3977: QueryService template args 
removed
URL: https://github.com/apache/geode-native/pull/155
 
 
   -Removed the template parameters for QueryService


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> .NET QueryService templating should match usage
> ---
>
> Key: GEODE-3977
> URL: https://issues.apache.org/jira/browse/GEODE-3977
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> QueryService uses generics
>  generic
>   //generic
>   Query^ QueryService::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3977) .NET QueryService templating should match usage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256094#comment-16256094
 ] 

ASF GitHub Bot commented on GEODE-3977:
---

mhansonp closed pull request #154: GEODE-3977: Modifying the QueryService 
template
URL: https://github.com/apache/geode-native/pull/154
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/clicache/integration-test/PutGetTestsN.cs 
b/clicache/integration-test/PutGetTestsN.cs
index 21478218..a4896a4a 100644
--- a/clicache/integration-test/PutGetTestsN.cs
+++ b/clicache/integration-test/PutGetTestsN.cs
@@ -318,8 +318,8 @@ public void DoRunQuery()
   }
   else
   {
-QueryService qs = null;
-qs = 
CacheHelper.DCache.GetPoolManager().Find(m_region.Attributes.PoolName).GetQueryService();
+QueryService qs = null;
+qs = 
CacheHelper.DCache.GetPoolManager().Find(m_region.Attributes.PoolName).GetQueryService();
 Query qry = qs.NewQuery("SELECT * FROM " + m_region.FullPath);
 ISelectResults results = qry.Execute();
 // not really interested in results but loop through them neverthless
diff --git a/clicache/integration-test/ThinClientAppDomainQueryTests.cs 
b/clicache/integration-test/ThinClientAppDomainQueryTests.cs
index 90aabf71..728b1b4e 100644
--- a/clicache/integration-test/ThinClientAppDomainQueryTests.cs
+++ b/clicache/integration-test/ThinClientAppDomainQueryTests.cs
@@ -124,7 +124,7 @@ public void VerifyQueries()
 
   QueryHelper qh = QueryHelper.GetHelper(CacheHelper.DCache);
 
-  QueryService qs = 
CacheHelper.DCache.GetPoolManager().Find("__TESTPOOL1_").GetQueryService();
+  QueryService qs = 
CacheHelper.DCache.GetPoolManager().Find("__TESTPOOL1_").GetQueryService();
 
   int qryIdx = 0;
 
@@ -204,7 +204,7 @@ public void VerifyUnsupporteQueries()
 
   QueryHelper qh = QueryHelper.GetHelper(CacheHelper.DCache);
 
-  QueryService qs = 
CacheHelper.DCache.GetPoolManager().Find("__TESTPOOL1_").GetQueryService();
+  QueryService qs = 
CacheHelper.DCache.GetPoolManager().Find("__TESTPOOL1_").GetQueryService();
 
   int qryIdx = 0;
 
diff --git a/clicache/integration-test/ThinClientCqIRTestsN.cs 
b/clicache/integration-test/ThinClientCqIRTestsN.cs
index ea90850b..12a2071c 100644
--- a/clicache/integration-test/ThinClientCqIRTestsN.cs
+++ b/clicache/integration-test/ThinClientCqIRTestsN.cs
@@ -148,8 +148,8 @@ public void StepOneQE(string locators)
   region["3"] = p3;
   region["4"] = p4;
 
-  QueryService qs = null;
-  qs = 
CacheHelper.DCache.GetPoolManager().Find("__TESTPOOL1_").GetQueryService();
+  QueryService qs = null;
+  qs = 
CacheHelper.DCache.GetPoolManager().Find("__TESTPOOL1_").GetQueryService();
   CqAttributesFactory cqFac = new 
CqAttributesFactory();
   ICqListener cqLstner = new MyCqListener();
   cqFac.AddCqListener(cqLstner);
@@ -207,7 +207,7 @@ public void StepOneQE(string locators)
   }
 }
   }
-  qry = qs.GetCq(CqName);
+  qry = qs.GetCq(CqName);
   qry.Stop();
   qry.Close();
   // Bring down the region
diff --git a/clicache/integration-test/ThinClientCqTestsN.cs 
b/clicache/integration-test/ThinClientCqTestsN.cs
index 2dd81187..86e3e383 100644
--- a/clicache/integration-test/ThinClientCqTestsN.cs
+++ b/clicache/integration-test/ThinClientCqTestsN.cs
@@ -393,9 +393,9 @@ public void StepOneQE(string locators)
   region["3"] = p3;
   region["4"] = p4;
 
-  QueryService qs = null;
+  QueryService qs = null;
 
-  qs = 
CacheHelper.DCache.GetPoolManager().Find("__TESTPOOL1_").GetQueryService();
+  qs = 
CacheHelper.DCache.GetPoolManager().Find("__TESTPOOL1_").GetQueryService();
   CqAttributesFactory cqFac = new 
CqAttributesFactory();
   ICqListener cqLstner = new MyCqListener();
   cqFac.AddCqListener(cqLstner);
@@ -409,7 +409,7 @@ public void StepOneQE(string locators)
   region["1"] = p4;
   Thread.Sleep(18000); // sleep 0.3min to allow server c query to complete
 
-  qry = qs.GetCq(CqName);
+  qry = qs.GetCq(CqName);
 
   CqServiceStatistics cqSvcStats = qs.GetCqStatistics();
   Assert.AreEqual(1, cqSvcStats.numCqsActive());
@@ -454,9 +454,9 @@ public void StepOnePdxQE(string locators)
   region["3"] = p3;
   region["4"] = 

[jira] [Resolved] (GEODE-183) Warning message about multiple replies logged when performing a backup

[JIRA]

 [ 
https://issues.apache.org/jira/browse/GEODE-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Juan José Ramos Cassella resolved GEODE-183.

   Resolution: Fixed
Fix Version/s: 1.4.0

I was working on this one, but it's already fixed as a consequence of 
GEODE-3940.

> Warning message about multiple replies logged when performing a backup
> --
>
> Key: GEODE-183
> URL: https://issues.apache.org/jira/browse/GEODE-183
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Dan Smith
>Priority: Minor
> Fix For: 1.4.0
>
>
> This warning message is logged when issuing a backup command through gfsh.
> [warning 2015/07/30 17:57:03.950 PDT locator1  Connection(5)-127.0.0.1> tid=0x69] Received reply from member 
> 172.16.115.205(locator1:105277:locator):54895 but was not expecting one. 
> More than one reply may have been received. The reply that was not expected 
> is: com.gemstone.gemfire.admin.internal.FinishBackupResponse: 
> [91384a78-4703-416e-881f-f17c6b85ec4e 
> [172.16.115.205:/home/dsmith/data/manual_test/locator1/ConfigDiskDir_locator1]]
> To reproduce
> {noformat}
> gfsh start locator --name=locator1 --port=55221
> gfsh start server --name=server1 --J=-Dgemfire.locators=localhost[55221] 
> --J=-Dgemfire.mcast-port=0 
> gfsh create region --name=region1 --type=REPLICATE_PERSISTENT
> gfsh backup disk-store --dir=/tmp/backup1
> {noformat}
> Looking at the code in FinishBackupRequest, the issue is that the locator 
> performing the backup locally on any disk stores present on the locator. It 
> passes the result of that backup into the reply processor. The reply 
> processor logs this warning because it was only initialized to expect replies 
> from the other members, not from the locator itself.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3969) Protobuf protocol requests includes a CallbackArgs field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255981#comment-16255981
 ] 

ASF GitHub Bot commented on GEODE-3969:
---

upthewaterspout commented on a change in pull request #1047: GEODE-3969: Remove 
CallbackArgs from protobuf requests
URL: https://github.com/apache/geode/pull/1047#discussion_r151538999
 
 

 ##
 File path: geode-protobuf/src/main/proto/v1/clientProtocol.proto
 ##
 @@ -35,7 +35,6 @@ message Message {
 }
 
 message Request {
-CallbackArguments callbackArg = 1;
 oneof requestAPI {
 PutRequest putRequest = 2;
 
 Review comment:
   Since callback arg is gone, should putRequest actually start with 1?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol requests includes a CallbackArgs field
> 
>
> Key: GEODE-3969
> URL: https://issues.apache.org/jira/browse/GEODE-3969
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
>
> We eventually want to support allowing clients to pass arguments to cache 
> listeners in their requests, but this functionality is not going to be 
> present in v1.  Having this field is therefore misleading and it should be 
> removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3801) Utilize hard-links to copy files during backups

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3801.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Utilize hard-links to copy files during backups
> ---
>
> Key: GEODE-3801
> URL: https://issues.apache.org/jira/browse/GEODE-3801
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Darrel Schneider
> Fix For: 1.4.0
>
>
> Instead of copying files which are read-only during a backup, create a 
> hard-link to the file in the backup location. This prevents losing the file 
> if the original location is deleted, but does not require make a new copy of 
> the file. If hard-links cannot be created, revert to the existing copying 
> mechanic.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3940) Backup can hang while trying to get a lock

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3940.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Backup can hang while trying to get a lock 
> ---
>
> Key: GEODE-3940
> URL: https://issues.apache.org/jira/browse/GEODE-3940
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Lynn Gallinat
>Assignee: Darrel Schneider
> Fix For: 1.4.0
>
>
> {noformat}
> Backup can hang when createKrf cannot get the compactor lock.
> "Pooled Message Processor 2" #196 daemon prio=10 os_prio=0 
> tid=0x7fef9801e000 nid=0x3cf3 waiting on condition [0x7ff094cd5000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for  <0xf1a72c60> (a 
> java.util.concurrent.locks.ReentrantLock$NonfairSync)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)
> at 
> java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209)
> at 
> java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285)
> at 
> org.apache.geode.internal.cache.Oplog.lockCompactor(Oplog.java:6046)
> < trying to get compactor lock
> at org.apache.geode.internal.cache.Oplog.createKrf(Oplog.java:4157)   
>  < in createKrf
> at org.apache.geode.internal.cache.Oplog.finishKrf(Oplog.java:7746)
> at 
> org.apache.geode.internal.cache.BackupManager.backupOplog(BackupManager.java:580)
> at 
> org.apache.geode.internal.cache.BackupManager.completeBackup(BackupManager.java:270)
> at 
> org.apache.geode.internal.cache.BackupManager.doBackup(BackupManager.java:139)
> at 
> org.apache.geode.admin.internal.FinishBackupRequest.createResponse(FinishBackupRequest.java:102)
> at 
> org.apache.geode.internal.admin.remote.CliLegacyMessage.process(CliLegacyMessage.java:39)
> at 
> org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:374)
> at 
> org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:440)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:666)
> at 
> org.apache.geode.distributed.internal.DistributionManager$4$1.run(DistributionManager.java:923)
> at java.lang.Thread.run(Thread.java:748)
> The compactor thread already has the compactor lock.
> It is waiting for a DiskEntry lock.
> "Idle OplogCompactor" #379 daemon prio=10 os_prio=0 tid=0x7ff020026000 
> nid=0x6916 waiting for monitor entry [0x7ff08c7ce000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> org.apache.geode.internal.cache.Oplog.writeOneKeyEntryForKRF(Oplog.java:3924)
> - waiting to lock <0xf1c55c70> (a 
> org.apache.geode.internal.cache.entries.VersionedThinDiskRegionEntryOffHeapStringKey2)
>   <== waiting for DiskEntry lock
> at org.apache.geode.internal.cache.Oplog.createKrf(Oplog.java:4201)   
><=== already in createKrf
> - locked <0xf1a72c30> (a 
> java.util.concurrent.atomic.AtomicBoolean)
> at org.apache.geode.internal.cache.Oplog$2.run(Oplog.java:3875)
> at 
> org.apache.geode.internal.cache.DiskStoreImpl$5.run(DiskStoreImpl.java:4386)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> The DiskEntry lock is held by this thread and is waiting for replies:
> "PartitionedRegion Message Processor26" #238 daemon prio=10 os_prio=0 
> tid=0x7fef9c01f800 nid=0x3dd0 waiting on condition [0x7ff08ebe9000]
>java.lang.Thread.State: TIMED_WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for  <0xf1e42200> (a 
> java.util.concurrent.CountDownLatch$Sync)
> at 
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
> at 
> 

[jira] [Commented] (GEODE-3940) Backup can hang while trying to get a lock

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255963#comment-16255963
 ] 

ASF subversion and git services commented on GEODE-3940:


Commit d59c73030b0d5123158829e8a32acfe28f6b1a9d in geode's branch 
refs/heads/develop from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d59c730 ]

Merge pull request #1053 from apache/feature/GEODE-3940

Feature/geode 3940

> Backup can hang while trying to get a lock 
> ---
>
> Key: GEODE-3940
> URL: https://issues.apache.org/jira/browse/GEODE-3940
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Lynn Gallinat
>Assignee: Darrel Schneider
>
> {noformat}
> Backup can hang when createKrf cannot get the compactor lock.
> "Pooled Message Processor 2" #196 daemon prio=10 os_prio=0 
> tid=0x7fef9801e000 nid=0x3cf3 waiting on condition [0x7ff094cd5000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for  <0xf1a72c60> (a 
> java.util.concurrent.locks.ReentrantLock$NonfairSync)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)
> at 
> java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209)
> at 
> java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285)
> at 
> org.apache.geode.internal.cache.Oplog.lockCompactor(Oplog.java:6046)
> < trying to get compactor lock
> at org.apache.geode.internal.cache.Oplog.createKrf(Oplog.java:4157)   
>  < in createKrf
> at org.apache.geode.internal.cache.Oplog.finishKrf(Oplog.java:7746)
> at 
> org.apache.geode.internal.cache.BackupManager.backupOplog(BackupManager.java:580)
> at 
> org.apache.geode.internal.cache.BackupManager.completeBackup(BackupManager.java:270)
> at 
> org.apache.geode.internal.cache.BackupManager.doBackup(BackupManager.java:139)
> at 
> org.apache.geode.admin.internal.FinishBackupRequest.createResponse(FinishBackupRequest.java:102)
> at 
> org.apache.geode.internal.admin.remote.CliLegacyMessage.process(CliLegacyMessage.java:39)
> at 
> org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:374)
> at 
> org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:440)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:666)
> at 
> org.apache.geode.distributed.internal.DistributionManager$4$1.run(DistributionManager.java:923)
> at java.lang.Thread.run(Thread.java:748)
> The compactor thread already has the compactor lock.
> It is waiting for a DiskEntry lock.
> "Idle OplogCompactor" #379 daemon prio=10 os_prio=0 tid=0x7ff020026000 
> nid=0x6916 waiting for monitor entry [0x7ff08c7ce000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> org.apache.geode.internal.cache.Oplog.writeOneKeyEntryForKRF(Oplog.java:3924)
> - waiting to lock <0xf1c55c70> (a 
> org.apache.geode.internal.cache.entries.VersionedThinDiskRegionEntryOffHeapStringKey2)
>   <== waiting for DiskEntry lock
> at org.apache.geode.internal.cache.Oplog.createKrf(Oplog.java:4201)   
><=== already in createKrf
> - locked <0xf1a72c30> (a 
> java.util.concurrent.atomic.AtomicBoolean)
> at org.apache.geode.internal.cache.Oplog$2.run(Oplog.java:3875)
> at 
> org.apache.geode.internal.cache.DiskStoreImpl$5.run(DiskStoreImpl.java:4386)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> The DiskEntry lock is held by this thread and is waiting for replies:
> "PartitionedRegion Message Processor26" #238 daemon prio=10 os_prio=0 
> tid=0x7fef9c01f800 nid=0x3dd0 waiting on condition [0x7ff08ebe9000]
>java.lang.Thread.State: TIMED_WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
>  

[jira] [Commented] (GEODE-3940) Backup can hang while trying to get a lock

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255962#comment-16255962
 ] 

ASF subversion and git services commented on GEODE-3940:


Commit ad786a5699950454ed366174215950ad02ee756a in geode's branch 
refs/heads/develop from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ad786a5 ]

Merge remote-tracking branch 'origin/develop' into feature/GEODE-3940


> Backup can hang while trying to get a lock 
> ---
>
> Key: GEODE-3940
> URL: https://issues.apache.org/jira/browse/GEODE-3940
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Lynn Gallinat
>Assignee: Darrel Schneider
>
> {noformat}
> Backup can hang when createKrf cannot get the compactor lock.
> "Pooled Message Processor 2" #196 daemon prio=10 os_prio=0 
> tid=0x7fef9801e000 nid=0x3cf3 waiting on condition [0x7ff094cd5000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for  <0xf1a72c60> (a 
> java.util.concurrent.locks.ReentrantLock$NonfairSync)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)
> at 
> java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209)
> at 
> java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285)
> at 
> org.apache.geode.internal.cache.Oplog.lockCompactor(Oplog.java:6046)
> < trying to get compactor lock
> at org.apache.geode.internal.cache.Oplog.createKrf(Oplog.java:4157)   
>  < in createKrf
> at org.apache.geode.internal.cache.Oplog.finishKrf(Oplog.java:7746)
> at 
> org.apache.geode.internal.cache.BackupManager.backupOplog(BackupManager.java:580)
> at 
> org.apache.geode.internal.cache.BackupManager.completeBackup(BackupManager.java:270)
> at 
> org.apache.geode.internal.cache.BackupManager.doBackup(BackupManager.java:139)
> at 
> org.apache.geode.admin.internal.FinishBackupRequest.createResponse(FinishBackupRequest.java:102)
> at 
> org.apache.geode.internal.admin.remote.CliLegacyMessage.process(CliLegacyMessage.java:39)
> at 
> org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:374)
> at 
> org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:440)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:666)
> at 
> org.apache.geode.distributed.internal.DistributionManager$4$1.run(DistributionManager.java:923)
> at java.lang.Thread.run(Thread.java:748)
> The compactor thread already has the compactor lock.
> It is waiting for a DiskEntry lock.
> "Idle OplogCompactor" #379 daemon prio=10 os_prio=0 tid=0x7ff020026000 
> nid=0x6916 waiting for monitor entry [0x7ff08c7ce000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> org.apache.geode.internal.cache.Oplog.writeOneKeyEntryForKRF(Oplog.java:3924)
> - waiting to lock <0xf1c55c70> (a 
> org.apache.geode.internal.cache.entries.VersionedThinDiskRegionEntryOffHeapStringKey2)
>   <== waiting for DiskEntry lock
> at org.apache.geode.internal.cache.Oplog.createKrf(Oplog.java:4201)   
><=== already in createKrf
> - locked <0xf1a72c30> (a 
> java.util.concurrent.atomic.AtomicBoolean)
> at org.apache.geode.internal.cache.Oplog$2.run(Oplog.java:3875)
> at 
> org.apache.geode.internal.cache.DiskStoreImpl$5.run(DiskStoreImpl.java:4386)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> The DiskEntry lock is held by this thread and is waiting for replies:
> "PartitionedRegion Message Processor26" #238 daemon prio=10 os_prio=0 
> tid=0x7fef9c01f800 nid=0x3dd0 waiting on condition [0x7ff08ebe9000]
>java.lang.Thread.State: TIMED_WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
>   

[jira] [Commented] (GEODE-3801) Utilize hard-links to copy files during backups

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255961#comment-16255961
 ] 

ASF subversion and git services commented on GEODE-3801:


Commit 080730b2df5c7ec0a17acd195a5b953dfc6a0d5c in geode's branch 
refs/heads/develop from [~nreich]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=080730b ]

GEODE-3801: Use hardlinks for backup oplog files (#963)

* Oplog files that are backed up are read-only. For this reason,
  they can be transfered to the backup location through hard links,
  instead of copying the file. This change improves speed of backups.
  If the creation of a hard link fails, we revert to the existing copy
  behavior.
* During backups, the copying of the oplog's krf file was being done while
  that file could still be in the process of writing. This change ensures
  that if a krf is to be written, that it is finished and included in the
  backup
* cleanup existing oplog tests


> Utilize hard-links to copy files during backups
> ---
>
> Key: GEODE-3801
> URL: https://issues.apache.org/jira/browse/GEODE-3801
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Darrel Schneider
>
> Instead of copying files which are read-only during a backup, create a 
> hard-link to the file in the backup location. This prevents losing the file 
> if the original location is deleted, but does not require make a new copy of 
> the file. If hard-links cannot be created, revert to the existing copying 
> mechanic.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3879) Refactor EvictionAttribute to be a real enum

[Jens Deppe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe resolved GEODE-3879.
---
Resolution: Won't Fix

This appears to be almost impossible to do without introducing breaking 
backwards compatibility changes.

> Refactor EvictionAttribute to be a real enum
> 
>
> Key: GEODE-3879
> URL: https://issues.apache.org/jira/browse/GEODE-3879
> Project: Geode
>  Issue Type: Improvement
>  Components: eviction
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>
> This could easily be refactored into an actual enum.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (GEODE-3879) Refactor EvictionAttribute to be a real enum

[Jens Deppe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe closed GEODE-3879.
-

> Refactor EvictionAttribute to be a real enum
> 
>
> Key: GEODE-3879
> URL: https://issues.apache.org/jira/browse/GEODE-3879
> Project: Geode
>  Issue Type: Improvement
>  Components: eviction
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>
> This could easily be refactored into an actual enum.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3007) Simplify support for custom GFSH commands

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255927#comment-16255927
 ] 

ASF subversion and git services commented on GEODE-3007:


Commit 0e5dd6ba45519463147337c8265db15e8f1840fc in geode's branch 
refs/heads/feature/GEODE-3940 from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0e5dd6b ]

GEODE-3007: Simplify support for custom GFSH commands (#1042)

* GEODE-3007: Simplify support for custom GFSH commands

> Simplify support for custom GFSH commands
> -
>
> Key: GEODE-3007
> URL: https://issues.apache.org/jira/browse/GEODE-3007
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> Geode currently supports three ways to load GFSH commands: 
> 1. Scan the classpath for commands in 
> "org.apache.geode.management.internal.cli.commands”
> 2. Scan the classpath for commands in a package specified by a user via the 
> “user-command-packages” system property. 
> 3. Scan the classpath for commands registered in files inside 
> META-INF.services (e.g. 
> "geode-core/src/test/resources/META-INF/services/org.springframework.shell.core.CommandMarker”)
>  
> After the improvements made by GEODE-2989, there is no reason to require a 
> user to specify the location of their custom commands via one of these 
> mechanisms.  Instead, we should simply scan the entire classpath for any 
> classes implementing CommandMarker (regardless of whatever packages they live 
> in).  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3940) Backup can hang while trying to get a lock

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255931#comment-16255931
 ] 

ASF subversion and git services commented on GEODE-3940:


Commit ad786a5699950454ed366174215950ad02ee756a in geode's branch 
refs/heads/feature/GEODE-3940 from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ad786a5 ]

Merge remote-tracking branch 'origin/develop' into feature/GEODE-3940


> Backup can hang while trying to get a lock 
> ---
>
> Key: GEODE-3940
> URL: https://issues.apache.org/jira/browse/GEODE-3940
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Lynn Gallinat
>Assignee: Darrel Schneider
>
> {noformat}
> Backup can hang when createKrf cannot get the compactor lock.
> "Pooled Message Processor 2" #196 daemon prio=10 os_prio=0 
> tid=0x7fef9801e000 nid=0x3cf3 waiting on condition [0x7ff094cd5000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for  <0xf1a72c60> (a 
> java.util.concurrent.locks.ReentrantLock$NonfairSync)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)
> at 
> java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209)
> at 
> java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285)
> at 
> org.apache.geode.internal.cache.Oplog.lockCompactor(Oplog.java:6046)
> < trying to get compactor lock
> at org.apache.geode.internal.cache.Oplog.createKrf(Oplog.java:4157)   
>  < in createKrf
> at org.apache.geode.internal.cache.Oplog.finishKrf(Oplog.java:7746)
> at 
> org.apache.geode.internal.cache.BackupManager.backupOplog(BackupManager.java:580)
> at 
> org.apache.geode.internal.cache.BackupManager.completeBackup(BackupManager.java:270)
> at 
> org.apache.geode.internal.cache.BackupManager.doBackup(BackupManager.java:139)
> at 
> org.apache.geode.admin.internal.FinishBackupRequest.createResponse(FinishBackupRequest.java:102)
> at 
> org.apache.geode.internal.admin.remote.CliLegacyMessage.process(CliLegacyMessage.java:39)
> at 
> org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:374)
> at 
> org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:440)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:666)
> at 
> org.apache.geode.distributed.internal.DistributionManager$4$1.run(DistributionManager.java:923)
> at java.lang.Thread.run(Thread.java:748)
> The compactor thread already has the compactor lock.
> It is waiting for a DiskEntry lock.
> "Idle OplogCompactor" #379 daemon prio=10 os_prio=0 tid=0x7ff020026000 
> nid=0x6916 waiting for monitor entry [0x7ff08c7ce000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> org.apache.geode.internal.cache.Oplog.writeOneKeyEntryForKRF(Oplog.java:3924)
> - waiting to lock <0xf1c55c70> (a 
> org.apache.geode.internal.cache.entries.VersionedThinDiskRegionEntryOffHeapStringKey2)
>   <== waiting for DiskEntry lock
> at org.apache.geode.internal.cache.Oplog.createKrf(Oplog.java:4201)   
><=== already in createKrf
> - locked <0xf1a72c30> (a 
> java.util.concurrent.atomic.AtomicBoolean)
> at org.apache.geode.internal.cache.Oplog$2.run(Oplog.java:3875)
> at 
> org.apache.geode.internal.cache.DiskStoreImpl$5.run(DiskStoreImpl.java:4386)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> The DiskEntry lock is held by this thread and is waiting for replies:
> "PartitionedRegion Message Processor26" #238 daemon prio=10 os_prio=0 
> tid=0x7fef9c01f800 nid=0x3dd0 waiting on condition [0x7ff08ebe9000]
>java.lang.Thread.State: TIMED_WAITING (parking)
> at sun.misc.Unsafe.park(Native 

[jira] [Commented] (GEODE-3979) CI failure: org.apache.geode.cache30.ClientServerCCEDUnitTest > testClientDoesNotExpireEntryPrematurely

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255926#comment-16255926
 ] 

ASF subversion and git services commented on GEODE-3979:


Commit 7718945726823c353de5316eaeefd58be42d15f7 in geode's branch 
refs/heads/feature/GEODE-3940 from [~agingade]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7718945 ]

GEODE-3979: fix flaky test (#1061)



> CI failure: org.apache.geode.cache30.ClientServerCCEDUnitTest > 
> testClientDoesNotExpireEntryPrematurely
> ---
>
> Key: GEODE-3979
> URL: https://issues.apache.org/jira/browse/GEODE-3979
> Project: Geode
>  Issue Type: Bug
>  Components: expiration
>Reporter: Anilkumar Gingade
>Assignee: Anilkumar Gingade
> Fix For: 1.4.0
>
>
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:331)
> at 
> org.apache.geode.cache30.ClientServerCCEDUnitTest.testClientDoesNotExpireEntryPrematurely(ClientServerCCEDUnitTest.java:232)
> Caused by:
> java.lang.AssertionError: entry expired 1 milliseconds early



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3935) Failure from CqSecurityAuthorizedUserDUnitTest

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255923#comment-16255923
 ] 

ASF subversion and git services commented on GEODE-3935:


Commit 5f08a9ee40116b9ef926410862f5daa749ddfb24 in geode's branch 
refs/heads/feature/GEODE-3940 from [~nnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5f08a9e ]

GEODE-3935: Closing down the cache after each test.

* Test failure was attributed to an incompatible cache present in the 
system.
* The @Before method will close the existing cache before each test.


> Failure from CqSecurityAuthorizedUserDUnitTest
> --
>
> Key: GEODE-3935
> URL: https://issues.apache.org/jira/browse/GEODE-3935
> Project: Geode
>  Issue Type: Bug
>  Components: cq
>Reporter: Dan Smith
> Fix For: 1.4.0
>
>
> We saw this in an internal CI run from develop with revision 
> e630cd3ad93f84a14819308d7a97d9bb9fb7197f
> {noformat}
> :geode-cq:distributedTest
> org.apache.geode.cache.query.cq.dunit.CqSecurityAuthorizedUserDUnitTest > 
> cqExecuteWithInitialResultsWithMethodInvocationWithUsersWithCqPermissionsWithPrepopulatedRegionShouldBeDeniedBecauseOfInvocation[0]
>  FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.security.query.QuerySecurityBase$$Lambda$324/1598682259.run 
> in VM 1 running on Host a248aa0818f9 with 4 VMs
> Caused by:
> java.lang.IllegalStateException: Existing cache's default pool was 
> not compatible
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3978) Ci Failure: org.apache.geode.cache30.RegionReliabilityDistAckDUnitTest > testLimitedAccessWithLocalEntryExpiration FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255925#comment-16255925
 ] 

ASF subversion and git services commented on GEODE-3978:


Commit dfaa0f1e92d3d168abe97472104d6138aba6be50 in geode's branch 
refs/heads/feature/GEODE-3940 from [~agingade]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=dfaa0f1 ]

GEODE-3978: add wait with respect to region size (#1060)



> Ci Failure: org.apache.geode.cache30.RegionReliabilityDistAckDUnitTest > 
> testLimitedAccessWithLocalEntryExpiration FAILED
> -
>
> Key: GEODE-3978
> URL: https://issues.apache.org/jira/browse/GEODE-3978
> Project: Geode
>  Issue Type: Bug
>  Components: expiration
>Reporter: Anilkumar Gingade
>Assignee: Anilkumar Gingade
> Fix For: 1.4.0
>
>
> Seems like flaky test:
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.geode.cache30.RegionReliabilityTestCase.testLimitedAccessWithLocalEntryExpiration(RegionReliabilityTestCase.java:833)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-1920) CI Failure: WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255929#comment-16255929
 ] 

ASF subversion and git services commented on GEODE-1920:


Commit 7f0d5f529c1dc44fecb970a099eb307dd1824235 in geode's branch 
refs/heads/feature/GEODE-3940 from [~nnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7f0d5f5 ]

GEODE-1920 Addition of more logs to the test

* More logs were added at the failure points to figure out what caused 
a failure.
* Refactored by simplifying the code and removing deprecated function 
calls.
* Removed the flaky tag


> CI Failure: 
> WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously
> -
>
> Key: GEODE-1920
> URL: https://issues.apache.org/jira/browse/GEODE-1920
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Eric Shu
>  Labels: ci
> Fix For: 1.4.0
>
>
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously(WanAutoDiscoveryDUnitTest.java:274)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor233.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor232.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> 

[jira] [Commented] (GEODE-1019) Suspect string: WanValidationsDUnitTest.testBug50434_PR_Parallel_pass

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255924#comment-16255924
 ] 

ASF subversion and git services commented on GEODE-1019:


Commit 4dafde13dfa47475382d41849eb7e5eea4eef996 in geode's branch 
refs/heads/feature/GEODE-3940 from [~nnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4dafde1 ]

GEODE-1019: Removing the flaky tag

* Refactoring the test base class occured in a different ticket.


> Suspect string: WanValidationsDUnitTest.testBug50434_PR_Parallel_pass
> -
>
> Key: GEODE-1019
> URL: https://issues.apache.org/jira/browse/GEODE-1019
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Dan Smith
>  Labels: CI, Flaky
> Fix For: 1.4.0
>
>
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during 
> this run.
> Fix the strings or use DistributedTestCase.addExpectedException to ignore.
> ---
> Found suspect string in log4j at line 4668
> [fatal 2016/02/26 07:59:12.465 PST  tid=0x20c] 
> Possible loss of quorum due to the loss of 3 cache processes: 
> [cc2-ub(14993):1029, cc2-ub(15020):1030, 
> cc2-ub(15048):1031]
>   at org.junit.Assert.fail(Assert.java:88)
>   at 
> com.gemstone.gemfire.test.dunit.standalone.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:355)
>   at 
> com.gemstone.gemfire.test.dunit.DistributedTestCase.cleanupAllVms(DistributedTestCase.java:464)
>   at 
> com.gemstone.gemfire.test.dunit.DistributedTestCase.tearDownDistributedTestCase(DistributedTestCase.java:438)
>   at 
> com.gemstone.gemfire.test.dunit.DistributedTestCase.tearDown(DistributedTestCase.java:428)
>   at junit.framework.TestCase.runBare(TestCase.java:146)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> 

[jira] [Commented] (GEODE-1920) CI Failure: WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255930#comment-16255930
 ] 

ASF subversion and git services commented on GEODE-1920:


Commit 478665f17ef56e3d1bd2a0da1fe4d041476170a7 in geode's branch 
refs/heads/feature/GEODE-3940 from [~nabarunnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=478665f ]

Revert "GEODE-1920 Addition of more logs to the test"

This reverts commit 7f0d5f529c1dc44fecb970a099eb307dd1824235.


> CI Failure: 
> WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously
> -
>
> Key: GEODE-1920
> URL: https://issues.apache.org/jira/browse/GEODE-1920
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Eric Shu
>  Labels: ci
> Fix For: 1.4.0
>
>
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously(WanAutoDiscoveryDUnitTest.java:274)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor233.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor232.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
>   at 
> 

[jira] [Commented] (GEODE-3007) Simplify support for custom GFSH commands

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255928#comment-16255928
 ] 

ASF subversion and git services commented on GEODE-3007:


Commit 0e5dd6ba45519463147337c8265db15e8f1840fc in geode's branch 
refs/heads/feature/GEODE-3940 from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0e5dd6b ]

GEODE-3007: Simplify support for custom GFSH commands (#1042)

* GEODE-3007: Simplify support for custom GFSH commands

> Simplify support for custom GFSH commands
> -
>
> Key: GEODE-3007
> URL: https://issues.apache.org/jira/browse/GEODE-3007
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> Geode currently supports three ways to load GFSH commands: 
> 1. Scan the classpath for commands in 
> "org.apache.geode.management.internal.cli.commands”
> 2. Scan the classpath for commands in a package specified by a user via the 
> “user-command-packages” system property. 
> 3. Scan the classpath for commands registered in files inside 
> META-INF.services (e.g. 
> "geode-core/src/test/resources/META-INF/services/org.springframework.shell.core.CommandMarker”)
>  
> After the improvements made by GEODE-2989, there is no reason to require a 
> user to specify the location of their custom commands via one of these 
> mechanisms.  Instead, we should simply scan the entire classpath for any 
> classes implementing CommandMarker (regardless of whatever packages they live 
> in).  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3738) CI Failure: org.apache.geode.security.ClientAuthorizationDUnitTest

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255922#comment-16255922
 ] 

ASF subversion and git services commented on GEODE-3738:


Commit 944436ab9af24ba909a9b69ade23813ec6be21f5 in geode's branch 
refs/heads/feature/GEODE-3940 from [~khowe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=944436a ]

GEODE-3738: Add Flaky category to ClientAuthorizationDUnitTest (#1054)



> CI Failure:  org.apache.geode.security.ClientAuthorizationDUnitTest
> ---
>
> Key: GEODE-3738
> URL: https://issues.apache.org/jira/browse/GEODE-3738
> Project: Geode
>  Issue Type: Bug
>  Components: security, tests
>Reporter: Jared Stewart
>  Labels: ci
>
> {noformat}
> Error
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.security.ClientAuthorizationDUnitTest$$Lambda$177/351125497.run
>  in VM 2 running on Host 2d21656aaf6b with 4 VMs with version 120
> Stacktrace
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.security.ClientAuthorizationDUnitTest$$Lambda$177/351125497.run
>  in VM 2 running on Host 2d21656aaf6b with 4 VMs with version 120
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
>   at 
> org.apache.geode.security.ClientAuthorizationDUnitTest.testPutsGetsWithFailover(ClientAuthorizationDUnitTest.java:350)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at org.junit.runners.Suite.runChild(Suite.java:128)
>   at org.junit.runners.Suite.runChild(Suite.java:27)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor443.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> 

[jira] [Resolved] (GEODE-3983) Reading of new protocol major version byte may be non-blocking

[Brian Rowe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Rowe resolved GEODE-3983.
---
Resolution: Invalid

In investigating this we realized that all input after the communication mode 
will be read from the socket using blocking I/O.  We've created a feature to 
improve this (GEODE-3986), but with the current code, this bug is not an issue.

> Reading of new protocol major version byte may be non-blocking
> --
>
> Key: GEODE-3983
> URL: https://issues.apache.org/jira/browse/GEODE-3983
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Michael Dodge
>
> The new protocol has two bytes of out-of-band information sent first across 
> the socket: the communication mode (0x6E) and the major version (currently 
> 0x01). When using a selector, specific care is taken to read the 
> communication mode in a blocking fashion. Alas, the same care is *_not_* 
> taken to read the major version.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3986) Selector mode acceptor should better support nonblocking I/O

[Brian Rowe (JIRA)]

Brian Rowe created GEODE-3986:
-

 Summary: Selector mode acceptor should better support nonblocking 
I/O
 Key: GEODE-3986
 URL: https://issues.apache.org/jira/browse/GEODE-3986
 Project: Geode
  Issue Type: New Feature
  Components: client/server
Reporter: Brian Rowe


An acceptor on a cache server running in selector mode will attempt to read a 
communication mode from a connection using a non-blocking read, but regardless 
of the result of that will perform all future reads using blocking I/O.  If 
several sockets get partial messages, the server can get deadlocked waiting for 
the message completion even if there are other sockets which have complete 
messages pending.  We should be able to properly service a number of sockets 
much larger than the number of threads in our pool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3977) .NET QueryService templating should match usage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255833#comment-16255833
 ] 

ASF GitHub Bot commented on GEODE-3977:
---

mhansonp commented on a change in pull request #154: GEODE-3977: Modifying the 
QueryService template
URL: https://github.com/apache/geode-native/pull/154#discussion_r151514551
 
 

 ##
 File path: clicache/src/QueryService.hpp
 ##
 @@ -51,7 +60,7 @@ namespace Apache
   /// 
   /// Provides a query service.
   /// 
-  generic
+  generic
 
 Review comment:
   I agree, so I will pull all of the templating out of QueryService.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> .NET QueryService templating should match usage
> ---
>
> Key: GEODE-3977
> URL: https://issues.apache.org/jira/browse/GEODE-3977
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> QueryService uses generics
>  generic
>   //generic
>   Query^ QueryService::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3969) Protobuf protocol requests includes a CallbackArgs field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255825#comment-16255825
 ] 

ASF GitHub Bot commented on GEODE-3969:
---

galen-pivotal commented on issue #1047: GEODE-3969: Remove CallbackArgs from 
protobuf requests
URL: https://github.com/apache/geode/pull/1047#issuecomment-345035501
 
 
   It looks like this is actually two changes: removing callbackArgs and 
renaming ServerAPI to LocatorAPI. Looks good though.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol requests includes a CallbackArgs field
> 
>
> Key: GEODE-3969
> URL: https://issues.apache.org/jira/browse/GEODE-3969
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
>
> We eventually want to support allowing clients to pass arguments to cache 
> listeners in their requests, but this functionality is not going to be 
> present in v1.  Having this field is therefore misleading and it should be 
> removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3977) .NET QueryService templating should match usage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255800#comment-16255800
 ] 

ASF GitHub Bot commented on GEODE-3977:
---

pivotal-jbarrett commented on a change in pull request #154: GEODE-3977: 
Modifying the QueryService template
URL: https://github.com/apache/geode-native/pull/154#discussion_r151507982
 
 

 ##
 File path: clicache/src/QueryService.hpp
 ##
 @@ -51,7 +60,7 @@ namespace Apache
   /// 
   /// Provides a query service.
   /// 
-  generic
+  generic
 
 Review comment:
   Additionally methods like `CloseCqs` operates on all CQs, not just the ones 
that match the `TResult` of the class.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> .NET QueryService templating should match usage
> ---
>
> Key: GEODE-3977
> URL: https://issues.apache.org/jira/browse/GEODE-3977
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> QueryService uses generics
>  generic
>   //generic
>   Query^ QueryService::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3977) .NET QueryService templating should match usage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255801#comment-16255801
 ] 

ASF GitHub Bot commented on GEODE-3977:
---

pivotal-jbarrett commented on a change in pull request #154: GEODE-3977: 
Modifying the QueryService template
URL: https://github.com/apache/geode-native/pull/154#discussion_r151508130
 
 

 ##
 File path: clicache/src/QueryService.hpp
 ##
 @@ -66,65 +75,66 @@ namespace Apache
 /// Get a CqQuery object to enable continuous querying.
 /// 
 /// @endnativeclient
-//generic
-CqQuery^ NewCq( String^ query, CqAttributes^ cqAttr, bool isDurable );
+generic
+  CqQuery^ NewCq(String^ query, CqAttributes^ cqAttr, bool isDurable);
+  
 /// @nativeclient
 /// 
 /// Get a CqQuery object to enable continuous querying.
 /// 
 /// @endnativeclient
-//generic
+generic
 CqQuery^ NewCq( String^ name, String^ query, 
CqAttributes^ cqAttr, bool isDurable );
 /// @nativeclient
 /// 
 /// Close all  CqQuery on this client.
 /// 
 /// @endnativeclient
-   void CloseCqs();
+ void CloseCqs();
 
 /// @nativeclient
 /// 
 /// Get all  CqQuery on this client.
 /// 
 /// @endnativeclient
-  //generic
-   array^>^ GetCqs();
+generic
+ array^>^ GetCqs();
 
 Review comment:
   Formatting is getting out of whack here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> .NET QueryService templating should match usage
> ---
>
> Key: GEODE-3977
> URL: https://issues.apache.org/jira/browse/GEODE-3977
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> QueryService uses generics
>  generic
>   //generic
>   Query^ QueryService::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3977) .NET QueryService templating should match usage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255799#comment-16255799
 ] 

ASF GitHub Bot commented on GEODE-3977:
---

pivotal-jbarrett commented on a change in pull request #154: GEODE-3977: 
Modifying the QueryService template
URL: https://github.com/apache/geode-native/pull/154#discussion_r151507780
 
 

 ##
 File path: clicache/src/QueryService.hpp
 ##
 @@ -51,7 +60,7 @@ namespace Apache
   /// 
   /// Provides a query service.
   /// 
-  generic
+  generic
 
 Review comment:
   The more I think about it does it even make sense for the class itself to be 
templated. Does the class itself depend in any way on the `TResult`. I think 
the answer is no if you look at each method. The bulk of the methods are 
factories for `Query` and `CqQuery`.  So should have to 
ask for a new `QueryService` every time I want to make new `Query` with a 
different `TResult`? That seems wrong to me.
   ```
   var qsString = cache.getQueryService();
   var qString = qsString.createQuery("");
   var qsInt = cache.getQueryService)();
   var qInt = qsInt.createQuery("...");
   ```
   vs.
   ```
   var qs = cache.getQueryService();
   var qString = qs.createQuery("");
   var qInt = qs.createQuery("...");
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> .NET QueryService templating should match usage
> ---
>
> Key: GEODE-3977
> URL: https://issues.apache.org/jira/browse/GEODE-3977
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> QueryService uses generics
>  generic
>   //generic
>   Query^ QueryService::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-1920) CI Failure: WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255746#comment-16255746
 ] 

ASF GitHub Bot commented on GEODE-1920:
---

nabarunnag closed pull request #1069: Revert "GEODE-1920 Addition of more logs 
to the test"
URL: https://github.com/apache/geode/pull/1069
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CI Failure: 
> WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously
> -
>
> Key: GEODE-1920
> URL: https://issues.apache.org/jira/browse/GEODE-1920
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Eric Shu
>  Labels: ci
> Fix For: 1.4.0
>
>
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously(WanAutoDiscoveryDUnitTest.java:274)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor233.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor232.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> 

[jira] [Commented] (GEODE-1920) CI Failure: WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255745#comment-16255745
 ] 

ASF GitHub Bot commented on GEODE-1920:
---

nabarunnag opened a new pull request #1069: Revert "GEODE-1920 Addition of more 
logs to the test"
URL: https://github.com/apache/geode/pull/1069
 
 
   Reverts apache/geode#980


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CI Failure: 
> WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously
> -
>
> Key: GEODE-1920
> URL: https://issues.apache.org/jira/browse/GEODE-1920
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Eric Shu
>  Labels: ci
> Fix For: 1.4.0
>
>
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously(WanAutoDiscoveryDUnitTest.java:274)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor233.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor232.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)

[jira] [Commented] (GEODE-1920) CI Failure: WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255747#comment-16255747
 ] 

ASF subversion and git services commented on GEODE-1920:


Commit 478665f17ef56e3d1bd2a0da1fe4d041476170a7 in geode's branch 
refs/heads/develop from [~nabarunnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=478665f ]

Revert "GEODE-1920 Addition of more logs to the test"

This reverts commit 7f0d5f529c1dc44fecb970a099eb307dd1824235.


> CI Failure: 
> WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously
> -
>
> Key: GEODE-1920
> URL: https://issues.apache.org/jira/browse/GEODE-1920
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Eric Shu
>  Labels: ci
> Fix For: 1.4.0
>
>
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously(WanAutoDiscoveryDUnitTest.java:274)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor233.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor232.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
>   at 
> 

[jira] [Commented] (GEODE-1920) CI Failure: WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255743#comment-16255743
 ] 

ASF subversion and git services commented on GEODE-1920:


Commit a8848a9d20406394b1a2f427ddc2ea22066bc1b4 in geode's branch 
refs/heads/revert-980-feature/GEODE-1920 from [~nabarunnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a8848a9 ]

Revert "GEODE-1920 Addition of more logs to the test"

This reverts commit 7f0d5f529c1dc44fecb970a099eb307dd1824235.


> CI Failure: 
> WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously
> -
>
> Key: GEODE-1920
> URL: https://issues.apache.org/jira/browse/GEODE-1920
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Eric Shu
>  Labels: ci
> Fix For: 1.4.0
>
>
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously(WanAutoDiscoveryDUnitTest.java:274)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor233.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor232.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
>   at 
> 

[jira] [Updated] (GEODE-1866) LauncherLifecycleCommandsDUnitTest.test014GemFireServerJvmProcessTerminatesOnOutOfMemoryError

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-1866:

Labels: CI flaky  (was: CI)

> LauncherLifecycleCommandsDUnitTest.test014GemFireServerJvmProcessTerminatesOnOutOfMemoryError
> -
>
> Key: GEODE-1866
> URL: https://issues.apache.org/jira/browse/GEODE-1866
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: xiaojian zhou
>  Labels: CI, flaky
> Fix For: 1.0.0-incubating
>
>
> {noformat}
> Geode_develop_DistributedTests  3832
> one of failures is:
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest
>  > test006StartLocatorInRelativeDirectory FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.readPid(LauncherLifecycleCommandsDUnitTest.java:175)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.waitForGemFireProcessToStop(LauncherLifecycleCommandsDUnitTest.java:240)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.stopLocator(LauncherLifecycleCommandsDUnitTest.java:210)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.stopLocator(LauncherLifecycleCommandsDUnitTest.java:206)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.test006StartLocatorInRelativeDirectory(LauncherLifecycleCommandsDUnitTest.java:492)
> [noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (GEODE-1866) LauncherLifecycleCommandsDUnitTest.test014GemFireServerJvmProcessTerminatesOnOutOfMemoryError

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt reopened GEODE-1866:
-

> LauncherLifecycleCommandsDUnitTest.test014GemFireServerJvmProcessTerminatesOnOutOfMemoryError
> -
>
> Key: GEODE-1866
> URL: https://issues.apache.org/jira/browse/GEODE-1866
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: xiaojian zhou
>  Labels: CI, flaky
> Fix For: 1.0.0-incubating
>
>
> {noformat}
> Geode_develop_DistributedTests  3832
> one of failures is:
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest
>  > test006StartLocatorInRelativeDirectory FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.readPid(LauncherLifecycleCommandsDUnitTest.java:175)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.waitForGemFireProcessToStop(LauncherLifecycleCommandsDUnitTest.java:240)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.stopLocator(LauncherLifecycleCommandsDUnitTest.java:210)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.stopLocator(LauncherLifecycleCommandsDUnitTest.java:206)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.test006StartLocatorInRelativeDirectory(LauncherLifecycleCommandsDUnitTest.java:492)
> [noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-1866) LauncherLifecycleCommandsDUnitTest.test014GemFireServerJvmProcessTerminatesOnOutOfMemoryError

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-1866:

Component/s: management

> LauncherLifecycleCommandsDUnitTest.test014GemFireServerJvmProcessTerminatesOnOutOfMemoryError
> -
>
> Key: GEODE-1866
> URL: https://issues.apache.org/jira/browse/GEODE-1866
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: xiaojian zhou
>  Labels: CI, flaky
> Fix For: 1.0.0-incubating
>
>
> {noformat}
> Geode_develop_DistributedTests  3832
> one of failures is:
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest
>  > test006StartLocatorInRelativeDirectory FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.readPid(LauncherLifecycleCommandsDUnitTest.java:175)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.waitForGemFireProcessToStop(LauncherLifecycleCommandsDUnitTest.java:240)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.stopLocator(LauncherLifecycleCommandsDUnitTest.java:210)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.stopLocator(LauncherLifecycleCommandsDUnitTest.java:206)
> at 
> com.gemstone.gemfire.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.test006StartLocatorInRelativeDirectory(LauncherLifecycleCommandsDUnitTest.java:492)
> [noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (GEODE-1920) CI Failure: WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun closed GEODE-1920.
--

> CI Failure: 
> WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously
> -
>
> Key: GEODE-1920
> URL: https://issues.apache.org/jira/browse/GEODE-1920
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Eric Shu
>  Labels: ci
> Fix For: 1.4.0
>
>
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously(WanAutoDiscoveryDUnitTest.java:274)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor233.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor232.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 

[jira] [Updated] (GEODE-1920) CI Failure: WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun updated GEODE-1920:
---
Fix Version/s: 1.4.0

> CI Failure: 
> WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously
> -
>
> Key: GEODE-1920
> URL: https://issues.apache.org/jira/browse/GEODE-1920
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Eric Shu
>  Labels: ci
> Fix For: 1.4.0
>
>
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously(WanAutoDiscoveryDUnitTest.java:274)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor233.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor232.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 

[jira] [Resolved] (GEODE-1920) CI Failure: WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun resolved GEODE-1920.

Resolution: Fixed

> CI Failure: 
> WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously
> -
>
> Key: GEODE-1920
> URL: https://issues.apache.org/jira/browse/GEODE-1920
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Eric Shu
>  Labels: ci
>
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously(WanAutoDiscoveryDUnitTest.java:274)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor233.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor232.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)

[jira] [Commented] (GEODE-1920) CI Failure: WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255729#comment-16255729
 ] 

ASF GitHub Bot commented on GEODE-1920:
---

nabarunnag closed pull request #980: GEODE-1920 Addition of more logs to the 
test
URL: https://github.com/apache/geode/pull/980
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java
 
b/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java
index 7c1308790a..9f4dee2f0f 100644
--- 
a/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java
+++ 
b/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java
@@ -14,16 +14,17 @@
  */
 package org.apache.geode.internal.cache.wan.misc;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 import java.net.InetAddress;
 import java.net.InetSocketAddress;
 import java.net.UnknownHostException;
-import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
 import java.util.Set;
+import java.util.stream.IntStream;
 
 import org.junit.Ignore;
 import org.junit.Test;
@@ -39,10 +40,7 @@
 import org.apache.geode.test.dunit.Host;
 import org.apache.geode.test.dunit.IgnoredException;
 import org.apache.geode.test.dunit.LogWriterUtils;
-import org.apache.geode.test.dunit.cache.internal.JUnit4CacheTestCase;
-import org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase;
 import org.apache.geode.test.junit.categories.DistributedTest;
-import org.apache.geode.test.junit.categories.FlakyTest;
 
 @Category(DistributedTest.class)
 public class WanAutoDiscoveryDUnitTest extends WANTestBase {
@@ -234,7 +232,6 @@ public void test_TK_Recognises_LN_AND_NY() {
 vm2.invoke(() -> WANTestBase.checkAllSiteMetaData(dsVsPort));
   }
 
-  @Category(FlakyTest.class) // GEODE-1920
   @Test
   public void test_NY_Recognises_TK_AND_HK_Simultaneously() {
 Map dsVsPort = new HashMap<>();
@@ -261,27 +258,14 @@ public void test_NY_Recognises_TK_AND_HK_Simultaneously() 
{
 dsVsPort.put(4, locatorPortshk);
 async[1] = vm3.invokeAsync(() -> WANTestBase.createFirstRemoteLocator(4, 
nyLocPort1));
 
-ArrayList locatorPortsln2 = new ArrayList();
 async[2] = vm4.invokeAsync(() -> WANTestBase.createSecondLocator(1, 
lnLocPort1));
 
-ArrayList locatorPortsny2 = new ArrayList();
 async[3] = vm5.invokeAsync(() -> WANTestBase.createSecondLocator(2, 
nyLocPort1));
 
+waitForAsyncInvokesToComplete(async);
 
-try {
-  async[0].join();
-  async[1].join();
-  async[2].join();
-  async[3].join();
-} catch (InterruptedException e) {
-  e.printStackTrace();
-  fail();
-}
-
-locatorPortstk.add(new InetSocketAddress("localhost", (Integer) 
async[0].getReturnValue()));
-locatorPortshk.add(new InetSocketAddress("localhost", (Integer) 
async[1].getReturnValue()));
-locatorPortsln.add(new InetSocketAddress("localhost", (Integer) 
async[2].getReturnValue()));
-locatorPortsny.add(new InetSocketAddress("localhost", (Integer) 
async[3].getReturnValue()));
+addPortNumbersToDSPortNumCollection(locatorPortsln, locatorPortsny, async, 
locatorPortstk,
+locatorPortshk);
 
 vm0.invoke(() -> WANTestBase.checkAllSiteMetaData(dsVsPort));
 vm1.invoke(() -> WANTestBase.checkAllSiteMetaData(dsVsPort));
@@ -289,6 +273,52 @@ public void test_NY_Recognises_TK_AND_HK_Simultaneously() {
 vm3.invoke(() -> WANTestBase.checkAllSiteMetaData(dsVsPort));
   }
 
+  private void addPortNumbersToDSPortNumCollection(Set 
locatorPortsln,
+  Set locatorPortsny, AsyncInvocation[] async,
+  Set locatorPortstk, Set 
locatorPortshk) {
+IntStream.range(0, 4).forEach(i -> {
+  Integer portNumber = null;
+  try {
+portNumber = (Integer) async[i].get();
+switch (i) {
+  case 0:
+locatorPortstk.add(new InetSocketAddress("localhost", portNumber));
+break;
+  case 1:
+locatorPortshk.add(new InetSocketAddress("localhost", portNumber));
+break;
+  case 2:
+locatorPortsln.add(new InetSocketAddress("localhost", portNumber));
+break;
+  case 3:
+locatorPortsny.add(new InetSocketAddress("localhost", portNumber));
+break;
+}
+  } catch (Exception e) {
+e.printStackTrace();
+if (portNumber == null) {
+  fail("No port number was returned for async invocation #" + i);

[jira] [Commented] (GEODE-1920) CI Failure: WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255730#comment-16255730
 ] 

ASF subversion and git services commented on GEODE-1920:


Commit 7f0d5f529c1dc44fecb970a099eb307dd1824235 in geode's branch 
refs/heads/develop from [~nnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7f0d5f5 ]

GEODE-1920 Addition of more logs to the test

* More logs were added at the failure points to figure out what caused 
a failure.
* Refactored by simplifying the code and removing deprecated function 
calls.
* Removed the flaky tag


> CI Failure: 
> WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously
> -
>
> Key: GEODE-1920
> URL: https://issues.apache.org/jira/browse/GEODE-1920
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Eric Shu
>  Labels: ci
>
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.wan.misc.WanAutoDiscoveryDUnitTest.test_NY_Recognises_TK_AND_HK_Simultaneously(WanAutoDiscoveryDUnitTest.java:274)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor233.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.GeneratedMethodAccessor232.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> 

[jira] [Commented] (GEODE-3977) .NET QueryService templating should match usage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255665#comment-16255665
 ] 

ASF GitHub Bot commented on GEODE-3977:
---

mhansonp opened a new pull request #154: GEODE-3977: Modifying the QueryService 
template
URL: https://github.com/apache/geode-native/pull/154
 
 
   -Modified the QueryService template to only take
one parameter instead of two.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> .NET QueryService templating should match usage
> ---
>
> Key: GEODE-3977
> URL: https://issues.apache.org/jira/browse/GEODE-3977
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> QueryService uses generics
>  generic
>   //generic
>   Query^ QueryService::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3539) Add more test coverage for p2p commands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255662#comment-16255662
 ] 

ASF GitHub Bot commented on GEODE-3539:
---

jinmeiliao commented on a change in pull request #1065: GEODE-3539: Add missing 
test coverage to 'list disk-stores' and …
URL: https://github.com/apache/geode/pull/1065#discussion_r151484942
 
 

 ##
 File path: 
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DescribeDiskStoreCommandIntegrationTest.java
 ##
 @@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.rules.GfshCommandRule;
+import org.apache.geode.test.junit.rules.GfshCommandRule.PortType;
+import org.apache.geode.test.junit.rules.ServerStarterRule;
+
+@Category(IntegrationTest.class)
+public class DescribeDiskStoreCommandIntegrationTest {
+  private static final String REGION_NAME = "test-region";
+  private static final String MEMBER_NAME = "testServer";
+  private static final String DISK_STORE_NAME = "testDiskStore";
+
+  private static final List expectedData = Arrays.asList("Disk Store 
ID", "Disk Store Name",
+  "Member ID", "Member Name", "Allow Force Compaction", "Auto Compaction",
+  "Compaction Threshold", "Max Oplog Size", "Queue Size", "Time Interval", 
"Write Buffer Size",
+  "Disk Usage Warning Percentage", "Disk Usage Critical Percentage ",
+  "PDX Serialization Meta-Data Stored", "Disk Directory", "Size");
+
+  @ClassRule
+  public static ServerStarterRule server =
+  new ServerStarterRule().withRegion(RegionShortcut.REPLICATE, REGION_NAME)
+  
.withName(MEMBER_NAME).withJMXManager().withEmbeddedLocator().withAutoStart();
+
+  @BeforeClass
+  public static void beforeClass() {
+server.getCache().createDiskStoreFactory().create(DISK_STORE_NAME);
+  }
+
+  @Rule
+  public GfshCommandRule gfsh = new GfshCommandRule();
+
+  @Before
+  public void setTimeout() {
+gfsh.setTimeout(1);
+  }
+
+  @Test
+  public void commandFailsWithoutOptions() throws Exception {
+String cmd = "describe disk-store";
+gfsh.connectAndVerify(server.getEmbeddedLocatorPort(), PortType.locator);
 
 Review comment:
   you can put your connectAndVerify in the beforeClass() method


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add more test coverage for p2p commands
> ---
>
> Key: GEODE-3539
> URL: https://issues.apache.org/jira/browse/GEODE-3539
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Jinmei Liao
>
> Add more command tests that would eventually get rid of the legacy tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3624) Update exceptions to more closely match standard exception interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255649#comment-16255649
 ] 

ASF GitHub Bot commented on GEODE-3624:
---

pivotal-jbarrett commented on a change in pull request #152: GEODE-3624: Update 
C++ client exceptions to implement std::exception interface
URL: https://github.com/apache/geode-native/pull/152#discussion_r151483458
 
 

 ##
 File path: clicache/src/ExceptionTypes.cpp
 ##
 @@ -112,6 +112,12 @@ namespace Apache
   System::Exception^ GeodeException::Get(const 
apache::geode::client::Exception& nativeEx)
   {
 Exception^ innerException = nullptr;
+try
+{
+  std::rethrow_if_nested(nativeEx);
+} catch (const apache::geode::client::Exception& ex) {
+  innerException = GeodeException::Get(ex);
+}
 
 Review comment:
   Crazy but hey its the C++11 way right!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update exceptions to more closely match standard exception interface
> 
>
> Key: GEODE-3624
> URL: https://issues.apache.org/jira/browse/GEODE-3624
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: David Kimura
>
> Native client library should follow standard exception interface for any 
> thrown exceptions.  This means one less custom interface that a customer or 
> developer needs to understand.
> {noformat}
> namespace apache {
> namespace geode {
> namespace client {
> class Exception : public std::exception {...};
> class IllegalArgumentException : public Exception {...};
> class TransactionException : public Exception {...};
> class RollbackException : public TransactionException {...};
> // NO - class IllegalArgumentException : public Exception, public
> std::invalid_argument {...};
> // NO - class IllegalArgumentException : public std::invalid_argument {...};
> // NO - class IllegalArgumentException : public Exception, public
> TransactionException {...};
> }
> }
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3624) Update exceptions to more closely match standard exception interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255648#comment-16255648
 ] 

ASF GitHub Bot commented on GEODE-3624:
---

pivotal-jbarrett commented on a change in pull request #152: GEODE-3624: Update 
C++ client exceptions to implement std::exception interface
URL: https://github.com/apache/geode-native/pull/152#discussion_r151482907
 
 

 ##
 File path: cppcache/include/geode/ExceptionTypes.hpp
 ##
 @@ -59,265 +40,369 @@ class CacheableString;
 /**
  *@brief A geode assertion exception.
  **/
-_GF_EXCEPTION_DEF(AssertionException);
+class AssertionException : public Exception {
 
 Review comment:
   OMG! So much better!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update exceptions to more closely match standard exception interface
> 
>
> Key: GEODE-3624
> URL: https://issues.apache.org/jira/browse/GEODE-3624
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: David Kimura
>
> Native client library should follow standard exception interface for any 
> thrown exceptions.  This means one less custom interface that a customer or 
> developer needs to understand.
> {noformat}
> namespace apache {
> namespace geode {
> namespace client {
> class Exception : public std::exception {...};
> class IllegalArgumentException : public Exception {...};
> class TransactionException : public Exception {...};
> class RollbackException : public TransactionException {...};
> // NO - class IllegalArgumentException : public Exception, public
> std::invalid_argument {...};
> // NO - class IllegalArgumentException : public std::invalid_argument {...};
> // NO - class IllegalArgumentException : public Exception, public
> TransactionException {...};
> }
> }
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3624) Update exceptions to more closely match standard exception interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255647#comment-16255647
 ] 

ASF GitHub Bot commented on GEODE-3624:
---

pivotal-jbarrett commented on a change in pull request #152: GEODE-3624: Update 
C++ client exceptions to implement std::exception interface
URL: https://github.com/apache/geode-native/pull/152#discussion_r151483255
 
 

 ##
 File path: cppcache/include/geode/Exception.hpp
 ##
 @@ -52,9 +52,9 @@ class CPPCACHE_EXPORT Exception : public std::exception {
   /** Creates an exception.
* @param  msg1 message pointer, this is copied into the exception.
**/
-  Exception(const char* msg1);
+  explicit Exception(const char* msg1);
 
 Review comment:
   I think it is only really necessary when the first arg is a ref to avoid a 
conversation copy construct. Though it probably doesn't hurt here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update exceptions to more closely match standard exception interface
> 
>
> Key: GEODE-3624
> URL: https://issues.apache.org/jira/browse/GEODE-3624
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: David Kimura
>
> Native client library should follow standard exception interface for any 
> thrown exceptions.  This means one less custom interface that a customer or 
> developer needs to understand.
> {noformat}
> namespace apache {
> namespace geode {
> namespace client {
> class Exception : public std::exception {...};
> class IllegalArgumentException : public Exception {...};
> class TransactionException : public Exception {...};
> class RollbackException : public TransactionException {...};
> // NO - class IllegalArgumentException : public Exception, public
> std::invalid_argument {...};
> // NO - class IllegalArgumentException : public std::invalid_argument {...};
> // NO - class IllegalArgumentException : public Exception, public
> TransactionException {...};
> }
> }
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-1897) Users should be able to configure eviction through gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255586#comment-16255586
 ] 

ASF GitHub Bot commented on GEODE-1897:
---

jinmeiliao commented on a change in pull request #1068: GEODE-1897: Ensure that 
eviction-object-sizer also implements Declarable
URL: https://github.com/apache/geode/pull/1068#discussion_r151472616
 
 

 ##
 File path: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java
 ##
 @@ -683,10 +683,6 @@ public Result preExecution(GfshParseResult parseResult) {
   return ResultBuilder.createUserErrorResult(
 
 Review comment:
   "and" these two ifs to make less nesting


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Users should be able to configure eviction through gfsh
> ---
>
> Key: GEODE-1897
> URL: https://issues.apache.org/jira/browse/GEODE-1897
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Jens Deppe
>
> While creating a region in gfsh, users should be able to configure eviction 
> for that region.
> All three modes of eviction should be supported:
> 1. Eviction driven by the resource manager:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-enabled
> {noformat}
> 2. eviction driven by entry count in the region:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE 
> --eviction-entry-count=1000
> {noformat}
> 3. eviction driven by bytes used:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-max-memory=100m
> {noformat}
> And also specify the eviction action as
> {noformat}
> --eviction-action=overflow-to-disk or
> --eviction-action=destroy
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3341) Refactor DiskStoreCommandsDUnitTest to use test rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255575#comment-16255575
 ] 

ASF GitHub Bot commented on GEODE-3341:
---

pdxrunner commented on a change in pull request #1062: GEODE-3341: Convert 
DiskStoreCommandsDUnitTest to use gfsh rules
URL: https://github.com/apache/geode/pull/1062#discussion_r151469638
 
 

 ##
 File path: 
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java
 ##
 @@ -12,1480 +12,283 @@
  * or implied. See the License for the specific language governing permissions 
and limitations under
  * the License.
  */
+
 package org.apache.geode.management.internal.cli.commands;
 
-import static 
org.apache.geode.distributed.ConfigurationProperties.ENABLE_CLUSTER_CONFIGURATION;
-import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
-import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_PORT;
-import static org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER;
-import static 
org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_BIND_ADDRESS;
-import static 
org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_PORT;
-import static 
org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_START;
-import static org.apache.geode.distributed.ConfigurationProperties.LOCATORS;
-import static org.apache.geode.distributed.ConfigurationProperties.LOG_LEVEL;
-import static org.apache.geode.distributed.ConfigurationProperties.MCAST_PORT;
-import static org.apache.geode.distributed.ConfigurationProperties.NAME;
-import static 
org.apache.geode.distributed.ConfigurationProperties.START_LOCATOR;
-import static 
org.apache.geode.distributed.ConfigurationProperties.USE_CLUSTER_CONFIGURATION;
-import static org.apache.geode.test.dunit.Assert.fail;
-import static org.apache.geode.test.dunit.LogWriterUtils.getLogWriter;
-import static org.apache.geode.test.dunit.Wait.waitForCriterion;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
 
 import java.io.File;
-import java.io.IOException;
-import java.net.InetAddress;
-import java.net.UnknownHostException;
-import java.util.Collection;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Properties;
-import java.util.StringTokenizer;
-import java.util.concurrent.CopyOnWriteArrayList;
-import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
 
-import org.apache.commons.io.FileUtils;
+import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
 
 import org.apache.geode.cache.Cache;
-import org.apache.geode.cache.CacheFactory;
-import org.apache.geode.cache.DataPolicy;
-import org.apache.geode.cache.DiskStore;
-import org.apache.geode.cache.DiskStoreFactory;
-import org.apache.geode.cache.EvictionAction;
-import org.apache.geode.cache.EvictionAttributes;
-import org.apache.geode.cache.PartitionAttributes;
-import org.apache.geode.cache.PartitionAttributesFactory;
 import org.apache.geode.cache.Region;
-import org.apache.geode.cache.RegionFactory;
-import org.apache.geode.cache.RegionShortcut;
-import org.apache.geode.cache.Scope;
-import org.apache.geode.cache.query.data.PortfolioPdx;
 import org.apache.geode.compression.SnappyCompressor;
-import org.apache.geode.distributed.DistributedSystemDisconnectedException;
 import org.apache.geode.distributed.Locator;
 import org.apache.geode.distributed.internal.ClusterConfigurationService;
 import org.apache.geode.distributed.internal.InternalLocator;
-import org.apache.geode.internal.AvailablePort;
-import org.apache.geode.internal.AvailablePortHelper;
-import org.apache.geode.internal.cache.GemFireCacheImpl;
-import org.apache.geode.internal.cache.InternalCache;
-import org.apache.geode.internal.cache.PartitionedRegion;
 import org.apache.geode.internal.cache.SnapshotTestUtil;
-import org.apache.geode.internal.cache.persistence.PersistentMemberManager;
-import org.apache.geode.management.cli.Result;
-import org.apache.geode.management.internal.cli.i18n.CliStrings;
-import org.apache.geode.management.internal.cli.result.CommandResult;
-import org.apache.geode.management.internal.cli.shell.Gfsh;
-import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
-import org.apache.geode.test.dunit.AsyncInvocation;
-import org.apache.geode.test.dunit.Host;
-import org.apache.geode.test.dunit.SerializableCallable;
-import org.apache.geode.test.dunit.SerializableRunnable;
-import org.apache.geode.test.dunit.VM;
-import 

[jira] [Commented] (GEODE-1897) Users should be able to configure eviction through gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1624#comment-1624
 ] 

ASF GitHub Bot commented on GEODE-1897:
---

jdeppe-pivotal opened a new pull request #1068: GEODE-1897: Ensure that 
eviction-object-sizer also implements Declarable
URL: https://github.com/apache/geode/pull/1068
 
 
   - Minor acceptance test updates
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Users should be able to configure eviction through gfsh
> ---
>
> Key: GEODE-1897
> URL: https://issues.apache.org/jira/browse/GEODE-1897
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Jens Deppe
>
> While creating a region in gfsh, users should be able to configure eviction 
> for that region.
> All three modes of eviction should be supported:
> 1. Eviction driven by the resource manager:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-enabled
> {noformat}
> 2. eviction driven by entry count in the region:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE 
> --eviction-entry-count=1000
> {noformat}
> 3. eviction driven by bytes used:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-max-memory=100m
> {noformat}
> And also specify the eviction action as
> {noformat}
> --eviction-action=overflow-to-disk or
> --eviction-action=destroy
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3683) CacheConnectionTimeoutJUnitTest failing intermittently in CI.

[Brian Baynes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Baynes updated GEODE-3683:

Fix Version/s: (was: 1.3.0)
   1.4.0

> CacheConnectionTimeoutJUnitTest failing intermittently in CI.
> -
>
> Key: GEODE-3683
> URL: https://issues.apache.org/jira/browse/GEODE-3683
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Galen O'Sullivan
> Fix For: 1.4.0
>
>
> The `testUnresponsiveClientsGetDisconnected` test is failing. I think this is 
> because the Awaitility condition is broken.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)