[GitHub] [hbase] Apache-HBase commented on pull request #4353: HBASE-26959 Brotli compression support
Apache-HBase commented on PR #4353: URL: https://github.com/apache/hbase/pull/4353#issuecomment-1106034187 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 22s | master passed | | +1 :green_heart: | compile | 1m 36s | master passed | | +1 :green_heart: | shadedjars | 3m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 59s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 28s | the patch passed | | +1 :green_heart: | compile | 1m 51s | the patch passed | | +1 :green_heart: | javac | 1m 51s | the patch passed | | +1 :green_heart: | shadedjars | 3m 54s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 1m 33s | root generated 3 new + 82 unchanged - 3 fixed = 85 total (was 85) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 345m 54s | root in the patch passed. | | | | 377m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4353/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4353 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3e624ab43e78 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 41ae90d63f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4353/6/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4353/6/testReport/ | | Max. process+thread count | 4692 (vs. ulimit of 3) | | modules | C: hbase-common hbase-resource-bundle hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd . hbase-assembly U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4353/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] liangxs commented on pull request #4362: HBASE-26964 Fix java import in admin.rb
liangxs commented on PR #4362: URL: https://github.com/apache/hbase/pull/4362#issuecomment-1106008613 @pankaj72981 Thanks very much for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4353: HBASE-26959 Brotli compression support
Apache-HBase commented on PR #4353: URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105983000 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 40s | master passed | | +1 :green_heart: | compile | 1m 50s | master passed | | +1 :green_heart: | shadedjars | 3m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 43s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 33s | the patch passed | | +1 :green_heart: | compile | 1m 51s | the patch passed | | +1 :green_heart: | javac | 1m 51s | the patch passed | | +1 :green_heart: | shadedjars | 3m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 243m 6s | root in the patch passed. | | | | 277m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4353/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4353 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 62767ce18835 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 41ae90d63f | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4353/6/testReport/ | | Max. process+thread count | 4526 (vs. ulimit of 3) | | modules | C: hbase-common hbase-resource-bundle hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4353/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4353: HBASE-26959 Brotli compression support
Apache-HBase commented on PR #4353: URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105885157 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 56s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 2s | master passed | | +1 :green_heart: | compile | 5m 47s | master passed | | +1 :green_heart: | checkstyle | 1m 5s | master passed | | +1 :green_heart: | spotbugs | 9m 13s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 5s | the patch passed | | +1 :green_heart: | compile | 5m 55s | the patch passed | | -0 :warning: | javac | 5m 55s | root generated 15 new + 1458 unchanged - 15 fixed = 1473 total (was 1473) | | +1 :green_heart: | checkstyle | 1m 17s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 36s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 10m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 15s | The patch does not generate ASF License warnings. | | | | 62m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4353/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4353 | | Optional Tests | dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle | | uname | Linux 04a7224a32f7 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 41ae90d63f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4353/6/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 138 (vs. ulimit of 3) | | modules | C: hbase-common hbase-resource-bundle hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4353/6/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3999: HBASE-26645 Upgrade create-release to use JDK11
Apache-HBase commented on PR #3999: URL: https://github.com/apache/hbase/pull/3999#issuecomment-1105792777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch | | +1 :green_heart: | hadolint | 0m 0s | There were no new hadolint issues. | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 2m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3999/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3999 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint | | uname | Linux 9b855182a138 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 41ae90d63f | | Max. process+thread count | 28 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3999/2/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 hadolint=1.17.5-0-g443423c | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3999: HBASE-26645 Upgrade create-release to use JDK11
Apache-HBase commented on PR #3999: URL: https://github.com/apache/hbase/pull/3999#issuecomment-1105792127 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3999/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3999 | | Optional Tests | | | uname | Linux e71a4689006e 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 41ae90d63f | | Max. process+thread count | 30 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3999/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26708) Netty Leak detected and eventually results in OutOfDirectMemoryError
[
https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526094#comment-17526094
]
Josh Elser commented on HBASE-26708:
[~vjasani] did you ever get to the bottom of this one? We have a case where
we're seeing a slow leak and warnings from Netty in the same "Created at" point.
> Netty Leak detected and eventually results in OutOfDirectMemoryError
>
>
> Key: HBASE-26708
> URL: https://issues.apache.org/jira/browse/HBASE-26708
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.4.6
>Reporter: Viraj Jasani
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.12
>
>
> Under constant data ingestion, using default Netty based RpcServer and
> RpcClient implementation results in OutOfDirectMemoryError, supposedly caused
> by leaks detected by Netty's LeakDetector.
> {code:java}
> 2022-01-25 17:03:10,084 ERROR [S-EventLoopGroup-1-3]
> util.ResourceLeakDetector - java:115)
>
> org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.expandCumulation(ByteToMessageDecoder.java:538)
>
> org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder$1.cumulate(ByteToMessageDecoder.java:97)
>
> org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:274)
>
> org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
>
> org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
>
> org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
>
> org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
>
> org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
>
> org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
>
> org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
>
> org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795)
>
> org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:480)
>
> org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)
>
> org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
>
> org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
>
> org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> java.lang.Thread.run(Thread.java:748)
> {code}
> {code:java}
> 2022-01-25 17:03:14,014 ERROR [S-EventLoopGroup-1-3]
> util.ResourceLeakDetector -
> apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:507)
>
> org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:446)
>
> org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
>
> org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
>
> org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
>
> org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
>
> org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
>
> org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
>
> org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
>
> org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
>
> org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795)
>
> org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:480)
>
>
[GitHub] [hbase] Apache-HBase commented on pull request #4337: HBASE-25058 Export necessary modules when running under JDK11
Apache-HBase commented on PR #4337: URL: https://github.com/apache/hbase/pull/4337#issuecomment-1105777880 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 20s | master passed | | +1 :green_heart: | compile | 1m 29s | master passed | | +1 :green_heart: | shadedjars | 3m 56s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 19s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 8s | the patch passed | | +1 :green_heart: | compile | 1m 23s | the patch passed | | +1 :green_heart: | javac | 1m 23s | the patch passed | | +1 :green_heart: | shadedjars | 3m 52s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 1m 18s | root generated 6 new + 77 unchanged - 8 fixed = 83 total (was 85) | ||| _ Other Tests _ | | -1 :x: | unit | 360m 9s | root in the patch failed. | | | | 380m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4337/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4337 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 737c796a85aa 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 13d932cba3 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4337/8/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4337/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4337/8/testReport/ | | Max. process+thread count | 4978 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4337/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3999: HBASE-26645 Upgrade create-release to use JDK11
Apache-HBase commented on PR #3999: URL: https://github.com/apache/hbase/pull/3999#issuecomment-1105775875 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3999/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3999 | | Optional Tests | | | uname | Linux 1c9daec0dbb7 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 41ae90d63f | | Max. process+thread count | 41 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3999/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #4353: HBASE-26959 Brotli compression support
apurtell commented on PR #4353: URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105758772 Rebased on master, using supplemental models to fix the LICENSE.vm issue as required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell commented on a diff in pull request #4353: HBASE-26959 Brotli compression support
apurtell commented on code in PR #4353: URL: https://github.com/apache/hbase/pull/4353#discussion_r855592677 ## hbase-resource-bundle/src/main/resources/META-INF/LICENSE.vm: ## @@ -1381,7 +1381,7 @@ You can redistribute it and/or modify it under either the terms of the ## See this FAQ link for justifications: https://www.apache.org/legal/resolved.html ## ## NB: This list is later compared as lower-case. New entries must also be all lower-case -#set($non_aggregate_fine = [ 'public domain', 'new bsd license', 'bsd license', 'bsd', 'bsd 2-clause license', 'mozilla public license version 1.1', 'mozilla public license version 2.0', 'creative commons attribution license, version 2.5' ]) +#set($non_aggregate_fine = [ 'public domain', 'new bsd license', 'bsd license', 'bsd', 'bsd 2-clause license', 'mozilla public license version 1.1', 'mozilla public license version 2.0', 'creative commons attribution license, version 2.5', 'apache license 2.0' ]) Review Comment: I'm glad you had me do it again because this time I was successful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-26760) LICENSE handling should not allow non-aggregated "apache-2.0"
[
https://issues.apache.org/jira/browse/HBASE-26760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526070#comment-17526070
]
Andrew Kyle Purtell edited comment on HBASE-26760 at 4/21/22 8:47 PM:
--
I tried this with brotli4j and the supplimental models approach did not work.
PR#4353 for the curious. I am going to try it again based on review feedback.
This is going to come up again, I am fairly certain.
was (Author: apurtell):
I tried this with brotli4j and the supplimental models approach did not work.
> LICENSE handling should not allow non-aggregated "apache-2.0"
> -
>
> Key: HBASE-26760
> URL: https://issues.apache.org/jira/browse/HBASE-26760
> Project: HBase
> Issue Type: Task
> Components: community
>Affects Versions: 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.4.10
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.11
>
>
> our non-aggregated license check currently allows the malformed name
> "apache-2.0". All ALv2 licenses should be aggregated.
> - remove "apache-2.0" from the {{non_aggregate_fine}} list
> - figure out what dependencies are referring to this license and correct them
> in {{supplemental-models.xml}}
> nice to have: maybe add a precommit check that complains if the
> {{non_aggregate_fine}} set is changed?
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] apurtell commented on a diff in pull request #4353: HBASE-26959 Brotli compression support
apurtell commented on code in PR #4353: URL: https://github.com/apache/hbase/pull/4353#discussion_r855578555 ## hbase-resource-bundle/src/main/resources/META-INF/LICENSE.vm: ## @@ -1381,7 +1381,7 @@ You can redistribute it and/or modify it under either the terms of the ## See this FAQ link for justifications: https://www.apache.org/legal/resolved.html ## ## NB: This list is later compared as lower-case. New entries must also be all lower-case -#set($non_aggregate_fine = [ 'public domain', 'new bsd license', 'bsd license', 'bsd', 'bsd 2-clause license', 'mozilla public license version 1.1', 'mozilla public license version 2.0', 'creative commons attribution license, version 2.5' ]) +#set($non_aggregate_fine = [ 'public domain', 'new bsd license', 'bsd license', 'bsd', 'bsd 2-clause license', 'mozilla public license version 1.1', 'mozilla public license version 2.0', 'creative commons attribution license, version 2.5', 'apache license 2.0' ]) Review Comment: @busbey I tried the supplimental models approach and it did not work. I will put it back so you can observe the failure. Or perhaps by doing it again I will find some detail missed last time. I would hate to abandon this work because of this nit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26760) LICENSE handling should not allow non-aggregated "apache-2.0"
[
https://issues.apache.org/jira/browse/HBASE-26760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526070#comment-17526070
]
Andrew Kyle Purtell commented on HBASE-26760:
-
I tried this with brotli4j and the supplimental models approach did not work.
> LICENSE handling should not allow non-aggregated "apache-2.0"
> -
>
> Key: HBASE-26760
> URL: https://issues.apache.org/jira/browse/HBASE-26760
> Project: HBase
> Issue Type: Task
> Components: community
>Affects Versions: 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.4.10
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.11
>
>
> our non-aggregated license check currently allows the malformed name
> "apache-2.0". All ALv2 licenses should be aggregated.
> - remove "apache-2.0" from the {{non_aggregate_fine}} list
> - figure out what dependencies are referring to this license and correct them
> in {{supplemental-models.xml}}
> nice to have: maybe add a precommit check that complains if the
> {{non_aggregate_fine}} set is changed?
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HBASE-26959) Brotli compression support
[ https://issues.apache.org/jira/browse/HBASE-26959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526067#comment-17526067 ] Andrew Kyle Purtell commented on HBASE-26959: - After ingesting ~5TB of CommonCrawl data, brotli compressing at level 7 offers a few % improvement (-85% vs -82%) over zstandard also compressing at its notion of level 7. This stands to reason as brotli will fall back on its static dictionary pre-trained on web content before adding input to the generic/dynamic dictionary; while zstandard does not have this advantage (although it could, if the user configures a suitable pre-trained dictionary for it (see HBASE-26353)). At scale that difference would be noticeable. > Brotli compression support > -- > > Key: HBASE-26959 > URL: https://issues.apache.org/jira/browse/HBASE-26959 > Project: HBase > Issue Type: New Feature >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-3 > > > I was about to document the compression improvements upcoming in 2.5.0 and > realized we lacked support for one of the major compression formats in use > today. (Arguably brotli is not often used to compress data at rest, but is > widely supported among web browsers and HTTP servers and clients.) > Brotli support for Java is provided by Apache 2 licensed > [Brotli4j|https://github.com/hyperxpro/Brotli4j] available in Maven central. > It is not difficult to add it, so let's add it. There might be some advantage > to opting for brotli compression when storing web data given the precomputed > static dictionary of such content included in its specification. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] apurtell commented on pull request #4353: HBASE-26959 Brotli compression support
apurtell commented on PR #4353: URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105732799 After ingesting ~5TB of CommonCrawl data, brotli compressing at level 7 offers a few % improvement (-85% vs -82%) over zstandard also compressing at its notion of level 7. This stands to reason as brotli will fall back on its static dictionary pre-trained on web content before adding input to the generic/dynamic dictionary; while zstandard does not have this advantage (although it could, if the user configures a suitable pre-trained dictionary for it (see HBASE-26353)). At scale that difference would be noticeable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on a diff in pull request #4353: HBASE-26959 Brotli compression support
busbey commented on code in PR #4353: URL: https://github.com/apache/hbase/pull/4353#discussion_r855535440 ## hbase-resource-bundle/src/main/resources/META-INF/LICENSE.vm: ## @@ -1381,7 +1381,7 @@ You can redistribute it and/or modify it under either the terms of the ## See this FAQ link for justifications: https://www.apache.org/legal/resolved.html ## ## NB: This list is later compared as lower-case. New entries must also be all lower-case -#set($non_aggregate_fine = [ 'public domain', 'new bsd license', 'bsd license', 'bsd', 'bsd 2-clause license', 'mozilla public license version 1.1', 'mozilla public license version 2.0', 'creative commons attribution license, version 2.5' ]) +#set($non_aggregate_fine = [ 'public domain', 'new bsd license', 'bsd license', 'bsd', 'bsd 2-clause license', 'mozilla public license version 1.1', 'mozilla public license version 2.0', 'creative commons attribution license, version 2.5', 'apache license 2.0' ]) Review Comment: this should not change. please correct the name of the license via supplemental models. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4337: HBASE-25058 Export necessary modules when running under JDK11
Apache-HBase commented on PR #4337: URL: https://github.com/apache/hbase/pull/4337#issuecomment-1105675701 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 41s | master passed | | +1 :green_heart: | compile | 1m 51s | master passed | | +1 :green_heart: | shadedjars | 3m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 54s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 31s | the patch passed | | +1 :green_heart: | compile | 1m 51s | the patch passed | | +1 :green_heart: | javac | 1m 51s | the patch passed | | +1 :green_heart: | shadedjars | 3m 40s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 57s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 239m 53s | root in the patch passed. | | | | 263m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4337/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4337 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9e95060d8412 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 13d932cba3 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4337/8/testReport/ | | Max. process+thread count | 4728 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4337/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #4353: HBASE-26959 Brotli compression support
apurtell commented on PR #4353: URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105670399 Unless @busbey actually responds soon I have an approval and will merge this to move forward. He's not around much these days. Let me give it another day. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #4353: HBASE-26959 Brotli compression support
apurtell commented on PR #4353: URL: https://github.com/apache/hbase/pull/4353#issuecomment-1105668094 @Apache9 I did not save the error text. It is the standard error text you get when LICENSE.vm cannot be processed. It said to add "apache license 2.0" to non_aggregated_fine. So that is what I did, because that is true. The reason this happens is due to the Brotli4j POMs, how the license is described in them. Nothing we can do about it except add it to non_aggregated_fine as intended, I believe. I tried to substitute for the Brotli4j model in suppliemental_models but this did not work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell commented on a diff in pull request #4353: HBASE-26959 Brotli compression support
apurtell commented on code in PR #4353:
URL: https://github.com/apache/hbase/pull/4353#discussion_r855525069
##
hbase-compression/hbase-compression-zstd/src/main/java/org/apache/hadoop/hbase/io/compress/zstd/ZstdCodec.java:
##
@@ -121,10 +123,10 @@ static int getLevel(Configuration conf) {
}
static int getBufferSize(Configuration conf) {
-int size = conf.getInt(ZSTD_BUFFER_SIZE_KEY,
+return conf.getInt(ZSTD_BUFFER_SIZE_KEY,
conf.getInt(CommonConfigurationKeys.IO_COMPRESSION_CODEC_ZSTD_BUFFER_SIZE_KEY,
-
CommonConfigurationKeys.IO_COMPRESSION_CODEC_ZSTD_BUFFER_SIZE_DEFAULT));
-return size > 0 ? size : 256 * 1024; // Don't change this default
+// IO_COMPRESSION_CODEC_ZSTD_BUFFER_SIZE_DEFAULT is 0! We can't allow
that.
Review Comment:
It is Hadoop's default, IO_COMPRESSION_CODEC_ZSTD_BUFFER_SIZE_DEFAULT is a
Hadoop constant. We reuse these where we can. But the value of '0' gives an
error creating the (Hadoop) compression stream. So we don't accept it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3999: HBASE-26645 Upgrade create-release to use JDK11
ndimiduk commented on PR #3999: URL: https://github.com/apache/hbase/pull/3999#issuecomment-1105527814 Okay, this change just got complicated. Now we include both JDK versions in the docker file (the easy part) and support the user specifying which JDK they want used for the build (the annoyingly involved part). And I pushed without doing enough testing. The new parsing code has some bugs. Will be back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-26964) Fix java import in admin.rb
[
https://issues.apache.org/jira/browse/HBASE-26964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pankaj Kumar resolved HBASE-26964.
--
Fix Version/s: 3.0.0-alpha-3
Resolution: Fixed
Thanks [~liangxs] for the contribution.
> Fix java import in admin.rb
> ---
>
> Key: HBASE-26964
> URL: https://issues.apache.org/jira/browse/HBASE-26964
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: Xuesen Liang
>Assignee: Xuesen Liang
>Priority: Minor
> Fix For: 3.0.0-alpha-3
>
>
> The java_import for MobCompactPartitionPolicy in admin.rb is missed, which
> cause an error message for creating table.
> {code:bash}
> hbase:006:0> create 't2', {NAME => 'f', IS_MOB => true, MOB_THRESHOLD =>
> 100, MOB_COMPACT_PARTITION_POLICY => 'weekly'}
> ERROR: uninitialized constant Hbase::Admin::MobCompactPartitionPolicy
> Did you mean? Hbase::Admin::MOB_COMPACT_PARTITION_POLICY
> For usage try 'help "create"'
> Took 0.6897 seconds
> hbase:007:0> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] pankaj72981 merged pull request #4362: HBASE-26964 Fix java import in admin.rb
pankaj72981 merged PR #4362: URL: https://github.com/apache/hbase/pull/4362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4305: HBASE-26907 Update Hadoop3 versions for JEP 223 compliance
Apache-HBase commented on PR #4305: URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105433164 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 22s | master passed | | +1 :green_heart: | compile | 1m 35s | master passed | | +1 :green_heart: | shadedjars | 3m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 1m 33s | the patch passed | | +1 :green_heart: | javac | 1m 33s | the patch passed | | +1 :green_heart: | shadedjars | 3m 40s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 330m 29s | root in the patch passed. | | | | 352m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4305 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e4b56faf359c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8d8f956099 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/testReport/ | | Max. process+thread count | 4162 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] 2005hithlj commented on pull request #4358: HBASE-26951 HMaster should exit gracefully, when stopped via hbase-daemon.sh
2005hithlj commented on PR #4358: URL: https://github.com/apache/hbase/pull/4358#issuecomment-1105432048 I have deleted TestHRegionServer.java in the second commit, but still remind that this class failed to compile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25983) javadoc generation fails on openjdk-11.0.11+9
[
https://issues.apache.org/jira/browse/HBASE-25983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525809#comment-17525809
]
Duo Zhang commented on HBASE-25983:
---
OK, this is the last unresolved issue.
Let's take a look again.
> javadoc generation fails on openjdk-11.0.11+9
> -
>
> Key: HBASE-25983
> URL: https://issues.apache.org/jira/browse/HBASE-25983
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.4.3
> Environment: maven - 3.5.4 and 3.6.2
> java - openjdk 11.0.11+9
> centos6
> hbase - 2.4.3
>Reporter: Bryan Beaudreault
>Priority: Major
>
> I'm trying to build javadoc for HBase 2.4.3 on jdk11. The command I'm running
> is as follows:
> {code:java}
> JAVA_HOME=/usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/ mvn
> -Phadoop-3.0 -Phadoop.profile=3.0 -Dhadoop-three.version=3.2.2
> -Dhadoop.guava.version=27.0-jre -Dslf4j.version=1.7.25
> -Djetty.version=9.3.29.v20201019 -Dzookeeper.version=3.5.7 -DskipTests
> -Dcheckstyle.skip=true site{code}
> I've tried this with maven 3.5.4 and 3.6.2. Based on JAVA_HOME above,
> jdk11.0.11+9.
> {{The error is as follows:}}
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.2.0:aggregate-no-fork
> report:
> [ERROR] Exit code: 1 - javadoc: warning - The old Doclet and Taglet APIs in
> the packages
> [ERROR] com.sun.javadoc, com.sun.tools.doclets and their implementations
> [ERROR] are planned to be removed in a future JDK release. These
> [ERROR] components have been superseded by the new APIs in
> jdk.javadoc.doclet.
> [ERROR] Users are strongly recommended to migrate to the new APIs.
> [ERROR] javadoc: error - invalid flag: -author
> [ERROR]
> [ERROR] Command line was:
> /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/bin/javadoc -J-Xmx2G
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> '/hbase/rpm/build/BUILD/hbase-2.4.3/target/site/apidocs' dir.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]{code}
> I believe this is due to the yetus doclet
> org.apache.yetus.audience.tools.IncludePublicAnnotationsStandardDoclet.
> Commenting this doclet out from the userapi and testuserapi reportSets in
> pom.xml fixes the build.
>
> I noticed hbase 2.4.3 depends on audience-annotations 0.5.0, which is very
> old. I tried updating to 0.13.0, but that did not help.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (HBASE-26947) Implement a special TestAppender to limit the size of test output
[ https://issues.apache.org/jira/browse/HBASE-26947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26947: -- Fix Version/s: 2.5.0 3.0.0-alpha-3 > Implement a special TestAppender to limit the size of test output > - > > Key: HBASE-26947 > URL: https://issues.apache.org/jira/browse/HBASE-26947 > Project: HBase > Issue Type: Improvement > Components: logging, test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-3 > > > Recently our build nodes were out of space several times. I've checked some > of them, all are because of logging in an infinite loop which makes a very > big log output. > I've already opened several issues for this, such as HBASE-26858, > HBASE-26941, HBASE-26946. > So in general, I think we should have a way to limit the total size of a log > output. So when we do something wrong in code it will not eat all the space > soon and bring down our ci. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (HBASE-25058) Export necessary modules when running under JDK11
[
https://issues.apache.org/jira/browse/HBASE-25058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-25058.
---
Fix Version/s: 2.5.0
3.0.0-alpha-3
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch-2.5+.
Thanks [~ndimiduk] for reviewing!
> Export necessary modules when running under JDK11
> -
>
> Key: HBASE-25058
> URL: https://issues.apache.org/jira/browse/HBASE-25058
> Project: HBase
> Issue Type: Sub-task
> Components: Performance, rpc
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0
>Reporter: Nick Dimiduk
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> Running on JDK11, I noticed this in the debug logging. It looks like netty is
> using {{sun.misc.Unsafe}} instead of the new location on jdk11.
> {noformat}
> 2020-09-17 00:21:53,318 DEBUG
> org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent0:
> jdk.internal.misc.Unsafe.allocateUninitializedArray(int): unavailable
> java.lang.IllegalAccessException: class
> org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent0$6
> cannot access class jdk.internal.misc.Unsafe (in module java.base) because
> module java.base does not export jdk.internal.misc to unnamed module @78461bc4
> at
> java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361)
> at
> java.base/java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:591)
> at java.base/java.lang.reflect.Method.invoke(Method.java:558)
> at
> org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent0$6.run(PlatformDependent0.java:335)
> at java.base/java.security.AccessController.doPrivileged(Native
> Method)
> at
> org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent0.(PlatformDependent0.java:326)
> at
> org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent.isAndroid(PlatformDependent.java:289)
> at
> org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent.(PlatformDependent.java:92)
> at
> org.apache.hbase.thirdparty.io.netty.channel.epoll.Native.loadNativeLibrary(Native.java:228)
> at
> org.apache.hbase.thirdparty.io.netty.channel.epoll.Native.(Native.java:58)
> at
> org.apache.hbase.thirdparty.io.netty.channel.epoll.Epoll.(Epoll.java:39)
> at
> org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.(EpollEventLoop.java:51)
> at
> org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoopGroup.newChild(EpollEventLoopGroup.java:150)
> at
> org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoopGroup.newChild(EpollEventLoopGroup.java:35)
> at
> org.apache.hbase.thirdparty.io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:84)
> at
> org.apache.hbase.thirdparty.io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:58)
> at
> org.apache.hbase.thirdparty.io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:47)
> at
> org.apache.hbase.thirdparty.io.netty.channel.MultithreadEventLoopGroup.(MultithreadEventLoopGroup.java:59)
> at
> org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoopGroup.(EpollEventLoopGroup.java:112)
> at
> org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoopGroup.(EpollEventLoopGroup.java:99)
> at
> org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoopGroup.(EpollEventLoopGroup.java:76)
> at
> org.apache.hadoop.hbase.util.NettyEventLoopGroupConfig.(NettyEventLoopGroupConfig.java:58)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.setupNetty(HRegionServer.java:713)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:569)
> at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:524)
> at
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
> at
> org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:3054)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:236)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140)
>
[jira] [Resolved] (HBASE-22172) Suppress Java 11 reflective access warnings
[
https://issues.apache.org/jira/browse/HBASE-22172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-22172.
---
Resolution: Duplicate
HBASE-25058 has been resolved and we expose several jdk modules out to avoid
the illegal access warnings.
Resolve this one as duplicated.
> Suppress Java 11 reflective access warnings
> ---
>
> Key: HBASE-22172
> URL: https://issues.apache.org/jira/browse/HBASE-22172
> Project: HBase
> Issue Type: Sub-task
> Components: java, scripts
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Attachments: hbase-22172.master.001.patch
>
>
> While running a Java 8 compiled hbase on Java 11 system, I found the
> following warnings being thrown. I think we can add the "--add-opens" flag to
> HBASE_OPTS (if the jdk version is 11) to suppress this warning.
> {code:java}
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> (file:/Users/jatsakthi/test/HBASE_TEST_AREA/hbase-3.0.0-SNAPSHOT/lib/hbase-common-3.0.0-SNAPSHOT.jar)
> to method java.nio.Bits.unaligned()
> WARNING: Please consider reporting this to the maintainers of
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] Apache9 merged pull request #4337: HBASE-25058 Export necessary modules when running under JDK11
Apache9 merged PR #4337: URL: https://github.com/apache/hbase/pull/4337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4337: HBASE-25058 Export necessary modules when running under JDK11
Apache-HBase commented on PR #4337: URL: https://github.com/apache/hbase/pull/4337#issuecomment-1105395230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 22s | master passed | | +1 :green_heart: | compile | 5m 58s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 1s | the patch passed | | +1 :green_heart: | compile | 5m 50s | the patch passed | | -0 :warning: | javac | 5m 50s | root generated 8 new + 1465 unchanged - 8 fixed = 1473 total (was 1473) | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 0s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 39s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 33m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4337/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4337 | | Optional Tests | dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile | | uname | Linux c751b5059d06 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 13d932cba3 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4337/8/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 139 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4337/8/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-26947) Implement a special TestAppender to limit the size of test output
[ https://issues.apache.org/jira/browse/HBASE-26947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26947. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.5+. Thanks [~ndimiduk] for reviewing! > Implement a special TestAppender to limit the size of test output > - > > Key: HBASE-26947 > URL: https://issues.apache.org/jira/browse/HBASE-26947 > Project: HBase > Issue Type: Improvement > Components: logging, test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > Recently our build nodes were out of space several times. I've checked some > of them, all are because of logging in an infinite loop which makes a very > big log output. > I've already opened several issues for this, such as HBASE-26858, > HBASE-26941, HBASE-26946. > So in general, I think we should have a way to limit the total size of a log > output. So when we do something wrong in code it will not eat all the space > soon and bring down our ci. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-25326) Allow hbase-connector to be used with Apache Spark 3.0
[ https://issues.apache.org/jira/browse/HBASE-25326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525781#comment-17525781 ] Igor Bernstein commented on HBASE-25326: Hi, are there any plans to publish a release with these fixes? > Allow hbase-connector to be used with Apache Spark 3.0 > --- > > Key: HBASE-25326 > URL: https://issues.apache.org/jira/browse/HBASE-25326 > Project: HBase > Issue Type: Improvement >Reporter: Luca Canali >Assignee: Luca Canali >Priority: Minor > Fix For: hbase-connectors-1.1.0 > > > Currently hbase-spark connector only works with Spark 2.x. > Apache Spark 3.0 has been relesead in June 2020. > This addresses the changes needed to run the connector with Spark 3.0 and > also to be able to compile the connector using Spark 3.0 as a dependency. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] Apache9 merged pull request #4340: HBASE-26947 Implement a special TestAppender to limit the size of tes…
Apache9 merged PR #4340: URL: https://github.com/apache/hbase/pull/4340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4305: HBASE-26907 Update Hadoop3 versions for JEP 223 compliance
Apache-HBase commented on PR #4305: URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105336868 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 37s | master passed | | +1 :green_heart: | compile | 2m 11s | master passed | | +1 :green_heart: | shadedjars | 4m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 14s | the patch passed | | +1 :green_heart: | compile | 2m 7s | the patch passed | | +1 :green_heart: | javac | 2m 7s | the patch passed | | +1 :green_heart: | shadedjars | 4m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 13s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 244m 26s | root in the patch failed. | | | | 272m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4305 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux dbf2c523a5c1 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8d8f956099 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/testReport/ | | Max. process+thread count | 2465 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4359: HBASE-26962: Add mob info in web UI
Apache9 commented on PR #4359: URL: https://github.com/apache/hbase/pull/4359#issuecomment-1105328262 Mind taking a full size capture of the region page, so we can know what is whole page looks like? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] clarax commented on pull request #105: HBASE-24587 hbck2 command should accept one or more files containing a list of region names/table names/namespaces
clarax commented on PR #105: URL: https://github.com/apache/hbase-operator-tools/pull/105#issuecomment-1105324434 > @clarax Okay, this is looking good. Anything else you want to tweak before I commit? Not for now. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26967) FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected
Boris created HBASE-26967:
-
Summary: FilterList with FuzzyRowFilter and
SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as
expected
Key: HBASE-26967
URL: https://issues.apache.org/jira/browse/HBASE-26967
Project: HBase
Issue Type: Bug
Components: Filters
Affects Versions: 2.4.11
Reporter: Boris
I created test table with two column families:
{quote}_create 'test_table2', 'f1', 'f2'_
_put 'test_table2', '1', 'f1:col1', 'a1'_
_put 'test_table2', '1', 'f2:col2', 'a2'_
_put 'test_table2', '2', 'f1:col1', 'b1'_
_put 'test_table2', '2', 'f2:col2', 'b2'_
{quote}
code snippet below doesn't work as expected:
{quote}_{color:#0033b3}try {color}({color:#00}Table table {color}=
{color:#00}connection{color}.getTable({color:#00}TableName{color}.valueOf({color:#067d17}"test_table2"{color})))
{_
_{color:#00}Scan scan {color}= {color:#0033b3}new {color}Scan();_
_{color:#00}scan{color}.addFamily({color:#00}Bytes{color}.toBytes({color:#067d17}"f1"{color}));_
_{color:#00}scan{color}.addFamily({color:#00}Bytes{color}.toBytes({color:#067d17}"f2"{color}));_
_{color:#00}scan{color}.setFilter({color:#0033b3}new
{color}FuzzyRowFilter({color:#00}List{color}.of({color:#0033b3}new
{color}Pair<>({color:#00}Bytes{color}.toBytes({color:#067d17}"1"{color}),
{color:#0033b3}new byte{color}[] { {color:#1750eb}0x00 {color}};_
_{color:#00}System{color}.{color:#871094}out{color}.println({color:#067d17}"result
of fuzzy filter:"{color});_
_{color:#0033b3}for {color}({color:#00}Result r {color}:
{color:#00}table{color}.getScanner({color:#00}scan{color})) {_
_{color:#00}System{color}.{color:#871094}out{color}.println({color:#00}Bytes{color}.toString({color:#00}r{color}.getRow()));_
_}_
_{color:#00}System{color}.{color:#871094}out{color}.println({color:#067d17}"result
of single column value filter:"{color});_
_{color:#00}scan{color}.setFilter(_
_{color:#0033b3}new
{color}SingleColumnValueFilter({color:#00}Bytes{color}.toBytes({color:#067d17}"f2"{color}),
{color:#00}Bytes{color}.toBytes({color:#067d17}"col2"{color}),
{color:#00}CompareOperator{color}.{color:#871094}EQUAL{color},
{color:#00}Bytes{color}.toBytes({color:#067d17}"x"{color})));_
_{color:#0033b3}for {color}({color:#00}Result r {color}:
{color:#00}table{color}.getScanner({color:#00}scan{color})) {_
_{color:#00}System{color}.{color:#871094}out{color}.println({color:#00}Bytes{color}.toString({color:#00}r{color}.getRow()));_
_}_
_{color:#00}System{color}.{color:#871094}out{color}.println({color:#067d17}"result
of fuzzy or single column value filters:"{color});_
_{color:#00}FilterList filterList {color}= {color:#0033b3}new
{color}FilterList({color:#00}Operator{color}.{color:#871094}MUST_PASS_ONE{color});_
_{color:#00}filterList{color}.addFilter({color:#0033b3}new
{color}FuzzyRowFilter({color:#00}List{color}.of({color:#0033b3}new
{color}Pair<>({color:#00}Bytes{color}.toBytes({color:#067d17}"1"{color}),
{color:#0033b3}new byte{color}[] { {color:#1750eb}0x00 {color}};_
_{color:#00}filterList{color}.addFilter(_
_{color:#0033b3}new
{color}SingleColumnValueFilter({color:#00}Bytes{color}.toBytes({color:#067d17}"f2"{color}),
{color:#00}Bytes{color}.toBytes({color:#067d17}"col2"{color}),
{color:#00}CompareOperator{color}.{color:#871094}EQUAL{color},
{color:#00}Bytes{color}.toBytes({color:#067d17}"x"{color})));_
_{color:#00}scan{color}.setFilter({color:#00}filterList{color});_
_{color:#0033b3}for {color}({color:#00}Result r {color}:
{color:#00}table{color}.getScanner({color:#00}scan{color})) {_
_{color:#00}System{color}.{color:#871094}out{color}.println({color:#00}Bytes{color}.toString({color:#00}r{color}.getRow()));_
_}_
_}_
{quote}
Expected result in my opinion is:
{quote}result of fuzzy filter:
1
result of single column value filter:
result of fuzzy or single column value filters:
1
{quote}
But i got (NOT OK):
{quote}result of fuzzy filter:
1
result of single column value filter:
result of fuzzy or single column value filters:
1
2
{quote}
For tables with one column family or commentig out line
_{color:#00}scan{color}.addFamily({color:#00}Bytes{color}.toBytes({color:#067d17}"f1"{color}))_
filter list evaluation is working OK. Similar example with PrefixFilter is
working like a charm:
{quote}_{color:#0033b3}try {color}({color:#00}Table table {color}=
{color:#00}connection{color}.getTable({color:#00}TableName{color}.valueOf({color:#067d17}"test_table2"{color})))
{_
_{color:#00}Scan scan {color}= {color:#0033b3}new {color}Scan();_
_{color:#00}scan{color}.addFamily({color:#00}Bytes{color}.toBytes({color:#067d17}"f1"{color}));_
[GitHub] [hbase] Apache9 commented on a diff in pull request #4305: HBASE-26907 Update Hadoop3 versions for JEP 223 compliance
Apache9 commented on code in PR #4305:
URL: https://github.com/apache/hbase/pull/4305#discussion_r855257735
##
pom.xml:
##
@@ -3032,7 +3033,8 @@
--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED
${hbase-surefire.argLine}
-3.2.0
+
+3.2.3
Review Comment:
From my understanding in the past, the minimum version here is the minimum
supported hadoop version. And for the quick hadoop check, it is usually the
latest patch release for a minor release line.
But seems what we have in pom is usually the minimum minor release line but
the latest patch release of this minor release line... So there 3.2.3 should be
OK.
On the CVE problem, it is another story, it usually means we need to drop
the support for some patch releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4337: HBASE-25058 Export necessary modules when running under JDK11
Apache9 commented on code in PR #4337:
URL: https://github.com/apache/hbase/pull/4337#discussion_r855243274
##
pom.xml:
##
@@ -3036,7 +3036,16 @@
${releaseTarget}
---add-opens=java.base/jdk.internal.ref=ALL-UNNAMED
${hbase-surefire.argLine}
+-Dio.netty.tryReflectionSetAccessible=true
+ --illegal-access=permit
+ --add-modules jdk.unsupported
+ --add-opens java.base/java.nio=ALL-UNNAMED
+ --add-opens java.base/sun.nio.ch=ALL-UNNAMED
+ --add-opens java.base/java.lang=ALL-UNNAMED
+ --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED
Review Comment:
Ah, copy-paste error. Thanks for pointing this out.
Let me change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-26961) cache region locations when getAllRegionLocations() for branch-2.4+
[ https://issues.apache.org/jira/browse/HBASE-26961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ruanhui updated HBASE-26961: Description: backport HBASE-26942 to branch-2.4 and branch-2.5 (was: backport HBASE-26942 for branch-2.2, branch-2.3 and branch-2.4) > cache region locations when getAllRegionLocations() for branch-2.4+ > --- > > Key: HBASE-26961 > URL: https://issues.apache.org/jira/browse/HBASE-26961 > Project: HBase > Issue Type: Improvement > Components: Client >Affects Versions: 2.4.11 >Reporter: ruanhui >Assignee: ruanhui >Priority: Minor > Fix For: 2.4.12 > > > backport HBASE-26942 to branch-2.4 and branch-2.5 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HBASE-26961) cache region locations when getAllRegionLocations() for branch-2.4+
[ https://issues.apache.org/jira/browse/HBASE-26961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ruanhui updated HBASE-26961: Summary: cache region locations when getAllRegionLocations() for branch-2.4+ (was: cache region locations when getAllRegionLocations() for branch-2.2+) > cache region locations when getAllRegionLocations() for branch-2.4+ > --- > > Key: HBASE-26961 > URL: https://issues.apache.org/jira/browse/HBASE-26961 > Project: HBase > Issue Type: Improvement > Components: Client >Affects Versions: 2.4.11 >Reporter: ruanhui >Assignee: ruanhui >Priority: Minor > Fix For: 2.4.12 > > > backport HBASE-26942 for branch-2.2, branch-2.3 and branch-2.4 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-26943) HMaster page style display confusion
[ https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525739#comment-17525739 ] Yu Li commented on HBASE-26943: --- Thanks [~ndimiduk], no problem (smile). > HMaster page style display confusion > > > Key: HBASE-26943 > URL: https://issues.apache.org/jira/browse/HBASE-26943 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 3.0.0-alpha-3 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Minor > Fix For: 3.0.0-alpha-3 > > Attachments: procedure_before.png, procedure_good.png, > usertable_before.png, usertable_good.png > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4358: HBASE-26951 HMaster should exit gracefully, when stopped via hbase-daemon.sh
Apache-HBase commented on PR #4358: URL: https://github.com/apache/hbase/pull/4358#issuecomment-1105252253 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 31s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 5m 26s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 2m 1s | root in the patch failed. | | -1 :x: | compile | 0m 59s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 59s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 4m 17s | patch has 16 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 57s | hbase-server in the patch failed. | | | | 21m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4358 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 897e619028f7 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8d8f956099 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/testReport/ | | Max. process+thread count | 68 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4358: HBASE-26951 HMaster should exit gracefully, when stopped via hbase-daemon.sh
Apache-HBase commented on PR #4358: URL: https://github.com/apache/hbase/pull/4358#issuecomment-1105248800 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 53s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 25s | master passed | | +1 :green_heart: | compile | 2m 13s | master passed | | +1 :green_heart: | checkstyle | 0m 39s | master passed | | +1 :green_heart: | spotbugs | 1m 19s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 14s | root in the patch failed. | | -1 :x: | compile | 1m 19s | hbase-server in the patch failed. | | -0 :warning: | javac | 1m 19s | hbase-server in the patch failed. | | +1 :green_heart: | checkstyle | 0m 35s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 1m 28s | The patch causes 16 errors with Hadoop v3.1.2. | | -1 :x: | hadoopcheck | 2m 58s | The patch causes 16 errors with Hadoop v3.2.2. | | -1 :x: | hadoopcheck | 4m 26s | The patch causes 16 errors with Hadoop v3.3.1. | | -1 :x: | spotbugs | 0m 27s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 18m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4358 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 37f339024922 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8d8f956099 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-general-check/output/patch-javac-3.1.2.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-general-check/output/patch-javac-3.2.2.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-general-check/output/patch-javac-3.3.1.txt | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt | | Max. process+thread count | 72 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4358: HBASE-26951 HMaster should exit gracefully, when stopped via hbase-daemon.sh
Apache-HBase commented on PR #4358: URL: https://github.com/apache/hbase/pull/4358#issuecomment-1105244526 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 45s | master passed | | +1 :green_heart: | compile | 0m 45s | master passed | | +1 :green_heart: | shadedjars | 3m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 34s | root in the patch failed. | | -1 :x: | compile | 0m 43s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 43s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 2m 55s | patch has 16 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 44s | hbase-server in the patch failed. | | | | 15m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4358 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 185b2b825286 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8d8f956099 | | Default Java | AdoptOpenJDK-11.0.10+9 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/testReport/ | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4358/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26943) HMaster page style display confusion
[ https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525679#comment-17525679 ] Nick Dimiduk commented on HBASE-26943: -- Hey, no problem [~liyu], [~heliangjun]. I'm happy to help if I can. I must apologize as well because I left that comment after noticing the commit in the recent git history, but I did not go back and read through the PRs. > HMaster page style display confusion > > > Key: HBASE-26943 > URL: https://issues.apache.org/jira/browse/HBASE-26943 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 3.0.0-alpha-3 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Minor > Fix For: 3.0.0-alpha-3 > > Attachments: procedure_before.png, procedure_good.png, > usertable_before.png, usertable_good.png > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-26966) Packaging and Integration Stage can fail with BindingException
[
https://issues.apache.org/jira/browse/HBASE-26966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525676#comment-17525676
]
Nick Dimiduk commented on HBASE-26966:
--
Heya [~busbey] here's some more kindling for your interest in wrapping all this
stuff up inside of minikube or kind or whatever.
> Packaging and Integration Stage can fail with BindingException
> --
>
> Key: HBASE-26966
> URL: https://issues.apache.org/jira/browse/HBASE-26966
> Project: HBase
> Issue Type: Task
> Components: build, integration tests
>Reporter: Nick Dimiduk
>Priority: Major
>
> Following up on a failed [branch-2 nightly
> build|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/520/], I
> found an annoying bug in the Packaging and Integration stage. Launching the
> HDFS cluster used by the test failed, for a really dumb reason.
> {noformat}
> 22/04/19 19:58:59 INFO service.AbstractService: Service HistoryClientService
> failed in state STARTED; cause:
> org.apache.hadoop.yarn.exceptions.YarnRuntimeException:
> java.net.BindException: Problem binding to [jenkins-hbase3.apache.org:0]
> java.net.BindException: Cannot assign requested address; For more details
> see: http://wiki.apache.org/hadoop/BindException
> org.apache.hadoop.yarn.exceptions.YarnRuntimeException:
> java.net.BindException: Problem binding to [jenkins-hbase3.apache.org:0]
> java.net.BindException: Cannot assign requested address; For more details
> see: http://wiki.apache.org/hadoop/BindException
> at
> org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.getServer(RpcServerFactoryPBImpl.java:138)
> at
> org.apache.hadoop.yarn.ipc.HadoopYarnProtoRPC.getServer(HadoopYarnProtoRPC.java:65)
> at org.apache.hadoop.yarn.ipc.YarnRPC.getServer(YarnRPC.java:54)
> at
> org.apache.hadoop.mapreduce.v2.hs.HistoryClientService.serviceStart(HistoryClientService.java:128)
> at
> org.apache.hadoop.service.AbstractService.start(AbstractService.java:194)
> at
> org.apache.hadoop.service.CompositeService.serviceStart(CompositeService.java:121)
> at
> org.apache.hadoop.mapreduce.v2.hs.JobHistoryServer.serviceStart(JobHistoryServer.java:202)
> at
> org.apache.hadoop.service.AbstractService.start(AbstractService.java:194)
> at
> org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster$JobHistoryServerWrapper$1.run(MiniMRYarnCluster.java:236)
> Caused by: java.net.BindException: Problem binding to
> [jenkins-hbase3.apache.org:0] java.net.BindException: Cannot assign requested
> address; For more details see: http://wiki.apache.org/hadoop/BindException
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.net.NetUtils.wrapWithMessage(NetUtils.java:824)
> at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:735)
> at org.apache.hadoop.ipc.Server.bind(Server.java:615)
> at org.apache.hadoop.ipc.Server$Listener.(Server.java:1179)
> at org.apache.hadoop.ipc.Server.(Server.java:2983)
> at org.apache.hadoop.ipc.RPC$Server.(RPC.java:1003)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server.(ProtobufRpcEngine.java:425)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine.getServer(ProtobufRpcEngine.java:346)
> at org.apache.hadoop.ipc.RPC$Builder.build(RPC.java:844)
> at
> org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.createServer(RpcServerFactoryPBImpl.java:168)
> at
> org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.getServer(RpcServerFactoryPBImpl.java:131)
> ... 8 more
> Caused by: java.net.BindException: Cannot assign requested address
> at sun.nio.ch.Net.bind0(Native Method)
> at sun.nio.ch.Net.bind(Net.java:438)
> at sun.nio.ch.Net.bind(Net.java:430)
> at
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:225)
> at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
> at org.apache.hadoop.ipc.Server.bind(Server.java:598)
> ... 16 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (HBASE-26966) Packaging and Integration Stage can fail with BindingException
Nick Dimiduk created HBASE-26966:
Summary: Packaging and Integration Stage can fail with
BindingException
Key: HBASE-26966
URL: https://issues.apache.org/jira/browse/HBASE-26966
Project: HBase
Issue Type: Task
Components: build, integration tests
Reporter: Nick Dimiduk
Following up on a failed [branch-2 nightly
build|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/520/], I
found an annoying bug in the Packaging and Integration stage. Launching the
HDFS cluster used by the test failed, for a really dumb reason.
{noformat}
22/04/19 19:58:59 INFO service.AbstractService: Service HistoryClientService
failed in state STARTED; cause:
org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.net.BindException:
Problem binding to [jenkins-hbase3.apache.org:0] java.net.BindException: Cannot
assign requested address; For more details see:
http://wiki.apache.org/hadoop/BindException
org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.net.BindException:
Problem binding to [jenkins-hbase3.apache.org:0] java.net.BindException: Cannot
assign requested address; For more details see:
http://wiki.apache.org/hadoop/BindException
at
org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.getServer(RpcServerFactoryPBImpl.java:138)
at
org.apache.hadoop.yarn.ipc.HadoopYarnProtoRPC.getServer(HadoopYarnProtoRPC.java:65)
at org.apache.hadoop.yarn.ipc.YarnRPC.getServer(YarnRPC.java:54)
at
org.apache.hadoop.mapreduce.v2.hs.HistoryClientService.serviceStart(HistoryClientService.java:128)
at
org.apache.hadoop.service.AbstractService.start(AbstractService.java:194)
at
org.apache.hadoop.service.CompositeService.serviceStart(CompositeService.java:121)
at
org.apache.hadoop.mapreduce.v2.hs.JobHistoryServer.serviceStart(JobHistoryServer.java:202)
at
org.apache.hadoop.service.AbstractService.start(AbstractService.java:194)
at
org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster$JobHistoryServerWrapper$1.run(MiniMRYarnCluster.java:236)
Caused by: java.net.BindException: Problem binding to
[jenkins-hbase3.apache.org:0] java.net.BindException: Cannot assign requested
address; For more details see: http://wiki.apache.org/hadoop/BindException
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at org.apache.hadoop.net.NetUtils.wrapWithMessage(NetUtils.java:824)
at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:735)
at org.apache.hadoop.ipc.Server.bind(Server.java:615)
at org.apache.hadoop.ipc.Server$Listener.(Server.java:1179)
at org.apache.hadoop.ipc.Server.(Server.java:2983)
at org.apache.hadoop.ipc.RPC$Server.(RPC.java:1003)
at
org.apache.hadoop.ipc.ProtobufRpcEngine$Server.(ProtobufRpcEngine.java:425)
at
org.apache.hadoop.ipc.ProtobufRpcEngine.getServer(ProtobufRpcEngine.java:346)
at org.apache.hadoop.ipc.RPC$Builder.build(RPC.java:844)
at
org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.createServer(RpcServerFactoryPBImpl.java:168)
at
org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.getServer(RpcServerFactoryPBImpl.java:131)
... 8 more
Caused by: java.net.BindException: Cannot assign requested address
at sun.nio.ch.Net.bind0(Native Method)
at sun.nio.ch.Net.bind(Net.java:438)
at sun.nio.ch.Net.bind(Net.java:430)
at
sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:225)
at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
at org.apache.hadoop.ipc.Server.bind(Server.java:598)
... 16 more
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase-operator-tools] ndimiduk commented on pull request #105: HBASE-24587 hbck2 command should accept one or more files containing a list of region names/table names/namespaces
ndimiduk commented on PR #105: URL: https://github.com/apache/hbase-operator-tools/pull/105#issuecomment-1105156673 @clarax Okay, this is looking good. Anything else you want to tweak before I commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] carp84 commented on a diff in pull request #4358: HBASE-26951 HMaster should exit gracefully, when stopped via hbase-daemon.sh
carp84 commented on code in PR #4358:
URL: https://github.com/apache/hbase/pull/4358#discussion_r855109431
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java:
##
@@ -85,7 +85,7 @@ public static void install(final Configuration conf, final
FileSystem fs,
Runnable fsShutdownHook = suppressHdfsShutdownHook(fs);
Thread t = new ShutdownHookThread(conf, stop, threadToJoin,
fsShutdownHook);
ShutdownHookManager.affixShutdownHook(t, 0);
-LOG.debug("Installed shutdown hook thread: " + t.getName());
+LOG.info("Installed shutdown hook thread: " + t.getName());
Review Comment:
It seems this change is not necessary
##
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java:
##
@@ -447,6 +451,22 @@ protected final void closeZooKeeper() {
}
}
+ /**
+ * In order to register ShutdownHook, this method is called
+ * when HMaster and HRegionServer are started.
+ * For details, please refer to HBASE-26951
+ */
+ protected void intallShutdownHook() {
+ShutdownHook.install(conf, dataFs, this, Thread.currentThread());
+isInstalledShutdownHook = true;
Review Comment:
```suggestion
isShutdownHookInstalled = true;
```
##
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java:
##
@@ -447,6 +451,22 @@ protected final void closeZooKeeper() {
}
}
+ /**
+ * In order to register ShutdownHook, this method is called
+ * when HMaster and HRegionServer are started.
+ * For details, please refer to HBASE-26951
+ */
+ protected void intallShutdownHook() {
+ShutdownHook.install(conf, dataFs, this, Thread.currentThread());
+isInstalledShutdownHook = true;
+ }
+
+ @RestrictedApi(explanation = "Should only be called in tests", link = "",
+allowedOnPath = ".*/src/test/.*")
+ public boolean isInstalledShutdownHook() {
Review Comment:
```suggestion
public boolean isShutdownHookInstalled() {
```
##
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java:
##
@@ -447,6 +451,22 @@ protected final void closeZooKeeper() {
}
}
+ /**
+ * In order to register ShutdownHook, this method is called
+ * when HMaster and HRegionServer are started.
+ * For details, please refer to HBASE-26951
+ */
+ protected void intallShutdownHook() {
+ShutdownHook.install(conf, dataFs, this, Thread.currentThread());
+isInstalledShutdownHook = true;
+ }
+
+ @RestrictedApi(explanation = "Should only be called in tests", link = "",
+allowedOnPath = ".*/src/test/.*")
+ public boolean isInstalledShutdownHook() {
+return isInstalledShutdownHook;
Review Comment:
```suggestion
return isShutdownHookInstalled;
```
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java:
##
@@ -305,5 +305,10 @@ public void testBlockingHbkc1WithLockFile() throws
IOException {
// Assert lock gets put in place again.
assertTrue(fs.exists(hbckLockPath));
}
-}
+ @Test
+ public void testInstallShutdownHook() throws IOException {
+// Test for HBASE-26951
+
assertTrue(TEST_UTIL.getHBaseCluster().getMaster().isInstalledShutdownHook());
Review Comment:
```suggestion
assertTrue(TEST_UTIL.getHBaseCluster().getMaster().isShutdownHookInstalled());
```
##
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java:
##
@@ -91,6 +92,9 @@
// of HRegionServer in isolation.
protected volatile boolean stopped = false;
+ // Only test for HBASE-26951
+ private boolean isInstalledShutdownHook = false;
Review Comment:
```suggestion
// Only for testing
private boolean isShutdownHookInstalled = false;
```
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServer.java:
##
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import static org.junit.Assert.assertTrue;
+import java.io.IOException;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import
[GitHub] [hbase] ndimiduk commented on a diff in pull request #4337: HBASE-25058 Export necessary modules when running under JDK11
ndimiduk commented on code in PR #4337:
URL: https://github.com/apache/hbase/pull/4337#discussion_r855116476
##
pom.xml:
##
@@ -3036,7 +3036,16 @@
${releaseTarget}
---add-opens=java.base/jdk.internal.ref=ALL-UNNAMED
${hbase-surefire.argLine}
+-Dio.netty.tryReflectionSetAccessible=true
+ --illegal-access=permit
+ --add-modules jdk.unsupported
+ --add-opens java.base/java.nio=ALL-UNNAMED
+ --add-opens java.base/sun.nio.ch=ALL-UNNAMED
+ --add-opens java.base/java.lang=ALL-UNNAMED
+ --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED
Review Comment:
This one `add-opens` line uses an `=` to specify its argument, the rest
don't. Mine making them all uniform? Same thing in `bin/hbase`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-26943) HMaster page style display confusion
[ https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525659#comment-17525659 ] LiangJun He commented on HBASE-26943: - Thanks for your reminder [~ndimiduk] , I will revert and see how to fix this problem. > HMaster page style display confusion > > > Key: HBASE-26943 > URL: https://issues.apache.org/jira/browse/HBASE-26943 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 3.0.0-alpha-3 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Minor > Fix For: 3.0.0-alpha-3 > > Attachments: procedure_before.png, procedure_good.png, > usertable_before.png, usertable_good.png > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-26938) Compaction failures after StoreFileTracker integration
[
https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525655#comment-17525655
]
Nick Dimiduk commented on HBASE-26938:
--
bq. I see that CompactionProgress is also shared via volatile field progress.
This inappropriate sharing of a single Compactor per store over multiple
threads via class fields is also behind the JIRAs we have open for weird
compaction progress reporting. /cc Nick Dimiduk Let me fix that too.
Excellent! Thanks for digging in here.
> Compaction failures after StoreFileTracker integration
> --
>
> Key: HBASE-26938
> URL: https://issues.apache.org/jira/browse/HBASE-26938
> Project: HBase
> Issue Type: Bug
> Components: Compaction
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Andrew Kyle Purtell
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> [ Currently this has only been tested with branch-2.5 and branch-2. Testing
> with master next, will update afterward. ]
> Test cluster of 10 regionservers is configured each RS with 5 flush threads,
> 5 large compaction threads, and 10 small compaction threads.
> Hadoop is 3.3.2. Java is 11. HFiles are on HDFS.
> All the StoreFileTracker implementations, DEFAULT or FILE, exhibit compaction
> time store writer errors in an ingest heavy use case. Unit tests don't seem
> to cover whatever this is. Most compactions succeed, but some do not. Those
> that do not are failing with state or sanity check assertions. Below errors
> are all from DEFAULT. They seem related... store writer instance
> usage/close/locking issues during compactions.
> Warnings like "writer exists when it should not":
> {noformat}
> 2022-04-07T23:13:11,351 WARN
> [regionserver/ip-172-31-63-83:8120-shortCompactions-8]
> compactions.Compactor: Writer exists when it should not: {
>
> hdfs://ip-172-31-58-47.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestLoadCommonCrawl/b518f72941d4427e7e1923407643df67/.tmp/c/29d7b88c4c214ddcbba4f747514a2cf5
> }
> {noformat}
> Errors like:
> IllegalStateException thrown from
> HFileBlockIndex$BlockIndexWriter.shouldWriteBlock:
> {noformat}
> 2022-04-07T23:13:11,508 ERROR
> [regionserver/ip-172-31-63-83:8120-shortCompactions-6]
> regionserver.CompactSplit: Compaction failed
> region=IntegrationTestLoadCommonCrawl,,1649373172576.b518f72941d4427e7e1923407643df67.,
> storeName=b518f72941d4427e7e1923407643df67/c, priority=10,
> startTime=1649373185476
> java.lang.IllegalStateException: curInlineChunk is null; has shouldWriteBlock
> been called with closing=true and then called again?
> at
> org.apache.hadoop.hbase.io.hfile.HFileBlockIndex$BlockIndexWriter.shouldWriteBlock(HFileBlockIndex.java:1258)
> ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
> at
> org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.writeInlineBlocks(HFileWriterImpl.java:523)
> ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
> at
> org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.close(HFileWriterImpl.java:608)
> ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
> at
> org.apache.hadoop.hbase.regionserver.StoreFileWriter.close(StoreFileWriter.java:377)
> ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
> at
> org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.abortWriter(DefaultCompactor.java:84)
> ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
> at
> org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.abortWriter(DefaultCompactor.java:76)
> ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
> at
> org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:384)
> ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
> at
> org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:62)
> ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
> at
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:125)
> ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
> {noformat}
> and IllegalStateException thrown from HFileBlock$Writer.expectState:
> {noformat}
> 2022-04-07T23:13:11,559 ERROR
> [regionserver/ip-172-31-63-83:8120-shortCompactions-8]
> regionserver.CompactSplit: Compaction failed
> region=IntegrationTestLoadCommonCrawl,,1649373172576.b518f72941d4427e7e1923407643df67.,
> storeName=b518f72941d4427e7e1923407643df67/c, priority=0,
> startTime=1649373191325
> java.lang.IllegalStateException: Expected state: BLOCK_READY, actual state:
> WRITING
> at
> org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.expectState(HFileBlock.java:1190)
>
[jira] [Reopened] (HBASE-26943) HMaster page style display confusion
[ https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li reopened HBASE-26943: --- Thanks for chiming in [~ndimiduk]. The original change for this JIRA was exactly editing the css definitions inline in the html, it's me that asked [~heliangjun] to do the formatting. Sorry but I was lack of the knowledge for minimized resource, while one thing I cared about was whether the change is easy to track (changes in the one-liner way seems pretty hard to tell). About the commit format, since the changes are separated into two commits, only one of them (242a194b3c) matches the summary (title) of the JIRA while the other (d0318732b7) doesn't. Would you mind teach me the correct way? Only one commit is allowed for one JIRA and the commit message must match the title of the JIRA? I haven't been merging commits for a while so there might be some rules I forgot or some new ones that I don't know, and I'd love to (re)learn and follow up. Thanks. I've reopened the issue for further discussion, and will revert and re-commit the changes once required updates done and get [~ndimiduk]'s +1. > HMaster page style display confusion > > > Key: HBASE-26943 > URL: https://issues.apache.org/jira/browse/HBASE-26943 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 3.0.0-alpha-3 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Minor > Fix For: 3.0.0-alpha-3 > > Attachments: procedure_before.png, procedure_good.png, > usertable_before.png, usertable_good.png > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4305: HBASE-26907 Update Hadoop3 versions for JEP 223 compliance
Apache-HBase commented on PR #4305: URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105070192 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 41s | master passed | | +1 :green_heart: | compile | 6m 55s | master passed | | +0 :ok: | refguide | 2m 0s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 29s | the patch passed | | +1 :green_heart: | compile | 6m 50s | the patch passed | | +1 :green_heart: | javac | 6m 50s | the patch passed | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 1m 52s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 12m 53s | Patch does not cause any errors with Hadoop 3.1.4 3.2.3 3.3.2. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 45m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4305 | | Optional Tests | dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile refguide | | uname | Linux a7b721e95225 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8d8f956099 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4305/3/yetus-general-check/output/branch-site/book.html | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4305/3/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 138 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26960) Another case for unnecessary replication suspending in RegionReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-26960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-26960:
-
Status: Patch Available (was: Open)
> Another case for unnecessary replication suspending in RegionReplicationSink
>
>
> Key: HBASE-26960
> URL: https://issues.apache.org/jira/browse/HBASE-26960
> Project: HBase
> Issue Type: Bug
> Components: read replicas
>Affects Versions: 3.0.0-alpha-2
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
>
> Besides HBASE-26768, there is another case replication in
> {{RegionReplicationSink}} would be suspend:
> For {{RegionReplicationSink}}, when there is a replication error ,
> {{RegionReplicationSink}} invokes {{MemStoreFlusher#requestFlush}} to request
> a flush, and after receiving the {{FlushAction#START_FLUSH}} or
> {{FlushAction#CANNOT_FLUSH}} flush marker, it would resume the replication.
> But when {{MemStoreFlusher}} flushing, it invokes following method
> {{HRegion.flushcache}} with the {{writeFlushRequestWalMarker}} set to false:
> {code:java}
> public FlushResultImpl flushcache(List families,
> boolean writeFlushRequestWalMarker, FlushLifeCycleTracker tracker)
> throws IOException {
> }
> {code}
> When {{writeFlushRequestWalMarker}} is set to false, {{HRegion.flushcache}}
> does not write the {{FlushAction#CANNOT_FLUSH}} flush marker to {{WAL}} when
> the memstore is empty, just as following
> {{HRegion.writeFlushRequestMarkerToWAL}} illustrated:
> {code:java}
> private boolean writeFlushRequestMarkerToWAL(WAL wal, boolean
> writeFlushWalMarker) {
> if (writeFlushWalMarker && wal != null && !writestate.readOnly) {
> FlushDescriptor desc =
> ProtobufUtil.toFlushDescriptor(FlushAction.CANNOT_FLUSH,
> getRegionInfo(), -1, new TreeMap<>(Bytes.BYTES_COMPARATOR));
> try {
> WALUtil.writeFlushMarker(wal, this.getReplicationScope(),
> getRegionInfo(), desc, true, mvcc,
> regionReplicationSink.orElse(null));
> return true;
> } catch (IOException e) {
> LOG.warn(getRegionInfo().getEncodedName() + " : " +
> "Received exception while trying to write the flush request to
> wal", e);
> }
> }
> return false;
> }
> {code}
> so when there is a replication error when the memstore is empty(eg.
> replicating the {{FlushAction#START_FLUSH}} or {{FlushAction#COMMIT_FLUSH}}
> ), the replication may suspend until next memstore flush,even though later
> there are user writes and it could replicate normally.
> I simulate this problem in the PR , and for {{writeFlushRequestWalMarker}}
> paramter, it is introduced by HBASE-11580 and just only determines whether or
> not writing the {{FlushAction#CANNOT_FLUSH}} flush marker to WAL when the
> memstore is empty, so I think for simplicity, we could set it to true always
> for {{MemStoreFlusher}}.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (HBASE-26960) Another case for unnecessary replication suspending in RegionReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-26960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-26960:
-
Description:
Besides HBASE-26768, there is another case replication in
{{RegionReplicationSink}} would be suspend:
For {{RegionReplicationSink}}, when there is a replication error ,
{{RegionReplicationSink}} invokes {{MemStoreFlusher#requestFlush}} to request a
flush, and after receiving the {{FlushAction#START_FLUSH}} or
{{FlushAction#CANNOT_FLUSH}} flush marker, it would resume the replication. But
when {{MemStoreFlusher}} flushing, it invokes following method
{{HRegion.flushcache}} with the {{writeFlushRequestWalMarker}} set to false:
{code:java}
public FlushResultImpl flushcache(List families,
boolean writeFlushRequestWalMarker, FlushLifeCycleTracker tracker) throws
IOException {
}
{code}
When {{writeFlushRequestWalMarker}} is set to false, {{HRegion.flushcache}}
does not write the {{FlushAction#CANNOT_FLUSH}} flush marker to {{WAL}} when
the memstore is empty, just as following
{{HRegion.writeFlushRequestMarkerToWAL}} illustrated:
{code:java}
private boolean writeFlushRequestMarkerToWAL(WAL wal, boolean
writeFlushWalMarker) {
if (writeFlushWalMarker && wal != null && !writestate.readOnly) {
FlushDescriptor desc =
ProtobufUtil.toFlushDescriptor(FlushAction.CANNOT_FLUSH,
getRegionInfo(), -1, new TreeMap<>(Bytes.BYTES_COMPARATOR));
try {
WALUtil.writeFlushMarker(wal, this.getReplicationScope(),
getRegionInfo(), desc, true, mvcc,
regionReplicationSink.orElse(null));
return true;
} catch (IOException e) {
LOG.warn(getRegionInfo().getEncodedName() + " : " +
"Received exception while trying to write the flush request to wal",
e);
}
}
return false;
}
{code}
so when there is a replication error when the memstore is empty(eg. replicating
the {{FlushAction#START_FLUSH}} or {{FlushAction#COMMIT_FLUSH}} ), the
replication may suspend until next memstore flush,even though later there are
user writes and it could replicate normally.
I simulate this problem in the PR , and for {{writeFlushRequestWalMarker}}
paramter, it is introduced by HBASE-11580 and just only determines whether or
not writing the {{FlushAction#CANNOT_FLUSH}} flush marker to WAL when the
memstore is empty, so I think for simplicity, we could set it to true always
for {{MemStoreFlusher}}.
was:
Besides HBASE-26768, there is another case replication in
{{RegionReplicationSink}} would be suspend:
For {{RegionReplicationSink}}, when there is a replication error ,
{{RegionReplicationSink}} invokes {{MemStoreFlusher#requestFlush}} to request a
flush, and after receiving the {{FlushAction#START_FLUSH}} or
{{FlushAction#CANNOT_FLUSH}} flush marker, it would resume the replication. But
when {{MemStoreFlusher}} flushing, it invokes following method
{{HRegion.flushcache}} with the {{writeFlushRequestWalMarker}} set to false:
{code:java}
public FlushResultImpl flushcache(List families,
boolean writeFlushRequestWalMarker, FlushLifeCycleTracker tracker) throws
IOException {
}
{code}
When {{writeFlushRequestWalMarker}} is set to false, {{HRegion.flushcache}}
does not write the {{FlushAction#CANNOT_FLUSH}} flush marker to {{WAL}} when
the memstore is empty, so when there is a replication error when the memstore
is empty(eg. replicating the {{FlushAction#START_FLUSH}} or
{{FlushAction#COMMIT_FLUSH}} ), the replication may suspend until next memstore
flush,even though later there are user writes and it could replicate normally.
I simulate this problem in the PR , and for {{writeFlushRequestWalMarker}}
paramter, it is introduced by HBASE-11580 and just only determines whether or
not writing the {{FlushAction#CANNOT_FLUSH}} flush marker to WAL when the
memstore is empty, so I think for simplicity, we could set it to true always
for {{MemStoreFlusher}}.
> Another case for unnecessary replication suspending in RegionReplicationSink
>
>
> Key: HBASE-26960
> URL: https://issues.apache.org/jira/browse/HBASE-26960
> Project: HBase
> Issue Type: Bug
> Components: read replicas
>Affects Versions: 3.0.0-alpha-2
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
>
> Besides HBASE-26768, there is another case replication in
> {{RegionReplicationSink}} would be suspend:
> For {{RegionReplicationSink}}, when there is a replication error ,
> {{RegionReplicationSink}} invokes {{MemStoreFlusher#requestFlush}} to request
> a flush, and after receiving the {{FlushAction#START_FLUSH}} or
> {{FlushAction#CANNOT_FLUSH}} flush marker, it would resume the replication.
> But when {{MemStoreFlusher}} flushing, it invokes following method
>
[GitHub] [hbase] Apache-HBase commented on pull request #4305: HBASE-26907 Update Hadoop3 versions for JEP 223 compliance
Apache-HBase commented on PR #4305: URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105026859 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4305: HBASE-26907 Update Hadoop3 versions for JEP 223 compliance
Apache-HBase commented on PR #4305: URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105026760 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4305: HBASE-26907 Update Hadoop3 versions for JEP 223 compliance
Apache-HBase commented on PR #4305: URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105026469 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4305/3/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26965) Replace fully qualified class names with import statements where possible
[ https://issues.apache.org/jira/browse/HBASE-26965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525610#comment-17525610 ] Duo Zhang commented on HBASE-26965: --- For some logging related tests, I used this trick to use the log4j2 related classes, FYI. > Replace fully qualified class names with import statements where possible > - > > Key: HBASE-26965 > URL: https://issues.apache.org/jira/browse/HBASE-26965 > Project: HBase > Issue Type: Task >Reporter: Nick Dimiduk >Priority: Major > > Over on HBASE-26954, it was noticed that our enforcer check missed a class. > Turns out, the restrict-imports enforcer-rule only works on import > statements. Let's take a pass for fully qualified classes uses outside of > import statements and see if we can reduce their number, so as to avoid this > type of mistake in the future. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] ndimiduk commented on pull request #4305: HBASE-26907 Update Hadoop3 versions for JEP 223 compliance
ndimiduk commented on PR #4305: URL: https://github.com/apache/hbase/pull/4305#issuecomment-1105014084 HBASE-26954 is fixed, so reverted that commit from the changeset. Let's see how it does (should be fine). Do you have further concerns, @Apache9 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26943) HMaster page style display confusion
[ https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525607#comment-17525607 ] Nick Dimiduk commented on HBASE-26943: -- Heya [~heliangjun]. The visual improvement from your screenshots is a nice one, thank you for picking this up. However, I have a couple concerns. # The minimized bootstrap file comes directly from the upstream distribution, which means that when we upgrade bootstrap in the future, we will lose your change. # The minimized file is minimized, including removal of whitespace, so as to reduce its size over the wire. Adding formatting defeats the purpose of a minimized resource. # The title of the commit that was merged does not match the summary of this JIRA. This is in breach of our community standards. Please reopen this issue, reverting the change as committed, and address my above concerns. I think a proper fix to this bug is to add your modified CSS to some other css file later in the cascade. That may mean that you need to add a new css file or edit the css definitions inline in the html, I'm not exactly sure. When you do so, please ensure that the commit format matches our community guidelines. Also, this is a nice visual fix, so please provide back-port PRs for all of our active release lines: master, branch-2, branch-2.5, and branch-2.4. Thanks a lot for taking this one! > HMaster page style display confusion > > > Key: HBASE-26943 > URL: https://issues.apache.org/jira/browse/HBASE-26943 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 3.0.0-alpha-3 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Minor > Fix For: 3.0.0-alpha-3 > > Attachments: procedure_before.png, procedure_good.png, > usertable_before.png, usertable_good.png > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HBASE-26954) Compilation of master vs hadoop-3.3.2 fails
[
https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26954:
-
Fix Version/s: 3.0.0-alpha-3
> Compilation of master vs hadoop-3.3.2 fails
> ---
>
> Key: HBASE-26954
> URL: https://issues.apache.org/jira/browse/HBASE-26954
> Project: HBase
> Issue Type: Task
> Components: build, hadoop3
>Affects Versions: 3.0.0-alpha-2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> We noticed over on HBASE-26907 while adding Hadoop 3.3.2 to our nightly build
> matrix that we get a compilation failure when setting this as the
> hadoop.three version.
> {noformat}
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4305/yetus-general-check/src/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java:[832,29]
> package org.apache.htrace.core does not exist
> [INFO] 1 error
> [INFO] -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (HBASE-26954) Compilation of master vs hadoop-3.3.2 fails
[
https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26954:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Compilation of master vs hadoop-3.3.2 fails
> ---
>
> Key: HBASE-26954
> URL: https://issues.apache.org/jira/browse/HBASE-26954
> Project: HBase
> Issue Type: Task
> Components: build, hadoop3
>Affects Versions: 3.0.0-alpha-2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> We noticed over on HBASE-26907 while adding Hadoop 3.3.2 to our nightly build
> matrix that we get a compilation failure when setting this as the
> hadoop.three version.
> {noformat}
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4305/yetus-general-check/src/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java:[832,29]
> package org.apache.htrace.core does not exist
> [INFO] 1 error
> [INFO] -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] ndimiduk merged pull request #4363: HBASE-26954 Compilation of master vs hadoop-3.3.2 fails
ndimiduk merged PR #4363: URL: https://github.com/apache/hbase/pull/4363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #4363: HBASE-26954 Compilation of master vs hadoop-3.3.2 fails
ndimiduk commented on PR #4363: URL: https://github.com/apache/hbase/pull/4363#issuecomment-1104984360 I filed HBASE-26965 for the follow-up to avoid this in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26965) Replace fully qualified class names with import statements where possible
Nick Dimiduk created HBASE-26965: Summary: Replace fully qualified class names with import statements where possible Key: HBASE-26965 URL: https://issues.apache.org/jira/browse/HBASE-26965 Project: HBase Issue Type: Task Reporter: Nick Dimiduk Over on HBASE-26954, it was noticed that our enforcer check missed a class. Turns out, the restrict-imports enforcer-rule only works on import statements. Let's take a pass for fully qualified classes uses outside of import statements and see if we can reduce their number, so as to avoid this type of mistake in the future. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4363: HBASE-26954 Compilation of master vs hadoop-3.3.2 fails
Apache-HBase commented on PR #4363: URL: https://github.com/apache/hbase/pull/4363#issuecomment-1104970626 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 41s | master passed | | +1 :green_heart: | compile | 0m 20s | master passed | | +1 :green_heart: | shadedjars | 3m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 38s | the patch passed | | +1 :green_heart: | compile | 0m 19s | the patch passed | | +1 :green_heart: | javac | 0m 19s | the patch passed | | +1 :green_heart: | shadedjars | 3m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 13m 25s | hbase-mapreduce in the patch passed. | | | | 31m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4363/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4363 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 16bc17c91555 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 35aa57e445 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4363/1/testReport/ | | Max. process+thread count | 2817 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4363/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4363: HBASE-26954 Compilation of master vs hadoop-3.3.2 fails
Apache-HBase commented on PR #4363: URL: https://github.com/apache/hbase/pull/4363#issuecomment-1104966350 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 28s | master passed | | +1 :green_heart: | compile | 0m 18s | master passed | | +1 :green_heart: | shadedjars | 3m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 16s | the patch passed | | +1 :green_heart: | compile | 0m 18s | the patch passed | | +1 :green_heart: | javac | 0m 18s | the patch passed | | +1 :green_heart: | shadedjars | 3m 40s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 13m 17s | hbase-mapreduce in the patch passed. | | | | 28m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4363/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4363 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4379ae10758f 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 35aa57e445 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4363/1/testReport/ | | Max. process+thread count | 2661 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4363/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4363: HBASE-26954 Compilation of master vs hadoop-3.3.2 fails
Apache-HBase commented on PR #4363: URL: https://github.com/apache/hbase/pull/4363#issuecomment-1104964531 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 23s | master passed | | +1 :green_heart: | compile | 0m 33s | master passed | | +1 :green_heart: | checkstyle | 0m 14s | master passed | | +1 :green_heart: | spotbugs | 0m 30s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | +1 :green_heart: | javac | 0m 30s | the patch passed | | +1 :green_heart: | checkstyle | 0m 13s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 28s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 0m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 26m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4363/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4363 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 442afa09407a 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 35aa57e445 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 65 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4363/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26954) Compilation of master vs hadoop-3.3.2 fails
[
https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26954:
-
Status: Patch Available (was: In Progress)
> Compilation of master vs hadoop-3.3.2 fails
> ---
>
> Key: HBASE-26954
> URL: https://issues.apache.org/jira/browse/HBASE-26954
> Project: HBase
> Issue Type: Task
> Components: build, hadoop3
>Affects Versions: 3.0.0-alpha-2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
>
> We noticed over on HBASE-26907 while adding Hadoop 3.3.2 to our nightly build
> matrix that we get a compilation failure when setting this as the
> hadoop.three version.
> {noformat}
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4305/yetus-general-check/src/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java:[832,29]
> package org.apache.htrace.core does not exist
> [INFO] 1 error
> [INFO] -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] ndimiduk opened a new pull request, #4363: HBASE-26954 Compilation of master vs hadoop-3.3.2 fails
ndimiduk opened a new pull request, #4363: URL: https://github.com/apache/hbase/pull/4363 I think this reference to HTrace was simply missed in early changes. It happens to have not been noticed because earlier versions of Hadoop provide an HTrace jar in the dependency set. Our import ban didn't catch this because we don't import the HTrace class, we refer to it via fully qualified class name. The restrict-imports enforcer-rule appears to work only on import statements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-26954) Compilation of master vs hadoop-3.3.2 fails
[
https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk reassigned HBASE-26954:
Assignee: Nick Dimiduk
> Compilation of master vs hadoop-3.3.2 fails
> ---
>
> Key: HBASE-26954
> URL: https://issues.apache.org/jira/browse/HBASE-26954
> Project: HBase
> Issue Type: Task
> Components: build, hadoop3
>Affects Versions: 3.0.0-alpha-2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
>
> We noticed over on HBASE-26907 while adding Hadoop 3.3.2 to our nightly build
> matrix that we get a compilation failure when setting this as the
> hadoop.three version.
> {noformat}
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4305/yetus-general-check/src/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java:[832,29]
> package org.apache.htrace.core does not exist
> [INFO] 1 error
> [INFO] -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work started] (HBASE-26954) Compilation of master vs hadoop-3.3.2 fails
[
https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-26954 started by Nick Dimiduk.
> Compilation of master vs hadoop-3.3.2 fails
> ---
>
> Key: HBASE-26954
> URL: https://issues.apache.org/jira/browse/HBASE-26954
> Project: HBase
> Issue Type: Task
> Components: build, hadoop3
>Affects Versions: 3.0.0-alpha-2
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
>
> We noticed over on HBASE-26907 while adding Hadoop 3.3.2 to our nightly build
> matrix that we get a compilation failure when setting this as the
> hadoop.three version.
> {noformat}
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
> /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4305/yetus-general-check/src/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java:[832,29]
> package org.apache.htrace.core does not exist
> [INFO] 1 error
> [INFO] -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] comnetwork commented on pull request #4355: HBASE-26960 Another case for unnecessary replication suspending in Re…
comnetwork commented on PR #4355: URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104906271 @Apache9, thank you very much , ok, I think we could also add a MVCC entry to maintain the MVCC order to invoke the `RegionReplicationSink.add`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4355: HBASE-26960 Another case for unnecessary replication suspending in Re…
Apache9 commented on PR #4355: URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104895102 OK, checked the code again, the problem here is that, if we do not write WAL, then we will not have a MVCC.WriteEntry then we can not use WriteEntry.attachCompletionAction trick. This is a problem. Let me think if there is a way to fix this. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4355: HBASE-26960 Another case for unnecessary replication suspending in Re…
Apache9 commented on PR #4355:
URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104879841
> @Apache9 , `RegionReplicationSink.add` is invoked by
`MultiVersionConcurrencyControl.complete(WriteEntry)`, so it seems not very
elegant and somewhat tricky to not write WAL but still invoke
`RegionReplicationSink.add`.
>
> I think we could add an overload `MemStoreFlusher.requestFlush` to accept
the `writeFlushRequestWalMarker` paramter，just some modifications for
{{MemStoreFlusher}}, I think seems it is more suitable than doing some trick to
not write WAL but still invoke `RegionReplicationSink.add`?
I think it is OK to not write the WAL but still add it to
RegionReplicationSink.
A problem for the old implementation of region replication is that, if users
use SKIP_WAL, then we can not do region replication any more. WIth the current
approach, since we do not need to read WAL from the file, it is OK for us to
send out WAL even if we do not want to write the WAL to file.
This one could a start. Later we could also try to see if the actual data
WAL can be replicated when SKIP_WAL is used.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] comnetwork commented on pull request #4355: HBASE-26960 Another case for unnecessary replication suspending in Re…
comnetwork commented on PR #4355:
URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104874108
@Apache9 , `RegionReplicationSink.add` is invoked by
`MultiVersionConcurrencyControl.complete(WriteEntry)`, so it seems not very
elegant and somewhat tricky to not write WAL but still invoke
`RegionReplicationSink.add`.
I think we could add an overload `MemStoreFlusher.requestFlush` to accept
the `writeFlushRequestWalMarker` paramter，just some modifications for
{{MemStoreFlusher}}, I think seems it is more suitable than doing some trick to
not write WAL but still invoke `RegionReplicationSink.add`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4355: HBASE-26960 Another case for unnecessary replication suspending in Re…
Apache9 commented on PR #4355: URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104779728 This will cause we write extra data in WAL. Maybe a more lightweight solution is to call RegionReplicationSink.add even when writeFlushWalMarker is false? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4360: HBASE-26932 Skip generating ref guide when running 'mvn site' on bran…
Apache-HBase commented on PR #4360: URL: https://github.com/apache/hbase/pull/4360#issuecomment-1104767746 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 1m 59s | branch-2 passed | | +1 :green_heart: | compile | 1m 24s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 27s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 0s | the patch passed | | +1 :green_heart: | compile | 1m 24s | the patch passed | | +1 :green_heart: | javac | 1m 24s | the patch passed | | +1 :green_heart: | shadedjars | 3m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 336m 18s | root in the patch passed. | | | | 356m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4360/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4360 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 84181df47fa1 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / a81b369157 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4360/2/testReport/ | | Max. process+thread count | 4660 (vs. ulimit of 12500) | | modules | C: hbase-archetypes/hbase-archetype-builder . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4360/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
