subject:"\[jira\] \[Commented\] \(HBASE\-13262\) ResultScanner doesn't return all rows in Scan"


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385532#comment-14385532
 ] 

Josh Elser commented on HBASE-13262:


bq. Can we redo the server side size scanner size limit? I assume this can 
still go wrong.

You mean have the server adhere to the limit set in the {{Scan}}? Best as I can 
tell, the server does look at the size set on the scan. Perhaps I misunderstood 
your question though.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, 
 HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, 
 HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385533#comment-14385533
 ] 

Josh Elser commented on HBASE-13262:


Not at problem, glad we got this in.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, 
 HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, 
 HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-28 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385552#comment-14385552
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12708007/HBASE-13262-0.98-v7.patch
  against 0.98 branch at commit 0967c6af29ba0546a167583535659a0c13de45b3.
  ATTACHMENT ID: 12708007

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
24 warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13479//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13479//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13479//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13479//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13479//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, 
 HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, 
 HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-28 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385535#comment-14385535
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12708004/HBASE-13262-branch-1.0-v7.patch
  against branch-1.0 branch at commit 0967c6af29ba0546a167583535659a0c13de45b3.
  ATTACHMENT ID: 12708004

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 8 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
3759 checkstyle errors (more than the master's current 3758 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

 {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s):   
at 
org.apache.camel.component.quartz2.SpringQuartzConsumerTwoAppsClusteredRecoveryTest.testQuartzPersistentStoreClusteredApp(SpringQuartzConsumerTwoAppsClusteredRecoveryTest.java:64)
at 
org.apache.camel.component.jpa.JpaWithNamedQueryTest.testProducerInsertsIntoDatabaseThenConsumerFiresMessageExchange(JpaWithNamedQueryTest.java:112)
at 
org.apache.camel.component.jpa.JpaWithNamedQueryTest.testProducerInsertsIntoDatabaseThenConsumerFiresMessageExchange(JpaWithNamedQueryTest.java:112)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13477//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13477//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13477//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13477//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, 
 HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, 
 HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-28 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385618#comment-14385618
 ] 

Hudson commented on HBASE-13262:


FAILURE: Integrated in HBase-1.0 #836 (See 
[https://builds.apache.org/job/HBase-1.0/836/])
HBASE-13262 Observe ScanResponse.moreResults in ClientScanner. (apurtell: rev 
20189c258cbcf109de10f76f06c059681e438615)
* 
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallReversedScanner.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSizeFailures.java
* hbase-protocol/src/main/protobuf/Client.proto
* 
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java


 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, 
 HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, 
 HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-28 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385625#comment-14385625
 ] 

Hudson commented on HBASE-13262:


FAILURE: Integrated in HBase-1.1 #336 (See 
[https://builds.apache.org/job/HBase-1.1/336/])
HBASE-13262 Observe ScanResponse.moreResults in ClientScanner. (apurtell: rev 
b0116398ffa6aec57d42739df40e22dc4edaaa0f)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSizeFailures.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* 
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java
* hbase-protocol/src/main/protobuf/Client.proto
* 
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallReversedScanner.java


 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, 
 HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, 
 HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-28 Thread Lars Hofhansl (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385601#comment-14385601
 ] 

Lars Hofhansl commented on HBASE-13262:
---

Sorry wasn't clear. The max result size setting is available on the client only 
for 1.1 and up, right?
I was wondering whether we can just turn on that setting on the server again 
for 0.98 and 1.0. But it would still be an issue with an old client that does 
not have this fix.
So my next thought: Add the max size to 0.98 and 1.0 and remove the server side 
limit there. Then default the client size limit to 2mb.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, 
 HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, 
 HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-28 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385631#comment-14385631
 ] 

Hudson commented on HBASE-13262:


SUCCESS: Integrated in HBase-TRUNK #6319 (See 
[https://builds.apache.org/job/HBase-TRUNK/6319/])
HBASE-13262 Observe ScanResponse.moreResults in ClientScanner. (apurtell: rev 
ced0e324a190e75d8a93b8b09676781853819361)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSizeFailures.java
* 
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallReversedScanner.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientSmallScanner.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
* hbase-protocol/src/main/protobuf/Client.proto
* 
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java


 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, 
 HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, 
 HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385612#comment-14385612
 ] 

Josh Elser commented on HBASE-13262:


Thanks, Andrew! Your legwork is much appreciated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, 
 HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, 
 HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-28 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385512#comment-14385512
 ] 

Andrew Purtell commented on HBASE-13262:


Great, thanks. Working on commits now. (Checking out locally first.)

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-0.98-v7.patch, 
 HBASE-13262-branch-1-v2.patch, HBASE-13262-branch-1-v3.patch, 
 HBASE-13262-branch-1.0-v7.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-28 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385377#comment-14385377
 ] 

Andrew Purtell commented on HBASE-13262:


There's no rule. Personally, I will try to backport if no branch patches are 
provided if its clear how to resolve the conflicts and I'm confident of what I 
am doing. In this case, git is giving me large conflict sections. In order to 
port, I'd have to look at the master patch and replay it onto branch by hand. 
Better let the person(s) deeply engaged in the original work do that. 

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385370#comment-14385370
 ] 

Josh Elser commented on HBASE-13262:


The last time I had a patch targeted for multiple branches, I was told the 
committer would take care of the backporting. Your comment tells me otherwise. 
I'll get you some patches for branch-1.0 and 0.98.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-27 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384959#comment-14384959
 ] 

Andrew Purtell commented on HBASE-13262:


Any last thoughts or updates?

Let's get this in so we can start releases on Monday with this included, e.g. 
0.98.12. I will probably commit this in a couple of hours to let Jenkins chew 
on the results over the weekend. 



 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-27 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385147#comment-14385147
 ] 

Andrew Purtell commented on HBASE-13262:


Unfortunately this isn't ready yet. This issue has fix versions for master, 
branch-1, branch-1.0, and 0.98. I was able to port back the v7 patch for master 
to branch-1 pretty easily but not so to branch-1.0. I stopped there and didn't 
even attempt 0.98. We can commit this to branch-1 and master only or wait for 
all necessary patches first. I'd rather commit everywhere at once if fixes for 
all targeted branches are forthcoming. 

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-26 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383244#comment-14383244
 ] 

Ted Yu commented on HBASE-13262:


+1 on patch v7.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-26 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383242#comment-14383242
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12707651/HBASE-13262-v7.patch
  against master branch at commit 18256fc9544866fc7182dfc5dd9d73b8cef02d66.
  ATTACHMENT ID: 12707651

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 8 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13455//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13455//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13455//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13455//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-26 Thread Sean Busbey (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383248#comment-14383248
 ] 

Sean Busbey commented on HBASE-13262:
-

perfectly reasonable. I was only checking so I would know what to look for when 
reviewing.

I updated the targets to include branch-1.0.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383241#comment-14383241
 ] 

Josh Elser commented on HBASE-13262:


I was actually thinking that branch-1.0 would be omitted, but, on second look, 
I'm not seeing anything that would actually violate the patch update rules. I 
agree with everything Jonathan said WRT necessary patch alterations on 0.98 and 
branch-1.0.

I'm happy to apply the patch for those branches as well, but I'm kind of 
waiting on someone to tell/ask this of me rather than just do it on my own..

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-26 Thread Lars Hofhansl (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382251#comment-14382251
 ] 

Lars Hofhansl commented on HBASE-13262:
---

Looks good to me.
{{+  if (null != values  values.length  0  
callable.getServerHasMoreResultsContext()) {}}

I'd probably name this just {{callable.hasMoreResultsContext}}. So that will 
work right with an old client, right? It'll just not read the context and fall 
back to the old logic. That's what the code does, just making sure it's 
something we tested.


 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-26 Thread Jonathan Lawlor (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382232#comment-14382232
 ] 

Jonathan Lawlor commented on HBASE-13262:
-

+1, lgtm

Anyone else have some time to review this nice patch?

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-26 Thread Jonathan Lawlor (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383024#comment-14383024
 ] 

Jonathan Lawlor commented on HBASE-13262:
-

I agree, that test failure looks unrelated to me; likely just flaky. Let's 
reattach the patch to trigger another QA run to see if it happens again

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-26 Thread Sean Busbey (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383058#comment-14383058
 ] 

Sean Busbey commented on HBASE-13262:
-

sorry for the drive-by question, what's the current set of target branches for 
this fix? jira says master, branch-1, and 0.98. There's a change that is 
disallowed in branch-1.0, I presume?

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-26 Thread Jonathan Lawlor (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383102#comment-14383102
 ] 

Jonathan Lawlor commented on HBASE-13262:
-

[~elserj] please correct me if I'm wrong, but I believe this change will go 
into 0.98+ (so branch-1.0 should be included in the target branches). In 0.98 
and branch-1.0, The flag can be set based on the same checks from branch-1+ 
except that a check against the boolean {{moreRows}} would replace the check 
{{state.hasMoreValues}} since NextState is branch-1+

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262-v7.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-26 Thread Lars Hofhansl (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382703#comment-14382703
 ] 

Lars Hofhansl commented on HBASE-13262:
---

That was just a nit :) (thanks for changing it)
What's table state querying? Meaning to use a scanner to see if a table 
exists or is enabled/disabled? How would the patch affect that?

+1 on patch in any case.


 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382707#comment-14382707
 ] 

Josh Elser commented on HBASE-13262:


For the record, 1.0.0 client with a patched 1.1.0-SNAPSHOT worked fine

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382711#comment-14382711
 ] 

Josh Elser commented on HBASE-13262:


Sorry, I was unclear. {{Admin#isTableEnabled}} and {{Admin#deleteTable}} don't 
appear to work with a 1.0.0 client and a 2.0.0-SNAP server, but such a breakage 
is allowed as I understand it. This happens with and without the patches here. 
I was just noting that I had to slightly change my program for the 1.0.0 and 
2.0.0-SNAP test I ran (whereas testing 1.0.0 and 1.1.0-SNAP required no changes 
to the original program).

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382426#comment-14382426
 ] 

Josh Elser commented on HBASE-13262:


bq. I'd probably name this just callable.hasMoreResultsContext.

Happy to change that. Will do (below) testing first.

bq. So that will work right with an old client, right? It'll just not read the 
context and fall back to the old logic. That's what the code does, just making 
sure it's something we tested.

That's the intent, but, admittedly, I haven't explicitly tested this. I'll give 
it a quick go.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382930#comment-14382930
 ] 

Josh Elser commented on HBASE-13262:


Test failure looks unrelated to me (Jenkins goofed up, perhaps?).

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-26 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382923#comment-14382923
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12707604/HBASE-13262-v7.patch
  against master branch at commit 18256fc9544866fc7182dfc5dd9d73b8cef02d66.
  ATTACHMENT ID: 12707604

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 8 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13450//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13450//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13450//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13450//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262-v7.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-26 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381498#comment-14381498
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12707430/HBASE-13262-v6.patch
  against master branch at commit 948a6a63e8c1a347ff18903cba8fe6ffb6190d37.
  ATTACHMENT ID: 12707430

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any  
new Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13437//testReport/
Release Findbugs (version 2.0.3)warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13437//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13437//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13437//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262-v6.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-25 Thread Lars Hofhansl (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380172#comment-14380172
 ] 

Lars Hofhansl commented on HBASE-13262:
---

I think this is important enough to get it into 0.98 sooner than later.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380195#comment-14380195
 ] 

Josh Elser commented on HBASE-13262:


Concern noted. I think I have the changes made WRT the stuff Jonathan pointed 
out yesterday. Will put up a new patch shortly.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380619#comment-14380619
 ] 

Josh Elser commented on HBASE-13262:


Oops. Caught it -- will add a new test and repost patch (plus Jonathan's 
concerns after I read them)

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380572#comment-14380572
 ] 

Josh Elser commented on HBASE-13262:


:sigh: reran my standalone test and I'm seeing the original problem. Apparently 
my tests are missing something.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380630#comment-14380630
 ] 

Josh Elser commented on HBASE-13262:


bq. Currently the batch limit and size limit are being checked, but the batch 
limit should be replaced with a check against i = rows. 

Cool, I just noticed this was actually the reason things were broken. Checking 
only the sizeLimit and batchLimit was causing moreResultsInReason=false when we 
just had a normal moreValues. I think the positive case for moreResultsInRegion 
would then be:

{code}
null != state  (state.sizeLimitReached() || i = rows || 
state.hasMoreValues())
{code}

bq. I think your intention was probably to check the caching limit it's just 
that the terminology surrounding batch is a little misleading (even the javadoc 
on Scan#setBatch is misleading; values instead of cells).

You read my confusion like a book :). The differentiation between caching and 
batch is rather confusing. Thank you for clarifying.

bq. Also, just a note on backporting to 0.98 and branch-1.0. Because NextState 
is only in branch-1+, the corresponding check for size limit will simply be 
currentScanResultSize = maxResultSize (looks like you have it covered in this 
patch actually) and the cache limit check will still be i=rows.

Cool thank you for commenting on those, I've only started looking back there 
now (1.1 and 2.0 were enough to try to wrap my head around together). FWIW, 
[~lhofhansl]'s recommendation about removing ScanResultWithContext will likely 
make the 0.98 and 1.0 backport much easier (at least the cherry-pick was a bit 
painful locally). I am leaning towards that now as well.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380396#comment-14380396
 ] 

Jonathan Lawlor commented on HBASE-13262:
-

[~elserj] This is looking good, I like the introduction of the new flag. Some 
quick review below:

When setting the flag inside RSRpcServices, I think we should be checking the 
size limit and the caching (i.e. row) limit. Currently the batch limit and size 
limit are being checked, but the batch limit should be replaced with a check 
against {{i = rows}}. 

The reason behind replacing the batch limit check with a caching limit check is 
that the batch is a limit on the number of cells per Result. So reaching the 
batch limit doesn't necessarily mean we are done with the scan but rather that 
we have accumulated enough cells necessary for a Result to be formed. On the 
other hand, it would be worthwhile to add a check against the caching limit 
(i.e. {{i = rows}}). I think your intention was probably to check the caching 
limit it's just that the terminology surrounding batch is a little misleading 
(even the javadoc on {{Scan#setBatch}} is misleading; values instead of 
cells).

Also, just a note on backporting to 0.98 and branch-1.0. Because NextState is 
only in branch-1+, the corresponding check for size limit will simply be 
{{currentScanResultSize = maxResultSize}} (looks like you have it covered in 
this patch actually) and the cache limit check will still be {{i=rows}}.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380707#comment-14380707
 ] 

Jonathan Lawlor commented on HBASE-13262:
-

bq. I think the positive case for moreResultsInRegion would then be...

That condition looks good to me. I would probably swap out 
{{state.sizeLimitReached()}} for {{currentScanResultSize = maxResultSize}} 
just because it is the condition that is used to break out of the loop and so 
may make more sense to someone reading the code later (the two conditions would 
be equivalent, this is just a thought). I like the inclusion of 
state.hasMoreValues, smart :)

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-25 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380798#comment-14380798
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12707260/HBASE-13262-v4.patch
  against master branch at commit 5a58116bb531f0b256fdbfcabd3fad20663170fd.
  ATTACHMENT ID: 12707260

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 16 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+KeyValue kv1 = new KeyValue(row1.getBytes(), cf.getBytes(), 
cq.getBytes(), 1, Type.Maximum);
+  new java.lang.String[] { CellsPerResult, ScannerId, 
MoreResults, Ttl, Results, Stale, PartialFlagPerResult, 
MoreResultsInRegion, });

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13423//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262.patch, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380971#comment-14380971
 ] 

Jonathan Lawlor commented on HBASE-13262:
-

bq. I can lift it up to ScannerCallable if you think that makes more sense. 
Like you said, I was just trying to mimic what was already in place.

I think they would be better located inside ScannerCallable because there are 
already a few methods defined there that are specific to scanning such as 
getCaching and getScan. Again, not a huge deal

bq. I've been going under the assumption that it's much less likely to run into 
them (emphasis on small). For the sake of getting this out, I didn't want to 
make yet another change as we get close

I see, makes sense to me; just wanted to make sure that we didn't forget about 
them :)

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380990#comment-14380990
 ] 

Josh Elser commented on HBASE-13262:


bq. I think they would be better located inside ScannerCallable because there 
are already a few methods defined there that are specific to scanning such as 
getCaching and getScan. Again, not a huge deal

Ok, I'll get these staged but wait for the current test-patch to fire before 
putting up a new patch. If v5 comes back clean, we can clean this up later.

bq. just wanted to make sure that we didn't forget about them

np, created HBASE-13335 to make sure :)

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-25 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381048#comment-14381048
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12707338/HBASE-13262-v5.patch
  against master branch at commit 134b95579c0d02d54f477e437f03ca1a825256f4.
  ATTACHMENT ID: 12707338

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13430//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380946#comment-14380946
 ] 

Jonathan Lawlor commented on HBASE-13262:
-

[~elserj] This patch looks great, just one nit below, may not be relevant:

Nit: The methods for checking moreResultsInRegion were placed inside the 
RegionServerCallable. I wonder if they would be better located inside 
ScannerCallable rather than overridden there. The flag is only really relevant 
when we're scanning, so seems weird that we have it inside 
RegionServerCallable. That being said, I do understand you were looking to 
match behavior of getHRegionInfo so probably why it is in RegionServerCallable

It seems as though the logic within ClientScanner will deal with this problem 
well. I think the only part left would be to expand that coverage into the 
ClientSmallScanner and ClientSmallReversed scanners and then backport it to 
0.98 and branch-1.0 (I know above you mentioned your intention was to get 
ClientScanner covered first before worrying about the others).

Would be great to get another set of eyes on this as well if anyone else has 
some time

Great work [~elserj]!

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381130#comment-14381130
 ] 

Josh Elser commented on HBASE-13262:


{{TestDistributedLogSplitting.testLogReplayTwoSequentialRSDown}} is what 
failed. Rerunning it locally, the test just seems flaky. 

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

[
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380953#comment-14380953
]

Josh Elser commented on HBASE-13262:

Cool, thanks for taking a look.

{quote}
Nit: The methods for checking moreResultsInRegion were placed inside the
RegionServerCallable. I wonder if they would be better located inside
ScannerCallable rather than overridden there. The flag is only really relevant
when we're scanning, so seems weird that we have it inside
RegionServerCallable. That being said, I do understand you were looking to
match behavior of getHRegionInfo so probably why it is in RegionServerCallable
{quote}

Yeah, that's right. I can lift it up to ScannerCallable if you think that makes
more sense. Like you said, I was just trying to mimic what was already in place.

{quote}
It seems as though the logic within ClientScanner will deal with this problem
well. I think the only part left would be to expand that coverage into the
ClientSmallScanner and ClientSmallReversed scanners and then backport it to
0.98 and branch-1.0 (I know above you mentioned your intention was to get
ClientScanner covered first before worrying about the others).
{quote}

I've been going under the assumption that it's much less likely to run into
them (emphasis on small). For the sake of getting this out, I didn't want to
make yet another change as we get close, but thought I would just update those
as a follow-on (hopefully with some more tests). Really doesn't matter if we
just do it at once.

ResultScanner doesn't return all rows in Scan
-

Key: HBASE-13262
URL: https://issues.apache.org/jira/browse/HBASE-13262
Project: HBase
Issue Type: Bug
Components: Client
Affects Versions: 2.0.0, 1.1.0
Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
Fix For: 2.0.0, 1.1.0, 0.98.13

Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch,
HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch,
HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch,
HBASE-13262-v4.patch, HBASE-13262-v5.patch, HBASE-13262.patch,
regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt

Tried to write a simple Java client again 1.1.0-SNAPSHOT.
* Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]),
for a total of 10M cells written
* Read back the data from the table, ensure I saw 10M cells
Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of
the actual rows. Running against 1.0.0, returns all 10M records as expected.
[Code I was
running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
for the curious.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-24 Thread Jonathan Lawlor (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378680#comment-14378680
 ] 

Jonathan Lawlor commented on HBASE-13262:
-

bq. Is there a reason you think that we need to introduce a new attribute on 
the message though
Good point. Perhaps the current moreResults flag could be modified to be 
relevant to the region. My concern would be that the flag has already been 
established as relevant to the scan as a whole rather than per region, so we 
would have to be sure that any changes to the way that the flag is set is 
understood globally and not misunderstood to mean that the whole scan should 
stop. Also, if it does become about the region rather than the scan as a whole, 
would there still be a mechanism for the server to indicate to the client that 
the whole scan is done (would it still be result == null)?

bq. I think the best we can do is fall back to the old logic and pray we don't 
run into the problem
Ya, I think you may be right

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378731#comment-14378731
 ] 

Josh Elser commented on HBASE-13262:


bq. would there still be a mechanism for the server to indicate to the client 
that the whole scan is done

Ah, that's a good point. So, as I understand it, we have the following cases 
which the RS will return to a client:

* {{Result}}s and more results on this region
* {{Result}}s and no more result on this region (this was the original bug)
* No {{Result}}s and no more results on this region (but we need to check the 
other Regions)
* No {{Result}}s and the filter is done (this filter case)

It might be possible to differentiate between the 3 and 4th point if we knew 
when {{Result[]}} was null instead of just empty, specifically, for the filter 
case, if the client could get a ScanResponse in which the {{Result[]}} was 
actually null, we could still keep them separate. I'm not a big fan of that 
though, nor am I convinced it would even work. I don't quite understand how the 
non-protobuf serialization of {{Result}}s works presently.

That said, hasResults could be left solely for the filter-termination case, and 
I could introduce a moreResultsInRegion attribute after all. hasResults would 
still be a bit goofy WRT its name, but some comments can make it clear that 
it's purpose is explicitly for the filter case and nothing else.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-24 Thread Jonathan Lawlor (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378931#comment-14378931
 ] 

Jonathan Lawlor commented on HBASE-13262:
-

bq. as I understand it, we have the following cases which the RS will return to 
a client 
Those cases make sense to me

bq. I'm not a big fan of that though, nor am I convinced it would even work
I agree. I think it may be best to introduce a new flag to communicate this 
information on a per region basis, but if anyone else has any ideas please 
chime in.

bq. But to be clear, we'd need for that fix to include logic on the server side 
that works safely with older clients, or we can't revert it
Ya, in the case that the client does not know to look for the flag, or in the 
case that the server does not send the flag, the fix from HBASE-13303 will be 
necessary. Because of this, I don't believe the fix currently in the works 
would allow us to revert HBASE-13303, correct me if I'm wrong [~elserj].

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-24 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378736#comment-14378736
 ] 

Andrew Purtell commented on HBASE-13262:


Linking HBASE-13303 here as a reminder that commit should be reverted once this 
issue has a more comprehensive fix ready.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-24 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378894#comment-14378894
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12707001/HBASE-13262-v3.patch
  against master branch at commit 8cb4f89c013b254c6d3e9bee7b63137a391bcaba.
  ATTACHMENT ID: 12707001

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 16 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13396//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

[
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379022#comment-14379022
]

Josh Elser commented on HBASE-13262:

I at least tried to add some tests :)

bq. Do you need ScanResultWithContext? Could also add a getter for the new bit
(similar to the existing getHRegionInfo). That'd keep the change more
manageable (but maybe not nicer).

We could, but I don't think that's quite as representative of the state we're
encapsulating. It made sense to me to tie the results we got from the server to
the extra information we got in the same call. We could make a getter on the
Callable -- it's just separating state which ultimately came from the same RPC.

That said, I'm not extremely adamant one way or the other, just explaining the
rationale behind why I did it that way. :)

ResultScanner doesn't return all rows in Scan
-

Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch,
HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch,
HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch,
HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt,
testrun_branch1.0.txt

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378991#comment-14378991
 ] 

Josh Elser commented on HBASE-13262:


That is essentially what the current patch does, Lars. The discussion today was 
that Jonathan pointed out that the bit I did use wouldn't work 100% -- I need 
to introduce a brand new one instead. I had thought I could get away with 
reusing the existing moreResults bit that was already on ScanResponse.

Let me know if I missed some concern you have.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-24 Thread Lars Hofhansl (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378964#comment-14378964
]

Lars Hofhansl commented on HBASE-13262:
---

Without looking at the patch... I do not think this issue needs an extensive
fix. We only need to do the following:
# add an exhausted region bit to the scan response
# on the server set that flag if we sent a response because we ran out of stuff
to read from the region (i.e. we did *not* run into a size or row limit).
# on the client, if present, use this bit to decide how to continue in the
loop. I.e. if set skip to the next region (else fall back to the existing
logic, in all versions but trunk)

I wouldn't do more in this jira. Fix the basic stuff first, then file add-on
jiras to improve.
It's also quite possible that I am missing something.

ResultScanner doesn't return all rows in Scan
-

Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch,
HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch,
HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch,
HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt,
testrun_branch1.0.txt

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378990#comment-14378990
 ] 

Josh Elser commented on HBASE-13262:


bq. I don't believe the fix currently in the works would allow us to revert 
HBASE-13303, correct me if I'm wrong Josh Elser.

Yeah, I think you're right. We'd need it in place as long as we support 1.1 
clients to speak with =1.1 servers.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-24 Thread Lars Hofhansl (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379012#comment-14379012
 ] 

Lars Hofhansl commented on HBASE-13262:
---

I see the patch is big only because you factored out loadCache and added tests 
:)

Do you need ScanResultWithContext? Could also add a getter for the new bit 
(similar to the existing getHRegionInfo). That'd keep the change more 
manageable (but maybe not nicer).


 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-24 Thread Lars Hofhansl (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379035#comment-14379035
 ] 

Lars Hofhansl commented on HBASE-13262:
---

My reasoning would be that result[] is the actual state we want, the other bits 
are used for internal management, and hence they feel separate to me (i.e. we 
might want to add more/different bits later, and not change the result classes 
around).

Not feeling strongly about this either.


 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch, 
 HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378125#comment-14378125
 ] 

Josh Elser commented on HBASE-13262:


Missed running these tests locally. Looks like there was some implicit state 
built into a null ScanResponse which I broke in this last patch. Instead of a 
null {{Result[]}} coming back, it got an empty {{Result[]}} and 
{{getMoreResults=false}} -- I think I can just update the done condition in 
ClientScanner.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-24 Thread Jonathan Lawlor (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378559#comment-14378559
]

Jonathan Lawlor commented on HBASE-13262:
-

[~elserj] Nice patch, some review below

Nice tests, I especially like the new TestClientScanner

bq. // TODO Use the server's response about more results
Not sure what this line means, do we need to check the more results flag here?

I like the idea of using moreResults flag but I believe we need to actually
introduce a new flag into the ScanResponse. Unfortunately, the name moreResults
is a little misleading as it seems perfect for what we are trying to achieve.
Looking into RSRpcServices to see when this moreResults flag is set to false,
it looks like this happens only when scanner.isFilterDone() is true. Looking
closer, RegionScannerImpl#isFilterDone is only true when the RegionScanner
wants to indicate that the entire scan should stop (i.e. the client shouldn't
even try to change regions, the whole scan is done).

So to be clear, it looks as though the moreResults flag is false ONLY when the
entire scan needs to stop, NOT when a region is exhausted. The net effect is
that moreResults will always appear to be true client side, even when the
region is exhausted. Thus, I think we will still end up making that extra RPC
that Lars mentioned above in order to see that the Result[] is empty and thus
the region is exhausted, before the region change occurs.

Since moreResults is a flag that is used for global scan logic (logic not
specific to a particular region), I think we need to introduce a new flag that
is specific to the region's results. If the result size limit or caching limit
is reached inside RSRpcServices, return true, else false.

bq. // Server didn't respond whether it has more results or not.
Is it possible here that we may inadvertently interpret the missing flag as
meaning the region is exhausted? Probably fine because the limit logic is still
in the ClientScanner while condition, just wondering.

ResultScanner doesn't return all rows in Scan
-

Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch,
HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch,
HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt,
testrun_branch1.0.txt

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

[
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378610#comment-14378610
]

Josh Elser commented on HBASE-13262:

Just attached some v3 patches which will hopefully fix all of the tests and
checkstyle stuff.

Thanks for the review, Jonathan.

bq. Not sure what this line means, do we need to check the more results flag
here?

Yeah, I only changed ClientScanner to start using
{{ScanResponse#getMoreResults()}}. I assume that the reverse (small) scanner
should also start using it in the long run. I left them as-is for the time just
to not get more sidetracked with them and focus on getting ClientScanner
correct.

{quote}
I like the idea of using moreResults flag but I believe we need to actually
introduce a new flag into the ScanResponse. Unfortunately, the name moreResults
is a little misleading as it seems perfect for what we are trying to achieve.
Looking into RSRpcServices to see when this moreResults flag is set to false,
it looks like this happens only when scanner.isFilterDone() is true. Looking
closer, RegionScannerImpl#isFilterDone is only true when the RegionScanner
wants to indicate that the entire scan should stop (i.e. the client shouldn't
even try to change regions, the whole scan is done).

Hrm, it appears you are correct once again. I had thought I had some changes in
RSRpcServices for this already, but perhaps I lost them in the shuffle. Also a
sign that my tests aren't sufficient, I suppose. Is there a reason you think
that we need to introduce a new attribute on the message though? As long as the
server fills in that attribute correctly in all cases, it would work w/o
changing the message structure, no? That would hopefully make moreResults a bit
less obtuse for client-use (not to mention the improvements already present WRT
null results carrying some special logic in ClientScanner and ScannerCallable).

{quote}
bq. // Server didn't respond whether it has more results or not.

Is it possible here that we may inadvertently interpret the missing flag as
meaning the region is exhausted? Probably fine because the limit logic is still
in the ClientScanner while condition, just wondering.
{quote}

Yeah, that was a drawback to dealing with it like I did. I was trying to think
through the case of what happens when talking to an older server (or one that
just doesn't give the flag). I think the best we can do is fall back to the old
logic and pray we don't run into the problem? I'd need to do more digging
through older versions to be 100% certain though.

ResultScanner doesn't return all rows in Scan
-

Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch,
HBASE-13262-branch-1-v3.patch, HBASE-13262-branch-1.patch,
HBASE-13262-v1.patch, HBASE-13262-v2.patch, HBASE-13262-v3.patch,
HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt,
testrun_branch1.0.txt

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376418#comment-14376418
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12706579/HBASE-13262-v1.patch
  against master branch at commit 845f5de121e92a99b41b30dc86cb3f2898e0254f.
  ATTACHMENT ID: 12706579

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 16 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
1920 checkstyle errors (more than the master's current 1918 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+KeyValue kv1 = new KeyValue(row.getBytes(), cf.getBytes(), 
cq.getBytes(), 1, Type.Maximum);
+  inOrder.verify(caller, 
Mockito.times(2)).callWithoutRetries(Mockito.any(RetryingCallable.class),
+KeyValue kv1 = new KeyValue(row.getBytes(), cf.getBytes(), 
cq.getBytes(), 1, Type.Maximum);
+  inOrder.verify(caller, 
Mockito.times(2)).callWithoutRetries(Mockito.any(RetryingCallable.class),
+  inOrder.verify(caller, 
Mockito.times(2)).callWithoutRetries(Mockito.any(RetryingCallable.class),
+KeyValue kv1 = new KeyValue(row.getBytes(), cf.getBytes(), 
cq.getBytes(), 1, Type.Maximum);
+  inOrder.verify(caller, 
Mockito.times(2)).callWithoutRetries(Mockito.any(RetryingCallable.class),
+KeyValue kv1 = new KeyValue(row.getBytes(), cf.getBytes(), 
cq.getBytes(), 1, Type.Maximum);
+KeyValue kv2 = new KeyValue(row2.getBytes(), cf.getBytes(), 
cq.getBytes(), 1, Type.Maximum);
+  inOrder.verify(caller, 
Mockito.times(2)).callWithoutRetries(Mockito.any(RetryingCallable.class),

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13370//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project:

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376571#comment-14376571
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12706672/HBASE-13262-branch-1.patch
  against branch-1 branch at commit 65d3781897baf05ef583fce3b5e8e08cd6228f35.
  ATTACHMENT ID: 12706672

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 16 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
3811 checkstyle errors (more than the master's current 3809 errors).

{color:red}-1 findbugs{color}.  The patch appears to introduce 2 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+KeyValue kv1 = new KeyValue(row.getBytes(), cf.getBytes(), 
cq.getBytes(), 1, Type.Maximum);
+  inOrder.verify(caller, 
Mockito.times(2)).callWithoutRetries(Mockito.any(RetryingCallable.class),
+KeyValue kv1 = new KeyValue(row.getBytes(), cf.getBytes(), 
cq.getBytes(), 1, Type.Maximum);
+  inOrder.verify(caller, 
Mockito.times(2)).callWithoutRetries(Mockito.any(RetryingCallable.class),
+  inOrder.verify(caller, 
Mockito.times(2)).callWithoutRetries(Mockito.any(RetryingCallable.class),
+KeyValue kv1 = new KeyValue(row.getBytes(), cf.getBytes(), 
cq.getBytes(), 1, Type.Maximum);
+  inOrder.verify(caller, 
Mockito.times(2)).callWithoutRetries(Mockito.any(RetryingCallable.class),
+KeyValue kv1 = new KeyValue(row.getBytes(), cf.getBytes(), 
cq.getBytes(), 1, Type.Maximum);
+KeyValue kv2 = new KeyValue(row2.getBytes(), cf.getBytes(), 
cq.getBytes(), 1, Type.Maximum);
+  inOrder.verify(caller, 
Mockito.times(2)).callWithoutRetries(Mockito.any(RetryingCallable.class),

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.master.TestAssignmentManager

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13371//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376183#comment-14376183
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12706573/HBASE-13262.patch
  against master branch at commit 845f5de121e92a99b41b30dc86cb3f2898e0254f.
  ATTACHMENT ID: 12706573

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 16 new 
or modified tests.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13368//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262.patch, 
 regionserver-logging.diff, testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-23 Thread Nick Dimiduk (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376321#comment-14376321
 ] 

Nick Dimiduk commented on HBASE-13262:
--

[~elserj] You can trigger a build vs a specific branch by including the branch 
name in the patch name. The branch names accepted are: 
https://github.com/apache/hbase/blob/master/dev-support/test-patch.properties#L28-L30

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-v1.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan

2015-03-23 Thread Josh Elser (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376326#comment-14376326
 ] 

Josh Elser commented on HBASE-13262:


Ooo, thanks for the tip, Nick!

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-v1.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377269#comment-14377269
 ] 

Hadoop QA commented on HBASE-13262:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12706813/HBASE-13262-v2.patch
  against master branch at commit 5459008ccdc83f09e6d8d7ec90144dc120e1a084.
  ATTACHMENT ID: 12706813

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified tests.

{color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
1919 checkstyle errors (more than the master's current 1917 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
  org.apache.hadoop.hbase.client.TestFromClientSide

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13379//console

This message is automatically generated.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, HBASE-13262-branch-1-v2.patch, 
 HBASE-13262-branch-1.patch, HBASE-13262-v1.patch, HBASE-13262-v2.patch, 
 HBASE-13262.patch, regionserver-logging.diff, testrun_0.98.txt, 
 testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375413#comment-14375413
 ] 

ramkrishna.s.vasudevan commented on HBASE-13262:


Yes, during flushing we always write the tag length even when it is 0.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375415#comment-14375415
 ] 

ramkrishna.s.vasudevan commented on HBASE-13262:


Yes, during flushing we always write the tag length even when it is 0.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan


[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375416#comment-14375416
 ] 

ramkrishna.s.vasudevan commented on HBASE-13262:


Yes, during flushing we always write the tag length even when it is 0.

 ResultScanner doesn't return all rows in Scan
 -

 Key: HBASE-13262
 URL: https://issues.apache.org/jira/browse/HBASE-13262
 Project: HBase
  Issue Type: Bug
  Components: Client
Affects Versions: 2.0.0, 1.1.0
 Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Blocker
 Fix For: 2.0.0, 1.1.0, 0.98.13

 Attachments: 13262-0.98-testpatch.txt, regionserver-logging.diff, 
 testrun_0.98.txt, testrun_branch1.0.txt


 Tried to write a simple Java client again 1.1.0-SNAPSHOT.
 * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
 for a total of 10M cells written
 * Read back the data from the table, ensure I saw 10M cells
 Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
 the actual rows. Running against 1.0.0, returns all 10M records as expected.
 [Code I was 
 running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-13262) ResultScanner doesn't return all rows in Scan