[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774816#comment-16774816 ] ASF subversion and git services commented on KYLIN-3597: Commit 0d43ae933937a9c25f81fca16de6c7b627e45371 in kylin's branch refs/heads/master-hadoop3.1 from whuwb [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=0d43ae9 ] KYLIN-3597 fix sonar issues and refactor test cases > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774806#comment-16774806 ] ASF subversion and git services commented on KYLIN-3597: Commit 0d43ae933937a9c25f81fca16de6c7b627e45371 in kylin's branch refs/heads/master-hadoop3.1 from whuwb [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=0d43ae9 ] KYLIN-3597 fix sonar issues and refactor test cases > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767450#comment-16767450 ] ASF GitHub Bot commented on KYLIN-3597: --- shaofengshi commented on pull request #467: KYLIN-3597 fix sonar issues and refactor test cases URL: https://github.com/apache/kylin/pull/467 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767451#comment-16767451 ] ASF subversion and git services commented on KYLIN-3597: Commit 0d43ae933937a9c25f81fca16de6c7b627e45371 in kylin's branch refs/heads/master from whuwb [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=0d43ae9 ] KYLIN-3597 fix sonar issues and refactor test cases > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766863#comment-16766863 ] ASF GitHub Bot commented on KYLIN-3597: --- whuwb commented on pull request #467: KYLIN-3597 fix sonar issues and refactor test cases URL: https://github.com/apache/kylin/pull/467 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750825#comment-16750825 ] ASF GitHub Bot commented on KYLIN-3597: --- shaofengshi commented on pull request #444: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/444 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750826#comment-16750826 ] ASF subversion and git services commented on KYLIN-3597: Commit d3235e7b1fa4d95b56d79ebee00dcfee67af53b4 in kylin's branch refs/heads/master from whuwb [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=d3235e7 ] KYLIN-3597 fix sonar issues > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749955#comment-16749955 ] ASF GitHub Bot commented on KYLIN-3597: --- whuwb commented on pull request #444: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/444 [INFO] [INFO] Reactor Summary for Apache Kylin 2.6.0-SNAPSHOT: [INFO] [INFO] Apache Kylin ... SUCCESS [ 6.974 s] [INFO] Apache Kylin - Core Common . SUCCESS [ 17.837 s] [INFO] Apache Kylin - Core Metadata ... SUCCESS [ 53.416 s] [INFO] Apache Kylin - Core Dictionary . SUCCESS [06:03 min] [INFO] Apache Kylin - Core Cube ... SUCCESS [01:24 min] [INFO] Apache Kylin - Core Metrics SUCCESS [ 1.493 s] [INFO] Apache Kylin - Core Job SUCCESS [ 46.899 s] [INFO] Apache Kylin - Core Storage SUCCESS [ 8.040 s] [INFO] Apache Kylin - MapReduce Engine SUCCESS [ 22.222 s] [INFO] Apache Kylin - Spark Engine SUCCESS [ 15.364 s] [INFO] Apache Kylin - Hive Source . SUCCESS [ 7.214 s] [INFO] Apache Kylin - DataSource SDK .. SUCCESS [ 10.493 s] [INFO] Apache Kylin - Jdbc Source . SUCCESS [ 20.402 s] [INFO] Apache Kylin - Kafka Source SUCCESS [ 4.901 s] [INFO] Apache Kylin - Cache ... SUCCESS [ 7.958 s] [INFO] Apache Kylin - HBase Storage ... SUCCESS [ 41.641 s] [INFO] Apache Kylin - Query ... SUCCESS [ 11.846 s] [INFO] Apache Kylin - Metrics Reporter Hive ... SUCCESS [ 1.031 s] [INFO] Apache Kylin - Metrics Reporter Kafka .. SUCCESS [ 1.359 s] [INFO] Apache Kylin - REST Server Base SUCCESS [ 27.610 s] [INFO] Apache Kylin - REST Server . SUCCESS [01:50 min] [INFO] Apache Kylin - JDBC Driver . SUCCESS [ 9.361 s] [INFO] Apache Kylin - Assembly SUCCESS [ 15.579 s] [INFO] Apache Kylin - Tool SUCCESS [ 16.280 s] [INFO] Apache Kylin - Tool Assembly ... SUCCESS [ 5.683 s] [INFO] Apache Kylin - Integration Test SUCCESS [ 02:42 h] [INFO] Apache Kylin - Tomcat Extension SUCCESS [ 4.301 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 02:58 h [INFO] Finished at: 2019-01-23T09:55:58Z [INFO] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744716#comment-16744716 ] ASF subversion and git services commented on KYLIN-3597: Commit 3825a3d7fb0b503b819631caa6920eec3231852c in kylin's branch refs/heads/master from whuwb [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=3825a3d ] KYLIN-3597 fix sonar issues > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744714#comment-16744714 ] ASF GitHub Bot commented on KYLIN-3597: --- shaofengshi commented on pull request #430: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/430 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744717#comment-16744717 ] ASF subversion and git services commented on KYLIN-3597: Commit e7783777df4256d391f1d37a3d015bdd2398be2b in kylin's branch refs/heads/master from whuwb [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=e778377 ] KYLIN-3597 fix sonar issues > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues phase 1
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743975#comment-16743975 ] ASF GitHub Bot commented on KYLIN-3597: --- whuwb commented on pull request #430: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/430 Fix sonar issues [INFO] [INFO] Reactor Summary for Apache Kylin 2.6.0-SNAPSHOT: [INFO] [INFO] Apache Kylin ... SUCCESS [ 8.621 s] [INFO] Apache Kylin - Core Common . SUCCESS [ 16.452 s] [INFO] Apache Kylin - Core Metadata ... SUCCESS [ 52.959 s] [INFO] Apache Kylin - Core Dictionary . SUCCESS [06:04 min] [INFO] Apache Kylin - Core Cube ... SUCCESS [01:29 min] [INFO] Apache Kylin - Core Metrics SUCCESS [ 1.754 s] [INFO] Apache Kylin - Core Job SUCCESS [ 47.255 s] [INFO] Apache Kylin - Core Storage SUCCESS [ 8.095 s] [INFO] Apache Kylin - MapReduce Engine SUCCESS [ 23.348 s] [INFO] Apache Kylin - Spark Engine SUCCESS [ 8.221 s] [INFO] Apache Kylin - Hive Source . SUCCESS [ 6.699 s] [INFO] Apache Kylin - DataSource SDK .. SUCCESS [ 11.649 s] [INFO] Apache Kylin - Jdbc Source . SUCCESS [ 20.404 s] [INFO] Apache Kylin - Kafka Source SUCCESS [ 5.919 s] [INFO] Apache Kylin - Cache ... SUCCESS [ 9.387 s] [INFO] Apache Kylin - HBase Storage ... SUCCESS [ 46.270 s] [INFO] Apache Kylin - Query ... SUCCESS [ 14.726 s] [INFO] Apache Kylin - Metrics Reporter Hive ... SUCCESS [ 1.079 s] [INFO] Apache Kylin - Metrics Reporter Kafka .. SUCCESS [ 0.854 s] [INFO] Apache Kylin - REST Server Base SUCCESS [ 26.286 s] [INFO] Apache Kylin - REST Server . SUCCESS [02:02 min] [INFO] Apache Kylin - JDBC Driver . SUCCESS [ 8.589 s] [INFO] Apache Kylin - Assembly SUCCESS [ 16.929 s] [INFO] Apache Kylin - Tool SUCCESS [ 12.207 s] [INFO] Apache Kylin - Tool Assembly ... SUCCESS [ 4.185 s] [INFO] Apache Kylin - Integration Test SUCCESS [ 02:46 h] [INFO] Apache Kylin - Tomcat Extension SUCCESS [ 5.503 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 03:02 h [INFO] Finished at: 2019-01-14T21:54:56Z [INFO] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues phase 1 > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729264#comment-16729264 ] ASF GitHub Bot commented on KYLIN-3597: --- shaofengshi commented on pull request #418: KYLIN-3597 fix sonar problems URL: https://github.com/apache/kylin/pull/418 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729265#comment-16729265 ] ASF subversion and git services commented on KYLIN-3597: Commit 49e835a3b317ee79ecd4ed1ebbb25409e0ce6718 in kylin's branch refs/heads/master from Lijun Cao [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=49e835a ] KYLIN-3597 fix sonar problems > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729249#comment-16729249 ] ASF GitHub Bot commented on KYLIN-3597: --- caolijun1166 commented on pull request #418: KYLIN-3597 fix sonar problems URL: https://github.com/apache/kylin/pull/418 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728900#comment-16728900 ] ASF GitHub Bot commented on KYLIN-3597: --- shaofengshi commented on pull request #416: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/416 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1672#comment-1672 ] ASF GitHub Bot commented on KYLIN-3597: --- caolijun1166 commented on pull request #416: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/416 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728845#comment-16728845 ] ASF subversion and git services commented on KYLIN-3597: Commit 338a8f1e699dcdc297f48a9a0ecfb99d2b1c947b in kylin's branch refs/heads/master from Lijun Cao [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=338a8f1 ] KYLIN-3597 fix sonar issues > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728271#comment-16728271 ] ASF GitHub Bot commented on KYLIN-3597: --- shaofengshi commented on pull request #401: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/401 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728272#comment-16728272 ] ASF subversion and git services commented on KYLIN-3597: Commit 3b9c5a55139ca85e60e45bb5c748f480178a93d5 in kylin's branch refs/heads/master from whuwb [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=3b9c5a5 ] KYLIN-3597 fix sonar issues > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728242#comment-16728242 ] Zhong Yanghong commented on KYLIN-3597: --- Hi [~Shaofengshi], what's the status of this? Can it be marked as resolved? > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723608#comment-16723608 ] ASF GitHub Bot commented on KYLIN-3597: --- whuwb opened a new pull request #401: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/401 Fix sonar issues This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722149#comment-16722149 ] ASF subversion and git services commented on KYLIN-3597: Commit 62830469424c3f2dcb79f35d1f66e1698768428f in kylin's branch refs/heads/master from [~caolijun1166] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=6283046 ] KYLIN-3597 improve code smell > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722152#comment-16722152 ] ASF subversion and git services commented on KYLIN-3597: Commit 32a31506ce609eeabe3c88544a2bcf742a5c5599 in kylin's branch refs/heads/master from whuwb [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=32a3150 ] KYLIN-3597 fix sonar issues > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722151#comment-16722151
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi closed pull request #392: KYLIN-3597 fix sonar issues
URL: https://github.com/apache/kylin/pull/392
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/util/SSHClient.java
b/core-common/src/main/java/org/apache/kylin/common/util/SSHClient.java
index 26729207bb..b5d645952c 100644
--- a/core-common/src/main/java/org/apache/kylin/common/util/SSHClient.java
+++ b/core-common/src/main/java/org/apache/kylin/common/util/SSHClient.java
@@ -42,6 +42,7 @@
public class SSHClient {
protected static final org.slf4j.Logger logger =
LoggerFactory.getLogger(SSHClient.class);
+private static final String ERROR_IN_CHECK_ACK = "Error in checkAck()";
private String hostname;
private int port;
@@ -97,7 +98,7 @@ public void scpFileToRemote(String localFile, String
remoteTargetDirectory) thro
out.write(command.getBytes(StandardCharsets.UTF_8));
out.flush();
if (checkAck(in) != 0) {
-throw new Exception("Error in checkAck()");
+throw new Exception(ERROR_IN_CHECK_ACK);
}
}
@@ -115,7 +116,7 @@ public void scpFileToRemote(String localFile, String
remoteTargetDirectory) thro
out.write(command.getBytes(StandardCharsets.UTF_8));
out.flush();
if (checkAck(in) != 0) {
-throw new Exception("Error in checkAck()");
+throw new Exception(ERROR_IN_CHECK_ACK);
}
// send a content of lfile
@@ -134,7 +135,7 @@ public void scpFileToRemote(String localFile, String
remoteTargetDirectory) thro
out.write(buf, 0, 1);
out.flush();
if (checkAck(in) != 0) {
-throw new Exception("Error in checkAck()");
+throw new Exception(ERROR_IN_CHECK_ACK);
}
out.close();
diff --git
a/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java
b/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java
index 057f7e84e2..54c6764023 100644
---
a/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java
+++
b/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java
@@ -20,6 +20,7 @@
import java.io.IOException;
import java.util.List;
+import java.util.Locale;
import java.util.Map;
import java.util.concurrent.Callable;
import java.util.concurrent.ExecutionException;
@@ -97,20 +98,20 @@ public static CuboidRecommender getInstance() {
true);
if (recommendCuboid != null) {
-logger.info("Add recommend cuboids for " + key
+ " to cache");
+logger.info(String.format(Locale.ROOT, "Add
recommend cuboids for %s to cache", key));
cuboidRecommendCache.put(key, recommendCuboid);
}
return recommendCuboid;
} catch (Exception e) {
cuboidRecommendCache.invalidate(key);
-logger.error("Failed to get recommend cuboids for
" + key + " in cache", e);
+logger.error(String.format(Locale.ROOT, "Failed to
get recommend cuboids for %s in cache", key), e);
throw e;
}
}
});
} catch (ExecutionException e) {
-logger.error("Failed to get recommend cuboids for " + key);
+logger.error(String.format(Locale.ROOT, "Failed to get
recommend cuboids for %s", key));
}
}
return results;
@@ -121,9 +122,9 @@ public static CuboidRecommender getInstance() {
*/
public Map getRecommendCuboidList(CuboidStats cuboidStats,
KylinConfig kylinConf,
boolean ifForceRecommend) {
-long Threshold1 = 1L <<
kylinConf.getCubePlannerAgreedyAlgorithmAutoThreshold();
-long Threshold2 = 1L <<
kylinConf.getCubePlannerGeneticAlgorithmAutoThreshold();
-if (Threshold1 >= Threshold2) {
+long threshold1 = 1L <<
kylinConf.getCubePlannerAgreedyAlgorithmAutoThreshold();
+long threshold2 = 1L <<
kylinConf.getCubePlannerGeneticAlgorithmAutoThreshold();
+if (threshold1 >=
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722148#comment-16722148
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi closed pull request #393: KYLIN-3597 improve code smell
URL: https://github.com/apache/kylin/pull/393
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
index 018552caf1..f67f6b3479 100644
--- a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
+++ b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
@@ -62,6 +62,8 @@
private static final String DEFAULT = "default";
private static final String KYLIN_ENGINE_MR_JOB_JAR =
"kylin.engine.mr.job-jar";
private static final String KYLIN_STORAGE_HBASE_COPROCESSOR_LOCAL_JAR =
"kylin.storage.hbase.coprocessor-local-jar";
+private static final String FILE_SCHEME = "file:";
+private static final String MAPRFS_SCHEME = "maprfs:";
/*
* DON'T DEFINE CONSTANTS FOR PROPERTY KEYS!
@@ -264,10 +266,10 @@ public String getHdfsWorkingDirectory() {
root += "/";
cachedHdfsWorkingDirectory = root;
-if (cachedHdfsWorkingDirectory.startsWith("file:")) {
-cachedHdfsWorkingDirectory =
cachedHdfsWorkingDirectory.replace("file:", "file://");
-} else if (cachedHdfsWorkingDirectory.startsWith("maprfs:")) {
-cachedHdfsWorkingDirectory =
cachedHdfsWorkingDirectory.replace("maprfs:", "maprfs://");
+if (cachedHdfsWorkingDirectory.startsWith(FILE_SCHEME)) {
+cachedHdfsWorkingDirectory =
cachedHdfsWorkingDirectory.replace(FILE_SCHEME, "file://");
+} else if (cachedHdfsWorkingDirectory.startsWith(MAPRFS_SCHEME)) {
+cachedHdfsWorkingDirectory =
cachedHdfsWorkingDirectory.replace(MAPRFS_SCHEME, "maprfs://");
}
return cachedHdfsWorkingDirectory;
}
@@ -302,10 +304,10 @@ public String getMetastoreBigCellHdfsDirectory() {
root += "/";
cachedBigCellDirectory = root;
-if (cachedBigCellDirectory.startsWith("file:")) {
-cachedBigCellDirectory = cachedBigCellDirectory.replace("file:",
"file://");
-} else if (cachedBigCellDirectory.startsWith("maprfs:")) {
-cachedBigCellDirectory = cachedBigCellDirectory.replace("maprfs:",
"maprfs://");
+if (cachedBigCellDirectory.startsWith(FILE_SCHEME)) {
+cachedBigCellDirectory =
cachedBigCellDirectory.replace(FILE_SCHEME, "file://");
+} else if (cachedBigCellDirectory.startsWith(MAPRFS_SCHEME)) {
+cachedBigCellDirectory =
cachedBigCellDirectory.replace(MAPRFS_SCHEME, "maprfs://");
}
return cachedBigCellDirectory;
@@ -411,7 +413,7 @@ public String getMetadataUrlPrefix() {
}
public boolean isResourceStoreReconnectEnabled() {
-return
Boolean.parseBoolean(getOptional("kylin.resourcestore.reconnect-enabled",
"false"));
+return
Boolean.parseBoolean(getOptional("kylin.resourcestore.reconnect-enabled",
FALSE));
}
public int getResourceStoreReconnectBaseMs() {
@@ -1445,7 +1447,7 @@ public int getScanThreshold() {
}
public boolean isLazyQueryEnabled() {
-return
Boolean.parseBoolean(getOptional("kylin.query.lazy-query-enabled", "false"));
+return
Boolean.parseBoolean(getOptional("kylin.query.lazy-query-enabled", FALSE));
}
public long getLazyQueryWaitingTimeoutMilliSeconds() {
@@ -1543,7 +1545,7 @@ public String getMemCachedHosts() {
}
public boolean isQuerySegmentCacheEnabled() {
-return
Boolean.parseBoolean(getOptional("kylin.query.segment-cache-enabled", "false"));
+return
Boolean.parseBoolean(getOptional("kylin.query.segment-cache-enabled", FALSE));
}
public int getQuerySegmentCacheTimeout() {
@@ -1665,7 +1667,7 @@ public String getSQLResponseSignatureClass() {
}
public boolean isQueryCacheSignatureEnabled() {
-return
Boolean.parseBoolean(this.getOptional("kylin.query.cache-signature-enabled",
"false"));
+return
Boolean.parseBoolean(this.getOptional("kylin.query.cache-signature-enabled",
FALSE));
}
//
diff --git
a/core-common/src/main/java/org/apache/kylin/common/persistence/ContentWriter.java
b/core-common/src/main/java/org/apache/kylin/common/persistence/ContentWriter.java
index 25420a4d7e..c7d963d40c 100644
---
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721014#comment-16721014 ] ASF GitHub Bot commented on KYLIN-3597: --- caolijun1166 opened a new pull request #393: KYLIN-3597 improve code smell URL: https://github.com/apache/kylin/pull/393 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720991#comment-16720991 ] ASF GitHub Bot commented on KYLIN-3597: --- whuwb opened a new pull request #392: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/392 fix sonar issues This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718374#comment-16718374 ] ASF subversion and git services commented on KYLIN-3597: Commit 23732b207d90a2a5ad9068e07c3b5176bceb0406 in kylin's branch refs/heads/master from whuwb [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=23732b2 ] KYLIN-3597 fix sonar issues > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718373#comment-16718373
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi closed pull request #383: KYLIN-3597 fix sonar issues
URL: https://github.com/apache/kylin/pull/383
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/KylinVersion.java
b/core-common/src/main/java/org/apache/kylin/common/KylinVersion.java
index ae18d0b57b..bbdb3a8645 100644
--- a/core-common/src/main/java/org/apache/kylin/common/KylinVersion.java
+++ b/core-common/src/main/java/org/apache/kylin/common/KylinVersion.java
@@ -34,8 +34,8 @@
import com.google.common.collect.Iterables;
public class KylinVersion implements Comparable {
-private static final String COMMIT_SHA1_v15 = "commit_SHA1";
-private static final String COMMIT_SHA1_v13 = "commit.sha1";
+private static final String COMMIT_SHA1_V15 = "commit_SHA1";
+private static final String COMMIT_SHA1_V13 = "commit.sha1";
public final int major;
public final int minor;
@@ -194,9 +194,9 @@ public static String getKylinClientInformation() {
public static String getGitCommitInfo() {
try {
-File commitFile = new File(KylinConfig.getKylinHome(),
COMMIT_SHA1_v15);
+File commitFile = new File(KylinConfig.getKylinHome(),
COMMIT_SHA1_V15);
if (!commitFile.exists()) {
-commitFile = new File(KylinConfig.getKylinHome(),
COMMIT_SHA1_v13);
+commitFile = new File(KylinConfig.getKylinHome(),
COMMIT_SHA1_V13);
}
List lines = FileUtils.readLines(commitFile,
Charset.defaultCharset());
StringBuilder sb = new StringBuilder();
diff --git
a/core-common/src/main/java/org/apache/kylin/common/QueryContext.java
b/core-common/src/main/java/org/apache/kylin/common/QueryContext.java
index a065a13f11..000f7bf28a 100644
--- a/core-common/src/main/java/org/apache/kylin/common/QueryContext.java
+++ b/core-common/src/main/java/org/apache/kylin/common/QueryContext.java
@@ -40,6 +40,9 @@
public class QueryContext {
private static final Logger logger =
LoggerFactory.getLogger(QueryContext.class);
+private static final String CSSR_SHOULD_BE_INIT_FOR_CONTEXT =
"CubeSegmentStatisticsResult should be initialized for context {}";
+private static final String CSSM_SHOULD_BE_INIT_FOR_CSSR =
"cubeSegmentStatisticsMap should be initialized for CubeSegmentStatisticsResult
with query type {}";
+private static final String INPUT = " input ";
public interface QueryStopListener {
void stop(QueryContext query);
@@ -208,13 +211,12 @@ public void setContextRealization(int ctxId, String
realizationName, int realiza
public CubeSegmentStatistics getCubeSegmentStatistics(int ctxId, String
cubeName, String segmentName) {
CubeSegmentStatisticsResult cubeSegmentStatisticsResult =
cubeSegmentStatisticsResultMap.get(ctxId);
if (cubeSegmentStatisticsResult == null) {
-logger.warn("CubeSegmentStatisticsResult should be initialized for
context {}", ctxId);
+logger.warn(CSSR_SHOULD_BE_INIT_FOR_CONTEXT, ctxId);
return null;
}
ConcurrentMap>
cubeSegmentStatisticsMap = cubeSegmentStatisticsResult.cubeSegmentStatisticsMap;
if (cubeSegmentStatisticsMap == null) {
-logger.warn(
-"cubeSegmentStatisticsMap should be initialized for
CubeSegmentStatisticsResult with query type {}",
cubeSegmentStatisticsResult.queryType);
+logger.warn(CSSM_SHOULD_BE_INIT_FOR_CSSR,
cubeSegmentStatisticsResult.queryType);
return null;
}
ConcurrentMap segmentStatisticsMap =
cubeSegmentStatisticsMap.get(cubeName);
@@ -235,13 +237,12 @@ public CubeSegmentStatistics getCubeSegmentStatistics(int
ctxId, String cubeName
public void addCubeSegmentStatistics(int ctxId, CubeSegmentStatistics
cubeSegmentStatistics) {
CubeSegmentStatisticsResult cubeSegmentStatisticsResult =
cubeSegmentStatisticsResultMap.get(ctxId);
if (cubeSegmentStatisticsResult == null) {
-logger.warn("CubeSegmentStatisticsResult should be initialized for
context {}", ctxId);
+logger.warn(CSSR_SHOULD_BE_INIT_FOR_CONTEXT, ctxId);
return;
}
ConcurrentMap>
cubeSegmentStatisticsMap = cubeSegmentStatisticsResult.cubeSegmentStatisticsMap;
if (cubeSegmentStatisticsMap == null) {
-logger.warn(
-"cubeSegmentStatisticsMap should be initialized for
CubeSegmentStatisticsResult with
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718309#comment-16718309 ] ASF subversion and git services commented on KYLIN-3597: Commit 0b31a911302c0754ae6da5745d127dcaa336a467 in kylin's branch refs/heads/master from hit-lacus [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=0b31a91 ] KYLIN-3597 Improve code smell > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718308#comment-16718308
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi closed pull request #378: KYLIN-3597 Improve code smell
URL: https://github.com/apache/kylin/pull/378
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
b/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
index 4fb9522c96..a7459c0494 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
@@ -21,6 +21,7 @@
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
+import java.util.Locale;
import java.util.Map;
import org.apache.commons.lang3.StringUtils;
@@ -60,12 +61,15 @@
private static final Logger logger =
LoggerFactory.getLogger(CubeDescManager.class);
-public static final Serializer CUBE_DESC_SERIALIZER = new
JsonSerializer(CubeDesc.class);
+public static final Serializer CUBE_DESC_SERIALIZER = new
JsonSerializer<>(CubeDesc.class);
public static CubeDescManager getInstance(KylinConfig config) {
return config.getManager(CubeDescManager.class);
}
+static final String BROKEN_CUBE_MSG = "Broken cube desc %s";
+static final String CUBE_SHOULD_NOT_BE_DRAFT_MSG = "CubeDesc '%s' must not
be a draft";
+
// called by reflection
static CubeDescManager newInstance(KylinConfig config) throws IOException {
return new CubeDescManager(config);
@@ -84,20 +88,20 @@ static CubeDescManager newInstance(KylinConfig config)
throws IOException {
private AutoReadWriteLock descMapLock = new AutoReadWriteLock();
private CubeDescManager(KylinConfig cfg) throws IOException {
-logger.info("Initializing CubeDescManager with config " + cfg);
+logger.info("Initializing CubeDescManager with config {}", cfg);
this.config = cfg;
-this.cubeDescMap = new CaseInsensitiveStringCache(config,
"cube_desc");
+this.cubeDescMap = new CaseInsensitiveStringCache<>(config,
"cube_desc");
this.crud = new CachedCrudAssist(getStore(),
ResourceStore.CUBE_DESC_RESOURCE_ROOT, CubeDesc.class,
cubeDescMap) {
@Override
protected CubeDesc initEntityAfterReload(CubeDesc cubeDesc, String
resourceName) {
if (cubeDesc.isDraft())
-throw new IllegalArgumentException("CubeDesc '" +
cubeDesc.getName() + "' must not be a draft");
+throw new
IllegalArgumentException(String.format(Locale.ROOT,
CUBE_SHOULD_NOT_BE_DRAFT_MSG, cubeDesc.getName()));
try {
cubeDesc.init(config);
} catch (Exception e) {
-logger.warn("Broken cube desc " + cubeDesc.resourceName(),
e);
+logger.warn(String.format(Locale.ROOT, BROKEN_CUBE_MSG,
cubeDesc.resourceName()), e);
cubeDesc.addError(e.toString());
}
return cubeDesc;
@@ -175,10 +179,6 @@ public CubeDesc reloadCubeDescLocal(String name) throws
IOException {
/**
* Create a new CubeDesc
- *
- * @param cubeDesc
- * @return
- * @throws IOException
*/
public CubeDesc createCubeDesc(CubeDesc cubeDesc) throws IOException {
try (AutoLock lock = descMapLock.lockForWrite()) {
@@ -187,7 +187,7 @@ public CubeDesc createCubeDesc(CubeDesc cubeDesc) throws
IOException {
if (cubeDescMap.containsKey(cubeDesc.getName()))
throw new IllegalArgumentException("CubeDesc '" +
cubeDesc.getName() + "' already exists");
if (cubeDesc.isDraft())
-throw new IllegalArgumentException("CubeDesc '" +
cubeDesc.getName() + "' must not be a draft");
+throw new IllegalArgumentException(String.format(Locale.ROOT,
CUBE_SHOULD_NOT_BE_DRAFT_MSG, cubeDesc.getName()));
try {
cubeDesc.init(config);
@@ -219,10 +219,6 @@ public CubeDesc createCubeDesc(CubeDesc cubeDesc) throws
IOException {
/**
* Update CubeDesc with the input. Broadcast the event into cluster
- *
- * @param desc
- * @return
- * @throws IOException
*/
public CubeDesc updateCubeDesc(CubeDesc desc) throws IOException {
try (AutoLock lock = descMapLock.lockForWrite()) {
@@ -233,7 +229,7 @@ public CubeDesc updateCubeDesc(CubeDesc desc) throws
IOException {
if (!cubeDescMap.containsKey(name))
throw new
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716430#comment-16716430 ] ASF GitHub Bot commented on KYLIN-3597: --- whuwb opened a new pull request #383: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/383 [INFO] Reactor Summary for Apache Kylin 2.6.0-SNAPSHOT: [INFO] [INFO] Apache Kylin ... SUCCESS [ 9.532 s] [INFO] Apache Kylin - Core Common . SUCCESS [ 16.622 s] [INFO] Apache Kylin - Core Metadata ... SUCCESS [ 55.307 s] [INFO] Apache Kylin - Core Dictionary . SUCCESS [04:43 min] [INFO] Apache Kylin - Core Cube ... SUCCESS [01:22 min] [INFO] Apache Kylin - Core Metrics SUCCESS [ 1.574 s] [INFO] Apache Kylin - Core Job SUCCESS [ 45.869 s] [INFO] Apache Kylin - Core Storage SUCCESS [ 8.851 s] [INFO] Apache Kylin - MapReduce Engine SUCCESS [ 23.260 s] [INFO] Apache Kylin - Spark Engine SUCCESS [ 8.053 s] [INFO] Apache Kylin - Hive Source . SUCCESS [ 6.935 s] [INFO] Apache Kylin - DataSource SDK .. SUCCESS [ 11.676 s] [INFO] Apache Kylin - Jdbc Source . SUCCESS [ 21.074 s] [INFO] Apache Kylin - Kafka Source SUCCESS [ 5.867 s] [INFO] Apache Kylin - Cache ... SUCCESS [ 10.135 s] [INFO] Apache Kylin - HBase Storage ... SUCCESS [ 18.042 s] [INFO] Apache Kylin - Query ... SUCCESS [ 13.160 s] [INFO] Apache Kylin - Metrics Reporter Hive ... SUCCESS [ 1.023 s] [INFO] Apache Kylin - Metrics Reporter Kafka .. SUCCESS [ 0.795 s] [INFO] Apache Kylin - REST Server Base SUCCESS [ 30.443 s] [INFO] Apache Kylin - REST Server . SUCCESS [01:38 min] [INFO] Apache Kylin - JDBC Driver . SUCCESS [ 10.255 s] [INFO] Apache Kylin - Assembly SUCCESS [ 16.523 s] [INFO] Apache Kylin - Tool SUCCESS [ 13.613 s] [INFO] Apache Kylin - Tool Assembly ... SUCCESS [ 4.267 s] [INFO] Apache Kylin - Integration Test SUCCESS [ 02:45 h] [INFO] Apache Kylin - Tomcat Extension SUCCESS [ 3.378 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 02:58 h [INFO] Finished at: 2018-12-08T04:15:53Z [INFO] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714743#comment-16714743 ] ASF subversion and git services commented on KYLIN-3597: Commit 497cdf0c3bf0bee3bcc1c9d9ff21b0a00448f42e in kylin's branch refs/heads/master from whuwb [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=497cdf0 ] KYLIN-3597 fix sonar issues > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714742#comment-16714742 ] ASF subversion and git services commented on KYLIN-3597: Commit 4e171c8b0fbcd7a6ffaa24e62a12dd7a070ccd49 in kylin's branch refs/heads/master from whuwb [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=4e171c8 ] KYLIN-3597 fix snoar issues > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714741#comment-16714741
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi closed pull request #379: KYLIN-3597 fix sonar issues
URL: https://github.com/apache/kylin/pull/379
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/BackwardCompatibilityConfig.java
b/core-common/src/main/java/org/apache/kylin/common/BackwardCompatibilityConfig.java
index aeb7636059..751d2f7da6 100644
---
a/core-common/src/main/java/org/apache/kylin/common/BackwardCompatibilityConfig.java
+++
b/core-common/src/main/java/org/apache/kylin/common/BackwardCompatibilityConfig.java
@@ -144,26 +144,21 @@ private static void generateFindAndReplaceScript(String
kylinRepoPath, String ou
BackwardCompatibilityConfig bcc = new BackwardCompatibilityConfig();
File repoDir = new File(kylinRepoPath).getCanonicalFile();
File outputDir = new File(outputPath).getCanonicalFile();
-PrintWriter out = null;
// generate sed file
File sedFile = new File(outputDir, "upgrade-old-config.sed");
-try {
-out = new PrintWriter(sedFile, "UTF-8");
+try (PrintWriter out = new PrintWriter(sedFile, "UTF-8")) {
for (Entry e : bcc.old2new.entrySet()) {
out.println("s/" + quote(e.getKey()) + "/" + e.getValue() +
"/g");
}
for (Entry e : bcc.old2newPrefix.entrySet()) {
out.println("s/" + quote(e.getKey()) + "/" + e.getValue() +
"/g");
}
-} finally {
-IOUtils.closeQuietly(out);
}
// generate sh file
File shFile = new File(outputDir, "upgrade-old-config.sh");
-try {
-out = new PrintWriter(shFile, "UTF-8");
+try (PrintWriter out = new PrintWriter(shFile, "UTF-8")) {
out.println("#!/bin/bash");
Stack stack = new Stack<>();
stack.push(repoDir);
@@ -179,8 +174,6 @@ private static void generateFindAndReplaceScript(String
kylinRepoPath, String ou
out.println("sed -i -f upgrade-old-config.sed " +
f.getAbsolutePath());
}
}
-} finally {
-IOUtils.closeQuietly(out);
}
System.out.println("Files generated:");
diff --git a/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
b/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
index 4a86b762f3..4db1748910 100644
--- a/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
+++ b/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
@@ -50,6 +50,7 @@
public class KylinConfig extends KylinConfigBase {
private static final long serialVersionUID = 1L;
private static final Logger logger =
LoggerFactory.getLogger(KylinConfig.class);
+private static final String METADATA_URI_PREFIX = "Metadata uri : ";
/**
* Kylin properties file name
@@ -192,20 +193,20 @@ private static UriType decideUriType(String metaUri) {
return UriType.PROPERTIES_FILE;
} else {
throw new IllegalStateException(
-"Metadata uri : " + metaUri + " is a local
file but not kylin.properties");
+METADATA_URI_PREFIX + metaUri + " is a local
file but not kylin.properties");
}
} else {
throw new IllegalStateException(
-"Metadata uri : " + metaUri + " looks like a file
but it's neither a file nor a directory");
+METADATA_URI_PREFIX + metaUri + " looks like a
file but it's neither a file nor a directory");
}
} else {
if (RestClient.matchFullRestPattern(metaUri))
return UriType.REST_ADDR;
else
-throw new IllegalStateException("Metadata uri : " +
metaUri + " is not a valid REST URI address");
+throw new IllegalStateException(METADATA_URI_PREFIX +
metaUri + " is not a valid REST URI address");
}
} catch (Exception e) {
-throw new IllegalStateException("Metadata uri : " + metaUri + " is
not recognized", e);
+throw new IllegalStateException(METADATA_URI_PREFIX + metaUri + "
is not recognized", e);
}
}
@@ -393,9 +394,8 @@ private static OrderedProperties buildSiteOrderedProps() {
*/
private static void
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714670#comment-16714670 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io commented on issue #379: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/379#issuecomment-445802919 # [Codecov](https://codecov.io/gh/apache/kylin/pull/379?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@684f21c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `16.66%`. [](https://codecov.io/gh/apache/kylin/pull/379?src=pr=tree) ```diff @@Coverage Diff@@ ## master #379 +/- ## = Coverage ? 23.64% Complexity? 4882 = Files ? 1134 Lines ?68641 Branches ? 9750 = Hits ?16228 Misses?50826 Partials ? 1587 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/379?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/kylin/common/BackwardCompatibilityConfig.java](https://codecov.io/gh/apache/kylin/pull/379/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9CYWNrd2FyZENvbXBhdGliaWxpdHlDb25maWcuamF2YQ==) | `41.81% <0%> (ø)` | `15 <0> (?)` | | | [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/379/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh) | `36.17% <25%> (ø)` | `23 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/379?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/379?src=pr=footer). Last update [684f21c...5109f65](https://codecov.io/gh/apache/kylin/pull/379?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714640#comment-16714640 ] ASF GitHub Bot commented on KYLIN-3597: --- asfgit commented on issue #379: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/379#issuecomment-445794610 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714639#comment-16714639 ] ASF GitHub Bot commented on KYLIN-3597: --- whuwb opened a new pull request #379: KYLIN-3597 fix sonar issues URL: https://github.com/apache/kylin/pull/379 [INFO] [INFO] Reactor Summary for Apache Kylin 2.6.0-SNAPSHOT: [INFO] [INFO] Apache Kylin ... SUCCESS [ 6.897 s] [INFO] Apache Kylin - Core Common . SUCCESS [ 14.739 s] [INFO] Apache Kylin - Core Metadata ... SUCCESS [ 58.231 s] [INFO] Apache Kylin - Core Dictionary . SUCCESS [05:17 min] [INFO] Apache Kylin - Core Cube ... SUCCESS [01:21 min] [INFO] Apache Kylin - Core Metrics SUCCESS [ 1.472 s] [INFO] Apache Kylin - Core Job SUCCESS [ 43.913 s] [INFO] Apache Kylin - Core Storage SUCCESS [ 8.012 s] [INFO] Apache Kylin - MapReduce Engine SUCCESS [ 19.776 s] [INFO] Apache Kylin - Spark Engine SUCCESS [ 7.607 s] [INFO] Apache Kylin - Hive Source . SUCCESS [ 7.070 s] [INFO] Apache Kylin - DataSource SDK .. SUCCESS [ 12.198 s] [INFO] Apache Kylin - Jdbc Source . SUCCESS [ 20.597 s] [INFO] Apache Kylin - Kafka Source SUCCESS [ 5.457 s] [INFO] Apache Kylin - Cache ... SUCCESS [ 9.464 s] [INFO] Apache Kylin - HBase Storage ... SUCCESS [ 17.873 s] [INFO] Apache Kylin - Query ... SUCCESS [ 13.782 s] [INFO] Apache Kylin - Metrics Reporter Hive ... SUCCESS [ 0.985 s] [INFO] Apache Kylin - Metrics Reporter Kafka .. SUCCESS [ 0.869 s] [INFO] Apache Kylin - REST Server Base SUCCESS [ 28.272 s] [INFO] Apache Kylin - REST Server . SUCCESS [01:35 min] [INFO] Apache Kylin - JDBC Driver . SUCCESS [ 8.622 s] [INFO] Apache Kylin - Assembly SUCCESS [ 16.291 s] [INFO] Apache Kylin - Tool SUCCESS [ 12.324 s] [INFO] Apache Kylin - Tool Assembly ... SUCCESS [ 3.907 s] [INFO] Apache Kylin - Integration Test SUCCESS [ 02:38 h] [INFO] Apache Kylin - Tomcat Extension SUCCESS [ 2.266 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 02:52 h [INFO] Finished at: 2018-12-07T19:22:25Z [INFO] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714519#comment-16714519 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io commented on issue #378: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/378#issuecomment-445759183 # [Codecov](https://codecov.io/gh/apache/kylin/pull/378?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@684f21c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `9.8%`. [](https://codecov.io/gh/apache/kylin/pull/378?src=pr=tree) ```diff @@Coverage Diff@@ ## master #378 +/- ## = Coverage ? 23.63% Complexity? 4881 = Files ? 1134 Lines ?68648 Branches ? 9749 = Hits ?16225 Misses?50834 Partials ? 1589 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/378?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...kylin/measure/percentile/PercentileSerializer.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9wZXJjZW50aWxlL1BlcmNlbnRpbGVTZXJpYWxpemVyLmphdmE=) | `75% <ø> (ø)` | `5 <0> (?)` | | | [...apache/kylin/storage/hbase/util/RowCounterCLI.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL1Jvd0NvdW50ZXJDTEkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...e/kylin/source/kafka/util/KafkaSampleProducer.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvdXRpbC9LYWZrYVNhbXBsZVByb2R1Y2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ylin/query/relnode/visitor/TupleFilterVisitor.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvdmlzaXRvci9UdXBsZUZpbHRlclZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0RvZ2dlZEN1YmVCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...pache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0luTWVtQ3ViZUJ1aWxkZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `58.97% <25%> (ø)` | `19 <0> (?)` | | | [...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/378/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh) | `33.81% <57.14%> (ø)` | `12 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/378?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/378?src=pr=footer). Last update [684f21c...74ef7e8](https://codecov.io/gh/apache/kylin/pull/378?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues >
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714494#comment-16714494 ] ASF GitHub Bot commented on KYLIN-3597: --- asfgit commented on issue #378: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/378#issuecomment-445750812 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714493#comment-16714493 ] ASF GitHub Bot commented on KYLIN-3597: --- hit-lacus opened a new pull request #378: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/378 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714496#comment-16714496 ] ASF GitHub Bot commented on KYLIN-3597: --- hit-lacus commented on issue #378: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/378#issuecomment-445750880 Local CI test pass. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714335#comment-16714335 ] ASF subversion and git services commented on KYLIN-3597: Commit 39878baa405385e850820838f86fcfe56a10b0ca in kylin's branch refs/heads/kylin-on-parquet from Wu Bin [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=39878ba ] Issue 3597 fix sonar issues (#375) * KYLIN-3597 fix sonar issues > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713605#comment-16713605 ] ASF subversion and git services commented on KYLIN-3597: Commit 39878baa405385e850820838f86fcfe56a10b0ca in kylin's branch refs/heads/master from Wu Bin [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=39878ba ] Issue 3597 fix sonar issues (#375) * KYLIN-3597 fix sonar issues > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713539#comment-16713539 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3927](https://coveralls.io/builds/20514049) * **12** of **76** **(15.79%)** changed or added relevant lines in **9** files are covered. * **11** unchanged lines in **5** files lost coverage. * Overall coverage decreased (**-0.001%**) to **25.943%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [query/src/main/java/org/apache/kylin/query/util/QueryUtil.java](https://coveralls.io/builds/20514049/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FQueryUtil.java#L129) | 3 | 4 | 75.0% | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20514049/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L62) | 0 | 3 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/20514049/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L99) | 4 | 8 | 50.0% | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20514049/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L135) | 0 | 5 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20514049/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L96) | 0 | 6 | 0.0% | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaSampleProducer.java](https://coveralls.io/builds/20514049/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaSampleProducer.java#L59) | 0 | 6 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20514049/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L63) | 0 | 7 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20514049/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L137) | 0 | 32 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20514049/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L47) | 1 | 0.0% | | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaSampleProducer.java](https://coveralls.io/builds/20514049/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaSampleProducer.java#L141) | 1 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/20514049/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20514049/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L132) | 3 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20514049/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L114) | 4 | 0.0% | | Totals | [](https://coveralls.io/builds/20514049) | | :-- | --: | | Change from base [Build 3920](https://coveralls.io/builds/20502796): | -0.001% | | Covered Lines: | 17694 | | Relevant Lines: | 68204 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713535#comment-16713535 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3921](https://coveralls.io/builds/20502981) * **9** of **65** **(13.85%)** changed or added relevant lines in **9** files are covered. * **193** unchanged lines in **7** files lost coverage. * Overall coverage decreased (**-0.005%**) to **25.939%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [query/src/main/java/org/apache/kylin/query/util/QueryUtil.java](https://coveralls.io/builds/20502981/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FQueryUtil.java#L129) | 2 | 3 | 66.67% | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20502981/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L63) | 0 | 2 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20502981/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L135) | 0 | 3 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L99) | 4 | 8 | 50.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L96) | 0 | 5 | 0.0% | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaSampleProducer.java](https://coveralls.io/builds/20502981/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaSampleProducer.java#L59) | 0 | 5 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L63) | 0 | 7 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L137) | 0 | 29 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L47) | 1 | 0.0% | | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/20502981/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20502981/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L68) | 4 | 0.0% | | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20502981/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L132) | 41 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L178) | 65 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20502981/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L114) | 79 | 0.0% | | Totals | [](https://coveralls.io/builds/20502981) | | :-- | --: | | Change from base [Build
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713528#comment-16713528 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3923](https://coveralls.io/builds/20504200) * **9** of **71** **(12.68%)** changed or added relevant lines in **9** files are covered. * **29** unchanged lines in **6** files lost coverage. * Overall coverage decreased (**-0.001%**) to **25.942%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [query/src/main/java/org/apache/kylin/query/util/QueryUtil.java](https://coveralls.io/builds/20504200/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FQueryUtil.java#L129) | 2 | 3 | 66.67% | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20504200/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L63) | 0 | 2 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/20504200/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L99) | 4 | 8 | 50.0% | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20504200/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L135) | 0 | 5 | 0.0% | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaSampleProducer.java](https://coveralls.io/builds/20504200/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaSampleProducer.java#L59) | 0 | 5 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20504200/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L96) | 0 | 6 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20504200/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L63) | 0 | 7 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20504200/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L137) | 0 | 32 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20504200/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L47) | 1 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/20504200/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20504200/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L132) | 3 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20504200/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L114) | 4 | 0.0% | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20504200/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L68) | 4 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/20504200/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L284) | 15 | 38.3% | | Totals | [](https://coveralls.io/builds/20504200) | | :-- | --: | | Change from base [Build 3920](https://coveralls.io/builds/20502796): | -0.001% | | Covered Lines: | 17693 | | Relevant Lines: | 68201 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713530#comment-16713530 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3924](https://coveralls.io/builds/20504806) * **12** of **76** **(15.79%)** changed or added relevant lines in **9** files are covered. * **31** unchanged lines in **7** files lost coverage. * Overall coverage decreased (**-0.005%**) to **25.939%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [query/src/main/java/org/apache/kylin/query/util/QueryUtil.java](https://coveralls.io/builds/20504806/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FQueryUtil.java#L129) | 3 | 4 | 75.0% | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20504806/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L62) | 0 | 3 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/20504806/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L99) | 4 | 8 | 50.0% | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20504806/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L135) | 0 | 5 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20504806/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L96) | 0 | 6 | 0.0% | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaSampleProducer.java](https://coveralls.io/builds/20504806/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaSampleProducer.java#L59) | 0 | 6 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20504806/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L63) | 0 | 7 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20504806/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L137) | 0 | 32 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20504806/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L47) | 1 | 0.0% | | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaSampleProducer.java](https://coveralls.io/builds/20504806/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaSampleProducer.java#L141) | 1 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/20504806/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20504806/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L132) | 3 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20504806/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L114) | 4 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20504806/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/20504806/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L284) | 15 | 38.3% | | Totals | [](https://coveralls.io/builds/20504806) | | :-- | --: | | Change from base [Build
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713527#comment-16713527 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3919](https://coveralls.io/builds/20502519) * **9** of **61** **(14.75%)** changed or added relevant lines in **9** files are covered. * **212** unchanged lines in **5** files lost coverage. * Overall coverage decreased (**-0.0008%**) to **25.943%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [query/src/main/java/org/apache/kylin/query/util/QueryUtil.java](https://coveralls.io/builds/20502519/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FQueryUtil.java#L129) | 2 | 3 | 66.67% | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20502519/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L63) | 0 | 2 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20502519/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L135) | 0 | 3 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/20502519/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L99) | 4 | 8 | 50.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20502519/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L96) | 0 | 5 | 0.0% | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaSampleProducer.java](https://coveralls.io/builds/20502519/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaSampleProducer.java#L59) | 0 | 5 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20502519/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L63) | 0 | 7 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20502519/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L137) | 0 | 25 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20502519/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L47) | 1 | 0.0% | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20502519/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L68) | 4 | 0.0% | | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20502519/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L132) | 41 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20502519/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L178) | 65 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20502519/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L113) | 101 | 0.0% | | Totals | [](https://coveralls.io/builds/20502519) | | :-- | --: | | Change from base [Build 3920](https://coveralls.io/builds/20502796): | -0.0008% | | Covered Lines: | 17695 | | Relevant Lines: | 68207 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713522#comment-16713522 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3926](https://coveralls.io/builds/20509512) * **12** of **76** **(15.79%)** changed or added relevant lines in **9** files are covered. * **26** unchanged lines in **6** files lost coverage. * Overall coverage remained the same at **25.942%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [query/src/main/java/org/apache/kylin/query/util/QueryUtil.java](https://coveralls.io/builds/20509512/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FQueryUtil.java#L129) | 3 | 4 | 75.0% | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20509512/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L62) | 0 | 3 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/20509512/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L99) | 4 | 8 | 50.0% | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20509512/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L135) | 0 | 5 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20509512/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L96) | 0 | 6 | 0.0% | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaSampleProducer.java](https://coveralls.io/builds/20509512/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaSampleProducer.java#L59) | 0 | 6 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20509512/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L63) | 0 | 7 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20509512/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L137) | 0 | 32 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20509512/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L47) | 1 | 0.0% | | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaSampleProducer.java](https://coveralls.io/builds/20509512/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaSampleProducer.java#L141) | 1 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/20509512/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20509512/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L132) | 3 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20509512/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L114) | 4 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/20509512/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L284) | 15 | 38.3% | | Totals | [](https://coveralls.io/builds/20509512) | | :-- | --: | | Change from base [Build 3920](https://coveralls.io/builds/20502796): | 0.0% | | Covered Lines: | 17694 | | Relevant Lines: | 68206 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713518#comment-16713518 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls commented on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445429198 ## Pull Request Test Coverage Report for [Build 3922](https://coveralls.io/builds/20503129) * **9** of **65** **(13.85%)** changed or added relevant lines in **9** files are covered. * **447** unchanged lines in **10** files lost coverage. * Overall coverage remained the same at **25.925%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [query/src/main/java/org/apache/kylin/query/util/QueryUtil.java](https://coveralls.io/builds/20503129/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FQueryUtil.java#L129) | 2 | 3 | 66.67% | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20503129/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L63) | 0 | 2 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20503129/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L135) | 0 | 3 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/20503129/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L99) | 4 | 8 | 50.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20503129/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L96) | 0 | 5 | 0.0% | [source-kafka/src/main/java/org/apache/kylin/source/kafka/util/KafkaSampleProducer.java](https://coveralls.io/builds/20503129/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2Futil%2FKafkaSampleProducer.java#L59) | 0 | 5 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20503129/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L63) | 0 | 7 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://coveralls.io/builds/20503129/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FInMemCubeBuilder.java#L137) | 0 | 29 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://coveralls.io/builds/20503129/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcli%2FDictionaryGeneratorCLI.java#L47) | 1 | 0.0% | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/RowCounterCLI.java](https://coveralls.io/builds/20503129/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FRowCounterCLI.java#L68) | 4 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20503129/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/20503129/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L93) | 15 | 72.53% | | [query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java](https://coveralls.io/builds/20503129/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2Fvisitor%2FTupleFilterVisitor.java#L132) | 41 | 0.0% | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java](https://coveralls.io/builds/20503129/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDistributedScheduler.java#L65) | 57 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://coveralls.io/builds/20503129/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FDoggedCubeBuilder.java#L178) | 65 | 0.0% | |
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713507#comment-16713507
]
ASF GitHub Bot commented on KYLIN-3597:
---
hit-lacus closed pull request #374: KYLIN-3597 Improve code smell
URL: https://github.com/apache/kylin/pull/374
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
b/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
index 4fb9522c96..a9af3b7cfe 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
@@ -21,6 +21,7 @@
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
+import java.util.Locale;
import java.util.Map;
import org.apache.commons.lang3.StringUtils;
@@ -60,12 +61,15 @@
private static final Logger logger =
LoggerFactory.getLogger(CubeDescManager.class);
-public static final Serializer CUBE_DESC_SERIALIZER = new
JsonSerializer(CubeDesc.class);
+public static final Serializer CUBE_DESC_SERIALIZER = new
JsonSerializer<>(CubeDesc.class);
public static CubeDescManager getInstance(KylinConfig config) {
return config.getManager(CubeDescManager.class);
}
+static final String BROKEN_CUBE_MSG = "Broken cube desc %s";
+static final String CUBE_SHOULD_NOT_BE_DRAFT_MSG = "CubeDesc '%s' must not
be a draft";
+
// called by reflection
static CubeDescManager newInstance(KylinConfig config) throws IOException {
return new CubeDescManager(config);
@@ -84,20 +88,20 @@ static CubeDescManager newInstance(KylinConfig config)
throws IOException {
private AutoReadWriteLock descMapLock = new AutoReadWriteLock();
private CubeDescManager(KylinConfig cfg) throws IOException {
-logger.info("Initializing CubeDescManager with config " + cfg);
+logger.info("Initializing CubeDescManager with config {}", cfg);
this.config = cfg;
-this.cubeDescMap = new CaseInsensitiveStringCache(config,
"cube_desc");
+this.cubeDescMap = new CaseInsensitiveStringCache<>(config,
"cube_desc");
this.crud = new CachedCrudAssist(getStore(),
ResourceStore.CUBE_DESC_RESOURCE_ROOT, CubeDesc.class,
cubeDescMap) {
@Override
protected CubeDesc initEntityAfterReload(CubeDesc cubeDesc, String
resourceName) {
if (cubeDesc.isDraft())
-throw new IllegalArgumentException("CubeDesc '" +
cubeDesc.getName() + "' must not be a draft");
+throw new
IllegalArgumentException(String.format(Locale.ROOT,
CUBE_SHOULD_NOT_BE_DRAFT_MSG, cubeDesc.getName()));
try {
cubeDesc.init(config);
} catch (Exception e) {
-logger.warn("Broken cube desc " + cubeDesc.resourceName(),
e);
+logger.warn(String.format(Locale.ROOT,
CUBE_SHOULD_NOT_BE_DRAFT_MSG, cubeDesc.resourceName()), e);
cubeDesc.addError(e.toString());
}
return cubeDesc;
@@ -147,7 +151,7 @@ public CubeDesc getCubeDesc(String name) {
public List listAllDesc() {
try (AutoLock lock = descMapLock.lockForRead()) {
-return new ArrayList(cubeDescMap.values());
+return new ArrayList<>(cubeDescMap.values());
}
}
@@ -175,10 +179,6 @@ public CubeDesc reloadCubeDescLocal(String name) throws
IOException {
/**
* Create a new CubeDesc
- *
- * @param cubeDesc
- * @return
- * @throws IOException
*/
public CubeDesc createCubeDesc(CubeDesc cubeDesc) throws IOException {
try (AutoLock lock = descMapLock.lockForWrite()) {
@@ -187,7 +187,7 @@ public CubeDesc createCubeDesc(CubeDesc cubeDesc) throws
IOException {
if (cubeDescMap.containsKey(cubeDesc.getName()))
throw new IllegalArgumentException("CubeDesc '" +
cubeDesc.getName() + "' already exists");
if (cubeDesc.isDraft())
-throw new IllegalArgumentException("CubeDesc '" +
cubeDesc.getName() + "' must not be a draft");
+throw new IllegalArgumentException(String.format(Locale.ROOT,
CUBE_SHOULD_NOT_BE_DRAFT_MSG, cubeDesc.getName()));
try {
cubeDesc.init(config);
@@ -219,10 +219,6 @@ public CubeDesc createCubeDesc(CubeDesc cubeDesc) throws
IOException {
/**
* Update CubeDesc with the input. Broadcast the event into cluster
- *
- * @param desc
- * @return
- * @throws IOException
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713071#comment-16713071 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812 # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=h1) Report > Merging [#374](https://codecov.io/gh/apache/kylin/pull/374?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/2979f4092ee338ad1bbdaeaca5639d99466268d8?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `11.84%`. [](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #374 +/- ## - Coverage 23.63% 23.63% -0.01% Complexity 4839 4839 Files 1131 1131 Lines 6820168204 +3 Branches 9685 9685 Hits 1612216122 - Misses5051150514 +3 Partials 1568 1568 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/kylin/storage/hbase/util/RowCounterCLI.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL1Jvd0NvdW50ZXJDTEkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...e/kylin/source/kafka/util/KafkaSampleProducer.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvdXRpbC9LYWZrYVNhbXBsZVByb2R1Y2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ylin/query/relnode/visitor/TupleFilterVisitor.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvdmlzaXRvci9UdXBsZUZpbHRlclZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0RvZ2dlZEN1YmVCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0luTWVtQ3ViZUJ1aWxkZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `58.97% <25%> (+0.53%)` | `19 <0> (ø)` | :arrow_down: | | [...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh) | `33.81% <50%> (ø)` | `12 <0> (ø)` | :arrow_down: | | [...kylin/measure/percentile/PercentileSerializer.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9wZXJjZW50aWxlL1BlcmNlbnRpbGVTZXJpYWxpemVyLmphdmE=) | `75% <80%> (ø)` | `5 <2> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | ... and [1 more](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712775#comment-16712775 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812 # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=h1) Report > Merging [#374](https://codecov.io/gh/apache/kylin/pull/374?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/2979f4092ee338ad1bbdaeaca5639d99466268d8?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `9.27%`. [](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #374 +/- ## - Coverage 23.63% 23.63% -0.01% Complexity 4839 4839 Files 1131 1131 Lines 6820168206 +5 Branches 9685 9684 -1 Hits 1612216122 - Misses5051150516 +5 Partials 1568 1568 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/kylin/storage/hbase/util/RowCounterCLI.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL1Jvd0NvdW50ZXJDTEkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...e/kylin/source/kafka/util/KafkaSampleProducer.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvdXRpbC9LYWZrYVNhbXBsZVByb2R1Y2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ylin/query/relnode/visitor/TupleFilterVisitor.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvdmlzaXRvci9UdXBsZUZpbHRlclZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0RvZ2dlZEN1YmVCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0luTWVtQ3ViZUJ1aWxkZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh) | `33.33% <13.79%> (-0.48%)` | `12 <0> (ø)` | | | [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `58.97% <25%> (+0.53%)` | `19 <0> (ø)` | :arrow_down: | | [...kylin/measure/percentile/PercentileSerializer.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9wZXJjZW50aWxlL1BlcmNlbnRpbGVTZXJpYWxpemVyLmphdmE=) | `75% <80%> (ø)` | `5 <2> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | ... and [1 more](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712417#comment-16712417 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812 # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=h1) Report > Merging [#374](https://codecov.io/gh/apache/kylin/pull/374?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/2979f4092ee338ad1bbdaeaca5639d99466268d8?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `9.27%`. [](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #374 +/- ## - Coverage 23.63% 23.63% -0.01% Complexity 4839 4839 Files 1131 1131 Lines 6820168206 +5 Branches 9685 9684 -1 - Hits 1612216119 -3 - Misses5051150518 +7 - Partials 1568 1569 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/kylin/storage/hbase/util/RowCounterCLI.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL1Jvd0NvdW50ZXJDTEkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...e/kylin/source/kafka/util/KafkaSampleProducer.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvdXRpbC9LYWZrYVNhbXBsZVByb2R1Y2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ylin/query/relnode/visitor/TupleFilterVisitor.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvdmlzaXRvci9UdXBsZUZpbHRlclZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0RvZ2dlZEN1YmVCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0luTWVtQ3ViZUJ1aWxkZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh) | `33.33% <13.79%> (-0.48%)` | `12 <0> (ø)` | | | [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `58.97% <25%> (+0.53%)` | `19 <0> (ø)` | :arrow_down: | | [...kylin/measure/percentile/PercentileSerializer.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9wZXJjZW50aWxlL1BlcmNlbnRpbGVTZXJpYWxpemVyLmphdmE=) | `75% <80%> (ø)` | `5 <2> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | ... and [1 more](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712354#comment-16712354 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812 # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=h1) Report > Merging [#374](https://codecov.io/gh/apache/kylin/pull/374?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/2979f4092ee338ad1bbdaeaca5639d99466268d8?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `5.06%`. [](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #374 +/- ## - Coverage 23.63% 23.63% -0.01% Complexity 4839 4839 Files 1131 1131 Lines 6820168201 Branches 9685 9681 -4 - Hits 1612216121 -1 - Misses5051150512 +1 Partials 1568 1568 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ylin/query/relnode/visitor/TupleFilterVisitor.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvdmlzaXRvci9UdXBsZUZpbHRlclZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0luTWVtQ3ViZUJ1aWxkZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0RvZ2dlZEN1YmVCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh) | `33.33% <13.79%> (-0.48%)` | `12 <0> (ø)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=footer). Last update [2979f40...a152798](https://codecov.io/gh/apache/kylin/pull/374?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712342#comment-16712342 ] ASF GitHub Bot commented on KYLIN-3597: --- hit-lacus commented on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445123989 CI test is running. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712276#comment-16712276 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io edited a comment on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812 # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=h1) Report > Merging [#374](https://codecov.io/gh/apache/kylin/pull/374?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/2979f4092ee338ad1bbdaeaca5639d99466268d8?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `7.14%`. [](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #374 +/- ## - Coverage 23.63% 23.63% -0.01% Complexity 4839 4839 Files 1131 1131 Lines 6820168207 +6 Branches 9685 9688 +3 - Hits 1612216119 -3 - Misses5051150519 +8 - Partials 1568 1569 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ylin/query/relnode/visitor/TupleFilterVisitor.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvdmlzaXRvci9UdXBsZUZpbHRlclZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0luTWVtQ3ViZUJ1aWxkZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0RvZ2dlZEN1YmVCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh) | `33.81% <44.44%> (ø)` | `12 <0> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=footer). Last update [2979f40...798df64](https://codecov.io/gh/apache/kylin/pull/374?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL:
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712253#comment-16712253 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io commented on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445096812 # [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@2979f40`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `4.04%`. [](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) ```diff @@Coverage Diff@@ ## master #374 +/- ## = Coverage ? 23.63% Complexity? 4839 = Files ? 1131 Lines ?68207 Branches ? 9690 = Hits ?16123 Misses?50516 Partials ? 1568 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/374?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ylin/query/relnode/visitor/TupleFilterVisitor.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvdmlzaXRvci9UdXBsZUZpbHRlclZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../apache/kylin/cube/cli/DictionaryGeneratorCLI.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9EaWN0aW9uYXJ5R2VuZXJhdG9yQ0xJLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...pache/kylin/cube/inmemcubing/InMemCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0luTWVtQ3ViZUJ1aWxkZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ache/kylin/cube/inmemcubing/DoggedCubeBuilder.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL0RvZ2dlZEN1YmVCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/374/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh) | `33.81% <44.44%> (ø)` | `12 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/374?src=pr=footer). Last update [2979f40...c4eaaba](https://codecov.io/gh/apache/kylin/pull/374?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712226#comment-16712226 ] ASF GitHub Bot commented on KYLIN-3597: --- hit-lacus opened a new pull request #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712227#comment-16712227 ] ASF GitHub Bot commented on KYLIN-3597: --- asfgit commented on issue #374: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/374#issuecomment-445092041 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700523#comment-16700523
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi closed pull request #363: KYLIN-3597 fix static code issues
URL: https://github.com/apache/kylin/pull/363
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core-common/src/main/java/org/apache/kylin/common/util/Bytes.java
b/core-common/src/main/java/org/apache/kylin/common/util/Bytes.java
index 33fc31a987..a2679219f3 100644
--- a/core-common/src/main/java/org/apache/kylin/common/util/Bytes.java
+++ b/core-common/src/main/java/org/apache/kylin/common/util/Bytes.java
@@ -41,7 +41,6 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-
import sun.misc.Unsafe;
/**
@@ -116,6 +115,7 @@
// JHat says BU is 56 bytes.
// SizeOf which uses java.lang.instrument says 24 bytes. (3 longs?)
public static final int ESTIMATED_HEAP_TAX = 16;
+public static final String LENGTH_MUST_BE_GREATER_THAN_0 = "length must be
greater than 0";
/**
* Returns length of the byte array, returning 0 if the array is null.
@@ -491,7 +491,7 @@ public static int putLong(byte[] bytes, int offset, long
val) {
* @return incremented offset
*/
public static int putLongUnsafe(byte[] bytes, int offset, long val) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
val = Long.reverseBytes(val);
}
org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.theUnsafe.putLong(bytes,
@@ -652,7 +652,7 @@ public static int toInt(byte[] bytes, int offset, final int
length) {
* @return the int value
*/
public static int toIntUnsafe(byte[] bytes, int offset) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
return Integer.reverseBytes(
org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.theUnsafe
.getInt(bytes, (long) offset
@@ -672,7 +672,7 @@ public static int toIntUnsafe(byte[] bytes, int offset) {
* @return the short value
*/
public static short toShortUnsafe(byte[] bytes, int offset) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
return Short.reverseBytes(
org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.theUnsafe
.getShort(bytes, (long) offset
@@ -692,7 +692,7 @@ public static short toShortUnsafe(byte[] bytes, int offset)
{
* @return the long value
*/
public static long toLongUnsafe(byte[] bytes, int offset) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
return Long.reverseBytes(
org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.theUnsafe
.getLong(bytes, (long) offset
@@ -763,7 +763,7 @@ public static int putInt(byte[] bytes, int offset, int val)
{
* @return incremented offset
*/
public static int putIntUnsafe(byte[] bytes, int offset, int val) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
val = Integer.reverseBytes(val);
}
org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.theUnsafe.putInt(bytes,
@@ -880,7 +880,7 @@ public static int putShort(byte[] bytes, int offset, short
val) {
* @return incremented offset
*/
public static int putShortUnsafe(byte[] bytes, int offset, short val) {
-if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.littleEndian)
{
+if
(org.apache.kylin.common.util.Bytes.LexicographicalComparerHolder.UnsafeComparer.LITTLEENDIAN)
{
val = Short.reverseBytes(val);
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700524#comment-16700524 ] ASF subversion and git services commented on KYLIN-3597: Commit 7bcc6987e5bbcfd57f320aa19c4fba67ed02aaea in kylin's branch refs/heads/master from shaofengshi [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=7bcc698 ] KYLIN-3597 fix static code issues fix UT > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700501#comment-16700501 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io commented on issue #363: KYLIN-3597 fix static code issues URL: https://github.com/apache/kylin/pull/363#issuecomment-442078521 # [Codecov](https://codecov.io/gh/apache/kylin/pull/363?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@2d8e0fc`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `40.59%`. [](https://codecov.io/gh/apache/kylin/pull/363?src=pr=tree) ```diff @@Coverage Diff@@ ## master #363 +/- ## = Coverage ? 23.62% Complexity? 4824 = Files ? 1130 Lines ?68022 Branches ? 9657 = Hits ?16072 Misses?50383 Partials ? 1567 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/363?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/kylin/sdk/datasource/adaptor/DefaultAdaptor.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvRGVmYXVsdEFkYXB0b3IuamF2YQ==) | `36.08% <ø> (ø)` | `12 <0> (?)` | | | [...in/rest/broadcaster/BroadcasterReceiveServlet.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvYnJvYWRjYXN0ZXIvQnJvYWRjYXN0ZXJSZWNlaXZlU2VydmxldC5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | | | [.../org/apache/kylin/engine/mr/ByteArrayWritable.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQnl0ZUFycmF5V3JpdGFibGUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...e/kylin/source/kafka/util/KafkaSampleProducer.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvdXRpbC9LYWZrYVNhbXBsZVByb2R1Y2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../main/java/org/apache/kylin/common/util/Bytes.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0J5dGVzLmphdmE=) | `1.01% <0%> (ø)` | `3 <0> (?)` | | | [...re/bitmap/BitmapIntersectDistinctCountAggFunc.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwSW50ZXJzZWN0RGlzdGluY3RDb3VudEFnZ0Z1bmMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...apache/kylin/job/execution/AbstractExecutable.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQWJzdHJhY3RFeGVjdXRhYmxlLmphdmE=) | `51.4% <23.07%> (ø)` | `48 <3> (?)` | | | [...be/model/validation/rule/AggregationGroupRule.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9BZ2dyZWdhdGlvbkdyb3VwUnVsZS5qYXZh) | `54.63% <27.27%> (ø)` | `20 <17> (?)` | | | [...in/sdk/datasource/adaptor/AbstractJdbcAdaptor.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvQWJzdHJhY3RKZGJjQWRhcHRvci5qYXZh) | `54.21% <33.33%> (ø)` | `13 <0> (?)` | | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `52.04% <75%> (ø)` | `21 <1> (?)` | | | ... and [1 more](https://codecov.io/gh/apache/kylin/pull/363/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/363?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/363?src=pr=footer). Last update
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700202#comment-16700202 ] ASF GitHub Bot commented on KYLIN-3597: --- shaofengshi opened a new pull request #363: KYLIN-3597 fix static code issues URL: https://github.com/apache/kylin/pull/363 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700203#comment-16700203 ] ASF GitHub Bot commented on KYLIN-3597: --- asfgit commented on issue #363: KYLIN-3597 fix static code issues URL: https://github.com/apache/kylin/pull/363#issuecomment-442011938 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683095#comment-16683095
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi closed pull request #326: KYLIN-3597, fix the critical bug reported
by sonar: Make sure this ex…
URL: https://github.com/apache/kylin/pull/326
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/cache/src/main/java/net/spy/memcached/RefinedKetamaNodeLocator.java
b/cache/src/main/java/net/spy/memcached/RefinedKetamaNodeLocator.java
index 95298d73e5..43f31bccc4 100644
--- a/cache/src/main/java/net/spy/memcached/RefinedKetamaNodeLocator.java
+++ b/cache/src/main/java/net/spy/memcached/RefinedKetamaNodeLocator.java
@@ -110,7 +110,7 @@ public RefinedKetamaNodeLocator(List nodes,
HashAlgorithm alg, Ke
* continuum
* @param alg The hash algorithm to use when choosing a node in the Ketama
* consistent hash continuum
- * @param weights node weights for ketama, a map from InetSocketAddress to
+ * @param nodeWeights node weights for ketama, a map from
InetSocketAddress to
* weight as Integer
* @param configuration node locator configuration
*/
@@ -233,7 +233,7 @@ protected void setKetamaNodes(List nodes) {
if (isWeightedKetama) {
int thisWeight = weights.get(node.getSocketAddress());
-float percent = (float) thisWeight / (float) totalWeight;
+float percent = (totalWeight == 0 ? 0f : (float) thisWeight /
(float) totalWeight);
int pointerPerServer = (int) ((Math.floor(
(float) (percent * (float) config.getNodeRepetitions()
/ 4 * (float) nodeCount + 0.01)))
* 4);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
> Issue Type: Improvement
> Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683096#comment-16683096 ] ASF subversion and git services commented on KYLIN-3597: Commit f0b26c42bad84d6ee2cb367557d256e057d9287c in kylin's branch refs/heads/master from [~Aron.tao] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=f0b26c4 ] KYLIN-3597, fix the critical bug reported by sonar: Make sure this expression can't be zero before doing this division. > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674752#comment-16674752 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-43496 Hi @mingmwang, there's a problem reported by sonar, and I offer a fix, can you take a look and confirm the change? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674753#comment-16674753 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-43496 Hi @mingmwang, there's a critical bug reported by sonar, and I offer a fix, can you take a look and confirm the change? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674739#comment-16674739 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-435556355 ## Pull Request Test Coverage Report for [Build 3836](https://coveralls.io/builds/19905348) * **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered. * **5** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.003%**) to **23.613%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [cache/src/main/java/net/spy/memcached/RefinedKetamaNodeLocator.java](https://coveralls.io/builds/19905348/source?filename=cache%2Fsrc%2Fmain%2Fjava%2Fnet%2Fspy%2Fmemcached%2FRefinedKetamaNodeLocator.java#L236) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19905348/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | Totals | [](https://coveralls.io/builds/19905348) | | :-- | --: | | Change from base [Build 3832](https://coveralls.io/builds/19886418): | -0.003% | | Covered Lines: | 16809 | | Relevant Lines: | 71186 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674737#comment-16674737 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-435556421 # [Codecov](https://codecov.io/gh/apache/kylin/pull/326?src=pr=h1) Report > Merging [#326](https://codecov.io/gh/apache/kylin/pull/326?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/caf109ea016c0bcbbef8f15c26b620003f253955?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/326?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #326 +/- ## - Coverage 21.55% 21.54% -0.02% + Complexity 4579 4577 -2 Files 1112 1112 Lines 7118671186 Branches 1028410285 +1 - Hits 1534315334 -9 - Misses5437354379 +6 - Partials 1470 1473 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/326?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/net/spy/memcached/RefinedKetamaNodeLocator.java](https://codecov.io/gh/apache/kylin/pull/326/diff?src=pr=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9uZXQvc3B5L21lbWNhY2hlZC9SZWZpbmVkS2V0YW1hTm9kZUxvY2F0b3IuamF2YQ==) | `24.17% <0%> (ø)` | `8 <0> (ø)` | :arrow_down: | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/326/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/326/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-1.83%)` | `7% <0%> (ø)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/326/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/326?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/326?src=pr=footer). Last update [caf109e...80027df](https://codecov.io/gh/apache/kylin/pull/326?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674717#comment-16674717 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron commented on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-435768040 When "totalWeight" is 0, means there are no nodes, so "thisWeight" is 0 too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674716#comment-16674716 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-43496 Hi @shaofengshi, I do a simple modify just change the init value, could you assess if this change is correct? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674715#comment-16674715 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron edited a comment on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-43496 Hi @shaofengshi, I do a simple modify just change the init value, could you assess if this change is correct? When "totalWeight" is 0, means there are no nodes, so "thisWeight" is 0 too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673908#comment-16673908 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io commented on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-435556421 # [Codecov](https://codecov.io/gh/apache/kylin/pull/326?src=pr=h1) Report > Merging [#326](https://codecov.io/gh/apache/kylin/pull/326?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/caf109ea016c0bcbbef8f15c26b620003f253955?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/kylin/pull/326?src=pr=tree) ```diff @@Coverage Diff@@ ## master #326 +/- ## = Coverage 21.54% 21.54% Complexity 4578 4578 = Files 1112 1112 Lines 7118671186 Branches 1028410284 = Hits 1533815338 Misses5437754377 Partials 1471 1471 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/326?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/net/spy/memcached/RefinedKetamaNodeLocator.java](https://codecov.io/gh/apache/kylin/pull/326/diff?src=pr=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9uZXQvc3B5L21lbWNhY2hlZC9SZWZpbmVkS2V0YW1hTm9kZUxvY2F0b3IuamF2YQ==) | `24.17% <100%> (ø)` | `8 <0> (ø)` | :arrow_down: | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/326/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/326/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/326?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/326?src=pr=footer). Last update [caf109e...ce558d7](https://codecov.io/gh/apache/kylin/pull/326?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673907#comment-16673907 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls commented on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-435556355 ## Pull Request Test Coverage Report for [Build 3833](https://coveralls.io/builds/19886760) * **1** of **1** **(100.0%)** changed or added relevant line in **1** file are covered. * **5** unchanged lines in **1** file lost coverage. * Overall coverage remained the same at **23.616%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19886760/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | Totals | [](https://coveralls.io/builds/19886760) | | :-- | --: | | Change from base [Build 3832](https://coveralls.io/builds/19886418): | 0.0% | | Covered Lines: | 16811 | | Relevant Lines: | 71186 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673905#comment-16673905 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron commented on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-43496 Hi @shaofengshi, I do a simple modify just change the init value, could you assess if this change is correct? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673903#comment-16673903 ] ASF GitHub Bot commented on KYLIN-3597: --- asfgit commented on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-43155 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673902#comment-16673902 ] ASF GitHub Bot commented on KYLIN-3597: --- Aaron opened a new pull request #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326 …pression can't be zero before doing this division. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673899#comment-16673899 ] Jiatao Tao commented on KYLIN-3597: --- A new CRITICAL bug report by sonar: Make sure this expression can't be zero before doing this division. I'll fix this. > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663297#comment-16663297
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi closed pull request #309: KYLIN-3597 Fix sonar issues
URL: https://github.com/apache/kylin/pull/309
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
b/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
index 7e3be40cdb..7801185f1d 100755
--- a/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
@@ -125,6 +125,8 @@ static CubeManager newInstance(KylinConfig config) throws
IOException {
private SegmentAssist segAssist = new SegmentAssist();
private DictionaryAssist dictAssist = new DictionaryAssist();
+private Random ran = new Random();
+
private CubeManager(KylinConfig cfg) throws IOException {
logger.info("Initializing CubeManager with config {}", cfg);
this.config = cfg;
@@ -524,7 +526,6 @@ private String getSnapshotResPath(CubeSegment cubeSegment,
String tableName, Sna
String namePrefix = config.getHBaseTableNamePrefix();
String namespace = config.getHBaseStorageNameSpace();
String tableName = "";
-Random ran = new Random();
do {
StringBuffer sb = new StringBuffer();
if ((namespace.equals("default") || namespace.equals("")) ==
false) {
diff --git
a/query/src/main/java/org/apache/kylin/query/enumerator/HiveEnumerator.java
b/query/src/main/java/org/apache/kylin/query/enumerator/HiveEnumerator.java
index 2b258f0326..f1b674b632 100644
--- a/query/src/main/java/org/apache/kylin/query/enumerator/HiveEnumerator.java
+++ b/query/src/main/java/org/apache/kylin/query/enumerator/HiveEnumerator.java
@@ -62,7 +62,7 @@ private ResultSet executeQuery() {
String url = olapContext.olapSchema.getStarSchemaUrl();
String user = olapContext.olapSchema.getStarSchemaUser();
String pwd = olapContext.olapSchema.getStarSchemaPassword();
-String sql = olapContext.sql;
+String sql = olapContext.sql.toString();
Statement stmt = null;
try {
conn = DriverManager.getConnection(url, user, pwd);
diff --git
a/source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java
b/source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java
index b1021dc885..6ad8593d8a 100644
---
a/source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java
+++
b/source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java
@@ -112,7 +112,8 @@ public long getHiveTableRows(String database, String
tableName) throws Exception
ResultSet resultSet = null;
long count = 0;
try {
-resultSet = stmt.executeQuery("select count(*) from " + database +
"." + tableName);
+String query = "select count(*) from ";
+resultSet = stmt.executeQuery(query.concat(database + "." +
tableName));
if (resultSet.next()) {
count = resultSet.getLong(1);
}
@@ -147,8 +148,10 @@ public HiveTableMeta getHiveTableMeta(String database,
String tableName) throws
}
builder.setAllColumns(allColumns);
DBUtils.closeQuietly(columns);
-stmt.execute("use " + database);
-ResultSet resultSet = stmt.executeQuery("describe formatted " +
tableName);
+String exe = "use ";
+stmt.execute(exe.concat(database));
+String des = "describe formatted ";
+ResultSet resultSet = stmt.executeQuery(des.concat(tableName));
extractHiveTableMeta(resultSet, builder);
DBUtils.closeQuietly(resultSet);
return builder.createHiveTableMeta();
@@ -169,7 +172,11 @@ public static String considerDataTypePrecision(String
dataType, String precision
private void extractHiveTableMeta(ResultSet resultSet,
HiveTableMetaBuilder builder) throws SQLException {
while (resultSet.next()) {
+parseResultEntry(resultSet, builder);
+}
+}
+private void parseResultEntry(ResultSet resultSet, HiveTableMetaBuilder
builder) throws SQLException{
List partitionColumns =
Lists.newArrayList();
if ("# Partition
Information".equals(resultSet.getString(1).trim())) {
resultSet.next();
@@ -204,23 +211,7 @@ private void extractHiveTableMeta(ResultSet resultSet,
HiveTableMetaBuilder buil
builder.setTableType(resultSet.getString(2).trim());
}
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662056#comment-16662056 ] ASF GitHub Bot commented on KYLIN-3597: --- ZhouYC627 opened a new pull request #309: KYLIN-3597 Fix sonar issues URL: https://github.com/apache/kylin/pull/309 Refactor methods to reduce the Cognitive Complexity Reuse "Random" objects Use SQL binding mechanisms This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662057#comment-16662057 ] ASF GitHub Bot commented on KYLIN-3597: --- asfgit commented on issue #309: KYLIN-3597 Fix sonar issues URL: https://github.com/apache/kylin/pull/309#issuecomment-432596687 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659940#comment-16659940
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi closed pull request #303: KYLIN-3597 Refactor methods to reduce
Cognitive Complexity
URL: https://github.com/apache/kylin/pull/303
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
b/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
index dbd19559fe..b1d0f4930e 100755
--- a/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
@@ -323,35 +323,48 @@ private CubeInstance updateCubeWithRetry(CubeUpdate
update, int retry) throws IO
List toRemoveResources = Lists.newArrayList();
if (update.getToRemoveSegs() != null) {
-Iterator iterator = newSegs.iterator();
-while (iterator.hasNext()) {
-CubeSegment currentSeg = iterator.next();
-for (CubeSegment toRemoveSeg : update.getToRemoveSegs()) {
-if (currentSeg.getUuid().equals(toRemoveSeg.getUuid())) {
-logger.info("Remove segment {}", currentSeg);
-
toRemoveResources.add(currentSeg.getStatisticsResourcePath());
-iterator.remove();
-break;
-}
-}
-}
+getToRemoveSegments(update, newSegs, toRemoveResources);
}
if (update.getToUpdateSegs() != null) {
-for (CubeSegment segment : update.getToUpdateSegs()) {
-for (int i = 0; i < newSegs.size(); i++) {
-if (newSegs.get(i).getUuid().equals(segment.getUuid())) {
-newSegs.set(i, segment);
-break;
-}
-}
-}
+updateSegments(update, newSegs);
}
Collections.sort(newSegs);
newSegs.validate();
cube.setSegments(newSegs);
+setCubeMember(cube, update);
+
+try {
+cube = crud.save(cube);
+} catch (WriteConflictException ise) {
+logger.warn("Write conflict to update cube {} at try {}, will
retry...", cube.getName(), retry);
+if (retry >= 7) {
+logger.error("Retried 7 times till got error, abandoning...",
ise);
+throw ise;
+}
+
+cube = crud.reload(cube.getName());
+update.setCubeInstance(cube.latestCopyForWrite());
+return updateCubeWithRetry(update, ++retry);
+}
+
+for (String resource : toRemoveResources) {
+try {
+getStore().deleteResource(resource);
+} catch (IOException ioe) {
+logger.error("Failed to delete resource {}",
toRemoveResources);
+}
+}
+
+//this is a duplicate call to take care of scenarios where REST cache
service unavailable
+
ProjectManager.getInstance(cube.getConfig()).clearL2Cache(cube.getProject());
+
+return cube;
+}
+
+private void setCubeMember(CubeInstance cube, CubeUpdate update) {
if (update.getStatus() != null) {
cube.setStatus(update.getStatus());
}
@@ -377,35 +390,32 @@ private CubeInstance updateCubeWithRetry(CubeUpdate
update, int retry) throws IO
cube.putSnapshotResPath(lookupSnapshotPathEntry.getKey(),
lookupSnapshotPathEntry.getValue());
}
}
+}
-try {
-cube = crud.save(cube);
-} catch (WriteConflictException ise) {
-logger.warn("Write conflict to update cube {} at try {}, will
retry...", cube.getName(), retry);
-if (retry >= 7) {
-logger.error("Retried 7 times till got error, abandoning...",
ise);
-throw ise;
+private void updateSegments(CubeUpdate update, Segments
newSegs) {
+for (CubeSegment segment : update.getToUpdateSegs()) {
+for (int i = 0; i < newSegs.size(); i++) {
+if (newSegs.get(i).getUuid().equals(segment.getUuid())) {
+newSegs.set(i, segment);
+break;
+}
}
-
-cube = crud.reload(cube.getName());
-update.setCubeInstance(cube.latestCopyForWrite());
-return updateCubeWithRetry(update, ++retry);
}
+}
-if (toRemoveResources.size() > 0) {
-for (String resource : toRemoveResources) {
-
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659939#comment-16659939 ] ASF GitHub Bot commented on KYLIN-3597: --- shaofengshi commented on issue #303: KYLIN-3597 Refactor methods to reduce Cognitive Complexity URL: https://github.com/apache/kylin/pull/303#issuecomment-432057474 Merged with a minor update. Thank you yichen . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659937#comment-16659937 ] ASF subversion and git services commented on KYLIN-3597: Commit c5394b432f59e3552ff51b2e20c27ec38838184c in kylin's branch refs/heads/master from ZhouYC627 [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=c5394b4 ] KYLIN-3597 Refactor methods to reduce Cognitive Complexity > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658211#comment-16658211 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io commented on issue #303: KYLIN-3597 Refactor methods to reduce Cognitive Complexity URL: https://github.com/apache/kylin/pull/303#issuecomment-431667369 # [Codecov](https://codecov.io/gh/apache/kylin/pull/303?src=pr=h1) Report > Merging [#303](https://codecov.io/gh/apache/kylin/pull/303?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/c87856da8551b035a084c3e51aafe123f6845e6e?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `41.79%`. [](https://codecov.io/gh/apache/kylin/pull/303?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #303 +/- ## - Coverage 21.32% 21.32% -0.01% - Complexity 4447 4448 +1 Files 1088 1088 Lines 6998969995 +6 Branches 1011110104 -7 - Hits 1492614923 -3 - Misses5366453671 +7 - Partials 1399 1401 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/303?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...in/storage/hbase/util/GridTableHBaseBenchmark.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL0dyaWRUYWJsZUhCYXNlQmVuY2htYXJrLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `40.39% <47.45%> (+0.68%)` | `44 <7> (+2)` | :arrow_up: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.92%)` | `7% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/303?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/303?src=pr=footer). Last update [c87856d...1f54214](https://codecov.io/gh/apache/kylin/pull/303?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658209#comment-16658209 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls commented on issue #303: KYLIN-3597 Refactor methods to reduce Cognitive Complexity URL: https://github.com/apache/kylin/pull/303#issuecomment-431666978 ## Pull Request Test Coverage Report for [Build 3787](https://coveralls.io/builds/19639564) * **30** of **67** **(44.78%)** changed or added relevant lines in **2** files are covered. * **6** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.005%**) to **23.325%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/GridTableHBaseBenchmark.java](https://coveralls.io/builds/19639564/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FGridTableHBaseBenchmark.java#L176) | 0 | 8 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java](https://coveralls.io/builds/19639564/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java#L341) | 30 | 59 | 50.85% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/19639564/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/19639564/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19639564/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/19639564) | | :-- | --: | | Change from base [Build 3782](https://coveralls.io/builds/19627842): | 0.005% | | Covered Lines: | 16326 | | Relevant Lines: | 69995 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658205#comment-16658205 ] ASF GitHub Bot commented on KYLIN-3597: --- ZhouYC627 opened a new pull request #303: KYLIN-3597 Refactor methods to reduce Cognitive Complexity URL: https://github.com/apache/kylin/pull/303 https://issues.apache.org/jira/browse/KYLIN-3597 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658206#comment-16658206 ] ASF GitHub Bot commented on KYLIN-3597: --- asfgit commented on issue #303: KYLIN-3597 Refactor methods to reduce Cognitive Complexity URL: https://github.com/apache/kylin/pull/303#issuecomment-431665703 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658044#comment-16658044
]
ASF GitHub Bot commented on KYLIN-3597:
---
caolijun1166 closed pull request #297: KYLIN-3597 Use SecureRandom instead of
Random
URL: https://github.com/apache/kylin/pull/297
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
b/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
index dbd19559fe..8b1a978f93 100755
--- a/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
@@ -19,6 +19,8 @@
package org.apache.kylin.cube;
import java.io.IOException;
+import java.security.NoSuchAlgorithmException;
+import java.security.SecureRandom;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
@@ -514,18 +516,22 @@ private String getSnapshotResPath(CubeSegment
cubeSegment, String tableName, Sna
String namePrefix = config.getHBaseTableNamePrefix();
String namespace = config.getHBaseStorageNameSpace();
String tableName = "";
-Random ran = new Random();
-do {
-StringBuffer sb = new StringBuffer();
-if ((namespace.equals("default") || namespace.equals("")) ==
false) {
-sb.append(namespace).append(":");
-}
-sb.append(namePrefix);
-for (int i = 0; i < HBASE_TABLE_LENGTH; i++) {
-sb.append(ALPHA_NUM.charAt(ran.nextInt(ALPHA_NUM.length(;
-}
-tableName = sb.toString();
-} while (this.usedStorageLocation.containsValue(tableName));
+try {
+Random ran = SecureRandom.getInstanceStrong();
+do {
+StringBuffer sb = new StringBuffer();
+if ((namespace.equals("default") || namespace.equals("")) ==
false) {
+sb.append(namespace).append(":");
+}
+sb.append(namePrefix);
+for (int i = 0; i < HBASE_TABLE_LENGTH; i++) {
+
sb.append(ALPHA_NUM.charAt(ran.nextInt(ALPHA_NUM.length(;
+}
+tableName = sb.toString();
+} while (this.usedStorageLocation.containsValue(tableName));
+} catch (NoSuchAlgorithmException e) {
+throw new RuntimeException("SecureRandom.getInstanceStrong() can't
get such algorithm.");
+}
return tableName;
}
diff --git
a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/GridTableHBaseBenchmark.java
b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/GridTableHBaseBenchmark.java
index 6dd16fe494..4938f5f009 100644
---
a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/GridTableHBaseBenchmark.java
+++
b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/GridTableHBaseBenchmark.java
@@ -20,6 +20,8 @@
import java.io.IOException;
import java.nio.charset.StandardCharsets;
+import java.security.NoSuchAlgorithmException;
+import java.security.SecureRandom;
import java.util.List;
import java.util.Random;
@@ -258,8 +260,12 @@ private static void dot(int i, int nRows) {
private static byte[] randomBytes() {
byte[] bytes = new byte[CELL_SIZE];
-Random rand = new Random();
-rand.nextBytes(bytes);
+try {
+Random rand = SecureRandom.getInstanceStrong();
+rand.nextBytes(bytes);
+} catch (NoSuchAlgorithmException e) {
+throw new RuntimeException("SecureRandom.getInstanceStrong() can't
get such algorithm.");
+}
return bytes;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
> Issue Type: Improvement
> Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656113#comment-16656113 ] ASF GitHub Bot commented on KYLIN-3597: --- caolijun1166 opened a new pull request #297: KYLIN-3597 Use SecureRandom instead of Random URL: https://github.com/apache/kylin/pull/297 KYLIN-3597 Use SecureRandom instead of Random This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649621#comment-16649621 ] ASF subversion and git services commented on KYLIN-3597: Commit 5f6007ff2b5aead4781c876fa3203dd67188d90b in kylin's branch refs/heads/master from shaofengshi [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=5f6007f ] KYLIN-3597 improve code smell > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649365#comment-16649365
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi closed pull request #288: KYLIN-3597 Improve code smell
URL: https://github.com/apache/kylin/pull/288
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
index 6f1dfd9144..386a73ca6f 100644
--- a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
+++ b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
@@ -57,6 +57,12 @@
private static final long serialVersionUID = 1L;
private static final Logger logger =
LoggerFactory.getLogger(KylinConfigBase.class);
+private static final String FALSE = "false";
+private static final String TRUE = "true";
+private static final String DEFAULT = "default";
+private static final String KYLIN_ENGINE_MR_JOB_JAR =
"kylin.engine.mr.job-jar";
+private static final String KYLIN_STORAGE_HBASE_COPROCESSOR_LOCAL_JAR =
"kylin.storage.hbase.coprocessor-local-jar";
+
/*
* DON'T DEFINE CONSTANTS FOR PROPERTY KEYS!
*
@@ -84,13 +90,13 @@ public static String getKylinHomeWithoutWarn() {
public static String getSparkHome() {
String sparkHome = System.getenv("SPARK_HOME");
if (StringUtils.isNotEmpty(sparkHome)) {
-logger.info("SPARK_HOME was set to " + sparkHome);
+logger.info("SPARK_HOME was set to {}", sparkHome);
return sparkHome;
}
sparkHome = System.getProperty("SPARK_HOME");
if (StringUtils.isNotEmpty(sparkHome)) {
-logger.info("SPARK_HOME was set to " + sparkHome);
+logger.info("SPARK_HOME was set to {}", sparkHome);
return sparkHome;
}
@@ -195,7 +201,7 @@ final protected String getRequired(String prop) {
* Use with care, properties should be read-only. This is for testing only.
*/
final public void setProperty(String key, String value) {
-logger.info("Kylin Config was updated with " + key + " : " + value);
+logger.info("Kylin Config was updated with {} : {}", key, value);
properties.setProperty(BCC.check(key), value);
}
@@ -228,7 +234,6 @@ public String getDeployEnv() {
}
private String cachedHdfsWorkingDirectory;
-private String cachedBigCellDirectory;
public String getHdfsWorkingDirectory() {
if (cachedHdfsWorkingDirectory != null)
@@ -301,7 +306,7 @@ public String getZookeeperConnectString() {
}
public boolean isZookeeperAclEnabled() {
-return
Boolean.parseBoolean(getOptional("kylin.env.zookeeper-acl-enabled", "false"));
+return
Boolean.parseBoolean(getOptional("kylin.env.zookeeper-acl-enabled", FALSE));
}
public String getZKAuths() {
@@ -381,7 +386,7 @@ public String getHBaseMappingAdapter() {
}
public boolean isCheckCopyOnWrite() {
-return
Boolean.parseBoolean(getOptional("kylin.metadata.check-copy-on-write",
"false"));
+return
Boolean.parseBoolean(getOptional("kylin.metadata.check-copy-on-write", FALSE));
}
public String getHbaseClientScannerTimeoutPeriod() {
@@ -401,7 +406,7 @@ public String getHbaseClientRetriesNumber() {
//
public boolean isUseForestTrieDictionary() {
-return
Boolean.parseBoolean(getOptional("kylin.dictionary.use-forest-trie", "true"));
+return
Boolean.parseBoolean(getOptional("kylin.dictionary.use-forest-trie", TRUE));
}
public int getTrieDictionaryForestMaxTrieSizeMB() {
@@ -413,11 +418,11 @@ public int getCachedDictMaxEntrySize() {
}
public boolean isGrowingDictEnabled() {
-return
Boolean.parseBoolean(this.getOptional("kylin.dictionary.growing-enabled",
"false"));
+return
Boolean.parseBoolean(this.getOptional("kylin.dictionary.growing-enabled",
FALSE));
}
public boolean isDictResuable() {
-return
Boolean.parseBoolean(this.getOptional("kylin.dictionary.resuable", "false"));
+return
Boolean.parseBoolean(this.getOptional("kylin.dictionary.resuable", FALSE));
}
public int getAppendDictEntrySize() {
@@ -453,7 +458,7 @@ public double getExtTableSnapshotLocalCacheMaxSizeGB() {
}
public boolean isShrunkenDictFromGlobalEnabled() {
-return
Boolean.parseBoolean(this.getOptional("kylin.dictionary.shrunken-from-global-enabled",
"false"));
+
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649366#comment-16649366 ] ASF subversion and git services commented on KYLIN-3597: Commit ae9c24a5782841e5079fad44d2c807b07ae72f33 in kylin's branch refs/heads/master from [~caolijun1166] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=ae9c24a ] KYLIN-3597 Improve code smell > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649190#comment-16649190 ] ASF GitHub Bot commented on KYLIN-3597: --- codecov-io commented on issue #288: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/288#issuecomment-429588453 # [Codecov](https://codecov.io/gh/apache/kylin/pull/288?src=pr=h1) Report > Merging [#288](https://codecov.io/gh/apache/kylin/pull/288?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/fdafecc23a34e1b245dbe409cfd2fc1984717c55?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `3.26%`. [](https://codecov.io/gh/apache/kylin/pull/288?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#288 +/- ## === + Coverage 21.29% 21.3% +0.01% Complexity 44424442 === Files 10871087 Lines 69953 69966 +13 Branches 10107 10107 === + Hits 14894 14907 +13 - Misses53650 53656 +6 + Partials 14091403 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/288?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...age/hbase/lookup/LookupTableHFilesBulkLoadJob.java](https://codecov.io/gh/apache/kylin/pull/288/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9sb29rdXAvTG9va3VwVGFibGVIRmlsZXNCdWxrTG9hZEpvYi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/288/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `14.68% <2.77%> (ø)` | `36 <2> (ø)` | :arrow_down: | | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/288/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `39.71% <5.26%> (-0.96%)` | `42 <0> (ø)` | | | [...lin/dict/lookup/cache/RocksDBLookupTableCache.java](https://codecov.io/gh/apache/kylin/pull/288/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGVDYWNoZS5qYXZh) | `76.68% <0%> (+0.51%)` | `27% <0%> (ø)` | :arrow_down: | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/288/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+3.64%)` | `7% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/288?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/288?src=pr=footer). Last update [fdafecc...45af68f](https://codecov.io/gh/apache/kylin/pull/288?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[ https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649189#comment-16649189 ] ASF GitHub Bot commented on KYLIN-3597: --- coveralls edited a comment on issue #288: KYLIN-3597 Improve code smell URL: https://github.com/apache/kylin/pull/288#issuecomment-429504585 ## Pull Request Test Coverage Report for [Build 3765](https://coveralls.io/builds/19508188) * **3** of **92** **(3.26%)** changed or added relevant lines in **3** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.006%**) to **23.314%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableHFilesBulkLoadJob.java](https://coveralls.io/builds/19508188/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Flookup%2FLookupTableHFilesBulkLoadJob.java#L88) | 0 | 1 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java](https://coveralls.io/builds/19508188/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java#L400) | 1 | 19 | 5.26% | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/19508188/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L93) | 2 | 72 | 2.78% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/19508188/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L988) | 2 | 15.82% | | Totals | [](https://coveralls.io/builds/19508188) | | :-- | --: | | Change from base [Build 3758](https://coveralls.io/builds/19483243): | 0.006% | | Covered Lines: | 16312 | | Relevant Lines: | 69966 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix sonar reported static code issues > - > > Key: KYLIN-3597 > URL: https://issues.apache.org/jira/browse/KYLIN-3597 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Shaofeng SHI >Priority: Major > Fix For: v2.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3597) Fix sonar reported static code issues
[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648956#comment-16648956
]
ASF GitHub Bot commented on KYLIN-3597:
---
shaofengshi commented on a change in pull request #288: KYLIN-3597 Improve code
smell
URL: https://github.com/apache/kylin/pull/288#discussion_r224960913
##
File path: core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
##
@@ -100,6 +100,9 @@ public static CubeManager getInstance(KylinConfig config) {
return config.getManager(CubeManager.class);
}
+private static final String FOR_CUBE = "For cube ";
+private static final String SEGMENT = ", segment ";
Review comment:
I don't think this worth to declare.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix sonar reported static code issues
> -
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
> Issue Type: Improvement
> Components: Others
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.6.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
