[jira] [Commented] (MNG-7608) Make Resolver native transport the default in Maven4
[ https://issues.apache.org/jira/browse/MNG-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642711#comment-17642711 ] ASF GitHub Bot commented on MNG-7608: - olamy commented on PR #892: URL: https://github.com/apache/maven/pull/892#issuecomment-1335937017 before this it was possible for users to use their own wagon impls. How is it possible now? > Make Resolver native transport the default in Maven4 > > > Key: MNG-7608 > URL: https://issues.apache.org/jira/browse/MNG-7608 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate, 4.0.0 > > > The ancient Wagon should be phased out, and "native" resolver transport > should be the default in Maven4. This in start halves the HTTP request count > toward Maven Central and any major MRM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] olamy commented on pull request #892: [MNG-7608] Make native transport the default
olamy commented on PR #892: URL: https://github.com/apache/maven/pull/892#issuecomment-1335937017 before this it was possible for users to use their own wagon impls. How is it possible now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (JXR-169) Use of deprecated velocity configuration keys
[
https://issues.apache.org/jira/browse/JXR-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642701#comment-17642701
]
Michael Osipov commented on JXR-169:
https://github.com/apache/maven-jxr/pull/64/files#diff-eb50e94d8619ce52441a04b69abec80f467d873aa9fd09684a0faad3a1c5e153
> Use of deprecated velocity configuration keys
> --
>
> Key: JXR-169
> URL: https://issues.apache.org/jira/browse/JXR-169
> Project: Maven JXR
> Issue Type: Improvement
> Components: maven2 jxr plugin
>Affects Versions: 3.2.0
>Reporter: Dave Wichers
>Priority: Minor
>
> When I run: mvn site, using my project's pom:
> [https://github.com/nahsra/antisamy/blob/main/pom.xml]
> I'm seeing the following warnings. I think this means these jxr-plugins are
> using old resource names. Unless I'm doing something wrong in my pom. But I
> can't find any references to these resources in my project, so I'm assuming
> its a problem in your project. Can you confirm this is an issue in maven-jxr
> and you can fix it? Or is it my fault?
> The velocity configuration key changes are described here:
> https://velocity.apache.org/engine/devel/configuration-property-changes-in-2.1.html
> [*INFO*] Generating "{*}Source Xref{*}" report *---*
> maven-jxr-plugin:3.2.0:jxr
> [*WARNING*] configuration key 'resource.loader' has been deprecated in favor
> of 'resource.loaders'
> [*WARNING*] configuration key 'classpath.resource.loader.class' has been
> deprecated in favor of 'resource.loader.classpath.class'
> [*WARNING*] configuration key 'velocimacro.library' has been deprecated in
> favor of 'velocimacro.library.path'
> [*INFO*] Generating "{*}Test Source Xref{*}" report *---*
> maven-jxr-plugin:3.2.0:test-jxr
> [*WARNING*] configuration key 'resource.loader' has been deprecated in favor
> of 'resource.loaders'
> [*WARNING*] configuration key 'classpath.resource.loader.class' has been
> deprecated in favor of 'resource.loader.classpath.class'
> [*WARNING*] configuration key 'velocimacro.library' has been deprecated in
> favor of 'velocimacro.library.path'
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-jxr] dependabot[bot] commented on pull request #83: Bump plexus-utils from 3.4.2 to 3.5.0
dependabot[bot] commented on PR #83: URL: https://github.com/apache/maven-jxr/pull/83#issuecomment-1335877529 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] michael-o closed pull request #83: Bump plexus-utils from 3.4.2 to 3.5.0
michael-o closed pull request #83: Bump plexus-utils from 3.4.2 to 3.5.0 URL: https://github.com/apache/maven-jxr/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] michael-o commented on pull request #83: Bump plexus-utils from 3.4.2 to 3.5.0
michael-o commented on PR #83: URL: https://github.com/apache/maven-jxr/pull/83#issuecomment-1335877506 Superseded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (JXR-177) Upgrade Plexus Utils to 3.5.0
[ https://issues.apache.org/jira/browse/JXR-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed JXR-177. -- Resolution: Fixed Fixed with [cf999873cd4b5eb8188639a504b40624d088854e|https://gitbox.apache.org/repos/asf?p=maven-jxr.git;a=commit;h=cf999873cd4b5eb8188639a504b40624d088854e]. > Upgrade Plexus Utils to 3.5.0 > - > > Key: JXR-177 > URL: https://issues.apache.org/jira/browse/JXR-177 > Project: Maven JXR > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (JXR-177) Upgrade Plexus Utils to 3.5.0
Michael Osipov created JXR-177: -- Summary: Upgrade Plexus Utils to 3.5.0 Key: JXR-177 URL: https://issues.apache.org/jira/browse/JXR-177 Project: Maven JXR Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: next-release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-compiler-plugin] slawekjaranowski commented on a diff in pull request #158: [MCOMPILER-512] - Defining maven.compiler.release as empty string end…
slawekjaranowski commented on code in PR #158: URL: https://github.com/apache/maven-compiler-plugin/pull/158#discussion_r1038557284 ## src/main/java/org/apache/maven/plugin/compiler/TestCompilerMojo.java: ## @@ -311,9 +312,9 @@ protected void preparePaths( Set sourceFiles ) testModuleDescriptor = result.getMainModuleDescriptor(); } -if ( release != null ) +if ( !StringUtils.isEmpty( getRelease() ) ) Review Comment: There is method `isNotEmpty` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-457) Change showWarnings to true by default
[
https://issues.apache.org/jira/browse/MCOMPILER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642694#comment-17642694
]
Hudson commented on MCOMPILER-457:
--
Build succeeded in Jenkins: Maven » Maven TLP » maven-compiler-plugin » master
#95
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-compiler-plugin/job/master/95/
> Change showWarnings to true by default
> --
>
> Key: MCOMPILER-457
> URL: https://issues.apache.org/jira/browse/MCOMPILER-457
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Reporter: Thomas Broyer
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.11.0
>
>
> I see no reason to hide warnings by default, and setting {{failOnWarning}} to
> {{true}} will be useless without also setting {{showWarnings}} to {{true}};
> but you'll actually never know until you *actually* expect a warning (and
> build failure) and doesn't see it. Setting {{failOnWarning}} preventively
> without also setting {{showWarnings}} thus won't prevent anything; even if
> you also pass a strict {{-Xlint:all}} (because {{-nowarn}} has precedence
> apparently).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MCOMPILER-457) Change showWarnings to true by default
[
https://issues.apache.org/jira/browse/MCOMPILER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MCOMPILER-457.
-
Fix Version/s: 3.11.0
Resolution: Fixed
> Change showWarnings to true by default
> --
>
> Key: MCOMPILER-457
> URL: https://issues.apache.org/jira/browse/MCOMPILER-457
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Reporter: Thomas Broyer
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.11.0
>
>
> I see no reason to hide warnings by default, and setting {{failOnWarning}} to
> {{true}} will be useless without also setting {{showWarnings}} to {{true}};
> but you'll actually never know until you *actually* expect a warning (and
> build failure) and doesn't see it. Setting {{failOnWarning}} preventively
> without also setting {{showWarnings}} thus won't prevent anything; even if
> you also pass a strict {{-Xlint:all}} (because {{-nowarn}} has precedence
> apparently).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-compiler-plugin] slawekjaranowski merged pull request #157: [MCOMPILER-457] Change showWarnings to true by default
slawekjaranowski merged PR #157: URL: https://github.com/apache/maven-compiler-plugin/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-917) Upgrade components and plugin in ITs
[ https://issues.apache.org/jira/browse/MSITE-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642692#comment-17642692 ] Hudson commented on MSITE-917: -- Build failed in Jenkins: Maven » Maven TLP » maven-site-plugin » master #50 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-site-plugin/job/master/50/ > Upgrade components and plugin in ITs > > > Key: MSITE-917 > URL: https://issues.apache.org/jira/browse/MSITE-917 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0-M4 > > > * Upgrade Jetty to 9.4.49.v20220914 > * Maven PMD Plugin to 3.19.0 > * Maven JXR Plugin to 3.3.0 > * Maven PIR Plugin to 3.4.1 > * Maven Surefire Plugin to 3.0.0-M7 > * Maven Reporting Impl to 4.0.0-M3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSITE-919) Upgrade Maven Reporting Exec to 2.0.0-M3
[ https://issues.apache.org/jira/browse/MSITE-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642691#comment-17642691 ] Hudson commented on MSITE-919: -- Build failed in Jenkins: Maven » Maven TLP » maven-site-plugin » master #50 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-site-plugin/job/master/50/ > Upgrade Maven Reporting Exec to 2.0.0-M3 > > > Key: MSITE-919 > URL: https://issues.apache.org/jira/browse/MSITE-919 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0-M4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-457) Change showWarnings to true by default
[
https://issues.apache.org/jira/browse/MCOMPILER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642690#comment-17642690
]
Hudson commented on MCOMPILER-457:
--
Build succeeded in Jenkins: Maven » Maven TLP » maven-compiler-plugin » master
#94
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-compiler-plugin/job/master/94/
> Change showWarnings to true by default
> --
>
> Key: MCOMPILER-457
> URL: https://issues.apache.org/jira/browse/MCOMPILER-457
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Reporter: Thomas Broyer
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> I see no reason to hide warnings by default, and setting {{failOnWarning}} to
> {{true}} will be useless without also setting {{showWarnings}} to {{true}};
> but you'll actually never know until you *actually* expect a warning (and
> build failure) and doesn't see it. Setting {{failOnWarning}} preventively
> without also setting {{showWarnings}} thus won't prevent anything; even if
> you also pass a strict {{-Xlint:all}} (because {{-nowarn}} has precedence
> apparently).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MSITE-917) Upgrade components and plugin in ITs
[ https://issues.apache.org/jira/browse/MSITE-917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSITE-917. Resolution: Fixed Fixed with [eea479f137c841684c0fd594f5dd4022e2586f89|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=eea479f137c841684c0fd594f5dd4022e2586f89]. > Upgrade components and plugin in ITs > > > Key: MSITE-917 > URL: https://issues.apache.org/jira/browse/MSITE-917 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0-M4 > > > * Upgrade Jetty to 9.4.49.v20220914 > * Maven PMD Plugin to 3.19.0 > * Maven JXR Plugin to 3.3.0 > * Maven PIR Plugin to 3.4.1 > * Maven Surefire Plugin to 3.0.0-M7 > * Maven Reporting Impl to 4.0.0-M3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSITE-919) Upgrade Maven Reporting Exec to 2.0.0-M3
[ https://issues.apache.org/jira/browse/MSITE-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSITE-919. Resolution: Fixed Fixed with [107785fd681f3f112cfe11fbaf817345eb183163|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=107785fd681f3f112cfe11fbaf817345eb183163]. > Upgrade Maven Reporting Exec to 2.0.0-M3 > > > Key: MSITE-919 > URL: https://issues.apache.org/jira/browse/MSITE-919 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0-M4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-compiler-plugin] pzygielo commented on a diff in pull request #157: [MCOMPILER-457] Change showWarnings to true by default
pzygielo commented on code in PR #157: URL: https://github.com/apache/maven-compiler-plugin/pull/157#discussion_r1038501482 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -176,7 +176,7 @@ /** * Set to true to show compilation warnings. */ Review Comment: Updated. I really missed that the opposite of flag was described by javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-deploy-plugin] awisus opened a new pull request, #30: [MDEPLOY-272] - Skip deploy-file as done in DeployMojo
awisus opened a new pull request, #30: URL: https://github.com/apache/maven-deploy-plugin/pull/30 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPH) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MPH-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MPH-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7612) Chained Local Repository
[ https://issues.apache.org/jira/browse/MNG-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642672#comment-17642672 ] ASF GitHub Bot commented on MNG-7612: - slawekjaranowski opened a new pull request, #897: URL: https://github.com/apache/maven/pull/897 Adds new feature: Chained Local Repository Manager. Cherry-pick f8f56b33c0585638723a20d71eb848d40a1f44e0 --- https://issues.apache.org/jira/browse/MNG-7612 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Chained Local Repository > - > > Key: MNG-7612 > URL: https://issues.apache.org/jira/browse/MNG-7612 > Project: Maven > Issue Type: New Feature > Components: Artifacts and Repositories >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > New feature: Chained Local Repository Manager (CLRM). > This new feature is not something one would use in production, is more > targeted to Integration Test isolation. > User story: ITs usually are run as part of Maven build – lets call it "outer > build" – that may build among other things, plugins and some artifacts needed > for the ITs. The ITs itself – let's call them "inner build" – should run in > isolated environment. > Problem: the "outer build" is usually affected by user environment > (settings.xml, use of MRM, and may use user own local repository unless > alternate specified) but also we do not want user MRM to be altered by IT > runs. The "inner build" on the other hand, may fail if use same LRM as "outer > build", as they are isolated, so they do not use settings.xml from the outer > build, may not use MRM and same remote repository IDs, and all these may lead > to mysterious "artifact not found" problems. Typically, outer build may use > MRM that defines mirrorOf with ID "my-mrm", while inner would use defaults, > where only remote repository is "central": this leads that user LRM gets > populated with artifacts available from "my-mrm" remote repository, while > inner build would know only about "central" remote repository. Enhanced LRM > (default since Maven 3.0) would refuse to serve up these artifacts. > Solution is CLRM: with CLRM user is able to specify isolated LRM for ITs, > while still making artifacts from outer LRM "visible" (discoverable) for the > IT build. Inner build uses isolated LRM solely, but for resolution purposes > still is able to resolve from outer LRM, where outer build might deployed > artifacts, plugins used by IT inner build. > Technical remark: CLRM defines "head" LRM, and list of LRM as "tail". Almost > all methods are delegated toward "head", except for find methods (metadata > and artifact), exposing tail LRM contents for artifact resolution. Also, CLRM > is *able* to enforce artifact availability (as explained above), but in most > cases (at least in IT user story), one
[GitHub] [maven] slawekjaranowski opened a new pull request, #897: [MNG-7612] Chained LRM
slawekjaranowski opened a new pull request, #897: URL: https://github.com/apache/maven/pull/897 Adds new feature: Chained Local Repository Manager. Cherry-pick f8f56b33c0585638723a20d71eb848d40a1f44e0 --- https://issues.apache.org/jira/browse/MNG-7612 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on a diff in pull request #157: [MCOMPILER-457] Change showWarnings to true by default
pzygielo commented on code in PR #157: URL: https://github.com/apache/maven-compiler-plugin/pull/157#discussion_r1038463233 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -176,7 +176,7 @@ /** * Set to true to show compilation warnings. */ Review Comment: I see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-script-interpreter] slawekjaranowski merged pull request #86: Code cleanup after parent 38
slawekjaranowski merged PR #86: URL: https://github.com/apache/maven-script-interpreter/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MCOMPILER-457) Change showWarnings to true by default
[
https://issues.apache.org/jira/browse/MCOMPILER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MCOMPILER-457:
-
Assignee: Slawomir Jaranowski
> Change showWarnings to true by default
> --
>
> Key: MCOMPILER-457
> URL: https://issues.apache.org/jira/browse/MCOMPILER-457
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Reporter: Thomas Broyer
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> I see no reason to hide warnings by default, and setting {{failOnWarning}} to
> {{true}} will be useless without also setting {{showWarnings}} to {{true}};
> but you'll actually never know until you *actually* expect a warning (and
> build failure) and doesn't see it. Setting {{failOnWarning}} preventively
> without also setting {{showWarnings}} thus won't prevent anything; even if
> you also pass a strict {{-Xlint:all}} (because {{-nowarn}} has precedence
> apparently).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-compiler-plugin] slawekjaranowski merged pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
slawekjaranowski merged PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] slawekjaranowski commented on a diff in pull request #157: [MCOMPILER-457] Change showWarnings to true by default
slawekjaranowski commented on code in PR #157: URL: https://github.com/apache/maven-compiler-plugin/pull/157#discussion_r1038440809 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -176,7 +176,7 @@ /** * Set to true to show compilation warnings. */ Review Comment: We should update such documentation to something like: ``` Set to false disable warnings during compilation ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7609) Clarify documentation of extension descriptor
[
https://issues.apache.org/jira/browse/MNG-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642634#comment-17642634
]
Hudson commented on MNG-7609:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » PR-896 #2
See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-896/2/
> Clarify documentation of extension descriptor
> -
>
> Key: MNG-7609
> URL: https://issues.apache.org/jira/browse/MNG-7609
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
>
> The extension descriptor is documented in
> https://maven.apache.org/ref/3-LATEST/maven-core/extension.html based on the
> MDO file at
> https://github.com/apache/maven/blob/master/maven-core/src/main/mdo/extension.mdo.
> It is lacking important information such as
> - how are subpackages and wildcards handled in {{exportedPackages}}?
> - how can one export individual classes via {{exportedPackages}} (compare
> with
> https://github.com/apache/maven/blob/c6ecff9923088d854d4621e17d602f1c70dda806/maven-core/src/main/mdo/extension.mdo#L50)
> - how are {{exportedPackages}} and {{exportedArtifacts}} related? Are they
> just merged or are they combined in some other way?
> The better extension descriptor documentation should finally be linked also
> from
> https://github.com/apache/maven/blob/master/maven-core/src/site/apt/core-extensions.apt.vm,
> as well as from
> https://maven.apache.org/guides/mini/guide-maven-classloading.html#API_Classloader
> and https://maven.apache.org/guides/mini/guide-using-extensions.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7608) Make Resolver native transport the default in Maven4
[ https://issues.apache.org/jira/browse/MNG-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642635#comment-17642635 ] Hudson commented on MNG-7608: - Build unstable in Jenkins: Maven » Maven TLP » maven » PR-896 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-896/2/ > Make Resolver native transport the default in Maven4 > > > Key: MNG-7608 > URL: https://issues.apache.org/jira/browse/MNG-7608 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate, 4.0.0 > > > The ancient Wagon should be phased out, and "native" resolver transport > should be the default in Maven4. This in start halves the HTTP request count > toward Maven Central and any major MRM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7612) Chained Local Repository
[ https://issues.apache.org/jira/browse/MNG-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642624#comment-17642624 ] Hudson commented on MNG-7612: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #95 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/95/ > Chained Local Repository > - > > Key: MNG-7612 > URL: https://issues.apache.org/jira/browse/MNG-7612 > Project: Maven > Issue Type: New Feature > Components: Artifacts and Repositories >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > New feature: Chained Local Repository Manager (CLRM). > This new feature is not something one would use in production, is more > targeted to Integration Test isolation. > User story: ITs usually are run as part of Maven build – lets call it "outer > build" – that may build among other things, plugins and some artifacts needed > for the ITs. The ITs itself – let's call them "inner build" – should run in > isolated environment. > Problem: the "outer build" is usually affected by user environment > (settings.xml, use of MRM, and may use user own local repository unless > alternate specified) but also we do not want user MRM to be altered by IT > runs. The "inner build" on the other hand, may fail if use same LRM as "outer > build", as they are isolated, so they do not use settings.xml from the outer > build, may not use MRM and same remote repository IDs, and all these may lead > to mysterious "artifact not found" problems. Typically, outer build may use > MRM that defines mirrorOf with ID "my-mrm", while inner would use defaults, > where only remote repository is "central": this leads that user LRM gets > populated with artifacts available from "my-mrm" remote repository, while > inner build would know only about "central" remote repository. Enhanced LRM > (default since Maven 3.0) would refuse to serve up these artifacts. > Solution is CLRM: with CLRM user is able to specify isolated LRM for ITs, > while still making artifacts from outer LRM "visible" (discoverable) for the > IT build. Inner build uses isolated LRM solely, but for resolution purposes > still is able to resolve from outer LRM, where outer build might deployed > artifacts, plugins used by IT inner build. > Technical remark: CLRM defines "head" LRM, and list of LRM as "tail". Almost > all methods are delegated toward "head", except for find methods (metadata > and artifact), exposing tail LRM contents for artifact resolution. Also, CLRM > is *able* to enforce artifact availability (as explained above), but in most > cases (at least in IT user story), one would want to inhibit this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #153: [MCOMPILER-457] Warn about warn-config conflicting values
pzygielo commented on PR #153: URL: https://github.com/apache/maven-compiler-plugin/pull/153#issuecomment-1335567397 May I ask for review, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #157: [MCOMPILER-457] Change showWarnings to true by default
pzygielo commented on PR #157: URL: https://github.com/apache/maven-compiler-plugin/pull/157#issuecomment-1335567019 May I ask for review, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7612) Chained Local Repository
[ https://issues.apache.org/jira/browse/MNG-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642614#comment-17642614 ] ASF GitHub Bot commented on MNG-7612: - slawekjaranowski merged PR #890: URL: https://github.com/apache/maven/pull/890 > Chained Local Repository > - > > Key: MNG-7612 > URL: https://issues.apache.org/jira/browse/MNG-7612 > Project: Maven > Issue Type: New Feature > Components: Artifacts and Repositories >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > New feature: Chained Local Repository Manager (CLRM). > This new feature is not something one would use in production, is more > targeted to Integration Test isolation. > User story: ITs usually are run as part of Maven build – lets call it "outer > build" – that may build among other things, plugins and some artifacts needed > for the ITs. The ITs itself – let's call them "inner build" – should run in > isolated environment. > Problem: the "outer build" is usually affected by user environment > (settings.xml, use of MRM, and may use user own local repository unless > alternate specified) but also we do not want user MRM to be altered by IT > runs. The "inner build" on the other hand, may fail if use same LRM as "outer > build", as they are isolated, so they do not use settings.xml from the outer > build, may not use MRM and same remote repository IDs, and all these may lead > to mysterious "artifact not found" problems. Typically, outer build may use > MRM that defines mirrorOf with ID "my-mrm", while inner would use defaults, > where only remote repository is "central": this leads that user LRM gets > populated with artifacts available from "my-mrm" remote repository, while > inner build would know only about "central" remote repository. Enhanced LRM > (default since Maven 3.0) would refuse to serve up these artifacts. > Solution is CLRM: with CLRM user is able to specify isolated LRM for ITs, > while still making artifacts from outer LRM "visible" (discoverable) for the > IT build. Inner build uses isolated LRM solely, but for resolution purposes > still is able to resolve from outer LRM, where outer build might deployed > artifacts, plugins used by IT inner build. > Technical remark: CLRM defines "head" LRM, and list of LRM as "tail". Almost > all methods are delegated toward "head", except for find methods (metadata > and artifact), exposing tail LRM contents for artifact resolution. Also, CLRM > is *able* to enforce artifact availability (as explained above), but in most > cases (at least in IT user story), one would want to inhibit this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] slawekjaranowski merged pull request #890: [MNG-7612] Chained LRM
slawekjaranowski merged PR #890: URL: https://github.com/apache/maven/pull/890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7608) Make Resolver native transport the default in Maven4
[ https://issues.apache.org/jira/browse/MNG-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642609#comment-17642609 ] Hudson commented on MNG-7608: - Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-890 #3 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-890/3/ > Make Resolver native transport the default in Maven4 > > > Key: MNG-7608 > URL: https://issues.apache.org/jira/browse/MNG-7608 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate, 4.0.0 > > > The ancient Wagon should be phased out, and "native" resolver transport > should be the default in Maven4. This in start halves the HTTP request count > toward Maven Central and any major MRM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7612) Chained Local Repository
[ https://issues.apache.org/jira/browse/MNG-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642608#comment-17642608 ] Hudson commented on MNG-7612: - Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-890 #3 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-890/3/ > Chained Local Repository > - > > Key: MNG-7612 > URL: https://issues.apache.org/jira/browse/MNG-7612 > Project: Maven > Issue Type: New Feature > Components: Artifacts and Repositories >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > New feature: Chained Local Repository Manager (CLRM). > This new feature is not something one would use in production, is more > targeted to Integration Test isolation. > User story: ITs usually are run as part of Maven build – lets call it "outer > build" – that may build among other things, plugins and some artifacts needed > for the ITs. The ITs itself – let's call them "inner build" – should run in > isolated environment. > Problem: the "outer build" is usually affected by user environment > (settings.xml, use of MRM, and may use user own local repository unless > alternate specified) but also we do not want user MRM to be altered by IT > runs. The "inner build" on the other hand, may fail if use same LRM as "outer > build", as they are isolated, so they do not use settings.xml from the outer > build, may not use MRM and same remote repository IDs, and all these may lead > to mysterious "artifact not found" problems. Typically, outer build may use > MRM that defines mirrorOf with ID "my-mrm", while inner would use defaults, > where only remote repository is "central": this leads that user LRM gets > populated with artifacts available from "my-mrm" remote repository, while > inner build would know only about "central" remote repository. Enhanced LRM > (default since Maven 3.0) would refuse to serve up these artifacts. > Solution is CLRM: with CLRM user is able to specify isolated LRM for ITs, > while still making artifacts from outer LRM "visible" (discoverable) for the > IT build. Inner build uses isolated LRM solely, but for resolution purposes > still is able to resolve from outer LRM, where outer build might deployed > artifacts, plugins used by IT inner build. > Technical remark: CLRM defines "head" LRM, and list of LRM as "tail". Almost > all methods are delegated toward "head", except for find methods (metadata > and artifact), exposing tail LRM contents for artifact resolution. Also, CLRM > is *able* to enforce artifact availability (as explained above), but in most > cases (at least in IT user story), one would want to inhibit this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7614) Maven should translate transport configuration fully to resolver transports.
[ https://issues.apache.org/jira/browse/MNG-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642607#comment-17642607 ] Hudson commented on MNG-7614: - Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-890 #3 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-890/3/ > Maven should translate transport configuration fully to resolver transports. > > > Key: MNG-7614 > URL: https://issues.apache.org/jira/browse/MNG-7614 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.0 > > > Maven should properly translate transport configuration, instead to assume > Wagon. > Master (Maven 4) got this fixed as part of MNG-7608, but for Maven 3.9.x this > needs to be backported, as it got native transporter as part of MNG-7454 but > confguration translation still needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-script-interpreter] slawekjaranowski opened a new pull request, #86: Code cleanup after parent 38
slawekjaranowski opened a new pull request, #86: URL: https://github.com/apache/maven-script-interpreter/pull/86 - remove duplicate licenses header - workaround for MPOM-371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-script-interpreter] slawekjaranowski commented on pull request #83: Bump maven-shared-components from 37 to 38
slawekjaranowski commented on PR #83: URL: https://github.com/apache/maven-script-interpreter/pull/83#issuecomment-1335511427 Agree nobody looks at it but we still love such reports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7608) Make Resolver native transport the default in Maven4
[ https://issues.apache.org/jira/browse/MNG-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642594#comment-17642594 ] Hudson commented on MNG-7608: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #94 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/94/ > Make Resolver native transport the default in Maven4 > > > Key: MNG-7608 > URL: https://issues.apache.org/jira/browse/MNG-7608 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate, 4.0.0 > > > The ancient Wagon should be phased out, and "native" resolver transport > should be the default in Maven4. This in start halves the HTTP request count > toward Maven Central and any major MRM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7614) Maven should translate transport configuration fully to resolver transports.
[ https://issues.apache.org/jira/browse/MNG-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642593#comment-17642593 ] Hudson commented on MNG-7614: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #94 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/94/ > Maven should translate transport configuration fully to resolver transports. > > > Key: MNG-7614 > URL: https://issues.apache.org/jira/browse/MNG-7614 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.0 > > > Maven should properly translate transport configuration, instead to assume > Wagon. > Master (Maven 4) got this fixed as part of MNG-7608, but for Maven 3.9.x this > needs to be backported, as it got native transporter as part of MNG-7454 but > confguration translation still needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7608) Make Resolver native transport the default in Maven4
[ https://issues.apache.org/jira/browse/MNG-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642585#comment-17642585 ] Hudson commented on MNG-7608: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #144 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/144/ > Make Resolver native transport the default in Maven4 > > > Key: MNG-7608 > URL: https://issues.apache.org/jira/browse/MNG-7608 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate, 4.0.0 > > > The ancient Wagon should be phased out, and "native" resolver transport > should be the default in Maven4. This in start halves the HTTP request count > toward Maven Central and any major MRM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-7608) Make Resolver native transport the default in Maven4
[ https://issues.apache.org/jira/browse/MNG-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-7608. Resolution: Fixed > Make Resolver native transport the default in Maven4 > > > Key: MNG-7608 > URL: https://issues.apache.org/jira/browse/MNG-7608 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate, 4.0.0 > > > The ancient Wagon should be phased out, and "native" resolver transport > should be the default in Maven4. This in start halves the HTTP request count > toward Maven Central and any major MRM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-7614) Maven should translate transport configuration fully to resolver transports.
[ https://issues.apache.org/jira/browse/MNG-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-7614. Resolution: Fixed > Maven should translate transport configuration fully to resolver transports. > > > Key: MNG-7614 > URL: https://issues.apache.org/jira/browse/MNG-7614 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.0 > > > Maven should properly translate transport configuration, instead to assume > Wagon. > Master (Maven 4) got this fixed as part of MNG-7608, but for Maven 3.9.x this > needs to be backported, as it got native transporter as part of MNG-7454 but > confguration translation still needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7608) Make Resolver native transport the default in Maven4
[ https://issues.apache.org/jira/browse/MNG-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642570#comment-17642570 ] ASF GitHub Bot commented on MNG-7608: - cstamas merged PR #892: URL: https://github.com/apache/maven/pull/892 > Make Resolver native transport the default in Maven4 > > > Key: MNG-7608 > URL: https://issues.apache.org/jira/browse/MNG-7608 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate, 4.0.0 > > > The ancient Wagon should be phased out, and "native" resolver transport > should be the default in Maven4. This in start halves the HTTP request count > toward Maven Central and any major MRM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7614) Maven should translate transport configuration fully to resolver transports.
[ https://issues.apache.org/jira/browse/MNG-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642569#comment-17642569 ] ASF GitHub Bot commented on MNG-7614: - cstamas merged PR #895: URL: https://github.com/apache/maven/pull/895 > Maven should translate transport configuration fully to resolver transports. > > > Key: MNG-7614 > URL: https://issues.apache.org/jira/browse/MNG-7614 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.0 > > > Maven should properly translate transport configuration, instead to assume > Wagon. > Master (Maven 4) got this fixed as part of MNG-7608, but for Maven 3.9.x this > needs to be backported, as it got native transporter as part of MNG-7454 but > confguration translation still needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas merged pull request #892: [MNG-7608] Make native transport the default
cstamas merged PR #892: URL: https://github.com/apache/maven/pull/892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] cstamas merged pull request #216: MNG-7608] Make native transport the default
cstamas merged PR #216: URL: https://github.com/apache/maven-integration-testing/pull/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas merged pull request #895: [MNG-7614] Translate Plexus XML to proper resolver configuration
cstamas merged PR #895: URL: https://github.com/apache/maven/pull/895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7617) Small optimisations and cleanup in the project/model building
[ https://issues.apache.org/jira/browse/MNG-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642568#comment-17642568 ] Hudson commented on MNG-7617: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #143 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/143/ > Small optimisations and cleanup in the project/model building > - > > Key: MNG-7617 > URL: https://issues.apache.org/jira/browse/MNG-7617 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Minor > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7616) Add missing exported artifacts for the new API
[ https://issues.apache.org/jira/browse/MNG-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642567#comment-17642567 ] Hudson commented on MNG-7616: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #143 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/143/ > Add missing exported artifacts for the new API > -- > > Key: MNG-7616 > URL: https://issues.apache.org/jira/browse/MNG-7616 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-site] cstamas merged pull request #347: Add generic documentation how to configure transports
cstamas merged PR #347: URL: https://github.com/apache/maven-site/pull/347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-7617) Small optimisations and cleanup in the project/model building
[ https://issues.apache.org/jira/browse/MNG-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7617. Assignee: Guillaume Nodet Resolution: Fixed > Small optimisations and cleanup in the project/model building > - > > Key: MNG-7617 > URL: https://issues.apache.org/jira/browse/MNG-7617 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Minor > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7617) Small optimisations and cleanup in the project/model building
[ https://issues.apache.org/jira/browse/MNG-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642526#comment-17642526 ] ASF GitHub Bot commented on MNG-7617: - gnodet merged PR #816: URL: https://github.com/apache/maven/pull/816 > Small optimisations and cleanup in the project/model building > - > > Key: MNG-7617 > URL: https://issues.apache.org/jira/browse/MNG-7617 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Minor > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet merged pull request #816: [MNG-7617] Small optimisations and cleanup in the project/model building
gnodet merged PR #816: URL: https://github.com/apache/maven/pull/816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7617) Small optimisations and cleanup in the project/model building
Guillaume Nodet created MNG-7617: Summary: Small optimisations and cleanup in the project/model building Key: MNG-7617 URL: https://issues.apache.org/jira/browse/MNG-7617 Project: Maven Issue Type: Task Reporter: Guillaume Nodet Fix For: 4.0.0-alpha-3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-7616) Add missing exported artifacts for the new API
[ https://issues.apache.org/jira/browse/MNG-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7616. Resolution: Fixed > Add missing exported artifacts for the new API > -- > > Key: MNG-7616 > URL: https://issues.apache.org/jira/browse/MNG-7616 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7616) Add missing exported artifacts for the new API
[ https://issues.apache.org/jira/browse/MNG-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7616: - Summary: Add missing exported artifacts for the new API (was: Fix missing exported artifacts) > Add missing exported artifacts for the new API > -- > > Key: MNG-7616 > URL: https://issues.apache.org/jira/browse/MNG-7616 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7616) Fix missing exported artifacts
[ https://issues.apache.org/jira/browse/MNG-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642522#comment-17642522 ] ASF GitHub Bot commented on MNG-7616: - gnodet merged PR #894: URL: https://github.com/apache/maven/pull/894 > Fix missing exported artifacts > -- > > Key: MNG-7616 > URL: https://issues.apache.org/jira/browse/MNG-7616 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet merged pull request #894: [MNG-7616] Fix missing exported artifacts
gnodet merged PR #894: URL: https://github.com/apache/maven/pull/894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7613) Upgrade Apache Maven parent POM to version 38
[ https://issues.apache.org/jira/browse/MNG-7613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642521#comment-17642521 ] Hudson commented on MNG-7613: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #93 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/93/ > Upgrade Apache Maven parent POM to version 38 > - > > Key: MNG-7613 > URL: https://issues.apache.org/jira/browse/MNG-7613 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] mthmulders commented on a diff in pull request #816: Small optimisations and cleanup
mthmulders commented on code in PR #816:
URL: https://github.com/apache/maven/pull/816#discussion_r1038161348
##
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/BuildTimestampValueSource.java:
##
@@ -23,17 +23,19 @@
import org.codehaus.plexus.interpolation.AbstractValueSource;
class BuildTimestampValueSource extends AbstractValueSource {
-private final MavenBuildTimestamp mavenBuildTimestamp;
+private final Date startTime;
+private final Map properties;
BuildTimestampValueSource(Date startTime, Map properties) {
Review Comment:
AFAICS, the `MavenBuildTimestamp` class takes care of properly applying the
`maven.build.timestamp.format` value, too. I think it's a bit too much to
inline all of that here. Let's leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7614) Maven should translate transport configuration fully to resolver transports.
[
https://issues.apache.org/jira/browse/MNG-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642514#comment-17642514
]
ASF GitHub Bot commented on MNG-7614:
-
cstamas commented on code in PR #895:
URL: https://github.com/apache/maven/pull/895#discussion_r1038151549
##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -209,6 +211,76 @@ public DefaultRepositorySystemSession
newRepositorySession(MavenExecutionRequest
XmlPlexusConfiguration config = new
XmlPlexusConfiguration(dom);
configProps.put("aether.connector.wagon.config." +
server.getId(), config);
+
+// Translate to proper resolver configuration properties as
well (as Plexus XML above is Wagon specific
+// only)
+// but support only configuration/httpConfiguration/all, not
the per-method nonsense
+//
https://maven.apache.org/guides/mini/guide-http-settings.html
+Map headers = null;
+Integer connectTimeout = null;
+Integer requestTimeout = null;
+
+PlexusConfiguration httpHeaders =
config.getChild("httpHeaders", false);
+if (httpHeaders != null) {
+PlexusConfiguration[] properties =
httpHeaders.getChildren("property");
+if (properties != null && properties.length > 0) {
+headers = new HashMap<>();
+for (PlexusConfiguration property : properties) {
+headers.put(
+property.getChild("name").getValue(),
+property.getChild("value").getValue());
+}
+}
+}
+
+PlexusConfiguration connectTimeoutXml =
config.getChild("connectTimeout", false);
+if (connectTimeoutXml != null) {
+connectTimeout =
Integer.parseInt(connectTimeoutXml.getValue());
+} else {
+// fallback configuration name
+PlexusConfiguration httpConfiguration =
config.getChild("httpConfiguration", false);
+if (httpConfiguration != null) {
Review Comment:
that would mean am potentially mutating the config object (that is already
passed to Wagon as Plexus config)
> Maven should translate transport configuration fully to resolver transports.
>
>
> Key: MNG-7614
> URL: https://issues.apache.org/jira/browse/MNG-7614
> Project: Maven
> Issue Type: Improvement
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0
>
>
> Maven should properly translate transport configuration, instead to assume
> Wagon.
> Master (Maven 4) got this fixed as part of MNG-7608, but for Maven 3.9.x this
> needs to be backported, as it got native transporter as part of MNG-7454 but
> confguration translation still needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on a diff in pull request #895: [MNG-7614] Translate Plexus XML to proper resolver configuration
cstamas commented on code in PR #895:
URL: https://github.com/apache/maven/pull/895#discussion_r1038151549
##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -209,6 +211,76 @@ public DefaultRepositorySystemSession
newRepositorySession(MavenExecutionRequest
XmlPlexusConfiguration config = new
XmlPlexusConfiguration(dom);
configProps.put("aether.connector.wagon.config." +
server.getId(), config);
+
+// Translate to proper resolver configuration properties as
well (as Plexus XML above is Wagon specific
+// only)
+// but support only configuration/httpConfiguration/all, not
the per-method nonsense
+//
https://maven.apache.org/guides/mini/guide-http-settings.html
+Map headers = null;
+Integer connectTimeout = null;
+Integer requestTimeout = null;
+
+PlexusConfiguration httpHeaders =
config.getChild("httpHeaders", false);
+if (httpHeaders != null) {
+PlexusConfiguration[] properties =
httpHeaders.getChildren("property");
+if (properties != null && properties.length > 0) {
+headers = new HashMap<>();
+for (PlexusConfiguration property : properties) {
+headers.put(
+property.getChild("name").getValue(),
+property.getChild("value").getValue());
+}
+}
+}
+
+PlexusConfiguration connectTimeoutXml =
config.getChild("connectTimeout", false);
+if (connectTimeoutXml != null) {
+connectTimeout =
Integer.parseInt(connectTimeoutXml.getValue());
+} else {
+// fallback configuration name
+PlexusConfiguration httpConfiguration =
config.getChild("httpConfiguration", false);
+if (httpConfiguration != null) {
Review Comment:
that would mean am potentially mutating the config object (that is already
passed to Wagon as Plexus config) -- so nope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7614) Maven should translate transport configuration fully to resolver transports.
[
https://issues.apache.org/jira/browse/MNG-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642513#comment-17642513
]
ASF GitHub Bot commented on MNG-7614:
-
cstamas commented on code in PR #895:
URL: https://github.com/apache/maven/pull/895#discussion_r1038151549
##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -209,6 +211,76 @@ public DefaultRepositorySystemSession
newRepositorySession(MavenExecutionRequest
XmlPlexusConfiguration config = new
XmlPlexusConfiguration(dom);
configProps.put("aether.connector.wagon.config." +
server.getId(), config);
+
+// Translate to proper resolver configuration properties as
well (as Plexus XML above is Wagon specific
+// only)
+// but support only configuration/httpConfiguration/all, not
the per-method nonsense
+//
https://maven.apache.org/guides/mini/guide-http-settings.html
+Map headers = null;
+Integer connectTimeout = null;
+Integer requestTimeout = null;
+
+PlexusConfiguration httpHeaders =
config.getChild("httpHeaders", false);
+if (httpHeaders != null) {
+PlexusConfiguration[] properties =
httpHeaders.getChildren("property");
+if (properties != null && properties.length > 0) {
+headers = new HashMap<>();
+for (PlexusConfiguration property : properties) {
+headers.put(
+property.getChild("name").getValue(),
+property.getChild("value").getValue());
+}
+}
+}
+
+PlexusConfiguration connectTimeoutXml =
config.getChild("connectTimeout", false);
+if (connectTimeoutXml != null) {
+connectTimeout =
Integer.parseInt(connectTimeoutXml.getValue());
+} else {
+// fallback configuration name
+PlexusConfiguration httpConfiguration =
config.getChild("httpConfiguration", false);
+if (httpConfiguration != null) {
Review Comment:
that would mean am potentially mutating the XML (that is already passed to
Wagon as Plexus config)
> Maven should translate transport configuration fully to resolver transports.
>
>
> Key: MNG-7614
> URL: https://issues.apache.org/jira/browse/MNG-7614
> Project: Maven
> Issue Type: Improvement
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0
>
>
> Maven should properly translate transport configuration, instead to assume
> Wagon.
> Master (Maven 4) got this fixed as part of MNG-7608, but for Maven 3.9.x this
> needs to be backported, as it got native transporter as part of MNG-7454 but
> confguration translation still needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on a diff in pull request #895: [MNG-7614] Translate Plexus XML to proper resolver configuration
cstamas commented on code in PR #895:
URL: https://github.com/apache/maven/pull/895#discussion_r1038151549
##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -209,6 +211,76 @@ public DefaultRepositorySystemSession
newRepositorySession(MavenExecutionRequest
XmlPlexusConfiguration config = new
XmlPlexusConfiguration(dom);
configProps.put("aether.connector.wagon.config." +
server.getId(), config);
+
+// Translate to proper resolver configuration properties as
well (as Plexus XML above is Wagon specific
+// only)
+// but support only configuration/httpConfiguration/all, not
the per-method nonsense
+//
https://maven.apache.org/guides/mini/guide-http-settings.html
+Map headers = null;
+Integer connectTimeout = null;
+Integer requestTimeout = null;
+
+PlexusConfiguration httpHeaders =
config.getChild("httpHeaders", false);
+if (httpHeaders != null) {
+PlexusConfiguration[] properties =
httpHeaders.getChildren("property");
+if (properties != null && properties.length > 0) {
+headers = new HashMap<>();
+for (PlexusConfiguration property : properties) {
+headers.put(
+property.getChild("name").getValue(),
+property.getChild("value").getValue());
+}
+}
+}
+
+PlexusConfiguration connectTimeoutXml =
config.getChild("connectTimeout", false);
+if (connectTimeoutXml != null) {
+connectTimeout =
Integer.parseInt(connectTimeoutXml.getValue());
+} else {
+// fallback configuration name
+PlexusConfiguration httpConfiguration =
config.getChild("httpConfiguration", false);
+if (httpConfiguration != null) {
Review Comment:
that would mean am potentially mutating the XML (that is already passed to
Wagon as Plexus config) -- so nope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7614) Maven should translate transport configuration fully to resolver transports.
[
https://issues.apache.org/jira/browse/MNG-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642509#comment-17642509
]
ASF GitHub Bot commented on MNG-7614:
-
kwin commented on code in PR #895:
URL: https://github.com/apache/maven/pull/895#discussion_r1038147559
##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -209,6 +211,76 @@ public DefaultRepositorySystemSession
newRepositorySession(MavenExecutionRequest
XmlPlexusConfiguration config = new
XmlPlexusConfiguration(dom);
configProps.put("aether.connector.wagon.config." +
server.getId(), config);
+
+// Translate to proper resolver configuration properties as
well (as Plexus XML above is Wagon specific
+// only)
+// but support only configuration/httpConfiguration/all, not
the per-method nonsense
+//
https://maven.apache.org/guides/mini/guide-http-settings.html
+Map headers = null;
+Integer connectTimeout = null;
+Integer requestTimeout = null;
+
+PlexusConfiguration httpHeaders =
config.getChild("httpHeaders", false);
+if (httpHeaders != null) {
+PlexusConfiguration[] properties =
httpHeaders.getChildren("property");
+if (properties != null && properties.length > 0) {
+headers = new HashMap<>();
+for (PlexusConfiguration property : properties) {
+headers.put(
+property.getChild("name").getValue(),
+property.getChild("value").getValue());
+}
+}
+}
+
+PlexusConfiguration connectTimeoutXml =
config.getChild("connectTimeout", false);
+if (connectTimeoutXml != null) {
+connectTimeout =
Integer.parseInt(connectTimeoutXml.getValue());
+} else {
+// fallback configuration name
+PlexusConfiguration httpConfiguration =
config.getChild("httpConfiguration", false);
+if (httpConfiguration != null) {
Review Comment:
maybe instead of the nested if, just `config.getChild("httpConfiguration",
true).getChild("all", true).getChild("connectionTimeout", false)`
> Maven should translate transport configuration fully to resolver transports.
>
>
> Key: MNG-7614
> URL: https://issues.apache.org/jira/browse/MNG-7614
> Project: Maven
> Issue Type: Improvement
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0
>
>
> Maven should properly translate transport configuration, instead to assume
> Wagon.
> Master (Maven 4) got this fixed as part of MNG-7608, but for Maven 3.9.x this
> needs to be backported, as it got native transporter as part of MNG-7454 but
> confguration translation still needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] kwin commented on a diff in pull request #895: [MNG-7614] Translate Plexus XML to proper resolver configuration
kwin commented on code in PR #895:
URL: https://github.com/apache/maven/pull/895#discussion_r1038147559
##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -209,6 +211,76 @@ public DefaultRepositorySystemSession
newRepositorySession(MavenExecutionRequest
XmlPlexusConfiguration config = new
XmlPlexusConfiguration(dom);
configProps.put("aether.connector.wagon.config." +
server.getId(), config);
+
+// Translate to proper resolver configuration properties as
well (as Plexus XML above is Wagon specific
+// only)
+// but support only configuration/httpConfiguration/all, not
the per-method nonsense
+//
https://maven.apache.org/guides/mini/guide-http-settings.html
+Map headers = null;
+Integer connectTimeout = null;
+Integer requestTimeout = null;
+
+PlexusConfiguration httpHeaders =
config.getChild("httpHeaders", false);
+if (httpHeaders != null) {
+PlexusConfiguration[] properties =
httpHeaders.getChildren("property");
+if (properties != null && properties.length > 0) {
+headers = new HashMap<>();
+for (PlexusConfiguration property : properties) {
+headers.put(
+property.getChild("name").getValue(),
+property.getChild("value").getValue());
+}
+}
+}
+
+PlexusConfiguration connectTimeoutXml =
config.getChild("connectTimeout", false);
+if (connectTimeoutXml != null) {
+connectTimeout =
Integer.parseInt(connectTimeoutXml.getValue());
+} else {
+// fallback configuration name
+PlexusConfiguration httpConfiguration =
config.getChild("httpConfiguration", false);
+if (httpConfiguration != null) {
Review Comment:
maybe instead of the nested if, just `config.getChild("httpConfiguration",
true).getChild("all", true).getChild("connectionTimeout", false)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7614) Maven should translate transport configuration fully to resolver transports.
[
https://issues.apache.org/jira/browse/MNG-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642507#comment-17642507
]
ASF GitHub Bot commented on MNG-7614:
-
kwin commented on code in PR #895:
URL: https://github.com/apache/maven/pull/895#discussion_r1038145135
##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -209,6 +211,76 @@ public DefaultRepositorySystemSession
newRepositorySession(MavenExecutionRequest
XmlPlexusConfiguration config = new
XmlPlexusConfiguration(dom);
configProps.put("aether.connector.wagon.config." +
server.getId(), config);
+
+// Translate to proper resolver configuration properties as
well (as Plexus XML above is Wagon specific
+// only)
+// but support only configuration/httpConfiguration/all, not
the per-method nonsense
Review Comment:
`not the per-method nonsense` :-) maybe just mention that only method `all`
is supported.
> Maven should translate transport configuration fully to resolver transports.
>
>
> Key: MNG-7614
> URL: https://issues.apache.org/jira/browse/MNG-7614
> Project: Maven
> Issue Type: Improvement
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0
>
>
> Maven should properly translate transport configuration, instead to assume
> Wagon.
> Master (Maven 4) got this fixed as part of MNG-7608, but for Maven 3.9.x this
> needs to be backported, as it got native transporter as part of MNG-7454 but
> confguration translation still needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] kwin commented on a diff in pull request #895: [MNG-7614] Translate Plexus XML to proper resolver configuration
kwin commented on code in PR #895:
URL: https://github.com/apache/maven/pull/895#discussion_r1038145135
##
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##
@@ -209,6 +211,76 @@ public DefaultRepositorySystemSession
newRepositorySession(MavenExecutionRequest
XmlPlexusConfiguration config = new
XmlPlexusConfiguration(dom);
configProps.put("aether.connector.wagon.config." +
server.getId(), config);
+
+// Translate to proper resolver configuration properties as
well (as Plexus XML above is Wagon specific
+// only)
+// but support only configuration/httpConfiguration/all, not
the per-method nonsense
Review Comment:
`not the per-method nonsense` :-) maybe just mention that only method `all`
is supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7616) Fix missing exported artifacts
[ https://issues.apache.org/jira/browse/MNG-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642503#comment-17642503 ] ASF GitHub Bot commented on MNG-7616: - cstamas commented on PR #894: URL: https://github.com/apache/maven/pull/894#issuecomment-1335237275 > @cstamas I think a few resolver artifacts are missing, but I'm not even sure they are part of the default class loader. Could you double check ? Nope, all good, connector and transport is not part of public api, they were never published > Fix missing exported artifacts > -- > > Key: MNG-7616 > URL: https://issues.apache.org/jira/browse/MNG-7616 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #894: [MNG-7616] Fix missing exported artifacts
cstamas commented on PR #894: URL: https://github.com/apache/maven/pull/894#issuecomment-1335237275 > @cstamas I think a few resolver artifacts are missing, but I'm not even sure they are part of the default class loader. Could you double check ? Nope, all good, connector and transport is not part of public api, they were never published -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPOM-358) Automatically enable "reporting" profile during release
[ https://issues.apache.org/jira/browse/MPOM-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed MPOM-358. Resolution: Won't Fix > Automatically enable "reporting" profile during release > --- > > Key: MPOM-358 > URL: https://issues.apache.org/jira/browse/MPOM-358 > Project: Maven POMs > Issue Type: Improvement > Components: maven >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > The "reporting" profile contains crucial reports for the generated site and > should therefore be automatically enabled during release. Otherwise the site > being created and deployed during a release may easily miss those reports. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPOM-358) Automatically enable "reporting" profile during release
[ https://issues.apache.org/jira/browse/MPOM-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642496#comment-17642496 ] Konrad Windszus commented on MPOM-358: -- As the prerequisite MPOM-359 has been closed as won't fix, this cannot be implemented. > Automatically enable "reporting" profile during release > --- > > Key: MPOM-358 > URL: https://issues.apache.org/jira/browse/MPOM-358 > Project: Maven POMs > Issue Type: Improvement > Components: maven >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > The "reporting" profile contains crucial reports for the generated site and > should therefore be automatically enabled during release. Otherwise the site > being created and deployed during a release may easily miss those reports. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-parent] kwin closed pull request #91: [MPOM-358] Activate "reporting" profile during releases
kwin closed pull request #91: [MPOM-358] Activate "reporting" profile during releases URL: https://github.com/apache/maven-parent/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPOM-359) Deploy site also with release:perform
[
https://issues.apache.org/jira/browse/MPOM-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus closed MPOM-359.
Resolution: Won't Fix
> Deploy site also with release:perform
> -
>
> Key: MPOM-359
> URL: https://issues.apache.org/jira/browse/MPOM-359
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Reporter: Konrad Windszus
>Priority: Major
>
> By default {{release:perform}} executes both {{deploy}} and {{site-deploy}}
> (if the project has a / element), compare with
> https://maven.apache.org/maven-release/maven-release-plugin/perform-mojo.html#goals.
> This default behaviour is overwritten in the ASF parent at
> https://github.com/apache/maven-apache-parent/blob/a4f3c6400104f711e86342649bb77a3a55f1f97f/pom.xml#L255
> by a simple {{deploy}} i.e. site is not built and deployed when performing
> the release.
> As having the staged site available for all Maven releases is reasonable
> already at the time the vote starts (makes it easy to verify the site) and
> the staging site is anyhow in a dedicated repository
> (https://maven.apache.org/developers/website/deploy-component-reference-documentation.html#staging-component-reference-documentation,
> i.e. not visible to end users) I propose to restore the default behaviour
> for {{m-r-p}} in the Maven Parent POM.
> This would also require to disable the default binding of
> https://maven.apache.org/plugins/maven-site-plugin/deploy-mojo.html and
> instead bind
> {{https://maven.apache.org/plugins/maven-scm-publish-plugin/publish-scm-mojo.html}}
> to that phase.
> Then the step 2 from
> https://maven.apache.org/developers/release/maven-project-release-procedure.html#promote-the-release
> would be a simple replacement of the final site at
> https://maven.apache.org/developers/website/deploy-component-reference-documentation.html#publishing-versioned-component-reference-documentation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5
[
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MNG-7611:
-
Fix Version/s: 4.0.0
> java.lang.IllegalStateException: Required Java version 1.8 is not met by
> current version: 17.0.5
>
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not
> met by current version: 17.0.5
>at
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5
[
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved MNG-7611.
--
Resolution: Fixed
> java.lang.IllegalStateException: Required Java version 1.8 is not met by
> current version: 17.0.5
>
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not
> met by current version: 17.0.5
>at
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7613) Upgrade Apache Maven parent POM to version 38
[ https://issues.apache.org/jira/browse/MNG-7613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MNG-7613. Resolution: Fixed > Upgrade Apache Maven parent POM to version 38 > - > > Key: MNG-7613 > URL: https://issues.apache.org/jira/browse/MNG-7613 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7616) Fix missing exported artifacts
[ https://issues.apache.org/jira/browse/MNG-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642481#comment-17642481 ] ASF GitHub Bot commented on MNG-7616: - gnodet commented on code in PR #894: URL: https://github.com/apache/maven/pull/894#discussion_r1038100207 ## maven-core/src/main/resources/META-INF/maven/extension.xml: ## @@ -136,6 +136,16 @@ under the License. + Fix missing exported artifacts > -- > > Key: MNG-7616 > URL: https://issues.apache.org/jira/browse/MNG-7616 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #894: [MNG-7616] Fix missing exported artifacts
gnodet commented on code in PR #894: URL: https://github.com/apache/maven/pull/894#discussion_r1038100207 ## maven-core/src/main/resources/META-INF/maven/extension.xml: ## @@ -136,6 +136,16 @@ under the License. + +org.apache.maven:maven-api-core +org.apache.maven:maven-api-meta +org.apache.maven:maven-api-model +org.apache.maven:maven-api-settings +org.apache.maven:maven-api-toolchain +org.apache.maven:maven-api-xml +org.apache.maven:maven-xml-impl +org.apache.maven:plexus-utils Review Comment: Good point. I've also removed the `maven-xml-impl` for the same reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] mthmulders commented on a diff in pull request #816: Small optimisations and cleanup
mthmulders commented on code in PR #816:
URL: https://github.com/apache/maven/pull/816#discussion_r1038097778
##
maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileActivationContext.java:
##
@@ -194,15 +162,30 @@ public Map getProjectProperties() {
}
public DefaultProfileActivationContext setProjectProperties(Properties
projectProperties) {
-if (projectProperties != null) {
-this.projectProperties = projectProperties.entrySet().stream()
-.collect(collectingAndThen(
-toMap(k -> String.valueOf(k.getKey()), v ->
String.valueOf(v)),
-Collections::unmodifiableMap));
-} else {
-this.projectProperties = Collections.emptyMap();
-}
+return setProjectProperties(toMap(projectProperties));
+}
+
+public DefaultProfileActivationContext setProjectProperties(Map projectProperties) {
+this.projectProperties = unmodifiable(projectProperties);
Review Comment:
Ah, I see, we now have *two* methods named `setProjectProperties`. The
`null` guarding is now split over those two methods, where it was previously in
one method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7613) Upgrade Apache Maven parent POM to version 38
[ https://issues.apache.org/jira/browse/MNG-7613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642478#comment-17642478 ] Hudson commented on MNG-7613: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #92 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/92/ > Upgrade Apache Maven parent POM to version 38 > - > > Key: MNG-7613 > URL: https://issues.apache.org/jira/browse/MNG-7613 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642479#comment-17642479 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #92 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/92/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #816: Small optimisations and cleanup
gnodet commented on code in PR #816:
URL: https://github.com/apache/maven/pull/816#discussion_r1038095866
##
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/BuildTimestampValueSource.java:
##
@@ -23,17 +23,19 @@
import org.codehaus.plexus.interpolation.AbstractValueSource;
class BuildTimestampValueSource extends AbstractValueSource {
-private final MavenBuildTimestamp mavenBuildTimestamp;
+private final Date startTime;
+private final Map properties;
BuildTimestampValueSource(Date startTime, Map properties) {
Review Comment:
Another possibility is to get rid of the `MavenBuildTimestamp` and simply
inline the call inside `BuildTimestampValueSource.getValue()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #816: Small optimisations and cleanup
gnodet commented on code in PR #816:
URL: https://github.com/apache/maven/pull/816#discussion_r1038094757
##
maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileActivationContext.java:
##
@@ -194,15 +162,30 @@ public Map getProjectProperties() {
}
public DefaultProfileActivationContext setProjectProperties(Properties
projectProperties) {
-if (projectProperties != null) {
-this.projectProperties = projectProperties.entrySet().stream()
-.collect(collectingAndThen(
-toMap(k -> String.valueOf(k.getKey()), v ->
String.valueOf(v)),
-Collections::unmodifiableMap));
-} else {
-this.projectProperties = Collections.emptyMap();
-}
+return setProjectProperties(toMap(projectProperties));
+}
+
+public DefaultProfileActivationContext setProjectProperties(Map projectProperties) {
+this.projectProperties = unmodifiable(projectProperties);
Review Comment:
> Previously, a `null` for the `projectProperties` argument would result in
`this.projectProperties` being an empty `Map`. With this patch, it would result
in `this.projectProperties` being `null`. Are you sure that's an intended
change?
I don't think that's true. `toMap` can return `null`, but `unmodifiable(x)`
returns an empty list/map, so `this.projectProperties` can never be `null`
afaik.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #816: Small optimisations and cleanup
gnodet commented on code in PR #816:
URL: https://github.com/apache/maven/pull/816#discussion_r1038090672
##
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/BuildTimestampValueSource.java:
##
@@ -23,17 +23,19 @@
import org.codehaus.plexus.interpolation.AbstractValueSource;
class BuildTimestampValueSource extends AbstractValueSource {
-private final MavenBuildTimestamp mavenBuildTimestamp;
+private final Date startTime;
+private final Map properties;
BuildTimestampValueSource(Date startTime, Map properties) {
Review Comment:
The problem is that the only usage is when using the
`ModelBuildingRequest.getBuildStartTime()`, which comes from
`ProjectBuildingRequest.getBuildStartTime()` and
`MavenExecutionRequest.getStartTime()`. Without modifying those, which are
public interfaces, there's no real value in changing this internal class.
Maybe when the core switches to the v4 api, as the start time is available
as an `Instant` on the `Session`, then it will make sense to switch. For now,
it will only add `Date` -> `Instant` conversions for no real value imho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (MNG-7244) Remove deprecated WARNING for usage of pom.X placeholders
[
https://issues.apache.org/jira/browse/MNG-7244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642347#comment-17642347
]
Michael Osipov edited comment on MNG-7244 at 12/2/22 12:19 PM:
---
{quote}[~cstamas], support it forever?
{quote}
Let's move that discussion to MNG-7604 as this ticket is already closed.
was (Author: mthmulders):
{quote}[~cstamas], support it forever?
{quote}
Let's move that discussion to
[MNG-7604|https://issues.apache.org/jira/browse/MNG-7244], as this ticket is
already closed.
> Remove deprecated WARNING for usage of pom.X placeholders
> -
>
> Key: MNG-7244
> URL: https://issues.apache.org/jira/browse/MNG-7244
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Assignee: Maarten Mulders
>Priority: Minor
> Fix For: 4.0.0-alpha-2, 4.0.0
>
>
> Currently, we produce a {{WARNING}} in case of using {{pom.version}} or alike.
> We've been doing that for years so people have had enough time to update
> their projects. We can now remove the support and the accompanying warning,
> resorting to the default behaviour of not resolving the expression at all.
> {code}
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for 'com.soebes.examples.j2ee:appasm:pom:1.0-SNAPSHOT'
> [WARNING] The expression ${pom.version} is deprecated. Please use
> ${project.version} instead.
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7616) Fix missing exported artifacts
[ https://issues.apache.org/jira/browse/MNG-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642469#comment-17642469 ] ASF GitHub Bot commented on MNG-7616: - kwin commented on code in PR #894: URL: https://github.com/apache/maven/pull/894#discussion_r1038069370 ## maven-core/src/main/resources/META-INF/maven/extension.xml: ## @@ -136,6 +136,16 @@ under the License. + Fix missing exported artifacts > -- > > Key: MNG-7616 > URL: https://issues.apache.org/jira/browse/MNG-7616 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] kwin commented on a diff in pull request #894: [MNG-7616] Fix missing exported artifacts
kwin commented on code in PR #894: URL: https://github.com/apache/maven/pull/894#discussion_r1038069370 ## maven-core/src/main/resources/META-INF/maven/extension.xml: ## @@ -136,6 +136,16 @@ under the License. + +org.apache.maven:maven-api-core +org.apache.maven:maven-api-meta +org.apache.maven:maven-api-model +org.apache.maven:maven-api-settings +org.apache.maven:maven-api-toolchain +org.apache.maven:maven-api-xml +org.apache.maven:maven-xml-impl +org.apache.maven:plexus-utils Review Comment: I don't think this works, as only a handful of classes are actually exposed. For that reason the old plexus-utils was also not listed here. IIUC then listing an artifact here makes it impossible to add it explicitly to the class loader hierarchy (for a plugin or build extension) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7616) Fix missing exported artifacts
[ https://issues.apache.org/jira/browse/MNG-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642463#comment-17642463 ] ASF GitHub Bot commented on MNG-7616: - kwin commented on code in PR #894: URL: https://github.com/apache/maven/pull/894#discussion_r1038069370 ## maven-core/src/main/resources/META-INF/maven/extension.xml: ## @@ -136,6 +136,16 @@ under the License. + Fix missing exported artifacts > -- > > Key: MNG-7616 > URL: https://issues.apache.org/jira/browse/MNG-7616 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7616) Fix missing exported artifacts
[ https://issues.apache.org/jira/browse/MNG-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642464#comment-17642464 ] ASF GitHub Bot commented on MNG-7616: - kwin commented on code in PR #894: URL: https://github.com/apache/maven/pull/894#discussion_r1038069370 ## maven-core/src/main/resources/META-INF/maven/extension.xml: ## @@ -136,6 +136,16 @@ under the License. + Fix missing exported artifacts > -- > > Key: MNG-7616 > URL: https://issues.apache.org/jira/browse/MNG-7616 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] kwin commented on a diff in pull request #894: [MNG-7616] Fix missing exported artifacts
kwin commented on code in PR #894: URL: https://github.com/apache/maven/pull/894#discussion_r1038069370 ## maven-core/src/main/resources/META-INF/maven/extension.xml: ## @@ -136,6 +136,16 @@ under the License. + +org.apache.maven:maven-api-core +org.apache.maven:maven-api-meta +org.apache.maven:maven-api-model +org.apache.maven:maven-api-settings +org.apache.maven:maven-api-toolchain +org.apache.maven:maven-api-xml +org.apache.maven:maven-xml-impl +org.apache.maven:plexus-utils Review Comment: I don't think this works, as only a handful of classes are actually exposed. For that reason the old plexus-utils was also no listed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7613) Upgrade Apache Maven parent POM to version 38
[ https://issues.apache.org/jira/browse/MNG-7613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642462#comment-17642462 ] ASF GitHub Bot commented on MNG-7613: - slawekjaranowski merged PR #891: URL: https://github.com/apache/maven/pull/891 > Upgrade Apache Maven parent POM to version 38 > - > > Key: MNG-7613 > URL: https://issues.apache.org/jira/browse/MNG-7613 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] kwin commented on a diff in pull request #894: [MNG-7616] Fix missing exported artifacts
kwin commented on code in PR #894: URL: https://github.com/apache/maven/pull/894#discussion_r1038069370 ## maven-core/src/main/resources/META-INF/maven/extension.xml: ## @@ -136,6 +136,16 @@ under the License. + +org.apache.maven:maven-api-core +org.apache.maven:maven-api-meta +org.apache.maven:maven-api-model +org.apache.maven:maven-api-settings +org.apache.maven:maven-api-toolchain +org.apache.maven:maven-api-xml +org.apache.maven:maven-xml-impl +org.apache.maven:plexus-utils Review Comment: I don't think this works, as only a handful of classes are actually exposed. For that reason the old plexus-utils was also not listed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski merged pull request #891: [MNG-7613] Upgrade Apache Maven parent POM to version 38
slawekjaranowski merged PR #891: URL: https://github.com/apache/maven/pull/891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7613) Upgrade Apache Maven parent POM to version 38
[ https://issues.apache.org/jira/browse/MNG-7613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642460#comment-17642460 ] ASF GitHub Bot commented on MNG-7613: - slawekjaranowski commented on PR #891: URL: https://github.com/apache/maven/pull/891#issuecomment-1335124322 Failed build on branch, now branch was moved to PR build so is not accessible. > Upgrade Apache Maven parent POM to version 38 > - > > Key: MNG-7613 > URL: https://issues.apache.org/jira/browse/MNG-7613 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] mthmulders commented on a diff in pull request #816: Small optimisations and cleanup
mthmulders commented on code in PR #816:
URL: https://github.com/apache/maven/pull/816#discussion_r1038065321
##
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/BuildTimestampValueSource.java:
##
@@ -23,17 +23,19 @@
import org.codehaus.plexus.interpolation.AbstractValueSource;
class BuildTimestampValueSource extends AbstractValueSource {
-private final MavenBuildTimestamp mavenBuildTimestamp;
+private final Date startTime;
+private final Map properties;
BuildTimestampValueSource(Date startTime, Map properties) {
super(false);
-this.mavenBuildTimestamp = new MavenBuildTimestamp(startTime,
properties);
+this.startTime = startTime;
+this.properties = properties;
Review Comment:
All right, that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #891: [MNG-7613] Upgrade Apache Maven parent POM to version 38
slawekjaranowski commented on PR #891: URL: https://github.com/apache/maven/pull/891#issuecomment-1335124322 Failed build on branch, now branch was moved to PR build so is not accessible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] cstamas opened a new pull request, #347: Add generic documentation how to configure transports
cstamas opened a new pull request, #347: URL: https://github.com/apache/maven-site/pull/347 As HTTP settings are not "wagon-only" anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #816: Small optimisations and cleanup
gnodet commented on code in PR #816:
URL: https://github.com/apache/maven/pull/816#discussion_r1038039145
##
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/BuildTimestampValueSource.java:
##
@@ -23,17 +23,19 @@
import org.codehaus.plexus.interpolation.AbstractValueSource;
class BuildTimestampValueSource extends AbstractValueSource {
-private final MavenBuildTimestamp mavenBuildTimestamp;
+private final Date startTime;
+private final Map properties;
BuildTimestampValueSource(Date startTime, Map properties) {
super(false);
-this.mavenBuildTimestamp = new MavenBuildTimestamp(startTime,
properties);
+this.startTime = startTime;
+this.properties = properties;
Review Comment:
We could, but the only usage is when passed to the `MavenBuildTimestamp`
which does support `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
