[jira] [Commented] (NIFI-4786) Allow Expression Evaluation to Kinesis/Firehose Stream Name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330065#comment-16330065
 ] 

ASF GitHub Bot commented on NIFI-4786:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/2409
  
Reviewing...


> Allow Expression Evaluation to Kinesis/Firehose Stream Name
> ---
>
> Key: NIFI-4786
> URL: https://issues.apache.org/jira/browse/NIFI-4786
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Dorian Bugeja
>Priority: Minor
>  Labels: features, performance, pull-request-available
> Attachments: 
> NIFI_4786___Allow_Expression_Evaluation_to_Kinesis_Firehose_Stream_Name.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currenctly, the Stream name propoerty for both Firehose and Kinesis does not 
> support the expression language. Routing can be performed based on an 
> attribute of the flowfile and having a single component rather than multiple 
> for each one. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2409: NIFI-4786 - Allow Expression Evaluation to Kinesis/Firehos...

[jvwing]

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/2409
  
Reviewing...


---

[GitHub] nifi issue #2408: localization using the JSTL standard fmt tag for multiling...

[ns7381]

Github user ns7381 commented on the issue:

https://github.com/apache/nifi/pull/2408
  
@mcgilman OK. If have any problem, please timely communicate


---

[GitHub] nifi issue #2408: localization using the JSTL standard fmt tag for multiling...

[ns7381]

Github user ns7381 commented on the issue:

https://github.com/apache/nifi/pull/2408
  
@mcgilman OK. If have any problem, please timely communicate


---

[jira] [Commented] (NIFI-4731) BigQuery processors

[Mikhail Sosonkin (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329825#comment-16329825
 ] 

Mikhail Sosonkin commented on NIFI-4731:


Just wanted to give an update. I'm just finishing up the unit tests and will be 
ready to submit a PR soon. The batch load processor has been running in a live 
environment nicely.

> BigQuery processors
> ---
>
> Key: NIFI-4731
> URL: https://issues.apache.org/jira/browse/NIFI-4731
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Mikhail Sosonkin
>Priority: Major
>
> NIFI should have processors for putting data into BigQuery (Streaming and 
> Batch).
> Initial working processors can be found this repository: 
> https://github.com/nologic/nifi/tree/NIFI-4731/nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery
> I'd like to get them into Nifi proper.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4776) Test suite behavioral differences

[Mikhail Sosonkin (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329820#comment-16329820
 ] 

Mikhail Sosonkin commented on NIFI-4776:


I may have jumped the gun on this one :( My apologies! Could have sworn that 
asLong() was used in other examples. I looked at the MergeContent processor, 
but I looked back and saw that it was using .asDataSize() method.

I guess the issue in this ticket now is a better stack trace for the exceptions 
generated during the test run.

> Test suite behavioral differences
> -
>
> Key: NIFI-4776
> URL: https://issues.apache.org/jira/browse/NIFI-4776
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Mikhail Sosonkin
>Priority: Major
>
> I think there might a difference in behavior for how processor attributes are 
> evaluated in the test suite vs real execution. I'm not entirely sure if it is 
> an expected/acceptable behavior. It has to do with the DATA_SIZE_VALIDATOR. 
> Mine was defined as follows:
>  
>     public static final PropertyDescriptor MAX_ROW_SIZE = new 
> PropertyDescriptor
>         .Builder().name(BigQueryAttributes.MAX_ROW_SIZE_ATTR)
>         .displayName("Max row size")
>         .description(BigQueryAttributes.MAX_ROW_SIZE_DESC)
>         .required(true)
>         .defaultValue("1 MB")
>         .addValidator(StandardValidators.DATA_SIZE_VALIDATOR)
>         .build();
>  
> Then I would use it like this in the onTrigger method:
>  
>     final long max_row_size = context.getProperty(MAX_ROW_SIZE).asLong();
>  
> I used it this way based on the examples I've seen in the other processors. 
> In the runtime it seems to be working great and gives me the byte values. 
> However, in testing it would throw an exception because it would try to parse 
> "1 MB" (the default value) as an actual Long. Of course, if I just place a 
> long value (like 1024) it would not pass the validation function. So, I did a 
> more explicit "cast" using the asDataSize method:
>  
>     final long max_row_size = 
> context.getProperty(MAX_ROW_SIZE).asDataSize(DataUnit.B).longValue();
>  
> This solved my problems and makes the code a bit more explicit which is nice. 
> The annoying part is that the StandardProcessorTestRunner does not keep the 
> stacktrace from the exceptions generated in onTrigger of the processor 
> (StandardProcessorTestRunner:199)
>  
>    final Throwable thrown = future.get();
>  
> That is what caused confusion for me. I hadn't realized that the exception 
> was being thrown via my code. So, if anything the test suite needs to do a 
> better job at delivering stack traces for the exceptions to help with 
> debugging. Depending on what you decide, there might be two tasks here.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-114) Consolidate JSON API use to RapidJSON

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329764#comment-16329764
 ] 

ASF GitHub Bot commented on MINIFICPP-114:
--

Github user calebj commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/191
  
@phrocker Honestly, I just reimplemented the JSON handling in RapidJSON as 
well as I could, and fixed the things that broke the build and tests. Help 
would be greatly appreciated.


> Consolidate JSON API use to RapidJSON
> -
>
> Key: MINIFICPP-114
> URL: https://issues.apache.org/jira/browse/MINIFICPP-114
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: John Reynolds
>Assignee: John Reynolds
>Priority: Major
> Fix For: 0.4.0
>
>
> MiNiFi was updated with new dependencies to jsoncpp: 
> SiteToSiteProvenanceReportingTask
> Performance observations indicate significant improvements with RapidJSON vs. 
> jsoncpp.  Convert all use of jsoncpp to RapidJSON where applicable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp issue #191: MINIFICPP-114 Consolidate JSON API use to RapidJ...

[calebj]

Github user calebj commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/191
  
@phrocker Honestly, I just reimplemented the JSON handling in RapidJSON as 
well as I could, and fixed the things that broke the build and tests. Help 
would be greatly appreciated.


---

[jira] [Commented] (MINIFICPP-367) Implement expression language arithmetic operations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329617#comment-16329617
 ] 

ASF GitHub Bot commented on MINIFICPP-367:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/243#discussion_r162199080
  
--- Diff: extensions/expression-language/Expression.cpp ---
@@ -146,6 +149,124 @@ std::string expr_replaceEmpty(const 
std::vector ) {
 
 #endif  // EXPRESSION_LANGUAGE_USE_REGEX
 
+std::string expr_binaryOp(const std::vector ,
+  long double (*ldop)(long double, long double),
+  int (*iop)(int, int),
+  bool long_only = false) {
+  try {
+if (!long_only &&
+args[0].find('.') == args[0].npos &&
+args[1].find('.') == args[1].npos &&
+args[1].find('e') == args[1].npos &&
+args[0].find('e') == args[0].npos &&
+args[0].find('E') == args[0].npos &&
+args[1].find('E') == args[1].npos) {
+  return std::to_string(iop(std::stoi(args[0]), std::stoi(args[1])));
+} else {
+  std::stringstream ss;
+  ss << std::fixed << 
std::setprecision(std::numeric_limits::digits10)
+ << ldop(std::stold(args[0]), std::stold(args[1]));
+  auto result = ss.str();
+  result.erase(result.find_last_not_of('0') + 1, std::string::npos);
+
+  if (result.find('.') == result.length() - 1) {
+result.erase(result.length() - 1, std::string::npos);
+  }
+
+  return result;
+}
+  } catch (const std::exception ) {
+return "";
+  }
+}
+
+std::string expr_plus(const std::vector ) {
+  return expr_binaryOp(args,
+   [](long double a, long double b) { return a + b; },
--- End diff --

does it make sense to define these lambda's statically?


> Implement expression language arithmetic operations
> ---
>
> Key: MINIFICPP-367
> URL: https://issues.apache.org/jira/browse/MINIFICPP-367
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>Priority: Major
>
> Mathematical Operations and Numeric Manipulation
> plus
> minus
> multiply
> divide
> mod
> toRadix
> fromRadix
> random
> math



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #243: MINIFICPP-367 Implement expression langua...

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/243#discussion_r162199080
  
--- Diff: extensions/expression-language/Expression.cpp ---
@@ -146,6 +149,124 @@ std::string expr_replaceEmpty(const 
std::vector ) {
 
 #endif  // EXPRESSION_LANGUAGE_USE_REGEX
 
+std::string expr_binaryOp(const std::vector ,
+  long double (*ldop)(long double, long double),
+  int (*iop)(int, int),
+  bool long_only = false) {
+  try {
+if (!long_only &&
+args[0].find('.') == args[0].npos &&
+args[1].find('.') == args[1].npos &&
+args[1].find('e') == args[1].npos &&
+args[0].find('e') == args[0].npos &&
+args[0].find('E') == args[0].npos &&
+args[1].find('E') == args[1].npos) {
+  return std::to_string(iop(std::stoi(args[0]), std::stoi(args[1])));
+} else {
+  std::stringstream ss;
+  ss << std::fixed << 
std::setprecision(std::numeric_limits::digits10)
+ << ldop(std::stold(args[0]), std::stold(args[1]));
+  auto result = ss.str();
+  result.erase(result.find_last_not_of('0') + 1, std::string::npos);
+
+  if (result.find('.') == result.length() - 1) {
+result.erase(result.length() - 1, std::string::npos);
+  }
+
+  return result;
+}
+  } catch (const std::exception ) {
+return "";
+  }
+}
+
+std::string expr_plus(const std::vector ) {
+  return expr_binaryOp(args,
+   [](long double a, long double b) { return a + b; },
--- End diff --

does it make sense to define these lambda's statically?


---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329602#comment-16329602
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162197312
  
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.cpp ---
@@ -256,7 +256,7 @@ void HttpSiteToSiteClient::closeTransaction(const 
std::string ) {
   }
 
   std::string append_str;
-  logger_->log_info("Site2Site close transaction %s", 
transaction->getUUIDStr().c_str());
--- End diff --

I think this is truly informative for teir 1 support. 


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162197312
  
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.cpp ---
@@ -256,7 +256,7 @@ void HttpSiteToSiteClient::closeTransaction(const 
std::string ) {
   }
 
   std::string append_str;
-  logger_->log_info("Site2Site close transaction %s", 
transaction->getUUIDStr().c_str());
--- End diff --

I think this is truly informative for teir 1 support. 


---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329601#comment-16329601
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162197151
  
--- Diff: 
libminifi/include/core/controller/StandardControllerServiceProvider.h ---
@@ -111,10 +111,10 @@ class StandardControllerServiceProvider : public 
ControllerServiceProvider, publ
 for (auto service : controller_map_->getAllControllerServices()) {
 
   if (service->canEnable()) {
-logger_->log_info("Enabling %s", service->getName());
--- End diff --

Ditto on the comments about enabling/starting something be critical for 
tier 1 to support. 


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162197151
  
--- Diff: 
libminifi/include/core/controller/StandardControllerServiceProvider.h ---
@@ -111,10 +111,10 @@ class StandardControllerServiceProvider : public 
ControllerServiceProvider, publ
 for (auto service : controller_map_->getAllControllerServices()) {
 
   if (service->canEnable()) {
-logger_->log_info("Enabling %s", service->getName());
--- End diff --

Ditto on the comments about enabling/starting something be critical for 
tier 1 to support. 


---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329598#comment-16329598
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196896
  
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -193,17 +193,17 @@ void RemoteProcessorGroupPort::onTrigger(const 
std::shared_ptr protocol_ = nullptr;
   try {
-logger_->log_info("get protocol in on trigger");
+logger_->log_trace("get protocol in on trigger");
 protocol_ = getNextProtocol();
 
 if (!protocol_) {
-  logger_->log_info("no protocol, yielding");
--- End diff --

This one should likely be debug otherwise we'd need to get to trace to 
support this. The one above is definitely a trace. 


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329599#comment-16329599
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162197063
  
--- Diff: libminifi/src/FlowControlProtocol.cpp ---
@@ -216,7 +216,7 @@ void FlowControlProtocol::stop() {
   if (!running_)
 return;
   running_ = false;
-  logger_->log_info("FlowControl Protocol Stop");
+  logger_->log_trace("FlowControl Protocol Stop");
--- End diff --

I believe these messages provide critical information to tier1 support. 


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162197063
  
--- Diff: libminifi/src/FlowControlProtocol.cpp ---
@@ -216,7 +216,7 @@ void FlowControlProtocol::stop() {
   if (!running_)
 return;
   running_ = false;
-  logger_->log_info("FlowControl Protocol Stop");
+  logger_->log_trace("FlowControl Protocol Stop");
--- End diff --

I believe these messages provide critical information to tier1 support. 


---

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196896
  
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -193,17 +193,17 @@ void RemoteProcessorGroupPort::onTrigger(const 
std::shared_ptr protocol_ = nullptr;
   try {
-logger_->log_info("get protocol in on trigger");
+logger_->log_trace("get protocol in on trigger");
 protocol_ = getNextProtocol();
 
 if (!protocol_) {
-  logger_->log_info("no protocol, yielding");
--- End diff --

This one should likely be debug otherwise we'd need to get to trace to 
support this. The one above is definitely a trace. 


---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329594#comment-16329594
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196636
  
--- Diff: libminifi/src/SchedulingAgent.cpp ---
@@ -40,7 +40,7 @@ bool 
SchedulingAgent::hasWorkToDo(std::shared_ptr processor) {
 }
 
 std::future 
SchedulingAgent::enableControllerService(std::shared_ptr
 ) {
-  logger_->log_info("Enabling CSN in SchedulingAgent %s", 
serviceNode->getName());
--- End diff --

As per my comment below I think these are candidates for INFO based on the 
belief that support any type of teir 1 support might need this information. 


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2411: NIFI-4789 Extract grok multi pattern support

[charlesporter]

GitHub user charlesporter opened a pull request:

https://github.com/apache/nifi/pull/2411

NIFI-4789 Extract grok multi pattern support

ExtractGrok Processor supports multiple expressions
-separated by comma or by specified delimiter
-option to return on first match or to run all expressions in list
ralated enhancements:
-multiple pattern files support
-selectable result attribute prefix (default unchanged from  '.grok')

implemented by creating multiple kraken-Grok  objects. It is possible that 
performance could be improved by using elasticsearch implementation: 

https://github.com/elastic/elasticsearch/tree/d6d0c13bd63f28347ebdb0f9364e44921c248b8b/modules/ingest-common/src/main/java/org/elasticsearch/ingest/commoncommon/src/main/java/org/elasticsearch/ingest/common/Grok.java
 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/charlesporter/nifi ExtractGrokMultiPattern

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2411.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2411


commit 66b072a3d7348cb8dc1d2c6ab52634116b1bf6d7
Author: charlesporter 
Date:   2018-01-17T04:14:45Z

ExtractGrok Supports multiple expressions
-separated by comma or specified delimiter
-option to return on first match or to run all expressions in list
other enhancements
-multiple pattern files
-selectable result attribute prefix

commit dd8bc224c5193c8b6b47fb8babf6cb6c8323eef3
Author: charlesporter 
Date:   2018-01-17T04:14:45Z

ExtractGrok Supports multiple expressions
-separated by comma or specified delimiter
-option to return on first match or to run all expressions in list
other enhancements
-multiple pattern files
-selectable result attribute prefix

commit f289df5613046ad8595ce8b980e7063c59ee8cdb
Author: charlesporter 
Date:   2018-01-17T22:04:29Z

remerge




---

[jira] [Commented] (NIFI-4789) Enhance ExtractGrok processor to handle multiple grok expressions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329596#comment-16329596
 ] 

ASF GitHub Bot commented on NIFI-4789:
--

GitHub user charlesporter opened a pull request:

https://github.com/apache/nifi/pull/2411

NIFI-4789 Extract grok multi pattern support

ExtractGrok Processor supports multiple expressions
-separated by comma or by specified delimiter
-option to return on first match or to run all expressions in list
ralated enhancements:
-multiple pattern files support
-selectable result attribute prefix (default unchanged from  '.grok')

implemented by creating multiple kraken-Grok  objects. It is possible that 
performance could be improved by using elasticsearch implementation: 

https://github.com/elastic/elasticsearch/tree/d6d0c13bd63f28347ebdb0f9364e44921c248b8b/modules/ingest-common/src/main/java/org/elasticsearch/ingest/commoncommon/src/main/java/org/elasticsearch/ingest/common/Grok.java
 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/charlesporter/nifi ExtractGrokMultiPattern

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2411.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2411


commit 66b072a3d7348cb8dc1d2c6ab52634116b1bf6d7
Author: charlesporter 
Date:   2018-01-17T04:14:45Z

ExtractGrok Supports multiple expressions
-separated by comma or specified delimiter
-option to return on first match or to run all expressions in list
other enhancements
-multiple pattern files
-selectable result attribute prefix

commit dd8bc224c5193c8b6b47fb8babf6cb6c8323eef3
Author: charlesporter 
Date:   2018-01-17T04:14:45Z

ExtractGrok Supports multiple expressions
-separated by comma or specified delimiter
-option to return on first match or to run all expressions in list
other enhancements
-multiple pattern files
-selectable result attribute prefix

commit f289df5613046ad8595ce8b980e7063c59ee8cdb
Author: charlesporter 
Date:   2018-01-17T22:04:29Z

remerge




> Enhance ExtractGrok processor to handle multiple grok expressions
> -
>
> Key: NIFI-4789
> URL: https://issues.apache.org/jira/browse/NIFI-4789
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework
>Affects Versions: 1.2.0, 1.5.0
> Environment: all
>Reporter: Charles Porter
>Priority: Minor
>  Labels: features
>
> Many flows require running several grok expressions against an input to 
> correctly tag and extract data. using many separate grok processors to 
> accomplish this is unwieldy and hard to maintain.  Supporting multiple grok 
> expressions delimited by comma or user selected delimiter greatly simplifies 
> this.  
> Feature is coded and tested, ready for pull request, if feature is approved



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196636
  
--- Diff: libminifi/src/SchedulingAgent.cpp ---
@@ -40,7 +40,7 @@ bool 
SchedulingAgent::hasWorkToDo(std::shared_ptr processor) {
 }
 
 std::future 
SchedulingAgent::enableControllerService(std::shared_ptr
 ) {
-  logger_->log_info("Enabling CSN in SchedulingAgent %s", 
serviceNode->getName());
--- End diff --

As per my comment below I think these are candidates for INFO based on the 
belief that support any type of teir 1 support might need this information. 


---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329590#comment-16329590
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196401
  
--- Diff: libminifi/src/capi/Plan.cpp ---
@@ -115,7 +115,7 @@ bool linkToPrevious) {
 
 bool ExecutionPlan::setProperty(const std::shared_ptr 
proc, const std::string , const std::string ) {
   uint32_t i = 0;
-  logger_->log_info("Attempting to set property %s %s for %s", prop, 
value, proc->getName());
+  logger_->log_debug("Attempting to set property %s %s for %s", prop, 
value, proc->getName());
--- End diff --

oh man this is definitely me! I copied and pasted a lot of these. Thanks 
for catching this!


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329589#comment-16329589
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196333
  
--- Diff: libminifi/src/controllers/SSLContextService.cpp ---
@@ -134,7 +134,7 @@ void SSLContextService::onEnable() {
 certificate = test_cert;
 logger_->log_debug("%s now good", certificate);
   } else {
-logger_->log_debug("%s still not good", test_cert);
+logger_->log_warn("%s still not good", test_cert);
--- End diff --

good catch!


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196431
  
--- Diff: libminifi/src/ThreadedSchedulingAgent.cpp ---
@@ -104,10 +104,10 @@ void ThreadedSchedulingAgent::stop() {
 
 void ThreadedSchedulingAgent::unschedule(std::shared_ptr 
processor) {
   std::lock_guard lock(mutex_);
-  logger_->log_info("Shutting down threads for processor %s/%s", 
processor->getName().c_str(), processor->getUUIDStr().c_str());
+  logger_->log_debug("Shutting down threads for processor %s/%s", 
processor->getName().c_str(), processor->getUUIDStr().c_str());
 
   if (processor->getScheduledState() != core::RUNNING) {
-logger_->log_info("Cannot unschedule threads for processor %s because 
it is not running", processor->getName().c_str());
--- End diff --

Much prefer this!


---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329592#comment-16329592
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196431
  
--- Diff: libminifi/src/ThreadedSchedulingAgent.cpp ---
@@ -104,10 +104,10 @@ void ThreadedSchedulingAgent::stop() {
 
 void ThreadedSchedulingAgent::unschedule(std::shared_ptr 
processor) {
   std::lock_guard lock(mutex_);
-  logger_->log_info("Shutting down threads for processor %s/%s", 
processor->getName().c_str(), processor->getUUIDStr().c_str());
+  logger_->log_debug("Shutting down threads for processor %s/%s", 
processor->getName().c_str(), processor->getUUIDStr().c_str());
 
   if (processor->getScheduledState() != core::RUNNING) {
-logger_->log_info("Cannot unschedule threads for processor %s because 
it is not running", processor->getName().c_str());
--- End diff --

Much prefer this!


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196401
  
--- Diff: libminifi/src/capi/Plan.cpp ---
@@ -115,7 +115,7 @@ bool linkToPrevious) {
 
 bool ExecutionPlan::setProperty(const std::shared_ptr 
proc, const std::string , const std::string ) {
   uint32_t i = 0;
-  logger_->log_info("Attempting to set property %s %s for %s", prop, 
value, proc->getName());
+  logger_->log_debug("Attempting to set property %s %s for %s", prop, 
value, proc->getName());
--- End diff --

oh man this is definitely me! I copied and pasted a lot of these. Thanks 
for catching this!


---

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196333
  
--- Diff: libminifi/src/controllers/SSLContextService.cpp ---
@@ -134,7 +134,7 @@ void SSLContextService::onEnable() {
 certificate = test_cert;
 logger_->log_debug("%s now good", certificate);
   } else {
-logger_->log_debug("%s still not good", test_cert);
+logger_->log_warn("%s still not good", test_cert);
--- End diff --

good catch!


---

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196014
  
--- Diff: libminifi/src/core/ProcessSession.cpp ---
@@ -568,16 +568,16 @@ void ProcessSession::import(std::string source, 
std::vectorlog_info("Exporting content of %s to %s", 
flow->getUUIDStr().c_str(), destination.c_str());
+  logger_->log_debug("Exporting content of %s to %s", 
flow->getUUIDStr().c_str(), destination.c_str());
 
   ProcessSessionReadCallback cb(tmpFile, destination, logger_);
   read(flow, );
 
-  logger_->log_info("Committing %s", destination.c_str());
+  logger_->log_debug("Committing %s", destination.c_str());
   bool commit_ok = cb.commit();
 
   if (commit_ok) {
-logger_->log_info("Commit OK.");
+logger_->log_debug("Commit OK.");
--- End diff --

I'm on the fence about this one. I usually use the mantra as INFO provides 
informational statements for support staff, debug and trace used by developers 
for varying levels. In this case I could see a support staff asking, "Commit 
OK."  Is there an analog to this statement to provide this information? A 
totally quiet client at info makes it unusable and more importantly 
unsupportable by multiple levels of support. 


---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329586#comment-16329586
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196014
  
--- Diff: libminifi/src/core/ProcessSession.cpp ---
@@ -568,16 +568,16 @@ void ProcessSession::import(std::string source, 
std::vectorlog_info("Exporting content of %s to %s", 
flow->getUUIDStr().c_str(), destination.c_str());
+  logger_->log_debug("Exporting content of %s to %s", 
flow->getUUIDStr().c_str(), destination.c_str());
 
   ProcessSessionReadCallback cb(tmpFile, destination, logger_);
   read(flow, );
 
-  logger_->log_info("Committing %s", destination.c_str());
+  logger_->log_debug("Committing %s", destination.c_str());
   bool commit_ok = cb.commit();
 
   if (commit_ok) {
-logger_->log_info("Commit OK.");
+logger_->log_debug("Commit OK.");
--- End diff --

I'm on the fence about this one. I usually use the mantra as INFO provides 
informational statements for support staff, debug and trace used by developers 
for varying levels. In this case I could see a support staff asking, "Commit 
OK."  Is there an analog to this statement to provide this information? A 
totally quiet client at info makes it unusable and more importantly 
unsupportable by multiple levels of support. 


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329582#comment-16329582
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162195460
  
--- Diff: libminifi/src/core/ProcessSessionReadCallback.cpp ---
@@ -64,16 +64,16 @@ int64_t 
ProcessSessionReadCallback::process(std::shared_ptr stre
 bool ProcessSessionReadCallback::commit() {
   bool success = false;
 
-  logger_->log_info("committing export operation to %s", 
_destFile.c_str());
--- End diff --

ditto on the c_str(). It adds overhead and is vestigial. 


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162195460
  
--- Diff: libminifi/src/core/ProcessSessionReadCallback.cpp ---
@@ -64,16 +64,16 @@ int64_t 
ProcessSessionReadCallback::process(std::shared_ptr stre
 bool ProcessSessionReadCallback::commit() {
   bool success = false;
 
-  logger_->log_info("committing export operation to %s", 
_destFile.c_str());
--- End diff --

ditto on the c_str(). It adds overhead and is vestigial. 


---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329579#comment-16329579
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162195004
  
--- Diff: libminifi/src/sitetosite/RawSocketProtocol.cpp ---
@@ -112,11 +112,11 @@ bool 
RawSiteToSiteClient::initiateResourceNegotiation() {
 return false;
   }
 
-  logger_->log_info("Negotiate protocol version with destination port %s 
current version %d", port_id_str_, _currentVersion);
+  logger_->log_debug("Negotiate protocol version with destination port %s 
current version %d", port_id_str_, _currentVersion);
 
   int ret = peer_->writeUTF(getResourceName());
 
-  logger_->log_info("result of writing resource name is %i", ret);
+  logger_->log_debug("result of writing resource name is %i", ret);
--- End diff --

^ this honestly seems like it would be a trace level to help trace the 
level of execution through the stream writes. 


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162195004
  
--- Diff: libminifi/src/sitetosite/RawSocketProtocol.cpp ---
@@ -112,11 +112,11 @@ bool 
RawSiteToSiteClient::initiateResourceNegotiation() {
 return false;
   }
 
-  logger_->log_info("Negotiate protocol version with destination port %s 
current version %d", port_id_str_, _currentVersion);
+  logger_->log_debug("Negotiate protocol version with destination port %s 
current version %d", port_id_str_, _currentVersion);
 
   int ret = peer_->writeUTF(getResourceName());
 
-  logger_->log_info("result of writing resource name is %i", ret);
+  logger_->log_debug("result of writing resource name is %i", ret);
--- End diff --

^ this honestly seems like it would be a trace level to help trace the 
level of execution through the stream writes. 


---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329574#comment-16329574
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162194578
  
--- Diff: libminifi/src/sitetosite/RawSocketProtocol.cpp ---
@@ -519,7 +519,7 @@ bool RawSiteToSiteClient::bootstrap() {
   tearDown();
 
   if (establish() && handShake() && negotiateCodec()) {
-logger_->log_info("Site2Site Ready For data transaction");
+logger_->log_trace("Site2Site Ready For data transaction");
--- End diff --

If you were to set the log level to debug one might expect there to be 
something here, as you would need to select trace and inevitably trace the 
entire flow of execution vice getting debug information. 


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162194578
  
--- Diff: libminifi/src/sitetosite/RawSocketProtocol.cpp ---
@@ -519,7 +519,7 @@ bool RawSiteToSiteClient::bootstrap() {
   tearDown();
 
   if (establish() && handShake() && negotiateCodec()) {
-logger_->log_info("Site2Site Ready For data transaction");
+logger_->log_trace("Site2Site Ready For data transaction");
--- End diff --

If you were to set the log level to debug one might expect there to be 
something here, as you would need to select trace and inevitably trace the 
entire flow of execution vice getting debug information. 


---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329565#comment-16329565
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162194212
  
--- Diff: main/MiNiFiMain.cpp ---
@@ -110,7 +110,7 @@ int main(int argc, char **argv) {
   }
 
   if (signal(SIGINT, sigHandler) == SIG_ERR || signal(SIGTERM, sigHandler) 
== SIG_ERR || signal(SIGPIPE, SIG_IGN) == SIG_ERR) {
-logger->log_error("Can not install signal handler");
+logger->log_error("Cannot install signal handler");
--- End diff --

Seems unnecessary, both are acceptable spellings. 


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162194212
  
--- Diff: main/MiNiFiMain.cpp ---
@@ -110,7 +110,7 @@ int main(int argc, char **argv) {
   }
 
   if (signal(SIGINT, sigHandler) == SIG_ERR || signal(SIGTERM, sigHandler) 
== SIG_ERR || signal(SIGPIPE, SIG_IGN) == SIG_ERR) {
-logger->log_error("Can not install signal handler");
+logger->log_error("Cannot install signal handler");
--- End diff --

Seems unnecessary, both are acceptable spellings. 


---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329564#comment-16329564
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162194109
  
--- Diff: libminifi/src/sitetosite/SiteToSiteClient.cpp ---
@@ -467,12 +467,12 @@ int16_t SiteToSiteClient::send(std::string 
transactionID, DataPacket *packet, co
   }
 
   if (transaction->getState() != TRANSACTION_STARTED && 
transaction->getState() != DATA_EXCHANGED) {
-logger_->log_debug("Site2Site transaction %s is not at started or 
exchanged state", transactionID.c_str());
--- End diff --

we should also make it a point to change these from transactionID.c_str() 
to tranactionID


> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162194109
  
--- Diff: libminifi/src/sitetosite/SiteToSiteClient.cpp ---
@@ -467,12 +467,12 @@ int16_t SiteToSiteClient::send(std::string 
transactionID, DataPacket *packet, co
   }
 
   if (transaction->getState() != TRANSACTION_STARTED && 
transaction->getState() != DATA_EXCHANGED) {
-logger_->log_debug("Site2Site transaction %s is not at started or 
exchanged state", transactionID.c_str());
--- End diff --

we should also make it a point to change these from transactionID.c_str() 
to tranactionID


---

[GitHub] nifi-minifi-cpp pull request #244: MINIFICPP-365 Adjusting log levels.

[apiri]

GitHub user apiri opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244

MINIFICPP-365 Adjusting log levels.

current status of working to remove extraneous log statements.

for some of the typical flows I use for testing this amounts to almost no 
information being provided.  going to look through the various components a bit 
more to see if statements should be added


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apiri/nifi-minifi-cpp minificpp-365

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #244


commit f0b7562961017894f77175734a08a4d206786b4a
Author: Aldrin Piri 
Date:   2018-01-17T20:11:45Z

MINIFICPP-365 Adjusting log levels.




---

[jira] [Commented] (MINIFICPP-365) Refine log levels and messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329553#comment-16329553
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
--

GitHub user apiri opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/244

MINIFICPP-365 Adjusting log levels.

current status of working to remove extraneous log statements.

for some of the typical flows I use for testing this amounts to almost no 
information being provided.  going to look through the various components a bit 
more to see if statements should be added


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apiri/nifi-minifi-cpp minificpp-365

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #244


commit f0b7562961017894f77175734a08a4d206786b4a
Author: Aldrin Piri 
Date:   2018-01-17T20:11:45Z

MINIFICPP-365 Adjusting log levels.




> Refine log levels and messages
> --
>
> Key: MINIFICPP-365
> URL: https://issues.apache.org/jira/browse/MINIFICPP-365
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Major
> Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-374) Create thread management strategy through a controller service.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329530#comment-16329530
 ] 

ASF GitHub Bot commented on MINIFICPP-374:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/242#discussion_r162190115
  
--- Diff: README.md ---
@@ -609,6 +609,21 @@ Additionally, a unique hexadecimal 
uid.minifi.device.segment should be assigned
class: ControllerServiceClass
Properties:
 
+### Linux Power Manager Controller Service
+  The linux power manager controller service can be configured to monitor 
the battery level and status ( discharging or charging ) via the following 
configuration.
+  Simply provide the capacity path and status path along with your 
threshold for the trigger and low battery alarm and you can monitor your 
battery and throttle
+  the threadpools within MiNiFi C++. Note that the name is identified must 
be ThreadPoolManager.
+
+   Controller Services:
+- name: ThreadPoolManager
+  id: 2438e3c8-015a-1000-79ca-83af40ec1888
+  class: LinuxPowerManagerService
+  Properties:
+  Battery Capacity Path: /path/to/battery/capacity
+  Battery Status Path: /path/to/battery/status
--- End diff --

Controller services provide a shared service. In this case the evaluation 
of information to make a determination of whether or not we should reduce 
threads. It has been discussed that we can move gathering of this information 
into a Processor, but then we have to transfer it somewhere. In that flow we 
need to build logic and feed that to elements such as the thread executor, 
power management, etc. We would need to create a pipeline of logic that flows 
beyond the processors into structural elements of MiNiFi C++. This is better 
suited for a controller service. Controller services, by way of the 
ControllerServiceProvider, are already designed to be part of the thread pools 
( scheduling agents ) amongst other structural components. 

This allows a single shared state to make an informed decision. While I can 
see the case where we feed the controller service by way of the processor 
output, we'd have to do so at the cost of incurring FlowFile management ( we 
could have a single processor, but what's the point of that? ). 


> Create thread management strategy through a controller service. 
> 
>
> Key: MINIFICPP-374
> URL: https://issues.apache.org/jira/browse/MINIFICPP-374
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> I've created a series of thread management strategy controller services. The 
> first was a linux battery monitor that I'm contributing. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #242: MINIFICPP-374: Commit Linux power managem...

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/242#discussion_r162190115
  
--- Diff: README.md ---
@@ -609,6 +609,21 @@ Additionally, a unique hexadecimal 
uid.minifi.device.segment should be assigned
class: ControllerServiceClass
Properties:
 
+### Linux Power Manager Controller Service
+  The linux power manager controller service can be configured to monitor 
the battery level and status ( discharging or charging ) via the following 
configuration.
+  Simply provide the capacity path and status path along with your 
threshold for the trigger and low battery alarm and you can monitor your 
battery and throttle
+  the threadpools within MiNiFi C++. Note that the name is identified must 
be ThreadPoolManager.
+
+   Controller Services:
+- name: ThreadPoolManager
+  id: 2438e3c8-015a-1000-79ca-83af40ec1888
+  class: LinuxPowerManagerService
+  Properties:
+  Battery Capacity Path: /path/to/battery/capacity
+  Battery Status Path: /path/to/battery/status
--- End diff --

Controller services provide a shared service. In this case the evaluation 
of information to make a determination of whether or not we should reduce 
threads. It has been discussed that we can move gathering of this information 
into a Processor, but then we have to transfer it somewhere. In that flow we 
need to build logic and feed that to elements such as the thread executor, 
power management, etc. We would need to create a pipeline of logic that flows 
beyond the processors into structural elements of MiNiFi C++. This is better 
suited for a controller service. Controller services, by way of the 
ControllerServiceProvider, are already designed to be part of the thread pools 
( scheduling agents ) amongst other structural components. 

This allows a single shared state to make an informed decision. While I can 
see the case where we feed the controller service by way of the processor 
output, we'd have to do so at the cost of incurring FlowFile management ( we 
could have a single processor, but what's the point of that? ). 


---

[jira] [Commented] (NIFIREG-93) Create a quick-start guide

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFIREG-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329523#comment-16329523
 ] 

ASF GitHub Bot commented on NIFIREG-93:
---

GitHub user andrewmlim opened a pull request:

https://github.com/apache/nifi-registry/pull/87

NIFIREG-93 Added Getting Started guide and fixed typo in Admin Guide



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrewmlim/nifi-registry NIFIREG-93

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #87


commit 854f9f7a9022c7ec8ad16559dd71048455906f78
Author: Andrew Lim 
Date:   2018-01-17T21:45:21Z

NIFIREG-93 Added Getting Started guide and fixed typo in Admin Guide




> Create a quick-start guide
> --
>
> Key: NIFIREG-93
> URL: https://issues.apache.org/jira/browse/NIFIREG-93
> Project: NiFi Registry
>  Issue Type: Improvement
>Affects Versions: 0.1.0
>Reporter: Bryan Bende
>Assignee: Andrew Lim
>Priority: Minor
>
> During voting of the 0.1.0 RC, several people expressed that a quick start 
> guide for the registry would be helpful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-registry pull request #87: NIFIREG-93 Added Getting Started guide and f...

[andrewmlim]

GitHub user andrewmlim opened a pull request:

https://github.com/apache/nifi-registry/pull/87

NIFIREG-93 Added Getting Started guide and fixed typo in Admin Guide



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrewmlim/nifi-registry NIFIREG-93

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #87


commit 854f9f7a9022c7ec8ad16559dd71048455906f78
Author: Andrew Lim 
Date:   2018-01-17T21:45:21Z

NIFIREG-93 Added Getting Started guide and fixed typo in Admin Guide




---

[jira] [Commented] (NIFI-4688) PutParquet should have RemoteOwner and RemoteGroup LE(Language Expression) turn to TRUE

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329462#comment-16329462
 ] 

ASF GitHub Bot commented on NIFI-4688:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2336
  
Hey @panelladavide - I think the last version of your PR is missing some 
parts of your code. Can you take a look? Could you rebase it against master and 
squash commits into a single one?


> PutParquet should have RemoteOwner and RemoteGroup LE(Language Expression) 
> turn to TRUE
> ---
>
> Key: NIFI-4688
> URL: https://issues.apache.org/jira/browse/NIFI-4688
> Project: Apache NiFi
>  Issue Type: Wish
>Affects Versions: 1.4.0
>Reporter: dav
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2336: NIFI-4688 - PutParquet should have RemoteOwner and RemoteG...

[pvillard31]

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2336
  
Hey @panelladavide - I think the last version of your PR is missing some 
parts of your code. Can you take a look? Could you rebase it against master and 
squash commits into a single one?


---

[jira] [Updated] (NIFI-4618) Add documentation for context path whitelisting

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-4618:
--
Status: Patch Available  (was: In Progress)

https://github.com/apache/nifi/pull/2410

> Add documentation for context path whitelisting
> ---
>
> Key: NIFI-4618
> URL: https://issues.apache.org/jira/browse/NIFI-4618
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation  Website
>Affects Versions: 1.5.0
>Reporter: Andy LoPresto
>Assignee: Matt Gilman
>Priority: Minor
>  Labels: documentation, proxy
>
> In NIFI-4501 we introduced a new {{nifi.properties}} property 
> {{nifi.web.proxy.context.path}} to allow whitelisting context paths when 
> using a proxy. The use of this property and the expected formatting should be 
> documented in the Admin Guide. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (NIFI-4766) Add documentation for new proxy host values in nifi.properties

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-4766:
--
Status: Patch Available  (was: In Progress)

> Add documentation for new proxy host values in nifi.properties
> --
>
> Key: NIFI-4766
> URL: https://issues.apache.org/jira/browse/NIFI-4766
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Documentation  Website
>Affects Versions: 1.5.0
>Reporter: Andy LoPresto
>Assignee: Matt Gilman
>Priority: Major
>  Labels: config, documentation, host, proxy
>
> A new property will be introduced in NIFI-4761 which allows whitelisting 
> custom host(s) for the host header value. The cause of and use of this 
> property should be well documented in the Admin Guide. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4766) Add documentation for new proxy host values in nifi.properties

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329458#comment-16329458
 ] 

ASF GitHub Bot commented on NIFI-4766:
--

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/2410

Updating proxy documentation

NIFI-4766:
- Documenting nifi.web.proxy.host property.
- Updating proxy confiugration.
NIFI-4618:
- Documenting nifi.web.proxy.context.path property.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-4618

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2410.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2410


commit 52307e6a7d09d8870fb4d6132f900966e6983bbc
Author: Matt Gilman 
Date:   2018-01-17T20:55:40Z

NIFI-4766:
- Documenting nifi.web.proxy.host property.
- Updating proxy confiugration.
NIFI-4618:
- Documenting nifi.web.proxy.context.path property.




> Add documentation for new proxy host values in nifi.properties
> --
>
> Key: NIFI-4766
> URL: https://issues.apache.org/jira/browse/NIFI-4766
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Documentation  Website
>Affects Versions: 1.5.0
>Reporter: Andy LoPresto
>Assignee: Matt Gilman
>Priority: Major
>  Labels: config, documentation, host, proxy
>
> A new property will be introduced in NIFI-4761 which allows whitelisting 
> custom host(s) for the host header value. The cause of and use of this 
> property should be well documented in the Admin Guide. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2410: Updating proxy documentation

[mcgilman]

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/2410

Updating proxy documentation

NIFI-4766:
- Documenting nifi.web.proxy.host property.
- Updating proxy confiugration.
NIFI-4618:
- Documenting nifi.web.proxy.context.path property.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-4618

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2410.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2410


commit 52307e6a7d09d8870fb4d6132f900966e6983bbc
Author: Matt Gilman 
Date:   2018-01-17T20:55:40Z

NIFI-4766:
- Documenting nifi.web.proxy.host property.
- Updating proxy confiugration.
NIFI-4618:
- Documenting nifi.web.proxy.context.path property.




---

[jira] [Resolved] (NIFI-4759) PutMongo does not handle updateKey field correctly

[Pierre Villard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard resolved NIFI-4759.
--
   Resolution: Fixed
Fix Version/s: 1.6.0

> PutMongo does not handle updateKey field correctly
> --
>
> Key: NIFI-4759
> URL: https://issues.apache.org/jira/browse/NIFI-4759
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Major
> Fix For: 1.6.0
>
>
> Two issues:
> * The updateKey field is ignored in favor of _id in the update code block of 
> PutMongo.
> * _id fields are always treated as strings, even if they're valid ObjectIds 
> represented as a string. PutMongo should be able to handle these as ObjectIds.
> Regarding the first point, this works:
> {code:java}
> {
> "_id": "1234",
> "$set": { "msg": "Hello, world" }
> }
> {code}
> This does not:
> {code:java}
> {
> "uniqueKey": "12345",
> "$set": { "msg": "Hello, World" }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MINIFICPP-374) Create thread management strategy through a controller service.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329447#comment-16329447
 ] 

ASF GitHub Bot commented on MINIFICPP-374:
--

Github user minifirocks commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/242#discussion_r162174433
  
--- Diff: README.md ---
@@ -609,6 +609,21 @@ Additionally, a unique hexadecimal 
uid.minifi.device.segment should be assigned
class: ControllerServiceClass
Properties:
 
+### Linux Power Manager Controller Service
+  The linux power manager controller service can be configured to monitor 
the battery level and status ( discharging or charging ) via the following 
configuration.
+  Simply provide the capacity path and status path along with your 
threshold for the trigger and low battery alarm and you can monitor your 
battery and throttle
+  the threadpools within MiNiFi C++. Note that the name is identified must 
be ThreadPoolManager.
+
+   Controller Services:
+- name: ThreadPoolManager
+  id: 2438e3c8-015a-1000-79ca-83af40ec1888
+  class: LinuxPowerManagerService
+  Properties:
+  Battery Capacity Path: /path/to/battery/capacity
+  Battery Status Path: /path/to/battery/status
--- End diff --

overall looks good. One question I have is why we implement using a 
controller service instead of a processor. It looks like more like processor to 
monitor the standard pro filesystem and perform some user config actions


> Create thread management strategy through a controller service. 
> 
>
> Key: MINIFICPP-374
> URL: https://issues.apache.org/jira/browse/MINIFICPP-374
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> I've created a series of thread management strategy controller services. The 
> first was a linux battery monitor that I'm contributing. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (NIFI-4759) PutMongo does not handle updateKey field correctly

[Pierre Villard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-4759:
-
Component/s: Extensions

> PutMongo does not handle updateKey field correctly
> --
>
> Key: NIFI-4759
> URL: https://issues.apache.org/jira/browse/NIFI-4759
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Major
> Fix For: 1.6.0
>
>
> Two issues:
> * The updateKey field is ignored in favor of _id in the update code block of 
> PutMongo.
> * _id fields are always treated as strings, even if they're valid ObjectIds 
> represented as a string. PutMongo should be able to handle these as ObjectIds.
> Regarding the first point, this works:
> {code:java}
> {
> "_id": "1234",
> "$set": { "msg": "Hello, world" }
> }
> {code}
> This does not:
> {code:java}
> {
> "uniqueKey": "12345",
> "$set": { "msg": "Hello, World" }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4759) PutMongo does not handle updateKey field correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329446#comment-16329446
 ] 

ASF GitHub Bot commented on NIFI-4759:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2401


> PutMongo does not handle updateKey field correctly
> --
>
> Key: NIFI-4759
> URL: https://issues.apache.org/jira/browse/NIFI-4759
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Major
> Fix For: 1.6.0
>
>
> Two issues:
> * The updateKey field is ignored in favor of _id in the update code block of 
> PutMongo.
> * _id fields are always treated as strings, even if they're valid ObjectIds 
> represented as a string. PutMongo should be able to handle these as ObjectIds.
> Regarding the first point, this works:
> {code:java}
> {
> "_id": "1234",
> "$set": { "msg": "Hello, world" }
> }
> {code}
> This does not:
> {code:java}
> {
> "uniqueKey": "12345",
> "$set": { "msg": "Hello, World" }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #242: MINIFICPP-374: Commit Linux power managem...

[minifirocks]

Github user minifirocks commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/242#discussion_r162174433
  
--- Diff: README.md ---
@@ -609,6 +609,21 @@ Additionally, a unique hexadecimal 
uid.minifi.device.segment should be assigned
class: ControllerServiceClass
Properties:
 
+### Linux Power Manager Controller Service
+  The linux power manager controller service can be configured to monitor 
the battery level and status ( discharging or charging ) via the following 
configuration.
+  Simply provide the capacity path and status path along with your 
threshold for the trigger and low battery alarm and you can monitor your 
battery and throttle
+  the threadpools within MiNiFi C++. Note that the name is identified must 
be ThreadPoolManager.
+
+   Controller Services:
+- name: ThreadPoolManager
+  id: 2438e3c8-015a-1000-79ca-83af40ec1888
+  class: LinuxPowerManagerService
+  Properties:
+  Battery Capacity Path: /path/to/battery/capacity
+  Battery Status Path: /path/to/battery/status
--- End diff --

overall looks good. One question I have is why we implement using a 
controller service instead of a processor. It looks like more like processor to 
monitor the standard pro filesystem and perform some user config actions


---

[GitHub] nifi pull request #2401: NIFI-4759 Fixed a bug that left a hard-coded refere...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2401


---

[jira] [Commented] (NIFI-4759) PutMongo does not handle updateKey field correctly

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329444#comment-16329444
 ] 

ASF subversion and git services commented on NIFI-4759:
---

Commit ca54186b608682d028719ae836bd8d8f83fd24d7 in nifi's branch 
refs/heads/master from [~mike.thomsen]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ca54186 ]

NIFI-4759 - Fixed a bug that left a hard-coded reference to _id in as the 
update key for MongoDB upserts.

Signed-off-by: Pierre Villard 

This closes #2401.


> PutMongo does not handle updateKey field correctly
> --
>
> Key: NIFI-4759
> URL: https://issues.apache.org/jira/browse/NIFI-4759
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Major
>
> Two issues:
> * The updateKey field is ignored in favor of _id in the update code block of 
> PutMongo.
> * _id fields are always treated as strings, even if they're valid ObjectIds 
> represented as a string. PutMongo should be able to handle these as ObjectIds.
> Regarding the first point, this works:
> {code:java}
> {
> "_id": "1234",
> "$set": { "msg": "Hello, world" }
> }
> {code}
> This does not:
> {code:java}
> {
> "uniqueKey": "12345",
> "$set": { "msg": "Hello, World" }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4759) PutMongo does not handle updateKey field correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329443#comment-16329443
 ] 

ASF GitHub Bot commented on NIFI-4759:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2401
  
+1, LGTM, thanks for the PR @MikeThomsen and thanks for the review @mgaido91


> PutMongo does not handle updateKey field correctly
> --
>
> Key: NIFI-4759
> URL: https://issues.apache.org/jira/browse/NIFI-4759
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Major
>
> Two issues:
> * The updateKey field is ignored in favor of _id in the update code block of 
> PutMongo.
> * _id fields are always treated as strings, even if they're valid ObjectIds 
> represented as a string. PutMongo should be able to handle these as ObjectIds.
> Regarding the first point, this works:
> {code:java}
> {
> "_id": "1234",
> "$set": { "msg": "Hello, world" }
> }
> {code}
> This does not:
> {code:java}
> {
> "uniqueKey": "12345",
> "$set": { "msg": "Hello, World" }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2401: NIFI-4759 Fixed a bug that left a hard-coded reference to ...

[pvillard31]

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2401
  
+1, LGTM, thanks for the PR @MikeThomsen and thanks for the review @mgaido91


---

[jira] [Updated] (NIFI-4748) Add endpoint override to PutKinesisStream and PutKinesisFirehose

[Pierre Villard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-4748:
-
Component/s: Extensions

> Add endpoint override to PutKinesisStream and PutKinesisFirehose
> 
>
> Key: NIFI-4748
> URL: https://issues.apache.org/jira/browse/NIFI-4748
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Joey Frazee
>Assignee: Joey Frazee
>Priority: Minor
> Fix For: 1.6.0
>
>
> Both AmazonKinesisClient and AmazonKinesisFirehoseClient support setRegion() 
> and endpoint override can be useful for unit testing and working with Kinesis 
> compatible services, so it'd be helpful to add the ENDPOINT_OVERRIDE property 
> to these processors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (NIFI-4748) Add endpoint override to PutKinesisStream and PutKinesisFirehose

[Pierre Villard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-4748:
-
   Resolution: Fixed
Fix Version/s: 1.6.0
   Status: Resolved  (was: Patch Available)

> Add endpoint override to PutKinesisStream and PutKinesisFirehose
> 
>
> Key: NIFI-4748
> URL: https://issues.apache.org/jira/browse/NIFI-4748
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Joey Frazee
>Assignee: Joey Frazee
>Priority: Minor
> Fix For: 1.6.0
>
>
> Both AmazonKinesisClient and AmazonKinesisFirehoseClient support setRegion() 
> and endpoint override can be useful for unit testing and working with Kinesis 
> compatible services, so it'd be helpful to add the ENDPOINT_OVERRIDE property 
> to these processors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2399: NIFI-4748 Add endpoint override to Kinesis processo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2399


---

[jira] [Commented] (NIFI-4748) Add endpoint override to PutKinesisStream and PutKinesisFirehose

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329432#comment-16329432
 ] 

ASF subversion and git services commented on NIFI-4748:
---

Commit ea2519e3ea5edba8b91b37e9d815bc711b3a997c in nifi's branch 
refs/heads/master from [~jfrazee]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ea2519e ]

NIFI-4748 - Add endpoint override to Kinesis processors

Signed-off-by: Pierre Villard 

This closes #2399.


> Add endpoint override to PutKinesisStream and PutKinesisFirehose
> 
>
> Key: NIFI-4748
> URL: https://issues.apache.org/jira/browse/NIFI-4748
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joey Frazee
>Assignee: Joey Frazee
>Priority: Minor
>
> Both AmazonKinesisClient and AmazonKinesisFirehoseClient support setRegion() 
> and endpoint override can be useful for unit testing and working with Kinesis 
> compatible services, so it'd be helpful to add the ENDPOINT_OVERRIDE property 
> to these processors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4748) Add endpoint override to PutKinesisStream and PutKinesisFirehose

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329435#comment-16329435
 ] 

ASF GitHub Bot commented on NIFI-4748:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2399


> Add endpoint override to PutKinesisStream and PutKinesisFirehose
> 
>
> Key: NIFI-4748
> URL: https://issues.apache.org/jira/browse/NIFI-4748
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joey Frazee
>Assignee: Joey Frazee
>Priority: Minor
>
> Both AmazonKinesisClient and AmazonKinesisFirehoseClient support setRegion() 
> and endpoint override can be useful for unit testing and working with Kinesis 
> compatible services, so it'd be helpful to add the ENDPOINT_OVERRIDE property 
> to these processors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4748) Add endpoint override to PutKinesisStream and PutKinesisFirehose

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329427#comment-16329427
 ] 

ASF GitHub Bot commented on NIFI-4748:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2399
  
+1, merging to master, thanks @jfrazee 


> Add endpoint override to PutKinesisStream and PutKinesisFirehose
> 
>
> Key: NIFI-4748
> URL: https://issues.apache.org/jira/browse/NIFI-4748
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joey Frazee
>Assignee: Joey Frazee
>Priority: Minor
>
> Both AmazonKinesisClient and AmazonKinesisFirehoseClient support setRegion() 
> and endpoint override can be useful for unit testing and working with Kinesis 
> compatible services, so it'd be helpful to add the ENDPOINT_OVERRIDE property 
> to these processors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2399: NIFI-4748 Add endpoint override to Kinesis processors

[pvillard31]

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2399
  
+1, merging to master, thanks @jfrazee 


---

[jira] [Commented] (MINIFICPP-367) Implement expression language arithmetic operations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329309#comment-16329309
 ] 

ASF GitHub Bot commented on MINIFICPP-367:
--

GitHub user achristianson opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/243

MINIFICPP-367 Implement expression language arithmetic operations

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [x] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-367

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #243


commit 1c4c0005f61a4672ff3c5892f06009e179d20289
Author: Andy I. Christianson 
Date:   2018-01-16T21:05:47Z

MINIFICPP-367 Implement expression language arithmetic operations




> Implement expression language arithmetic operations
> ---
>
> Key: MINIFICPP-367
> URL: https://issues.apache.org/jira/browse/MINIFICPP-367
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>Priority: Major
>
> Mathematical Operations and Numeric Manipulation
> plus
> minus
> multiply
> divide
> mod
> toRadix
> fromRadix
> random
> math



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #243: MINIFICPP-367 Implement expression langua...

[achristianson]

GitHub user achristianson opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/243

MINIFICPP-367 Implement expression language arithmetic operations

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [x] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-367

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #243


commit 1c4c0005f61a4672ff3c5892f06009e179d20289
Author: Andy I. Christianson 
Date:   2018-01-16T21:05:47Z

MINIFICPP-367 Implement expression language arithmetic operations




---

[jira] [Created] (MINIFICPP-376) EL fails on chained function calls

[Andrew Christianson (JIRA)]

Andrew Christianson created MINIFICPP-376:
-

 Summary: EL fails on chained function calls
 Key: MINIFICPP-376
 URL: https://issues.apache.org/jira/browse/MINIFICPP-376
 Project: NiFi MiNiFi C++
  Issue Type: Bug
Reporter: Andrew Christianson
Assignee: Andrew Christianson


Chained calls such as random():mod(10):plus(1) do not work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4789) Enhance ExtractGrok processor to handle multiple grok expressions

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329295#comment-16329295
 ] 

Joseph Witt commented on NIFI-4789:
---

It certainly sounds cool [~opensource.char...@gmail.com].  Its best if you send 
over the PR and it gets reviewed from there.

> Enhance ExtractGrok processor to handle multiple grok expressions
> -
>
> Key: NIFI-4789
> URL: https://issues.apache.org/jira/browse/NIFI-4789
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework
>Affects Versions: 1.2.0, 1.5.0
> Environment: all
>Reporter: Charles Porter
>Priority: Minor
>  Labels: features
>
> Many flows require running several grok expressions against an input to 
> correctly tag and extract data. using many separate grok processors to 
> accomplish this is unwieldy and hard to maintain.  Supporting multiple grok 
> expressions delimited by comma or user selected delimiter greatly simplifies 
> this.  
> Feature is coded and tested, ready for pull request, if feature is approved



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (NIFI-4789) Enhance ExtractGrok processor to handle multiple grok expressions

[Charles Porter (JIRA)]

Charles Porter created NIFI-4789:


 Summary: Enhance ExtractGrok processor to handle multiple grok 
expressions
 Key: NIFI-4789
 URL: https://issues.apache.org/jira/browse/NIFI-4789
 Project: Apache NiFi
  Issue Type: New Feature
  Components: Core Framework
Affects Versions: 1.5.0, 1.2.0
 Environment: all
Reporter: Charles Porter


Many flows require running several grok expressions against an input to 
correctly tag and extract data. using many separate grok processors to 
accomplish this is unwieldy and hard to maintain.  Supporting multiple grok 
expressions delimited by comma or user selected delimiter greatly simplifies 
this.  
Feature is coded and tested, ready for pull request, if feature is approved



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (NIFI-4766) Add documentation for new proxy host values in nifi.properties

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman reassigned NIFI-4766:
-

Assignee: Matt Gilman  (was: Andy LoPresto)

> Add documentation for new proxy host values in nifi.properties
> --
>
> Key: NIFI-4766
> URL: https://issues.apache.org/jira/browse/NIFI-4766
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Documentation  Website
>Affects Versions: 1.5.0
>Reporter: Andy LoPresto
>Assignee: Matt Gilman
>Priority: Major
>  Labels: config, documentation, host, proxy
>
> A new property will be introduced in NIFI-4761 which allows whitelisting 
> custom host(s) for the host header value. The cause of and use of this 
> property should be well documented in the Admin Guide. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (NIFI-4618) Add documentation for context path whitelisting

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman reassigned NIFI-4618:
-

Assignee: Matt Gilman  (was: Andy LoPresto)

> Add documentation for context path whitelisting
> ---
>
> Key: NIFI-4618
> URL: https://issues.apache.org/jira/browse/NIFI-4618
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation  Website
>Affects Versions: 1.5.0
>Reporter: Andy LoPresto
>Assignee: Matt Gilman
>Priority: Minor
>  Labels: documentation, proxy
>
> In NIFI-4501 we introduced a new {{nifi.properties}} property 
> {{nifi.web.proxy.context.path}} to allow whitelisting context paths when 
> using a proxy. The use of this property and the expected formatting should be 
> documented in the Admin Guide. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4390) Add a keyboard shortcut for Connection related dialogs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329076#comment-16329076
 ] 

ASF GitHub Bot commented on NIFI-4390:
--

Github user yuri1969 commented on the issue:

https://github.com/apache/nifi/pull/2157
  
@mcgilman This PR was created solely in order to speed up the connection 
creation. There was a follow-up discussion at 
https://issues.apache.org/jira/browse/NIFI-4390.

So I'm not sure if this particular PR is still valid.


> Add a keyboard shortcut for Connection related dialogs
> --
>
> Key: NIFI-4390
> URL: https://issues.apache.org/jira/browse/NIFI-4390
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Yuri
>Priority: Minor
>  Labels: dialogs, shortcuts, ui, ux
> Attachments: nifi_dialogs_v1.ods
>
>
> Current dialogs don't allow to bound a keyboard shortcut to an action. This 
> hinders the UX, since there are many dialogs involved in the most common 
> interactions.
> For instance, adding a new connection with a single relationship still 
> requires a click at the confirm button. Instead, it should be possible to 
> confirm the dialog simply by hitting the Enter key.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2157: NIFI-4390 - Add a keyboard shortcut for Connection...

[yuri1969]

Github user yuri1969 commented on the issue:

https://github.com/apache/nifi/pull/2157
  
@mcgilman This PR was created solely in order to speed up the connection 
creation. There was a follow-up discussion at 
https://issues.apache.org/jira/browse/NIFI-4390.

So I'm not sure if this particular PR is still valid.


---

[jira] [Created] (NIFI-4788) Expose whitelisting configuration for docker instantiation

[Aldrin Piri (JIRA)]

Aldrin Piri created NIFI-4788:
-

 Summary: Expose whitelisting configuration for docker instantiation
 Key: NIFI-4788
 URL: https://issues.apache.org/jira/browse/NIFI-4788
 Project: Apache NiFi
  Issue Type: Sub-task
  Components: Docker
Affects Versions: 1.5.0
Reporter: Aldrin Piri
Assignee: Aldrin Piri






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (NIFIREG-119) Detect incorrect configuration when using composite user group provider

[Kevin Doran (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFIREG-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Doran reassigned NIFIREG-119:
---

Assignee: Kevin Doran

> Detect incorrect configuration when using composite user group provider
> ---
>
> Key: NIFIREG-119
> URL: https://issues.apache.org/jira/browse/NIFIREG-119
> Project: NiFi Registry
>  Issue Type: Improvement
>Reporter: Kevin Doran
>Assignee: Kevin Doran
>Priority: Minor
>
> We should be able to detect if the same user group provider is entered more 
> than once in the composite user group provider and fail start up.
> Example config that should fail start up:
> 
>   composite-configurable-user-group-provider
>   
> org.apache.nifi.registry.security.authorization.CompositeConfigurableUserGroupProvider
>   file-user-group-provider
>   file-user-group-provider
>   ldap-user-group-provider
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (NIFIREG-119) Detect incorrect configuration when using composite user group provider

[Kevin Doran (JIRA)]

Kevin Doran created NIFIREG-119:
---

 Summary: Detect incorrect configuration when using composite user 
group provider
 Key: NIFIREG-119
 URL: https://issues.apache.org/jira/browse/NIFIREG-119
 Project: NiFi Registry
  Issue Type: Improvement
Reporter: Kevin Doran


We should be able to detect if the same user group provider is entered more 
than once in the composite user group provider and fail start up.

Example config that should fail start up:


  composite-configurable-user-group-provider
  
org.apache.nifi.registry.security.authorization.CompositeConfigurableUserGroupProvider
  file-user-group-provider
  file-user-group-provider
  ldap-user-group-provider




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4784) ProcessorStatusSnapshotDTO and ProcessorStatusDTO annotation fixes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328915#comment-16328915
 ] 

ASF GitHub Bot commented on NIFI-4784:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2407
  
Thanks @sbouchex! This has been merged to master.


> ProcessorStatusSnapshotDTO and ProcessorStatusDTO annotation fixes
> --
>
> Key: NIFI-4784
> URL: https://issues.apache.org/jira/browse/NIFI-4784
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.5.0
> Environment: All
>Reporter: Sébastien Bouchex Bellomié
>Priority: Minor
> Fix For: 1.6.0
>
>
> Following NIFI-4615  , it appears that the allowableValues annotation for the 
> ProcessorStatusDTO and ProcessorStatusSnapshotDTO classes  are incorrect as 
> the runStatus coming from org.apache.nifi.controller.status.RunStatus enum 
> with the values "Running", "Stopped", "Invalid", "Disabled" are not uppercase.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4784) ProcessorStatusSnapshotDTO and ProcessorStatusDTO annotation fixes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328917#comment-16328917
 ] 

ASF GitHub Bot commented on NIFI-4784:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2407


> ProcessorStatusSnapshotDTO and ProcessorStatusDTO annotation fixes
> --
>
> Key: NIFI-4784
> URL: https://issues.apache.org/jira/browse/NIFI-4784
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.5.0
> Environment: All
>Reporter: Sébastien Bouchex Bellomié
>Priority: Minor
> Fix For: 1.6.0
>
>
> Following NIFI-4615  , it appears that the allowableValues annotation for the 
> ProcessorStatusDTO and ProcessorStatusSnapshotDTO classes  are incorrect as 
> the runStatus coming from org.apache.nifi.controller.status.RunStatus enum 
> with the values "Running", "Stopped", "Invalid", "Disabled" are not uppercase.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2407: NIFI-4784 ProcessorStatusSnapshotDTO and ProcessorS...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2407


---

[jira] [Commented] (NIFI-4784) ProcessorStatusSnapshotDTO and ProcessorStatusDTO annotation fixes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328914#comment-16328914
 ] 

ASF subversion and git services commented on NIFI-4784:
---

Commit e4dda497bb8c8bb44ebc562f3562f65801dfc338 in nifi's branch 
refs/heads/master from [~sbouc...@infovista.com]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=e4dda49 ]

NIFI-4784: Fixed runStatus allowedValues. This closes #2407


> ProcessorStatusSnapshotDTO and ProcessorStatusDTO annotation fixes
> --
>
> Key: NIFI-4784
> URL: https://issues.apache.org/jira/browse/NIFI-4784
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.5.0
> Environment: All
>Reporter: Sébastien Bouchex Bellomié
>Priority: Minor
> Fix For: 1.6.0
>
>
> Following NIFI-4615  , it appears that the allowableValues annotation for the 
> ProcessorStatusDTO and ProcessorStatusSnapshotDTO classes  are incorrect as 
> the runStatus coming from org.apache.nifi.controller.status.RunStatus enum 
> with the values "Running", "Stopped", "Invalid", "Disabled" are not uppercase.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (NIFI-4784) ProcessorStatusSnapshotDTO and ProcessorStatusDTO annotation fixes

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman resolved NIFI-4784.
---
   Resolution: Fixed
Fix Version/s: 1.6.0

> ProcessorStatusSnapshotDTO and ProcessorStatusDTO annotation fixes
> --
>
> Key: NIFI-4784
> URL: https://issues.apache.org/jira/browse/NIFI-4784
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.5.0
> Environment: All
>Reporter: Sébastien Bouchex Bellomié
>Priority: Minor
> Fix For: 1.6.0
>
>
> Following NIFI-4615  , it appears that the allowableValues annotation for the 
> ProcessorStatusDTO and ProcessorStatusSnapshotDTO classes  are incorrect as 
> the runStatus coming from org.apache.nifi.controller.status.RunStatus enum 
> with the values "Running", "Stopped", "Invalid", "Disabled" are not uppercase.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2407: NIFI-4784 ProcessorStatusSnapshotDTO and ProcessorStatusDT...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2407
  
Thanks @sbouchex! This has been merged to master.


---

[jira] [Updated] (NIFI-4781) ClientAuthenticationMethod to be optional

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-4781:
--
Fix Version/s: (was: 1.4.0)
   1.6.0

> ClientAuthenticationMethod to be optional
> -
>
> Key: NIFI-4781
> URL: https://issues.apache.org/jira/browse/NIFI-4781
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Senthil Annaswamy
>Priority: Minor
> Fix For: 1.6.0
>
>
> token_endpoint_auth_methods_supported
>  OPTIONAL. JSON array containing a list of Client Authentication methods 
> supported by this Token Endpoint. The options are client_secret_post, 
> client_secret_basic, client_secret_jwt, and private_key_jwt, as described in 
> Section 9 of OpenID Connect Core 1.0 [OpenID.Core]. Other authentication 
> methods MAY be defined by extensions. If omitted, the default is 
> client_secret_basic -- the HTTP Basic Authentication Scheme specified in 
> Section 2.3.1 of OAuth 2.0 [RFC6749].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (NIFI-4781) ClientAuthenticationMethod to be optional

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman resolved NIFI-4781.
---
Resolution: Fixed

> ClientAuthenticationMethod to be optional
> -
>
> Key: NIFI-4781
> URL: https://issues.apache.org/jira/browse/NIFI-4781
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Senthil Annaswamy
>Priority: Minor
> Fix For: 1.6.0
>
>
> token_endpoint_auth_methods_supported
>  OPTIONAL. JSON array containing a list of Client Authentication methods 
> supported by this Token Endpoint. The options are client_secret_post, 
> client_secret_basic, client_secret_jwt, and private_key_jwt, as described in 
> Section 9 of OpenID Connect Core 1.0 [OpenID.Core]. Other authentication 
> methods MAY be defined by extensions. If omitted, the default is 
> client_secret_basic -- the HTTP Basic Authentication Scheme specified in 
> Section 2.3.1 of OAuth 2.0 [RFC6749].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2213: Update StandardOidcIdentityProvider.java

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2213
  
Thanks @Senthilannaswamy! This has been merged to master.


---

[jira] [Commented] (NIFI-4781) ClientAuthenticationMethod to be optional

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328912#comment-16328912
 ] 

ASF subversion and git services commented on NIFI-4781:
---

Commit 790f14b8ef77740fc79839f51a3521db39afde09 in nifi's branch 
refs/heads/master from [~Senthil,Annaswamy]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=790f14b ]

NIFI-4781: Updated ClientAuthenticationMethod as optional field response from 
OpenID provider. This closes #2213


> ClientAuthenticationMethod to be optional
> -
>
> Key: NIFI-4781
> URL: https://issues.apache.org/jira/browse/NIFI-4781
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Senthil Annaswamy
>Priority: Minor
> Fix For: 1.4.0
>
>
> token_endpoint_auth_methods_supported
>  OPTIONAL. JSON array containing a list of Client Authentication methods 
> supported by this Token Endpoint. The options are client_secret_post, 
> client_secret_basic, client_secret_jwt, and private_key_jwt, as described in 
> Section 9 of OpenID Connect Core 1.0 [OpenID.Core]. Other authentication 
> methods MAY be defined by extensions. If omitted, the default is 
> client_secret_basic -- the HTTP Basic Authentication Scheme specified in 
> Section 2.3.1 of OAuth 2.0 [RFC6749].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2213: Update StandardOidcIdentityProvider.java

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2213


---

[jira] [Updated] (NIFI-4786) Allow Expression Evaluation to Kinesis/Firehose Stream Name

[Joseph Witt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Witt updated NIFI-4786:
--
Fix Version/s: (was: 1.5.0)

> Allow Expression Evaluation to Kinesis/Firehose Stream Name
> ---
>
> Key: NIFI-4786
> URL: https://issues.apache.org/jira/browse/NIFI-4786
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Dorian Bugeja
>Priority: Minor
>  Labels: features, performance, pull-request-available
> Attachments: 
> NIFI_4786___Allow_Expression_Evaluation_to_Kinesis_Firehose_Stream_Name.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currenctly, the Stream name propoerty for both Firehose and Kinesis does not 
> support the expression language. Routing can be performed based on an 
> attribute of the flowfile and having a single component rather than multiple 
> for each one. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4786) Allow Expression Evaluation to Kinesis/Firehose Stream Name

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328891#comment-16328891
 ] 

Joseph Witt commented on NIFI-4786:
---

fix version can be set once review and traction toward a merge.  Thanks for the 
contribution

> Allow Expression Evaluation to Kinesis/Firehose Stream Name
> ---
>
> Key: NIFI-4786
> URL: https://issues.apache.org/jira/browse/NIFI-4786
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Dorian Bugeja
>Priority: Minor
>  Labels: features, performance, pull-request-available
> Attachments: 
> NIFI_4786___Allow_Expression_Evaluation_to_Kinesis_Firehose_Stream_Name.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currenctly, the Stream name propoerty for both Firehose and Kinesis does not 
> support the expression language. Routing can be performed based on an 
> attribute of the flowfile and having a single component rather than multiple 
> for each one. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4786) Allow Expression Evaluation to Kinesis/Firehose Stream Name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328886#comment-16328886
 ] 

ASF GitHub Bot commented on NIFI-4786:
--

GitHub user SunSatION reopened a pull request:

https://github.com/apache/nifi/pull/2409

NIFI-4786 - Allow Expression Evaluation to Kinesis/Firehose Stream Name

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SunSatION/nifi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2409


commit a4e7e677d6f9b85fb872f5217532fb6cb082c2c2
Author: dorian.bugeja 
Date:   2018-01-17T10:22:39Z

NIFI-4786 - Allow Expression Evaluation to Kinesis/Firehose Stream Name

commit 7a4e1a71c5ee89191f2b5204b2edfa0f614624b9
Author: dorian.bugeja 
Date:   2018-01-17T10:36:12Z

NIFI-4786 - Allow Expression Evaluation to Kinesis/Firehose Stream Name




> Allow Expression Evaluation to Kinesis/Firehose Stream Name
> ---
>
> Key: NIFI-4786
> URL: https://issues.apache.org/jira/browse/NIFI-4786
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Dorian Bugeja
>Priority: Minor
>  Labels: features, performance, pull-request-available
> Fix For: 1.5.0
>
> Attachments: 
> NIFI_4786___Allow_Expression_Evaluation_to_Kinesis_Firehose_Stream_Name.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currenctly, the Stream name propoerty for both Firehose and Kinesis does not 
> support the expression language. Routing can be performed based on an 
> attribute of the flowfile and having a single component rather than multiple 
> for each one. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4786) Allow Expression Evaluation to Kinesis/Firehose Stream Name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328885#comment-16328885
 ] 

ASF GitHub Bot commented on NIFI-4786:
--

Github user SunSatION closed the pull request at:

https://github.com/apache/nifi/pull/2409


> Allow Expression Evaluation to Kinesis/Firehose Stream Name
> ---
>
> Key: NIFI-4786
> URL: https://issues.apache.org/jira/browse/NIFI-4786
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Dorian Bugeja
>Priority: Minor
>  Labels: features, performance, pull-request-available
> Fix For: 1.5.0
>
> Attachments: 
> NIFI_4786___Allow_Expression_Evaluation_to_Kinesis_Firehose_Stream_Name.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currenctly, the Stream name propoerty for both Firehose and Kinesis does not 
> support the expression language. Routing can be performed based on an 
> attribute of the flowfile and having a single component rather than multiple 
> for each one. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2409: NIFI-4786 - Allow Expression Evaluation to Kinesis/...

[SunSatION]

Github user SunSatION closed the pull request at:

https://github.com/apache/nifi/pull/2409


---

[GitHub] nifi pull request #2409: NIFI-4786 - Allow Expression Evaluation to Kinesis/...

[SunSatION]

GitHub user SunSatION reopened a pull request:

https://github.com/apache/nifi/pull/2409

NIFI-4786 - Allow Expression Evaluation to Kinesis/Firehose Stream Name

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SunSatION/nifi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2409


commit a4e7e677d6f9b85fb872f5217532fb6cb082c2c2
Author: dorian.bugeja 
Date:   2018-01-17T10:22:39Z

NIFI-4786 - Allow Expression Evaluation to Kinesis/Firehose Stream Name

commit 7a4e1a71c5ee89191f2b5204b2edfa0f614624b9
Author: dorian.bugeja 
Date:   2018-01-17T10:36:12Z

NIFI-4786 - Allow Expression Evaluation to Kinesis/Firehose Stream Name




---

[jira] [Updated] (NIFIREG-111) Update count when lists are filtered

[Andrew Lim (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFIREG-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Lim updated NIFIREG-111:
---
Description: 
The UI shows the total number of buckets/users respectively. However, if the 
list is filtered, the number is static and doesn't update.

Maybe we can make this consistent with what is done in NiFi and show 
"Displaying X of X", so the user can see the count of items shown with the 
filter applied, but also the total count.

  was:
The UI shows the total number of buckets/users respectiviely.  However, if the 
list is filtered, the number is static and doesn't update.

Maybe we can make this consistent with what is done in NiFi and show 
"Displaying X of X", so the user can see the count of items shown with the 
filter applied, but also the total count.


> Update count when lists are filtered
> 
>
> Key: NIFIREG-111
> URL: https://issues.apache.org/jira/browse/NIFIREG-111
> Project: NiFi Registry
>  Issue Type: Improvement
>Affects Versions: 0.1.0
>Reporter: Andrew Lim
>Priority: Minor
>
> The UI shows the total number of buckets/users respectively. However, if the 
> list is filtered, the number is static and doesn't update.
> Maybe we can make this consistent with what is done in NiFi and show 
> "Displaying X of X", so the user can see the count of items shown with the 
> filter applied, but also the total count.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2408: localization using the JSTL standard fmt tag for multiling...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/2408
  
@ns7381 Thanks for the PR! I plan to start reviewing this soon. 


---

[GitHub] nifi-minifi pull request #110: MINIFI-427: Adds version to System Admin Guid...

[jzonthemtn]

GitHub user jzonthemtn opened a pull request:

https://github.com/apache/nifi-minifi/pull/110

MINIFI-427: Adds version to System Admin Guide.

Thank you for submitting a contribution to Apache NiFi - MiNiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi-minifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under minifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under minifi-assembly?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jzonthemtn/nifi-minifi MINIFI-427

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #110


commit 664146c08a1d40dc067c9b0adf17565ff07c204b
Author: jzemerick 
Date:   2018-01-17T14:17:27Z

MINIFI-427: Adds version to System Admin Guide.




---