[jira] [Commented] (TC-540) TO postinstall writes incorrect keys to ldap.conf

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140133#comment-16140133
 ] 

ASF GitHub Bot commented on TC-540:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/866
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/139/



> TO postinstall writes incorrect keys to ldap.conf
> -
>
> Key: TC-540
> URL: https://issues.apache.org/jira/browse/TC-540
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>Priority: Blocker
> Fix For: 2.1.0
>
>
> I think this needs to be fixed for 2.1.
> postinstall writes incorrect keys to /opt/traffic_ops/app/conf/ldap.conf -- 
> they should be:
> {quote}
>"host"
>"admin_dn" 
>"admin_pass" 
>"search_base"
> {quote}
> but the keys that show up are:
> {quote}
>"password"
>"search_base"
>"hostname" 
>"admin_dn" 
>"setupLdap"
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-549) TO install missing perl Crypt::ScryptKDF library

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140131#comment-16140131
 ] 

ASF GitHub Bot commented on TC-549:
---

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/862


> TO install missing perl Crypt::ScryptKDF library
> 
>
> Key: TC-549
> URL: https://issues.apache.org/jira/browse/TC-549
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Fix For: 2.2.0
>
>
> postinstall for Traffic Ops requires the Crypt::ScryptKDF perl library.
> This means that it must be installed prior to the carton run,  which is done 
> by postinstall.
> So,  it needs to be added to the rpm spec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-540) TO postinstall writes incorrect keys to ldap.conf

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140124#comment-16140124
 ] 

ASF GitHub Bot commented on TC-540:
---

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/866

[TC-540] fix ldap.conf key



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol ldap-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/866.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #866






> TO postinstall writes incorrect keys to ldap.conf
> -
>
> Key: TC-540
> URL: https://issues.apache.org/jira/browse/TC-540
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>Priority: Blocker
> Fix For: 2.1.0
>
>
> I think this needs to be fixed for 2.1.
> postinstall writes incorrect keys to /opt/traffic_ops/app/conf/ldap.conf -- 
> they should be:
> {quote}
>"host"
>"admin_dn" 
>"admin_pass" 
>"search_base"
> {quote}
> but the keys that show up are:
> {quote}
>"password"
>"search_base"
>"hostname" 
>"admin_dn" 
>"setupLdap"
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-549) TO install missing perl Crypt::ScryptKDF library

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140023#comment-16140023
 ] 

ASF GitHub Bot commented on TC-549:
---

Github user hbeatty commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/862
  
@dangogh merged - please close


> TO install missing perl Crypt::ScryptKDF library
> 
>
> Key: TC-549
> URL: https://issues.apache.org/jira/browse/TC-549
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Fix For: 2.2.0
>
>
> postinstall for Traffic Ops requires the Crypt::ScryptKDF perl library.
> This means that it must be installed prior to the carton run,  which is done 
> by postinstall.
> So,  it needs to be added to the rpm spec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140004#comment-16140004
 ] 

ASF GitHub Bot commented on TC-535:
---

Github user hbeatty commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/860
  
@mitchell852 merged - please close


> DS URL sig key apis needs to have tenancy check in place
> 
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the 
> use_tenancy parameter but when activated it is used to limit the scope of 
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's 
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-547) Fix regression issues caused by TC-187

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139462#comment-16139462
 ] 

ASF GitHub Bot commented on TC-547:
---

Github user zhilhuan commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/855
  
@rawlinp Thanks for your comments! Yes, that's need aother discussion, 
because the certs may be pasted by operator instead of generated by ops.


> Fix regression issues caused by TC-187
> --
>
> Key: TC-547
> URL: https://issues.apache.org/jira/browse/TC-547
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 3.0.0
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>
> Fix for TC-187 introduced change to use "ds_" instead of xml_id as the 
> key to put SSL certificate to riak server.
> This may cause regression issues when doing migration. And as xml_id becomes 
> immutable now, this change is not needed anymore. 
> Also the change for get ssl certificate in API may cause regression issue. 
> Will revert it as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-287) Add support for per-Delivery Service routing/name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139391#comment-16139391
 ] 

ASF GitHub Bot commented on TC-287:
---

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/865
  
Thanks for squashing your commits, however a PR this size should probably 
have more than 1 commit.


> Add support for per-Delivery Service routing/name
> -
>
> Key: TC-287
> URL: https://issues.apache.org/jira/browse/TC-287
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Router
>Reporter: Eric Friedrich
>Assignee: Rawlin Peters
>  Labels: crconfig, routing
>
> A default routing name/entry point should be added as a profile parameter, 
> and this parameter should be used by default as the value of the "routing 
> name" or "entry point" on the delivery service in the CRConfig. This value 
> should be overridable on a per-delivery service level, which means that the 
> delivery service UIs should be enhanced to provide this capability and to 
> display the default value.
> Once above is implemented, consume the new delivery service parameter and 
> configure accordingly within Traffic Router.
> From: 
> https://github.com/Comcast/traffic_control/issues/61
> https://github.com/Comcast/traffic_control/issues/62



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-287) Add support for per-Delivery Service routing/name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139319#comment-16139319
 ] 

ASF GitHub Bot commented on TC-287:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/865
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/99/



> Add support for per-Delivery Service routing/name
> -
>
> Key: TC-287
> URL: https://issues.apache.org/jira/browse/TC-287
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Router
>Reporter: Eric Friedrich
>Assignee: Rawlin Peters
>  Labels: crconfig, routing
>
> A default routing name/entry point should be added as a profile parameter, 
> and this parameter should be used by default as the value of the "routing 
> name" or "entry point" on the delivery service in the CRConfig. This value 
> should be overridable on a per-delivery service level, which means that the 
> delivery service UIs should be enhanced to provide this capability and to 
> display the default value.
> Once above is implemented, consume the new delivery service parameter and 
> configure accordingly within Traffic Router.
> From: 
> https://github.com/Comcast/traffic_control/issues/61
> https://github.com/Comcast/traffic_control/issues/62



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-287) Add support for per-Delivery Service routing/name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139287#comment-16139287
 ] 

ASF GitHub Bot commented on TC-287:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/865
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/138/



> Add support for per-Delivery Service routing/name
> -
>
> Key: TC-287
> URL: https://issues.apache.org/jira/browse/TC-287
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Router
>Reporter: Eric Friedrich
>Assignee: Rawlin Peters
>  Labels: crconfig, routing
>
> A default routing name/entry point should be added as a profile parameter, 
> and this parameter should be used by default as the value of the "routing 
> name" or "entry point" on the delivery service in the CRConfig. This value 
> should be overridable on a per-delivery service level, which means that the 
> delivery service UIs should be enhanced to provide this capability and to 
> display the default value.
> Once above is implemented, consume the new delivery service parameter and 
> configure accordingly within Traffic Router.
> From: 
> https://github.com/Comcast/traffic_control/issues/61
> https://github.com/Comcast/traffic_control/issues/62



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-287) Add support for per-Delivery Service routing/name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139277#comment-16139277
 ] 

ASF GitHub Bot commented on TC-287:
---

GitHub user rawlinp opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/865

[TC-287] Add support for per-DeliveryService routing names

Add a routing_name column to the DeliveryService table and populate it
to 'tr' and 'edge' for HTTP and DNS delivery services, respectively.

To make upgrading seamless for CDNs using a custom http.routing.name
(configured in the TR), provide a temporary upgrade parameter to
populate the routing name for HTTP Delivery Services. Otherwise HTTP
DSes will get routing_name = "tr".

Replace all hardcoded/assumed routing names of 'edge' or 'tr' in Traffic
Ops with the proper routing name configured for that delivery service.

Update the API/UI to support custom routing names for delivery services.
To prevent breaking the API, "routingName" is an optional field (the DB
schema provides an arbitrary default).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawlinp/incubator-trafficcontrol 
per-cdn-routing-names_2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/865.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #865


commit 1925845dd9c5cc53a87dcff130d1e5843142023f
Author: Rawlin Peters 
Date:   2017-07-31T17:37:50Z

[TC-287] Add support for per-DeliveryService routing names

Add a routing_name column to the DeliveryService table and populate it
to 'tr' and 'edge' for HTTP and DNS delivery services, respectively.

To make upgrading seamless for CDNs using a custom http.routing.name
(configured in the TR), provide a temporary upgrade parameter to
populate the routing name for HTTP Delivery Services. Otherwise HTTP
DSes will get routing_name = "tr".

Replace all hardcoded/assumed routing names of 'edge' or 'tr' in Traffic
Ops with the proper routing name configured for that delivery service.

Update the API/UI to support custom routing names for delivery services.
To prevent breaking the API, "routingName" is an optional field (the DB
schema provides an arbitrary default).




> Add support for per-Delivery Service routing/name
> -
>
> Key: TC-287
> URL: https://issues.apache.org/jira/browse/TC-287
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Router
>Reporter: Eric Friedrich
>Assignee: Rawlin Peters
>  Labels: crconfig, routing
>
> A default routing name/entry point should be added as a profile parameter, 
> and this parameter should be used by default as the value of the "routing 
> name" or "entry point" on the delivery service in the CRConfig. This value 
> should be overridable on a per-delivery service level, which means that the 
> delivery service UIs should be enhanced to provide this capability and to 
> display the default value.
> Once above is implemented, consume the new delivery service parameter and 
> configure accordingly within Traffic Router.
> From: 
> https://github.com/Comcast/traffic_control/issues/61
> https://github.com/Comcast/traffic_control/issues/62



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-551) TO API - add the ability to filter parameters by name or config file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139107#comment-16139107
 ] 

ASF GitHub Bot commented on TC-551:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/863
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/97/



> TO API - add the ability to filter parameters by name or config file
> 
>
> Key: TC-551
> URL: https://issues.apache.org/jira/browse/TC-551
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Examples:
> /api/1.2/parameters?name=LogFormat.Format
> /api/1.2/parameters?configFile=records.config



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139066#comment-16139066
 ] 

ASF GitHub Bot commented on TC-441:
---

Github user mitchell852 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/858
  
manually closing


> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139067#comment-16139067
 ] 

ASF GitHub Bot commented on TC-441:
---

Github user mitchell852 closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/858


> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-551) TO API - add the ability to filter parameters by name or config file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139045#comment-16139045
 ] 

ASF GitHub Bot commented on TC-551:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/863


> TO API - add the ability to filter parameters by name or config file
> 
>
> Key: TC-551
> URL: https://issues.apache.org/jira/browse/TC-551
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Examples:
> /api/1.2/parameters?name=LogFormat.Format
> /api/1.2/parameters?configFile=records.config



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-549) TO install missing perl Crypt::ScryptKDF library

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139027#comment-16139027
 ] 

ASF GitHub Bot commented on TC-549:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/862
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/96/



> TO install missing perl Crypt::ScryptKDF library
> 
>
> Key: TC-549
> URL: https://issues.apache.org/jira/browse/TC-549
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Fix For: 2.2.0
>
>
> postinstall for Traffic Ops requires the Crypt::ScryptKDF perl library.
> This means that it must be installed prior to the carton run,  which is done 
> by postinstall.
> So,  it needs to be added to the rpm spec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-551) TO API - add the ability to filter parameters by name or config file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139009#comment-16139009
 ] 

ASF GitHub Bot commented on TC-551:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/863
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/136/



> TO API - add the ability to filter parameters by name or config file
> 
>
> Key: TC-551
> URL: https://issues.apache.org/jira/browse/TC-551
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Examples:
> /api/1.2/parameters?name=LogFormat.Format
> /api/1.2/parameters?configFile=records.config



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-551) TO API - add the ability to filter parameters by name or config file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139000#comment-16139000
 ] 

ASF GitHub Bot commented on TC-551:
---

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/863

[TC-551] - adds the ability to filter parameters by name or config_file



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
tc-551-add-filters-to-params-api

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/863.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #863


commit 575b853616647cc0515ae8ea030f611d5866d9e9
Author: Jeremy Mitchell 
Date:   2017-08-23T20:10:45Z

adds the ability to filter parameters by name or config_file




> TO API - add the ability to filter parameters by name or config file
> 
>
> Key: TC-551
> URL: https://issues.apache.org/jira/browse/TC-551
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Examples:
> /api/1.2/parameters?name=LogFormat.Format
> /api/1.2/parameters?configFile=records.config



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-549) TO install missing perl Crypt::ScryptKDF library

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138990#comment-16138990
 ] 

ASF GitHub Bot commented on TC-549:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/862
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/135/



> TO install missing perl Crypt::ScryptKDF library
> 
>
> Key: TC-549
> URL: https://issues.apache.org/jira/browse/TC-549
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Fix For: 2.2.0
>
>
> postinstall for Traffic Ops requires the Crypt::ScryptKDF perl library.
> This means that it must be installed prior to the carton run,  which is done 
> by postinstall.
> So,  it needs to be added to the rpm spec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-549) TO install missing perl Crypt::ScryptKDF library

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138979#comment-16138979
 ] 

ASF GitHub Bot commented on TC-549:
---

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/862

[BACKPORT][TC-549] adds perl-Crypt-ScryptKDF to traffic_ops rpm deps

 so postinstall wil run

(cherry picked from commit 3737bb1429cfadea51ef6f28a6098eb08c29a8df)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
cryptlib-dep-2.1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/862.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #862


commit 867d6f997ee694a84774bd3002228b38894fc8f1
Author: Dan Kirkwood 
Date:   2017-08-23T18:14:35Z

adds perl-Crypt-ScryptKDF to traffic_ops rpm deps so postinstall will run

(cherry picked from commit 3737bb1429cfadea51ef6f28a6098eb08c29a8df)




> TO install missing perl Crypt::ScryptKDF library
> 
>
> Key: TC-549
> URL: https://issues.apache.org/jira/browse/TC-549
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Fix For: 2.2.0
>
>
> postinstall for Traffic Ops requires the Crypt::ScryptKDF perl library.
> This means that it must be installed prior to the carton run,  which is done 
> by postinstall.
> So,  it needs to be added to the rpm spec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-549) TO install missing perl Crypt::ScryptKDF library

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138930#comment-16138930
 ] 

ASF GitHub Bot commented on TC-549:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/861


> TO install missing perl Crypt::ScryptKDF library
> 
>
> Key: TC-549
> URL: https://issues.apache.org/jira/browse/TC-549
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Fix For: 2.2.0
>
>
> postinstall for Traffic Ops requires the Crypt::ScryptKDF perl library.
> This means that it must be installed prior to the carton run,  which is done 
> by postinstall.
> So,  it needs to be added to the rpm spec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-549) TO install missing perl Crypt::ScryptKDF library

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138872#comment-16138872
 ] 

ASF GitHub Bot commented on TC-549:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/861
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/95/



> TO install missing perl Crypt::ScryptKDF library
> 
>
> Key: TC-549
> URL: https://issues.apache.org/jira/browse/TC-549
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Fix For: 2.2.0
>
>
> postinstall for Traffic Ops requires the Crypt::ScryptKDF perl library.
> This means that it must be installed prior to the carton run,  which is done 
> by postinstall.
> So,  it needs to be added to the rpm spec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138836#comment-16138836
 ] 

ASF GitHub Bot commented on TC-441:
---

Github user hbeatty commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/858
  
@mitchell852 merged - please close


> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138833#comment-16138833
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/94/



> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-549) TO install missing perl Crypt::ScryptKDF library

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138831#comment-16138831
 ] 

ASF GitHub Bot commented on TC-549:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/861
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/134/



> TO install missing perl Crypt::ScryptKDF library
> 
>
> Key: TC-549
> URL: https://issues.apache.org/jira/browse/TC-549
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Fix For: 2.2.0
>
>
> postinstall for Traffic Ops requires the Crypt::ScryptKDF perl library.
> This means that it must be installed prior to the carton run,  which is done 
> by postinstall.
> So,  it needs to be added to the rpm spec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-549) TO install missing perl Crypt::ScryptKDF library

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138818#comment-16138818
 ] 

ASF GitHub Bot commented on TC-549:
---

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/861

[TC-549] adds missing perl-Crypt-ScryptKDF dependency to TO rpm



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
missing-crypt-lib

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #861






> TO install missing perl Crypt::ScryptKDF library
> 
>
> Key: TC-549
> URL: https://issues.apache.org/jira/browse/TC-549
> Project: Traffic Control
>  Issue Type: Bug
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Fix For: 2.2.0
>
>
> postinstall for Traffic Ops requires the Crypt::ScryptKDF perl library.
> This means that it must be installed prior to the carton run,  which is done 
> by postinstall.
> So,  it needs to be added to the rpm spec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138789#comment-16138789
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/133/



> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138775#comment-16138775
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/132/



> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138772#comment-16138772
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  
retest this please


> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138765#comment-16138765
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/93/



> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138759#comment-16138759
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  
retest this please


> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138721#comment-16138721
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/91/



> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138727#comment-16138727
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/131/



> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138716#comment-16138716
 ] 

ASF GitHub Bot commented on TC-491:
---

Github user rawlinp closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/856


> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation
> 
>
> Key: TC-491
> URL: https://issues.apache.org/jira/browse/TC-491
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Robert Scrimo
>Assignee: Jeremy Mitchell
>Priority: Critical
> Fix For: 2.1.0, 2.2.0
>
>
> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation.
> E.g.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
> key constraint "fk_job_deliveryservice1" on table "job"
> DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
> "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
> /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642
> Workaround: No UI/API end-point to delete the associated job.  Delete 
> associated job from database.
> NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138709#comment-16138709
 ] 

ASF GitHub Bot commented on TC-491:
---

Github user hbeatty commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/856
  
@rawlinp Thank you for renaming your branch. This has been merged. Please 
close.


> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation
> 
>
> Key: TC-491
> URL: https://issues.apache.org/jira/browse/TC-491
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Robert Scrimo
>Assignee: Jeremy Mitchell
>Priority: Critical
> Fix For: 2.1.0, 2.2.0
>
>
> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation.
> E.g.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
> key constraint "fk_job_deliveryservice1" on table "job"
> DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
> "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
> /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642
> Workaround: No UI/API end-point to delete the associated job.  Delete 
> associated job from database.
> NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-547) Fix regression issues caused by TC-187

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138676#comment-16138676
 ] 

ASF GitHub Bot commented on TC-547:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/855


> Fix regression issues caused by TC-187
> --
>
> Key: TC-547
> URL: https://issues.apache.org/jira/browse/TC-547
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 3.0.0
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>
> Fix for TC-187 introduced change to use "ds_" instead of xml_id as the 
> key to put SSL certificate to riak server.
> This may cause regression issues when doing migration. And as xml_id becomes 
> immutable now, this change is not needed anymore. 
> Also the change for get ssl certificate in API may cause regression issue. 
> Will revert it as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-540) TO postinstall writes incorrect keys to ldap.conf

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138669#comment-16138669
 ] 

ASF GitHub Bot commented on TC-540:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/859
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/130/



> TO postinstall writes incorrect keys to ldap.conf
> -
>
> Key: TC-540
> URL: https://issues.apache.org/jira/browse/TC-540
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>Priority: Blocker
> Fix For: 2.1.0
>
>
> I think this needs to be fixed for 2.1.
> postinstall writes incorrect keys to /opt/traffic_ops/app/conf/ldap.conf -- 
> they should be:
> {quote}
>"host"
>"admin_dn" 
>"admin_pass" 
>"search_base"
> {quote}
> but the keys that show up are:
> {quote}
>"password"
>"search_base"
>"hostname" 
>"admin_dn" 
>"setupLdap"
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-540) TO postinstall writes incorrect keys to ldap.conf

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138653#comment-16138653
 ] 

ASF GitHub Bot commented on TC-540:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/859
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/90/



> TO postinstall writes incorrect keys to ldap.conf
> -
>
> Key: TC-540
> URL: https://issues.apache.org/jira/browse/TC-540
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>Priority: Blocker
> Fix For: 2.1.0
>
>
> I think this needs to be fixed for 2.1.
> postinstall writes incorrect keys to /opt/traffic_ops/app/conf/ldap.conf -- 
> they should be:
> {quote}
>"host"
>"admin_dn" 
>"admin_pass" 
>"search_base"
> {quote}
> but the keys that show up are:
> {quote}
>"password"
>"search_base"
>"hostname" 
>"admin_dn" 
>"setupLdap"
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-547) Fix regression issues caused by TC-187

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138651#comment-16138651
 ] 

ASF GitHub Bot commented on TC-547:
---

Github user rawlinp commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/855
  
Looks good to me. Thanks for fixing this!

Note that we'll have to figure out if we want to regenerate the actual 
certs too (rather than just the hostname in the riak record), but we'll tackle 
that in a new PR once we've discussed what needs to be done about that.


> Fix regression issues caused by TC-187
> --
>
> Key: TC-547
> URL: https://issues.apache.org/jira/browse/TC-547
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 3.0.0
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>
> Fix for TC-187 introduced change to use "ds_" instead of xml_id as the 
> key to put SSL certificate to riak server.
> This may cause regression issues when doing migration. And as xml_id becomes 
> immutable now, this change is not needed anymore. 
> Also the change for get ssl certificate in API may cause regression issue. 
> Will revert it as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-540) TO postinstall writes incorrect keys to ldap.conf

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138647#comment-16138647
 ] 

ASF GitHub Bot commented on TC-540:
---

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/859

[BACKPORT][TC-540] fix postinstall ldap.conf keys; prompt for base_url



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 2.1-ldapfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/859.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #859


commit d8c0d89e2d6f86b37bff528bb0a789ca9c55ae1f
Author: Dan Kirkwood 
Date:   2017-08-18T18:44:33Z

required keys in ldap.conf; check host form; add base_url to defaults and 
q's

(cherry picked from commit df979b164af2575159cd339036200a72215c63c2)

commit d1075d7d938925c5df164bb45ed91f99b12f0d13
Author: Dan Kirkwood 
Date:   2017-08-22T20:57:22Z

updates base_url

(cherry picked from commit 35abdcc64d9dbe70a1fd118bc51538d6fa10be66)




> TO postinstall writes incorrect keys to ldap.conf
> -
>
> Key: TC-540
> URL: https://issues.apache.org/jira/browse/TC-540
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>Priority: Blocker
> Fix For: 2.1.0
>
>
> I think this needs to be fixed for 2.1.
> postinstall writes incorrect keys to /opt/traffic_ops/app/conf/ldap.conf -- 
> they should be:
> {quote}
>"host"
>"admin_dn" 
>"admin_pass" 
>"search_base"
> {quote}
> but the keys that show up are:
> {quote}
>"password"
>"search_base"
>"hostname" 
>"admin_dn" 
>"setupLdap"
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138648#comment-16138648
 ] 

ASF GitHub Bot commented on TC-535:
---

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/860

[TC-535] - 2.1.x url sig tenancy checks



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
2.1.x-url-sig-tenancy-checks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/860.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #860


commit c673c2973468c4fab7af4dd486416698d999a0ba
Author: nir-sopher 
Date:   2017-08-13T15:25:37Z

url sig - tenancy checks

(cherry picked from commit a70ba7d49f44ff7dbff81d38ba76913032b2916e)

commit cf65023066804e6f944a161d65f626b765e3b81c
Author: nir-sopher 
Date:   2017-08-22T19:54:16Z

DS URL access - removing a test probably failed on env diffs

(cherry picked from commit 4b68e32102e99f27f378e800a77976b486cc3bf7)




> DS URL sig key apis needs to have tenancy check in place
> 
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the 
> use_tenancy parameter but when activated it is used to limit the scope of 
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's 
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138643#comment-16138643
 ] 

ASF GitHub Bot commented on TC-535:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/831


> DS URL sig key apis needs to have tenancy check in place
> 
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the 
> use_tenancy parameter but when activated it is used to limit the scope of 
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's 
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138640#comment-16138640
 ] 

ASF GitHub Bot commented on TC-441:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/858
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/88/



> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138639#comment-16138639
 ] 

ASF GitHub Bot commented on TC-441:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/858
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/128/



> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138631#comment-16138631
 ] 

ASF GitHub Bot commented on TC-441:
---

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/858

[BACKPORT] [TC-441] - refactored how tokin login works to ensure tokin 
login is complete be…

…fore attempting to resolve other dependencies that need the authentication 
cookie

(cherry picked from commit 98092836c2ae5ac3382245e1b3645eefbda1c7b6)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
2.1.x-fixes-token-login-on-tp

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/858.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #858


commit 2598bd6a060a5419edb5dfea610fab194ef06081
Author: Jeremy Mitchell 
Date:   2017-08-23T16:33:36Z

refactored how tokin login works to ensure tokin login is complete before 
attempting to resolve other dependencies that need the authentication cookie

(cherry picked from commit 98092836c2ae5ac3382245e1b3645eefbda1c7b6)




> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138623#comment-16138623
 ] 

ASF GitHub Bot commented on TC-441:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/857


> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138619#comment-16138619
 ] 

ASF GitHub Bot commented on TC-441:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/857
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/127/



> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-540) TO postinstall writes incorrect keys to ldap.conf

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138614#comment-16138614
 ] 

ASF GitHub Bot commented on TC-540:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/854


> TO postinstall writes incorrect keys to ldap.conf
> -
>
> Key: TC-540
> URL: https://issues.apache.org/jira/browse/TC-540
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>Priority: Blocker
> Fix For: 2.1.0
>
>
> I think this needs to be fixed for 2.1.
> postinstall writes incorrect keys to /opt/traffic_ops/app/conf/ldap.conf -- 
> they should be:
> {quote}
>"host"
>"admin_dn" 
>"admin_pass" 
>"search_base"
> {quote}
> but the keys that show up are:
> {quote}
>"password"
>"search_base"
>"hostname" 
>"admin_dn" 
>"setupLdap"
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138611#comment-16138611
 ] 

ASF GitHub Bot commented on TC-441:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/857
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/87/



> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-547) Fix regression issues caused by TC-187

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138605#comment-16138605
 ] 

ASF GitHub Bot commented on TC-547:
---

Github user DylanVolz commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/855
  
@zhilhuan Yes that was a build server issue that should be resolved now.

This PR looks good; it reverts the breaking changes introduced by the 
change from xmlId to id in the keysto store ssl keys in riak.


> Fix regression issues caused by TC-187
> --
>
> Key: TC-547
> URL: https://issues.apache.org/jira/browse/TC-547
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 3.0.0
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>
> Fix for TC-187 introduced change to use "ds_" instead of xml_id as the 
> key to put SSL certificate to riak server.
> This may cause regression issues when doing migration. And as xml_id becomes 
> immutable now, this change is not needed anymore. 
> Also the change for get ssl certificate in API may cause regression issue. 
> Will revert it as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138606#comment-16138606
 ] 

ASF GitHub Bot commented on TC-441:
---

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/857

[TC-441] - refactored how tokin login works to ensure tokin login is 
complete be…

…fore attempting to resolve other dependencies that need the authentication 
cookie

this is related to password reset because password reset utilizes token 
login

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
tc-441-fixes-token-login

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/857.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #857


commit e4abe88f8b4493dd5f5a0cc91360b3da8f3d7a79
Author: Jeremy Mitchell 
Date:   2017-08-23T16:33:36Z

refactored how tokin login works to ensure tokin login is complete before 
attempting to resolve other dependencies that need the authentication cookie




> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138551#comment-16138551
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/126/



> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138548#comment-16138548
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/86/



> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138543#comment-16138543
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  
retest this please


> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138489#comment-16138489
 ] 

ASF GitHub Bot commented on TC-441:
---

Github user mitchell852 closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/847


> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138488#comment-16138488
 ] 

ASF GitHub Bot commented on TC-441:
---

Github user mitchell852 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/847
  
manually closing


> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138481#comment-16138481
 ] 

ASF GitHub Bot commented on TC-491:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/856
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/85/



> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation
> 
>
> Key: TC-491
> URL: https://issues.apache.org/jira/browse/TC-491
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Robert Scrimo
>Assignee: Jeremy Mitchell
>Priority: Critical
> Fix For: 2.1.0, 2.2.0
>
>
> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation.
> E.g.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
> key constraint "fk_job_deliveryservice1" on table "job"
> DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
> "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
> /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642
> Workaround: No UI/API end-point to delete the associated job.  Delete 
> associated job from database.
> NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138475#comment-16138475
 ] 

ASF GitHub Bot commented on TC-491:
---

Github user rawlinp commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/856
  
@hbeatty renamed my branch and recreated the PR


> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation
> 
>
> Key: TC-491
> URL: https://issues.apache.org/jira/browse/TC-491
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Robert Scrimo
>Assignee: Jeremy Mitchell
>Priority: Critical
> Fix For: 2.1.0, 2.2.0
>
>
> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation.
> E.g.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
> key constraint "fk_job_deliveryservice1" on table "job"
> DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
> "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
> /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642
> Workaround: No UI/API end-point to delete the associated job.  Delete 
> associated job from database.
> NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138472#comment-16138472
 ] 

ASF GitHub Bot commented on TC-491:
---

GitHub user rawlinp opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/856

[BACKPORT] [TC-491] [TC-492] - Fix SQL error in downgrade scripts

(cherry picked from commit 4a5962ed53720c6ff2286979a71161e782d725e7)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawlinp/incubator-trafficcontrol 
backport-sql-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/856.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #856


commit e9880975207de5364702da27f4c9929648a0ccbd
Author: Rawlin Peters 
Date:   2017-08-21T22:45:54Z

Fix SQL error in downgrade scripts

(cherry picked from commit 4a5962ed53720c6ff2286979a71161e782d725e7)




> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation
> 
>
> Key: TC-491
> URL: https://issues.apache.org/jira/browse/TC-491
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Robert Scrimo
>Assignee: Jeremy Mitchell
>Priority: Critical
> Fix For: 2.1.0, 2.2.0
>
>
> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation.
> E.g.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
> key constraint "fk_job_deliveryservice1" on table "job"
> DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
> "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
> /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642
> Workaround: No UI/API end-point to delete the associated job.  Delete 
> associated job from database.
> NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138466#comment-16138466
 ] 

ASF GitHub Bot commented on TC-491:
---

Github user rawlinp closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/851


> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation
> 
>
> Key: TC-491
> URL: https://issues.apache.org/jira/browse/TC-491
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Robert Scrimo
>Assignee: Jeremy Mitchell
>Priority: Critical
> Fix For: 2.1.0, 2.2.0
>
>
> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation.
> E.g.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
> key constraint "fk_job_deliveryservice1" on table "job"
> DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
> "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
> /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642
> Workaround: No UI/API end-point to delete the associated job.  Delete 
> associated job from database.
> NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138401#comment-16138401
 ] 

ASF GitHub Bot commented on TC-491:
---

Github user hbeatty commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/851
  
@rawlinp Can you please rename your branch?


> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation
> 
>
> Key: TC-491
> URL: https://issues.apache.org/jira/browse/TC-491
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Robert Scrimo
>Assignee: Jeremy Mitchell
>Priority: Critical
> Fix For: 2.1.0, 2.2.0
>
>
> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation.
> E.g.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
> key constraint "fk_job_deliveryservice1" on table "job"
> DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
> "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
> /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642
> Workaround: No UI/API end-point to delete the associated job.  Delete 
> associated job from database.
> NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-441) TPv2 - implement password reset functionality

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138373#comment-16138373
 ] 

ASF GitHub Bot commented on TC-441:
---

Github user hbeatty commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/847
  
@mitchell852 merged - please close


> TPv2 - implement password reset functionality
> -
>
> Key: TC-441
> URL: https://issues.apache.org/jira/browse/TC-441
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>
> implement password reset functionality



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-547) Fix regression issues caused by TC-187

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137974#comment-16137974
 ] 

ASF GitHub Bot commented on TC-547:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/855
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/124/



> Fix regression issues caused by TC-187
> --
>
> Key: TC-547
> URL: https://issues.apache.org/jira/browse/TC-547
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 3.0.0
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>
> Fix for TC-187 introduced change to use "ds_" instead of xml_id as the 
> key to put SSL certificate to riak server.
> This may cause regression issues when doing migration. And as xml_id becomes 
> immutable now, this change is not needed anymore. 
> Also the change for get ssl certificate in API may cause regression issue. 
> Will revert it as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137980#comment-16137980
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user zhilhuan commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  
@DylanVolz https://github.com/apache/incubator-trafficcontrol/pull/855 for 
TC-547 is ready for review.


> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-336) Add ability to copy url_sig keys from one DS to another GH #1540

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137979#comment-16137979
 ] 

ASF GitHub Bot commented on TC-336:
---

Github user zhilhuan commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/790
  
https://github.com/apache/incubator-trafficcontrol/pull/855


> Add ability to copy url_sig keys from one DS to another GH #1540
> 
>
> Key: TC-336
> URL: https://issues.apache.org/jira/browse/TC-336
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Vault
>Reporter: Dewayne Richardson
>Assignee: Dylan Volz
>Priority: Minor
>  Labels: keys, url_signing
>
> There are some cases where we want to use the same URL sig keys for multiple 
> delivery services. Currently this is handled by using cURL and other manual 
> processes. Traffic Ops should support the ability to copy url sig keys from 
> one DS to another. When this happens Traffic Ops should also create the 
> necessary parameters for the target DS so that URL signing works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-547) Fix regression issues caused by TC-187

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137970#comment-16137970
 ] 

ASF GitHub Bot commented on TC-547:
---

Github user zhilhuan commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/855
  
@rawlinp This PR reverted the regression issues introduced by TC-187. And 
also resolved your comments in PR#360. Please help to review.


> Fix regression issues caused by TC-187
> --
>
> Key: TC-547
> URL: https://issues.apache.org/jira/browse/TC-547
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 3.0.0
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>
> Fix for TC-187 introduced change to use "ds_" instead of xml_id as the 
> key to put SSL certificate to riak server.
> This may cause regression issues when doing migration. And as xml_id becomes 
> immutable now, this change is not needed anymore. 
> Also the change for get ssl certificate in API may cause regression issue. 
> Will revert it as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-547) Fix regression issues caused by TC-187

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137969#comment-16137969
 ] 

ASF GitHub Bot commented on TC-547:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/855
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/84/



> Fix regression issues caused by TC-187
> --
>
> Key: TC-547
> URL: https://issues.apache.org/jira/browse/TC-547
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 3.0.0
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>
> Fix for TC-187 introduced change to use "ds_" instead of xml_id as the 
> key to put SSL certificate to riak server.
> This may cause regression issues when doing migration. And as xml_id becomes 
> immutable now, this change is not needed anymore. 
> Also the change for get ssl certificate in API may cause regression issue. 
> Will revert it as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-547) Fix regression issues caused by TC-187

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137973#comment-16137973
 ] 

ASF GitHub Bot commented on TC-547:
---

Github user zhilhuan commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/855
  
fatal: ambiguous argument 'TC-547': unknown revision or path not in the 
working tree.

This is a issue in build server, not my code, right?


> Fix regression issues caused by TC-187
> --
>
> Key: TC-547
> URL: https://issues.apache.org/jira/browse/TC-547
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 3.0.0
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>
> Fix for TC-187 introduced change to use "ds_" instead of xml_id as the 
> key to put SSL certificate to riak server.
> This may cause regression issues when doing migration. And as xml_id becomes 
> immutable now, this change is not needed anymore. 
> Also the change for get ssl certificate in API may cause regression issue. 
> Will revert it as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-547) Fix regression issues caused by TC-187

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137968#comment-16137968
 ] 

ASF GitHub Bot commented on TC-547:
---

GitHub user zhilhuan opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/855

[TC-547] Fix regression issues caused by TC-187

Fix regression issues caused by TC-187:
1. revert: replace xml_id with ds_ as riak key for ssl certificate
2. revert: decode base64 for ssl csr, crt, key in restful api

Add missing code for update ssl keystore when hostname changes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zhilhuan/incubator-trafficcontrol TC-547

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/855.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #855


commit 8dd685f4ee99c17f212839bc7d61e9b7553d6e67
Author: Zhilin Huang 
Date:   2017-08-23T03:03:03Z

Fix regression issues caused by TC-187:
1. revert: replace xml_id with ds_ as riak key for ssl certificate
2. revert: decode base64 for ssl csr, crt, key in restful api

Add missing code for update ssl keystore when hostname changes




> Fix regression issues caused by TC-187
> --
>
> Key: TC-547
> URL: https://issues.apache.org/jira/browse/TC-547
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 3.0.0
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>
> Fix for TC-187 introduced change to use "ds_" instead of xml_id as the 
> key to put SSL certificate to riak server.
> This may cause regression issues when doing migration. And as xml_id becomes 
> immutable now, this change is not needed anymore. 
> Also the change for get ssl certificate in API may cause regression issue. 
> Will revert it as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-336) Add ability to copy url_sig keys from one DS to another GH #1540

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137977#comment-16137977
 ] 

ASF GitHub Bot commented on TC-336:
---

Github user zhilhuan commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/790
  
@DylanVolz PR#855 for TC-547 is ready for review.


> Add ability to copy url_sig keys from one DS to another GH #1540
> 
>
> Key: TC-336
> URL: https://issues.apache.org/jira/browse/TC-336
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Vault
>Reporter: Dewayne Richardson
>Assignee: Dylan Volz
>Priority: Minor
>  Labels: keys, url_signing
>
> There are some cases where we want to use the same URL sig keys for multiple 
> delivery services. Currently this is handled by using cURL and other manual 
> processes. Traffic Ops should support the ability to copy url sig keys from 
> one DS to another. When this happens Traffic Ops should also create the 
> necessary parameters for the target DS so that URL signing works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-540) TO postinstall writes incorrect keys to ldap.conf

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137447#comment-16137447
 ] 

ASF GitHub Bot commented on TC-540:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/854
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/123/



> TO postinstall writes incorrect keys to ldap.conf
> -
>
> Key: TC-540
> URL: https://issues.apache.org/jira/browse/TC-540
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>Priority: Blocker
> Fix For: 2.1.0
>
>
> I think this needs to be fixed for 2.1.
> postinstall writes incorrect keys to /opt/traffic_ops/app/conf/ldap.conf -- 
> they should be:
> {quote}
>"host"
>"admin_dn" 
>"admin_pass" 
>"search_base"
> {quote}
> but the keys that show up are:
> {quote}
>"password"
>"search_base"
>"hostname" 
>"admin_dn" 
>"setupLdap"
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-540) TO postinstall writes incorrect keys to ldap.conf

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137442#comment-16137442
 ] 

ASF GitHub Bot commented on TC-540:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/854
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/83/



> TO postinstall writes incorrect keys to ldap.conf
> -
>
> Key: TC-540
> URL: https://issues.apache.org/jira/browse/TC-540
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>Priority: Blocker
> Fix For: 2.1.0
>
>
> I think this needs to be fixed for 2.1.
> postinstall writes incorrect keys to /opt/traffic_ops/app/conf/ldap.conf -- 
> they should be:
> {quote}
>"host"
>"admin_dn" 
>"admin_pass" 
>"search_base"
> {quote}
> but the keys that show up are:
> {quote}
>"password"
>"search_base"
>"hostname" 
>"admin_dn" 
>"setupLdap"
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-540) TO postinstall writes incorrect keys to ldap.conf

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137440#comment-16137440
 ] 

ASF GitHub Bot commented on TC-540:
---

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/854

[TC-540] postinstall ldap.conf keys fixed; cdn.conf base_url added

keys for ldap.conf were incorrect and caused traffic_ops not to connect to 
ldap.   cdn.conf base_url question was missed causing base_url in existing 
cdn.conf to be unchanged.

Both of these were fixed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol ldap-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/854.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #854


commit 1d80843aabeaebbb7f2581d7772dd74b4fe57c0f
Author: Dan Kirkwood 
Date:   2017-08-18T18:44:33Z

required keys in ldap.conf; check host form; add base_url to defaults and 
q's

commit 9419bb8e52b6c0423e69fc2492537dd97354acbf
Author: Dan Kirkwood 
Date:   2017-08-22T20:57:22Z

updates base_url




> TO postinstall writes incorrect keys to ldap.conf
> -
>
> Key: TC-540
> URL: https://issues.apache.org/jira/browse/TC-540
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>Priority: Blocker
> Fix For: 2.1.0
>
>
> I think this needs to be fixed for 2.1.
> postinstall writes incorrect keys to /opt/traffic_ops/app/conf/ldap.conf -- 
> they should be:
> {quote}
>"host"
>"admin_dn" 
>"admin_pass" 
>"search_base"
> {quote}
> but the keys that show up are:
> {quote}
>"password"
>"search_base"
>"hostname" 
>"admin_dn" 
>"setupLdap"
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137407#comment-16137407
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/82/



> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137406#comment-16137406
 ] 

ASF GitHub Bot commented on TC-443:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/122/



> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-443) TPv2 - add the ability to view cache config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137397#comment-16137397
 ] 

ASF GitHub Bot commented on TC-443:
---

GitHub user DylanVolz opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/853

WIP [TC-443] - add the ability to manage ssl keys to TPv2

waiting to merge on https://issues.apache.org/jira/browse/TC-547

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DylanVolz/incubator-trafficcontrol 
ssl-key-management-ui

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/853.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #853


commit af41ade59a9b8cd8630d652e929349328459e031
Author: Dylan Volz 
Date:   2017-08-10T17:15:19Z

add the ability to manage ssl keys to TPv2




> TPv2 - add the ability to view cache config files
> -
>
> Key: TC-443
> URL: https://issues.apache.org/jira/browse/TC-443
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> add the ability to view cache config files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137296#comment-16137296
 ] 

ASF GitHub Bot commented on TC-535:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/831
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/121/



> DS URL sig key apis needs to have tenancy check in place
> 
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the 
> use_tenancy parameter but when activated it is used to limit the scope of 
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's 
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137293#comment-16137293
 ] 

ASF GitHub Bot commented on TC-535:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/831
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/81/



> DS URL sig key apis needs to have tenancy check in place
> 
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the 
> use_tenancy parameter but when activated it is used to limit the scope of 
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's 
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137285#comment-16137285
 ] 

ASF GitHub Bot commented on TC-535:
---

Github user nir-sopher commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/831
  
This test had no issues on my VM.
It can be removed, but I do not understand what is the cause of the failure.
Any additional inputs in the log from the failure?
10x,
Nir


> DS URL sig key apis needs to have tenancy check in place
> 
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the 
> use_tenancy parameter but when activated it is used to limit the scope of 
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's 
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-336) Add ability to copy url_sig keys from one DS to another GH #1540

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137252#comment-16137252
 ] 

ASF GitHub Bot commented on TC-336:
---

Github user DylanVolz commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/790
  
waiting to merge on https://issues.apache.org/jira/browse/TC-547


> Add ability to copy url_sig keys from one DS to another GH #1540
> 
>
> Key: TC-336
> URL: https://issues.apache.org/jira/browse/TC-336
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Vault
>Reporter: Dewayne Richardson
>Assignee: Dylan Volz
>Priority: Minor
>  Labels: keys, url_signing
>
> There are some cases where we want to use the same URL sig keys for multiple 
> delivery services. Currently this is handled by using cURL and other manual 
> processes. Traffic Ops should support the ability to copy url sig keys from 
> one DS to another. When this happens Traffic Ops should also create the 
> necessary parameters for the target DS so that URL signing works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-336) Add ability to copy url_sig keys from one DS to another GH #1540

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137109#comment-16137109
 ] 

ASF GitHub Bot commented on TC-336:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/790
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/79/



> Add ability to copy url_sig keys from one DS to another GH #1540
> 
>
> Key: TC-336
> URL: https://issues.apache.org/jira/browse/TC-336
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Vault
>Reporter: Dewayne Richardson
>Assignee: Dylan Volz
>Priority: Minor
>  Labels: keys, url_signing
>
> There are some cases where we want to use the same URL sig keys for multiple 
> delivery services. Currently this is handled by using cURL and other manual 
> processes. Traffic Ops should support the ability to copy url sig keys from 
> one DS to another. When this happens Traffic Ops should also create the 
> necessary parameters for the target DS so that URL signing works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-336) Add ability to copy url_sig keys from one DS to another GH #1540

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137106#comment-16137106
 ] 

ASF GitHub Bot commented on TC-336:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/790
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/119/



> Add ability to copy url_sig keys from one DS to another GH #1540
> 
>
> Key: TC-336
> URL: https://issues.apache.org/jira/browse/TC-336
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Vault
>Reporter: Dewayne Richardson
>Assignee: Dylan Volz
>Priority: Minor
>  Labels: keys, url_signing
>
> There are some cases where we want to use the same URL sig keys for multiple 
> delivery services. Currently this is handled by using cURL and other manual 
> processes. Traffic Ops should support the ability to copy url sig keys from 
> one DS to another. When this happens Traffic Ops should also create the 
> necessary parameters for the target DS so that URL signing works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-336) Add ability to copy url_sig keys from one DS to another GH #1540

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137104#comment-16137104
 ] 

ASF GitHub Bot commented on TC-336:
---

Github user DylanVolz commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/790#discussion_r134556388
  
--- Diff: 
traffic_portal/app/src/common/api/DeliveryServiceUrlSigKeysService.js ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+var DeliveryServiceUrlSigKeysService = function(locationUtils, 
messageModel, $http, $q, ENV) {
+
+   this.generateUrlSigKeys = function(dsXmlId) {
+   var request = $q.defer();
+   $http.post(ENV.api['root'] + 'deliveryservices/xmlId/' + 
dsXmlId + '/urlkeys/generate')
+   .then(
+   function(result) {
+   messageModel.setMessages([ { level: 'success', 
text: 'URL Sig Keys generated' } ], true);
--- End diff --

fault message included properly now.


> Add ability to copy url_sig keys from one DS to another GH #1540
> 
>
> Key: TC-336
> URL: https://issues.apache.org/jira/browse/TC-336
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Vault
>Reporter: Dewayne Richardson
>Assignee: Dylan Volz
>Priority: Minor
>  Labels: keys, url_signing
>
> There are some cases where we want to use the same URL sig keys for multiple 
> delivery services. Currently this is handled by using cURL and other manual 
> processes. Traffic Ops should support the ability to copy url sig keys from 
> one DS to another. When this happens Traffic Ops should also create the 
> necessary parameters for the target DS so that URL signing works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-336) Add ability to copy url_sig keys from one DS to another GH #1540

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137105#comment-16137105
 ] 

ASF GitHub Bot commented on TC-336:
---

Github user DylanVolz commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/790#discussion_r134556400
  
--- Diff: 
traffic_portal/app/src/common/api/DeliveryServiceUrlSigKeysService.js ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+var DeliveryServiceUrlSigKeysService = function(locationUtils, 
messageModel, $http, $q, ENV) {
+
+   this.generateUrlSigKeys = function(dsXmlId) {
+   var request = $q.defer();
+   $http.post(ENV.api['root'] + 'deliveryservices/xmlId/' + 
dsXmlId + '/urlkeys/generate')
+   .then(
+   function(result) {
+   messageModel.setMessages([ { level: 'success', 
text: 'URL Sig Keys generated' } ], true);
+   request.resolve();
+   },
+   function() {
+   messageModel.setMessages(fault.data.alerts, 
false);
+   request.reject();
+   }
+   );
+   return request.promise;
+   };
+
+   this.copyUrlSigKeys = function(dsXmlId, copyFromXmlId) {
+   var request = $q.defer();
+$http.post(ENV.api['root'] + 'deliveryservices/xmlId/' + 
dsXmlId + '/urlkeys/copyFromXmlId/' + copyFromXmlId)
+   .then(
+   function(result) {
+   messageModel.setMessages([ { level: 'success', 
text: 'URL Sig Keys copied' } ], true);
--- End diff --

fault message included properly now.


> Add ability to copy url_sig keys from one DS to another GH #1540
> 
>
> Key: TC-336
> URL: https://issues.apache.org/jira/browse/TC-336
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Vault
>Reporter: Dewayne Richardson
>Assignee: Dylan Volz
>Priority: Minor
>  Labels: keys, url_signing
>
> There are some cases where we want to use the same URL sig keys for multiple 
> delivery services. Currently this is handled by using cURL and other manual 
> processes. Traffic Ops should support the ability to copy url sig keys from 
> one DS to another. When this happens Traffic Ops should also create the 
> necessary parameters for the target DS so that URL signing works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-336) Add ability to copy url_sig keys from one DS to another GH #1540

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137102#comment-16137102
 ] 

ASF GitHub Bot commented on TC-336:
---

Github user DylanVolz commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/790#discussion_r134555976
  
--- Diff: traffic_ops/app/lib/TrafficOpsRoutes.pm ---
@@ -571,6 +571,11 @@ sub api_routes {
->to( 'KeysUrlSig#copy_url_sig_keys', namespace => 
'API::DeliveryService' );
$r->get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys")->over( 
authenticated => 1, not_ldap => 1 )
->to( 'KeysUrlSig#view_by_xmlid', namespace => 
'API::DeliveryService' );
+   # -- DELIVERY SERVICE: VIEW URL SIG KEYS BY ID
+   $r->get("/api/$version/deliveryservices/:id/urlkeys")->over( 
authenticated => 1, not_ldap => 1 )
--- End diff --

documentation has now been added


> Add ability to copy url_sig keys from one DS to another GH #1540
> 
>
> Key: TC-336
> URL: https://issues.apache.org/jira/browse/TC-336
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops, Traffic Vault
>Reporter: Dewayne Richardson
>Assignee: Dylan Volz
>Priority: Minor
>  Labels: keys, url_signing
>
> There are some cases where we want to use the same URL sig keys for multiple 
> delivery services. Currently this is handled by using cURL and other manual 
> processes. Traffic Ops should support the ability to copy url sig keys from 
> one DS to another. When this happens Traffic Ops should also create the 
> necessary parameters for the target DS so that URL signing works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-545) CRConfig should not list teak nodes as edges

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137015#comment-16137015
 ] 

ASF GitHub Bot commented on TC-545:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/845
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/118/



> CRConfig should not list teak nodes as edges
> 
>
> Key: TC-545
> URL: https://issues.apache.org/jira/browse/TC-545
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Derek Gelinas
>Assignee: Derek Gelinas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-545) CRConfig should not list teak nodes as edges

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137012#comment-16137012
 ] 

ASF GitHub Bot commented on TC-545:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/845
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/78/



> CRConfig should not list teak nodes as edges
> 
>
> Key: TC-545
> URL: https://issues.apache.org/jira/browse/TC-545
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Derek Gelinas
>Assignee: Derek Gelinas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-545) CRConfig should not list teak nodes as edges

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137004#comment-16137004
 ] 

ASF GitHub Bot commented on TC-545:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/845
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/117/



> CRConfig should not list teak nodes as edges
> 
>
> Key: TC-545
> URL: https://issues.apache.org/jira/browse/TC-545
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Derek Gelinas
>Assignee: Derek Gelinas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-545) CRConfig should not list teak nodes as edges

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136996#comment-16136996
 ] 

ASF GitHub Bot commented on TC-545:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/845
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/77/



> CRConfig should not list teak nodes as edges
> 
>
> Key: TC-545
> URL: https://issues.apache.org/jira/browse/TC-545
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Derek Gelinas
>Assignee: Derek Gelinas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136928#comment-16136928
 ] 

ASF GitHub Bot commented on TC-535:
---

Github user mitchell852 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/831
  
I'm getting a failure when i run your tests. I think it has to do with your 
set_param_value subroutine...I think...

$ prove -qrp t/api/1.1/deliveryservice/keys_url_sig.t
t/api/1.1/deliveryservice/keys_url_sig.t .. 1/? DBI bind_columns: invalid 
number of arguments: got handle + 0, expected handle + between 1 and -1
Usage: $h->bind_columns(\$var1 [, \$var2, ...]) at 
/code/src/github.com/apache/incubator-trafficcontrol/traffic_ops/app/local/lib/perl5/darwin-thread-multi-2level/DBI.pm
 line 2074.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 6.

Test Summary Report
---
t/api/1.1/deliveryservice/keys_url_sig.t (Wstat: 65280 Tests: 6 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
Files=1, Tests=6,  2 wallclock secs ( 0.02 usr  0.01 sys +  1.76 cusr  0.53 
csys =  2.32 CPU)
Result: FAIL


> DS URL sig key apis needs to have tenancy check in place
> 
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the 
> use_tenancy parameter but when activated it is used to limit the scope of 
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's 
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136907#comment-16136907
 ] 

ASF GitHub Bot commented on TC-535:
---

Github user mitchell852 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134509030
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm ---
@@ -69,14 +86,17 @@ sub copy_url_sig_keys {
else {
return $self->alert("Delivery Service to copy from 
'$copy_from_xml_id' does not exist.");
}
+   if (!$tenant_utils->is_ds_resource_accessible($tenants_data, 
$copy_rs->tenant_id)) {
+   return $self->forbidden("Forbidden. Source delivery-service 
tenant is not available to the user.");
+   }
my $copy_config_file = 
$self->url_sig_config_file_name($copy_from_xml_id);
 
my $helper = new Utils::Helper( { mojo => $self } );
my $url_sig_key_values_json;
 
#verify we can copy keys out
if ( $helper->is_valid_delivery_service($copy_ds_id) ) {
-   if ( $is_admin || 
$helper->is_delivery_service_assigned($copy_ds_id) ) {
+   if ( $is_admin || 
$helper->is_delivery_service_assigned($copy_ds_id) || 
$tenant_utils->use_tenancy()) {
--- End diff --

i see


> DS URL sig key apis needs to have tenancy check in place
> 
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the 
> use_tenancy parameter but when activated it is used to limit the scope of 
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's 
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136901#comment-16136901
 ] 

ASF GitHub Bot commented on TC-491:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/851
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/116/



> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation
> 
>
> Key: TC-491
> URL: https://issues.apache.org/jira/browse/TC-491
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Robert Scrimo
>Assignee: Jeremy Mitchell
>Priority: Critical
> Fix For: 2.1.0, 2.2.0
>
>
> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation.
> E.g.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
> key constraint "fk_job_deliveryservice1" on table "job"
> DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
> "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
> /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642
> Workaround: No UI/API end-point to delete the associated job.  Delete 
> associated job from database.
> NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136895#comment-16136895
 ] 

ASF GitHub Bot commented on TC-491:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/851
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/76/



> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation
> 
>
> Key: TC-491
> URL: https://issues.apache.org/jira/browse/TC-491
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0, 2.2.0
>Reporter: Robert Scrimo
>Assignee: Jeremy Mitchell
>Priority: Critical
> Fix For: 2.1.0, 2.2.0
>
>
> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation.
> E.g.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
> key constraint "fk_job_deliveryservice1" on table "job"
> DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
> "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
> /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642
> Workaround: No UI/API end-point to delete the associated job.  Delete 
> associated job from database.
> NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-483) TPv2 / TO API - make tenant a required field on delivery service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136863#comment-16136863
 ] 

ASF GitHub Bot commented on TC-483:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/850


> TPv2 / TO API - make tenant a required field on delivery service
> 
>
> Key: TC-483
> URL: https://issues.apache.org/jira/browse/TC-483
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops API, Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> Currently, the tenant_id on a delivery service create or update is optional 
> in the Traffic Portal and the TO API. This presents a risk because failure to 
> set the ds.tenant_id will allow all users to see that delivery service. This 
> may include users that should have no access to this delivery service.
> I suggest we make this a required field on create or update of a ds. At some 
> point tenancy will be required but in the interim tenancy can be turned off 
> using the use-tenancy=0 parameter. 
> If the desire is to not use tenancy, you can still set the ds.tenant = root 
> tenant (which is provided via seeds.sql) and use-tenancy=0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-520) TPv2 - add the ability to see all delivery services for each tenant

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136854#comment-16136854
 ] 

ASF GitHub Bot commented on TC-520:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/848


> TPv2 - add the ability to see all delivery services for each tenant
> ---
>
> Key: TC-520
> URL: https://issues.apache.org/jira/browse/TC-520
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops API, Traffic Portal
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Delivery services are grouped by tenant. Add the ability to see all ds's for 
> each tenant. This will help tenancy management.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-483) TPv2 / TO API - make tenant a required field on delivery service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136820#comment-16136820
 ] 

ASF GitHub Bot commented on TC-483:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/850
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/115/



> TPv2 / TO API - make tenant a required field on delivery service
> 
>
> Key: TC-483
> URL: https://issues.apache.org/jira/browse/TC-483
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops API, Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> Currently, the tenant_id on a delivery service create or update is optional 
> in the Traffic Portal and the TO API. This presents a risk because failure to 
> set the ds.tenant_id will allow all users to see that delivery service. This 
> may include users that should have no access to this delivery service.
> I suggest we make this a required field on create or update of a ds. At some 
> point tenancy will be required but in the interim tenancy can be turned off 
> using the use-tenancy=0 parameter. 
> If the desire is to not use tenancy, you can still set the ds.tenant = root 
> tenant (which is provided via seeds.sql) and use-tenancy=0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-483) TPv2 / TO API - make tenant a required field on delivery service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136818#comment-16136818
 ] 

ASF GitHub Bot commented on TC-483:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/850
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/75/



> TPv2 / TO API - make tenant a required field on delivery service
> 
>
> Key: TC-483
> URL: https://issues.apache.org/jira/browse/TC-483
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops API, Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> Currently, the tenant_id on a delivery service create or update is optional 
> in the Traffic Portal and the TO API. This presents a risk because failure to 
> set the ds.tenant_id will allow all users to see that delivery service. This 
> may include users that should have no access to this delivery service.
> I suggest we make this a required field on create or update of a ds. At some 
> point tenancy will be required but in the interim tenancy can be turned off 
> using the use-tenancy=0 parameter. 
> If the desire is to not use tenancy, you can still set the ds.tenant = root 
> tenant (which is provided via seeds.sql) and use-tenancy=0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-483) TPv2 / TO API - make tenant a required field on delivery service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136816#comment-16136816
 ] 

ASF GitHub Bot commented on TC-483:
---

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/850

[TC-483] - TPv2 - marks tenant as required for users and delivery services



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
tc-483-tp-tenant-required

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/850.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #850


commit 5cbebeb0fe38e0e27157559f06e665662b648512
Author: Jeremy Mitchell 
Date:   2017-08-22T13:45:58Z

marks tenant as required for users and delivery services




> TPv2 / TO API - make tenant a required field on delivery service
> 
>
> Key: TC-483
> URL: https://issues.apache.org/jira/browse/TC-483
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops API, Traffic Portal
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> Currently, the tenant_id on a delivery service create or update is optional 
> in the Traffic Portal and the TO API. This presents a risk because failure to 
> set the ds.tenant_id will allow all users to see that delivery service. This 
> may include users that should have no access to this delivery service.
> I suggest we make this a required field on create or update of a ds. At some 
> point tenancy will be required but in the interim tenancy can be turned off 
> using the use-tenancy=0 parameter. 
> If the desire is to not use tenancy, you can still set the ds.tenant = root 
> tenant (which is provided via seeds.sql) and use-tenancy=0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-545) CRConfig should not list teak nodes as edges

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136703#comment-16136703
 ] 

ASF GitHub Bot commented on TC-545:
---

Github user dg4prez commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/845
  
Don't merge this, because I'm a dummy.


> CRConfig should not list teak nodes as edges
> 
>
> Key: TC-545
> URL: https://issues.apache.org/jira/browse/TC-545
> Project: Traffic Control
>  Issue Type: Improvement
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Derek Gelinas
>Assignee: Derek Gelinas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-187) Update delivery service makes SSL keys invalid

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136581#comment-16136581
 ] 

ASF GitHub Bot commented on TC-187:
---

Github user zhilhuan commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/360#discussion_r134432509
  
--- Diff: traffic_ops/app/lib/UI/DeliveryService.pm ---
@@ -152,12 +153,7 @@ sub get_example_urls {
}
}
elsif ( $re->{type} eq 'PATH_REGEXP' ) {
-   if ( defined( $example_urls[ $re->{set_number} 
] ) ) {
-   $example_urls[ $re->{set_number} ] .= 
$re->{pattern};
-   }
-   else {
-   $example_urls[ $re->{set_number} ] = 
$re->{pattern};
-   }
+   push(@example_urls, $re->{pattern});
--- End diff --

It messed up when both "HOST_REGEXP" and "PATH_REGEXP" configured. Root 
cause:

1. Duplicated "set_number" is not allowed in DS configuration in GUI. So 
not "PATH_REGEXP" will share the same "set_number" with "HOST_REGEXP".
2. "$re->{set_number}" is not the index of "@example_urls". See the "push( 
@example_urls, $https_url );" code above. So "$example_urls[ $re->{set_number} 
] .= $re->{pattern};" may mess up with any other "HOST_REGEXP".


> Update delivery service makes SSL keys invalid
> --
>
> Key: TC-187
> URL: https://issues.apache.org/jira/browse/TC-187
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>  Labels: ssl, xml-id
>
> Modify xml-id or subdomain in a https delivery service will make existing SSL 
> keys invalid.
> And there is problem to generate keys if using "http and https" together with 
> 1 host_regex, and 1 path_regex.
> BTW, the certificate returned by RESTful API is not consistent with that GUI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-187) Update delivery service makes SSL keys invalid

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136584#comment-16136584
 ] 

ASF GitHub Bot commented on TC-187:
---

Github user zhilhuan commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/360#discussion_r134435019
  
--- Diff: traffic_ops/app/lib/UI/SslKeys.pm ---
@@ -75,6 +75,34 @@ sub add {
}
 }
 
+sub update_sslkey {
+   my $self = shift;
+   my $ds_id = shift;
+   my $xml_id = shift;
+   my $hostname = shift;
+   my $response_container = $self->riak_get( 'ssl', "ds_$ds_id-latest");
--- End diff --

will use xml_id instead in TC-547.


> Update delivery service makes SSL keys invalid
> --
>
> Key: TC-187
> URL: https://issues.apache.org/jira/browse/TC-187
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Reporter: Zhilin Huang
>Assignee: Zhilin Huang
>  Labels: ssl, xml-id
>
> Modify xml-id or subdomain in a https delivery service will make existing SSL 
> keys invalid.
> And there is problem to generate keys if using "http and https" together with 
> 1 host_regex, and 1 path_regex.
> BTW, the certificate returned by RESTful API is not consistent with that GUI.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)