[jira] [Commented] (ZOOKEEPER-3727) Fix 3.5 source tarball to represent the git repository
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096330#comment-17096330 ] Hadoop QA commented on ZOOKEEPER-3727: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4452//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4452//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4452//console This message is automatically generated. > Fix 3.5 source tarball to represent the git repository > -- > > Key: ZOOKEEPER-3727 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3727 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Norbert Kalmár >Assignee: Mate Szalay-Beko >Priority: Major > Fix For: 3.5.8 > > Time Spent: 10m > Remaining Estimate: 0h > > There are some difference in the source tarball for recent 3.5 releases, like: > - Info.java file in zookeeper-server (generated class) > - checkstyle.xml is missing > - git.properties file present in tarball > - missing .gitattributes and .gitignore (the question is should these be even > included?) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3355) Remove 'tbd' From Docs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095306#comment-17095306 ] Hadoop QA commented on ZOOKEEPER-3355: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4451//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4451//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4451//console This message is automatically generated. > Remove 'tbd' From Docs > -- > > Key: ZOOKEEPER-3355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3355 > Project: ZooKeeper > Issue Type: Improvement > Components: documentation >Affects Versions: 3.5.4, 3.6.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0, 3.5.8 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > For years, there have been lots of 'tbd' recorded in the documentation. It > does not look very polished and there is no one working on these. I think > it's time to finally remove them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3357) Remove Dead Link from ZooKeeper Programmer's Guide
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095259#comment-17095259 ] Hadoop QA commented on ZOOKEEPER-3357: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4448//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4448//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4448//console This message is automatically generated. > Remove Dead Link from ZooKeeper Programmer's Guide > -- > > Key: ZOOKEEPER-3357 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3357 > Project: ZooKeeper > Issue Type: Improvement > Components: documentation >Affects Versions: 3.5.4, 3.6.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Trivial > Labels: pull-request-available > Fix For: 3.7.0, 3.5.8 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Remove dead link to _ZooKeeper Talk at the Hadoup Summit 2008_ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3751) upgrade jackson-databind to 2.10 from 2.9
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094633#comment-17094633 ] Hadoop QA commented on ZOOKEEPER-3751: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4443//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4443//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4443//console This message is automatically generated. > upgrade jackson-databind to 2.10 from 2.9 > - > > Key: ZOOKEEPER-3751 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3751 > Project: ZooKeeper > Issue Type: Task > Components: security >Affects Versions: 3.6.0, 3.5.7, 3.7.0 >Reporter: Patrick D. Hunt >Assignee: Patrick D. Hunt >Priority: Critical > Labels: pull-request-available > Fix For: 3.7.0, 3.6.1 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Upgrade jackson-databind to 2.10 form 2.9. 2.10 is the current latest > version. Also we've been seeing lots of vulnerability reports with 2.9 - > perhaps this will help. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3739) Remove use of com.sun.nio.file.SensitivityWatchEventModifier
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094525#comment-17094525 ] Hadoop QA commented on ZOOKEEPER-3739: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4439//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4439//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4439//console This message is automatically generated. > Remove use of com.sun.nio.file.SensitivityWatchEventModifier > > > Key: ZOOKEEPER-3739 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3739 > Project: ZooKeeper > Issue Type: Bug > Components: build, server >Reporter: Christopher Tubbs >Assignee: Christopher Tubbs >Priority: Major > Labels: pull-request-available > Fix For: 3.7.0, 3.6.1 > > Time Spent: 2.5h > Remaining Estimate: 0h > > For better support building on newer JDKs, the unsupported class, > com.sun.nio.file.SensitivityWatchEventModifier, must not be used. > I will submit a PR for this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-2307) ZooKeeper not starting because acceptedEpoch is less than the currentEpoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094406#comment-17094406
]
Hadoop QA commented on ZOOKEEPER-2307:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4436//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4436//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4436//console
This message is automatically generated.
> ZooKeeper not starting because acceptedEpoch is less than the currentEpoch
> --
>
> Key: ZOOKEEPER-2307
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2307
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2307-01.patch, ZOOKEEPER-2307-02.patch,
> ZOOKEEPER-2307-03.patch, ZOOKEEPER-2307-04.patch
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> This issue occurred in one of our test environment where disk was being
> changed to read only very frequently.
> The the scenario is as follows:
> # Configure three node ZooKeeper cluster, lets say nodes are A, B and C
> # Start A and B. Both A and B start successfully, quorum is running.
> # Start C, because of IO error C fails to update acceptedEpoch file. But C
> also starts successfully, joins the quorum as follower
> # Stop C
> # Start C, bellow exception with message "The accepted epoch, 0 is less than
> the current epoch, 1" is thrown
> {code}
> 2015-10-29 16:52:32,942 [myid:3] - ERROR [main:QuorumPeer@784] - Unable to
> load database on disk
> java.io.IOException: The accepted epoch, 0 is less than the current epoch, 1
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:781)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:720)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:202)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:139)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:88)
> 2015-10-29 16:52:32,946 [myid:3] - ERROR [main:QuorumPeerMain@111] -
> Unexpected exception, exiting abnormally
> java.lang.RuntimeException: Unable to run quorum server
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:785)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:720)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:202)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:139)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:88)
> Caused by: java.io.IOException: The accepted epoch, 0 is less than the
> current epoch, 1
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:781)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-2307) ZooKeeper not starting because acceptedEpoch is less than the currentEpoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094322#comment-17094322
]
Hadoop QA commented on ZOOKEEPER-2307:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4432//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4432//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4432//console
This message is automatically generated.
> ZooKeeper not starting because acceptedEpoch is less than the currentEpoch
> --
>
> Key: ZOOKEEPER-2307
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2307
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2307-01.patch, ZOOKEEPER-2307-02.patch,
> ZOOKEEPER-2307-03.patch, ZOOKEEPER-2307-04.patch
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> This issue occurred in one of our test environment where disk was being
> changed to read only very frequently.
> The the scenario is as follows:
> # Configure three node ZooKeeper cluster, lets say nodes are A, B and C
> # Start A and B. Both A and B start successfully, quorum is running.
> # Start C, because of IO error C fails to update acceptedEpoch file. But C
> also starts successfully, joins the quorum as follower
> # Stop C
> # Start C, bellow exception with message "The accepted epoch, 0 is less than
> the current epoch, 1" is thrown
> {code}
> 2015-10-29 16:52:32,942 [myid:3] - ERROR [main:QuorumPeer@784] - Unable to
> load database on disk
> java.io.IOException: The accepted epoch, 0 is less than the current epoch, 1
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:781)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:720)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:202)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:139)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:88)
> 2015-10-29 16:52:32,946 [myid:3] - ERROR [main:QuorumPeerMain@111] -
> Unexpected exception, exiting abnormally
> java.lang.RuntimeException: Unable to run quorum server
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:785)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:720)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:202)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:139)
> at
> org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:88)
> Caused by: java.io.IOException: The accepted epoch, 0 is less than the
> current epoch, 1
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:781)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3780) restore Version.getRevision() to be backward compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077547#comment-17077547 ] Hadoop QA commented on ZOOKEEPER-3780: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4396//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4396//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4396//console This message is automatically generated. > restore Version.getRevision() to be backward compatible > --- > > Key: ZOOKEEPER-3780 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3780 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.6.0, 3.5.6, 3.5.7 >Reporter: Norbert Kalmár >Assignee: Norbert Kalmár >Priority: Critical > Labels: pull-request-available > Fix For: 3.7.0, 3.6.1, 3.5.8 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > We removed the getRevision() function in 3.5.6: > https://github.com/apache/zookeeper/commit/96880c0b2ba39f1841f8bdc4a0119a467b462d03#diff-1d42dde48d42e3baf819e22b56a880a7 > Some projects (like HBase for example) are actually using this method. > (Although not relevant anymore, since we are on git). > 3.5.6, 3.5.7 and 3.6.0 does not have this method anymore. However, if someone > is using this function, to make upgrading easier, we should restore it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3716) upgrade netty 4.1.42 to address CVE-2019-20444 CVE-2019-20445
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029515#comment-17029515 ] Hadoop QA commented on ZOOKEEPER-3716: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4344//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4344//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4344//console This message is automatically generated. > upgrade netty 4.1.42 to address CVE-2019-20444 CVE-2019-20445 > - > > Key: ZOOKEEPER-3716 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3716 > Project: ZooKeeper > Issue Type: Bug > Components: security, server >Affects Versions: 3.6.0, 3.5.6, 3.7.0 >Reporter: Patrick D. Hunt >Assignee: Patrick D. Hunt >Priority: Blocker > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > OWASP dependency-check is failing > upgrade netty 4.1.42 to address CVE-2019-20444 CVE-2019-20445 > [ERROR] netty-transport-4.1.42.Final.jar: CVE-2019-20445, CVE-2019-20444 > We need to upgrade to netty 4.1.45 (current latest) or later -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3701) Split brain on log disk full
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025973#comment-17025973
]
Hadoop QA commented on ZOOKEEPER-3701:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4337//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4337//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4337//console
This message is automatically generated.
> Split brain on log disk full
>
>
> Key: ZOOKEEPER-3701
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3701
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.13, 3.5.6
>Reporter: Ivan Kelly
>Assignee: Andor Molnar
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 6h
> Remaining Estimate: 0h
>
> We ran into a situation where the cluster ended up with split brain when the
> log disk filled up on a node.
> The ZK cluster(3 node) in question was being used as the metadata store for
> Pulsar. There was an outage in the Pulsar cluster, where two the ZK nodes
> filled up there log disks, causing the cluster to lose quorum. Once we
> rectified the full disk situation and restarted the nodes everything seemed
> to work, but we started getting a lot of log messages about
> UpdateMetadataLoop retrying. UpdateMetadataLoop is used to update bookkeeper
> ledger metadata. If it sees a write conflict it rereads the znode, checks
> whether the update needs to happen, applies it and writes. These retries were
> flooding the log on a subset of the brokers. It turned out that it was
> reading a znode with version 0, but when it tried the setData with version
> set to 0 it was failing because the znode had a version of 2 (there were many
> instances of this). After investigating this, we saw that the znode had a
> different stat and value on ZK-1 to that on ZK-0 & ZK-2.
> We resolved the situation by deleting the log and snapshots from ZK-1 and
> restarting, at which point everything went back to normal. Had ZK-1 managed
> to become leader we would have been in a lot of trouble, but thankfully this
> didn't happen.
> For the sequence of events that led to split brain, I'll refer to the
> following code.
> {code}
> public class FileTxnSnapLog {
> ...
> public boolean truncateLog(long zxid) throws IOException {
> // close the existing txnLog and snapLog
> close();
> // truncate it
> FileTxnLog truncLog = new FileTxnLog(dataDir);
> boolean truncated = truncLog.truncate(zxid);
> truncLog.close();
> // re-open the txnLog and snapLog
> // I'd rather just close/reopen this object itself, however that
> // would have a big impact outside ZKDatabase as there are other
> // objects holding a reference to this object.
> txnLog = new FileTxnLog(dataDir);
> snapLog = new FileSnap(snapDir);
> return truncated;
> }
> public void close() throws IOException {
> txnLog.close();
> snapLog.close();
> }
> }
> public class FileSnap implements SnapShot {
> ...
> public synchronized void serialize(DataTree dt, Map
> sessions, File snapShot)
> throws IOException {
> if (!close) {
> // actual snapshot code
> }
> }
> @Override
> public synchronized void close() throws IOException {
> close = true;
> }
> }
> {code}
> The sequence of events that lead to the failure are:
> | 2020-01-04 01:56:56Z | ZK-2 fails to write to its transaction log due to
> disk full. ZK-2 is still participating in leader election. ZK-2 becomes a
> follower of ZK-1. ZK-1 sends TRUNC to ZK-2. truncLog.truncate on ZK-2 throws
> an exception because of the disk being full, and leaves the process in a
> broken state. |
> |2020-01-04 02:35:23Z | ZK-2 removes 9 transaction logs from disk (bringing
> it from 100% to 19%). It doesn't recover because its in a broken state. |
[jira] [Commented] (ZOOKEEPER-3638) Update Jetty to 9.4.24.v20191120
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008932#comment-17008932 ] Hadoop QA commented on ZOOKEEPER-3638: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4313//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4313//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4313//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4313//console This message is automatically generated. > Update Jetty to 9.4.24.v20191120 > > > Key: ZOOKEEPER-3638 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3638 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Major > Labels: pull-request-available > Fix For: 3.5.7, 3.7.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Jetty should be updated to the latest version (9.4.24.v20191120) to pick up > some CVE fixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3539) Fix branch-3.5 after upgrade on ASF CI
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997266#comment-16997266 ] Hadoop QA commented on ZOOKEEPER-3539: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4299//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4299//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4299//console This message is automatically generated. > Fix branch-3.5 after upgrade on ASF CI > -- > > Key: ZOOKEEPER-3539 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3539 > Project: ZooKeeper > Issue Type: Task > Components: build, build-infrastructure >Affects Versions: 3.5.5 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Blocker > Labels: pull-request-available > Fix For: 3.5.6 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > ASF CI now lacks "findbugs" tool. > ASF CI upgraded gcc and now there are some errors related to the usage of > NULL in calls of fprintf. > We should: > - disable findbugs on CI ant-based tasks > - use LOG_DEBUG consistently with the rest of code in C client > Please note that on branch-3.5 we are officially using Maven and Spotbugs, > ant stuff is there only for compatibility in build, findbugs is not strictly > needed to check the goodness of code in branch-3.5. > branch-3.4 is only with ANT, let's treat this problem as a different task -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3388) Allow client port to support plaintext and encrypted connections simultaneously
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997188#comment-16997188 ] Hadoop QA commented on ZOOKEEPER-3388: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4297//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4297//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4297//console This message is automatically generated. > Allow client port to support plaintext and encrypted connections > simultaneously > --- > > Key: ZOOKEEPER-3388 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3388 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 4h 10m > Remaining Estimate: 0h > > ZOOKEEPER-2125 extended the ZooKeeper server-side to handle encrypted client > connections by allowing the server to open a second client port (the secure > client port) to manage this new style of traffic. A server is able to handle > plaintext and encrypted clients simultaneously by managing each on their > respective ports. > When it comes time to get all clients connecting to your system to start > using encryption, this approach requires that they make two changes > simultaneously: altering their client properties to start use the secure > settings and altering the routing information that they provide in order to > know where to connect with the ensemble. If either is misconfigured then the > client is cut off from the ensemble. With a large deployment of clients that > are owned by a different teams and different tools, this presents a danger in > activating the feature. Ideally, the two changes could be staggered so that > first the encryption feature is activated and then the routing information is > changed in a subsequent phase. > Allow the server connection factory managing the regular client port to > handle both plaintext and encrypted connections. This will be independent of > the operation of the server connection factory managing the secure client > port but similar settings ought to apply to both (e.g. cipher suites) to > maintain inter compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3644) Data loss after upgrading standalone ZK server 3.4.14 to 3.5.6 with snapshot.trust.empty=true
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997014#comment-16997014
]
Hadoop QA commented on ZOOKEEPER-3644:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4295//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4295//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4295//console
This message is automatically generated.
> Data loss after upgrading standalone ZK server 3.4.14 to 3.5.6 with
> snapshot.trust.empty=true
> -
>
> Key: ZOOKEEPER-3644
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3644
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.5.6
>Reporter: Manikumar
>Assignee: Michael Han
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We have tried to upgrade single node *standalone* ZK server from 3.4.14 to
> 3.5.6. There were no snapshot files, so as suggested in ZOOKEEPER-3056, we
> have set snapshot.trust.empty to true. After server startup, when we tried to
> list the znodes, we found that znodes are missing.
> Steps to reproduce:
> # Start a single node ZK 3.4.14 server and create few znodes
> # Upgrade the server to 3.5.6 with snapshot.trust.empty=true config
> # try to list the znodes using zkShell
> Looking into the [source
> code|https://github.com/apache/zookeeper/blob/release-3.5.6/zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java#L224],
> looks like we are not reading transaction log if there are no snapshot files
> and snapshot.trust.empty is set to true.
> ZK 3.5.6 logs:
> {quote}[2019-12-07 12:13:35,007] INFO Created server with tickTime 3000
> minSessionTimeout 6000 maxSessionTimeout 6 datadir
> /var/lib/zookeeper/version-2 snapdir /var/lib/zookeeper/version-2
> (org.apache.zookeeper.server.ZooKeeperServer)
> [2019-12-07 12:13:35,012] INFO Using
> org.apache.zookeeper.server.NIOServerCnxnFactory as server connection factory
> (org.apache.zookeeper.server.ServerCnxnFactory)
> [2019-12-07 12:13:35,014] INFO Configuring NIO connection handler with 10s
> sessionless connection timeout, 1 selector thread(s), 12 worker threads, and
> 64 kB direct buffers. (org.apache
> .zookeeper.server.NIOServerCnxnFactory)
> [2019-12-07 12:13:35,017] INFO binding to port
> [0.0.0.0/0.0.0.0:2181|http://0.0.0.0/0.0.0.0:2181]
> (org.apache.zookeeper.server.NIOServerCnxnFactory)
> [2019-12-07 12:13:35,027] INFO zookeeper.snapshotSizeFactor = 0.33
> (org.apache.zookeeper.server.ZKDatabase)
> [2019-12-07 12:13:35,029] DEBUG Created new input stream
> /var/lib/zookeeper/version-2/log.1
> (org.apache.zookeeper.server.persistence.FileTxnLog)
> [2019-12-07 12:13:35,031] DEBUG Created new input archive
> /var/lib/zookeeper/version-2/log.1
> (org.apache.zookeeper.server.persistence.FileTxnLog)
> [2019-12-07 12:13:35,035] DEBUG EOF exception java.io.EOFException: Failed
> to read /var/lib/zookeeper/version-2/log.1
> (org.apache.zookeeper.server.persistence.FileTxnLog)
> [2019-12-07 12:13:35,035] WARN No snapshot found, but there are log entries.
> This should only be allowed during upgrading.
> (org.apache.zookeeper.server.persistence.FileTxnSnapLog)
> [2019-12-07 12:13:35,035] INFO Snapshotting: 0x0 to
> /var/lib/zookeeper/version-2/snapshot.0
> (org.apache.zookeeper.server.persistence.FileTxnSnapLog)
> [2019-12-07 12:13:35,036] INFO Snapshotting: 0x0 to
> /var/lib/zookeeper/version-2/snapshot.0
> (org.apache.zookeeper.server.persistence.FileTxnSnapLog)
> [2019-12-07 12:13:35,050] INFO Using checkIntervalMs=6
> maxPerMinute=1 (org.apache.zookeeper.server.ContainerManager)
> [2019-12-07 12:15:07,137] DEBUG Accepted socket connection from
> /[127.0.0.1:3|http://127.0.0.1:3/]
> (org.apache.zookeeper.server.NIOServerCnxnFacto
[jira] [Commented] (ZOOKEEPER-3388) Allow client port to support plaintext and encrypted connections simultaneously
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993553#comment-16993553 ] Hadoop QA commented on ZOOKEEPER-3388: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4291//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4291//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4291//console This message is automatically generated. > Allow client port to support plaintext and encrypted connections > simultaneously > --- > > Key: ZOOKEEPER-3388 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3388 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3.5h > Remaining Estimate: 0h > > ZOOKEEPER-2125 extended the ZooKeeper server-side to handle encrypted client > connections by allowing the server to open a second client port (the secure > client port) to manage this new style of traffic. A server is able to handle > plaintext and encrypted clients simultaneously by managing each on their > respective ports. > When it comes time to get all clients connecting to your system to start > using encryption, this approach requires that they make two changes > simultaneously: altering their client properties to start use the secure > settings and altering the routing information that they provide in order to > know where to connect with the ensemble. If either is misconfigured then the > client is cut off from the ensemble. With a large deployment of clients that > are owned by a different teams and different tools, this presents a danger in > activating the feature. Ideally, the two changes could be staggered so that > first the encryption feature is activated and then the routing information is > changed in a subsequent phase. > Allow the server connection factory managing the regular client port to > handle both plaintext and encrypted connections. This will be independent of > the operation of the server connection factory managing the secure client > port but similar settings ought to apply to both (e.g. cipher suites) to > maintain inter compatibility. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3539) Fix branch-3.5 after upgrade on ASF CI
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985066#comment-16985066 ] Hadoop QA commented on ZOOKEEPER-3539: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4277//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4277//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4277//console This message is automatically generated. > Fix branch-3.5 after upgrade on ASF CI > -- > > Key: ZOOKEEPER-3539 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3539 > Project: ZooKeeper > Issue Type: Task > Components: build, build-infrastructure >Affects Versions: 3.5.5 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Blocker > Labels: pull-request-available > Fix For: 3.5.6 > > Time Spent: 2h > Remaining Estimate: 0h > > ASF CI now lacks "findbugs" tool. > ASF CI upgraded gcc and now there are some errors related to the usage of > NULL in calls of fprintf. > We should: > - disable findbugs on CI ant-based tasks > - use LOG_DEBUG consistently with the rest of code in C client > Please note that on branch-3.5 we are officially using Maven and Spotbugs, > ant stuff is there only for compatibility in build, findbugs is not strictly > needed to check the goodness of code in branch-3.5. > branch-3.4 is only with ANT, let's treat this problem as a different task -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3627) Update Jackson to 2.9.10.1 and the Owasp plugin to 5.2.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981609#comment-16981609 ] Hadoop QA commented on ZOOKEEPER-3627: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4269//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4269//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4269//console This message is automatically generated. > Update Jackson to 2.9.10.1 and the Owasp plugin to 5.2.4 > > > Key: ZOOKEEPER-3627 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3627 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.7 > > Time Spent: 2h > Remaining Estimate: 0h > > Jackson databind should be updated to 2.9.10.1 to pick up a CVE fix. This > task also includes updating the owasp maven plugin to the latest version, > which helps to detect CVE issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3627) Update Jackson to 2.9.10.1 and the Owasp plugin to 5.2.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981436#comment-16981436 ] Hadoop QA commented on ZOOKEEPER-3627: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4267//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4267//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4267//console This message is automatically generated. > Update Jackson to 2.9.10.1 and the Owasp plugin to 5.2.4 > > > Key: ZOOKEEPER-3627 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3627 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.7 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Jackson databind should be updated to 2.9.10.1 to pick up a CVE fix. This > task also includes updating the owasp maven plugin to the latest version, > which helps to detect CVE issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943825#comment-16943825 ] Hadoop QA commented on ZOOKEEPER-1260: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4189//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4189//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4189//console This message is automatically generated. > Audit logging in ZooKeeper servers. > --- > > Key: ZOOKEEPER-1260 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Reporter: Mahadev Konar >Assignee: Mohammad Arshad >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.7 > > Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf > > Time Spent: 5h 20m > Remaining Estimate: 0h > > Lots of users have had questions on debugging which client changed what znode > and what updates went through a znode. We should add audit logging as in > Hadoop (look at Namenode Audit logging) to log which client changed what in > the zookeeper servers. This could just be a log4j audit logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943051#comment-16943051 ] Hadoop QA commented on ZOOKEEPER-1260: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4180//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4180//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4180//console This message is automatically generated. > Audit logging in ZooKeeper servers. > --- > > Key: ZOOKEEPER-1260 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Reporter: Mahadev Konar >Assignee: Mohammad Arshad >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.7 > > Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Lots of users have had questions on debugging which client changed what znode > and what updates went through a znode. We should add audit logging as in > Hadoop (look at Namenode Audit logging) to log which client changed what in > the zookeeper servers. This could just be a log4j audit logger. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3563) dependency check failing on 3.4 and 3.5 branches - CVE-2019-16869 on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942041#comment-16942041 ] Hadoop QA commented on ZOOKEEPER-3563: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4175//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4175//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4175//console This message is automatically generated. > dependency check failing on 3.4 and 3.5 branches - CVE-2019-16869 on Netty > -- > > Key: ZOOKEEPER-3563 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3563 > Project: ZooKeeper > Issue Type: Bug > Components: security >Affects Versions: 3.5.5, 3.4.14 >Reporter: Patrick D. Hunt >Priority: Blocker > Labels: pull-request-available > Fix For: 3.4.15, 3.5.6 > > Time Spent: 40m > Remaining Estimate: 0h > > The mvn dependency check is failing on 3.4 and 3.5: > 3.4: > [ERROR] netty-3.10.6.Final.jar: CVE-2019-16869 > 3.5: > [ERROR] netty-transport-4.1.29.Final.jar: CVE-2019-16869 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3563) dependency check failing on 3.4 and 3.5 branches - CVE-2019-16869 on Netty
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941421#comment-16941421 ] Hadoop QA commented on ZOOKEEPER-3563: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4169//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4169//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4169//console This message is automatically generated. > dependency check failing on 3.4 and 3.5 branches - CVE-2019-16869 on Netty > -- > > Key: ZOOKEEPER-3563 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3563 > Project: ZooKeeper > Issue Type: Bug > Components: security >Affects Versions: 3.5.5, 3.4.14 >Reporter: Patrick D. Hunt >Priority: Blocker > Labels: pull-request-available > Fix For: 3.4.15, 3.5.6 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The mvn dependency check is failing on 3.4 and 3.5: > 3.4: > [ERROR] netty-3.10.6.Final.jar: CVE-2019-16869 > 3.5: > [ERROR] netty-transport-4.1.29.Final.jar: CVE-2019-16869 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3496) Transaction larger than jute.maxbuffer makes ZooKeeper unavailable
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937045#comment-16937045
]
Hadoop QA commented on ZOOKEEPER-3496:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4152//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4152//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4152//console
This message is automatically generated.
> Transaction larger than jute.maxbuffer makes ZooKeeper unavailable
> --
>
> Key: ZOOKEEPER-3496
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3496
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.5, 3.4.14
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Critical
> Labels: pull-request-available
> Fix For: 3.6.0, 3.4.15, 3.5.7
>
> Attachments: ZOOKEEPER-3496-001.patch
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> *Problem:*
> ZooKeeper server fails to start, logs following error
> {code:java}
> Exception in thread "main" java.io.IOException: Unreasonable length = 1001025
> at
> org.apache.jute.BinaryInputArchive.checkLength(BinaryInputArchive.java:127)
> at
> org.apache.jute.BinaryInputArchive.readBuffer(BinaryInputArchive.java:92)
> {code}
> This indicates that one of the transactions size is more than the configured
> jute.maxbuffer values. But how transaction more than jute.maxbuffer size is
> allowed to write?
> *Analysis:*
> At ZooKeeper server jute.maxbuffer specifies the maximum size of a
> transaction. By default it is 1 MB at the server
> jute.maxbuffer is used for following:
> # Size sanity check of incoming request. Incoming requests size must not be
> more than jute.maxbuffer
> # Size sanity check of the transaction while reading from transaction or
> snapshot file. Transaction size must not be more than jute.maxbuffer+1024
> # Size sanity check of transaction while reading data from the leader.
> Transaction size must not be more than jute.maxbuffer+1024
> Request size sanity check is done in the beginning of a request processing
> but later request processing adds additional information into request then
> writes to transaction file. This additional information size is not
> considered in sanity check. This is how transaction larger than
> jute.maxbuffer are accepted into ZooKeeper.
> If this additional information size is less than 1024 Bytes then it is OK as
> ZooKeeper already takes care of it.
> But if this additional information size is more than 1024 bytes it allows the
> request, But while reading from transaction/snapshot file and while reading
> from leader it fails and make the ZooKeeper service unavailable
> +Example:+
> Suppose incoming request size is 100 Bytes
> Configured jute.maxbuffer is 100
> After processing the request ZooKeeper server adds 1025 more bytes
> In this case, request will be processed successfully, and 100+1025 bytes
> will be written to transaction file
> But while reading from the transaction log 100+1025 bytes cannot be read
> as max allowed length is 100(effectively 100+1024).
> *Solutions:*
> If incoming request size sanity check is done after populating all additional
> information then this problem is solved. But doing sanity check in the later
> stage of request processing will defeat the purpose of sanity check itself.
> So this we can not do
> Currently additional information size is constant 1024 Bytes [Code
> Reference|https://github.com/apache/zookeeper/blob/branch-3.5/zookeeper-jute/src/main/java/org/apache/jute/BinaryInputArchive.java#L126].
> We should increase this value and make it more reasonable. I propose to make
> this additional information size to same as the jute.maxbuffer. Also make
> additional information size configurable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3496) Transaction larger than jute.maxbuffer makes ZooKeeper unavailable
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936131#comment-16936131
]
Hadoop QA commented on ZOOKEEPER-3496:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4150//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4150//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4150//console
This message is automatically generated.
> Transaction larger than jute.maxbuffer makes ZooKeeper unavailable
> --
>
> Key: ZOOKEEPER-3496
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3496
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.5, 3.4.14
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Critical
> Labels: pull-request-available
> Fix For: 3.6.0, 3.4.15, 3.5.7
>
> Attachments: ZOOKEEPER-3496-001.patch
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> *Problem:*
> ZooKeeper server fails to start, logs following error
> {code:java}
> Exception in thread "main" java.io.IOException: Unreasonable length = 1001025
> at
> org.apache.jute.BinaryInputArchive.checkLength(BinaryInputArchive.java:127)
> at
> org.apache.jute.BinaryInputArchive.readBuffer(BinaryInputArchive.java:92)
> {code}
> This indicates that one of the transactions size is more than the configured
> jute.maxbuffer values. But how transaction more than jute.maxbuffer size is
> allowed to write?
> *Analysis:*
> At ZooKeeper server jute.maxbuffer specifies the maximum size of a
> transaction. By default it is 1 MB at the server
> jute.maxbuffer is used for following:
> # Size sanity check of incoming request. Incoming requests size must not be
> more than jute.maxbuffer
> # Size sanity check of the transaction while reading from transaction or
> snapshot file. Transaction size must not be more than jute.maxbuffer+1024
> # Size sanity check of transaction while reading data from the leader.
> Transaction size must not be more than jute.maxbuffer+1024
> Request size sanity check is done in the beginning of a request processing
> but later request processing adds additional information into request then
> writes to transaction file. This additional information size is not
> considered in sanity check. This is how transaction larger than
> jute.maxbuffer are accepted into ZooKeeper.
> If this additional information size is less than 1024 Bytes then it is OK as
> ZooKeeper already takes care of it.
> But if this additional information size is more than 1024 bytes it allows the
> request, But while reading from transaction/snapshot file and while reading
> from leader it fails and make the ZooKeeper service unavailable
> +Example:+
> Suppose incoming request size is 100 Bytes
> Configured jute.maxbuffer is 100
> After processing the request ZooKeeper server adds 1025 more bytes
> In this case, request will be processed successfully, and 100+1025 bytes
> will be written to transaction file
> But while reading from the transaction log 100+1025 bytes cannot be read
> as max allowed length is 100(effectively 100+1024).
> *Solutions:*
> If incoming request size sanity check is done after populating all additional
> information then this problem is solved. But doing sanity check in the later
> stage of request processing will defeat the purpose of sanity check itself.
> So this we can not do
> Currently additional information size is constant 1024 Bytes [Code
> Reference|https://github.com/apache/zookeeper/blob/branch-3.5/zookeeper-jute/src/main/java/org/apache/jute/BinaryInputArchive.java#L126].
> We should increase this value and make it more reasonable. I propose to make
> this additional information size to same as the jute.maxbuffer. Also make
> additional information size configurable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3496) Transaction larger than jute.maxbuffer makes ZooKeeper unavailable
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934358#comment-16934358
]
Hadoop QA commented on ZOOKEEPER-3496:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4148//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4148//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4148//console
This message is automatically generated.
> Transaction larger than jute.maxbuffer makes ZooKeeper unavailable
> --
>
> Key: ZOOKEEPER-3496
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3496
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.5, 3.4.14
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Critical
> Labels: pull-request-available
> Fix For: 3.6.0, 3.4.15, 3.5.7
>
> Attachments: ZOOKEEPER-3496-001.patch
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> *Problem:*
> ZooKeeper server fails to start, logs following error
> {code:java}
> Exception in thread "main" java.io.IOException: Unreasonable length = 1001025
> at
> org.apache.jute.BinaryInputArchive.checkLength(BinaryInputArchive.java:127)
> at
> org.apache.jute.BinaryInputArchive.readBuffer(BinaryInputArchive.java:92)
> {code}
> This indicates that one of the transactions size is more than the configured
> jute.maxbuffer values. But how transaction more than jute.maxbuffer size is
> allowed to write?
> *Analysis:*
> At ZooKeeper server jute.maxbuffer specifies the maximum size of a
> transaction. By default it is 1 MB at the server
> jute.maxbuffer is used for following:
> # Size sanity check of incoming request. Incoming requests size must not be
> more than jute.maxbuffer
> # Size sanity check of the transaction while reading from transaction or
> snapshot file. Transaction size must not be more than jute.maxbuffer+1024
> # Size sanity check of transaction while reading data from the leader.
> Transaction size must not be more than jute.maxbuffer+1024
> Request size sanity check is done in the beginning of a request processing
> but later request processing adds additional information into request then
> writes to transaction file. This additional information size is not
> considered in sanity check. This is how transaction larger than
> jute.maxbuffer are accepted into ZooKeeper.
> If this additional information size is less than 1024 Bytes then it is OK as
> ZooKeeper already takes care of it.
> But if this additional information size is more than 1024 bytes it allows the
> request, But while reading from transaction/snapshot file and while reading
> from leader it fails and make the ZooKeeper service unavailable
> +Example:+
> Suppose incoming request size is 100 Bytes
> Configured jute.maxbuffer is 100
> After processing the request ZooKeeper server adds 1025 more bytes
> In this case, request will be processed successfully, and 100+1025 bytes
> will be written to transaction file
> But while reading from the transaction log 100+1025 bytes cannot be read
> as max allowed length is 100(effectively 100+1024).
> *Solutions:*
> If incoming request size sanity check is done after populating all additional
> information then this problem is solved. But doing sanity check in the later
> stage of request processing will defeat the purpose of sanity check itself.
> So this we can not do
> Currently additional information size is constant 1024 Bytes [Code
> Reference|https://github.com/apache/zookeeper/blob/branch-3.5/zookeeper-jute/src/main/java/org/apache/jute/BinaryInputArchive.java#L126].
> We should increase this value and make it more reasonable. I propose to make
> this additional information size to same as the jute.maxbuffer. Also make
> additional information size configurable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3552) Source tarbal for branch-3.5 does not set execution permissions to "configure" file
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933729#comment-16933729 ] Hadoop QA commented on ZOOKEEPER-3552: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4146//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4146//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4146//console This message is automatically generated. > Source tarbal for branch-3.5 does not set execution permissions to > "configure" file > --- > > Key: ZOOKEEPER-3552 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3552 > Project: ZooKeeper > Issue Type: Bug > Components: build, c client >Affects Versions: 3.5.6 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Blocker > Labels: pull-request-available > Fix For: 3.5.6 > > Time Spent: 20m > Remaining Estimate: 0h > > During the Rc0 VOTE of 3.5.6 we found that the 'configure' file inside the > source tarball does not have the right permissions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ZOOKEEPER-3542) X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on machines with 2 cores
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928095#comment-16928095 ] Hadoop QA commented on ZOOKEEPER-3542: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4141//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4141//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4141//console This message is automatically generated. > X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on > machines with 2 cores > --- > > Key: ZOOKEEPER-3542 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3542 > Project: ZooKeeper > Issue Type: Test > Components: build, tests >Affects Versions: 3.5.5 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Critical > Labels: pull-request-available > Fix For: 3.5.6 > > Time Spent: 0.5h > Remaining Estimate: 0h > > On this Fedora machine: > [eolivelli@localhost zookeeper-server]$ uname -a > Linux localhost.localdomain 5.2.9-200.fc30.x86_64 #1 SMP Fri Aug 16 21:37:45 > UTC 2019 x86_64 x86_64 x86_64 GNU/Linux > [eolivelli@localhost zookeeper-server]$ mvn -v > Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; > 2019-08-27T17:06:16+02:00) > Maven home: /home/eolivelli/Scaricati/maven > Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: > /home/eolivelli/dev/jdk8u222-b10/jre > Default locale: it_IT, platform encoding: UTF-8 > OS name: "linux", version: "5.2.9-200.fc30.x86_64", arch: "amd64", family: > "unix" > [eolivelli@localhost zookeeper-server]$ cat /proc/cpuinfo > processor : 0 > vendor_id : AuthenticAMD > cpu family: 21 > model : 112 > model name: AMD A9-9410 RADEON R5, 5 COMPUTE CORES 2C+3G > stepping : 0 > microcode : 0x6006704 > cpu MHz : 1444.800 > cache size: 1024 KB > physical id : 0 > siblings : 2 > core id : 0 > cpu cores : 2 > apicid: 16 > initial apicid: 0 > fpu : yes > fpu_exception : yes > cpuid level : 13 > wp: yes > flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov > pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb > rdtscp lm constant_tsc rep_good acc_power nopl nonstop_tsc cpuid extd_apicid > aperfmperf pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt > aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a > misalignsse 3dnowprefetch osvw ibs xop skinit wdt lwp fma4 tce nodeid_msr tbm > perfctr_core perfctr_nb bpext ptsc mwaitx cpb hw_pstate ssbd vmmcall fsgsbase > bmi1 avx2 smep bmi2 xsaveopt arat npt lbrv svm_lock nrip_save tsc_scale > vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic > v_vmsave_vmload vgif overflow_recov > bugs : fxsave_leak sysret_ss_attrs null_seg spectre_v1 spectre_v2 > spec_store_bypass > bogomips : 5789.50 > TLB size : 1536 4K pages > clflush size : 64 > cache_alignment : 64 > address sizes : 48 bits physical, 48 bits virtual > power management: ts ttp tm 100mhzsteps hwpstate cpb eff_freq_ro acc_power > [13] > processor : 1 > vendor_id : AuthenticAMD > cpu family: 21 > model : 112 > model name: AMD A9-9410 RADEON R5, 5 COMPUTE CORES 2C+3G > stepping : 0 > microcode : 0x6006704 > cpu MHz : 1483.889 > cache size: 1024 KB > physical id : 0 > siblings : 2 > core id : 1 > cpu cores : 2 > apicid: 17 > initial apicid: 1 > fpu : yes > fpu_exception : yes > cpuid level : 13 > wp: yes > flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov > pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb > rdtscp lm constant_tsc rep_good acc_power nopl nonstop_tsc cpuid extd_apic
[jira] [Commented] (ZOOKEEPER-3542) X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on machines with 2 cores
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928089#comment-16928089 ] Hadoop QA commented on ZOOKEEPER-3542: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4138//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4138//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4138//console This message is automatically generated. > X509UtilTest#testClientRenegotiationFails is flaky on JDK8 + linux on > machines with 2 cores > --- > > Key: ZOOKEEPER-3542 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3542 > Project: ZooKeeper > Issue Type: Test > Components: build, tests >Affects Versions: 3.5.5 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Critical > Labels: pull-request-available > Fix For: 3.5.6 > > Time Spent: 0.5h > Remaining Estimate: 0h > > On this Fedora machine: > [eolivelli@localhost zookeeper-server]$ uname -a > Linux localhost.localdomain 5.2.9-200.fc30.x86_64 #1 SMP Fri Aug 16 21:37:45 > UTC 2019 x86_64 x86_64 x86_64 GNU/Linux > [eolivelli@localhost zookeeper-server]$ mvn -v > Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; > 2019-08-27T17:06:16+02:00) > Maven home: /home/eolivelli/Scaricati/maven > Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: > /home/eolivelli/dev/jdk8u222-b10/jre > Default locale: it_IT, platform encoding: UTF-8 > OS name: "linux", version: "5.2.9-200.fc30.x86_64", arch: "amd64", family: > "unix" > [eolivelli@localhost zookeeper-server]$ cat /proc/cpuinfo > processor : 0 > vendor_id : AuthenticAMD > cpu family: 21 > model : 112 > model name: AMD A9-9410 RADEON R5, 5 COMPUTE CORES 2C+3G > stepping : 0 > microcode : 0x6006704 > cpu MHz : 1444.800 > cache size: 1024 KB > physical id : 0 > siblings : 2 > core id : 0 > cpu cores : 2 > apicid: 16 > initial apicid: 0 > fpu : yes > fpu_exception : yes > cpuid level : 13 > wp: yes > flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov > pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb > rdtscp lm constant_tsc rep_good acc_power nopl nonstop_tsc cpuid extd_apicid > aperfmperf pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt > aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a > misalignsse 3dnowprefetch osvw ibs xop skinit wdt lwp fma4 tce nodeid_msr tbm > perfctr_core perfctr_nb bpext ptsc mwaitx cpb hw_pstate ssbd vmmcall fsgsbase > bmi1 avx2 smep bmi2 xsaveopt arat npt lbrv svm_lock nrip_save tsc_scale > vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic > v_vmsave_vmload vgif overflow_recov > bugs : fxsave_leak sysret_ss_attrs null_seg spectre_v1 spectre_v2 > spec_store_bypass > bogomips : 5789.50 > TLB size : 1536 4K pages > clflush size : 64 > cache_alignment : 64 > address sizes : 48 bits physical, 48 bits virtual > power management: ts ttp tm 100mhzsteps hwpstate cpb eff_freq_ro acc_power > [13] > processor : 1 > vendor_id : AuthenticAMD > cpu family: 21 > model : 112 > model name: AMD A9-9410 RADEON R5, 5 COMPUTE CORES 2C+3G > stepping : 0 > microcode : 0x6006704 > cpu MHz : 1483.889 > cache size: 1024 KB > physical id : 0 > siblings : 2 > core id : 1 > cpu cores : 2 > apicid: 17 > initial apicid: 1 > fpu : yes > fpu_exception : yes > cpuid level : 13 > wp: yes > flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov > pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb > rdtscp lm constant_tsc rep_good acc_power nopl nonstop_tsc cpuid extd_apic
[jira] [Commented] (ZOOKEEPER-3440) Fix Apache RAT check by excluding binary files (images)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928026#comment-16928026
]
Hadoop QA commented on ZOOKEEPER-3440:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4135//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4135//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4135//console
This message is automatically generated.
> Fix Apache RAT check by excluding binary files (images)
> ---
>
> Key: ZOOKEEPER-3440
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3440
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, documentation
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Critical
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.6
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> I see this error on Jenkins as we are missing the exclusion for the images of
> the docs.
> {code:java}
> Unapproved licenses:
>
> /home/jenkins/jenkins-slave/workspace/zookeeper-master-maven/zookeeper-docs/src/main/resources/markdown/images/state_dia.dia
> {code}
> We should also add this check to the precommit job on Travis (this will be
> part of the commit) and on CI (this is a manual configuration, to be done
> after fixing this issue)
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (ZOOKEEPER-3539) Fix branch-3.5 after upgrade on ASF CI
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925133#comment-16925133 ] Hadoop QA commented on ZOOKEEPER-3539: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4125//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4125//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4125//console This message is automatically generated. > Fix branch-3.5 after upgrade on ASF CI > -- > > Key: ZOOKEEPER-3539 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3539 > Project: ZooKeeper > Issue Type: Task > Components: build, build-infrastructure >Affects Versions: 3.5.5 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Blocker > Labels: pull-request-available > Fix For: 3.5.6 > > Time Spent: 40m > Remaining Estimate: 0h > > ASF CI now lacks "findbugs" tool. > ASF CI upgraded gcc and now there are some errors related to the usage of > NULL in calls of fprintf. > We should: > - disable findbugs on CI ant-based tasks > - use LOG_DEBUG consistently with the rest of code in C client > Please note that on branch-3.5 we are officially using Maven and Spotbugs, > ant stuff is there only for compatibility in build, findbugs is not strictly > needed to check the goodness of code in branch-3.5. > branch-3.4 is only with ANT, let's treat this problem as a different task -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (ZOOKEEPER-3539) Fix branch-3.5 after upgrade on ASF CI
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925112#comment-16925112 ] Hadoop QA commented on ZOOKEEPER-3539: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4122//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4122//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4122//console This message is automatically generated. > Fix branch-3.5 after upgrade on ASF CI > -- > > Key: ZOOKEEPER-3539 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3539 > Project: ZooKeeper > Issue Type: Task > Components: build, build-infrastructure >Affects Versions: 3.5.5 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Blocker > Labels: pull-request-available > Fix For: 3.5.6 > > Time Spent: 20m > Remaining Estimate: 0h > > ASF CI now lacks "findbugs" tool. > ASF CI upgraded gcc and now there are some errors related to the usage of > NULL in calls of fprintf. > We should: > - disable findbugs on CI ant-based tasks > - use LOG_DEBUG consistently with the rest of code in C client > Please note that on branch-3.5 we are officially using Maven and Spotbugs, > ant stuff is there only for compatibility in build, findbugs is not strictly > needed to check the goodness of code in branch-3.5. > branch-3.4 is only with ANT, let's treat this problem as a different task -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (ZOOKEEPER-3518) owasp check flagging jackson-databind 2.9.9.1
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915237#comment-16915237 ] Hadoop QA commented on ZOOKEEPER-3518: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4104//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4104//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4104//console This message is automatically generated. > owasp check flagging jackson-databind 2.9.9.1 > - > > Key: ZOOKEEPER-3518 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3518 > Project: ZooKeeper > Issue Type: Bug > Components: security >Affects Versions: 3.6.0, 3.5.5 >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Blocker > Labels: pull-request-available > Fix For: 3.6.0, 3.5.6 > > Time Spent: 10m > Remaining Estimate: 0h > > owasp check is flagging jackson-databind 2.9.9.1 - upgrade to 2.9.9.3 > CVE-2019-14379, CVE-2019-14439, CVE-2019-12384 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (ZOOKEEPER-3448) Introduce MessageTracker to assist debug leader and leaner connectivity issues
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912772#comment-16912772 ] Hadoop QA commented on ZOOKEEPER-3448: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4102//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4102//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4102//console This message is automatically generated. > Introduce MessageTracker to assist debug leader and leaner connectivity issues > -- > > Key: ZOOKEEPER-3448 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3448 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: Twitter, pull-request-available > Time Spent: 3h 20m > Remaining Estimate: 0h > > We want to have better insight on the state of the world when learners lost > connection with leader, so we need capture more information when that > happens. We capture more information through MessageTracker which will record > the last few sent and received messages at various protocol stage, and these > information will be dumped to log files for further analysis. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (ZOOKEEPER-3448) Introduce MessageTracker to assist debug leader and leaner connectivity issues
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912596#comment-16912596 ] Hadoop QA commented on ZOOKEEPER-3448: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4101//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4101//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4101//console This message is automatically generated. > Introduce MessageTracker to assist debug leader and leaner connectivity issues > -- > > Key: ZOOKEEPER-3448 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3448 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: Twitter, pull-request-available > Time Spent: 2h 40m > Remaining Estimate: 0h > > We want to have better insight on the state of the world when learners lost > connection with leader, so we need capture more information when that > happens. We capture more information through MessageTracker which will record > the last few sent and received messages at various protocol stage, and these > information will be dumped to log files for further analysis. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (ZOOKEEPER-3494) No need to depend on netty-all (SSL)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900719#comment-16900719 ] Hadoop QA commented on ZOOKEEPER-3494: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4095//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4095//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4095//console This message is automatically generated. > No need to depend on netty-all (SSL) > > > Key: ZOOKEEPER-3494 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3494 > Project: ZooKeeper > Issue Type: Improvement >Affects Versions: 3.6.0, 3.5.5 >Reporter: Norbert Kalmar >Assignee: Norbert Kalmar >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > ZooKeeper currently depends on netty-all to satisfy the requirements for the > SSL capability. > netty-all is an unnecessarily broad dependency, we already had request to > revise (https://issues.apache.org/jira/browse/SOLR-13665) > netty-handler (429KB) and netty-transport-native-epoll (115KB) looks like is > enough. > Netty-all was ~4MB. > This reduce size of netty dependency to 1/8. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3494) No need to depend on netty-all (SSL)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900065#comment-16900065 ] Hadoop QA commented on ZOOKEEPER-3494: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4094//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4094//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4094//console This message is automatically generated. > No need to depend on netty-all (SSL) > > > Key: ZOOKEEPER-3494 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3494 > Project: ZooKeeper > Issue Type: Improvement >Affects Versions: 3.6.0, 3.5.5 >Reporter: Norbert Kalmar >Assignee: Norbert Kalmar >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > ZooKeeper currently depends on netty-all to satisfy the requirements for the > SSL capability. > netty-all is an unnecessarily broad dependency, we already had request to > revise (https://issues.apache.org/jira/browse/SOLR-13665) > netty-handler (429KB) and netty-transport-native-epoll (115KB) looks like is > enough. > Netty-all was ~4MB. > This reduce size of netty dependency to 1/8. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3480) Flaky test CommitProcessorMetricsTest.testConcurrentRequestProcessingInCommitProcessor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899408#comment-16899408 ] Hadoop QA commented on ZOOKEEPER-3480: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4093//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4093//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4093//console This message is automatically generated. > Flaky test > CommitProcessorMetricsTest.testConcurrentRequestProcessingInCommitProcessor > -- > > Key: ZOOKEEPER-3480 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3480 > Project: ZooKeeper > Issue Type: Test > Components: tests >Affects Versions: 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Found this flaky test on Jenkins, here is the log: > Error Message > expected:<3> but was:<2> > h3. Stacktrace > java.lang.AssertionError: expected:<3> but was:<2> at > org.apache.zookeeper.server.quorum.CommitProcessorMetricsTest.testConcurrentRequestProcessingInCommitProcessor(CommitProcessorMetricsTest.java:391) > h3. Standard Output > 2019-07-31 03:15:17,408 [myid:] - INFO [main:ZKTestCase$1@60] - STARTING > testConcurrentRequestProcessingInCommitProcessor 2019-07-31 03:15:17,408 > [myid:] - INFO [main:CommitProcessorMetricsTest@52] - setup 2019-07-31 > 03:15:17,409 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - > RUNNING TEST METHOD testConcurrentRequestProcessingInCommitProcessor > 2019-07-31 03:15:17,411 [myid:] - INFO [main:CommitProcessor@496] - > Configuring CommitProcessor with readBatchSize -1 commitBatchSize 1 > 2019-07-31 03:15:17,411 [myid:] - INFO [main:CommitProcessor@454] - > Configuring CommitProcessor with 24 worker threads. 2019-07-31 03:15:17,461 > [myid:] - INFO [main:CommitProcessorMetricsTest$TestCommitProcessor@109] - > numWorkerThreads in Test is 3 2019-07-31 03:15:19,466 [myid:] - INFO > [main:JUnit4ZKTestRunner$LoggedInvokeMethod@99] - TEST METHOD FAILED > testConcurrentRequestProcessingInCommitProcessor java.lang.AssertionError: > expected:<3> but was:<2> at org.junit.Assert.fail(Assert.java:88) at > org.junit.Assert.failNotEquals(Assert.java:834) at > org.junit.Assert.assertEquals(Assert.java:118) at > org.junit.Assert.assertEquals(Assert.java:144) at > org.apache.zookeeper.server.quorum.CommitProcessorMetricsTest.testConcurrentRequestProcessingInCommitProcessor(CommitProcessorMetricsTest.java:391) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:80) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at > org.junit.rules.RunRules.evaluate(RunRules.java:20) at > org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(Pa
[jira] [Commented] (ZOOKEEPER-3448) Introduce MessageTracker to assist debug leader and leaner connectivity issues
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898594#comment-16898594 ] Hadoop QA commented on ZOOKEEPER-3448: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4091//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4091//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4091//console This message is automatically generated. > Introduce MessageTracker to assist debug leader and leaner connectivity issues > -- > > Key: ZOOKEEPER-3448 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3448 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: Twitter, pull-request-available > Time Spent: 2h 40m > Remaining Estimate: 0h > > We want to have better insight on the state of the world when learners lost > connection with leader, so we need capture more information when that > happens. We capture more information through MessageTracker which will record > the last few sent and received messages at various protocol stage, and these > information will be dumped to log files for further analysis. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3473) Improving successful TLS handshake throughput with concurrent control
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897828#comment-16897828 ] Hadoop QA commented on ZOOKEEPER-3473: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4089//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4089//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4089//console This message is automatically generated. > Improving successful TLS handshake throughput with concurrent control > - > > Key: ZOOKEEPER-3473 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3473 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 50m > Remaining Estimate: 0h > > When there are lots of clients trying to re-establish sessions, there might > be lots of half finished handshake timed out, and those failed ones keep > reconnecting to another server and restarting the handshake from beginning > again, which caused herd effect. > > And the number of total ZK sessions could be supported within session timeout > are impacted a lot after enabling TLS. > > To improve the throughput, we added the TLS concurrent control to reduce the > herd effect, and from out benchmark this doubled the sessions we could > support within session timeout. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3473) Improving successful TLS handshake throughput with concurrent control
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897782#comment-16897782 ] Hadoop QA commented on ZOOKEEPER-3473: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4088//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4088//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4088//console This message is automatically generated. > Improving successful TLS handshake throughput with concurrent control > - > > Key: ZOOKEEPER-3473 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3473 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 50m > Remaining Estimate: 0h > > When there are lots of clients trying to re-establish sessions, there might > be lots of half finished handshake timed out, and those failed ones keep > reconnecting to another server and restarting the handshake from beginning > again, which caused herd effect. > > And the number of total ZK sessions could be supported within session timeout > are impacted a lot after enabling TLS. > > To improve the throughput, we added the TLS concurrent control to reduce the > herd effect, and from out benchmark this doubled the sessions we could > support within session timeout. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3473) Improving successful TLS handshake throughput with concurrent control
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896862#comment-16896862 ] Hadoop QA commented on ZOOKEEPER-3473: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4087//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4087//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4087//console This message is automatically generated. > Improving successful TLS handshake throughput with concurrent control > - > > Key: ZOOKEEPER-3473 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3473 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 50m > Remaining Estimate: 0h > > When there are lots of clients trying to re-establish sessions, there might > be lots of half finished handshake timed out, and those failed ones keep > reconnecting to another server and restarting the handshake from beginning > again, which caused herd effect. > > And the number of total ZK sessions could be supported within session timeout > are impacted a lot after enabling TLS. > > To improve the throughput, we added the TLS concurrent control to reduce the > herd effect, and from out benchmark this doubled the sessions we could > support within session timeout. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3150) Data integrity check when loading snapshot/txns from disk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894795#comment-16894795 ] Hadoop QA commented on ZOOKEEPER-3150: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 53 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4079//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4079//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4079//console This message is automatically generated. > Data integrity check when loading snapshot/txns from disk > - > > Key: ZOOKEEPER-3150 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3150 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 9h 20m > Remaining Estimate: 0h > > This is a sub task of ZOOKEEPER-3114, which is going to check the data > integrity by calculating the hash value of data tree, and compare the value > when reload the snapshot/txns from disk. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3473) Improving successful TLS handshake throughput with concurrent control
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894786#comment-16894786 ] Hadoop QA commented on ZOOKEEPER-3473: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4078//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4078//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4078//console This message is automatically generated. > Improving successful TLS handshake throughput with concurrent control > - > > Key: ZOOKEEPER-3473 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3473 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 10m > Remaining Estimate: 0h > > When there are lots of clients trying to re-establish sessions, there might > be lots of half finished handshake timed out, and those failed ones keep > reconnecting to another server and restarting the handshake from beginning > again, which caused herd effect. > > And the number of total ZK sessions could be supported within session timeout > are impacted a lot after enabling TLS. > > To improve the throughput, we added the TLS concurrent control to reduce the > herd effect, and from out benchmark this doubled the sessions we could > support within session timeout. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3472) Treat check request as a write request which needs to wait for the check txn commit from leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894775#comment-16894775 ] Hadoop QA commented on ZOOKEEPER-3472: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4077//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4077//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4077//console This message is automatically generated. > Treat check request as a write request which needs to wait for the check txn > commit from leader > --- > > Key: ZOOKEEPER-3472 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3472 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0, 3.5.5 >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Check op is usually used as a sub op in multi, but from the ZooKeeper server > implementation it can also called separately, the learner will forward this > request to leader, and the leader will check the version with the given > version in the request, and generate a txn (error) in the quorum. > > This is kind of a heavier sync to make sure when the client check on a > learner, it is syncing up to date with leader when the check request is being > processed. The learner need to wait for this remote commit before reply to > client in FinalRequestProcessor. > > There is no explicit API exposed for check, so it seems not a problem, but > it could leave an issue there if the check API is exposed in the future. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3471) Potential lock unavailable due to dangling ephemeral nodes left during local session upgrading
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894762#comment-16894762 ] Hadoop QA commented on ZOOKEEPER-3471: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4076//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4076//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4076//console This message is automatically generated. > Potential lock unavailable due to dangling ephemeral nodes left during local > session upgrading > -- > > Key: ZOOKEEPER-3471 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3471 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 10m > Remaining Estimate: 0h > > There is a race condition which might be triggered if the client create > session, upgrading the session with ephemeral node, then immediately issued > close session request before it's removed from local session tracker. > > The close session request will be treated as a local session close request > since it still exists in the local session tracker, which goes through the ZK > pipeline and delete the session from both local and global session tracker. > Since the session is not tracked anymore, it will leave the ephemeral nodes > there. > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3150) Data integrity check when loading snapshot/txns from disk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894240#comment-16894240 ] Hadoop QA commented on ZOOKEEPER-3150: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 53 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4074//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4074//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4074//console This message is automatically generated. > Data integrity check when loading snapshot/txns from disk > - > > Key: ZOOKEEPER-3150 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3150 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 6h 20m > Remaining Estimate: 0h > > This is a sub task of ZOOKEEPER-3114, which is going to check the data > integrity by calculating the hash value of data tree, and compare the value > when reload the snapshot/txns from disk. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3418) Improve quorum throughput through eager ACL checks of requests on local servers
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894224#comment-16894224 ] Hadoop QA commented on ZOOKEEPER-3418: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4072//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4072//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4072//console This message is automatically generated. > Improve quorum throughput through eager ACL checks of requests on local > servers > --- > > Key: ZOOKEEPER-3418 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3418 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: Twitter, pull-request-available > Time Spent: 3h 20m > Remaining Estimate: 0h > > Serving write requests that change the state of the system requires quorum > operations, and in some cases, the quorum operations can be avoided if the > requests are doomed to fail. ACL check failure is such a case. To optimize > for this case, we elevate the ACL check logic and perform eager ACL check on > local server (where the requests are received), and fail fast, before sending > the requests to leader. > As with any features, there is a feature flag that can control this feature > on, or off (default). This feature is also forward compatible in that for new > any new Op code (and some existing Op code we did not explicit check > against), they will pass the check and (potentially) fail on leader side, > instead of being prematurely filtered out on local server. > The end result is better throughput and stability of the quorum for certain > workloads. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-1634) A new feature proposal to ZooKeeper: authentication enforcement
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891586#comment-16891586 ] Hadoop QA commented on ZOOKEEPER-1634: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 16 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4070//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4070//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4070//console This message is automatically generated. > A new feature proposal to ZooKeeper: authentication enforcement > --- > > Key: ZOOKEEPER-1634 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1634 > Project: ZooKeeper > Issue Type: New Feature > Components: security, server >Affects Versions: 3.4.5 >Reporter: Jaewoong Choi >Assignee: Michael Han >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Attachments: > zookeeper_3.4.5_patch_for_authentication_enforcement.patch > > Original Estimate: 72h > Time Spent: 4h > Remaining Estimate: 68h > > Up to the version of 3.4.5, ZooKeeperServer doesn't force the authentication > if the client doesn't give any auth-info through ZooKeeper#addAuthInfo method > invocation. Hence, every znode should have at least one ACL assigned > otherwise any unauthenticated client can do anything on it. > The current authentication/authorization mechanism of ZooKeeper described > above has several points at issue: > 1. At security standpoint, a maleficent client can access a znode which > doesn't have any proper authorization access control set. > 2. At runtime performance standpoint, authorization for every znode to every > operation is unnecessarily but always evaluated against the client who > bypassed the authentication phase. > In other words, the current mechanism doesn't address a certain requirement > at below: > "We want to protect a ZK server by enforcing a simple authentication to every > client no matter which znode it is trying to access. Every connection (or > operation) from the client won't be established but rejected if it doesn't > come with a valid authentication information. As we don't have any other > distinction between znodes in term of authorization, we don't want any ACLs > on any znode." > To address the issues mentioned above, we propose a feature called > "authentication enforcement" to the ZK source. The idea is roughly but > clearly described in a form of patch in the attached file > (zookeeper_3.4.5_patch_for_authentication_enforcement.patch): which makes > ZooKeeperServer enforce the authentication with the given 2 configurations: > authenticationEnforced (boolean) and enforcedAuthenticationScheme (string) > against every operation coming through ZooKeeperServer#processPacket method > except for OpCode.auth operation. The repository base of the patch is > "http://svn.apache.org/repos/asf/zookeeper/tags/release-3.4.5/"; -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3418) Improve quorum throughput through eager ACL checks of requests on local servers
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891540#comment-16891540 ] Hadoop QA commented on ZOOKEEPER-3418: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4069//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4069//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4069//console This message is automatically generated. > Improve quorum throughput through eager ACL checks of requests on local > servers > --- > > Key: ZOOKEEPER-3418 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3418 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: Twitter, pull-request-available > Time Spent: 2.5h > Remaining Estimate: 0h > > Serving write requests that change the state of the system requires quorum > operations, and in some cases, the quorum operations can be avoided if the > requests are doomed to fail. ACL check failure is such a case. To optimize > for this case, we elevate the ACL check logic and perform eager ACL check on > local server (where the requests are received), and fail fast, before sending > the requests to leader. > As with any features, there is a feature flag that can control this feature > on, or off (default). This feature is also forward compatible in that for new > any new Op code (and some existing Op code we did not explicit check > against), they will pass the check and (potentially) fail on leader side, > instead of being prematurely filtered out on local server. > The end result is better throughput and stability of the quorum for certain > workloads. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3448) Introduce MessageTracker to assist debug leader and leaner connectivity issues
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891509#comment-16891509 ] Hadoop QA commented on ZOOKEEPER-3448: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4068//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4068//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4068//console This message is automatically generated. > Introduce MessageTracker to assist debug leader and leaner connectivity issues > -- > > Key: ZOOKEEPER-3448 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3448 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: Twitter, pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > We want to have better insight on the state of the world when learners lost > connection with leader, so we need capture more information when that > happens. We capture more information through MessageTracker which will record > the last few sent and received messages at various protocol stage, and these > information will be dumped to log files for further analysis. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3448) Introduce MessageTracker to assist debug leader and leaner connectivity issues
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891422#comment-16891422 ] Hadoop QA commented on ZOOKEEPER-3448: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4067//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4067//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4067//console This message is automatically generated. > Introduce MessageTracker to assist debug leader and leaner connectivity issues > -- > > Key: ZOOKEEPER-3448 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3448 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: Twitter, pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > We want to have better insight on the state of the world when learners lost > connection with leader, so we need capture more information when that > happens. We capture more information through MessageTracker which will record > the last few sent and received messages at various protocol stage, and these > information will be dumped to log files for further analysis. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3356) Request throttling in Netty is not working as expected and could cause direct buffer OOM issue
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890432#comment-16890432 ] Hadoop QA commented on ZOOKEEPER-3356: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4066//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4066//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4066//console This message is automatically generated. > Request throttling in Netty is not working as expected and could cause direct > buffer OOM issue > --- > > Key: ZOOKEEPER-3356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3356 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.4, 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > The current implementation of Netty enable/disable recv logic may cause the > direct buffer OOM because we may enable read a large chunk of packets and > disabled again after consuming a single ZK request. We have seen this problem > on prod occasionally. > > Need a more advanced flow control in Netty instead of using AUTO_READ. Have > improved it internally by enable/disable recv based on the queuedBuffer size, > will upstream this soon. > > With this implementation, the max Netty queued buffer size (direct memory > usage) will be 2 * recv_buffer size. It's not the per message size because in > epoll ET mode it will try to read until the socket is empty, and because of > SslHandler will trigger another read when it's not a full encrypt packet and > haven't issued any decrypt message. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3463) Enable warning messages in maven compiler plugin
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889168#comment-16889168
]
Hadoop QA commented on ZOOKEEPER-3463:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4063//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4063//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4063//console
This message is automatically generated.
> Enable warning messages in maven compiler plugin
>
>
> Key: ZOOKEEPER-3463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3463
> Project: ZooKeeper
> Issue Type: Task
> Components: build
>Affects Versions: 3.6.0, 3.5.5, 3.4.14
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> "Show Warnings" is off by default in Maven Compiler Plugin. This invalidates
> our most recent setting of -Werror (treat warnings as errors).
> Let's enable compiler warning messages in all projects and adjust Xdoclint
> setting:
> {noformat}
>
> true
>
> ...
> -Xdoclint:-missing
> ...
>
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (ZOOKEEPER-3463) Enable warning messages in maven compiler plugin
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886268#comment-16886268
]
Hadoop QA commented on ZOOKEEPER-3463:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4061//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4061//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/4061//console
This message is automatically generated.
> Enable warning messages in maven compiler plugin
>
>
> Key: ZOOKEEPER-3463
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3463
> Project: ZooKeeper
> Issue Type: Task
> Components: build
>Affects Versions: 3.6.0, 3.5.5, 3.4.14
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> "Show Warnings" is off by default in Maven Compiler Plugin. This invalidates
> our most recent setting of -Werror (treat warnings as errors).
> Let's enable compiler warning messages in all projects and adjust Xdoclint
> setting:
> {noformat}
>
> true
>
> ...
> -Xdoclint:-missing
> ...
>
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
