TODO-Plugin guidance

[Ronald Petty]

Hello,

I could be living in the past, but I am trying to get the old `mvn hpi:...` 
to work and it seems it has changed.  I found a page saying we should use 
this method here:

mvn archetype:generate -B -DarchetypeGroupId=io.jenkins.archetypes 
-DarchetypeArtifactId=hello-world-plugin -DarchetypeVersion=1.4 
-DartifactId=first

mvn hpi:run

Things start up, and I see the TODO plugin installed, but the Hello World 
Builder is now gone.  No errors appear on start in the log.

Can someone point me to a fool proof hello-world (TODO) tutorial for 
Jenkins 2.115 development?

I appreciate the help.

Regards.

Ron

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/b669b566-eb39-4b24-b76b-3965e14fa7e2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Heads up! Jenkins is on YouTube, with more videos coming soon!

[Slide]

This is great, thanks for doing this!

On Tue, Apr 10, 2018 at 7:01 PM R. Tyler Croy  wrote:

>
> The Jenkins project has been on YouTube for a while, but I recently
> transitioned our channel to a "Brand Account", which means we can share
> permissions to post videos _much_ more easily:
>
> https://www.youtube.com/c/jenkinscicd
>
>
> I am hoping that we can share access, not only for the Jenkins Online
> Meetups
> (https://www.meetup.com/Jenkins-online-meetup/), but also for more project
> meetings and group meetings (see also:
> https://groups.google.com/d/msg/jenkinsci-dev/6-1mZoKp4hM/EHz5NaPRBgAJ).
>
>
> Hope you all find more video content helpful!
>
>
> Cheers
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/20180411020146.GB1836%40grape.lasagna.io
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVfHgLTD97xcU%3DCB0D69F32xi5CjWhRixXEWo-6L12RSog%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Heads up! Jenkins is on YouTube, with more videos coming soon!

[R. Tyler Croy]

The Jenkins project has been on YouTube for a while, but I recently
transitioned our channel to a "Brand Account", which means we can share
permissions to post videos _much_ more easily:

https://www.youtube.com/c/jenkinscicd


I am hoping that we can share access, not only for the Jenkins Online Meetups
(https://www.meetup.com/Jenkins-online-meetup/), but also for more project
meetings and group meetings (see also:
https://groups.google.com/d/msg/jenkinsci-dev/6-1mZoKp4hM/EHz5NaPRBgAJ).


Hope you all find more video content helpful!


Cheers

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/20180411020146.GB1836%40grape.lasagna.io.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

Re: Request for comments: Special Interest Groups (SIGs) for the Jenkins project

[R. Tyler Croy]

(replies inline)

On Thu, 22 Mar 2018, R. Tyler Croy wrote:

> 
> I have been looking at some of the great things the Kubernetes community has
> been doing for ideas we can borrow, and one idea which really sticks out is:
> Special Interest Groups (SIGs)
> 
> 
> A full list of the Kubernetes community SIGs can be found here:
> 
> 
> I think we already have some groups, which are almost informal SIGs, such as
> Security, GSoC, Infra, etc. The aspects of SIGs which I really would like to
> formalize, and support from a community infra standpoint are:


Here's an update, I've written out my first draft of what SIGs might look like
for us here: https://github.com/jenkinsci/jep/pull/81

Please let me know what you all think, I'm especially curious for Daniel,
Oliver, Ewelina, and Carlos's thoughts as I am hoping this helps you all get
more contribution and focus :)



Cheers

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/20180411015642.GA1836%40grape.lasagna.io.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

Re: Need help designing a fix for JENKINS-50504

[me]

I meant "Thanks for pointing out JENKINS-41854" below.

On Tuesday, April 10, 2018 at 5:42:20 PM UTC-7, m...@basilcrow.com wrote:
>
> Thanks for pointing out JENKINS-45294. That is exactly what I am facing, 
> at least twice a month. It causes severe disruption to my users, so I need 
> to come up with a plan. I see that the bug is unassigned. If it isn't fixed 
> soon, I might have to try to fix it myself by necessity. I suppose the best 
> way to start would be by writing a test case that triggers the issue. Does 
> the Jenkinsrule test harness provide any functionality for setting up this 
> kind of scenario? I see there are some existing tests that restart Jenkins, 
> but I'm not sure how to write an automated test that makes a node 
> disconnect and reconnect in the manner described in the bug. Any advice or 
> pointers to existing code or tests would be appreciated.
>
> On Wednesday, April 4, 2018 at 1:26:29 AM UTC-7, Oleg Nenashev wrote:
>>
>> This issue seems to be Pipeline-specific (actually DueableTask-Specific). 
>> Standard Freestyle jobs should abort immediately on the agent 
>> disconnection, but Pipeline jobs may recover and continue using the 
>> workspace.
>>
>> However, it seems ugly to use the new channel in the "in use" map, 
>>> because the job is still technically running under the old channel.
>>
>>
>> No, it should be running under the new channel. Old channel gets 
>> disposed, and Remoting 3.14+ adds some diagnostics for these cases (e.g. 
>> JENKINS-45294 ). Now 
>> it causes some issues in Durable task which does not always recreate 
>> FilePath and underlying Workspace (JENKINS-41854 
>>  and other similar 
>> issues with "Channel is closing or closed").
>>
>> WorkspaceList#inUse should be reacquired by Pipeline for sure when it 
>> reconnects to a new agent. I would guess it happens even now (or not?), but 
>> clearly there is a potential of race conditions between recovered jobs and 
>> new submissions.
>>
>> The proposed patch may help, although workspace management is not really 
>> the strongest part of the Jenkins core. I would rather suggest redesigning 
>> it so that workspaces can be tracked independently on the node state (the 
>> proposed change does the same for a single cache). Some better UI/ 
>> workspace release features could be added as an added value.
>>
>> BR, Oleg
>>  
>>
>> On Monday, April 2, 2018 at 10:08:28 PM UTC+2, m...@basilcrow.com wrote:
>>>
>>> Hi Ivan,
>>>
>>> Thanks for your reply. I'm not exactly sure how my proposed workaround 
>>> would necessarily cause concurrency issues. Doesn't that depend on how it's 
>>> implemented? I agree that it's strange that the agent wasn't disconnected 
>>> and still keeps the old connection to the master, even though new jobs use 
>>> a new connection. Doesn't this violate the invariant implied by the 
>>> implementation of WorkspaceList#inUse, which is that the entries in the map 
>>> always represent the latest channel for a given node? This definitely seems 
>>> like a core bug to me. I don't believe I should need to tune my TCP stack, 
>>> because pipeline claims to be resilient to network outages. If the master 
>>> logs "SEVERE: I/O error in channel jenkins-node" and "INFO: Attempting to 
>>> reconnect jenkins-node", then why do jobs continue running on the old 
>>> connection, violating the invariant in WorkspaceList#inUse?
>>>
>>> Thanks,
>>> Basil
>>>
>>> On Sunday, April 1, 2018 at 6:47:02 AM UTC-7, Ivan Fernandez Calvo wrote:

 The pruposed workaround could cause concurrence issues, I think the the 
 main issue why the agent is not disconnected and keep the old connection 
 is 
 the most important thing. Did you checked the open connection from the 
 Agent to the master with netstat? It should be two connections the old one 
 an an new one, Has the  agent more than one slave.jar process running? Are 
 your agents VM or baremetal? Did you tune your tcp stack with proper 
 values 
 to keepalive?
>>>
>>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/9fd964f0-ad48-4a96-8cb2-f6524cfa9b33%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Need help designing a fix for JENKINS-50504

[me]

Thanks for pointing out JENKINS-45294. That is exactly what I am facing, at 
least twice a month. It causes severe disruption to my users, so I need to 
come up with a plan. I see that the bug is unassigned. If it isn't fixed 
soon, I might have to try to fix it myself by necessity. I suppose the best 
way to start would be by writing a test case that triggers the issue. Does 
the Jenkinsrule test harness provide any functionality for setting up this 
kind of scenario? I see there are some existing tests that restart Jenkins, 
but I'm not sure how to write an automated test that makes a node 
disconnect and reconnect in the manner described in the bug. Any advice or 
pointers to existing code or tests would be appreciated.

On Wednesday, April 4, 2018 at 1:26:29 AM UTC-7, Oleg Nenashev wrote:
>
> This issue seems to be Pipeline-specific (actually DueableTask-Specific). 
> Standard Freestyle jobs should abort immediately on the agent 
> disconnection, but Pipeline jobs may recover and continue using the 
> workspace.
>
> However, it seems ugly to use the new channel in the "in use" map, because 
>> the job is still technically running under the old channel.
>
>
> No, it should be running under the new channel. Old channel gets disposed, 
> and Remoting 3.14+ adds some diagnostics for these cases (e.g. 
> JENKINS-45294 ). Now 
> it causes some issues in Durable task which does not always recreate 
> FilePath and underlying Workspace (JENKINS-41854 
>  and other similar 
> issues with "Channel is closing or closed").
>
> WorkspaceList#inUse should be reacquired by Pipeline for sure when it 
> reconnects to a new agent. I would guess it happens even now (or not?), but 
> clearly there is a potential of race conditions between recovered jobs and 
> new submissions.
>
> The proposed patch may help, although workspace management is not really 
> the strongest part of the Jenkins core. I would rather suggest redesigning 
> it so that workspaces can be tracked independently on the node state (the 
> proposed change does the same for a single cache). Some better UI/ 
> workspace release features could be added as an added value.
>
> BR, Oleg
>  
>
> On Monday, April 2, 2018 at 10:08:28 PM UTC+2, m...@basilcrow.com wrote:
>>
>> Hi Ivan,
>>
>> Thanks for your reply. I'm not exactly sure how my proposed workaround 
>> would necessarily cause concurrency issues. Doesn't that depend on how it's 
>> implemented? I agree that it's strange that the agent wasn't disconnected 
>> and still keeps the old connection to the master, even though new jobs use 
>> a new connection. Doesn't this violate the invariant implied by the 
>> implementation of WorkspaceList#inUse, which is that the entries in the map 
>> always represent the latest channel for a given node? This definitely seems 
>> like a core bug to me. I don't believe I should need to tune my TCP stack, 
>> because pipeline claims to be resilient to network outages. If the master 
>> logs "SEVERE: I/O error in channel jenkins-node" and "INFO: Attempting to 
>> reconnect jenkins-node", then why do jobs continue running on the old 
>> connection, violating the invariant in WorkspaceList#inUse?
>>
>> Thanks,
>> Basil
>>
>> On Sunday, April 1, 2018 at 6:47:02 AM UTC-7, Ivan Fernandez Calvo wrote:
>>>
>>> The pruposed workaround could cause concurrence issues, I think the the 
>>> main issue why the agent is not disconnected and keep the old connection is 
>>> the most important thing. Did you checked the open connection from the 
>>> Agent to the master with netstat? It should be two connections the old one 
>>> an an new one, Has the  agent more than one slave.jar process running? Are 
>>> your agents VM or baremetal? Did you tune your tcp stack with proper values 
>>> to keepalive?
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/f523fd4b-b9c5-46c6-94fe-9ee2c71d81f2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Essentials] Instance Health Checking JEP: ready for first review

[Liam Newman]

Jesse,
Thanks for the reminder about that point around commenting.

As an editor, I have no objections to having pre-draft discussions in
whatever way contributors see fit.

As a sponsor of JEP-1, it is important to me that when a sponsor submits a
JEP for "Approval as Draft", that feedback they get on _that_ PR focuses on
issues that would prevent the JEP being approved as draft rather than on
design or other questions.  I'll add a note about this to
https://github.com/jenkinsci/jep/pull/76 .

-Liam




On Tue, Apr 10, 2018 at 12:41 PM Baptiste Mathus  wrote:

> 2018-04-10 16:33 GMT+02:00 R. Tyler Croy :
>
>> (replies inline)
>>
>> On Tue, 10 Apr 2018, Jesse Glick wrote:
>>
>> > I for one would find it easier to comment on a PR, but IIRC JEP
>> > editors have discouraged this for some reason
>> >
>> >
>> > ???Healthness??? is not a word???it is just ???health???.
>> >
>> >
>> > I would suggest `/metrics/evergreen/healthcheck` just return an empty
>> > JSON document, or a simple ???OK??? marker by default???only listing
>> things
>> > that are _not_ healthy.
>>
>> It was my understanding that this format was simply the Dropwizard
>> healthcheck
>> format.
>>
>
> Yes. Exactly. Also, though TBH I didn't test it myself yet, I expect one
> can contribute healthchecks, and they'd appear there.
>
> That "OK" idea is already somehow available if one enables the `canPing`
> configuration field. Then `curl`ing the URL will reply with just PONG and
> http-200 IIRC. But I felt this was unnecessary to enable that too.
>
>
>>
>> Do you have some reasoning for this you could share? Otherwise this seems
>> like
>> a bit of personal preference to me, but I'm sure there's some logic I
>> could be
>> missing here.
>>
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/20180410143346.discdbodxgiudmfz%40grape.lasagna.io
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS6FcSp_faJL5C26-xESdUrSQvw%3D40%2BGVxf-SkWM5TOvQQ%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAA0qCNxaUqBC6ckV-BE9qn%3DabQpoZqKMTE3oQ%3Di%3DGpqHkWG6Tw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Slide]

Why are you skipping the enforcer?

On Tue, Apr 10, 2018 at 8:30 AM Eugen Horovitz <
eugen.horov...@whitesourcesoftware.com> wrote:

> Hi Jesse ,
>
> I did all the changes and still got the same errors..
> I am probably still missing some important stuff... I am newbie in
> jenkins plugin development and I will be greatfull if you can have a
> look.
>
> https://gist.github.com/eugenhoro/f73f4d666c64ea809e6a6711a0e40ed3
>
> maven fails to build and also this
>
> mvn test -Djenkins.version=2.102 -Denforcer.skip=true
>
> from https://jenkins.io/blog/2018/01/13/jep-200/
>
> Thanks a lot
>
> On Tue, Apr 10, 2018 at 3:50 PM, Jesse Glick  wrote:
>
>> On Tue, Apr 10, 2018 at 2:25 AM, Eugen Horovitz
>>  wrote:
>> > Could not resolve dependencies for project
>> org.jenkins-ci.plugins:whitesource:hpi:18.2.1-SNAPSHOT:
>> > Failure to find org.jenkins-ci.main:jenkins-war:executable-war:2.102 in
>> https://repo.jenkins-ci.org/public/
>>
>> Stop overriding the version of `maven-hpi-plugin` in your POM. The old
>> version you are specifying does not work any more. Let it get picked
>> up by the parent.
>>
>> For that matter, there is a bunch of other stuff in your POM which can
>> and should be deleted. The configuration of `maven-compiler-plugin`,
>> for example.
>>
>
>> --
>> You received this message because you are subscribed to a topic in the
>> Google Groups "Jenkins Developers" group.
>> To unsubscribe from this topic, visit
>> https://groups.google.com/d/topic/jenkinsci-dev/NI533mCeKgc/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to
>> jenkinsci-dev+unsubscr...@googlegroups.com.
>>
> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0EozZfCAVRLFMwOLg_Jj1UjPMVb-bpejW7HyQy%2BvrC0w%40mail.gmail.com
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> *Eugen Horovitz*
>
> *Senior software engineer*
>
>
>
> *WhiteSource  **empowers businesses
> to develop better software *
> *by harnessing the power of open source*
> 
> 
> 
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BZxFhfexSVsYBbyA%3DQhGGtSzzPNxNQiqKtEA3Y8gmUqTHJbdA%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVfSazke1dcdPWRDU0gEwakqw9A9yq0-H%3DM4JX7B71n83g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Eugen Horovitz]

Hi Jesse ,

I did all the changes and still got the same errors..
I am probably still missing some important stuff... I am newbie in jenkins
plugin development and I will be greatfull if you can have a look.

https://gist.github.com/eugenhoro/f73f4d666c64ea809e6a6711a0e40ed3

maven fails to build and also this

mvn test -Djenkins.version=2.102 -Denforcer.skip=true

from https://jenkins.io/blog/2018/01/13/jep-200/

Thanks a lot

On Tue, Apr 10, 2018 at 3:50 PM, Jesse Glick  wrote:

> On Tue, Apr 10, 2018 at 2:25 AM, Eugen Horovitz
>  wrote:
> > Could not resolve dependencies for project org.jenkins-ci.plugins:
> whitesource:hpi:18.2.1-SNAPSHOT:
> > Failure to find org.jenkins-ci.main:jenkins-war:executable-war:2.102 in
> https://repo.jenkins-ci.org/public/
>
> Stop overriding the version of `maven-hpi-plugin` in your POM. The old
> version you are specifying does not work any more. Let it get picked
> up by the parent.
>
> For that matter, there is a bunch of other stuff in your POM which can
> and should be deleted. The configuration of `maven-compiler-plugin`,
> for example.
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/jenkinsci-dev/NI533mCeKgc/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/CANfRfr0EozZfCAVRLFMwOLg_Jj1UjPMVb-bpejW7HyQy%2BvrC0w%
> 40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
*Eugen Horovitz*

*Senior software engineer*



*WhiteSource  **empowers businesses
to develop better software *
*by harnessing the power of open source*




-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BZxFhfexSVsYBbyA%3DQhGGtSzzPNxNQiqKtEA3Y8gmUqTHJbdA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Essentials] Instance Health Checking JEP: ready for first review

[Jesse Glick]

On Tue, Apr 10, 2018 at 10:33 AM, R. Tyler Croy  wrote:
> Do you have some reasoning for this you could share?

Merely that “nothing in particular is broken” is not news, so there is
not much a client needs to know.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0df4JRZiyr0hEgHxzvTyw0XL3JDk1OMRgZdHnyuGzQcw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Essentials] Instance Health Checking JEP: ready for first review

[R. Tyler Croy]

(replies inline)

On Tue, 10 Apr 2018, Jesse Glick wrote:

> I for one would find it easier to comment on a PR, but IIRC JEP
> editors have discouraged this for some reason
> 
> 
> ???Healthness??? is not a word???it is just ???health???.
> 
> 
> I would suggest `/metrics/evergreen/healthcheck` just return an empty
> JSON document, or a simple ???OK??? marker by default???only listing things
> that are _not_ healthy.

It was my understanding that this format was simply the Dropwizard healthcheck
format.

Do you have some reasoning for this you could share? Otherwise this seems like
a bit of personal preference to me, but I'm sure there's some logic I could be
missing here.




-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/20180410143346.discdbodxgiudmfz%40grape.lasagna.io.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

Re: [Essentials] Instance Health Checking JEP: ready for first review

[Jesse Glick]

I for one would find it easier to comment on a PR, but IIRC JEP
editors have discouraged this for some reason…?


“Healthness” is not a word—it is just “health”.


I would suggest `/metrics/evergreen/healthcheck` just return an empty
JSON document, or a simple “OK” marker by default—only listing things
that are _not_ healthy.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2U160HAC7VTSe%2B4UXz2TMokTmBnxFVNhbwD-CtZG_%2BZA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Startup deadlock when using a GlobalConfiguration + Initializer < JOB_LOADED

[Jesse Glick]

While changing the initializer settings may have happened to solve the
issue in this case, the advice is not generally applicable. Use
JENKINS-50663 for discussion.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1B6WZMdo2DHVYdETSTXiaomQKsPKqcg-UVnzAMfDbLPA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Jesse Glick]

On Tue, Apr 10, 2018 at 2:25 AM, Eugen Horovitz
 wrote:
> Could not resolve dependencies for project 
> org.jenkins-ci.plugins:whitesource:hpi:18.2.1-SNAPSHOT:
> Failure to find org.jenkins-ci.main:jenkins-war:executable-war:2.102 in 
> https://repo.jenkins-ci.org/public/

Stop overriding the version of `maven-hpi-plugin` in your POM. The old
version you are specifying does not work any more. Let it get picked
up by the parent.

For that matter, there is a bunch of other stuff in your POM which can
and should be deleted. The configuration of `maven-compiler-plugin`,
for example.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0EozZfCAVRLFMwOLg_Jj1UjPMVb-bpejW7HyQy%2BvrC0w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

validating-string-parameter-plugin PR's

[Slide]

Based on the comments to a PR I created to fix the build of the
validating-string-parameter-plugin, it looks like there is no maintainer
[1]. I would like to take temporary maintainership to get some of the PR's
merged and get the plugin into a better state. The only person in the
repository permissions file [2] for this plugin is vlatombe, who commented
that he no longer maintains the plugin.


1 -
https://github.com/jenkinsci/validating-string-parameter-plugin/pull/10#issuecomment-379685163
2 -
https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-validating-string-parameter.yml

Thanks,

Alex

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVcj3bd4nVxy98Sq8Jz%3DZHoAvix%3DTnfOLds0TYGGmG6pyQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Essentials] Instance Health Checking JEP: ready for first review

[Baptiste Mathus]

Sorry, the right link is
https://github.com/batmat/jep/tree/JENKINS-50294/jep/

2018-04-10 14:09 GMT+02:00 Baptiste Mathus :

> Hello everyone,
>
> Just published the draft of the JEP for the "Essentials Instance Client
> Health Checking", it is ready for, and warmly welcoming, review:
>
> https://github.com/batmat/jep/blob/JENKINS-50294/README.adoc
>
> To sum up, this will be the *component* used to decide if we trigger a
> rollback or not after we ran an upgrade. (in which case, we will roll back
> using jep-302 ).
>
> Please answer with your feedback in this thread as much as possible.
>
> Thank you!
>
> PS: context is https://issues.jenkins-ci.org/browse/JENKINS-50294
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS5_CWd5nfzXoivoy%3D%3DoUrDMwc-6KQ%2B9Ji_%3DJ7zmPZmMEw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Essentials] Instance Health Checking JEP: ready for first review

[Baptiste Mathus]

Hello everyone,

Just published the draft of the JEP for the "Essentials Instance Client
Health Checking", it is ready for, and warmly welcoming, review:

https://github.com/batmat/jep/blob/JENKINS-50294/README.adoc

To sum up, this will be the *component* used to decide if we trigger a
rollback or not after we ran an upgrade. (in which case, we will roll back
using jep-302 ).

Please answer with your feedback in this thread as much as possible.

Thank you!

PS: context is https://issues.jenkins-ci.org/browse/JENKINS-50294

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS55c6LXzLOx1wyW0h%3D2%2Br0DyQejLesbNUKP3u-VNF6VRQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Startup deadlock when using a GlobalConfiguration + Initializer < JOB_LOADED

[Baptiste Mathus]

AIUI, interesting to read and related:
https://www.cloudbees.com/blog/jenkins-plugin-developer-case-files-episode-1-when-extensions-bites-you-posterior

2018-04-10 12:26 GMT+02:00 Julien HENRY :

> My point was to clarify the specific case of GlobalConfiguration. I'm not
> pretending any Initializer should be after JOB_LOADED.
>
> The deadlock was sneaky, because it can only be reproduced if you have
> previous config data. So we haven't spotted it during our tests (because we
> start from a clean env) and we ended up releasing something broken.
>
> Julien Henry | SonarSource
>
> Developer
> https://sonarsource.com
>
> 2018-04-10 11:59 GMT+02:00 Daniel Beck :
>
>>
>> > On 10. Apr 2018, at 11:51, Julien HENRY 
>> wrote:
>> >
>> > If you look at the stacktraces, the deadlock occurs in the constructor
>> of the GlobalConfiguration, because it ends up calling OldDataMonitor that
>> itself access ExtensionList, and that seems to conflict with other plugins
>> like GitSCM that also access ExtensionList from its Initializer.
>>
>>
>> Right, so in this case it depends on the class you extend. More
>> convoluted, but still doesn't look like it can never be earlier than
>> JOB_LOADED…?
>>
>> --
>> You received this message because you are subscribed to a topic in the
>> Google Groups "Jenkins Developers" group.
>> To unsubscribe from this topic, visit https://groups.google.com/d/to
>> pic/jenkinsci-dev/hyMmQ-eDDVo/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to
>> jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/ms
>> gid/jenkinsci-dev/486CA78C-5D51-4FF3-AE39-021CC3499A17%40beckweb.net.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/CAD9wyxE%3DmHzo8SQtLhb9ReNQo4ngkMUj8bJk
> LeMEzbAVVC79UA%40mail.gmail.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS4rwYnx04eYiLLD5BvfNk_N7EZ2T9BV3xppkNKJc3zJ0g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Startup deadlock when using a GlobalConfiguration + Initializer < JOB_LOADED

[Daniel Beck]

> On 10. Apr 2018, at 10:39, Julien HENRY  wrote:
> 
> Could it be possible to improve the situation, by at least completing the 
> Javadoc, or maybe detecting and failing fast when a GlobalConfiguration tries 
> to use an Initializer earlier than JOB_LOADED ?
> 

It probably depends on what your initializer does.

I understand the Javadoc to mean that it needs to be PLUGINS_PREPARED _or 
later_ -- if that (or something similar) would have helped, just file a PR to 
core. Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/61B2D983-17C5-42B8-86D4-731E7E2F5D04%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

Startup deadlock when using a GlobalConfiguration + Initializer < JOB_LOADED

[Julien HENRY]

Hi,

Our plugin uses a GlobalConfiguration extension, and to migrate old data, 
we added an Initializer.

Following the javadoc 

 
of Initializer, I set after=PLUGINS_PREPARED

@Extension
public class MyGlobalConfiguration extends GlobalConfiguration {

  public MyGlobalConfiguration() {
load();
  }

  @Initializer(after = InitMilestone.PLUGINS_PREPARED)
  public void migrateData() {
// ...
  }

}

But this lead to a startup deadlock.

"GitSCM.onLoaded":
 waiting for ownable synchronizer 0x85777f80, (a 
java/util/concurrent/locks/ReentrantLock$NonfairSync),
 which is held by "MyGlobalConfiguration.migrateData"
"MyGlobalConfiguration.migrateData":
  waiting to lock Monitor@0x7f9ef0282808 (Object@0x84f2b888, a 
hudson/ExtensionList$Lock),
  which is held by "GitSCM.onLoaded"

Seems that the OldDataMonitor is somehow involed in the deadlock (see stack 
traces).

After spending a lot of time on it, I found the solution in the logstash 

 
plugin: change the Initializer to after=JOB_LOADED

Could it be possible to improve the situation, by at least completing the 
Javadoc, or maybe detecting and failing fast when a GlobalConfiguration 
tries to use an Initializer earlier than JOB_LOADED ?

Thread 5233: (state = BLOCKED)
 - hudson.ExtensionList.ensureLoaded() @bci=40, line=303 (Interpreted frame)
 - hudson.ExtensionList.iterator() @bci=6, line=158 (Interpreted frame)
 - jenkins.model.Jenkins.getAdministrativeMonitor(java.lang.String) @bci=4, 
line=2109 (Interpreted frame)
 - hudson.diagnosis.OldDataMonitor.get(jenkins.model.Jenkins) @bci=3, 
line=82 (Interpreted frame)
 - hudson.diagnosis.OldDataMonitor.report(hudson.model.Saveable, 
java.util.Collection) @bci=196, line=217 (Interpreted frame)
 - hudson.util.RobustReflectionConverter.doUnmarshal(java.lang.Object, 
com.thoughtworks.xstream.io.HierarchicalStreamReader, 
com.thoughtworks.xstream.converters.UnmarshallingContext) @bci=734, 
line=371 (Interpreted frame)
 - 
hudson.util.RobustReflectionConverter.unmarshal(com.thoughtworks.xstream.io.HierarchicalStreamReader,
 
com.thoughtworks.xstream.converters.UnmarshallingContext) @bci=11, line=270 
(Interpreted frame)
 - com.thoughtworks.xstream.core.TreeUnmarshaller.convert(java.lang.Object, 
java.lang.Class, com.thoughtworks.xstream.converters.Converter) @bci=15, 
line=72 (Interpreted frame)
 - 
com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(java.lang.Object,
 
java.lang.Class, com.thoughtworks.xstream.converters.Converter) @bci=175, 
line=65 (Interpreted frame)
 - 
com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(java.lang.Object, 
java.lang.Class, com.thoughtworks.xstream.converters.Converter) @bci=82, 
line=66 (Interpreted frame)
 - 
com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(java.lang.Object, 
java.lang.Class) @bci=4, line=50 (Interpreted frame)
 - 
com.thoughtworks.xstream.core.TreeUnmarshaller.start(com.thoughtworks.xstream.converters.DataHolder)
 
@bci=20, line=134 (Interpreted frame)
 - 
com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.unmarshal(java.lang.Object,
 
com.thoughtworks.xstream.io.HierarchicalStreamReader, 
com.thoughtworks.xstream.converters.DataHolder, 
com.thoughtworks.xstream.converters.ConverterLookup, 
com.thoughtworks.xstream.mapper.Mapper) @bci=15, line=32 (Interpreted frame)
 - 
com.thoughtworks.xstream.XStream.unmarshal(com.thoughtworks.xstream.io.HierarchicalStreamReader,
 
java.lang.Object, com.thoughtworks.xstream.converters.DataHolder) @bci=15, 
line=1189 (Interpreted frame)
 - 
hudson.util.XStream2.unmarshal(com.thoughtworks.xstream.io.HierarchicalStreamReader,
 
java.lang.Object, com.thoughtworks.xstream.converters.DataHolder, boolean) 
@bci=54, line=160 (Interpreted frame)
 - 
hudson.util.XStream2.unmarshal(com.thoughtworks.xstream.io.HierarchicalStreamReader,
 
java.lang.Object, com.thoughtworks.xstream.converters.DataHolder) @bci=5, 
line=131 (Interpreted frame)
 - 
com.thoughtworks.xstream.XStream.unmarshal(com.thoughtworks.xstream.io.HierarchicalStreamReader,
 
java.lang.Object) @bci=4, line=1173 (Interpreted frame)
 - hudson.XmlFile.unmarshal(java.lang.Object, boolean) @bci=102, line=178 
(Interpreted frame)
 - hudson.XmlFile.unmarshal(java.lang.Object) @bci=3, line=161 (Interpreted 
frame)
 - hudson.model.Descriptor.load() @bci=15, line=893 (Interpreted frame)
 - hudson.plugins.sonar.MyGlobalConfiguration.() @bci=18, line=49 
(Interpreted frame)
 - 
hudson.plugins.sonar.MyGlobalConfiguration$$FastClassByGuice$$9ca8165c.newInstance(int,
 
java.lang.Object[]) @bci=24 (Interpreted frame)
 - 
com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(java.lang.Object[])
 

Re: Request to become maintainer of the statistics-gatherer-plugin

[Luca Milanesio]

2 weeks sound good to me, and yes, I always avoid forks :-)

Luca.

> On 10 Apr 2018, at 08:02, Joseph P  wrote:
> 
> Usually the wait period is 2 weeks :) I would not recommend creating another 
> plugin.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/8b9ce146-6cf1-4b5a-a702-108ffe540d29%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/8CBEDFB2-204A-4096-880A-6EA8D6B381B0%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Request to become maintainer of the statistics-gatherer-plugin

[Joseph P]

Usually the wait period is 2 weeks :) I would not recommend creating another 
plugin.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/8b9ce146-6cf1-4b5a-a702-108ffe540d29%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Request to become maintainer of the statistics-gatherer-plugin

[Daniel Beck]

> On 10. Apr 2018, at 08:45, Luca Milanesio  wrote:
> 
> What is the wait time for getting this escalated and giving the possibility 
> to fix bugs on the plugin?
> Alternatively, should I just submit a brand-new plugin proposal? (which could 
> cause confusion: people may not know which one is "active")

Two weeks is the typical waiting time after reaching out to maintainers 
directly.

Up to you whether you create a new plugin, but like you point out, "plugin 
overload" has in the past been a source for user confusion and irritation.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/1FC91AC2-A988-4881-B641-7F0ECFF23D73%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

Re: Request to become maintainer of the statistics-gatherer-plugin

[Luca Milanesio]

PIng ... any feedback from the current maintainer?

What is the wait time for getting this escalated and giving the possibility to 
fix bugs on the plugin?
Alternatively, should I just submit a brand-new plugin proposal? (which could 
cause confusion: people may not know which one is "active")

Thanks for the feedback.

Luca.

> On 9 Apr 2018, at 11:07, Luca Milanesio  wrote:
> 
> 
> 
>> On 9 Apr 2018, at 11:01, Daniel Beck  wrote:
>> 
>> 
>>> On 9. Apr 2018, at 09:15, Luca Milanesio  wrote:
>>> 
>>> a) His e-mail is not public, not even to the members of the JenkinsCI org
>>> b) He doesn't respond to mentions in GitHub
>>> 
>>> Does anybody have a pointer or address to reach him?
>> 
>> For future reference, the way I typically do this:
>> 
>> Check https://github.com/jenkins-infra/repository-permissions-updater for 
>> authorized uploader user names.
>> If that list is empty (~ no release in 3+ years), check uploader user names 
>> of previous releases in Artifactory.
>> 
>> Then log in to Jira, 
>> https://issues.jenkins-ci.org/secure/ViewProfile.jspa?name= and append the 
>> user name(s) you found.
> 
> Yep, that the one I found as well :-)
> Let's see his feedback on the mailing list.
> 
> I found some activity in Jira a few months ago, hopefully he is still 
> following the project !
> 
> Luca.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/1BFFA5A0-37F7-4957-B8AE-7B3C7D902F84%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: jep-200 issue

[Eugen Horovitz]

Hi Jesse,

Thanks a lot for your reply .
now getting different error :

Could not resolve dependencies for project
org.jenkins-ci.plugins:whitesource:hpi:18.2.1-SNAPSHOT:
Failure to find org.jenkins-ci.main:jenkins-war:executable-war:2.102 in
https://repo.jenkins-ci.org/public/
 was cached in the local repository, resolution will not be reattempted
until the update interval of repo.jenkins-ci.org has elapsed or updates are
forced -> [Help 1]

Any ideas ?
Thanks !



On Mon, Apr 9, 2018 at 7:56 PM, Jesse Glick  wrote:

> On Mon, Apr 9, 2018 at 12:28 PM,
>  wrote:
> > mvn test -Djenkins.version=2.102 -Denforcer.skip=true
> >
> > but this fails with "Failure to find
> > org.jenkins-ci.main:jenkins-war:jar:war-for-test:2.102 "
>
> You need to use a newer parent POM—at least 2.30.
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/jenkinsci-dev/NI533mCeKgc/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/CANfRfr3Qm-msf_LBEJ6xspA3ceVTpMCkikBycjn7Q_
> AgK%3DpKAQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
*Eugen Horovitz*

*Senior software engineer*



*WhiteSource  **empowers businesses
to develop better software *
*by harnessing the power of open source*




-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BZxFhe3_z879_oJmHDncjXpB1ruEZXkY2Cj6L72i42qbMChCQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.