[josm-dev] Cleaning up i18n/build.xml
Hi all,
Recently, I started contributing to OpenStreetMap. I would like to
contribute to JOSM as well. To start, I wanted to improve some Finnish
translations. However, I noticed a few problems with
http://svn.openstreetmap.org/applications/editors/josm/i18n/build.xml
that I would like to fix first.
The attached patch removes some exec rules and adds a dependency on
gettext-ant-tasks. It also ensures that the files will be processed
in a fixed order. Thus, the diffs to i18n/po/*.po should become much
smaller and more readable than with the current solution of running find
and not sorting the output.
I would have committed it already, but I think
that the best place for the added .jar file is in core/lib, and I
don't have commit access to that repository. Could someone
add gettext-ant-tasks-0.9.3.jar to
http://josm.openstreetmap.de/svn/trunk/lib, so that I can commit
the attached patch to
http://svn.openstreetmap.org/applications/editors/josm/i18n/, please?
Best regards,
Marko Mäkelä
http://www.openstreetmap.org/user/skela/
Property changes on: i18n
___
Name: svn:ignore
- java_sourcefiles.txt
trans_*.java
build
+ build
Index: i18n/build.xml
===
--- i18n/build.xml (revision 13392)
+++ i18n/build.xml (working copy)
@@ -15,57 +15,51 @@
property name=ant.build.javac.target value=1.5/
- target name=josm.pot
-exec executable=perl output=trans_presets.java
+ property name=gettexttasks.jar value=${josm.build.dir}/lib/gettext-ant-tasks-0.9.3.jar/
+
+ target name=init.gettext description=Loads the Ant gettext tasks
+taskdef name=gettext-extract classname=org.xnap.commons.ant.gettext.GettextExtractKeysTask classpath=${gettexttasks.jar}/
+taskdef name=gettext-merge classname=org.xnap.commons.ant.gettext.GettextMergeKeysTask classpath=${gettexttasks.jar}/
+taskdef name=gettext-dist classname=org.xnap.commons.ant.gettext.GettextDistTask classpath=${gettexttasks.jar}/
+ /target
+
+ target name=trans_.java
+mkdir dir=${i18n.build.dir}/
+exec executable=perl output=${i18n.build.dir}/trans_presets.java
arg line=convpreset.pl ${josm.presets}/
/exec
-exec executable=perl output=trans_style.java
+exec executable=perl output=${i18n.build.dir}/trans_style.java
arg line=convstyle.pl ${josm.style}/
/exec
-exec executable=perl output=trans_validator.java
+exec executable=perl output=${i18n.build.dir}/trans_validator.java
arg line=convvalidator.pl ${validator.tagfile}/
/exec
-exec executable=perl output=trans_wms.java
+exec executable=perl output=${i18n.build.dir}/trans_wms.java
arg line=convwms.pl ${wms.srcfile}/
/exec
-exec executable=perl output=trans_surveyor.java
+exec executable=perl output=${i18n.build.dir}/trans_surveyor.java
arg line=convsurveyor.pl ${surveyor.srcfile}/
/exec
+ /target
-exec executable=find output=java_sourcefiles.txt osfamily=unix
- arg value=${josm.build.dir}/src /
- arg value=${plugin.dir}/
- arg value=./
- arg value=-name/
- arg value=*.java/
-/exec
-
-exec executable=xgettext
- arg line=-ktr -ktrn:1,2 -ktrc -kmarktr -Ljava --from-code=UTF-8 -opo/josm.pot -fjava_sourcefiles.txt/
-/exec
+ target name=po/josm.pot
+ description=Extracts message keys from the source code
+ depends=trans_.java,init.gettext
+gettext-extract keysFile=josm.pot poDirectory=po
+ keywords=-k -ktrc -ktr -kmarktr -ktrn:1,2 -ktrl
+ fileset dir=${josm.build.dir}/src includes=**/*.java/
+ fileset dir=${plugin.dir} includes=**/*.java/
+ fileset dir=${i18n.build.dir} includes=trans_*.java/
+/gettext-extract
/target
- target name=build depends=josm.pot
+ target name=build depends=po/josm.pot,init.gettext
copy file=i18n.properties todir=build/org/openstreetmap/josm /
-ant target=build-langproperty name=language value=bg//ant
-ant target=build-langproperty name=language value=cs//ant
-ant target=build-langproperty name=language value=da//ant
-ant target=build-langproperty name=language value=de//ant
-ant target=build-langproperty name=language value=el//ant
-ant target=build-langproperty name=language value=en_GB//ant
-ant target=build-langproperty name=language value=es//ant
-ant target=build-langproperty name=language value=fi//ant
-ant target=build-langproperty name=language value=fr//ant
-ant target=build-langproperty name=language value=he/property name=jlanguage value=iw_IL//ant
-ant target=build-langproperty name=language value=it//ant
-ant target=build-langproperty name=language value=nl//ant
-ant target=build-langproperty name=language value=pl//ant
-ant target=build-langproperty name=language value=ro//ant
-ant target=build-langproperty name=language value=ru
Re: [josm-dev] Patches
On Sun, Feb 01, 2009 at 11:37:46PM +0100, Dirk Stöcker wrote: Hello to all, please attach patches to Trac tickets. When this does not work try a zipped/gzipped/tar.gzipped/... version (but only when not working due to spam warning). It is much harder to to check whether patches are resolved or not when they are posted to the mailinglist. Sorry, I feel that this was directed at me. I committed some fixes to the tcx plugin last night. I don't have commit access to the JOSM core. Discussions here are fine, but stuff ready for checkin should be in the Trac. Does this apply only to the JOSM core? I have one non-core patch ready for checkin, which makes i18n/build.xml use gettext-ant-tasks. I didn't commit it yet, because I would like to have an official gettext-ant.tasks jar file that includes this fix: http://code.google.com/p/gettext-commons/issues/detail?id=9. Should I post the patch for i18n/build.xml to trac? Or should I commit it as it is now? The issue is that the files i18n/po/*.po would contain absolute, not relative, paths to the source files. Best regards, Marko Mäkelä ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Cleaning up i18n/build.xml
On Fri, Mar 06, 2009 at 12:24:51PM +0100, Dirk Stöcker wrote: On Tue, 3 Mar 2009, Marko Mäkelä wrote: Finally, http://code.google.com/p/gettext-commons/issues/detail?id=9 was fixed in gettext-ant-tasks-0.9.6.jar. I committed the patch to josm/i18n but did not commit the rebuilt po directory or generated files, because I didn't want to step on anyone's toes with that. You broke the i18n build at least in 4 places: a) he will not be build, as you removed the language renaming of previous build. he must be iw_IL inside of java or it wont work. b) the number of strings is no longer displayed, so I cannot check anmore if the translations are complete or the import process was faulty. c) The final josm-translations.jar contains the .java files, which is a waste of space. d) ant clean does not cleanup po directory anymore I'm sorry about this. I will try to fix these during the weekend. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Cleaning up i18n/build.xml
On Sun, Mar 08, 2009 at 03:36:24PM +0100, Dirk Stöcker wrote: On Sat, 7 Mar 2009, Marko Mäkelä wrote: There was a nother bug. You forgot the specialmessages.java file. I reverted your revert. The current version now uses gettext-ant task till msgmerge state and the java-file generating uses old style. Until the 2 problems are fixed this should be acceptable. Agreed. Great that you came up with this hybrid solution. After all, it's only the gettext-dist task that is lacking. I will keep an eye on the two gettext-ant-tasks issues that I filed, and will post here before doing any further commits. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Displaying the properties of GPX points
As a GNU/Linux user, I've been thinking of using JOSM as a poor man's Garmin Training Center that would display me the elevation profiles and heart rate and cadence statistics of my bike rides. Displaying the elevation profiles of GPX tracks would be a good start. Any suggestions? As far as I understand, I couldn't use the Garmin software even if I wanted, because it apparently doesn't run under WINE. I'm aware of http://viking.sourceforge.net, which can display the elevation data on the GPX trace itself. I'd prefer something that displayed the data in a mouse tooltip when the mouse cursor is positioned over the track and also in a 2D graph with the time on the horizontal axis and elevation (cadence, heart rate, speed, whatever things that can be derived from the data) in different colours on the vertical axis. I guess I could implement a mouse tooltip for the GPX layer that would display the timestamp, longitude, latitude, elevation, and possibly other attributes. I have no idea how to combine the above mentioned 2D graph with JOSM (or any map viewer, for that matter). Maybe right-clicking a point on the GPX layer could pop up a scrollable graph window that would show the data centered around the selected point. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Displaying the properties of GPX points
On Tue, Mar 10, 2009 at 02:07:41PM +0200, Marko Mäkelä wrote: As a GNU/Linux user, I've been thinking of using JOSM as a poor man's Garmin Training Center that would display me the elevation profiles and heart rate and cadence statistics of my bike rides. Displaying the elevation profiles of GPX tracks would be a good start. Any suggestions? As far as I understand, I couldn't use the Garmin software even if I wanted, because it apparently doesn't run under WINE. I'm aware of http://viking.sourceforge.net, which can display the elevation data on the GPX trace itself. I'd prefer something that displayed the data in a mouse tooltip when the mouse cursor is positioned over the track and also in a 2D graph with the time on the horizontal axis and elevation (cadence, heart rate, speed, whatever things that can be derived from the data) in different colours on the vertical axis. I was also pointed to ael, which is a Tcl/Tk application, partially a front-end to gpsbabel. It was slow and seemed to be geared towards a real-time connection to a GPS receiver. My Garmin Edge 705 only implements usb-storage, FAT and XML-based interchange formats. It doesn't send any NMEA sentences or anything like that. I guess I could implement a mouse tooltip for the GPX layer that would display the timestamp, longitude, latitude, elevation, and possibly other attributes. I have no idea how to combine the above mentioned 2D graph with JOSM (or any map viewer, for that matter). Maybe right-clicking a point on the GPX layer could pop up a scrollable graph window that would show the data centered around the selected point. I studied the code today, and it looks like the selection only works for objects of classes derived from OsmPrimitive. Neither the GPX layer nor the GPX data derives from OsmPrimitive. This is why GPX points can't be selected or right-clicked in JOSM. I fear that converting the data to OsmPrimitive objects would cost too much memory. In the JOSM framework, I could convert points based on query expressions to additional layers, e.g., points where I'm on the top of a hill. (Something similar to MarkersFromNamedPoints.) I could possibly also render the layer in different colors, e.g,. based on the speed. Given the difficulty of selecting GPX track points in JOSM, I think I will try to implement this in a map viewer application. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] [PATCH] Implement shop=alcohol
The attached patch makes shop=alcohol appear as shop=beverages in JOSM. According to http://wiki.openstreetmap.org/wiki/Tag:shop%3Dalcohol these two values of shop are equivalent, with the exception that shop=alcohol has a government license. In those countries where such a license is needed, shop=beverages would only sell beverages containing little or no alcohol. Please apply the patch. Marko Index: core/presets/presets.xml === --- core/presets/presets.xml (revision 1521) +++ core/presets/presets.xml (working copy) @@ -2427,6 +2427,11 @@ See also http://josm.openstreetmap.de/wi key key=shop value=organic / text key=name text=Name default= delete_if_empty=true / /item +item name=Alcohol icon=presets/empty.png type=node,closedway +label text=Edit Alcohol Shop / +key key=shop value=alcohol / +text key=name text=Name default= delete_if_empty=true / +/item item name=Beverages icon=presets/empty.png type=node,closedway label text=Edit Beverages Shop / key key=shop value=beverages / Index: core/styles/standard/elemstyles.xml === --- core/styles/standard/elemstyles.xml (revision 1521) +++ core/styles/standard/elemstyles.xml (working copy) @@ -2235,6 +2235,14 @@ in case they have same priority! Using p /rule rule + condition k=shop v=alcohol/ + icon annotate=true src=shop/beverages.png/ + area colour=shop#5f/ + scale_min1/scale_min + scale_max5/scale_max + /rule + + rule condition k=shop v=beverages/ icon annotate=true src=shop/beverages.png/ area colour=shop#5f/ ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] [PATCH] Implement shop=general
The attached patch makes JOSM recognize shop=general. Please apply. Marko Index: core/presets/presets.xml === --- core/presets/presets.xml (revision 1521) +++ core/presets/presets.xml (working copy) @@ -2458,6 +2458,12 @@ See also http://josm.openstreetmap.de/wi key key=shop value=garden_centre / text key=name text=Name default= delete_if_empty=true / /item +item name=General icon=presets/empty.png type=node,closedway +link href=http://wiki.openstreetmap.org/wiki/Tag:shop=general; / +label text=Edit General Store / +key key=shop value=general / +text key=name text=Name default= delete_if_empty=true / +/item item name=Hardware icon=presets/empty.png type=node,closedway link href=http://wiki.openstreetmap.org/wiki/Tag:shop=hardware; / label text=Edit Hardware Store / Index: core/styles/standard/elemstyles.xml === --- core/styles/standard/elemstyles.xml (revision 1521) +++ core/styles/standard/elemstyles.xml (working copy) @@ -2339,6 +2339,14 @@ in case they have same priority! Using p /rule rule + condition k=shop v=general/ + icon annotate=true src=shop.png/ + area colour=shop#5f/ + scale_min1/scale_min + scale_max5/scale_max + /rule + + rule condition k=shop v=groceries/ icon annotate=true src=shop/groceries/fruits.png/ area colour=shop#5f/ ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Displaying the properties of GPX points
On Tue, Mar 10, 2009 at 02:07:41PM +0200, Marko Mäkelä wrote: As a GNU/Linux user, I've been thinking of using JOSM as a poor man's Garmin Training Center that would display me the elevation profiles and heart rate and cadence statistics of my bike rides. Displaying the elevation profiles of GPX tracks would be a good start. Any suggestions? As far as I understand, I couldn't use the Garmin software even if I wanted, because it apparently doesn't run under WINE. I came across MyTourbook http://mytourbook.sourceforge.net/ today. It does a good job at visualizing Garmin TCX files on OpenStreetMap tiles, among many other things. It is based on Java SWT and Eclipse RCP (Rich Client Platform). The source code license is GNU GPL. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Deletion conflicts
On Tue, Apr 28, 2009 at 11:32:51AM +0200, Rolf Bode-Meyer wrote: 2009/4/27 Frederik Ramm frede...@remote.org: (Incidentally - how can a node have only one version and this is deleted? Would one not have to first create the node, making v1, then delete it, making v2?) Why? Deleting doesn't create a version of the deleted element. I don't think CVS does either. CVS (and RCS, I think) do in a sense create a version of the deleted element, by moving the ,v file to an Attic directory in the repository. I think that the revision-per-tree approach of Subversion makes much more sense than the revision-per-file approach of CVS and RCS. The Subversion model could be impractical for OSM, though. There are so many objects being edited concurrently, all over the world. While someone is working on a small local change, the global revision count could easily grow by hundreds or thousands. How do distributed revision control systems solve this problem? Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] geotagged images proposal
On Tue, Sep 01, 2009 at 03:01:14AM +0200, Martin Koppenhoefer wrote: I was using a separate script in windows for this (haven't yet managed in Linux but I guess it available as well), that was writing those coordinates into the images. With JOSM-Plugin Agpifoj you can read and automatically align them afterwards in JOSM - but I agree that it would be nice as well to have JOSM able to write them. For what it is worth, Debian GNU/Linux includes a package of the gpscorrelate program. One minor annoyance in it that I have not bothered to fix yet is that it can process only one GPX trace at a time. I sometimes split the traces into logical steps while recording them, but I cannot do the same for the photos. So, I have merged GPX traces in a text editor when needed. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Two patches for the Validator plugin
Hi, Sorry if I am giving the impression of being too impatient, but I have submitted two patches on Trac. As an outsider or hang-around member of the JOSM developer community, I am not familiar with the workflow. Will the Trac tickets containing the patches be eventually accepted or rejected by someone, or would it be better to send reminders on this list? Or should I look up the owner of a component somewhere and bug the owner directly? The patches in question are these two, both for the Validator plugin: http://josm.openstreetmap.de/ticket/3412 Check for missing name:* translations http://josm.openstreetmap.de/ticket/3669 NodesWithSameName with unique ref The latter (#3669) suppresses bogus nodes with same name warnings for bus stops and other nodes that carry a unique ref tag. Dirk already replied that the whole check should be dropped, but I think that it is useful. Best regards, Marko (user Skela) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Relation link text
On Mon, Oct 12, 2009 at 11:18:27PM +0200, Stephan Knauss wrote: I still think the symbols and the names do not fit. My suggestion is to patch it to look like this: 7 head_to_head(--), 8 tail_to_tail(--), 9 head_to_tail(--), 10tail_to_head(--); A line in the editor having that symbol -- would then show a way connected to the next way (line below), the direction of the way pointing in direction of the next way. What about replacing the ASCII art with real Unicode arrows (U+2190 LEFTWARDS ARROW ← and U+2192 RIGHTWARDS ARROW →)? Java uses Unicode natively, but some very old font might lack the glyphs. That might be the case for some of the triangles in the U+25B6 to U+25C5 range. Those could be more readable than the arrows, e.g., ▶◀ or ▻◅. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Two patches for the Validator plugin
On Sat, Oct 10, 2009 at 09:47:07PM +0200, Dirk Stöcker wrote: On Sat, 10 Oct 2009, Marko Mäkelä wrote: Sorry if I am giving the impression of being too impatient, but I have submitted two patches on Trac. As an outsider or hang-around member of the JOSM developer community, I am not familiar with the workflow. Will the Trac tickets containing the patches be eventually accepted or rejected by someone, or would it be better to send reminders on this list? Or should I look up the owner of a component somewhere and bug the owner directly? Patches which hang for longer time usually have somedrawbacks, as discussions for both tickets show. For both I'm still not really convinced that the patches improve the current situation. I understand your concerns on #3412, which proposes a new validator check. But I do not share your view on #3669, which removes one class of bogus validator warnings. I realized that I have commit access to the JOSM plugin tree, and I took the liberty of committing the #3669 patch. I will hold back #3412 for now, because the anonymous critic has not followed up on my reply. Another class of bogus warnings that have been disturbing me is UnconnectedWays complaining about natural=cliff or barrier=fence next to a road. I might attack that next. Best regards, Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Localisation policy for quotes etc.
Resurfacing from lurk mode. (I have been more active with mkgmap lately.) On Wed, Jan 13, 2010 at 09:33:24AM -0500, Matthias Julius wrote: BTW, I came across a number of strings where single quotes were not escaped. So I think this overhaul is a good thing. You could open another can of worms and replace the ' with the UTF-8 curly quote ’. :-) By the way, I filed two tickets against gettext-commons a long time ago. Some weeks ago, the tickets were updated: http://code.google.com/p/gettext-commons/issues/detail?id=30 http://code.google.com/p/gettext-commons/issues/detail?id=31 I should get around to checking if the i18n/build.xml could be rewritten to use the portable ant tasks instead of invoking the gettext tools directly. Best regards, Marko (User:Skela) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Please don't delete http://josm.openstreetmap.de/wiki/HaitiLessonsLearned
Hi, On Thu, Jan 28, 2010 at 09:49:10AM +0100, Karl Guggisberg wrote: Hi, you're free to create trac tickets as you wish and you already did. This page is by no means a replacement of trac ticketing system and I ask you again not to delete it. If these are personal notes, then why use an common wiki page instead of a personal file on your harddisk? Because I did so. I don't have to justify. Sorry for jumping in, but I have a suggestion for you. I understand Dirk's points, but I do see some merit in the notes too. I can think of three places for the notes that could be more suitable or appropriate: http://www.openstreetmap.org/diary http://wiki.openstreetmap.org/wiki/User:* http://wiki.openstreetmap.org/wiki/WikiProject_Haiti Karl, could you consider moving the notes to one or more of these places? Best regards, Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Wireframe saves the day for a complex multipolygon
On Sat, Feb 06, 2010 at 07:42:30PM +0100, Sebastian Klein wrote: There is a wireframe mode in the view menu. This could be useful for tracing. I found the wireframe mode essential today when defining a lake multipolygon in JOSM r2711 (oldish, I know). Without wireframe, JOSM dozed for maybe 20 seconds between every action. Even selecting menus did not work. If you want to repeat this, check Lake Inari http://www.openstreetmap.org/browse/relation/402543. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Wireframe saves the day for a complex multipolygon
Jiri, thanks for your quick response! On Sun, Feb 07, 2010 at 11:09:09AM +0100, Jiri Klement wrote: Multipolygon painting speed was improved in 2793, but Lake Inari was very slow anyway, because it contains multiple outer polygons. I've added optimalization for this case today (r2948). Btw. outer polygons are not used correctly in the lake, when there is small lake inside of island on the big lake, the small lake shouldn't be part of the big lake multipolygon. I followed the example on the wiki page http://wiki.openstreetmap.org/wiki/Relation:multipolygon which does suggest that lakes within islands can be defined as role=outer: --- start quote --- From the possibility of having multiple outer rings in one relation, it also follows that you can easily model islands within a hole: relation id=1 tag k=type v=multipolygon / member type=way id=1 role=outer / member type=way id=2 role=inner / member type=way id=3 role=outer / /relation A construct like this would previously have required different multipolygon relations, one with way 1 being outer and way 2 being inner, as well as one with way 2 being outer and way 3 being innner. Such cascading is still recommended when the island in the middle is something else than the area on the outside, but where the island is the same stuff it can just be made a hole in the hole. --- end quote --- Admittedly, the lakes within islands are not the same stuff as the outer lake (they should at least be called something else than the main lake). I will fix this soonish, also to give mkgmap's multipolygon code some further exercise. (Mkgmap must split multipolygons to normal polygons for Garmin.) Another problem that I had with multipolygons was defining one for Kemijärvi today (http://www.openstreetmap.org/browse/changeset/3812690, http://www.openstreetmap.org/browse/relation/403320). JOSM complained about intersecting lines, not saying which lines, but I could not see anything special on the screen, except some almost-self-intersecting outer coastline. Based on the node count given (5008 IIRC), I guessed that it would be the outer coastline that JOSM is complaining about. The outer coastline would consist of 9*500+508 nodes. One last thing: Is there an easy way to download a way, node or relation by the browse URL? I have clicked in the web browser to a random node and copied the coordinate URL to JOSM. I wish there were a simpler method. Also, would it be possible to download select relation members in the relation browser, say, if I only want to tweak the coastline but not the islands? There are many complex lakes in Finland. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Wireframe saves the day for a complex multipolygon
On Sun, Feb 07, 2010 at 02:06:51PM -0500, Matthias Julius wrote: I followed the example on the wiki page http://wiki.openstreetmap.org/wiki/Relation:multipolygon which does suggest that lakes within islands can be defined as role=outer: I wrote that Wiki page and I still think it makes sense. This method (where there may be additional outers inside inners) also conforms to the OGC simple features geometry rules, i.e. everybody does it. This might be correct use of the Multipolygon relation, but is the lake on the island really part of the outer lake? If it is a separate lake with its own name I would say it should be a separate object for OSM. I think that the lakes-within-islands would be separate lakes, and thus Jiri is right: they should be excluded from the big-lake multipolygon. When they were included in role=outer, mkgmap gave them the name of the multipolygon. Someone already fixed this by removing the lakes-within-islands from the multipolygon relation and by removing natural=land from the islands, so that the islands would be empty and no multipolygons will be needed for them. The proper solution would be to keep the natural=land and define separate multipolygons for each island that contains lakes. I might do that later. Thanks to Frederik for the exact Download URL tip. It would be helpful if JOSM would accept the http://api.openstreetmap.org/api/0.6/relation/402543 also on the command line. It would also be very helpful if JOSM rewrote the following types of URLs to API urls: http://www.openstreetmap.org/browse/relation/402543 http://www.openstreetmap.org/?relation=402543 Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Wireframe saves the day for a complex multipolygon
On Sun, Feb 07, 2010 at 09:33:59PM +0200, Teemu Koskinen wrote: I fixed them, but i disagree on the correctness of natural=land. The multipolygon relation already unambiguously says that the holes are land if there's no other tags sayng that it's eg. wood etc. Thanks for stepping forward and explaining this. Your change note did not specify what was done or why it was done. Given that Northern Finland is very sparsely populated and there are very few roads in the Inarinjärvi area, I would make an educated guess that most of the islands are uninhabited, in more or less natural state. In more populated areas, I would hesitate to make educated guesses for landuse, and I could leave the island polygons untagged until more is known about them. Also if the lake-within-island doesn't itself have islands, it doesn't need to be a multipolygon, as it is residing in the hole (island) of the larger lake. As long as the island is given some tags that identify it as an area, I believe that multipolygons have to be defined for the island-with-lakes. I defined multipolygons for the few Inarinjärvi islands with lakes. For what it is worth, I replaced the natural=land tags to the islands last night, before reading your message. Feel free to remove them again; I do not want to get into an edit war. Best regards, Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Wireframe saves the day for a complex multipolygon
On Mon, Feb 08, 2010 at 07:13:08AM -0500, Matthias Julius wrote: Marko Mäkelä marko.mak...@iki.fi writes: As long as the island is given some tags that identify it as an area, I believe that multipolygons have to be defined for the island-with-lakes. Why? You don't consider the lake on the island as part of the island? Not any more than I would consider the island on the lake as part of the lake. For instance, should an island polygon be tagged landuse=residential, the lake on the island would not be part of the residential area. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] self-intersecting ways
On Thu, Mar 04, 2010 at 06:39:34PM +0100, colliar wrote: Richard Welty schrieb: On 3/4/10 11:54 AM, Alan Mintz wrote: At 2010-03-03 14:31, Richard Welty wrote: From a technical standpoint, the land parcels do indeed usually extend out to the centerline of the roadway, but an easement is granted to the city/county/state for the road, utilities, etc., and the area within the easement may not be built upon by the landowner. IMO, that should exclude the area within the easement from the landuse boundary. and from a practical point of view, this is how they are in the database at the present time; nodes for landuse/areas are at the same locations as nodes in highways. I came accross this, too, and have to say it is quite a lot of work to get the landuse of the road and often you get conflicts later on these areas again. Maybe a tool for unglueing those objects and moving the area aubout 2 meters of would be nice or even a automatical fix by josm itself. +1. Some days ago, I came across a mkgmap warning for a dead-end oneway in a residential area that was riddled with landuse polygons that shared points with ways. It was very hard to see that the oneway was not connected to the road it was supposed to. I spent several minutes detaching the landuses from the roads in the area. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Function to select or download a sequence of ways?
Hi Karl, To the best of my knowlege there is no such function yet ... Now there is: http://wiki.openstreetmap.org/wiki/JOSM/Plugins/WaySelectorPlugin Thanks to your reply and the availability of WayDownloaderPlugin source code, I got an easy start. I posted some ideas for further development to the above wiki page, but the plugin already scratches my itch (selecting the mainland coastline in a large natural=coastline map extract). (3) you can listen to the current selection. See org.openstreetmap.josm.data.osm.event.SelectionEventManager I might look at this later, to update the enabled/disabled state of the plugin based on the current selection. Best regards, Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Function to select or download a sequence of ways?
Hello Martin, hello Stephan, On Mon, Mar 15, 2010 at 12:38:36AM +0100, Stephan Knauss wrote: Hello Martin, Martin Koppenhoefer wrote: another selection-feature I'm missing quite often (maybe it is already there and I don't know how to use it) is the use of the selection-rectangle to select ways but not nodes. Currently if you select by rectangle you will only select nodes, and ways completely surrounded. The selection I am talking about would select all ways intersected or completely within the selection rectangle, but not the contained nodes. I also don't know whether thnere is a more direct way or not. In case I need to select a bunch of ways I do like this: 1) Use rectangle to select area containing all desired ways (including all nodes. Hold alt-key to select ways that have nodes inside selection) 2) use search feature to search for type:node and remove from selection 3) in case selection contains relations, repeat step 2 with relations What I have done is select the area (or all objects) and then search for type:way in the selection. That can be combined with other attributes, such as type:way highway=primary. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Feature Request: Timed Save
On Thu, Jun 24, 2010 at 01:34:26PM +0200, Claudius wrote: Am 24.06.2010 11:37, Attila Szász: Personally I prefer doing a series of edits then I upload them in one single batch - probably because I am too lazy to add comments with every upload. The other scenario is that e.g. you lose your network connection while editing and obviously you don't want to lose your edits by closing JOSM down. It would be really handy to be able to continue later on. Save your edits as .osm file? And lose your undo history when reloading? Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Feature Request: Timed Save
On Thu, Jun 24, 2010 at 03:14:58PM +0200, M∡rtin Koppenhoefer wrote: 2010/6/24 Marko Mäkelä marko.mak...@iki.fi: On Thu, Jun 24, 2010 at 01:34:26PM +0200, Claudius wrote: Save your edits as .osm file? And lose your undo history when reloading? yes. IMHO that's a minor issue. If you're editing you might need a lot of undos for the last actions If the crash is unpredictable, you might need to undo some last actions after recovering from the *.osm file. +1 for an autosave action (sure, in the background would be very nice), configurable (on/off and time intervall in minutes) With a configurable file name pattern, it could be even more useful. Then you would have some history by having multiple snapshots of the work. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Manual zoom JOSM
On Sun, Jul 18, 2010 at 05:39:50PM -0400, Russ Nelson wrote: Paul Johnson writes: Ctrl-= doesn't do anything, and ctrl-shift-= (to get a plus) doesn't work. Ctrl-- works, but that only zooms me out. For whatever reason, it has to be Ctrl-KP+ even though Ctrl-- also works. FWIW, - and + work for me, using the Swedish/Finnish layout on my laptop (no mouse wheel, no numeric keypad). I believe that many European keyboard layouts have both keys reachable without the Shift key. Could it be that JOSM doesn't like the Shift key that is needed to get a + on the American keyboard? Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Change to changeset comment handling, RfD
On Tue, Aug 03, 2010 at 08:08:56PM -0400, Anthony wrote: The quality of my own changeset comments is absolutely irrelevant in this discussion; let's assume, if it gives you pleasure, that they are all just That might discredit the messenger, but not change anything about the message. I think that it is important to keep the two separate, the message and the messenger. minor haiti geometry repair fix source typo fix self-intersecting boundary move lake from one relation to other remove forest self-intersection Is that you? Being a programmer and a daily user of version control systems, I share Frederik's view that some effort should be made to write good changeset comments. They can be useful later, say, after several months or years. Of the above comments, I think that the first one is questionable, almost as bad as the fixes or adjustments regularly written by some long-time contributors. The remaining ones are descriptive, if the changesets contain just that (e.g., replace source=lndsat with source=Landsat, fix polygons or multipolygons). Nobody is perfect, at least not all the time. :-) Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Question about audio file mapping/synchronization
On Sat, Oct 23, 2010 at 11:08:42PM +0200, activityworkshop wrote: Unfortunately I wasn't able to figure out how to properly synchronize my audio files within JOSM, because I couldn't work out how to apply my timezone offset (GPS track in UTC, audio files in local time). Is this a feature that's planned, or is the idea to always reset the audio recorder (or camera) clock to UTC? For what it is worth, I have always kept my camera clocks at UTC, years before getting a GPS receiver. If I had an audio recorder, I would keep it at UTC as well. For some software, I set TZ=UTC0 so that they will do the right thing. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Question about audio file mapping/synchronization
On Sun, Oct 24, 2010 at 01:55:58PM +0200, M∡rtin Koppenhoefer wrote: For what it is worth, I have always kept my camera clocks at UTC, years before getting a GPS receiver. you can do this, but it will overcomplicate your life if you're interested in times. I do not understand how. The native file systems in *nix-like operating systems internally keep the time in UTC anyway. I see the file dates as is, because my copying script sets TZ=UTC0 so that the timestamps in the camera's FAT file system will be interpreted correctly. If I want to see the file dates in a different time zone, no problem, I just set TZ differently before ls. This arrangement avoids any adjustments due to daylight saving time or travelling across time zones. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Sorry, bad English...
On Tue, Dec 07, 2010 at 07:39:46PM +0100, Tobias Wendorff wrote: I think my topic was wrong: Microsoft gains access to aerial imagery Not necessarily. One of these should be correct: - OSM gains access to Microsoft's aerial imagery - Microsoft grants access to aerial imagery Microsoft must have gained access to aerial imagery (by signing a contract with or by acquiring a rightsholder) in such a way that it can grant access to OSM. Best regards, Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] get OsmPrimitive just by ID not knowing type
On Tue, Dec 21, 2010 at 09:54:00AM +0100, Frederik Ramm wrote: Is that a missing feature in JOSM or is it not possible to find an osm object at the server just knowing the id? There can be a way with ID 1, a node with ID 1, and a relation with ID 1. In other words, the ID consists of two components: the object type and the type-specific ID. If you want to convert it to a single number, you could (for now, until a new object type is introduced) use something like this: id=type + osm_id*3 where type=0 for node, 1 for way, 2 for relation Or use id=type | osm_id 3 if you want some room for future expansion (3 bits = type codes 0..7) Best regards, Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Netbeans // older josm code?
On Sat, Feb 26, 2011 at 12:45:04AM -0300, Werner Horsch wrote: Question I'm updating an old coded plugin and in order to understand some stuff I need to look to some old way.java file, probably from 2008 How do I find it? You can use svn log -v for this. If you know the directory where file was at that time, you can limit the search by giving an argument, such as svn log -v http://svn.openstreetmap.org/applications/editors/josm/plugins/x | less In the log output, using your favourite pager (less in the above example) you can search for the file name or the approximate date. Then you can do something like this: svn cat -r12345 http://svn.openstreetmap.org/applications/editors/josm/plugins/x/way.java svn update -r12345 plugins/x/way.java (if it exists in your working copy) svn checkout -r12345 plugins/x/way.java (Note that the JOSM core is at http://josm.openstreetmap.de/svn/trunk, but plugins are in the OpenStreetMap Subversion repository.) I suggest that you visit http://subversion.apache.org/docs/ or http://svnbook.red-bean.com/. Best regards, Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Taggen von übereinanderliegenden Ways in JOSM erkennen
On Sun, Mar 20, 2011 at 02:49:15PM +0100, Holger Schr@der wrote: Gibt es im JOSM eine Möglichkeit schnell zu erkennen, ob Nodes mit doppelten Ways verbunden sind? Wenn nicht, ist daran gedacht dies zu implementieren? Einigermaßen. Nodes, die zu mehreren Ways gehören, werden anders gezeichnet als Nodes, die nur mit einem Way verbunden sind. Und wie gesagt, die mittlere Maustaste ist praktisch. In English: Is it possible to quickly see in JOSM if nodes belong to duplicated ways? My answer: nodes that belong to multiple ways are drawn a little differently from nodes that belong to only one way. And, as it was pointed out, you can use the middle mouse button to select one of several overlapping elements. Schöne Grüße / Best regards, Marko Mäkelä ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Version 4327 is from 32nd of July.
On Tue, Aug 30, 2011 at 12:13:22PM +0200, Martin Koppenhoefer wrote: the startpage shows this: 2011-07-32 (4327) Select and delete mode now have better visual indication what the next action will do (highlighting, cursor changes). can this be changed to 2011-08-21 ? In the MySQL date arithmetics, it should be a funny way of writing 2011-08-01 :-) Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Plugin for Karlsruhe schema
On Tue, Oct 25, 2011 at 11:43:48PM +0200, Hartmut Holzgraefe wrote: Not saying that such a plugin doesn't make sense for certain areas in the world, but i haven't seen this by linear distance scheme in any place but the USA yet, so its probably low priority for the rest of the world, and definitely for all parts of Europe i've been to ... For what it is worth, Finland uses a somewhat similar numbering scheme in rural areas. If I remember correctly, the house number increments by one for every 10 metres from the start of the road. But, you can still have a,b,c suffixes to the house number if there are several houses sharing the same driveway to the rural road. So, I guess that the interpolation line would be helpful until someone fills in the real house numbers and driveways. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Loading a relation of numerous unconnected sections to my GPSr
On Fri, Jan 06, 2012 at 09:36:45PM -, Bob Hawkins wrote:
I am not sure where to post this question. so I shall place it on the
mkgmap development list, too.
I guess you could generate a separate map layer from this relation. See
my scripts at http://www.polkupyoraily.net/osm/ how I generate some
route relations. I misuse the Garmin time zone line for them. The Edge
705 renders them as a black line, and I can choose in the settings menu
which layers are visible.
I just added a bus route yesterday and edited the wiki
http://wiki.openstreetmap.org/wiki/Finland:HSL/bus. There, we use the
{{bus}} template, which takes 1 or 2 relation IDs as parameter. One link
that the template expands to is to a GPX provider. Would it do the trick
for you?
http://osmrm.openstreetmap.de/gpx.jsp?relation=23309
Marko
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Style: Icon depending on way tag?
On Wed, Apr 18, 2012 at 03:14:23PM +0200, Frederik Ramm wrote: On a general note, are the (AFAICS German) road signs that JOSM uses in its default style a good idea for an editor that is used (hopefully) the world over? I would say that they are useful in every country that follows the Vienna (Wien) convention on traffic signs (most of Europe, at least). There are minor variations, but it is better than having no icons, IMO. Marko ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] License for tracer2
On Mon, Oct 28, 2013 at 02:19:26PM +0100, Dirk Brünig wrote: The server I check out from http://subversion.assembla.com/svn/osm-tracer There is also an License file. But it is in written in Czech. Program lze bez omezení použít pro pøípravu dat do projektu OpenStreetMap. Program lze bez omezení šíøit a mìnit s tím, že bude zachována a pøiložena tato licence. Program ale nelze použít pro pøípravu dat, které by byly komerènì využity, aniž by pøed tímto využitím byly uploadovány do projektu OpenStreetMap pod licencí, kterou OSM vyžaduje. FWIW, I do not think that ø (U+00F8) exists in the Czech alphabet. I guess that it should be ř instead, because that is what 0xf8 is in latin2. Likewise, èì should probably be čě. I tried to translate this by recode utf8..latin1|recode latin2..utf8, but some characters were crippled, such as ž was replaced with z. This sentence looks alarming: Program ale nelže použít pro přípravu dat, které by byly komerčně vyuzity, ... Based on my very limited knowledge of Slavic languages, I am guessing that the 2 last words mean something like commercial utilization. If it is prohibiting that, it would be incompatible with the GPL. Best regards, Marko Mäkelä ___ josm-dev mailing list josm-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] API for GPX files
On Sat, Jan 18, 2014 at 04:58:35PM +, Gerhardus Geldenhuis wrote: I am playing around with gps data from a tracking company and need something that can easily visualize gps tracks. Have you looked at OpenLayers, which is Javascript for the web browser? It lets you display GPX files on top of map tiles (such as Mapnik tiles or even some aerial imagery sources). I did this some time ago for visualizing a route that I drew in JOSM. I highlighted some ways in JOSM and exported them as GPX. But, it sounds like you could skip the JOSM step altogether. Another option is to somehow render the data to map tiles and display those as a transparent layer on top of the base map layer. There are several web pages like this, highlighting public transit routes, skiing routes, you name it. On the server side it is very easy, you are just serving static files. Even the background map tiles would not have to be stored on your web server. If you are looking for a non-networked solution, you could check MyTourbook, which is an open source Java application. It will display training data from bicycle computers on top of a map. The colour of the trace can visualize different things, such as the speed or the heart rate. Best regards, Marko ___ josm-dev mailing list josm-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] license of data produced by JOSM
On Thu, Nov 20, 2014 at 12:51:55PM +0100, Tobias Wendorff wrote: Hi there, JOSM is one of the best mapping tools with topological support. In comparism to widely spread CAD software, like Microstation, it's reduced to the needs of a mapper. Missing features, like mapping bank/slops can easily be added by external python scripts. My clients often ask whether JOSM can be used for non-OSM data or mapped data strictly has to be release under ODbL (or similar). JOSM is licensed under the GNU GPL, which guarantees the four freedoms listed at https://gnu.org/philosophy/free-sw.html The first one seems to apply here: The freedom to run the program as you wish, for any purpose (freedom 0). Only if you import some data sources into JOSM and create a derivative work based on that, then the copyright licenses of those data sources could apply. If there are such terms and conditions, would it be possible to use OSM for commercial mapping when donating to the OSM foundation or JOSM developers? I know many people, who would pay a fee for using JOSM, since it's exactly what they need to simplify daily work and raise productivity. Of course, it is always a good idea to support the project, even if you are not legally required to do so. Marko (not an active JOSM developer) ___ josm-dev mailing list josm-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/josm-dev
