KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 76 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/76/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 08 Nov 2018 07:45:17 +
 Build duration:
12 min and counting
   CONSOLE OUTPUT
  [...truncated 446.34 KB...]   Creating library ..\..\..\lib\ftp.lib and object ..\..\..\lib\ftp.expmain_ghelp.cpp   Creating library ..\..\..\lib\remote.lib and object ..\..\..\lib\remote.exp   Creating library ..\..\..\lib\trash.lib and object ..\..\..\lib\trash.exp   Creating library ..\..\..\lib\file.lib and object ..\..\..\lib\file.exp[ 32%] Built target kio_file[ 32%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help_autogen/mocs_compilation.cpp.obj[ 32%] Building CXX object src/ioslaves/remote/kdedmodule/CMakeFiles/remotedirnotify.dir/remotedirnotifymodule.cpp.objremotedirnotifymodule.cppmocs_compilation.cppScanning dependencies of target kio_http[ 32%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.obj[ 33%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/http.cpp.objhttp.cpp   Creating library ..\..\..\lib\ftp.lib and object ..\..\..\lib\ftp.exp[ 33%] Built target kio_ftpxslt_help.cpp[ 33%] Building CXX object src/ioslaves/remote/kdedmodule/CMakeFiles/remotedirnotify.dir/__/debug.cpp.obj[ 33%] Linking CXX shared module ..\..\..\bin\kf5\kio\help.dll   Creating library ..\..\..\lib\remote.lib and object ..\..\..\lib\remote.exp[ 33%] Built target kio_remote[ 33%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_autogen/mocs_compilation.cpp.objmocs_compilation.cppScanning dependencies of target kioslave[ 33%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/httpauthentication.cpp.obj[ 33%] Building CXX object src/kioslave/CMakeFiles/kioslave.dir/kioslave.cpp.objkioslave.cpp   Creating library ..\..\..\lib\trash.lib and object ..\..\..\lib\trash.exp[ 33%] Built target kio_trashdebug.cpp[ 33%] Building CXX object src/ioslaves/remote/kdedmodule/CMakeFiles/remotedirnotify.dir/remotedirnotify_autogen/mocs_compilation.cpp.obj   Creating library ..\..\..\lib\help.lib and object ..\..\..\lib\help.expScanning dependencies of target kiod5c:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\ioslaves\http\parsinghelpers.cpp(281): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of datamocs_compilation.cpp[ 34%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/httpfilter.cpp.obj[ 34%] Linking CXX shared module ..\..\..\bin\kf5\kio\ghelp.dllC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\http\http.cpp(2029): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of dataC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\http\http.cpp(2029): warning C4267: 'initializing': conversion from 'size_t' to 'const int', possible loss of dataC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\http\http.cpp(2050): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of dataC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\kioslave\kioslave.cpp(96): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\include\qt5\QtCore/qstring.h(829): note: see declaration of 'QString::QString'C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\include\qt5\QtCore/qmetatype.h(1942): note: see declaration of 'QString'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\kioslave\kioslave.cpp(114): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\include\qt5\QtCore/qstring.h(829): note: see declaration of 'QString::QString'C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\include\qt5\QtCore/qmetatype.h(1942): note: see declaration of 'QString'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\ioslaves\http\http.cpp(2857): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of dataC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\kioslave\kioslave.cpp(118): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\include\qt5\QtCore/qstring.h(829): note: see declaration of 'QString::QString'C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\include\qt5\QtCore/qmetatype.h(1942): note: see declaration of 'QString'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\kioslave\kioslave.cpp(119): error C2248: 'QString::QString': cannot access private member declared in class 'QString'C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\include\qt5\QtCore/qstring.h(829): note: see declaration of 'QString::QString'C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\include\qt5\QtCore/qmetatype.h(1942): note: see declaration of 

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 75 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/75/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 06 Nov 2018 14:36:21 +
 Build duration:
1 day 17 hr and counting

Re: Regression in Frameworks - DBus Hangs

[Ben Cooksley]

On Sat, Nov 3, 2018 at 4:41 PM Ben Cooksley  wrote:
>
> Hi all,
>
> Following commits made to Frameworks somewhere in the October 21 to
> October 28 time frame, the unit tests of Konsole on the CI system have
> started to hang following completion.
>
> This hang is occurring due to a behaviour of CTest, where it will wait
> (indefinitely) following the conclusion of a test for processes
> spawned by that test to exit.
>
> Previously, the "konsole --separate" process launched by Konsole's
> dbus unit test would exit normally, however following the changes in
> Frameworks it now hangs and does not exit as expected.
>
> This is causing quite a bit of trouble as these builds require manual
> Sysadmin intervention in order to have the jobs complete successfully.
>
> Could someone take a look into this regression please?
>
> Regretfully it isn't possible to run GDB within the CI system
> environment (Docker drops CAP_SYS_PTRACE) so i'm unable to get a
> backtrace out of Konsole to find where it is stuck.

Ping?

Anyone got any idea why this behaviour has regressed?

>
> Thanks,
> Ben

Regards,
Ben

D15739: [Places panel] Don't show Root by default

[David C]

davidc added a comment.


  Okay, I was only referring to the Places section, not the entire panel.
  
  I do think changing the default label of `Root`'s mounted device would 
prevent the confusion of the one user who wanted it removed from Devices. But 
that was only one of many criticisms of this change.
  
  I think the most emotional responses consider this change to be 
condescending. Painting `/` as "too dangerous" for the typical user, even 
though Dolphin already has restrictions that make system damage through the 
Dolphin GUI impossible. Removing the quick and easy Places link and relying on 
users to locate `Root` among their mounted physical devices gives the 
impression that we don't `/` to be easily accessible through Dolphin at all, 
even if people can't do anything once they get there.
  
  I have an additional concern that this level of obfuscation could have the 
unintended effect of making things more confusing for truly novice users, who 
may not realize there is a directory structure beyond `Home` at all. This can 
create many problems when trying to understand what the system is doing, or 
when troubleshooting problems.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, abetts, 
svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Nathaniel Graham]

ngraham added a comment.


  In D15739#356008 , @davidc wrote:
  
  > Are you referring to the mounted device under the Devices section?
  
  
  Yes.
  
  > I'm unaware of how to get to the root directory in a single click using 
Places, if the existing link is removed.
  
  Perhaps a visual aid will help. Here is how the Places panel looks today, as 
of KIO's git master:
  
  F6397673: Places visual aid.png 
  
  This patch removed the red-circled item. The blue-circled item is still 
visible and still takes you to / when clicked on. Does that help? We are also 
thinking about improving the label given to the Root disk when it doesn't have 
a disk label. So instead of saying, " GiB Hard Drive", we could potentially 
make it  say "Root drive" or "Root" or " GiB Hard Drive (Root)" or anything 
else, really.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, abetts, 
svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[David C]

davidc added a comment.


  Are you referring to the mounted device under the Devices section? I'm 
unaware of how to get to the root directory in a single click using Places, if 
the existing link is removed.
  
  My question to users addressed the Devices point and I also provided the user 
feedback re: Devices. As you can see, opinion on the Devices link was mixed, 
while they were strongly in favor of the Places link. The person who said they 
wanted `Root` removed from Devices explained that the first time he used 
Plasma, he saw it mounted there and was afraid he had installed his system onto 
the wrong partition.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, abetts, 
svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Nathaniel Graham]

ngraham added a comment.


  I do not understand why this change provokes any negative reactions. Right 
now, the Places panel has two items that both lead to the exact same location. 
This patch simply removes one of them by default, and adding it again if you 
want is a 10 second operation. No functionality is lost; / can still be 
accessed with a single click on an item in the Places panel by default. There 
will still be a "direct shortcut to the root directory".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, abetts, 
svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[David C]

davidc added a comment.


  I strongly advise against this. This change goes against Plasma's brand 
identity and will provoke a strongly negative reaction from our core audiences.
  
  Plasma is strongly associated with powerful tools and high utility. Users 
also love having many options. Every time GNOME is criticized for "removing 
features," or not listening to feedback, we win big. Plasma is frequently 
praised for being the desktop environment that makes an effort to listen to its 
users.
  
  I asked for some preliminary feedback on a large Discord server for Linux 
users. I made sure to specify that the change only applied to the Places link, 
and Root would remain visible in Devices.
  
  Within **two** minutes of asking:
  
  - 4 users came out strongly against the change
  - 1 person was indifferent because they mostly used the terminal for most 
things outside of Home.
  - 2 people suggested removing the desktop link from Places instead of root.
  - 1 user asked for the removal of the Devices link to root
  - 1 person had never noticed root was listed under Devices
  
  Only the terminal user believed the Places link presented a safety risk to 
GUI users. Three people said there was no safety risk because Dolphin does not 
allow the editing of system files.
  
  Two users mentioned proprietary operating systems which provide a direct 
shortcut to the root directory.
  One user said this change would make him **"mad,"** and one person asked if 
the team thought **users were stupid.** One user said it sounded "like 
something GNOME would do, not KDE."
  
  This was a quick 5 minute survey, but the feedback was very strong and even 
emotional.
  
  My personal opinion aligns with many of these comments, and I too find this 
change out of character for Plasma.
  I contribute to Promo and I am certainly not the most technical person here. 
I use this Places link many times a day. I consider the Devices link to be 
conceptually different, and it's much less convenient because my root partition 
is in the middle of my Devices list. I don't ever feel in danger of a misclick 
because Dolphin prevents any editing or deletion of system files.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, abetts, 
svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  This blows up the places tests; will fix them in this patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: tcanabrava, ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, 
broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham

D16742: Fix iconitemtest regression

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16742

To: joselema, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  In D16643#355965 , @bruns wrote:
  
  > If it does not receive any events, it can and must not accept. All events 
go to the parent.
  
  
  `DeclarativeDropArea::dragMoveEvent(QDragMoveEvent *event)` is called only 
when it receives the event, isn't it?
  When I does not receive any events like you said, it does nothing. So what's 
wrong with my patch ?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[Stefan Brüns]

bruns added a comment.


  In D16643#355964 , @trmdi wrote:
  
  > In D16643#355177 , @bruns wrote:
  >
  > > You have a conceptual misunderstanding of the enabled property, see 
QQuickItem 
  > >
  > > > enabled : bool
  > > >  This property holds whether the item receives mouse and keyboard 
events. By default this is true.
  > >
  > >
  >
  >
  > Yes, but what do you think about this:
  >  http://doc.qt.io/qt-5/qevent.html#accepted-prop
  >
  > > accepted : bool
  > >  Setting the accept parameter indicates that the event receiver wants the 
event.
  >
  > Isn't DragArea the event receiver?
  
  
  If it does not receive any events, it can and must not accept. All events go 
to the parent.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  In D16643#355177 , @bruns wrote:
  
  > You have a conceptual misunderstanding of the enabled property, see 
QQuickItem 
  >
  > > enabled : bool
  > >  This property holds whether the item receives mouse and keyboard events. 
By default this is true.
  >
  >
  
  
  Yes, but what do you think about this:
  http://doc.qt.io/qt-5/qevent.html#accepted-prop
  
  > accepted : bool
  >  Setting the accept parameter indicates that the event receiver wants the 
event.
  
  Isn't DragArea the event receiver?
  
  > It would also be good if you stick to one issue at a time.
  
  Why for a very simple one-line patch ?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 69 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/69/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 07 Nov 2018 23:34:00 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6332/8431)43%
(10151/23425)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2777)49%
(5802/11905)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(823/1573)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 125 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/125/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 07 Nov 2018 23:34:00 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6331/8431)43%
(10151/23429)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2777)49%
(5801/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(824/1575)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

[Alexey Min]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:eb916c305a5c: Fix crash if XDG_CACHE_HOME directory is 
too small or out of space (authored by alexeymin).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16744?vs=45077=45083

REVISION DETAIL
  https://phabricator.kde.org/D16744

AFFECTED FILES
  src/lib/caching/kshareddatacache_p.h

To: alexeymin, dfaure, #frameworks, mpyne
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  switch would require ugly fall-through, I prefer this code.

REPOSITORY
  R244 KCoreAddons

BRANCH
  bug400610

REVISION DETAIL
  https://phabricator.kde.org/D16744

To: alexeymin, dfaure, #frameworks, mpyne
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

[Alexey Min]

alexeymin added a comment.


  In D16744#355899 , @cfeck wrote:
  
  > Would a switch be more readable?
  
  
  Did you mean a block with `if (result == ENOSPC) {` ? Strictly speaking this 
whole block is not necessary, but it can provide some useful info in console.
  Or do you suggest adding switch with all error return codes from 
http://man7.org/linux/man-pages/man3/posix_fallocate.3.html? 

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D16744

To: alexeymin, dfaure, #frameworks, mpyne
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

[Christoph Feck]

cfeck added a reviewer: mpyne.
cfeck added a comment.


  Would a switch be more readable?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D16744

To: alexeymin, dfaure, #frameworks, mpyne
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

[Alexey Min]

alexeymin updated this revision to Diff 45077.
alexeymin added a comment.


  - Fix typo "in" -> "on"

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16744?vs=45074=45077

BRANCH
  bug400610

REVISION DETAIL
  https://phabricator.kde.org/D16744

AFFECTED FILES
  src/lib/caching/kshareddatacache_p.h

To: alexeymin, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

[Alexey Min]

alexeymin edited the test plan for this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D16744

To: alexeymin, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

[Alexey Min]

alexeymin added a reviewer: Frameworks.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D16744

To: alexeymin, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

[Alexey Min]

alexeymin edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D16744

To: alexeymin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

[Alexey Min]

alexeymin edited the test plan for this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D16744

To: alexeymin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

[Alexey Min]

alexeymin edited the test plan for this revision.
alexeymin added a reviewer: dfaure.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D16744

To: alexeymin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

[Alexey Min]

alexeymin created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alexeymin requested review of this revision.

REVISION SUMMARY
  Incorrect checking for error return code of posix_fallocate() causes function 
to think that all is OK while it is not causing crash in some cases.
  The fix for 4-year bug is a simple one-liner...
  
  BUG: 400610
  CCBUG: 339829

TEST PLAN
  good test plan provided in https://bugs.kde.org/show_bug.cgi?id=400610 . 
Works like a charm, tested in KDE Neon dev-ustable

REPOSITORY
  R244 KCoreAddons

BRANCH
  bug400610

REVISION DETAIL
  https://phabricator.kde.org/D16744

AFFECTED FILES
  src/lib/caching/kshareddatacache_p.h

To: alexeymin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Nathaniel Graham]

ngraham added a comment.


  In D14631#355791 , @mlaurent wrote:
  
  > For me seems good +1
  
  
  You still have a "Request changes" status for this patch. If you're happy 
with it now, can you change that to "Accepted? Thanks!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns

D16742: Fix iconitemtest regression

[José Manuel Santamaría Lema]

joselema created this revision.
joselema added reviewers: mart, apol.
Herald added a project: Frameworks.
Herald removed a subscriber: Frameworks.
joselema requested review of this revision.

REVISION SUMMARY
  Hi,
  
  after this commit
  
https://cgit.kde.org/plasma-framework.git/commit/?id=9f08668147d2e99f8b5069ff50d5c54e672a87af
  
  The iconitemtest started to fail. As we can see from that commit the set of 
changes starts with this:
  
if (sourceString.endsWith(QLatin1String(".svg")) ||
sourceString.endsWith(QLatin1String(".svgz"))) {
m_icon = QIcon(localFile);
m_imageIcon = QImage();
} else {
m_icon = QIcon(localFile);
m_imageIcon = QImage();
}
  
  As we can see the code executed in the "if" block and the "else" block is 
exactly the same. My guess (and it's just a wild guess because I don't actually 
understand the code involved) is that you actually wanted to do this:
  
if (sourceString.endsWith(QLatin1String(".svg")) ||
sourceString.endsWith(QLatin1String(".svgz"))) {
m_icon = QIcon(localFile);
m_imageIcon = QImage();
} else {
m_icon = QIcon();
m_imageIcon = QImage(localfile);
}
  
  So I'm attaching a patch doing that ↑

TEST PLAN
  I have just built the code with the patch, it fixes the test for me, but I'm 
not sure if the patch is correct.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D16742

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: joselema, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16735: Implement text_input_unstable_v3

[Roman Gilg]

romangg added a task: T9815: Improve touch/virtual keyboard.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16735

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Laurent Montel]

mlaurent added a comment.


  For me seems good +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 105 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/105/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 07 Nov 2018 16:24:23 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testWaylandSurface
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(233/257)91%
(233/257)82%
(23893/29160)50%
(9408/18812)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client95%
(40/42)95%
(40/42)90%
(10907/12055)46%
(5790/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)82%
(5650/6923)63%
(1489/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)84%
(6902/8236)63%
(1960/3094)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/79/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 07 Nov 2018 16:24:23 +
 Build duration:
7 min 52 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24876/29181)53%
(9891/18812)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11700/12056)49%
(6215/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5736/6934)64%
(1506/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(7006/8245)65%
(2001/3094)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D16701: Correct version of newly added PlasmaVirtualDesktop interface

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:2db50b2be381: Correct version of newly added 
PlasmaVirtualDesktop interface (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16701?vs=44977=45053

REVISION DETAIL
  https://phabricator.kde.org/D16701

AFFECTED FILES
  src/client/plasmavirtualdesktop.h
  src/client/plasmawindowmanagement.h
  src/client/registry.h
  src/server/display.h
  src/server/plasmavirtualdesktop_interface.h
  src/server/plasmawindowmanagement_interface.h

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  In D7446#355675 , @andreask wrote:
  
  > I would suggest to have by default detail view instead of icon view cause 
with detail view it's easier to read the paths.
  
  
  That's a good idea, let me see what I can do.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham retitled this revision from "[Places panel] Add a Recently Used item by 
default" to "[Places panel] Revamp the Recently Saved section".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Add a Recently Used item by default

[Nathaniel Graham]

ngraham updated this revision to Diff 45043.
ngraham added a comment.


  Rebase on master
  
  Updating D7446 : [Places panel] Add a 
Recently Used item by default

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=45040=45043

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Add a Recently Used item by default

[Andreas Kainz]

andreask added a comment.


  I would suggest to have by default detail view instead of icon view cause 
with detail view it's easier to read the paths.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D15739: [Places panel] Don't show Root by default

[Tomaz Canabrava]

tcanabrava accepted this revision.
tcanabrava added a comment.
This revision is now accepted and ready to land.


  too many +1 to not be accepted.

REPOSITORY
  R241 KIO

BRANCH
  remote-root-from-places-panel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: tcanabrava, ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, 
broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham

D7446: [Places panel] Add a Recently Used item by default

[Nathaniel Graham]

ngraham updated this revision to Diff 45040.
ngraham added a comment.


  - Revamp the whole section

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=42865=45040

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D16735: Implement text_input_unstable_v3

[Roman Gilg]

romangg created this revision.
romangg added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Adds support for the text_input_unstable_v3 protocol to our current
  implementations v0 and v2.
  
  Protocol v3 is relatively new and features large changes relative to v2.
  All state changes are now double buffered and key input functionality has been
  removed, what makes the protocol leaner.

TEST PLAN
  Autotest amended.

REPOSITORY
  R127 KWayland

BRANCH
  textInputV3

REVISION DETAIL
  https://phabricator.kde.org/D16735

AFFECTED FILES
  autotests/client/test_text_input.cpp
  src/client/CMakeLists.txt
  src/client/protocols/text-input-unstable-v3.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/textinput.cpp
  src/client/textinput.h
  src/client/textinput_p.h
  src/client/textinput_v0.cpp
  src/client/textinput_v2.cpp
  src/client/textinput_v3.cpp
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/seat_interface.h
  src/server/textinput_interface.cpp
  src/server/textinput_interface.h
  src/server/textinput_interface_p.h
  src/server/textinput_interface_v0.cpp
  src/server/textinput_interface_v2.cpp
  src/server/textinput_interface_v3.cpp

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16665: Add programmaticaly useful error signalling

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D16665#355578 , @apol wrote:
  
  > Maybe it would be good to produce the Discover patch before committing this 
to make sure the API is the one we want.
  
  
  Good idea, yes, i'll get that whipped together and submitted with reference 
to this one :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D16665

To: leinir, #knewstuff, apol
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D16665: Add programmaticaly useful error signalling

[Aleix Pol Gonzalez]

apol added a comment.


  Maybe it would be good to produce the Discover patch before committing this 
to make sure the API is the one we want.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D16665

To: leinir, #knewstuff, apol
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D16665: Add programmaticaly useful error signalling

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D16665

To: leinir, #knewstuff, apol
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/78/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 07 Nov 2018 13:41:17 +
 Build duration:
6 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testWaylandSurface
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(233/257)91%
(233/257)82%
(23924/29160)50%
(9432/18812)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client95%
(40/42)95%
(40/42)91%
(10934/12054)46%
(5815/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)82%
(5655/6924)63%
(1490/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)84%
(6901/8236)63%
(1958/3094)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 104 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/104/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 07 Nov 2018 13:41:17 +
 Build duration:
7 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24875/29181)53%
(9894/18812)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11699/12056)49%
(6215/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5736/6934)64%
(1509/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(7006/8245)65%
(2001/3094)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D16708: [server] Text input content hint and purpose per protocol version

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:7c0f6cfa2eae: [server] Text input content hint and 
purpose per protocol version (authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16708?vs=44970=45033#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16708?vs=44970=45033

REVISION DETAIL
  https://phabricator.kde.org/D16708

AFFECTED FILES
  src/server/textinput_interface.cpp
  src/server/textinput_interface_p.h
  src/server/textinput_interface_v0.cpp
  src/server/textinput_interface_v2.cpp

To: romangg, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16708: [server] Text input content hint and purpose per protocol version

[Roman Gilg]

romangg marked an inline comment as done.

REPOSITORY
  R127 KWayland

BRANCH
  textInputEnums

REVISION DETAIL
  https://phabricator.kde.org/D16708

To: romangg, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16665: Add programmaticaly useful error signalling

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 45032.
leinir marked an inline comment as done.
leinir added a comment.


  Adjust the patch to address @apol's comment about deprecating the old error 
signal

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16665?vs=44855=45032

REVISION DETAIL
  https://phabricator.kde.org/D16665

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/core/CMakeLists.txt
  src/core/downloadmanager.cpp
  src/core/engine.cpp
  src/core/engine.h
  src/core/errorcode.h
  src/core/provider.h
  src/downloadwidget.cpp
  src/ui/progressindicator.cpp
  src/ui/progressindicator_p.h

To: leinir, #knewstuff, apol
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D16665: Add programmaticaly useful error signalling

[Dan Leinir Turthra Jensen]

leinir marked an inline comment as done.
leinir added inline comments.

INLINE COMMENTS

> apol wrote in engine.h:430
> I would include the error message here and deprecate `signalError`. Otherwise 
> it's going to be a mess matching both signals.

Quite a good point, yes - i've done a bit of jiggling around, new patch incoming

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D16665

To: leinir, #knewstuff, apol
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/64/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 07 Nov 2018 12:46:32 +
 Build duration:
5 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(18/19)95%
(18/19)72%
(1538/2132)51%
(1075/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(537/539)51%
(243/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(558/755)64%
(598/935)src.kpackage.private100%
(6/6)100%
(6/6)79%
(284/358)49%
(96/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(145/462)26%
(131/506)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/86/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 07 Nov 2018 12:46:32 +
 Build duration:
5 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(18/19)95%
(18/19)72%
(1538/2132)51%
(1075/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(537/539)51%
(243/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(558/755)64%
(598/935)src.kpackage.private100%
(6/6)100%
(6/6)79%
(284/358)49%
(96/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(145/462)26%
(131/506)

D16733: Capture package metadata before install start

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:451b1785e8d0: Capture package metadata before install 
start (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16733?vs=45026=45028#toc

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16733?vs=45026=45028

REVISION DETAIL
  https://phabricator.kde.org/D16733

AFFECTED FILES
  src/kpackage/private/packagejob.cpp

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16733: Capture package metadata before install start

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I would add a comment saying "please don't call d->package from the lambda 
because it breaks".

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16733

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16733: Capture package metadata before install start

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KPackage (despite being supposedly internally shared) is not kept as a
  strong reference inside PackageJob. Potentially it could go out of scope
  before a job ends.
  
  The signals to emit changes relied on the package. This patch captures
  relevant metadata at the start of the install.
  
  noCrashOnAsyncInstall test now passes again

TEST PLAN
  Ran test

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16733

AFFECTED FILES
  src/kpackage/private/packagejob.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns