date:20231123

[Libreoffice-bugs] [Bug 158246] intersection of two line become white

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158246

--- Comment #2 from Kjell Edvard Medhaug  ---
Created attachment 190992
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190992=edit
PDF exported from OneNote

Created in "Microsoft OneNote for Windows 10", version 16001.14326.21452.0,
with Norwegian user interface. Exported to file using the integrated File -
Export functionality in OneNote. Other file created by print-to-pdf, using the
virtual printer driver supplied with Windows, displays identical behavior.

The file has random scribble objects made with the "pen" drawing tool in
Microsoft OneNote. Some using default line width and some with wider line; some
remain as freehand lines and some are converted automatically by OneNote to
regular shapes (ellipse and circle).

The objects are rendered without "white-outs" in OneNote, and also in Adobe
Reader.

When opened in Draw, there are white-outs where there is wide line overlapping
wide line on the same object (crossing line on freehand object, rounded ends of
"autocorrected" regular objects). 

- Overlapping between objects does not display any white-out. 
- Narrow line does not display any white-out.

Just a thought: 
Perhaps some combination of ...
- Coloration "XOR" when object ID or stacking order is identical?
- Wider lines defined by "contour vector" while narrow line is defined by
simple vector + width, and crossing vector somehow confused with contour
vector.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155888] SAXException: No input source at /home/abuild/rpmbuild/BUILD/libreoffice-7.5.4.2/sax/source/fastparser/fastparser.cxx:1055

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155888

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
How was the file created in the first place?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/svtools sw/qa sw/source

2023-11-23 Thread Mike Kaganski (via logerrit)

 include/svtools/parhtml.hxx  |1 
 sw/qa/extras/htmlexport/data/test_no_space_preserve.fodt |   25 ++
 sw/qa/extras/htmlexport/htmlexport.cxx   |  147 +++
 sw/source/filter/html/htmlatr.cxx|   86 ++--
 sw/source/filter/html/swhtml.cxx |2 
 sw/source/filter/html/wrthtml.cxx|1 
 sw/source/filter/html/wrthtml.hxx|3 
 7 files changed, 241 insertions(+), 24 deletions(-)

New commits:
commit 2da3c1f0bf180e44e82d6ef9bbcd33129026a3dc
Author: Mike Kaganski 
AuthorDate: Tue Nov 14 11:05:05 2023 +0300
Commit: Mike Kaganski 
CommitDate: Thu Nov 23 14:14:09 2023 +0100

Limit PreserveSpaces HTML/ReqIF export option to proper space characters

We only need to care about SPACE, TAB, LF, and CR. We don't need to care
about LF in some cases, because it gets converted to a  element, and
handled specially. And we don't need to care about other "whitespace"
characters, like control characters and Unicode space.

Our own object placeholder characters were treated as "space", which was
wrong.

One peculiarity needs to be noted. In ReqIF case, a SPACE before LF needs
no 'xml:space="preserve"', but an LF before SPACE needs one, because it
needs to disambiguate between a  followed by a significant space vs.
a  followed by a pretty-printed newline.

Change-Id: I74273592df05bb94d8e4ecaea2c069c0e086b7d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159853
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/include/svtools/parhtml.hxx b/include/svtools/parhtml.hxx
index 5ce3d27cb61d..22dfe2769e2a 100644
--- a/include/svtools/parhtml.hxx
+++ b/include/svtools/parhtml.hxx
@@ -189,6 +189,7 @@ protected:
 
 void SetNamespace(std::u16string_view rNamespace);
 
+bool GetPreserveSpaces() const { return m_bPreserveSpaces; }
 void SetPreserveSpaces(bool val) { m_bPreserveSpaces = val; }
 
 public:
diff --git a/sw/qa/extras/htmlexport/data/test_no_space_preserve.fodt 
b/sw/qa/extras/htmlexport/data/test_no_space_preserve.fodt
new file mode 100644
index ..e0d9a3506e9f
--- /dev/null
+++ b/sw/qa/extras/htmlexport/data/test_no_space_preserve.fodt
@@ -0,0 +1,25 @@
+
+
+
+ 
+  
+   No special spaces
+   Leading space
+   Trailing space 
+   Double space
+   Leading/trailing breaks
+Leading break + space
+   Trailing space + break 
+   Middlebreak
+   Middle space + break
+   Middle break + space
+   Trailing space and SVG 
+  
PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPHN2ZyB4bWxucz0iaHR0
+   cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgdmlld0JveD0iMCAwIDIw
+   IDIwIiBzdHJva2U9ImJsYWNrIj4KPHBhdGggZD0iTTEsMUwxOSwxOSIvPgo8L3N2Zz4=
+  
+ 
+
+  
+ 
+
\ No newline at end of file
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx 
b/sw/qa/extras/htmlexport/htmlexport.cxx
index c436411daf52..161357ffbdba 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -2835,6 +2835,153 @@ CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, 
testReqIF_PreserveSpaces)
 CPPUNIT_ASSERT_EQUAL(paraText, getParagraph(1)->getString());
 }
 
+CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, testHTML_NoPreserveSpaces)
+{
+// Test cases where "PreserveSpaces" should not introduce respective markup
+
+const auto assertXPath_NoWhiteSpaceInStyle
+= [this](const xmlDocUniquePtr& pDoc, const OString& rXPath) {
+  xmlXPathObjectPtr pXmlObj = getXPathNode(pDoc, rXPath);
+  xmlNodeSetPtr pXmlNodes = pXmlObj->nodesetval;
+  CPPUNIT_ASSERT_EQUAL_MESSAGE(rXPath.getStr(), 1, 
xmlXPathNodeSetGetLength(pXmlNodes));
+  xmlNodePtr pXmlNode = pXmlNodes->nodeTab[0];
+  if (xmlChar* prop = xmlGetProp(pXmlNode, BAD_CAST("style")))
+  {
+  OUString style = OUString::fromUtf8(reinterpret_cast(prop));
+  CPPUNIT_ASSERT_MESSAGE(rXPath.getStr(), 
style.indexOf("white-space:") < 0);
+  }
+  xmlXPathFreeObject(pXmlObj);
+  };
+const auto assertXPath_HasWhiteSpaceInStyle
+= [this](const xmlDocUniquePtr& pDoc, const OString& rXPath) {
+  const OUString style = getXPath(pDoc, rXPath, "style"_ostr);
+  CPPUNIT_ASSERT_MESSAGE(rXPath.getStr(), 
style.indexOf("white-space: pre-wrap") >= 0);
+  };
+
+createSwDoc("test_no_space_preserve.fodt");
+
+// Export to plain HTML, using PreserveSpaces:
+saveWithParams({
+comphelper::makePropertyValue("FilterName", u"HTML (StarWriter)"_ustr),
+comphelper::makePropertyValue("PreserveSpaces", true),
+});
+
+htmlDocUniquePtr pHtmlDoc = parseHtml(maTempFile);
+CPPUNIT_ASSERT(pHtmlDoc);
+
+// No whitespace preservation, where no leading / trailing / double 
whitespace
+

[Libreoffice-bugs] [Bug 157551] LO Calc Data - Validity - Cell Range / LIST - Selection List - The dropdown is tiny and away from clicked arrow

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157551

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com
  Regression By||Noel Grandin

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
Thanks for the bibisect, Sophie. I can confirm that's when it started (build
commit [311548b1b7fd05a8721cbea42d3a42933a71c62b] on linux-64-24-2).

commit  b6b26421a1029b18b48b69dbdac4bb70fb622604
author  Noel GrandinThu Jul 20 08:19:52 2023 +0200
committer   Noel Grandin  Wed Aug 02 08:13:15 2023 +0200
split Point/Size/Rectangle into AbsoluteScreenPixel* types
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154676

Noel, can you please have a look?
My concerns:
- dropdown points to previous column
- dropdown points to previous row

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158300] ods file closed by Viewer if experimental mode is enabled

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158300

--- Comment #11 from Sophie Sipasseuth  ---
:-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - writerfilter/qa writerfilter/source

2023-11-23 Thread Jaume Pujantell (via logerrit)

 writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx   |6 ++
 writerfilter/qa/cppunittests/dmapper/data/fdo78333-1-minimized.docx |binary
 writerfilter/source/dmapper/DomainMapper.cxx|   26 
+++---
 writerfilter/source/dmapper/SdtHelper.cxx   |1 
 4 files changed, 16 insertions(+), 17 deletions(-)

New commits:
commit a8ee639d256315e730bc4014dcca0d78f2de686f
Author: Jaume Pujantell 
AuthorDate: Wed Nov 22 11:59:09 2023 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 23 14:09:33 2023 +0100

fix a regression crash from commit 5082d50

The commit generated crashes in the crashtest documents
7711 bugtrackers/docx/fdo78333-1.docx and
695 forums/docx/forum-mso-en-4096.docx.
This was due to "m_xFieldStartRange", the start of the text
portion of the block SDT, being recorded too early. This led to
including characters that shouldn't be there in the generated
content control.
This patch moves the calls to setFieldStartRange to just before
the first appendTextPortion call.

Change-Id: I7230346fee9a37ebac70beb9bcafd9d7b612eb00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159816
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 
(cherry picked from commit 7c4dba1deffd81f647a4a3be7a79f68f3bf9f1ba)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159761
Tested-by: Jenkins CollaboraOffice 

diff --git a/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx 
b/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx
index 7cafcd19f280..ec771ba0f1b4 100644
--- a/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx
+++ b/writerfilter/qa/cppunittests/dmapper/DomainMapper.cxx
@@ -149,6 +149,12 @@ CPPUNIT_TEST_FIXTURE(Test, testSdtBlockText)
 xContentControlProps->getPropertyValue("Alias") >>= aAlias;
 CPPUNIT_ASSERT_EQUAL(OUString("myalias"), aAlias);
 }
+
+CPPUNIT_TEST_FIXTURE(Test, testFdo78333)
+{
+// just care that it doesn't crash/assert
+loadFromURL(u"fdo78333-1-minimized.docx");
+}
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git 
a/writerfilter/qa/cppunittests/dmapper/data/fdo78333-1-minimized.docx 
b/writerfilter/qa/cppunittests/dmapper/data/fdo78333-1-minimized.docx
new file mode 100644
index ..0c4a5bc67288
Binary files /dev/null and 
b/writerfilter/qa/cppunittests/dmapper/data/fdo78333-1-minimized.docx differ
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 0c5f5d855261..9f279469362f 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -1190,9 +1190,6 @@ void DomainMapper::lcl_attribute(Id nName, Value & val)
 m_pImpl->PushSdt();
 break;
 }
-if (m_pImpl->m_pSdtHelper->getControlType() == 
SdtControlType::plainText
-&& GetCurrentTextRange().is())
-
m_pImpl->m_pSdtHelper->setFieldStartRange(GetCurrentTextRange()->getEnd());
 m_pImpl->SetSdt(true);
 }
 break;
@@ -4115,7 +4112,6 @@ void DomainMapper::lcl_utext(const sal_uInt8 * data_, 
size_t len)
 {
 m_pImpl->m_pSdtHelper->createPlainTextControl();
 finishParagraph();
-
m_pImpl->m_pSdtHelper->setFieldStartRange(GetCurrentTextRange()->getEnd());
 return;
 }
 }
@@ -4369,10 +4365,9 @@ void DomainMapper::lcl_utext(const sal_uInt8 * data_, 
size_t len)
 m_pImpl->clearDeferredBreaks();
 }
 
-bool bSdtBlockUnusedText
-= m_pImpl->m_pSdtHelper->GetSdtType() != 
NS_ooxml::LN_CT_SdtRun_sdtContent
-  && m_pImpl->m_pSdtHelper->getControlType() == 
SdtControlType::plainText
-  && m_pImpl->m_pSdtHelper->hasUnusedText();
+bool bInSdtBlockText
+= m_pImpl->m_pSdtHelper->GetSdtType() == 
NS_ooxml::LN_CT_SdtBlock_sdtContent
+  && m_pImpl->m_pSdtHelper->getControlType() == 
SdtControlType::plainText;
 if (pContext && pContext->GetFootnote().is())
 {
 pContext->GetFootnote()->setLabel( sText );
@@ -4382,32 +4377,29 @@ void DomainMapper::lcl_utext(const sal_uInt8 * data_, 
size_t len)
 }
 else if (m_pImpl->IsOpenFieldCommand() && 
!m_pImpl->IsForceGenericFields())
 {
-if (bSdtBlockUnusedText)
+if (bInSdtBlockText && m_pImpl->m_pSdtHelper->hasUnusedText())
 m_pImpl->m_pSdtHelper->createPlainTextControl();
 m_pImpl->AppendFieldCommand(sText);
-if (bSdtBlockUnusedText)
-
m_pImpl->m_pSdtHelper->setFieldStartRange(GetCurrentTextRange()->getEnd());
 }
 else if( m_pImpl->IsOpenField() && 
m_pImpl->IsFieldResultAsString())
 {
-if

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa sw/source

2023-11-23 Thread Jaume Pujantell (via logerrit)

 sw/qa/core/unocore/data/tdf108272-1-minimal.docx |binary
 sw/qa/core/unocore/unocore.cxx   |6 ++
 sw/source/core/unocore/unotext.cxx   |1 +
 3 files changed, 7 insertions(+)

New commits:
commit 9201a9f0aa239b4a2fce17b7c45175590855f349
Author: Jaume Pujantell 
AuthorDate: Mon Nov 20 10:24:18 2023 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 23 14:09:02 2023 +0100

fix a regression crash

Fixes a crash introduced by commit 5082d50 in crashtesting file
7693 bugtrackers/docx/tdf108272-1.docx.

Change-Id: Id33c49165c4d345d652a546db14df98ee0ff754a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159736
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 43868de0ddabba952b923f6189d1fefeddb70bcf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159760
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/core/unocore/data/tdf108272-1-minimal.docx 
b/sw/qa/core/unocore/data/tdf108272-1-minimal.docx
new file mode 100644
index ..28efdf65b9af
Binary files /dev/null and b/sw/qa/core/unocore/data/tdf108272-1-minimal.docx 
differ
diff --git a/sw/qa/core/unocore/unocore.cxx b/sw/qa/core/unocore/unocore.cxx
index f3b102f096cc..dd4d71eda57c 100644
--- a/sw/qa/core/unocore/unocore.cxx
+++ b/sw/qa/core/unocore/unocore.cxx
@@ -932,6 +932,12 @@ CPPUNIT_TEST_FIXTURE(SwCoreUnocoreTest, 
testCollectFrameAtNodeWithLayout)
 assertXPath(pXmlDoc, "//draw:frame", 1);
 }
 
+// just care that it doesn't crash/assert
+CPPUNIT_TEST_FIXTURE(SwCoreUnocoreTest, testTdf108272Crash)
+{
+createSwDoc("tdf108272-1-minimal.docx");
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/unocore/unotext.cxx 
b/sw/source/core/unocore/unotext.cxx
index 98b9cecbf57c..3f8cf8dee72c 100644
--- a/sw/source/core/unocore/unotext.cxx
+++ b/sw/source/core/unocore/unotext.cxx
@@ -1690,6 +1690,7 @@ SwXText::convertToTextFrame(
 (pStartStartNode != GetStartNode()))
 {
 // if not - remove the additional paragraphs and throw
+oAnchorCheckPam.reset(); // clear SwIndex before deleting nodes
 if (bParaBeforeInserted)
 {
 SwCursor aDelete(*pStartPam->GetPoint(), nullptr);

[Libreoffice-bugs] [Bug 158334] New: EDITING selecting and deselecting a connector is slow

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158334

Bug ID: 158334
   Summary: EDITING selecting and deselecting a connector is slow
   Product: LibreOffice
   Version: 7.3.7.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bugzi...@dedinext.be

Created attachment 190991
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190991=edit
screen recording

I have been creating a drawing consisting of mostly rectangles and connectors.
The more I extended the drawing, the more I noticed there is a delay when
selecting and deselecting a connector. Selecting and deselecting a rectangle
does not experience this delay.

I see no point in providing a screenshot of the issue since it does not occur
in a static situation. I have made two screen recordings though to demonstrate
the issue.

Regarding the screen recordings: each mouse move is immediately followed by a
mouse click. You will notice in the first screen recording that the rectangles
get selected each time but the connectors do not get selected.
In the second screen recording, I increased the delay from 1s to 2s to allow
the connectors to be selected.


This may or may not be linked to bug ID 155120.


P.S. I had to put both screen recording files into an archive because I can
only upload 1 file to this bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158290] "Formattings" should be used instead of "Formats" in some cases

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158290

--- Comment #4 from sophie  ---
(In reply to V Stuart Foote from comment #3)

> However, as the en-US is the core for other translations, the requirement to
> distinguish slips. Which way is it handled for translators. In general I
> don't believe we are well served by massive string changes propagating as
> l10n/i18n translation churn.
> 
> IMHO => WF
> 
> @Sophie?

Thanks Tuomas for reporting and Stuart for the ping :)

So if "the requirement to distinguish slips", there is no way to be sure that
the right word will be used in future strings.
In this case, I think it's up to translators to make the distinction if it
exists in their language.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 158290] "Formattings" should be used instead of "Formats" in some cases

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158290

--- Comment #4 from sophie  ---
(In reply to V Stuart Foote from comment #3)

> However, as the en-US is the core for other translations, the requirement to
> distinguish slips. Which way is it handled for translators. In general I
> don't believe we are well served by massive string changes propagating as
> l10n/i18n translation churn.
> 
> IMHO => WF
> 
> @Sophie?

Thanks Tuomas for reporting and Stuart for the ping :)

So if "the requirement to distinguish slips", there is no way to be sure that
the right word will be used in future strings.
In this case, I think it's up to translators to make the distinction if it
exists in their language.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153322] RFE: Add Macro Security Settings button to macro infobar

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=153322

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7482

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 157482] Turn Security Warnings popup windows into infobars

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157482

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||samuel.mehrbrodt@allotropia
   ||.de,
   ||stephane.guillou@libreoffic
   ||e.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3322

--- Comment #13 from Stéphane Guillou (stragu) 
 ---
I guess we should also mention Samuel's
f41627ab60372345be646c53d967b65be43b562f here, and maybe at 7.6 to the target?
It doesn't have an attached ugzilla ticket.

Also, I tested in 7.6.3 and a recent trunk build, and I can't see an infobar on
fileopen on ODS or ODB files with macros (High macro security level, the
default). 7.5 would warn that the document had macros on the same default
setting, so no notification at all is a loss in my opinion.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7d357628d6e8ce3f9e3c3a567ada21f02bce8d42
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 7.6.3.1 (X86_64) / LibreOffice Community
Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 158323] CRASH when switch back from HTML View to Normal View after edit in HTML source code

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158323

--- Comment #4 from Julien Nabet  ---
I don't know if it's expected that GetStyleSheetPool may return null.
If it is, this patch can fix this:
diff --git a/sw/source/uibase/docvw/PostItMgr.cxx
b/sw/source/uibase/docvw/PostItMgr.cxx
index 12c5e4f52d11..c69402c8583e 100644
--- a/sw/source/uibase/docvw/PostItMgr.cxx
+++ b/sw/source/uibase/docvw/PostItMgr.cxx
@@ -225,7 +225,9 @@ SwPostItMgr::SwPostItMgr(SwView* pView)
 StartListening(*mpView->GetDocShell());
 // listen to stylesheet pool to update on stylesheet rename,
 // as EditTextObject references styles by name.
-   
StartListening(*static_cast(mpView->GetDocShell()->GetStyleSheetPool())->GetEEStyleSheetPool());
+SfxStyleSheetBasePool* pPool = mpView->GetDocShell()->GetStyleSheetPool();
+if  (pPool)
+   
StartListening(*static_cast(pPool)->GetEEStyleSheetPool());
 if (!mvPostItFields.empty())
 {
 mbWaitingForCalcRects = true;

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109530] [META] File opening issues

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=109530
Bug 109530 depends on bug 155782, which changed state.

Bug 155782 Summary: Unable to open 17 page docx file properly
https://bugs.documentfoundation.org/show_bug.cgi?id=155782

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155782] Unable to open 17 page docx file properly

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155782

Timur  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|NEW

--- Comment #8 from Timur  ---
Not fixed in 7.6 or 24.2. Regardless it opens, any move makes wrong pagination
and CPU.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - 2 commits - include/sfx2 sc/source sd/source sfx2/source sw/source

2023-11-23 Thread Caolán McNamara (via logerrit)

 include/sfx2/objsh.hxx   |7 --
 sc/source/core/data/global.cxx   |   32 +
 sd/source/ui/app/sdmod1.cxx  |   29 --
 sfx2/source/doc/objmisc.cxx  |   27 
 sw/source/uibase/shells/drwtxtex.cxx |8 +--
 sw/source/uibase/wrtsh/wrtsh2.cxx|   38 ++-
 6 files changed, 78 insertions(+), 63 deletions(-)

New commits:
commit 76cb7253a19ef73ce465bb388be002f4f7d7ddd7
Author: Caolán McNamara 
AuthorDate: Wed Nov 22 21:14:41 2023 +
Commit: Caolán McNamara 
CommitDate: Thu Nov 23 13:29:48 2023 +0100

reuse AllowedLinkProtocolFromDocument in impress/draw

Change-Id: I73ca4f087946a45dbf92d69a0dc1e769de9b5690
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159843
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit f0942eed2eb328b04856f20613f5226d66b66a20)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159759
Reviewed-by: Michael Stahl 

diff --git a/sd/source/ui/app/sdmod1.cxx b/sd/source/ui/app/sdmod1.cxx
index 881d5aa1eefd..eeaa12166bb1 100644
--- a/sd/source/ui/app/sdmod1.cxx
+++ b/sd/source/ui/app/sdmod1.cxx
@@ -33,6 +33,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -192,26 +193,32 @@ void SdModule::Execute(SfxRequest& rReq)
 {
 bool bIntercept = false;
 ::sd::DrawDocShell* pDocShell = dynamic_cast< ::sd::DrawDocShell 
*>( SfxObjectShell::Current() );
-if (pDocShell)
+::sd::ViewShell* pViewShell = pDocShell ? 
pDocShell->GetViewShell() : nullptr;
+if (pViewShell)
 {
-::sd::ViewShell* pViewShell = pDocShell->GetViewShell();
-if (pViewShell)
+if( sd::SlideShow::IsRunning( pViewShell->GetViewShellBase() ) 
)
 {
-if( sd::SlideShow::IsRunning( 
pViewShell->GetViewShellBase() ) )
+// Prevent documents from opening while the slide
+// show is running, except when this request comes
+// from a shape interaction.
+if (rReq.GetArgs() == nullptr)
 {
-// Prevent documents from opening while the slide
-// show is running, except when this request comes
-// from a shape interaction.
-if (rReq.GetArgs() == nullptr)
-{
-bIntercept = true;
-}
+bIntercept = true;
 }
 }
 }
 
 if (!bIntercept)
 {
+if (const SfxStringItem* pURLItem = 
rReq.GetArg(SID_FILE_NAME))
+{
+if (!pViewShell || 
!SfxObjectShell::AllowedLinkProtocolFromDocument(pURLItem->GetValue(),
+   
 pViewShell->GetObjectShell(),
+   
 pViewShell->GetFrameWeld()))
+{
+return;
+}
+}
 SfxGetpApp()->ExecuteSlot(rReq, SfxGetpApp()->GetInterface());
 }
 else
commit 413293bace52d64e6e13d004bec794da4d0f576b
Author: Caolán McNamara 
AuthorDate: Wed Nov 15 11:39:24 2023 +
Commit: Caolán McNamara 
CommitDate: Thu Nov 23 13:29:41 2023 +0100

reuse AllowedLinkProtocolFromDocument in writer

reorg calc hyperlink check to reuse elsewhere

Change-Id: I20ae3c5df15502c3a0a366fb4a2924c06ffac3d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159487
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit e6a7537762e19fde446441edd10d301f9b37ce75)

reuse AllowedLinkProtocolFromDocument in writer

Change-Id: Iacf5e313fc6ca5f7d69ca6986a036f0e1ab1f2a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159488
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 32535dfa82200b54296838b52285c054fbe5e51d)

combine these hyperlink dispatchers into one call

Change-Id: Icb7822e811013de648ccf2fbb23a5f0be9e29bb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159489
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 0df175ccc6ea542bc5801f631ff72bed187042eb)

we can have just one LoadURL for writer

Change-Id: Ia0162ee1c275292fcf200bad4662e4c2c6b7b972
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159557
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit 521ca9cf6acbae96cf95d9740859c9682212013d)
Reviewed-on:

[Libreoffice-ux-advise] [Bug 158290] "Formattings" should be used instead of "Formats" in some cases

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158290

V Stuart Foote  changed:

   What|Removed |Added

 CC||so...@libreoffice.org

--- Comment #3 from V Stuart Foote  ---
Not convinced. Yes in technical English there is a distinction to be made
between nouns "format" and "formatting" where the root verb remains "format".

E.g. "a particular data format requires specific data formatting"

So could make a case for nuanced application, and selective string changes.

However, as the en-US is the core for other translations, the requirement to
distinguish slips. Which way is it handled for translators. In general I don't
believe we are well served by massive string changes propagating as l10n/i18n
translation churn.

IMHO => WF

@Sophie?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 158290] "Formattings" should be used instead of "Formats" in some cases

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158290

V Stuart Foote  changed:

   What|Removed |Added

 CC||so...@libreoffice.org

--- Comment #3 from V Stuart Foote  ---
Not convinced. Yes in technical English there is a distinction to be made
between nouns "format" and "formatting" where the root verb remains "format".

E.g. "a particular data format requires specific data formatting"

So could make a case for nuanced application, and selective string changes.

However, as the en-US is the core for other translations, the requirement to
distinguish slips. Which way is it handled for translators. In general I don't
believe we are well served by massive string changes propagating as l10n/i18n
translation churn.

IMHO => WF

@Sophie?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157935] After installation of 7.6.2, first form opening of .odb file freezes LO

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157935

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Blocks||107659
 Ever confirmed|0   |1
 CC||samuel.mehrbrodt@allotropia
   ||.de

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
So for me, the issue is different: LO 7.6 does not notify the user that the
file contains macros that are not going to be run.
Not quite the same as what you describe, but might be related?

Tested every time with a new profile:

7.5.8.2: macro security prompt at fileopen. Once macros are allowed, opening
the file uses the custom dialog.
7.6.3.1: _no_ macro security prompt at fileopen. Once macros are allowed,
opening the file uses the custom dialog.

Version: 7.6.3.1 (X86_64) / LibreOffice Community
Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US

Same on macOS:

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 2; OS: Mac OS X 13.2.1; UI render: Skia/Raster; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US

This change I bibisected with the linux-64-7.6 repo to first bad build commit
[90c59bb5b9c0b4d42872347f2f22fa2f2702361f] which points to:

commit  f41627ab60372345be646c53d967b65be43b562f
author  Samuel MehrbrodtFri Jan 27 10:34:29 2023 +0100
committer   Samuel MehrbrodtMon Jan 30 08:15:09 2023 +
Show infobar instead of blocking dialog when macros are not allowed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146250

@Samuel, can you please have a look? Base does not show the infobar.
@Can you test version 7.5 to see if it also works like 7.1? That would help
narrow it down.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107659
[Bug 107659] [META] Macro bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107659

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157935


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157935
[Bug 157935] After installation of 7.6.2, first form opening of .odb file
freezes LO
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa sw/source

2023-11-23 Thread Miklos Vajna (via logerrit)

 sw/qa/core/layout/data/floattable-table-join.docx |binary
 sw/qa/core/layout/tabfrm.cxx  |   60 ++
 sw/source/core/layout/tabfrm.cxx  |   14 -
 3 files changed, 73 insertions(+), 1 deletion(-)

New commits:
commit 2a201107fbd3499292e62b9f9c3ae5c4f28b76a9
Author: Miklos Vajna 
AuthorDate: Wed Nov 22 08:31:17 2023 +0100
Commit: Caolán McNamara 
CommitDate: Thu Nov 23 13:26:38 2023 +0100

sw floattable: fix crash by trying harder to split tables

Regression from commit 60e2fdf1d7e8346e5a3835369c47e582c737ce20 (sw
floattable: maintain the invariant that fly height is at least MINFLY,
2023-09-28), the bugdoc crashed on load in SwTabFrame::MakeAll(),
because the tab frame's HasFollowFlowLine() was true, but
GetFollow()->GetFirstNonHeadlineRow() was nullptr and the invarint is
that these are always in sync.

Digging deeper, what happens is that the master table has a split row at
the end, so the follow table has a "follow flow line". We remove that
when we try to split the master table (split either moves rows to the
follow or creates a new follow), so the follow table only has a
"headline row" remaining. Then Split() is called with bTryToSplit set to
true, this fails (because only a single line would fit the master, but
orphan/widow control rejects that) and then we join the follow table
(because it only has headline rows), so a split with bTryToSplit set to
false (don't split the row itself) never happens. This at the end leads
to a strange table frame with only headline rows and gets deleted, which
is odd to happen during the initial layout.

Fix the problem by remembering if we just removed the follow flow line,
and in case we tried to split the rows itself and table split failed,
then don't join the follow table, so a next split can be invoked with
bTryToSplit set to false, which leads to the correct layout. This means
not only the crash is fixed, but also no layout loop happens and result
matches Word.

Limit this to tables in split flys, at least for this bugdoc the inline
table case would not have this problem as widow/orphan control is
disabled inside inline tables.

(cherry picked from commit 223d2fac61e061478721a7a4a89b1362f5037d8f)

Change-Id: I172e38be11baf6f73df722a4c6c035a6a283d727
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159848
Tested-by: Jenkins CollaboraOffice 
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sw/qa/core/layout/data/floattable-table-join.docx 
b/sw/qa/core/layout/data/floattable-table-join.docx
new file mode 100644
index ..807b4cfa8c11
Binary files /dev/null and b/sw/qa/core/layout/data/floattable-table-join.docx 
differ
diff --git a/sw/qa/core/layout/tabfrm.cxx b/sw/qa/core/layout/tabfrm.cxx
index 44ee7c2a6966..7642c3d29ea6 100644
--- a/sw/qa/core/layout/tabfrm.cxx
+++ b/sw/qa/core/layout/tabfrm.cxx
@@ -13,6 +13,10 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
 
 namespace
 {
@@ -93,6 +97,62 @@ CPPUNIT_TEST_FIXTURE(Test, testSplitFlyNestedRowSpan)
 // Then make sure the resulting page count matches Word:
 CPPUNIT_ASSERT_EQUAL(6, getPages());
 }
+
+CPPUNIT_TEST_FIXTURE(Test, testSplitFlyTableJoin)
+{
+// Given a document with a multi-page floating table:
+// When loading this document:
+createSwDoc("floattable-table-join.docx");
+
+// Then make sure this document doesn't crash the layout and has a 
floating table split on 4
+// pages:
+SwDoc* pDoc = getSwDoc();
+SwRootFrame* pLayout = pDoc->getIDocumentLayoutAccess().GetCurrentLayout();
+auto pPage1 = pLayout->Lower()->DynCastPageFrame();
+CPPUNIT_ASSERT(pPage1);
+CPPUNIT_ASSERT(pPage1->GetSortedObjs());
+{
+SwSortedObjs& rPageObjs = *pPage1->GetSortedObjs();
+CPPUNIT_ASSERT_EQUAL(static_cast(1), rPageObjs.size());
+auto pFly = 
rPageObjs[0]->DynCastFlyFrame()->DynCastFlyAtContentFrame();
+CPPUNIT_ASSERT(pFly);
+// Start of the chain.
+CPPUNIT_ASSERT(!pFly->GetPrecede());
+CPPUNIT_ASSERT(pFly->HasFollow());
+}
+auto pPage2 = pPage1->GetNext()->DynCastPageFrame();
+CPPUNIT_ASSERT(pPage2);
+CPPUNIT_ASSERT(pPage2->GetSortedObjs());
+{
+SwSortedObjs& rPageObjs = *pPage2->GetSortedObjs();
+CPPUNIT_ASSERT_EQUAL(static_cast(1), rPageObjs.size());
+auto pFly = 
rPageObjs[0]->DynCastFlyFrame()->DynCastFlyAtContentFrame();
+CPPUNIT_ASSERT(pFly);
+CPPUNIT_ASSERT(pFly->GetPrecede());
+CPPUNIT_ASSERT(pFly->HasFollow());
+}
+auto pPage3 = pPage2->GetNext()->DynCastPageFrame();
+CPPUNIT_ASSERT(pPage3);
+CPPUNIT_ASSERT(pPage3->GetSortedObjs());
+{
+SwSortedObjs& rPageObjs = *pPage3->GetSortedObjs();
+CPPUNIT_ASSERT_EQUAL(static_cast(1),

[Libreoffice-bugs] [Bug 158333] FILEOPEN: DOCX: Layout differences with justified paragraph if multiple text portions in a line

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158333

László Németh  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 CC||nem...@numbertext.org
 Ever confirmed|0   |1
   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |

--- Comment #3 from László Németh  ---
(In reply to Mike Kaganski from comment #1)
> Likely you forgot to actually attach the text doc mentioned in comment 0.

@Mike: Thanks, indeed!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158323] CRASH when switch back from HTML View to Normal View after edit in HTML source code

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158323

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158323] CRASH when switch back from HTML View to Normal View after edit in HTML source code

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158323

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #3 from Julien Nabet  ---
Created attachment 190990
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190990=edit
gdb bt

On pc Debian x86-64 with master sources updated today, I could reproduce this.

I attached bt with gdb console logs if it can help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-24.2.0.0.alpha1'

2023-11-23 Thread Xisco Fauli (via logerrit)

Tag 'libreoffice-24.2.0.0.alpha1' created by Xisco Fauli 
 at 2023-11-23 12:16 +

Tag libreoffice-24.2.0.0.alpha1
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmVfQokACgkQ9DSh76/u
rqM+Ow//T0ZbgA3Vqt35D5hoJIm8kF9yGr7iWZ+PjhJUHLczCqg42Km3LHqiNFpv
1cYLXejM5IIXM5emQtGoMFl4RtpxFBdMAAV61XtVdxPKw3a27jvLZlYJdLZyvCdx
0x05NZwa4rDx/S81DT2zbp/U9M4eBsrRDME7OxiVSIdl8sFLmUTjto9aA83L1Hf3
B/wKzOvhwt8WAyq+7c5XePPW+62vsmKr54hdDXuTlCSE+WWx05taD23TWafMigwK
KJNbj1XA6QnrfZG0Wn650j6LaJL/DV+/MWEozEwEsLewv6lAwLqmST95/38ZZGbE
Lz+I1ZpqRGThK5LZqou3MT26kSFv/mbg1jVlm9gGZe4QTdUlfNvYMlB7/I4UhWDU
/3UF3zZQ4BF4I+zrcoCR1v8VJo/T3hFeU2QnpbmaFrKkujoIZZx88tvYQ5Tuapc+
ISon5/nfuqfBfSu2grNs29siVZZ0Zbc87YcTU+BwG5W1GNeK9SgY+CGKrqe+zCpD
DXA90hT+cNvfoNdUrPWs1m1HLVS2X3noqeJlG62dzPiZGU3z+C5FMRl/whDizaoL
HtBPrd+LtzPRWDBNZrZhKzA88zxzPnidqEXdLiHTC9ZwjnIrdSLdEUEokhBmaG/L
WGZy1Te/66HotVy0ox/LkB0heq/jM5zxGk0HaYfOoxBE9cyca/E=
=Hyc4
-END PGP SIGNATURE-

Changes since libreoffice-7-6-branch-point-4270:
---
 0 files changed
---

[Libreoffice-commits] core.git: android/source

2023-11-23 Thread Michael Weghorn (via logerrit)

 android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 934a4937e32b4ccf4690b642ccf4787331f37b68
Author: Michael Weghorn 
AuthorDate: Thu Nov 23 11:35:03 2023 +0100
Commit: Michael Weghorn 
CommitDate: Thu Nov 23 13:20:56 2023 +0100

tdf#158331 android: Fix "Save As" for non-experimental mode

While "Save" (i.e. saving back to the original location)
doesn't make sense when editing is disabled (because the
doc cannot be changed) and the menu entry is therefore
not available when the experimental editing mode is
disabled, "Save As" does make sense, e.g. in order to
save a copy of a file opened from another app.

The menu entry was there, but not working as expected,
a 0-byte file was created.

This is because `LibreOfficeMainActivity#saveFileToOriginalSource`
would return early if experimental mode is disabled.
No longer do that, but save the file as requested.

Change-Id: I5785b6060c4ba9cdf3e9c3591b9f941ab987bf4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159857
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git 
a/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java 
b/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java
index 54418f5cbc8f..b21ad02383d7 100644
--- a/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java
+++ b/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java
@@ -416,7 +416,7 @@ public class LibreOfficeMainActivity extends 
AppCompatActivity implements Settin
 }
 
 public void saveFileToOriginalSource() {
-if (isReadOnlyMode() || mTempFile == null || mDocumentUri == null || 
!mDocumentUri.getScheme().equals(ContentResolver.SCHEME_CONTENT))
+if (mTempFile == null || mDocumentUri == null || 
!mDocumentUri.getScheme().equals(ContentResolver.SCHEME_CONTENT))
 return;
 
 boolean copyOK = false;

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-24.2.0.0.alpha1'

2023-11-23 Thread Xisco Fauli (via logerrit)

Tag 'libreoffice-24.2.0.0.alpha1' created by Xisco Fauli 
 at 2023-11-23 12:16 +

Tag libreoffice-24.2.0.0.alpha1
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmVfQogACgkQ9DSh76/u
rqMt/RAAkwkUDmjHiZsb1ZvwobRnL1U3z7t5BAGlvzvTxdFoZJnSNw0/NeaSzDtr
2oujgCZs//MbjPfQLHz2YRy4F0Wqurxt8bgxstMD0/ftdERGsgDB1pq00m1pd200
cbwnsq9eitqYDBqa/cKxVBt8tO1ExUBOUs/v2YEAOZyTwBRurEyhyxaGp2+H3WGe
3PdggCmSvF8zcbRt9cQ5ZZNl84Eu0ujKhr7VkqbOAAJAuOOv4cNaOMredZ7nikCA
PY7X8/c3FxklL5WDpoiTHzSTZuhYEUVqCCVs5Ws243axBCTyQpA9S4AG1H7pBTVc
mF/T0E7b0LOP2zMqtPwn7MPYODmDBPpFfoJ7ocha6HMAL6tKUW1yK9kQOaJr5sUs
+xOgpGzjycqrlwR4b2xko0Ms54/y0AoZQIJTVtrwu3H6ykVjdwob63rQsVkv0Cl5
+t2YGbWRAJSDnvjIYFtsufJW1NoKfN4dQaKPk0AB7DDIt8Ik2R45pCJXq9UoUmyQ
IjDHhbkiX8py2z6QgDFB+9KPbuj+eU8+xkqzfP2f8+w6c2nCK1vWMcRVfSSHMENj
BqBHoYbzNMvEawss3XlCUdhdID6Tbmoronof2j4HfZ/oEhYI82NMTI7PbmxOdtvt
QpGilWNaW8pDrLH1+Jdm4K/tbMaUpOxYxo72RRI0vq9Bka+mZF4=
=VGOl
-END PGP SIGNATURE-

Changes since libreoffice-7-6-branch-point-22:
---
 0 files changed
---

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-24.2.0.0.alpha1'

2023-11-23 Thread Xisco Fauli (via logerrit)

Tag 'libreoffice-24.2.0.0.alpha1' created by Xisco Fauli 
 at 2023-11-23 12:16 +

Tag libreoffice-24.2.0.0.alpha1
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmVfQogACgkQ9DSh76/u
rqOMFg//Q+NBLw+ryJwB7ZFdCDTIC7rMwzPXg+DlfB90Vc94/7zlc4ysEKdWixYM
0vThJSQCsekbkpvXmER/c8TqdFMjRWPPSzMqqE79oYctvjIXZnBATuWd9+xFbYNW
HpHDy+q9CEyOyLr9oM4oqTMx/yZfDkzF7WZP7GNfQI4cf+DKUhYPjAjDVdYfXDhX
ZXvQ8l841gsvn2D1hQSgyQnR7s62hpF08yhNRU3I4NArWkRsgil2P+Ngmf62R3Ir
vjw0WGpF5pNTjdNIzZV9ZqtsRSWsun7s56vWIUJWkB7YyA3X6N/eK1vekURtkXxX
MzwoSBHj4iG8NUAs/K6Ztzw1IQ0qdzqv8RdKI8pWlAXHqy8FQPrT+Hhog5w8pnvi
3PvmklO3XVCEpEF5RfVCsbUPyclL39uNbxcoXdsPRcPUtN9YC5NtRf3Jtah40ShP
TtkZJjyNJQyhR3G/dIFMKXhfSWStnSE05Yk9VtRkK1GjWU78/pTEIK/zQmvyXAJ6
jQEyS9HguX5Y6XYclO25UZY6gqZYwtaPvMsXZRJBCy+5oUnikWNRq6jvl/mCNX34
sVqAFSWakZk5E9isASfFGBJ8MQZ1lrjYjrAF0o4mKhhMP5l0QabouS6zfsrutBXH
vN2YA9jJgS1gLrQ5sujUMCFK58H1RQyUbHJT5dlR2Mfh7TqXJF8=
=2PG9
-END PGP SIGNATURE-

Changes since libreoffice-7-6-branch-point-247:
---
 0 files changed
---

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-24.2.0.0.alpha1'

2023-11-23 Thread Xisco Fauli (via logerrit)

Tag 'libreoffice-24.2.0.0.alpha1' created by Xisco Fauli 
 at 2023-11-23 12:16 +

Tag libreoffice-24.2.0.0.alpha1
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmVfQocACgkQ9DSh76/u
rqPmwhAAhLWhmporU2LuswUYOsQHJ0t3RDnaMAbjh3FfFU9atm8zP0O7y38SIyds
3f5h/hH7FPcBvj5o+JYat72h1buglb18vpM9RCKJPNJUQJMdQpUo46GXICFpq4uq
KUqZImhJoY9GO/zUKod4EtszWNMeAFs1RljT2Tmp94n8CIdxFBYU5DJtYcGUImHU
n1Gw9MJ40mMolCgJerGEjkkSAu7SuXn9d6nIImfTWd5HKyeFsxa9T1FLB4U2W7ST
4OXNnNdQqHZ2VntFoe6xJ84aSe5aKgVAtbU/wt9iruwI3Mq7WKTwnnGdp41Je3fB
yssvein5krX205yClW5f7dFRO/DzOe2CzQDcY63Ooe0P/5FXXR+R04U/COKMXApM
p9pF4wn/Djw/02uIoq9zWckbK3PduWZu5tR6MAX5Q48tPazuC0H6eT6iF/stFlpw
IjUjnR9BBesYQKvo9Z9geztfbkuiDpVjhI1kRsDzlBvKxFHAMimeKnztq2eveYq4
UZPVnvDWKGPubhQ9H+qDrHNrsYDF1WlbLPO3HUU83zHomZ25z1b6wTvdBcL+sdOR
qztcikmSnXMQCWEQ9BHXUsnw7omB+6z4uy3Jee5UpBJQcWia0njZ/lfiX21UQSbY
qmQaJS9tci9l62geVjpbkQfjZn97RF8psfvEq/T8fwNcUq4gxtE=
=VUYi
-END PGP SIGNATURE-

Changes since libreoffice-7-6-branch-point-10:
---
 0 files changed
---

[Libreoffice-bugs] [Bug 158333] FILEOPEN: DOCX: Layout differences with justified paragraph if multiple text portions in a line

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158333

--- Comment #2 from László Németh  ---
Created attachment 190989
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190989=edit
test document

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: configure.ac

2023-11-23 Thread Xisco Fauli (via logerrit)

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1f83730fb54ba68129048d0989bf6c957e0b933b
Author: Xisco Fauli 
AuthorDate: Thu Nov 23 13:18:48 2023 +0100
Commit: Xisco Fauli 
CommitDate: Thu Nov 23 13:18:48 2023 +0100

bump product version to 24.2.0.0.alpha1+

Change-Id: Iabc985c1329d4c1ac31ddf93e8b8f4b6f3c48900

diff --git a/configure.ac b/configure.ac
index eb4dd017a406..e41223ff7ec1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[24.2.0.0.alpha0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[24.2.0.0.alpha1+],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[RESOLVED/INVALID] Re: Visual Studio minimum version 2022 for more compatibility with c++20 ?

2023-11-23 Thread Julien Nabet


Indeed I was wrong, sorry for the noise.

Thank you again Mike! :-)

[Libreoffice-bugs] [Bug 156340] Document contains macro signed by OpenPGP key can't be enabled and causes operation hanging

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=156340

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||156340


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=156340
[Bug 156340] Document contains macro signed by OpenPGP key can't be enabled and
causes operation hanging
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107659

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||156340


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=156340
[Bug 156340] Document contains macro signed by OpenPGP key can't be enabled and
causes operation hanging
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156340] Document contains macro signed by OpenPGP key can't be enabled and causes operation hanging

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=156340

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|7.6.0.0 beta1+  |7.0.4.2 release
URL||https://ask.libreoffice.org
   ||/t/the-right-way-to-sign-a-
   ||macro/93656
 Blocks||107659, 105605
 CC||stephane.guillou@libreoffic
   ||e.org


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107659
[Bug 107659] [META] Macro bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - translations

2023-11-23 Thread Xisco Fauli (via logerrit)

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit aeae57cde7bdbaea83e4be66c63af528861ada32
Author: Xisco Fauli 
AuthorDate: Thu Nov 23 12:57:01 2023 +0100
Commit: Gerrit Code Review 
CommitDate: Thu Nov 23 12:57:01 2023 +0100

Update git submodules

* Update translations from branch 'libreoffice-7-6'
  to 712976a275e961ec7dea3cfb1bf4a3e059946e9c
  - update translations for 7-6

and force-fix errors using pocheck

Change-Id: Ib2ddeb17ecd788d3852eadfd649a1139d9d8b2d9

diff --git a/translations b/translations
index e5a7360dffd0..712976a275e9 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit e5a7360dffd0aed5554da056777d8d8f3e6abcb9
+Subproject commit 712976a275e961ec7dea3cfb1bf4a3e059946e9c

[Libreoffice-commits] translations.git: Branch 'libreoffice-7-6' - source/an source/ast source/bg source/ca source/cs source/el source/es source/gl source/gug source/hsb source/ja source/lt source/nl

2023-11-23 Thread Xisco Fauli (via logerrit)

 source/an/cui/messages.po  |   11 
 source/an/sc/messages.po   |8 
 source/an/svx/messages.po  |9 
 source/an/sw/messages.po   |   10 
 source/ast/cui/messages.po |8 
 source/ast/helpcontent2/source/text/sdatabase.po   |8 
 source/ast/helpcontent2/source/text/shared/01.po   |   16 
 source/ast/helpcontent2/source/text/simpress/01.po |   10 
 source/ast/helpcontent2/source/text/swriter/01.po  |6 
 source/ast/officecfg/registry/data/org/openoffice/Office/UI.po |   13 
 source/ast/sc/messages.po  |6 
 source/ast/sw/messages.po  |9 
 source/bg/helpcontent2/source/text/shared/01.po|   40 
 source/bg/helpcontent2/source/text/swriter/menu.po |   58 -
 source/ca/helpcontent2/source/text/shared/01.po|5 
 source/ca/helpcontent2/source/text/simpress/01.po  |8 
 source/ca/helpcontent2/source/text/swriter/01.po   |6 
 source/ca/officecfg/registry/data/org/openoffice/Office/UI.po  |   18 
 source/cs/helpcontent2/source/text/shared/01.po|8 
 source/cs/helpcontent2/source/text/shared/guide.po |  166 +--
 source/cs/helpcontent2/source/text/swriter/00.po   |   56 -
 source/el/helpcontent2/source/text/shared/00.po|  156 +--
 source/es/helpcontent2/source/text/sdatabase.po|8 
 source/es/helpcontent2/source/text/swriter/01.po   |6 
 source/es/sw/messages.po   |   10 
 source/gl/cui/messages.po  |6 
 source/gl/filter/messages.po   |8 
 source/gl/officecfg/registry/data/org/openoffice/Office/UI.po  |6 
 source/gl/sc/messages.po   |8 
 source/gl/svx/messages.po  |   10 
 source/gug/helpcontent2/source/text/sdatabase.po   |8 
 source/gug/helpcontent2/source/text/swriter/01.po  |6 
 source/hsb/helpcontent2/source/text/shared/optionen.po |   12 
 source/ja/cui/messages.po  |8 
 source/ja/svtools/messages.po  |   10 
 source/ja/sw/messages.po   |   10 
 source/lt/sw/messages.po   |   10 
 source/nl/officecfg/registry/data/org/openoffice/Office/UI.po  |   42 
 source/pl/helpcontent2/source/text/sbasic/shared.po|  476 
+-
 source/pl/helpcontent2/source/text/scalc/01.po |  324 +++---
 source/pl/sc/messages.po   |   10 
 source/pl/scaddins/messages.po |   16 
 42 files changed, 811 insertions(+), 818 deletions(-)

New commits:
commit 712976a275e961ec7dea3cfb1bf4a3e059946e9c
Author: Xisco Fauli 
AuthorDate: Thu Nov 23 12:55:33 2023 +0100
Commit: Xisco Fauli 
CommitDate: Thu Nov 23 12:56:14 2023 +0100

update translations for 7-6

and force-fix errors using pocheck

Change-Id: Ib2ddeb17ecd788d3852eadfd649a1139d9d8b2d9

diff --git a/source/an/cui/messages.po b/source/an/cui/messages.po
index 98d11cbc503..39e5d5b88ff 100644
--- a/source/an/cui/messages.po
+++ b/source/an/cui/messages.po
@@ -4,16 +4,16 @@ msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n;
 "POT-Creation-Date: 2023-07-06 10:56+0200\n"
-"PO-Revision-Date: 2023-06-11 20:35+\n"
+"PO-Revision-Date: 2023-11-23 11:25+\n"
 "Last-Translator: Adolfo Jayme Barrientos \n"
-"Language-Team: Aragonese 
\n"
+"Language-Team: Aragonese 
\n"
 "Language: an\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=n != 1;\n"
 "X-Accelerator-Marker: ~\n"
-"X-Generator: LibreOffice\n"
+"X-Generator: Weblate 5.1.1\n"
 "X-POOTLE-MTIME: 1542195185.00\n"
 
 #. GyY9M
@@ -6118,7 +6118,7 @@ msgstr ""
 #: cui/uiconfig/ui/bulletandposition.ui:919
 msgctxt "bulletandposition|ALlabel"
 msgid "Alignment:"
-msgstr ""
+msgstr "Aliniación:"
 
 #. BfBBW
 #: cui/uiconfig/ui/bulletandposition.ui:937
@@ -13537,10 +13537,9 @@ msgstr ""
 
 #. 7Wuu8
 #: cui/uiconfig/ui/numberingoptionspage.ui:362
-#, fuzzy
 msgctxt "numberingoptionspage|orientft"
 msgid "Alignment:"
-msgstr "Aliniación"
+msgstr "Aliniación:"
 
 #. BJjDU
 #:

[Libreoffice-bugs] [Bug 158333] FILEOPEN: DOCX: Layout differences with justified paragraph if multiple text portions in a line

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158333

--- Comment #1 from Mike Kaganski  ---
Likely you forgot to actually attach the text doc mentioned in comment 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: translations

2023-11-23 Thread Xisco Fauli (via logerrit)

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2de6ca621d47c410bb6082f03cd2b1a960ae1179
Author: Xisco Fauli 
AuthorDate: Thu Nov 23 12:41:28 2023 +0100
Commit: Gerrit Code Review 
CommitDate: Thu Nov 23 12:41:28 2023 +0100

Update git submodules

* Update translations from branch 'master'
  to 0ddbebfba051ff3e347d1074f28c9d43b45ab4c3
  - update translations for master

and force-fix errors using pocheck

Change-Id: I5c3b49c1a54cc4ad00e54e37ceddbd834e2f4579

diff --git a/translations b/translations
index 94a68df82da0..0ddbebfba051 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 94a68df82da0b9bd94e8bc324caac9bf49d4121a
+Subproject commit 0ddbebfba051ff3e347d1074f28c9d43b45ab4c3

[Libreoffice-commits] translations.git: source/an source/ast source/bg source/ca source/cs source/de source/el source/es source/fr source/gl source/gug source/hsb source/ja source/lt source/nl source/

2023-11-23 Thread Xisco Fauli (via logerrit)

 source/an/cui/messages.po |   
13 
 source/an/sc/messages.po  |
8 
 source/an/svx/messages.po |
7 
 source/an/sw/messages.po  |   
12 
 source/ast/cui/messages.po|   
10 
 source/ast/helpcontent2/source/text/sdatabase.po  |
8 
 source/ast/officecfg/registry/data/org/openoffice/Office/UI.po|   
31 
 source/ast/sc/messages.po |
8 
 source/ast/sw/messages.po |
9 
 source/bg/connectivity/registry/macab/org/openoffice/Office/DataAccess.po |   
12 
 source/bg/cui/messages.po |   
50 -
 source/bg/helpcontent2/source/text/sdatabase.po   |
6 
 source/bg/helpcontent2/source/text/shared/01.po   |   
38 
 source/bg/helpcontent2/source/text/swriter/menu.po|   
58 -
 source/bg/officecfg/registry/data/org/openoffice/Office/UI.po |
6 
 source/ca/cui/messages.po |   
10 
 source/ca/officecfg/registry/data/org/openoffice/Office/UI.po |   
38 
 source/ca/sw/messages.po  |   
10 
 source/cs/helpcontent2/source/text/shared/01.po   |
6 
 source/cs/helpcontent2/source/text/shared/guide.po|  
214 ++--
 source/cs/helpcontent2/source/text/swriter/00.po  |   
66 -
 source/de/helpcontent2/source/text/swriter/00.po  |  
176 +--
 source/el/helpcontent2/source/text/shared/00.po   |  
370 +++
 source/es/cui/messages.po |
6 
 source/es/filter/source/config/fragments/types.po |
9 
 source/es/helpcontent2/source/text/sdatabase.po   |   
10 
 source/es/officecfg/registry/data/org/openoffice/Office/UI.po |   
38 
 source/es/sc/messages.po  |   
16 
 source/es/sw/messages.po  |   
16 
 source/es/xmlsecurity/messages.po |   
11 
 source/fr/helpcontent2/source/text/sbasic/shared/03.po|  
104 +-
 source/fr/helpcontent2/source/text/scalc/01.po|  
220 ++--
 source/gl/cui/messages.po |
6 
 source/gl/filter/messages.po  |
6 
 source/gl/officecfg/registry/data/org/openoffice/Office/UI.po |
6 
 source/gl/sc/messages.po  |
8 
 source/gl/svx/messages.po |   
10 
 source/gug/helpcontent2/source/text/sdatabase.po  |   
10 
 source/hsb/helpcontent2/source/text/shared/optionen.po|
6 
 source/ja/cui/messages.po |
8 
 source/ja/svtools/messages.po |
6 
 source/ja/sw/messages.po  |
8 
 source/lt/sw/messages.po  |
8 
 source/nl/helpcontent2/source/text/scalc/00.po|   
24 
 source/nl/officecfg/registry/data/org/openoffice/Office/UI.po |   
40 
 source/pl/helpcontent2/source/text/sbasic/shared.po   |  
476 +-
 source/pl/helpcontent2/source/text/scalc/01.po|  
324 +++---
 source/pl/sc/messages.po  |   
10 
 source/pl/scaddins/messages.po|   
14 
 source/pt-BR/helpcontent2/source/text/scalc/00.po |   
90 -
 source/pt-BR/helpcontent2/source/text/swriter/01.po   |
6 
 51 files changed, 1330 insertions(+), 1332 deletions(-)

New commits:
commit 0ddbebfba051ff3e347d1074f28c9d43b45ab4c3
Author: Xisco Fauli 
AuthorDate: Thu Nov 23 12:39:15 2023 +0100
Commit: Xisco Fauli 
CommitDate: Thu Nov 23 12:40:34 2023 +0100

update translations for master

and force-fix errors using pocheck

Change-Id: I5c3b49c1a54cc4ad00e54e37ceddbd834e2f4579

diff --git a/source/an/cui/messages.po b/source/an/cui/messages.po
index 989f12a7111..ba9b410f648 100644
--- a/source/an/cui/messages.po
+++ b/source/an/cui/messages.po
@@ -4,7 +4,7 @@ msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To:

[Libreoffice-bugs] [Bug 158333] New: FILEOPEN: DOCX: Layout differences with justified paragraph if multiple text portions in a line

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158333

Bug ID: 158333
   Summary: FILEOPEN: DOCX: Layout differences with justified
paragraph if multiple text portions in a line
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nem...@numbertext.org

Description:
Multiple text portions, e.g. if some part of a line contains direct character
formatting breaks DOCX interoperability of justified paragraphs.

Follow-up to Bug 119908.

Steps to Reproduce:
1. Open the attached test document.

Actual Results:
Second line contains two words ("sed. Cras")

Expected Results:
Second line contains only the last word ("Cras")


Reproducible: Always


User Profile Reset: No

Additional Info:
Removing the multiple text portions by clicking in the text, and Ctrl-A Ctrl-C
Ctrl-Shift-V, choosing Unformatted text, the second line contains only the last
word, as requested.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115709

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||157326


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157326
[Bug 157326] track changes on input fields result in exception and not able to
open the document
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157326] track changes on input fields result in exception and not able to open the document

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157326

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|7.3.0.3 release |7.3.0.2 rc
   Priority|medium  |high
 CC||stephane.guillou@libreoffic
   ||e.org,
   ||vasily.melenc...@cib.de
 Blocks||115709

--- Comment #20 from Stéphane Guillou (stragu) 
 ---
Vasily, any chance you could have a look?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115709
[Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158239] Unify lockdown behavior of Options dialog page Impress - Grid

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158239

Balázs Varga (allotropia)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |balazs.varga...@gmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158321] No error message when file doesn't exist

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158321

Noel Grandin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109326] [META] Data filter bugs and enhancements

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=109326
Bug 109326 depends on bug 158072, which changed state.

Bug 158072 Summary: Fails to apply AutoFilter or Standard Filter in Mail Merge 
dialog after it was applied once successfully (Writer+Calc)
https://bugs.documentfoundation.org/show_bug.cgi?id=158072

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158072] Fails to apply AutoFilter or Standard Filter in Mail Merge dialog after it was applied once successfully (Writer+Calc)

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158072

Noel Grandin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102998
Bug 102998 depends on bug 158072, which changed state.

Bug 158072 Summary: Fails to apply AutoFilter or Standard Filter in Mail Merge 
dialog after it was applied once successfully (Writer+Calc)
https://bugs.documentfoundation.org/show_bug.cgi?id=158072

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157326] track changes on input fields result in exception and not able to open the document

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157326

--- Comment #19 from Stéphane Guillou (stragu) 
 ---
*** Bug 157985 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157985] Corrupt DOCX document after saving (track changes involved) 2

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157985

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #14 from Stéphane Guillou (stragu) 
 ---
(In reply to Roman from comment #11)
> Created attachment 190549 [details]
> stdContent_noproblem

Reproduced by editing the contents of this table with Track Changes on and:

Version: 7.5.8.2 (X86_64) / LibreOffice Community
Build ID: f718d63693263970429a68f568db6046aaa9df01
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

As well as:

Version: 7.6.3.1 (X86_64) / LibreOffice Community
Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

In any case, seems like the same issue as bug 157326, marking as a duplicate.

*** This bug has been marked as a duplicate of bug 157326 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158321] No error message when file doesn't exist

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158321

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: comphelper/source include/comphelper include/ucbhelper ucbhelper/source unotools/source

2023-11-23 Thread Noel Grandin (via logerrit)

 comphelper/source/misc/simplefileaccessinteraction.cxx |   12 +--
 comphelper/source/misc/stillreadwriteinteraction.cxx   |   61 -
 include/comphelper/stillreadwriteinteraction.hxx   |6 +
 include/ucbhelper/interceptedinteraction.hxx   |   34 ++---
 ucbhelper/source/client/interceptedinteraction.cxx |8 +-
 unotools/source/misc/mediadescriptor.cxx   |1 
 6 files changed, 73 insertions(+), 49 deletions(-)

New commits:
commit 59280a9ce5a15136a6fdd383aedf02c6cf7d6e96
Author: Noel Grandin 
AuthorDate: Thu Nov 23 10:01:44 2023 +0100
Commit: Noel Grandin 
CommitDate: Thu Nov 23 12:07:09 2023 +0100

tdf#158321 No error message when file doesn't exist

Revert "reduce allocations in InterceptedInteraction"

This reverts commit e3c961e6a3917d95534652e0f982918cc1079015.

Change-Id: I26ba0acaa088dff1800ccd69513056f821bd4d7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159762
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/misc/simplefileaccessinteraction.cxx 
b/comphelper/source/misc/simplefileaccessinteraction.cxx
index 15029a1230e0..8cd77af7d693 100644
--- a/comphelper/source/misc/simplefileaccessinteraction.cxx
+++ b/comphelper/source/misc/simplefileaccessinteraction.cxx
@@ -29,9 +29,10 @@ const sal_Int32 HANDLE_CERTIFICATEREQUEST = 3;
 /// Will handle com::sun::star::ucb::AuthenticationRequest
 const sal_Int32 HANDLE_AUTHENTICATIONREQUEST = 4;
 
-static std::span getInterceptions()
+SimpleFileAccessInteraction::SimpleFileAccessInteraction(
+const css::uno::Reference& xHandler)
 {
-static const ::ucbhelper::InterceptedInteraction::InterceptedRequest 
lInterceptions[]{
+std::vector<::ucbhelper::InterceptedInteraction::InterceptedRequest> 
lInterceptions{
 { //intercept standard IO error exception (local file and WebDAV)
   css::uno::Any(css::ucb::InteractiveIOException()),
   cppu::UnoType::get(), 
HANDLE_INTERACTIVEIOEXCEPTION },
@@ -51,14 +52,9 @@ static std::span
   css::uno::Any(css::ucb::AuthenticationRequest()),
   cppu::UnoType::get(), 
HANDLE_AUTHENTICATIONREQUEST }
 };
-return lInterceptions;
-}
 
-SimpleFileAccessInteraction::SimpleFileAccessInteraction(
-const css::uno::Reference& xHandler)
-: InterceptedInteraction(getInterceptions())
-{
 setInterceptedHandler(xHandler);
+setInterceptions(std::move(lInterceptions));
 }
 
 SimpleFileAccessInteraction::~SimpleFileAccessInteraction() {}
diff --git a/comphelper/source/misc/stillreadwriteinteraction.cxx 
b/comphelper/source/misc/stillreadwriteinteraction.cxx
index 191b751f978d..88bc25bc46cb 100644
--- a/comphelper/source/misc/stillreadwriteinteraction.cxx
+++ b/comphelper/source/misc/stillreadwriteinteraction.cxx
@@ -34,42 +34,43 @@
 
 namespace comphelper{
 
-const sal_Int32 HANDLE_INTERACTIVEIOEXCEPTION   = 0;
-const sal_Int32 HANDLE_UNSUPPORTEDDATASINKEXCEPTION = 1;
-const sal_Int32 HANDLE_AUTHENTICATIONREQUESTEXCEPTION = 2;
-const sal_Int32 HANDLE_CERTIFICATEVALIDATIONREQUESTEXCEPTION = 3;
-
-static std::span getInterceptions()
-{
-static const ::ucbhelper::InterceptedInteraction::InterceptedRequest 
lInterceptions[] {
-{
-  css::uno::Any(css::ucb::InteractiveIOException()),
-  cppu::UnoType::get(), 
HANDLE_INTERACTIVEIOEXCEPTION
-},
-{
-  css::uno::Any(css::ucb::UnsupportedDataSinkException()),
-  cppu::UnoType::get(), 
HANDLE_UNSUPPORTEDDATASINKEXCEPTION
-},
-{
-  css::uno::Any(css::ucb::AuthenticationRequest()),
-  cppu::UnoType::get(), 
HANDLE_AUTHENTICATIONREQUESTEXCEPTION
-},
-{
-  css::uno::Any(css::ucb::CertificateValidationRequest()),
-  cppu::UnoType::get(), 
HANDLE_CERTIFICATEVALIDATIONREQUESTEXCEPTION
-},
-};
-return lInterceptions;
-}
-
 StillReadWriteInteraction::StillReadWriteInteraction(const 
css::uno::Reference< css::task::XInteractionHandler >& xHandler,
  css::uno::Reference< 
css::task::XInteractionHandler > xAuxiliaryHandler)
- : InterceptedInteraction(getInterceptions())
- , m_bUsed(false)
+ : m_bUsed(false)
  , m_bHandledByMySelf (false)
  , m_xAuxiliaryHandler(std::move(xAuxiliaryHandler))
 {
+std::vector< ::ucbhelper::InterceptedInteraction::InterceptedRequest > 
lInterceptions;
+lInterceptions.reserve(4);
+::ucbhelper::InterceptedInteraction::InterceptedRequest  
aInterceptedRequest;
+
+aInterceptedRequest.Handle = HANDLE_INTERACTIVEIOEXCEPTION;
+aInterceptedRequest.Request <<= css::ucb::InteractiveIOException();
+aInterceptedRequest.Continuation = 
cppu::UnoType::get();
+lInterceptions.push_back(aInterceptedRequest);
+
+aInterceptedRequest.Handle =

[Libreoffice-bugs] [Bug 158072] Fails to apply AutoFilter or Standard Filter in Mail Merge dialog after it was applied once successfully (Writer+Calc)

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158072

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: connectivity/source

2023-11-23 Thread Noel Grandin (via logerrit)

 connectivity/source/drivers/component/CDatabaseMetaData.cxx |  125 
 connectivity/source/drivers/dbase/DDatabaseMetaData.cxx |  173 +---
 connectivity/source/drivers/file/FDatabaseMetaData.cxx  |8 
 3 files changed, 146 insertions(+), 160 deletions(-)

New commits:
commit f23ee916466bd6e0d328a4e541e104445c8ecb0a
Author: Noel Grandin 
AuthorDate: Thu Nov 23 11:16:23 2023 +0200
Commit: Noel Grandin 
CommitDate: Thu Nov 23 12:06:50 2023 +0100

tdf#158072 Fails to apply AutoFilter in Mail Merge dialog

regression from
commit 66b0bc55854ba13b92b6c39b95f3f2d4ef76bf20
Author: Noel Grandin 
Date:   Fri Mar 10 10:35:33 2023 +0200
simplify initialisation in *DatabaseMetaData
where I failed to notice that the supposedly static data was being
std::move'd

Change-Id: I6238fa8e20ee6ca9fe31c29a7e05262dc1e3bede
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159851
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/connectivity/source/drivers/component/CDatabaseMetaData.cxx 
b/connectivity/source/drivers/component/CDatabaseMetaData.cxx
index bbd921bca3f6..49d83e36af12 100644
--- a/connectivity/source/drivers/component/CDatabaseMetaData.cxx
+++ b/connectivity/source/drivers/component/CDatabaseMetaData.cxx
@@ -48,72 +48,67 @@ Reference< XResultSet > 
OComponentDatabaseMetaData::impl_getTypeInfo_throw(  )
 {
 rtl::Reference pResult = new 
ODatabaseMetaDataResultSet(::connectivity::ODatabaseMetaDataResultSet::eTypeInfo);
 
-static ODatabaseMetaDataResultSet::ORows aRows = []()
+ODatabaseMetaDataResultSet::ORows aRows;
+aRows.reserve(6);
+ODatabaseMetaDataResultSet::ORow aRow
 {
-ODatabaseMetaDataResultSet::ORows aTmp;
-aTmp.reserve(6);
-ODatabaseMetaDataResultSet::ORow aRow
-{
-ODatabaseMetaDataResultSet::getEmptyValue(),
-new ORowSetValueDecorator(OUString("VARCHAR")),
-new ORowSetValueDecorator(DataType::VARCHAR),
-new ORowSetValueDecorator(sal_Int32(65535)),
-ODatabaseMetaDataResultSet::getQuoteValue(),
-ODatabaseMetaDataResultSet::getQuoteValue(),
-ODatabaseMetaDataResultSet::getEmptyValue(),
-ODatabaseMetaDataResultSet::get1Value(), // 
ORowSetValue((sal_Int32)ColumnValue::NULLABLE
-ODatabaseMetaDataResultSet::get1Value(),
-new ORowSetValueDecorator(sal_Int32(ColumnSearch::CHAR)),
-ODatabaseMetaDataResultSet::get1Value(),
-ODatabaseMetaDataResultSet::get0Value(),
-ODatabaseMetaDataResultSet::get0Value(),
-ODatabaseMetaDataResultSet::getEmptyValue(),
-ODatabaseMetaDataResultSet::get0Value(),
-ODatabaseMetaDataResultSet::get0Value(),
-ODatabaseMetaDataResultSet::getEmptyValue(),
-ODatabaseMetaDataResultSet::getEmptyValue(),
-new ORowSetValueDecorator(sal_Int32(10))
-};
-
-aTmp.push_back(aRow);
-
-aRow[1] = new ORowSetValueDecorator(OUString("DECIMAL"));
-aRow[2] = new ORowSetValueDecorator(DataType::DECIMAL);
-aRow[3] = ODatabaseMetaDataResultSet::get0Value();
-aRow[9] = ODatabaseMetaDataResultSet::getBasicValue();
-aRow[15] = ODatabaseMetaDataResultSet::get0Value();
-aTmp.push_back(aRow);
-
-aRow[1] = new ORowSetValueDecorator(OUString("BOOL"));
-aRow[2] = new ORowSetValueDecorator(DataType::BIT);
-aRow[3] = new ORowSetValueDecorator(sal_Int32(20));
-aRow[9] = ODatabaseMetaDataResultSet::getBasicValue();
-aRow[15] = new ORowSetValueDecorator(sal_Int32(15));
-aTmp.push_back(aRow);
-
-aRow[1] = new ORowSetValueDecorator(OUString("DATE"));
-aRow[2] = new ORowSetValueDecorator(DataType::DATE);
-aRow[3] = ODatabaseMetaDataResultSet::get0Value();
-aRow[9] = ODatabaseMetaDataResultSet::getBasicValue();
-aRow[15] = ODatabaseMetaDataResultSet::get0Value();
-aTmp.push_back(aRow);
-
-aRow[1] = new ORowSetValueDecorator(OUString("TIME"));
-aRow[2] = new ORowSetValueDecorator(DataType::TIME);
-aRow[3] = ODatabaseMetaDataResultSet::get0Value();
-aRow[9] = ODatabaseMetaDataResultSet::getBasicValue();
-aRow[15] = ODatabaseMetaDataResultSet::get0Value();
-aTmp.push_back(aRow);
-
-aRow[1] = new ORowSetValueDecorator(OUString("TIMESTAMP"));
-aRow[2] = new ORowSetValueDecorator(DataType::TIMESTAMP);
-aRow[3] = ODatabaseMetaDataResultSet::get0Value();
-aRow[9] = ODatabaseMetaDataResultSet::getBasicValue();
-aRow[15] = ODatabaseMetaDataResultSet::get0Value();
-aTmp.push_back(aRow);
-
-return aTmp;
-}();
+ODatabaseMetaDataResultSet::getEmptyValue(),
+new ORowSetValueDecorator(OUString("VARCHAR")),
+new ORowSetValueDecorator(DataType::VARCHAR),
+new

[Libreoffice-bugs] [Bug 155782] Unable to open 17 page docx file properly

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155782

BogdanB  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155904] docx file is not available in file open?

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155904

Buovjaga  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158331] Android Viewer: "Save as" creates 0 byte file (with Experimentation Mode turned off)

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158331

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |m.wegh...@posteo.de
   |desktop.org |

--- Comment #3 from Michael Weghorn  ---
Pending fix (makes saving work rather than removing the menu entry):
https://gerrit.libreoffice.org/c/core/+/159857

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sfx2/source sw/source

2023-11-23 Thread Caolán McNamara (via logerrit)

 sfx2/source/appl/appserv.cxx  |9 +
 sw/source/uibase/wrtsh/wrtsh2.cxx |5 +
 2 files changed, 10 insertions(+), 4 deletions(-)

New commits:
commit d7b33b1be8fee684e906f170f4001735c095056e
Author: Caolán McNamara 
AuthorDate: Thu Nov 23 08:53:30 2023 +
Commit: Caolán McNamara 
CommitDate: Thu Nov 23 11:48:55 2023 +0100

use SID_DOCFRAME for dialog parents if there is no SID_FILLFRAME

if there is no other hint

which avoids: sfx2/source/appl/appserv.cxx:314: no parent for dialogs
without the need to add extra SID_FILLFRAME just to smuggle a default
parent in.

Change-Id: I99980c951a0046afa3cc22e02b4f79850e3b2736
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159850
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index d58b62a9bf3b..9c1b3c9d2a57 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -256,6 +256,13 @@ namespace
 return xFrame;
 }
 
+Reference GetDocFrame(const SfxRequest& rReq)
+{
+const SfxFrameItem* pFrameItem = 
rReq.GetArg(SID_DOCFRAME);
+SfxFrame* pFrame = pFrameItem ? pFrameItem->GetFrame() : nullptr;
+return pFrame ? pFrame->GetFrameInterface() : nullptr;
+}
+
 class LicenseDialog : public weld::GenericDialogController
 {
 public:
@@ -309,6 +316,8 @@ weld::Window* SfxRequest::GetFrameWeld() const
 }
 
 Reference xFrame(GetRequestFrame(*this));
+if (!xFrame)
+xFrame = GetDocFrame(*this);
 if (!xFrame)
 {
 SAL_WARN("sfx.appl", "no parent for dialogs");
diff --git a/sw/source/uibase/wrtsh/wrtsh2.cxx 
b/sw/source/uibase/wrtsh/wrtsh2.cxx
index 029b728bb30a..3a9e51136fd0 100644
--- a/sw/source/uibase/wrtsh/wrtsh2.cxx
+++ b/sw/source/uibase/wrtsh/wrtsh2.cxx
@@ -597,8 +597,6 @@ static void LoadURL(SwView& rView, const OUString& rURL, 
LoadUrlFlags nFilter,
 if ((nFilter & LoadUrlFlags::NewView) && 
!comphelper::LibreOfficeKit::isActive())
 aTargetFrameName.SetValue( "_blank" );
 
-SfxUnoFrameItem aDocFrame(SID_FILLFRAME, 
rViewFrame.GetFrame().GetFrameInterface());
-
 rViewFrame.GetDispatcher()->ExecuteList(SID_OPENDOC,
 SfxCallMode::ASYNCHRON|SfxCallMode::RECORD,
 {
@@ -607,8 +605,7 @@ static void LoadURL(SwView& rView, const OUString& rURL, 
LoadUrlFlags nFilter,
 ,
 , ,
 
-},
-{  } );
+});
 }
 
 void LoadURL( SwViewShell& rVSh, const OUString& rURL, LoadUrlFlags nFilter,

[Libreoffice-bugs] [Bug 157031] Character dialog opens with small but annoying lag (3 seconds) every time when opening (macOS)

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157031

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|24.2.0.0 alpha0+ Master |7.5.4.2 release
 CC||kha...@libreoffice.org,
   ||stephane.guillou@libreoffic
   ||e.org

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Reproduced on macOS:

7.4.6: ~1 second
7.5.4: above 2 seconds
7.6.2: above 2 seconds
24.2 at c60a9db1f2a8e2a088c6b89bcdff4901b28f2864: above 2 seconds

Definitely noticeable now. I'd say the change happened somewhere in 7.5.

Format > Paragraph stays below 2 seconds in all versions tested, no change.

on Linux, not reproduced.

Wondering if it could have a link to the fix for bug 152460, given that I see
the same kind of delay for another dialog with font preview, e.g. Styles > Edit
Style...

Khaled, what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: translations

2023-11-23 Thread Martin Srebotnjak (via logerrit)

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 93aa534cee0ab74b9ad4b72b739e9a26c6dfc129
Author: Martin Srebotnjak 
AuthorDate: Thu Nov 23 11:41:28 2023 +0100
Commit: Gerrit Code Review 
CommitDate: Thu Nov 23 11:41:28 2023 +0100

Update git submodules

* Update translations from branch 'master'
  to 94a68df82da0b9bd94e8bc324caac9bf49d4121a
  - Updated Slovenian translation

Change-Id: I97fbc2c814dd61ddd17032540ca4ee24b8c61324

diff --git a/translations b/translations
index d0fb14adc609..94a68df82da0 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit d0fb14adc60976ff54a9561254d070717a76004c
+Subproject commit 94a68df82da0b9bd94e8bc324caac9bf49d4121a

[Libreoffice-commits] translations.git: source/sl

2023-11-23 Thread Martin Srebotnjak (via logerrit)

 source/sl/connectivity/registry/macab/org/openoffice/Office/DataAccess.po |   
15 
 source/sl/cui/messages.po | 
2248 ++---
 source/sl/dbaccess/messages.po|  
176 
 source/sl/desktop/messages.po |   
47 
 source/sl/extensions/messages.po  |   
10 
 source/sl/filter/source/config/fragments/filters.po   |   
35 
 source/sl/filter/source/config/fragments/internalgraphicfilters.po|   
15 
 source/sl/filter/source/config/fragments/types.po |   
17 
 source/sl/helpcontent2/source/auxiliary.po|   
12 
 source/sl/helpcontent2/source/text/sbasic/guide.po|   
12 
 source/sl/helpcontent2/source/text/sbasic/shared.po   |   
84 
 source/sl/helpcontent2/source/text/sbasic/shared/03.po| 
2202 +
 source/sl/helpcontent2/source/text/scalc.po   |  
276 
 source/sl/helpcontent2/source/text/scalc/00.po| 
1330 ++-
 source/sl/helpcontent2/source/text/scalc/01.po| 
2128 +++--
 source/sl/helpcontent2/source/text/scalc/guide.po |   
28 
 source/sl/helpcontent2/source/text/sdatabase.po   |   
12 
 source/sl/helpcontent2/source/text/sdraw.po   |   
52 
 source/sl/helpcontent2/source/text/shared.po  |  
572 -
 source/sl/helpcontent2/source/text/shared/00.po   | 
3874 +++---
 source/sl/helpcontent2/source/text/shared/01.po   | 
3350 +++-
 source/sl/helpcontent2/source/text/shared/02.po   |  
822 +-
 source/sl/helpcontent2/source/text/shared/autopi.po   | 
1356 ---
 source/sl/helpcontent2/source/text/shared/guide.po|  
246 
 source/sl/helpcontent2/source/text/shared/menu.po |  
776 +-
 source/sl/helpcontent2/source/text/shared/optionen.po |  
320 
 source/sl/helpcontent2/source/text/simpress.po|   
64 
 source/sl/helpcontent2/source/text/simpress/00.po |   
84 
 source/sl/helpcontent2/source/text/simpress/01.po |   
80 
 source/sl/helpcontent2/source/text/simpress/02.po |   
12 
 source/sl/helpcontent2/source/text/simpress/guide.po  |   
84 
 source/sl/helpcontent2/source/text/swriter.po | 
1034 --
 source/sl/helpcontent2/source/text/swriter/00.po  | 
1672 +++-
 source/sl/helpcontent2/source/text/swriter/01.po  | 
1904 ++--
 source/sl/helpcontent2/source/text/swriter/02.po  |  
436 +
 source/sl/helpcontent2/source/text/swriter/04.po  |   
26 
 source/sl/helpcontent2/source/text/swriter/guide.po   |  
324 
 source/sl/helpcontent2/source/text/swriter/librelogo.po   |   
16 
 source/sl/helpcontent2/source/text/swriter/menu.po|   
26 
 source/sl/officecfg/registry/data/org/openoffice/Office.po|  
355 
 source/sl/officecfg/registry/data/org/openoffice/Office/UI.po |  
359 
 source/sl/sc/messages.po  |  
986 +-
 source/sl/sd/messages.po  | 
2301 ++---
 source/sl/sfx2/messages.po|  
779 +-
 source/sl/starmath/messages.po|  
694 -
 source/sl/svtools/messages.po |   
38 
 source/sl/svx/messages.po | 
1613 ++--
 source/sl/sw/messages.po  | 
3349 
 source/sl/uui/messages.po |   
21 
 source/sl/vcl/messages.po |  
121 
 source/sl/xmlsecurity/messages.po |  
118 
 51 files changed, 22059 insertions(+), 14452 deletions(-)

New commits:
commit 94a68df82da0b9bd94e8bc324caac9bf49d4121a
Author: Martin Srebotnjak 
AuthorDate: Thu Nov 23 11:41:22 2023 +0100
Commit: Andras Timar 
CommitDate: Thu Nov 23 11:41:22 2023 +0100

Updated Slovenian translation

Change-Id: I97fbc2c814dd61ddd17032540ca4ee24b8c61324

diff --git 
a/source/sl/connectivity/registry/macab/org/openoffice/Office/DataAccess.po 
b/source/sl/connectivity/registry/macab/org/openoffice/Office/DataAccess.po
index 1a5d1239804..2b11923fbd4 100644
---

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - android/source

2023-11-23 Thread Michael Weghorn (via logerrit)

 android/source/res/layout/activity_main.xml |4 ++--
 android/source/res/values/dimens.xml|1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit b5013b9d79270522d8b121258496373abe5f2d45
Author: Michael Weghorn 
AuthorDate: Wed Nov 22 09:27:45 2023 +0100
Commit: Michael Stahl 
CommitDate: Thu Nov 23 11:39:38 2023 +0100

tdf#158307 android a11y: Auto-detect toolbar height

Instead of hard-coding a toolbar height for the
cell address and formula bar in Calc, use
`android:layout_height="wrap_content"`, so the height
is determined based on the font size.
This avoids the text getting cut off when a large
font size has been selected in Android's accessibility
settings.

Change-Id: I9bfbe2b7a1db39ac11d9ed0ab15290f974782489
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159809
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
(cherry picked from commit abed55b1ea7f04a0a522d54e369d170a71045cd5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159757
Reviewed-by: Michael Stahl 

diff --git a/android/source/res/layout/activity_main.xml 
b/android/source/res/layout/activity_main.xml
index bd444f9fe79f..c03f0c93aea9 100644
--- a/android/source/res/layout/activity_main.xml
+++ b/android/source/res/layout/activity_main.xml
@@ -42,7 +42,7 @@
 256dp
 48dp
 24dp
-40dp
 96dp
 -11dp
 -7dp

[Libreoffice-bugs] [Bug 155927] rtf terminates vnc session

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155927

jindam, vani  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from jindam, vani  ---
* no repro
Version: 7.6.3.1 (ARM_EABI) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155904] docx file is not available in file open?

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155904

jindam, vani  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from jindam, vani  ---
* no repro
Version: 7.6.3.1 (ARM_EABI) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158332] Areas from the context menu remain after exiting the presentation (VCL gtk3, DE kde and Xfce)

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158332

--- Comment #2 from Vladislav Tarakanov  ---
Created attachment 190988
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190988=edit
Check with Xfce

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158332] Areas from the context menu remain after exiting the presentation (VCL gtk3, DE kde and Xfce)

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158332

--- Comment #1 from Vladislav Tarakanov  ---
Created attachment 190987
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190987=edit
Check with KDE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158332] New: Areas from the context menu remain after exiting the presentation (VCL gtk3, DE kde and Xfce)

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158332

Bug ID: 158332
   Summary: Areas from the context menu remain after exiting the
presentation (VCL gtk3, DE kde and Xfce)
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vladislav.taraka...@bk.ru

Description:
When the right mouse button is pressed on the screen that appears after the
presentation is completed (with the inscription "Click to exit
presentation..."), the area on the screen that should have been in place of the
context menu will remain. The problem was reproduced with the VCL plugin with
the KDE and XFce desktop environments (on Debian 12). The problem is not
reproducible with DE Gnome.

This problem was noticed only with the gtk3 plugin; in kf5, right-clicking the
mouse does not complete the demo. On Windows, RMB also does not end the demo.

Should this behavior be treated as a LO error or should this problem be fixed
in DE?

Steps to Reproduce:
1. Run Impress with gtk3 plugin and KDE desktop environment 
2. Start the demonstration, go to the screen with "Click to exit
presentation..."
3. Press RMB

Actual Results:
The demonstration ends and the area on the screen remains in the place where
the context menu should have been displayed

Expected Results:
The demo ends without displaying the context menu area, or the demo does not
end but the context menu is displayed


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 13eb599d8b0f81e4024f4aa2a6dd8b074f80a9df
CPU threads: 12; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157658] saving a change to password protected DOCX makes document unprotected

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157658

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
   Hardware|Other   |ARM

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
I tested again, still can't reproduce with:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c60a9db1f2a8e2a088c6b89bcdff4901b28f2864
CPU threads: 2; OS: macOS 13.2.1; UI render: Skia/Raster; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

* Can you still reproduce in a more recent version, e.g. 7.6.3? Wondering if
the resolution of bug 142147 helps.
* Can you try creating a sample document from scratch in which you can
reproduce the issue, that you could share (along with its password)?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155888] SAXException: No input source at /home/abuild/rpmbuild/BUILD/libreoffice-7.5.4.2/sax/source/fastparser/fastparser.cxx:1055

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155888

jindam, vani  changed:

   What|Removed |Added

 CC||jindam.v...@disroot.org

--- Comment #3 from jindam, vani  ---
* repro with slightly modified message
* .docx opens
Version: 7.6.3.1 (ARM_EABI) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

An error occurred during opening the file. This may be caused by incorrect file
contents.
The error details are:
SAXException: No input source at
/home/abuild/rpmbuild/BUILD/libreoffice-7.6.3.1/sax/source/fastparser/fastparser.cxx:1042
Proceeding with import may cause data loss or corruption, and application may
become unstable or crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155788] page 1 with image missing on docx

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155788

--- Comment #9 from jindam, vani  ---
Created attachment 190986
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190986=edit
screenshot repro 7.6.3.1 (ARM_EABI) / LibreOffice Community

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155788] page 1 with image missing on docx

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155788

--- Comment #8 from jindam, vani  ---
* still repro
Version: 7.6.3.1 (ARM_EABI) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158291] The term "Field Shadings" is confusing

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158291

--- Comment #3 from Adolfo Jayme Barrientos  ---
"Indicators"?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 158291] The term "Field Shadings" is confusing

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158291

--- Comment #3 from Adolfo Jayme Barrientos  ---
"Indicators"?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 86899] [META] Requests for the addition of UNO commands

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86899

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||158196


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158196
[Bug 158196] Add 'shuffle' or 'random' option to 'Sort' dialog
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 158196] Add 'shuffle' or 'random' option to 'Sort' dialog

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158196

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
 Blocks||86899
   Keywords|needsUXEval |
   Assignee|libreoffice-b...@lists.free |qui...@gmail.com
   |desktop.org |

--- Comment #16 from Heiko Tietze  ---
We discussed the topic in the design meeting.

The function is very much welcome. Adding it to the sort dialog is quite
confusing given that you first sort asc by column A, then randomly by B, and
last desc for C. Makes no sense.

So we recommend to add the command "Unsort Selection" under Data next to the
sort options. (an alternative to unsort would be shuffle; randomize might be
misleading)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86899
[Bug 86899] [META] Requests for the addition of UNO commands
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 158196] Add 'shuffle' or 'random' option to 'Sort' dialog

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158196

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
 Blocks||86899
   Keywords|needsUXEval |
   Assignee|libreoffice-b...@lists.free |qui...@gmail.com
   |desktop.org |

--- Comment #16 from Heiko Tietze  ---
We discussed the topic in the design meeting.

The function is very much welcome. Adding it to the sort dialog is quite
confusing given that you first sort asc by column A, then randomly by B, and
last desc for C. Makes no sense.

So we recommend to add the command "Unsort Selection" under Data next to the
sort options. (an alternative to unsort would be shuffle; randomize might be
misleading)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86899
[Bug 86899] [META] Requests for the addition of UNO commands
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158238] Unify lockdown behavior of Options dialog page Impress - View

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158238

Balázs Varga (allotropia)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |balazs.varga...@gmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101912
Bug 101912 depends on bug 100530, which changed state.

Bug 100530 Summary: Unable to access LibreOffice Online menu or toolbar 
(CollaboraCloudSuite) via keyboard when using a screen reader
https://bugs.documentfoundation.org/show_bug.cgi?id=100530

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTOURBUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 100530] Unable to access LibreOffice Online menu or toolbar (CollaboraCloudSuite) via keyboard when using a screen reader

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100530

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |NOTOURBUG
 Status|NEW |RESOLVED

--- Comment #14 from Michael Weghorn  ---
I've seen various accessibility-related commits for LibreOfficeKit (that's used
by Collabora Online) in LibreOffice core recently, but don't know about the
current status.

In any case, since this is about Collabora Online, I'm closing this as
NOTOURBUG.

If this is still an issue, it should be tracked via an issue in the Collabora
Online Github repo instead:
https://github.com/CollaboraOnline/online/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157253] Repaint: padding covers end of last word when changing alignment in table cell (steps in comment 7)

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=157253

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 OS|Linux (All) |All

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
Reproduced on macOS Ventura with a 1920×1080 display:

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 2; OS: Mac OS X 13.2.1; UI render: Skia/Raster; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US

Switching windows or slides repaints and shows the full word.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158297] Pasting unformatted text over existing values - an empty line will not handle the last column value (STR comment 8)

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158297

MBS  changed:

   What|Removed |Added

   Assignee|schilha...@zks.uni-kiel.de  |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #9 from MBS  ---
> @MBS, Are you really assigning this report to yourself, in order to work on 
> it?
Aww, no, I'm not able to work on it! :-O

I'm just a user (complaining), not native in English, struggling with the WIKI
(TLDR). Please assign it to someone able to fix it or to decide to state this
as a wanted phenomenon. How to change this? default? Can you change this?

Concerning your description:

> Until LO 5.2.0.4, the result is (as expected):
> 
> Legend;1;2;3
> b;b-1;b-2;b-3
> empty;b-1;b-2;b-3
> d;d-1;d-2;d-3
> e;e-1;e-2;e-3

IMHO this is NOT what was to expect (unless "skip empty cells" was ticked),
since the source contained an empty line (empty;;;) which is now NOT empty
after the source was copied to the target.

The "skip empty cells" option allows to fix a target table with new values
(changed or extending the table) and leave the "good" values in the target by
pasting empty fields over it, then the former values remain in the target.

> With these settings in the import dialogue, IMO the result should had been as 
> it was before, in LO 5.2.0.4 and older.
I disagree with that.

It should result in this:

Legend;1;2;3
b;b-1;b-2;b-3
empty;;;
d;d-1;d-2;d-3
e;e-1;e-2;e-3

[skip empty cells]
btw when the "skip empty cells" option was ticked the result from comment 8
would be:

Legend;1;2;3
b;b-1;b-2;b-3
empty;b-1;b-2;b-3
d;d-1;d-2;d-3
e;e-1;e-2;e-3

all source cells with values overwrite existing target cells (updating them)
and empty ones from source will remain untouched in the target.
Maybe this is the differential replacement you were looking for?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158112

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval, regression |accessibility

--- Comment #7 from Heiko Tietze  ---
We discussed the topic in the design meeting.

An idea to solve the problem is to use alt+shift+. Or to remove the
default shortcuts, and make it available for customization. This means a
considerable effort and could be detrimental to a11y (no default). 

Sidenote: ctrl+alt+ is available for customization but should not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158112

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval, regression |accessibility

--- Comment #7 from Heiko Tietze  ---
We discussed the topic in the design meeting.

An idea to solve the problem is to use alt+shift+. Or to remove the
default shortcuts, and make it available for customization. This means a
considerable effort and could be detrimental to a11y (no default). 

Sidenote: ctrl+alt+ is available for customization but should not.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 158168] add UNO command for Hidden font effect of characters in Writer

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158168

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #6 from Heiko Tietze  ---
We discussed the topic in the design meeting.

The proposed character style might be a workaround but wouldn't be effective if
the text has a CS applied, eg. Emphasis. Switching to "Hidden" CS overwrites
the actual style - and duplicating every CS makes no sense too.

So we propose to add the command and apply the hidden attribute as direct
formatting.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 158168] add UNO command for Hidden font effect of characters in Writer

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158168

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #6 from Heiko Tietze  ---
We discussed the topic in the design meeting.

The proposed character style might be a workaround but wouldn't be effective if
the text has a CS applied, eg. Emphasis. Switching to "Hidden" CS overwrites
the actual style - and duplicating every CS makes no sense too.

So we propose to add the command and apply the hidden attribute as direct
formatting.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: svx/source

2023-11-23 Thread Noel Grandin (via logerrit)

 svx/source/dialog/framelinkarray.cxx |  207 +--
 1 file changed, 104 insertions(+), 103 deletions(-)

New commits:
commit ac424db10e963864bc5744897561e0bf127a615c
Author: Noel Grandin 
AuthorDate: Thu Nov 23 09:28:46 2023 +0200
Commit: Noel Grandin 
CommitDate: Thu Nov 23 10:37:23 2023 +0100

re-apply "Work with what we have in ArrayImpl: pointers"

re-apply commit f7df46c917533d3ce3528d52f49629fe9f51e67b "Work with what
we have in ArrayImpl: pointers", which I somehow managed to revert while
preparing commit d9c726beb64968e84d2150824c81dcf0a8b66ec2 "optimise
framelinkarray lookup"

Change-Id: I05c3da965ef334597f17fea9deded28218b15a47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159846
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svx/source/dialog/framelinkarray.cxx 
b/svx/source/dialog/framelinkarray.cxx
index 3431c861fcfd..21afef6441f5 100644
--- a/svx/source/dialog/framelinkarray.cxx
+++ b/svx/source/dialog/framelinkarray.cxx
@@ -228,6 +228,7 @@ bool Cell::operator==(const Cell& rOther) const
 && mnAddTop == rOther.mnAddTop
 && mnAddBottom == rOther.mnAddBottom
 && meRotMode == rOther.meRotMode
+&& mfOrientation == rOther.mfOrientation
 && mbOverlapX == rOther.mbOverlapX
 && mbOverlapY == rOther.mbOverlapY;
 }
@@ -246,6 +247,7 @@ size_t Cell::hashCode() const
 o3tl::hash_combine(seed, mnAddTop);
 o3tl::hash_combine(seed, mnAddBottom);
 o3tl::hash_combine(seed, meRotMode);
+o3tl::hash_combine(seed, mfOrientation);
 o3tl::hash_combine(seed, mbOverlapX);
 o3tl::hash_combine(seed, mbOverlapY);
 return seed;
@@ -321,7 +323,7 @@ struct ArrayImpl
 sal_Int32   GetIndex( sal_Int32 nCol, sal_Int32 nRow ) const
 { return nRow * mnWidth + nCol; }
 
-const Cell& GetCell( sal_Int32 nCol, sal_Int32 nRow ) const;
+const Cell* GetCell( sal_Int32 nCol, sal_Int32 nRow ) const;
 voidPutCell( sal_Int32 nCol, sal_Int32 nRow, const Cell& );
 
 sal_Int32  GetMergedFirstCol( sal_Int32 nCol, sal_Int32 nRow ) 
const;
@@ -329,8 +331,8 @@ struct ArrayImpl
 sal_Int32  GetMergedLastCol( sal_Int32 nCol, sal_Int32 nRow ) 
const;
 sal_Int32  GetMergedLastRow( sal_Int32 nCol, sal_Int32 nRow ) 
const;
 
-const Cell& GetMergedOriginCell( sal_Int32 nCol, sal_Int32 nRow ) 
const;
-const Cell& GetMergedLastCell( sal_Int32 nCol, sal_Int32 nRow ) 
const;
+const Cell* GetMergedOriginCell( sal_Int32 nCol, sal_Int32 nRow ) 
const;
+const Cell* GetMergedLastCell( sal_Int32 nCol, sal_Int32 nRow ) 
const;
 
 boolIsMergedOverlappedLeft( sal_Int32 nCol, sal_Int32 nRow 
) const;
 boolIsMergedOverlappedRight( sal_Int32 nCol, sal_Int32 
nRow ) const;
@@ -408,9 +410,9 @@ Cell* ArrayImpl::createOrFind(const Cell& rCell)
 return pRetval;
 }
 
-const Cell& ArrayImpl::GetCell( sal_Int32 nCol, sal_Int32 nRow ) const
+const Cell* ArrayImpl::GetCell( sal_Int32 nCol, sal_Int32 nRow ) const
 {
-return IsValidPos( nCol, nRow ) ? *maCells[ GetIndex( nCol, nRow ) ] : 
OBJ_CELL_NONE;
+return IsValidPos( nCol, nRow ) ? maCells[ GetIndex( nCol, nRow ) ] : 
_CELL_NONE;
 }
 
 void ArrayImpl::PutCell( sal_Int32 nCol, sal_Int32 nRow, const Cell & rCell )
@@ -422,61 +424,61 @@ void ArrayImpl::PutCell( sal_Int32 nCol, sal_Int32 nRow, 
const Cell & rCell )
 sal_Int32 ArrayImpl::GetMergedFirstCol( sal_Int32 nCol, sal_Int32 nRow ) const
 {
 sal_Int32 nFirstCol = nCol;
-while( (nFirstCol > 0) && GetCell( nFirstCol, nRow ).mbOverlapX ) 
--nFirstCol;
+while( (nFirstCol > 0) && GetCell( nFirstCol, nRow )->mbOverlapX ) 
--nFirstCol;
 return nFirstCol;
 }
 
 sal_Int32 ArrayImpl::GetMergedFirstRow( sal_Int32 nCol, sal_Int32 nRow ) const
 {
 sal_Int32 nFirstRow = nRow;
-while( (nFirstRow > 0) && GetCell( nCol, nFirstRow ).mbOverlapY ) 
--nFirstRow;
+while( (nFirstRow > 0) && GetCell( nCol, nFirstRow )->mbOverlapY ) 
--nFirstRow;
 return nFirstRow;
 }
 
 sal_Int32 ArrayImpl::GetMergedLastCol( sal_Int32 nCol, sal_Int32 nRow ) const
 {
 sal_Int32 nLastCol = nCol + 1;
-while( (nLastCol < mnWidth) && GetCell( nLastCol, nRow ).mbOverlapX ) 
++nLastCol;
+while( (nLastCol < mnWidth) && GetCell( nLastCol, nRow )->mbOverlapX ) 
++nLastCol;
 return nLastCol - 1;
 }
 
 sal_Int32 ArrayImpl::GetMergedLastRow( sal_Int32 nCol, sal_Int32 nRow ) const
 {
 sal_Int32 nLastRow = nRow + 1;
-while( (nLastRow < mnHeight) && GetCell( nCol, nLastRow ).mbOverlapY ) 
++nLastRow;
+while( (nLastRow < mnHeight) && GetCell( nCol, nLastRow )->mbOverlapY ) 
++nLastRow;
 return nLastRow - 1;
 }
 
-const Cell& ArrayImpl::GetMergedOriginCell( sal_Int32 nCol, sal_Int32 nRow ) 
const
+const Cell* ArrayImpl::GetMergedOriginCell( sal_Int32 nCol, sal_Int32 nRow

[Libreoffice-bugs] [Bug 86899] [META] Requests for the addition of UNO commands

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86899

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||151563


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151563
[Bug 151563] Inconsistent behavior of "New style from selection" in Styles list
and Styles menu
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151563] Inconsistent behavior of "New style from selection" in Styles list and Styles menu

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=151563

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
 Ever confirmed|0   |1
 Blocks||86899
 Status|UNCONFIRMED |NEW

--- Comment #5 from Heiko Tietze  ---
We discussed the topic in the design meeting.

The functions works as expected in the Stylist but not anywhere else. And while
it's not obvious that the command uno:StyleNewByExample is needed as command
making it available in the menu/toolbar/shortcut it requires otherwise the use
of the sidebar.

So we suggest to first rename the command to "New Paragraph Style From
Selection" and then to introduce a new command which does the same for
character style. It's unlikely that other style families are needed.

Code pointer for renaming:
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu

However, it's a generic command available in Calc too, where it creates a new
cell style. We might need to separate it from GenericCommands into sw/sc


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86899
[Bug 86899] [META] Requests for the addition of UNO commands
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 151563] Inconsistent behavior of "New style from selection" in Styles list and Styles menu

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=151563

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
 Ever confirmed|0   |1
 Blocks||86899
 Status|UNCONFIRMED |NEW

--- Comment #5 from Heiko Tietze  ---
We discussed the topic in the design meeting.

The functions works as expected in the Stylist but not anywhere else. And while
it's not obvious that the command uno:StyleNewByExample is needed as command
making it available in the menu/toolbar/shortcut it requires otherwise the use
of the sidebar.

So we suggest to first rename the command to "New Paragraph Style From
Selection" and then to introduce a new command which does the same for
character style. It's unlikely that other style families are needed.

Code pointer for renaming:
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu

However, it's a generic command available in Calc too, where it creates a new
cell style. We might need to separate it from GenericCommands into sw/sc


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86899
[Bug 86899] [META] Requests for the addition of UNO commands
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 158331] Android Viewer: "Save as" creates 0 byte file (with Experimentation Mode turned off)

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158331

Michael Weghorn  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||m.wegh...@posteo.de

--- Comment #2 from Michael Weghorn  ---
I can reproduce on a Fairphone 3.

Version: 7.6.3.2-android
Build ID: 8c4c8a83119e

(In reply to Kira Tubo from comment #0)
> The "Save as" function creates 0 byte file with no data with Experimentation
> Mode turned off. Note: if Experimentation Mode is turned on, this issue does
> not occur. 

Nice finding, thanks! (I remember having seen 0 byte files in the past, but
couldn't reliably reproduce back then, great to know that this happens when
experimental mode is off.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158328] Android Viewer: Keyboard disappears when table cell expands to new line while typing

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158328

Michael Weghorn  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||m.wegh...@posteo.de

--- Comment #2 from Michael Weghorn  ---
I can reproduce on a Fairphone 3.

Version: 7.6.3.2-android
Build ID: 8c4c8a83119e

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158323] CRASH when switch back from HTML View to Normal View after edit in HTML source code

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158323

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3064
 CC||momonas...@gmail.com
  Regression By||Maxim Monastirsky

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Bibisected with linux-64-24.2 repo to first bad build commit
[867559232d567aefa2ba108a880f93431008ef2a] which points to:

commit  d934aeace6e7049db3959421538ae382cb97b1d1
author  Maxim Monastirsky   Thu Jun 15 11:16:18 2023 +0300
committer   Maxim Monastirsky   Fri Jun 16 00:48:44 2023 +0200
tdf#103064 sw,editeng: make para styles work inside comments
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153156

Maxim, can you please have a look?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158327] Android Viewer: Cannot select/reposition/resize inserted line/shape/image

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158327

Michael Weghorn  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||m.wegh...@posteo.de

--- Comment #2 from Michael Weghorn  ---
I can reproduce on a Fairphone 3.

Version: 7.6.3.2-android
Build ID: 8c4c8a83119e

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 158290] "Formattings" should be used instead of "Formats" in some cases

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158290

Heiko Tietze  changed:

   What|Removed |Added

 CC||fit...@ubuntu.com,
   ||jmill...@yahoo.com,
   ||vsfo...@libreoffice.org

--- Comment #2 from Heiko Tietze  ---
Something for the native speakers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 158290] "Formattings" should be used instead of "Formats" in some cases

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158290

Heiko Tietze  changed:

   What|Removed |Added

 CC||fit...@ubuntu.com,
   ||jmill...@yahoo.com,
   ||vsfo...@libreoffice.org

--- Comment #2 from Heiko Tietze  ---
Something for the native speakers.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 80054] Enhancement request: Add option to allow user to select color of non-printing characters

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=80054

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8291

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 158291] The term "Field Shadings" is confusing

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158291

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=80
   ||054

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 158291] The term "Field Shadings" is confusing

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158291

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=80
   ||054

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 158291] The term "Field Shadings" is confusing

2023-11-23 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158291

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=58
   ||434

--- Comment #2 from Heiko Tietze  ---
Some effort has been made to show distinguish fields from non-printable
characters, see bug 58434. Might need further actions. Goal is to distinguish
fields from other special text. However, is a non-breaking space really not a
field? I suggest to discuss this in extra tickets.

Renaming "Field Shading" to "Spotlight Fields" sounds okay to me but I'm afraid
this ends up in calling all those functions "spotlight". Which is a lot of
effort for not much benefit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

< 1 2 3 4 >

201 - 300 of 328 matches

Mail list logo