Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Stephan Bergmann]

On 14/03/18 16:03, Christian Lohmaier wrote:

On Wed, Mar 14, 2018 at 3:29 PM, Stephan Bergmann  wrote:

(And I think David already
nailed the reason down in another mail in this thread.)


To be honest hard to find the info in all that ranting/user
permissions re setting verified statues surely should not have any
effect on notifications for comments/messages that are added using
"gerrit review" command, etc.


Not sure what you mean with ranting, quoting 
:


"But let us do a step back and re-visit this thread: the actual
problem we are trying to solve is a different one: a missing
feedback from Jenkins on failed verifications jobs. [...]

"My proposal to solve that for now and avoid future discussions:

"1. Grant 'Remove Reviewer' ACL to stewards group: [5]. That way many
devs are able to drop the wrong vote, and someone is always on the IRC.

"2. Re-configure Jenkins Trigger Plugin set-up and enable voting of
Verified-1 on failed jobs."

To me at least, the proposal sounds like an effective way to address the 
problem, and I would be happy if somebody from the infra team could look 
into that.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Christian Lohmaier]

On Wed, Mar 14, 2018 at 3:29 PM, Stephan Bergmann  wrote:
> On 14/03/18 14:38, Christian Lohmaier wrote:
>>
>> Then it is worse - your mailserver then silently deletes mail. Here's
>> one that was sent to both you and me and that still was in my
>> inbox...:
>
>
> Why do you assume that I did not get that mail?

Because I certainly do get mails for changes where I'm not the owner.
Because the other mails for jenkins comments I get always have other
recipients in CC
Because you (and Eike) are the only ones so far who said they wouldn't
receive mails for jenkins' comments.

> (And I think David already
> nailed the reason down in another mail in this thread.)

To be honest hard to find the info in all that ranting/user
permissions re setting verified statues surely should not have any
effect on notifications for comments/messages that are added using
"gerrit review" command, etc.

But whatever...

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Stephan Bergmann]

On 14/03/18 14:38, Christian Lohmaier wrote:

Then it is worse - your mailserver then silently deletes mail. Here's
one that was sent to both you and me and that still was in my
inbox...:


Why do you assume that I did not get that mail?  It was apparently a 
mail triggered by a Jenkins comment made to 
, which is owned by me.  I do 
get such mails alright, just not mails about Jenkins comments made to 
changes owned by others, on which I'm merely a reviewer.  (And I think 
David already nailed the reason down in another mail in this thread.)



###
Delivered-To: lohmaier+libreoff...@gmail.com
Received: by 10.25.167.141 with SMTP id q135csp5071333lfe;
 Tue, 27 Feb 2018 07:51:51 -0800 (PST)
X-Google-Smtp-Source:
AH8x224NAjuc6BmaBhi31NrkA4faf5cGS1kx9+zztpGGG1Md1ihiSh3e480lcZbM00Wufld+EIl4
X-Received: by 10.223.168.46 with SMTP id l43mr14044383wrc.118.1519746711808;
 Tue, 27 Feb 2018 07:51:51 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1519746711; cv=none;
 d=google.com; s=arc-20160816;
 b=iHeBvUq+oS2NTKYTDBNRhn1NkFYOEcYbfrJg3wjuqSpQpfRQNWmrb/iqADc+JLTV1R
  ab1OLPz/FZ7Ir1N0qj2VQsPxr4ye85G0Ortl8gUkUXZ7dSnEEyxYbH9U+6vPbyK5uwU0
  d/34nqsZMw3BooIyN3IFIGR6lbutjOOIY/4EMtUGLKV+mjPRa0uEXqTtS3hGXwzZsBcE
  ckpaARC0TYSaXRjw2sFLotABr31I0PByh4N7srW7r3DVotpxmq4OIlwoAOv2b/xie3g1
  AUMU8Y9fqSzjnxx1pN7hDO47P5ZJp6OY6jYG1KGgysqMkw19EZZMne6qEK24brCEMTFs
  ERAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
d=google.com; s=arc-20160816;
 h=content-transfer-encoding:message-id:user-agent:content-disposition
  :mime-version:references:in-reply-to:subject:list-unsubscribe
  :list-id:reply-to:to:from:date:dkim-signature
  :arc-authentication-results;
 bh=WlV0gXF8MWSj4XxSn23QafvqX6681ivj9Qv6OfVilAU=;
 b=PiftyQjcTCQCVQ2Qz+eQO3QyzlTM94c2dQm6uc/I+H1nxbtLsQ2WI3OXw8M8mW8+H6
  CEBYaJL98i/EZnpTtKNajnOvvb/97ceUWgmsUP9o90KdkpozJajoP/SrDsUBAXG94nsV
  +gEvyq9zIdew2SwRsjCXO0i/ShA1YLizGobHf+V3lofLUoKTX9r7orcACa3IBPPTpPQ7
  EYyNfxwolZtmMLkRGKmFthoF1K9bt4sqpCzq1DjLwsMus6bBNlQY/sPhqkTOz285tf+m
  8AxaIIO7XFl6XyEPcyvx7bvYaMDCO/9U5QKeqO/eh7qJKDDhaZCQdksokWHMiW8+EDXl
  orTg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@libreoffice.org
header.s=091c684752c0c86472e3d9b91cc91375 header.b=FwRBbuym;
spf=pass (google.com: domain of ger...@gerrit.libreoffice.org
designates 2a00:1828:a012:202::1 as permitted sender)
smtp.mailfrom=ger...@gerrit.libreoffice.org
Return-Path: 
Received: from vm202.documentfoundation.org
(vm202.documentfoundation.org. [2a00:1828:a012:202::1])
 by mx.google.com with ESMTPS id f9si5237290wrf.83.2018.02.27.07.51.51
 for 
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 27 Feb 2018 07:51:51 -0800 (PST)
Received-SPF: pass (google.com: domain of
ger...@gerrit.libreoffice.org designates 2a00:1828:a012:202::1 as
permitted sender) client-ip=2a00:1828:a012:202::1;
Authentication-Results: mx.google.com;
dkim=pass header.i=@libreoffice.org
header.s=091c684752c0c86472e3d9b91cc91375 header.b=FwRBbuym;
spf=pass (google.com: domain of ger...@gerrit.libreoffice.org
designates 2a00:1828:a012:202::1 as permitted sender)
smtp.mailfrom=ger...@gerrit.libreoffice.org
Received: from localhost (vm202.documentfoundation.org [127.0.0.1]) by
vm202.documentfoundation.org (Postfix) with ESMTP id 5F82040791; Tue,
27 Feb 2018 15:51:51 + (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libreoffice.org;
h=content-transfer-encoding:message-id:user-agent
:content-disposition:content-type:content-type:mime-version
:references:in-reply-to:subject:subject:list-unsubscribe:list-id
:reply-to:from:from:date:date:received:received:received; s=
091c684752c0c86472e3d9b91cc91375; i=@gerrit.libreoffice.org; t=
1519746709; x=1521561110; bh=WlV0gXF8MWSj4XxSn23QafvqX6681ivj9Qv
6OfVilAU=; b=FwRBbuymUOZXLXwiMmGc7JiCebatBBUboN9J/YtCuIOLm+OU4ji
k/etNXzdcYXBx8WONaJeILKrrsh7X3cKybNqKh2UJMdnBdD/ocjHR24eV8E3wOe0
GGhrN2/uPSmDbRA7O2jJr8aLN2zsZ1bdhm4xHeEnUUe4E62aMjbIpfgUpd3AHkO5
bTVhKTd6RI/XchYmK6ZR8zlbBknacpa/uF0qqQxzdWJ88nG31//6eHXWB48LC074
uQthtoBoWbAaBIeKbR6/9e5qPm4Bms9YyJDlA9HcnDuJw21YoCFjYHG91HQ1Bcu5
hUZXCrZRhQLfW3HhfVPN55ryFc0QL+cPuZw==
X-Virus-Scanned: amavisd-new at vm202.documentfoundation.org
Received: from vm202.documentfoundation.org ([127.0.0.1]) by localhost
(vm202.documentfoundation.org [127.0.0.1]) (amavisd-new, port 10026)
with LMTP id DTYcu3JnVCDc; Tue, 27 Feb 2018 15:51:49 + (UTC)
Received: from gerrit.libreoffice.org (vm148.documentfoundation.org
[IPv6:2a00:1828:a012:148::1]) (using TLSv1.2 with cipher
ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN
"gerrit.libreoffice.org", Issuer "gerrit.libreoffice.org" (not
verified)) by vm202.documentfoundation.org 

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Christian Lohmaier]

Hi Stephan, *,

On Fri, Mar 9, 2018 at 3:38 PM, Stephan Bergmann  wrote:
> On 06.03.2018 10:09, Stephan Bergmann wrote:
>>
>> There's no such mails blocked in my spam folder.

Then it is worse - your mailserver then silently deletes mail. Here's
one that was sent to both you and me and that still was in my
inbox...:
###
Delivered-To: lohmaier+libreoff...@gmail.com
Received: by 10.25.167.141 with SMTP id q135csp5071333lfe;
Tue, 27 Feb 2018 07:51:51 -0800 (PST)
X-Google-Smtp-Source:
AH8x224NAjuc6BmaBhi31NrkA4faf5cGS1kx9+zztpGGG1Md1ihiSh3e480lcZbM00Wufld+EIl4
X-Received: by 10.223.168.46 with SMTP id l43mr14044383wrc.118.1519746711808;
Tue, 27 Feb 2018 07:51:51 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1519746711; cv=none;
d=google.com; s=arc-20160816;
b=iHeBvUq+oS2NTKYTDBNRhn1NkFYOEcYbfrJg3wjuqSpQpfRQNWmrb/iqADc+JLTV1R
 ab1OLPz/FZ7Ir1N0qj2VQsPxr4ye85G0Ortl8gUkUXZ7dSnEEyxYbH9U+6vPbyK5uwU0
 d/34nqsZMw3BooIyN3IFIGR6lbutjOOIY/4EMtUGLKV+mjPRa0uEXqTtS3hGXwzZsBcE
 ckpaARC0TYSaXRjw2sFLotABr31I0PByh4N7srW7r3DVotpxmq4OIlwoAOv2b/xie3g1
 AUMU8Y9fqSzjnxx1pN7hDO47P5ZJp6OY6jYG1KGgysqMkw19EZZMne6qEK24brCEMTFs
 ERAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
d=google.com; s=arc-20160816;
h=content-transfer-encoding:message-id:user-agent:content-disposition
 :mime-version:references:in-reply-to:subject:list-unsubscribe
 :list-id:reply-to:to:from:date:dkim-signature
 :arc-authentication-results;
bh=WlV0gXF8MWSj4XxSn23QafvqX6681ivj9Qv6OfVilAU=;
b=PiftyQjcTCQCVQ2Qz+eQO3QyzlTM94c2dQm6uc/I+H1nxbtLsQ2WI3OXw8M8mW8+H6
 CEBYaJL98i/EZnpTtKNajnOvvb/97ceUWgmsUP9o90KdkpozJajoP/SrDsUBAXG94nsV
 +gEvyq9zIdew2SwRsjCXO0i/ShA1YLizGobHf+V3lofLUoKTX9r7orcACa3IBPPTpPQ7
 EYyNfxwolZtmMLkRGKmFthoF1K9bt4sqpCzq1DjLwsMus6bBNlQY/sPhqkTOz285tf+m
 8AxaIIO7XFl6XyEPcyvx7bvYaMDCO/9U5QKeqO/eh7qJKDDhaZCQdksokWHMiW8+EDXl
 orTg==
ARC-Authentication-Results: i=1; mx.google.com;
   dkim=pass header.i=@libreoffice.org
header.s=091c684752c0c86472e3d9b91cc91375 header.b=FwRBbuym;
   spf=pass (google.com: domain of ger...@gerrit.libreoffice.org
designates 2a00:1828:a012:202::1 as permitted sender)
smtp.mailfrom=ger...@gerrit.libreoffice.org
Return-Path: 
Received: from vm202.documentfoundation.org
(vm202.documentfoundation.org. [2a00:1828:a012:202::1])
by mx.google.com with ESMTPS id f9si5237290wrf.83.2018.02.27.07.51.51
for 
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 27 Feb 2018 07:51:51 -0800 (PST)
Received-SPF: pass (google.com: domain of
ger...@gerrit.libreoffice.org designates 2a00:1828:a012:202::1 as
permitted sender) client-ip=2a00:1828:a012:202::1;
Authentication-Results: mx.google.com;
   dkim=pass header.i=@libreoffice.org
header.s=091c684752c0c86472e3d9b91cc91375 header.b=FwRBbuym;
   spf=pass (google.com: domain of ger...@gerrit.libreoffice.org
designates 2a00:1828:a012:202::1 as permitted sender)
smtp.mailfrom=ger...@gerrit.libreoffice.org
Received: from localhost (vm202.documentfoundation.org [127.0.0.1]) by
vm202.documentfoundation.org (Postfix) with ESMTP id 5F82040791; Tue,
27 Feb 2018 15:51:51 + (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libreoffice.org;
h=content-transfer-encoding:message-id:user-agent
:content-disposition:content-type:content-type:mime-version
:references:in-reply-to:subject:subject:list-unsubscribe:list-id
:reply-to:from:from:date:date:received:received:received; s=
091c684752c0c86472e3d9b91cc91375; i=@gerrit.libreoffice.org; t=
1519746709; x=1521561110; bh=WlV0gXF8MWSj4XxSn23QafvqX6681ivj9Qv
6OfVilAU=; b=FwRBbuymUOZXLXwiMmGc7JiCebatBBUboN9J/YtCuIOLm+OU4ji
k/etNXzdcYXBx8WONaJeILKrrsh7X3cKybNqKh2UJMdnBdD/ocjHR24eV8E3wOe0
GGhrN2/uPSmDbRA7O2jJr8aLN2zsZ1bdhm4xHeEnUUe4E62aMjbIpfgUpd3AHkO5
bTVhKTd6RI/XchYmK6ZR8zlbBknacpa/uF0qqQxzdWJ88nG31//6eHXWB48LC074
uQthtoBoWbAaBIeKbR6/9e5qPm4Bms9YyJDlA9HcnDuJw21YoCFjYHG91HQ1Bcu5
hUZXCrZRhQLfW3HhfVPN55ryFc0QL+cPuZw==
X-Virus-Scanned: amavisd-new at vm202.documentfoundation.org
Received: from vm202.documentfoundation.org ([127.0.0.1]) by localhost
(vm202.documentfoundation.org [127.0.0.1]) (amavisd-new, port 10026)
with LMTP id DTYcu3JnVCDc; Tue, 27 Feb 2018 15:51:49 + (UTC)
Received: from gerrit.libreoffice.org (vm148.documentfoundation.org
[IPv6:2a00:1828:a012:148::1]) (using TLSv1.2 with cipher
ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN
"gerrit.libreoffice.org", Issuer "gerrit.libreoffice.org" (not
verified)) by vm202.documentfoundation.org (Postfix) with ESMTPS id
3A7BB3FF53; Tue, 27 Feb 2018 15:51:49 + (UTC)
Received: from gerrit.libreoffice.org (gerrit.libreoffice.org
[127.0.0.1]) by gerrit.libreoffice.org (Postfix) with ESMTP id
EFC95E005A; Tue, 27 Feb 2018 16:51:48 +0100 (CET)
Date: Tue, 27 Feb 2018 16:51:47 

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Stephan Bergmann]

On 11/03/18 09:59, David Ostrovsky wrote:

On Fri Mar 9 19:14:33 UTC 2018, Eike Rathke wrote:

On Tuesday, 2018-03-06 10:09:22 +0100, Stephan Bergmann wrote:
for a Gerrit change on which I'm listed as reviewer, I do get mails

for mine

and all other people's comments, just not for comments from Jenkins.


Same here. I also don't get Jenkins comments mails for changes in

areas

that touch my Watched Projects list (under Settings), even though
I ticked All Comments for each entry there as well.


You and Stephan tell us, that you do want to be notified from
Jenkins and get all that spam (on start job and finish job, and re-
scheduled verification on rebases, and fixed patch sets in case first
17 verifications failed). Other developers told us the wuite the
opposite: shutdown the notification firehose and stop spam reviewers.


What I originally asked for is indeed something quite different (see 
below).  I understand that Christian offered this "spamming from 
Jenkins" as a mitigation for the problems I reported (lack of feedback 
on failed Jenkins/Gerrit builds), and I answered that that mitigation 
does not work.



But let us do a step back and re-visit this thread: the actual
problem we are trying to solve is a different one: a missing
feedback from Jenkins on failed verifications jobs. Let me repeat
this again: the LibreOffice Gerrit-Jenkins setup deviates from
the standard recommended setup, by preventing voting Verified-1 on
failed builds.

That was an oversight, as confirmed by infra team, and in case of
false negative, Verified-1 vote can be easily removed by anyone, who
was granted the Remove Revievers ACL. In recent gerrit versions, I
even added "Delete Vote" feature, that let you preserve the reviewer
on a change, and only remove the vote. I would like to re-new my
call and ask infra team (again) to enable voting Verified-1 on failed
verifications.

My proposal to solve that for now and avoid future discussions:

1. Grant "Remove Reviewer" ACL to stewards group: [5]. That way many
devs are able to drop the wrong vote, and someone is always on the IRC.
2. Re-configure Jenkins Trigger Plugin set-up and enable voting of
Verified-1 on failed jobs.


Sounds good to me.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Let failed Jenkins builds set Verified: -1 in Gerrit?

[David Ostrovsky]

On Fri Mar 9 19:14:33 UTC 2018, Eike Rathke wrote:

>> On Tuesday, 2018-03-06 10:09:22 +0100, Stephan Bergmann wrote:
>> for a Gerrit change on which I'm listed as reviewer, I do get mails
for mine
>> and all other people's comments, just not for comments from Jenkins.
>
>Same here. I also don't get Jenkins comments mails for changes in
areas
>that touch my Watched Projects list (under Settings), even though
>I ticked All Comments for each entry there as well.

You and Stephan tell us, that you do want to be notified from
Jenkins and get all that spam (on start job and finish job, and re-
scheduled verification on rebases, and fixed patch sets in case first
17 verifications failed). Other developers told us the wuite the
opposite: shutdown the notification firehose and stop spam reviewers.

Gerrit has a mean for that: ACL "Email Reviewers" that can be denied:
[1] that id documented on Gerrit ACL page: [2] and to be easy to find
is even documented on the Jenkins Gerrit Trigger plugin: [3].

The bottom line of the discussion was: we shutdown the firehose and
disallow Jenkins to spam reviewers. On this screenshot, from All-
Project ACL page in gerrit, you can see how/where this DENY rule is
implemented: [4].

Of course, we could easily remove that DENY rule (again), but
I'm sure, that this would just restart the bikeshedding on that topic
that would probably end up (again) in disabling the firehose.

But let us do a step back and re-visit this thread: the actual
problem we are trying to solve is a different one: a missing
feedback from Jenkins on failed verifications jobs. Let me repeat
this again: the LibreOffice Gerrit-Jenkins setup deviates from
the standard recommended setup, by preventing voting Verified-1 on
failed builds.

That was an oversight, as confirmed by infra team, and in case of
false negative, Verified-1 vote can be easily removed by anyone, who
was granted the Remove Revievers ACL. In recent gerrit versions, I
even added "Delete Vote" feature, that let you preserve the reviewer
on a change, and only remove the vote. I would like to re-new my
call and ask infra team (again) to enable voting Verified-1 on failed
verifications.

My proposal to solve that for now and avoid future discussions:

1. Grant "Remove Reviewer" ACL to stewards group: [5]. That way many
devs are able to drop the wrong vote, and someone is always on the IRC.
2. Re-configure Jenkins Trigger Plugin set-up and enable voting of
Verified-1 on failed jobs.

[1] https://github.com/GerritCodeReview/gerrit/commit/d9488f0c37084f3e8
b6426ad9fd7722bea776ae2
[2] https://gerrit-review.googlesource.com/Documentation/access-control
.html#capability_emailReviewers
[3] https://wiki.jenkins.io/display/JENKINS/Gerrit+Trigger#GerritTrigge
r-Reducenumberofnotificationemails
[4] https://imgur.com/a/Lz3XM
[5] https://gerrit-review.googlesource.com/Documentation/access-control
.html#category_remove_reviewer

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Eike Rathke]

Hi,

On Tuesday, 2018-03-06 10:09:22 +0100, Stephan Bergmann wrote:

> On 05.03.2018 21:41, Christian Lohmaier wrote:
> > On Wed, Feb 28, 2018 at 9:24 AM, Stephan Bergmann  
> > wrote:
> > > On 23.02.2018 18:57, Christian Lohmaier wrote:
> > > > Done - now jenkins' message should be sent to ALL (owner, reviewer and
> > > > "interested" users (those who starred the change or watch another user
> > > > on the changeset)
> > > Doesn't seem to work.
> > I certainly do get the jenkins build-status comments sent as email
> > notifications..
> 
> for a Gerrit change on which I'm listed as reviewer, I do get mails for mine
> and all other people's comments, just not for comments from Jenkins.

Same here. I also don't get Jenkins comments mails for changes in areas
that touch my Watched Projects list (under Settings), even though
I ticked All Comments for each entry there as well.

I seem to get Jenkins comments mails only for changes I submitted.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Stephan Bergmann]

On 06.03.2018 10:09, Stephan Bergmann wrote:

On 05.03.2018 21:41, Christian Lohmaier wrote:
On Wed, Feb 28, 2018 at 9:24 AM, Stephan Bergmann 
 wrote:

On 23.02.2018 18:57, Christian Lohmaier wrote:


Done - now jenkins' message should be sent to ALL (owner, reviewer and
"interested" users (those who starred the change or watch another user
on the changeset)



Doesn't seem to work.


I certainly do get the jenkins build-status comments sent as email
notifications..

I assume you already did the usual look-in-spamfolder dance? Also I
assume you do receive the rest of the gerrit-comments, just not the
ones from jenkins?


There's no such mails blocked in my spam folder.  And I'm pretty sure 
that, for a Gerrit change on which I'm listed as reviewer, I do get 
mails for mine and all other people's comments, just not for comments 
from Jenkins.  But I don't have a fresh example handy right now where 
that happened; I'll keep an eye out when this happens again.


Still doesn't seem to work.  For 
's four comments today (Mar 
9) so far,



Andras Timar
Uploaded patch set 4.
15:02



Jenkins
Patch Set 4: Build queued https://ci.libreoffice.org/job/gerrit_master/541/
15:03



Andras Timar
Patch Set 2: (2 comments)
15:04



Jenkins
Patch Set 4: Build Failed https://ci.libreoffice.org/job/gerrit_master/541/ : 
FAILURE
15:16


I got mails for the two by Andras, but not for the two by Jenkins.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Stephan Bergmann]

On 05.03.2018 21:41, Christian Lohmaier wrote:

On Wed, Feb 28, 2018 at 9:24 AM, Stephan Bergmann  wrote:

On 23.02.2018 18:57, Christian Lohmaier wrote:


Done - now jenkins' message should be sent to ALL (owner, reviewer and
"interested" users (those who starred the change or watch another user
on the changeset)



Doesn't seem to work.


I certainly do get the jenkins build-status comments sent as email
notifications..

I assume you already did the usual look-in-spamfolder dance? Also I
assume you do receive the rest of the gerrit-comments, just not the
ones from jenkins?


There's no such mails blocked in my spam folder.  And I'm pretty sure 
that, for a Gerrit change on which I'm listed as reviewer, I do get 
mails for mine and all other people's comments, just not for comments 
from Jenkins.  But I don't have a fresh example handy right now where 
that happened; I'll keep an eye out when this happens again.


(At  I didn't find any 
mail-related settings other than "CC Me On Comments I Write" on the 
Preferences page, which is ticked for me.)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Christian Lohmaier]

Hi Stephan,

On Wed, Feb 28, 2018 at 9:24 AM, Stephan Bergmann  wrote:
> On 23.02.2018 18:57, Christian Lohmaier wrote:
>>
>> Done - now jenkins' message should be sent to ALL (owner, reviewer and
>> "interested" users (those who starred the change or watch another user
>> on the changeset)
>
>
> Doesn't seem to work.

I certainly do get the jenkins build-status comments sent as email
notifications..

I assume you already did the usual look-in-spamfolder dance? Also I
assume you do receive the rest of the gerrit-comments, just not the
ones from jenkins?

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Stephan Bergmann]

On 23.02.2018 18:57, Christian Lohmaier wrote:

Done - now jenkins' message should be sent to ALL (owner, reviewer and
"interested" users (those who starred the change or watch another user
on the changeset)


Doesn't seem to work.  For example, I didn't get any mails for any of 
yesterday's/today's Jenkins FAILURE/ABORTED comments to 
, even though I'm listed as 
reviewer there.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Christian Lohmaier]

Hi *,

On Fri, Feb 23, 2018 at 4:22 PM, Miklos Vajna  wrote:
> Hi,
>
> On Fri, Feb 23, 2018 at 04:08:24PM +0100, Stephan Bergmann 
>  wrote:
>> > I think this was a decision from Norbert, probably because he was worried
>> > about false negatives. A workaround is to watch your inbox (which gets a
>> > mail, whatever is the outcome), rather than the above URL.
>>
>> Except, you never get a mail about Jenkins success/failure if it wasn't you
>> who sent the patch set to Gerrit.
>
> Cloph, do you have a view on this?

Done - now jenkins' message should be sent to ALL (owner, reviewer and
"interested" users (those who starred the change or watch another user
on the changeset)

> Could we have Jenkins set Verified-1
> on the change if the build fails to have a clear separation between "not
> yet verified" and "verified but failed" states, immediately visible from
> the dashboard?

That is not a technical question, but more one of do we want to have
it, given that builds can fail because of various other reasons...

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Stephan Bergmann]

On 23.02.2018 16:22, Miklos Vajna wrote:

Cloph, do you have a view on this? Could we have Jenkins set Verified-1
on the change if the build fails to have a clear separation between "not
yet verified" and "verified but failed" states, immediately visible from
the dashboard?


Note that there was follow-on discussion back then, but unfortunately 
detached from the original mail thread due to missing In-Reply-To 
headers on two of David's replies, 
<https://lists.freedesktop.org/archives/libreoffice/2017-November/078991.html> 
"Let failed Jenkins builds set Verified: -1 in Gerrit?" and 
<https://lists.freedesktop.org/archives/libreoffice/2017-December/078997.html> 
"Let failed Jenkins builds set Verified: -1 in Gerrit?".

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Kaganski Mike]

On 2/23/2018 6:22 PM, Miklos Vajna wrote:
> Hi,
> 
> On Fri, Feb 23, 2018 at 04:08:24PM +0100, Stephan Bergmann 
>  wrote:
>>> I think this was a decision from Norbert, probably because he was worried
>>> about false negatives. A workaround is to watch your inbox (which gets a
>>> mail, whatever is the outcome), rather than the above URL.
>>
>> Except, you never get a mail about Jenkins success/failure if it wasn't you
>> who sent the patch set to Gerrit.
> 
> Cloph, do you have a view on this? Could we have Jenkins set Verified-1
> on the change if the build fails to have a clear separation between "not
> yet verified" and "verified but failed" states, immediately visible from
> the dashboard?

IIRC, that was about "minimal possible negative mark is only possible to 
be removed by one who had set it" thing...

-- 
Best regards,
Mike Kaganski
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Miklos Vajna]

Hi,

On Fri, Feb 23, 2018 at 04:08:24PM +0100, Stephan Bergmann 
 wrote:
> > I think this was a decision from Norbert, probably because he was worried
> > about false negatives. A workaround is to watch your inbox (which gets a
> > mail, whatever is the outcome), rather than the above URL.
> 
> Except, you never get a mail about Jenkins success/failure if it wasn't you
> who sent the patch set to Gerrit.

Cloph, do you have a view on this? Could we have Jenkins set Verified-1
on the change if the build fails to have a clear separation between "not
yet verified" and "verified but failed" states, immediately visible from
the dashboard?

Thanks,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Stephan Bergmann]

On 30.11.2017 09:00, Miklos Vajna wrote:

On Wed, Nov 29, 2017 at 12:16:24PM +0100, Stephan Bergmann 
 wrote:

Is there any good reason why a failed Gerrit/Jenkins build does not set the
corresponding Gerrit change's Verified flag to -1 (similar to how a
successful such build sets the flag to +1)?

Especially with the poor Jenkins turnaround times, it is hard to tell on a
page like  whether a change
is not yet ready for submission because Jenkins has not yet built it or
because the Jenkins build failed.  The "V" ("Verified") column is empty in
both cases.  (And I assume it would contain something like a red cross if
the Verified flag is -1.)


I think this was a decision from Norbert, probably because he was worried
about false negatives. A workaround is to watch your inbox (which gets a
mail, whatever is the outcome), rather than the above URL.


Except, you never get a mail about Jenkins success/failure if it wasn't 
you who sent the patch set to Gerrit.


I just happened to run into this scenario:  Reviewed a Gerrit change 
from somebody else without commit rights.  The Jenkins build had not yet 
finished when I reviewed the change.  But the change looked good to me, 
and I was pretty sure it wouldn't cause build problems, so I set it to 
Code-Review +2.  I wanted to wait for Jenkins' Verified +1 (to be on the 
save side after all) before submitting it.  And I couldn't rely on the 
original author eventually submitting it once Jenkins gave it a Verified 
+1, as the author didn't have commit rights.  So I felt obliged to see 
that change through until it was submitted.  But how would I learn that 
the Jenkins build had failed after all?  Only by polling on the change's 
specific URL, not by polling merely my dashboard page.  Oh my.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Stephan Bergmann]

On 12/07/2017 09:07 PM, Michael Stahl wrote:

mainly the benefit would be that you could see on the search page which
changes have finished build logs that need investigating, those would be
the "verified: -1" ones.


Exactly.  That's what I stated as motivation in this thread's original post.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Michael Stahl]

On 01.12.2017 18:27, Norbert Thiebaud wrote:
> On Fri, Dec 1, 2017 at 1:32 AM, David Ostrovsky  wrote:
>> On Thu Nov 30 08:25:40 UTC 2017, Stephan Bergmann wrote:
>>
>>> Does "(with a help of maintainers)" imply that there are change
>>> owners who could not override a VRFY-1 from Jenkins themselves?
>>
>> Yes. I believe that "registered users" group members will not be
>> able to remove VRFY-1 vote.
> 
> I do not know of anyway, anyone can remove it using the ui, short of
> impersonating jenkins' user.
> 
> the only available way to remove the -1 is to rebase the patch, since
> hte -1 is bound to the particular patcheset version...
> then hope that jenkins will not put another -1, or at least quickly
> +2/+1 the rebased patch and submit... neither are desirable.
> 
> hence the choice of +1/0 rather than +1/-1 for jenkins.

so if the problem is that a -1 vote would block "submit" until it is
removed, and it can (because we don't want to give "admin" privs to
everyone) only be removed by the user that added the -1 vote, we could
add a "verified: -2" as a possible value that is never automatically
set, but only manually by somebody reviewing the build logs.

only the -2 would block "submit", the -1 could be overruled because it's
not the lowest value.

> For all practical purpose: 0 means jenkins has not yet try or was not
> successful.
> to submit one would have to manually add a verify +1. to do that you
> need to go the the change view, and jenkins activity or lack thereof
> is pretty apparent there.
> 
> I suspect the intent is to quicky avoid changeset that failed
> jenkins... but then whether the change set has failed or has not yet
> been built, what is the difference wrt to avoiding going in the
> details of the change ?
> from a review perspective no verification or failed verification means
> the same thing: not ready

on the other hand i agree with Norbert that there isn't all that much
benefit to be gained over the status quo.

mainly the benefit would be that you could see on the search page which
changes have finished build logs that need investigating, those would be
the "verified: -1" ones.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Eike Rathke]

Hi,

On Friday, 2017-12-01 11:27:02 -0600, Norbert Thiebaud wrote:

> On Fri, Dec 1, 2017 at 1:32 AM, David Ostrovsky  wrote:
> > On Thu Nov 30 08:25:40 UTC 2017, Stephan Bergmann wrote:
> >>Does "(with a help of maintainers)" imply that there are change
> >>owners who could not override a VRFY-1 from Jenkins themselves?
> >
> > Yes. I believe that "registered users" group members will not be
> > able to remove VRFY-1 vote.
> 
> I do not know of anyway, anyone can remove it using the ui, short of
> impersonating jenkins' user.
> 
> the only available way to remove the -1 is to rebase the patch, since
> hte -1 is bound to the particular patcheset version...
> then hope that jenkins will not put another -1, or at least quickly
> +2/+1 the rebased patch and submit... neither are desirable.
> 
> hence the choice of +1/0 rather than +1/-1 for jenkins.

Wouldn't it be possible to have the Verify field be a set of -2/-1/0/+1,
with -2 being the sticky denial value, and let Jenkins set only -1 or +1?

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Norbert Thiebaud]

On Tue, Dec 5, 2017 at 1:16 AM, David Ostrovsky  wrote:
>
> RTFM: [1]? Quoting:
>
> "
> *Remove Reviewer*
>
> This category permits users to remove other users from the list of
> reviewers on a change.
> [...]
> Project owners and site administrators can always remove any reviewer
> (even without having the Remove Reviewer access right assigned).
>
> Users without this access right can only remove themselves from the
> reviewer list on a change.
> "
>
> Also note, that the ancient/legacy Gerrit version @LibreOffice
> has a major design bug/missing feature: [2] there is now way to
> remove a vote. Only the whole reviewer, with all votes can
> be wiped out.

I'm sorry but it is completely un-obvious that removing a 'reviewer'
from the list would wipe out the history of that reviewer.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[David Ostrovsky]

On Fri, 2017-12-01 at 11:27 -0600, Norbert Thiebaud wrote:
> On Fri, Dec 1, 2017 at 1:32 AM, David Ostrovsky 
> wrote:
> > On Thu Nov 30 08:25:40 UTC 2017, Stephan Bergmann wrote:
> > 
> > > Does "(with a help of maintainers)" imply that there are change
> > > owners who could not override a VRFY-1 from Jenkins themselves?
> > 
> > Yes. I believe that "registered users" group members will not be
> > able to remove VRFY-1 vote.
> 
> I do not know of anyway, anyone can remove it using the ui, short of
> impersonating jenkins' user.

RTFM: [1]? Quoting:

"
*Remove Reviewer*

This category permits users to remove other users from the list of
reviewers on a change.
[...]
Project owners and site administrators can always remove any reviewer
(even without having the Remove Reviewer access right assigned).

Users without this access right can only remove themselves from the
reviewer list on a change.
"

Also note, that the ancient/legacy Gerrit version @LibreOffice
has a major design bug/missing feature: [2] there is now way to
remove a vote. Only the whole reviewer, with all votes can
be wiped out. I fixed this years ago: [3]. But unfortunately,
LibreOffice's infra team is unable to allocate resources to
upgrade gerrit. We are almost 4 major releases behind.
(Wikimedia: [3] and OpenStack: [4] projects upgraded to
2.13.9 years ago without any issue).

[1] https://gerrit.libreoffice.org/Documentation/access-control.html#ca
tegory_remove_reviewer
[2] https://bugs.chromium.org/p/gerrit/issues/detail?id=3035
[2] https://gerrit-review.googlesource.com/#/c/gerrit/+/62410/
[3] https://gerrit.wikimedia.org
[4] https://review.openstack.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Norbert Thiebaud]

On Fri, Dec 1, 2017 at 1:32 AM, David Ostrovsky  wrote:
> On Thu Nov 30 08:25:40 UTC 2017, Stephan Bergmann wrote:
>
>>Does "(with a help of maintainers)" imply that there are change
>>owners who could not override a VRFY-1 from Jenkins themselves?
>
> Yes. I believe that "registered users" group members will not be
> able to remove VRFY-1 vote.

I do not know of anyway, anyone can remove it using the ui, short of
impersonating jenkins' user.

the only available way to remove the -1 is to rebase the patch, since
hte -1 is bound to the particular patcheset version...
then hope that jenkins will not put another -1, or at least quickly
+2/+1 the rebased patch and submit... neither are desirable.

hence the choice of +1/0 rather than +1/-1 for jenkins.

For all practical purpose: 0 means jenkins has not yet try or was not
successful.
to submit one would have to manually add a verify +1. to do that you
need to go the the change view, and jenkins activity or lack thereof
is pretty apparent there.

I suspect the intent is to quicky avoid changeset that failed
jenkins... but then whether the change set has failed or has not yet
been built, what is the difference wrt to avoiding going in the
details of the change ?
from a review perspective no verification or failed verification means
the same thing: not ready
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Norbert Thiebaud]

On Thu, Nov 30, 2017 at 2:00 AM, Miklos Vajna  wrote:
>
> I think this was a decision from Norbert, probably because he was worried
> about false negatives. A workaround is to watch your inbox (which gets a
> mail, whatever is the outcome), rather than the above URL.
>
> (I would have no problem if Jenkins would put a Verified-1, though.)

Indeed False positive is a problem, especially since verify is a -1/+1 range
and
"By default, a change is submittable when it gets at least one highest
vote in each voting category and has no lowest vote (aka veto vote) in
any category."

so if jenkins did put a -1 that would be blocking until _jenkins_
reverse its vote.

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Let failed Jenkins builds set Verified: -1 in Gerrit?

[David Ostrovsky]

On Thu Nov 30 08:25:40 UTC 2017, Stephan Bergmann wrote:

>Does "(with a help of maintainers)" imply that there are change
>owners who could not override a VRFY-1 from Jenkins themselves?

Yes. I believe that "registered users" group members will not be
able to remove VRFY-1 vote.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Let failed Jenkins builds set Verified: -1 in Gerrit?

[Miklos Vajna]

Hi Stephan,

On Wed, Nov 29, 2017 at 12:16:24PM +0100, Stephan Bergmann 
 wrote:
> Is there any good reason why a failed Gerrit/Jenkins build does not set the
> corresponding Gerrit change's Verified flag to -1 (similar to how a
> successful such build sets the flag to +1)?
> 
> Especially with the poor Jenkins turnaround times, it is hard to tell on a
> page like  whether a change
> is not yet ready for submission because Jenkins has not yet built it or
> because the Jenkins build failed.  The "V" ("Verified") column is empty in
> both cases.  (And I assume it would contain something like a red cross if
> the Verified flag is -1.)

I think this was a decision from Norbert, probably because he was worried
about false negatives. A workaround is to watch your inbox (which gets a
mail, whatever is the outcome), rather than the above URL.

(I would have no problem if Jenkins would put a Verified-1, though.)

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Let failed Jenkins builds set Verified: -1 in Gerrit?

[Stephan Bergmann]

Is there any good reason why a failed Gerrit/Jenkins build does not set 
the corresponding Gerrit change's Verified flag to -1 (similar to how a 
successful such build sets the flag to +1)?


Especially with the poor Jenkins turnaround times, it is hard to tell on 
a page like  whether a 
change is not yet ready for submission because Jenkins has not yet built 
it or because the Jenkins build failed.  The "V" ("Verified") column is 
empty in both cases.  (And I assume it would contain something like a 
red cross if the Verified flag is -1.)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice