Re: suspended ctests

2016-09-20 Thread Kornel Benko
Am Montag, 19. September 2016 um 06:36:49, schrieb Guenter Milde 

> On 2016-09-16, Kornel Benko wrote:
> 
> > [-- Type: text/plain, Encoding: quoted-printable --]
> 
> > Am Freitag, 16. September 2016 um 19:28:04, schrieb Guenter Milde 
> > 
> >> On 2016-09-13, Guenter Milde wrote:
> >> > On 2016-09-13, Kornel Benko wrote:
> 
> >> >>> >> * Do you still need the "suspendeTests"? What for?
> 
> >> >>> > Yes, we need them. This tests will not be executed with the call
> >> >>> > 'ctest
> >> >>> > -L export'.
> 
> >> ...
> 
> >> >>> In the meantime, we know the particular problem for most of the 
> >> >>> suspended
> >> >>> tests.
> >> >>> Some were fixed. Others require inversion (we know the problem is a
> >> >>> wontfix or a bug on trac).
> 
> >> Therefore, I'll reword the question:
> 
> >> Do you call `ctest -L export` regularely?
> 
> > This is my alias for export:
> > ctest -j12 -timeout 300 -L export -E "xhtml|lyx16|lyx21|lyx22"
> 
> >> Could you imagine calling `ctest -L export -LE "texissues|attic"` instead?
> 
> > Sure, but if you think texissues should not be tested, make them part
> > of suspended.
> 
> -1 this would mean duplicating all 83 lines of the "texissues" section in
>invertedTests into suspendedTests

Maybe. I counted 20 entries.

> -1 this would not allow me to get rid of the suspendedTests filter.   
> 
> OTOH, the alias might easily be changed to:
> 
>ctest -j12 -timeout 300 -L export -E "xhtml|lyx16|lyx21|lyx22" -LE 
> "texissues|attic"

And why remove attic? Do we not want to support lyx-file written with old lyx?
If yes, then we should test IMHO.

> >>   +1 filters not only 58 but 80 "wontfix" inverted tests

"wontfix" definitely belongs to suspendedTests or ignoredTests.

> >>   +4 makes the test system less complicated.
> 

It was not me alone who built the test system. Still, I don’t think it is 
complicated.

> Günter

Kornel

signature.asc
Description: This is a digitally signed message part.


Re: fr/beamer.lyx + pdf4: encoding issue

2016-09-20 Thread Kornel Benko
Am Dienstag, 20. September 2016 um 10:56:29, schrieb Scott Kostyshak 

> On Tue, Sep 20, 2016 at 06:28:48AM +, Guenter Milde wrote:
> > On 2016-09-20, Scott Kostyshak wrote:
> 
> > > But at the same time I don't think it makes sense to deviate from the
> > > original (English) version, where ERT is used. 
> > 
> > Yes.
> > 
> > > So I think you are right that is the way to go, unless we want to
> > > change all versions of the Beamer manual to a comment or note inset,
> > > and that seems like more work than should be done for this trivial
> > > issue.
> > 
> > Yes.
> > 
> > -> invert the test (pdf4_texF)
> > 
> > > Changed to \'{e} in stable at 9f3518bc and cherry-picked to master at
> > > 1c7835c0.
> > 
> > > Thanks for the discussion. I now have a better idea of how to deal with
> > > this for similar issues when they come up.
> > 
> > I don't think this is the right way.
> > 
> > The documentation is for documentation, test-use is secondary and "exotic
> > tests" don't merit changes that make the documentation more difficult to 
> > read.
> 
> I agree this is the right policy. If I convert those comments to a LyX
> note or comment inset, this policy is still satisfied because the inset
> is just as readable, right? So either:
> 
> (1) revert the commit I pushed and invert the test

Please no. If we never interpret ERT, then this will stay inverted forever.
Inverted tests are waiting for correction, at least this was what I have/had in 
mind.

> or
> 
> (2) change the inset for all beamer manuals.

+1

> Do you agree that both would be satisfactory?
> 
> Scott

Kornel


signature.asc
Description: This is a digitally signed message part.


Re: cannot compile master

2016-09-20 Thread Kornel Benko
Am Dienstag, 20. September 2016 um 09:59:38, schrieb Ian Wilder 

> On 2016-09-11 13:42:41 +, Kornel Benko said:
> 
> > Am Sonntag, 11. September 2016 um 12:24:26, schrieb Guenter Milde 
> > 
> >> On 2016-09-10, Kornel Benko wrote:
> >>> Am Freitag, 9. September 2016 um 22:29:23, schrieb Guenter Milde 
> >>> 
>  On 2016-09-09, Scott Kostyshak wrote:
> >> 
> >> 
> >> as of today, I cannot compile master, "make" fails with
>  ...
> >> GuiView.cpp:(.text+0x1fa85): undefined reference to 
> >> `QSvgRenderer::~QSvgRenderer()'
>  ...
> >> 
> >> ...
> >> 
> >>> Adding ${QT_QTSVG_LIBRARY} to target_link_libraries for lyx works here.
> >> 
> >> Dear Kornel,
> >> 
> >> this did the trick also here. Could you commit the patch, please?
> >> 
> >> Günter
> > 
> > Done at 050d817. Someone has to check if the change works on windows 
> > and MAC too.
> > 
> > Kornel
> > 
> > 
> > 
> 
> For some reason, I can't compile master at all on macOS.
> Mine fails  with
> 
> make[3]: *** No rule to make target `libs/signals/src/connection.cpp', 
> needed by `libs/signals/src/connection.o'.  Stop.
> 
> I'm using macports, and I've successfully compiled the 2.2 branch just 
> prior to its release.
> 
> If I can get past this step, I can confirm or deny a build for the mac 
> platform.
> 
> Thanks,
> Ian

You are compiling master?
Looks like you use old build tree. This file _was_ part of our boost build.

Kornel 

signature.asc
Description: This is a digitally signed message part.


Re: fr/beamer.lyx + system fonts + Xe/Lua fails

2016-09-20 Thread Jürgen Spitzmüller
The argument inset must be in the language of the quotation. If not,
you get an environment that beamer cannot parse.

LyX should probably just pass those arguments without language changes.
OTOH there are also arguments that contain text in a specific language.

Jürgen

Am Montag, den 19.09.2016, 22:49 -0400 schrieb Scott Kostyshak:
> I wonder if this is the language nesting issue?
> 
> Attached is a more minimal example that gives the same error, which
> is
> the following:
> 
> -
> Runaway argument?
> \let \AtEndDocument \@firstofone \@enddocumenthook \@checkend
> {docume\ETC.
> ! File ended while scanning use of \beamer@collect@@body.
>  
> \par 
> <*> beamer.tex
>   
> I suspect you have forgotten a `}', causing me
> to read past where you wanted me to stop.
> I'll try to recover; but if the error is serious,
> you'd better type `E' or `X' now and fix your file.
> 
> ! Emergency stop.
> <*> beamer.tex
> -
> 
> Any ideas?
> 
> Scott

beamer2.lyx
Description: application/lyx


signature.asc
Description: This is a digitally signed message part


Re: fr/beamer.lyx + pdf4: encoding issue

2016-09-20 Thread Guenter Milde
On 2016-09-20, Scott Kostyshak wrote:
> On Tue, Sep 20, 2016 at 01:24:02AM +0200, Kornel Benko wrote:

>> > > * change the comment from ERT to comment
>> > 
>> > I did not think of this possibility. I like it.
>> > 
>> > > * invert the test (we already have several cases of inverted:ERT)

>> I'd say, since it is ERT, which means 'latex', use the suggested  \'{e}.

However, with default output (pdflatex), the ERT compiles fine, even with
all other export routes except the "exotic" XeTeX+TeX-fonts
(because of the special encoding-restriction of this combination)!

> I was at first against this because I thought the ERT inset was meant to
> be read by French readers of the LyX beamer manual, and \'{e} looks ugly
> (don't we use LyX to avoid backslashes and brackets?). 

Yes.

> But at the same time I don't think it makes sense to deviate from the
> original (English) version, where ERT is used. 

Yes.

> So I think you are right that is the way to go, unless we want to
> change all versions of the Beamer manual to a comment or note inset,
> and that seems like more work than should be done for this trivial
> issue.

Yes.

-> invert the test (pdf4_texF)

> Changed to \'{e} in stable at 9f3518bc and cherry-picked to master at
> 1c7835c0.

> Thanks for the discussion. I now have a better idea of how to deal with
> this for similar issues when they come up.

I don't think this is the right way.

The documentation is for documentation, test-use is secondary and "exotic
tests" don't merit changes that make the documentation more difficult to read.

Günter




Re: fr/beamer.lyx + system fonts + Xe/Lua fails

2016-09-20 Thread Enrico Forestieri
On Tue, Sep 20, 2016 at 09:05:50AM +0200, Jürgen Spitzmüller wrote:

> The argument inset must be in the language of the quotation. If not,
> you get an environment that beamer cannot parse.

I don't think so. This is rather a case of a not properly terminated
language switch. See attached.

-- 
Enrico
#LyX 2.3 created this file. For more info see http://www.lyx.org/
\lyxformat 512
\begin_document
\begin_header
\save_transient_properties true
\origin unavailable
\textclass beamer
\use_default_options true
\maintain_unincluded_children false
\language french
\language_package default
\inputencoding auto
\fontencoding global
\font_roman "default" "DejaVu Sans"
\font_sans "default" "DejaVu Sans"
\font_typewriter "default" "DejaVu Sans"
\font_math "auto" "auto"
\font_default_family default
\use_non_tex_fonts true
\font_sc false
\font_osf false
\font_sf_scale 100 100
\font_tt_scale 100 100
\use_microtype false
\graphics default
\default_output_format default
\output_sync 0
\bibtex_command default
\index_command default
\paperfontsize default
\spacing single
\use_hyperref false
\papersize default
\use_geometry true
\use_package amsmath 1
\use_package amssymb 1
\use_package cancel 1
\use_package esint 1
\use_package mathdots 1
\use_package mathtools 1
\use_package mhchem 1
\use_package stackrel 1
\use_package stmaryrd 1
\use_package undertilde 1
\cite_engine basic
\cite_engine_type default
\biblio_style plain
\use_bibtopic false
\use_indices false
\paperorientation portrait
\suppress_date false
\justification true
\use_refstyle 1
\index Index
\shortcut idx
\color #008000
\end_index
\secnumdepth 3
\tocdepth 3
\paragraph_separation indent
\paragraph_indentation default
\quotes_language french
\papercolumns 1
\papersides 1
\paperpagestyle default
\tracking_changes false
\output_changes false
\html_math_output 0
\html_css_as_file 0
\html_be_strict false
\end_header

\begin_body

\begin_layout Frame
\begin_inset Argument 4
status collapsed

\begin_layout Plain Layout
Un exemple
\end_layout

\end_inset


\end_layout

\begin_layout Frame
Soit par exemple une citation.
 Dans un environnement 
\begin_inset Flex Structure
status collapsed

\begin_layout Plain Layout
Cite
\end_layout

\end_inset

, vous pouvez spécifier les réglages de recouvrement via 
\begin_inset Flex Alert
status collapsed

\begin_layout Plain Layout
Insérer\SpecialChar menuseparator
Spécifications de recouvrement
\end_layout

\end_inset

.
 Si vous les faites et saisissez 
\begin_inset Quotes fld
\end_inset

2
\begin_inset Quotes frd
\end_inset

, la citation n’apparaîtra que sur la (sous-)diapo 2:
\end_layout

\begin_deeper
\begin_layout Quote
\begin_inset Argument 1
status open

\begin_layout Plain Layout
2
\end_layout

\end_inset


\lang english
Fear no more the heat o’ the sun
\end_layout

\begin_layout Quote

\lang english
Nor the furious winter’s rages
\end_layout

\begin_layout Quote

\lang english
Thou thy worldly task hast done
\end_layout

\begin_layout Quote

\lang english
Home art gone, and ta’en thy wages
\end_layout

\begin_layout Quote

\lang english
\begin_inset ERT
status open

\begin_layout Plain Layout


\backslash
end{english}
\end_layout

\end_inset


\end_layout

\end_deeper
\begin_layout Frame
Voilà comment fonctionne le concept, fondamentalement
\end_layout

\end_body
\end_document


Re: [LyX/master] Improve info display for biblatex databases

2016-09-20 Thread Richard Heck
On 09/18/2016 04:35 AM, Juergen Spitzmueller wrote:
> commit ba171930670696153b7fcce8e2ba648a294d8425
> Author: Juergen Spitzmueller 
> Date:   Sun Sep 18 10:33:33 2016 +0200
>
> Improve info display for biblatex databases
> 
> If an entry does not have a year field, check for a date field
> (the common type in biblatex databases) and extract the year(s).
> 
> Candidate for branch.

Let's hold this for 2.2.3, but it will be fine when that is open.

rh



Re: [PATCH] A fix for the zombie -lyxformat- files invasion ?

2016-09-20 Thread Richard Heck
On 09/20/2016 10:20 AM, Jean-Marc Lasgouttes wrote:
> Le 09/09/2016 à 23:01, Richard Heck a écrit :
>> On 09/09/2016 04:45 AM, Jean-Marc Lasgouttes wrote:
>>> Hello,
>>>
>>> Here is a trivial idea to limit the proliferation of
>>> myfile-lyxformat-322.lyx files that are more annoying than helpful to
>>> many people (or helpful in a Clippy sense). Can we at least use .lyx~
>>> as extension?
>>>
>>> Patch attached. I do not know whether there are other things we should
>>> care about.
>>
>> That would be fine with me.
>>
>> I wonder if just changing "lyxformat" to "backup" would make it clearer
>> what these are.
>
> If they end with .lyx~, they will look like backup files.
> If we remove lyxformat, the number after it will look mysterious.
>
> I will push to master soon. What about branch?

OK.

rh



Re: [LyX/master] Improve info display for biblatex databases

2016-09-20 Thread Jürgen Spitzmüller
Am Dienstag, den 20.09.2016, 13:24 -0400 schrieb Richard Heck:
> Let's hold this for 2.2.3

Sure, that was the plan anyway.

> , but it will be fine when that is open.

I will come back with some of the candidates when we are there.

Jürgen

> rh
> 

signature.asc
Description: This is a digitally signed message part


Re: Fwd: Re: Small problems with figure previews

2016-09-20 Thread Pietro Cortese
Hello,

by using the debugging option as you suggested and looking in the code
the issue became clear.
With QT4.8 lyx is using QT for conversion and therefore the suggestion
to change the converter settings didn't work.
I recompiled with QT5 and now it is using the external converter and
therefore the suggestion:
convert -density 150  $$i $$o
does the trick.

Thanks,
Pietro





Re: fr/beamer.lyx + pdf4: encoding issue

2016-09-20 Thread Scott Kostyshak
On Tue, Sep 20, 2016 at 05:51:36PM +0200, Kornel Benko wrote:
> Am Dienstag, 20. September 2016 um 10:56:29, schrieb Scott Kostyshak 
> 
> > On Tue, Sep 20, 2016 at 06:28:48AM +, Guenter Milde wrote:
> > > On 2016-09-20, Scott Kostyshak wrote:

> > > The documentation is for documentation, test-use is secondary and "exotic
> > > tests" don't merit changes that make the documentation more difficult to 
> > > read.
> > 
> > I agree this is the right policy. If I convert those comments to a LyX
> > note or comment inset, this policy is still satisfied because the inset
> > is just as readable, right? So either:
> > 
> > (1) revert the commit I pushed and invert the test
> 
> Please no. If we never interpret ERT, then this will stay inverted forever.
> Inverted tests are waiting for correction, at least this was what I have/had 
> in mind.

I tend to agree. Something feels wrong with inverting. Unless we label
the issue as a LyX enhancement (and create a trac ticket) because there
is no way in LyX to produce LyX-readable content in this case that can
be exported to several different formats.

> > or
> > 
> > (2) change the inset for all beamer manuals.
> 
> +1

OK I will go for this. I'll wait another day or so to see if Günter
disagrees.

Scott

> > Do you agree that both would be satisfactory?
> > 
> > Scott
> 
>   Kornel


signature.asc
Description: PGP signature


Re: cannot compile master

2016-09-20 Thread Ian Wilder

On 2016-09-11 13:42:41 +, Kornel Benko said:

Am Sonntag, 11. September 2016 um 12:24:26, schrieb Guenter Milde 


On 2016-09-10, Kornel Benko wrote:
Am Freitag, 9. September 2016 um 22:29:23, schrieb Guenter Milde 


On 2016-09-09, Scott Kostyshak wrote:




as of today, I cannot compile master, "make" fails with

...
GuiView.cpp:(.text+0x1fa85): undefined reference to 
`QSvgRenderer::~QSvgRenderer()'

...


...


Adding ${QT_QTSVG_LIBRARY} to target_link_libraries for lyx works here.


Dear Kornel,

this did the trick also here. Could you commit the patch, please?

Günter


Done at 050d817. Someone has to check if the change works on windows 
and MAC too.


Kornel





For some reason, I can't compile master at all on macOS.
Mine fails  with

make[3]: *** No rule to make target `libs/signals/src/connection.cpp', 
needed by `libs/signals/src/connection.o'.  Stop.


I'm using macports, and I've successfully compiled the 2.2 branch just 
prior to its release.


If I can get past this step, I can confirm or deny a build for the mac 
platform.


Thanks,
Ian




Re: fr/beamer.lyx + pdf4: encoding issue

2016-09-20 Thread Scott Kostyshak
On Tue, Sep 20, 2016 at 06:28:48AM +, Guenter Milde wrote:
> On 2016-09-20, Scott Kostyshak wrote:

> > But at the same time I don't think it makes sense to deviate from the
> > original (English) version, where ERT is used. 
> 
> Yes.
> 
> > So I think you are right that is the way to go, unless we want to
> > change all versions of the Beamer manual to a comment or note inset,
> > and that seems like more work than should be done for this trivial
> > issue.
> 
> Yes.
> 
> -> invert the test (pdf4_texF)
> 
> > Changed to \'{e} in stable at 9f3518bc and cherry-picked to master at
> > 1c7835c0.
> 
> > Thanks for the discussion. I now have a better idea of how to deal with
> > this for similar issues when they come up.
> 
> I don't think this is the right way.
> 
> The documentation is for documentation, test-use is secondary and "exotic
> tests" don't merit changes that make the documentation more difficult to read.

I agree this is the right policy. If I convert those comments to a LyX
note or comment inset, this policy is still satisfied because the inset
is just as readable, right? So either:

(1) revert the commit I pushed and invert the test

or

(2) change the inset for all beamer manuals.

Do you agree that both would be satisfactory?

Scott


signature.asc
Description: PGP signature


Re: [PATCH] A fix for the zombie -lyxformat- files invasion ?

2016-09-20 Thread Jean-Marc Lasgouttes

Le 09/09/2016 à 23:01, Richard Heck a écrit :

On 09/09/2016 04:45 AM, Jean-Marc Lasgouttes wrote:

Hello,

Here is a trivial idea to limit the proliferation of
myfile-lyxformat-322.lyx files that are more annoying than helpful to
many people (or helpful in a Clippy sense). Can we at least use .lyx~
as extension?

Patch attached. I do not know whether there are other things we should
care about.


That would be fine with me.

I wonder if just changing "lyxformat" to "backup" would make it clearer
what these are.


If they end with .lyx~, they will look like backup files.
If we remove lyxformat, the number after it will look mysterious.

I will push to master soon. What about branch?

JMarc