from:"Phuedx \(Code Review\)"

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove ExtMobileFrontend::eventLog

2018-01-17 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404703 )

Change subject: Hygiene: Remove ExtMobileFrontend::eventLog
..

Hygiene: Remove ExtMobileFrontend::eventLog

Since I25f9e1ca, the method is no longer used.

Change-Id: I3a32d87b594ae53ee6d8ba47b6304764c74bcdc0
---
M includes/MobileFrontend.body.php
1 file changed, 0 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/03/404703/1

diff --git a/includes/MobileFrontend.body.php b/includes/MobileFrontend.body.php
index 45f4196..444f589 100644
--- a/includes/MobileFrontend.body.php
+++ b/includes/MobileFrontend.body.php
@@ -9,19 +9,6 @@
  */
 class ExtMobileFrontend {
/**
-* Uses EventLogging when available to record an event on server side
-*
-* @param string $schema The name of the schema
-* @param int $revision The revision of the schema
-* @param array $data The data to be recorded against the schema
-*/
-   public static function eventLog( $schema, $revision, $data ) {
-   if ( is_callable( [ EventLogging::class, 'logEvent' ] ) ) {
-   EventLogging::logEvent( $schema, $revision, $data );
-   }
-   }
-
-   /**
 * Transforms content to be mobile friendly version.
 * Filters out various elements and runs the MobileFormatter.
 * @param OutputPage $out

-- 
To view, visit https://gerrit.wikimedia.org/r/404703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a32d87b594ae53ee6d8ba47b6304764c74bcdc0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Drop use of MobileOptionsTracking schema

2018-01-16 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404495 )

Change subject: Drop use of MobileOptionsTracking schema
..

Drop use of MobileOptionsTracking schema

Going forward we can rely on pageview data to get a sense of how
many users are in beta.

statsd also gives us a  little information on behaviour of the form
so we keep it.

EventLogging has been broken for some time so is removed.

Bug: T182235
Change-Id: I365a31a2e4d1cce280d89fc2a2004290e8ff548d
---
M includes/specials/SpecialMobileOptions.php
1 file changed, 1 insertion(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/95/404495/1

diff --git a/includes/specials/SpecialMobileOptions.php 
b/includes/specials/SpecialMobileOptions.php
index 81cfdbe..a61e1ce 100644
--- a/includes/specials/SpecialMobileOptions.php
+++ b/includes/specials/SpecialMobileOptions.php
@@ -219,12 +219,6 @@
 * of returnto or, if not set, back to this special page
 */
private function submitSettingsForm() {
-   $schema = 'MobileOptionsTracking';
-   $schemaRevision = 16934032;
-   $schemaData = [
-   'action' => 'success',
-   'beta' => "nochange",
-   ];
$context = MobileContext::singleton();
$request = $this->getRequest();
$user = $this->getUser();
@@ -236,26 +230,11 @@
. $this->msg( "mobile-frontend-save-error" 
)->parse()
. ''
);
-   $schemaData['action'] = 'error';
-   $schemaData['errorText'] = $errorText;
-   ExtMobileFrontend::eventLog( $schema, $schemaRevision, 
$schemaData );
$this->addSettingsForm();
return;
}
 
-   if ( $request->getBool( 'enableBeta' ) ) {
-   $group = 'beta';
-   if ( !$context->isBetaGroupMember() ) {
-   // The request was to turn on beta
-   $schemaData['beta'] = "on";
-   }
-   } else {
-   $group = '';
-   if ( $context->isBetaGroupMember() ) {
-   // beta was turned off
-   $schemaData['beta'] = "off";
-   }
-   }
+   $group = $request->getBool( 'enableBeta' ) ? 'beta' : '';
$context->setMobileMode( $group );
$returnToTitle = Title::newFromText( $request->getText( 
'returnto' ) );
if ( $returnToTitle ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I365a31a2e4d1cce280d89fc2a2004290e8ff548d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx 
Gerrit-Reviewer: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revision: Handle all return values of Title::newFromId

2017-12-27 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400408 )

Change subject: Revision: Handle all return values of Title::newFromId
..

Revision: Handle all return values of Title::newFromId

In Revision::getKnownCurrent, fail early when Title::newFromId returns
null to avoid an uncatchable fatal error being triggered.

RevisionStore#getKnownCurrentRevision requires that the title parameter
be an instance of Title.

This follows on from Ia4c20a91.

Change-Id: I9bddafcc5df630d1dff1e2526194186cab7097e5
---
M includes/Revision.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/08/400408/1

diff --git a/includes/Revision.php b/includes/Revision.php
index 8f36e88..b8b56a3 100644
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -1204,6 +1204,10 @@
? $pageIdOrTitle
: Title::newFromID( $pageIdOrTitle );
 
+   if ( !$title ) {
+   return false;
+   }
+
$record = self::getRevisionStore()->getKnownCurrentRevision( 
$title, $revId );
return $record ? new Revision( $record ) : false;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/400408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bddafcc5df630d1dff1e2526194186cab7097e5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: instrumentation: Bump schema revision

2017-12-14 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398293 )

Change subject: instrumentation: Bump schema revision
..

instrumentation: Bump schema revision

Following on from I6643168a, the client-side JSONSchema validation does
handle the integer type [0] so we can enforce that timestamps are integers
on the client as well as on the server.

[0] 
https://github.com/wikimedia/mediawiki-extensions-EventLogging/blob/3d0837e5/modules/ext.eventLogging.core.js#L102-L103

Bug: T182000
Change-Id: I79af7975388d50a570e209b212c0c90322e4a23a
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/93/398293/1

diff --git a/extension.json b/extension.json
index bab24f1..dee6d0c 100644
--- a/extension.json
+++ b/extension.json
@@ -53,7 +53,7 @@
]
},
"EventLoggingSchemas": {
-   "Popups": 17430287
+   "Popups": 17540736
},
"config": {
"@PopupsBetaFeature": "@var bool: Whether the extension should 
be enabled as an opt-in beta feature. If true, the BetaFeatures extension must 
be installed. False by default.",

-- 
To view, visit https://gerrit.wikimedia.org/r/398293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79af7975388d50a570e209b212c0c90322e4a23a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Update MobileContext#logMobileMode documentation

2017-12-13 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398116 )

Change subject: Update MobileContext#logMobileMode documentation
..

Update MobileContext#logMobileMode documentation

... with a note to update the documentation for the X-Analytics header,
which it affects.

Change-Id: I4d5677e9c6631196219946bcf9ac37945fa5445e
---
M includes/MobileContext.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/16/398116/1

diff --git a/includes/MobileContext.php b/includes/MobileContext.php
index c5e1946..a8c0c21 100644
--- a/includes/MobileContext.php
+++ b/includes/MobileContext.php
@@ -1108,6 +1108,9 @@
 * Adds analytics log items if the user is in beta mode
 *
 * Invoked from MobileFrontendHooks::onRequestContextCreateSkin()
+*
+* Making changes to what this method logs? Make sure you update the
+* documentation for the X-Analytics header: 
https://wikitech.wikimedia.org/wiki/X-Analytics
 */
public function logMobileMode() {
if ( $this->isBetaGroupMember() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/398116
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d5677e9c6631196219946bcf9ac37945fa5445e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Add npm job for the Chromium render service

2017-11-29 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394058 )

Change subject: Add npm job for the Chromium render service
..

Add npm job for the Chromium render service

The Chromium render service is service-template-node-based and uses the
standard `npm test` entry point.

Bug: T179552
Change-Id: I594687c417b9a336a11ae452e0bf465add47a477
---
M zuul/layout.yaml
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/58/394058/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 4fd6354..b270ade 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -6643,6 +6643,10 @@
 gate-and-submit:
   - trending-edits-deploy-npm-node-6-jessie
 
+  - name: mediawiki/services/chromium-render
+template:
+  - name: npm
+
   - name: mediawiki/extensions/Parsoid
 template:
   - name: archived

-- 
To view, visit https://gerrit.wikimedia.org/r/394058
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I594687c417b9a336a11ae452e0bf465add47a477
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: gateway/rest: Handle large "small" thumbnails

2017-10-12 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383831 )

Change subject: gateway/rest: Handle large "small" thumbnails
..

gateway/rest: Handle large "small" thumbnails

NOTE: This is a test case to demonstrate the following design issue.

The Page Summary API's idea of a "small" thumbnail can vary
independently of the Page Previews client. Indeed, prior to T173434, the
Page Summary API requested thumbnails with a dimension of 320px whereas
this client considered 300px to be the target dimension.

Bug: T176627
Change-Id: I0a3f6ef8d6cb416309c90213074b91e0e5332bd7
---
M tests/node-qunit/gateway/rest.test.js
1 file changed, 25 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/31/383831/1

diff --git a/tests/node-qunit/gateway/rest.test.js 
b/tests/node-qunit/gateway/rest.test.js
index b2b1de0..b33ecf7 100644
--- a/tests/node-qunit/gateway/rest.test.js
+++ b/tests/node-qunit/gateway/rest.test.js
@@ -184,6 +184,31 @@
);
 
// ---
+   //
+   // We deliberately set the thumbnail size to something smaller than 
what is
+   // requested by the Page Summary API. This tests the situation where the
+   // client (Page Previews) and the server have diverged in what they 
consider
+   // the smallest allowable image.
+   //
+   // Prior to T173434, the Page Summary API requested thumbnails with a
+   // dimension of 320px whereas this client considered 300px to be the 
target
+   // dimension. What if we decided that the Page Summary API should 
request
+   // thumbnails at 620px?
+   //
+   // See T176729 for more context.
+   model = gateway.convertPageToModel(
+   RESTBASE_RESPONSE_WITH_SMALL_IMAGE,
+   250,
+   provideParsedExtract
+   );
+
+   assert.deepEqual(
+   model.thumbnail.source,
+   
'https://upload.wikimedia.org/wikipedia/commons/thumb/2/2c/RH-Fedora_logo-nonfree.png/250px-RH-Fedora_log_nonfree.png',
+   'It should handle the Page Summary API returning "small" images 
than are larger than the requested width.'
+   );
+
+   // ---
model = gateway.convertPageToModel( 
RESTBASE_RESPONSE_WITH_LANDSCAPE_IMAGE, 640, provideParsedExtract );
 
assert.deepEqual(

-- 
To view, visit https://gerrit.wikimedia.org/r/383831
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a3f6ef8d6cb416309c90213074b91e0e5332bd7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: Register PHPUnit tests via UnitTestsList hook

2017-10-10 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383350 )

Change subject: Register PHPUnit tests via UnitTestsList hook
..

Register PHPUnit tests via UnitTestsList hook

Change-Id: Ieca8a54df476c5de22b4ceff303ea8b855b1e52a
---
M Collection.hooks.php
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection 
refs/changes/50/383350/1

diff --git a/Collection.hooks.php b/Collection.hooks.php
index abd8ac6..d69e4ca 100644
--- a/Collection.hooks.php
+++ b/Collection.hooks.php
@@ -440,4 +440,17 @@
}
return true;
}
+
+   /**
+* [UnitTestsList][0] hook handler.
+*
+* Registers the extension's PHPUnit tests.
+*
+* [0]: https://www.mediawiki.org/wiki/Manual:Hooks/UnitTestsList.
+*
+* @param array &$paths
+*/
+   public static function onUnitTestsList( array &$paths ) {
+   $paths[] = __DIR__ . '/tests/phpunit';
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/383350
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieca8a54df476c5de22b4ceff303ea8b855b1e52a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: Don't request render if renderer not configured

2017-10-10 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383347 )

Change subject: Don't request render if renderer not configured
..

Don't request render if renderer not configured

If $mwCollectionMWServeURL is falsy, then don't try make an HTTP request
to the rendering backend. Instead, log a helpful message to the
"collection" log group.

Bug: T177795
Change-Id: Ia33e7f72b4d3cbbea6c8e939ea80ef05c179648f
---
M RenderingAPI.php
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection 
refs/changes/47/383347/1

diff --git a/RenderingAPI.php b/RenderingAPI.php
index 397872d..2593416 100644
--- a/RenderingAPI.php
+++ b/RenderingAPI.php
@@ -301,14 +301,22 @@
// If $serveURL has a | in it, we need to use a proxy.
list( $proxy, $serveURL ) = array_pad( explode( '|', $serveURL, 
2 ), -2, '' );
 
+   if ( !$serveURL ) {
+   wfDebugLog( 'collection', 'The mwlib/OCG render server 
URL isn\'t configured.' );
+
+   return new CollectionAPIResult( false );
+   }
+
$response = Http::post(
$serveURL,
[ 'postData' => $params, 'proxy' => $proxy ],
__METHOD__
);
+
if ( $response === false ) {
wfDebugLog( 'collection', "Request to $serveURL 
resulted in error" );
}
+
return new CollectionAPIResult( $response );
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/383347
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia33e7f72b4d3cbbea6c8e939ea80ef05c179648f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[master]: subscriber: Wait until browser idle before logging

2017-09-21 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/379532 )

Change subject: subscriber: Wait until browser idle before logging
..

subscriber: Wait until browser idle before logging

If no additional ResourceLoader modules need to be loaded, then the
subscriber module (ext.eventLogging.subscriber) may be executed after
window.onload has fired. If this is the case, then the subscriber will
never be subscribed.

Subscribing the subscriber in an idle callback (via
mw.requestIdleCallback) maintains the minimal impact of logging events
on the loading of assets and avoids the Firefox 51+ issue of
double-logging events due to window.onload firing twice under certain
conditions (see T170018 and [0]).

[0]: https://bugzilla.mozilla.org/show_bug.cgi?id=1379762

Bug: T175918
Change-Id: I4458c13194ba3962f67347726653d6354e4e41dc
---
M modules/ext.eventLogging.subscriber.js
1 file changed, 7 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/32/379532/1

diff --git a/modules/ext.eventLogging.subscriber.js 
b/modules/ext.eventLogging.subscriber.js
index 28ea1b7..be476c3 100644
--- a/modules/ext.eventLogging.subscriber.js
+++ b/modules/ext.eventLogging.subscriber.js
@@ -1,8 +1,8 @@
 /*!
- * Because subscribers to mw#track receive the full backlog of events
- * matching the subscription, event processing can be safely deferred
- * until the window's load event has fired. This keeps the impact of
- * analytic instrumentation on page load times to a minimum.
+ * Because subscribers to mw#track receive the full backlog of events matching
+ * the subscription, event processing can be safely deferred until the browser
+ * is idle. This keeps the impact of analytic instrumentation on page load 
times
+ * to a minimum.
  *
  * @author Ori Livneh 
  */
@@ -87,13 +87,10 @@
 
};
 
-   // Avoid the logging of duplicate events (T170018).
-   //
-   // The load event must only fire once. However, Firefox 51 introduced a
-   // bug that causes the event to fire again when returning from the
-   // "Back-Forward cache" (BFCache) under certain circumstances (see
+   // Using mw.requestIdleCallback also avoids the logging of duplicate 
events in
+   // Firefox 51+ when subscribing to the "load" event (see T170018 and
// https://bugzilla.mozilla.org/show_bug.cgi?id=1379762).
-   $( window ).one( 'load', function () {
+   mw.requestIdleCallback( function () {
mw.trackSubscribe( 'event.', handleTrackedEvent );
} );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/379532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4458c13194ba3962f67347726653d6354e4e41dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Stop A/B test on enwiki and dewiki

2017-09-18 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/378686 )

Change subject: pagePreviews: Stop A/B test on enwiki and dewiki
..

pagePreviews: Stop A/B test on enwiki and dewiki

Changes:
* Remove A/B test configuration for all wikis.
* Disable EventLogging instrumentation on all wikis.
* Revert the Page Previews feature to a beta feature on enwiki and
  dewiki. This also has the effect of disabling the feature for logged
  out users.

Bug: T176068
Change-Id: Ia69d651dc7d0f3971252b30b9d3c9fff9809e372
---
M wmf-config/InitialiseSettings.php
1 file changed, 3 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/86/378686/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index f96d715..49e3a8f 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -13585,9 +13585,6 @@
// stage 0 and stage 1 wikis.
'pp_stage0' => true,
'pp_stage1' => true,
-   // T172291
-   'enwiki' => true,
-   'dewiki' => true,
 ],
 
 'wgPopupsPageBlacklist' => [
@@ -13615,6 +13612,8 @@
 
 'wmgPopupsBetaFeature' => [
'default' => false,
+   'enwiki' => true,
+   'dewiki' => true,
 ],
 
 'wgPopupsStatsvSamplingRate' => [
@@ -13624,16 +13623,12 @@
 ],
 
 'wgPopupsAnonsExperimentalGroupSize' => [
-   // Read: Enable previews for all anonymous users by default, which is 
the current behaviour on all wikis except enwiki and dewiki per T162672.
+   // Read: Enable previews for all anonymous users by default.
'default' => 0,
-   'enwiki' => 0.06,
-   'dewiki' => 0.16,
 ],
 
 'wgPopupsEventLogging' => [
'default' => false,
-   'enwiki' => true,
-   'dewiki' => true,
 ],
 
 'wgPopupsGateway' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/378686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia69d651dc7d0f3971252b30b9d3c9fff9809e372
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Scale A/B test bucket sizes by 10

2017-08-30 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/374815 )

Change subject: pagePreviews: Scale A/B test bucket sizes by 10
..

pagePreviews: Scale A/B test bucket sizes by 10

Currently, we're seeing ~10 Popups events/s at peak time [0]. We've had
the go ahead from Analytics Engineering to increase that rate to ~100
events/s [1]. Since the rate is proportional to the size of the on and
control buckets - controlled by $wgPopupsAnonsExperimentalGroupSize - we
simply multiply it by 10 to achieve the desired rate.

[0] 
https://grafana.wikimedia.org/dashboard/db/eventlogging-schema?var-schema=Popups=5m=1=150392160=1504028841970
[1] https://phabricator.wikimedia.org/T172291#3565685

Bug: T172291
Change-Id: I13b849c173665bb119c7abfb0bd7fdeb0376f4b8
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/15/374815/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 7bb2165..2722766 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -13620,8 +13620,8 @@
 'wgPopupsAnonsExperimentalGroupSize' => [
// Read: Enable previews for all anonymous users by default, which is 
the current behaviour on all wikis except enwiki and dewiki per T162672.
'default' => 0,
-   'enwiki' => 0.006,
-   'dewiki' => 0.016,
+   'enwiki' => 0.06,
+   'dewiki' => 0.16,
 ],
 
 'wgPopupsEventLogging' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/374815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13b849c173665bb119c7abfb0bd7fdeb0376f4b8
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Bump on/control group size to 25% (BC-only)

2017-08-24 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373541 )

Change subject: pagePreviews: Bump on/control group size to 25% (BC-only)
..

pagePreviews: Bump on/control group size to 25% (BC-only)

Bug: T171853
Change-Id: I21f256f87029c4e91e6b1637faa5550d4c70856b
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/41/373541/1

diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index 3e7d73f..f698dab 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -574,7 +574,7 @@
// disabled by default; for 50%, PP will be disabled as will the
// instrumentation.
'-wgPopupsAnonsExperimentalGroupSize' => [
-   'default' => 0.25,
+   'default' => 0.5,
],
 
// T171853: Enable PP EventLogging instrumentation on enwiki 
only so that we

-- 
To view, visit https://gerrit.wikimedia.org/r/373541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21f256f87029c4e91e6b1637faa5550d4c70856b
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Re-enable on Beta Cluster

2017-08-24 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373531 )

Change subject: pagePreviews: Re-enable on Beta Cluster
..

pagePreviews: Re-enable on Beta Cluster

I85c3fcfd accidentally disabled Page Previews for enwiki and dewiki on
the Beta Cluster by not overriding $wmgUsePopups.

Bug: T171853
Change-Id: I840858eb06ae1f1f01b1cef178cbe59d33df00df
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/31/373531/1

diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index 1b394c2..3e7d73f 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -561,7 +561,7 @@
//
// Note well that the Popups extension is only loaded when 
either
// wmgUsePopups or wmgPopupsBetaFeature is truthy.
-   'wmgUsePopups' => [
+   '-wmgUsePopups' => [
'default' => true,
],
 

-- 
To view, visit https://gerrit.wikimedia.org/r/373531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I840858eb06ae1f1f01b1cef178cbe59d33df00df
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Enable A/B test (BC-only)

2017-08-23 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373264 )

Change subject: pagePreviews: Enable A/B test (BC-only)
..

pagePreviews: Enable A/B test (BC-only)

Enable anonymous user bucket on all wikis but only enable the
EventLogging instrumentation on enwiki (so that we can prove that the
kill switch works).

Bug: T171853
Change-Id: I85c3fcfdbca8b0d634995f95a93bacf72248eb9d
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 26 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/64/373264/1

diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index c20bd91..799138c 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -553,19 +553,9 @@
'default' => true,
],
 
-   // T165018: Make Page Previews (Popups) use RESTBase's page 
summary endpoint
-   // and consume the HTML returned.
-   'wgPopupsGateway' => [
-   'default' => 'restbaseHTML',
-   ],
+   // TODO:
+   // - Tidy up config
 
-   // To allow us to test EventLogging in the beta cluster we log 
all events
-   'wgPopupsSchemaSamplingRate' => [
-   'default' => 1,
-   ],
-   'wgPopupsStatsvSamplingRate' => [
-   'default' => 1,
-   ],
'wgEnableRcFiltersBetaFeature' => [
'default' => true,
],
@@ -577,10 +567,33 @@
'wmgUsePopups' => [
'default' => true,
],
+
'wmgPopupsBetaFeature' => [
'default' => false,
],
-   'wgPopupsAnonsEnabledSamplingRate' => [
+
+   // T171853: For 25% of anonymous user sessions, Page Previews 
will be
+   // enabled by default as well as the instrumentation; for 25%, 
PP will be
+   // disabled by default; for 50%, PP will be disabled as will the
+   // instrumentation.
+   'wgPopupsAnonsExperimentalGroupSize' => [
+   'default' => 0.25,
+   ],
+
+   // T171853: Enable PP EventLogging instrumentation on enwiki 
only so that we
+   // can prove the killswitch works.
+   'wgPopupsEventLogging' => [
+   'default' => false,
+   'enwiki' => true,
+   ],
+
+   // T165018: Make Page Previews (Popups) use RESTBase's page 
summary endpoint
+   // and consume the HTML returned.
+   'wgPopupsGateway' => [
+   'default' => 'restbaseHTML',
+   ],
+
+   'wgPopupsStatsvSamplingRate' => [
'default' => 1,
],
 

-- 
To view, visit https://gerrit.wikimedia.org/r/373264
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I85c3fcfdbca8b0d634995f95a93bacf72248eb9d
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: relatedArticles: Tidy up config

2017-08-22 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373043 )

Change subject: relatedArticles: Tidy up config
..

relatedArticles: Tidy up config

The sidebar feature has been removed, meaning that Related Articles now
always operates as if wgRelatedArticlesShowInFooter were true.

We can now safely remove the ShowIn* config variables.

Bug: T165991
Change-Id: Ia79435a9f15b84b542875387d66c27b6e3a5d004
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
2 files changed, 4 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/43/373043/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 2b98209..01a18e3 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -2945,13 +2945,10 @@
 
 if ( $wmgUseRelatedArticles ) {
wfLoadExtension( 'RelatedArticles' );
-   if ( $wmgRelatedArticlesShowInFooter ) {
-   $wgRelatedArticlesShowInSidebar = false;
-   $wgRelatedArticlesShowInFooter = true;
-   $wgRelatedArticlesLoggingBucketSize = 0.01;
-   $wgRelatedArticlesUseCirrusSearch = 
$wmgRelatedArticlesUseCirrusSearch;
-   $wgRelatedArticlesOnlyUseCirrusSearch = false;
-   }
+
+   $wgRelatedArticlesLoggingBucketSize = 0.01;
+   $wgRelatedArticlesUseCirrusSearch = $wmgRelatedArticlesUseCirrusSearch;
+   $wgRelatedArticlesOnlyUseCirrusSearch = false;
 }
 
 // Workaround for T142663 - override flat arrays
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 1d2e5f2..0c4fe05 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -17630,10 +17630,6 @@
'frwikinews' => true, // T143480
 ],
 
-'wmgRelatedArticlesShowInFooter' => [
-   'default' => true, // T164391, T143480
-],
-
 'wgRelatedArticlesCardLimit' => [
'default' => 3,
'wikivoyage' => 9,

-- 
To view, visit https://gerrit.wikimedia.org/r/373043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia79435a9f15b84b542875387d66c27b6e3a5d004
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Deploy to next 100 stage 1 wikis

2017-08-16 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372137 )

Change subject: pagePreviews: Deploy to next 100 stage 1 wikis
..

pagePreviews: Deploy to next 100 stage 1 wikis

Note well that the dewiki and enwiki entries have been removed from the
pp_stage1 dblist to be certain that this change doesn't affect those
wikis.

Bug: T162672
Change-Id: I4e3b340cd14a4a44ce8f3e18599f288ecc9246d2
---
M dblists/pp_stage1.dblist
1 file changed, 100 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/37/372137/1

diff --git a/dblists/pp_stage1.dblist b/dblists/pp_stage1.dblist
index b102441..5f49fa9 100644
--- a/dblists/pp_stage1.dblist
+++ b/dblists/pp_stage1.dblist
@@ -1,6 +1,6 @@
-# Generated with:
+# Generated with:
 #
-#   ./multiversion/bin/expanddblist dblists/pp_stage1_raw.dblist | tail -n 297 
| head -n 50 > dblists/pp_stage1.dblist
+#   ./multiversion/bin/expanddblist dblists/pp_stage1_raw.dblist | tail -n 302 
| head -n 50 > dblists/pp_stage1.dblist
 aawiki
 abwiki
 acewiki
@@ -21,6 +21,7 @@
 arzwiki
 astwiki
 aswiki
+atjwiki
 avwiki
 aywiki
 azbwiki
@@ -51,3 +52,100 @@
 chrwiki
 chwiki
 chywiki
+ckbwiki
+cowiki
+crhwiki
+crwiki
+csbwiki
+cswiki
+cuwiki
+cvwiki
+cywiki
+dawiki
+dinwiki
+diqwiki
+dsbwiki
+dtywiki
+dvwiki
+dzwiki
+eewiki
+emlwiki
+eowiki
+eswiki
+etwiki
+euwiki
+extwiki
+fawiki
+ffwiki
+fiu_vrowiki
+fiwiki
+fjwiki
+fowiki
+frpwiki
+frrwiki
+frwiki
+furwiki
+fywiki
+gagwiki
+ganwiki
+gawiki
+gdwiki
+glkwiki
+glwiki
+gnwiki
+gomwiki
+gotwiki
+guwiki
+gvwiki
+hakwiki
+hawiki
+hawwiki
+hifwiki
+hiwiki
+howiki
+hrwiki
+hsbwiki
+htwiki
+hywiki
+hzwiki
+iawiki
+idwiki
+iewiki
+igwiki
+iiwiki
+ikwiki
+ilowiki
+iowiki
+iswiki
+iuwiki
+jamwiki
+jawiki
+jbowiki
+jvwiki
+kaawiki
+kabwiki
+kawiki
+kbdwiki
+kbpwiki
+kgwiki
+kiwiki
+kjwiki
+kkwiki
+klwiki
+kmwiki
+knwiki
+koiwiki
+kowiki
+krcwiki
+krwiki
+kshwiki
+kswiki
+kuwiki
+kvwiki
+kwwiki
+kywiki
+ladwiki
+lawiki
+lbewiki
+lbwiki
+lezwiki

-- 
To view, visit https://gerrit.wikimedia.org/r/372137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e3b340cd14a4a44ce8f3e18599f288ecc9246d2
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Deploy to first 50 of stage 1 wikis

2017-08-03 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369960 )

Change subject: pagePreviews: Deploy to first 50 of stage 1 wikis
..

pagePreviews: Deploy to first 50 of stage 1 wikis

Add the pp_stage2 and pp_stage1_computed dblists, which represent the
following:

* pp_stage2: The set of wikis that we're not deploying to in the
  near feature.
* pp_stage1_computed: The set of wikis that aren't in either pp_stage0
  or pp_stage2.

Add the pp_stage1.dblist, which is the set of the first 50 wikis
from the expanded pp_stage1_computed dblist.

Enable Page Previews by default for the wikis in the pp_stage1 dblist.

Bug: T162672
Change-Id: I3963e8eae708ba367dc321d62fa383643dccee17
---
A dblists/pp_stage1.dblist
A dblists/pp_stage1_computed.dblist
A dblists/pp_stage2.dblist
M wmf-config/InitialiseSettings.php
4 files changed, 69 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/60/369960/1

diff --git a/dblists/pp_stage1.dblist b/dblists/pp_stage1.dblist
new file mode 100644
index 000..c5c3087
--- /dev/null
+++ b/dblists/pp_stage1.dblist
@@ -0,0 +1,53 @@
+# Generated with:
+#
+#   ./multiversion/bin/expanddblist dblists/pp_stage1_computed.dblist | tail 
-n 297 | head -n 50 > dblists/pp_stage1.dblist
+aawiki
+abwiki
+acewiki
+adywiki
+afwiki
+akwiki
+alswiki
+amwiki
+angwiki
+anwiki
+arbcom_cswiki
+arbcom_dewiki
+arbcom_enwiki
+arbcom_fiwiki
+arbcom_nlwiki
+arcwiki
+arwiki
+arzwiki
+astwiki
+aswiki
+avwiki
+aywiki
+azbwiki
+azwiki
+barwiki
+bat_smgwiki
+bawiki
+bclwiki
+be_x_oldwiki
+bewiki
+bgwiki
+bhwiki
+biwiki
+bjnwiki
+bmwiki
+bnwiki
+bowiki
+bpywiki
+brwiki
+bswiki
+bugwiki
+bxrwiki
+cbk_zamwiki
+cdowiki
+cebwiki
+cewiki
+chowiki
+chrwiki
+chwiki
+chywiki
diff --git a/dblists/pp_stage1_computed.dblist 
b/dblists/pp_stage1_computed.dblist
new file mode 100644
index 000..029b2a9
--- /dev/null
+++ b/dblists/pp_stage1_computed.dblist
@@ -0,0 +1 @@
+%% wikipedia.dblist - pp_stage0.dblist - pp_stage2.dblist
diff --git a/dblists/pp_stage2.dblist b/dblists/pp_stage2.dblist
new file mode 100644
index 000..046910d
--- /dev/null
+++ b/dblists/pp_stage2.dblist
@@ -0,0 +1,2 @@
+enwiki
+dewiki
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 09e3c04..533d40f 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -13503,9 +13503,10 @@
'default' => false,
'sewikimedia' => true, // T68374
 
-   // T136602, T162162: Make Page Previews enabled by default for the 
stage 0
-   // wikis.
+   // T136602, T162162, T162672: Make Page Previews enabled by default for 
the
+   // stage 0 and stage 1 wikis.
'pp_stage0' => true,
+   'pp_stage1' => true,
 ],
 
 'wgPopupsPageBlacklist' => [
@@ -13538,14 +13539,19 @@
// T136602: Make Page Previews enabled by default for 90% of anon users 
for
// the stage 0 wikis.
'pp_stage0' => 0.9,
+
+   // T162672: Make Page Previews enabled by default for the stage 1 wikis.
+   'pp_stage1' => 1,
 ],
 
 'wmgPopupsBetaFeature' => [
'default' => true,
 
-   // Explicitly disable Page Previews as a beta feature for the stage 0 
wikis
-   // (reflecting that it's enabled in the wmgUsePopups section above).
+   // Explicitly disable Page Previews as a beta feature for the stage 0 
and
+   // stage 1 wikis (reflecting that it's enabled in the wmgUsePopups 
section
+   // above).
'pp_stage0' => false,
+   'pp_stage1' => false,
 
'wikidatawiki' => false,
'wiktionary' => false,
@@ -13587,8 +13593,10 @@
 'wgPopupsGateway' => [
'default' => 'mwApiPlain',
 
-   // Make Page Previews use RESTBase for the following stage 0 wikis.
+   // Make Page Previews use RESTBase for the following stage 0 and stage 1
+   // wikis.
'pp_stage0' => 'restbasePlain',
+   'pp_stage1' => 'restbasePlain',
 ],
 
 // T160081 (and others): Make sure that Page Previews can detect the many, many

-- 
To view, visit https://gerrit.wikimedia.org/r/369960
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3963e8eae708ba367dc321d62fa383643dccee17
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Increase i13n sampling rate for ruwiki

2017-07-24 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367398 )

Change subject: pagePreviews: Increase i13n sampling rate for ruwiki
..

pagePreviews: Increase i13n sampling rate for ruwiki

Correct the typo in I0b2752f4 that meant ruwiki didn't have the
increased sampling rate.

Bug: T171325
Change-Id: Ia747b39a5c89f9e347f1e880adb22966d31512f8
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/98/367398/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index e237a2b..d8c619c 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -13494,7 +13494,7 @@
// * See $wmgUsePopups above for the definition of "stage 0".
'itwiki' => 0.01,
'huwiki' => 0.01,
-   'itwiki' => 0.01,
+   'ruwiki' => 0.01,
 ],
 
 'wgPopupsStatsvSamplingRate' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/367398
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia747b39a5c89f9e347f1e880adb22966d31512f8
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Increase instrumentation sampling rate

2017-07-21 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366882 )

Change subject: pagePreviews: Increase instrumentation sampling rate
..

pagePreviews: Increase instrumentation sampling rate

... for itwiki, huwiki, and ruwiki to 1% of all distinct browser
sessions so that the analysis of data from the state 0 wikis can be
expedited.

The current sampling rate yields ~1 event logged per second. We can
safely increase this to 10.

Bug: T171325
Change-Id: I0b2752f4dc2ad387f6857e3b51edecc9e06078bd
---
M wmf-config/InitialiseSettings.php
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/82/366882/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 6d7302b..e237a2b 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -13485,6 +13485,16 @@
// current rate of Popups events being logged:
// 
https://grafana.wikimedia.org/dashboard/db/eventlogging-schema?var-schema=Popups
'default' => 0.001,
+
+   // T171325: Increase the per-session sampling rate of the Page Previews
+   // EventLogging instrumentation to 1% of all distinct browser sessions 
so
+   // that analysis of the stage 0* test can be completed in a reasonable 
amount
+   // of time.
+   //
+   // * See $wmgUsePopups above for the definition of "stage 0".
+   'itwiki' => 0.01,
+   'huwiki' => 0.01,
+   'itwiki' => 0.01,
 ],
 
 'wgPopupsStatsvSamplingRate' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/366882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b2752f4dc2ad387f6857e3b51edecc9e06078bd
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Revert "Stop RelatedArticles A/B test and clean up c...

2017-07-20 Thread Phuedx (Code Review)

Hello jenkins-bot, Dereckson,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/366546

to review the following change.


Change subject: Revert "Revert "Stop RelatedArticles A/B test and clean up 
config""
..

Revert "Revert "Stop RelatedArticles A/B test and clean up config""

This reverts commit d4518868774791aafd5fcd4eddfa10cf8f764c6f.

Bug: T169948
Change-Id: I75142d594f7e4fe5c5c8ba4f05bee8a2f45b11f1
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
2 files changed, 0 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/46/366546/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index d213a1c..8743c6f 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -2907,11 +2907,6 @@
$wgRelatedArticlesLoggingBucketSize = 0.01;
$wgRelatedArticlesUseCirrusSearch = 
$wmgRelatedArticlesUseCirrusSearch;
$wgRelatedArticlesOnlyUseCirrusSearch = false;
-
-   // T167236: Maintain backwards compatibility with the currently 
deployed
-   // version of RelatedArticles.
-   $wgRelatedArticlesEnabledSamplingRate = 
$wgRelatedArticlesEnabledBucketSize;
-   $wgRelatedArticlesLoggingSamplingRate = 
$wgRelatedArticlesLoggingBucketSize;
}
 }
 
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index bee4534..813a8c8 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -17474,16 +17474,8 @@
'related-articles-footer-blacklisted-skins' => [],
 ],
 
-'wgRelatedArticlesEnabledSamplingRate' => [
-   'default' => 1,
-   // T167310
-   'enwiki' => 0.98,
-],
-
 'wgRelatedArticlesEnabledBucketSize' => [
'default' => 1,
-   // T167310
-   'enwiki' => 0.98,
 ],
 
 'wmgUseRelatedSites' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/366546
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I75142d594f7e4fe5c5c8ba4f05bee8a2f45b11f1
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 
Gerrit-Reviewer: Dereckson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: i13n: popupEnabled = false for disabled event

2017-07-19 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366287 )

Change subject: i13n: popupEnabled = false for disabled event
..

i13n: popupEnabled = false for disabled event

... for consistency with the server-sent disabled event introduced in
I63faecb0.

Bug: T167365
Change-Id: I3a96df5279f6f0f4e573765735ab0e1fc6f406a8
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
M tests/node-qunit/reducers/eventLogging.test.js
4 files changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/87/366287/1


-- 
To view, visit https://gerrit.wikimedia.org/r/366287
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a96df5279f6f0f4e573765735ab0e1fc6f406a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Enable page previews for everyone on labs"

2017-07-18 Thread Phuedx (Code Review)

Hello Florianschmidtwelzow, jenkins-bot, Jdlrobson,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/365943

to review the following change.


Change subject: Revert "Enable page previews for everyone on labs"
..

Revert "Enable page previews for everyone on labs"

This reverts commit 74332e2191ef629874c3c2ec6a2db6bda8461d05.

Change-Id: I7b8f33ab97931774532f6febf0b3a25e8c28e74c
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/43/365943/1

diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index eaa6ac4..000cf4d 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -601,14 +601,6 @@
'default' => true,
],
 
-   // Enable page previews for everyone in labs (T162672)
-   'wgPopupsAnonsEnabledSamplingRate' => [
-   'default' => 1,
-   ],
-   'wmgPopupsBetaFeature' => [
-   'default' => false,
-   ],
-
'wmgUseCollaborationKit' => [
'default' => false,
'enwiki' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/365943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b8f33ab97931774532f6febf0b3a25e8c28e74c
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Log all events for page previews in beta cluster"

2017-07-18 Thread Phuedx (Code Review)

Hello Florianschmidtwelzow, jenkins-bot, Jdlrobson,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/365941

to review the following change.


Change subject: Revert "Log all events for page previews in beta cluster"
..

Revert "Log all events for page previews in beta cluster"

This reverts commit e170b8109139fdc522db7c3fb24f66b2f22db9a2.

Change-Id: I04d34be830c1c5f6e11ebb47b5940f1e378b89d1
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 0 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/41/365941/1

diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index 000cf4d..91825c0 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -590,13 +590,6 @@
'default' => 'restbaseHTML',
],
 
-   // To allow us to test EventLogging in the beta cluster we log 
all events
-   'wgPopupsSchemaSamplingRate' => [
-   'default' => 1,
-   ],
-   'wgPopupsStatsvSamplingRate' => [
-   'default' => 1,
-   ],
'wgEnableRcFiltersBetaFeature' => [
'default' => true,
],

-- 
To view, visit https://gerrit.wikimedia.org/r/365941
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I04d34be830c1c5f6e11ebb47b5940f1e378b89d1
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Re-enable Popups extension on Beta Cluster

2017-07-18 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365939 )

Change subject: pagePreviews: Re-enable Popups extension on Beta Cluster
..

pagePreviews: Re-enable Popups extension on Beta Cluster

Following on from I8077cb35, wmgUsePopups must be true for the Popups
extension to be loaded.

Bug: T167365
Change-Id: I893c54a068361d167d8602670344853f179bad0d
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/39/365939/1

diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index eaa6ac4..8ea5248 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -602,12 +602,18 @@
],
 
// Enable page previews for everyone in labs (T162672)
-   'wgPopupsAnonsEnabledSamplingRate' => [
-   'default' => 1,
+   //
+   // Note well that the Popups extension is only loaded when 
either
+   // wmgUsePopups or wmgPopupsBetaFeature is truthy.
+   'wmgUsePopups' => [
+   'default' => true,
],
'wmgPopupsBetaFeature' => [
'default' => false,
],
+   'wgPopupsAnonsEnabledSamplingRate' => [
+   'default' => 1,
+   ],
 
'wmgUseCollaborationKit' => [
'default' => false,

-- 
To view, visit https://gerrit.wikimedia.org/r/365939
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I893c54a068361d167d8602670344853f179bad0d
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[wmf/1.30.0-wmf.7]: Don't subscribe EventLogging twice if window.onload fires twice

2017-07-11 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364389 )

Change subject: Don't subscribe EventLogging twice if window.onload fires twice
..

Don't subscribe EventLogging twice if window.onload fires twice

Do not subscribe again on subsequent load events.

Bug: T170018
Change-Id: I21b60a581b9dd3c4f4473c711941b6c28f7f7f0e
---
M modules/ext.eventLogging.subscriber.js
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/89/364389/1

diff --git a/modules/ext.eventLogging.subscriber.js 
b/modules/ext.eventLogging.subscriber.js
index e569ae7..28ea1b7 100644
--- a/modules/ext.eventLogging.subscriber.js
+++ b/modules/ext.eventLogging.subscriber.js
@@ -87,7 +87,13 @@
 
};
 
-   $( window ).on( 'load', function () {
+   // Avoid the logging of duplicate events (T170018).
+   //
+   // The load event must only fire once. However, Firefox 51 introduced a
+   // bug that causes the event to fire again when returning from the
+   // "Back-Forward cache" (BFCache) under certain circumstances (see
+   // https://bugzilla.mozilla.org/show_bug.cgi?id=1379762).
+   $( window ).one( 'load', function () {
mw.trackSubscribe( 'event.', handleTrackedEvent );
} );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/364389
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21b60a581b9dd3c4f4473c711941b6c28f7f7f0e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: wmf/1.30.0-wmf.7
Gerrit-Owner: Phuedx 
Gerrit-Reviewer: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove wgMFTidyMobileViewSections

2017-07-10 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364230 )

Change subject: Hygiene: Remove wgMFTidyMobileViewSections
..

Hygiene: Remove wgMFTidyMobileViewSections

wgMFTidyMobileViewSections was unconditionally set to false on all
production wikis in I35bdf93b. The concern that the apps could handle
untidy (imbalanced) HTML in the mobileview response is now moot as they
consume the Mobile Content Service family of services, which transform
and return valid HTML5 from Parsoid.

Bug: T168671
Change-Id: I4c8f5437dc25eec8f1ea1d87468ca01566460334
---
M README.md
M extension.json
M includes/api/ApiMobileView.php
3 files changed, 2 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/30/364230/1

diff --git a/README.md b/README.md
index d6f7a38..4569ab7 100644
--- a/README.md
+++ b/README.md
@@ -219,14 +219,6 @@
 * Type: `Boolean`
 * Default: `false`
 
- $wgMFTidyMobileViewSections
-
-Controls whether API `action=mobileview` should have every HTML section tidied
-for invalid markup.
-
-* Type: `Boolean`
-* Default: `true`
-
  $wgMFMobileHeader
 
 Requests containing header with this name will be considered as coming from
diff --git a/extension.json b/extension.json
index 1abf146..95c150e 100644
--- a/extension.json
+++ b/extension.json
@@ -1775,7 +1775,6 @@
],
"MFSpecialCaseMainPage": false,
"MinervaEnableSiteNotice": false,
-   "MFTidyMobileViewSections": true,
"MFMobileHeader": "X-Subdomain",
"MFRemovableClasses": {
"beta": [],
diff --git a/includes/api/ApiMobileView.php b/includes/api/ApiMobileView.php
index bec4f2c..daa6ca4 100644
--- a/includes/api/ApiMobileView.php
+++ b/includes/api/ApiMobileView.php
@@ -495,7 +495,6 @@
 * @param string $html representing the entire page
 * @param Title $title
 * @param ParserOutput $parserOutput
-* @param boolean $useTidy whether the provided HTML should be tidied 
(optional)
 * @param integer $revId this is a temporary parameter to avoid debug 
log warnings.
 *  Long term the call to wfDebugLog should be moved outside this 
method (optional)
 * @return array structure representing the list of sections and their 
properties:
@@ -505,9 +504,7 @@
 *  - text: [] of the text of each individual section. length === same 
as sections
 *  or of length 1 when there is a mismatch.
 */
-   protected function parseSectionsData( $html, Title $title, ParserOutput 
$parserOutput,
-   $useTidy = false, $revId = null
-   ) {
+   protected function parseSectionsData( $html, Title $title, ParserOutput 
$parserOutput, $revId = null ) {
$data = [];
$data['sections'] = $parserOutput->getSections();
$sectionCount = count( $data['sections'] );
@@ -528,9 +525,6 @@
foreach ( $chunks as $chunk ) {
if ( count( $data['text'] ) ) {
$chunk = " 1 ) {
-   $chunk = MWTidy::tidy( $chunk );
}
if ( preg_match( '/]*?class="references"/', 
$chunk ) ) {
$data['refsections'][count( $data['text'] )] = 
true;
@@ -645,9 +639,7 @@
'refsections' => [],
];
} else {
-   $useTidy = $this->getConfig()->get( 'TidyConfig' ) !== 
null
-   && $mfConfig->get( 'MFTidyMobileViewSections' );
-   $data = $this->parseSectionsData( $html, $title, 
$parserOutput, $useTidy, $latest );
+   $data = $this->parseSectionsData( $html, $title, 
$parserOutput, $latest );
if ( $this->usePageImages ) {
$image = $this->getPageImage( $title );
if ( $image ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/364230
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c8f5437dc25eec8f1ea1d87468ca01566460334
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[master]: WIP

2017-07-10 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364188 )

Change subject: WIP
..

WIP

Change-Id: I348079ee80e1d27f9dd70c0340237edc8d0371b0
---
M modules/ext.eventLogging.subscriber.js
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/88/364188/1

diff --git a/modules/ext.eventLogging.subscriber.js 
b/modules/ext.eventLogging.subscriber.js
index e569ae7..2e496b0 100644
--- a/modules/ext.eventLogging.subscriber.js
+++ b/modules/ext.eventLogging.subscriber.js
@@ -7,6 +7,8 @@
  * @author Ori Livneh 
  */
 ( function ( mw, $ ) {
+   console.log( 'READY' );
+
var pageViewToken = mw.user.generateRandomSessionId();
 
/**
@@ -88,6 +90,8 @@
};
 
$( window ).on( 'load', function () {
+   console.log( 'LOAD' );
+
mw.trackSubscribe( 'event.', handleTrackedEvent );
} );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/364188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I348079ee80e1d27f9dd70c0340237edc8d0371b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: i13n: Return false over not sampling

2017-07-03 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362977 )

Change subject: Hygiene: i13n: Return false over not sampling
..

Hygiene: i13n: Return false over not sampling

Previously, if the browser didn't support the Beacon API, then
instrumentation/eventLogging#isEnabled would bucket the user with a
sampling rate of 0, which is equivalent to returning false. This change
simply does the latter.

Additional changes:
* Update the documented module names of the instrumentation/eventLogging
  and statsv modules.

Bug: T168847
Change-Id: I7ae5c10da42ca614b5b1a6619f9555e5665344cf
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/instrumentation/eventLogging.js
M src/instrumentation/statsv.js
M tests/node-qunit/instrumentation/eventLogging.test.js
5 files changed, 8 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/77/362977/1


-- 
To view, visit https://gerrit.wikimedia.org/r/362977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ae5c10da42ca614b5b1a6619f9555e5665344cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: i13n: Update MobileOptionsTracking schema rev

2017-06-27 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/361643 )

Change subject: i13n: Update MobileOptionsTracking schema rev
..

i13n: Update MobileOptionsTracking schema rev

The images property has now been removed from the MobileOptionsTracking
schema [0].

[0] 
https://meta.wikimedia.org/w/index.php?title=Schema%3AMobileOptionsTracking=revision=16934032=16895873

Bug: T109870
Change-Id: I3a0883d00286a6a73a4e1a6961b36743bfd2eb17
---
M includes/specials/SpecialMobileOptions.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/43/361643/1

diff --git a/includes/specials/SpecialMobileOptions.php 
b/includes/specials/SpecialMobileOptions.php
index 5fee143..14216ca 100644
--- a/includes/specials/SpecialMobileOptions.php
+++ b/includes/specials/SpecialMobileOptions.php
@@ -231,7 +231,7 @@
 */
private function submitSettingsForm() {
$schema = 'MobileOptionsTracking';
-   $schemaRevision = 14003392;
+   $schemaRevision = 16934032;
$schemaData = [
'action' => 'success',
'images' => "nochange",

-- 
To view, visit https://gerrit.wikimedia.org/r/361643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a0883d00286a6a73a4e1a6961b36743bfd2eb17
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Hygiene: SamplingRate -> BucketSize

2017-06-19 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/360165 )

Change subject: Hygiene: SamplingRate -> BucketSize
..

Hygiene: SamplingRate -> BucketSize

In order to avoid further confusion, clarify that we're bucketing users
for experiments.

Bug: T167236
Depends-On: I752cdf068ca25bffb38229380785e7da1a208049
Change-Id: I6508ab8fa3d436ae295eb047e170fdc5417d25fc
---
M extension.json
M includes/FooterHooks.php
M resources/ext.relatedArticles.readMore.bootstrap/index.js
M resources/ext.relatedArticles.readMore.eventLogging/index.js
M tests/browser/LocalSettings.php
5 files changed, 18 insertions(+), 21 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles 
refs/changes/65/360165/1

diff --git a/extension.json b/extension.json
index b256e7b..eb217f2 100644
--- a/extension.json
+++ b/extension.json
@@ -166,8 +166,8 @@
"RelatedArticlesShowInFooter": false,
"RelatedArticlesUseCirrusSearch": false,
"RelatedArticlesOnlyUseCirrusSearch": false,
-   "RelatedArticlesLoggingSamplingRate": 0.01,
-   "RelatedArticlesEnabledSamplingRate": 1,
+   "RelatedArticlesLoggingBucketSize": 0.01,
+   "RelatedArticlesEnabledBucketSize": 1,
"@RelatedArticlesFooterWhitelistedSkins": "List of skin names 
(e.g. 'minerva') where related articles will be shown in the footer.",
"RelatedArticlesFooterWhitelistedSkins": [ "minerva" ]
},
diff --git a/includes/FooterHooks.php b/includes/FooterHooks.php
index 61ac275..c19f506 100644
--- a/includes/FooterHooks.php
+++ b/includes/FooterHooks.php
@@ -158,10 +158,10 @@
public static function onResourceLoaderGetConfigVars( &$vars ) {
$config = MediaWikiServices::getInstance()->getConfigFactory()
->makeConfig( 'RelatedArticles' );
-   $vars['wgRelatedArticlesLoggingSamplingRate'] =
-   $config->get( 'RelatedArticlesLoggingSamplingRate' );
-   $vars['wgRelatedArticlesEnabledSamplingRate']
-   = $config->get( 'RelatedArticlesEnabledSamplingRate' );
+   $vars['wgRelatedArticlesLoggingBucketSize'] =
+   $config->get( 'RelatedArticlesLoggingBucketSize' );
+   $vars['wgRelatedArticlesEnabledBucketSize']
+   = $config->get( 'RelatedArticlesEnabledBucketSize' );
return true;
}
 
diff --git a/resources/ext.relatedArticles.readMore.bootstrap/index.js 
b/resources/ext.relatedArticles.readMore.bootstrap/index.js
index 953a811..1c01ae4 100644
--- a/resources/ext.relatedArticles.readMore.bootstrap/index.js
+++ b/resources/ext.relatedArticles.readMore.bootstrap/index.js
@@ -15,26 +15,25 @@
shouldShowReadMore;
 
/**
-* Is RelatedArticles extension enabled for current user
+* Gets whether the feature is enabled for the user.
 *
-* Returns true if the user opted into the beta feature, otherwise
-* user's session ID is used to determine the eligibility for 
RelatedArticles functionality,
-* based on the value of wgRelatedArticlesEnabledSamplingRate
-* thus the function will result the same outcome as long as the browser
-* hasn't been restarted or the cookie hasn't been cleared.
+* The user's session ID is used to determine the eligibility for
+* RelatedArticles functionality, based on the value of
+* `$wgRelatedArticlesEnabledBucketSize`. The result of the function 
will be
+* the same for the duration of their session.
 *
 * @return {boolean}
 */
function isEnabledForCurrentUser() {
var bucket,
-   samplingRate = mw.config.get( 
'wgRelatedArticlesEnabledSamplingRate', 1 );
+   bucketSize = mw.config.get( 
'wgRelatedArticlesEnabledBucketSize', 1 );
 
bucket = mw.experiments.getBucket( {
name: 'ext.relatedArticles.visibility',
enabled: true,
buckets: {
-   control: 1 - samplingRate,
-   A: samplingRate
+   control: 1 - bucketSize,
+   A: bucketSize
}
}, mw.user.sessionId() );
return bucket === 'A';
diff --git a/resources/ext.relatedArticles.readMore.eventLogging/index.js 
b/resources/ext.relatedArticles.readMore.eventLogging/index.js
index 87ec230..004c492 100644
--- a/resources/ext.relatedArticles.readMore.eventLogging/index.js
+++ b/resources/ext.relatedArticles.readMore.eventLogging/index.js
@@ -25,9 +25,7 @@
 * @return {boolean}
 */
function isEnabledForCurrentUser() {

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: relatedArticles: SamplingRate -> BucketSize

2017-06-19 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/360166 )

Change subject: relatedArticles: SamplingRate -> BucketSize
..

relatedArticles: SamplingRate -> BucketSize

In order to avoid further confusion, clarify that we're bucketing users
for experiments.

Bug: T167236
Change-Id: I752cdf068ca25bffb38229380785e7da1a208049
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings-labs.php
M wmf-config/InitialiseSettings.php
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/66/360166/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 61f8902..9bcffe8 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -2891,7 +2891,7 @@
if ( $wmgRelatedArticlesShowInFooter ) {
$wgRelatedArticlesShowInSidebar = false;
$wgRelatedArticlesShowInFooter = true;
-   $wgRelatedArticlesLoggingSamplingRate = 0.01;
+   $wgRelatedArticlesLoggingBucketSize = 0.01;
$wgRelatedArticlesUseCirrusSearch = 
$wmgRelatedArticlesUseCirrusSearch;
$wgRelatedArticlesOnlyUseCirrusSearch = false;
}
diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index 18c57f2..dceff2d 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -359,7 +359,7 @@
'wmgUseRelatedArticles' => [
'default' => true,
],
-   'wgRelatedArticlesEnabledSamplingRate' => [
+   'wgRelatedArticlesEnabledBucketSize' => [
'default' => 1,
'enwiki' => 1,
],
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 0b7412b..a55226c 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -17299,7 +17299,7 @@
'related-articles-footer-blacklisted-skins' => [],
 ],
 
-'wgRelatedArticlesEnabledSamplingRate' => [
+'wgRelatedArticlesEnabledBucketSize' => [
'default' => 1,
// T167310
'enwiki' => 0.98,

-- 
To view, visit https://gerrit.wikimedia.org/r/360166
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I752cdf068ca25bffb38229380785e7da1a208049
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: i13n: Don't sample by pageview

2017-06-19 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/359921 )

Change subject: i13n: Don't sample by pageview
..

i13n: Don't sample by pageview

Currently, the mw.eventLog.Schema class samples per pageview. However,
we expect that if a user is bucketed for a session, then all
EventLogging events logged during that session are in the sample.

Unlike Popups in I4f653bba, the RelatedArticles instrumentation does
rely on another mw.eventLog.Schema behavior: distinguishing between
static and dynamic data. This and the use of mw.eventLog.Schema could be
removed in a follow-on change.

Bug: T167236
Change-Id: I9583cb98264efd7dc46b45bbce5323036a100536
---
M resources/ext.relatedArticles.readMore.eventLogging/index.js
1 file changed, 57 insertions(+), 13 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles 
refs/changes/21/359921/1

diff --git a/resources/ext.relatedArticles.readMore.eventLogging/index.js 
b/resources/ext.relatedArticles.readMore.eventLogging/index.js
index afe721b..87ec230 100644
--- a/resources/ext.relatedArticles.readMore.eventLogging/index.js
+++ b/resources/ext.relatedArticles.readMore.eventLogging/index.js
@@ -5,9 +5,65 @@
skin = mw.config.get( 'skin' ),
$window = $( window );
 
-   if ( !$.isFunction( navigator.sendBeacon ) ) {
+   /**
+* Gets whether the UA supports [the Beacon API][0].
+*
+* [0]: https://www.w3.org/TR/beacon/
+*
+* @return {boolean}
+*/
+   function supportsBeacon() {
+   return $.isFunction( window.navigator.sendBeacon );
+   }
+
+   /**
+* Gets whether the instrumentation is enabled for the user.
+*
+* We sample at the feature level, not by pageview. If the 
instrumentation is
+* enabled for the user, then it's enabled for the duration of their 
session.
+*
+* @return {boolean}
+*/
+   function isEnabledForCurrentUser() {
+
+   // TODO: Rename this and other instances to bucketingRate.
+   var samplingRate = mw.config.get( 
'wgRelatedArticlesLoggingSamplingRate', 0 );
+
+   if ( !supportsBeacon() ) {
+   return false;
+   }
+
+   return mw.experiments.getBucket( {
+   name: 'ext.relatedArticles.instrumentation',
+   enabled: true,
+   buckets: {
+   control: 1 - samplingRate,
+   A: samplingRate
+   }
+   }, mw.user.sessionId() ) === 'A';
+   }
+
+   if ( !isEnabledForCurrentUser() ) {
return;
}
+
+   // ---
+   // BEGIN INSTRUMENTATION
+   // ---
+
+   schemaRelatedPages = new mw.eventLog.Schema(
+   'RelatedArticles',
+
+   // The instrumentation is enabled for the user's session. DON'T 
SAMPLE AT
+   // THE EVENT LEVEL.
+   1,
+
+   {
+   pageId: mw.config.get( 'wgArticleId' ),
+   skin: ( skin === 'minerva' ) ? skin + '-' + 
mw.config.get( 'wgMFMode' ) : skin,
+   userSessionToken: mw.user.sessionId()
+   }
+   );
 
/**
 * Log when ReadMore is seen by the user
@@ -18,18 +74,6 @@
schemaRelatedPages.log( { eventName: 'seen' } );
}
}
-
-   schemaRelatedPages = new mw.eventLog.Schema(
-   'RelatedArticles',
-   // not sampled if the config variable is not set
-   mw.config.get( 'wgRelatedArticlesLoggingSamplingRate', 0 ),
-   {
-   pageId: mw.config.get( 'wgArticleId' ),
-   skin: ( skin === 'minerva' ) ? skin + '-' + 
mw.config.get( 'wgMFMode' ) : skin,
-   // This should persist for a given user across their 
session.
-   userSessionToken: mw.user.sessionId()
-   }
-   );
 
mw.trackSubscribe( 'ext.relatedArticles.logEnabled', function ( _, data 
) {
schemaRelatedPages.log( {

-- 
To view, visit https://gerrit.wikimedia.org/r/359921
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9583cb98264efd7dc46b45bbce5323036a100536
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: experiments: Extract mediawiki.hash class

2017-06-19 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/359918 )

Change subject: experiments: Extract mediawiki.hash class
..

experiments: Extract mediawiki.hash class

mw.experiments uses a private implementation of the Jenkins
one-at-a-time hash function, whereas, say, the Resource Loader uses a
private implementation of the FNV-1 (32-bit) hash function [0]. The
FNV-1a hash function is also implemented separately in the Popups
extension [1].

Ideally, all three should use the same hash function and it should be
publicly available. To achieve these ends we'll:

1. Extract the private implementations of both hash functions;
2. Clarify the API, if necessary;
3. Update mw.experiments and Popups to use a hash function provided by
core.

This change is part of #1.

[0] 
https://github.com/wikimedia/mediawiki/blob/5604684b/resources/src/mediawiki/mediawiki.js#L24-L53
[1] 
https://github.com/wikimedia/mediawiki-extensions-Popups/blob/9ed1703c/src/changeListeners/eventLogging.js#L7-L29

Change-Id: Id2d5c4ac945a467d2beefbac9627ec99d35f7502
---
M resources/Resources.php
M resources/src/mediawiki/mediawiki.experiments.js
A resources/src/mediawiki/mediawiki.hash.js
3 files changed, 47 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/18/359918/1

diff --git a/resources/Resources.php b/resources/Resources.php
index f4149ea..3fd9e77 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1400,9 +1400,14 @@
'styles' => 'resources/src/mediawiki.toolbar/toolbar.less',
'dependencies' => 'jquery.textSelection',
],
+   'mediawiki.hash' => [
+   'scripts' => 'resources/src/mediawiki/mediawiki.hash.js',
+   'targets' => [ 'desktop', 'mobile' ],
+   ],
'mediawiki.experiments' => [
'scripts' => 'resources/src/mediawiki/mediawiki.experiments.js',
'targets' => [ 'desktop', 'mobile' ],
+   'dependencies' => 'mediawiki.hash',
],
 
/* MediaWiki Action */
diff --git a/resources/src/mediawiki/mediawiki.experiments.js 
b/resources/src/mediawiki/mediawiki.experiments.js
index 4fedbea..5173923 100644
--- a/resources/src/mediawiki/mediawiki.experiments.js
+++ b/resources/src/mediawiki/mediawiki.experiments.js
@@ -4,36 +4,6 @@
MAX_INT32_UNSIGNED = 4294967295;
 
/**
-* An implementation of Jenkins' one-at-a-time hash.
-*
-* @see https://en.wikipedia.org/wiki/Jenkins_hash_function
-*
-* @param {string} string String to hash
-* @return {number} The hash as a 32-bit unsigned integer
-* @ignore
-*
-* @author Ori Livneh 
-* @see https://jsbin.com/kejewi/4/watch?js,console
-*/
-   function hashString( string ) {
-   /* eslint-disable no-bitwise */
-   var hash = 0,
-   i = string.length;
-
-   while ( i-- ) {
-   hash += string.charCodeAt( i );
-   hash += ( hash << 10 );
-   hash ^= ( hash >> 6 );
-   }
-   hash += ( hash << 3 );
-   hash ^= ( hash >> 11 );
-   hash += ( hash << 15 );
-
-   return hash >>> 0;
-   /* eslint-enable no-bitwise */
-   }
-
-   /**
 * Provides an API for bucketing users in experiments.
 *
 * @class mw.experiments
@@ -93,7 +63,7 @@
range += buckets[ key ];
}
 
-   hash = hashString( experiment.name + ':' + token );
+   hash = mw.hash.jenkins( experiment.name + ':' + token );
max = ( hash / MAX_INT32_UNSIGNED ) * range;
 
for ( key in buckets ) {
diff --git a/resources/src/mediawiki/mediawiki.hash.js 
b/resources/src/mediawiki/mediawiki.hash.js
new file mode 100644
index 000..050a1e1
--- /dev/null
+++ b/resources/src/mediawiki/mediawiki.hash.js
@@ -0,0 +1,41 @@
+( function ( mw ) {
+
+   /**
+* Provides an API for hashing strings.
+*
+* @class mw.hash
+* @singleton
+*/
+   mw.hash = {
+
+   /**
+   * An implementation of [the Jenkins' one-at-a-time hash 
function][0]
+   *
+   * @param {string} string String to hash
+   * @return {number} The hash as a 32-bit unsigned integer
+   *
+   * @author Ori Livneh 
+   * @see https://jsbin.com/kejewi/4/watch?js,console
+   *
+   * [0]: https://en.wikipedia.org/wiki/Jenkins_hash_function
+   */
+   jenkins: function jenkins( string ) {
+   /* eslint-disable

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: RelatedArticles no longer depends on Cards

2017-06-15 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/359193 )

Change subject: RelatedArticles no longer depends on Cards
..

RelatedArticles no longer depends on Cards

Since I784fd132, the RelatedArticles extension no longer depends on the
Cards extension. Indeed, the Cards extension is soon to be undeployed.

Bug: T167452
Change-Id: I4cc211630f4f0fe9fa4cd0d6fe70f9bf1e6210ba
---
M puppet/modules/role/manifests/relatedarticles.pp
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/93/359193/1

diff --git a/puppet/modules/role/manifests/relatedarticles.pp 
b/puppet/modules/role/manifests/relatedarticles.pp
index 359a807..d3e3e1f 100644
--- a/puppet/modules/role/manifests/relatedarticles.pp
+++ b/puppet/modules/role/manifests/relatedarticles.pp
@@ -12,9 +12,6 @@
 wgRelatedArticlesShowInSidebar   => false,
 wgRelatedArticlesShowInFooter=> true,
 wgRelatedArticlesUseCirrusSearch => true,
-},
-require  => MediaWiki::Extension['Cards'],
+}
 }
-
-mediawiki::extension { 'Cards': }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/359193
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cc211630f4f0fe9fa4cd0d6fe70f9bf1e6210ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Group instrumentation modules

2017-06-15 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/359130 )

Change subject: Hygiene: Group instrumentation modules
..

Hygiene: Group instrumentation modules

Following on from I4f653bba, since the schema and statsvInstrumentation
modules are similar, let's group/rename them:

  schema -> instrumentation/eventLogging
  statsvInstrumentation -> instrumentation/statsv

Change-Id: Ic59e0da7d4917f6733fd090f15d3c269af863f05
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/index.js
R src/instrumentation/eventLogging.js
R src/instrumentation/statsv.js
R tests/node-qunit/instrumentation/eventLogging.test.js
R tests/node-qunit/instrumentation/statsv.test.js
7 files changed, 10 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/30/359130/1


-- 
To view, visit https://gerrit.wikimedia.org/r/359130
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic59e0da7d4917f6733fd090f15d3c269af863f05
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Consume HTML from RESTBase endpoint

2017-06-15 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/359123 )

Change subject: pagePreviews: Consume HTML from RESTBase endpoint
..

pagePreviews: Consume HTML from RESTBase endpoint

... on the Beta Cluster only!

Bug: T165018
Change-Id: Ida4d07deeaaf720172639dde404f25f8120e6aac
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/23/359123/1

diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index 8873bc9..18c57f2 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -580,9 +580,10 @@
'default' => true,
],
 
-   // T156800: Make Page Prevews (Popups) use RESTBase's page 
summary endpoint.
-   'wgPopupsAPIUseRESTBase' => [
-   'default' => true,
+   // T165018: Make Page Previews (Popups) use RESTBase's page 
summary endpoint
+   // and consume the HTML returned.
+   'wgPopupsGateway' => [
+   'default' => 'restbaseHTML',
],
 
'wgEnableRcFiltersBetaFeature' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/359123
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida4d07deeaaf720172639dde404f25f8120e6aac
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: i13n: Log EL events with mw.track

2017-06-14 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/358957 )

Change subject: i13n: Log EL events with mw.track
..

i13n: Log EL events with mw.track

Currently, the mw.eventLog.Schema class samples per pageview. However,
we expect that if a user is bucketed for a session, then all
EventLogging events logged during that session are in the sample.

Moreover, loading the class in the way that we did - asynchronously,
using mw.loader#using - introduced an issue where the eventLogging
change listener would subscribe in the next tick of the JavaScript VM's
event loop and miss the "pageLoaded" event being queued (see T167273).

Changes:
* Make the schema module follow the form of the statsvInstrumentation
  module, i.e. make it expose the #isEnabled method, and add the
  associated getEventLoggingTracker function.
* Update the eventLogging change listener accept the tracker returned by
  getEventLoggingTracker.
* Update/fix related JSDoc documentation.

Bug: T167236
Bug: T167273
Change-Id: I4f653bbaf1bbc2c2f70327e338080e17cd3443d4
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/changeListeners/eventLogging.js
M src/changeListeners/statsv.js
M src/index.js
M src/schema.js
M tests/node-qunit/changeListeners/eventLogging.test.js
M tests/node-qunit/schema.test.js
8 files changed, 166 insertions(+), 95 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/57/358957/1


-- 
To view, visit https://gerrit.wikimedia.org/r/358957
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f653bbaf1bbc2c2f70327e338080e17cd3443d4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: i13n: Extract experiments module

2017-06-14 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/358956 )

Change subject: i13n: Extract experiments module
..

i13n: Extract experiments module

... from the statsvInstrumentation module so that the bucketing logic
can be shared with other instrumentation modules.

Change-Id: I5732fa539a3911939fa85fa88c102fa8dcfa5613
---
M resources/dist/index.js
M resources/dist/index.js.map
A src/experiments.js
M src/index.js
M src/statsvInstrumentation.js
A tests/node-qunit/experiments.test.js
M tests/node-qunit/statsvInstrumentation.test.js
7 files changed, 136 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/56/358956/1


-- 
To view, visit https://gerrit.wikimedia.org/r/358956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5732fa539a3911939fa85fa88c102fa8dcfa5613
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[wmf/1.30.0-wmf.4]: actions/rest: Use DB-key version of title

2017-06-13 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/358528 )

Change subject: actions/rest: Use DB-key version of title
..

actions/rest: Use DB-key version of title

This reduces the number of 301 Redirect responses when fetching previews
from RESTBase.

Bug: T167633
Change-Id: I830947ab79e72dcc023193412c8d5bcee986e23f
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/actions.js
M tests/node-qunit/stubs.js
4 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/28/358528/1


-- 
To view, visit https://gerrit.wikimedia.org/r/358528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I830947ab79e72dcc023193412c8d5bcee986e23f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: wmf/1.30.0-wmf.4
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: actions/rest: Use DB-key version of title

2017-06-12 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/358338 )

Change subject: actions/rest: Use DB-key version of title
..

actions/rest: Use DB-key version of title

This reduces the number of 301 Redirect responses when fetching previews
from RESTBase.

Bug: T167633
Change-Id: I830947ab79e72dcc023193412c8d5bcee986e23f
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/actions.js
M tests/node-qunit/stubs.js
4 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/38/358338/1


-- 
To view, visit https://gerrit.wikimedia.org/r/358338
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I830947ab79e72dcc023193412c8d5bcee986e23f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: eventLogging: Add missing properties to "tapped settings cog...

2017-06-07 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/357570 )

Change subject: eventLogging: Add missing properties to "tapped settings cog" 
event
..

eventLogging: Add missing properties to "tapped settings cog" event

When there's an interaction, then the "tapped settings cog" event should
have the same properties set as the other interaction-specific events.

This was discovered while QAing T164256.

Bug: T164256
Change-Id: I4749b52656203c7e0c42ae742556ee996eee322a
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
M tests/node-qunit/reducers/eventLogging.test.js
4 files changed, 43 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/70/357570/1


-- 
To view, visit https://gerrit.wikimedia.org/r/357570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4749b52656203c7e0c42ae742556ee996eee322a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: gateway: Fix Accept header sent by rest gateway

2017-06-06 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/357359 )

Change subject: gateway: Fix Accept header sent by rest gateway
..

gateway: Fix Accept header sent by rest gateway

Prior to this change the Accept header sent by the rest gateway was

  application/json; charset=utf-8profile="..."

Change-Id: I00f277e724c561634b26c9ab10bd35332c6dba91
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/gateway/rest.js
M tests/node-qunit/gateway/rest.test.js
4 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/59/357359/1


-- 
To view, visit https://gerrit.wikimedia.org/r/357359
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I00f277e724c561634b26c9ab10bd35332c6dba91
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: doc: Document reducers/eventLogging module

2017-05-26 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355749 )

Change subject: doc: Document reducers/eventLogging module
..

doc: Document reducers/eventLogging module

Bug: T158236
Change-Id: I327f11ba804063a912c355477e9247a99e9b6e32
---
M resources/dist/index.js.map
M src/reducers/eventLogging.js
2 files changed, 30 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/49/355749/1


-- 
To view, visit https://gerrit.wikimedia.org/r/355749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I327f11ba804063a912c355477e9247a99e9b6e32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: eventLogging: Add perceivedWait prop to all events

2017-05-25 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355646 )

Change subject: eventLogging: Add perceivedWait prop to all events
..

eventLogging: Add perceivedWait prop to all events

... and the previewType property as well.

Per the Popups schema [0], the "opened" action should have the
perceivedWait and previewType properties set.

Bug: T166323
Change-Id: I957d123434a6b750aff6f5279865321a08367382
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
M tests/node-qunit/reducers/eventLogging.test.js
4 files changed, 56 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/46/355646/1


-- 
To view, visit https://gerrit.wikimedia.org/r/355646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I957d123434a6b750aff6f5279865321a08367382
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: doc: Document userSettings module

2017-05-25 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355634 )

Change subject: doc: Document userSettings module
..

doc: Document userSettings module

Bug: T158236
Change-Id: Ia2365c7d6d1b9bc7438a3824656f1dde2a0170fb
---
M resources/dist/index.js.map
M src/userSettings.js
2 files changed, 28 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/34/355634/1


-- 
To view, visit https://gerrit.wikimedia.org/r/355634
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2365c7d6d1b9bc7438a3824656f1dde2a0170fb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: doc: Add doc:start script

2017-05-25 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355607 )

Change subject: doc: Add doc:start script
..

doc: Add doc:start script

Supporting changes:
* Use nodemon@1.11.0.

Change-Id: I7b528525874e377533e92c0a80c8aae9f6a18620
---
M package.json
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/07/355607/1

diff --git a/package.json b/package.json
index a78240d..54f475b 100644
--- a/package.json
+++ b/package.json
@@ -7,6 +7,7 @@
 "test:dev": "grunt lint && npm run test:node",
 "test": " npm run check-built-assets && npm run test:dev",
 "doc": "jsdoc -c jsdoc.json",
+"doc:start": "nodemon --watch src --exec 'npm run doc'",
 "check-built-assets": "echo 'CHECKING BUILD SOURCES ARE COMMITED' && rm 
-rf test-build && mv resources/dist test-build && npm run build && diff -x 
'*.map' -r test-build resources/dist && rm -rf test-build",
 "coverage": "istanbul cover node_modules/.bin/mw-node-qunit 
tests/node-qunit/*.js tests/node-qunit/**/*.js",
 "precommit": "npm run test:dev && npm run build && git add resources/dist"
@@ -25,6 +26,7 @@
 "jsdoc": "^3.4.3",
 "mock-require": "^2.0.1",
 "mw-node-qunit": "^2.0.0",
+"nodemon": "^1.11.0",
 "redux": "3.6.0",
 "redux-thunk": "2.2.0",
 "stylelint-config-wikimedia": "0.4.1",

-- 
To view, visit https://gerrit.wikimedia.org/r/355607
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b528525874e377533e92c0a80c8aae9f6a18620
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: WIP doc: Document gateway modules

2017-05-24 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355474 )

Change subject: WIP doc: Document gateway modules
..

WIP doc: Document gateway modules

Additional changes:
* Fix the summary not showing up for the Container interface.

Bug: T158236
Change-Id: I7c5dee1b4525c2db28b89e57604d2d073620293d
---
M src/container.js
M src/gateway/index.js
2 files changed, 13 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/74/355474/1

diff --git a/src/container.js b/src/container.js
index 50ae86b..97e9c28 100644
--- a/src/container.js
+++ b/src/container.js
@@ -12,10 +12,9 @@
cache = {};
 
/**
-* @interface Container
-*
 * The interface implemented by all service containers.
 *
+* @interface Container
 * @global
 */
return {
diff --git a/src/gateway/index.js b/src/gateway/index.js
index e2c6285..318bb16 100644
--- a/src/gateway/index.js
+++ b/src/gateway/index.js
@@ -1,18 +1,22 @@
+// Note that this interface definition is in the global scope.
 /**
- * Interface for API gateway that fetches page summary
+ * The interface implemented by all preview gateways.
  *
- * @interface ext.popups.Gateway
+ * @interface Gateway
  */
 
 /**
- * Returns a preview model fetched from the api
+ * Returns a preview fetched from some source.
+ *
+ * If the underlying request is successful and the response is not empty;
+ * otherwise it rejects.
+ *
  * @function
- * @name ext.popups.Gateway#getPageSummary
- * @param {String} title Page title we're querying
- * @returns {jQuery.Promise} that resolves with {ext.popups.PreviewModel}
- * if the request is successful and the response is not empty; otherwise
- * it rejects.
+ * @name Gateway#getPageSummary
+ * @param {String} title The title of the page to fetch the preview from.
+ * @returns {jQuery.Promise}
  */
+
 module.exports = {
createMediaWikiApiGateway: require( './mediawiki' ),
createRESTBaseGateway: require( './rest' )

-- 
To view, visit https://gerrit.wikimedia.org/r/355474
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c5dee1b4525c2db28b89e57604d2d073620293d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: doc: Document statsvInstrumentation module

2017-05-24 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355401 )

Change subject: doc: Document statsvInstrumentation module
..

doc: Document statsvInstrumentation module

Bug: T158236
Change-Id: I138a1ef5305c0b49415d5f2a914ba45fd6aa869b
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/statsvInstrumentation.js
3 files changed, 13 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/01/355401/1


-- 
To view, visit https://gerrit.wikimedia.org/r/355401
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I138a1ef5305c0b49415d5f2a914ba45fd6aa869b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: mobileFrontend: Move first paragraph before infobox

2017-05-24 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355397 )

Change subject: mobileFrontend: Move first paragraph before infobox
..

mobileFrontend: Move first paragraph before infobox

Following on from I28d532fc, enable moving the first paragraph before
the infobox on all articles by default.

Bug: T150325
Change-Id: I4154e8f6b7e29c1acd0a06452e6b572239d62f70
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/97/355397/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 194cfa7..de8b4ab 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15267,9 +15267,7 @@
 
 'wgMFShowFirstParagraphBeforeInfobox' => [
'default' => [
-   'base' => false,
-   // T149830
-   'beta' => true
+   'base' => true,
]
 ],
 

-- 
To view, visit https://gerrit.wikimedia.org/r/355397
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4154e8f6b7e29c1acd0a06452e6b572239d62f70
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: doc: Document counts module

2017-05-23 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355199 )

Change subject: doc: Document counts module
..

doc: Document counts module

Bug: T158236
Change-Id: I27106436e693289aa0c4140cef8e3d6210bcd8fb
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/counts.js
3 files changed, 11 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/99/355199/1


-- 
To view, visit https://gerrit.wikimedia.org/r/355199
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27106436e693289aa0c4140cef8e3d6210bcd8fb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: doc: Document isEnabled module

2017-05-23 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355200 )

Change subject: doc: Document isEnabled module
..

doc: Document isEnabled module

Bug: T158236
Change-Id: Ib80a5951e41765b982fecf4e2ac33767e4ef1738
---
M resources/dist/index.js.map
M src/isEnabled.js
2 files changed, 11 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/00/355200/1


-- 
To view, visit https://gerrit.wikimedia.org/r/355200
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib80a5951e41765b982fecf4e2ac33767e4ef1738
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: docs: Document schema module

2017-05-22 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355145 )

Change subject: docs: Document schema module
..

docs: Document schema module

Bug: T158236
Change-Id: I365fbfc1725d92003e902301252d53d4620c2128
---
M resources/dist/index.js.map
M src/schema.js
2 files changed, 11 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/45/355145/1


-- 
To view, visit https://gerrit.wikimedia.org/r/355145
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I365fbfc1725d92003e902301252d53d4620c2128
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: doc: Document wait module

2017-05-22 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355144 )

Change subject: doc: Document wait module
..

doc: Document wait module

Bug: T158236
Change-Id: I5bdd3d7bb6fd0eb219b01ae113dc5bc8bdf12d0a
---
M resources/dist/index.js.map
M src/wait.js
2 files changed, 10 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/44/355144/1


-- 
To view, visit https://gerrit.wikimedia.org/r/355144
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bdd3d7bb6fd0eb219b01ae113dc5bc8bdf12d0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: doc: Document preview/model module

2017-05-22 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355143 )

Change subject: doc: Document preview/model module
..

doc: Document preview/model module

Changes:
* Assign exports to exports rather than reassigning module.exports so
  that JSDoc can guess inner members.
* Tidy up parameter types with JSDoc's "nullable" syntax.

Bug: T158236
Change-Id: I7261d1bb3924c9f14301490f54d7813dcffc959b
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/preview/model.js
3 files changed, 41 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/43/355143/1


-- 
To view, visit https://gerrit.wikimedia.org/r/355143
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7261d1bb3924c9f14301490f54d7813dcffc959b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: WIP Make JSDuck Work Again

2017-05-19 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/354455 )

Change subject: WIP Make JSDuck Work Again
..

WIP Make JSDuck Work Again

Change-Id: I8da712075dd28f6b228c96fa9577ca39eb148fb5
---
M jsduck.json
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/55/354455/1

diff --git a/jsduck.json b/jsduck.json
index 128a970..f8d6e1f 100644
--- a/jsduck.json
+++ b/jsduck.json
@@ -1,5 +1,6 @@
 {
-   "--title": "Hovercards - Documentation",
+   "--title": "Page Previews - Documentation",
"--output": "docs",
-   "--": ["resources"]
+   "--processes": "0",
+   "--": ["src"]
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/354455
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8da712075dd28f6b228c96fa9577ca39eb148fb5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: rl: Break out mobile.mainMenu style module

2017-05-18 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/354225 )

Change subject: rl: Break out mobile.mainMenu style module
..

rl: Break out mobile.mainMenu style module

The mobile.mainMenu styles are loaded by OutputPage#addModuleStyles,
which requires that the specified modules are styles-only, on the
Special:MobileMenu page. A side effect of this is that the
mobile.mainMenu JS and templates aren't loaded on Special:MobileMenu,
which is fortunate as they aren't required. They are also loaded by the
RL on other pages.

Support both ways of loading the mobile.mainMenu styles (and other
content) and the RL by:

* Creating the mobile.mainMenu.styles styles-only RL module.
* Making the mobile.mainMenu RL module depend on mobile.mainMenu.styles.
* Only the mobile.mainMenu.styles RL module on Special:MobileMenu.

Bug: T164892
Change-Id: Ia108d63753593ca8e6ce266e595d32af148b436a
---
M extension.json
M includes/specials/SpecialMobileMenu.php
2 files changed, 11 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/25/354225/1

diff --git a/extension.json b/extension.json
index 3c27293..49221a2 100644
--- a/extension.json
+++ b/extension.json
@@ -299,6 +299,15 @@
"contributions": 
"resources/mobile.mainMenu.icons/contributions.svg"
}
},
+   "mobile.mainMenu.styles": {
+   "targets": [
+   "mobile",
+   "desktop"
+   ],
+   "styles": [
+   "resources/mobile.mainMenu/mainmenu.less"
+   ]
+   },
"mobile.mainMenu": {
"targets": [
"mobile",
@@ -306,13 +315,11 @@
],
"dependencies": [
"mobile.mainMenu.icons",
+   "mobile.mainMenu.styles",
"mobile.startup",

"mobile.loggingSchemas.mobileWebMainMenuClickTracking"
],
"position": "bottom",
-   "styles": [
-   "resources/mobile.mainMenu/mainmenu.less"
-   ],
"templates": {
"menu.hogan": 
"resources/mobile.mainMenu/menu.mustache",
"menuGroup.hogan": 
"resources/mobile.mainMenu/menuGroup.mustache"
diff --git a/includes/specials/SpecialMobileMenu.php 
b/includes/specials/SpecialMobileMenu.php
index 7489064..8b8fff7 100644
--- a/includes/specials/SpecialMobileMenu.php
+++ b/includes/specials/SpecialMobileMenu.php
@@ -34,7 +34,7 @@
$out->addModuleStyles(
[
'mobile.mainMenu.icons',
-   'mobile.mainMenu',
+   'mobile.mainMenu.styles',
]
);
}

-- 
To view, visit https://gerrit.wikimedia.org/r/354225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia108d63753593ca8e6ce266e595d32af148b436a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Break out mobile.messageBox styles module

2017-05-18 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/354222 )

Change subject: Hygiene: Break out mobile.messageBox styles module
..

Hygiene: Break out mobile.messageBox styles module

Because the mobile.messageBox styles are loaded using
OutputPage#addModuleStyles, which requires that the specified modules
are styles-only, on certain special pages. They are also loaded by the
RL on other pages as they are depended on by the mobile.nearby and
mobile.editor.common RL modules.

Support both ways of loading the mobile.messageBox styles (and other
content) and the RL by:

* Creating the mobile.messageBox.styles styles-only RL module.
* Making the mobile.messageBox RL module depend on
  mobile.messageBox.styles.
* Loading the mobile.messageBox.styles RL module using
  OutputPage#addModuleStyles.

Bug: T164892
Change-Id: I46dd7fbfdfebd1daf732f9c3a7dbbf488ff6c533
---
M extension.json
M includes/skins/SkinMinerva.php
2 files changed, 14 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/22/354222/1

diff --git a/extension.json b/extension.json
index 4191e85..e4c7ec8 100644
--- a/extension.json
+++ b/extension.json
@@ -321,17 +321,24 @@
"resources/mobile.mainMenu/MainMenu.js"
]
},
+   "mobile.messageBox.styles": {
+   "targets": [
+   "mobile",
+   "desktop"
+   ],
+   "position": "top",
+   "styles": [
+   "resources/mobile.messageBox/messageBox.less"
+   ]
+   },
"mobile.messageBox": {
"targets": [
"mobile",
"desktop"
],
"dependencies": [
-   "mobile.startup"
-   ],
-   "position": "top",
-   "styles": [
-   "resources/mobile.messageBox/messageBox.less"
+   "mobile.startup",
+   "mobile.messageBox.styles"
],
"templates": {
"MessageBox.hogan": 
"resources/mobile.messageBox/MessageBox.mustache"
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 1b18eeb..8cadaf4 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -1402,14 +1402,14 @@
$styles[] = 'skins.minerva.userpage.styles';
$styles[] = 'skins.minerva.userpage.icons';
} elseif ( $title->isSpecialPage() ) {
-   $styles[] = 'mobile.messageBox';
+   $styles[] = 'mobile.messageBox.styles';
$styles['special'] = 'skins.minerva.special.styles';
}
if ( $title->isSpecial( 'Notifications' ) ) {
$styles[] = 'skins.minerva.notifications.filter.styles';
}
if ( $this->getOutput()->getRequest()->getText( 'oldid' ) ) {
-   $styles[] = 'mobile.messageBox';
+   $styles[] = 'mobile.messageBox.styles';
}
 
return $styles;

-- 
To view, visit https://gerrit.wikimedia.org/r/354222
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46dd7fbfdfebd1daf732f9c3a7dbbf488ff6c533
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: actions: Mix title and namespaceID into LINK_DWELL

2017-05-15 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/353903 )

Change subject: actions: Mix title and namespaceID into LINK_DWELL
..

actions: Mix title and namespaceID into LINK_DWELL

This fixes a bug in I8a63d82, where the pageTitleHover and
namespaceIdHover properties of EventLogging events weren't being set.

Bug: T164256
Change-Id: Ie2c2d253f6508b89d48129fd17a902e5ded7cad5
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/actions.js
M tests/node-qunit/actions.test.js
4 files changed, 12 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/03/353903/1


-- 
To view, visit https://gerrit.wikimedia.org/r/353903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2c2d253f6508b89d48129fd17a902e5ded7cad5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[wmf/1.29.0-wmf.21]: eventLogging: Discard events with duplicate tokens

2017-05-10 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/353058 )

Change subject: eventLogging: Discard events with duplicate tokens
..

eventLogging: Discard events with duplicate tokens

I6a38a261 made the eventLogging change listener count and discard
duplicate events and count duplicate tokens.

While we isolate the issue(s) that lead to duplication (reuse, likely)
of tokens, make the eventLogging change listener discard events with
duplicate tokens as well.

Bug: T161769
Bug: T163198
Change-Id: I0dbb16c37814d39d7aec35c8fb7cc7309704c550
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/changeListeners/eventLogging.js
M tests/node-qunit/changeListeners/eventLogging.test.js
4 files changed, 30 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/58/353058/1


-- 
To view, visit https://gerrit.wikimedia.org/r/353058
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dbb16c37814d39d7aec35c8fb7cc7309704c550
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: wmf/1.29.0-wmf.21
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[wmf/1.30.0-wmf.1]: eventLogging: Discard events with duplicate tokens

2017-05-10 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/353038 )

Change subject: eventLogging: Discard events with duplicate tokens
..

eventLogging: Discard events with duplicate tokens

I6a38a261 made the eventLogging change listener count and discard
duplicate events and count duplicate tokens.

While we isolate the issue(s) that lead to duplication (reuse, likely)
of tokens, make the eventLogging change listener discard events with
duplicate tokens as well.

Bug: T161769
Bug: T163198
Change-Id: I0dbb16c37814d39d7aec35c8fb7cc7309704c550
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/changeListeners/eventLogging.js
M tests/node-qunit/changeListeners/eventLogging.test.js
4 files changed, 30 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/38/353038/1


-- 
To view, visit https://gerrit.wikimedia.org/r/353038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dbb16c37814d39d7aec35c8fb7cc7309704c550
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: wmf/1.30.0-wmf.1
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: eventLogging: Discard events with duplicate tokens

2017-05-10 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/353035 )

Change subject: eventLogging: Discard events with duplicate tokens
..

eventLogging: Discard events with duplicate tokens

I6a38a261 made the eventLogging change listener count and discard
duplicate events and count duplicate tokens.

While we isolate the issue(s) that lead to duplication (reuse, likely)
of tokens, make the eventLogging change listener discard events with
duplicate tokens as well.

Bug: T161769
Bug: T163198
Change-Id: I0dbb16c37814d39d7aec35c8fb7cc7309704c550
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/changeListeners/eventLogging.js
M tests/node-qunit/changeListeners/eventLogging.test.js
4 files changed, 30 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/35/353035/1


-- 
To view, visit https://gerrit.wikimedia.org/r/353035
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dbb16c37814d39d7aec35c8fb7cc7309704c550
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: WIP eventLogging: Add missing *Hover properties

2017-05-09 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/352870 )

Change subject: WIP eventLogging: Add missing *Hover properties
..

WIP eventLogging: Add missing *Hover properties

Bug: T164256
Change-Id: I8a63d82a65324680dff9176020a8ea97695428c4
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/actions.js
M src/processLinks.js
M src/reducers/eventLogging.js
M tests/node-qunit/actions.test.js
M tests/node-qunit/processLinks.test.js
M tests/node-qunit/reducers/eventLogging.test.js
8 files changed, 128 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/70/352870/1


-- 
To view, visit https://gerrit.wikimedia.org/r/352870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a63d82a65324680dff9176020a8ea97695428c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: eventLogging: Round perceivedWait property

2017-05-09 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/352868 )

Change subject: eventLogging: Round perceivedWait property
..

eventLogging: Round perceivedWait property

The perceivedWait property, introduced in I3fd253f1, must be an
integer.

Bug: T164256
Change-Id: If19e8694e5ac111af0f27146cf4ac03bd1a6ff82
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/68/352868/1


-- 
To view, visit https://gerrit.wikimedia.org/r/352868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If19e8694e5ac111af0f27146cf4ac03bd1a6ff82
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Tidy up QUnit references

2017-05-04 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/351798 )

Change subject: Hygiene: Tidy up QUnit references
..

Hygiene: Tidy up QUnit references

Since Ieea378c9 all QUnit tests are run in Node.js and not in the
browser. Tidy up references to QUnit inside of the codebase and tooling.

Changes:
* Don't exclude src/processLinks.js in Istanbul code coverage reports.
* Don't test for window.QUnit in createSchema. We no longer run the risk
  of sending beacons while running the QUnit test suite as it's no
  longer run in the browser.

Bug: T160406
Change-Id: Ifb6adb84b8019dd69231b50af00bf978b708fc60
---
M .istanbul.yml
M src/schema.js
M tests/node-qunit/schema.test.js
3 files changed, 1 insertion(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/98/351798/1

diff --git a/.istanbul.yml b/.istanbul.yml
index 22c9c5f..96fc6c9 100644
--- a/.istanbul.yml
+++ b/.istanbul.yml
@@ -3,6 +3,5 @@
   excludes: [
 "resources/dist/*", # Compiled assets
 "*.js", # Gruntfile.js and webpack.config.js
-"src/processLinks.js", # Covered by browser QUnit integration test
 "src/index.js", # Application entry point
   ]
diff --git a/src/schema.js b/src/schema.js
index 569278e..870f653 100644
--- a/src/schema.js
+++ b/src/schema.js
@@ -14,8 +14,7 @@
 
if (
!window.navigator ||
-   !$.isFunction( window.navigator.sendBeacon ) ||
-   window.QUnit
+   !$.isFunction( window.navigator.sendBeacon )
) {
samplingRate = 0;
}
diff --git a/tests/node-qunit/schema.test.js b/tests/node-qunit/schema.test.js
index 928597c..aea9c15 100644
--- a/tests/node-qunit/schema.test.js
+++ b/tests/node-qunit/schema.test.js
@@ -55,13 +55,3 @@
 
assert.deepEqual( mw.eventLog.Schema.getCall( 1 ).args, expectedArgs );
 } );
-
-QUnit.test( 'it should use a 0 sampling rate in a unit testing environment', 
function ( assert ) {
-   assert.expect( 1 );
-
-   this.window.QUnit = {};
-
-   createSchema( this.config, this.window );
-
-   assert.ok( mw.eventLog.Schema.calledWith( 'Popups', 0 ) );
-} );

-- 
To view, visit https://gerrit.wikimedia.org/r/351798
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb6adb84b8019dd69231b50af00bf978b708fc60
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: eventLogging: Add missing perceivedWait property

2017-05-03 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/351605 )

Change subject: eventLogging: Add missing perceivedWait property
..

eventLogging: Add missing perceivedWait property

Per the Popups schema [0], the "dismissed" action expects the
perceivedWait property to be set.

Happily, the time until the preview was shown is already recorded and
used to determine whether or not to create a "dismissed" or
"dwelledButAbandoned" event.

Reducer changes:
* When creating the "dismissed" event, set the perceivedWait property to
  the already accumulated timeToPreviewShow.

[0] https://meta.wikimedia.org/wiki/Schema:Popups

Change-Id: I3fd253f1c2ff5fa8e24c9225060d728ffd8dfd27
---
M src/reducers/eventLogging.js
M tests/node-qunit/reducers/eventLogging.test.js
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/05/351605/1

diff --git a/src/reducers/eventLogging.js b/src/reducers/eventLogging.js
index 6741d27..8717dfd 100644
--- a/src/reducers/eventLogging.js
+++ b/src/reducers/eventLogging.js
@@ -59,6 +59,7 @@
if ( interaction.timeToPreviewShow !== undefined ) {
result.action = 'dismissed';
result.previewType = interaction.previewType;
+   result.perceivedWait = interaction.timeToPreviewShow;
} else {
result.action = 'dwelledButAbandoned';
}
diff --git a/tests/node-qunit/reducers/eventLogging.test.js 
b/tests/node-qunit/reducers/eventLogging.test.js
index 0184c2a..8cff446 100644
--- a/tests/node-qunit/reducers/eventLogging.test.js
+++ b/tests/node-qunit/reducers/eventLogging.test.js
@@ -568,7 +568,9 @@
action: 'dismissed',
 
// N.B. that the FETCH_* actions have been skipped.
-   previewType: undefined
+   previewType: undefined,
+
+   perceivedWait: 700
},
'It should enqueue a "dismissed" event when the preview has 
been shown.'
);

-- 
To view, visit https://gerrit.wikimedia.org/r/351605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fd253f1c2ff5fa8e24c9225060d728ffd8dfd27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Create pp_stage0.dblist

2017-05-02 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/351286 )

Change subject: pagePreviews: Create pp_stage0.dblist
..

pagePreviews: Create pp_stage0.dblist

Extract the repeated set of stage 0 wikis into a dblist so that:

* The config is more easily consumed by humans; and
* The stage 1 list can be computed.

Bug: T162672
Change-Id: I8f586626077c348c68401504a7fe262da2dbd7c0
---
A dblists/pp_stage0.dblist
M wmf-config/InitialiseSettings.php
2 files changed, 14 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/86/351286/1

diff --git a/dblists/pp_stage0.dblist b/dblists/pp_stage0.dblist
new file mode 100644
index 000..0fa481d
--- /dev/null
+++ b/dblists/pp_stage0.dblist
@@ -0,0 +1,6 @@
+itwiki
+ruwiki
+elwiki
+cawiki
+hewiki
+huwiki
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index cca03be..4169f66 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -13208,14 +13208,9 @@
'default' => false,
'sewikimedia' => true, // T68374
 
-   // T136602, T162162: Make Page Previews enabled by default for the 
following
-   // "stage 0" wikis.
-   'itwiki' => true,
-   'ruwiki' => true,
-   'elwiki' => true,
-   'cawiki' => true,
-   'hewiki' => true,
-   'huwiki' => true,
+   // T136602, T162162: Make Page Previews enabled by default for the 
stage 0
+   // wikis.
+   'pp_stage0' => true,
 ],
 
 'wgPopupsAnonsEnabledSamplingRate' => [
@@ -13223,14 +13218,8 @@
'sewikimedia' => 1, // T68374
 
// T136602: Make Page Previews enabled by default for 90% of anon users 
for
-   // the following stage 0 wikis. As above, note well that enabling Page
-   // Previews by default on hewiki is blocked on T160614.
-   'itwiki' => 0.9,
-   'ruwiki' => 0.9,
-   'elwiki' => 0.9,
-   'cawiki' => 0.9,
-   'hewiki' => 0.9,
-   'huwiki' => 0.9
+   // the stage 0 wikis.
+   'pp_stage0' => 0.9,
 ],
 
 'wmgPopupsBetaFeature' => [
@@ -13238,6 +13227,7 @@
'wikidatawiki' => false,
'wiktionary' => false,
'nonbetafeatures' => false,
+   'pp_stage0' => false,
 ],
 
 'wgPopupsSchemaSamplingRate' => [
@@ -13257,13 +13247,8 @@
 'wgPopupsAPIUseRESTBase' => [
'default' => false,
 
-   // T158221: Make Page Previews use RESTBase for the following stage 0 
wikis.
-   'itwiki' => true,
-   'ruwiki' => true,
-   'elwiki' => true,
-   'cawiki' => true,
-   'hewiki' => true,
-   'huwiki' => true,
+   // T158221: Make Page Previews use RESTBase for the stage 0 wikis.
+   'pp_stage0' => true,
 ],
 
 // T160081 (and others): Make sure that Page Previews can detect the many, many

-- 
To view, visit https://gerrit.wikimedia.org/r/351286
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f586626077c348c68401504a7fe262da2dbd7c0
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Deploy to first 50 of stage 1 wikis

2017-05-02 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/351287 )

Change subject: pagePreviews: Deploy to first 50 of stage 1 wikis
..

pagePreviews: Deploy to first 50 of stage 1 wikis

Add the pp_stage2 and pp_stage1_computed dblists so that the first chunk
can be computed.

If a chunk size of 50 has little to no impact on Page Previews,
RESTBase, and Varnish performance, then it should be trivial to increase
it to 100 or more.

Bug: T162672
Change-Id: I505e91006055dcfaec69853ad91adc7c090b1a41
---
A dblists/pp_stage1_chunk0.dblist
A dblists/pp_stage1_computed.dblist
A dblists/pp_stage2.dblist
3 files changed, 56 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/87/351287/1

diff --git a/dblists/pp_stage1_chunk0.dblist b/dblists/pp_stage1_chunk0.dblist
new file mode 100644
index 000..c73dd10
--- /dev/null
+++ b/dblists/pp_stage1_chunk0.dblist
@@ -0,0 +1,53 @@
+# Generated with:
+#
+#   ./multiversion/bin/expanddblist dblists/pp_stage1_computed.dblist | tail 
-n 297 | head -n 50 > dblists/pp_stage1_chunk0.dblist
+aawiki
+abwiki
+acewiki
+adywiki
+afwiki
+akwiki
+alswiki
+amwiki
+angwiki
+anwiki
+arbcom_cswiki
+arbcom_dewiki
+arbcom_enwiki
+arbcom_fiwiki
+arbcom_nlwiki
+arcwiki
+arwiki
+arzwiki
+astwiki
+aswiki
+avwiki
+aywiki
+azbwiki
+azwiki
+barwiki
+bat_smgwiki
+bawiki
+bclwiki
+be_x_oldwiki
+bewiki
+bgwiki
+bhwiki
+biwiki
+bjnwiki
+bmwiki
+bnwiki
+bowiki
+bpywiki
+brwiki
+bswiki
+bugwiki
+bxrwiki
+cbk_zamwiki
+cdowiki
+cebwiki
+cewiki
+chowiki
+chrwiki
+chwiki
+chywiki
diff --git a/dblists/pp_stage1_computed.dblist 
b/dblists/pp_stage1_computed.dblist
new file mode 100644
index 000..029b2a9
--- /dev/null
+++ b/dblists/pp_stage1_computed.dblist
@@ -0,0 +1 @@
+%% wikipedia.dblist - pp_stage0.dblist - pp_stage2.dblist
diff --git a/dblists/pp_stage2.dblist b/dblists/pp_stage2.dblist
new file mode 100644
index 000..046910d
--- /dev/null
+++ b/dblists/pp_stage2.dblist
@@ -0,0 +1,2 @@
+enwiki
+dewiki

-- 
To view, visit https://gerrit.wikimedia.org/r/351287
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I505e91006055dcfaec69853ad91adc7c090b1a41
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Document removeXMLProcInst line in .svgo.yml

2017-04-28 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/350814 )

Change subject: Document removeXMLProcInst line in .svgo.yml
..

Document removeXMLProcInst line in .svgo.yml

Change-Id: Ibacb748fec161f08a2e2d9ca15847da0e3cc8ccd
---
M .svgo.yml
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/14/350814/1

diff --git a/.svgo.yml b/.svgo.yml
index 52ae3ca..dd58499 100644
--- a/.svgo.yml
+++ b/.svgo.yml
@@ -1,5 +1,12 @@
 plugins:
+
+  # If the SVG doesn't start with an XML declaration, then it's MIME type will
+  # be detected as "text/plain" rather than "image/svg+xml" by libmagic and,
+  # consequently, MediaWiki's CSSMin CSS minifier. libmagic's default database
+  # currently requires that SVGs contain an XML declaration
+  # .
   - removeXMLProcInst: false
+
   - cleanupIDs: false
   - collapseGroups: false
-  - mergePaths: false
\ No newline at end of file
+  - mergePaths: false

-- 
To view, visit https://gerrit.wikimedia.org/r/350814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibacb748fec161f08a2e2d9ca15847da0e3cc8ccd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Remove isLoggingEnabled with Null Object pattern

2017-04-27 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/350552 )

Change subject: Remove isLoggingEnabled with Null Object pattern
..

Remove isLoggingEnabled with Null Object pattern

The statsv change listener depended on both the analytics tracking
function and whether it should log metrics to StatsD. We can simplify
the behaviour of the change listener by passing in a function which
doesn't log metrics to StatsD if such logging is disabled.

The change listener is now more isolated from other components.
Moreover, sharing the analytics tracking function with other components
is simpler as there's no repeated code.

Bug: T163198
Change-Id: Ibf4785fa4c27c1ad4739f02410f57412f56ff481
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/changeListeners/statsv.js
M src/index.js
M tests/node-qunit/changeListeners/statsv.test.js
5 files changed, 79 insertions(+), 58 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/52/350552/1


-- 
To view, visit https://gerrit.wikimedia.org/r/350552
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf4785fa4c27c1ad4739f02410f57412f56ff481
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Optimise SVGs with svgo

2017-04-26 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/350395 )

Change subject: Optimise SVGs with svgo
..

Optimise SVGs with svgo

... by running the following:

svgo --disable removeXMLProcInst images/ resources/

Change-Id: I10b2286d6577701ba3b9a8651d5165fa81b8d293
---
M images/popups-ltr.svg
M images/popups-rtl.svg
M resources/ext.popups.images/close.svg
M resources/ext.popups.images/cog.svg
4 files changed, 4 insertions(+), 93 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/95/350395/1

diff --git a/images/popups-ltr.svg b/images/popups-ltr.svg
index c1f2dd5..8302772 100644
--- a/images/popups-ltr.svg
+++ b/images/popups-ltr.svg
@@ -1,41 +1 @@
-
-http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 
264 162" id="svg2">
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 264 
162">
\ No newline at end of file
diff --git a/images/popups-rtl.svg b/images/popups-rtl.svg
index 65c7ae9..2e4db3d 100644
--- a/images/popups-rtl.svg
+++ b/images/popups-rtl.svg
@@ -1,41 +1 @@
-
-http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 
264 162" id="svg2">
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+http://www.w3.org/2000/svg; width="264" height="162" viewBox="0 0 264 
162">
\ No newline at end of file
diff --git a/resources/ext.popups.images/close.svg 
b/resources/ext.popups.images/close.svg
index 2e06148..46957b2 100644
--- a/resources/ext.popups.images/close.svg
+++ b/resources/ext.popups.images/close.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
\ No newline at end of file
diff --git a/resources/ext.popups.images/cog.svg 
b/resources/ext.popups.images/cog.svg
index 8f1fb47..38de270 100644
--- a/resources/ext.popups.images/cog.svg
+++ b/resources/ext.popups.images/cog.svg
@@ -1,10 +1 @@
-
-
-http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd;>
-http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink; x="0px" y="0px"
-viewBox="0 0 24 24" enable-background="new 0 0 24 24" 
xml:space="preserve">
-
-
+http://www.w3.org/2000/svg; 
viewBox="0 0 24 24">
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/350395
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I10b2286d6577701ba3b9a8651d5165fa81b8d293
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Reading Web Page Previews alerts

2017-04-26 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/350377 )

Change subject: Reading Web Page Previews alerts
..

Reading Web Page Previews alerts

Use the Nagios Grafana alerts adapter introduced in Ieb902f45 to notify
the Reading Web team of any graphs that are alerting.

Change-Id: I1254d3f5b15898cf89e3d4d85bb444f08ab94ca8
---
M modules/icinga/manifests/ircbot.pp
A modules/icinga/manifests/monitor/reading_web.pp
M modules/nagios_common/files/contactgroups.cfg
M modules/nagios_common/templates/notification_commands.cfg.erb
M modules/role/manifests/icinga.pp
5 files changed, 27 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/77/350377/1

diff --git a/modules/icinga/manifests/ircbot.pp 
b/modules/icinga/manifests/ircbot.pp
index 3a8844f..efc6624 100644
--- a/modules/icinga/manifests/ircbot.pp
+++ b/modules/icinga/manifests/ircbot.pp
@@ -15,6 +15,7 @@
 '/var/log/icinga/irc-interactive.log' => '#wikimedia-interactive',
 '/var/log/icinga/irc-performance.log' => '#wikimedia-perf-bots',
 '/var/log/icinga/irc-fundraising.log' => '#wikimedia-fundraising',
+'/var/log/icinga/irc-reading-web.log' => 
'#wikimedia-reading-web-bots',
 }
 $ircecho_nick   = 'icinga-wm'
 $ircecho_server = 'chat.freenode.net'
diff --git a/modules/icinga/manifests/monitor/reading_web.pp 
b/modules/icinga/manifests/monitor/reading_web.pp
new file mode 100644
index 000..4cd1edc
--- /dev/null
+++ b/modules/icinga/manifests/monitor/reading_web.pp
@@ -0,0 +1,10 @@
+# == Class: icinga::monitor::reading_web
+#
+# Monitor the following Reading Web Grafana dashboards:
+#
+# * Page Previews Dashboard 

+class icinga::monitor::reading_web {
+monitoring::grafana_alert { 'db/reading-web-page-previews':
+contact_group => 'team-reading-web',
+}
+}
diff --git a/modules/nagios_common/files/contactgroups.cfg 
b/modules/nagios_common/files/contactgroups.cfg
index 1474a45..fbefc9b 100644
--- a/modules/nagios_common/files/contactgroups.cfg
+++ b/modules/nagios_common/files/contactgroups.cfg
@@ -101,3 +101,7 @@
 members 
irc-performance,team-performance,gilles,aaron,krinkle,phedenskog
 }
 
+define contactgroup {
+contactgroup_name   team-reading-web
+members 
irc-reading-web,phuedx,jhernandez,jrobson,bmansurov,pmiazga,sniedzielski
+}
diff --git a/modules/nagios_common/templates/notification_commands.cfg.erb 
b/modules/nagios_common/templates/notification_commands.cfg.erb
index 1b09e4b..61eb75e 100644
--- a/modules/nagios_common/templates/notification_commands.cfg.erb
+++ b/modules/nagios_common/templates/notification_commands.cfg.erb
@@ -166,3 +166,14 @@
command_namenotify-service-by-irc-fundraising
command_lineecho "$NOTIFICATIONTYPE$ - $SERVICEDESC$ on $HOSTNAME$ 
is $SERVICESTATE$: $SERVICEOUTPUT$ $SERVICEACKAUTHOR$ $SERVICEACKCOMMENT$" >> 
<%= @irc_dir_path %>/irc-fundraising.log
}
+
+# IRC output for Reading Web
+define command{
+   command_namenotify-host-by-irc-reading-web
+   command_lineecho "$NOTIFICATIONTYPE$ - Host $HOSTALIAS$ is 
$HOSTSTATE$: $HOSTOUTPUT$ $HOSTACKAUTHOR$ $HOSTACKCOMMENT$" >> <%= 
@irc_dir_path %>/irc-reading-web.log
+   }
+
+define command{
+   command_namenotify-service-by-irc-reading-web
+   command_lineecho "$NOTIFICATIONTYPE$ - $SERVICEDESC$ on $HOSTNAME$ 
is $SERVICESTATE$: $SERVICEOUTPUT$ $SERVICEACKAUTHOR$ $SERVICEACKCOMMENT$" >> 
<%= @irc_dir_path %>/irc-reading-web.log
+   }
diff --git a/modules/role/manifests/icinga.pp b/modules/role/manifests/icinga.pp
index b1d0fbe..92ae9e7 100644
--- a/modules/role/manifests/icinga.pp
+++ b/modules/role/manifests/icinga.pp
@@ -22,6 +22,7 @@
 include icinga::monitor::elasticsearch
 include icinga::monitor::wdqs
 include icinga::monitor::performance
+include icinga::monitor::reading_web
 include icinga::event_handlers::raid
 
 include role::authdns::monitoring

-- 
To view, visit https://gerrit.wikimedia.org/r/350377
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1254d3f5b15898cf89e3d4d85bb444f08ab94ca8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Track and discard duplicate enqueued events

2017-04-25 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/350206 )

Change subject: Track and discard duplicate enqueued events
..

Track and discard duplicate enqueued events

The eventLogging change listener is responsible for ensuring that the
internal state of Page Previews matches its external state (that
perceived by the user and UA). It does this by logging enqueued events
with ext.eventLog.Schema#log. This makes it the perfect place to track
and discard duplicate events enqueued by the Page Previews codebase
observed in T161769.

If no duplicate events are being enqueued, then we know that there's an
issue in the EventLogging codebase or with the UA itself - particularly
the implementation of Navigator#sendBeacon.

Change listener changes:
* Make the eventLogging change listener store enqueued events that it's
  logged by storing "hashes" of the dynamic parts of them in memory.
* If the eventLogging change listener sees the same enqueued event more
  than once, then it dequeues the event and increments a counter in
  StatsD.

Bug: T163198
Change-Id: I6a38a2619d777a76dd45eb7300079e1f07b07b12
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/changeListeners/eventLogging.js
M tests/node-qunit/changeListeners/eventLogging.test.js
4 files changed, 157 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/06/350206/1


-- 
To view, visit https://gerrit.wikimedia.org/r/350206
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a38a2619d777a76dd45eb7300079e1f07b07b12
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Don't show preview when user abandons link

2017-04-21 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349410 )

Change subject: Don't show preview when user abandons link
..

Don't show preview when user abandons link

Bug: T163350
Change-Id: I154dde4e3ccaed3d11cb023c85c44451fc0ad957
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/preview.js
M tests/node-qunit/reducers/preview.test.js
4 files changed, 22 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/10/349410/1


-- 
To view, visit https://gerrit.wikimedia.org/r/349410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I154dde4e3ccaed3d11cb023c85c44451fc0ad957
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Don't occlude link when preview is above mouse

2017-04-20 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349231 )

Change subject: Don't occlude link when preview is above mouse
..

Don't occlude link when preview is above mouse

When the user dwells on a link and there's enough room to display a
preview above it, then the preview should rest atop the link rather than
above the mouse.

Bug: T161366
Change-Id: Ia7266f6e5c272817581bdbcb3710429b266556e4
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/renderer.js
3 files changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/31/349231/1


-- 
To view, visit https://gerrit.wikimedia.org/r/349231
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7266f6e5c272817581bdbcb3710429b266556e4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Foo

2017-04-19 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348919 )

Change subject: Foo
..

Foo

Change-Id: I1acdfc15237d1d91e144b9fa5933ab6b3cfd9186
---
M tests/node-qunit/actions.test.js
1 file changed, 5 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/19/348919/1

diff --git a/tests/node-qunit/actions.test.js b/tests/node-qunit/actions.test.js
index 0732bbd..739c6ab 100644
--- a/tests/node-qunit/actions.test.js
+++ b/tests/node-qunit/actions.test.js
@@ -409,8 +409,7 @@
activeToken: token
}
};
-   },
-   done = assert.async();
+   };
 
this.sandbox.stub( mw, 'now' ).returns( new Date() );
 
@@ -429,7 +428,10 @@
'Have you spoken with #Design about changing this value?'
);
 
-   this.waitPromises[ 0 ].then( function () {
+   // After ABANDON_END_DELAY milliseconds...
+   this.waitDeferreds[ 0 ].resolve();
+
+   return this.waitPromises[ 0 ].then( function () {
assert.ok(
dispatch.calledWith( {
type: 'ABANDON_END',
@@ -437,12 +439,7 @@
} ),
'ABANDON_* share the same token.'
);
-
-   done();
} );
-
-   // After ABANDON_END_DELAY milliseconds...
-   this.waitDeferreds[ 0 ].resolve();
 } );
 
 QUnit.module( 'ext.popups/actions#saveSettings' );

-- 
To view, visit https://gerrit.wikimedia.org/r/348919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1acdfc15237d1d91e144b9fa5933ab6b3cfd9186
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: reducers: Don't destroy interaction on LINK_CLICK

2017-04-18 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348789 )

Change subject: reducers: Don't destroy interaction on LINK_CLICK
..

reducers: Don't destroy interaction on LINK_CLICK

I09d8776 introduced a bug in the eventLogging reducer where reducing
LINK_CLICK would remove any accumulated interaction state but not close
the interaction.

Update the associated tests so that they correctly test the reduction of
this action.

Bug: T162924
Change-Id: Ia03e719c228ee96f279c1fa89252dc6b6371a8e9
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
M tests/node-qunit/reducers/eventLogging.test.js
4 files changed, 25 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/89/348789/1


-- 
To view, visit https://gerrit.wikimedia.org/r/348789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia03e719c228ee96f279c1fa89252dc6b6371a8e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: actions: Conditionally dispatch ABANDON_*

2017-04-18 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348790 )

Change subject: actions: Conditionally dispatch ABANDON_*
..

actions: Conditionally dispatch ABANDON_*

If the user CmdOrCtrl+Clicks on a link, then the link will remain
focussed. If a preview is shown, clicks another element on the page, and
then there'll be no token to include in ABANDON_* with.

Bug: T162924
Change-Id: Ie2237aa55ea9a11070498b66c73b8bf1898d8d44
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/actions.js
M tests/node-qunit/actions.test.js
4 files changed, 24 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/90/348790/1


-- 
To view, visit https://gerrit.wikimedia.org/r/348790
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2237aa55ea9a11070498b66c73b8bf1898d8d44
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: WIP

2017-04-18 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348780 )

Change subject: WIP
..

WIP

Bug: T162924
Change-Id: I340dee6881437b254c53b187c15a1adad7769b27
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/actions.js
M src/reducers/eventLogging.js
M tests/node-qunit/actions.test.js
M tests/node-qunit/reducers/eventLogging.test.js
6 files changed, 48 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/80/348780/1


-- 
To view, visit https://gerrit.wikimedia.org/r/348780
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I340dee6881437b254c53b187c15a1adad7769b27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: reducers: Make LINK_CLICK finalize but not close

2017-04-16 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348321 )

Change subject: reducers: Make LINK_CLICK finalize but not close
..

reducers: Make LINK_CLICK finalize but not close

... the interaction.

Following on from Iccba3c4c, LINK_CLICK shouldn't be considered the end
of an interaction because the link or preview can still be abandoned by
the user. Unlike ABANDON_END and LINK_DWELL, therefore, LINK_CLICK
musn't destroy the interaction but indicate that no more events should
be enqueued for the interaction.

More concretely, if the user has clicked the link or the preview, then
a "dwelledButAbandoned" or "dismissed" event shouldn't be logged.

Changes:
* Distinguish between "finalizing" and "closing" an interaction, where
  the latter is the current behavior of ABANDON_END, LINK_DWELL, and
  LINK_CLICK, in the eventLogging reducer and associated tests.
* If the interaction is finalized, then either the "dwelledButAbandoned"
  or "dismissed" events shouldn't be logged.

Bug: T162924
Change-Id: I09d8776da992053f89a77508e29a7cde3cfeeac6
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
M tests/node-qunit/reducers/eventLogging.test.js
4 files changed, 103 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/21/348321/1


-- 
To view, visit https://gerrit.wikimedia.org/r/348321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09d8776da992053f89a77508e29a7cde3cfeeac6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: reducers: Update eventLogging documentation

2017-04-14 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348266 )

Change subject: reducers: Update eventLogging documentation
..

reducers: Update eventLogging documentation

Bug: T159490
Change-Id: Ica8363ffb166cf4e1583b481a7055f6d1678ccf4
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
3 files changed, 55 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/66/348266/1


-- 
To view, visit https://gerrit.wikimedia.org/r/348266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica8363ffb166cf4e1583b481a7055f6d1678ccf4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: dist: Bundle assets with webpack@2.4.1

2017-04-14 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348226 )

Change subject: dist: Bundle assets with webpack@2.4.1
..

dist: Bundle assets with webpack@2.4.1

Change-Id: I2d653bb50fdebce3a2b7ac3a60748cbb0b8b8f6d
---
M resources/dist/index.js
M resources/dist/index.js.map
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/26/348226/1


-- 
To view, visit https://gerrit.wikimedia.org/r/348226
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d653bb50fdebce3a2b7ac3a60748cbb0b8b8f6d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: WIP

2017-04-14 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348200 )

Change subject: WIP
..

WIP

Change-Id: If1ee1853ba7a9b2a66b24bb93b4e6062b92b0dba
---
M includes/PopupsHooks.php
1 file changed, 4 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/00/348200/1

diff --git a/includes/PopupsHooks.php b/includes/PopupsHooks.php
index 3429187..662b6bf 100644
--- a/includes/PopupsHooks.php
+++ b/includes/PopupsHooks.php
@@ -119,20 +119,12 @@
 */
public static function onResourceLoaderTestModules( array &$testModules,
ResourceLoader &$resourceLoader ) {
-   $localBasePath = __DIR__ . '/..';
-   $scripts = glob( 
"{$localBasePath}/tests/qunit/ext.popups/{,**/}*.test.js", GLOB_BRACE );
-   $start = strlen( $localBasePath ) + 1;
-
-   $scripts = array_map( function ( $script ) use ( $start ) {
-   return substr( $script, $start );
-   }, $scripts );
-
$testModules['qunit']['ext.popups.tests'] = [
-   'scripts' => $scripts,
-   'dependencies' => [
-   'ext.popups'
+   'scripts' => [
+   'tests/qunit/ext.popups/processLinks.test.js',
+   'src/processLinks.js',
],
-   'localBasePath' => $localBasePath,
+   'localBasePath' => __DIR__ . '/..',
'remoteExtPath' => 'Popups',
];
}

-- 
To view, visit https://gerrit.wikimedia.org/r/348200
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If1ee1853ba7a9b2a66b24bb93b4e6062b92b0dba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP Revert "Upgrade to jQuery v3"

2017-04-13 Thread Phuedx (Code Review)

Hello Krinkle, Jack Phoenix, jenkins-bot, Jforrester,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/348068

to review the following change.


Change subject: WIP Revert "Upgrade to jQuery v3"
..

WIP Revert "Upgrade to jQuery v3"

DO NOT SUBMIT

This reverts commit bf69459d5011f7970c159ae752ac399df174ccb3.

Change-Id: Ibc1f22d0f8544c3d0dcad23ad7b18d79be5a32cc
---
M RELEASE-NOTES-1.29
M includes/DefaultSettings.php
M resources/Resources.php
D resources/lib/jquery/jquery.migrate.js
D resources/lib/jquery/jquery3.js
5 files changed, 3 insertions(+), 10,812 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/68/348068/1


-- 
To view, visit https://gerrit.wikimedia.org/r/348068
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc1f22d0f8544c3d0dcad23ad7b18d79be5a32cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Phuedx 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP

2017-04-13 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348058 )

Change subject: WIP
..

WIP

Change-Id: Id5315b67ddd0e6be6cae5176377acda13f8dd9bb
---
M api.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/58/348058/1

diff --git a/api.php b/api.php
index a6ce3b2..1a37693 100644
--- a/api.php
+++ b/api.php
@@ -1,4 +1,4 @@
-https://gerrit.wikimedia.org/r/348058
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5315b67ddd0e6be6cae5176377acda13f8dd9bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.29.0-wmf.20]: formatter: Change log channel of infobox message

2017-04-12 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/347886 )

Change subject: formatter: Change log channel of infobox message
..

formatter: Change log channel of infobox message

By default, the minimum log level for Logstash is INFO [0]. The minimum
log level for the "mobile" channel, however, is DEBUG [1].

[0] 
https://github.com/wikimedia/operations-mediawiki-config/blob/8342bcbbd040bab1cd3b140b47a58f7ee08d1a46/wmf-config/InitialiseSettings.php#L4795
[1] 
https://github.com/wikimedia/operations-mediawiki-config/blob/8342bcbbd040bab1cd3b140b47a58f7ee08d1a46/wmf-config/InitialiseSettings.php#L4868

Bug: T149884
Change-Id: I61d20ea8dcc8cd63e826f56567302248b3c92f61
(cherry picked from commit 9da62ce9bb015427e3043f1aed6980db981a00d1)
---
M includes/MobileFormatter.php
M tests/phpunit/MobileFormatterTest.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/86/347886/1

diff --git a/includes/MobileFormatter.php b/includes/MobileFormatter.php
index 9a88fbb..0686414 100644
--- a/includes/MobileFormatter.php
+++ b/includes/MobileFormatter.php
@@ -265,7 +265,7 @@
private function logInfoboxesWrappedInContainers( $leadSectionBody, 
DOMXPath $xPath ) {
$infoboxes = $xPath->query( 
'.//table[contains(@class,"infobox")]', $leadSectionBody );
if ( $infoboxes->length > 0 ) {
-   \MediaWiki\Logger\LoggerFactory::getInstance( 
'MobileFrontend' )->debug(
+   \MediaWiki\Logger\LoggerFactory::getInstance( 'mobile' 
)->debug(
"Found infobox wrapped with container on 
{$this->title} (rev:{$this->revId})"
);
}
diff --git a/tests/phpunit/MobileFormatterTest.php 
b/tests/phpunit/MobileFormatterTest.php
index 05773fc..1e2973c 100644
--- a/tests/phpunit/MobileFormatterTest.php
+++ b/tests/phpunit/MobileFormatterTest.php
@@ -846,7 +846,7 @@
$this->assertContains( '0', $message );
} ) );
 
-   $this->setLogger( 'MobileFrontend', $loggerMock );
+   $this->setLogger( 'mobile', $loggerMock );
$formatter->filterContent( false, false, false, true );
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/347886
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61d20ea8dcc8cd63e826f56567302248b3c92f61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.29.0-wmf.20
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: reducers: Make LINK_CLICK finalize interaction

2017-04-12 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/347829 )

Change subject: reducers: Make LINK_CLICK finalize interaction
..

reducers: Make LINK_CLICK finalize interaction

... in the eventLogging reducer.

Like ABANDON_END, the LINK_CLICK should be considered the end of the
interaction in the context of the EventLogging instrumentation, i.e. no
events should be logged after the user clicks the preview or the link.

See T159490#3172692 for additional context.

Bug: T159490
Change-Id: Iccba3c4c2b6121016ff7923c11b1622bc046ad6b
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
M tests/node-qunit/reducers/eventLogging.test.js
4 files changed, 16 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/29/347829/1


-- 
To view, visit https://gerrit.wikimedia.org/r/347829
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccba3c4c2b6121016ff7923c11b1622bc046ad6b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: formatter: Change log level of infobox message

2017-04-11 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/347802 )

Change subject: formatter: Change log level of infobox message
..

formatter: Change log level of infobox message

I61d20ea was only partially correct. The

  'mobile' => 'debug',

entry of $wmgMonologChannels sets the minimum log level for the udp2log
handler. Unless the minimum log level isn't DEBUG, the Logstash handler
still requires a log level of INFO [0].

[0] 
https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/logging.php#L216

Bug: T149884
Change-Id: I426409fcd39d39b5e6d1173eb8b5e0e2ebfdf70e
---
M includes/MobileFormatter.php
M tests/phpunit/MobileFormatterTest.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/02/347802/1

diff --git a/includes/MobileFormatter.php b/includes/MobileFormatter.php
index 0686414..7644c70 100644
--- a/includes/MobileFormatter.php
+++ b/includes/MobileFormatter.php
@@ -265,7 +265,7 @@
private function logInfoboxesWrappedInContainers( $leadSectionBody, 
DOMXPath $xPath ) {
$infoboxes = $xPath->query( 
'.//table[contains(@class,"infobox")]', $leadSectionBody );
if ( $infoboxes->length > 0 ) {
-   \MediaWiki\Logger\LoggerFactory::getInstance( 'mobile' 
)->debug(
+   \MediaWiki\Logger\LoggerFactory::getInstance( 'mobile' 
)->info(
"Found infobox wrapped with container on 
{$this->title} (rev:{$this->revId})"
);
}
diff --git a/tests/phpunit/MobileFormatterTest.php 
b/tests/phpunit/MobileFormatterTest.php
index 1e2973c..174ce23 100644
--- a/tests/phpunit/MobileFormatterTest.php
+++ b/tests/phpunit/MobileFormatterTest.php
@@ -838,7 +838,7 @@
 
$loggerMock = $this->getMock( \Psr\Log\LoggerInterface::class );
$loggerMock->expects( $this->once() )
-   ->method( 'debug' )
+   ->method( 'info' )
->will( $this->returnCallback( function( $message ) use 
( $title ) {
// Debug message contains Page title
$this->assertContains( $title, $message );

-- 
To view, visit https://gerrit.wikimedia.org/r/347802
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I426409fcd39d39b5e6d1173eb8b5e0e2ebfdf70e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: formatter: Change log channel of infobox message

2017-04-11 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/347619 )

Change subject: formatter: Change log channel of infobox message
..

formatter: Change log channel of infobox message

By default, the minimum log level for Logstash is INFO [0]. The minimum
log level for the "mobile" channel, however, is DEBUG [1].

[0] 
https://github.com/wikimedia/operations-mediawiki-config/blob/8342bcbbd040bab1cd3b140b47a58f7ee08d1a46/wmf-config/InitialiseSettings.php#L4795
[1] 
https://github.com/wikimedia/operations-mediawiki-config/blob/8342bcbbd040bab1cd3b140b47a58f7ee08d1a46/wmf-config/InitialiseSettings.php#L4868

Bug: T149884
Change-Id: I61d20ea8dcc8cd63e826f56567302248b3c92f61
---
M includes/MobileFormatter.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/19/347619/1

diff --git a/includes/MobileFormatter.php b/includes/MobileFormatter.php
index 9a88fbb..0686414 100644
--- a/includes/MobileFormatter.php
+++ b/includes/MobileFormatter.php
@@ -265,7 +265,7 @@
private function logInfoboxesWrappedInContainers( $leadSectionBody, 
DOMXPath $xPath ) {
$infoboxes = $xPath->query( 
'.//table[contains(@class,"infobox")]', $leadSectionBody );
if ( $infoboxes->length > 0 ) {
-   \MediaWiki\Logger\LoggerFactory::getInstance( 
'MobileFrontend' )->debug(
+   \MediaWiki\Logger\LoggerFactory::getInstance( 'mobile' 
)->debug(
"Found infobox wrapped with container on 
{$this->title} (rev:{$this->revId})"
);
}

-- 
To view, visit https://gerrit.wikimedia.org/r/347619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61d20ea8dcc8cd63e826f56567302248b3c92f61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: actions: Add token to PREVIEW_SHOW

2017-04-11 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/347598 )

Change subject: actions: Add token to PREVIEW_SHOW
..

actions: Add token to PREVIEW_SHOW

Mirroring all other actions that are dispatched after some delay, add
the token to the PREVIEW_SHOW action.

Supporting changes:
* Pass the token to ext.popups.Preview#show so that it can be passed to
  actions#previewShow.

Bug: T159490
Change-Id: I128fd56e770ed09d5d0dc55db73d11b013049c79
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/actions.js
M src/changeListeners/render.js
M src/renderer.js
M tests/node-qunit/actions.test.js
M tests/node-qunit/changeListeners/render.test.js
7 files changed, 58 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/98/347598/1


-- 
To view, visit https://gerrit.wikimedia.org/r/347598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I128fd56e770ed09d5d0dc55db73d11b013049c79
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: reducers: Make PREVIEW_SHOW require a token

2017-04-11 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/347600 )

Change subject: reducers: Make PREVIEW_SHOW require a token
..

reducers: Make PREVIEW_SHOW require a token

Like the FETCH_COMPLETE and ABANDON_END actions, the PREVIEW_SHOW action
was delayed but not conditionally reduced. As ABANDON_END is delayed,
there's a potential for a race and if ABANDON_END is reduced before
PREVIEW_SHOW, then there's no interaction to reduce the action into,
which causes an error, e.g. T159490#3165276 and T162373. Making
PREVIEW_SHOW require a token stops the error occurring in this scenario.

An alternative would be to clear the timeout created in
ext.popups.Preview#show in #hide. However, this would be inconsistent
with actions#fetch and actions#abandon.

Bug: T159490
Change-Id: Ibd2c0c6f45e4392582cc6ed08517f6ca1146d57a
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
M tests/node-qunit/reducers/eventLogging.test.js
4 files changed, 18 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/00/347600/1


-- 
To view, visit https://gerrit.wikimedia.org/r/347600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd2c0c6f45e4392582cc6ed08517f6ca1146d57a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: DRY up eventLogging reducer

2017-04-11 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/347599 )

Change subject: Hygiene: DRY up eventLogging reducer
..

Hygiene: DRY up eventLogging reducer

Extract the repeated token testing for the FETCH_COMPLETE and
ABANDON_END actions.

Bug: T159490
Change-Id: Iebb167c4039f1685bb98ded7cbe5bb3ef3275dd7
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
3 files changed, 41 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/99/347599/1


-- 
To view, visit https://gerrit.wikimedia.org/r/347599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebb167c4039f1685bb98ded7cbe5bb3ef3275dd7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: pagePreviews: Enable NavPopups gadget detection

2017-04-09 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/347291 )

Change subject: pagePreviews: Enable NavPopups gadget detection
..

pagePreviews: Enable NavPopups gadget detection

Note well that the name and exact implementation of the gadget varies
but, inevitably, the NavPopups gadget's source is loaded from enwiki.
This is handled by defining the name of the gadget per wiki.

Also, tidy up some outdated comments around other Page Previews config
variables.

Bug: T160081
Change-Id: I918e611ecfa7497fc10cb523f7b456823431074b
---
M wmf-config/InitialiseSettings.php
1 file changed, 40 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/91/347291/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 23eac41..ec0ffb2 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -13323,15 +13323,12 @@
'default' => false,
'sewikimedia' => true, // T68374
 
-   // T136602: Make Page Previews enabled by default for the following 
"stage
-   // 0" wikis. Note well that enabling Page Previews by default on hewiki 
is
-   // blocked on T160614.
+   // T136602, T162162: Make Page Previews enabled by default for the 
following
+   // "stage 0" wikis.
'itwiki' => true,
'ruwiki' => true,
'elwiki' => true,
'cawiki' => true,
-
-   // T162162
'hewiki' => true,
'huwiki' => true,
 ],
@@ -13382,6 +13379,44 @@
'huwiki' => true,
 ],
 
+// T160081 (and others): Make sure that Page Previews can detect the many, many
+// variants of the NavPopups gadget.
+//
+// Generated using go_go_gadget_export.php from
+// https://gist.github.com/phuedx/8dd383e9b444270df6d068564aad9412.
+'wgPopupsConflictingNavPopupsGadgetName' => [
+   'default' => 'Navigation_popups',
+   'af' => 'popups',
+   'av' => 'popups',
+   'az' => 'popups',
+   'azb' => 'popups',
+   'be' => 'popups',
+   'br' => 'Popups',
+   'da' => 'Popups',
+   'de' => 'navigation-popups',
+   'el' => 'popupdelay',
+   'eo' => 'Popups',
+   'es' => 'Navigation_popups ',
+   'fa' => 'popups',
+   'fi' => 'popups',
+   'fr' => 'Popups ',
+   'gag' => 'popups',
+   'he' => 'popup',
+   'id' => 'NavPopups',
+   'min' => 'NavPopups',
+   'mzn' => 'popups',
+   'nl' => 'Navigatie popups',
+   'oc' => 'Popups',
+   'pl' => 'Navigation popups ',
+   'ro' => 'popups',
+   'ru' => 'popups',
+   'simple' => 'Navigation_popups-API',
+   'sr' => 'Popups',
+   'tg' => 'popups',
+   'vec' => 'Popup',
+   'yi' => 'NavigationPopups',
+],
+
 'wmgULSCompactLanguageLinksBetaFeature' => [
'default' => true,
'testwiki' => false,

-- 
To view, visit https://gerrit.wikimedia.org/r/347291
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I918e611ecfa7497fc10cb523f7b456823431074b
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Remove dependency on es5-shim RL module

2017-04-08 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/347148 )

Change subject: Remove dependency on es5-shim RL module
..

Remove dependency on es5-shim RL module

Per I95400637, the es5-shim module is now deprecated.

Change-Id: Ia00f6c18c8d20f8a98d9dcd439af5aa5baba0d73
---
M extension.json
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/48/347148/1

diff --git a/extension.json b/extension.json
index 6abe7c1..6f0a3e3 100644
--- a/extension.json
+++ b/extension.json
@@ -106,7 +106,6 @@
"popups-preview-footer-read"
],
"dependencies": [
-   "es5-shim",
"ext.popups.images",
"mediawiki.experiments",
"mediawiki.storage",

-- 
To view, visit https://gerrit.wikimedia.org/r/347148
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia00f6c18c8d20f8a98d9dcd439af5aa5baba0d73
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Reduce nesting of test cases

2017-04-07 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/346981 )

Change subject: Hygiene: Reduce nesting of test cases
..

Hygiene: Reduce nesting of test cases

The ABANDON_START action test cases were (accidentally?) nested under
the FETCH_COMPLETE action test cases...

Bug: T162373
Change-Id: Ia7866178162512602dedd7f70d62c17995ee5076
---
M tests/node-qunit/reducers/eventLogging.test.js
1 file changed, 13 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/81/346981/1

diff --git a/tests/node-qunit/reducers/eventLogging.test.js 
b/tests/node-qunit/reducers/eventLogging.test.js
index 5a24acf..d807204 100644
--- a/tests/node-qunit/reducers/eventLogging.test.js
+++ b/tests/node-qunit/reducers/eventLogging.test.js
@@ -371,22 +371,22 @@
state,
'It should NOOP if the interaction has been finalised.'
);
+} );
 
-   QUnit.test( 'ABANDON_START', function ( assert ) {
-   var state = {
-   interaction: {}
-   };
+QUnit.test( 'ABANDON_START', function ( assert ) {
+   var state = {
+   interaction: {}
+   };
 
-   state = eventLogging( state, {
-   type: 'ABANDON_START',
-   timestamp: Date.now()
-   } );
-
-   assert.notOk(
-   state.interaction.isUserDwelling,
-   'It should mark the link or preview as having been 
abandoned.'
-   );
+   state = eventLogging( state, {
+   type: 'ABANDON_START',
+   timestamp: Date.now()
} );
+
+   assert.notOk(
+   state.interaction.isUserDwelling,
+   'It should mark the link or preview as having been abandoned.'
+   );
 } );
 
 QUnit.test( 'ABANDON_END', function ( assert ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/346981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7866178162512602dedd7f70d62c17995ee5076
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: reducers: Reduce FETCH_COMPLETE if token matches

2017-04-07 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/346979 )

Change subject: reducers: Reduce FETCH_COMPLETE if token matches
..

reducers: Reduce FETCH_COMPLETE if token matches

... instead of using the active element.

In the case of the eventLogging reducer, this fixes scenario 4.1 from
T159490#3150331, which was caused by late FETCH_COMPLETE actions being
reduced regardless of whether interaction had been finalised or a new
interaction had started.

Bug: T159490
Change-Id: If9d718625b0302ea2f75a778005643b4eef62bde
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/reducers/eventLogging.js
M src/reducers/preview.js
M tests/node-qunit/reducers/eventLogging.test.js
M tests/node-qunit/reducers/preview.test.js
6 files changed, 68 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/79/346979/1


-- 
To view, visit https://gerrit.wikimedia.org/r/346979
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9d718625b0302ea2f75a778005643b4eef62bde
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: WIP

2017-04-07 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/346970 )

Change subject: WIP
..

WIP

Change-Id: Ic71dd3ce5e7933273f84a9a64d41e7f3a4cb03f4
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/actions.js
M tests/node-qunit/actions.test.js
4 files changed, 40 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/70/346970/1


-- 
To view, visit https://gerrit.wikimedia.org/r/346970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic71dd3ce5e7933273f84a9a64d41e7f3a4cb03f4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Remove trailing whitespace

2017-04-06 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/346834 )

Change subject: Hygiene: Remove trailing whitespace
..

Hygiene: Remove trailing whitespace

... from tests/node-qunit/actions.test.js.

Spotted during the review of Ic3165620.

Change-Id: I0fb78d2dc3aadc6b42bd9f441bca9a72300f720c
---
M tests/node-qunit/actions.test.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/34/346834/1

diff --git a/tests/node-qunit/actions.test.js b/tests/node-qunit/actions.test.js
index 262ef85..86e9be1 100644
--- a/tests/node-qunit/actions.test.js
+++ b/tests/node-qunit/actions.test.js
@@ -340,7 +340,7 @@
args,
result = {},
that = this;
- 
+
whenSpy = this.sandbox.stub( $, 'when' )
.returns( whenDeferred.promise() );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/346834
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fb78d2dc3aadc6b42bd9f441bca9a72300f720c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[wmf/1.29.0-wmf.19]: actions: Correctly delay FETCH_COMPLETE

2017-04-06 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/346832 )

Change subject: actions: Correctly delay FETCH_COMPLETE
..

actions: Correctly delay FETCH_COMPLETE

I496fe317 caused a regression where the FETCH_COMPLETE was delayed for a
total of 650 ms rather than 500 ms. This is evidenced by a 150 ms step
in the median Time To Preview immediately after today's (Thursday, 6th
April) MediaWiki train [0].

[0] 
https://grafana.wikimedia.org/dashboard/db/reading-web-page-previews?refresh=1m=1=1491505806387=1491507027263

Change-Id: Ic31656208671766f2c08cfaf55babba64455a614
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/actions.js
M tests/node-qunit/actions.test.js
4 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/32/346832/1


-- 
To view, visit https://gerrit.wikimedia.org/r/346832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic31656208671766f2c08cfaf55babba64455a614
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: wmf/1.29.0-wmf.19
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: actions: Correctly delay FETCH_COMPLETE

2017-04-06 Thread Phuedx (Code Review)

Phuedx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/346830 )

Change subject: actions: Correctly delay FETCH_COMPLETE
..

actions: Correctly delay FETCH_COMPLETE

I496fe317 caused a regression where the FETCH_COMPLETE was delayed for a
total of 650 ms rather than 500 ms. This is evidenced by a 150 ms step
in the median Time To Preview immediately after today's (Thursday, 6th
April) MediaWiki train [0].

[0] 
https://grafana.wikimedia.org/dashboard/db/reading-web-page-previews?refresh=1m=1=1491505806387=1491507027263

Change-Id: Ic31656208671766f2c08cfaf55babba64455a614
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/actions.js
M tests/node-qunit/actions.test.js
4 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/30/346830/1


-- 
To view, visit https://gerrit.wikimedia.org/r/346830
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic31656208671766f2c08cfaf55babba64455a614
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

1 2 3 4 5 6 7 8 >

1 - 100 of 708 matches

Mail list logo