Re: [meta-freescale] imx-uuc: typo error

[Otavio Salvador]

Hello Bas,

On Sat, Sep 23, 2017 at 4:44 PM, Bas Mevissen  wrote:
> On 30/08/17 21:40, Otavio Salvador wrote:
>
> Hi Otavio, Teemu,
>
>> I did the update and merged the fix on master branch. Teemu please
>> give it a go and let me know if it works fine to you so we can
>> backport this to the other branches.
>>
>
> Was this tested? I only see CFLAGS added to the Makefile and not the LDFLAGS
> as suggested by Otavio?

So far, it seems to be working fine. It has got some fixes on the
Makefile which has been commited in the repository so bumping the
revision did address it.

Please let me know if it fails on you.
>
> Cheers,
>
> Bas.
> --
> ___
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale



-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Bas Mevissen]

On 30/08/17 21:40, Otavio Salvador wrote:

Hi Otavio, Teemu,


I did the update and merged the fix on master branch. Teemu please
give it a go and let me know if it works fine to you so we can
backport this to the other branches.



Was this tested? I only see CFLAGS added to the Makefile and not the 
LDFLAGS as suggested by Otavio?


Cheers,

Bas.
--
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Bas Mevissen]

On 30/08/2017 21:40, Otavio Salvador wrote:

Hello Bas,
Hello Teemu,


I never got around resending the patch using git. The host I was working on
didn't have things configured to do so.


It was a shame. A community health requires people to spend the time
to contribute back when they have the opportunity.



I basically agree, however the patch itself was ready and good to go. 
Requiring people to use stuff like git format-patch and git send-email 
is the actual shame. Figuring out how these things work, setting up a 
mail server on a (scrap) virtual host used for the development at hand 
and having the correct e-mail addresses (signing address different from 
mailing list address...) takes unnecessary time.


So IMO, opportunity is more than being able to do everything according 
to a well-established process. Sometimes, time only permits to make the 
actual fix and improve it (over my own requirements) for general usage.



I did the update and merged the fix on master branch. Teemu please
give it a go and let me know if it works fine to you so we can
backport this to the other branches.


Thanks a lot. Your work is definitely appreciated.

Cheers,

Bas.

--
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Otavio Salvador]

Hello Bas,
Hello Teemu,

> I never got around resending the patch using git. The host I was working on
> didn't have things configured to do so.

It was a shame. A community health requires people to spend the time
to contribute back when they have the opportunity.

> Best for now is to create .bbappend for yourself to add the patch I send to
> the mailing list to your build.

I did the update and merged the fix on master branch. Teemu please
give it a go and let me know if it works fine to you so we can
backport this to the other branches.

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Bas Mevissen]

On 16/08/2017 08:41, Keskinarkaus, Teemu wrote:


-Original Message-
From: meta-freescale-boun...@yoctoproject.org 
[mailto:meta-freescale-boun...@yoctoproject.org] On Behalf Of Otavio Salvador
Sent: 10. huhtikuuta 2017 17:01
To: Bas Mevissen
Cc: meta-freescale@yoctoproject.org
Subject: Re: [meta-freescale] imx-uuc: typo error

On Mon, Apr 10, 2017 at 6:27 AM, Bas Mevissen <ab...@basmevissen.nl> wrote:



On 07/04/2017 22:14, Otavio Salvador wrote:

(...)


Instead, adding LDFLAGS on the CC should fix the real error.



That's a better idea indeed. Attached patch fixes the protocol typo
and fixes the Makefile to resolve the QA issue detected.


The patch seems fine but you must export it using git-format-patch and send it 
using git send-email.


> Hi,
>
> I took latest sources for meta-freescale from git.yoctoproject and 
github and neither one had this fix. (I tried, master, morty and pyro 
branches). Has it been committed yet or is this needed to be done manually?

>
> -Teemu Keskinarkaus

(please don't top-post, fixed it for you)

I never got around resending the patch using git. The host I was working 
on didn't have things configured to do so.


Best for now is to create .bbappend for yourself to add the patch I send 
to the mailing list to your build.


Cheers,

Bas.
--
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Keskinarkaus, Teemu]

Hi,

I took latest sources for meta-freescale from git.yoctoproject and github and 
neither one had this fix. (I tried, master, morty and pyro branches). Has it 
been committed yet or is this needed to be done manually?

-Teemu Keskinarkaus

-Original Message-
From: meta-freescale-boun...@yoctoproject.org 
[mailto:meta-freescale-boun...@yoctoproject.org] On Behalf Of Otavio Salvador
Sent: 10. huhtikuuta 2017 17:01
To: Bas Mevissen
Cc: meta-freescale@yoctoproject.org
Subject: Re: [meta-freescale] imx-uuc: typo error

On Mon, Apr 10, 2017 at 6:27 AM, Bas Mevissen <ab...@basmevissen.nl> wrote:
>
>
> On 07/04/2017 22:14, Otavio Salvador wrote:
>
> (...)
>>
>> Instead, adding LDFLAGS on the CC should fix the real error.
>>
>
> That's a better idea indeed. Attached patch fixes the protocol typo
> and fixes the Makefile to resolve the QA issue detected.

The patch seems fine but you must export it using git-format-patch and send it 
uusing git send-email.

--
Otavio Salvador O.S. Systems
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.ossystems.com.br=02%7C01%7Cteemu.keskinarkaus%40crosscontrol.com%7C9b8521989e7b4833e06808d4801a344c%7C1602ae82026640d6910b11680fe0f6a5%7C0%7C0%7C636274297410641040=XRkyTwAHWbX3ugcjpWtO79Rv0xZzH%2Fl03roJDo2rCP0%3D=0

https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcode.ossystems.com.br=02%7C01%7Cteemu.keskinarkaus%40crosscontrol.com%7C9b8521989e7b4833e06808d4801a344c%7C1602ae82026640d6910b11680fe0f6a5%7C0%7C0%7C636274297410651057=8YNCxOQBvMKp2MB5SEgKE3Y%2FsJLnVmxzFrTdsvapcpQ%3D=0
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
--
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.yoctoproject.org%2Flistinfo%2Fmeta-freescale=02%7C01%7Cteemu.keskinarkaus%40crosscontrol.com%7C9b8521989e7b4833e06808d4801a344c%7C1602ae82026640d6910b11680fe0f6a5%7C0%7C0%7C636274297410651057=sUeG%2FjM6%2Bh4RVVls5UDTZsHk%2BPpyhQ6MKcsMTw6eDbI%3D=0



Actuant Corporation Email Notice

This message is intended only for the use of the Addressee and may contain 
information that is PRIVILEGED and/or CONFIDENTIAL.
This email is intended only for the personal and confidential use of the 
recipient(s) named above. If the reader of this email is not an intended 
recipient, you have received this email in error and any review, dissemination, 
distribution or copying is strictly prohibited.
If you have received this email in error, please notify the sender immediately 
by return mail and permanently delete the copy you received.

Thank you.
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Esponde, Joel]

Yes I am using Morty 16.0.1.

Joël Esponde
Honeywell | Safety and Productivity Solutions

> -Message d'origine-
> De : meta-freescale-boun...@yoctoproject.org [mailto:meta-freescale-
> boun...@yoctoproject.org] De la part de Esponde, Joel
> Envoyé : lundi 10 avril 2017 13:05
> À : Bas Mevissen <ab...@basmevissen.nl>; meta-
> freesc...@yoctoproject.org
> Objet : Re: [meta-freescale] imx-uuc: typo error
> 
>  HONEYWELL WARNING: This email was sent from outside of Honeywell
> and the sender cannot be verified. Use CAUTION before opening file
> attachments, links, or replying to the email. For additional information 
> please
> visit go.honeywell.com/Spoof 
> 
> > -Message d'origine-
> > De : Bas Mevissen [mailto:ab...@basmevissen.nl]
> > Envoyé : vendredi 7 avril 2017 16:24
> > À : Esponde, Joel <joel.espo...@honeywell.com>; meta-
> > freesc...@yoctoproject.org
> > Objet : Re: [meta-freescale] imx-uuc: typo error
> >
> > On 07/04/2017 11:53, Esponde, Joel wrote:
> > >
> > > For this kind of very small issue, is it sufficient to send just an
> > > email like this?
> > >
> > > Or do I need to follow any patch based workflow?
> > >
> > >
> >
> > This reminds me of an issue I ran into with the same package. It failed with
> > QA issues:
> >
> > ERROR: imx-uuc-0.5.1+gitAUTOINC+3440b11083-r1 do_package_qa: QA
> > Issue:
> > No GNU_HASH in the elf binary:
> > '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-
> > uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-
> uuc/usr/bin/uuc'
> > No GNU_HASH in the elf binary:
> > '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-
> > uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-
> > uuc/usr/bin/sdimage'
> > [ldflags]
> >
> 
> Hi,
> 
> I did not see that issue on my side.
> It built just fine.
> Do you have an explanation on that?
> 
> Joël Esponde
> Honeywell | Safety and Productivity Solutions
> 
> --
> ___
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Otavio Salvador]

On Mon, Apr 10, 2017 at 6:27 AM, Bas Mevissen  wrote:
>
>
> On 07/04/2017 22:14, Otavio Salvador wrote:
>
> (...)
>>
>> Instead, adding LDFLAGS on the CC should fix the real error.
>>
>
> That's a better idea indeed. Attached patch fixes the protocol typo and
> fixes the Makefile to resolve the QA issue detected.

The patch seems fine but you must export it using git-format-patch and
send it uusing git send-email.

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Esponde, Joel]

> -Message d'origine-
> De : Bas Mevissen [mailto:ab...@basmevissen.nl]
> Envoyé : vendredi 7 avril 2017 16:24
> À : Esponde, Joel <joel.espo...@honeywell.com>; meta-
> freesc...@yoctoproject.org
> Objet : Re: [meta-freescale] imx-uuc: typo error
> 
> On 07/04/2017 11:53, Esponde, Joel wrote:
> >
> > For this kind of very small issue, is it sufficient to send just an
> > email like this?
> >
> > Or do I need to follow any patch based workflow?
> >
> >
> 
> This reminds me of an issue I ran into with the same package. It failed with
> QA issues:
> 
> ERROR: imx-uuc-0.5.1+gitAUTOINC+3440b11083-r1 do_package_qa: QA
> Issue:
> No GNU_HASH in the elf binary:
> '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-
> uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/uuc'
> No GNU_HASH in the elf binary:
> '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-
> uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-
> uuc/usr/bin/sdimage'
> [ldflags]
> 

Hi,

I did not see that issue on my side.
It built just fine.
Do you have an explanation on that?

Joël Esponde
Honeywell | Safety and Productivity Solutions

-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Bas Mevissen]

On 10/04/2017 13:05, Esponde, Joel wrote:
(...)

This reminds me of an issue I ran into with the same package. It failed with
QA issues:

ERROR: imx-uuc-0.5.1+gitAUTOINC+3440b11083-r1 do_package_qa: QA
Issue:
No GNU_HASH in the elf binary:
'/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-
uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/uuc'
No GNU_HASH in the elf binary:
'/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-
uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-
uuc/usr/bin/sdimage'
[ldflags]



Hi,

I did not see that issue on my side.
It built just fine.
Do you have an explanation on that?



I did not set any extra QA checks in my local.conf. Are you working on 
Morty too?


Cheers,

Bas.


--
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Esponde, Joel]

> -Message d'origine-
> De : Bas Mevissen [mailto:ab...@basmevissen.nl]
> Envoyé : lundi 10 avril 2017 11:28
> À : Otavio Salvador <otavio.salva...@ossystems.com.br>
> Cc : Esponde, Joel <joel.espo...@honeywell.com>; meta-
> freesc...@yoctoproject.org
> Objet : Re: [meta-freescale] imx-uuc: typo error
> 
> 
> 
> On 07/04/2017 22:14, Otavio Salvador wrote:
> 
> (...)
> >
> > Instead, adding LDFLAGS on the CC should fix the real error.
> >
> 
> That's a better idea indeed. Attached patch fixes the protocol typo and fixes
> the Makefile to resolve the QA issue detected.
> 
> Cheers,
> 
> Bas.

Thank you for considering my fix and creating a patch for that!

Joël Esponde
Honeywell | Safety and Productivity Solutions
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Bas Mevissen]

On 07/04/2017 22:14, Otavio Salvador wrote:

(...)
>
> Instead, adding LDFLAGS on the CC should fix the real error.
>

That's a better idea indeed. Attached patch fixes the protocol typo and
fixes the Makefile to resolve the QA issue detected.

Cheers,

Bas.

- Fix typo in download protocol (found by Joel Esponde)
- Fixed QA issue below by adding LDFLAGS (as suggested by Otavio Salvador)

ERROR: imx-uuc-0.5.1+gitAUTOINC+3440b11083-r1 do_package_qa: QA Issue: No GNU_HASH in the elf binary: '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/uuc'
No GNU_HASH in the elf binary: '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/sdimage' [ldflags]

Found-by: Joel Esponde 
Signed-off-by: Bas Mevissen 
diff --git a/recipes-bsp/imx-uuc/imx-uuc/add-ldflags.patch b/recipes-bsp/imx-uuc/imx-uuc/add-ldflags.patch
new file mode 100644
index 000..ee46446
--- /dev/null
+++ b/recipes-bsp/imx-uuc/imx-uuc/add-ldflags.patch
@@ -0,0 +1,17 @@
+diff --git a/Makefile b/Makefile
+index df19c9f..384035b 100644
+--- a/Makefile
 b/Makefile
+@@ -5,10 +5,10 @@ BINDIR ?= /usr/bin
+ all: uuc sdimage
+ 
+ uuc: uu.c
+-	$(CC)  uu.c -o uuc -lpthread
++	$(CC) uu.c -o uuc $(LDFLAGS) -lpthread
+ 
+ sdimage: sdimage.c
+-	$(CC) sdimage.c -o sdimage
++	$(CC) sdimage.c -o sdimage $(LDFLAGS)
+ 
+ install:
+ 	install -d $(DESTDIR)$(BINDIR)
diff --git a/recipes-bsp/imx-uuc/imx-uuc_git.bb b/recipes-bsp/imx-uuc/imx-uuc_git.bb
index 6fb838a..f99e81b 100644
--- a/recipes-bsp/imx-uuc/imx-uuc_git.bb
+++ b/recipes-bsp/imx-uuc/imx-uuc_git.bb
@@ -11,7 +11,9 @@ inherit autotools-brokensep
 PR = "r1"
 PV = "0.5.1+git${SRCPV}"
 
-SRC_URI = "git://github.com/NXPmicro/imx-uuc.git;protocal=https"
+SRC_URI = "git://github.com/NXPmicro/imx-uuc.git;protocol=https \
+   file://add-ldflags.patch"
+
 SRCREV = "3440b1108373e79669cc17ba1d2be91a123a2053"
 
 S = "${WORKDIR}/git"
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Otavio Salvador]

On Fri, Apr 7, 2017 at 11:23 AM, Bas Mevissen  wrote:
>
> On 07/04/2017 11:53, Esponde, Joel wrote:
>>
>>
>> For this kind of very small issue, is it sufficient to send just an
>> email like this?
>>
>> Or do I need to follow any patch based workflow?
>>
>>
>
> This reminds me of an issue I ran into with the same package. It failed
> with QA issues:
>
> ERROR: imx-uuc-0.5.1+gitAUTOINC+3440b11083-r1 do_package_qa: QA Issue:
> No GNU_HASH in the elf binary:
> '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/uuc'
> No GNU_HASH in the elf binary:
> '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/sdimage'
> [ldflags]
>
> I don't think it is worthwhile to fix the source, so I would propose to
> add to the recipe:
>
> INSANE_SKIP_${PN} += "ldflags"


Instead, adding LDFLAGS on the CC should fix the real error.


-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] imx-uuc: typo error

[Bas Mevissen]

On 07/04/2017 11:53, Esponde, Joel wrote:


For this kind of very small issue, is it sufficient to send just an
email like this?

Or do I need to follow any patch based workflow?




This reminds me of an issue I ran into with the same package. It failed
with QA issues:

ERROR: imx-uuc-0.5.1+gitAUTOINC+3440b11083-r1 do_package_qa: QA Issue:
No GNU_HASH in the elf binary:
'/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/uuc'
No GNU_HASH in the elf binary:
'/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/sdimage'
[ldflags]

I don't think it is worthwhile to fix the source, so I would propose to
add to the recipe:

INSANE_SKIP_${PN} += "ldflags"

Attached patch (including the typo fix) tested against current state of
Morty.

Cheers,

Bas.

- Fix typo in download protocol (found by Joel Esponde)
- Mitigate QA issue not worthwhile to fix:

ERROR: imx-uuc-0.5.1+gitAUTOINC+3440b11083-r1 do_package_qa: QA Issue: No GNU_HASH in the elf binary: '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/uuc'
No GNU_HASH in the elf binary: '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/sdimage' [ldflags]

Solved by adding INSANE_SKIP to recipe.


Found-by: Joel Esponde 
Signed-off-by: Bas Mevissen 
diff --git a/recipes-bsp/imx-uuc/imx-uuc_git.bb b/recipes-bsp/imx-uuc/imx-uuc_git.bb
index 6fb838a..4b3de09 100644
--- a/recipes-bsp/imx-uuc/imx-uuc_git.bb
+++ b/recipes-bsp/imx-uuc/imx-uuc_git.bb
@@ -8,10 +8,12 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 inherit autotools-brokensep
 
+INSANE_SKIP_${PN} += "ldflags"
+
 PR = "r1"
 PV = "0.5.1+git${SRCPV}"
 
-SRC_URI = "git://github.com/NXPmicro/imx-uuc.git;protocal=https"
+SRC_URI = "git://github.com/NXPmicro/imx-uuc.git;protocol=https"
 SRCREV = "3440b1108373e79669cc17ba1d2be91a123a2053"
 
 S = "${WORKDIR}/git"

-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale