[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 # [Codecov](https://codecov.io/gh/apache/superset/pull/15320?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15320](https://codecov.io/gh/apache/superset/pull/15320?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f8318d2) into [master](https://codecov.io/gh/apache/superset/commit/c211f7df8e5d3ebe0d0424016354f27aef5882aa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c211f7d) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #15320 +/- ## === Coverage 77.23% 77.23% === Files 973 973 Lines 5047850478 Branches 6182 6182 === Hits3898538985 Misses 1128711287 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.41% <ø> (ø)` | | | mysql | `81.68% <ø> (ø)` | | | postgres | `81.69% <ø> (ø)` | | | presto | `81.40% <ø> (ø)` | | | python | `82.23% <ø> (ø)` | | | sqlite | `81.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15320?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15320?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [c211f7d...f8318d2](https://codecov.io/gh/apache/superset/pull/15320?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] jinghua-qa commented on issue #15322: [native filter] Enlarged default value window overlap with Multiple selection option.
jinghua-qa commented on issue #15322: URL: https://github.com/apache/superset/issues/15322#issuecomment-866592551 also clicking 'X' on the second line of the default value has no reponse https://user-images.githubusercontent.com/81597121/123052833-1bdf6300-d3b8-11eb-8856-4ac5bbe0babb.mov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 # [Codecov](https://codecov.io/gh/apache/superset/pull/15320?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15320](https://codecov.io/gh/apache/superset/pull/15320?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f8318d2) into [master](https://codecov.io/gh/apache/superset/commit/c211f7df8e5d3ebe0d0424016354f27aef5882aa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c211f7d) will **decrease** coverage by `0.23%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15320 +/- ## == - Coverage 77.23% 76.99% -0.24% == Files 973 973 Lines 5047850478 Branches 6182 6182 == - Hits3898538867 -118 - Misses 1128711405 +118 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.68% <ø> (ø)` | | | postgres | `81.69% <ø> (ø)` | | | presto | `?` | | | python | `81.78% <ø> (-0.45%)` | :arrow_down: | | sqlite | `81.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <ø> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.95%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-1.65%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.76% <0.00%> (-0.27%)` | :arrow_down: | |
[GitHub] [superset] zhaoyongjie commented on a change in pull request #15318: fix: nvd3 bar chart sortby metric
zhaoyongjie commented on a change in pull request #15318: URL: https://github.com/apache/superset/pull/15318#discussion_r656789078 ## File path: tests/core_tests.py ## @@ -999,7 +1000,8 @@ def test_explore_json_dist_bar_order(self): SELECT count(name) AS count_name, count(ds) AS count_ds FROM birth_names WHERE ds >= '1921-01-22 00:00:00.00' AND ds < '2021-01-22 00:00:00.00' -GROUP BY name ORDER BY count_name DESC, count_ds DESC Review comment: For the distributed bar only a single metric can be sorted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15319: fix: Capitalize time granularity weekdays
codecov[bot] commented on pull request #15319: URL: https://github.com/apache/superset/pull/15319#issuecomment-866574864 # [Codecov](https://codecov.io/gh/apache/superset/pull/15319?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15319](https://codecov.io/gh/apache/superset/pull/15319?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b53fbdb) into [master](https://codecov.io/gh/apache/superset/commit/c211f7df8e5d3ebe0d0424016354f27aef5882aa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c211f7d) will **decrease** coverage by `0.16%`. > The diff coverage is `100.00%`. > :exclamation: Current head b53fbdb differs from pull request most recent head bb45da8. Consider uploading reports for the commit bb45da8 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15319?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15319 +/- ## == - Coverage 77.23% 77.07% -0.17% == Files 973 973 Lines 5047850478 Branches 6182 6182 == - Hits3898538904 -81 - Misses 1128711368 +81 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `?` | | | postgres | `81.70% <ø> (+<0.01%)` | :arrow_up: | | presto | `81.40% <ø> (ø)` | | | python | `81.92% <ø> (-0.31%)` | :arrow_down: | | sqlite | `81.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15319?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.37% <ø> (ø)` | | | [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `83.95% <100.00%> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.85% <0.00%> (-4.29%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.23% <0.00%> (-0.79%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15319/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.10% <0.00%> (-0.44%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15318: fix: nvd3 bar chart sortby metric
codecov[bot] edited a comment on pull request #15318: URL: https://github.com/apache/superset/pull/15318#issuecomment-866595851 # [Codecov](https://codecov.io/gh/apache/superset/pull/15318?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15318](https://codecov.io/gh/apache/superset/pull/15318?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (da4d734) into [master](https://codecov.io/gh/apache/superset/commit/ab153e66cc6a3ad6a55d9d2b19aef3ef2f9f2625?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ab153e6) will **decrease** coverage by `0.15%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15318 +/- ## == - Coverage 77.14% 76.99% -0.16% == Files 973 973 Lines 5047350481 +8 Branches 6183 6183 == - Hits3893838867 -71 - Misses 1132911408 +79 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.68% <100.00%> (-0.01%)` | :arrow_down: | | postgres | `81.69% <100.00%> (-0.01%)` | :arrow_down: | | python | `81.78% <100.00%> (-0.30%)` | :arrow_down: | | sqlite | `81.33% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdml6LnB5) | `56.52% <100.00%> (+0.04%)` | :arrow_up: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-1.06%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-0.24%)` | :arrow_down: | | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.93% <0.00%>
[GitHub] [superset] codecov[bot] commented on pull request #15304: feat(viz): add categories to the viz picker
codecov[bot] commented on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 # [Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15304](https://codecov.io/gh/apache/superset/pull/15304?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4cc9084) into [fancy-viz-select-modal](https://codecov.io/gh/apache/superset/commit/c99a44fc70f5c6e1f075e89379df4dd9045abfaa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c99a44f) will **decrease** coverage by `0.25%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## fancy-viz-select-modal #15304 +/- ## == - Coverage 77.79% 77.54% -0.26% == Files 966 966 Lines 4965249652 Branches 6319 6319 == - Hits3862738502 -125 - Misses 1082410949 +125 Partials 201 201 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `?` | | | postgres | `81.73% <ø> (ø)` | | | presto | `?` | | | python | `81.77% <ø> (-0.48%)` | :arrow_down: | | sqlite | `81.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-1.66%)` | :arrow_down: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.85% <0.00%> (-1.43%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.97% <0.00%> (-1.05%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 # [Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15304](https://codecov.io/gh/apache/superset/pull/15304?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4cc9084) into [fancy-viz-select-modal](https://codecov.io/gh/apache/superset/commit/c99a44fc70f5c6e1f075e89379df4dd9045abfaa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c99a44f) will **decrease** coverage by `0.23%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## fancy-viz-select-modal #15304 +/- ## == - Coverage 77.79% 77.56% -0.24% == Files 966 966 Lines 4965249652 Branches 6319 6319 == - Hits3862738512 -115 - Misses 1082410939 +115 Partials 201 201 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.70% <ø> (ø)` | | | postgres | `81.73% <ø> (ø)` | | | presto | `?` | | | python | `81.81% <ø> (-0.44%)` | :arrow_down: | | sqlite | `81.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-1.66%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.76% <0.00%> (-0.27%)` | :arrow_down: | |
[GitHub] [superset] jinghua-qa opened a new issue #15322: [native filter] Enlarged default value window overlap with Multiple selection option.
jinghua-qa opened a new issue #15322: URL: https://github.com/apache/superset/issues/15322 https://user-images.githubusercontent.com/81597121/123050821-f4879680-d3b5-11eb-93e6-bb40472728ef.png;> ## Description When select 3+ default value, the default value window will be enlarge and overlap with Multiple selection option. ## Screenshot environment: superset master ## Design input -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #15184: fix: datasource payload is incorrect
dpgaspar commented on a change in pull request #15184:
URL: https://github.com/apache/superset/pull/15184#discussion_r656875243
##
File path: superset/connectors/connector_registry.py
##
@@ -73,6 +74,47 @@ def get_all_datasources(cls, session: Session) ->
List["BaseDatasource"]:
datasources.extend(qry.all())
return datasources
+@classmethod
+def get_user_datasources(cls, session: Session) -> List["BaseDatasource"]:
+from superset import security_manager
+
+# collect datasources which the user has explicit permissions to
+user_perms = security_manager.user_view_menu_names("datasource_access")
+schema_perms = security_manager.user_view_menu_names("schema_access")
+user_datasources = []
+for datasource_class in ConnectorRegistry.sources.values():
+user_datasources.extend(
+session.query(datasource_class)
+.filter(
+or_(
+datasource_class.perm.in_(user_perms),
+datasource_class.schema_perm.in_(schema_perms),
+)
+)
+.all()
+)
+
+# get all datasources and organize by database -> schema -> datasource
+all_datasources = cls.get_all_datasources(session)
+hierarchy: Dict[
+"Database", Dict[Optional[str], Set["BaseDatasource"]]
+] = defaultdict(lambda: defaultdict(set))
+for datasource in all_datasources:
+hierarchy[datasource.database][datasource.schema].add(datasource)
+
+# add datasources with implicit permission (eg, database access)
+for database, schemas_tables in hierarchy.items():
+has_database_access =
security_manager.can_access_database(database)
+for schema, datasources in schemas_tables.items():
+schema_perm = security_manager.get_schema_perm(database,
schema)
+if has_database_access or (
+schema_perm
+and security_manager.can_access("schema_access",
schema_perm)
+):
+user_datasources.extend(datasources)
Review comment:
`can_access_database` handles it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] kgabryje opened a new pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined
kgabryje opened a new pull request #15324: URL: https://github.com/apache/superset/pull/15324 ### SUMMARY Currently, if for some reason backend doesn't return `column_types` field in datasets query, we disable selecting time filters in native filters modal. This PR makes the feature more foolproof, by assuming that temporal columns exist if `column_types_ is undefined. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC @villebro @graceguo-supercat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 # [Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15304](https://codecov.io/gh/apache/superset/pull/15304?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f0db540) into [fancy-viz-select-modal](https://codecov.io/gh/apache/superset/commit/c99a44fc70f5c6e1f075e89379df4dd9045abfaa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c99a44f) will **decrease** coverage by `0.22%`. > The diff coverage is `100.00%`. > :exclamation: Current head f0db540 differs from pull request most recent head 6daa108. Consider uploading reports for the commit 6daa108 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## fancy-viz-select-modal #15304 +/- ## == - Coverage 77.79% 77.57% -0.23% == Files 966 966 Lines 4965249671 +19 Branches 6319 5949 -370 == - Hits3862738532 -95 - Misses 1082410940 +116 + Partials 201 199 -2 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | javascript | `72.84% <100.00%> (+0.02%)` | :arrow_up: | | presto | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...plore/components/controls/VizTypeControl/index.tsx](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9pbmRleC50c3g=) | `96.87% <100.00%> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-1.66%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 # [Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15304](https://codecov.io/gh/apache/superset/pull/15304?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6daa108) into [fancy-viz-select-modal](https://codecov.io/gh/apache/superset/commit/c99a44fc70f5c6e1f075e89379df4dd9045abfaa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c99a44f) will **decrease** coverage by `0.23%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## fancy-viz-select-modal #15304 +/- ## == - Coverage 77.79% 77.56% -0.24% == Files 966 966 Lines 4965249643 -9 Branches 6319 5949 -370 == - Hits3862738505 -122 - Misses 1082410939 +115 + Partials 201 199 -2 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.70% <ø> (ø)` | | | postgres | `81.71% <ø> (-0.02%)` | :arrow_down: | | presto | `?` | | | python | `81.79% <ø> (-0.46%)` | :arrow_down: | | sqlite | `81.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...plore/components/controls/VizTypeControl/index.tsx](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9pbmRleC50c3g=) | `96.87% <100.00%> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.63% <0.00%> (-2.35%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.13% <0.00%> (-1.68%)` | :arrow_down: |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 # [Codecov](https://codecov.io/gh/apache/superset/pull/15320?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15320](https://codecov.io/gh/apache/superset/pull/15320?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f8318d2) into [master](https://codecov.io/gh/apache/superset/commit/c211f7df8e5d3ebe0d0424016354f27aef5882aa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c211f7d) will **decrease** coverage by `0.08%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15320 +/- ## == - Coverage 77.23% 77.15% -0.09% == Files 973 973 Lines 5047850478 Branches 6182 6182 == - Hits3898538944 -41 - Misses 1128711328 +41 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.41% <ø> (ø)` | | | mysql | `81.68% <ø> (ø)` | | | postgres | `81.69% <ø> (ø)` | | | presto | `?` | | | python | `82.07% <ø> (-0.16%)` | :arrow_down: | | sqlite | `81.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <ø> (ø)` | | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `84.42% <0.00%> (-5.90%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.45% <0.00%> (-1.42%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.76% <0.00%> (-0.27%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15320?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15320?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [c211f7d...f8318d2](https://codecov.io/gh/apache/superset/pull/15320?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the
[GitHub] [superset] codecov[bot] edited a comment on pull request #15318: fix: nvd3 bar chart sortby metric
codecov[bot] edited a comment on pull request #15318: URL: https://github.com/apache/superset/pull/15318#issuecomment-866595851 # [Codecov](https://codecov.io/gh/apache/superset/pull/15318?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15318](https://codecov.io/gh/apache/superset/pull/15318?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (da4d734) into [master](https://codecov.io/gh/apache/superset/commit/ab153e66cc6a3ad6a55d9d2b19aef3ef2f9f2625?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ab153e6) will **increase** coverage by `0.08%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15318 +/- ## == + Coverage 77.14% 77.22% +0.08% == Files 973 973 Lines 5047350481 +8 Branches 6183 6183 == + Hits3893838985 +47 + Misses 1132911290 -39 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.41% <100.00%> (-0.01%)` | :arrow_down: | | mysql | `81.68% <100.00%> (-0.01%)` | :arrow_down: | | postgres | `81.69% <100.00%> (-0.01%)` | :arrow_down: | | presto | `81.40% <100.00%> (?)` | | | python | `82.23% <100.00%> (+0.15%)` | :arrow_up: | | sqlite | `81.33% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdml6LnB5) | `56.52% <100.00%> (+0.04%)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.54% <0.00%> (-0.04%)` | :arrow_down: | | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `60.68% <0.00%> (ø)` | | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `90.02% <0.00%> (+0.26%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.87% <0.00%> (+1.41%)` | :arrow_up: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `90.31% <0.00%> (+5.89%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15318?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] [superset] blackhawk28 opened a new issue #15327: Superset-Athena setup
blackhawk28 opened a new issue #15327: URL: https://github.com/apache/superset/issues/15327 I have connected my superset with Athena using JDBC url, and i can see my athena tables on superset now but that is showing from a single catalog tables, suppose i have one more catalog in my Athena how can i onboard both catalog tables to superset? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL
codecov[bot] commented on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 # [Codecov](https://codecov.io/gh/apache/superset/pull/15320?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15320](https://codecov.io/gh/apache/superset/pull/15320?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f8318d2) into [master](https://codecov.io/gh/apache/superset/commit/c211f7df8e5d3ebe0d0424016354f27aef5882aa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c211f7d) will **decrease** coverage by `0.24%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15320 +/- ## == - Coverage 77.23% 76.98% -0.25% == Files 973 973 Lines 5047850449 -29 Branches 6182 6182 == - Hits3898538839 -146 - Misses 1128711404 +117 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.68% <ø> (ø)` | | | postgres | `81.68% <ø> (-0.02%)` | :arrow_down: | | presto | `?` | | | python | `81.76% <ø> (-0.47%)` | :arrow_down: | | sqlite | `81.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <ø> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.95%)` | :arrow_down: | | [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `73.42% <0.00%> (-2.45%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.20% <0.00%> (-1.67%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` |
[GitHub] [superset] villebro commented on a change in pull request #15270: feat(editable-title): move cursor and scroll to the end
villebro commented on a change in pull request #15270:
URL: https://github.com/apache/superset/pull/15270#discussion_r656792478
##
File path: superset-frontend/src/components/EditableTitle/index.tsx
##
@@ -70,6 +70,13 @@ export default function EditableTitle({
useEffect(() => {
if (isEditing) {
contentRef.current.focus();
+ // move cursor and scroll to the end
+ if (contentRef.current.setSelectionRange) {
+const { length } = contentRef.current.value;
+contentRef.current.setSelectionRange(length, length);
+contentRef.current.scrollLeft = contentRef.current.scrollWidth;
+contentRef.current.scrollTop = contentRef.current.scrollHeight;
Review comment:
> Cool. Here I think it need to scroll to the bottom for the textarea.
Right you are!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined
villebro commented on a change in pull request #15324:
URL: https://github.com/apache/superset/pull/15324#discussion_r656887497
##
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##
@@ -275,9 +275,10 @@ const FILTER_TYPE_NAME_MAPPING = {
};
// TODO: add column_types field to DatasourceMeta
+// We return true if column_types is undefined as a precaution against backend
failing to return column_types
const hasTemporalColumns = (
dataset: DatasourceMeta & { column_types: GenericDataType[] },
-) => dataset?.column_types?.includes(GenericDataType.TEMPORAL);
+) => dataset?.column_types?.includes(GenericDataType.TEMPORAL) ?? true;
Review comment:
Could we make it even more bulletproof by checking for length of
`column_types`? Something like `!dataset?.column_types?.length ||
dataset?.column_types?.includes(GenericDataType.TEMPORAL)`? The reason is I
suspect the Druid connector might return an empty array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries
dpgaspar commented on a change in pull request #15082: URL: https://github.com/apache/superset/pull/15082#discussion_r656889274 ## File path: superset/models/core.py ## @@ -379,6 +379,9 @@ def _log_query(sql: str) -> None: with closing(engine.raw_connection()) as conn: cursor = conn.cursor() +if hasattr(cursor, 'fetch_size'): Review comment: wouldn't it make more sense to just set your database connection to whatever top value you need? I mean why not just configure the elasticsearch connection with the fetch_size for ROW_LIMIT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] suddjian commented on issue #15174: Dynamic plugin not showing up in VizTypeControl
suddjian commented on issue #15174: URL: https://github.com/apache/superset/issues/15174#issuecomment-866655603 Thank you so much for your debugging efforts @krsnik93! I think I understand the problem before even needing to repro I am actively working on this file so I should be able to address the problem quite soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined
codecov[bot] commented on pull request #15324: URL: https://github.com/apache/superset/pull/15324#issuecomment-866655694 # [Codecov](https://codecov.io/gh/apache/superset/pull/15324?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15324](https://codecov.io/gh/apache/superset/pull/15324?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (94ef79c) into [master](https://codecov.io/gh/apache/superset/commit/6324490dd3359f4b2aa2acd88b9b83f42203?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6324490) will **not change** coverage. > The diff coverage is `100.00%`. > :exclamation: Current head 94ef79c differs from pull request most recent head 2dd5934. Consider uploading reports for the commit 2dd5934 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15324?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #15324 +/- ## === Coverage 77.00% 77.00% === Files 973 973 Lines 5048850488 Branches 6184 6183-1 === Hits3887738877 Misses 1140511405 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | javascript | `71.77% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15324?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15324/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.13% <100.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15324?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15324?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [6324490...2dd5934](https://codecov.io/gh/apache/superset/pull/15324?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] jaythacker opened a new issue #15323: way to show schema and table for other project in big query
jaythacker opened a new issue #15323: URL: https://github.com/apache/superset/issues/15323 My service account in big query has access to other project as well, and its required to join tables form both of the project. I am able to write query and do join, but I am not able to see available tables in other project. Is there any way to see that table in left side panel of SQL editor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15318: fix: nvd3 bar chart sortby metric
codecov[bot] edited a comment on pull request #15318: URL: https://github.com/apache/superset/pull/15318#issuecomment-866595851 # [Codecov](https://codecov.io/gh/apache/superset/pull/15318?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15318](https://codecov.io/gh/apache/superset/pull/15318?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (da4d734) into [master](https://codecov.io/gh/apache/superset/commit/ab153e66cc6a3ad6a55d9d2b19aef3ef2f9f2625?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ab153e6) will **decrease** coverage by `0.00%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15318 +/- ## == - Coverage 77.14% 77.14% -0.01% == Files 973 973 Lines 5047350481 +8 Branches 6183 6183 == + Hits3893838944 +6 - Misses 1132911331 +2 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.41% <100.00%> (-0.01%)` | :arrow_down: | | mysql | `81.68% <100.00%> (-0.01%)` | :arrow_down: | | postgres | `81.69% <100.00%> (-0.01%)` | :arrow_down: | | python | `82.07% <100.00%> (-0.01%)` | :arrow_down: | | sqlite | `81.33% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdml6LnB5) | `56.52% <100.00%> (+0.04%)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.54% <0.00%> (-0.04%)` | :arrow_down: | | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `60.68% <0.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15318?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15318?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [ab153e6...da4d734](https://codecov.io/gh/apache/superset/pull/15318?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional
[GitHub] [superset] codecov[bot] edited a comment on pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined
codecov[bot] edited a comment on pull request #15324: URL: https://github.com/apache/superset/pull/15324#issuecomment-866655694 # [Codecov](https://codecov.io/gh/apache/superset/pull/15324?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15324](https://codecov.io/gh/apache/superset/pull/15324?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (94ef79c) into [master](https://codecov.io/gh/apache/superset/commit/6324490dd3359f4b2aa2acd88b9b83f42203?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6324490) will **decrease** coverage by `0.15%`. > The diff coverage is `100.00%`. > :exclamation: Current head 94ef79c differs from pull request most recent head c3ef0a9. Consider uploading reports for the commit c3ef0a9 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15324?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15324 +/- ## == - Coverage 77.15% 77.00% -0.16% == Files 973 973 Lines 5048850488 Branches 6184 6183 -1 == - Hits3895438877 -77 - Misses 1132811405 +77 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | javascript | `71.77% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15324?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15324/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.13% <100.00%> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15324/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15324/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15324/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15324/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-1.06%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15324/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15324/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-0.24%)` | :arrow_down: | |
[GitHub] [superset] kgabryje commented on a change in pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined
kgabryje commented on a change in pull request #15324:
URL: https://github.com/apache/superset/pull/15324#discussion_r656909789
##
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##
@@ -275,9 +275,10 @@ const FILTER_TYPE_NAME_MAPPING = {
};
// TODO: add column_types field to DatasourceMeta
+// We return true if column_types is undefined as a precaution against backend
failing to return column_types
const hasTemporalColumns = (
dataset: DatasourceMeta & { column_types: GenericDataType[] },
-) => dataset?.column_types?.includes(GenericDataType.TEMPORAL);
+) => dataset?.column_types?.includes(GenericDataType.TEMPORAL) ?? true;
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] samudurand opened a new pull request #15321: Allow to set service account on Helm deployment
samudurand opened a new pull request #15321: URL: https://github.com/apache/superset/pull/15321 ### SUMMARY When deploying to AWS with helm3, the standard way to give a pod an IAM role is to use service accounts. This change allows to set the service account name on the deployment. ### TESTING INSTRUCTIONS Deploy superset after setting the "supersetNode.serviceAccount" value. Then check that the node has the rights provided by the service account. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] john-bodley commented on issue #6032: [SIP-11] Proposal for deprecating the native Druid NoSQL connector
john-bodley commented on issue #6032: URL: https://github.com/apache/superset/issues/6032#issuecomment-866575832 @wchaofan apologies I just saw your comment. The `DRUID_IS_ACTIVE` flag is somewhat misleading and relates to whether the native Druid NoSQL connector is exposed. Per the SIP given that the connector is slated for deprecation I would _strongly_ recommend that you register your Druid cluster as a SQL database. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15318: fix: nvd3 bar chart sortby metric
codecov[bot] commented on pull request #15318: URL: https://github.com/apache/superset/pull/15318#issuecomment-866595851 # [Codecov](https://codecov.io/gh/apache/superset/pull/15318?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15318](https://codecov.io/gh/apache/superset/pull/15318?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (da4d734) into [master](https://codecov.io/gh/apache/superset/commit/ab153e66cc6a3ad6a55d9d2b19aef3ef2f9f2625?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ab153e6) will **decrease** coverage by `0.17%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15318 +/- ## == - Coverage 77.14% 76.96% -0.18% == Files 973 973 Lines 5047350481 +8 Branches 6183 6183 == - Hits3893838855 -83 - Misses 1132911420 +91 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `?` | | | postgres | `81.69% <100.00%> (-0.01%)` | :arrow_down: | | python | `81.74% <100.00%> (-0.34%)` | :arrow_down: | | sqlite | `81.33% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15318?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdml6LnB5) | `56.52% <100.00%> (+0.04%)` | :arrow_up: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.85% <0.00%> (-4.29%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-1.06%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.97% <0.00%> (-0.79%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15318/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.10% <0.00%> (-0.48%)` | :arrow_down: | |
[GitHub] [superset] kgabryje closed issue #14974: [native-filters]close indicator popover on resize
kgabryje closed issue #14974: URL: https://github.com/apache/superset/issues/14974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #15305: fix(dashboard): Close FiltersBadge popover on window resize
kgabryje merged pull request #15305: URL: https://github.com/apache/superset/pull/15305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 # [Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15304](https://codecov.io/gh/apache/superset/pull/15304?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f0db540) into [fancy-viz-select-modal](https://codecov.io/gh/apache/superset/commit/c99a44fc70f5c6e1f075e89379df4dd9045abfaa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c99a44f) will **decrease** coverage by `0.22%`. > The diff coverage is `100.00%`. > :exclamation: Current head f0db540 differs from pull request most recent head 4cc9084. Consider uploading reports for the commit 4cc9084 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## fancy-viz-select-modal #15304 +/- ## == - Coverage 77.79% 77.57% -0.23% == Files 966 966 Lines 4965249671 +19 Branches 6319 5949 -370 == - Hits3862738532 -95 - Misses 1082410940 +116 + Partials 201 199 -2 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | javascript | `72.84% <100.00%> (+0.02%)` | :arrow_up: | | presto | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...plore/components/controls/VizTypeControl/index.tsx](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9pbmRleC50c3g=) | `96.87% <100.00%> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-1.66%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined
codecov[bot] edited a comment on pull request #15324: URL: https://github.com/apache/superset/pull/15324#issuecomment-866655694 # [Codecov](https://codecov.io/gh/apache/superset/pull/15324?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15324](https://codecov.io/gh/apache/superset/pull/15324?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c3ef0a9) into [master](https://codecov.io/gh/apache/superset/commit/6324490dd3359f4b2aa2acd88b9b83f42203?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6324490) will **decrease** coverage by `0.00%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15324?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15324 +/- ## == - Coverage 77.15% 77.15% -0.01% == Files 973 973 Lines 5048850491 +3 Branches 6184 6184 == + Hits3895438956 +2 - Misses 1132811329 +1 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | javascript | `71.77% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15324?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15324/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.11% <100.00%> (-0.03%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15324?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15324?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [6324490...c3ef0a9](https://codecov.io/gh/apache/superset/pull/15324?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] musduo opened a new issue #15331: nginx configuration
musduo opened a new issue #15331: URL: https://github.com/apache/superset/issues/15331 I set the gunicorn to superset as it says in the doc. (https://superset.apache.org/docs/installation/configuring-superset)  But I couldn't configure nginx. How should I configure Nginx? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] hughhhh commented on a change in pull request #15206: feat: implement specific errors for SQL Lab
hug commented on a change in pull request #15206: URL: https://github.com/apache/superset/pull/15206#discussion_r657179195 ## File path: docs/src/pages/docs/Miscellaneous/issue_codes.mdx ## @@ -207,3 +207,43 @@ The submitted payload has the incorrect schema. ``` Please check that the request payload has the expected schema. + +## Issue 1021 + +``` +Results backend needed for asynchronous queries is not configured. +``` + +Your instance of Superset doesn't have a results backend configured, which is needed for asynchronous queries. Please contact an administrator for further assistance. Review comment: Can we point them to the docs on how to configure this as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #15206: feat: implement specific errors for SQL Lab
betodealmeida merged pull request #15206: URL: https://github.com/apache/superset/pull/15206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #15184: fix: datasource payload is incorrect
betodealmeida merged pull request #15184: URL: https://github.com/apache/superset/pull/15184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] blackhawk28 commented on issue #875: Support of JOIN statement for queries
blackhawk28 commented on issue #875: URL: https://github.com/apache/superset/issues/875#issuecomment-866702345 > > > @xrmx that is correct, in general I would like to have the flexibility to define table with sql statement so to join more table, even coming from different database. > My general use case is to provide a general purpose analytics framework (we are evaluating superset for this) to be connected to a Big Data Infrastructure, and user can choose which dataset (or join of dataset) to use in their analysis. > Thanks a lot! hey were you able to do that join table from multiple databases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] dpgaspar commented on pull request #15328: fix: downgrade selenium log level on timeout
dpgaspar commented on pull request #15328: URL: https://github.com/apache/superset/pull/15328#issuecomment-866706193 > LGTM. As a follow-up, I wonder if we should change the status of charts that have rendered a non-timeout related error to be able to distinguish between real and errored timeouts? yes we should that would be really useful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined
kgabryje merged pull request #15324: URL: https://github.com/apache/superset/pull/15324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #15226: [native-filters] hide non-numeric columns in numeric range filter
kgabryje commented on issue #15226:
URL: https://github.com/apache/superset/issues/15226#issuecomment-866721523
@villebro This feature requires changes in the response from `/dataset/{id}`
endpoint, as it doesn't return `type_generic` field for columns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] musduo closed issue #15330: Uwsgi configuration
musduo closed issue #15330: URL: https://github.com/apache/superset/issues/15330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] kitkat73 opened a new issue #15332: Line chart tooltip doesn't show on Chrome
kitkat73 opened a new issue #15332:
URL: https://github.com/apache/superset/issues/15332
Similar to [this issue on
Firefox](https://github.com/apache/superset/issues/7822), the tooltip on line
charts is sometimes missing. The behavior is rather stochastic, see the
description.
### Expected results
On hover over a datapoint on a line chart, display tooltip with exact values.
### Actual results
The data point is highlighted but no tooltip. Alternatively, it flashes for
a second and then disappears (see the video below). The only solution is to
force-refresh the chart - then the tooltip temporarily works. If you leave the
dashboard tab and come back, the tooltip is gone and the chart needs to be
force-refreshed again.
Screenshots
https://user-images.githubusercontent.com/42228832/123117053-b6d04f80-d441-11eb-875f-38a6eeb0f698.png;>
My colleague recorded this video clearly showing the issue (password:
2pQcGv8V):
https://cisco-collab.webex.com/recordingservice/sites/cisco-collab/recording/53432c86b65a1039bab50050568f1ab8/playback
How to reproduce the bug
It is hard to reproduce because the problem occurs for certain dashboards,
and for certain not. Also on the dashboard from the video, some charts are
sometimes working fine and some are missing it, next time it's not working for
any. However, we were able to reproduce the missing tooltip behavior for at
least 3 different users, all on Chrome.
1. Go to a dashboard containing line charts
2. Hover over a time point
3. Observe the tooltip flashing and disappearing or not showing at all
### Environment
- superset version: `Version: 1.1.0`
- python version: `python:3.8.9-slim`
### Checklist
- [x] I have reproduced the issue with at least the latest released version
of superset.
- [x] I have checked the issue tracker for the same issue and I haven't
found one similar. - I found one, it's linked at the top, but it's for Firefox
and it looks like it's been solved for that browser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] Ognian opened a new issue #15333: move docker-compose and needed docker directory to a new repo
Ognian opened a new issue #15333: URL: https://github.com/apache/superset/issues/15333 moving docker compose and the needed ./docker directory to a new git repository (i.e apache/docker_compose_superset) would greatly simplify updating a local instance of superset, since we would only git clone this small repo (apache/docker_compose_superset) instead of the whole development one containing the source code (apache/superset). This is needed since unfortunately there is no way to clone only a subdirectory of a github repo therefore we have to split it in 2 different repos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 # [Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15304](https://codecov.io/gh/apache/superset/pull/15304?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6daa108) into [fancy-viz-select-modal](https://codecov.io/gh/apache/superset/commit/c99a44fc70f5c6e1f075e89379df4dd9045abfaa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c99a44f) will **decrease** coverage by `0.22%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## fancy-viz-select-modal #15304 +/- ## == - Coverage 77.79% 77.57% -0.23% == Files 966 966 Lines 4965249671 +19 Branches 6319 5949 -370 == - Hits3862738532 -95 - Misses 1082410940 +116 + Partials 201 199 -2 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.70% <ø> (ø)` | | | postgres | `81.73% <ø> (ø)` | | | presto | `?` | | | python | `81.81% <ø> (-0.44%)` | :arrow_down: | | sqlite | `81.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...plore/components/controls/VizTypeControl/index.tsx](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9pbmRleC50c3g=) | `96.87% <100.00%> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-1.66%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | |
[GitHub] [superset] musduo opened a new issue #15330: Uwsgi configuration
musduo opened a new issue #15330:
URL: https://github.com/apache/superset/issues/15330
I have problems with superset uwsgi configuration. Below are the uwsgi log
details and uwsgi.ini configuration settings.
Installation Document:
[https://www.programmersought.com/article/2643728000/](url)
**uwsgi.log**
`Traceback (most recent call last):
File "./werkzeug/local.py", line 375, in
__call__ = lambda x, *a, **kw: x._get_current_object()(*a, **kw)
File "./werkzeug/local.py", line 306, in _get_current_object
return self.__local()
File "./flask/globals.py", line 52, in _find_app
raise RuntimeError(_app_ctx_err_msg)
RuntimeError: Working outside of application context.
This typically means that you attempted to use functionality that needed
to interface with the current application object in some way. To solve
this, set up an application context with app.app_context(). See the
documentation for more information.
[pid: 16585|app: 0|req: 1/1] 127.0.0.1 () {38 vars in 602 bytes} [Wed Jun 23
10:13:29 2021] GET / => generated 0 bytes in 2 msecs (HTTP/1.1 500) 0 headers
in 0 bytes (0 switches on core 0)
Traceback (most recent call last):
File "./werkzeug/local.py", line 375, in
__call__ = lambda x, *a, **kw: x._get_current_object()(*a, **kw)
File "./werkzeug/local.py", line 306, in _get_current_object
return self.__local()
File "./flask/globals.py", line 52, in _find_app
raise RuntimeError(_app_ctx_err_msg)
RuntimeError: Working outside of application context.`
**uwsgi.ini**
``
wsgi-file=/home/baris/supset/lib/python3.7/site-packages/superset/run.py
callable=app
socket= /home/baris/supset/uwsgi_conf/uwsgi.sock
daemonize= /home/baris/supset/uwsgi_conf/uwsgi.log
pidfile= /home/baris/supset/uwsgi_conf/uwsgi.pid
workers=2
http=localhost:8088
uid=root
gid=root
master=true
vacuum=true
thunder-lock=true
enable-threads=true
harakiri=30
post-buffering=4096
py-autoreload = 1
``
In this file, I tried many things instead of app.run. i am getting "no
python application found, check your startup logs for errors" error here too.
**run.py**
`from superset import app
if __name__ == '__main__':
app.run(host='0.0.0.0')`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15328: fix: downgrade selenium log level on timeout
codecov[bot] edited a comment on pull request #15328: URL: https://github.com/apache/superset/pull/15328#issuecomment-866703539 # [Codecov](https://codecov.io/gh/apache/superset/pull/15328?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15328](https://codecov.io/gh/apache/superset/pull/15328?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0f4a5a9) into [master](https://codecov.io/gh/apache/superset/commit/f31d573561824043521b5081aea42620d6ac4558?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f31d573) will **decrease** coverage by `0.05%`. > The diff coverage is `85.71%`. > :exclamation: Current head 0f4a5a9 differs from pull request most recent head a794821. Consider uploading reports for the commit a794821 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15328?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15328 +/- ## == - Coverage 77.15% 77.09% -0.06% == Files 973 973 Lines 5048350488 +5 Branches 6183 6184 +1 == - Hits3894938924 -25 - Misses 1132811358 +30 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.68% <0.00%> (+<0.01%)` | :arrow_up: | | postgres | `81.69% <0.00%> (ø)` | | | presto | `81.39% <0.00%> (?)` | | | python | `81.96% <0.00%> (-0.12%)` | :arrow_down: | | sqlite | `81.33% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15328?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/utils/webdriver.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvd2ViZHJpdmVyLnB5) | `78.66% <0.00%> (ø)` | | | [...ard/components/FiltersBadge/DetailsPanel/index.tsx](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwvaW5kZXgudHN4) | `87.30% <100.00%> (+1.09%)` | :arrow_up: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.93% <0.00%> (-0.13%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `90.02% <0.00%> (+0.26%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.63% <0.00%> (+1.17%)` | :arrow_up: | |
[GitHub] [superset] codecov[bot] commented on pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets
codecov[bot] commented on pull request #15302: URL: https://github.com/apache/superset/pull/15302#issuecomment-866830279 # [Codecov](https://codecov.io/gh/apache/superset/pull/15302?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15302](https://codecov.io/gh/apache/superset/pull/15302?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (54121df) into [master](https://codecov.io/gh/apache/superset/commit/cef3dc0b02bf0e1610465c6db7f71a3dc0c9a7e6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cef3dc0) will **decrease** coverage by `0.00%`. > The diff coverage is `87.34%`. [](https://codecov.io/gh/apache/superset/pull/15302?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15302 +/- ## == - Coverage 77.23% 77.22% -0.01% == Files 973 975 +2 Lines 5043850522 +84 Branches 6175 6201 +26 == + Hits3895739018 +61 - Misses 1127611297 +21 - Partials 205 207 +2 ``` | Flag | Coverage Δ | | |---|---|---| | javascript | `71.80% <87.34%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15302?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...nd/src/common/hooks/useComponentDidUpdate/index.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDb21wb25lbnREaWRVcGRhdGUvaW5kZXgudHM=) | `0.00% <0.00%> (ø)` | | | [...ilterScopingModal/CrossFilterScopingForm/index.tsx](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0vaW5kZXgudHN4) | `84.61% <ø> (ø)` | | | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `95.65% <66.66%> (-4.35%)` | :arrow_down: | | [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `90.62% <80.00%> (-5.03%)` | :arrow_down: | | [...ConfigModal/FiltersConfigForm/FilterScope/utils.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3V0aWxzLnRz) | `95.89% <81.81%> (-2.62%)` | :arrow_down: | | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.97% <90.00%> (-0.03%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 # [Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15304](https://codecov.io/gh/apache/superset/pull/15304?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1a718d3) into [fancy-viz-select-modal](https://codecov.io/gh/apache/superset/commit/c99a44fc70f5c6e1f075e89379df4dd9045abfaa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c99a44f) will **decrease** coverage by `0.22%`. > The diff coverage is `100.00%`. > :exclamation: Current head 1a718d3 differs from pull request most recent head 6daa108. Consider uploading reports for the commit 6daa108 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## fancy-viz-select-modal #15304 +/- ## == - Coverage 77.79% 77.57% -0.23% == Files 966 966 Lines 4965249671 +19 Branches 6319 5949 -370 == - Hits3862738532 -95 - Misses 1082410940 +116 + Partials 201 199 -2 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | javascript | `72.84% <100.00%> (+0.02%)` | :arrow_up: | | presto | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...plore/components/controls/VizTypeControl/index.tsx](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9pbmRleC50c3g=) | `96.87% <100.00%> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-1.66%)` | :arrow_down: | |
[GitHub] [superset] villebro commented on a change in pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing
villebro commented on a change in pull request #15279:
URL: https://github.com/apache/superset/pull/15279#discussion_r656877011
##
File path: superset/utils/pandas_postprocessing.py
##
@@ -425,9 +429,11 @@ def select(
@validate_column_args("columns")
-def diff(df: DataFrame, columns: Dict[str, str], periods: int = 1,) ->
DataFrame:
+def diff(
+df: DataFrame, columns: Dict[str, str], periods: int = 1, axis: int = 0,
Review comment:
Let's be more explicit about the axis type (I personally never remember
for certain what 0 and 1 means on axis). If Pandas isn't yet exposing types,
maybe something like
```python
class PandasPostprocessingAxis(int, Enum):
ROW = 0
COLUMN = 1
```
##
File path: superset/common/query_context.py
##
@@ -97,6 +101,62 @@ def __init__( # pylint: disable=too-many-arguments
"result_format": self.result_format,
}
+def processing_time_offset(
+self, df: pd.DataFrame, query_object: QueryObject,
+) -> Tuple[pd.DataFrame, List[str]]:
+# ensure query_object is immutable
+query_object_clone = copy.copy(query_object)
+rv_sql = []
+
+time_offset = query_object.time_offset
+outer_from_dttm = query_object.from_dttm
+outer_to_dttm = query_object.to_dttm
+for offset in time_offset:
+try:
+query_object_clone.from_dttm = get_past_or_future(
+offset, outer_from_dttm,
+)
+query_object_clone.to_dttm = get_past_or_future(offset,
outer_to_dttm,)
+except ValueError as ex:
+raise QueryObjectValidationError(str(ex))
+# make sure subquery use main query where clause
+query_object_clone.inner_from_dttm = outer_from_dttm
+query_object_clone.inner_to_dttm = outer_to_dttm
+query_object_clone.time_offset = []
Review comment:
I wonder if we should add `time_offset` to the `QueryObject` schema and
rename the current one to `time_offsets`, adding both to the cache key. Example:
We want to make a query with two offsets: one year ago and two years ago.
The "actual" main query that gets executed and cached (no additional columns
added yet):
```python
time_offsets: None
time_offset: None
```
First extra query (gets concatenated to the previous dataframe):
```python
time_offsets: None
time_offset: 1
```
Second extra query (also concatenated to the main dataframe):
```python
time_offsets: None
time_offset: 2
```
Main `QueryObject`:
```python
time_offsets: [1, 2]
time_offset: None
```
Finally, when the full query object is constructed, the following result
would be cached with the following keys:
This way the main query result would be persisted along with the results of
the extra query results without the need to rebuild the full dataframe on each
request, and the extra queries could then also be cached individually.
##
File path: superset/utils/pandas_postprocessing.py
##
@@ -436,14 +442,68 @@ def diff(df: DataFrame, columns: Dict[str, str], periods:
int = 1,) -> DataFrame
on diff values calculated from `y`, leaving the original column `y`
unchanged.
:param periods: periods to shift for calculating difference.
+:param axis: 0 for row, 1 for column. default 0.
:return: DataFrame with diffed columns
:raises QueryObjectValidationError: If the request in incorrect
"""
df_diff = df[columns.keys()]
-df_diff = df_diff.diff(periods=periods)
+df_diff = df_diff.diff(periods=periods, axis=axis)
return _append_columns(df, df_diff, columns)
+@validate_column_args("source_columns", "compare_columns")
+def compare(
+df: DataFrame,
+source_columns: List[str],
+compare_columns: List[str],
+compare_type: Optional[str],
Review comment:
Same here: `class PandasPostprocessingCompare(str, Enum)`
##
File path: superset/common/query_context.py
##
@@ -130,11 +191,16 @@ def get_query_result(self, query_object: QueryObject) ->
Dict[str, Any]:
if self.enforce_numerical_metrics:
self.df_metrics_to_num(df, query_object)
+if query_object.time_offset:
+df, offset_sql = self.processing_time_offset(df, query_object)
+query += ";\n\n".join(offset_sql)
+query += ";\n\n"
Review comment:
We probably don't need this line?
```suggestion
```
##
File path: superset/common/query_object.py
##
@@ -94,6 +96,7 @@ class QueryObject:
datasource: Optional[BaseDatasource]
result_type: Optional[ChartDataResultType]
is_rowcount: bool
+time_offset: List[str]
Review comment:
I think it would be great to deprecate the current string-based offset,
and use a
[GitHub] [superset] villebro commented on a change in pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing
villebro commented on a change in pull request #15279: URL: https://github.com/apache/superset/pull/15279#discussion_r656928933 ## File path: superset/common/query_context.py ## @@ -97,6 +101,62 @@ def __init__( # pylint: disable=too-many-arguments "result_format": self.result_format, } +def processing_time_offset( +self, df: pd.DataFrame, query_object: QueryObject, +) -> Tuple[pd.DataFrame, List[str]]: +# ensure query_object is immutable +query_object_clone = copy.copy(query_object) +rv_sql = [] + +time_offset = query_object.time_offset +outer_from_dttm = query_object.from_dttm +outer_to_dttm = query_object.to_dttm +for offset in time_offset: +try: +query_object_clone.from_dttm = get_past_or_future( +offset, outer_from_dttm, +) +query_object_clone.to_dttm = get_past_or_future(offset, outer_to_dttm,) +except ValueError as ex: +raise QueryObjectValidationError(str(ex)) +# make sure subquery use main query where clause +query_object_clone.inner_from_dttm = outer_from_dttm +query_object_clone.inner_to_dttm = outer_to_dttm +query_object_clone.time_offset = [] Review comment: I wonder if we should add `time_offset` to the `QueryObject` schema and rename the current one to `time_offsets`, adding both to the cache key. Example: We want to make a query with two offsets: one year ago and two years ago. The "actual" main query that gets executed and cached (no additional columns added yet): ```python time_offsets: None time_offset: None ``` First extra query (gets concatenated to the previous dataframe): ```python time_offsets: None time_offset: 1 ``` Second extra query (also concatenated to the main dataframe): ```python time_offsets: None time_offset: 2 ``` Finally, when the full query object is constructed, the following result would be cached with the following keys: ```python time_offsets: [1, 2] time_offset: None ``` This way the main query result would be persisted along with the results of the extra query results without the need to rebuild the full dataframe on each request, and the extra queries could then also be cached individually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] juleslagarde opened a new issue #15329: docker build failed (with fix)
juleslagarde opened a new issue #15329:
URL: https://github.com/apache/superset/issues/15329
Command `docker build` failed
### Expected results
build sucessfull
### Actual results
error
In file included from Modules/LDAPObject.c:9:0:
Modules/errors.h:8:18: fatal error: lber.h: No such file or directory
compilation terminated.
error: command 'gcc' failed with exit status 1
How to reproduce the bug
1. Git clone https://github.com/apache/superset
1. run docker build
1. See error
### Environment
- superset version: `1.2.0`
- python version: `Python 3.7.9`
### Fix found
added package libldap2-dev in Dockerfile at line 30 [in Dockerfile at line
30](https://github.com/apache/superset/blob/387d93302fa2f4f475cd572b62d0908615e67919/Dockerfile#L30)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets
villebro commented on a change in pull request #15302:
URL: https://github.com/apache/superset/pull/15302#discussion_r656965106
##
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##
@@ -580,6 +592,28 @@ const FiltersConfigForm = (
setActiveFilterPanelKey(activeFilterPanelKey);
}, [hasCheckedAdvancedControl]);
+ const initiallyExcluded = useMemo(() => {
Review comment:
nit: `initiallyExcludedCharts`
##
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.tsx
##
@@ -56,11 +57,41 @@ const FilterScope: FC = ({
scope,
updateFormValues,
chartId,
+ initiallyExcludedCharts,
}) => {
- const initialScope = scope || getDefaultScopeValue(chartId);
- const initialScoping = isScopingAll(initialScope, chartId)
-? Scoping.all
-: Scoping.specific;
+ const [initialScope] = useState(
+scope || getDefaultScopeValue(chartId, initiallyExcludedCharts),
+ );
+ const [initialScoping] = useState(
+isScopingAll(initialScope, chartId) ? Scoping.all : Scoping.specific,
+ );
Review comment:
This isn't directly related to this PR, but it confused me while reading
this code: having two props called `initialScope` and `initialScoping` right
next to each other feels very ambiguous. If changing this to something slightly
more specific doesn't lead down a huge rabbit hole, I'd opt for renaming
`Scoping` to `ScopingType` and consequently `initialScoping` to
`initialScopingType`, perhaps even `initialScope` to `initialChartScope`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets
kgabryje commented on a change in pull request #15302:
URL: https://github.com/apache/superset/pull/15302#discussion_r656971367
##
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.tsx
##
@@ -56,11 +57,41 @@ const FilterScope: FC = ({
scope,
updateFormValues,
chartId,
+ initiallyExcludedCharts,
}) => {
- const initialScope = scope || getDefaultScopeValue(chartId);
- const initialScoping = isScopingAll(initialScope, chartId)
-? Scoping.all
-: Scoping.specific;
+ const [initialScope] = useState(
+scope || getDefaultScopeValue(chartId, initiallyExcludedCharts),
+ );
+ const [initialScoping] = useState(
+isScopingAll(initialScope, chartId) ? Scoping.all : Scoping.specific,
+ );
Review comment:
Totally agree, I feel like I spend more time trying to wrap my head
around difference between those 2 than actual developing. I'll change that in
this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] blackhawk28 commented on issue #875: Support of JOIN statement for queries
blackhawk28 commented on issue #875: URL: https://github.com/apache/superset/issues/875#issuecomment-866701274 > > > @gclsoft `SELECT` in expressions as IN > > ``` > SELECT (SELECT...) ... > ``` > > isn't supported by all database engines. > > Just create a view! by this can we join table from multiple databases ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #15279: feat: run extra query on QueryObject and add compare operator for post_processing
zhaoyongjie commented on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-866702014 > Some comments. Also, I'm unable to get the offsets to work. When I try to do a 1 year offset, I get the following results (notice that the offset label is correct, but the data is the same as the original query): >  > > The same parameters on the NVD3 Line chart: >  This is because the original offset is always negative. (offset backward, if the current is 2016-2017, `the 1 year offset ago`, is 2017-2018) For the new design, I would like to put `ago/later` into the time interval. This allows the user to know which direction to do offset. for this question, the dataset may be have not before `1 year ago` data in the new time-series viz. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15328: fix: downgrade selenium log level on timeout
codecov[bot] edited a comment on pull request #15328: URL: https://github.com/apache/superset/pull/15328#issuecomment-866703539 # [Codecov](https://codecov.io/gh/apache/superset/pull/15328?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15328](https://codecov.io/gh/apache/superset/pull/15328?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0f4a5a9) into [master](https://codecov.io/gh/apache/superset/commit/f31d573561824043521b5081aea42620d6ac4558?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f31d573) will **decrease** coverage by `0.15%`. > The diff coverage is `85.71%`. > :exclamation: Current head 0f4a5a9 differs from pull request most recent head a794821. Consider uploading reports for the commit a794821 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15328?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15328 +/- ## == - Coverage 77.15% 77.00% -0.16% == Files 973 973 Lines 5048350488 +5 Branches 6183 6184 +1 == - Hits3894938877 -72 - Misses 1132811405 +77 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.68% <0.00%> (+<0.01%)` | :arrow_up: | | postgres | `81.69% <0.00%> (ø)` | | | python | `81.78% <0.00%> (-0.30%)` | :arrow_down: | | sqlite | `81.33% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15328?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/utils/webdriver.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvd2ViZHJpdmVyLnB5) | `78.66% <0.00%> (ø)` | | | [...ard/components/FiltersBadge/DetailsPanel/index.tsx](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwvaW5kZXgudHN4) | `87.30% <100.00%> (+1.09%)` | :arrow_up: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-1.06%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | |
[GitHub] [superset] kgabryje commented on pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets
kgabryje commented on pull request #15302: URL: https://github.com/apache/superset/pull/15302#issuecomment-866815980 @graceguo-supercat Would you like to verify that this PR works properly on Airbnb environments before it's merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] dpgaspar opened a new pull request #15328: fix: downgrade selenium log level on timeout
dpgaspar opened a new pull request #15328: URL: https://github.com/apache/superset/pull/15328 ### SUMMARY The majority of `TimeoutException` are triggered due to charts that do not render correctly or take a long time to load data (normally the first) Most of the execution stack is: ``` Traceback (most recent call last): File "/usr/local/lib/python3.7/site-packages/superset/utils/webdriver.py", line 111, in get_screenshot EC.presence_of_element_located((By.CLASS_NAME, element_name)) File "/usr/local/lib/python3.7/site-packages/selenium/webdriver/support/wait.py", line 80, in until raise TimeoutException(message, screen, stacktrace) selenium.common.exceptions.TimeoutException: Message: ``` We should log these, but it's not critical so this PR downgrades the level to warning. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] kgabryje closed pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined
kgabryje closed pull request #15324: URL: https://github.com/apache/superset/pull/15324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15324: fix(native-filters): Assume that temporal columns exist if column_types is undefined
codecov[bot] edited a comment on pull request #15324: URL: https://github.com/apache/superset/pull/15324#issuecomment-866655694 # [Codecov](https://codecov.io/gh/apache/superset/pull/15324?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15324](https://codecov.io/gh/apache/superset/pull/15324?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c3ef0a9) into [master](https://codecov.io/gh/apache/superset/commit/6324490dd3359f4b2aa2acd88b9b83f42203?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6324490) will **decrease** coverage by `0.00%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15324?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15324 +/- ## == - Coverage 77.15% 77.15% -0.01% == Files 973 973 Lines 5048850491 +3 Branches 6184 6184 == + Hits3895438956 +2 - Misses 1132811329 +1 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | javascript | `71.77% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15324?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15324/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.11% <100.00%> (-0.03%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15324?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15324?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [6324490...c3ef0a9](https://codecov.io/gh/apache/superset/pull/15324?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15328: fix: downgrade selenium log level on timeout
codecov[bot] commented on pull request #15328: URL: https://github.com/apache/superset/pull/15328#issuecomment-866703539 # [Codecov](https://codecov.io/gh/apache/superset/pull/15328?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15328](https://codecov.io/gh/apache/superset/pull/15328?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0f4a5a9) into [master](https://codecov.io/gh/apache/superset/commit/f31d573561824043521b5081aea42620d6ac4558?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f31d573) will **decrease** coverage by `0.15%`. > The diff coverage is `85.71%`. > :exclamation: Current head 0f4a5a9 differs from pull request most recent head a794821. Consider uploading reports for the commit a794821 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15328?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15328 +/- ## == - Coverage 77.15% 77.00% -0.16% == Files 973 973 Lines 5048350488 +5 Branches 6183 6184 +1 == - Hits3894938877 -72 - Misses 1132811405 +77 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.68% <0.00%> (+<0.01%)` | :arrow_up: | | postgres | `81.70% <0.00%> (+<0.01%)` | :arrow_up: | | python | `81.78% <0.00%> (-0.30%)` | :arrow_down: | | sqlite | `81.33% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15328?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/utils/webdriver.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvd2ViZHJpdmVyLnB5) | `78.66% <0.00%> (ø)` | | | [...ard/components/FiltersBadge/DetailsPanel/index.tsx](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwvaW5kZXgudHN4) | `87.30% <100.00%> (+1.09%)` | :arrow_up: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-1.06%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15328/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | |
[GitHub] [superset] serenajiang merged pull request #15315: fix(api): handle undefined column type_generic
serenajiang merged pull request #15315: URL: https://github.com/apache/superset/pull/15315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 # [Codecov](https://codecov.io/gh/apache/superset/pull/15320?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15320](https://codecov.io/gh/apache/superset/pull/15320?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f8318d2) into [master](https://codecov.io/gh/apache/superset/commit/b295c6ad43798d33b15af7b34ab4a4ff1fd2a903?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b295c6a) will **increase** coverage by `0.06%`. > The diff coverage is `n/a`. > :exclamation: Current head f8318d2 differs from pull request most recent head 454f831. Consider uploading reports for the commit 454f831 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15320 +/- ## == + Coverage 77.16% 77.23% +0.06% == Files 973 973 Lines 5052350478 -45 Branches 6184 6182 -2 == - Hits3898638985 -1 + Misses 1133111287 -44 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.41% <ø> (-0.03%)` | :arrow_down: | | mysql | `81.68% <ø> (-0.03%)` | :arrow_down: | | postgres | `81.69% <ø> (-0.03%)` | :arrow_down: | | presto | `81.40% <ø> (?)` | | | python | `82.23% <ø> (+0.12%)` | :arrow_up: | | sqlite | `81.33% <ø> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <ø> (ø)` | | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `78.68% <0.00%> (-4.65%)` | :arrow_down: | | [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `82.22% <0.00%> (-1.40%)` | :arrow_down: | | [...ard/components/FiltersBadge/DetailsPanel/index.tsx](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwvaW5kZXgudHN4) | `86.20% <0.00%> (-1.10%)` | :arrow_down: | | [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `83.95% <0.00%> (-0.94%)` | :arrow_down: | | [superset/errors.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | | | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.54% <0.00%> (ø)` | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 # [Codecov](https://codecov.io/gh/apache/superset/pull/15320?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15320](https://codecov.io/gh/apache/superset/pull/15320?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (454f831) into [master](https://codecov.io/gh/apache/superset/commit/b295c6ad43798d33b15af7b34ab4a4ff1fd2a903?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b295c6a) will **decrease** coverage by `0.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15320 +/- ## == - Coverage 77.16% 77.00% -0.17% == Files 973 973 Lines 5052350494 -29 Branches 6184 6184 == - Hits3898638881 -105 - Misses 1133111407 +76 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.70% <ø> (ø)` | | | postgres | `81.70% <ø> (-0.02%)` | :arrow_down: | | python | `81.79% <ø> (-0.31%)` | :arrow_down: | | sqlite | `81.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <ø> (-0.41%)` | :arrow_down: | | [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <ø> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `73.42% <0.00%> (-2.45%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-1.06%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.20% <0.00%> (-0.25%)` | :arrow_down: | |
[GitHub] [superset] sowo commented on a change in pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries
sowo commented on a change in pull request #15082: URL: https://github.com/apache/superset/pull/15082#discussion_r657338240 ## File path: superset/models/core.py ## @@ -379,6 +379,9 @@ def _log_query(sql: str) -> None: with closing(engine.raw_connection()) as conn: cursor = conn.cursor() +if hasattr(cursor, 'fetch_size'): Review comment: According to the elasticsearch-dbapi docs (https://github.com/preset-io/elasticsearch-dbapi#fetch-size), the fetch_size is set at the cursor level and not when initiating a connection. As far as I understand the code (see https://github.com/apache/superset/blob/a330b664c13e34a4c7ca954f9a3a527a43a5535f/superset/models/core.py#L404), there's no method that I could override to create a cursor with engine specific settings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets
michael-s-molina commented on a change in pull request #15302:
URL: https://github.com/apache/superset/pull/15302#discussion_r657296148
##
File path:
superset-frontend/src/common/hooks/useComponentDidUpdate/useComponentDidUpdate.ts
##
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { EffectCallback, useEffect, useRef } from 'react';
+
+export const useComponentDidUpdate = (effect: EffectCallback) => {
+ const isMountedRef = useRef(false);
+ // eslint-disable-next-line react-hooks/exhaustive-deps
+ useEffect(() => {
+if (isMountedRef.current) {
+ effect();
+}
+ }, [effect]);
+
+ useEffect(() => {
Review comment:
Do we need this second `useEffect`?
https://stackoverflow.com/questions/53179075/with-useeffect-how-can-i-skip-applying-an-effect-upon-the-initial-render
##
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.test.tsx
##
@@ -115,6 +115,7 @@ describe('FilterScope', () => {
fireEvent.click(screen.getByText('Scoping'));
fireEvent.click(screen.getByLabelText('Apply to specific panels'));
+screen.debug(undefined, 3);
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets
codecov[bot] edited a comment on pull request #15302: URL: https://github.com/apache/superset/pull/15302#issuecomment-866830279 # [Codecov](https://codecov.io/gh/apache/superset/pull/15302?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15302](https://codecov.io/gh/apache/superset/pull/15302?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (54121df) into [master](https://codecov.io/gh/apache/superset/commit/cef3dc0b02bf0e1610465c6db7f71a3dc0c9a7e6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cef3dc0) will **decrease** coverage by `0.00%`. > The diff coverage is `87.34%`. > :exclamation: Current head 54121df differs from pull request most recent head 3c4ce80. Consider uploading reports for the commit 3c4ce80 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15302?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15302 +/- ## == - Coverage 77.23% 77.22% -0.01% == Files 973 975 +2 Lines 5043850522 +84 Branches 6175 6201 +26 == + Hits3895739018 +61 - Misses 1127611297 +21 - Partials 205 207 +2 ``` | Flag | Coverage Δ | | |---|---|---| | javascript | `71.80% <87.34%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15302?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...nd/src/common/hooks/useComponentDidUpdate/index.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDb21wb25lbnREaWRVcGRhdGUvaW5kZXgudHM=) | `0.00% <0.00%> (ø)` | | | [...ilterScopingModal/CrossFilterScopingForm/index.tsx](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0vaW5kZXgudHN4) | `84.61% <ø> (ø)` | | | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `95.65% <66.66%> (-4.35%)` | :arrow_down: | | [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `90.62% <80.00%> (-5.03%)` | :arrow_down: | | [...ConfigModal/FiltersConfigForm/FilterScope/utils.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3V0aWxzLnRz) | `95.89% <81.81%> (-2.62%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL
codecov[bot] edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-866558845 # [Codecov](https://codecov.io/gh/apache/superset/pull/15320?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15320](https://codecov.io/gh/apache/superset/pull/15320?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (454f831) into [master](https://codecov.io/gh/apache/superset/commit/b295c6ad43798d33b15af7b34ab4a4ff1fd2a903?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b295c6a) will **decrease** coverage by `0.15%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15320 +/- ## == - Coverage 77.16% 77.01% -0.16% == Files 973 973 Lines 5052350523 Branches 6184 6184 == - Hits3898638909 -77 - Misses 1133111408 +77 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.70% <ø> (ø)` | | | postgres | `81.72% <ø> (ø)` | | | python | `81.81% <ø> (-0.30%)` | :arrow_down: | | sqlite | `81.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15320?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <ø> (-0.41%)` | :arrow_down: | | [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `88.63% <ø> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-1.06%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-0.24%)` | :arrow_down: | | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/15320/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.93% <0.00%> (-0.13%)` | :arrow_down: | -- [Continue to review
[GitHub] [superset] codecov[bot] edited a comment on pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries
codecov[bot] edited a comment on pull request #15082: URL: https://github.com/apache/superset/pull/15082#issuecomment-858573390 # [Codecov](https://codecov.io/gh/apache/superset/pull/15082?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15082](https://codecov.io/gh/apache/superset/pull/15082?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a330b66) into [1.2](https://codecov.io/gh/apache/superset/commit/387d93302fa2f4f475cd572b62d0908615e67919?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (387d933) will **decrease** coverage by `0.19%`. > The diff coverage is `68.86%`. > :exclamation: Current head a330b66 differs from pull request most recent head 374f942. Consider uploading reports for the commit 374f942 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15082?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## 1.2 #15082 +/- ## == - Coverage 77.20% 77.00% -0.20% == Files 956 973 +17 Lines 4816450494+2330 Branches 6006 6184 +178 == + Hits3718338881+1698 - Misses 1077611407 +631 - Partials 205 206 +1 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.70% <ø> (+0.67%)` | :arrow_up: | | postgres | `81.70% <ø> (+0.64%)` | :arrow_up: | | python | `81.79% <ø> (+0.35%)` | :arrow_up: | | sqlite | `81.36% <ø> (+0.68%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15082?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset-frontend/src/CRUD/Fieldset.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGRzZXQuanN4) | `85.71% <ø> (ø)` | | | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ø)` | | | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.97% <ø> (ø)` | | | [...-frontend/src/SqlLab/components/SouthPane/state.ts](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9zdGF0ZS50cw==) | `100.00% <ø> (ø)` | | | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `34.95% <ø> (ø)` | | | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `50.00% <ø> (ø)` | | | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | | |
[GitHub] [superset] pkdotson merged pull request #15309: refactor: migrate icon to icons in tablecollection
pkdotson merged pull request #15309: URL: https://github.com/apache/superset/pull/15309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets
kgabryje commented on a change in pull request #15302:
URL: https://github.com/apache/superset/pull/15302#discussion_r657306915
##
File path:
superset-frontend/src/common/hooks/useComponentDidUpdate/useComponentDidUpdate.ts
##
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { EffectCallback, useEffect, useRef } from 'react';
+
+export const useComponentDidUpdate = (effect: EffectCallback) => {
+ const isMountedRef = useRef(false);
+ // eslint-disable-next-line react-hooks/exhaustive-deps
+ useEffect(() => {
+if (isMountedRef.current) {
+ effect();
+}
+ }, [effect]);
+
+ useEffect(() => {
Review comment:
Good point, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets
codecov[bot] edited a comment on pull request #15302: URL: https://github.com/apache/superset/pull/15302#issuecomment-866830279 # [Codecov](https://codecov.io/gh/apache/superset/pull/15302?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15302](https://codecov.io/gh/apache/superset/pull/15302?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (54121df) into [master](https://codecov.io/gh/apache/superset/commit/cef3dc0b02bf0e1610465c6db7f71a3dc0c9a7e6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cef3dc0) will **decrease** coverage by `0.00%`. > The diff coverage is `87.34%`. > :exclamation: Current head 54121df differs from pull request most recent head cd6232a. Consider uploading reports for the commit cd6232a to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15302?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15302 +/- ## == - Coverage 77.23% 77.22% -0.01% == Files 973 975 +2 Lines 5043850522 +84 Branches 6175 6201 +26 == + Hits3895739018 +61 - Misses 1127611297 +21 - Partials 205 207 +2 ``` | Flag | Coverage Δ | | |---|---|---| | javascript | `71.80% <87.34%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15302?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...nd/src/common/hooks/useComponentDidUpdate/index.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDb21wb25lbnREaWRVcGRhdGUvaW5kZXgudHM=) | `0.00% <0.00%> (ø)` | | | [...ilterScopingModal/CrossFilterScopingForm/index.tsx](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0vaW5kZXgudHN4) | `84.61% <ø> (ø)` | | | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `95.65% <66.66%> (-4.35%)` | :arrow_down: | | [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `90.62% <80.00%> (-5.03%)` | :arrow_down: | | [...ConfigModal/FiltersConfigForm/FilterScope/utils.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3V0aWxzLnRz) | `95.89% <81.81%> (-2.62%)` | :arrow_down: | |
[GitHub] [superset] kgabryje commented on a change in pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets
kgabryje commented on a change in pull request #15302:
URL: https://github.com/apache/superset/pull/15302#discussion_r657306740
##
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.test.tsx
##
@@ -115,6 +115,7 @@ describe('FilterScope', () => {
fireEvent.click(screen.getByText('Scoping'));
fireEvent.click(screen.getByLabelText('Apply to specific panels'));
+screen.debug(undefined, 3);
Review comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] srinify merged pull request #15245: docs: fix hyperlink
srinify merged pull request #15245: URL: https://github.com/apache/superset/pull/15245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries
codecov[bot] edited a comment on pull request #15082: URL: https://github.com/apache/superset/pull/15082#issuecomment-858573390 # [Codecov](https://codecov.io/gh/apache/superset/pull/15082?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15082](https://codecov.io/gh/apache/superset/pull/15082?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a330b66) into [1.2](https://codecov.io/gh/apache/superset/commit/387d93302fa2f4f475cd572b62d0908615e67919?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (387d933) will **decrease** coverage by `0.18%`. > The diff coverage is `68.86%`. > :exclamation: Current head a330b66 differs from pull request most recent head 374f942. Consider uploading reports for the commit 374f942 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15082?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## 1.2 #15082 +/- ## == - Coverage 77.20% 77.01% -0.19% == Files 956 973 +17 Lines 4816450523+2359 Branches 6006 6184 +178 == + Hits3718338909+1726 - Misses 1077611408 +632 - Partials 205 206 +1 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.70% <ø> (+0.67%)` | :arrow_up: | | postgres | `81.72% <ø> (+0.66%)` | :arrow_up: | | python | `81.81% <ø> (+0.37%)` | :arrow_up: | | sqlite | `81.36% <ø> (+0.68%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15082?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset-frontend/src/CRUD/Fieldset.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGRzZXQuanN4) | `85.71% <ø> (ø)` | | | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ø)` | | | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.97% <ø> (ø)` | | | [...-frontend/src/SqlLab/components/SouthPane/state.ts](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9zdGF0ZS50cw==) | `100.00% <ø> (ø)` | | | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `34.95% <ø> (ø)` | | | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `50.00% <ø> (ø)` | | | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | | |
[GitHub] [superset] codecov[bot] commented on pull request #15334: fix: Big Query Error messaging
codecov[bot] commented on pull request #15334: URL: https://github.com/apache/superset/pull/15334#issuecomment-867050505 # [Codecov](https://codecov.io/gh/apache/superset/pull/15334?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15334](https://codecov.io/gh/apache/superset/pull/15334?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e99f6bd) into [pexdax/db-connection-ui](https://codecov.io/gh/apache/superset/commit/725f406064ec26a476212f163118945ddcbce0da?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (725f406) will **decrease** coverage by `0.86%`. > The diff coverage is `16.66%`. > :exclamation: Current head e99f6bd differs from pull request most recent head a93f30a. Consider uploading reports for the commit a93f30a to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15334?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## pexdax/db-connection-ui #15334 +/- ## === - Coverage77.01% 76.14% -0.87% === Files 975 973 -2 Lines5418051372-2808 Branches 6587 6587 === - Hits 4172739119-2608 + Misses 1223412034 -200 Partials 219 219 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `?` | | | postgres | `81.70% <16.66%> (-0.62%)` | :arrow_down: | | presto | `?` | | | python | `81.74% <16.66%> (-1.08%)` | :arrow_down: | | sqlite | `81.35% <16.66%> (-0.63%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15334?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `34.56% <ø> (ø)` | | | [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `87.41% <16.66%> (-0.62%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.95%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-4.89%)` | :arrow_down: | |
[GitHub] [superset] john-bodley merged pull request #15319: fix: Capitalize time granularity weekdays
john-bodley merged pull request #15319: URL: https://github.com/apache/superset/pull/15319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] serenajiang merged pull request #15285: fix: Revert "build(webpack): use [contenthash] instead of [chunkhash]"
serenajiang merged pull request #15285: URL: https://github.com/apache/superset/pull/15285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL
john-bodley commented on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-867028511 @villebro would you mind re-reviewing this PR? I added all the additional time grains (not just week starting/ending) which have not previously been defined or the SQL connector. Let me know if this should be added in `db_engine_specs/base.py` (as defined) or whether `db_engine_specs/druid.py` should override the `get_time_grains()` method. Furthermore I'm not sure if additional work is required, i.e., for Pandas post processing per [here](https://github.com/apache/superset/blob/7c17b1a97faae45883a141e5e70bfd4b66c902f0/superset/utils/pandas_postprocessing.py#L85-L102v). Additionally I'm not sure if the custom [time grain configuration logic](https://github.com/apache/superset/blob/master/superset/config.py#L544-L557) actually works if these need to be defined within the post processing as mentioned above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15302: feat(native-filters): Set default scope by filters' and charts' datasets
codecov[bot] edited a comment on pull request #15302: URL: https://github.com/apache/superset/pull/15302#issuecomment-866830279 # [Codecov](https://codecov.io/gh/apache/superset/pull/15302?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15302](https://codecov.io/gh/apache/superset/pull/15302?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cd6232a) into [master](https://codecov.io/gh/apache/superset/commit/cef3dc0b02bf0e1610465c6db7f71a3dc0c9a7e6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cef3dc0) will **decrease** coverage by `0.01%`. > The diff coverage is `87.17%`. [](https://codecov.io/gh/apache/superset/pull/15302?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #15302 +/- ## == - Coverage 77.23% 77.22% -0.02% == Files 973 975 +2 Lines 5043850525 +87 Branches 6175 6201 +26 == + Hits3895739017 +60 - Misses 1127611301 +25 - Partials 205 207 +2 ``` | Flag | Coverage Δ | | |---|---|---| | javascript | `71.79% <87.17%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15302?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...nd/src/common/hooks/useComponentDidUpdate/index.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDb21wb25lbnREaWRVcGRhdGUvaW5kZXgudHM=) | `0.00% <0.00%> (ø)` | | | [...ilterScopingModal/CrossFilterScopingForm/index.tsx](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0vaW5kZXgudHN4) | `84.61% <ø> (ø)` | | | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `95.65% <66.66%> (-4.35%)` | :arrow_down: | | [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `90.62% <80.00%> (-5.03%)` | :arrow_down: | | [...ConfigModal/FiltersConfigForm/FilterScope/utils.ts](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3V0aWxzLnRz) | `95.89% <81.81%> (-2.62%)` | :arrow_down: | | [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/15302/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `69.97% <90.00%> (-0.03%)` | :arrow_down: | |
[GitHub] [superset] john-bodley edited a comment on pull request #15320: chore: Add Druid SQL time grains for parity with Druid NoSQL
john-bodley edited a comment on pull request #15320: URL: https://github.com/apache/superset/pull/15320#issuecomment-867028511 @villebro would you mind re-reviewing this PR? I added all the additional time grains (not just week starting/ending) which have not previously been defined or the SQL connector. Let me know if this should be added in `db_engine_specs/base.py` (as defined) or whether `db_engine_specs/druid.py` should override the `get_time_grains()` method. Furthermore I'm not sure if additional work is required, i.e., for Pandas post processing per [here](https://github.com/apache/superset/blob/7c17b1a97faae45883a141e5e70bfd4b66c902f0/superset/utils/pandas_postprocessing.py#L85-L102v). Additionally I'm not sure if the custom [time grain configuration logic](https://github.com/apache/superset/blob/master/superset/config.py#L544-L557) actually works if these need to be defined within the post processing as mentioned above, i.e., can Superset really support custom time grains? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] hughhhh opened a new pull request #15334: fix: Big Query Error messaging
hug opened a new pull request #15334: URL: https://github.com/apache/superset/pull/15334 ### SUMMARY Raising the proper validation errors for BigQuery malformatted request. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries
codecov[bot] edited a comment on pull request #15082: URL: https://github.com/apache/superset/pull/15082#issuecomment-858573390 # [Codecov](https://codecov.io/gh/apache/superset/pull/15082?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15082](https://codecov.io/gh/apache/superset/pull/15082?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a330b66) into [1.2](https://codecov.io/gh/apache/superset/commit/387d93302fa2f4f475cd572b62d0908615e67919?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (387d933) will **decrease** coverage by `0.18%`. > The diff coverage is `68.86%`. > :exclamation: Current head a330b66 differs from pull request most recent head 374f942. Consider uploading reports for the commit 374f942 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15082?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## 1.2 #15082 +/- ## == - Coverage 77.20% 77.01% -0.19% == Files 956 973 +17 Lines 4816450523+2359 Branches 6006 6184 +178 == + Hits3718338909+1726 - Misses 1077611408 +632 - Partials 205 206 +1 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | javascript | `71.76% <68.86%> (-0.56%)` | :arrow_down: | | mysql | `81.70% <ø> (+0.67%)` | :arrow_up: | | postgres | `81.72% <ø> (+0.66%)` | :arrow_up: | | python | `81.81% <ø> (+0.37%)` | :arrow_up: | | sqlite | `81.36% <ø> (+0.68%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15082?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset-frontend/src/CRUD/Fieldset.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGRzZXQuanN4) | `85.71% <ø> (ø)` | | | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ø)` | | | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.97% <ø> (ø)` | | | [...-frontend/src/SqlLab/components/SouthPane/state.ts](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9zdGF0ZS50cw==) | `100.00% <ø> (ø)` | | | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `34.95% <ø> (ø)` | | | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `50.00% <ø> (ø)` | | | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15334: fix: Big Query Error messaging
codecov[bot] edited a comment on pull request #15334: URL: https://github.com/apache/superset/pull/15334#issuecomment-867050505 # [Codecov](https://codecov.io/gh/apache/superset/pull/15334?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15334](https://codecov.io/gh/apache/superset/pull/15334?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e99f6bd) into [pexdax/db-connection-ui](https://codecov.io/gh/apache/superset/commit/725f406064ec26a476212f163118945ddcbce0da?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (725f406) will **decrease** coverage by `0.86%`. > The diff coverage is `16.66%`. > :exclamation: Current head e99f6bd differs from pull request most recent head c5153df. Consider uploading reports for the commit c5153df to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15334?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## pexdax/db-connection-ui #15334 +/- ## === - Coverage77.01% 76.14% -0.87% === Files 975 973 -2 Lines5418051372-2808 Branches 6587 6587 === - Hits 4172739119-2608 + Misses 1223412034 -200 Partials 219 219 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `?` | | | postgres | `81.70% <16.66%> (-0.62%)` | :arrow_down: | | presto | `?` | | | python | `81.74% <16.66%> (-1.08%)` | :arrow_down: | | sqlite | `81.35% <16.66%> (-0.63%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15334?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `34.56% <ø> (ø)` | | | [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `87.41% <16.66%> (-0.62%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.95%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-4.89%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15334: fix: Big Query Error messaging
codecov[bot] edited a comment on pull request #15334: URL: https://github.com/apache/superset/pull/15334#issuecomment-867050505 # [Codecov](https://codecov.io/gh/apache/superset/pull/15334?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15334](https://codecov.io/gh/apache/superset/pull/15334?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2934591) into [pexdax/db-connection-ui](https://codecov.io/gh/apache/superset/commit/725f406064ec26a476212f163118945ddcbce0da?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (725f406) will **decrease** coverage by `0.86%`. > The diff coverage is `33.33%`. > :exclamation: Current head 2934591 differs from pull request most recent head c5153df. Consider uploading reports for the commit c5153df to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15334?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## pexdax/db-connection-ui #15334 +/- ## === - Coverage77.01% 76.14% -0.87% === Files 975 973 -2 Lines5418051375-2805 Branches 6587 6587 === - Hits 4172739121-2606 + Misses 1223412035 -199 Partials 219 219 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `?` | | | postgres | `81.70% <33.33%> (-0.62%)` | :arrow_down: | | presto | `?` | | | python | `81.74% <33.33%> (-1.08%)` | :arrow_down: | | sqlite | `81.35% <33.33%> (-0.63%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15334?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `34.56% <ø> (ø)` | | | [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `87.41% <16.66%> (-0.62%)` | :arrow_down: | | [superset/databases/commands/validate.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3ZhbGlkYXRlLnB5) | `74.57% <66.66%> (-0.43%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.95%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15334: fix: Big Query Error messaging
codecov[bot] edited a comment on pull request #15334: URL: https://github.com/apache/superset/pull/15334#issuecomment-867050505 # [Codecov](https://codecov.io/gh/apache/superset/pull/15334?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15334](https://codecov.io/gh/apache/superset/pull/15334?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2934591) into [pexdax/db-connection-ui](https://codecov.io/gh/apache/superset/commit/725f406064ec26a476212f163118945ddcbce0da?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (725f406) will **decrease** coverage by `0.86%`. > The diff coverage is `33.33%`. > :exclamation: Current head 2934591 differs from pull request most recent head 60c135d. Consider uploading reports for the commit 60c135d to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15334?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## pexdax/db-connection-ui #15334 +/- ## === - Coverage77.01% 76.14% -0.87% === Files 975 973 -2 Lines5418051375-2805 Branches 6587 6587 === - Hits 4172739121-2606 + Misses 1223412035 -199 Partials 219 219 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `?` | | | postgres | `81.70% <33.33%> (-0.62%)` | :arrow_down: | | presto | `?` | | | python | `81.74% <33.33%> (-1.08%)` | :arrow_down: | | sqlite | `81.35% <33.33%> (-0.63%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15334?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `34.56% <ø> (ø)` | | | [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `87.41% <16.66%> (-0.62%)` | :arrow_down: | | [superset/databases/commands/validate.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3ZhbGlkYXRlLnB5) | `74.57% <66.66%> (-0.43%)` | :arrow_down: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15334/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.95%)` | :arrow_down: | |
[GitHub] [superset] hughhhh merged pull request #15334: fix: Big Query Error messaging
hug merged pull request #15334: URL: https://github.com/apache/superset/pull/15334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI
codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 # [Codecov](https://codecov.io/gh/apache/superset/pull/14881?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#14881](https://codecov.io/gh/apache/superset/pull/14881?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c64ad88) into [master](https://codecov.io/gh/apache/superset/commit/c7c63751e9cc2d64f2041d3aae671b0a2bbde51e?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c7c6375) will **decrease** coverage by `0.22%`. > The diff coverage is `68.57%`. > :exclamation: Current head c64ad88 differs from pull request most recent head c283be6. Consider uploading reports for the commit c283be6 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/14881?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #14881 +/- ## == - Coverage 77.25% 77.03% -0.23% == Files 971 971 Lines 5030850325 +17 Branches 6140 6140 == - Hits3886738766 -101 - Misses 1123711355 +118 Partials 204 204 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.70% <69.44%> (+<0.01%)` | :arrow_up: | | postgres | `81.72% <69.44%> (+<0.01%)` | :arrow_up: | | presto | `?` | | | python | `81.80% <69.44%> (-0.44%)` | :arrow_down: | | sqlite | `81.35% <69.44%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14881?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | | | [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | | | [...set-frontend/src/views/CRUD/data/database/types.ts](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS90eXBlcy50cw==) | `100.00% <ø> (ø)` | | | [superset/config.py](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.15% <ø> (ø)` | | | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `53.02% <33.33%> (ø)` | | | [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `87.41% <37.50%> (-2.22%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 # [Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15304](https://codecov.io/gh/apache/superset/pull/15304?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c0ac8c1) into [fancy-viz-select-modal](https://codecov.io/gh/apache/superset/commit/c99a44fc70f5c6e1f075e89379df4dd9045abfaa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c99a44f) will **decrease** coverage by `0.22%`. > The diff coverage is `100.00%`. > :exclamation: Current head c0ac8c1 differs from pull request most recent head 8b6f8bc. Consider uploading reports for the commit 8b6f8bc to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## fancy-viz-select-modal #15304 +/- ## == - Coverage 77.79% 77.57% -0.23% == Files 966 966 Lines 4965249671 +19 Branches 6319 5949 -370 == - Hits3862738532 -95 - Misses 1082410940 +116 + Partials 201 199 -2 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | javascript | `72.84% <100.00%> (+0.02%)` | :arrow_up: | | presto | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...plore/components/controls/VizTypeControl/index.tsx](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9pbmRleC50c3g=) | `96.87% <100.00%> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-1.66%)` | :arrow_down: | |
[GitHub] [superset] rusackas merged pull request #15306: refactor: Icon to icons for certifiedIcon
rusackas merged pull request #15306: URL: https://github.com/apache/superset/pull/15306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15306: refactor: Icon to icons for certifiedIcon
github-actions[bot] commented on pull request #15306: URL: https://github.com/apache/superset/pull/15306#issuecomment-867148199 Ephemeral environment shutdown and build artifacts deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15337: feat: Add validation Errors to bottom alert
codecov[bot] edited a comment on pull request #15337: URL: https://github.com/apache/superset/pull/15337#issuecomment-867148577 # [Codecov](https://codecov.io/gh/apache/superset/pull/15337?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15337](https://codecov.io/gh/apache/superset/pull/15337?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (13db62b) into [pexdax/db-connection-ui](https://codecov.io/gh/apache/superset/commit/c283be61a29237ef759d315f89c6ed2054aed7ec?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c283be6) will **decrease** coverage by `0.23%`. > The diff coverage is `14.28%`. [](https://codecov.io/gh/apache/superset/pull/15337?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## pexdax/db-connection-ui #15337 +/- ## === - Coverage76.75% 76.52% -0.24% === Files 972 972 Lines5061150611 Branches 6258 6258 === - Hits 3884938731 -118 - Misses 1155611674 +118 Partials 206 206 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.70% <ø> (ø)` | | | postgres | `81.72% <ø> (ø)` | | | presto | `?` | | | python | `81.80% <ø> (-0.45%)` | :arrow_down: | | sqlite | `81.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15337?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/15337/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `46.39% <0.00%> (ø)` | | | [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/15337/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `34.56% <16.66%> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15337/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15337/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.20% <0.00%> (-17.21%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15337/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.95%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15337/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15337/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-1.66%)` | :arrow_down: |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 # [Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15304](https://codecov.io/gh/apache/superset/pull/15304?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1a718d3) into [fancy-viz-select-modal](https://codecov.io/gh/apache/superset/commit/c99a44fc70f5c6e1f075e89379df4dd9045abfaa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c99a44f) will **decrease** coverage by `0.22%`. > The diff coverage is `100.00%`. > :exclamation: Current head 1a718d3 differs from pull request most recent head 092b2a7. Consider uploading reports for the commit 092b2a7 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## fancy-viz-select-modal #15304 +/- ## == - Coverage 77.79% 77.57% -0.23% == Files 966 966 Lines 4965249671 +19 Branches 6319 5949 -370 == - Hits3862738532 -95 - Misses 1082410940 +116 + Partials 201 199 -2 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | javascript | `72.84% <100.00%> (+0.02%)` | :arrow_up: | | presto | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...plore/components/controls/VizTypeControl/index.tsx](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9pbmRleC50c3g=) | `96.87% <100.00%> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-1.66%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15082: fix: Honor ROW_LIMIT setting in elasticsearch queries
codecov[bot] edited a comment on pull request #15082: URL: https://github.com/apache/superset/pull/15082#issuecomment-858573390 # [Codecov](https://codecov.io/gh/apache/superset/pull/15082?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15082](https://codecov.io/gh/apache/superset/pull/15082?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a330b66) into [1.2](https://codecov.io/gh/apache/superset/commit/387d93302fa2f4f475cd572b62d0908615e67919?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (387d933) will **increase** coverage by `0.04%`. > The diff coverage is `68.86%`. > :exclamation: Current head a330b66 differs from pull request most recent head 374f942. Consider uploading reports for the commit 374f942 to get more accurate results [](https://codecov.io/gh/apache/superset/pull/15082?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## 1.2 #15082 +/- ## == + Coverage 77.20% 77.24% +0.04% == Files 956 973 +17 Lines 4816450523+2359 Branches 6006 6184 +178 == + Hits3718339025+1842 - Misses 1077611292 +516 - Partials 205 206 +1 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.43% <ø> (+0.66%)` | :arrow_up: | | javascript | `71.76% <68.86%> (-0.56%)` | :arrow_down: | | mysql | `81.70% <ø> (+0.67%)` | :arrow_up: | | postgres | `81.72% <ø> (+0.66%)` | :arrow_up: | | presto | `81.42% <ø> (?)` | | | python | `82.25% <ø> (+0.81%)` | :arrow_up: | | sqlite | `81.36% <ø> (+0.68%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15082?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [superset-frontend/src/CRUD/Fieldset.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGRzZXQuanN4) | `85.71% <ø> (ø)` | | | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ø)` | | | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.97% <ø> (ø)` | | | [...-frontend/src/SqlLab/components/SouthPane/state.ts](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9zdGF0ZS50cw==) | `100.00% <ø> (ø)` | | | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `34.95% <ø> (ø)` | | | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/15082/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `50.00% <ø> (ø)` | | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 # [Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15304](https://codecov.io/gh/apache/superset/pull/15304?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (092b2a7) into [fancy-viz-select-modal](https://codecov.io/gh/apache/superset/commit/c99a44fc70f5c6e1f075e89379df4dd9045abfaa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c99a44f) will **decrease** coverage by `0.22%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## fancy-viz-select-modal #15304 +/- ## == - Coverage 77.79% 77.57% -0.23% == Files 966 966 Lines 4965249671 +19 Branches 6319 5949 -370 == - Hits3862738532 -95 - Misses 1082410940 +116 + Partials 201 199 -2 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `81.70% <ø> (ø)` | | | postgres | `81.73% <ø> (ø)` | | | presto | `?` | | | python | `81.81% <ø> (-0.44%)` | :arrow_down: | | sqlite | `81.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...plore/components/controls/VizTypeControl/index.tsx](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9pbmRleC50c3g=) | `96.87% <100.00%> (ø)` | | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.32% <0.00%> (-17.08%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.36% <0.00%> (-6.53%)` | :arrow_down: | | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.15% <0.00%> (-1.66%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.97% <0.00%> (-0.41%)` | :arrow_down: | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #14881: feat: Database Connection UI
codecov[bot] edited a comment on pull request #14881: URL: https://github.com/apache/superset/pull/14881#issuecomment-849871089 # [Codecov](https://codecov.io/gh/apache/superset/pull/14881?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#14881](https://codecov.io/gh/apache/superset/pull/14881?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c64ad88) into [master](https://codecov.io/gh/apache/superset/commit/c7c63751e9cc2d64f2041d3aae671b0a2bbde51e?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c7c6375) will **decrease** coverage by `0.25%`. > The diff coverage is `68.57%`. [](https://codecov.io/gh/apache/superset/pull/14881?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #14881 +/- ## == - Coverage 77.25% 77.00% -0.26% == Files 971 971 Lines 5030850325 +17 Branches 6140 6140 == - Hits3886738754 -113 - Misses 1123711367 +130 Partials 204 204 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `?` | | | mysql | `?` | | | postgres | `81.72% <69.44%> (+<0.01%)` | :arrow_up: | | presto | `?` | | | python | `81.76% <69.44%> (-0.49%)` | :arrow_down: | | sqlite | `81.35% <69.44%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14881?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | | | [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | | | [...set-frontend/src/views/CRUD/data/database/types.ts](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS90eXBlcy50cw==) | `100.00% <ø> (ø)` | | | [superset/config.py](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.15% <ø> (ø)` | | | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `53.02% <33.33%> (ø)` | | | [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `87.41% <37.50%> (-2.22%)` | :arrow_down: | | [.../database/DatabaseModal/DatabaseConnectionForm.tsx](https://codecov.io/gh/apache/superset/pull/14881/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL0RhdGFiYXNlQ29ubmVjdGlvbkZvcm0udHN4) | `48.48% <51.85%> (ø)` | | |
[GitHub] [superset] codecov[bot] edited a comment on pull request #15304: feat(viz): add categories to the viz picker
codecov[bot] edited a comment on pull request #15304: URL: https://github.com/apache/superset/pull/15304#issuecomment-85777 # [Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#15304](https://codecov.io/gh/apache/superset/pull/15304?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (092b2a7) into [fancy-viz-select-modal](https://codecov.io/gh/apache/superset/commit/c99a44fc70f5c6e1f075e89379df4dd9045abfaa?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c99a44f) will **increase** coverage by `0.01%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## fancy-viz-select-modal #15304 +/- ## == + Coverage 77.79% 77.80% +0.01% == Files 966 966 Lines 4965249671 +19 Branches 6319 5949 -370 == + Hits3862738649 +22 + Misses 1082410823 -1 + Partials 201 199 -2 ``` | Flag | Coverage Δ | | |---|---|---| | hive | `81.44% <ø> (ø)` | | | mysql | `81.70% <ø> (ø)` | | | postgres | `81.73% <ø> (ø)` | | | presto | `81.43% <ø> (+<0.01%)` | :arrow_up: | | python | `82.25% <ø> (+<0.01%)` | :arrow_up: | | sqlite | `81.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15304?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...plore/components/controls/VizTypeControl/index.tsx](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9pbmRleC50c3g=) | `96.87% <100.00%> (ø)` | | | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `50.85% <0.00%> (ø)` | | | [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | `64.28% <0.00%> (ø)` | | | [...plore/components/controls/VizTypeControl/index.jsx](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9pbmRleC5qc3g=) | | | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/15304/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `90.31% <0.00%> (+0.42%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15304?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? =
[GitHub] [superset] pkdotson opened a new pull request #15336: refactor: icon to icons for basicerror componenet
pkdotson opened a new pull request #15336: URL: https://github.com/apache/superset/pull/15336 ### SUMMARY This pr refactors the basicerror icon to icons. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF before https://user-images.githubusercontent.com/17326228/123161138-e708f580-d423-11eb-8bf2-aa269ce2d293.png;> https://user-images.githubusercontent.com/17326228/123161494-4e26aa00-d424-11eb-9f72-64874c7428a0.png;> after https://user-images.githubusercontent.com/17326228/123161163-ee300380-d423-11eb-8d94-dd8b52c1be62.png;> https://user-images.githubusercontent.com/17326228/123161494-4e26aa00-d424-11eb-9f72-64874c7428a0.png;> ### TESTING INSTRUCTIONS To test you must enable nativefilters feature flags and check the filterconfigmodal and filterbox for the basic error alert. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [superset] john-bodley commented on a change in pull request #15184: fix: datasource payload is incorrect
john-bodley commented on a change in pull request #15184:
URL: https://github.com/apache/superset/pull/15184#discussion_r657430908
##
File path: superset/connectors/connector_registry.py
##
@@ -99,6 +100,41 @@ def get_datasource_by_id( # pylint:
disable=too-many-arguments
pass
raise NoResultFound(_("Datasource id not found: %(id)s",
id=datasource_id))
+@classmethod
+def get_user_datasources(cls, session: Session) -> List["BaseDatasource"]:
+from superset import security_manager
+
+# collect datasources which the user has explicit permissions to
+user_perms = security_manager.user_view_menu_names("datasource_access")
+schema_perms = security_manager.user_view_menu_names("schema_access")
+user_datasources = set()
+for datasource_class in ConnectorRegistry.sources.values():
+user_datasources.update(
+session.query(datasource_class)
Review comment:
@betodealmeida @dpgaspar I believe this logic, i.e., relying on the
fragile `perm` and `schema_perm` columns in the database, breaks if people are
using a custom security manager. Should we be calling
[get_datasources_accessible_by_user](https://github.com/apache/superset/blob/a06a2f30af02820189450b2264fa6bb734507ed8/superset/security/manager.py#L508)
instead?
Note I sense currently Superset doesn't do a great job of differentiating
between metadata and data access. The `get_datasources_accessible_by_user` is
somewhat of a misnomer as it is merely used for metadata access (for an
awareness perspective).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
