[GitHub] michellethomas opened a new pull request #5021: Allow MetricsControl to aggregate on a column with an expression
michellethomas opened a new pull request #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021 In the new MetricsControl, selecting a column with an expression would fail because it's just using the column name which doesn't exist in the underlying table (only in our metadata). This would add the expression (if there is one) inside the aggregation. @john-bodley @GabeLoins @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5020: Make port number optional in superset for druid
codecov-io commented on issue #5020: Make port number optional in superset for druid URL: https://github.com/apache/incubator-superset/pull/5020#issuecomment-389665315 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr=h1) Report > Merging [#5020](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e72c9cded37f7e1b6eaf3c5192249f5d08ce5ce4?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5020 +/- ## == - Coverage 77.34% 77.33% -0.01% == Files 44 44 Lines8664 8667 +3 == + Hits 6701 6703 +2 - Misses 1963 1964 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5020/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `80.44% <75%> (-0.06%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr=footer). Last update [e72c9cd...d3f2a12](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] jasnovak commented on issue #4900: Hide restricted ui elements, remove from error message
jasnovak commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389649681 @graceguo-supercat No, we don't have that case. But I think to support both cases, you may need another permission, say can_save_as_dash This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] xrmx commented on issue #5016: Hi All I am very new with superset, i tired to add a mysql database, all connection tested result seem OK with the list of the tables at the bottom of page, but
xrmx commented on issue #5016: Hi All I am very new with superset, i tired to add a mysql database, all connection tested result seem OK with the list of the tables at the bottom of page, but when I tried to save it present the error: General Error . Any one have faced this before? URL: https://github.com/apache/incubator-superset/issues/5016#issuecomment-389655330 Please close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] amalakar opened a new pull request #5020: Make port number optional in superset for druid
amalakar opened a new pull request #5020: Make port number optional in superset for druid URL: https://github.com/apache/incubator-superset/pull/5020 It appears that urllib throws error with ssl if port number is provided ``` url = "https://example.com:443/druid/v2; req = urllib.request.Request(url, druid_query_str, headers) res = urllib.request.urlopen(req) ``` The above call fails with the following error: ``` urllib2.HTTPError: HTTP Error 404: Not Found ``` If url is set to https://example.com/druid/v2 it works, this change makes the port number optional. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] amalakar commented on issue #5020: Make port number optional in superset for druid
amalakar commented on issue #5020: Make port number optional in superset for druid URL: https://github.com/apache/incubator-superset/pull/5020#issuecomment-389658902 Full stack trace: ``` Traceback (most recent call last): File "/Users/amalakar/Library/Preferences/IntelliJIdea2017.3/scratches/scratch_6.py", line 21, in res = urllib.request.urlopen(req) File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 154, in urlopen return opener.open(url, data, timeout) File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 435, in open response = meth(req, response) File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 548, in http_response 'http', request, response, code, msg, hdrs) File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 473, in error return self._call_chain(*args) File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 407, in _call_chain result = func(*args) File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 556, in http_error_default raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) urllib2.HTTPError: HTTP Error 404: Not Found ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley commented on issue #5019: fix missing datasource error message
john-bodley commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389665676 Should we cascade deleted datasource and delete the corresponding slice(s)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389738913 @john-bodley In the case where I found the issue, the user wasn't aware the underlying datasource was missing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389738913 @john-bodley In the case where I found the issue, the user wasn't aware the underlying datasource was missing. I think deleting would have been even more confusing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389738913 @john-bodley In the case where I found the issue, the user wasn't aware the underlying datasource was missing. I think deleting would have been even more confusing for him. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit
codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#issuecomment-389737583 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=h1) Report > Merging [#5023](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a64b3f57747d7b9328d4a5f84afe8f7b21b069b?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `85.71%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5023 +/- ## == + Coverage 77.34% 77.35% +0.01% == Files 44 44 Lines8665 8678 +13 == + Hits 6702 6713 +11 - Misses 1963 1965 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.66% <ø> (ø)` | :arrow_up: | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `75.54% <100%> (+0.26%)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.76% <81.81%> (-0.15%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=footer). Last update [5a64b3f...71ca5cc](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] hajdbo commented on issue #4857: Incorrect SQL statement on "View Query": python-encoded % character (%%) on STR_TO_DATE()
hajdbo commented on issue #4857: Incorrect SQL statement on "View Query": python-encoded % character (%%) on STR_TO_DATE() URL: https://github.com/apache/incubator-superset/issues/4857#issuecomment-389391118 Seems very closely related to https://github.com/apache/incubator-superset/issues/617 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389759380 @mistercrunch Upon furthher investigation, I think the current approach is best for the following reaosns 1. datasource_info is the first place the datasource is checked from the form data. And it's the first place 2. The method intentionally does not fail because the error is handled downstream (https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L60), where the intelligible error message (Viz is missing a datasource) is displayed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389759380 @john-bodley @mistercrunch Upon furthher investigation, I think the current approach is best for the following reaosns 1. datasource_info is the first place the datasource is checked from the form data. And it's the first place 2. The method intentionally does not fail because the error is handled downstream (https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L64), where the intelligible error message (Viz is missing a datasource) is displayed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley commented on issue #5031: Dashboard initial page load logging with tabs
john-bodley commented on issue #5031: Dashboard initial page load logging with tabs URL: https://github.com/apache/incubator-superset/pull/5031#issuecomment-391418634 I think there’s merit in providing more generic logging where each page component is uniquely identifiable. That provides various consumers with the flexibility of being able to decide how they consume the performance data. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric
mistercrunch commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric URL: https://github.com/apache/incubator-superset/issues/5045#issuecomment-390553650 @GabeLoins This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] hughhhh commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState
hug commented on a change in pull request #5057: Translate string to array
for multi fields in getControlsState
URL:
https://github.com/apache/incubator-superset/pull/5057#discussion_r190262556
##
File path: superset/assets/src/explore/store.js
##
@@ -56,6 +56,10 @@ export function getControlsState(state, form_data) {
delete control.mapStateToProps;
}
+if (control.multi && typeof formData[k] === 'string') {
Review comment:
nit: `formData[k] = (control.multi && typeof formData[k] === 'string') ?
[formData[k]] : formData[k]`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] hughhhh commented on issue #5057: Translate string to array for multi fields in getControlsState
hug commented on issue #5057: Translate string to array for multi fields in getControlsState URL: https://github.com/apache/incubator-superset/pull/5057#issuecomment-391362905 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5055: Fixing tooltip displaying metrics in heatmap
codecov-io commented on issue #5055: Fixing tooltip displaying metrics in heatmap URL: https://github.com/apache/incubator-superset/pull/5055#issuecomment-391102466 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5055?src=pr=h1) Report > Merging [#5055](https://codecov.io/gh/apache/incubator-superset/pull/5055?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b8aeb1a8255bb057248f818dca96ab10fa42eee1?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/5055?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5055 +/- ## === Coverage 77.52% 77.52% === Files 44 44 Lines8707 8707 === Hits 6750 6750 Misses 1957 1957 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5055?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5055?src=pr=footer). Last update [b8aeb1a...0a76a7c](https://codecov.io/gh/apache/incubator-superset/pull/5055?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas commented on issue #4981: Make time filter more usable
michellethomas commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391108467 Yeah after looking into it, it may be difficult to message because it depends on whether you are using a date or not (and also which engine you are using). For us using dates (not datetime): druid start date inclusive / end date exclusive sqla (with presto) start date exclusive / end date inclusive sqla tries to be inclusive on both ends and will add a filter like `WHERE "ds" >= '2018-05-14 00:00:00' AND "ds" <= '2018-05-18 00:00:00'` but it’s getting excluded because of the lexicographic order. Here's a discussion of the issue. I think it was just dropped because we couldn't find a regression, but there's still an inconsistency we should discuss (maybe out of scope for this PR) https://apache-superset.slack.com/archives/C7G8CG0LR/p1512418244000100 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] vylc commented on issue #4981: Make time filter more usable
vylc commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391450331 Looks great! (1) I like the organization that @elibrumbaugh suggested. Can we name the tab "Relative" vs. Defaults. Custom is good. (2) Re: the inclusive/exclusive that @michellethomas brought up, I think that belongs in an info hover as opposed to trying to name the fields accordingly (3) Ok/Cancel are good. @GabeLoins do you want to adopt this as well for your metric popover (vs. Save/Close)? For consistency, I'd also move your buttons to the lower right since that's more natural than over to the lower left. Cancel (no color) should be to the left of OK (teal superset color) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley opened a new pull request #5062: [markup] Enable allow-forms
john-bodley opened a new pull request #5062: [markup] Enable allow-forms URL: https://github.com/apache/incubator-superset/pull/5062 This PR fixes an issue where a dashboard contained a markup slice with links to other dashboards, and when one tried to either export or explore a slice on the referenced dashboard the following error occurred: ``` Blocked form submission to because the form's frame is sandboxed and the 'allow-forms' permission is not set. ``` The solution is simply to enable the `allow-forms` permission in the markup iframe component. Note given the complexity of the issue, I'm unsure whether one could write a unit test for this scenario, though I was able to validate the fix in my local environment. to: @graceguo-supercat @michellethomas @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters
john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters URL: https://github.com/apache/incubator-superset/pull/5056#discussion_r190356316 ## File path: superset/viz.py ## @@ -235,7 +235,11 @@ def query_obj(self): groupby.remove(DTTM_ALIAS) is_timeseries = True -# Add extra filters into the query form data +# extras are used to query elements specific to a datasource type +# for instance the extra where clause that applies only to Tables + Review comment: Nit. Remove blank line. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters
john-bodley commented on a change in pull request #5056: [Adhoc Filters] integrating dashboard filters with adhoc filters URL: https://github.com/apache/incubator-superset/pull/5056#discussion_r190356344 ## File path: superset/viz.py ## @@ -235,7 +235,11 @@ def query_obj(self): groupby.remove(DTTM_ALIAS) is_timeseries = True -# Add extra filters into the query form data +# extras are used to query elements specific to a datasource type +# for instance the extra where clause that applies only to Tables + +utils.split_adhoc_filters_into_base_filters(form_data) + Review comment: Nit. Remove blank line. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley closed pull request #5060: [get_df] Adding support for multi-statement SQL
john-bodley closed pull request #5060: [get_df] Adding support for
multi-statement SQL
URL: https://github.com/apache/incubator-superset/pull/5060
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/models/core.py b/superset/models/core.py
index 8448c7ba54..e36c717299 100644
--- a/superset/models/core.py
+++ b/superset/models/core.py
@@ -690,9 +690,13 @@ def get_quoter(self):
return self.get_dialect().identifier_preparer.quote
def get_df(self, sql, schema):
-sql = sql.strip().strip(';')
+sqls = [x.strip() for x in sql.strip().strip(';').split(';')]
eng = self.get_sqla_engine(schema=schema)
-df = pd.read_sql_query(sql, eng)
+
+for i in range(len(sqls) - 1):
+eng.execute(sqls[i])
+
+df = pd.read_sql_query(sqls[-1], eng)
def needs_conversion(df_series):
if df_series.empty:
diff --git a/tests/model_tests.py b/tests/model_tests.py
index 8af104f57c..45ee61edd6 100644
--- a/tests/model_tests.py
+++ b/tests/model_tests.py
@@ -106,6 +106,20 @@ def test_grains_dict(self):
self.assertEquals(d.get('P1D').function, 'DATE({col})')
self.assertEquals(d.get('Time Column').function, '{col}')
+def test_single_statement(self):
+main_db = self.get_main_database(db.session)
+
+if main_db.backend == 'mysql':
+df = main_db.get_df('SELECT 1', None)
+self.assertEquals(df.iat[0, 0], 1)
+
+def test_multi_statement(self):
+main_db = self.get_main_database(db.session)
+
+if main_db.backend == 'mysql':
+df = main_db.get_df('USE superset; SELECT 1', None)
+self.assertEquals(df.iat[0, 0], 1)
+
class SqlaTableModelTestCase(SupersetTestCase):
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] betodealmeida commented on issue #4981: Make time filter more usable
betodealmeida commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391093955 Yeah, I'm unsure about the naming. Maybe we could use "simple" and "custom", like the filters? @michellethomas, how are they different? Is one of them inclusive and the other exclusive? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas opened a new pull request #5055: Fixing tooltip displaying metrics in heatmap
michellethomas opened a new pull request #5055: Fixing tooltip displaying metrics in heatmap URL: https://github.com/apache/incubator-superset/pull/5055 Heatmap was showing `[object, object]` instead of metric name for adhoc metrics because it needed the metric label. @GabeLoins @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] GabeLoins commented on issue #5055: Fixing tooltip displaying metrics in heatmap
GabeLoins commented on issue #5055: Fixing tooltip displaying metrics in heatmap URL: https://github.com/apache/incubator-superset/pull/5055#issuecomment-391096242 LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch closed issue #5061: Support Multi charts
mistercrunch closed issue #5061: Support Multi charts URL: https://github.com/apache/incubator-superset/issues/5061 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5054: Security vulnerability for 0.25.0
mistercrunch commented on issue #5054: Security vulnerability for 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5054#issuecomment-391428932 On my environment the gamma user gets redirected to the welcome page. Have you run `superset init` since upgrade? The provided roles are updated/synced when running `supreset init`, perhaps `Gamma` role was altered at some point, or perhaps that endpoint wasn't secured at the last time you ran `superset init` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] ujhujuh opened a new issue #1768: I want to add some chart style, such as linePlusBarChart, multiBarHorizontalChart, multiChart
ujhujuh opened a new issue #1768: I want to add some chart style, such as linePlusBarChart, multiBarHorizontalChart, multiChart URL: https://github.com/apache/incubator-superset/issues/1768 Make sure these boxes are checked before submitting your issue - thank you! - [yes ] I have checked the superset logs for python stacktraces and included it here as text if any - [yes ] I have reproduced the issue with at least the latest released version of superset - [yes] I have checked the issue tracker for the same issue and I haven't found one similar In our project , we enhance the viz that add some chart style : linePlusBarChart, multiBarHorizontalChart, multiChart. we can get the chart like that:    ### Superset version 0.14.1 ### Expected results 1.linePlusBarChart 2. multiBarHorizontalChart, 3.multiChart. ### Actual results fine ### Steps to reproduce New feature. later, I will submit the code, ,if you think my code is okay, could you please merge pull reqiest? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5061: Support Multi charts
mistercrunch commented on issue #5061: Support Multi charts URL: https://github.com/apache/incubator-superset/issues/5061#issuecomment-391429655 Reopened the original issue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState
mistercrunch commented on a change in pull request #5057: Translate string to
array for multi fields in getControlsState
URL:
https://github.com/apache/incubator-superset/pull/5057#discussion_r190332713
##
File path: superset/assets/src/explore/store.js
##
@@ -56,6 +56,10 @@ export function getControlsState(state, form_data) {
delete control.mapStateToProps;
}
+if (control.multi && typeof formData[k] === 'string') {
Review comment:
Would `!Array.isArray(formData[k])` be better?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5048: [bugfix] Render to section by override value
mistercrunch commented on issue #5048: [bugfix] Render to section by override value URL: https://github.com/apache/incubator-superset/pull/5048#issuecomment-391432296 Why closing? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] aok1425 commented on issue #5058: Add option for 24h dashboard refresh frequency
aok1425 commented on issue #5058: Add option for 24h dashboard refresh frequency URL: https://github.com/apache/incubator-superset/issues/5058#issuecomment-391438223 Amazing! I will do that--thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5054: Security vulnerability for 0.25.0
mistercrunch commented on issue #5054: Security vulnerability for 0.25.0 URL: https://github.com/apache/incubator-superset/issues/5054#issuecomment-391428932 Have you run `superset init` since upgrade? The provided roles are updated/synced when running `supreset init`, perhaps `Gamma` role was altered at some point, or perhaps that endpoint wasn't secured at the last time you ran `superset init` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5053: Database Permission for version 0.25.0
mistercrunch commented on issue #5053: Database Permission for version 0.25.0
URL:
https://github.com/apache/incubator-superset/issues/5053#issuecomment-391431982
What's keeping you from granting database access? Is the perm missing? it
should show as `database access on [{dbname}].(id:{id})` or something like
close to that. `superset init` may create missing perms if that's the case,
though the perm should have been created as the db got created.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas commented on issue #4981: Make time filter more usable
michellethomas commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391081201 For `Start/End` it would be nice to have the language make it clear if the range will be inclusive or exclusive. Druid and sqlalchemy data sources do not filter on the date ranges as both inclusive, and it can be especially confusing when looking at sums over a range (like in big number or table viz). It could be nice if druid/sqlalchemy were consistent, but changing it now would make existing slices incorrect (as people have adjusted to this difference). When we move to using druid sql, this will be consistent. I'll try to look around more for specific suggestions. Maybe something like `Starting after` and `Up to`? It's a little verbose though. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] sbarlock commented on issue #5003: Date formating lost when selecting MAX(date)
sbarlock commented on issue #5003: Date formating lost when selecting MAX(date) URL: https://github.com/apache/incubator-superset/issues/5003#issuecomment-391070630 @mistercrunch Thanks. So is there a way to display to a user, e.g. the last date a report was submitted? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] GabeLoins commented on a change in pull request #4981: Make time filter more usable
GabeLoins commented on a change in pull request #4981: Make time filter more
usable
URL:
https://github.com/apache/incubator-superset/pull/4981#discussion_r189983720
##
File path:
superset/assets/src/explore/components/controls/DateFilterControl.jsx
##
@@ -28,172 +51,265 @@ const propTypes = {
const defaultProps = {
animation: true,
onChange: () => {},
- value: '',
+ value: 'Last week',
};
+
export default class DateFilterControl extends React.Component {
constructor(props) {
super(props);
-const value = props.value || '';
+const value = props.value || defaultProps.value;
Review comment:
PropTypes (if the field is required) will prevent against null being passed
in- I'd say drop the `|| defaultProps.value`.
If the field can't be required, I'd still say its not needed- controls
across explore take in the value prop at face value and don't do this check.
For it to create a problem someone would have to start setting value as `null`
in a higher level explore component which I think would be a bigger issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState
michellethomas commented on a change in pull request #5057: Translate string to
array for multi fields in getControlsState
URL:
https://github.com/apache/incubator-superset/pull/5057#discussion_r190359546
##
File path: superset/assets/src/explore/store.js
##
@@ -56,6 +56,10 @@ export function getControlsState(state, form_data) {
delete control.mapStateToProps;
}
+if (control.multi && typeof formData[k] === 'string') {
Review comment:
I think we'd want to stick with `typeof formData[k] === 'string'` because
formData[k] might be undefined or null and we would want to leave it as null.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #5057: Translate string to array for multi fields in getControlsState
mistercrunch commented on a change in pull request #5057: Translate string to
array for multi fields in getControlsState
URL:
https://github.com/apache/incubator-superset/pull/5057#discussion_r190360447
##
File path: superset/assets/src/explore/store.js
##
@@ -56,6 +56,10 @@ export function getControlsState(state, form_data) {
delete control.mapStateToProps;
}
+if (control.multi && typeof formData[k] === 'string') {
Review comment:
Though I think it can be a `int` / `float` too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5062: [markup] Enable allow-forms
codecov-io commented on issue #5062: [markup] Enable allow-forms URL: https://github.com/apache/incubator-superset/pull/5062#issuecomment-391457330 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=h1) Report > Merging [#5062](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4c44223234b1533660e9faa14a3de57e955b89ef?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5062 +/- ## === Coverage 77.52% 77.52% === Files 44 44 Lines8707 8707 === Hits 6750 6750 Misses 1957 1957 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=footer). Last update [4c44223...60c3ccc](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5062: [markup] Enable allow-forms
codecov-io commented on issue #5062: [markup] Enable allow-forms URL: https://github.com/apache/incubator-superset/pull/5062#issuecomment-391457330 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=h1) Report > Merging [#5062](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4c44223234b1533660e9faa14a3de57e955b89ef?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5062 +/- ## === Coverage 77.52% 77.52% === Files 44 44 Lines8707 8707 === Hits 6750 6750 Misses 1957 1957 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=footer). Last update [4c44223...60c3ccc](https://codecov.io/gh/apache/incubator-superset/pull/5062?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] betodealmeida commented on issue #4981: Make time filter more usable
betodealmeida commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391458918 > (1) I like the organization that @elibrumbaugh suggested. Can we name the tab "Relative" vs. Defaults. Custom is good. @vylc, "relative" is not a good name for the first tab because the second one can also be relative, eg, you could have "last Sunday" as the start and "today" as the end time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit
codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#issuecomment-389737583 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=h1) Report > Merging [#5023](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5505c116ba9cf75f36fffdf562c6ebe8c11e436f?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `86.95%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5023 +/- ## == + Coverage 77.34% 77.35% +0.01% == Files 44 44 Lines8668 8688 +20 == + Hits 6704 6721 +17 - Misses 1964 1967 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.64% <ø> (ø)` | :arrow_up: | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `75.67% <100%> (+0.4%)` | :arrow_up: | | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.74% <100%> (ø)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.7% <82.35%> (-0.2%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=footer). Last update [5505c11...d7eb638](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #4834: Load async sql lab results early for Presto
timifasubaa commented on issue #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#issuecomment-390372158 The current approach incorporates feedback from the 1. It abandons the presto specific logic and uses fetchmany to get the prefetched results early and expands to any database that can fetchmany. 2. it writes the full data to the same bucket where the preloaded data was written before. This simplifies the logic. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #4834: Load async sql lab results early for Presto
timifasubaa commented on issue #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#issuecomment-390372158 The current approach incorporates the various feedback I have received on this PR. 1. It abandons the presto specific logic and uses fetchmany to get the prefetched results early and expands to any database that can fetchmany. 2. it writes the full data to the same bucket where the preloaded data was written before. This simplifies the logic. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict'
gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict' URL: https://github.com/apache/incubator-superset/issues/4984#issuecomment-390583363 > Did your original query work when doing heatmaps? I have a table which has row and column and a value at that row and column (all ints) and when I do X=row, Y=col, metric=value, I get unhashable dict error just as above. If this is unrelated, I can open another issue but it is basically the exact same but for histogram charts. which version? Can you paste a screen shot of this chart This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-390051454 Agree with raising early. Done that. I agree with the cascading idea of forcing users to delete all other dependent slices before deleting the slice but I'll push it to a future PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas commented on issue #4897: Heatmap improvements
michellethomas commented on issue #4897: Heatmap improvements URL: https://github.com/apache/incubator-superset/pull/4897#issuecomment-390059989 hey @mistercrunch it looks like this causes an issue with heatmaps that use `Value Bounds` with normalized turned off. The legend seems to respect the value bounds but the color doesn't change appropriately. It also looks like without the value bounds the legend is always showing the normalized 0-1 range. I can take a screenshot if the description is not clear. I'm testing on internal data so I'd just need to load test data. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit
timifasubaa commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189134922
##
File path: superset/utils.py
##
@@ -841,3 +841,17 @@ def ensure_path_exists(path):
except OSError as exc:
if not (os.path.isdir(path) and exc.errno == errno.EEXIST):
raise
+
+
+def get_limit_from_sql(sql):
+sql = sql.lower()
+limit = None
+tokens = sql.split()
+try:
+if 'limit' in tokens:
+limit_pos = tokens.index('limit') + 1
Review comment:
Ah, true. I hadn't thought of the subquery case. But split can handle the
tabs and newlines just fine. I'll go ahead to reuse your regex approach as that
is more robust.
And your suggestion of adding the logic within the checking function makes
sense.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley commented on a change in pull request #5019: fix missing datasource error message
john-bodley commented on a change in pull request #5019: fix missing datasource
error message
URL:
https://github.com/apache/incubator-superset/pull/5019#discussion_r189138119
##
File path: superset/views/core.py
##
@@ -1229,6 +1229,12 @@ def datasource_info(datasource_id, datasource_type,
form_data):
datasource = form_data.get('datasource', '')
if '__' in datasource:
datasource_id, datasource_type = datasource.split('__')
+# The case where the datasource has been deleted
+datasource_id = None if datasource_id == 'None' else datasource_id
+
+if not datasource_id:
Review comment:
Why not simply,
```
if datasource_id == 'None':
...
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5019: fix missing datasource error message
codecov-io commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389645443 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=h1) Report > Merging [#5019](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a64b3f57747d7b9328d4a5f84afe8f7b21b069b?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5019 +/- ## == - Coverage 77.34% 77.34% -0.01% == Files 44 44 Lines8665 8668 +3 == + Hits 6702 6704 +2 - Misses 1963 1964 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5019/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.64% <66.66%> (-0.02%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=footer). Last update [5a64b3f...f52f7aa](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands
GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032 Previously to this PR, when adding/viewing a simple filter with number of comparators this could happen:  That doesn't look so great and also makes it quite annoying to make any changes because you are forced to manually expand the box to hit save. In this PR I have the popover expand in reaction when the input field expands.  test plan: - ran the example shown in the above gif - ran the spec reviewers: @michellethomas @john-bodley @williaster @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
john-bodley commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-390869422 @mistercrunch what are your thoughts about having metrics reference other metrics, or should metric expressions be valid SQL? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] zhaoyongjie commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric
zhaoyongjie commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric URL: https://github.com/apache/incubator-superset/issues/5045#issuecomment-390564358 @zhangjian0111 which visualization type do you choice? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] miloradkrstevski closed issue #5036: Which db is best with Superset 0.24 and later (0.25+)?
miloradkrstevski closed issue #5036: Which db is best with Superset 0.24 and later (0.25+)? URL: https://github.com/apache/incubator-superset/issues/5036 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #4819: Visualization for multiple line charts
codecov-io commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-383682187 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=h1) Report > Merging [#4819](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ce0011e5fcacf8510142353df6c3cf530c04b1c2?src=pr=desc) will **increase** coverage by `0.06%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4819 +/- ## == + Coverage 77.35% 77.41% +0.06% == Files 44 44 Lines8677 8701 +24 == + Hits 6712 6736 +24 Misses 1965 1965 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4819/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.7% <100%> (+0.18%)` | :arrow_up: | | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/4819/diff?src=pr=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `44.69% <100%> (+0.62%)` | :arrow_up: | | [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4819/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=footer). Last update [ce0011e...513ef9c](https://codecov.io/gh/apache/incubator-superset/pull/4819?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] graceguo-supercat opened a new pull request #5051: [Dashboard] Allow Superset Alpha, Gamma users to save dashboard as a copy
graceguo-supercat opened a new pull request #5051: [Dashboard] Allow Superset Alpha, Gamma users to save dashboard as a copy URL: https://github.com/apache/incubator-superset/pull/5051 fix issue caused by #4900. @jasnovak @timifasubaa @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on issue #5038: [Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown
williaster commented on issue #5038: [Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown URL: https://github.com/apache/incubator-superset/pull/5038#issuecomment-390811715 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster closed pull request #5038: [Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown
williaster closed pull request #5038: [Explore] [Adhoc Metrics/Filters] Force
Ace editor to refresh when it is shown
URL: https://github.com/apache/incubator-superset/pull/5038
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/superset/assets/src/explore/components/AdhocFilterEditPopoverSqlTabContent.jsx
b/superset/assets/src/explore/components/AdhocFilterEditPopoverSqlTabContent.jsx
index 8a3a97bd82..7e8a6a6a39 100644
---
a/superset/assets/src/explore/components/AdhocFilterEditPopoverSqlTabContent.jsx
+++
b/superset/assets/src/explore/components/AdhocFilterEditPopoverSqlTabContent.jsx
@@ -33,6 +33,7 @@ export default class AdhocFilterEditPopoverSqlTabContent
extends React.Component
super(props);
this.onSqlExpressionChange = this.onSqlExpressionChange.bind(this);
this.onSqlExpressionClauseChange =
this.onSqlExpressionClauseChange.bind(this);
+this.handleAceEditorRef = this.handleAceEditorRef.bind(this);
this.selectProps = {
multi: false,
@@ -59,6 +60,10 @@ export default class AdhocFilterEditPopoverSqlTabContent
extends React.Component
}
}
+ componentDidUpdate() {
+this.aceEditorRef.editor.resize();
+ }
+
onSqlExpressionClauseChange(clause) {
this.props.onChange(this.props.adhocFilter.duplicateWith({
clause: clause && clause.clause,
@@ -73,6 +78,12 @@ export default class AdhocFilterEditPopoverSqlTabContent
extends React.Component
}));
}
+ handleAceEditorRef(ref) {
+if (ref) {
+ this.aceEditorRef = ref;
+}
+ }
+
render() {
const { adhocFilter, height } = this.props;
@@ -101,6 +112,7 @@ export default class AdhocFilterEditPopoverSqlTabContent
extends React.Component
this.aceEditorRef.editor.resize(), 0);
+ }
+
render() {
const {
adhocMetric: propsAdhocMetric,
@@ -200,6 +212,8 @@ export default class AdhocMetricEditPopover extends
React.Component {
defaultActiveKey={adhocMetric.expressionType}
className="adhoc-metric-edit-tabs"
style={{ height: this.state.height, width: this.state.width }}
+ onSelect={this.refreshAceEditor}
+ animation={false}
>
@@ -216,6 +230,7 @@ export default class AdhocMetricEditPopover extends
React.Component {
[GitHub] codecov-io commented on issue #5051: [Dashboard] Allow Superset Alpha, Gamma users to save dashboard as a copy
codecov-io commented on issue #5051: [Dashboard] Allow Superset Alpha, Gamma users to save dashboard as a copy URL: https://github.com/apache/incubator-superset/pull/5051#issuecomment-390827213 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5051?src=pr=h1) Report > Merging [#5051](https://codecov.io/gh/apache/incubator-superset/pull/5051?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a746fce383390cda5ea48094c94d80aa92b7d7bb?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5051?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5051 +/- ## === Coverage 77.35% 77.35% === Files 44 44 Lines8677 8677 === Hits 6712 6712 Misses 1965 1965 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5051?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5051/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.64% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5051?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5051?src=pr=footer). Last update [a746fce...1b6f7dc](https://codecov.io/gh/apache/incubator-superset/pull/5051?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] qin4zhang commented on issue #4398: database_access on [mydb] permissionview not created when database added
qin4zhang commented on issue #4398: database_access on [mydb] permissionview not created when database added URL: https://github.com/apache/incubator-superset/issues/4398#issuecomment-390910303 Resolved? Which version? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] qin4zhang opened a new issue #5149: [Session] How to set session timeout?
qin4zhang opened a new issue #5149: [Session] How to set session timeout? URL: https://github.com/apache/incubator-superset/issues/5149 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.25.5 ### Expected results I could set session timeout in config.py, and when the time is out , user should login again. ### Actual results I don't know how to set it ### Steps to reproduce What's your advice? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] xrmx commented on issue #5148: Portuguese Translation Doesn't Translate Everything
xrmx commented on issue #5148: Portuguese Translation Doesn't Translate Everything URL: https://github.com/apache/incubator-superset/issues/5148#issuecomment-395046659 Please reproduce with 0.25 or master This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] claycrosby opened a new issue #5148: Portuguese Translation Doesn't Translate Everything
claycrosby opened a new issue #5148: Portuguese Translation Doesn't Translate Everything URL: https://github.com/apache/incubator-superset/issues/5148 ### Superset version 0.24.0 ### Expected results All tabs, non-data words (e.g. "since" and "until," month names) are translated to Portuguese ### Actual results Only the Security tab is translated  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] nukeu666 opened a new issue #5145: Can see all datasources while making charts
nukeu666 opened a new issue #5145: Can see all datasources while making charts URL: https://github.com/apache/incubator-superset/issues/5145 Make sure these boxes are checked before submitting your issue - thank you! - [-] I have checked the superset logs for python stacktraces and included it here as text if any - [x] I have reproduced the issue with at least the latest released version of superset - [x] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.25 When I goto charts and create a new chart. I can see all datasources http://localhost/slicemodelview/add ### Expected results I should only be able to see datasources that I have been access to Being able to see all datasources is a security issue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] MAliNaqvi opened a new issue #5147: Change iframe result based on selection in the filterbox
MAliNaqvi opened a new issue #5147: Change iframe result based on selection in the filterbox URL: https://github.com/apache/incubator-superset/issues/5147 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for python stacktraces and included it here as text if any - [x ] I have reproduced the issue with at least the latest released version of superset - [x ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.24 ### Expected results The logo should change with the filterbox ### Actual results The logo doesn't change ### Steps to reproduce I want to update an iframe, based on the selection in the filterbox like so: https://www.dropbox.com/s/904llkwhxi0h17q/Screenshot%202018-05-29%2019.11.09.png?dl=0  The iframe chart only has the option of having a url like so https://www.dropbox.com/s/p9pjtfvuyn9wi6l/Screenshot%202018-05-29%2019.09.54.png?dl=0  How can I get the selection in the filterbox and use it to update the url in the iframe? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] k-hashimoto opened a new issue #5146: Configure to use Google BigQuery
k-hashimoto opened a new issue #5146: Configure to use Google BigQuery
URL: https://github.com/apache/incubator-superset/issues/5146
Make sure these boxes are checked before submitting your issue - thank you!
- [x ] I have checked the superset logs for python stacktraces and included
it here as text if any
- [ x] I have reproduced the issue with at least the latest released version
of superset
- [x ] I have checked the issue tracker for the same issue and I haven't
found one similar
### Superset version
"version": "0.25.5"
### Expected results
Can connect to bigquery on "Test Connection" in SQLAlchemy URI.
### Actual results
ERROR: {"error": "Connection failed!\n\nThe error message returned
was:\nCan't load plugin: sqlalchemy.dialects:bigquery"}
### Steps to reproduce
docker run -d -p 8088:8088 amancevice/superset
docker exec -it CONTAINER ID bash
(on running container) pip3 install pybigquery
docker exec -it CONTAINER ID superset-init
After that, access to locahost:8088 and login, move to "Sources -> Database
-> Add a new record"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] hughhhh commented on issue #5152: Use Rison for the explore URL
hug commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396019222 @betodealmeida thank you blessing us with this. CC.geoviz definitely needs it :P This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch closed pull request #4193: Init docker for local development environment.
mistercrunch closed pull request #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index df3cb8bd3c..11929a9b7e 100644 --- a/.gitignore +++ b/.gitignore @@ -41,3 +41,10 @@ superset/assets/version_info.json *.iml venv @eaDir/ + +# docker +/Dockerfile +/docker-build.sh +/docker-compose.yml +/docker-entrypoint.sh +/docker-init.sh diff --git a/contrib/docker/Dockerfile b/contrib/docker/Dockerfile new file mode 100644 index 00..3d474864f7 --- /dev/null +++ b/contrib/docker/Dockerfile @@ -0,0 +1,60 @@ +FROM python:3.6 + +MAINTAINER Xiao Hanyu + +# Add a normal user +RUN useradd --user-group --create-home --shell /bin/bash work + +# Configure environment +ENV LANG=C.UTF-8 \ +LC_ALL=C.UTF-8 \ +HOME=/home/work + +RUN apt-get update -y + +# Install some dependencies +# http://airbnb.io/superset/installation.html#os-dependencies +RUN apt-get update -y && apt-get install -y build-essential libssl-dev \ +libffi-dev python3-dev libsasl2-dev libldap2-dev + +RUN apt-get install -y vim less postgresql-client redis-tools + +# Install nodejs for custom build +# https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#making-your-own-build +# https://nodejs.org/en/download/package-manager/ +RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - +RUN apt-get install -y nodejs +RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -; \ +echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list; \ +apt-get update; \ +apt-get install -y yarn + +RUN mkdir $HOME/incubator-superset + +WORKDIR $HOME/incubator-superset + +COPY ./ ./ + +RUN pip install --upgrade setuptools pip +RUN pip install -e . && pip install -r requirements-dev.txt + +ENV PATH=/home/work/incubator-superset/superset/bin:$PATH \ +PYTHONPATH=./superset/:$PYTHONPATH + +COPY docker-entrypoint.sh /usr/local/bin/ +RUN chmod +x /usr/local/bin/docker-entrypoint.sh +RUN ln -s usr/local/bin/docker-entrypoint.sh /entrypoint.sh # backwards compat + +COPY ./superset ./superset +RUN chown -R work:work $HOME + +USER work + +RUN cd superset/assets && yarn +RUN cd superset/assets && npm run build + +HEALTHCHECK CMD ["curl", "-f", "http://localhost:8088/health;] + +ENTRYPOINT ["docker-entrypoint.sh"] + +EXPOSE 8088 diff --git a/contrib/docker/docker-build.sh b/contrib/docker/docker-build.sh new file mode 100644 index 00..55f73274d6 --- /dev/null +++ b/contrib/docker/docker-build.sh @@ -0,0 +1,5 @@ +#!/usr/bin/env bash + +set -ex + +docker build -t apache/incubator-superset -f Dockerfile . diff --git a/contrib/docker/docker-compose.yml b/contrib/docker/docker-compose.yml new file mode 100644 index 00..9085793c10 --- /dev/null +++ b/contrib/docker/docker-compose.yml @@ -0,0 +1,48 @@ +version: '3' +services: + redis: +image: redis:3.2 +restart: always +ports: + - 6379:6379 +volumes: + - redis:/data + postgres: +image: postgres:10 +restart: always +environment: + POSTGRES_DB: superset + POSTGRES_PASSWORD: superset + POSTGRES_USER: superset +ports: + - 5432:5432 +volumes: + - postgres:/var/lib/postgresql/data + superset: +image: apache/incubator-superset +restart: always +environment: + POSTGRES_DB: superset + POSTGRES_USER: superset + POSTGRES_PASSWORD: superset + POSTGRES_HOST: postgres + POSTGRES_PORT: 5432 + REDIS_HOST: redis + REDIS_PORT: 6379 + SUPERSET_ENV: local +ports: + - 8088:8088 +command: "tail -f /dev/null" +depends_on: + - postgres + - redis +volumes: + - .:/home/work/incubator-superset + - superset-node-modules:/home/work/incubator-superset/superset/assets/node_modules +volumes: + postgres: +external: false + redis: +external: false + superset-node-modules: +external: false diff --git a/contrib/docker/docker-entrypoint.sh b/contrib/docker/docker-entrypoint.sh new file mode 100644 index 00..c6629c7b70 --- /dev/null +++ b/contrib/docker/docker-entrypoint.sh @@ -0,0 +1,12 @@ +#!/bin/bash +set -ex + +if [ "$#" -ne 0 ]; then +exec "$@" +elif [ "$SUPERSET_ENV" = "local" ]; then +superset runserver -d +elif [ "$SUPERSET_ENV" = "production" ]; then +superset runserver -a 0.0.0.0 -w $((2 * $(getconf _NPROCESSORS_ONLN) + 1)) +else +superset --help +fi diff --git a/contrib/docker/docker-init.sh b/contrib/docker/docker-init.sh new file mode 100644 index 00..940ad4fa34 --- /dev/null +++ b/contrib/docker/docker-init.sh @@ -0,0 +1,24 @@ +#!/usr/bin/env bash + +set -ex +
[GitHub] mistercrunch commented on issue #4193: Init docker for local development environment.
mistercrunch commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-396019586  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] xiaohanyu commented on issue #4193: Init docker for local development environment.
xiaohanyu commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-396018556 CI passed after two more commits! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396019487 Only thing is this may have some intricacies that are hard to predict (maybe around `null`, `NaN`, `infinity` handling). The assumption that this is a drop-in replacement may not be 100% right, but there's no way to know for sure but to test it extensively in a production-like env. Tagging some of the Airbnb folks to make sure that they are on board and giving a heads up on this new URL format. @graceguo-supercat @williaster @michellethomas @john-bodley This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #4193: Init docker for local development environment.
codecov-io commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-396017411 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=h1) Report > Merging [#4193](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7d1c035658919473c251bef857f59d8df96fe3d4?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4193 +/- ## === Coverage 77.46% 77.46% === Files 44 44 Lines8729 8729 === Hits 6762 6762 Misses 1967 1967 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=footer). Last update [7d1c035...de876b5](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #4193: Init docker for local development environment.
codecov-io commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-396017411 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=h1) Report > Merging [#4193](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7d1c035658919473c251bef857f59d8df96fe3d4?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4193 +/- ## === Coverage 77.46% 77.46% === Files 44 44 Lines8729 8729 === Hits 6762 6762 Misses 1967 1967 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=footer). Last update [7d1c035...de876b5](https://codecov.io/gh/apache/incubator-superset/pull/4193?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL
mistercrunch commented on issue #5152: Use Rison for the explore URL
URL:
https://github.com/apache/incubator-superset/pull/5152#issuecomment-396019388
This LGTM. It could be good to add an entry in the FAQ ("How are the URL
formatted?"), or mentioning Rison somewhere else in the docs.
We should also do this in the dashboard app for consistency (doesn't have to
be this PR)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] rajivchodisetti commented on issue #4931: date/datetime/timestamp using unix timestamp in Table-viz
rajivchodisetti commented on issue #4931: date/datetime/timestamp using unix timestamp in Table-viz URL: https://github.com/apache/incubator-superset/issues/4931#issuecomment-395971867 I am also facing this issue, I have installed super-set just a day back This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley commented on issue #5143: strip druid metric type when value is postagg
john-bodley commented on issue #5143: strip druid metric type when value is postagg URL: https://github.com/apache/incubator-superset/pull/5143#issuecomment-395976435 I agree with @mistercrunch, we should ensure that all inputs are stripped of leading and trailing whitespace when saving the form data. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley commented on a change in pull request #5119: [sqllab] allow gamma users to access their SQLLab views
john-bodley commented on a change in pull request #5119: [sqllab] allow gamma users to access their SQLLab views URL: https://github.com/apache/incubator-superset/pull/5119#discussion_r194230629 ## File path: superset/security.py ## @@ -130,8 +131,13 @@ def datasource_access_by_name( datasources = ConnectorRegistry.query_datasources_by_name( db.session, database, datasource_name, schema=schema) +print(datasources) Review comment: Nit. Remove print statements. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch opened a new pull request #5176: Introduce class attr BaseViz.enforce_numerical_metrics
mistercrunch opened a new pull request #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #4726: [bugfix] convert metrics to numeric in dataframe
mistercrunch commented on a change in pull request #4726: [bugfix] convert
metrics to numeric in dataframe
URL:
https://github.com/apache/incubator-superset/pull/4726#discussion_r194572936
##
File path: superset/viz.py
##
@@ -170,11 +170,21 @@ def get_df(self, query_obj=None):
if self.datasource.offset:
df[DTTM_ALIAS] += timedelta(hours=self.datasource.offset)
df[DTTM_ALIAS] += self.time_shift
+
+self.df_metrics_to_num(df, query_obj.get('metrics') or [])
+
df.replace([np.inf, -np.inf], np.nan)
fillna = self.get_fillna_for_columns(df.columns)
df = df.fillna(fillna)
return df
+@staticmethod
+def df_metrics_to_num(df, metrics):
+"""Converting metrics to numeric when pandas.read_sql cannot"""
+for col, dtype in df.dtypes.items():
+if dtype.type == np.object_ and col in metrics:
+df[col] = pd.to_numeric(df[col])
Review comment:
@michellethomas what do you think of
https://github.com/apache/incubator-superset/pull/5176 ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics
codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176#issuecomment-396417232 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=h1) Report > Merging [#5176](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3477abf7eb8fdba22e59c3d9fa68b90511a8d4c?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5176 +/- ## == + Coverage 77.46% 77.47% +<.01% == Files 44 44 Lines8729 8732 +3 == + Hits 6762 6765 +3 Misses 1967 1967 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5176/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.33% <100%> (+0.03%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=footer). Last update [a3477ab...c3501b2](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics
codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176#issuecomment-396417232 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=h1) Report > Merging [#5176](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3477abf7eb8fdba22e59c3d9fa68b90511a8d4c?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5176 +/- ## == + Coverage 77.46% 77.47% +<.01% == Files 44 44 Lines8729 8732 +3 == + Hits 6762 6765 +3 Misses 1967 1967 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5176/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.33% <100%> (+0.03%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=footer). Last update [a3477ab...c3501b2](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics
codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176#issuecomment-396417232 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=h1) Report > Merging [#5176](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3477abf7eb8fdba22e59c3d9fa68b90511a8d4c?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5176 +/- ## == + Coverage 77.46% 77.47% +<.01% == Files 44 44 Lines8729 8732 +3 == + Hits 6762 6765 +3 Misses 1967 1967 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5176/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.33% <100%> (+0.03%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=footer). Last update [a3477ab...c3501b2](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] kirankumarpv commented on issue #3690: URL Prefix Superset Flask
kirankumarpv commented on issue #3690: URL Prefix Superset Flask URL: https://github.com/apache/incubator-superset/issues/3690#issuecomment-396435448 Hi, I am also having the same issue. I tried to fix it using Blurprints but superset doesn't seem to take into consideration blueprints with url_prefix. The main reason the need for me is I am trying to deploy superset on AWS Lambda on a serverless environment and since AWS API Gateway adds a stage name like '/dev' all the links are broken. I am able to get to the login page but most of them doesn't work because it seems it's trying to access resources at "/" but API Gateway puts all of them at "/dev". Any other way or do we need to modify all the static URL's? Can you help me to see if someone can get Blueprints working on superset with url_prefix option? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] lynch0227 commented on issue #5169: How to disable preview data feature?
lynch0227 commented on issue #5169: How to disable preview data feature? URL: https://github.com/apache/incubator-superset/issues/5169#issuecomment-396436689 OK, I got it. Thanks for your explanation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] lynch0227 closed issue #5169: How to disable preview data feature?
lynch0227 closed issue #5169: How to disable preview data feature? URL: https://github.com/apache/incubator-superset/issues/5169 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #5099: Dashboard level access control
mistercrunch commented on a change in pull request #5099: Dashboard level
access control
URL:
https://github.com/apache/incubator-superset/pull/5099#discussion_r194570629
##
File path:
superset/migrations/versions/76a4d742cf04_dashboard_role_many_to_many.py
##
@@ -0,0 +1,29 @@
+"""dashboard role many to many
+
+Revision ID: b21a4c518cab
+Revises: e866bd2d4976
+Create Date: 2018-03-08 16:30:36.924096
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = '76a4d742cf04'
+down_revision = '5ccf602336a0'
+
+from alembic import op
+import sqlalchemy as sa
+
+
+def upgrade():
+op.create_table('dashboard_role',
Review comment:
Hey so the model so far has been to *not* create these many-to-many tables,
and instead creating perms for each object (table, database, schema). This has
pros/cons, one of the pros being to have the security model limited to FAB's
RBAC tables. Meaning roles are only made out of users and perms. Then perms act
as imperfect FKs to the object table. Cons is the fact that the join is
imperfect as we want the perm object to be human readable, but contains the id.
I think I like the approach here, made possible by the fact that we now have
`SupersetSecurityManager` and can specify `rolemodelview`. I can see how we'd
move to do pattern for `Databases`, `DruidDatasource`, `SqlaTable` at some
point. I'm not sure what others may think about this approach.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396416232 @williaster the main driver is mostly readable, and maybe hackable urls. I really wish Rison was more popular / supported. Note that we could support it (@betodealmeida forked the repo and created a new Pypi entry) @betodealmeida if we want this feature we should cherry-pick it in our production and run it for a while and come back on this PR to comment on it saying something like "This has been extensively tested in our production for a long time and all is ok, and we are committed to maintain Prison in the long term" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster closed pull request #5055: Fixing tooltip displaying metrics in heatmap
williaster closed pull request #5055: Fixing tooltip displaying metrics in
heatmap
URL: https://github.com/apache/incubator-superset/pull/5055
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/src/visualizations/heatmap.js
b/superset/assets/src/visualizations/heatmap.js
index 7d471d5d80..c26291ffca 100644
--- a/superset/assets/src/visualizations/heatmap.js
+++ b/superset/assets/src/visualizations/heatmap.js
@@ -177,11 +177,12 @@ function heatmapVis(slice, payload) {
const k = d3.mouse(this);
const m = Math.floor(scale[0].invert(k[0]));
const n = Math.floor(scale[1].invert(k[1]));
+ const metric = typeof fd.metric === 'object' ? fd.metric.label :
fd.metric;
if (m in matrix && n in matrix[m]) {
const obj = matrix[m][n];
s += '' + fd.all_columns_x + ': ' + obj.x + '';
s += '' + fd.all_columns_y + ': ' + obj.y + '';
-s += '' + fd.metric + ': ' + valueFormatter(obj.v) +
'';
+s += '' + metric + ': ' + valueFormatter(obj.v) + '';
if (fd.show_perc) {
s += '%: ' + fp(fd.normalized ? obj.rank : obj.perc) +
'';
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #5122: Bump FAB and a bunch of JS libs
mistercrunch commented on a change in pull request #5122: Bump FAB and a bunch of JS libs URL: https://github.com/apache/incubator-superset/pull/5122#discussion_r194571227 ## File path: superset/assets/package.json ## @@ -150,13 +152,15 @@ "react-addons-test-utils": "^15.6.2", "react-test-renderer": "^15.6.2", "redux-mock-store": "^1.2.3", -"sinon": "^4.0.0", -"style-loader": "^0.18.2", +"//": "known minor issues in >5.0", Review comment: Got this as a suggested way to squeeze comments into JSON: https://stackoverflow.com/questions/14221579/how-do-i-add-comments-to-package-json-for-npm-install This works with `yarn` but not the current version `npm`. I'm pretty sure npm used to allow this but not 100%. On Slack I mentioned to @GabeLoins that this may be a good way to force people to use `yarn` as a result, since we now use `yarn.lock` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] betodealmeida opened a new pull request #5177: Time shift difference
betodealmeida opened a new pull request #5177: Time shift difference
URL: https://github.com/apache/incubator-superset/pull/5177
I added a new control to allow comparing comparing the main time series with
time shifts. In addition to showing the time shift as individual lines, it's
now possible to compute absolute and relative differences.
Current behavior, will be the default option in the selector ("individual
lines"):
https://user-images.githubusercontent.com/1534870/41261806-4c49bf02-6d92-11e8-80cd-2aa4d51e2b4b.png;>
Absolute difference:
https://user-images.githubusercontent.com/1534870/41261805-4c30cda8-6d92-11e8-9fbd-9325b2845e1d.png;>
Relative difference, computed as `(main - time_shift) / time_shift` (for a
"1 week" shift" this means that `100` means the value today is double the value
last week, and `-50` means that the value today is half of what it was last
week):
https://user-images.githubusercontent.com/1534870/41261804-4c1758f0-6d92-11e8-8c01-4bd91afe7ad2.png;>
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5174: Gantt Chart visualization
codecov-io commented on issue #5174: Gantt Chart visualization URL: https://github.com/apache/incubator-superset/pull/5174#issuecomment-396386176 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5174?src=pr=h1) Report > Merging [#5174](https://codecov.io/gh/apache/incubator-superset/pull/5174?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3477abf7eb8fdba22e59c3d9fa68b90511a8d4c?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `76.08%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5174?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5174 +/- ## == - Coverage 77.46% 77.45% -0.01% == Files 44 44 Lines8729 8775 +46 == + Hits 6762 6797 +35 - Misses 1967 1978 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5174?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5174/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: | | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/5174/diff?src=pr=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `45.3% <100%> (+0.61%)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5174/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `80.84% <50%> (-0.45%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5174?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5174?src=pr=footer). Last update [a3477ab...5446610](https://codecov.io/gh/apache/incubator-superset/pull/5174?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley opened a new pull request #5178: John bodley sql percent sign
john-bodley opened a new pull request #5178: John bodley sql percent sign
URL: https://github.com/apache/incubator-superset/pull/5178
This PR came about due to an error when exporting a SQL Lab result to CSV.
For example in Presto one can successfully run the following query:
```
SELECT '%'
```
which executes directly via the SQLAlchemy engine, however an error was
thrown when trying to export to CSV which uses the Pandas interface where as
`parameters` = `{}` which causes an exception in
[PyHive](https://github.com/dropbox/PyHive/blob/master/pyhive/presto.py#L172)
which uses the `pyformat` SQL
[parameterstyle](https://www.python.org/dev/peps/pep-0249/#paramstyle). In
essence,
```
SELECT '%' % {}
```
is invalid and thus one would need to escape the `%` character, i.e.,
```
SELECT '%%' % {}
```
The reason for the error is the Pandas SQL interface neglects engine
specific configuration of the DBAPI `execute` method. The fix is simply to
bypass the Pandas API for querying and mimic the logic that SQL Lab uses which
ensures that for presto `parameters` is `None` and thus it will not re-format
the string.
Note this PR also fixes the Hive and MySQL engine specs inline with their
API, i.e., both
[Hive](https://github.com/dropbox/PyHive/blob/master/pyhive/hive.py#L337) and
[MySQL](https://github.com/PyMySQL/mysqlclient-python/blob/master/MySQLdb/cursors.py#L204)
explicitly test whether the `parameters` and `args` respectively are `None`
(rather than doing a boolean check).
This means for MySQL in SQL Lab one can run queries of the form,
```
SELECT * FROM table WHERE column LIKE '%foo%'
```
as opposed to:
```
SELECT * FROM table WHERE column LIKE '%%foo%%'
```
since previously the MySQL engine spec defined `args` to `{}` causing the
string to be formatted with the empty dictionary args.
to: @betodealmeida @michellethomas @mistercrunch
cc: @graceguo-supercat @timifasubaa
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5177: Time shift difference
codecov-io commented on issue #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177#issuecomment-396419443 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=h1) Report > Merging [#5177](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3477abf7eb8fdba22e59c3d9fa68b90511a8d4c?src=pr=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5177 +/- ## == - Coverage 77.46% 77.41% -0.06% == Files 44 44 Lines8729 8736 +7 == + Hits 6762 6763 +1 - Misses 1967 1973 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5177/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `80.98% <33.33%> (-0.31%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=footer). Last update [a3477ab...a4c0dd4](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5177: Time shift difference
codecov-io commented on issue #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177#issuecomment-396419443 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=h1) Report > Merging [#5177](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a3477abf7eb8fdba22e59c3d9fa68b90511a8d4c?src=pr=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5177 +/- ## == - Coverage 77.46% 77.41% -0.06% == Files 44 44 Lines8729 8736 +7 == + Hits 6762 6763 +1 - Misses 1967 1973 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5177/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `80.98% <33.33%> (-0.31%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=footer). Last update [a3477ab...a4c0dd4](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-395911509 These are the final set of 3x empirical tests per example dashboard before and after, on non-minimized code with hard refresh/no caching. They look **even better** than above! - average total payload **decreased by 10.1 MB** (-71% change) - DOM content load time **decreased 8.7s** (-78% change) - Page total load time **decreased 7.9s** (-48% change) - the average # requests **increased by 30** @mistercrunch shall we merge this? | Total payload (MB) | | -- | -- | -- | -- Dashboard | Before | After | Delta Births example | 12.5 | 2.2 | **-10.3 MB** World data example | 12.5 | 2.6 | **-9.9 MB** Misc charts example | 14.6 | 4.3 | **-10.3 MB** Deck gl | 17.2 | 7.4 | **-9.8 MB** | DOM content loaded (seconds) | | -- | -- | -- | -- Dashboard | Before | After | Delta Births example | 11.52 | 2.28 | **-9.24 s** World data example | 10.77 | 2.73 | **-8.04 s** Misc charts example | 10.59 | 2.54 | **-8.05 s** Deck gl | 11.69 | 2.17 | **-9.5 s** | Total time [all requests incl async] (sec) | | -- | -- | -- | -- Dashboard | Before | After | Delta Births example | 16.63 | 7.96 | **-8.67 s** World data example | 13.17 | 6.76 | **-6.41 s** Misc charts example | 17.58 | 10.78 | **-6.80 s** Misc charts example w Deck gl | 18.43 | 8.85 | **-9.58 s** | Requests (count) | | -- | -- | -- | -- Dashboard | Before | After | Delta Births example | 32 | 63 | +31 World data example | 29 | 71 | +42 Misc charts example | 46 | 74 | +28 Deck gl (high bc of map tiles) | 196 | 217 | +21 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley commented on issue #5175: boto3 and botocore version mismatch
john-bodley commented on issue #5175: boto3 and botocore version mismatch URL: https://github.com/apache/incubator-superset/issues/5175#issuecomment-396444621 @mistercrunch @timifasubaa found a similar issue with Celery and had to pin the `kombu` subcomponent in [requirements.txt](https://github.com/apache/incubator-superset/blob/master/requirements.txt#L20). This file seems the right place to enforce strict pinning of packages when version conflicts etc. occur. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
