[OE-core] [PATCH v2 6/6] pango: Skip test-layout ptest

2022-04-13 Thread Khem Raj
This has intermittent behavior, is sensitive to harfbuzz version

Signed-off-by: Khem Raj 
---
v2: Add link to upstream bug

 .../0001-Skip-running-test-layout-test.patch  | 45 +++
 meta/recipes-graphics/pango/pango_1.50.6.bb   |  4 +-
 2 files changed, 48 insertions(+), 1 deletion(-)
 create mode 100644 
meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch

diff --git 
a/meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch 
b/meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch
new file mode 100644
index 000..ec7fb4727eb
--- /dev/null
+++ b/meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch
@@ -0,0 +1,45 @@
+From b9bfe3a79f165682a6db3d7ee1928365e93b1ccf Mon Sep 17 00:00:00 2001
+From: Khem Raj 
+Date: Wed, 13 Apr 2022 19:39:29 -0700
+Subject: [PATCH] Skip running test-layout test
+
+This fails intermittently, it varies based on what version of harfbuzz
+is installed and if it does not match with what pango CI tests then we
+get random failures in this test. This has been disabled in other
+distros [1] too
+
+We want to drop this on next upgrade and see if this test passes if not
+then keep it disabled
+
+Fixes
+
+Running test: pango/test-layout.test
+1..36
+ok 1 /layout/letterspacing.layout
+ok 2 /layout/valid-7.layout
+not ok 3 /layout/valid-14.layout
+Bail out!
+FAIL: pango/test-layout.test (Child process killed by signal 6)
+
+[1] 
https://github.com/archlinux/svntogit-packages/commit/3f883e7ff8071adad23b6bcc0ba4b995aff10d52
+
+Upstream-Status: Inappropriate [bugfix 
https://gitlab.gnome.org/GNOME/pango/-/issues/677]
+Signed-off-by: Khem Raj 
+---
+ tests/test-layout.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tests/test-layout.c b/tests/test-layout.c
+index 1139e4f..b47a066 100644
+--- a/tests/test-layout.c
 b/tests/test-layout.c
+@@ -222,5 +222,5 @@ main (int argc, char *argv[])
+ }
+   g_dir_close (dir);
+ 
+-  return g_test_run ();
++  return 77;
+ }
+-- 
+2.35.2
+
diff --git a/meta/recipes-graphics/pango/pango_1.50.6.bb 
b/meta/recipes-graphics/pango/pango_1.50.6.bb
index cd04801db10..93e16534641 100644
--- a/meta/recipes-graphics/pango/pango_1.50.6.bb
+++ b/meta/recipes-graphics/pango/pango_1.50.6.bb
@@ -18,7 +18,9 @@ inherit gnomebase gi-docgen ptest-gnome 
upstream-version-is-even gobject-introsp
 GIR_MESON_ENABLE_FLAG = "enabled"
 GIR_MESON_DISABLE_FLAG = "disabled"
 
-SRC_URI += "file://run-ptest"
+SRC_URI += "file://run-ptest \
+file://0001-Skip-running-test-layout-test.patch \
+"
 
 SRC_URI[archive.sha256sum] = 
"a998bcf36881c3ac20495d40bceb304f4eaa9175bd2967c85656434cbdafe86a"
 
-- 
2.35.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164390): 
https://lists.openembedded.org/g/openembedded-core/message/164390
Mute This Topic: https://lists.openembedded.org/mt/90458834/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] ccache: Fix build with gcc12/mips

2022-04-13 Thread Khem Raj
Please drop this patch, since it was a gcc bug which has been now
fixed in gcc trunk [1] and we will have this fix in gcc 12

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105234

On Tue, Apr 12, 2022 at 10:03 AM Khem Raj  wrote:
>
> Avoid gcc12 failure to inline function on mips
>
> Signed-off-by: Khem Raj 
> ---
>  ...t-Do-not-use-always_inline-with-mips.patch | 33 +++
>  meta/recipes-devtools/ccache/ccache_4.6.bb|  7 +++-
>  2 files changed, 39 insertions(+), 1 deletion(-)
>  create mode 100644 
> meta/recipes-devtools/ccache/ccache/0001-fmt-Do-not-use-always_inline-with-mips.patch
>
> diff --git 
> a/meta/recipes-devtools/ccache/ccache/0001-fmt-Do-not-use-always_inline-with-mips.patch
>  
> b/meta/recipes-devtools/ccache/ccache/0001-fmt-Do-not-use-always_inline-with-mips.patch
> new file mode 100644
> index 000..90cf27b4187
> --- /dev/null
> +++ 
> b/meta/recipes-devtools/ccache/ccache/0001-fmt-Do-not-use-always_inline-with-mips.patch
> @@ -0,0 +1,33 @@
> +From e57ce7af6f1ef0400aa847d79a7d3bc8803838bd Mon Sep 17 00:00:00 2001
> +From: Khem Raj 
> +Date: Mon, 11 Apr 2022 20:09:18 -0700
> +Subject: [PATCH] fmt: Do not use always_inline with mips
> +
> +mips/gcc-12 is not able to inline this function as reported here [1]
> +For now workaround this for mips by not forcing always_inline attribute
> +on functions
> +
> +[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105234
> +
> +Upstream-Status: Inappropriate [GCC MIPS Workaround]
> +Signed-off-by: Khem Raj 
> +---
> + src/third_party/fmt/core.h | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/src/third_party/fmt/core.h b/src/third_party/fmt/core.h
> +index 92a7aa1..e343ae0 100644
> +--- a/src/third_party/fmt/core.h
>  b/src/third_party/fmt/core.h
> +@@ -212,7 +212,7 @@
> + #endif
> +
> + #ifndef FMT_INLINE
> +-#  if FMT_GCC_VERSION || FMT_CLANG_VERSION
> ++#  if (FMT_GCC_VERSION || FMT_CLANG_VERSION) && !defined (__mips__)
> + #define FMT_INLINE inline __attribute__((always_inline))
> + #  else
> + #define FMT_INLINE inline
> +--
> +2.35.1
> +
> diff --git a/meta/recipes-devtools/ccache/ccache_4.6.bb 
> b/meta/recipes-devtools/ccache/ccache_4.6.bb
> index f019679cf18..740f92fb45e 100644
> --- a/meta/recipes-devtools/ccache/ccache_4.6.bb
> +++ b/meta/recipes-devtools/ccache/ccache_4.6.bb
> @@ -11,7 +11,9 @@ LIC_FILES_CHKSUM = 
> "file://LICENSE.adoc;md5=ff5327dc93e2b286c931dda3d6079da9"
>
>  DEPENDS = "zstd"
>
> -SRC_URI = 
> "https://github.com/ccache/ccache/releases/download/v${PV}/${BP}.tar.gz;
> +SRC_URI = 
> "https://github.com/ccache/ccache/releases/download/v${PV}/${BP}.tar.gz \
> +   file://0001-fmt-Do-not-use-always_inline-with-mips.patch \
> +  "
>  SRC_URI[sha256sum] = 
> "73a1767ac6b7c0404a1a55f761a746d338e702883c7137fbf587023062258625"
>
>  UPSTREAM_CHECK_URI = "https://github.com/ccache/ccache/releases/;
> @@ -24,3 +26,6 @@ BBCLASSEXTEND = "native nativesdk"
>
>  PACKAGECONFIG[docs] = 
> "-DENABLE_DOCUMENTATION=ON,-DENABLE_DOCUMENTATION=OFF,asciidoc"
>  PACKAGECONFIG[redis] = 
> "-DREDIS_STORAGE_BACKEND=ON,-DREDIS_STORAGE_BACKEND=OFF,hiredis"
> +PACKAGECONFIG[tests] = "-DENABLE_TESTING=ON,-DENABLE_TESTING=OFF,,"
> +
> +lcl_maybe_fortify:mipsarch = ""
> --
> 2.35.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164389): 
https://lists.openembedded.org/g/openembedded-core/message/164389
Mute This Topic: https://lists.openembedded.org/mt/90422736/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] go: Always pass interpreter to linker

2022-04-13 Thread J?rg Vehlow
Hi,

Am 4/11/2022 um 6:04 PM schrieb Khem Raj:
> On Mon, Apr 11, 2022 at 6:30 AM Jose Quaresma  wrote:
>>
>>
>>
>> J?rg Vehlow  escreveu no dia segunda, 11/04/2022 à(s) 
>> 13:35:
>>>
>>> From: Joerg Vehlow 
>>>
>>> When gos internal linker is used, it uses hardcoded paths to the
>>> interpreter (dynamic linker). For x86_64 this hardcoded path is
>>> /lib64/ld-linux-x86-64.so.2, but yocto's default dynamic linker path
>>> is /lib64/ld-linux-x86-64.so.2.
>>
>>
>> Is this correct? The first path is the seme one of the second.
> 
> its a typo, Sadly we do differ in baselib naming convention on x86_64
> ( without multilib )
> compared to other distributions which are inherently multilib and use
> /lib64 OE instead uses
> /lib when multilib is not enabled but lib64/ when multilib is enabled.

Any comment on the content of the patch or do I have to send a v2 with a
fixed commit message?

Thanks,
Joerg

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164388): 
https://lists.openembedded.org/g/openembedded-core/message/164388
Mute This Topic: https://lists.openembedded.org/mt/90393660/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 6/6] pango: Skip test-layout ptest

2022-04-13 Thread Alexander Kanavin
Please do file an upstream bug and include a link to it.

Alex

On Thu 14. Apr 2022 at 4.52, Khem Raj  wrote:

> This has intermittent behavior, is sensitive to harfbuzz version
>
> Signed-off-by: Khem Raj 
> ---
>  .../0001-Skip-running-test-layout-test.patch  | 45 +++
>  meta/recipes-graphics/pango/pango_1.50.6.bb   |  4 +-
>  2 files changed, 48 insertions(+), 1 deletion(-)
>  create mode 100644
> meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch
>
> diff --git
> a/meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch
> b/meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch
> new file mode 100644
> index 000..c391e158d28
> --- /dev/null
> +++
> b/meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch
> @@ -0,0 +1,45 @@
> +From b9bfe3a79f165682a6db3d7ee1928365e93b1ccf Mon Sep 17 00:00:00 2001
> +From: Khem Raj 
> +Date: Wed, 13 Apr 2022 19:39:29 -0700
> +Subject: [PATCH] Skip running test-layout test
> +
> +This fails intermittently, it varies based on what version of harfbuzz
> +is installed and if it does not match with what pango CI tests then we
> +get random failures in this test. This has been disabled in other
> +distros [1] too
> +
> +We want to drop this on next upgrade and see if this test passes if not
> +then keep it disabled
> +
> +Fixes
> +
> +Running test: pango/test-layout.test
> +1..36
> +ok 1 /layout/letterspacing.layout
> +ok 2 /layout/valid-7.layout
> +not ok 3 /layout/valid-14.layout
> +Bail out!
> +FAIL: pango/test-layout.test (Child process killed by signal 6)
> +
> +[1]
> https://github.com/archlinux/svntogit-packages/commit/3f883e7ff8071adad23b6bcc0ba4b995aff10d52
> +
> +Upstream-Status: Inappropriate [Distro specific]
> +Signed-off-by: Khem Raj 
> +---
> + tests/test-layout.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/tests/test-layout.c b/tests/test-layout.c
> +index 1139e4f..b47a066 100644
> +--- a/tests/test-layout.c
>  b/tests/test-layout.c
> +@@ -222,5 +222,5 @@ main (int argc, char *argv[])
> + }
> +   g_dir_close (dir);
> +
> +-  return g_test_run ();
> ++  return 77;
> + }
> +--
> +2.35.2
> +
> diff --git a/meta/recipes-graphics/pango/pango_1.50.6.bb
> b/meta/recipes-graphics/pango/pango_1.50.6.bb
> index cd04801db10..93e16534641 100644
> --- a/meta/recipes-graphics/pango/pango_1.50.6.bb
> +++ b/meta/recipes-graphics/pango/pango_1.50.6.bb
> @@ -18,7 +18,9 @@ inherit gnomebase gi-docgen ptest-gnome
> upstream-version-is-even gobject-introsp
>  GIR_MESON_ENABLE_FLAG = "enabled"
>  GIR_MESON_DISABLE_FLAG = "disabled"
>
> -SRC_URI += "file://run-ptest"
> +SRC_URI += "file://run-ptest \
> +file://0001-Skip-running-test-layout-test.patch \
> +"
>
>  SRC_URI[archive.sha256sum] =
> "a998bcf36881c3ac20495d40bceb304f4eaa9175bd2967c85656434cbdafe86a"
>
> --
> 2.35.2
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164387): 
https://lists.openembedded.org/g/openembedded-core/message/164387
Mute This Topic: https://lists.openembedded.org/mt/90456793/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Steve Sakoman
On Wed, Apr 13, 2022 at 5:02 PM Steve Sakoman  wrote:
>
> On Wed, Apr 13, 2022 at 5:01 PM Steve Sakoman via
> lists.openembedded.org 
> wrote:
> >
> > On Wed, Apr 13, 2022 at 4:47 PM Ralph Siemsen  
> > wrote:
> > >
> > > On Wed, 2022-04-13 at 11:39 -1000, Steve Sakoman wrote:
> > > > I did another experiment, where I disabled generation of the sha256
> > > > entries in Release (by adding --no-sha256 to the apt-ftparchive
> > > > command)
> > > >
> > > > As a result we get past this first hash mismatch in Release, but then
> > > > get later hash mismatches when it tries to download .debs.
> > >
> > > I am able to get past this, albeit with a hack. This fixes the sha256
> > > sum in the Release file, as well as verification of the .deb files.
> > > The original test then passes:
> > >
> > > RESULTS - apt.AptRepoTest.test_apt_install_from_repo: PASSED (46.75s)
> > >
> > > The hack to reduce the optimisation level for apt-native and apt. By
> > > default it uses CXXFLAGS="-g -O2". Reducing this to -O1 fixes the
> > > checksums.
> >
> > Nice work!
> >
> > > > The issue is happening on Fedora 35 and Alma 8, so no
> > > > buildtools-tarball in this case!
> >
> > I've started a build that uses buildtools just to verify that fixes it
> > and there aren't any other issues.
>
> FWIW, here is the link to that build - still underway.

Sigh, here is the link:
https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5078

>
> Steve
>
> >
> > > Fedora 35 is using gcc-11.2.1, could you check what Alma 8 uses?
> >
> > [sakoman@alma8-ty-1 ~]$ gcc --version
> > gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-4)
> >
> > >
> > > Here are a few other things I checked, prior to noticing the
> > > optimisation level issue:
> > >
> > > 1) we are using apt 1.2.31; the latest 1.2.y version is 1.2.35
> > > - this still has the problem with bad sha256sums
> > > - it does include several CVE fixes which we might want
> > > - it added a new dependency on systemd
> >
> > Urgh . . . this last part isn't good since it would be a behavior
> > change which isn't OK for LTS
> >
> > It may be that the best solution is to change to -O1 :-(
> >
> > Steve
> >
> > >
> > > 2) main branch version is 2.3.5
> > > - it switched to CMAKE
> > > - many new dependencies
> > > - I got it to configure, but not compile
> > > - custom crypto code seems to be dropped, in favour of gcrypt
> > > - presumably this would fix the sha256 however I cannot confirm
> > >
> > > Regards,
> > > Ralph
> > >
> > >
> > >
> >
> > 
> >

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164386): 
https://lists.openembedded.org/g/openembedded-core/message/164386
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Steve Sakoman
On Wed, Apr 13, 2022 at 5:01 PM Steve Sakoman via
lists.openembedded.org 
wrote:
>
> On Wed, Apr 13, 2022 at 4:47 PM Ralph Siemsen  
> wrote:
> >
> > On Wed, 2022-04-13 at 11:39 -1000, Steve Sakoman wrote:
> > > I did another experiment, where I disabled generation of the sha256
> > > entries in Release (by adding --no-sha256 to the apt-ftparchive
> > > command)
> > >
> > > As a result we get past this first hash mismatch in Release, but then
> > > get later hash mismatches when it tries to download .debs.
> >
> > I am able to get past this, albeit with a hack. This fixes the sha256
> > sum in the Release file, as well as verification of the .deb files.
> > The original test then passes:
> >
> > RESULTS - apt.AptRepoTest.test_apt_install_from_repo: PASSED (46.75s)
> >
> > The hack to reduce the optimisation level for apt-native and apt. By
> > default it uses CXXFLAGS="-g -O2". Reducing this to -O1 fixes the
> > checksums.
>
> Nice work!
>
> > > The issue is happening on Fedora 35 and Alma 8, so no
> > > buildtools-tarball in this case!
>
> I've started a build that uses buildtools just to verify that fixes it
> and there aren't any other issues.

FWIW, here is the link to that build - still underway.

Steve

>
> > Fedora 35 is using gcc-11.2.1, could you check what Alma 8 uses?
>
> [sakoman@alma8-ty-1 ~]$ gcc --version
> gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-4)
>
> >
> > Here are a few other things I checked, prior to noticing the
> > optimisation level issue:
> >
> > 1) we are using apt 1.2.31; the latest 1.2.y version is 1.2.35
> > - this still has the problem with bad sha256sums
> > - it does include several CVE fixes which we might want
> > - it added a new dependency on systemd
>
> Urgh . . . this last part isn't good since it would be a behavior
> change which isn't OK for LTS
>
> It may be that the best solution is to change to -O1 :-(
>
> Steve
>
> >
> > 2) main branch version is 2.3.5
> > - it switched to CMAKE
> > - many new dependencies
> > - I got it to configure, but not compile
> > - custom crypto code seems to be dropped, in favour of gcrypt
> > - presumably this would fix the sha256 however I cannot confirm
> >
> > Regards,
> > Ralph
> >
> >
> >
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164385): 
https://lists.openembedded.org/g/openembedded-core/message/164385
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Steve Sakoman
On Wed, Apr 13, 2022 at 4:47 PM Ralph Siemsen  wrote:
>
> On Wed, 2022-04-13 at 11:39 -1000, Steve Sakoman wrote:
> > I did another experiment, where I disabled generation of the sha256
> > entries in Release (by adding --no-sha256 to the apt-ftparchive
> > command)
> >
> > As a result we get past this first hash mismatch in Release, but then
> > get later hash mismatches when it tries to download .debs.
>
> I am able to get past this, albeit with a hack. This fixes the sha256
> sum in the Release file, as well as verification of the .deb files.
> The original test then passes:
>
> RESULTS - apt.AptRepoTest.test_apt_install_from_repo: PASSED (46.75s)
>
> The hack to reduce the optimisation level for apt-native and apt. By
> default it uses CXXFLAGS="-g -O2". Reducing this to -O1 fixes the
> checksums.

Nice work!

> > The issue is happening on Fedora 35 and Alma 8, so no
> > buildtools-tarball in this case!

I've started a build that uses buildtools just to verify that fixes it
and there aren't any other issues.

> Fedora 35 is using gcc-11.2.1, could you check what Alma 8 uses?

[sakoman@alma8-ty-1 ~]$ gcc --version
gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-4)

>
> Here are a few other things I checked, prior to noticing the
> optimisation level issue:
>
> 1) we are using apt 1.2.31; the latest 1.2.y version is 1.2.35
> - this still has the problem with bad sha256sums
> - it does include several CVE fixes which we might want
> - it added a new dependency on systemd

Urgh . . . this last part isn't good since it would be a behavior
change which isn't OK for LTS

It may be that the best solution is to change to -O1 :-(

Steve

>
> 2) main branch version is 2.3.5
> - it switched to CMAKE
> - many new dependencies
> - I got it to configure, but not compile
> - custom crypto code seems to be dropped, in favour of gcrypt
> - presumably this would fix the sha256 however I cannot confirm
>
> Regards,
> Ralph
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164384): 
https://lists.openembedded.org/g/openembedded-core/message/164384
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 6/6] pango: Skip test-layout ptest

2022-04-13 Thread Khem Raj
This has intermittent behavior, is sensitive to harfbuzz version

Signed-off-by: Khem Raj 
---
 .../0001-Skip-running-test-layout-test.patch  | 45 +++
 meta/recipes-graphics/pango/pango_1.50.6.bb   |  4 +-
 2 files changed, 48 insertions(+), 1 deletion(-)
 create mode 100644 
meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch

diff --git 
a/meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch 
b/meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch
new file mode 100644
index 000..c391e158d28
--- /dev/null
+++ b/meta/recipes-graphics/pango/pango/0001-Skip-running-test-layout-test.patch
@@ -0,0 +1,45 @@
+From b9bfe3a79f165682a6db3d7ee1928365e93b1ccf Mon Sep 17 00:00:00 2001
+From: Khem Raj 
+Date: Wed, 13 Apr 2022 19:39:29 -0700
+Subject: [PATCH] Skip running test-layout test
+
+This fails intermittently, it varies based on what version of harfbuzz
+is installed and if it does not match with what pango CI tests then we
+get random failures in this test. This has been disabled in other
+distros [1] too
+
+We want to drop this on next upgrade and see if this test passes if not
+then keep it disabled
+
+Fixes
+
+Running test: pango/test-layout.test
+1..36
+ok 1 /layout/letterspacing.layout
+ok 2 /layout/valid-7.layout
+not ok 3 /layout/valid-14.layout
+Bail out!
+FAIL: pango/test-layout.test (Child process killed by signal 6)
+
+[1] 
https://github.com/archlinux/svntogit-packages/commit/3f883e7ff8071adad23b6bcc0ba4b995aff10d52
+
+Upstream-Status: Inappropriate [Distro specific]
+Signed-off-by: Khem Raj 
+---
+ tests/test-layout.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tests/test-layout.c b/tests/test-layout.c
+index 1139e4f..b47a066 100644
+--- a/tests/test-layout.c
 b/tests/test-layout.c
+@@ -222,5 +222,5 @@ main (int argc, char *argv[])
+ }
+   g_dir_close (dir);
+ 
+-  return g_test_run ();
++  return 77;
+ }
+-- 
+2.35.2
+
diff --git a/meta/recipes-graphics/pango/pango_1.50.6.bb 
b/meta/recipes-graphics/pango/pango_1.50.6.bb
index cd04801db10..93e16534641 100644
--- a/meta/recipes-graphics/pango/pango_1.50.6.bb
+++ b/meta/recipes-graphics/pango/pango_1.50.6.bb
@@ -18,7 +18,9 @@ inherit gnomebase gi-docgen ptest-gnome 
upstream-version-is-even gobject-introsp
 GIR_MESON_ENABLE_FLAG = "enabled"
 GIR_MESON_DISABLE_FLAG = "disabled"
 
-SRC_URI += "file://run-ptest"
+SRC_URI += "file://run-ptest \
+file://0001-Skip-running-test-layout-test.patch \
+"
 
 SRC_URI[archive.sha256sum] = 
"a998bcf36881c3ac20495d40bceb304f4eaa9175bd2967c85656434cbdafe86a"
 
-- 
2.35.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164383): 
https://lists.openembedded.org/g/openembedded-core/message/164383
Mute This Topic: https://lists.openembedded.org/mt/90456793/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 4/6] pango: Upgrade to 1.50.6

2022-04-13 Thread Khem Raj
Changes in this release [1]

[1] 
https://github.com/GNOME/pango/commit/37a427018c92a2bc679ef104097e07a619609c9c
Signed-off-by: Khem Raj 
---
 .../recipes-graphics/pango/{pango_1.50.4.bb => pango_1.50.6.bb} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-graphics/pango/{pango_1.50.4.bb => pango_1.50.6.bb} (94%)

diff --git a/meta/recipes-graphics/pango/pango_1.50.4.bb 
b/meta/recipes-graphics/pango/pango_1.50.6.bb
similarity index 94%
rename from meta/recipes-graphics/pango/pango_1.50.4.bb
rename to meta/recipes-graphics/pango/pango_1.50.6.bb
index 0ea621bf670..b1b9054234d 100644
--- a/meta/recipes-graphics/pango/pango_1.50.4.bb
+++ b/meta/recipes-graphics/pango/pango_1.50.6.bb
@@ -20,7 +20,7 @@ GIR_MESON_DISABLE_FLAG = "disabled"
 
 SRC_URI += "file://run-ptest"
 
-SRC_URI[archive.sha256sum] = 
"f4ad63e87dc2b145300542a4fb004d07a9f91b34152fae0ddbe50ecdd851c162"
+SRC_URI[archive.sha256sum] = 
"a998bcf36881c3ac20495d40bceb304f4eaa9175bd2967c85656434cbdafe86a"
 
 DEPENDS = "glib-2.0 glib-2.0-native fontconfig freetype virtual/libiconv cairo 
harfbuzz fribidi"
 
-- 
2.35.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164381): 
https://lists.openembedded.org/g/openembedded-core/message/164381
Mute This Topic: https://lists.openembedded.org/mt/90456791/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 5/6] pango: Drop using additional cflags with clang

2022-04-13 Thread Khem Raj
This is no longer needed

Signed-off-by: Khem Raj 
---
 meta/recipes-graphics/pango/pango_1.50.6.bb | 4 
 1 file changed, 4 deletions(-)

diff --git a/meta/recipes-graphics/pango/pango_1.50.6.bb 
b/meta/recipes-graphics/pango/pango_1.50.6.bb
index b1b9054234d..cd04801db10 100644
--- a/meta/recipes-graphics/pango/pango_1.50.6.bb
+++ b/meta/recipes-graphics/pango/pango_1.50.6.bb
@@ -37,10 +37,6 @@ do_configure:prepend() {
 chmod +x ${S}/tests/*.py
 }
 
-do_configure:prepend:toolchain-clang() {
-sed -i -e "/Werror=implicit-fallthrough/d" ${S}/meson.build
-}
-
 LEAD_SONAME = "libpango-1.0*"
 
 FILES:${PN} = "${bindir}/* ${libdir}/libpango*${SOLIBS}"
-- 
2.35.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164382): 
https://lists.openembedded.org/g/openembedded-core/message/164382
Mute This Topic: https://lists.openembedded.org/mt/90456792/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 2/6] mdadm: Drop clang specific cflags

2022-04-13 Thread Khem Raj
This option is no longer needed

Signed-off-by: Khem Raj 
---
 meta/recipes-extended/mdadm/mdadm_4.2.bb | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-extended/mdadm/mdadm_4.2.bb 
b/meta/recipes-extended/mdadm/mdadm_4.2.bb
index 1c2fc8c37a7..19035caaec9 100644
--- a/meta/recipes-extended/mdadm/mdadm_4.2.bb
+++ b/meta/recipes-extended/mdadm/mdadm_4.2.bb
@@ -35,8 +35,6 @@ DEPENDS = "udev"
 SYSTEMD_SERVICE:${PN} = "mdmonitor.service"
 SYSTEMD_AUTO_ENABLE = "disable"
 
-CFLAGS:append:toolchain-clang = " -Wno-error=address-of-packed-member"
-
 # PPC64 and MIPS64 uses long long for u64 in the kernel, but powerpc's 
asm/types.h
 # prevents 64-bit userland from seeing this definition, instead defaulting
 # to u64 == long in userspace. Define __SANE_USERSPACE_TYPES__ to get
-- 
2.35.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164379): 
https://lists.openembedded.org/g/openembedded-core/message/164379
Mute This Topic: https://lists.openembedded.org/mt/90456788/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 3/6] harfbuzz: Upgrade to 4.2.0

2022-04-13 Thread Khem Raj
Changes in this release [1] [2]

[1] https://github.com/harfbuzz/harfbuzz/releases/tag/4.1.0
[2] https://github.com/harfbuzz/harfbuzz/releases/tag/4.2.0

Signed-off-by: Khem Raj 
---
 .../harfbuzz/{harfbuzz_4.0.1.bb => harfbuzz_4.2.0.bb}   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-graphics/harfbuzz/{harfbuzz_4.0.1.bb => harfbuzz_4.2.0.bb} 
(95%)

diff --git a/meta/recipes-graphics/harfbuzz/harfbuzz_4.0.1.bb 
b/meta/recipes-graphics/harfbuzz/harfbuzz_4.2.0.bb
similarity index 95%
rename from meta/recipes-graphics/harfbuzz/harfbuzz_4.0.1.bb
rename to meta/recipes-graphics/harfbuzz/harfbuzz_4.2.0.bb
index bf77a5e56c5..44d42e6904b 100644
--- a/meta/recipes-graphics/harfbuzz/harfbuzz_4.0.1.bb
+++ b/meta/recipes-graphics/harfbuzz/harfbuzz_4.2.0.bb
@@ -12,7 +12,7 @@ UPSTREAM_CHECK_URI = 
"https://github.com/${BPN}/${BPN}/releases;
 UPSTREAM_CHECK_REGEX = "harfbuzz-(?P\d+(\.\d+)+).tar"
 
 SRC_URI = 
"https://github.com/${BPN}/${BPN}/releases/download/${PV}/${BPN}-${PV}.tar.xz;
-SRC_URI[sha256sum] = 
"98f68777272db6cd7a3d5152bac75083cd52a26176d87bc04c8b3929d33bce49"
+SRC_URI[sha256sum] = 
"f2200f177768bdc21445aa09703326f3bbe8114ac083d081fe1a79d305c7ae73"
 
 inherit meson pkgconfig lib_package gtk-doc gobject-introspection
 
-- 
2.35.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164380): 
https://lists.openembedded.org/g/openembedded-core/message/164380
Mute This Topic: https://lists.openembedded.org/mt/90456790/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 1/6] riscv: Add tunes for rv64 without compressed instructions

2022-04-13 Thread Khem Raj
Signed-off-by: Khem Raj 
---
 meta/conf/machine/include/riscv/arch-riscv.inc | 2 ++
 meta/conf/machine/include/riscv/tune-riscv.inc | 8 
 2 files changed, 10 insertions(+)

diff --git a/meta/conf/machine/include/riscv/arch-riscv.inc 
b/meta/conf/machine/include/riscv/arch-riscv.inc
index e5611a12a66..230a266563a 100644
--- a/meta/conf/machine/include/riscv/arch-riscv.inc
+++ b/meta/conf/machine/include/riscv/arch-riscv.inc
@@ -7,6 +7,8 @@ TUNE_PKGARCH = "${TUNE_PKGARCH:tune-${DEFAULTTUNE}}"
 TUNE_CCARGS:append = "${@bb.utils.contains('TUNE_FEATURES', 'riscv64nf', ' 
-mabi=lp64', ' ', d)}"
 TUNE_CCARGS:append = "${@bb.utils.contains('TUNE_FEATURES', 'riscv32nf', ' 
-mabi=ilp32', ' ', d)}"
 
+TUNE_CCARGS:append = "${@bb.utils.contains('TUNE_FEATURES', 'riscv64nc', ' 
-march=rv64imafd', ' ', d)}"
+
 # Fix: ld: unrecognized option '--hash-style=sysv'
 LINKER_HASH_STYLE:libc-newlib = ""
 # Fix: ld: unrecognized option '--hash-style=gnu'
diff --git a/meta/conf/machine/include/riscv/tune-riscv.inc 
b/meta/conf/machine/include/riscv/tune-riscv.inc
index cc2896f277b..659801496c9 100644
--- a/meta/conf/machine/include/riscv/tune-riscv.inc
+++ b/meta/conf/machine/include/riscv/tune-riscv.inc
@@ -6,6 +6,8 @@ TUNEVALID[riscv32] = "Enable 32-bit RISC-V optimizations"
 TUNEVALID[riscv64nf] = "Enable 64-bit RISC-V optimizations no floating point"
 TUNEVALID[riscv32nf] = "Enable 32-bit RISC-V optimizations no floating point"
 
+TUNEVALID[riscv64nc] = "Enable 64-bit RISC-V optimizations without compressed 
instructions"
+
 TUNEVALID[bigendian] = "Big endian mode"
 
 AVAILTUNES += "riscv64 riscv32 riscv64nf riscv32nf"
@@ -31,3 +33,9 @@ TUNE_FEATURES:tune-riscv32nf = "${TUNE_FEATURES:tune-riscv32} 
riscv32nf"
 TUNE_ARCH:tune-riscv32nf = "riscv32"
 TUNE_PKGARCH:tune-riscv32nf = "riscv32nf"
 PACKAGE_EXTRA_ARCHS:tune-riscv32nf = "riscv32nf"
+
+# no compressed
+TUNE_FEATURES:tune-riscv64nc = "${TUNE_FEATURES:tune-riscv64} riscv64nc"
+TUNE_ARCH:tune-riscv64nc = "riscv64"
+TUNE_PKGARCH:tune-riscv64nc = "riscv64nc"
+PACKAGE_EXTRA_ARCHS:tune-riscv64nc = "riscv64nc"
-- 
2.35.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164378): 
https://lists.openembedded.org/g/openembedded-core/message/164378
Mute This Topic: https://lists.openembedded.org/mt/90456787/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Ralph Siemsen
On Wed, 2022-04-13 at 11:39 -1000, Steve Sakoman wrote:
> I did another experiment, where I disabled generation of the sha256
> entries in Release (by adding --no-sha256 to the apt-ftparchive
> command)
>
> As a result we get past this first hash mismatch in Release, but then
> get later hash mismatches when it tries to download .debs.

I am able to get past this, albeit with a hack. This fixes the sha256
sum in the Release file, as well as verification of the .deb files.
The original test then passes:

RESULTS - apt.AptRepoTest.test_apt_install_from_repo: PASSED (46.75s)

The hack to reduce the optimisation level for apt-native and apt. By
default it uses CXXFLAGS="-g -O2". Reducing this to -O1 fixes the
checksums.

> The issue is happening on Fedora 35 and Alma 8, so no
> buildtools-tarball in this case!

Fedora 35 is using gcc-11.2.1, could you check what Alma 8 uses?

Here are a few other things I checked, prior to noticing the
optimisation level issue:

1) we are using apt 1.2.31; the latest 1.2.y version is 1.2.35
- this still has the problem with bad sha256sums
- it does include several CVE fixes which we might want
- it added a new dependency on systemd

2) main branch version is 2.3.5
- it switched to CMAKE
- many new dependencies
- I got it to configure, but not compile
- custom crypto code seems to be dropped, in favour of gcrypt
- presumably this would fix the sha256 however I cannot confirm

Regards,
Ralph

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164377): 
https://lists.openembedded.org/g/openembedded-core/message/164377
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 0/8] kernel: consolidated pull request

2022-04-13 Thread Bruce Ashfield
On Wed, Apr 13, 2022 at 11:42 AM Bruce Ashfield via
lists.openembedded.org
 wrote:
>
>
>
> On Wed, Apr 13, 2022 at 11:19 AM Luca Ceresoli  
> wrote:
>>
>> Hello Bruce,
>>
>> Il giorno Tue, 12 Apr 2022 17:45:55 -0400
>> "Bruce Ashfield"  ha scritto:
>>
>> > From: Bruce Ashfield 
>> >
>> > Richard,
>> >
>> > Here's the collection of -stable, fixes and tweaks that I was talking
>> > about during the engineering sync on Tuesday.
>> >
>> > Feel free to take what you want, or just wait on them all until the
>> > release is over.
>> >
>> > It is worth taking the 5.18 -dev and lttng fixes IMHO, since they do
>> > make the release a bit more future proof. Likewise with Jon's -tiny
>> > changes.
>> >
>> > Cheers,
>> >
>> > Bruce
>> >
>> > The following changes since commit
>> > 632c83ab787211ef927a999f4ecde1d3ce40621d:
>> >
>> >   license_image.bbclass: close package.manifest file (2022-04-10
>> > 08:31:17 +0100)
>> >
>> > are available in the Git repository at:
>> >
>> >   git://git.yoctoproject.org/poky-contrib zedd/kernel
>> >   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel
>> >
>> > Bruce Ashfield (8):
>> >   linux-yocto/5.15: arm: poky-tiny cleanup and fixes
>> >   linux-yocto/5.15: update to v5.15.33
>> >   linux-yocto/5.10: update to v5.10.110
>> >   linux-yocto/5.10: base: enable kernel crypto userspace API
>> >   linux-yocto/5.15: base: enable kernel crypto userspace API
>> >   linux-yocto/5.15: kasan: fix BUG: sleeping function called from
>> > invalid context
>> >   lttng-modules: support kernel 5.18+
>> >   linux-yocto-dev: update to v5.18+
>>
>> Sending this series to the autobuilders triggered some errors and
>> warnings (see below). Can you check that?
>>
>
> unfortunately not. I'll wait out the release and re-submit these later.
>
> That being said, I've run similar tests to the errors found on the AB, and 
> can't reproduce locally, so I have no way to debug.
>
> Cheers,
>
> Bruce
>
>
>>
>> 1. kernel not booting on qemuppc
>>
>>   >> OpenBIOS 1.1 [Nov 1 2021 20:36]
>>   >> Configuration device id QEMU version 1 machine id 1
>>   >> CPUs: 1
>>   >> Memory: 256M
>>   >> UUID: ----
>>   >> CPU type PowerPC,G4
>>   milliseconds isn't unique.
>>   >> [ppc] Kernel already loaded (0x0100 + 0x01394760) (initrd
>>   >> 0x + 0x) [ppc] Kernel command line: root=/dev/vda rw 
>> mem=256M
>>   >> ip=192.168.7.4::192.168.7.3:255.255.255.0::eth0:off:8.8.8.8 
>> console=ttyS0 console=ttyS1 console=tty console=ttyS0 printk.time=1
>>   >> switching to new context:
>>

I was able to steal a bit of time and did a git bisect on this one. i
have a suspected commit:

commit c894ac44786cfed383a6c6b20c1bfb12eb96018a
Author: Thomas Zimmermann 
Date:   Tue Jan 25 10:12:18 2022 +0100

fbdev: Hot-unplug firmware fb devices on forced removal
commit 27599aacbaefcbf2af7b06b0029459bbf682000d upstream.

Which seems to line up with the messages in the panic.

I reverted it, and I'm able to boot again. I'll carry that locally and
see what the full upstream fix is later .. since this is going to hit
us on future kernels as well.

>>
>>   = end: snippet =
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/5012/steps/12/logs/stdio
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/5013/steps/12/logs/stdio
>>
>> 2. X.org not starting on qemuarm
>>
>> [14.037] (EE) No devices detected.
>> [14.039] (EE) Fatal server error:
>> [14.040] (EE) no screens found(EE)
>> [14.041] (EE)
>> Please consult the The X.Org Foundation support
>>  at http://wiki.x.org
>>  for help.
>> [14.042] (EE) Please also check the log file at
>> "/var/log/Xorg.0.log" for additional information.
>> [14.046] (EE) Server terminated with error (1). Closing log file.
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/5053/steps/12/logs/stdio
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/5054/steps/12/logs/stdio
>>


This was related to Jon Mason's config changes to qemuarm for -tiny,
he's got it working again, and a fix should be incoming.

>>
>> 3. ptest warning
>>
>> AssertionError: Failed ptests:
>> {'strace': ['landlock_create_ruleset-y.gen.test',
>> 'landlock_create_ruleset-y.gen']}
>>
>> This is landlock-related, thus perhaps caused by patch 2/8.
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/3117/steps/12/logs/stdio
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/3369/steps/12/logs/stdio
>>

No great idea on this one yet. I can't easily run ptests with my
aging/ancient builder, so I'll see if I can come up with a simpler way
to test it next week.

Bruce


>>
>> Best regards.
>> --
>> Luca Ceresoli, Bootlin
>> Embedded Linux and Kernel engineering
>> https://bootlin.com
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee at 
> its end
> - "Use the force Harry" - 

Re: [OE-core] [PATCH v2 2/2] pango: Upgrade to 1.50.6

2022-04-13 Thread Khem Raj
it looks like a rounding error. A bunch of them were fixed in few
months back via

https://gitlab.gnome.org/GNOME/pango/-/commit/053c9ff8ab00d6d7d4b7cbe8aeeaca58c0982df1

On Wed, Apr 13, 2022 at 3:42 PM Khem Raj  wrote:
>
> On Tue, Apr 12, 2022 at 1:07 AM Alexandre Belloni
>  wrote:
> >
> > Hi Khem,
> >
> > On 10/04/2022 16:16:59-0700, Khem Raj wrote:
> > > Changes in this release [1]
> > >
> > > [1] 
> > > https://github.com/GNOME/pango/commit/37a427018c92a2bc679ef104097e07a619609c9c
> >
> >
> > New ptest failures with this release:
> > https://autobuilder.yoctoproject.org/typhoon/#builders/82/builds/3109/steps/12/logs/stdio
> > https://autobuilder.yoctoproject.org/typhoon/#builders/81/builds/3362/steps/12/logs/stdio
> >
> > {'pango': ['pango/test-layout.test']}
> >
> > It seems to be intermittent as my previous build didn't have that
> > failure.
>
> hmmm is there more info in logs on how it fails ?
>
> >
> > > Signed-off-by: Khem Raj 
> > > ---
> > > v2: Rebased
> > >
> > >  .../recipes-graphics/pango/{pango_1.50.4.bb => pango_1.50.6.bb} | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >  rename meta/recipes-graphics/pango/{pango_1.50.4.bb => pango_1.50.6.bb} 
> > > (94%)
> > >
> > > diff --git a/meta/recipes-graphics/pango/pango_1.50.4.bb 
> > > b/meta/recipes-graphics/pango/pango_1.50.6.bb
> > > similarity index 94%
> > > rename from meta/recipes-graphics/pango/pango_1.50.4.bb
> > > rename to meta/recipes-graphics/pango/pango_1.50.6.bb
> > > index 0ea621bf670..b1b9054234d 100644
> > > --- a/meta/recipes-graphics/pango/pango_1.50.4.bb
> > > +++ b/meta/recipes-graphics/pango/pango_1.50.6.bb
> > > @@ -20,7 +20,7 @@ GIR_MESON_DISABLE_FLAG = "disabled"
> > >
> > >  SRC_URI += "file://run-ptest"
> > >
> > > -SRC_URI[archive.sha256sum] = 
> > > "f4ad63e87dc2b145300542a4fb004d07a9f91b34152fae0ddbe50ecdd851c162"
> > > +SRC_URI[archive.sha256sum] = 
> > > "a998bcf36881c3ac20495d40bceb304f4eaa9175bd2967c85656434cbdafe86a"
> > >
> > >  DEPENDS = "glib-2.0 glib-2.0-native fontconfig freetype virtual/libiconv 
> > > cairo harfbuzz fribidi"
> > >
> > > --
> > > 2.35.1
> > >
> >
> > >
> > > 
> > >
> >
> >
> > --
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164375): 
https://lists.openembedded.org/g/openembedded-core/message/164375
Mute This Topic: https://lists.openembedded.org/mt/90384193/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2 2/2] pango: Upgrade to 1.50.6

2022-04-13 Thread Khem Raj
On Tue, Apr 12, 2022 at 1:07 AM Alexandre Belloni
 wrote:
>
> Hi Khem,
>
> On 10/04/2022 16:16:59-0700, Khem Raj wrote:
> > Changes in this release [1]
> >
> > [1] 
> > https://github.com/GNOME/pango/commit/37a427018c92a2bc679ef104097e07a619609c9c
>
>
> New ptest failures with this release:
> https://autobuilder.yoctoproject.org/typhoon/#builders/82/builds/3109/steps/12/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#builders/81/builds/3362/steps/12/logs/stdio
>
> {'pango': ['pango/test-layout.test']}
>
> It seems to be intermittent as my previous build didn't have that
> failure.

hmmm is there more info in logs on how it fails ?

>
> > Signed-off-by: Khem Raj 
> > ---
> > v2: Rebased
> >
> >  .../recipes-graphics/pango/{pango_1.50.4.bb => pango_1.50.6.bb} | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >  rename meta/recipes-graphics/pango/{pango_1.50.4.bb => pango_1.50.6.bb} 
> > (94%)
> >
> > diff --git a/meta/recipes-graphics/pango/pango_1.50.4.bb 
> > b/meta/recipes-graphics/pango/pango_1.50.6.bb
> > similarity index 94%
> > rename from meta/recipes-graphics/pango/pango_1.50.4.bb
> > rename to meta/recipes-graphics/pango/pango_1.50.6.bb
> > index 0ea621bf670..b1b9054234d 100644
> > --- a/meta/recipes-graphics/pango/pango_1.50.4.bb
> > +++ b/meta/recipes-graphics/pango/pango_1.50.6.bb
> > @@ -20,7 +20,7 @@ GIR_MESON_DISABLE_FLAG = "disabled"
> >
> >  SRC_URI += "file://run-ptest"
> >
> > -SRC_URI[archive.sha256sum] = 
> > "f4ad63e87dc2b145300542a4fb004d07a9f91b34152fae0ddbe50ecdd851c162"
> > +SRC_URI[archive.sha256sum] = 
> > "a998bcf36881c3ac20495d40bceb304f4eaa9175bd2967c85656434cbdafe86a"
> >
> >  DEPENDS = "glib-2.0 glib-2.0-native fontconfig freetype virtual/libiconv 
> > cairo harfbuzz fribidi"
> >
> > --
> > 2.35.1
> >
>
> >
> > 
> >
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164374): 
https://lists.openembedded.org/g/openembedded-core/message/164374
Mute This Topic: https://lists.openembedded.org/mt/90384193/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Steve Sakoman
On Wed, Apr 13, 2022 at 11:41 AM Richard Purdie
 wrote:
>
> On Wed, 2022-04-13 at 11:39 -1000, Steve Sakoman wrote:
> > On Wed, Apr 13, 2022 at 9:05 AM Ralph Siemsen  
> > wrote:
> > >
> > > On Wed, Apr 13, 2022 at 2:19 PM Steve Sakoman  wrote:
> > >
> > > > Yes, and it appears they had a quite similar bug in the past!
> > > >
> > > > https://lists.debian.org/deity/2006/07/msg00074.html
> > >
> > > Interesting find... though it seems that is in a different sha256
> > > implementation than the one being used here ("Gifford").
> >
> > I did another experiment, where I disabled generation of the sha256
> > entries in Release (by adding --no-sha256 to the apt-ftparchive
> > command)
> >
> > As a result we get past this first hash mismatch in Release, but then
> > get later hash mismatches when it tries to download .debs.
> >
> > https://errors.yoctoproject.org/Errors/Details/654717/
> >
> > So it really does seem that apt sha256 generation is broken on
> > non-debian distros.
> >
> > > The other factor is that it behaves on ubuntu, but not fedora. Do the
> > > native packages get built with the host gcc (11.2 on fedora 35,
> > > whereas 9.3 on ubuntu 20.x)? Or does yocto also build a native
> > > toolchain to build host packages with?
> >
> > Perhaps Richard can answer this question!
>
> Native recipes are built using the host gcc so this could be host gcc 
> dependent.
> We do use buildtools-tarball on some hosts where the gcc is too old. You can 
> see
> what is used where in config.json in autobuilder-helper near the end.

The issue is happening on Fedora 35 and Alma 8, so no
buildtools-tarball in this case!

Steve

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164373): 
https://lists.openembedded.org/g/openembedded-core/message/164373
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Richard Purdie
On Wed, 2022-04-13 at 11:39 -1000, Steve Sakoman wrote:
> On Wed, Apr 13, 2022 at 9:05 AM Ralph Siemsen  
> wrote:
> > 
> > On Wed, Apr 13, 2022 at 2:19 PM Steve Sakoman  wrote:
> > 
> > > Yes, and it appears they had a quite similar bug in the past!
> > > 
> > > https://lists.debian.org/deity/2006/07/msg00074.html
> > 
> > Interesting find... though it seems that is in a different sha256
> > implementation than the one being used here ("Gifford").
> 
> I did another experiment, where I disabled generation of the sha256
> entries in Release (by adding --no-sha256 to the apt-ftparchive
> command)
> 
> As a result we get past this first hash mismatch in Release, but then
> get later hash mismatches when it tries to download .debs.
> 
> https://errors.yoctoproject.org/Errors/Details/654717/
> 
> So it really does seem that apt sha256 generation is broken on
> non-debian distros.
> 
> > The other factor is that it behaves on ubuntu, but not fedora. Do the
> > native packages get built with the host gcc (11.2 on fedora 35,
> > whereas 9.3 on ubuntu 20.x)? Or does yocto also build a native
> > toolchain to build host packages with?
> 
> Perhaps Richard can answer this question!

Native recipes are built using the host gcc so this could be host gcc dependent.
We do use buildtools-tarball on some hosts where the gcc is too old. You can see
what is used where in config.json in autobuilder-helper near the end.

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164372): 
https://lists.openembedded.org/g/openembedded-core/message/164372
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Steve Sakoman
On Wed, Apr 13, 2022 at 9:05 AM Ralph Siemsen  wrote:
>
> On Wed, Apr 13, 2022 at 2:19 PM Steve Sakoman  wrote:
>
> > Yes, and it appears they had a quite similar bug in the past!
> >
> > https://lists.debian.org/deity/2006/07/msg00074.html
>
> Interesting find... though it seems that is in a different sha256
> implementation than the one being used here ("Gifford").

I did another experiment, where I disabled generation of the sha256
entries in Release (by adding --no-sha256 to the apt-ftparchive
command)

As a result we get past this first hash mismatch in Release, but then
get later hash mismatches when it tries to download .debs.

https://errors.yoctoproject.org/Errors/Details/654717/

So it really does seem that apt sha256 generation is broken on
non-debian distros.

> The other factor is that it behaves on ubuntu, but not fedora. Do the
> native packages get built with the host gcc (11.2 on fedora 35,
> whereas 9.3 on ubuntu 20.x)? Or does yocto also build a native
> toolchain to build host packages with?

Perhaps Richard can answer this question!

Steve

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164371): 
https://lists.openembedded.org/g/openembedded-core/message/164371
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 04/12] recipetool: Change default paramter fallback_licenses of function split_pkg_licenses from None to []

2022-04-13 Thread Paul Eggleton
Hi Stefan

Firstly, thanks for the work extending and improving this. 

Secondly, apologies for dredging this up, but I just found this looking back
through the history for the release notes:

On Friday, 8 October 2021 20:42:20 NZST Stefan Herbrechtsmeier wrote:
> From: Stefan Herbrechtsmeier 
> 
> Signed-off-by: Stefan Herbrechtsmeier
>  ---
> 
> (no changes since v1)
> 
>  scripts/lib/recipetool/create.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/recipetool/create.py
> b/scripts/lib/recipetool/create.py index 83cf25d9b7..893980a5ce 100644
> --- a/scripts/lib/recipetool/create.py
> +++ b/scripts/lib/recipetool/create.py
> @@ -1134,7 +1134,7 @@ def guess_license(srctree, d):
> 
>  return licenses
> 
> -def split_pkg_licenses(licvalues, packages, outlines,
> fallback_licenses=None, pn='${PN}'): +def split_pkg_licenses(licvalues,
> packages, outlines, fallback_licenses=[], pn='${PN}'): """
>  Given a list of (license, path, md5sum) as returned by guess_license(),
> a dict of package name to path mappings, write out a set of

Note that setting a mutable type (e.g. an empty list) as a default for a
function parameter is not good practice in Python - see:

  
https://florimond.dev/en/posts/2018/08/python-mutable-defaults-are-the-source-of-all-evil/

I'm aware we have done this already in a few places - git grep "^def.*=\[\]" 
shows a few others that we probably ought to fix.

Paul




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164370): 
https://lists.openembedded.org/g/openembedded-core/message/164370
Mute This Topic: https://lists.openembedded.org/mt/86165224/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] license: add 'any_incompatible' function

2022-04-13 Thread Christopher Larson
On Wed, Apr 13, 2022 at 1:35 PM Peter Kjellerstedt <
peter.kjellerst...@axis.com> wrote:

> > -Original Message-
> > From: openembedded-core@lists.openembedded.org <
> openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie
> > Sent: den 13 april 2022 19:45
> > To: Christopher Larson ;
> openembedded-core@lists.openembedded.org
> > Cc: Christopher Larson 
> > Subject: Re: [OE-core] [PATCH v2] license: add 'any_incompatible'
> function
> >
> > On Wed, 2022-04-13 at 16:00 +, Christopher Larson wrote:
> > > This function returns True if any of the specified packages are
> skipped due to
> > > incompatible license.
> > >
> > > License exceptions are obeyed. The user may specify the package's
> license for
> > > cross-recipe checks.
> > >
> > > This allows for additions to packagegroups only for non-incompatible
> builds. For
> > > example:
> > >
> > > RDEPENDS_${PN} += "${@'dbench' if not any_incompatible(d,
> 'dbench', 'GPL-3.0-only') else ''}"
> > >
> > > Signed-off-by: Christopher Larson 
> > > ---
> > >  meta/classes/license.bbclass  | 38 +++
> > >  .../packagegroups/packagegroup-base.bb|  2 +
> > >  2 files changed, 40 insertions(+)
> > >
> > > v2 changes: fixed string packages logic, corrected reference to
> > > apply_pkg_license_exception, and avoided use of ${@} in the function
> docstring
> > > to avoid bitbake expanding it and recursing.
> > >
> > > diff --git a/meta/classes/license.bbclass
> b/meta/classes/license.bbclass
> > > index 0c637e966e..41993b7227 100644
> > > --- a/meta/classes/license.bbclass
> > > +++ b/meta/classes/license.bbclass
> > > @@ -320,6 +320,44 @@ def incompatible_license(d, dont_want_licenses,
> package=None):
> > >
> > >  return incompatible_pkg_license(d, dont_want_licenses, license)
> > >
> > > +def any_incompatible(d, packages, licensestring=None):
> > > +"""Return True if any of the packages are skipped due to
> incompatible license.
> > > +
> > > +License exceptions are obeyed. The user may specify the package's
> license
> > > +for cross-recipe checks.
> > > +
> > > +This allows for additions to packagegroups only for
> non-incompatible builds.
> > > +
> > > +For example: 'dbench' if not any_incompatible(d, 'dbench',
> 'GPL-3.0-only') else ''
> > > +"""
> > > +import oe.license
> > > +
> > > +if isinstance(packages, str):
> > > +packages = packages.split()
> > > +
> > > +bad_licenses = (d.getVar("INCOMPATIBLE_LICENSE") or "").split()
> > > +if not bad_licenses:
> > > +return False
> > > +bad_licenses = expand_wildcard_licenses(d, bad_licenses)
> > > +
> > > +if licensestring is None:
> > > +licensestring = d.getVar("LICENSE:%s" % package) if package
> else None
> > > +if not licensestring:
> > > +licensestring = d.getVar("LICENSE")
> > > +
> > > +exceptions = (d.getVar("INCOMPATIBLE_LICENSE_EXCEPTIONS") or
> "").split()
> > > +for pkg in packages:
> > > +remaining_bad_licenses =
> oe.license.apply_pkg_license_exception(
> > > +pkg, bad_licenses, exceptions
> > > +)
> > > +
> > > +incompatible_lic = incompatible_pkg_license(
> > > +d, remaining_bad_licenses, licensestring
> > > +)
> > > +if incompatible_lic:
> > > +return True
> > > +return False
> > > +
> > >  def check_license_flags(d):
> > >  """
> > >  This function checks if a recipe has any LICENSE_FLAGS that
> > > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb
> b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > index 7489ef61b0..1c97d03c21 100644
> > > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > @@ -14,6 +14,8 @@ PACKAGES = ' \
> > >  packagegroup-distro-base \
> > >  packagegroup-machine-base \
> > >  \
> > > +${@"dbench" if not any_incompatible(d, "dbench",
> "GPL-3.0-only") else ""} \
>
> This usage seems error prone at best. What if the license for dbench
> is changed?
>

It is, but we can't know other recipes licenses, so the options are
limited. It's also not the only similar thing we do along these lines. More
than once we've had to exclude something from a packagegroup based on the
current context and our knowledge that it's not buildable in this context,
such as knowing the required distro features of the recipe or its
unsupported architectures or COMPATIBLE_MACHINE.

I don't love it, but I don't see a lot of alternatives. RRECOMMENDS is an
interesting idea, but I don't believe it works as you'd hope today, and
would presumably require use of BAD_RECOMMENDATIONS for pickier images. I'm
certainly open to the alternatives on this, but in the meantime some
images/packagegroups just aren't buildable at all for incompatible_license
builds right now without risking layer-inclusion-based 

[OE-core] [PATCH v4 2/2] package_manager: fix missing dependency on gnupg when signing deb package feeds

2022-04-13 Thread Ferry Toth
From: Ferry Toth 

When signing the deb package feed gpg tools are a soft requirement. If 
gnupg-native
is not declared a dependancy the version from hosttools is used. Unfortunately 
the
gpg-agent version from Ubuntu 16.04 on the autobuilders is incompatible with 
the package_index task
and fails during oe-selftest. Fix by making gnupg-native a dependency.

Fixes: 0b4231b5 "package_manager: sign DEB package feeds"
Reported-by: Alexandre Belloni 
Suggested-by: Richard Purdie 
Signed-off-by: Ferry Toth 
---
 meta/classes/sign_package_feed.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/sign_package_feed.bbclass 
b/meta/classes/sign_package_feed.bbclass
index 16bcd147aa..f1504c2225 100644
--- a/meta/classes/sign_package_feed.bbclass
+++ b/meta/classes/sign_package_feed.bbclass
@@ -27,6 +27,7 @@ inherit sanity
 PACKAGE_FEED_SIGN = '1'
 PACKAGE_FEED_GPG_BACKEND ?= 'local'
 PACKAGE_FEED_GPG_SIGNATURE_TYPE ?= 'ASC'
+PACKAGEINDEXDEPS += "gnupg-native:do_populate_sysroot"
 
 # Make feed signing key to be present in rootfs
 FEATURE_PACKAGES_package-management:append = " signing-keys-packagefeed"
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164368): 
https://lists.openembedded.org/g/openembedded-core/message/164368
Mute This Topic: https://lists.openembedded.org/mt/90450459/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v4 1/2] apt: add apt selftest to test signed package feeds

2022-04-13 Thread Ferry Toth
From: Ferry Toth 

Since Gatesgarth apt (1.8.2) has become more strict and doesn’t allow unsigned 
repositories by default.
Currently when building images this requirement is worked around by using 
[allow-insecure=yes] and
equivalently when performing selftest.

Patches "gpg-sign: Add parameters to gpg signature function" and 
"package_manager: sign DEB package feeds"
enable signed DEB package feeds. This patch adds a runtime test for apt derived 
from the test_testimage_dnf
test. It creates a signed deb package feed, runs a qemu image to install the 
key and performs some package
management. To be able to install the key the gnupg package is added to the 
testimage.

Signed-off-by: Ferry Toth 
---
 meta/lib/oeqa/runtime/cases/apt.py   | 38 
 meta/lib/oeqa/selftest/cases/runtime_test.py | 38 
 2 files changed, 69 insertions(+), 7 deletions(-)

diff --git a/meta/lib/oeqa/runtime/cases/apt.py 
b/meta/lib/oeqa/runtime/cases/apt.py
index 53745df93f..574a34f148 100644
--- a/meta/lib/oeqa/runtime/cases/apt.py
+++ b/meta/lib/oeqa/runtime/cases/apt.py
@@ -21,7 +21,7 @@ class AptRepoTest(AptTest):
 
 @classmethod
 def setUpClass(cls):
-service_repo = os.path.join(cls.tc.td['DEPLOY_DIR_DEB'], 'all')
+service_repo = os.path.join(cls.tc.td['DEPLOY_DIR_DEB'], '')
 cls.repo_server = HTTPService(service_repo,
   '0.0.0.0', 
port=cls.tc.target.server_port,
   logger=cls.tc.logger)
@@ -34,20 +34,44 @@ class AptRepoTest(AptTest):
 def setup_source_config_for_package_install(self):
 apt_get_source_server = 'http://%s:%s/' % (self.tc.target.server_ip, 
self.repo_server.port)
 apt_get_sourceslist_dir = '/etc/apt/'
-self.target.run('cd %s; echo deb [ allow-insecure=yes ] %s ./ > 
sources.list' % (apt_get_sourceslist_dir, apt_get_source_server))
+self.target.run('cd %s; echo deb [ allow-insecure=yes ] %s/all ./ > 
sources.list' % (apt_get_sourceslist_dir, apt_get_source_server))
+
+def setup_source_config_for_package_install_signed(self):
+apt_get_source_server = 'http:\/\/%s:%s' % (self.tc.target.server_ip, 
self.repo_server.port)
+apt_get_sourceslist_dir = '/etc/apt/'
+self.target.run("cd %s; cp sources.list sources.list.bak; sed -i 
's/\[trusted=yes\] http:\/\/bogus_ip:bogus_port/%s/g' sources.list" % 
(apt_get_sourceslist_dir, apt_get_source_server))
 
 def cleanup_source_config_for_package_install(self):
 apt_get_sourceslist_dir = '/etc/apt/'
 self.target.run('cd %s; rm sources.list' % (apt_get_sourceslist_dir))
 
+def cleanup_source_config_for_package_install_signed(self):
+apt_get_sourceslist_dir = '/etc/apt/'
+self.target.run('cd %s; mv sources.list.bak sources.list' % 
(apt_get_sourceslist_dir))
+
+def setup_key(self):
+# the key is found on the target /etc/pki/packagefeed-gpg/
+# named PACKAGEFEED-GPG-KEY-poky-branch
+self.target.run('cd %s; apt-key add P*' % ('/etc/pki/packagefeed-gpg'))
+
 @skipIfNotFeature('package-management',
   'Test requires package-management to be in 
IMAGE_FEATURES')
 @skipIfNotDataVar('IMAGE_PKGTYPE', 'deb',
   'DEB is not the primary package manager')
 @OEHasPackage(['apt'])
 def test_apt_install_from_repo(self):
-self.setup_source_config_for_package_install()
-self.pkg('update')
-self.pkg('remove --yes run-postinsts-dev')
-self.pkg('install --yes --allow-unauthenticated run-postinsts-dev')
-self.cleanup_source_config_for_package_install()
+if not self.tc.td.get('PACKAGE_FEED_GPG_NAME'):
+self.setup_source_config_for_package_install()
+self.pkg('update')
+self.pkg('remove --yes run-postinsts-dev')
+self.pkg('install --yes --allow-unauthenticated run-postinsts-dev')
+self.cleanup_source_config_for_package_install()
+else:
+# when we are here a key has been set to sign the package feed and
+# public key and gnupg installed on the image by test_testimage_apt
+self.setup_source_config_for_package_install_signed()
+self.setup_key()
+self.pkg('update')
+self.pkg('install --yes run-postinsts-dev')
+self.pkg('remove --yes run-postinsts-dev')
+self.cleanup_source_config_for_package_install_signed()
diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py 
b/meta/lib/oeqa/selftest/cases/runtime_test.py
index 2ad89490fc..3ece617cb0 100644
--- a/meta/lib/oeqa/selftest/cases/runtime_test.py
+++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
@@ -162,6 +162,44 @@ class TestImage(OESelftestTestCase):
 bitbake('core-image-full-cmdline socat')
 bitbake('-c testimage core-image-full-cmdline')
 
+def test_testimage_apt(self):
+"""
+   

[OE-core] package_manager: support for signed DEB package feeds

2022-04-13 Thread Ferry Toth
[PATCH v4 1/2] apt: add apt selftest to test signed package feeds
[PATCH v4 2/2] package_manager: fix missing dependency on gnupg when

Since Gatesgarth apt (1.8.2) has become more strict and doesn’t allow unsigned 
repositories by default.
Currently when building images this requirement is worked around by using 
[allow-insecure=yes] and
equivalently when performing selftest.

Patches "gpg-sign: Add parameters to gpg signature function" and 
"package_manager: sign deb package feeds"
(already in master) enable signed deb package feeds. When called from 
`oe-selftest -r runtime_test.TestImage.test_testimage_apt` this patch adds a 
runtime test for apt 
derived from the test_testimage_dnf test. It creates a signed deb package feed, 
runs a qemu 
image to install the key and performs some package management. To be able to 
install the key
the gnupg package is added to the testimage.

Changes in V4:
 - Add fix to make gnupg-native a dependency else hosttools is used and 
   `oe-selftest -r runtime_test.TestImage.test_testimage_apt` fails on Ubuntu 
16.04 used 
   on the autobuilder (Alexandre Belloni)

Changes in V3:
 - When called from `bitbake core-image-sato -c testimage` package feed is 
unsigned. Auto-detect
   this case and behave as before (Richard Purdie)

Changes in V2:
 - Added runtime test for signed deb package feeds (Richard Purdie)


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164366): 
https://lists.openembedded.org/g/openembedded-core/message/164366
Mute This Topic: https://lists.openembedded.org/mt/90404956/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] license: add 'any_incompatible' function

2022-04-13 Thread Peter Kjellerstedt
> -Original Message-
> From: openembedded-core@lists.openembedded.org 
>  On Behalf Of Richard Purdie
> Sent: den 13 april 2022 19:45
> To: Christopher Larson ; 
> openembedded-core@lists.openembedded.org
> Cc: Christopher Larson 
> Subject: Re: [OE-core] [PATCH v2] license: add 'any_incompatible' function
> 
> On Wed, 2022-04-13 at 16:00 +, Christopher Larson wrote:
> > This function returns True if any of the specified packages are skipped due 
> > to
> > incompatible license.
> >
> > License exceptions are obeyed. The user may specify the package's license 
> > for
> > cross-recipe checks.
> >
> > This allows for additions to packagegroups only for non-incompatible 
> > builds. For
> > example:
> >
> > RDEPENDS_${PN} += "${@'dbench' if not any_incompatible(d, 'dbench', 
> > 'GPL-3.0-only') else ''}"
> >
> > Signed-off-by: Christopher Larson 
> > ---
> >  meta/classes/license.bbclass  | 38 +++
> >  .../packagegroups/packagegroup-base.bb|  2 +
> >  2 files changed, 40 insertions(+)
> >
> > v2 changes: fixed string packages logic, corrected reference to
> > apply_pkg_license_exception, and avoided use of ${@} in the function 
> > docstring
> > to avoid bitbake expanding it and recursing.
> >
> > diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
> > index 0c637e966e..41993b7227 100644
> > --- a/meta/classes/license.bbclass
> > +++ b/meta/classes/license.bbclass
> > @@ -320,6 +320,44 @@ def incompatible_license(d, dont_want_licenses, 
> > package=None):
> >
> >  return incompatible_pkg_license(d, dont_want_licenses, license)
> >
> > +def any_incompatible(d, packages, licensestring=None):
> > +"""Return True if any of the packages are skipped due to incompatible 
> > license.
> > +
> > +License exceptions are obeyed. The user may specify the package's 
> > license
> > +for cross-recipe checks.
> > +
> > +This allows for additions to packagegroups only for non-incompatible 
> > builds.
> > +
> > +For example: 'dbench' if not any_incompatible(d, 'dbench', 
> > 'GPL-3.0-only') else ''
> > +"""
> > +import oe.license
> > +
> > +if isinstance(packages, str):
> > +packages = packages.split()
> > +
> > +bad_licenses = (d.getVar("INCOMPATIBLE_LICENSE") or "").split()
> > +if not bad_licenses:
> > +return False
> > +bad_licenses = expand_wildcard_licenses(d, bad_licenses)
> > +
> > +if licensestring is None:
> > +licensestring = d.getVar("LICENSE:%s" % package) if package else 
> > None
> > +if not licensestring:
> > +licensestring = d.getVar("LICENSE")
> > +
> > +exceptions = (d.getVar("INCOMPATIBLE_LICENSE_EXCEPTIONS") or 
> > "").split()
> > +for pkg in packages:
> > +remaining_bad_licenses = oe.license.apply_pkg_license_exception(
> > +pkg, bad_licenses, exceptions
> > +)
> > +
> > +incompatible_lic = incompatible_pkg_license(
> > +d, remaining_bad_licenses, licensestring
> > +)
> > +if incompatible_lic:
> > +return True
> > +return False
> > +
> >  def check_license_flags(d):
> >  """
> >  This function checks if a recipe has any LICENSE_FLAGS that
> > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb 
> > b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > index 7489ef61b0..1c97d03c21 100644
> > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > @@ -14,6 +14,8 @@ PACKAGES = ' \
> >  packagegroup-distro-base \
> >  packagegroup-machine-base \
> >  \
> > +${@"dbench" if not any_incompatible(d, "dbench", 
> > "GPL-3.0-only") else ""} \

This usage seems error prone at best. What if the license for dbench 
is changed?

Also, the way I would prefer to do something like the above (assuming you 
meant to include it as a dependency in RDEPENDS:${PN} rather than PACKAGES) 
would be to instead unconditionally add it to RRECOMMENDS:${PN}. Then 
the normal licensing support should skip the package if you have the 
incompatible license globally configured, but since it is only a 
recommendation, that should not be a problem. 

However, one thing I just realized that isn't working is if you have a 
recommendation on a package and then only configure incompatible licenses 
per image. This is normally the preferred way to handle incompatible 
licenses as you can determine per image if a package should be allowed to 
be installed or not. But because the installation of the packages is 
handled by the package manager, and the license compliance is handled 
later by bitbake, there is currently nothing telling the package manager 
to skip the installation of the unwanted package due to its license, and 
instead there is an error because bitbake sees that it was installed. :(

> > +\
> >  

Re: [OE-core] [PATCH 2/2] buildtools: Add standalone make tarball

2022-04-13 Thread Richard Purdie
On Wed, 2022-04-13 at 12:21 -0700, Andre McCurdy wrote:
> On Wed, Apr 13, 2022 at 10:58 AM Richard Purdie
>  wrote:
> > 
> > Some versions of make have bugs. Add a way to provide a make tarball
> > that can be used on it's own in these cases.
> > 
> > Signed-off-by: Richard Purdie 
> > ---
> >  meta/conf/distro/include/maintainers.inc |  1 +
> >  .../recipes-core/meta/buildtools-make-tarball.bb | 16 
> >  2 files changed, 17 insertions(+)
> >  create mode 100644 meta/recipes-core/meta/buildtools-make-tarball.bb
> > 
> > diff --git a/meta/conf/distro/include/maintainers.inc 
> > b/meta/conf/distro/include/maintainers.inc
> > index 2c5e7308275..09a75933e26 100644
> > --- a/meta/conf/distro/include/maintainers.inc
> > +++ b/meta/conf/distro/include/maintainers.inc
> > @@ -84,6 +84,7 @@ RECIPE_MAINTAINER:pn-builder = "Richard Purdie 
> >  >  RECIPE_MAINTAINER:pn-buildtools-extended-tarball = "Richard Purdie 
> > "
> >  RECIPE_MAINTAINER:pn-buildtools-tarball = "Richard Purdie 
> > "
> >  RECIPE_MAINTAINER:pn-buildtools-docs-tarball = "Richard Purdie 
> > "
> > +RECIPE_MAINTAINER:pn-buildtools-make-tarball = "Richard Purdie 
> > "
> >  RECIPE_MAINTAINER:pn-busybox = "Andrej Valek "
> >  RECIPE_MAINTAINER:pn-busybox-inittab = "Denys Dmytriyenko 
> > "
> >  RECIPE_MAINTAINER:pn-bzip2 = "Denys Dmytriyenko "
> > diff --git a/meta/recipes-core/meta/buildtools-make-tarball.bb 
> > b/meta/recipes-core/meta/buildtools-make-tarball.bb
> > new file mode 100644
> > index 000..e278f682719
> > --- /dev/null
> > +++ b/meta/recipes-core/meta/buildtools-make-tarball.bb
> > @@ -0,0 +1,16 @@
> > +require recipes-core/meta/buildtools-tarball.bb
> > +
> > +DESCRIPTION = "SDK type target for building a standalone tarball 
> > containing build-essentials, python3, chrpath, \
> > +   make, git and tar. The tarball can be used to run bitbake 
> > builds on systems which don't meet the \
> > +   usual version requirements and have ancient compilers."
> 
> Over enthusiastic copy and paste?

Yes, well spotted. I'll fix that on the branch, thanks.

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164364): 
https://lists.openembedded.org/g/openembedded-core/message/164364
Mute This Topic: https://lists.openembedded.org/mt/90446806/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 1/2] ncurses: use COPYING file

2022-04-13 Thread Peter Kjellerstedt
> -Original Message-
> From: openembedded-core@lists.openembedded.org  c...@lists.openembedded.org> On Behalf Of Konrad Weihmann
> Sent: den 13 april 2022 19:09
> To: openembedded-core@lists.openembedded.org
> Cc: Konrad Weihmann 
> Subject: [OE-core] [PATCH 1/2] ncurses: use COPYING file
> 
> which has the same info as the in-file header used in before

That's not quite true. Please drop the last three lines of the COPYING 
file that contains editor configuration and a CVS $Id$.

Some of us use the output from LIC_FILES_CHKSUM to produce a combined 
license text for our products and any non-license related information 
that is included then becomes more or less problematic.

> 
> Signed-off-by: Konrad Weihmann 
> ---
>  meta/recipes-core/ncurses/ncurses.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-
> core/ncurses/ncurses.inc
> index a0ecd8a80b..8d374a1522 100644
> --- a/meta/recipes-core/ncurses/ncurses.inc
> +++ b/meta/recipes-core/ncurses/ncurses.inc
> @@ -2,7 +2,7 @@ SUMMARY = "The New Curses library"
>  DESCRIPTION = "SVr4 and XSI-Curses compatible curses library and terminfo
> tools including tic, infocmp, captoinfo. Supports color, multiple
> highlights, forms-drawing characters, and automatic recognition of keypad
> and function-key sequences. Extensions include resizable windows and mouse
> support on both xterm and Linux console using the gpm library."
>  HOMEPAGE = "http://www.gnu.org/software/ncurses/ncurses.html;
>  LICENSE = "MIT"
> -LIC_FILES_CHKSUM =
> "file://ncurses/base/version.c;beginline=1;endline=27;md5=5526f2f3a29edc95
> 538b368a4771edda"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=f852913c5d988a5f5a2f1df7ba7ee893"
>  SECTION = "libs"
>  DEPENDS = "ncurses-native"
>  DEPENDS:class-native = ""
> --
> 2.25.1

//Peter


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164363): 
https://lists.openembedded.org/g/openembedded-core/message/164363
Mute This Topic: https://lists.openembedded.org/mt/90445642/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 2/2] buildtools: Add standalone make tarball

2022-04-13 Thread Andre McCurdy
On Wed, Apr 13, 2022 at 10:58 AM Richard Purdie
 wrote:
>
> Some versions of make have bugs. Add a way to provide a make tarball
> that can be used on it's own in these cases.
>
> Signed-off-by: Richard Purdie 
> ---
>  meta/conf/distro/include/maintainers.inc |  1 +
>  .../recipes-core/meta/buildtools-make-tarball.bb | 16 
>  2 files changed, 17 insertions(+)
>  create mode 100644 meta/recipes-core/meta/buildtools-make-tarball.bb
>
> diff --git a/meta/conf/distro/include/maintainers.inc 
> b/meta/conf/distro/include/maintainers.inc
> index 2c5e7308275..09a75933e26 100644
> --- a/meta/conf/distro/include/maintainers.inc
> +++ b/meta/conf/distro/include/maintainers.inc
> @@ -84,6 +84,7 @@ RECIPE_MAINTAINER:pn-builder = "Richard Purdie 
>   RECIPE_MAINTAINER:pn-buildtools-extended-tarball = "Richard Purdie 
> "
>  RECIPE_MAINTAINER:pn-buildtools-tarball = "Richard Purdie 
> "
>  RECIPE_MAINTAINER:pn-buildtools-docs-tarball = "Richard Purdie 
> "
> +RECIPE_MAINTAINER:pn-buildtools-make-tarball = "Richard Purdie 
> "
>  RECIPE_MAINTAINER:pn-busybox = "Andrej Valek "
>  RECIPE_MAINTAINER:pn-busybox-inittab = "Denys Dmytriyenko "
>  RECIPE_MAINTAINER:pn-bzip2 = "Denys Dmytriyenko "
> diff --git a/meta/recipes-core/meta/buildtools-make-tarball.bb 
> b/meta/recipes-core/meta/buildtools-make-tarball.bb
> new file mode 100644
> index 000..e278f682719
> --- /dev/null
> +++ b/meta/recipes-core/meta/buildtools-make-tarball.bb
> @@ -0,0 +1,16 @@
> +require recipes-core/meta/buildtools-tarball.bb
> +
> +DESCRIPTION = "SDK type target for building a standalone tarball containing 
> build-essentials, python3, chrpath, \
> +   make, git and tar. The tarball can be used to run bitbake 
> builds on systems which don't meet the \
> +   usual version requirements and have ancient compilers."

Over enthusiastic copy and paste?

> +SUMMARY = "Standalone tarball for running builds on systems with inadequate 
> software and ancient compilers"
> +LICENSE = "MIT"
> +
> +# Add nativesdk equivalent of build-essentials
> +TOOLCHAIN_HOST_TASK = "\
> +nativesdk-sdk-provides-dummy \
> +nativesdk-make \
> +"
> +TOOLCHAIN_OUTPUTNAME = 
> "${SDK_ARCH}-buildtools-make-nativesdk-standalone-${DISTRO_VERSION}"
> +
> +SDK_TITLE = "Make build tool"
> --
> 2.32.0
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164362): 
https://lists.openembedded.org/g/openembedded-core/message/164362
Mute This Topic: https://lists.openembedded.org/mt/90446806/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] git: correct license

2022-04-13 Thread Peter Kjellerstedt
> -Original Message-
> From: openembedded-core@lists.openembedded.org  c...@lists.openembedded.org> On Behalf Of Konrad Weihmann
> Sent: den 13 april 2022 18:59
> To: Jose Quaresma 
> Cc: OE-core 
> Subject: Re: [OE-core] [PATCH] git: correct license
> 
> On 13.04.22 18:56, Jose Quaresma wrote:
> > Hi
> >
> > Konrad Weihmann mailto:kweihm...@outlook.com>>
> > escreveu no dia quarta, 13/04/2022 à(s) 17:34:
> >
> > by default git pulls in several code fragments not being licensed
> > under just GPL-2.0-only.
> > In fact obstack and poll are taken from glib, being licensed
> > under GPL-2.0-or-later - as this includes GPL-2.0-only, use this instead

No, it's the other way around. You can use GPL-2.0-or-later as 
GPL-2.0-only, but you *cannot* use GPL-2.0-only as GPL-2.0-or-later 
without relicensing the code, and, unless you are the owner of the 
code, you cannot do that. 

However, it is probably better to be explicit and actually state the 
LICENSE as "GPL-2.0-only & GPL-2.0-or-later & ..." since those are 
the licenses that are actually being used.

> >
> > Furthermore
> > reftable being BSD-3-Clause
> > sha1dc and inet_ntop being MIT
> > netmalloc being Bosst-1.0 aka BSL-1.0
> > regex being LGPL-2.1-or-later
> >
> > Signed-off-by: Konrad Weihmann  > >
> > ---
> >   meta/recipes-devtools/git/git_2.35.1.bb  |
> > 13 +++--
> >   1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/git/git_2.35.1.bb
> >  b/meta/recipes-devtools/git/git_2.35.1.bb
> > 
> > index 47c2211864..f8756b6dec 100644
> > --- a/meta/recipes-devtools/git/git_2.35.1.bb 
> > +++ b/meta/recipes-devtools/git/git_2.35.1.bb 
> > @@ -2,7 +2,7 @@ SUMMARY = "Distributed version control system"
> >   HOMEPAGE = "http://git-scm.com "
> >   DESCRIPTION = "Git is a free and open source distributed version 
> > control system designed to handle everything from small to very large 
> > projects with speed and efficiency."
> >   SECTION = "console/utils"
> > -LICENSE = "GPL-2.0-only"
> > +LICENSE = "GPL-2.0-or-later & BSD-3-Clause & MIT & BSL-1.0 & 
> > LGPL-2.1-or-later"
> >   DEPENDS = "openssl zlib"
> >
> >   PROVIDES:append:class-native = " git-replacement-native"
> > @@ -14,7 +14,16 @@ SRC_URI = 
> > "${KERNELORG_MIRROR}/software/scm/git/git-${PV}.tar.gz;name=tarball \
> >
> >   S = "${WORKDIR}/git-${PV}"
> >
> > -LIC_FILES_CHKSUM = 
> > "file://COPYING;md5=7c0d7ef03a7eb04ce795b0f60e68e7e1"
> > +LIC_FILES_CHKSUM = "\
> > +       file://COPYING;md5=7c0d7ef03a7eb04ce795b0f60e68e7e1 \
> > +       file://reftable/LICENSE;md5=1a6424cafc4c9c88c689848e165af33b \
> > +       file://sha1dc/LICENSE.txt;md5=9bbe4c990a9e98ea4b98ef5d3bcb8a7a \
> > +   
> > file://compat/nedmalloc/License.txt;md5=e4224ccaecb14d942c71d31bef20d78c \
> > +   
> > file://compat/inet_ntop.c;md5=76593c6f74e8ced5b24520175688d59b;endline=16 \
> > +   
> > file://compat/obstack.h;md5=08ad25fee5428cd879ceef451ce3a22e;endline=18 \
> > +   
> > file://compat/poll/poll.h;md5=9fc00170a53b8e3e52157c91ac688dd1;endline=19 \
> > +   
> > file://compat/regex/regex.h;md5=30cc8af0e6f0f8a25acec6d8783bb763;beginline=4;endline=22
> >  \
> > +"
> >
> >
> > I don't know if it is possible but if we can add a compat PACKAGECONFIG
> > will be great
> > so we can disable this part which simplifies a little the license.
> 
> That would be indeed nice to have - from my understanding of the
> makefile those are build unconditionally, so it would require a upstream
> work first I guess.
> 
> For now my patch is just reflecting what is actually used
> 
> > Jose
> >
> >   CVE_PRODUCT = "git-scm:git"
> >
> > --
> > 2.25.1
> > --
> > Best regards,
> >
> > José Quaresma

//Peter


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164361): 
https://lists.openembedded.org/g/openembedded-core/message/164361
Mute This Topic: https://lists.openembedded.org/mt/90444706/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Steve Sakoman
On Wed, Apr 13, 2022 at 7:37 AM Steve Sakoman  wrote:
>
> On Wed, Apr 13, 2022 at 6:41 AM Mike Crowe  wrote:
> >
> > On Wednesday 13 April 2022 at 06:02:22 -1000, Steve Sakoman wrote:
> > > Both runs completed and I'm still seeing success without the zlib patch:
> > >
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5069
> > >
> > > and failure with the patch:
> > >
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5070
> >
> > I'm certainly no expert with the autobuilder, but it looks like nothing was
> > actually compiled for both of those builds - everything came from the
> > sstate cache.
> >
> > I believe that Ralph's reproduction of the test failure without the zlib
> > patch was from a complete rebuild without anything coming from the sstate
> > cache.
> >
> > I suspect that if a PR bump or something similar that causes zlib and all
> > its reverse dependencies to be built were tested on top of the commit used
> > for build 5069 then the test failure would occur then as well and
> > exonerate the zlib patch.
>
> A valid point, let's see what happens with a PR bump:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5072
>
> I see plenty of rebuilds in process . . .

As you predicted, rebuilding zlib (and all dependencies) with a PR
bump did indeed result in the same failure, exonerating the zlib CVE
patch.

So it really does appear that we are chasing a bug in the native
apt-ftparchive command on fedora-35 (and likely alma-8 since I've seen
the error there too)

Steve

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164360): 
https://lists.openembedded.org/g/openembedded-core/message/164360
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Ralph Siemsen
On Wed, Apr 13, 2022 at 2:19 PM Steve Sakoman  wrote:

> Yes, and it appears they had a quite similar bug in the past!
>
> https://lists.debian.org/deity/2006/07/msg00074.html

Interesting find... though it seems that is in a different sha256
implementation than the one being used here ("Gifford").

The other factor is that it behaves on ubuntu, but not fedora. Do the
native packages get built with the host gcc (11.2 on fedora 35,
whereas 9.3 on ubuntu 20.x)? Or does yocto also build a native
toolchain to build host packages with?

Ralph

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164359): 
https://lists.openembedded.org/g/openembedded-core/message/164359
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] libbsd: upgrade 0.11.5 -> 0.11.6

2022-04-13 Thread Alexandre Belloni via lists.openembedded.org
Hello,

I fixed it up but this is now the third time this happens. Your patch
has a declared charset of 'y' which is not a thing and git am fails
with:

error: cannot convert from y to UTF-8
fatal: could not parse patch

You once again got the following prompt:

The following files are 8bit, but do not declare a Content-Transfer-Encoding.
something.patch
Which 8bit encoding should I declare [UTF-8]?

At that point, you pressed y but you should simply press enter. Please
remember to do so next time.

On 08/04/2022 04:49:59+0800, wangmy wrote:
> License-Update:
> -  Copyright year updated to 2022
> -  License ISC changed as following:
>remove "src/arc4random_openbsd.h" from Files
>add "test/explicit_bzero.c" and "test/strtonum.c" to Files
>add "Copyright © 2004 Otto Moerbeek "
>add "Copyright © 2014 Google Inc."
> 
> Signed-off-by: Wang Mingyu 
> ---
>  .../libbsd/{libbsd_0.11.5.bb => libbsd_0.11.6.bb} | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>  rename meta/recipes-support/libbsd/{libbsd_0.11.5.bb => libbsd_0.11.6.bb} 
> (90%)
> 
> diff --git a/meta/recipes-support/libbsd/libbsd_0.11.5.bb 
> b/meta/recipes-support/libbsd/libbsd_0.11.6.bb
> similarity index 90%
> rename from meta/recipes-support/libbsd/libbsd_0.11.5.bb
> rename to meta/recipes-support/libbsd/libbsd_0.11.6.bb
> index bb8766a070..74fc8ef4e5 100644
> --- a/meta/recipes-support/libbsd/libbsd_0.11.5.bb
> +++ b/meta/recipes-support/libbsd/libbsd_0.11.6.bb
> @@ -29,12 +29,12 @@ HOMEPAGE = "https://libbsd.freedesktop.org/wiki/;
>  # License: public-domain-Colin-Plumb
>  LICENSE = "BSD-3-Clause & BSD-4-Clause & ISC & PD"
>  LICENSE:${PN} = "BSD-3-Clause & ISC & PD"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=0b31944ca2c1075410a30f0c17379d3b"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=c2c635b94c8dcd3593f53e10fa8a499e"
>  SECTION = "libs"
> 
>  SRC_URI = "https://libbsd.freedesktop.org/releases/${BPN}-${PV}.tar.xz;
> 
> -SRC_URI[sha256sum] = 
> "1a9c952525635c1bb6770cb22e969b938d8e6a9d7912362b98ee8370599b0efd"
> +SRC_URI[sha256sum] = 
> "19b38f3172eaf693e6e1c68714636190c7e48851e45224d720b3b5bc0499b5df"
> 
>  inherit autotools pkgconfig
> 
> --
> 2.25.1
> 

> 
> 
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164358): 
https://lists.openembedded.org/g/openembedded-core/message/164358
Mute This Topic: https://lists.openembedded.org/mt/90374438/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Steve Sakoman
On Wed, Apr 13, 2022 at 8:02 AM Ralph Siemsen  wrote:
>
> On Wed, Apr 13, 2022 at 12:41 PM Mike Crowe  wrote:
> >
> > I believe that Ralph's reproduction of the test failure without the zlib
> > patch was from a complete rebuild without anything coming from the sstate
> > cache.
>
> Yes, just confirming the above. I wanted to be certain there was
> nothing left-over from a previous build, so I nuked everything except
> for downloads and my local.conf.
>
> I am quite certain the problem is with apt-ftparchive command, which
> is what generates the md5/sha sums in the Release file. It seems to
> behave differently under Fedora versus Ubuntu. Only the SHA256 is
> affected. It is worth noting that apt includes its own sha calculation
> code, they are not calling out to "sha256sum" or using an existing
> library.

Yes, and it appears they had a quite similar bug in the past!

https://lists.debian.org/deity/2006/07/msg00074.html

Bug#378183: apt: All SHA256 hashes generated/used by APT are wrong"

Steve


> Was busy with some other things this AM but am going to dive into
> apt-ftparchive source code next (which is C++, ugh...).
>
> Ralph

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164357): 
https://lists.openembedded.org/g/openembedded-core/message/164357
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] license: add 'any_incompatible' function

2022-04-13 Thread Christopher Larson
It’s just an example, but you’re right, I’ll change to a better one. Thanks!

--
Christopher Larson
chris_lar...@mentor.com, chris.lar...@siemens.com, kerg...@gmail.com
Principal Software Engineer, Embedded Linux Solutions, Siemens Digital 
Industries Software
On Apr 13, 2022, 10:44 AM -0700, Richard Purdie 
, wrote:
> On Wed, 2022-04-13 at 16:00 +, Christopher Larson wrote:
> > This function returns True if any of the specified packages are skipped due 
> > to
> > incompatible license.
> >
> > License exceptions are obeyed. The user may specify the package's license 
> > for
> > cross-recipe checks.
> >
> > This allows for additions to packagegroups only for non-incompatible 
> > builds. For
> > example:
> >
> > RDEPENDS_${PN} += "${@'dbench' if not any_incompatible(d, 'dbench', 
> > 'GPL-3.0-only') else ''}"
> >
> > Signed-off-by: Christopher Larson 
> > ---
> > meta/classes/license.bbclass | 38 +++
> > .../packagegroups/packagegroup-base.bb | 2 +
> > 2 files changed, 40 insertions(+)
> >
> > v2 changes: fixed string packages logic, corrected reference to
> > apply_pkg_license_exception, and avoided use of ${@} in the function 
> > docstring
> > to avoid bitbake expanding it and recursing.
> >
> > diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
> > index 0c637e966e..41993b7227 100644
> > --- a/meta/classes/license.bbclass
> > +++ b/meta/classes/license.bbclass
> > @@ -320,6 +320,44 @@ def incompatible_license(d, dont_want_licenses, 
> > package=None):
> >
> > return incompatible_pkg_license(d, dont_want_licenses, license)
> >
> > +def any_incompatible(d, packages, licensestring=None):
> > + """Return True if any of the packages are skipped due to incompatible 
> > license.
> > +
> > + License exceptions are obeyed. The user may specify the package's license
> > + for cross-recipe checks.
> > +
> > + This allows for additions to packagegroups only for non-incompatible 
> > builds.
> > +
> > + For example: 'dbench' if not any_incompatible(d, 'dbench', 
> > 'GPL-3.0-only') else ''
> > + """
> > + import oe.license
> > +
> > + if isinstance(packages, str):
> > + packages = packages.split()
> > +
> > + bad_licenses = (d.getVar("INCOMPATIBLE_LICENSE") or "").split()
> > + if not bad_licenses:
> > + return False
> > + bad_licenses = expand_wildcard_licenses(d, bad_licenses)
> > +
> > + if licensestring is None:
> > + licensestring = d.getVar("LICENSE:%s" % package) if package else None
> > + if not licensestring:
> > + licensestring = d.getVar("LICENSE")
> > +
> > + exceptions = (d.getVar("INCOMPATIBLE_LICENSE_EXCEPTIONS") or "").split()
> > + for pkg in packages:
> > + remaining_bad_licenses = oe.license.apply_pkg_license_exception(
> > + pkg, bad_licenses, exceptions
> > + )
> > +
> > + incompatible_lic = incompatible_pkg_license(
> > + d, remaining_bad_licenses, licensestring
> > + )
> > + if incompatible_lic:
> > + return True
> > + return False
> > +
> > def check_license_flags(d):
> > """
> > This function checks if a recipe has any LICENSE_FLAGS that
> > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb 
> > b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > index 7489ef61b0..1c97d03c21 100644
> > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > @@ -14,6 +14,8 @@ PACKAGES = ' \
> > packagegroup-distro-base \
> > packagegroup-machine-base \
> > \
> > + ${@"dbench" if not any_incompatible(d, "dbench", "GPL-3.0-only") else ""} 
> > \
> > + \
> > ${@bb.utils.contains("MACHINE_FEATURES", "acpi", "packagegroup-base-acpi", 
> > "",d)} \
> > ${@bb.utils.contains("MACHINE_FEATURES", "alsa", "packagegroup-base-alsa", 
> > "", d)} \
> > ${@bb.utils.contains("MACHINE_FEATURES", "apm", "packagegroup-base-apm", 
> > "", d)} \
>
> I suspect you didn't mean to include this piece since dbench isn't in core?
>
> Cheers,
>
> Richard
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164356): 
https://lists.openembedded.org/g/openembedded-core/message/164356
Mute This Topic: https://lists.openembedded.org/mt/90443891/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Ralph Siemsen
On Wed, Apr 13, 2022 at 12:41 PM Mike Crowe  wrote:
>
> I believe that Ralph's reproduction of the test failure without the zlib
> patch was from a complete rebuild without anything coming from the sstate
> cache.

Yes, just confirming the above. I wanted to be certain there was
nothing left-over from a previous build, so I nuked everything except
for downloads and my local.conf.

I am quite certain the problem is with apt-ftparchive command, which
is what generates the md5/sha sums in the Release file. It seems to
behave differently under Fedora versus Ubuntu. Only the SHA256 is
affected. It is worth noting that apt includes its own sha calculation
code, they are not calling out to "sha256sum" or using an existing
library.

Was busy with some other things this AM but am going to dive into
apt-ftparchive source code next (which is C++, ugh...).

Ralph

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164355): 
https://lists.openembedded.org/g/openembedded-core/message/164355
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 2/2] buildtools: Add standalone make tarball

2022-04-13 Thread Richard Purdie
Some versions of make have bugs. Add a way to provide a make tarball
that can be used on it's own in these cases.

Signed-off-by: Richard Purdie 
---
 meta/conf/distro/include/maintainers.inc |  1 +
 .../recipes-core/meta/buildtools-make-tarball.bb | 16 
 2 files changed, 17 insertions(+)
 create mode 100644 meta/recipes-core/meta/buildtools-make-tarball.bb

diff --git a/meta/conf/distro/include/maintainers.inc 
b/meta/conf/distro/include/maintainers.inc
index 2c5e7308275..09a75933e26 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -84,6 +84,7 @@ RECIPE_MAINTAINER:pn-builder = "Richard Purdie 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164354): 
https://lists.openembedded.org/g/openembedded-core/message/164354
Mute This Topic: https://lists.openembedded.org/mt/90446806/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 1/2] buildtools-tarball: Only add cert envvars if certs are included

2022-04-13 Thread Richard Purdie
Users may or may not include the certificates in buildtools. Only set the
appropriate variables if they're present.

Signed-off-by: Richard Purdie 
---
 meta/recipes-core/meta/buildtools-tarball.bb | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/meta/buildtools-tarball.bb 
b/meta/recipes-core/meta/buildtools-tarball.bb
index f9f36e68c4b..6b59e4934d5 100644
--- a/meta/recipes-core/meta/buildtools-tarball.bb
+++ b/meta/recipes-core/meta/buildtools-tarball.bb
@@ -69,8 +69,10 @@ create_sdk_files:append () {
touch $script
echo 'export 
PATH=${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${sbindir_nativesdk}:${SDKPATHNATIVE}${base_bindir_nativesdk}:${SDKPATHNATIVE}${base_sbindir_nativesdk}:$PATH'
 >> $script
echo 'export OECORE_NATIVE_SYSROOT="${SDKPATHNATIVE}"' >> $script
-   echo 'export 
GIT_SSL_CAINFO="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' 
>>$script
-   echo 'export 
SSL_CERT_FILE="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' 
>>$script
+   if [ -e 
"${SDK_OUTPUT}${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt" ]; 
then
+   echo 'export 
GIT_SSL_CAINFO="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' 
>>$script
+   echo 'export 
SSL_CERT_FILE="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' 
>>$script
+   fi
 
toolchain_create_sdk_version ${SDK_OUTPUT}/${SDKPATH}/version-${SDK_SYS}
 
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164353): 
https://lists.openembedded.org/g/openembedded-core/message/164353
Mute This Topic: https://lists.openembedded.org/mt/90446805/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Jose Quaresma
Hi Steve,

Steve Sakoman  escreveu no dia quarta, 13/04/2022 à(s)
18:37:

> On Wed, Apr 13, 2022 at 6:41 AM Mike Crowe  wrote:
> >
> > On Wednesday 13 April 2022 at 06:02:22 -1000, Steve Sakoman wrote:
> > > Both runs completed and I'm still seeing success without the zlib
> patch:
> > >
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5069
> > >
> > > and failure with the patch:
> > >
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5070
> >
> > I'm certainly no expert with the autobuilder, but it looks like nothing
> was
> > actually compiled for both of those builds - everything came from the
> > sstate cache.
> >
> > I believe that Ralph's reproduction of the test failure without the zlib
> > patch was from a complete rebuild without anything coming from the sstate
> > cache.
> >
> > I suspect that if a PR bump or something similar that causes zlib and all
> > its reverse dependencies to be built were tested on top of the commit
> used
> > for build 5069 then the test failure would occur then as well and
> > exonerate the zlib patch.
>
> A valid point, let's see what happens with a PR bump:
>

I think that bumping the PR is not enough to rebuild a package.
The sstate cache needs to be invalidated and bumped as well
with HASHEQUIV_HASH_VERSION.

PR = "r1"
HASHEQUIV_HASH_VERSION .= ".1"

Jose


>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5072
>
> I see plenty of rebuilds in process . . .
>
> Steve
>
> 
>
>

-- 
Best regards,

José Quaresma

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164352): 
https://lists.openembedded.org/g/openembedded-core/message/164352
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] license: add 'any_incompatible' function

2022-04-13 Thread Richard Purdie
On Wed, 2022-04-13 at 16:00 +, Christopher Larson wrote:
> This function returns True if any of the specified packages are skipped due to
> incompatible license.
> 
> License exceptions are obeyed. The user may specify the package's license for
> cross-recipe checks.
> 
> This allows for additions to packagegroups only for non-incompatible builds. 
> For
> example:
> 
> RDEPENDS_${PN} += "${@'dbench' if not any_incompatible(d, 'dbench', 
> 'GPL-3.0-only') else ''}"
> 
> Signed-off-by: Christopher Larson 
> ---
>  meta/classes/license.bbclass  | 38 +++
>  .../packagegroups/packagegroup-base.bb|  2 +
>  2 files changed, 40 insertions(+)
> 
> v2 changes: fixed string packages logic, corrected reference to
> apply_pkg_license_exception, and avoided use of ${@} in the function docstring
> to avoid bitbake expanding it and recursing.
> 
> diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
> index 0c637e966e..41993b7227 100644
> --- a/meta/classes/license.bbclass
> +++ b/meta/classes/license.bbclass
> @@ -320,6 +320,44 @@ def incompatible_license(d, dont_want_licenses, 
> package=None):
>  
>  return incompatible_pkg_license(d, dont_want_licenses, license)
>  
> +def any_incompatible(d, packages, licensestring=None):
> +"""Return True if any of the packages are skipped due to incompatible 
> license.
> +
> +License exceptions are obeyed. The user may specify the package's license
> +for cross-recipe checks.
> +
> +This allows for additions to packagegroups only for non-incompatible 
> builds.
> +
> +For example: 'dbench' if not any_incompatible(d, 'dbench', 
> 'GPL-3.0-only') else ''
> +"""
> +import oe.license
> +
> +if isinstance(packages, str):
> +packages = packages.split()
> +
> +bad_licenses = (d.getVar("INCOMPATIBLE_LICENSE") or "").split()
> +if not bad_licenses:
> +return False
> +bad_licenses = expand_wildcard_licenses(d, bad_licenses)
> +
> +if licensestring is None:
> +licensestring = d.getVar("LICENSE:%s" % package) if package else None
> +if not licensestring:
> +licensestring = d.getVar("LICENSE")
> +
> +exceptions = (d.getVar("INCOMPATIBLE_LICENSE_EXCEPTIONS") or "").split()
> +for pkg in packages:
> +remaining_bad_licenses = oe.license.apply_pkg_license_exception(
> +pkg, bad_licenses, exceptions
> +)
> +
> +incompatible_lic = incompatible_pkg_license(
> +d, remaining_bad_licenses, licensestring
> +)
> +if incompatible_lic:
> +return True
> +return False
> +
>  def check_license_flags(d):
>  """
>  This function checks if a recipe has any LICENSE_FLAGS that
> diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb 
> b/meta/recipes-core/packagegroups/packagegroup-base.bb
> index 7489ef61b0..1c97d03c21 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> @@ -14,6 +14,8 @@ PACKAGES = ' \
>  packagegroup-distro-base \
>  packagegroup-machine-base \
>  \
> +${@"dbench" if not any_incompatible(d, "dbench", "GPL-3.0-only") 
> else ""} \
> +\
>  ${@bb.utils.contains("MACHINE_FEATURES", "acpi", 
> "packagegroup-base-acpi", "",d)} \
>  ${@bb.utils.contains("MACHINE_FEATURES", "alsa", 
> "packagegroup-base-alsa", "", d)} \
>  ${@bb.utils.contains("MACHINE_FEATURES", "apm", 
> "packagegroup-base-apm", "", d)} \

I suspect you didn't mean to include this piece since dbench isn't in core?

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164351): 
https://lists.openembedded.org/g/openembedded-core/message/164351
Mute This Topic: https://lists.openembedded.org/mt/90443891/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Jose Quaresma
Jose Quaresma via lists.openembedded.org  escreveu no dia quarta, 13/04/2022 à(s)
18:11:

> Hi,
>
> Steve Sakoman  escreveu no dia quarta, 13/04/2022 à(s)
> 17:02:
>
>> On Wed, Apr 13, 2022 at 5:31 AM Steve Sakoman via
>> lists.openembedded.org 
>> wrote:
>> >
>> > On Tue, Apr 12, 2022 at 3:21 PM Ralph Siemsen 
>> wrote:
>> > >
>> > > On Tue, Apr 12, 2022 at 5:49 PM Steve Sakoman 
>> wrote:
>> > >
>> > > > I added a debug option to the failing command and did another
>> autobuilder run.
>> > > >
>> > > > You can see the output here:
>> > > >
>> > > > https://errors.yoctoproject.org/Errors/Details/654608/
>> > >
>> > > Okay, same error, "Hash Sum mismatch". And if I squint between all the
>> > > URL-encoding, I can see the md5/sha1/sha256/sha512sum values.
>> > >
>> > > The "apt update" command is doing the following:
>> > > - fetch the file called "Release"
>> > > - fetch the file called "Packages.gz" --> error occurs here
>> > >
>> > > Looking inside the Release file, it is plain text, and contains the
>> > > md5/sha1/sha256/sha512 sums of both Packages and Packages.gz (and also
>> > > the first two lines of Release).
>> > >
>> > > Manually checking each of those sums reveals an inconsistency: all the
>> > > sha256 values inside Release are incorrect, while all the other
>> > > md1/sha1/sha512 values are correct.
>> > >
>> > > And when we look at the URL-encoded debug info... the sha256 value is
>> > > the correct one for Packages.gz (as computed manually). However it
>> > > does not match the (incorrect) value within the Release file. Thus it
>> > > seems apt-get is justified when it complains about "Hash Sum
>> > > mismatch".
>> > >
>> > > Going back to my Ubuntu system, and looking at the generated Release
>> > > file... all the checksums are correct, including the sha256sum.
>> > >
>> > > So I am now looking into how Release file gets generated... as the
>> > > problem appears to be there... and it happens on Fedora but not
>> > > Ubuntu.
>> >
>> > As far as I can tell it is done here:
>> >
>> >
>> https://git.yoctoproject.org/poky/tree/meta/lib/oe/package_manager.py?h=dunfell#n301
>> >
>> > > One additional point to add: on the same Fedora 35 system, I did a
>> > > full rebuild *without* with xz/gzip CVE fixes, and the apt failure
>> > > still occurs. To be certain, I nuked cache, sstate-cache and tmp (so
>> > > basically the entire build directory) and the rebuild took several
>> > > hours.
>> >
>> > Now that is really strange!  In my experience it has only appeared
>> > after adding the zlib or xz CVE fix patches.
>> >
>> > I just started two runs on the autobuilder, with the zlib patch as the
>> > only difference.  Both on Fedora 35.
>>
>> Both runs completed and I'm still seeing success without the zlib patch:
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5069
>>
>> and failure with the patch:
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5070
>
>
> It seems the test that failed is something related with the apt.
> Is this repo hosted on 192.168.7.5 shared between master and dunfell
> branches?
> I ask this because there are some issues with apt [1] on master and it can
> be related to this.
>

The server is started in the test.
Sorry for the noise and please discard my comment.

Started HTTPService on 0.0.0.0:42261

Jose


>
> [1] apt: add apt selftest to test signed package feeds)
>
> Started HTTPService on 0.0.0.0:35637
> Traceback (most recent call last):
> File
> "/home/pokybuild/yocto-worker/pkgman-deb-non-deb/build/meta/lib/oeqa/core/decorator/__init__.py",
> line 36, in wrapped_f
> return func(*args, **kwargs)
> File
> "/home/pokybuild/yocto-worker/pkgman-deb-non-deb/build/meta/lib/oeqa/core/decorator/__init__.py",
> line 36, in wrapped_f
> return func(*args, **kwargs)
> File
> "/home/pokybuild/yocto-worker/pkgman-deb-non-deb/build/meta/lib/oeqa/core/decorator/__init__.py",
> line 36, in wrapped_f
> return func(*args, **kwargs)
> File
> "/home/pokybuild/yocto-worker/pkgman-deb-non-deb/build/meta/lib/oeqa/runtime/cases/apt.py",
> line 50, in test_apt_install_from_repo
> self.pkg('update')
> File
> "/home/pokybuild/yocto-worker/pkgman-deb-non-deb/build/meta/lib/oeqa/runtime/cases/apt.py",
> line 17, in pkg
> self.assertEqual(status, expected, message)
> AssertionError: 100 != 0 : apt-get update
> Ign:1 http://192.168.7.5:42261 ./ InRelease
> Get:2 http://192.168.7.5:42261 ./ Release [1213 B]
> Ign:3 http://192.168.7.5:42261 ./ Release.gpg
> Get:4 http://192.168.7.5:42261 ./ Packages [59.3 kB]
> Err:4 http://192.168.7.5:42261 ./ Packages
> Hash Sum mismatch
> Fetched 60.5 kB in 20s (3020 B/s)
> Reading package lists...
> W: The repository 'http://192.168.7.5:42261 ./ Release' is not signed.
> E: Failed to fetch http://192.168.7.5:42261/./Packages.gz Hash Sum
> mismatch
> E: Some index files failed to download. They have been ignored, or old
> ones used instead.
>
> Jose
>
>
>>
>> Steve
>>
>>
>>
>>
>
> --
> Best regards,
>
> José Quaresma
>

Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Steve Sakoman
On Wed, Apr 13, 2022 at 6:41 AM Mike Crowe  wrote:
>
> On Wednesday 13 April 2022 at 06:02:22 -1000, Steve Sakoman wrote:
> > Both runs completed and I'm still seeing success without the zlib patch:
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5069
> >
> > and failure with the patch:
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5070
>
> I'm certainly no expert with the autobuilder, but it looks like nothing was
> actually compiled for both of those builds - everything came from the
> sstate cache.
>
> I believe that Ralph's reproduction of the test failure without the zlib
> patch was from a complete rebuild without anything coming from the sstate
> cache.
>
> I suspect that if a PR bump or something similar that causes zlib and all
> its reverse dependencies to be built were tested on top of the commit used
> for build 5069 then the test failure would occur then as well and
> exonerate the zlib patch.

A valid point, let's see what happens with a PR bump:

https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5072

I see plenty of rebuilds in process . . .

Steve

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164349): 
https://lists.openembedded.org/g/openembedded-core/message/164349
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] cmake: add missing licenses

2022-04-13 Thread Konrad Weihmann
in target and native variant a different set of vendored libraries
is pulled from the cmake sources.
Add those licenses and there texts

Signed-off-by: Konrad Weihmann 
---
 meta/recipes-devtools/cmake/cmake-native_3.22.3.bb | 8 
 meta/recipes-devtools/cmake/cmake_3.22.3.bb| 7 +++
 2 files changed, 15 insertions(+)

diff --git a/meta/recipes-devtools/cmake/cmake-native_3.22.3.bb 
b/meta/recipes-devtools/cmake/cmake-native_3.22.3.bb
index 8293fe5e56..ee1f7761c4 100644
--- a/meta/recipes-devtools/cmake/cmake-native_3.22.3.bb
+++ b/meta/recipes-devtools/cmake/cmake-native_3.22.3.bb
@@ -9,6 +9,14 @@ SRC_URI += "file://OEToolchainConfig.cmake \
 
file://0005-Disable-use-of-ext2fs-ext2_fs.h-by-cmake-s-internal-.patch \
 "
 
+LICENSE:append = " & BSD-1-Clause & MIT & BSD-2-Clause"
+LIC_FILES_CHKSUM:append = " \
+file://Utilities/cmjsoncpp/LICENSE;md5=fa2a23dd1dc6c139f35105379d76df2b \
+file://Utilities/cmlibarchive/COPYING;md5=d499814247adaee08d88080841cb5665 
\
+file://Utilities/cmexpat/COPYING;md5=9e2ce3b3c4c0f2670883a23bbd7c37a9 \
+file://Utilities/cmlibrhash/COPYING;md5=a8c2a557a5c53b1c12cddbee98c099af \
+file://Utilities/cmlibuv/LICENSE;md5=a68902a430e32200263d182d44924d47 \
+"
 
 B = "${WORKDIR}/build"
 do_configure[cleandirs] = "${B}"
diff --git a/meta/recipes-devtools/cmake/cmake_3.22.3.bb 
b/meta/recipes-devtools/cmake/cmake_3.22.3.bb
index e111dd3c5a..752c37ba7d 100644
--- a/meta/recipes-devtools/cmake/cmake_3.22.3.bb
+++ b/meta/recipes-devtools/cmake/cmake_3.22.3.bb
@@ -12,6 +12,13 @@ SRC_URI:append:class-nativesdk = " \
 file://0001-CMakeDetermineSystem-use-oe-environment-vars-to-load.patch \
 "
 
+LICENSE:append = " & BSD-1-Clause & MIT"
+LIC_FILES_CHKSUM:append = " \
+file://Utilities/cmjsoncpp/LICENSE;md5=fa2a23dd1dc6c139f35105379d76df2b \
+file://Utilities/cmlibrhash/COPYING;md5=a8c2a557a5c53b1c12cddbee98c099af \
+file://Utilities/cmlibuv/LICENSE;md5=a68902a430e32200263d182d44924d47 \
+"
+
 # Strip ${prefix} from ${docdir}, set result into docdir_stripped
 python () {
 prefix=d.getVar("prefix")
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164348): 
https://lists.openembedded.org/g/openembedded-core/message/164348
Mute This Topic: https://lists.openembedded.org/mt/90446195/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Jose Quaresma
Hi,

Steve Sakoman  escreveu no dia quarta, 13/04/2022 à(s)
17:02:

> On Wed, Apr 13, 2022 at 5:31 AM Steve Sakoman via
> lists.openembedded.org 
> wrote:
> >
> > On Tue, Apr 12, 2022 at 3:21 PM Ralph Siemsen 
> wrote:
> > >
> > > On Tue, Apr 12, 2022 at 5:49 PM Steve Sakoman 
> wrote:
> > >
> > > > I added a debug option to the failing command and did another
> autobuilder run.
> > > >
> > > > You can see the output here:
> > > >
> > > > https://errors.yoctoproject.org/Errors/Details/654608/
> > >
> > > Okay, same error, "Hash Sum mismatch". And if I squint between all the
> > > URL-encoding, I can see the md5/sha1/sha256/sha512sum values.
> > >
> > > The "apt update" command is doing the following:
> > > - fetch the file called "Release"
> > > - fetch the file called "Packages.gz" --> error occurs here
> > >
> > > Looking inside the Release file, it is plain text, and contains the
> > > md5/sha1/sha256/sha512 sums of both Packages and Packages.gz (and also
> > > the first two lines of Release).
> > >
> > > Manually checking each of those sums reveals an inconsistency: all the
> > > sha256 values inside Release are incorrect, while all the other
> > > md1/sha1/sha512 values are correct.
> > >
> > > And when we look at the URL-encoded debug info... the sha256 value is
> > > the correct one for Packages.gz (as computed manually). However it
> > > does not match the (incorrect) value within the Release file. Thus it
> > > seems apt-get is justified when it complains about "Hash Sum
> > > mismatch".
> > >
> > > Going back to my Ubuntu system, and looking at the generated Release
> > > file... all the checksums are correct, including the sha256sum.
> > >
> > > So I am now looking into how Release file gets generated... as the
> > > problem appears to be there... and it happens on Fedora but not
> > > Ubuntu.
> >
> > As far as I can tell it is done here:
> >
> >
> https://git.yoctoproject.org/poky/tree/meta/lib/oe/package_manager.py?h=dunfell#n301
> >
> > > One additional point to add: on the same Fedora 35 system, I did a
> > > full rebuild *without* with xz/gzip CVE fixes, and the apt failure
> > > still occurs. To be certain, I nuked cache, sstate-cache and tmp (so
> > > basically the entire build directory) and the rebuild took several
> > > hours.
> >
> > Now that is really strange!  In my experience it has only appeared
> > after adding the zlib or xz CVE fix patches.
> >
> > I just started two runs on the autobuilder, with the zlib patch as the
> > only difference.  Both on Fedora 35.
>
> Both runs completed and I'm still seeing success without the zlib patch:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5069
>
> and failure with the patch:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5070


It seems the test that failed is something related with the apt.
Is this repo hosted on 192.168.7.5 shared between master and dunfell
branches?
I ask this because there are some issues with apt [1] on master and it can
be related to this.

[1] apt: add apt selftest to test signed package feeds)

Started HTTPService on 0.0.0.0:35637
Traceback (most recent call last):
File
"/home/pokybuild/yocto-worker/pkgman-deb-non-deb/build/meta/lib/oeqa/core/decorator/__init__.py",
line 36, in wrapped_f
return func(*args, **kwargs)
File
"/home/pokybuild/yocto-worker/pkgman-deb-non-deb/build/meta/lib/oeqa/core/decorator/__init__.py",
line 36, in wrapped_f
return func(*args, **kwargs)
File
"/home/pokybuild/yocto-worker/pkgman-deb-non-deb/build/meta/lib/oeqa/core/decorator/__init__.py",
line 36, in wrapped_f
return func(*args, **kwargs)
File
"/home/pokybuild/yocto-worker/pkgman-deb-non-deb/build/meta/lib/oeqa/runtime/cases/apt.py",
line 50, in test_apt_install_from_repo
self.pkg('update')
File
"/home/pokybuild/yocto-worker/pkgman-deb-non-deb/build/meta/lib/oeqa/runtime/cases/apt.py",
line 17, in pkg
self.assertEqual(status, expected, message)
AssertionError: 100 != 0 : apt-get update
Ign:1 http://192.168.7.5:42261 ./ InRelease
Get:2 http://192.168.7.5:42261 ./ Release [1213 B]
Ign:3 http://192.168.7.5:42261 ./ Release.gpg
Get:4 http://192.168.7.5:42261 ./ Packages [59.3 kB]
Err:4 http://192.168.7.5:42261 ./ Packages
Hash Sum mismatch
Fetched 60.5 kB in 20s (3020 B/s)
Reading package lists...
W: The repository 'http://192.168.7.5:42261 ./ Release' is not signed.
E: Failed to fetch http://192.168.7.5:42261/./Packages.gz Hash Sum mismatch
E: Some index files failed to download. They have been ignored, or old ones
used instead.

Jose


>
> Steve
>
> 
>
>

-- 
Best regards,

José Quaresma

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164347): 
https://lists.openembedded.org/g/openembedded-core/message/164347
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]

[OE-core] [PATCH 1/2] ncurses: use COPYING file

2022-04-13 Thread Konrad Weihmann
which has the same info as the in-file header used in before

Signed-off-by: Konrad Weihmann 
---
 meta/recipes-core/ncurses/ncurses.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/ncurses/ncurses.inc 
b/meta/recipes-core/ncurses/ncurses.inc
index a0ecd8a80b..8d374a1522 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -2,7 +2,7 @@ SUMMARY = "The New Curses library"
 DESCRIPTION = "SVr4 and XSI-Curses compatible curses library and terminfo 
tools including tic, infocmp, captoinfo. Supports color, multiple highlights, 
forms-drawing characters, and automatic recognition of keypad and function-key 
sequences. Extensions include resizable windows and mouse support on both xterm 
and Linux console using the gpm library."
 HOMEPAGE = "http://www.gnu.org/software/ncurses/ncurses.html;
 LICENSE = "MIT"
-LIC_FILES_CHKSUM = 
"file://ncurses/base/version.c;beginline=1;endline=27;md5=5526f2f3a29edc95538b368a4771edda"
+LIC_FILES_CHKSUM = "file://COPYING;md5=f852913c5d988a5f5a2f1df7ba7ee893"
 SECTION = "libs"
 DEPENDS = "ncurses-native"
 DEPENDS:class-native = ""
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164345): 
https://lists.openembedded.org/g/openembedded-core/message/164345
Mute This Topic: https://lists.openembedded.org/mt/90445642/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 2/2] python3-pip: correct license

2022-04-13 Thread Konrad Weihmann
as described in src/pip/_vendor/README.rst pip ships plenty
of vendored copies of other python modules.
Correct the license of the resulting package and
reference all the vendor copy license files correctly

Signed-off-by: Konrad Weihmann 
---
 .../python/python3-pip_22.0.3.bb  | 32 +--
 1 file changed, 30 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/python/python3-pip_22.0.3.bb 
b/meta/recipes-devtools/python/python3-pip_22.0.3.bb
index ee3e578b2c..09a305edf8 100644
--- a/meta/recipes-devtools/python/python3-pip_22.0.3.bb
+++ b/meta/recipes-devtools/python/python3-pip_22.0.3.bb
@@ -1,8 +1,36 @@
 SUMMARY = "The PyPA recommended tool for installing Python packages"
 HOMEPAGE = "https://pypi.org/project/pip;
 SECTION = "devel/python"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=63ec52baf95163b597008bb46db68030"
+LICENSE = "MIT & Apache-2.0 & MPL-2.0 & LGPL-2.1-only & BSD-3-Clause & PSF-2.0 
& BSD-2-Clause"
+LIC_FILES_CHKSUM = "\
+  file://LICENSE.txt;md5=63ec52baf95163b597008bb46db68030 \
+  
file://src/pip/_vendor/cachecontrol/LICENSE.txt;md5=6572692148079ebbbd800be4b9f36c6d
 \
+  file://src/pip/_vendor/certifi/LICENSE;md5=67da0714c3f9471067b729eca6c9fbe8 \
+  file://src/pip/_vendor/chardet/LICENSE;md5=a6f89e2100d9b6cdffcea4f398e37343 \
+  
file://src/pip/_vendor/colorama/LICENSE.txt;md5=b4936429a56a652b84c5c01280dcaa26
 \
+  
file://src/pip/_vendor/distlib/LICENSE.txt;md5=f6a11430d5cd6e2cd3832ee94f22ddfc 
\
+  file://src/pip/_vendor/distro.LICENSE;md5=d2794c0df5b907fdace235a619d80314 \
+  file://src/pip/_vendor/html5lib/LICENSE;md5=1ba5ada9e6fead1fdc32f43c9f10ba7c 
\
+  file://src/pip/_vendor/idna/LICENSE.md;md5=239668a7c6066d9e0c5382e9c8c6c0e1 \
+  file://src/pip/_vendor/msgpack/COPYING;md5=cd9523181d9d4fbf7ffca52eaa2a5751 \
+  
file://src/pip/_vendor/packaging/LICENSE;md5=faadaedca9251a90b205c9167578ce91 \
+  
file://src/pip/_vendor/packaging/LICENSE.APACHE;md5=2ee41112a44fe7014dce33e26468ba93
 \
+  file://src/pip/_vendor/pep517/LICENSE;md5=aad69c93f605003e3342b174d9b0708c \
+  
file://src/pip/_vendor/pkg_resources/LICENSE;md5=9a33897f1bca1160d7aad3835152e158
 \
+  
file://src/pip/_vendor/platformdirs/LICENSE.txt;md5=282c970bb844954c8535dd6e9733db7f
 \
+  file://src/pip/_vendor/progress/LICENSE;md5=00ab78a4113b09aacf63d762a7bb9644 
\
+  file://src/pip/_vendor/pygments/LICENSE;md5=98419e351433ac106a24e3ad435930bc 
\
+  
file://src/pip/_vendor/pyparsing/LICENSE;md5=657a566233888513e1f07ba13e2f47f1 \
+  file://src/pip/_vendor/requests/LICENSE;md5=34400b68072d710fecd0a2940a0d1658 
\
+  
file://src/pip/_vendor/resolvelib/LICENSE;md5=78e1c0248051c32a38a7f820c30bd7a5 \
+  file://src/pip/_vendor/rich/LICENSE;md5=b5f0b94fbc94f5ad9ae4efcf8a778303 \
+  file://src/pip/_vendor/six.LICENSE;md5=43cfc9e4ac0e377acfb9b76f56b8415d \
+  file://src/pip/_vendor/tenacity/LICENSE;md5=175792518e4ac015ab6696d16c4f607e 
\
+  file://src/pip/_vendor/tomli/LICENSE;md5=f0879d17df0110d1aa8c8c9f46f5 \
+  
file://src/pip/_vendor/typing_extensions.LICENSE;md5=64fc2b30b67d0a8423c250e0386ed72f
 \
+  
file://src/pip/_vendor/urllib3/LICENSE.txt;md5=c2823cb995439c984fd62a973d79815c 
\
+  
file://src/pip/_vendor/webencodings/LICENSE;md5=81fb24cd7823cce23b69f721993dce4d
 \
+"
 
 inherit pypi python_setuptools_build_meta
 
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164346): 
https://lists.openembedded.org/g/openembedded-core/message/164346
Mute This Topic: https://lists.openembedded.org/mt/90445643/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] git: correct license

2022-04-13 Thread Konrad Weihmann

On 13.04.22 18:56, Jose Quaresma wrote:

Hi

Konrad Weihmann mailto:kweihm...@outlook.com>> 
escreveu no dia quarta, 13/04/2022 à(s) 17:34:


by default git pulls in several code fragments not being licensed
under just GPL-2.0-only.
In fact obstack and poll are taken from glib, being licensed
under GPL-2.0-or-later - as this includes GPL-2.0-only, use this instead

Furthermore
reftable being BSD-3-Clause
sha1dc and inet_ntop being MIT
netmalloc being Bosst-1.0 aka BSL-1.0
regex being LGPL-2.1-or-later

Signed-off-by: Konrad Weihmann mailto:kweihm...@outlook.com>>
---
  meta/recipes-devtools/git/git_2.35.1.bb  |
13 +++--
  1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/git/git_2.35.1.bb
 b/meta/recipes-devtools/git/git_2.35.1.bb

index 47c2211864..f8756b6dec 100644
--- a/meta/recipes-devtools/git/git_2.35.1.bb 
+++ b/meta/recipes-devtools/git/git_2.35.1.bb 
@@ -2,7 +2,7 @@ SUMMARY = "Distributed version control system"
  HOMEPAGE = "http://git-scm.com "
  DESCRIPTION = "Git is a free and open source distributed version
control system designed to handle everything from small to very
large projects with speed and efficiency."
  SECTION = "console/utils"
-LICENSE = "GPL-2.0-only"
+LICENSE = "GPL-2.0-or-later & BSD-3-Clause & MIT & BSL-1.0 &
LGPL-2.1-or-later"
  DEPENDS = "openssl zlib"

  PROVIDES:append:class-native = " git-replacement-native"
@@ -14,7 +14,16 @@ SRC_URI =
"${KERNELORG_MIRROR}/software/scm/git/git-${PV}.tar.gz;name=tarball \

  S = "${WORKDIR}/git-${PV}"

-LIC_FILES_CHKSUM =
"file://COPYING;md5=7c0d7ef03a7eb04ce795b0f60e68e7e1"
+LIC_FILES_CHKSUM = "\
+       file://COPYING;md5=7c0d7ef03a7eb04ce795b0f60e68e7e1 \
+       file://reftable/LICENSE;md5=1a6424cafc4c9c88c689848e165af33b \
+       file://sha1dc/LICENSE.txt;md5=9bbe4c990a9e98ea4b98ef5d3bcb8a7a \
+ 
  file://compat/nedmalloc/License.txt;md5=e4224ccaecb14d942c71d31bef20d78c \
+ 
  file://compat/inet_ntop.c;md5=76593c6f74e8ced5b24520175688d59b;endline=16 \
+ 
  file://compat/obstack.h;md5=08ad25fee5428cd879ceef451ce3a22e;endline=18 \
+ 
  file://compat/poll/poll.h;md5=9fc00170a53b8e3e52157c91ac688dd1;endline=19 \
+ 
  file://compat/regex/regex.h;md5=30cc8af0e6f0f8a25acec6d8783bb763;beginline=4;endline=22 \

+"


I don't know if it is possible but if we can add a compat PACKAGECONFIG 
will be great

so we can disable this part which simplifies a little the license.


That would be indeed nice to have - from my understanding of the 
makefile those are build unconditionally, so it would require a upstream 
work first I guess.


For now my patch is just reflecting what is actually used



Jose


  CVE_PRODUCT = "git-scm:git"

-- 
2.25.1








--
Best regards,

José Quaresma

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164344): 
https://lists.openembedded.org/g/openembedded-core/message/164344
Mute This Topic: https://lists.openembedded.org/mt/90444706/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] git: correct license

2022-04-13 Thread Jose Quaresma
Hi

Konrad Weihmann  escreveu no dia quarta, 13/04/2022
à(s) 17:34:

> by default git pulls in several code fragments not being licensed
> under just GPL-2.0-only.
> In fact obstack and poll are taken from glib, being licensed
> under GPL-2.0-or-later - as this includes GPL-2.0-only, use this instead
>
> Furthermore
> reftable being BSD-3-Clause
> sha1dc and inet_ntop being MIT
> netmalloc being Bosst-1.0 aka BSL-1.0
> regex being LGPL-2.1-or-later
>
> Signed-off-by: Konrad Weihmann 
> ---
>  meta/recipes-devtools/git/git_2.35.1.bb | 13 +++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/git/git_2.35.1.bb
> b/meta/recipes-devtools/git/git_2.35.1.bb
> index 47c2211864..f8756b6dec 100644
> --- a/meta/recipes-devtools/git/git_2.35.1.bb
> +++ b/meta/recipes-devtools/git/git_2.35.1.bb
> @@ -2,7 +2,7 @@ SUMMARY = "Distributed version control system"
>  HOMEPAGE = "http://git-scm.com;
>  DESCRIPTION = "Git is a free and open source distributed version control
> system designed to handle everything from small to very large projects with
> speed and efficiency."
>  SECTION = "console/utils"
> -LICENSE = "GPL-2.0-only"
> +LICENSE = "GPL-2.0-or-later & BSD-3-Clause & MIT & BSL-1.0 &
> LGPL-2.1-or-later"
>  DEPENDS = "openssl zlib"
>
>  PROVIDES:append:class-native = " git-replacement-native"
> @@ -14,7 +14,16 @@ SRC_URI =
> "${KERNELORG_MIRROR}/software/scm/git/git-${PV}.tar.gz;name=tarball \
>
>  S = "${WORKDIR}/git-${PV}"
>
> -LIC_FILES_CHKSUM = "file://COPYING;md5=7c0d7ef03a7eb04ce795b0f60e68e7e1"
> +LIC_FILES_CHKSUM = "\
> +   file://COPYING;md5=7c0d7ef03a7eb04ce795b0f60e68e7e1 \
> +   file://reftable/LICENSE;md5=1a6424cafc4c9c88c689848e165af33b \
> +   file://sha1dc/LICENSE.txt;md5=9bbe4c990a9e98ea4b98ef5d3bcb8a7a \
> +
>  file://compat/nedmalloc/License.txt;md5=e4224ccaecb14d942c71d31bef20d78c \
> +
>  file://compat/inet_ntop.c;md5=76593c6f74e8ced5b24520175688d59b;endline=16 \
> +
>  file://compat/obstack.h;md5=08ad25fee5428cd879ceef451ce3a22e;endline=18 \
> +
>  file://compat/poll/poll.h;md5=9fc00170a53b8e3e52157c91ac688dd1;endline=19 \
> +
>  
> file://compat/regex/regex.h;md5=30cc8af0e6f0f8a25acec6d8783bb763;beginline=4;endline=22
> \
> +"
>

I don't know if it is possible but if we can add a compat PACKAGECONFIG
will be great
so we can disable this part which simplifies a little the license.

Jose


>
>  CVE_PRODUCT = "git-scm:git"
>
> --
> 2.25.1
>
>
> 
>
>

-- 
Best regards,

José Quaresma

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164343): 
https://lists.openembedded.org/g/openembedded-core/message/164343
Mute This Topic: https://lists.openembedded.org/mt/90444706/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Mike Crowe via lists.openembedded.org
On Wednesday 13 April 2022 at 06:02:22 -1000, Steve Sakoman wrote:
> Both runs completed and I'm still seeing success without the zlib patch:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5069
> 
> and failure with the patch:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5070

I'm certainly no expert with the autobuilder, but it looks like nothing was
actually compiled for both of those builds - everything came from the
sstate cache.

I believe that Ralph's reproduction of the test failure without the zlib
patch was from a complete rebuild without anything coming from the sstate
cache.

I suspect that if a PR bump or something similar that causes zlib and all
its reverse dependencies to be built were tested on top of the commit used
for build 5069 then the test failure would occur then as well and
exonerate the zlib patch.

Mike.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164342): 
https://lists.openembedded.org/g/openembedded-core/message/164342
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] git: correct license

2022-04-13 Thread Konrad Weihmann
by default git pulls in several code fragments not being licensed
under just GPL-2.0-only.
In fact obstack and poll are taken from glib, being licensed
under GPL-2.0-or-later - as this includes GPL-2.0-only, use this instead

Furthermore
reftable being BSD-3-Clause
sha1dc and inet_ntop being MIT
netmalloc being Bosst-1.0 aka BSL-1.0
regex being LGPL-2.1-or-later

Signed-off-by: Konrad Weihmann 
---
 meta/recipes-devtools/git/git_2.35.1.bb | 13 +++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/git/git_2.35.1.bb 
b/meta/recipes-devtools/git/git_2.35.1.bb
index 47c2211864..f8756b6dec 100644
--- a/meta/recipes-devtools/git/git_2.35.1.bb
+++ b/meta/recipes-devtools/git/git_2.35.1.bb
@@ -2,7 +2,7 @@ SUMMARY = "Distributed version control system"
 HOMEPAGE = "http://git-scm.com;
 DESCRIPTION = "Git is a free and open source distributed version control 
system designed to handle everything from small to very large projects with 
speed and efficiency."
 SECTION = "console/utils"
-LICENSE = "GPL-2.0-only"
+LICENSE = "GPL-2.0-or-later & BSD-3-Clause & MIT & BSL-1.0 & LGPL-2.1-or-later"
 DEPENDS = "openssl zlib"
 
 PROVIDES:append:class-native = " git-replacement-native"
@@ -14,7 +14,16 @@ SRC_URI = 
"${KERNELORG_MIRROR}/software/scm/git/git-${PV}.tar.gz;name=tarball \
 
 S = "${WORKDIR}/git-${PV}"
 
-LIC_FILES_CHKSUM = "file://COPYING;md5=7c0d7ef03a7eb04ce795b0f60e68e7e1"
+LIC_FILES_CHKSUM = "\
+   file://COPYING;md5=7c0d7ef03a7eb04ce795b0f60e68e7e1 \
+   file://reftable/LICENSE;md5=1a6424cafc4c9c88c689848e165af33b \
+   file://sha1dc/LICENSE.txt;md5=9bbe4c990a9e98ea4b98ef5d3bcb8a7a \
+   
file://compat/nedmalloc/License.txt;md5=e4224ccaecb14d942c71d31bef20d78c \
+   
file://compat/inet_ntop.c;md5=76593c6f74e8ced5b24520175688d59b;endline=16 \
+   file://compat/obstack.h;md5=08ad25fee5428cd879ceef451ce3a22e;endline=18 
\
+   
file://compat/poll/poll.h;md5=9fc00170a53b8e3e52157c91ac688dd1;endline=19 \
+   
file://compat/regex/regex.h;md5=30cc8af0e6f0f8a25acec6d8783bb763;beginline=4;endline=22
 \
+"
 
 CVE_PRODUCT = "git-scm:git"
 
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164341): 
https://lists.openembedded.org/g/openembedded-core/message/164341
Mute This Topic: https://lists.openembedded.org/mt/90444706/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] sanity: Show a warning that make 4.2.1 is buggy on non-ubuntu systems

2022-04-13 Thread Richard Purdie
We keep seeing hangs on the autobuilder with make 4.2.1 on Centos8, Alma8
and OpenSuse workers. The hang occurs in perl and kernel builds in particular.
The issue is fixed in 4.3 and has been patched on Ubuntu systems:

https://git.savannah.gnu.org/cgit/make.git/commit/?id=78b5fec6898c26956d00548427cda1101cb80f8a
https://savannah.gnu.org/bugs/?51400

Add a sanity test for make 4.2.1 and error for non-ubuntu systems. We're
making a buildtools-make-tarball available which can be used to
allow systems with the broken version to use the project.

Signed-off-by: Richard Purdie 
---
 meta/classes/sanity.bbclass | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index be956fbcd6c..c385d92e8b0 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -467,6 +467,12 @@ def check_make_version(sanity_data):
 os.remove("makefile_test_b.c")
 if os.path.exists("makefile_test.a"):
 os.remove("makefile_test.a")
+
+if bb.utils.vercmp_string_op(version, "4.2.1", "=="):
+distro = oe.lsb.distro_identifier()
+if "ubuntu" in distro:
+return None
+return "make version 4.2.1 is known to have issues on Centos/OpenSUSE 
and other non-Ubuntu systems. Please use a buildtools-make-tarball or a newer 
version of make.\n"
 return None
 
 
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164340): 
https://lists.openembedded.org/g/openembedded-core/message/164340
Mute This Topic: https://lists.openembedded.org/mt/90444705/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Steve Sakoman
On Wed, Apr 13, 2022 at 5:31 AM Steve Sakoman via
lists.openembedded.org 
wrote:
>
> On Tue, Apr 12, 2022 at 3:21 PM Ralph Siemsen  
> wrote:
> >
> > On Tue, Apr 12, 2022 at 5:49 PM Steve Sakoman  wrote:
> >
> > > I added a debug option to the failing command and did another autobuilder 
> > > run.
> > >
> > > You can see the output here:
> > >
> > > https://errors.yoctoproject.org/Errors/Details/654608/
> >
> > Okay, same error, "Hash Sum mismatch". And if I squint between all the
> > URL-encoding, I can see the md5/sha1/sha256/sha512sum values.
> >
> > The "apt update" command is doing the following:
> > - fetch the file called "Release"
> > - fetch the file called "Packages.gz" --> error occurs here
> >
> > Looking inside the Release file, it is plain text, and contains the
> > md5/sha1/sha256/sha512 sums of both Packages and Packages.gz (and also
> > the first two lines of Release).
> >
> > Manually checking each of those sums reveals an inconsistency: all the
> > sha256 values inside Release are incorrect, while all the other
> > md1/sha1/sha512 values are correct.
> >
> > And when we look at the URL-encoded debug info... the sha256 value is
> > the correct one for Packages.gz (as computed manually). However it
> > does not match the (incorrect) value within the Release file. Thus it
> > seems apt-get is justified when it complains about "Hash Sum
> > mismatch".
> >
> > Going back to my Ubuntu system, and looking at the generated Release
> > file... all the checksums are correct, including the sha256sum.
> >
> > So I am now looking into how Release file gets generated... as the
> > problem appears to be there... and it happens on Fedora but not
> > Ubuntu.
>
> As far as I can tell it is done here:
>
> https://git.yoctoproject.org/poky/tree/meta/lib/oe/package_manager.py?h=dunfell#n301
>
> > One additional point to add: on the same Fedora 35 system, I did a
> > full rebuild *without* with xz/gzip CVE fixes, and the apt failure
> > still occurs. To be certain, I nuked cache, sstate-cache and tmp (so
> > basically the entire build directory) and the rebuild took several
> > hours.
>
> Now that is really strange!  In my experience it has only appeared
> after adding the zlib or xz CVE fix patches.
>
> I just started two runs on the autobuilder, with the zlib patch as the
> only difference.  Both on Fedora 35.

Both runs completed and I'm still seeing success without the zlib patch:

https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5069

and failure with the patch:

https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/5070

Steve

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164339): 
https://lists.openembedded.org/g/openembedded-core/message/164339
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] license: add 'any_incompatible' function

2022-04-13 Thread Christopher Larson
This function returns True if any of the specified packages are skipped due to
incompatible license.

License exceptions are obeyed. The user may specify the package's license for
cross-recipe checks.

This allows for additions to packagegroups only for non-incompatible builds. For
example:

RDEPENDS_${PN} += "${@'dbench' if not any_incompatible(d, 'dbench', 
'GPL-3.0-only') else ''}"

Signed-off-by: Christopher Larson 
---
 meta/classes/license.bbclass  | 38 +++
 .../packagegroups/packagegroup-base.bb|  2 +
 2 files changed, 40 insertions(+)

diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
index 0c637e966e..41993b7227 100644
--- a/meta/classes/license.bbclass
+++ b/meta/classes/license.bbclass
@@ -320,6 +320,44 @@ def incompatible_license(d, dont_want_licenses, 
package=None):
 
 return incompatible_pkg_license(d, dont_want_licenses, license)
 
+def any_incompatible(d, packages, licensestring=None):
+"""Return True if any of the packages are skipped due to incompatible 
license.
+
+License exceptions are obeyed. The user may specify the package's license
+for cross-recipe checks.
+
+This allows for additions to packagegroups only for non-incompatible 
builds.
+
+For example: 'dbench' if not any_incompatible(d, 'dbench', 'GPL-3.0-only') 
else ''
+"""
+import oe.license
+
+if isinstance(packages, str):
+packages = packages.split()
+
+bad_licenses = (d.getVar("INCOMPATIBLE_LICENSE") or "").split()
+if not bad_licenses:
+return False
+bad_licenses = expand_wildcard_licenses(d, bad_licenses)
+
+if licensestring is None:
+licensestring = d.getVar("LICENSE:%s" % package) if package else None
+if not licensestring:
+licensestring = d.getVar("LICENSE")
+
+exceptions = (d.getVar("INCOMPATIBLE_LICENSE_EXCEPTIONS") or "").split()
+for pkg in packages:
+remaining_bad_licenses = oe.license.apply_pkg_license_exception(
+pkg, bad_licenses, exceptions
+)
+
+incompatible_lic = incompatible_pkg_license(
+d, remaining_bad_licenses, licensestring
+)
+if incompatible_lic:
+return True
+return False
+
 def check_license_flags(d):
 """
 This function checks if a recipe has any LICENSE_FLAGS that
diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb 
b/meta/recipes-core/packagegroups/packagegroup-base.bb
index 7489ef61b0..1c97d03c21 100644
--- a/meta/recipes-core/packagegroups/packagegroup-base.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
@@ -14,6 +14,8 @@ PACKAGES = ' \
 packagegroup-distro-base \
 packagegroup-machine-base \
 \
+${@"dbench" if not any_incompatible(d, "dbench", "GPL-3.0-only") 
else ""} \
+\
 ${@bb.utils.contains("MACHINE_FEATURES", "acpi", 
"packagegroup-base-acpi", "",d)} \
 ${@bb.utils.contains("MACHINE_FEATURES", "alsa", 
"packagegroup-base-alsa", "", d)} \
 ${@bb.utils.contains("MACHINE_FEATURES", "apm", 
"packagegroup-base-apm", "", d)} \
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164338): 
https://lists.openembedded.org/g/openembedded-core/message/164338
Mute This Topic: https://lists.openembedded.org/mt/90443892/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2] license: add 'any_incompatible' function

2022-04-13 Thread Christopher Larson
This function returns True if any of the specified packages are skipped due to
incompatible license.

License exceptions are obeyed. The user may specify the package's license for
cross-recipe checks.

This allows for additions to packagegroups only for non-incompatible builds. For
example:

RDEPENDS_${PN} += "${@'dbench' if not any_incompatible(d, 'dbench', 
'GPL-3.0-only') else ''}"

Signed-off-by: Christopher Larson 
---
 meta/classes/license.bbclass  | 38 +++
 .../packagegroups/packagegroup-base.bb|  2 +
 2 files changed, 40 insertions(+)

v2 changes: fixed string packages logic, corrected reference to
apply_pkg_license_exception, and avoided use of ${@} in the function docstring
to avoid bitbake expanding it and recursing.

diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
index 0c637e966e..41993b7227 100644
--- a/meta/classes/license.bbclass
+++ b/meta/classes/license.bbclass
@@ -320,6 +320,44 @@ def incompatible_license(d, dont_want_licenses, 
package=None):
 
 return incompatible_pkg_license(d, dont_want_licenses, license)
 
+def any_incompatible(d, packages, licensestring=None):
+"""Return True if any of the packages are skipped due to incompatible 
license.
+
+License exceptions are obeyed. The user may specify the package's license
+for cross-recipe checks.
+
+This allows for additions to packagegroups only for non-incompatible 
builds.
+
+For example: 'dbench' if not any_incompatible(d, 'dbench', 'GPL-3.0-only') 
else ''
+"""
+import oe.license
+
+if isinstance(packages, str):
+packages = packages.split()
+
+bad_licenses = (d.getVar("INCOMPATIBLE_LICENSE") or "").split()
+if not bad_licenses:
+return False
+bad_licenses = expand_wildcard_licenses(d, bad_licenses)
+
+if licensestring is None:
+licensestring = d.getVar("LICENSE:%s" % package) if package else None
+if not licensestring:
+licensestring = d.getVar("LICENSE")
+
+exceptions = (d.getVar("INCOMPATIBLE_LICENSE_EXCEPTIONS") or "").split()
+for pkg in packages:
+remaining_bad_licenses = oe.license.apply_pkg_license_exception(
+pkg, bad_licenses, exceptions
+)
+
+incompatible_lic = incompatible_pkg_license(
+d, remaining_bad_licenses, licensestring
+)
+if incompatible_lic:
+return True
+return False
+
 def check_license_flags(d):
 """
 This function checks if a recipe has any LICENSE_FLAGS that
diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb 
b/meta/recipes-core/packagegroups/packagegroup-base.bb
index 7489ef61b0..1c97d03c21 100644
--- a/meta/recipes-core/packagegroups/packagegroup-base.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
@@ -14,6 +14,8 @@ PACKAGES = ' \
 packagegroup-distro-base \
 packagegroup-machine-base \
 \
+${@"dbench" if not any_incompatible(d, "dbench", "GPL-3.0-only") 
else ""} \
+\
 ${@bb.utils.contains("MACHINE_FEATURES", "acpi", 
"packagegroup-base-acpi", "",d)} \
 ${@bb.utils.contains("MACHINE_FEATURES", "alsa", 
"packagegroup-base-alsa", "", d)} \
 ${@bb.utils.contains("MACHINE_FEATURES", "apm", 
"packagegroup-base-apm", "", d)} \
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164337): 
https://lists.openembedded.org/g/openembedded-core/message/164337
Mute This Topic: https://lists.openembedded.org/mt/90443891/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 0/8] kernel: consolidated pull request

2022-04-13 Thread Bruce Ashfield
On Wed, Apr 13, 2022 at 11:19 AM Luca Ceresoli 
wrote:

> Hello Bruce,
>
> Il giorno Tue, 12 Apr 2022 17:45:55 -0400
> "Bruce Ashfield"  ha scritto:
>
> > From: Bruce Ashfield 
> >
> > Richard,
> >
> > Here's the collection of -stable, fixes and tweaks that I was talking
> > about during the engineering sync on Tuesday.
> >
> > Feel free to take what you want, or just wait on them all until the
> > release is over.
> >
> > It is worth taking the 5.18 -dev and lttng fixes IMHO, since they do
> > make the release a bit more future proof. Likewise with Jon's -tiny
> > changes.
> >
> > Cheers,
> >
> > Bruce
> >
> > The following changes since commit
> > 632c83ab787211ef927a999f4ecde1d3ce40621d:
> >
> >   license_image.bbclass: close package.manifest file (2022-04-10
> > 08:31:17 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://git.yoctoproject.org/poky-contrib zedd/kernel
> >   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel
> >
> > Bruce Ashfield (8):
> >   linux-yocto/5.15: arm: poky-tiny cleanup and fixes
> >   linux-yocto/5.15: update to v5.15.33
> >   linux-yocto/5.10: update to v5.10.110
> >   linux-yocto/5.10: base: enable kernel crypto userspace API
> >   linux-yocto/5.15: base: enable kernel crypto userspace API
> >   linux-yocto/5.15: kasan: fix BUG: sleeping function called from
> > invalid context
> >   lttng-modules: support kernel 5.18+
> >   linux-yocto-dev: update to v5.18+
>
> Sending this series to the autobuilders triggered some errors and
> warnings (see below). Can you check that?
>
>
unfortunately not. I'll wait out the release and re-submit these later.

That being said, I've run similar tests to the errors found on the AB, and
can't reproduce locally, so I have no way to debug.

Cheers,

Bruce



> 1. kernel not booting on qemuppc
>
>   >> OpenBIOS 1.1 [Nov 1 2021 20:36]
>   >> Configuration device id QEMU version 1 machine id 1
>   >> CPUs: 1
>   >> Memory: 256M
>   >> UUID: ----
>   >> CPU type PowerPC,G4
>   milliseconds isn't unique.
>   >> [ppc] Kernel already loaded (0x0100 + 0x01394760) (initrd
>   >> 0x + 0x) [ppc] Kernel command line: root=/dev/vda rw
> mem=256M
>   >> ip=192.168.7.4::192.168.7.3:255.255.255.0::eth0:off:8.8.8.8
> console=ttyS0 console=ttyS1 console=tty console=ttyS0 printk.time=1
>   >> switching to new context:
>
>   = end: snippet =
>
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/5012/steps/12/logs/stdio
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/5013/steps/12/logs/stdio
>
> 2. X.org not starting on qemuarm
>
> [14.037] (EE) No devices detected.
> [14.039] (EE) Fatal server error:
> [14.040] (EE) no screens found(EE)
> [14.041] (EE)
> Please consult the The X.Org Foundation support
>  at http://wiki.x.org
>  for help.
> [14.042] (EE) Please also check the log file at
> "/var/log/Xorg.0.log" for additional information.
> [14.046] (EE) Server terminated with error (1). Closing log file.
>
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/5053/steps/12/logs/stdio
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/5054/steps/12/logs/stdio
>
> 3. ptest warning
>
> AssertionError: Failed ptests:
> {'strace': ['landlock_create_ruleset-y.gen.test',
> 'landlock_create_ruleset-y.gen']}
>
> This is landlock-related, thus perhaps caused by patch 2/8.
>
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/3117/steps/12/logs/stdio
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/3369/steps/12/logs/stdio
>
> Best regards.
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164336): 
https://lists.openembedded.org/g/openembedded-core/message/164336
Mute This Topic: https://lists.openembedded.org/mt/90428400/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 3/3] gettext: add MIT conditional as license

2022-04-13 Thread Konrad Weihmann
depending on the actual PACKAGECONFIG some
internal vendor copies of libxml, libcroco and glib will
be used.
In the case of libxml this adds MIT to the license.
Reference the license statements based on the actual choosen
PACKAGECONFIG

Signed-off-by: Konrad Weihmann 
---
 meta/recipes-core/gettext/gettext_0.21.bb | 9 +
 1 file changed, 9 insertions(+)

diff --git a/meta/recipes-core/gettext/gettext_0.21.bb 
b/meta/recipes-core/gettext/gettext_0.21.bb
index 30c1955d86..364e6a52a1 100644
--- a/meta/recipes-core/gettext/gettext_0.21.bb
+++ b/meta/recipes-core/gettext/gettext_0.21.bb
@@ -8,6 +8,15 @@ SECTION = "libs"
 LICENSE = "GPL-3.0-or-later & LGPL-2.1-or-later"
 LIC_FILES_CHKSUM = "file://COPYING;md5=c678957b0c8e964aa6c70fd77641a71e"
 
+# without libxml in PACKAGECONFIG vendor copy of the lib will be used
+LICENSE:append = " ${@bb.utils.contains('PACKAGECONFIG', 'libxml', '', '& 
MIT', d)}"
+LIC_FILES_CHKSUM:append = " ${@bb.utils.contains('PACKAGECONFIG', 'libxml', 
'', 
'file://libtextstyle/lib/libxml/COPYING;md5=2044417e2e5006b65a8b9067b683fcf1', 
d)}"
+# without croco in PACKAGECONFIG vendor copy of the lib will be used
+LIC_FILES_CHKSUM:append = " ${@bb.utils.contains('PACKAGECONFIG', 'croco', '', 
'file://libtextstyle/lib/libcroco/libcroco.h;md5=915a46e7307c2f7f8d2b9c503fc434ed;beginline=10;endline=28',
 d)}"
+# without glib in PACKAGECONFIG vendor copy of the lib will be used
+LIC_FILES_CHKSUM:append = " ${@bb.utils.contains('PACKAGECONFIG', 'glib', '', 
'file://libtextstyle/lib/glib/ghash.c;md5=af89a160226edf0b276b6183888037d0;beginline=10;endline=27',
 d)}"
+
+
 DEPENDS = "gettext-native virtual/libiconv"
 DEPENDS:class-native = "gettext-minimal-native"
 PROVIDES = "virtual/libintl virtual/gettext"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164335): 
https://lists.openembedded.org/g/openembedded-core/message/164335
Mute This Topic: https://lists.openembedded.org/mt/90443246/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 2/3] libidn2: add Unicode-DFS-2016 license

2022-04-13 Thread Konrad Weihmann
as COPYING clearly states that unicode data is baked into
the lib.
Add the license and reference the COPYING file for that

Signed-off-by: Konrad Weihmann 
---
 meta/recipes-extended/libidn/libidn2_2.3.2.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-extended/libidn/libidn2_2.3.2.bb 
b/meta/recipes-extended/libidn/libidn2_2.3.2.bb
index 7316c031ce..e1b25b4b8c 100644
--- a/meta/recipes-extended/libidn/libidn2_2.3.2.bb
+++ b/meta/recipes-extended/libidn/libidn2_2.3.2.bb
@@ -2,10 +2,11 @@ SUMMARY = "Internationalized Domain Name support library"
 DESCRIPTION = "Implementation of the Stringprep, Punycode and IDNA 
specifications defined by the IETF Internationalized Domain Names (IDN) working 
group."
 HOMEPAGE = "http://www.gnu.org/software/libidn/;
 SECTION = "libs"
-LICENSE = "(GPL-2.0-or-later | LGPL-3.0-only) & GPL-3.0-or-later"
+LICENSE = "(GPL-2.0-or-later | LGPL-3.0-only) & GPL-3.0-or-later & 
Unicode-DFS-2016"
 LIC_FILES_CHKSUM = "file://COPYING;md5=2d834ea7d480438ada04e5d846152395 \
 
file://COPYING.LESSERv3;md5=e6a600fd5e1d9cbde2d983680233ad02 \
 file://COPYINGv2;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
+
file://COPYING.unicode;md5=684cf5f7e3fded3546679424528261a9 \
 
file://src/idn2.c;endline=16;md5=e4b6d628a84a55f1fd8ae4c76c5f6509 \
 
file://lib/idn2.h.in;endline=27;md5=d0fc8ec628be130a1d5b889107e92477"
 
@@ -25,7 +26,7 @@ do_install:append() {
sed -i -e 's|-L${STAGING_LIBDIR}||' -e 's/  */ /g' 
${D}${libdir}/pkgconfig/libidn2.pc
 }
 
-LICENSE:${PN} = "(GPL-2.0-or-later | LGPL-3.0-only)"
+LICENSE:${PN} = "(GPL-2.0-or-later | LGPL-3.0-only) & Unicode-DFS-2016"
 LICENSE:${PN}-bin = "GPL-3.0-or-later"
 
 BBCLASSEXTEND = "native nativesdk"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164334): 
https://lists.openembedded.org/g/openembedded-core/message/164334
Mute This Topic: https://lists.openembedded.org/mt/90443245/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 1/3] libsdl2: fix license

2022-04-13 Thread Konrad Weihmann
by default libsdl2 is build with code from src/video/yuv2rgb, which
is licensed under BSD-2-Clause.
Additional by default hidapi is build, which is licensed under
GPL3 | BSD-2-Clause | HIDAPI license, pick the least restrictive
and best matching BSD-2-Clause.

Signed-off-by: Konrad Weihmann 
---
 meta/recipes-graphics/libsdl2/libsdl2_2.0.20.bb | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.20.bb 
b/meta/recipes-graphics/libsdl2/libsdl2_2.0.20.bb
index 4ba22c1fe6..c1c827af79 100644
--- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.20.bb
+++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.20.bb
@@ -7,8 +7,13 @@ BUGTRACKER = "http://bugzilla.libsdl.org/;
 
 SECTION = "libs"
 
-LICENSE = "Zlib"
-LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=68a088513da90254b2fbe664f42af315"
+LICENSE = "Zlib & BSD-2-Clause"
+LIC_FILES_CHKSUM = "\
+file://LICENSE.txt;md5=68a088513da90254b2fbe664f42af315 \
+file://src/hidapi/LICENSE.txt;md5=7c3949a631240cb6c31c50f3eb696077 \
+file://src/hidapi/LICENSE-bsd.txt;md5=b5fa085ce0926bb50d0621620a82361f \
+file://src/video/yuv2rgb/LICENSE;md5=79f8f3418d91531e05f0fc94ca67e071 \
+"
 
 # arm-neon adds MIT license
 LICENSE:append = " ${@bb.utils.contains('PACKAGECONFIG', 'arm-neon', '& MIT', 
'', d)}"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164333): 
https://lists.openembedded.org/g/openembedded-core/message/164333
Mute This Topic: https://lists.openembedded.org/mt/90443244/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH][dunfell] zlib: backport the fix for CVE-2018-25032

2022-04-13 Thread Steve Sakoman
On Tue, Apr 12, 2022 at 3:21 PM Ralph Siemsen  wrote:
>
> On Tue, Apr 12, 2022 at 5:49 PM Steve Sakoman  wrote:
>
> > I added a debug option to the failing command and did another autobuilder 
> > run.
> >
> > You can see the output here:
> >
> > https://errors.yoctoproject.org/Errors/Details/654608/
>
> Okay, same error, "Hash Sum mismatch". And if I squint between all the
> URL-encoding, I can see the md5/sha1/sha256/sha512sum values.
>
> The "apt update" command is doing the following:
> - fetch the file called "Release"
> - fetch the file called "Packages.gz" --> error occurs here
>
> Looking inside the Release file, it is plain text, and contains the
> md5/sha1/sha256/sha512 sums of both Packages and Packages.gz (and also
> the first two lines of Release).
>
> Manually checking each of those sums reveals an inconsistency: all the
> sha256 values inside Release are incorrect, while all the other
> md1/sha1/sha512 values are correct.
>
> And when we look at the URL-encoded debug info... the sha256 value is
> the correct one for Packages.gz (as computed manually). However it
> does not match the (incorrect) value within the Release file. Thus it
> seems apt-get is justified when it complains about "Hash Sum
> mismatch".
>
> Going back to my Ubuntu system, and looking at the generated Release
> file... all the checksums are correct, including the sha256sum.
>
> So I am now looking into how Release file gets generated... as the
> problem appears to be there... and it happens on Fedora but not
> Ubuntu.

As far as I can tell it is done here:

https://git.yoctoproject.org/poky/tree/meta/lib/oe/package_manager.py?h=dunfell#n301

> One additional point to add: on the same Fedora 35 system, I did a
> full rebuild *without* with xz/gzip CVE fixes, and the apt failure
> still occurs. To be certain, I nuked cache, sstate-cache and tmp (so
> basically the entire build directory) and the rebuild took several
> hours.

Now that is really strange!  In my experience it has only appeared
after adding the zlib or xz CVE fix patches.

I just started two runs on the autobuilder, with the zlib patch as the
only difference.  Both on Fedora 35.

Let's see if I can confirm what you are seeing!  I don't have a local
Fedora 35 machine, so I need to rely on the autobuilder.

Steve

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164332): 
https://lists.openembedded.org/g/openembedded-core/message/164332
Mute This Topic: https://lists.openembedded.org/mt/90107518/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] license: add 'any_incompatible' function

2022-04-13 Thread Christopher Larson
On Mon, Apr 11, 2022 at 9:14 AM Christopher Larson via
lists.openembedded.org  wrote:

> This function returns True if any of the specified packages are skipped
> due to
> incompatible license.
>
> License exceptions are obeyed. The user may specify the package's license
> for
> cross-recipe checks.
>
> This allows for additions to packagegroups only for non-incompatible
> builds. For
> example:
>
> RDEPENDS_${PN} += "${@'dbench' if not any_incompatible(d, 'dbench',
> 'GPL-3.0-only') else ''}"
>
> Signed-off-by: Christopher Larson 
> ---
>  meta/classes/license.bbclass | 37 
>  1 file changed, 37 insertions(+)
>
> diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
> index 0c637e966e..db8c3f8584 100644
> --- a/meta/classes/license.bbclass
> +++ b/meta/classes/license.bbclass
> @@ -320,6 +320,43 @@ def incompatible_license(d, dont_want_licenses,
> package=None):
>
>  return incompatible_pkg_license(d, dont_want_licenses, license)
>
> +def any_incompatible(d, packages, licensestring=None):
> +"""Return True if any of the packages are skipped due to incompatible
> license.
> +
> +License exceptions are obeyed. The user may specify the package's
> license
> +for cross-recipe checks.
> +
> +This allows for additions to packagegroups only for non-incompatible
> builds.
> +For example:
> +
> +RDEPENDS_${PN} += "${@'dbench' if not any_incompatible(d,
> 'dbench', 'GPL-3.0-only') else ''}"
> +"""
> +if not isinstance(packages, str):
> +packages = packages.split()
>

If it's not a string, I split it? Oops :) v2 forthcoming.
-- 
Christopher Larson
chris_lar...@mentor.com, chris.lar...@siemens.com, kerg...@gmail.com
Principal Software Engineer, Embedded Linux Solutions, Siemens Digital
Industries Software

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164331): 
https://lists.openembedded.org/g/openembedded-core/message/164331
Mute This Topic: https://lists.openembedded.org/mt/90398685/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Abongwa Amahnui Bonalais
Please is there a documentation that contains the possible commands and the 
files they affect?
If there is not, please what method do I use to know which command will affect 
a particular shell script except try and error?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164330): 
https://lists.openembedded.org/g/openembedded-core/message/164330
Mute This Topic: https://lists.openembedded.org/mt/90437025/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] Boot software/firmware (lack of) PROVIDES

2022-04-13 Thread Jon Mason
There is currently an issue with exclusivity for software with the
same use cases (e.g., PROVIDES), and potential confusion for software
with similar use cases.  This is especially problematic for the Arm
boot flow, as there are a number of pieces of competing
software/firmware that stack on top of each other, and this boot flow
gives them similar names.  I believe it is a problem on x86 and others
as well.

The boot flow in a typical Arm system looks something like:

SCP -> TF-A -> EDK2 -> grub

However each one of those pieces _could_ be interchanged with an
alternative.  For example, u-boot instead of tianocore, systemd-boot
instead of grub (or neither if booting via u-boot), etc.  Grouping
like software, looks to me like:

Control Processor Firmware:
SCP
MCP

Secure world Firmware:
TF-A
TF-M
Standalone-MM

Non-secure world firmware:
EDK2/tianocore
u-boot

Boot manager:
grub
systemd-boot
efibootmgr


The current PROVIDES are:

u-boot
PROVIDES = "virtual/bootloader"

that's it...

My suggestions are roughly the names of the categories above.  So:

SCP/MCP = "virtual/control-processor-firmware"
TFA/TFM = "virtual/secure-firmware"
EDK2/u-boot = "virtual/boot-firmware"
grub, etc = "virtual/boot-manager"


These are different from what is there now for u-boot.  So, I don't
think there should be a name collision with legacy layers.

If these pieces were uniquely in meta-arm, I could easily address them
there.  However, given that some are in oe-core (and potentially in
other places), I would like some feedback on the PROVIDES names and an
agreement on them (if possible) to help address this issue.

Thanks,
Jon

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164329): 
https://lists.openembedded.org/g/openembedded-core/message/164329
Mute This Topic: https://lists.openembedded.org/mt/90442900/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 0/8] kernel: consolidated pull request

2022-04-13 Thread Luca Ceresoli via lists.openembedded.org
Hello Bruce,

Il giorno Tue, 12 Apr 2022 17:45:55 -0400
"Bruce Ashfield"  ha scritto:

> From: Bruce Ashfield 
> 
> Richard,
> 
> Here's the collection of -stable, fixes and tweaks that I was talking
> about during the engineering sync on Tuesday.
> 
> Feel free to take what you want, or just wait on them all until the
> release is over.
> 
> It is worth taking the 5.18 -dev and lttng fixes IMHO, since they do
> make the release a bit more future proof. Likewise with Jon's -tiny
> changes.
> 
> Cheers,
> 
> Bruce
> 
> The following changes since commit
> 632c83ab787211ef927a999f4ecde1d3ce40621d:
> 
>   license_image.bbclass: close package.manifest file (2022-04-10
> 08:31:17 +0100)
> 
> are available in the Git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib zedd/kernel
>   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel
> 
> Bruce Ashfield (8):
>   linux-yocto/5.15: arm: poky-tiny cleanup and fixes
>   linux-yocto/5.15: update to v5.15.33
>   linux-yocto/5.10: update to v5.10.110
>   linux-yocto/5.10: base: enable kernel crypto userspace API
>   linux-yocto/5.15: base: enable kernel crypto userspace API
>   linux-yocto/5.15: kasan: fix BUG: sleeping function called from
> invalid context
>   lttng-modules: support kernel 5.18+
>   linux-yocto-dev: update to v5.18+

Sending this series to the autobuilders triggered some errors and
warnings (see below). Can you check that?

1. kernel not booting on qemuppc

  >> OpenBIOS 1.1 [Nov 1 2021 20:36]
  >> Configuration device id QEMU version 1 machine id 1
  >> CPUs: 1
  >> Memory: 256M
  >> UUID: ----
  >> CPU type PowerPC,G4
  milliseconds isn't unique.
  >> [ppc] Kernel already loaded (0x0100 + 0x01394760) (initrd
  >> 0x + 0x) [ppc] Kernel command line: root=/dev/vda rw 
mem=256M 
  >> ip=192.168.7.4::192.168.7.3:255.255.255.0::eth0:off:8.8.8.8 console=ttyS0 
console=ttyS1 console=tty console=ttyS0 printk.time=1 
  >> switching to new context:

  = end: snippet =

https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/5012/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/5013/steps/12/logs/stdio

2. X.org not starting on qemuarm

[14.037] (EE) No devices detected.
[14.039] (EE) Fatal server error:
[14.040] (EE) no screens found(EE) 
[14.041] (EE) 
Please consult the The X.Org Foundation support 
 at http://wiki.x.org
 for help. 
[14.042] (EE) Please also check the log file at
"/var/log/Xorg.0.log" for additional information. 
[14.046] (EE) Server terminated with error (1). Closing log file.

https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/5053/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/5054/steps/12/logs/stdio

3. ptest warning 

AssertionError: Failed ptests:
{'strace': ['landlock_create_ruleset-y.gen.test',
'landlock_create_ruleset-y.gen']}

This is landlock-related, thus perhaps caused by patch 2/8.

https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/3117/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/3369/steps/12/logs/stdio

Best regards.
-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164328): 
https://lists.openembedded.org/g/openembedded-core/message/164328
Mute This Topic: https://lists.openembedded.org/mt/90428400/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] Revert "adwaita-icon-theme: upgrade 41.0 -> 42.0"

2022-04-13 Thread Richard Purdie
This reverts commit 131b143b6ea37963a0380975718cbf8420e5b87f.

Upstream dropped many 'legacy' low res bitmap icons and also plans to
phase out 'generic app' icons in the svg format, saying that all apps
must carry their own icons. This breaks the icons displayed in sato
so revert for now until we have a plan to mitigate that.

[YOCTO #14782]

Signed-off-by: Richard Purdie 
---
 .../0001-Don-t-use-AC_CANONICAL_HOST.patch|  6 +-
 ...-installation-commands-as-shell-jobs.patch | 84 +++
 ...eme_42.0.bb => adwaita-icon-theme_41.0.bb} |  7 +-
 3 files changed, 92 insertions(+), 5 deletions(-)
 create mode 100644 
meta/recipes-gnome/gnome/adwaita-icon-theme/0001-Run-installation-commands-as-shell-jobs.patch
 rename meta/recipes-gnome/gnome/{adwaita-icon-theme_42.0.bb => 
adwaita-icon-theme_41.0.bb} (87%)

diff --git 
a/meta/recipes-gnome/gnome/adwaita-icon-theme/0001-Don-t-use-AC_CANONICAL_HOST.patch
 
b/meta/recipes-gnome/gnome/adwaita-icon-theme/0001-Don-t-use-AC_CANONICAL_HOST.patch
index 32f98e049b9..5afba3c6443 100644
--- 
a/meta/recipes-gnome/gnome/adwaita-icon-theme/0001-Don-t-use-AC_CANONICAL_HOST.patch
+++ 
b/meta/recipes-gnome/gnome/adwaita-icon-theme/0001-Don-t-use-AC_CANONICAL_HOST.patch
@@ -1,4 +1,4 @@
-From 15ffd817b3e334dc7c0508761c7ef417d76379c5 Mon Sep 17 00:00:00 2001
+From 63d97fefdbc90f5c68f67bdc30844776d9a1b720 Mon Sep 17 00:00:00 2001
 From: Jussi Kukkonen 
 Date: Tue, 30 May 2017 14:55:49 +0300
 Subject: [PATCH] Don't use AC_CANONICAL_HOST
@@ -14,12 +14,12 @@ Signed-off-by: Jussi Kukkonen 
  1 file changed, 1 deletion(-)
 
 diff --git a/configure.ac b/configure.ac
-index 040975e..5f7b53a 100644
+index f2659a5..1e8b016 100644
 --- a/configure.ac
 +++ b/configure.ac
 @@ -3,7 +3,6 @@ AC_PREREQ(2.53)
  
- AC_INIT([adwaita-icon-theme], [42.0],
+ AC_INIT([adwaita-icon-theme], [41.0],
  [http://bugzilla.gnome.org/enter_bug.cgi?product=adwaita-icon-theme])
 -AC_CANONICAL_HOST
  AC_CONFIG_MACRO_DIR([m4])
diff --git 
a/meta/recipes-gnome/gnome/adwaita-icon-theme/0001-Run-installation-commands-as-shell-jobs.patch
 
b/meta/recipes-gnome/gnome/adwaita-icon-theme/0001-Run-installation-commands-as-shell-jobs.patch
new file mode 100644
index 000..a1d39cf5584
--- /dev/null
+++ 
b/meta/recipes-gnome/gnome/adwaita-icon-theme/0001-Run-installation-commands-as-shell-jobs.patch
@@ -0,0 +1,84 @@
+From 79da031e9811f3eef34b14cce419be93fea34319 Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin 
+Date: Tue, 13 Jun 2017 18:10:06 +0300
+Subject: [PATCH] Run installation commands as shell jobs
+
+This greatly speeds up installation time on multi-core systems.
+
+Upstream-Status: Submitted 
[https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/merge_requests/39]
+Signed-off-by: Alexander Kanavin 
+
+---
+ src/fullcolor/Makefile.am |  5 +++--
+ src/spinner/Makefile.am   |  7 ---
+ src/symbolic/Makefile.am  | 11 ++-
+ 3 files changed, 13 insertions(+), 10 deletions(-)
+
+diff --git a/src/fullcolor/Makefile.am b/src/fullcolor/Makefile.am
+index d73529b..b7d0808 100644
+--- a/src/fullcolor/Makefile.am
 b/src/fullcolor/Makefile.am
+@@ -9,9 +9,10 @@ install-data-local:
+   for file in `cd $(top_srcdir)/$(SVGOUTDIR)/$$size && find . 
-name "*.png"`; do \
+   context="`dirname $$file`"; \
+   $(mkdir_p) $(DESTDIR)$(themedir)/$$size/$$context; \
+-  $(install_sh_DATA) 
$(top_srcdir)/$(SVGOUTDIR)/$$size/$$file $(DESTDIR)$(themedir)/$$size/$$file; \
++  $(install_sh_DATA) 
$(top_srcdir)/$(SVGOUTDIR)/$$size/$$file $(DESTDIR)$(themedir)/$$size/$$file & \
+   done; \
+-  done;
++  done; \
++  wait
+ 
+ ## FIXME we should add a way to remove links generated by icon mapping
+ uninstall-local:
+diff --git a/src/spinner/Makefile.am b/src/spinner/Makefile.am
+index c14caf6..322dc0d 100644
+--- a/src/spinner/Makefile.am
 b/src/spinner/Makefile.am
+@@ -24,13 +24,14 @@ install-data-local:
+ for file in `cd $(top_srcdir)/$(SVGOUTDIR)/$$size; find . -name 
"*.png"`; do \
+ context="`dirname $$file`"; \
+ $(mkdir_p) $(DESTDIR)$(themedir)/$$size/$$context; \
+-$(install_sh_DATA) 
$(top_srcdir)/$(SVGOUTDIR)/$$size/$$file $(DESTDIR)$(themedir)/$$size/$$file; \
++$(install_sh_DATA) 
$(top_srcdir)/$(SVGOUTDIR)/$$size/$$file $(DESTDIR)$(themedir)/$$size/$$file & \
+ done; \
+   for file in `cd $(top_srcdir)/$(SVGOUTDIR)/scalable-up-to-32; find . 
-name "*.svg"`; do \
+   context="`dirname $$file`"; \
+   $(mkdir_p) $(DESTDIR)$(themedir)/scalable-up-to-32/$$context; \
+-  $(install_sh_DATA) 
$(top_srcdir)/$(SVGOUTDIR)/scalable-up-to-32/$$file 
$(DESTDIR)$(themedir)/scalable-up-to-32/$$file; \
+-  done
++  $(install_sh_DATA) 
$(top_srcdir)/$(SVGOUTDIR)/scalable-up-to-32/$$file 
$(DESTDIR)$(themedir)/scalable-up-to-32/$$file & \

[OE-core] [PATCH] runqemu: Allow auto detection of the correct graphics options

2022-04-13 Thread Richard Purdie
Running "runqemu qemux86 kvm" when qemu is configured for sdl and/or gtk
display output currently leads to a poor user experience with no cursor
and corrupted fonts in the gtk case. This is due to no options being
passed to qemu which leads to the loss of the font envirornment variable
and the show-cursor option.

If the user hasn't specified a display type, grep the output of
"qemu-system-xxx --help" for the display types and pick the "best"
which ensures our config is passed in. That resolves the gtk font issue
and the cursor issue with both sdl and gtk.

Signed-off-by: Richard Purdie 
---
 scripts/runqemu | 21 +++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index 2f77a7bd0f2..664a073807d 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -1363,6 +1363,18 @@ class BaseConfig(object):
 if (self.gl_es == True or self.gl == True) and (self.sdl == False and 
self.gtk == False):
 raise RunQemuError('Option gl/gl-es needs gtk or sdl option.')
 
+# If we have no display option, we autodetect based upon what qemu 
supports. We
+# need our font setup and show-cusor below so we need to see what qemu 
--help says
+# is supported so we can pass our correct config in.
+if not self.nographic and not self.sdl and not self.gtk and not 
self.egl_headless == True:
+output = subprocess.check_output([self.qemu_bin, "--help"], 
universal_newlines=True)
+if "-display gtk" in output:
+self.gtk = True
+elif "-display sdl" in output:
+self.sdl = True
+else:
+self.qemu_opt += '-display none'
+
 if self.sdl == True or self.gtk == True or self.egl_headless == True:
 if self.gl or self.gl_es or self.egl_headless:
 self.qemu_opt += ' -device virtio-vga-gl '
@@ -1415,7 +1427,7 @@ class BaseConfig(object):
 if serial_num < 2:
 self.qemu_opt += " -serial null"
 
-def setup_final(self):
+def find_qemu(self):
 qemu_bin = os.path.join(self.bindir_native, self.qemu_system)
 
 # It is possible to have qemu-native in ASSUME_PROVIDED, and it won't
@@ -1434,8 +1446,13 @@ class BaseConfig(object):
 
 if not os.access(qemu_bin, os.X_OK):
 raise OEPathError("No QEMU binary '%s' could be found" % qemu_bin)
+self.qemu_bin = qemu_bin
+
+def setup_final(self):
+
+self.find_qemu()
 
-self.qemu_opt = "%s %s %s %s %s" % (qemu_bin, self.get('NETWORK_CMD'), 
self.get('QB_RNG'), self.get('ROOTFS_OPTIONS'), 
self.get('QB_OPT_APPEND').replace('@DEPLOY_DIR_IMAGE@', 
self.get('DEPLOY_DIR_IMAGE')))
+self.qemu_opt = "%s %s %s %s %s" % (self.qemu_bin, 
self.get('NETWORK_CMD'), self.get('QB_RNG'), self.get('ROOTFS_OPTIONS'), 
self.get('QB_OPT_APPEND').replace('@DEPLOY_DIR_IMAGE@', 
self.get('DEPLOY_DIR_IMAGE')))
 
 for ovmf in self.ovmf_bios:
 format = ovmf.rsplit('.', 1)[-1]
-- 
2.32.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164326): 
https://lists.openembedded.org/g/openembedded-core/message/164326
Mute This Topic: https://lists.openembedded.org/mt/90442235/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] CVE-2022-24765 (Uncontrolled search for the Git directory in Git)

2022-04-13 Thread Alex Kiernan
In the hope that it spares someone else a wasted day of figuring out
why parts of your build are randomly failing... I suspect it's this
change which is backported to (at least) Ubuntu 18.04 and causes git
operations from inside a fakeroot context (i.e. you're running as
"root") to fail as the check for crossing uid boundaries is triggered
and your .git directory isn't found.

--
Alex Kiernan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164325): 
https://lists.openembedded.org/g/openembedded-core/message/164325
Mute This Topic: https://lists.openembedded.org/mt/90441760/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v3 1/1] apt: add apt selftest to test signed package feeds

2022-04-13 Thread Richard Purdie
On Wed, 2022-04-13 at 15:43 +0200, Ferry Toth wrote:
> Hi,
> 
> Op 13-04-2022 om 09:00 schreef Richard Purdie:
> > On Wed, 2022-04-13 at 00:34 +0200, Alexandre Belloni wrote:
> > > On 13/04/2022 00:20:40+0200, Ferry Toth wrote:
> > > > Hi,
> > > > 
> > > > Op 12-04-2022 om 23:51 schreef Richard Purdie:
> > > > > On Tue, 2022-04-12 at 23:48 +0200, Alexandre Belloni wrote:
> > > > > > On 12/04/2022 23:32:49+0200, Ferry Toth wrote:
> > > > > > > Hi
> > > > > > > 
> > > > > > > Op 12-04-2022 om 16:16 schreef Alexandre Belloni:
> > > > > > > > Hello,
> > > > > > > > 
> > > > > > > > On 11/04/2022 22:50:36+0200, Ferry Toth wrote:
> > > > > > > > > From: Ferry Toth 
> > > > > > > > > 
> > > > > > > > > Since Gatesgarth apt (1.8.2) has become more strict and 
> > > > > > > > > doesn’t allow unsigned repositories by default.
> > > > > > > > > Currently when building images this requirement is worked 
> > > > > > > > > around by using [allow-insecure=yes] and
> > > > > > > > > equivalently when performing selftest.
> > > > > > > > > 
> > > > > > > > > Patches "gpg-sign: Add parameters to gpg signature function" 
> > > > > > > > > and "package_manager: sign DEB package feeds"
> > > > > > > > > enable signed DEB package feeds. This patch adds a runtime 
> > > > > > > > > test for apt derived from the test_testimage_dnf
> > > > > > > > > test. It creates a signed deb package feed, runs a qemu image 
> > > > > > > > > to install the key and performs some package
> > > > > > > > > management. To be able to install the key the gnupg package 
> > > > > > > > > is added to the testimage.
> > > > > > > > > 
> > > > > > > > This went through the autobuilders and it seems this still 
> > > > > > > > fails:
> > > > > > > That is disappointing.
> > > > > > > 
> > > > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3437/steps/15/logs/stdio
> > > > > > > > 
> > > > > > > > ERROR: package-index-1.0-r0 do_package_index: Could not get gpg 
> > > > > > > > version: Command 
> > > > > > > > '['/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/build-st-34525/tmp/hosttools/gpg',
> > > > > > > >  
> > > > > > > > '--agent-program=/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/build-st-34525/tmp/hosttools/gpg-agent|--auto-expand-secmem',
> > > > > > > >  '--version', '--no-permission-warning']' returned non-zero 
> > > > > > > > exit status 2.
> > > > > > > > ERROR: Logfile of failure stored in: 
> > > > > > > > /home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/build-st-34525/tmp/work/core2-64-poky-linux/package-index/1.0-r0/temp/log.do_package_index.53841
> > > > > > > > NOTE: recipe package-index-1.0-r0: task do_package_index: Failed
> > > > > > > In fact package_index is failing, which is outside this patch 
> > > > > > > code.
> > > > > > > 
> > > > > > > > ERROR: Task 
> > > > > > > > (/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/recipes-core/meta/package-index.bb:do_package_index)
> > > > > > > >  failed with exit code '1'
> > > > > > > > 
> > > > > > > > This was ubuntu 16.04 so maybe gpg on the distro is too old 
> > > > > > > > (1.4.20) but
> > > > > > > > I'm not sure as I think you are using gnupg-native.
> > > > > > > I would have expected gnupg-native, but the log line above shows 
> > > > > > > hosttools
> > > > > > > is being used. But the same would happen for signed rpm and ipk 
> > > > > > > feeds right?
> > > > > > > 
> > > > > > > Did we get the correct one tested? I see 55173d in next and then 
> > > > > > > reverted by
> > > > > > > Richard. But that was v2.
> > > > > > > 
> > > > > > This was 
> > > > > > https://git.yoctoproject.org/poky-contrib/commit/?id=5abda438ce762fc7b8e065e3e9063820c758918e
> > > > This is the correct one.
> > > > 
> > > > > > Just to be sure, I've started on ubuntu1604 both master and this 
> > > > > > branch,
> > > > > > we'll see if this reproduces.
> > > > > Firstly, this is occurring in the newly added test so this is being 
> > > > > triggered by
> > > > > the new code. I suspect what is happening is that gnupg-native isn't 
> > > > > being built
> > > > > before the test and this means that it is falling back to the system 
> > > > > gpg. The
> > > > > system gpg is too old on that worker so it fails.
> > > > Certainly
> > > > 
> > > > > You can probably reproduce locally by not having a gpg on your build 
> > > > > system
> > > > > (move it out the way temporarily?).
> > > > Thanks for the tip. Not sure if I can remove the package, but IIUC it's 
> > > > the
> > > > executable that needs to be present so I can just move it out of the 
> > > > way.
> > > > 
> > > > > If I'm right (and I'm just guessing), the fix is to add the missing 
> > > > > dependency
> > > > > to ensure gpg is one we've built.
> You are right
> > > > I know how to add dependency in a recipe, but where to add here?
> > > > 
> > > > I already have 'bitbake('gnupg-native -c addto_recipe_sysroot')'
> > > > Should I run 'bitbake('gnupg-native')' before that?
> > > 

Re: [OE-core] [PATCH v3 1/1] apt: add apt selftest to test signed package feeds

2022-04-13 Thread Ferry Toth

Hi,

Op 13-04-2022 om 09:00 schreef Richard Purdie:

On Wed, 2022-04-13 at 00:34 +0200, Alexandre Belloni wrote:

On 13/04/2022 00:20:40+0200, Ferry Toth wrote:

Hi,

Op 12-04-2022 om 23:51 schreef Richard Purdie:

On Tue, 2022-04-12 at 23:48 +0200, Alexandre Belloni wrote:

On 12/04/2022 23:32:49+0200, Ferry Toth wrote:

Hi

Op 12-04-2022 om 16:16 schreef Alexandre Belloni:

Hello,

On 11/04/2022 22:50:36+0200, Ferry Toth wrote:

From: Ferry Toth 

Since Gatesgarth apt (1.8.2) has become more strict and doesn’t allow unsigned 
repositories by default.
Currently when building images this requirement is worked around by using 
[allow-insecure=yes] and
equivalently when performing selftest.

Patches "gpg-sign: Add parameters to gpg signature function" and "package_manager: 
sign DEB package feeds"
enable signed DEB package feeds. This patch adds a runtime test for apt derived 
from the test_testimage_dnf
test. It creates a signed deb package feed, runs a qemu image to install the 
key and performs some package
management. To be able to install the key the gnupg package is added to the 
testimage.


This went through the autobuilders and it seems this still fails:

That is disappointing.


https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3437/steps/15/logs/stdio

ERROR: package-index-1.0-r0 do_package_index: Could not get gpg version: 
Command 
'['/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/build-st-34525/tmp/hosttools/gpg',
 
'--agent-program=/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/build-st-34525/tmp/hosttools/gpg-agent|--auto-expand-secmem',
 '--version', '--no-permission-warning']' returned non-zero exit status 2.
ERROR: Logfile of failure stored in: 
/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/build-st-34525/tmp/work/core2-64-poky-linux/package-index/1.0-r0/temp/log.do_package_index.53841
NOTE: recipe package-index-1.0-r0: task do_package_index: Failed

In fact package_index is failing, which is outside this patch code.


ERROR: Task 
(/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/recipes-core/meta/package-index.bb:do_package_index)
 failed with exit code '1'

This was ubuntu 16.04 so maybe gpg on the distro is too old (1.4.20) but
I'm not sure as I think you are using gnupg-native.

I would have expected gnupg-native, but the log line above shows hosttools
is being used. But the same would happen for signed rpm and ipk feeds right?

Did we get the correct one tested? I see 55173d in next and then reverted by
Richard. But that was v2.


This was 
https://git.yoctoproject.org/poky-contrib/commit/?id=5abda438ce762fc7b8e065e3e9063820c758918e

This is the correct one.


Just to be sure, I've started on ubuntu1604 both master and this branch,
we'll see if this reproduces.

Firstly, this is occurring in the newly added test so this is being triggered by
the new code. I suspect what is happening is that gnupg-native isn't being built
before the test and this means that it is falling back to the system gpg. The
system gpg is too old on that worker so it fails.

Certainly


You can probably reproduce locally by not having a gpg on your build system
(move it out the way temporarily?).

Thanks for the tip. Not sure if I can remove the package, but IIUC it's the
executable that needs to be present so I can just move it out of the way.


If I'm right (and I'm just guessing), the fix is to add the missing dependency
to ensure gpg is one we've built.

You are right

I know how to add dependency in a recipe, but where to add here?

I already have 'bitbake('gnupg-native -c addto_recipe_sysroot')'
Should I run 'bitbake('gnupg-native')' before that?

I copied these lines from test_testimage_dnf, shouldn't that have similar
problems?


sign_rpm.bbclass has PACKAGE_WRITE_DEPS += "gnupg-native", doesn't that
solve this issue?

Perhaps sign_package_feed.bbclass needs something like:

PACKAGEINDEXDEPS += "gnupg-native:do_populate_sysroot"


I added this to the end of 'meta/classes/package_deb.bbclass' and that 
works.


Do you agree this is the right place?

Should I squash with this patch or send in as a separate patch (fixes 
0b4231b5 
 
"package_manager: sign DEB package feeds")?



I'm not sure why/how it works in the rpm case but it does seem like the
dependency is missing in the deb one.

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164323): 
https://lists.openembedded.org/g/openembedded-core/message/164323
Mute This Topic: https://lists.openembedded.org/mt/90405081/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [meta-oe][PATCH] kernel: Delete unused KERNEL_LOCALVERSION variable

2022-04-13 Thread Alex Kiernan
On Wed, Apr 13, 2022 at 10:29 AM Luca Ceresoli
 wrote:
>
> Hello Alex,
>
> Il giorno Tue, 12 Apr 2022 14:08:18 +0100
> "Alex Kiernan"  ha scritto:
>
> > This has been unused since:
> >
> >   commit fb61dc1430f81ae2ee59766ffab8404fd79ff1b1
> >   Author: Richard Purdie 
> >   Date:   Mon Jan 8 21:05:18 2007 +
> >
> >   kernel.bbclass: Drop KERNEL_RELEASE variable
> >
> >   git-svn-id: https://svn.o-hand.com/repos/poky/trunk@1123
> > 311d38ba-8fff-0310-9ca6-ca027cbcb966
> >
> > Signed-off-by: Alex Kiernan 
>
> This patch has [meta-oe] in the subject line but it is indeed for
> oe-core. No need to resend it, I've taken it for autobuilders testing
> already, however this is something you should possibly fix in future
> patches.
>
> The same applies to the 8-patch series you sent a few minutes earlier.
>

Thank you!

-- 
Alex Kiernan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164322): 
https://lists.openembedded.org/g/openembedded-core/message/164322
Mute This Topic: https://lists.openembedded.org/mt/90417374/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Richard Purdie
On Wed, 2022-04-13 at 05:52 -0700, Abongwa Amahnui Bonalais wrote:
> I test the results by running bitbake core-image-sato.
> If it builds successsfully, then I assume that it is fine, 
> Please what method do you recommend I use to test the results.

You need to find a test which tests the component you're changing. "bitbake
core-image-sato" would test oe-init-build-env but it does not test toaster or 
bitbake-prserv-tool since that are not involved with that command.

An easy way to check is to actively break the script, put something in there you
know will break. If your test doesn't show it not working, it must not be
testing it.

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164321): 
https://lists.openembedded.org/g/openembedded-core/message/164321
Mute This Topic: https://lists.openembedded.org/mt/90437025/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Abongwa Amahnui Bonalais
I test the results by running bitbake core-image-sato.
If it builds successsfully, then I assume that it is fine,
Please what method do you recommend I use to test the results.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164320): 
https://lists.openembedded.org/g/openembedded-core/message/164320
Mute This Topic: https://lists.openembedded.org/mt/90437025/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Richard Purdie
On Wed, 2022-04-13 at 03:50 -0700, Abongwa Amahnui Bonalais wrote:
> Okay thank you what about Using $(...) notation instead of legacy backticked
> `...`.
> base=`basename $0`, changing it to base=$(basename $0)
> 
> Should I commence those changes?
> I'm seeing that based om recommendations when I run shellcheck 

It depends on how you're testing the end result.

I don't mind improving the scripts but what we don't really want are patches
made by just doing what that tool says without the result being tested.

How are you testing the results?

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164319): 
https://lists.openembedded.org/g/openembedded-core/message/164319
Mute This Topic: https://lists.openembedded.org/mt/90437025/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Abongwa Amahnui Bonalais
Okay thank you what about Using $(...) notation instead of legacy backticked 
`...`.
base=`basename $0`, changing it to base=$(basename $0)

Should I commence those changes?
I'm seeing that based om recommendations when I run shellcheck 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164318): 
https://lists.openembedded.org/g/openembedded-core/message/164318
Mute This Topic: https://lists.openembedded.org/mt/90437025/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Richard Purdie
On Wed, 2022-04-13 at 10:35 +0100, Abongwa Amahnui Bonalais wrote:
> Signed-off-by: Abongwa Bonalais Amahnui 
> ---
>  scripts/bitbake-prserv-tool | 22 +++---
>  1 file changed, 11 insertions(+), 11 deletions(-)

I want to suggest a little bit of caution with the direction these changes are
going.

Showing the user a clear error if that have spaces in a build path is a good
thing. Making oe-init-build-env handle that correctly is therefore desirable so
we can get the proper error from bitbake. This is likely the entry point most
users would find (toaster is another)

Since we don't support spaces in build paths and we're unlikely to do so given
that autotools can't, I'm not sure we want to go through too many of our scripts
doing this kind of change though. Most users would use the prserv tool as an
initial introduction to the project.

We did already see potential problems being introduced in the toaster changes on
the bitbake list and I do worry about potential regressions.

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164317): 
https://lists.openembedded.org/g/openembedded-core/message/164317
Mute This Topic: https://lists.openembedded.org/mt/90437025/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Abongwa Amahnui Bonalais
I meant to say globbing sorry.
I will remove the quotes from the subject.

If quotes are not needed in the file=$1, does that means the first patch is 
fine?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164316): 
https://lists.openembedded.org/g/openembedded-core/message/164316
Mute This Topic: https://lists.openembedded.org/mt/90437025/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Peter Kjellerstedt
> -Original Message-
> From: openembedded-core@lists.openembedded.org 
>  On Behalf Of Mike Looijmans
> Sent: den 13 april 2022 11:52
> To: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to 
> variables to prevent splitting and gobbling"

There shouldn't be quotes in the subject above. No idea how you 
managed to get them there...

Also, "gobbling" is not a word, AFAIK. Did you mean "globbing"?

> 
> See comment below (our mail server injects signatures, sorry for that)
> 
> 
> Met vriendelijke groet / kind regards,
> 
> Mike Looijmans
> System Expert
> 
> 
> TOPIC Embedded Products B.V.
> Materiaalweg 4, 5681 RJ Best
> The Netherlands
> 
> T: +31 (0) 499 33 69 69
> E: mike.looijm...@topicproducts.com
> W: www.topic.nl
> 
> Please consider the environment before printing this e-mail
> On 13-04-2022 11:35, Abongwa Amahnui Bonalais via lists.openembedded.org 
> wrote:
> > Signed-off-by: Abongwa Bonalais Amahnui 
> > ---
> >   scripts/bitbake-prserv-tool | 22 +++---
> >   1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/scripts/bitbake-prserv-tool b/scripts/bitbake-prserv-tool
> > index e55d98c72e..68caa9fb66 100755
> > --- a/scripts/bitbake-prserv-tool
> > +++ b/scripts/bitbake-prserv-tool
> > @@ -5,7 +5,7 @@
> >
> >   help ()
> >   {
> > -base=`basename $0`
> > +base=`basename "$0"`
> >   echo -e "Usage: $base command"
> >   echo "Avaliable commands:"
> >   echo -e "\texport : export and lock down the AUTOPR values 
> > from the PR service into a file for release."
> > @@ -16,7 +16,7 @@ clean_cache()
> >   {
> >   s=`bitbake -e | grep ^CACHE= | cut -f2 -d\"`
> >   if [ "x${s}" != "x" ]; then
> > -rm -rf ${s}
> > +rm -rf "${s}"
> >   fi
> >   }
> >
> > @@ -24,14 +24,14 @@ do_export ()
> >   {
> >   file=$1
> 
> You'd want to quote this one too I think.

Actually, as inconsistent as it may seem, quotes are _not_ needed above.

> 
> >   [ "x${file}" == "x" ] && help && exit 1
> > -rm -f ${file}
> > +rm -f "${file}"
> >
> >   clean_cache
> >   bitbake -R conf/prexport.conf -p
> >   s=`bitbake -R conf/prexport.conf -e | grep ^PRSERV_DUMPFILE= | cut 
> > -f2 -d\"`
> >   if [ "x${s}" != "x" ];
> >   then
> > -   [ -e $s ] && mv -f $s $file && echo "Exporting to file $file 
> > succeeded!"
> > +   [ -e "$s" ] && mv -f "$s" "$file" && echo "Exporting to file $file 
> > succeeded!"
> >  return 0
> >   fi
> >   echo "Exporting to file $file failed!"
> > @@ -44,7 +44,7 @@ do_import ()
> >   [ "x${file}" == "x" ] && help && exit 1
> >
> >   clean_cache
> > -bitbake -R conf/primport.conf -R $file -p
> > +bitbake -R conf/primport.conf -R "$file" -p
> >   ret=$?
> >   [ $ret -eq 0 ] && echo "Importing from file $file succeeded!" || echo 
> > "Importing from file $file failed!"
> >   return $ret
> > @@ -60,13 +60,13 @@ do_migrate_localcount ()
> >   return 1
> >   fi
> >
> > -rm -rf $df
> > +rm -rf "$df"
> >   clean_cache
> >   echo "Exporting LOCALCOUNT to AUTOINCs..."
> >   bitbake -R conf/migrate_localcount.conf -p
> >   [ ! $? -eq 0 ] && echo "Exporting to file $df failed!" && exit 1
> >
> > -if [ -e $df ];
> > +if [ -e "$df" ];
> >   then
> >   echo "Exporting to file $df succeeded!"
> >   else
> > @@ -75,7 +75,7 @@ do_migrate_localcount ()
> >   fi
> >
> >   echo "Importing generated AUTOINC entries..."
> > -[ -e $df ] && do_import $df
> > +[ -e "$df" ] && do_import "$df"
> >
> >   if [ ! $? -eq 0 ]
> >   then
> > @@ -93,17 +93,17 @@ case $2 in
> >   *.conf|*.inc)
> >   ;;
> >   *)
> > -echo ERROR: $2 must end with .conf or .inc!
> > +echo ERROR: "$2" must end with .conf or .inc!

The quote above is strictly not needed as the output from echo 
will be the same regardless if there are spaces in $2 or not. 
However, if you really want to quote that line, a more natural 
way would be:

echo "ERROR: $2 must end with .conf or .inc!"

> >   exit 1
> >   ;;
> >   esac
> >
> >   case $1 in
> >   export)
> > -do_export $2
> > +do_export "$2"
> >   ;;
> >   import)
> > -do_import $2
> > +do_import "$2"
> >   ;;
> >   migrate_localcount)
> >   do_migrate_localcount

//Peter


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164315): 
https://lists.openembedded.org/g/openembedded-core/message/164315
Mute This Topic: https://lists.openembedded.org/mt/90437025/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Abongwa Amahnui Bonalais
hi Mike, I have sent a patch that has the changes from your review.
cheers.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164314): 
https://lists.openembedded.org/g/openembedded-core/message/164314
Mute This Topic: https://lists.openembedded.org/mt/90437025/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Abongwa Amahnui Bonalais
Signed-off-by: Abongwa Bonalais Amahnui 
---
 scripts/bitbake-prserv-tool | 26 +-
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/scripts/bitbake-prserv-tool b/scripts/bitbake-prserv-tool
index e55d98c72e..c9fe4afca9 100755
--- a/scripts/bitbake-prserv-tool
+++ b/scripts/bitbake-prserv-tool
@@ -5,7 +5,7 @@
 
 help ()
 {
-base=`basename $0`
+base=`basename "$0"`
 echo -e "Usage: $base command"
 echo "Avaliable commands:"
 echo -e "\texport : export and lock down the AUTOPR values from 
the PR service into a file for release."
@@ -16,22 +16,22 @@ clean_cache()
 {
 s=`bitbake -e | grep ^CACHE= | cut -f2 -d\"`
 if [ "x${s}" != "x" ]; then
-rm -rf ${s}
+rm -rf "${s}"
 fi
 }
 
 do_export ()
 {
-file=$1
+file="$1"
 [ "x${file}" == "x" ] && help && exit 1
-rm -f ${file}
+rm -f "${file}"
 
 clean_cache
 bitbake -R conf/prexport.conf -p
 s=`bitbake -R conf/prexport.conf -e | grep ^PRSERV_DUMPFILE= | cut -f2 
-d\"`
 if [ "x${s}" != "x" ];
 then
-   [ -e $s ] && mv -f $s $file && echo "Exporting to file $file succeeded!"
+   [ -e "$s" ] && mv -f "$s" "$file" && echo "Exporting to file $file 
succeeded!"
return 0
 fi
 echo "Exporting to file $file failed!"
@@ -40,11 +40,11 @@ do_export ()
 
 do_import ()
 {
-file=$1
+file="$1"
 [ "x${file}" == "x" ] && help && exit 1
 
 clean_cache
-bitbake -R conf/primport.conf -R $file -p
+bitbake -R conf/primport.conf -R "$file" -p
 ret=$?
 [ $ret -eq 0 ] && echo "Importing from file $file succeeded!" || echo 
"Importing from file $file failed!"
 return $ret
@@ -60,13 +60,13 @@ do_migrate_localcount ()
 return 1
 fi
 
-rm -rf $df
+rm -rf "$df"
 clean_cache
 echo "Exporting LOCALCOUNT to AUTOINCs..."
 bitbake -R conf/migrate_localcount.conf -p
 [ ! $? -eq 0 ] && echo "Exporting to file $df failed!" && exit 1
 
-if [ -e $df ];
+if [ -e "$df" ];
 then
 echo "Exporting to file $df succeeded!"
 else
@@ -75,7 +75,7 @@ do_migrate_localcount ()
 fi
 
 echo "Importing generated AUTOINC entries..."
-[ -e $df ] && do_import $df
+[ -e "$df" ] && do_import "$df"
 
 if [ ! $? -eq 0 ]
 then
@@ -93,17 +93,17 @@ case $2 in
 *.conf|*.inc)
 ;;
 *)
-echo ERROR: $2 must end with .conf or .inc!
+echo ERROR: "$2" must end with .conf or .inc!
 exit 1
 ;;
 esac
 
 case $1 in
 export)
-do_export $2
+do_export "$2"
 ;;
 import)
-do_import $2
+do_import "$2"
 ;;
 migrate_localcount)
 do_migrate_localcount
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164313): 
https://lists.openembedded.org/g/openembedded-core/message/164313
Mute This Topic: https://lists.openembedded.org/mt/90437318/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] "script/autobuilder-worker-prereq-test: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Abongwa Amahnui Bonalais
Signed-off-by: Abongwa Bonalais Amahnui 
---
 scripts/autobuilder-worker-prereq-tests | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/autobuilder-worker-prereq-tests 
b/scripts/autobuilder-worker-prereq-tests
index 82e9a77bd5..cdf00bead6 100755
--- a/scripts/autobuilder-worker-prereq-tests
+++ b/scripts/autobuilder-worker-prereq-tests
@@ -15,11 +15,11 @@
 # test buildistory git repo works?
 #
 
-if [ ! -x $HOME/yocto-autobuilder-helper/scripts/checkvnc ]; then
+if [ ! -x "$HOME/yocto-autobuilder-helper/scripts/checkvnc" ]; then
 echo "$HOME/yocto-autobuilder-helper should be created."
 exit 1
 fi
-$HOME/yocto-autobuilder-helper/scripts/checkvnc
+"$HOME/yocto-autobuilder-helper/scripts/checkvnc"
 
 . ./oe-init-build-env > /dev/null
 if [ "$?" != "0" ]; then
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164312): 
https://lists.openembedded.org/g/openembedded-core/message/164312
Mute This Topic: https://lists.openembedded.org/mt/90437185/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Mike Looijmans

See comment below (our mail server injects signatures, sorry for that)


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijm...@topicproducts.com
W: www.topic.nl

Please consider the environment before printing this e-mail
On 13-04-2022 11:35, Abongwa Amahnui Bonalais via lists.openembedded.org wrote:

Signed-off-by: Abongwa Bonalais Amahnui 
---
  scripts/bitbake-prserv-tool | 22 +++---
  1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/scripts/bitbake-prserv-tool b/scripts/bitbake-prserv-tool
index e55d98c72e..68caa9fb66 100755
--- a/scripts/bitbake-prserv-tool
+++ b/scripts/bitbake-prserv-tool
@@ -5,7 +5,7 @@
  
  help ()

  {
-base=`basename $0`
+base=`basename "$0"`
  echo -e "Usage: $base command"
  echo "Avaliable commands:"
  echo -e "\texport : export and lock down the AUTOPR values from the 
PR service into a file for release."
@@ -16,7 +16,7 @@ clean_cache()
  {
  s=`bitbake -e | grep ^CACHE= | cut -f2 -d\"`
  if [ "x${s}" != "x" ]; then
-rm -rf ${s}
+rm -rf "${s}"
  fi
  }
  
@@ -24,14 +24,14 @@ do_export ()

  {
  file=$1


You'd want to quote this one too I think.


  [ "x${file}" == "x" ] && help && exit 1
-rm -f ${file}
+rm -f "${file}"
  
  clean_cache

  bitbake -R conf/prexport.conf -p
  s=`bitbake -R conf/prexport.conf -e | grep ^PRSERV_DUMPFILE= | cut -f2 
-d\"`
  if [ "x${s}" != "x" ];
  then
-   [ -e $s ] && mv -f $s $file && echo "Exporting to file $file succeeded!"
+   [ -e "$s" ] && mv -f "$s" "$file" && echo "Exporting to file $file 
succeeded!"
 return 0
  fi
  echo "Exporting to file $file failed!"
@@ -44,7 +44,7 @@ do_import ()
  [ "x${file}" == "x" ] && help && exit 1
  
  clean_cache

-bitbake -R conf/primport.conf -R $file -p
+bitbake -R conf/primport.conf -R "$file" -p
  ret=$?
  [ $ret -eq 0 ] && echo "Importing from file $file succeeded!" || echo 
"Importing from file $file failed!"
  return $ret
@@ -60,13 +60,13 @@ do_migrate_localcount ()
  return 1
  fi
  
-rm -rf $df

+rm -rf "$df"
  clean_cache
  echo "Exporting LOCALCOUNT to AUTOINCs..."
  bitbake -R conf/migrate_localcount.conf -p
  [ ! $? -eq 0 ] && echo "Exporting to file $df failed!" && exit 1
  
-if [ -e $df ];

+if [ -e "$df" ];
  then
  echo "Exporting to file $df succeeded!"
  else
@@ -75,7 +75,7 @@ do_migrate_localcount ()
  fi
  
  echo "Importing generated AUTOINC entries..."

-[ -e $df ] && do_import $df
+[ -e "$df" ] && do_import "$df"
  
  if [ ! $? -eq 0 ]

  then
@@ -93,17 +93,17 @@ case $2 in
  *.conf|*.inc)
  ;;
  *)
-echo ERROR: $2 must end with .conf or .inc!
+echo ERROR: "$2" must end with .conf or .inc!
  exit 1
  ;;
  esac
  
  case $1 in

  export)
-do_export $2
+do_export "$2"
  ;;
  import)
-do_import $2
+do_import "$2"
  ;;
  migrate_localcount)
  do_migrate_localcount








-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164311): 
https://lists.openembedded.org/g/openembedded-core/message/164311
Mute This Topic: https://lists.openembedded.org/mt/90437025/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] "bitbake-prserv-tool: Added quotes to variables to prevent splitting and gobbling"

2022-04-13 Thread Abongwa Amahnui Bonalais
Signed-off-by: Abongwa Bonalais Amahnui 
---
 scripts/bitbake-prserv-tool | 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/scripts/bitbake-prserv-tool b/scripts/bitbake-prserv-tool
index e55d98c72e..68caa9fb66 100755
--- a/scripts/bitbake-prserv-tool
+++ b/scripts/bitbake-prserv-tool
@@ -5,7 +5,7 @@
 
 help ()
 {
-base=`basename $0`
+base=`basename "$0"`
 echo -e "Usage: $base command"
 echo "Avaliable commands:"
 echo -e "\texport : export and lock down the AUTOPR values from 
the PR service into a file for release."
@@ -16,7 +16,7 @@ clean_cache()
 {
 s=`bitbake -e | grep ^CACHE= | cut -f2 -d\"`
 if [ "x${s}" != "x" ]; then
-rm -rf ${s}
+rm -rf "${s}"
 fi
 }
 
@@ -24,14 +24,14 @@ do_export ()
 {
 file=$1
 [ "x${file}" == "x" ] && help && exit 1
-rm -f ${file}
+rm -f "${file}"
 
 clean_cache
 bitbake -R conf/prexport.conf -p
 s=`bitbake -R conf/prexport.conf -e | grep ^PRSERV_DUMPFILE= | cut -f2 
-d\"`
 if [ "x${s}" != "x" ];
 then
-   [ -e $s ] && mv -f $s $file && echo "Exporting to file $file succeeded!"
+   [ -e "$s" ] && mv -f "$s" "$file" && echo "Exporting to file $file 
succeeded!"
return 0
 fi
 echo "Exporting to file $file failed!"
@@ -44,7 +44,7 @@ do_import ()
 [ "x${file}" == "x" ] && help && exit 1
 
 clean_cache
-bitbake -R conf/primport.conf -R $file -p
+bitbake -R conf/primport.conf -R "$file" -p
 ret=$?
 [ $ret -eq 0 ] && echo "Importing from file $file succeeded!" || echo 
"Importing from file $file failed!"
 return $ret
@@ -60,13 +60,13 @@ do_migrate_localcount ()
 return 1
 fi
 
-rm -rf $df
+rm -rf "$df"
 clean_cache
 echo "Exporting LOCALCOUNT to AUTOINCs..."
 bitbake -R conf/migrate_localcount.conf -p
 [ ! $? -eq 0 ] && echo "Exporting to file $df failed!" && exit 1
 
-if [ -e $df ];
+if [ -e "$df" ];
 then
 echo "Exporting to file $df succeeded!"
 else
@@ -75,7 +75,7 @@ do_migrate_localcount ()
 fi
 
 echo "Importing generated AUTOINC entries..."
-[ -e $df ] && do_import $df
+[ -e "$df" ] && do_import "$df"
 
 if [ ! $? -eq 0 ]
 then
@@ -93,17 +93,17 @@ case $2 in
 *.conf|*.inc)
 ;;
 *)
-echo ERROR: $2 must end with .conf or .inc!
+echo ERROR: "$2" must end with .conf or .inc!
 exit 1
 ;;
 esac
 
 case $1 in
 export)
-do_export $2
+do_export "$2"
 ;;
 import)
-do_import $2
+do_import "$2"
 ;;
 migrate_localcount)
 do_migrate_localcount
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164310): 
https://lists.openembedded.org/g/openembedded-core/message/164310
Mute This Topic: https://lists.openembedded.org/mt/90437025/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [meta-oe][PATCH] kernel: Delete unused KERNEL_LOCALVERSION variable

2022-04-13 Thread Luca Ceresoli via lists.openembedded.org
Hello Alex,

Il giorno Tue, 12 Apr 2022 14:08:18 +0100
"Alex Kiernan"  ha scritto:

> This has been unused since:
> 
>   commit fb61dc1430f81ae2ee59766ffab8404fd79ff1b1
>   Author: Richard Purdie 
>   Date:   Mon Jan 8 21:05:18 2007 +
> 
>   kernel.bbclass: Drop KERNEL_RELEASE variable
> 
>   git-svn-id: https://svn.o-hand.com/repos/poky/trunk@1123
> 311d38ba-8fff-0310-9ca6-ca027cbcb966
> 
> Signed-off-by: Alex Kiernan 

This patch has [meta-oe] in the subject line but it is indeed for
oe-core. No need to resend it, I've taken it for autobuilders testing
already, however this is something you should possibly fix in future
patches.

The same applies to the 8-patch series you sent a few minutes earlier.

Best regards
-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164309): 
https://lists.openembedded.org/g/openembedded-core/message/164309
Mute This Topic: https://lists.openembedded.org/mt/90417374/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] bluez5: install /var/lib/bluetooth directory

2022-04-13 Thread Stefan Herbrechtsmeier

Hi,

Am 11.04.2022 um 09:17 schrieb Stefan Herbrechtsmeier via 
lists.openembedded.org:

Am 08.04.2022 um 22:03 schrieb Markus Volk via lists.openembedded.org:
also had this issue and found out, that the bluetooth service did come 
up, once bluetooth was enabled


My fix was to edit like this

ReadWritePaths=:/var/lib/bluetooth

The colon ensures that the service won't fail if the directory doesn't 
exist


Regarding the documentation the ReadOnlyPaths and ReadWritePaths makes 
not sense because ProtectSystem=full mounts /usr, boot loader and /etc 
directories read-only.


Have somebody report the problem to the bluez project?


I have open an issue:
https://github.com/bluez/bluez/issues/329

I will post a patch when we come to a solution.

Regards
  Stefan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164308): 
https://lists.openembedded.org/g/openembedded-core/message/164308
Mute This Topic: https://lists.openembedded.org/mt/90331367/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 1/1] kernel: add kernel-image-fitimage-initramfs

2022-04-13 Thread Claudius Heine

Hi Richard,

On 2022-04-13 09:35, Richard Purdie wrote:

On Wed, 2022-04-13 at 09:18 +0200, Claudius Heine wrote:

Hi,

On 2022-03-30 11:15, Claudius Heine wrote:

When creating an initramfs bundled into a kernel fitimage, the resulting
fitimage will only be placed into the deploy directory and not packaged
by the kernel recipe/class.

Changing the kernel recipe/class to produce a package with the fitimage
containing the initramfs is not possible, because build dependencies
require the kernel packages to be already build before the initramfs can
be created.

The kernel-image-fitimage-initramfs recipe solves this dependency cycle
by packaging the fitimage with the embedded initramfs from the deploy
directory and replaces the `kernel-image` and `kernel-image-fitimage`
packages from the kernel recipe/class.


This patch was on master-next for a short while, any feedback on it?

In the cover letter I stated the only downside of this solution is, that
in case of package based updating, it would require manually changing
the version of this recipe.

Is this an acceptable downside, or is there a good way to fix this?


There were a few things which concern me. It is late in the release cycle for
this to make it into kirkstone so I was deferring it until 4.1 and the next
development cycle.

I was worried that it doesn't have a maintainers entry. I was also worried that
it doesn't have any tests and doesn't get used at all on the autobuilder. There
doesn't seem to have been much other feedback/review on the mailing list either.
There also isn't any documentation. This makes it likely to become a piece of
untested and potentially dead code going forward.

People are fixing up bits of the fitimage and initramfs code adhoc with just
enough changes to sovle their use case. We really need docs and tests and
ideally a clear plan on how this all fits together.

I suspect that the downside you mention, the fact that the kernel is removed
from package management will also catch people out. It is different to our
normal behaviour and I don't know how we highlight to users that this issue is
present.

I'm also worried that we don't have enough people looking at rewiew and that
there are probably issues here we need to discuss but we simply don't have the
right people with time to look at and think about it. I'm not the subject matter
expert here :(.

I wish I had something I could say as to how to make it acceptable to merge
(definitely needs tests) but I really don't know this area well enough and I
haven't had the time to think enough about it. It hovered in -next for a while
as I was trying my best to do so but with the release breaking I needed to clear
out -next for my own sanity and this ended in my defer pile. Even writing the
email explaining why takes 10 minutes.


Thanks a lot for the explanation! I might come back to this at a more 
relaxed period with the suggested improvements.


regards,
Claudius

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164307): 
https://lists.openembedded.org/g/openembedded-core/message/164307
Mute This Topic: https://lists.openembedded.org/mt/90127688/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 1/1] kernel: add kernel-image-fitimage-initramfs

2022-04-13 Thread Richard Purdie
On Wed, 2022-04-13 at 09:18 +0200, Claudius Heine wrote:
> Hi,
> 
> On 2022-03-30 11:15, Claudius Heine wrote:
> > When creating an initramfs bundled into a kernel fitimage, the resulting
> > fitimage will only be placed into the deploy directory and not packaged
> > by the kernel recipe/class.
> > 
> > Changing the kernel recipe/class to produce a package with the fitimage
> > containing the initramfs is not possible, because build dependencies
> > require the kernel packages to be already build before the initramfs can
> > be created.
> > 
> > The kernel-image-fitimage-initramfs recipe solves this dependency cycle
> > by packaging the fitimage with the embedded initramfs from the deploy
> > directory and replaces the `kernel-image` and `kernel-image-fitimage`
> > packages from the kernel recipe/class.
> 
> This patch was on master-next for a short while, any feedback on it?
> 
> In the cover letter I stated the only downside of this solution is, that 
> in case of package based updating, it would require manually changing 
> the version of this recipe.
> 
> Is this an acceptable downside, or is there a good way to fix this?

There were a few things which concern me. It is late in the release cycle for
this to make it into kirkstone so I was deferring it until 4.1 and the next
development cycle.

I was worried that it doesn't have a maintainers entry. I was also worried that
it doesn't have any tests and doesn't get used at all on the autobuilder. There
doesn't seem to have been much other feedback/review on the mailing list either.
There also isn't any documentation. This makes it likely to become a piece of
untested and potentially dead code going forward.

People are fixing up bits of the fitimage and initramfs code adhoc with just
enough changes to sovle their use case. We really need docs and tests and
ideally a clear plan on how this all fits together.

I suspect that the downside you mention, the fact that the kernel is removed
from package management will also catch people out. It is different to our
normal behaviour and I don't know how we highlight to users that this issue is
present.

I'm also worried that we don't have enough people looking at rewiew and that
there are probably issues here we need to discuss but we simply don't have the
right people with time to look at and think about it. I'm not the subject matter
expert here :(.

I wish I had something I could say as to how to make it acceptable to merge
(definitely needs tests) but I really don't know this area well enough and I
haven't had the time to think enough about it. It hovered in -next for a while
as I was trying my best to do so but with the release breaking I needed to clear
out -next for my own sanity and this ended in my defer pile. Even writing the
email explaining why takes 10 minutes.

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164306): 
https://lists.openembedded.org/g/openembedded-core/message/164306
Mute This Topic: https://lists.openembedded.org/mt/90127688/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 1/1] kernel: add kernel-image-fitimage-initramfs

2022-04-13 Thread Claudius Heine

Hi,

On 2022-03-30 11:15, Claudius Heine wrote:

When creating an initramfs bundled into a kernel fitimage, the resulting
fitimage will only be placed into the deploy directory and not packaged
by the kernel recipe/class.

Changing the kernel recipe/class to produce a package with the fitimage
containing the initramfs is not possible, because build dependencies
require the kernel packages to be already build before the initramfs can
be created.

The kernel-image-fitimage-initramfs recipe solves this dependency cycle
by packaging the fitimage with the embedded initramfs from the deploy
directory and replaces the `kernel-image` and `kernel-image-fitimage`
packages from the kernel recipe/class.


This patch was on master-next for a short while, any feedback on it?

In the cover letter I stated the only downside of this solution is, that 
in case of package based updating, it would require manually changing 
the version of this recipe.


Is this an acceptable downside, or is there a good way to fix this?

regards,
Claudius



Signed-off-by: Claudius Heine 
---
  .../kernel-image-fitimage-initramfs_0.1.0.bb  | 50 +++
  1 file changed, 50 insertions(+)
  create mode 100644 
meta/recipes-kernel/kernel-image-fitimage-initramfs/kernel-image-fitimage-initramfs_0.1.0.bb

diff --git 
a/meta/recipes-kernel/kernel-image-fitimage-initramfs/kernel-image-fitimage-initramfs_0.1.0.bb
 
b/meta/recipes-kernel/kernel-image-fitimage-initramfs/kernel-image-fitimage-initramfs_0.1.0.bb
new file mode 100644
index 00..c25168301b
--- /dev/null
+++ 
b/meta/recipes-kernel/kernel-image-fitimage-initramfs/kernel-image-fitimage-initramfs_0.1.0.bb
@@ -0,0 +1,50 @@
+# Copyright (C) 2022 Claudius Heine 
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+SUMMARY = "Packages the fitimage with embedded initramfs"
+LICENSE = "GPL-2.0-only"
+DEPENDS = "virtual/kernel"
+
+SRC_URI = ""
+
+inherit kernel-artifact-names
+INITRAMFS_IMAGE_NAME ?= "${@['${INITRAMFS_IMAGE}-${MACHINE}', 
''][d.getVar('INITRAMFS_IMAGE') == '']}"
+KERNEL_PACKAGE_NAME ?= "kernel"
+
+PN = "${KERNEL_PACKAGE_NAME}-image-fitimage-initramfs"
+
+do_configure[noexec] = "1"
+do_compile[noexec] = "1"
+
+do_install[deptask] = "do_deploy"
+do_install() {
+fitimage="$(readlink 
"${DEPLOY_DIR_IMAGE}/fitImage-${INITRAMFS_IMAGE_NAME}-${KERNEL_FIT_LINK_NAME}")"
+install -d ${D}/boot
+install -m 0644 \
+${DEPLOY_DIR_IMAGE}/${fitimage} \
+${D}/boot/
+ln -snf \
+${fitimage} \
+${D}/boot/fitImage
+}
+
+PACKAGES += "${KERNEL_PACKAGE_NAME}-image-initramfs"
+
+FILES:${PN} = "/boot/fitImage /boot/fitImage-*"
+RPROVIDES:${PN} = "${KERNEL_PACKAGE_NAME}-image-fitimage"
+RCONFLICTS:${PN} = "${KERNEL_PACKAGE_NAME}-image-fitimage"
+RREPLACES:${PN} = "${KERNEL_PACKAGE_NAME}-image-fitimage"
+
+RDEPENDS:${KERNEL_PACKAGE_NAME}-image-initramfs = 
"${KERNEL_PACKAGE_NAME}-image-fitimage-initramfs (= ${EXTENDPGKV})"
+RPROVIDES:${KERNEL_PACKAGE_NAME}-image-initramfs = 
"${KERNEL_PACKAGE_NAME}-image"
+RCONFLICTS:${KERNEL_PACKAGE_NAME}-image-initramfs = 
"${KERNEL_PACKAGE_NAME}-image"
+RREPLACES:${KERNEL_PACKAGE_NAME}-image-initramfs = 
"${KERNEL_PACKAGE_NAME}-image"
+ALLOW_EMPTY:${KERNEL_PACKAGE_NAME}-image-initramfs = "1"
+
+python() {
+if (not 'fitImage' in d.getVar('KERNEL_IMAGETYPES') or
+bb.utils.to_boolean(d.getVar('INITRAMFS_IMAGE_BUNDLE'))):
+raise bb.parse.SkipRecipe('Requires generation of fitImage and bundled 
initramfs.')
+if not d.getVar('KERNEL_FIT_LINK_NAME'):
+raise bb.parse.SkipRecipe('Requires generation of fitImage symlink in 
deploy dir.')
+}

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164305): 
https://lists.openembedded.org/g/openembedded-core/message/164305
Mute This Topic: https://lists.openembedded.org/mt/90127688/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2] libcap: add pam_cap license

2022-04-13 Thread Konrad Weihmann
If libcap is compiled with pam in PACKAGECONFIG
one additional license text becomes effective,
add that as a conditional

Signed-off-by: Konrad Weihmann 
---
v2:
- use spaces instead of tabs
- simplify by using bb.utils.contains

 meta/recipes-support/libcap/libcap_2.63.bb | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-support/libcap/libcap_2.63.bb 
b/meta/recipes-support/libcap/libcap_2.63.bb
index f3133f9ded..9e341c4bd0 100644
--- a/meta/recipes-support/libcap/libcap_2.63.bb
+++ b/meta/recipes-support/libcap/libcap_2.63.bb
@@ -5,7 +5,11 @@ users, without giving them full root permissions."
 HOMEPAGE = "http://sites.google.com/site/fullycapable/;
 # no specific GPL version required
 LICENSE = "BSD-3-Clause | GPL-2.0-only"
-LIC_FILES_CHKSUM = "file://License;md5=e2370ba375efe9e1a095c26d37e483b8"
+LIC_FILES_CHKSUM_PAM = 
"file://pam_cap/License;md5=0ad4c9c052b9719ee4fce1bfc7c7dee4"
+LIC_FILES_CHKSUM = "\
+file://License;md5=e2370ba375efe9e1a095c26d37e483b8 \
+${@bb.utils.contains('PACKAGECONFIG', 'pam', '${LIC_FILES_CHKSUM_PAM}', 
'', d)} \
+"
 
 DEPENDS = "hostperl-runtime-native gperf-native"
 
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164304): 
https://lists.openembedded.org/g/openembedded-core/message/164304
Mute This Topic: https://lists.openembedded.org/mt/90435857/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v3 1/1] apt: add apt selftest to test signed package feeds

2022-04-13 Thread Richard Purdie
On Wed, 2022-04-13 at 00:34 +0200, Alexandre Belloni wrote:
> On 13/04/2022 00:20:40+0200, Ferry Toth wrote:
> > Hi,
> > 
> > Op 12-04-2022 om 23:51 schreef Richard Purdie:
> > > On Tue, 2022-04-12 at 23:48 +0200, Alexandre Belloni wrote:
> > > > On 12/04/2022 23:32:49+0200, Ferry Toth wrote:
> > > > > Hi
> > > > > 
> > > > > Op 12-04-2022 om 16:16 schreef Alexandre Belloni:
> > > > > > Hello,
> > > > > > 
> > > > > > On 11/04/2022 22:50:36+0200, Ferry Toth wrote:
> > > > > > > From: Ferry Toth 
> > > > > > > 
> > > > > > > Since Gatesgarth apt (1.8.2) has become more strict and doesn’t 
> > > > > > > allow unsigned repositories by default.
> > > > > > > Currently when building images this requirement is worked around 
> > > > > > > by using [allow-insecure=yes] and
> > > > > > > equivalently when performing selftest.
> > > > > > > 
> > > > > > > Patches "gpg-sign: Add parameters to gpg signature function" and 
> > > > > > > "package_manager: sign DEB package feeds"
> > > > > > > enable signed DEB package feeds. This patch adds a runtime test 
> > > > > > > for apt derived from the test_testimage_dnf
> > > > > > > test. It creates a signed deb package feed, runs a qemu image to 
> > > > > > > install the key and performs some package
> > > > > > > management. To be able to install the key the gnupg package is 
> > > > > > > added to the testimage.
> > > > > > > 
> > > > > > 
> > > > > > This went through the autobuilders and it seems this still fails:
> > > > > 
> > > > > That is disappointing.
> > > > > 
> > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3437/steps/15/logs/stdio
> > > > > > 
> > > > > > ERROR: package-index-1.0-r0 do_package_index: Could not get gpg 
> > > > > > version: Command 
> > > > > > '['/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/build-st-34525/tmp/hosttools/gpg',
> > > > > >  
> > > > > > '--agent-program=/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/build-st-34525/tmp/hosttools/gpg-agent|--auto-expand-secmem',
> > > > > >  '--version', '--no-permission-warning']' returned non-zero exit 
> > > > > > status 2.
> > > > > > ERROR: Logfile of failure stored in: 
> > > > > > /home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/build-st-34525/tmp/work/core2-64-poky-linux/package-index/1.0-r0/temp/log.do_package_index.53841
> > > > > > NOTE: recipe package-index-1.0-r0: task do_package_index: Failed
> > > > > 
> > > > > In fact package_index is failing, which is outside this patch code.
> > > > > 
> > > > > > ERROR: Task 
> > > > > > (/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/recipes-core/meta/package-index.bb:do_package_index)
> > > > > >  failed with exit code '1'
> > > > > > 
> > > > > > This was ubuntu 16.04 so maybe gpg on the distro is too old 
> > > > > > (1.4.20) but
> > > > > > I'm not sure as I think you are using gnupg-native.
> > > > > 
> > > > > I would have expected gnupg-native, but the log line above shows 
> > > > > hosttools
> > > > > is being used. But the same would happen for signed rpm and ipk feeds 
> > > > > right?
> > > > > 
> > > > > Did we get the correct one tested? I see 55173d in next and then 
> > > > > reverted by
> > > > > Richard. But that was v2.
> > > > > 
> > > > 
> > > > This was 
> > > > https://git.yoctoproject.org/poky-contrib/commit/?id=5abda438ce762fc7b8e065e3e9063820c758918e
> > 
> > This is the correct one.
> > 
> > > > Just to be sure, I've started on ubuntu1604 both master and this branch,
> > > > we'll see if this reproduces.
> > > 
> > > Firstly, this is occurring in the newly added test so this is being 
> > > triggered by
> > > the new code. I suspect what is happening is that gnupg-native isn't 
> > > being built
> > > before the test and this means that it is falling back to the system gpg. 
> > > The
> > > system gpg is too old on that worker so it fails.
> > 
> > Certainly
> > 
> > > You can probably reproduce locally by not having a gpg on your build 
> > > system
> > > (move it out the way temporarily?).
> > 
> > Thanks for the tip. Not sure if I can remove the package, but IIUC it's the
> > executable that needs to be present so I can just move it out of the way.
> > 
> > > If I'm right (and I'm just guessing), the fix is to add the missing 
> > > dependency
> > > to ensure gpg is one we've built.
> > 
> > I know how to add dependency in a recipe, but where to add here?
> > 
> > I already have 'bitbake('gnupg-native -c addto_recipe_sysroot')'
> > Should I run 'bitbake('gnupg-native')' before that?
> > 
> > I copied these lines from test_testimage_dnf, shouldn't that have similar
> > problems?
> > 
> 
> sign_rpm.bbclass has PACKAGE_WRITE_DEPS += "gnupg-native", doesn't that
> solve this issue?

Perhaps sign_package_feed.bbclass needs something like:

PACKAGEINDEXDEPS += "gnupg-native:do_populate_sysroot"

I'm not sure why/how it works in the rpm case but it does seem like the
dependency is missing in the deb one.

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You 

Re: [OE-core] [yocto] QA notification for completed autobuilder build (yocto-4.0.rc1)

2022-04-13 Thread Teoh, Jay Shen
Hi Richard,

> -Original Message-
> From: openembedded-core@lists.openembedded.org  c...@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: Wednesday, 13 April, 2022 12:56 AM
> To: Teoh, Jay Shen ; Pokybuild User
> ; yo...@lists.yoctoproject.org; OE-core
> 
> Cc: qa-build-notificat...@lists.yoctoproject.org
> Subject: Re: [OE-core] [yocto] QA notification for completed autobuilder
> build (yocto-4.0.rc1)
> 
> On Tue, 2022-04-12 at 16:20 +, Teoh, Jay Shen wrote:
> > Hi all,
> >
> > This is the full report for yocto-4.0.rc1:
> > https://git.yoctoproject.org/cgit/cgit.cgi/yocto-testresults-contrib/t
> > ree/?h=intel-yocto-testresults
> >
> > === Summary 
> > No high milestone defects.
> >
> > new issue found
> >
> > Bug 14779 - [4.0rc1] Edgerouter can not boot up Bug 14782 - [QA
> > 4.0.rc1] - Icons not loaded properly Bug 14783 - [QA 4.0.rc1] -
> > Abnormal responsive time for File Manager PCManFM application
> >
> > === Bugs 
> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=14779
> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=14782
> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=14783
> 
> Thanks!
> 
> 14779 means we'll need an rc2. Do you have any information on whether
> 14782/14783 also occur in qemu images or are they just on the nuc hardware?
Yes, it was observed on qemu images as well.
> Do you know if anyone is looking into them or has any leads on the cause of
> them? 
No, I don't know. 
>I presume those things were tested in M3 so something regressed
> somewhere recently?
Yes. Things are working in M3 and tested. So it should be a regression between 
M3 and M4.
> 
> Cheers,
> 
> Richard

Thanks,
Jay

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164302): 
https://lists.openembedded.org/g/openembedded-core/message/164302
Mute This Topic: https://lists.openembedded.org/mt/90422031/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] kernel_configcheck should be run for SRCTREE linux

2022-04-13 Thread Alexandre Belloni via lists.openembedded.org
Hello,

I believe this has introduced a race condition and is the cause of those
two failures:
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3442/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/3399/steps/14/logs/stdio

2022-04-12 22:43:44,845 - oe-selftest - INFO - FAIL: 
devtool.DevtoolUpgradeTests.test_devtool_virtual_kernel_modify 
(subunit.RemotedTestCase)
2022-04-12 22:43:44,845 - oe-selftest - INFO - 
--
2022-04-12 22:43:44,845 - oe-selftest - INFO - 
testtools.testresult.real._StringException: Traceback (most recent call last):
  File 
"/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/lib/oeqa/selftest/cases/devtool.py",
 line 1911, in test_devtool_virtual_kernel_modify
runCmd('devtool build %s' % kernel_provider)
  File 
"/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/lib/oeqa/utils/commands.py",
 line 207, in runCmd
raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % 
(command, result.status, exc_output))
AssertionError: Command 'devtool build linux-yocto' returned non-zero exit 
status 1:

ERROR: linux-yocto-5.15.32+git999-r0 do_kernel_configcheck: config analysis 
failed: 
ERROR: Logfile of failure stored in: 
/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/build-st-3540668/tmp/work/qemux86_64-poky-linux/linux-yocto/5.15.32+git999-r0/temp/log.do_kernel_configcheck.342487
NOTE: recipe linux-yocto-5.15.32+git999-r0: task do_kernel_configcheck: Failed
ERROR: Task 
(/tmp/devtoolqasd4ey4qf/core-copy/meta/recipes-kernel/linux/linux-yocto_5.15.bb:do_kernel_configcheck)
 failed with exit code '1'

I tried to get the logs from the autobuilders but the
linux-yocto/5.15.32+git999-r0/ directory was not present anymore...

On 06/04/2022 18:39:59-0700, Yong Zhao via lists.openembedded.org wrote:
> The task is useful for a SRCTREE linux. Because it won't modify the
> SRCTREE, it does not hurt to run it by default.
> 
> Signed-off-by: Yong Zhao 
> ---
>  meta/classes/kernel-yocto.bbclass | 2 +-
>  scripts/lib/devtool/standard.py   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/kernel-yocto.bbclass 
> b/meta/classes/kernel-yocto.bbclass
> index 1d5a8cdf29..56ba340c1b 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -1,5 +1,5 @@
>  # remove tasks that modify the source tree in case externalsrc is inherited
> -SRCTREECOVEREDTASKS += "do_validate_branches do_kernel_configcheck 
> do_kernel_checkout do_fetch do_unpack do_patch"
> +SRCTREECOVEREDTASKS += "do_validate_branches do_kernel_checkout do_fetch 
> do_unpack do_patch"
>  PATCH_GIT_USER_EMAIL ?= "kernel-yocto@oe"
>  PATCH_GIT_USER_NAME ?= "OpenEmbedded"
>  
> diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
> index 01fb5ad96f..35cea6f320 100644
> --- a/scripts/lib/devtool/standard.py
> +++ b/scripts/lib/devtool/standard.py
> @@ -949,7 +949,7 @@ def modify(args, config, basepath, workspace):
>  
>  if bb.data.inherits_class('kernel', rd):
>  f.write('SRCTREECOVEREDTASKS = "do_validate_branches 
> do_kernel_checkout '
> -'do_fetch do_unpack do_kernel_configcheck"\n')
> +'do_fetch do_unpack"\n')
>  f.write('\ndo_patch[noexec] = "1"\n')
>  f.write('\ndo_configure:append() {\n'
>  'cp ${B}/.config ${S}/.config.baseline\n'
> -- 
> 2.35.1.1094.g7c7d902a7c-goog
> 

> 
> 
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164301): 
https://lists.openembedded.org/g/openembedded-core/message/164301
Mute This Topic: https://lists.openembedded.org/mt/90304701/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-