Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Ilya Maximets]

On 7/8/22 22:07, Gregory Rose wrote:
> 
> 
> On 7/8/2022 12:00 PM, Ilya Maximets wrote:
>> On 7/8/22 17:37, Ben Pfaff wrote:
>>> On Fri, Jul 8, 2022 at 1:53 AM David Marchand >> > wrote:
>>>
>>>  On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose >> > wrote:
>>>  > > xenserver/openvswitch-xen.spec.in 
>>>  >
>>>  > This is a bit of an issue.  Does anyone even use xenserver anymore?
>>>  > All of the documentation and build instructions are really old and
>>>  > I wonder of they work anymore.   I have no xenserver  build 
>>> environment
>>>  > to  test  any changes.
>>>
>>>  Same for me.
>>>
>>>  Ben, Ilya, do you know if this xenserver packaging still has users?
>>>  The last comment about it was in 2017.
>>>  fefb757ce408 ("debian, xenserver: Update logrotate config to match 
>>> RHEL.")
>>>
>>>  Should we keep on updating it? or can we simply drop support for
>>>  xenserver packaging?
>>>
>>> I'd be inclined to drop it. I have heard so little about xenserver (or XCP, 
>>> which
>>> I think is its successor) over the last few years. It makes me a bit sad, 
>>> since
>>> that's where Open vSwitch started out (in a few cases I literally had to
>>> disassemble bits of its binaries to understand what was going on), but the
>>> world moves on.
>>
>> It seems like there is a newer open-source XCP-ng project that is
>> more or less active.  There is also proprietary Citrix Hypervisor,
>> of course.  Both seems to have OVS as a default networking solution
>> and both seems to use some version of OVS 2.5.3.  Here is a repo
>> for XCP-ng one:
>>    https://github.com/xcp-ng-rpms/openvswitch
>>
>> They are not using our spec file though.  And have some custom
>> patches on top.  Not sure about Citrix Hypervisor, but I found some
>> more or less recent security hotfixes referencing openvswitch package
>> like this one:
>>    
>> https://support.citrix.com/article/CTX306423/hotfix-xs82e022-for-citrix-hypervisor-82
>>
>> So, yes, someone is still using it, but they are using about 5 year
>> old version at this point and they are not using upstream spec file.
>>
>> Maybe the removal is a right thing to do.  We can re-introduce the
>> scripts and spec files later if someone from aforementioned
>> projects will want to maintain them.  For now, I agree that xenserver
>> is not a priority, as all the xenserver users seems to use boxed
>> versions of openvswitch provided by XCP-ng or Citrix anyway.  These
>> projects can maintain their own variants if needed.  The code will
>> remain on 2.17 branch for a next few years, if some of these projects
>> will decide to upgrade.
>>
>> Thoughts?
> 
> I think removing the xenserver support is the right thing to do for now,
> especially given the information just shared.
> 
> I'll go ahead and get that done for V4 of the series and add your
> suggested change to continue to support AFXDP ci github workflows.

Ack.  Thanks!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Ilya Maximets]

On 7/8/22 21:54, Ben Pfaff wrote:
> On Fri, Jul 8, 2022 at 12:00 PM Ilya Maximets  > wrote:
> 
> On 7/8/22 17:37, Ben Pfaff wrote:
> > On Fri, Jul 8, 2022 at 1:53 AM David Marchand 
> mailto:david.march...@redhat.com> 
> >> wrote:
> >
> >     On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose    >> wrote:
> >     > > xenserver/openvswitch-xen.spec.in 
>   >
> >     >
> >     > This is a bit of an issue.  Does anyone even use xenserver 
> anymore?
> >     > All of the documentation and build instructions are really old and
> >     > I wonder of they work anymore.   I have no xenserver  build 
> environment
> >     > to  test  any changes.
> >
> >     Same for me.
> >
> >     Ben, Ilya, do you know if this xenserver packaging still has users?
> >     The last comment about it was in 2017.
> >     fefb757ce408 ("debian, xenserver: Update logrotate config to match 
> RHEL.")
> >
> >     Should we keep on updating it? or can we simply drop support for
> >     xenserver packaging?
> >
> > I'd be inclined to drop it. I have heard so little about xenserver (or 
> XCP, which
> > I think is its successor) over the last few years. It makes me a bit 
> sad, since
> > that's where Open vSwitch started out (in a few cases I literally had to
> > disassemble bits of its binaries to understand what was going on), but 
> the
> > world moves on.
> 
> It seems like there is a newer open-source XCP-ng project that is
> more or less active.  There is also proprietary Citrix Hypervisor,
> of course.  Both seems to have OVS as a default networking solution
> and both seems to use some version of OVS 2.5.3.  Here is a repo
> for XCP-ng one:
>   https://github.com/xcp-ng-rpms/openvswitch 
> 
> 
> They are not using our spec file though.  And have some custom
> patches on top.  Not sure about Citrix Hypervisor, but I found some
> more or less recent security hotfixes referencing openvswitch package
> like this one:
>   
> https://support.citrix.com/article/CTX306423/hotfix-xs82e022-for-citrix-hypervisor-82
>  
> 
> 
> So, yes, someone is still using it, but they are using about 5 year
> old version at this point and they are not using upstream spec file
> 
> 
> I guess they're not really using anything we're working on now. I think
> this still supports dropping it. I'm sure we'd welcome them back if they
> asked.

Agreed.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Gregory Rose]

On 7/8/2022 12:00 PM, Ilya Maximets wrote:

On 7/8/22 17:37, Ben Pfaff wrote:

On Fri, Jul 8, 2022 at 1:53 AM David Marchand mailto:david.march...@redhat.com>> wrote:

 On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose mailto:gvrose8...@gmail.com>> wrote:
 > > xenserver/openvswitch-xen.spec.in 
 >
 > This is a bit of an issue.  Does anyone even use xenserver anymore?
 > All of the documentation and build instructions are really old and
 > I wonder of they work anymore.   I have no xenserver  build environment
 > to  test  any changes.

 Same for me.

 Ben, Ilya, do you know if this xenserver packaging still has users?
 The last comment about it was in 2017.
 fefb757ce408 ("debian, xenserver: Update logrotate config to match RHEL.")

 Should we keep on updating it? or can we simply drop support for
 xenserver packaging?

I'd be inclined to drop it. I have heard so little about xenserver (or XCP, 
which
I think is its successor) over the last few years. It makes me a bit sad, since
that's where Open vSwitch started out (in a few cases I literally had to
disassemble bits of its binaries to understand what was going on), but the
world moves on.


It seems like there is a newer open-source XCP-ng project that is
more or less active.  There is also proprietary Citrix Hypervisor,
of course.  Both seems to have OVS as a default networking solution
and both seems to use some version of OVS 2.5.3.  Here is a repo
for XCP-ng one:
   https://github.com/xcp-ng-rpms/openvswitch

They are not using our spec file though.  And have some custom
patches on top.  Not sure about Citrix Hypervisor, but I found some
more or less recent security hotfixes referencing openvswitch package
like this one:
   
https://support.citrix.com/article/CTX306423/hotfix-xs82e022-for-citrix-hypervisor-82

So, yes, someone is still using it, but they are using about 5 year
old version at this point and they are not using upstream spec file.

Maybe the removal is a right thing to do.  We can re-introduce the
scripts and spec files later if someone from aforementioned
projects will want to maintain them.  For now, I agree that xenserver
is not a priority, as all the xenserver users seems to use boxed
versions of openvswitch provided by XCP-ng or Citrix anyway.  These
projects can maintain their own variants if needed.  The code will
remain on 2.17 branch for a next few years, if some of these projects
will decide to upgrade.

Thoughts?


I think removing the xenserver support is the right thing to do for now,
especially given the information just shared.

I'll go ahead and get that done for V4 of the series and add your
suggested change to continue to support AFXDP ci github workflows.

V3 was just posted to see if I can get the order of patches working a
little better.

Regards,

- Greg




Best regards, Ilya Maximets.

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Ben Pfaff]

On Fri, Jul 8, 2022 at 12:00 PM Ilya Maximets  wrote:

> On 7/8/22 17:37, Ben Pfaff wrote:
> > On Fri, Jul 8, 2022 at 1:53 AM David Marchand  > wrote:
> >
> > On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose  > wrote:
> > > > xenserver/openvswitch-xen.spec.in <
> http://openvswitch-xen.spec.in>
> > >
> > > This is a bit of an issue.  Does anyone even use xenserver anymore?
> > > All of the documentation and build instructions are really old and
> > > I wonder of they work anymore.   I have no xenserver  build
> environment
> > > to  test  any changes.
> >
> > Same for me.
> >
> > Ben, Ilya, do you know if this xenserver packaging still has users?
> > The last comment about it was in 2017.
> > fefb757ce408 ("debian, xenserver: Update logrotate config to match
> RHEL.")
> >
> > Should we keep on updating it? or can we simply drop support for
> > xenserver packaging?
> >
> > I'd be inclined to drop it. I have heard so little about xenserver (or
> XCP, which
> > I think is its successor) over the last few years. It makes me a bit
> sad, since
> > that's where Open vSwitch started out (in a few cases I literally had to
> > disassemble bits of its binaries to understand what was going on), but
> the
> > world moves on.
>
> It seems like there is a newer open-source XCP-ng project that is
> more or less active.  There is also proprietary Citrix Hypervisor,
> of course.  Both seems to have OVS as a default networking solution
> and both seems to use some version of OVS 2.5.3.  Here is a repo
> for XCP-ng one:
>   https://github.com/xcp-ng-rpms/openvswitch
>
> They are not using our spec file though.  And have some custom
> patches on top.  Not sure about Citrix Hypervisor, but I found some
> more or less recent security hotfixes referencing openvswitch package
> like this one:
>
> https://support.citrix.com/article/CTX306423/hotfix-xs82e022-for-citrix-hypervisor-82
>
> So, yes, someone is still using it, but they are using about 5 year
> old version at this point and they are not using upstream spec file


I guess they're not really using anything we're working on now. I think
this still supports dropping it. I'm sure we'd welcome them back if they
asked.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Ilya Maximets]

On 7/8/22 17:37, Ben Pfaff wrote:
> On Fri, Jul 8, 2022 at 1:53 AM David Marchand  > wrote:
> 
> On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose  > wrote:
> > > xenserver/openvswitch-xen.spec.in 
> >
> > This is a bit of an issue.  Does anyone even use xenserver anymore?
> > All of the documentation and build instructions are really old and
> > I wonder of they work anymore.   I have no xenserver  build environment
> > to  test  any changes.
> 
> Same for me.
> 
> Ben, Ilya, do you know if this xenserver packaging still has users?
> The last comment about it was in 2017.
> fefb757ce408 ("debian, xenserver: Update logrotate config to match RHEL.")
> 
> Should we keep on updating it? or can we simply drop support for
> xenserver packaging?
> 
> I'd be inclined to drop it. I have heard so little about xenserver (or XCP, 
> which
> I think is its successor) over the last few years. It makes me a bit sad, 
> since
> that's where Open vSwitch started out (in a few cases I literally had to
> disassemble bits of its binaries to understand what was going on), but the
> world moves on.

It seems like there is a newer open-source XCP-ng project that is
more or less active.  There is also proprietary Citrix Hypervisor,
of course.  Both seems to have OVS as a default networking solution
and both seems to use some version of OVS 2.5.3.  Here is a repo
for XCP-ng one:
  https://github.com/xcp-ng-rpms/openvswitch

They are not using our spec file though.  And have some custom
patches on top.  Not sure about Citrix Hypervisor, but I found some
more or less recent security hotfixes referencing openvswitch package
like this one:
  
https://support.citrix.com/article/CTX306423/hotfix-xs82e022-for-citrix-hypervisor-82

So, yes, someone is still using it, but they are using about 5 year
old version at this point and they are not using upstream spec file.

Maybe the removal is a right thing to do.  We can re-introduce the
scripts and spec files later if someone from aforementioned
projects will want to maintain them.  For now, I agree that xenserver
is not a priority, as all the xenserver users seems to use boxed
versions of openvswitch provided by XCP-ng or Citrix anyway.  These
projects can maintain their own variants if needed.  The code will
remain on 2.17 branch for a next few years, if some of these projects
will decide to upgrade.

Thoughts?

Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Ben Pfaff]

On Fri, Jul 8, 2022 at 1:53 AM David Marchand 
wrote:

> On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose  wrote:
> > > xenserver/openvswitch-xen.spec.in
> >
> > This is a bit of an issue.  Does anyone even use xenserver anymore?
> > All of the documentation and build instructions are really old and
> > I wonder of they work anymore.   I have no xenserver  build environment
> > to  test  any changes.
>
> Same for me.
>
> Ben, Ilya, do you know if this xenserver packaging still has users?
> The last comment about it was in 2017.
> fefb757ce408 ("debian, xenserver: Update logrotate config to match RHEL.")
>
> Should we keep on updating it? or can we simply drop support for
> xenserver packaging?
>
I'd be inclined to drop it. I have heard so little about xenserver (or XCP,
which
I think is its successor) over the last few years. It makes me a bit sad,
since
that's where Open vSwitch started out (in a few cases I literally had to
disassemble bits of its binaries to understand what was going on), but the
world moves on.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[David Marchand]

On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose  wrote:
> > xenserver/openvswitch-xen.spec.in
>
> This is a bit of an issue.  Does anyone even use xenserver anymore?
> All of the documentation and build instructions are really old and
> I wonder of they work anymore.   I have no xenserver  build environment
> to  test  any changes.

Same for me.

Ben, Ilya, do you know if this xenserver packaging still has users?
The last comment about it was in 2017.
fefb757ce408 ("debian, xenserver: Update logrotate config to match RHEL.")

Should we keep on updating it? or can we simply drop support for
xenserver packaging?


-- 
David Marchand

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Gregory Rose]

On 7/7/2022 4:53 AM, David Marchand wrote:

On Wed, Jul 6, 2022 at 6:57 PM Greg Rose  wrote:


It is time to remove support for the OVS kernel driver and push
towards use of the upstream Linux openvswitch kernel driver
in it's place [1].

There are many Linux specific source modules in the datapath that
will need eventual removal but some headers are still required for
the userspace code (which seems counterintuitive but...)

1.  https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393292.html

Greg Rose (6):
   acinclude.m4: Remove support for building the OVS kernel module


I would put this patch later in the series, once packaging, CI and
other scripts passing this option to ./configure have been dropped.

With the whole series applied, we still have references to --with-linux in:
.ci/linux-build.sh


Hi David,

I will update the .ci/linux-build.sh script when I make the change to
support AFXDP builds.


Vagrantfile
utilities/docker/debian/build-kernel-modules.sh
utilities/ovs-dev.py


I've updated these files to remove the --with-linux references as
well as associated  cleanups necessary for that  change.


xenserver/openvswitch-xen.spec.in


This is a bit of an issue.  Does anyone even use xenserver anymore?
All of the documentation and build instructions are really old and
I wonder of they work anymore.   I have no xenserver  build environment
to  test  any changes.

Thanks for all the reviews!

Regards,

- Greg
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Gregory Rose]

On 7/7/2022 2:30 AM, Ilya Maximets wrote:

On 7/7/22 10:27, David Marchand wrote:

Hi Greg,

On Wed, Jul 6, 2022 at 11:57 PM Gregory Rose  wrote:

On 7/6/2022 9:57 AM, Greg Rose wrote:

It is time to remove support for the OVS kernel driver and push
towards use of the upstream Linux openvswitch kernel driver
in it's place [1].

There are many Linux specific source modules in the datapath that
will need eventual removal but some headers are still required for
the userspace code (which seems counterintuitive but...)


The easier would be to move the current copy we have in the datapath/
under the include/openvswitch/ directory.
Am I missing something else?


To my knowledge, there is only one header we need, which is:

   datapath/linux/compat/include/linux/openvswitch.h

include/linux/ should be a good place for it.  So,

   git mv datapath/linux/compat/include/linux/openvswitch.h \
  include/linux/openvswitch.h
   git rm -r datapath

This header is not used directly, it's an input file for scripts
that generate include/odp-netlink.h, included by everything else,
and the datapath-windows/include/OvsDpInterface.h used in windows
datapath implementation.  So, their build targets will need a
path adjustment after moving the header.  See:

   datapath-windows/include/automake.mk
   include/automake.mk

Other than this one header, there is no code used by userspace
in datapath/ directory.

A few more lines will need to be removed from the Makefile.am,
as it seem to use the 'datapath' subdirectory still and requires
a few files from it via AC_CONFIG_SRCDIR/AC_CONFIG_FILES.
We also need to remove the modules_install target and clean up
the dist-hook-git target there.

Best regards, Ilya Maximets.


Thanks Ilya.  I'll see if I can get that to work.  I'm taking all
of David's suggestions as well as yours here and will roll them
up into a V2 of the series.

Regards,

- Greg
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Gregory Rose]

On 7/7/2022 1:27 AM, David Marchand wrote:

Hi Greg,

On Wed, Jul 6, 2022 at 11:57 PM Gregory Rose  wrote:

On 7/6/2022 9:57 AM, Greg Rose wrote:

It is time to remove support for the OVS kernel driver and push
towards use of the upstream Linux openvswitch kernel driver
in it's place [1].

There are many Linux specific source modules in the datapath that
will need eventual removal but some headers are still required for
the userspace code (which seems counterintuitive but...)


The easier would be to move the current copy we have in the datapath/
under the include/openvswitch/ directory.
Am I missing something else?




1.  https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393292.html

Greg Rose (6):
acinclude.m4: Remove support for building the OVS kernel module
rhel: Remove kernel mode spec
rhel: Remove RHEL 6 kernel module spec
tests: Remove support for check-kmod test
Documentation: Remove kernel module documentation
Disable unsupported kernel builds

   .github/workflows/build-and-test.yml  |  53 --
   Documentation/faq/releases.rst|   5 +-
   .../contributing/backporting-patches.rst  |   7 +
   Documentation/intro/install/fedora.rst|  24 -
   Documentation/intro/install/general.rst   |  63 --
   acinclude.m4  | 683 +-
   rhel/automake.mk  |  17 -
   rhel/kmod-openvswitch-rhel6.spec.in   | 123 
   rhel/openvswitch-kmod-fedora.spec.in  | 152 
   tests/automake.mk |   6 -
   10 files changed, 11 insertions(+), 1122 deletions(-)
   delete mode 100644 rhel/kmod-openvswitch-rhel6.spec.in
   delete mode 100644 rhel/openvswitch-kmod-fedora.spec.in



It seems I should have put the last patch first... Will reorder
the series and resend V2.


- In this series, there are mentions of the removal happening in 2.17,
while we are working on 2.18.

- That there are still other things to remove in the rhel/ directory,
I'll try to send a summary by tomorrow.

- We should keep the AF_XDP test and building the kernel should
remain, as Ilya suggested.
https://patchwork.ozlabs.org/project/openvswitch/patch/20220415214245.18948-7-gvrose8...@gmail.com/#2888008




Thanks for this review and the others.  I'll be incorporating these
review suggestions from this and your other responses into a V2
patch series.

- Greg
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[David Marchand]

On Thu, Jul 7, 2022 at 11:31 AM Ilya Maximets  wrote:
>
> On 7/7/22 10:27, David Marchand wrote:
> > Hi Greg,
> >
> > On Wed, Jul 6, 2022 at 11:57 PM Gregory Rose  wrote:
> >> On 7/6/2022 9:57 AM, Greg Rose wrote:
> >>> It is time to remove support for the OVS kernel driver and push
> >>> towards use of the upstream Linux openvswitch kernel driver
> >>> in it's place [1].
> >>>
> >>> There are many Linux specific source modules in the datapath that
> >>> will need eventual removal but some headers are still required for
> >>> the userspace code (which seems counterintuitive but...)
> >
> > The easier would be to move the current copy we have in the datapath/
> > under the include/openvswitch/ directory.
> > Am I missing something else?
>
> To my knowledge, there is only one header we need, which is:
>
>   datapath/linux/compat/include/linux/openvswitch.h
>
> include/linux/ should be a good place for it.  So,
>
>   git mv datapath/linux/compat/include/linux/openvswitch.h \
>  include/linux/openvswitch.h
>   git rm -r datapath
>
> This header is not used directly, it's an input file for scripts
> that generate include/odp-netlink.h, included by everything else,
> and the datapath-windows/include/OvsDpInterface.h used in windows
> datapath implementation.  So, their build targets will need a
> path adjustment after moving the header.  See:
>
>   datapath-windows/include/automake.mk
>   include/automake.mk
>
> Other than this one header, there is no code used by userspace
> in datapath/ directory.
>
> A few more lines will need to be removed from the Makefile.am,
> as it seem to use the 'datapath' subdirectory still and requires
> a few files from it via AC_CONFIG_SRCDIR/AC_CONFIG_FILES.
> We also need to remove the modules_install target and clean up
> the dist-hook-git target there.

+1.

As far as the drop of those datapath/ files are concerned, there are
also some more places to clean, like:
build-aux/initial-tab-allowed-files
configure.ac (which uses datapath/datapath.c presence)
utilities/ovs-dev.py (for ctags)

-- 
David Marchand

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[David Marchand]

On Wed, Jul 6, 2022 at 6:57 PM Greg Rose  wrote:
>
> It is time to remove support for the OVS kernel driver and push
> towards use of the upstream Linux openvswitch kernel driver
> in it's place [1].
>
> There are many Linux specific source modules in the datapath that
> will need eventual removal but some headers are still required for
> the userspace code (which seems counterintuitive but...)
>
> 1.  https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393292.html
>
> Greg Rose (6):
>   acinclude.m4: Remove support for building the OVS kernel module

I would put this patch later in the series, once packaging, CI and
other scripts passing this option to ./configure have been dropped.

With the whole series applied, we still have references to --with-linux in:
.ci/linux-build.sh
Vagrantfile
utilities/docker/debian/build-kernel-modules.sh
utilities/ovs-dev.py
xenserver/openvswitch-xen.spec.in


-- 
David Marchand

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Ilya Maximets]

On 7/7/22 10:27, David Marchand wrote:
> Hi Greg,
> 
> On Wed, Jul 6, 2022 at 11:57 PM Gregory Rose  wrote:
>> On 7/6/2022 9:57 AM, Greg Rose wrote:
>>> It is time to remove support for the OVS kernel driver and push
>>> towards use of the upstream Linux openvswitch kernel driver
>>> in it's place [1].
>>>
>>> There are many Linux specific source modules in the datapath that
>>> will need eventual removal but some headers are still required for
>>> the userspace code (which seems counterintuitive but...)
> 
> The easier would be to move the current copy we have in the datapath/
> under the include/openvswitch/ directory.
> Am I missing something else?

To my knowledge, there is only one header we need, which is:

  datapath/linux/compat/include/linux/openvswitch.h

include/linux/ should be a good place for it.  So,

  git mv datapath/linux/compat/include/linux/openvswitch.h \
 include/linux/openvswitch.h
  git rm -r datapath

This header is not used directly, it's an input file for scripts
that generate include/odp-netlink.h, included by everything else,
and the datapath-windows/include/OvsDpInterface.h used in windows
datapath implementation.  So, their build targets will need a
path adjustment after moving the header.  See:

  datapath-windows/include/automake.mk
  include/automake.mk

Other than this one header, there is no code used by userspace
in datapath/ directory.

A few more lines will need to be removed from the Makefile.am,
as it seem to use the 'datapath' subdirectory still and requires
a few files from it via AC_CONFIG_SRCDIR/AC_CONFIG_FILES.
We also need to remove the modules_install target and clean up
the dist-hook-git target there.

Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[David Marchand]

Hi Greg,

On Wed, Jul 6, 2022 at 11:57 PM Gregory Rose  wrote:
> On 7/6/2022 9:57 AM, Greg Rose wrote:
> > It is time to remove support for the OVS kernel driver and push
> > towards use of the upstream Linux openvswitch kernel driver
> > in it's place [1].
> >
> > There are many Linux specific source modules in the datapath that
> > will need eventual removal but some headers are still required for
> > the userspace code (which seems counterintuitive but...)

The easier would be to move the current copy we have in the datapath/
under the include/openvswitch/ directory.
Am I missing something else?


> >
> > 1.  https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393292.html
> >
> > Greg Rose (6):
> >acinclude.m4: Remove support for building the OVS kernel module
> >rhel: Remove kernel mode spec
> >rhel: Remove RHEL 6 kernel module spec
> >tests: Remove support for check-kmod test
> >Documentation: Remove kernel module documentation
> >Disable unsupported kernel builds
> >
> >   .github/workflows/build-and-test.yml  |  53 --
> >   Documentation/faq/releases.rst|   5 +-
> >   .../contributing/backporting-patches.rst  |   7 +
> >   Documentation/intro/install/fedora.rst|  24 -
> >   Documentation/intro/install/general.rst   |  63 --
> >   acinclude.m4  | 683 +-
> >   rhel/automake.mk  |  17 -
> >   rhel/kmod-openvswitch-rhel6.spec.in   | 123 
> >   rhel/openvswitch-kmod-fedora.spec.in  | 152 
> >   tests/automake.mk |   6 -
> >   10 files changed, 11 insertions(+), 1122 deletions(-)
> >   delete mode 100644 rhel/kmod-openvswitch-rhel6.spec.in
> >   delete mode 100644 rhel/openvswitch-kmod-fedora.spec.in
> >
>
> It seems I should have put the last patch first... Will reorder
> the series and resend V2.

- In this series, there are mentions of the removal happening in 2.17,
while we are working on 2.18.

- That there are still other things to remove in the rhel/ directory,
I'll try to send a summary by tomorrow.

- We should keep the AF_XDP test and building the kernel should
remain, as Ilya suggested.
https://patchwork.ozlabs.org/project/openvswitch/patch/20220415214245.18948-7-gvrose8...@gmail.com/#2888008


-- 
David Marchand

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Gregory Rose]

On 7/6/2022 9:57 AM, Greg Rose wrote:

It is time to remove support for the OVS kernel driver and push
towards use of the upstream Linux openvswitch kernel driver
in it's place [1].

There are many Linux specific source modules in the datapath that
will need eventual removal but some headers are still required for
the userspace code (which seems counterintuitive but...)

1.  https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393292.html

Greg Rose (6):
   acinclude.m4: Remove support for building the OVS kernel module
   rhel: Remove kernel mode spec
   rhel: Remove RHEL 6 kernel module spec
   tests: Remove support for check-kmod test
   Documentation: Remove kernel module documentation
   Disable unsupported kernel builds

  .github/workflows/build-and-test.yml  |  53 --
  Documentation/faq/releases.rst|   5 +-
  .../contributing/backporting-patches.rst  |   7 +
  Documentation/intro/install/fedora.rst|  24 -
  Documentation/intro/install/general.rst   |  63 --
  acinclude.m4  | 683 +-
  rhel/automake.mk  |  17 -
  rhel/kmod-openvswitch-rhel6.spec.in   | 123 
  rhel/openvswitch-kmod-fedora.spec.in  | 152 
  tests/automake.mk |   6 -
  10 files changed, 11 insertions(+), 1122 deletions(-)
  delete mode 100644 rhel/kmod-openvswitch-rhel6.spec.in
  delete mode 100644 rhel/openvswitch-kmod-fedora.spec.in



It seems I should have put the last patch first... Will reorder
the series and resend V2.

- Greg
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 0/6] Remove OVS kernel driver

[Greg Rose]

It is time to remove support for the OVS kernel driver and push
towards use of the upstream Linux openvswitch kernel driver
in it's place [1].

There are many Linux specific source modules in the datapath that
will need eventual removal but some headers are still required for
the userspace code (which seems counterintuitive but...)

1.  https://mail.openvswitch.org/pipermail/ovs-dev/2022-April/393292.html

Greg Rose (6):
  acinclude.m4: Remove support for building the OVS kernel module
  rhel: Remove kernel mode spec
  rhel: Remove RHEL 6 kernel module spec
  tests: Remove support for check-kmod test
  Documentation: Remove kernel module documentation
  Disable unsupported kernel builds

 .github/workflows/build-and-test.yml  |  53 --
 Documentation/faq/releases.rst|   5 +-
 .../contributing/backporting-patches.rst  |   7 +
 Documentation/intro/install/fedora.rst|  24 -
 Documentation/intro/install/general.rst   |  63 --
 acinclude.m4  | 683 +-
 rhel/automake.mk  |  17 -
 rhel/kmod-openvswitch-rhel6.spec.in   | 123 
 rhel/openvswitch-kmod-fedora.spec.in  | 152 
 tests/automake.mk |   6 -
 10 files changed, 11 insertions(+), 1122 deletions(-)
 delete mode 100644 rhel/kmod-openvswitch-rhel6.spec.in
 delete mode 100644 rhel/openvswitch-kmod-fedora.spec.in

-- 
2.17.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev