[Bug 1346245] Review Request: resultsdb_frontend - Frontend for the ResultsDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346245



--- Comment #1 from Ben Rosser  ---
So, first pass looks relatively sane, except as per the newer Python guidelines
you should use the following macros in %build and %install:

%{__python2} setup.py build -> %py2_build
%{__python2} setup.py install --skip-build --root %{buildroot} -> %py2_install

(see https://fedoraproject.org/wiki/Packaging:Python).

It would also be good to use "python2-*" to refer to your Requires and
BuildRequires where possible.

Otherwise I didn't find any blockers, so if you can modernize the Python macros
I'll go ahead with a full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #32 from gil cattaneo  ---
Issues:

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 44 files have
 unknown license. Detailed output of licensecheck in /home/gil/1369213
 -python-django-netjsongraph/licensecheck.txt


./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/lib/d3.min.js
 https://github.com/d3/d3 under BSD 3-Clause License.

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/src/netjsongraph.js
 https://github.com/interop-dev/netjsongraph.js under BSD 3-Clause License.
 All source files are without license headers. Please, ask to upstream to
 confirm the licensing of code and/or content/s. and add  license headers
 licensing of code and/or content/s

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[!]: Package contains no bundled libraries without FPC exception.

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/lib/d3.min.js

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/src/netjsongraph.js
  Please, add: Provides:   bundled(js-netjsongraph) = 0.1
   Provides:   bundled(js-d3) = 3.5.5
  in each Python packages.


python2-django-netjsongraph.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/tests/manage.py /usr/bin/env python
python2-django-netjsongraph.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/tests/manage.py 644 /usr/bin/env python
python3-django-netjsongraph.noarch: E: wrong-script-interpreter
/usr/lib/python3.5/site-packages/tests/manage.py /usr/bin/env python
python3-django-netjsongraph.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/tests/manage.py 644 /usr/bin/env python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375926] Review Request: python-nose2 - Next generation of nicer testing for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375926

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #14 from Neal Gompa  ---
Review comments:

* There are a couple of spelling errors in the descriptions that are valid:
"api" -> "API", "encourging" -> "encouraging". Please fix these.

* I'm ignoring the complaint about the egg-info since it's in the tests and not
installed.

Otherwise, looks great to me. Fix the spelling issues on import.

PACKAGE APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375926] Review Request: python-nose2 - Next generation of nicer testing for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375926



--- Comment #13 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Binary eggs must be removed in %prep
  Note: Binary egg files not removed in %prep:
 
./nose2/tests/functional/support/scenario/tests_in_unzipped_eggs/pkgunegg-0.0.0-py2.7.egg
 
./nose2/tests/functional/support/scenario/tests_in_zipped_eggs/pkgegg-0.0.0-py2.7.egg
  See:
 
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 171 files have unknown license.
 Detailed output of licensecheck in /home/makerpm/1375926-python-
 nose2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-nose2 , python3-nose2
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English 

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #31 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 44 files have
 unknown license. Detailed output of licensecheck in /home/gil/1369213
 -python-django-netjsongraph/licensecheck.txt


./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/lib/d3.min.js
 https://github.com/d3/d3 under BSD 3-Clause License.

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/src/netjsongraph.js
 https://github.com/interop-dev/netjsongraph.js under BSD 3-Clause License.
 All source files are without license headers. Please, ask to upstream to
confirm the
 licensing of code and/or content/s

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[x]: License file installed when any subpackage combination is installed.
[?]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.5/site-
 packages/tests(python3-repoze-who-plugins-sa, python3-custodia,
 python3-journal-brief, python3-django-federated-login,
 python3-oauth2), /usr/lib/python3.5/site-
 packages/tests/__pycache__(python3-repoze-who-plugins-sa,
 python3-custodia, python3-oauth2, python3-django-federated-login),
 /usr/lib/python2.7/site-packages/tests(python-repoze-who-plugins-sa,
 python-libturpial, python-django-federated-login, python-custodia)

[!]: Package contains no bundled libraries without FPC exception.

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/lib/d3.min.js

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/src/netjsongraph.js
  Please, add: Provides:   bundled(js-netjsongraph) = 0.1
   Provides:   bundled(js-d3) = 3.5.5
  in each Python packages.

[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or 

[Bug 1373666] Review Request: hddfancontrol - Control system fan speed by monitoring hard drive temperature

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373666

Tim Flink  changed:

   What|Removed |Added

 CC||tfl...@redhat.com
   Assignee|nob...@fedoraproject.org|tfl...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376869] Review Request: gap-pkg-lpres - Nilpotent quotients of L-presented groups

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376869

Tim Flink  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #1 from Tim Flink  ---

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 13 files have unknown license. Detailed
 output of licensecheck in /home/tflink/code/packages/gap-pkg-
 lpres/1376869-gap-pkg-lpres/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[-]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English 

[Bug 1376869] Review Request: gap-pkg-lpres - Nilpotent quotients of L-presented groups

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376869

Tim Flink  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|tfl...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376869] Review Request: gap-pkg-lpres - Nilpotent quotients of L-presented groups

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376869

Tim Flink  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tfl...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873



--- Comment #12 from Fedora Update System  ---
rubygem-async_sinatra-1.2.1-3.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cd208a3f8a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873



--- Comment #11 from Fedora Update System  ---
rubygem-async_sinatra-1.2.1-3.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-41326fc2f1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374035] Review Request: pimd - The original PIM-SM multicast routing daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374035

John W. Linville  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-09-19 15:54:39



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374035] Review Request: pimd - The original PIM-SM multicast routing daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374035



--- Comment #8 from Fedora Update System  ---
pimd-2.3.2-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a72d1e4a6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873

greg.helli...@gmail.com changed:

   What|Removed |Added

  Flags|needinfo?(greg.hellings@gma |
   |il.com) |



--- Comment #10 from greg.helli...@gmail.com ---
Let me get onto this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377473] Review Request: golang-github-hashicorp-go-version - Library for parsing and verifying versions and version constraints

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377473

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377473] New: Review Request: golang-github-hashicorp-go-version - Library for parsing and verifying versions and version constraints

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377473

Bug ID: 1377473
   Summary: Review Request: golang-github-hashicorp-go-version -
Library for parsing and verifying versions and version
constraints
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://mrunge.fedorapeople.org/reviews/golang-github-hashicorp-go-version/golang-github-hashicorp-go-version.spec

SRPM URL:
https://mrunge.fedorapeople.org/reviews/golang-github-hashicorp-go-version/golang-github-hashicorp-go-version-0-0.1.git7e3c02b.fc24.src.rpm

Description: Library for parsing and verifying versions and version constraints

Fedora Account System Username: mrunge

$ rpmlint golang-github-hashicorp-go-version-0-0.1.git7e3c02b.fc24.src.rpm
golang-github-hashicorp-go-version-devel-0-0.1.git7e3c02b.fc24.noarch.rpm
golang-github-hashicorp-go-version-unit-test-devel-0-0.1.git7e3c02b.fc24.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Koji scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=15709795

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374035] Review Request: pimd - The original PIM-SM multicast routing daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374035



--- Comment #7 from Fedora Update System  ---
pimd-2.3.2-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-5a2920fad0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374035] Review Request: pimd - The original PIM-SM multicast routing daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374035

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 476234] Review Request: mindi-busybox - Busybox version suited for Mindi

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=476234



--- Comment #25 from Bruno Cornec  ---
Updating package references in order to run fedora-review and prepare upload

ftp://ftp.mondorescue.org/fedora/23/x86_64/mindi-busybox-1.21.1-1.fc23.src.rpm
ftp://ftp.mondorescue.org/fedora/23/x86_64/mindi-busybox.spec

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1283296] Review Request: pam-u2f - PAM authentication over U2F

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1283296



--- Comment #22 from Seth Jennings  ---
Wow, so I've slacked off on this package like crazy!  Apologies.

I'm opening new bugs to track the issues raised, since this bug is closed.

Was able to recreate the selinux issue.  Opened this bug against
selinux-policy:
https://bugzilla.redhat.com/show_bug.cgi?id=1377451

FYI, full type enforcement needed is:

module my-login 1.0;

require {
type local_login_t;
type udev_var_run_t;
class file { getattr open read };
}

#= local_login_t ==
allow local_login_t udev_var_run_t:file { getattr open read };

Re: env vars issue, the upstream issue is closed and seems to be address by
1.0.4.  Just need to update the package to that version.  Opening a bug to
track for bodhi purposes:
https://bugzilla.redhat.com/show_bug.cgi?id=1377455

Re: README
https://bugzilla.redhat.com/show_bug.cgi?id=1377459

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377444] Review Request: perl-JSON-WebToken - JSON Web Token (JWT) implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377444

Nick Bebout  changed:

   What|Removed |Added

 Whiteboard||NotReady



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377444] New: Review Request: perl-JSON-WebToken - JSON Web Token ( JWT) implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377444

Bug ID: 1377444
   Summary: Review Request: perl-JSON-WebToken - JSON Web Token
(JWT) implementation
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: n...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://nb.fedorapeople.org/perl-JSON-WebToken.spec
SRPM URL: https://nb.fedorapeople.org/perl-JSON-WebToken-0.10-1.fc24.src.rpm
Description: JSON Web Token (JWT) implementation
Fedora Account System Username: nb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #30 from Germano Massullo  ---
(In reply to gil cattaneo from comment #29)
> So is only a question of branch and not of interpreter. you should change
> the if in corrispondint of the pytho3 package as i wrote  in comment#7

First of all, let's start speaking about line numbers
if you mean that line number 57
%if 0%{?with_python3}
should be replaced with
%if 0%{?el7}
that is a nonsense

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372718] Review Request: rubygem-puma - A simple, fast, threaded, and highly concurrent HTTP 1.1 server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372718



--- Comment #13 from Jun Aruga  ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15708125

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372718] Review Request: rubygem-puma - A simple, fast, threaded, and highly concurrent HTTP 1.1 server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372718



--- Comment #12 from Jun Aruga  ---
Created attachment 1202550
  --> https://bugzilla.redhat.com/attachment.cgi?id=1202550=edit
Fix for Vit Review

Hi Vit,
I uploaded the patch to fix for your review.
Could you check this patch?
Thanks.

- Add openssl-devel dependency to enable HTTPS support.
- Add regenerated parser logic.
- Improve Ruby load path to run test suite.
- Improve files section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366845] Review Request: reactor - Reactive fast data framework for the JVM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366845

gil cattaneo  changed:

   What|Removed |Added

  Flags||needinfo?(pidgornyy@informa
   ||tik.uni-frankfurt.de)



--- Comment #6 from gil cattaneo  ---
@Oles other problems?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #29 from gil cattaneo  ---
(In reply to Germano Massullo from comment #28)
> (In reply to gil cattaneo from comment #27)
> > (In reply to Germano Massullo from comment #26)
> > > gil, lastest files version is at
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1369213#c22
> > 
> > for Fedora python3 should be the default interpreter the reason are
> > summarized in https://bugzilla.redhat.com/show_bug.cgi?id=1346243#c6.
> > I would not have done better ...
> 
> wrong
> 
> Message URL
> https://lists.fedoraproject.org/archives/list/python-devel@lists.
> fedoraproject.org/message/SXVBA55NHTX2XVPVNGFVWJUNIR2Z3WDX/
> 
> ==
> BY Miro Hrončok, core member of Python-SIG
> This package shall (on Fedora) produce two subpackages:
> python2-django-netjsongraph and python3-django-netjsongraph. See an example
> spec here: 
> http://python-rpm-porting.readthedocs.io/en/latest/modules.html#ported-rpm-
> spec-file
> ==

So is only a question of branch and not of interpreter. you should change the
if in corrispondint of the pytho3 package as i wrote  in comment#7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #28 from Germano Massullo  ---
(In reply to gil cattaneo from comment #27)
> (In reply to Germano Massullo from comment #26)
> > gil, lastest files version is at
> > https://bugzilla.redhat.com/show_bug.cgi?id=1369213#c22
> 
> for Fedora python3 should be the default interpreter the reason are
> summarized in https://bugzilla.redhat.com/show_bug.cgi?id=1346243#c6.
> I would not have done better ...

wrong

Message URL
https://lists.fedoraproject.org/archives/list/python-de...@lists.fedoraproject.org/message/SXVBA55NHTX2XVPVNGFVWJUNIR2Z3WDX/

==
BY Miro Hrončok, core member of Python-SIG
This package shall (on Fedora) produce two subpackages:
python2-django-netjsongraph and python3-django-netjsongraph. See an example
spec here: 
http://python-rpm-porting.readthedocs.io/en/latest/modules.html#ported-rpm-spec-file
==

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

gil cattaneo  changed:

   What|Removed |Added

  Flags|needinfo?(puntogil@libero.i |
   |t)  |



--- Comment #27 from gil cattaneo  ---
(In reply to Germano Massullo from comment #26)
> gil, lastest files version is at
> https://bugzilla.redhat.com/show_bug.cgi?id=1369213#c22

for Fedora python3 should be the default interpreter the reason are summarized
in https://bugzilla.redhat.com/show_bug.cgi?id=1346243#c6.
I would not have done better ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369224] Review Request: jackson-modules-base - Jackson modules: Base

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369224

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357724] Review Request: qcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357724



--- Comment #27 from Fedora Update System  ---
qcint-1.8.6-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1227b5a8c2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357724] Review Request: qcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357724



--- Comment #26 from Fedora Update System  ---
qcint-1.8.6-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-74d77b7c2f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357724] Review Request: qcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357724



--- Comment #25 from Fedora Update System  ---
qcint-1.8.6-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6a2888ecbe

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357724] Review Request: qcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357724

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357724] Review Request: qcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357724



--- Comment #24 from Fedora Update System  ---
qcint-1.8.6-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fe321e1eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #26 from Germano Massullo  ---
gil, lastest files version is at
https://bugzilla.redhat.com/show_bug.cgi?id=1369213#c22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

Germano Massullo  changed:

   What|Removed |Added

  Flags||needinfo?(puntogil@libero.i
   ||t)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357728] Review Request: libcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357728



--- Comment #11 from Fedora Update System  ---
libcint-2.8.7-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-fecc59edeb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357728] Review Request: libcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357728



--- Comment #10 from Fedora Update System  ---
libcint-2.8.7-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4d56f839d1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354113



--- Comment #9 from Fedora Update System  ---
python-pytest-catchlog-1.2.2-2.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-42f09d7ea7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354113



--- Comment #10 from Fedora Update System  ---
python-pytest-catchlog-1.2.2-2.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-5ae36859d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354113



--- Comment #8 from Fedora Update System  ---
python-pytest-catchlog-1.2.2-2.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1602d69d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377252] Review Request: perl-Params-ValidationCompiler - Build an optimized subroutine parameter validator once , use it forever

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377252



--- Comment #3 from Fedora Update System  ---
perl-Params-ValidationCompiler-0.13-3.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-04cc921d53

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354113



--- Comment #7 from Fedora Update System  ---
python-pytest-catchlog-1.2.2-2.fc23 has been submitted as an update to Fedora
23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a3e3bff7b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357728] Review Request: libcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357728



--- Comment #9 from Fedora Update System  ---
libcint-2.8.7-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-85faa48618

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377252] Review Request: perl-Params-ValidationCompiler - Build an optimized subroutine parameter validator once , use it forever

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377252

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357728] Review Request: libcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357728

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357728] Review Request: libcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357728



--- Comment #8 from Fedora Update System  ---
libcint-2.8.7-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8bdf95a798

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369232] Review Request: jackson-datatypes-collections - Jackson datatypes: collections

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369232



--- Comment #11 from Fedora Update System  ---
jackson-datatypes-collections-2.7.6-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-493a0cf1dd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377252] Review Request: perl-Params-ValidationCompiler - Build an optimized subroutine parameter validator once , use it forever

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377252



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Params-ValidationCompiler

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369248] Review Request: jackson-datatype-jdk8 - Add-on module for Jackson to support JDK 8 data types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369248



--- Comment #9 from Fedora Update System  ---
jackson-datatype-jdk8-2.7.6-2.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-eb91de5d24

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369534] Review Request: libsass - C/ C++ port of the Sass CSS precompiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369534

Aurelien Bompard  changed:

   What|Removed |Added

  Flags|needinfo?(aurelien@bompard. |
   |org)|



--- Comment #2 from Aurelien Bompard  ---
Done! Files updated, thanks Randy :-)

Spec URL: https://abompard.fedorapeople.org/reviews/sass/libsass.spec
SRPM URL:
https://abompard.fedorapeople.org/reviews/sass/libsass-3.3.6-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369244] Review Request: jackson-datatype-jsr310 - Add-on module to support JSR-310 ( Java 8 Date & Time API) data types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369244



--- Comment #11 from Fedora Update System  ---
jackson-datatype-jsr310-2.7.6-2.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-79a8b90357

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369224] Review Request: jackson-modules-base - Jackson modules: Base

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369224

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369224] Review Request: jackson-modules-base - Jackson modules: Base

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369224



--- Comment #12 from Fedora Update System  ---
jackson-modules-base-2.7.6-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a2a9677a7c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372718] Review Request: rubygem-puma - A simple, fast, threaded, and highly concurrent HTTP 1.1 server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372718



--- Comment #11 from Jun Aruga  ---
(In reply to Vít Ondruch from comment #6)
> Jun, first of all, could you please bump the release between the review
> iterations? Coming late to the review, it is impossible to see what did you
> actually changed in the .spec file.
> 
> 
> * Mark %{gem_instdir}/Manifest.txt as a %doc
>   - %{gem_instdir}/Manifest.txt should be %doc, shouldn't be?

Yes, I would move to %doc.

> * Move %{gem_instdir}/tools into -doc
>   - What is the content of %{gem_instdir}/tools directory? It does not look
> essential to me, hence I'd suggest to move it into -doc subpackage.

The tools includes one test and init scripts for initd and upstart.
Yes, I would move to -doc subpackage.

> * Remove unnecessary seds
>   - Please remove the seds, where you are replacing the BUILD_EXT_DIR and use
> following command to execute the test suite instead:
> 
> ```
> RUBYOPT=-I.:lib:$(dirs +1)%{gem_extdir_mri} ruby \
>-rminitest/autorun \
>-e 'Dir.glob "./test/**/test_*.rb", (:require)' \
> -- -v
> ```
> 
> and
> 
> ```
> RUBYOPT=-I$(dirs +2)%{gem_extdir_mri} sh -x run.sh
> ```

Yes, I would change like your way.

> * Purpose of Patch1?
>   - Not sure about purpose of the Patch1, since if I comment it out and use
> the previous commands, I can execute the test suite just fine => I
> suggest
> to drop this patch altogether.
>   - You are right that upstream is inconsistent in this regard, but I'd say
> that the particular require you are fixing is the way how the test suites
> typically works, while the proposed fix is antipattern. IOW you should
> propose fix fixing all the other files.

I thinks the Patch1 is needed.
Because I got an error without the Patch1. It depends on the order of test.

 sh-4.3#
RUBYOPT=-I.:lib:/builddir/build/BUILD/rubygem-puma-3.6.0/usr/lib64/gems/ruby/puma-3.6.0
\
>   ruby -r minitest/autorun -e 'Dir.glob "./test/test_http11.rb", 
> (:require)' -- -v
/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require': cannot
load such file -- testhelp (LoadError)
  from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
  from
/builddir/build/BUILD/rubygem-puma-3.6.0/usr/share/gems/gems/puma-3.6.0/test/test_http11.rb:4:in
`'
  from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
  from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
  from -e:1:in `glob'
  from -e:1:in `'



When I add "-r test/testhelp", its test was passed.

 sh-4.3#
RUBYOPT=-I.:lib:/builddir/build/BUILD/rubygem-puma-3.6.0/usr/lib64/gems/ruby/puma-3.6.0
\
>   ruby -r minitest/autorun -r test/testhelp -e 'Dir.glob 
> "./test/test_http11.rb", (:require)' -- -v
...
100% passed


> * Missing dependency on openssl-devel
>   - Yes, you have noticed it correctly, that you need openssl-devel to enable
> HTTPS support, which we definitely want on Fedora.

Yes, I would use openssl-devel.

> * Shebangs in %{gem_instdir}/bin
>   - I'd suggest against changing the shebangs. Yes, rpmlint complains about
> them, but these are not executed by enduser typically, so I consider them
> false positive and the rpmlint check too strict.

OK. remove its logic to change the shebangs.

> * Regenerate the parser using Ragel
>   - The extension contains parser in C, generated using Ragel. Since current
> guidelines suggest to regenerate the files [1], it'd be nice if you try
> to
> regenerate them (see the Rakefile for details).

OK, I would do it.

> [1]
> https://fedoraproject.org/wiki/Packaging:Guidelines#Use_of_pregenerated_code


Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377228] Review Request: perl-Test2-Plugin-NoWarnings - Fail if tests warn

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377228



--- Comment #3 from Fedora Update System  ---
perl-Test2-Plugin-NoWarnings-0.02-3.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1d82b2619

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377228] Review Request: perl-Test2-Plugin-NoWarnings - Fail if tests warn

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377228

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376149] Review Request: fedora-obsolete-packages - A package to obsolete retired packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376149

Jason Tibbitts  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-09-19 09:28:34



--- Comment #6 from Jason Tibbitts  ---
That's great, but this package doesn't do any of that.  So... direct your
complaints elsewhere.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374138] Review Request: vim-syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #25 from Fedora Update System  ---
vim-syntastic-3.7.0-6.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-49c8d2132d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374138] Review Request: vim-syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #24 from Fedora Update System  ---
vim-syntastic-3.7.0-6.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-02dede1ec5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374138] Review Request: vim-syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #23 from Fedora Update System  ---
vim-syntastic-3.7.0-6.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f79b82727b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374138] Review Request: vim-syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377252] Review Request: perl-Params-ValidationCompiler - Build an optimized subroutine parameter validator once , use it forever

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377252

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Params-ValidationCompiler-0.13-2.fc26.noarch.rpm |
sort | uniq -c
  1 perl(:MODULE_COMPAT_5.24.0)
  1 perl(Eval::Closure)
  1 perl(Exception::Class)
  1 perl(Exporter)
  1 perl(Params::ValidationCompiler::Compiler)
  1 perl(Params::ValidationCompiler::Exceptions)
  1 perl(Scalar::Util)
  1 perl(Sub::Util) >= 1.40
  1 perl(overload)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Params-ValidationCompiler-0.13-2.fc26.noarch.rpm |
sort | uniq -c
  1 perl(Params::ValidationCompiler) = 0.13
  1 perl(Params::ValidationCompiler::Compiler) = 0.13
  1 perl(Params::ValidationCompiler::Exceptions) = 0.13
  1 perl-Params-ValidationCompiler = 0.13-2.fc26
Binary provides are Ok.

$ rpmlint ./perl-Params-ValidationCompiler*
perl-Params-ValidationCompiler.noarch: W: spelling-error Summary(en_US)
validator -> lavatorial
perl-Params-ValidationCompiler.noarch: W: spelling-error %description -l en_US
uncompromised -> uncompromising, compromised, uncompressed
perl-Params-ValidationCompiler.src: W: spelling-error Summary(en_US) validator
-> lavatorial
perl-Params-ValidationCompiler.src: W: spelling-error %description -l en_US
uncompromised -> uncompromising, compromised, uncompressed
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Rpmlint is ok

BuildRequires are almost ok.
FIX: Please remove 'findutils', it is not used.

Please correct 'FIX' issue.

Otherwise package is ok.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369224] Review Request: jackson-modules-base - Jackson modules: Base

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369224



--- Comment #11 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/jackson-modules-base

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357724] Review Request: qcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357724



--- Comment #23 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/qcint

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377228] Review Request: perl-Test2-Plugin-NoWarnings - Fail if tests warn

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377228



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test2-Plugin-NoWarnings

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357728] Review Request: libcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357728



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libcint

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1211821] Review Request: golang-github-bradfitz-gomemcache - Go Memcached client library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1211821



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-bradfitz-gomemcache

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374138] Review Request: vim-syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #22 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/vim-syntastic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332052] Review Request: python-filelock - A platform independent file lock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332052



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-filelock

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354113



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-pytest-catchlog

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374035] Review Request: pimd - The original PIM-SM multicast routing daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374035



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/pimd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369224] Review Request: jackson-modules-base - Jackson modules: Base

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369224



--- Comment #10 from gil cattaneo  ---
Thanks for the review!

create new SCM request/s:
https://admin.fedoraproject.org/pkgdb/package/requests/7858
https://admin.fedoraproject.org/pkgdb/package/requests/7859

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369224] Review Request: jackson-modules-base - Jackson modules: Base

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369224

Alexander Kurtakov  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Alexander Kurtakov  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
Lisence headers are missing in source files but this is project decision
and is stated in https://github.com/FasterXML/jackson-modules-base/issues/18 by
upstream developers
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 71680 bytes in 13 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency 

[Bug 1357724] Review Request: qcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357724



--- Comment #22 from Susi Lehtola  ---
(In reply to Matt Chan from comment #21)
> (In reply to Susi Lehtola from comment #19)
> > (In reply to Susi Lehtola from comment #18)
> > > Looks good. The review of qcint has been
> > > 
> > > APPROVED
> > 
> > ... on the condition you fix the License tag as was mentioned in Comment #3.
> 
> Hmm? I already changed it to GPLv3+?
> 
> Just making sure before I push it to updates-testing!

... You're right - I blame it on the jet lag. Go ahead!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369224] Review Request: jackson-modules-base - Jackson modules: Base

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369224

Alexander Kurtakov  changed:

   What|Removed |Added

  Flags|needinfo?(akurtako@redhat.c |
   |om) |



--- Comment #8 from Alexander Kurtakov  ---
Latest comment from https://github.com/FasterXML/jackson-modules-base/issues/18
is good to continue work. Will do full review now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376035] Review Request: modulemd - Module metadata manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376035



--- Comment #5 from Miroslav Suchý  ---
(In reply to Petr Šabata from comment #4)
> @Miroslav, I'd actually vote for postponing official packaging until there's
> a stable release with a stable API.  That might happen once we decide how to
> proceed with the module versioning changes we discussed at Flock.

Copr-frontend already use python-modulemd and right now there is broken
dependency. So I want to have it in Fedora as soon as possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377252] Review Request: perl-Params-ValidationCompiler - Build an optimized subroutine parameter validator once , use it forever

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377252

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377228] Review Request: perl-Test2-Plugin-NoWarnings - Fail if tests warn

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377228

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Test2-Plugin-NoWarnings-0.02-2.fc26.noarch.rpm | sort
| uniq -c
  1 perl(:MODULE_COMPAT_5.24.0)
  1 perl(Test2::API)
  1 perl(Test2::Event)
  1 perl(Test2::Util::HashBase)
  1 perl(parent)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.


$ rpm -qp --provides perl-Test2-Plugin-NoWarnings-0.02-2.fc26.noarch.rpm | sort
| uniq -c
  1 perl(Test2::Event::Warning) = 0.02
  1 perl(Test2::Plugin::NoWarnings) = 0.02
  1 perl-Test2-Plugin-NoWarnings = 0.02-2.fc26
Binary provides are Ok.

$ rpmlint ./perl-Test2-Plugin-NoWarnings*
perl-Test2-Plugin-NoWarnings.noarch: W: spelling-error %description -l en_US
diag -> jag, dig, dag
perl-Test2-Plugin-NoWarnings.src: W: spelling-error %description -l en_US diag
-> jag, dig, dag
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

BuildRequires are almost ok.
FIX: Please remove 'findutils', it is not used.

Please correct all 'FIX' issues.

Otherwise the package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377262] New: Review Request: golang-github-go-macaron-gzip - Provides Gzip compress to responses for Macaron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377262

Bug ID: 1377262
   Summary: Review Request: golang-github-go-macaron-gzip -
Provides Gzip compress to responses for Macaron
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://mrunge.fedorapeople.org/reviews/golang-github-go-macaron-gzip/golang-github-go-macaron-gzip.spec

SRPM URL:
https://mrunge.fedorapeople.org/reviews/golang-github-go-macaron-gzip/golang-github-go-macaron-gzip-0-0.1.git4938e9b.fc24.src.rpm

Description: Provides Gzip compress to responses for Macaron

Fedora Account System Username: mrunge

$ rpmlint golang-github-go-macaron-gzip-0-0.1.git4938e9b.fc24.src.rpm
golang-github-go-macaron-gzip-devel-0-0.1.git4938e9b.fc24.noarch.rpm
golang-github-go-macaron-gzip-unit-test-devel-0-0.1.git4938e9b.fc24.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377262] Review Request: golang-github-go-macaron-gzip - Provides Gzip compress to responses for Macaron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377262

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377228] Review Request: perl-Test2-Plugin-NoWarnings - Fail if tests warn

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377228

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377228] Review Request: perl-Test2-Plugin-NoWarnings - Fail if tests warn

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377228

Paul Howarth  changed:

   What|Removed |Added

 Blocks||1377252




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1377252
[Bug 1377252] Review Request: perl-Params-ValidationCompiler - Build an
optimized subroutine parameter validator once, use it forever
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377252] Review Request: perl-Params-ValidationCompiler - Build an optimized subroutine parameter validator once , use it forever

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377252

Paul Howarth  changed:

   What|Removed |Added

 Blocks||1376996, 1376997, 1376998
 Depends On||1377228




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376996
[Bug 1376996] perl-DateTime-1.39 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1376997
[Bug 1376997] perl-DateTime-Locale-1.07 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1376998
[Bug 1376998] perl-DateTime-TimeZone-2.03 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1377228
[Bug 1377228] Review Request: perl-Test2-Plugin-NoWarnings - Fail if tests
warn
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377252] New: Review Request: perl-Params-ValidationCompiler - Build an optimized subroutine parameter validator once , use it forever

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377252

Bug ID: 1377252
   Summary: Review Request: perl-Params-ValidationCompiler - Build
an optimized subroutine parameter validator once, use
it forever
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: p...@city-fan.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Params-ValidationCompiler/branches/fedora/perl-Params-ValidationCompiler.spec

SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Params-ValidationCompiler/perl-Params-ValidationCompiler-0.13-2.fc26.src.rpm

Description:
Create a customized, optimized, non-lobotomized, uncompromised, and thoroughly
specialized parameter checking subroutine.

Fedora Account System Username: pghmcfc

Note: this package is a new requirement for the perl-DateTime stack.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357724] Review Request: qcint - general GTO integrals for quantum chemistry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357724



--- Comment #21 from Matt Chan  ---
(In reply to Susi Lehtola from comment #19)
> (In reply to Susi Lehtola from comment #18)
> > Looks good. The review of qcint has been
> > 
> > APPROVED
> 
> ... on the condition you fix the License tag as was mentioned in Comment #3.

Hmm? I already changed it to GPLv3+?

Just making sure before I push it to updates-testing!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1377229




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1377229
[Bug 1377229] Review Request: golang-github-inconshreveable-log15 -
Structured, composable logging for Go
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1377229




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1377229
[Bug 1377229] Review Request: golang-github-inconshreveable-log15 -
Structured, composable logging for Go
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377229] Review Request: golang-github-inconshreveable-log15 - Structured, composable logging for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377229

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389
 Depends On||1376412, 1377227




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1376412
[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable
writer for windows.
https://bugzilla.redhat.com/show_bug.cgi?id=1377227
[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements
utilities to capture, manipulate, and format call stacks
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377229] New: Review Request: golang-github-inconshreveable-log15 - Structured, composable logging for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377229

Bug ID: 1377229
   Summary: Review Request: golang-github-inconshreveable-log15 -
Structured, composable logging for Go
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://mrunge.fedorapeople.org/reviews/golang-github-inconshreveable-log15/golang-github-inconshreveable-log15.spec

SRPM URL:
https://mrunge.fedorapeople.org/reviews/golang-github-inconshreveable-log15/golang-github-inconshreveable-log15-0-0.1.gitf1f14b4.fc24.src.rpm

Description: Structured, composable logging for Go

Fedora Account System Username: mrunge

$ rpmlint golang-github-inconshreveable-log15-0-0.1.gitf1f14b4.fc24.src.rpm
golang-github-inconshreveable-log15-devel-0-0.1.gitf1f14b4.fc24.noarch.rpm
golang-github-inconshreveable-log15-unit-test-devel-0-0.1.gitf1f14b4.fc24.x86_64.rpm
golang-github-inconshreveable-log15.src: W: spelling-error Summary(en_US)
composable -> compo sable, compo-sable, compos able
golang-github-inconshreveable-log15.src: W: spelling-error %description -l
en_US composable -> compo sable, compo-sable, compos able
golang-github-inconshreveable-log15-devel.noarch: W: spelling-error
Summary(en_US) composable -> compo sable, compo-sable, compos able
golang-github-inconshreveable-log15-devel.noarch: W: spelling-error
%description -l en_US composable -> compo sable, compo-sable, compos able
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377228] New: Review Request: perl-Test2-Plugin-NoWarnings - Fail if tests warn

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377228

Bug ID: 1377228
   Summary: Review Request: perl-Test2-Plugin-NoWarnings - Fail if
tests warn
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: p...@city-fan.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Test2-Plugin-NoWarnings/branches/fedora/perl-Test2-Plugin-NoWarnings.spec

SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Test2-Plugin-NoWarnings/perl-Test2-Plugin-NoWarnings-0.02-2.fc26.src.rpm

Description:
Loading this plugin causes your tests to fail if there any warnings while they
run. Each warning generates a new failing test and the warning content is
outputted via diag.

This module uses $SIG{__WARN__}, so if the code you're testing sets this, then
this module will stop working.

Fedora Account System Username: pghmcfc

Note: this package is a dependency of perl-Params-ValidationCompiler, which is
a new requirement for the perl-DateTime stack.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377227] New: Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377227

Bug ID: 1377227
   Summary: Review Request: golang-github-go-stack-stack -
Implements utilities to capture, manipulate, and
format call stacks
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://mrunge.fedorapeople.org/reviews/golang-github-go-stack-stack/golang-github-go-stack-stack.spec

SRPM URL:
https://mrunge.fedorapeople.org/reviews/golang-github-go-stack-stack/golang-github-go-stack-stack-0-0.1.git100eb0c.fc24.src.rpm

Description: Implements utilities to capture, manipulate, and format call
stacks

Fedora Account System Username: mrunge

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15704382

$ rpmlint golang-github-go-stack-stack-0-0.1.git100eb0c.fc24.src.rpm
golang-github-go-stack-stack-devel-0-0.1.git100eb0c.fc24.noarch.rpm
golang-github-go-stack-stack-unit-test-devel-0-0.1.git100eb0c.fc24.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376900] Review Request: espeak-ng - eSpeak NG Text-to-Speech

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376900

Jaroslav Škarvada  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jskar...@redhat.com
   Assignee|nob...@fedoraproject.org|jskar...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376899

Jaroslav Škarvada  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jskar...@redhat.com
   Assignee|nob...@fedoraproject.org|jskar...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373004] Review Request: rubygem-tzinfo-data - Timezone Data for TZInfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373004



--- Comment #2 from Yanis Guenane  ---
This package was initially created in order to be able to build fluentd[1],
which has it as a dependency.

Per your command and after looking at the TZInfo documentation,

> TZInfo requires a source of timezone data. There are two built-in options:
>
>The separate TZInfo::Data library (the tzinfo-data gem). TZInfo::Data 
> contains a set of Ruby modules that are generated from the IANA Time Zone 
> Database.
>A zoneinfo directory. Most Unix-like systems include a zoneinfo directory 
> containing timezone definitions. These are also generated from the IANA Time 
> Zone Database.
>
> By default, TZInfo::Data will be used. If TZInfo::Data is not available, then 
> TZInfo will search for a zoneinfo directory instead. 

So I will hold-on this one and see if I can proceed further without the need of
this one. Thank you for pointing it out.

[1] https://rubygems.org/gems/fluentd/versions/0.12.5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377038] Review Request: sxhkd - Simple X hotkey daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377038

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #15 from gil cattaneo  ---
Seem all ok now, approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org