[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #14 from yunying@intel.com ---
(In reply to Jared Wallace from comment #13)
> Tried running fedora-review on it, but the build failed...
> 
> Package pkgconfig-1:0.29.1-1.fc25.x86_64 is already installed, skipping.
> No matching package to install: 'pkgconfig(sapi)'
> No matching package to install: 'pkgconfig(tcti-device)'
> No matching package to install: 'pkgconfig(tcti-socket)'
> 
> Not all dependencies satisfied
> Error: Some packages could not be found.
> 
> 
> Given that it builds in copr, may just be my system. I'll take another look
> here in a bit.

Thanks for your comment, Jared.

This package has to be built upon the other new package: tpm2-tss(Bug 1369708).
Tpm2-tss will generate the required packages(sapi/tcti-device/tcti-socket)
which tpm2-tools need for compiling.

On COPR, I add packages "tpm2-tss" & "tpm2-tss-devel" to minimal buildroot of
tpm2-tools, and wait until tpm2-tss package build completed, so that these 2
*tss* packages are available before start building tpm2-tools.

Haven't run fedora-review locally, not sure how it should work..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385441] Review Request: rpmdeplint - Tool to find errors in RPM packages in the context of their dependency graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385441



--- Comment #6 from Parag AN(पराग)  ---
you are right. Sorry was busy yesterday and Internet was down. Its just up.
here is what I propose this package spec
https://pnemade.fedorapeople.org/fedora-work/rpmdeplint.spec

Also, was trying to make this compatible with EPEL7 but I saw there do not
exist python2- names for some packages.

Can you please submit an update?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385441] Review Request: rpmdeplint - Tool to find errors in RPM packages in the context of their dependency graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385441



--- Comment #5 from Dan Callaghan  ---
On second thought, rpmdeplint is also exposing a Python API so I guess for
completeness I should really make this package python-rpmdeplint which produces
python2-rpmdeplint and python3-rpmdeplint. On Fedora the /usr/bin/rpmdeplint
could be the Python 3 version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385441] Review Request: rpmdeplint - Tool to find errors in RPM packages in the context of their dependency graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385441



--- Comment #4 from Dan Callaghan  ---
Yeah, so are you saying for the Fedora package you would prefer it is built
against and runs in python3 instead of python2? I would leave it as python2 for
EPEL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720

Jared Wallace  changed:

   What|Removed |Added

 CC||jared-wall...@us.ibm.com



--- Comment #13 from Jared Wallace  ---
Tried running fedora-review on it, but the build failed...

Package pkgconfig-1:0.29.1-1.fc25.x86_64 is already installed, skipping.
No matching package to install: 'pkgconfig(sapi)'
No matching package to install: 'pkgconfig(tcti-device)'
No matching package to install: 'pkgconfig(tcti-socket)'
Not all dependencies satisfied
Error: Some packages could not be found.


Given that it builds in copr, may just be my system. I'll take another look
here in a bit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382152] Review Request: orpie - scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382152



--- Comment #3 from Jared Wallace  ---
Since it wasn't made clear, this package was orphaned and retired:
https://admin.fedoraproject.org/pkgdb/package/rpms/orpie/

Not sure now if it requires review or not.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382152] Review Request: orpie - scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382152



--- Comment #2 from Jared Wallace  ---
Tried the fedora-review tool, which fails since the original post did not have
raw links. So let's fix that.

Spec:https://bitbucket.org/jared-wallace/orpie/raw/2abe80a8c1e7e7c7a72056e14d72380828ccd937/SPECS/orpie.spec

SRPM:https://bitbucket.org/jared-wallace/orpie/raw/2abe80a8c1e7e7c7a72056e14d72380828ccd937/SRPMS/orpie-1.5.2-1.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358041] Review Request: python3-scipy - Scientific Tools for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358041

Orion Poplawski  changed:

   What|Removed |Added

 Whiteboard|AwaitingSubmitter   |



--- Comment #8 from Orion Poplawski  ---
Sorry for the delay.

(In reply to Antonio Trande from comment #5)
> Package review:
> 
> [!] Permissions on files must be set properly. Executables should be set
> with executable permissions, for example.

> [!] rpmlint must be run on the source rpm and all binary rpms the build
> produces. The output should be posted in the review:


> $ mock --no-clean -r epel-7-x86_64 --shell "rpmlint python3-scipy-debuginfo
> > rpmlint_output-debuginfo.txt"
> 
> python3-scipy-debuginfo.x86_64: W: spurious-executable-perm
> /usr/src/debug/scipy-0.17.1/scipy/special/c_misc/gammasgn.c
> python3-scipy-debuginfo.x86_64: W: spurious-executable-perm
> /usr/src/debug/scipy-0.17.1/scipy/special/c_misc/misc.h
> 'python-bytecode-wrong-magic-value'
> $ mock --no-clean -r epel-7-x86_64 --shell "rpmlint python34-scipy >
> rpmlint_output.txt"
> 
> A lot of 'python-bytecode-wrong-magic-value' and 'non-executable-script'
> errors.

python-bytecode errors are a bug in rpmlint.

* Mon Oct 17 2016 Orion Poplawski  - 0.18.1-1
- Update to 0.18.1
- Fix up file permissions

Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-scipy.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python3-scipy-0.18.1-1.el7.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #9 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package unretired
  Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/package/coot
  See:
 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names

- hicolr-icon-theme should be a Requires package

- /usr/share/icons/hicolor/* directories are owned by hicolr-icon-theme.
  You must list the coot.* image files only.

- All used licenses (GPLv2+ GPLv3+ LGPLv2+ LGPLv3+) are compatible among them.
  I think you can indicate GPLv3+ only as resultant license.

- Use %python2_sitelib instead of %python_sitelib

- I would split off libcoot-* libraries in a separated libcoot sub-package
  in order to obtain

  coot
  libcoot
  libcoot-devel
  coot-doc

  +
  coot-data for all data files

- Please, leave a comment about additional SourceX

- Spec use %global instead of %define unless justified

- Package should not use obsolete m4 macros
 Note: Some obsoleted macros found, see the attachment.
 See: https://fedorahosted.org/FedoraReview/wiki/AutoTools

- Please, fix unused-direct-shlib-dependency warnings


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[?]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later) (with incorrect FSF address)", "LGPL",
 "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated",
 "MIT/X11 (BSD like)", "LGPL (v3 or later)", "LGPL (v2.1 or later)".
 512 files have unknown license. Detailed output of licensecheck in
 /home/sagitter/1359402-coot/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/icons/hicolor/256x256/apps(hicolor-icon-theme, fedora-
 logos), /usr/share/icons/hicolor/96x96/apps(hicolor-icon-theme,
 fedora-logos), /usr/share/icons/hicolor/64x64/apps(hicolor-icon-
 theme), /usr/share/icons/hicolor/96x96(hicolor-icon-theme, fedora-
 logos), /usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme,
 fedora-logos), /usr/share/icons/hicolor/48x48(hicolor-icon-theme,
 fedora-logos), /usr/share/icons/hicolor/48x48/apps(hicolor-icon-theme,
 fedora-logos), /usr/share/icons/hicolor/64x64(hicolor-icon-theme),
 /usr/share/icons/hicolor/256x256(hicolor-icon-theme, fedora-logos),
 /usr/share/icons/hicolor(hicolor-icon-theme, fedora-logos),
 /usr/share/icons/hicolor/scalable(hicolor-icon-theme, fedora-logos)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in coot
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package 

[Bug 1344261] Review Request: warsow - Fast paced 3D first person shooter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344261



--- Comment #6 from Raphael Groner  ---
Are you interested in a review swap? Maybe you can take a look into bug
#1385856?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1016444] ReviewRequest: festige - a GUI frontend to fst and dssi vst (run Windows VST audio plugins under wine)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1016444

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2016-10-17 16:18:44



--- Comment #6 from Raphael Groner  ---
I'll close here. This request looks really dead to me, no response from
requester since years.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1227981] Review Request: budget - Your own personal financial assistant

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227981

Raphael Groner  changed:

   What|Removed |Added

  Flags||needinfo?(williamjmorenor@g
   ||mail.com)



--- Comment #11 from Raphael Groner  ---
Ping?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196920] Review Request: log4shib - C++ logging library for Shibboleth (OpenSAML)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196920

Raphael Groner  changed:

   What|Removed |Added

 Blocks|1385856 |
 Resolution|NOTABUG |DUPLICATE



--- Comment #7 from Raphael Groner  ---


*** This bug has been marked as a duplicate of bug 1385856 ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385856
[Bug 1385856] Review Request: log4shib - C++ logging library for Shibboleth
(OpenSAML)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385856] Review Request: log4shib - C++ logging library for Shibboleth (OpenSAML)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385856

Raphael Groner  changed:

   What|Removed |Added

 Depends On|1196920 |



--- Comment #2 from Raphael Groner  ---
*** Bug 1196920 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1196920
[Bug 1196920] Review Request: log4shib - C++ logging library for Shibboleth
(OpenSAML)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385856] New: Review Request: log4shib - C++ logging library for Shibboleth (OpenSAML)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385856

Bug ID: 1385856
   Summary: Review Request: log4shib - C++ logging library for
Shibboleth (OpenSAML)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: projects...@smart.ms
QA Contact: extras...@fedoraproject.org
CC: extras...@fedoraproject.org, guido.grazi...@gmail.com,
nob...@fedoraproject.org,
package-review@lists.fedoraproject.org,
projects...@smart.ms, raphael.gro...@daasi.de
Depends On: 1196920
Blocks: 1196917, 1196918



+++ This bug was initially created as a clone of Bug #1196920 +++

Spec URL: 
https://guidograzioli.fedorapeople.org/packages/log4shib/log4shib.spec

SRPM URL: 
https://guidograzioli.fedorapeople.org/packages/log4shib/log4shib-1.0.9-1.fc23.src.rpm

Description: 
log4shib is a forked version of log4cpp that has been created for the
Shibboleth project to ensure a consistent, working snapshot that builds
reliably on the necessary platforms.

Fedora Account System Username:guidograzioli

Additional info:
opensaml build is currently (2.4.3) falling back to using log4cpp; for updating
to opensaml 2.5.3 (xmltooling 1.5.3) this package becomes necessary.

--- Additional comment from Michael Schwendt on 2015-03-11 12:55:50 CET ---

> Name:   log4shib
> Group:  Development/Libraries

Runtime library base packages have been in group "System Environment/Libraries"
for many years. The group "Development/Libraries" is for the separate
build-time -devel packages.

Nowadays, the Group tag is optional, however:
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

Reusing a Fedora spec file for EL is not always a good idea, since differences
in updates and rebuilds introduce a lot of irrelevant crap in the %changelog.


> BuildRequires:  gcc-c++

JFYI, it is not necessary yet to add this.
https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2


> %package doc
> Summary:Development documentation for %{name}
> Group:  Development/Libraries

If at all, it would be group "Documentation".


> Requires:   %{name}%{?_isa} = %{version}-%{release}

Although the guidelines don't cover it [yet], documentation packages ought to
stay free of such unnecessary dependencies. It should be possible to install
documentation packages without pulling in unneeded runtime libs and other
dependencies. That is especially true, if the documentation does not need the
base package to be displayed/viewed by the user.


> # Packages are not supposed to add %optflags or %__global_ldflags to *.pcs
> sed -i -e "s|%{optflags}||;s|%{__global_ldflags}||" %{name}.pc

This will require a second look as I've only skimmed over the spec file. It
would be good if the .pc did not add any other unnecessary stuff to
CFLAGS/LDFLAGS.


> %files
> %defattr(-, root, root, 0755)

Superfluous. %defattr is not necessary anymore for a long time, and a change
from the default (-,root,root,-) would need to be explained:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions


> %doc ChangeLog 

There are a couple of other plain text doc files. Why not include them?


> %{_bindir}/log4shib-config

This will need to be checked for multilib conflicts as well as for inserted
CFLAGS/LDFLAGS just like the .pc file.  In case there is a conflict, a common
work-around is to have the script query pkg-config instead of redefining
paths/values itself.

--- Additional comment from Guido Grazioli on 2015-03-11 14:12:00 CET ---

(In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #1)

aaargh, apologies for having been lazy; I didn't handle a new package for quite
some time (ie years) so I'd thought that stealing from the log4cpp spec would
have been a nice way to avoid to go thru the guidelines again. I'll address the
issues shortly, thanks for your time.

--- Additional comment from Raphael Groner (DAASI International) on 2016-08-08
09:51:07 CEST ---

Any news here?

--- Additional comment from Raphael Groner on 2016-10-03 13:44:46 CEST ---

Friendly reminder. Are you still interested in this package?

--- Additional comment from Guido Grazioli on 2016-10-17 14:44:42 CEST ---

No.

--- Additional comment from Raphael Groner on 2016-10-17 20:45:40 CEST ---

This library is needed to update shibboleth stack, I'll take over here.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1196917
[Bug 1196917] Update to opensaml 2.5.3
https://bugzilla.redhat.com/show_bug.cgi?id=1196918
[Bug 1196918] Update xmltooling to 1.5.3
https://bugzilla.redhat.com/show_bug.cgi?id=1196920
[Bug 1196920] Review Request: log4shib - C++ logging library for Shibboleth
(OpenSAML)
-- 
You are receiving this mail because:
You are on the CC list 

[Bug 1197517] Review Request: elmon - Performance monitoring tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197517



--- Comment #12 from Raphael Groner  ---
Maybe you can take a look into bug #1385856?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196920] Review Request: log4shib - C++ logging library for Shibboleth (OpenSAML)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196920

Raphael Groner  changed:

   What|Removed |Added

 Blocks||1385856




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385856
[Bug 1385856] Review Request: log4shib - C++ logging library for Shibboleth
(OpenSAML)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385856] Review Request: log4shib - C++ logging library for Shibboleth (OpenSAML)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385856



--- Comment #1 from Raphael Groner  ---
Spec URL:
https://raphgro.fedorapeople.org/review/daasi/shibboleth/log4shib.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/daasi/shibboleth/log4shib-1.0.9-2.fc25.src.rpm

Fedora Account System Username: raphgro

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16109291

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196920] Review Request: log4shib - C++ logging library for Shibboleth (OpenSAML)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196920



--- Comment #6 from Raphael Groner  ---
This library is needed to update shibboleth stack, I'll take over here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1371296] Review Request: zsh-syntax-highlighting - Fish shell like syntax highlighting for Zsh

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1371296



--- Comment #3 from Raphael Groner  ---
Are you interested in packaging zsh-completions and zsh-autosuggestions, too?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381087] Review Request: python-pandas-datareader - Data readers from the pandas codebase

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381087



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-pandas-datareader

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385728] New: Review Request: perl-Specio-Library-Path-Tiny - Path:: Tiny types and coercions for Specio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385728

Bug ID: 1385728
   Summary: Review Request: perl-Specio-Library-Path-Tiny -
Path::Tiny types and coercions for Specio
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jples...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jplesnik.fedorapeople.org/perl-Specio-Library-Path-Tiny/perl-Specio-Library-Path-Tiny.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-Specio-Library-Path-Tiny/perl-Specio-Library-Path-Tiny-0.04-1.fc26.src.rpm

Description:
This library provides a set of Path::Tiny types and coercions for Specio.
These types can be used with Moose, Moo, Params::ValidationCompiler, and
other modules.


Fedora Account System Username: jples...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385728] Review Request: perl-Specio-Library-Path-Tiny - Path:: Tiny types and coercions for Specio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385728

Jitka Plesnikova  changed:

   What|Removed |Added

 Blocks||1385616




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385616
[Bug 1385616] perl-Code-TidyAll-0.54 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336255] Review Request: vim-wiki - A personal wiki For Vim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336255

Vít Ondruch  changed:

   What|Removed |Added

Summary|Review Request: vimwiki - A |Review Request: vim-wiki -
   |personal wiki For Vim   |A personal wiki For Vim



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336255] Review Request: vimwiki - A personal wiki For Vim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336255

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com



--- Comment #9 from Vít Ondruch  ---
Hi Brad,

I see that you define %{appdata_dir} but you actually don't provide any
appdata. Would you mind to provide some? Its not hard and it is nice to have
them, since your package can be easily installed via Gnome Software then. You
can check AppData section guidelines of guildelines [1] and my vim-commentary
package [2] for inspiration.



[1]
https://fedoraproject.org/wiki/Packaging:AppData#.metainfo.xml_file_creation
[2] http://pkgs.fedoraproject.org/cgit/rpms/vim-commentary.git/tree/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373019] Review Request: python-fuse - Python module that provides a simple interface to FUSE and MacFUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373019



--- Comment #2 from Juan Orti  ---
Hi, thanks for the comments.

I've updated the macros as you said. I will ask upstream to include a license
file.

Spec URL: https://jorti.fedorapeople.org/python-fuse/python-fuse.spec
SRPM URL:
https://jorti.fedorapeople.org/python-fuse/python-fuse-2.0.4-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381087] Review Request: python-pandas-datareader - Data readers from the pandas codebase

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381087



--- Comment #4 from Sergio Pascual  ---
Thank you for the review! 

I will remove the tests for the moment

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744
Bug 1302744 depends on bug 1385223, which changed state.

Bug 1385223 Summary: Review Request: python-rangehttpserver - SimpleHTTPServer 
with support for Range requests
https://bugzilla.redhat.com/show_bug.cgi?id=1385223

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385223] Review Request: python-rangehttpserver - SimpleHTTPServer with support for Range requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385223

Mathieu Bridon  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-10-17 09:31:48



--- Comment #5 from Mathieu Bridon  ---
Package built for F24+, updates created, closing.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #6 from David Moreau Simard  ---
Also, worth mentioning that I've toyed with the idea around also packaging
tests and docs but they are not included in the release tarball.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #5 from David Moreau Simard  ---
@Chandan, yes, I did notice the setup.py had extra requirements that were not
expressed in requirements.txt but it looked to me like they were not used.
Thanks for confirming.

I'm not sure what you mean for the LICENSE and README.md file ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196920] Review Request: log4shib - C++ logging library for Shibboleth (OpenSAML)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196920

Guido Grazioli  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
  Flags|needinfo?(guido.grazioli@gm |
   |ail.com)|
Last Closed||2016-10-17 08:44:42



--- Comment #5 from Guido Grazioli  ---
No.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385223] Review Request: python-rangehttpserver - SimpleHTTPServer with support for Range requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385223



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-rangehttpserver

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-pykwalify

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379778] Review Request: python-diff-match-patch - Algorithms for synchronizing plain text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379778



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-diff-match-patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385180] Review Request: purple-facebook - Facebook protocol plugin for purple2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385180



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/purple-facebook

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1371296] Review Request: zsh-syntax-highlighting - Fish shell like syntax highlighting for Zsh

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1371296



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/zsh-syntax-highlighting

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365839] Review Request: python-django-notifications-hq - GitHub notifications alike app for Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365839



--- Comment #3 from Julien Enselme  ---
I still have a problem with the requires. The list is:

- 'django>=1.7',
- 'django-model-utils>=2.0.3',
- 'jsonfield>=1.0.3',
- 'pytz'

But you only included django and pytz. In addition, from what I see in the
repos, django is called python2-django or python3-django.

Furthermore, I think the requires must go into the proper package (ie python2
deps in the python2 package and python3 deps in the python3 package).
Otherwise, the requirements will not be good.

Can you also launch the included tests or tell my why it's better not to launch
them (unreliable for instance)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381087] Review Request: python-pandas-datareader - Data readers from the pandas codebase

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381087

Julien Enselme  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Julien Enselme  ---
> There several bugs upstream about failing tests. I have enabled tests but the 
> build will not fail on tests failing. Not all tests seem to be installed, so 
> I'm running the tests directly in the source code

I didn't know that. Tests are a should items, and if you know they are
unreliable, you can completely remove the %check section. An alternative could
be to skip only the tests that causes problem (but it may not be possible or
require lots of work).

You now have rpmlint warnings about macro in comments. You can either remove
the line or use double % to avoid them. An alternative way to going to the
buildroot is to set PYTHONPATH to the current working directory.

Anyway, it looks good. Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781



--- Comment #2 from Michal Vala  ---
Spec URL:
https://github.com/sparkoo/sunflow/releases/download/v0.07.3.8097f6d/sunflow.spec
SRPM URL:
https://github.com/sparkoo/sunflow/releases/download/v0.07.3.8097f6d/sunflow-0.07.3-8097f6d.fc24.src.rpm

koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=16105793

* Mon Oct 17 2016 Michal Vala 

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #4 from Chandan Kumar  ---
Hello David,

After doing git grep sseclient and six, found that sseclient and six is not
required but due to present under install_requires in setup.py
https://github.com/thefactory/marathon-python/blob/master/setup.py#L16 and they
will remove in a new release :
https://github.com/thefactory/marathon-python/pull/143

Sorry for the noise, I will post my final review.

Thanks,

Chandan Kumar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105

Chandan Kumar  changed:

   What|Removed |Added

 CC||chku...@redhat.com



--- Comment #3 from Chandan Kumar  ---
Hello David,

Thanks for submitting the review.
Below is the few comments:
[1.] Please also include python-six, python-sseclient (Which is not packaged
yet in fedora) as a Requires as they are required by python-marathon.

For more info check this: https://paste.fedoraproject.org/453831/70149814/

[2.] for LICENSE and README.md file Sources, please submit a patch upstream and
put the link in the spec file.

Rest looks ok to me on a first glance.

Thanks,

Chandan Kumar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381087] Review Request: python-pandas-datareader - Data readers from the pandas codebase

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381087



--- Comment #2 from Sergio Pascual  ---

New files with you changes. There several bugs upstream about failing tests. I
have enabled tests but the build will not fail on tests failing. Not all tests
seem to be installed, so I'm running the tests directly in the source code

Spec URL: https://guaix.fis.ucm.es/~spr/fedora/python-pandas-datareader.spec
SRPM URL:
https://guaix.fis.ucm.es/~spr/fedora/python-pandas-datareader-0.2.1-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1272174] Review Request: golang-github-pmezard-go-difflib - Partial port of Python difflib package to Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272174

Luboš Uhliarik  changed:

   What|Removed |Added

   Fixed In Version||golang-github-pmezard-go-di
   ||fflib-0-0.1.gitf78a839.fc23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365839] Review Request: python-django-notifications-hq - GitHub notifications alike app for Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365839



--- Comment #2 from Sundeep Anand  ---
Thanks for the review. Updated package:

SPEC URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-django-notifications-hq.spec

SRPM URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-django-notifications-hq-1.2-1.fc24.src.rpm

Builds:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16105318
http://koji.fedoraproject.org/koji/taskinfo?taskID=16105327

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385534] Review Request: python-ruamel-ordereddict - Ordered dictionary with Key Insertion Order

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385534

Chandan Kumar  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-ruamel-ordereddict - |python-ruamel-ordereddict -
   |ruamel-ordereddict  | Ordered dictionary with
   ||Key Insertion Order



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385534] New: Review Request: python-ruamel-ordereddict - ruamel-ordereddict

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385534

Bug ID: 1385534
   Summary: Review Request: python-ruamel-ordereddict -
ruamel-ordereddict
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: chku...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://chandankumar.fedorapeople.org/python-ruamel-ordereddict.spec
SRPM URL:
https://chandankumar.fedorapeople.org/python-ruamel-ordereddict-0.4.9-1.fc24.src.rpm
Description: This is an implementation of an ordered dictionary with Key
Insertion Order
(KIO: updates of values do not affect the position of the key), Key Value
Insertion Order (KVIO, an existing key's position is removed and put at 
the back). The standard library module OrderedDict, implemented later,
implements a subset of ordereddict functionality.

Fedora Account System Username: chandankumar
Success Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16105140

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Parag AN(पराग)  ---
Looks good.
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385441] Review Request: rpmdeplint - Tool to find errors in RPM packages in the context of their dependency graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385441



--- Comment #3 from Parag AN(पराग)  ---
Yeah I was just checking spec for py3 compatibility before posting any review.
I see setup.py says its compatible with py3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1149566] Review Request: slurm - Simple LinUx Resource Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1149566



--- Comment #31 from Andrew Elwell  ---
Hi, is there any movement on this? If not I'll start a new package based on the
current upsream release of 16.05.5 (http://slurm.schedmd.com/download.html)

Andrew

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366355] Review Request: acme-tiny - Tiny auditable ACME script for Let's Encrypt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366355



--- Comment #33 from Fedora Update System  ---
acme-tiny-0.1-10.20160810git5a7b4e7.fc23 has been pushed to the Fedora 23
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385441] Review Request: rpmdeplint - Tool to find errors in RPM packages in the context of their dependency graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385441



--- Comment #2 from Dan Callaghan  ---
To make life easier on RHEL7 (so that we don't have to depend on the whole
EPEL7 Python 3 stack).

Internally in our Jenkins we are running rpmdeplint tests on both Python 2 and
Python 3 on Fedora, and we consider Python 3 as fully supported, so we could
switch this package over to it in future.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917



--- Comment #2 from Chandan Kumar  ---
Hello Parag,

Thanks for the review.
Here is the updated
SPEC: https://chandankumar.fedorapeople.org/python-pykwalify.spec
SRPM:
https://chandankumar.fedorapeople.org/python-pykwalify-1.5.1-2.fc24.src.rpm
Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16104193

Thanks,

Chandan Kumar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385441] Review Request: rpmdeplint - Tool to find errors in RPM packages in the context of their dependency graph

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385441



--- Comment #1 from Igor Gnatenko  ---
Is there some reason why it's python2 and not py3?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105

Chandan Kumar  changed:

   What|Removed |Added

 CC||chkumar...@gmail.com
   Assignee|nob...@fedoraproject.org|chkumar...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105

Chandan Kumar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org