[Differential] [Commented On] D2786: [server] Don't send key release for not pressed keys and no double key press

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D2786#51992, @luebking wrote:
  
  > Sounds reasonable enough, but seems to point out an issue in wayland:
  >
  > If clients "somehow" rely on balanced input, are there artificial releases 
when a client looses focus?
  
  
  Yes, on gaining focus it's send all the currently hold keys. The client is 
supposed to stop all autorepeating etc. on focus loss.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D2786

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[kio-extras] [Bug 368877] New: log_kio_sftp log flood

[David Shen via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368877

Bug ID: 368877
   Summary: log_kio_sftp log flood
   Product: kio-extras
   Version: unspecified
  Platform: Gentoo Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: default
  Assignee: plasma-devel@kde.org
  Reporter: davidshe...@gmail.com

When copying files from a remote location to local through sfftp, I saw kdeinit
is loggin "log_kio_sftp" like crazy.

kdeinit5[838]: log_kio_sftp: enqueueChunks
kdeinit5[838]: log_kio_sftp: enqueueChunks done "1"
kdeinit5[838]: log_kio_sftp: enqueueChunks
kdeinit5[838]: log_kio_sftp: enqueueChunks done "1"
kdeinit5[838]: log_kio_sftp: enqueueChunks
kdeinit5[838]: log_kio_sftp: enqueueChunks done "1"


I have tons of logs in my journalist. I wonder if it is necessary, or may be
something is wrong.

I created the sftp connection through the Dolphin GUI.


Reproducible: Always

Steps to Reproduce:
1. Create a connection to a SFTP location
2. Copy a large file from the remote to local
3. Observer log with "journalctl -f"

Actual Results:  
log_kio_sftp log floods

Expected Results:  
Some info. log about kio status

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Updated, 5 lines] D2790: Make application close upon Ctrl+Q

[apol (Aleix Pol Gonzalez)]

apol updated this revision to Diff 6767.
apol added a comment.


  Use Window.close rather than Qt.quit
  
  Gives the opportunity to the application to do something about the
  closing

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2790?vs=6764=6767

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2790

AFFECTED FILES
  src/controls/AbstractApplicationWindow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart, broulik
Cc: broulik, plasma-devel, apol

kwin 5.7.95 update for Qt 5.6

[Jonathan Riddell]

Martin pointed me towards this commit which allows kwin to recompile with Qt 5.6
http://commits.kde.org/kwin/99f491e79914da85213a899574ae36ad2e3c097c
I'm not able to make an updated tar because the translations don't
seem to be in place yet for Plasma/5.8 branch so if you use Qt 5.6
you'll need to add this patch

Jonathan

[Differential] [Changed Subscribers] D2787: Add support for resize only borders on Wayland

[Thomas Lübking]

luebking added inline comments.

INLINE COMMENTS

> abstract_client.cpp:1634
> +const auto margins = decoration()->resizeOnlyBorders();
> +if (!margins.isNull()) {
> +return Toplevel::inputGeometry() + margins;

spare this test and just

  return TopLevel::inputGeometry() + decoration()->resizeOnlyBorders();

resp. even (more controlled, geometry() isn't virtual, but it depends on what 
you really need here)

  return geometry() + decoration()->resizeOnlyBorders();

?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2787

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2786: [server] Don't send key release for not pressed keys and no double key press

[Thomas Lübking]

luebking added a comment.


  Sounds reasonable enough, but seems to point out an issue in wayland:
  
  If clients "somehow" rely on balanced input, are there artificial releases 
when a client looses focus?
  If not, do you end up with several clients in autorepeat (client side? 
really? with different behavior in every toolkit?) mode?
  If yes, are there likewise artificial presses when gaining focus?
  If yes, what happens for a shortcut where client A takes focus to client B on 
keypress X? X entered in B?

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D2786

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D2781: Use KDE_INSTALL_DATAROOTDIR

[heikobecker (Heiko Becker)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI3f2db19b3544: Use KDE_INSTALL_DATAROOTDIR (authored 
by heikobecker).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2781?vs=6748=6766

REVISION DETAIL
  https://phabricator.kde.org/D2781

AFFECTED FILES
  examples/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: heikobecker, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Commented On] D2790: Make application close upon Ctrl+Q

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  You can: http://doc.qt.io/qt-5/qml-qtquick-window-window.html#closing-signal

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, broulik, mart
Cc: broulik, plasma-devel, apol

[Differential] [Updated] D2790: Make application close upon Ctrl+Q

[mart (Marco Martin)]

mart added a comment.


  I would like it done as Kai's suggestion, I would call the signal 
quitRequested?
  about the other ways to quit, i guess it's window closing, which i don't 
think we can intercept in any way?

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, broulik, mart
Cc: broulik, plasma-devel, apol

[Differential] [Accepted] D2781: Use KDE_INSTALL_DATAROOTDIR

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2781

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: heikobecker, #kirigami, mart
Cc: plasma-devel, apol

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

[Fabian Köster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354250

--- Comment #34 from Fabian Köster  ---
(In reply to Kai Uwe Broulik from comment #33)
> I think so. That's why I pushed it this morning, tagging is usually around
> 10 to 12

Great, will test your patch as soon as I updated my system.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Jenkins-kde-ci: sddm-kcm Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/sddm-kcm%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 14:51:38 +
Build duration: 1 min 59 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: plasma-workspace Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 14:42:24 +
Build duration: 14 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 13/13 (100%)FILES 52/72 (72%)CLASSES 52/72 (72%)LINE 2049/5438 
(38%)CONDITIONAL 1413/5380 (26%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 101/135 (75%)CONDITIONAL 
36/66 (55%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/19 (26%)CLASSES 5/19 (26%)LINE 139/3088 (5%)CONDITIONAL 
88/3039 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 49/69 (71%)CONDITIONAL 
17/64 (27%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 39/39 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: polkit-kde-agent-1 Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/polkit-kde-agent-1%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 14:49:12 +
Build duration: 1 min 20 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 1 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 14:38:29 +
Build duration: 3 min 33 sec

CHANGE SET
No changes

[Differential] [Request, 14 lines] D2791: [Kicker RootModel] Show separator only when there are entries before it

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 368854
  FIXED-IN: 5.8.0

TEST PLAN
  Separator shows at the correct position if categories are enabled (tried 
different configurations) and hides if all are disabled.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2791

AFFECTED FILES
  applets/kicker/plugin/rootmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: ksshaskpass Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ksshaskpass%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 14:32:33 +
Build duration: 1 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: kmenuedit Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kmenuedit%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 14:31:08 +
Build duration: 1 min 45 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: kinfocenter Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kinfocenter%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 14:30:48 +
Build duration: 3 min 16 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Re: Review Request 128899: xcursor discovery: modernize

[Jason A. Donenfeld]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128899/
---

(Updated Sept. 15, 2016, 3:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, David Edmundson and Marco Martin.


Repository: plasma-desktop


Description
---

First we remove the fallback code for a version of Xcursor that
corresponds with an X server KDE doesn't even support any more.

Then we reverse the order of tilde expansion and deduplication, which
before was essentially incorrect.

Next we do deduplication properly, using Qt's removeDuplicates function.

Finally we replace the ugly regex with the helper function in
kcoreextras via std::transform.

This work here reflects the recent review and discussion that went into
the nearly identical code in kde-gtk-kcm.


Diffs
-

  kcms/cursortheme/xcursor/thememodel.cpp 
e0cb420b7787261d9b5a54b9c0d448d8dd65a988 

Diff: https://git.reviewboard.kde.org/r/128899/diff/


Testing
---


Thanks,

Jason A. Donenfeld

Re: Review Request 128899: xcursor discovery: modernize

[Jason A. Donenfeld]

> On Sept. 15, 2016, 11:12 a.m., Marco Martin wrote:
> > this is the same patch that appeared in phabricator as well, right?

Sorry for the double post. I posted it here first, before realizing that the 
plasma team prefers Phrabricator. We discussed it there, where it was approved, 
and I pushed the commit to the repo already. So we can close this. :)


- Jason A.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128899/#review99206
---


On Sept. 14, 2016, 10:11 a.m., Jason A. Donenfeld wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128899/
> ---
> 
> (Updated Sept. 14, 2016, 10:11 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> First we remove the fallback code for a version of Xcursor that
> corresponds with an X server KDE doesn't even support any more.
> 
> Then we reverse the order of tilde expansion and deduplication, which
> before was essentially incorrect.
> 
> Next we do deduplication properly, using Qt's removeDuplicates function.
> 
> Finally we replace the ugly regex with the helper function in
> kcoreextras via std::transform.
> 
> This work here reflects the recent review and discussion that went into
> the nearly identical code in kde-gtk-kcm.
> 
> 
> Diffs
> -
> 
>   kcms/cursortheme/xcursor/thememodel.cpp 
> e0cb420b7787261d9b5a54b9c0d448d8dd65a988 
> 
> Diff: https://git.reviewboard.kde.org/r/128899/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason A. Donenfeld
> 
>

Jenkins-kde-ci: khotkeys Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 1 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/khotkeys%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 14:29:33 +
Build duration: 2 min 14 sec

CHANGE SET
No changes

Jenkins-kde-ci: kde-gtk-config Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kde-gtk-config%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 14:27:32 +
Build duration: 1 min 37 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 232/291 
(80%)CONDITIONAL 139/244 (57%)

By packages
  
src
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 174/230 (76%)CONDITIONAL 
81/140 (58%)
tests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 58/61 (95%)CONDITIONAL 
58/104 (56%)

KDE at 20: Plasma 5.8 LTS Beta. Here for the Long Term.

[Jonathan Riddell]

Thursday, 15 September 2016. Today KDE releases a beta of its first Long Term
Support edition of its flagship desktop software, Plasma. This marks the point
where the developers and designers are happy to recommend Plasma for the widest
possible audience be they enterprise or non-techy home users. If you tried a
KDE desktop previously and have moved away, now is the time to re-assess,
Plasma is simple by default, powerful when needed.


Plasma's Comprehensive Features

Take a look at what Plasma offers, a comprehensive selection of features
unparalleled in any desktop software.

Desktop Widgets

Desktop Widgets Desktop Widgets

Cover your desktop in useful widgets to keep you up to date with weather,
amused with comics or helping with calculations.


Get Hot New Stuff

Get Hot New Stuff Get Hot New Stuff

Download wallpapers, window style, widgets, desktop effects and dozens of other
resources straight to your desktop. We work with the new KDE Store to bring you
a wide selection of addons for you to install.


Desktop Search

Desktop Search Desktop Search

Plasma will let you easily search your desktop for applications, folders,
music, video, files... everything you have.


Unified Look

Unified Look Unified Look

Plasma's default Breeze theme has a unified look across all the common
programmer toolkits - Qt 4 & 5, GTK 2 & 3, even LibreOffice.


Phone Integration

Phone Integration Phone Integration

Using KDE Connect you'll be notified on your desktop of text message, can
easily transfer files, have your music silenced during calls and even use your
phone as a remote control.


Infinitely Customisable

Infinitely Customisable Infinitely Customisable

Plasma is simple by default but you can customise it however you like with new
widgets, panels, screens and styles.


New in Plasma 5.8

Unified Boot to Shutdown Artwork

Unified Boot to Shutdown Artwork Unified Boot to Shutdown Artwork

This release brings an all-new login screen design giving you a complete Breeze
startup to shutdown experience. The layout has been tidied up and is more
suitable for workstations that are part of a domain or company network. While
it is much more streamlined, it also allows for greater customizability: for
instance, all Plasma wallpaper plugins, such as slideshows and animated
wallpapers, can now be used on the lock screen.


Right-to-Left Language Support

Right-to-Left Language Support Right-to-Left Language Support

Support for Semitic right-to-left written languages, such as Hebrew and Arabic,
has been greatly improved. Contents of panels, the desktop, and configuration
dialogs are mirrored in this configuration. Plasma’s sidebars, such as widget
explorer, window switcher, activity manager, show up on the right side of the
screen.


Improved Applets

Context Menu Media Controls Context Menu Media Controls

The virtual desktop switcher (“Pager”) and window list applets have been
rewritten, using the new task manager back-end we introduced in Plasma 5.7.
This allows them to use the same dataset as the task manager and improves their
performance while reducing memory consumption. The virtual desktop switcher
also acquired an option to show only the current screen in multi-screen setups
and now shares most of its code with the activity switcher applet.

Task manager gained further productivity features in this release. Media
controls that were previously available in task manager tooltips only are now
accessible in the context menus as well. In addition to bringing windows to the
front during a drag and drop operation, dropping files onto task manager
entries themselves will now open them in the associated application. Lastly,
the popup for grouped windows can now be navigated using the keyboard and text
rendering of its labels has been improved.


Simplified Global Shortcuts

Global Shortcuts Setup Global Shortcuts Setup

Global shortcuts configuration has been simplified to focus on the most common
task, that is launching applications. Building upon the jump list functionality
added in previous releases, global shortcuts can now be configured to jump to
specific tasks within an application.

Thanks to our Wayland effort, we can finally offer so-called “modifier-only
shortcuts”, enabling you to open the application menu by just pressing the Meta
key. Due to popular demand, this feature also got backported to the X11
session.

Other improvements

Plasma Discover's new UI Plasma Discover's new UI

This release sees many bugfixes in multi-screen support and, together with Qt
5.6.1, should significantly improve your experience with docking stations and
projectors.

KWin, Plasma’s window manager, now allows compositing through llvmpipe, easing
the deployment on exotic hardware and embedded devices. Now that there is a
standardized and widely-used interface for applications to request turning off
compositing, the “Unredirect Fullscreen” option has been removed. It often lead
to stability issues and because of that was already 

[Differential] [Accepted] D2790: Make application close upon Ctrl+Q

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.


  Ok, so if this is a general problem with Kirigami, fine, but needs to be 
addressed eventually.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart, broulik
Cc: broulik, plasma-devel, apol

[Differential] [Commented On] D2790: Make application close upon Ctrl+Q

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  In https://phabricator.kde.org/D2790#51966, @broulik wrote:
  
  > So, Ctrl+Q always quits without confirmation? What about having a
  >
  >   singal aboutToQuit(var event)
  >
  > and then do:
  >
  >   onActivated: {
  >   var event = {accepted: false}
  >   aboutToQuit(event);
  >   if (!event.accepted) {
  >   Qt.quit();
  >   }
  >   }
  >
  > Then an app can
  >
  >   onAboutToQuit: {
  >   if (hasUnsavedChanges) {
  >   event.accepted = true;
  >   // ask for confirmation
  >   }
  >   }
  
  
  That could be interesting but could be out of scope for the patch? There's 
other ways the application can be closed.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Updated] D2790: Make application close upon Ctrl+Q

[apol (Aleix Pol Gonzalez)]

apol updated the summary for this revision.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Commented On] D2790: Make application close upon Ctrl+Q

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  So, Ctrl+Q always quits without confirmation? What about having a
  
singal aboutToQuit(var event)
  
  and then do:
  
onActivated: {
var event = {accepted: false}
aboutToQuit(event);
if (!event.accepted) {
Qt.quit();
}
}
  
  Then an app can
  
onAboutToQuit: {
if (hasUnsavedChanges) {
event.accepted = true;
// ask for confirmation
}
}

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Updated] D2790: Make application close upon Ctrl+Q

[apol (Aleix Pol Gonzalez)]

apol marked an inline comment as done.
apol added a comment.


  Thanks!

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Updated, 5 lines] D2790: Make application close upon Ctrl+Q

[apol (Aleix Pol Gonzalez)]

apol updated this revision to Diff 6764.
apol added a comment.


  Turns out it was already there

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2790?vs=6763=6764

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2790

AFFECTED FILES
  src/controls/AbstractApplicationWindow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Changed Subscribers] D2790: Make application close upon Ctrl+Q

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> AbstractApplicationWindow.qml:293
> +Shortcut {
> +sequence: "Ctrl+Q"
> +onActivated: Qt.quit()

StandardKey.Quit should work (in Qt 5.2 iirc)

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2790

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol

[Differential] [Request, 5 lines] D2790: Make application close upon Ctrl+Q

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Should possibly integrate with the system's defaults but
  shortcuts are not abstracted out just yet.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2790

AFFECTED FILES
  src/controls/AbstractApplicationWindow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

Review Request 128919: Search for a Prison version that actually exists

[Antonio Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128919/
---

Review request for Plasma, Martin Gräßlin and Leslie Zhai.


Repository: plasma-workspace


Description
---

Prison is not yet in Frameworks, and its version number in git HEAD is still 
5.25


Diffs
-

  klipper/CMakeLists.txt 6db2d79 

Diff: https://git.reviewboard.kde.org/r/128919/diff/


Testing
---

Prison is detected and support is compiled again.


Thanks,

Antonio Rojas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 341 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/341/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 12:20:16 +
Build duration: 23 min

CHANGE SET
Revision 9deba0bc1ccdb919d6b7f91b72e3fdc83d656cae by Jonathan Riddell: (Update 
version number for 5.8.90 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

[Differential] [Request, 28 lines] D2789: [shell] Pass the panel visibility mode to KWayland PanelBehavior

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The visibility mode needs to be passed to KWayland by mapping to the
  PanelBehavior. This is required to pass the correct hint to KWin to
  adjust the layering, etc.
  
  BUG: 368499

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  panel-behavior-5.8

REVISION DETAIL
  https://phabricator.kde.org/D2789

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 19 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 12:14:08 +
Build duration: 3 min 29 sec

CHANGE SET
Revision e91b7b7e040de4f51b5af6895ceacbdc23ca6dad by Jonathan Riddell: (Update 
version number for 5.8.90 GIT_SILENT)
  change: edit CMakeLists.txt

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 340 - Still unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/340/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 11:14:07 +
Build duration: 33 min

CHANGE SET
Revision 2aa990b7fb8de5f80b5c1221ce373585d1dec4a7 by hein: (Fix XML.)
  change: edit applets/kicker/package/contents/config/main.xml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

[Differential] [Request, 50 lines] D2788: Fix whether a panel is supposed to have a strut in ShellClient

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  The PanelBehavior was incorrectly mapped to hasStrut resulting in too
  many modes creating a strut for the panel.
  
  CCBUG: 368499

REPOSITORY
  rKWIN KWin

BRANCH
  plasma-surface-panel-strut-5.8

REVISION DETAIL
  https://phabricator.kde.org/D2788

AFFECTED FILES
  autotests/integration/plasma_surface_test.cpp
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Plasma/5.8 branched

[Jonathan Riddell]

Plasma/5.8 branches have now been made.

Please continue to make lots of bug fixes to 5.8 so we can make a .0
release with no bugs :)

master will become Plasma/5.9

Jonathan

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

> On Sept. 15, 2016, 11:11 vorm., Marco Martin wrote:
> > doc/kcontrol/cache/index.docbook, line 19
> > 
> >
> > shouldn't it be updated as well?

see my description
the docbooks are imported as they were splitted from kde-runtime, any other 
necessary changes/updates will happen in a separate RRs/commits
That way we can distinguish what was imported from the source repo and what was 
changed in the target repo so we have a much clearer history


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review99205
---


On Sept. 15, 2016, 9:09 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 9:09 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

[Burkhard Lück]

> On Sept. 15, 2016, 11:07 vorm., Marco Martin wrote:
> > doc/kcontrol/filetypes/index.docbook, line 19
> > 
> >
> > kde 4.12?

see my description
the docbook is imported as it was splitted from kde-runtime, any other 
necessary changes will happen in a separate RR/commit
That way we can distinguish what was imported from the source repo and what was 
changed in the target repo so we have a much clearer history


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128914/#review99204
---


On Sept. 15, 2016, 9:08 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128914/
> ---
> 
> (Updated Sept. 15, 2016, 9:08 vorm.)
> 
> 
> Review request for Documentation, Localization and Translation (l10n) and 
> Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> doc/kcontrol/filetypes/ splitted from kde-runtime master using 
> https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbook ismported as it was splitted
> 
> To be done next:
> adapt CMakeLists.txt, change dtd to kf5, 
> reapply one update done in plasma-desktop
> make co-installable, see https://git.reviewboard.kde.org/r/128912/
> remove this imported kcontrol docbook from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/filetypes/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/filetypes/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128914/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol-kio-cli-tools.output, same log 
> in kde-runtime master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol-kio-cli-tools.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/32f72127-aa97-4393-88e1-d830e35dbfe2__git-log-doc-kcontrol-kio-cli-tools.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 105319: DBus-interface for changing wallpapers

[Varun Herale]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/105319/
---

(Updated Sept. 15, 2016, 11:33 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: kde-workspace


Description
---

This patch is for hosting a dbus-interface that can be used to load any 
installed wallpaper plugin onto current desktop containment. In case of default 
"image" plugin, the path to the image can also be sent which will change the 
wallpaper.  


Diffs
-

  plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
  plasma/desktop/shell/plasmaapp.h 6ae0c89 
  plasma/desktop/shell/plasmaapp.cpp 7abd8fc 

Diff: https://git.reviewboard.kde.org/r/105319/diff/


Testing
---

Tested on different activities and made sure it works for per-virtual desktop 
containment.

Haven't tested on a system with multiple screens though, as I don't have access 
to one. Could someone please test for that ?


Thanks,

Varun Herale

Re: Review Request 125743: Keep aspect ratio in default KSplash background

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125743/
---

(Updated Sept. 15, 2016, 11:33 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

I'm just not sure if it's better to do Fit or Crop. I went with Fit as that 
simply fits the whole artwork, but let me know if you think differently.

Ideally this should use a wallpaper package for the background, but I don't 
know how to use it from QML (if possible at all).

Issues with Fit:
* If the image is different aspect ratio than the screen, it would add black 
borders either above/below or left/right

Issues with Crop:
* if the image has bigger resolution than the screen, it will get cropped to be 
the screen resolution, so eg. the distro ships 1920x1200 wallpaper and on 
1024x768 the crop would be quite big (the image would still be centered so 
cropped on the sides)


Diffs
-

  lookandfeel/contents/splash/Splash.qml fdeb1ea 

Diff: https://git.reviewboard.kde.org/r/125743/diff/


Testing
---


Thanks,

Martin Klapetek

Re: Review Request 115192: Fix building 32bit target on 64bit machine

[Andrius da Costa Ribas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115192/
---

(Updated Sept. 15, 2016, 11:18 a.m.)


Status
--

This change has been discarded.


Review request for kdewin and Plasma.


Repository: kdeplasma-addons


Description
---

with_SSE2_explicitly_enabled_if_x86 namespace is only implemented with 
THIS_PATH_WITH_SSE2_EXPLICTLY_ENABLED defined, this symbol is defined in 
render_with_SSE2_explicitly_enabled.cpp, but this source is only built when 
using a 32bit processor. In my case HAVE_PATH_WITH_SSE2_EXPLICITLY_ENABLED is 
defined, though, in global.h, since this is not a 64bit target.


Diffs
-

  wallpapers/mandelbrot/renderthread.cpp c1b5c60 

Diff: https://git.reviewboard.kde.org/r/115192/diff/


Testing
---

Tested using MSVC 2010, 32bit target, with ${CMAKE_SYSTEM_PROCESSOR}=AMD64 
(it's a x86_64 processor)


Thanks,

Andrius da Costa Ribas

Re: Review Request 128899: xcursor discovery: modernize

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128899/#review99206
---


Ship it!




this is the same patch that appeared in phabricator as well, right?

- Marco Martin


On Sept. 14, 2016, 10:11 a.m., Jason A. Donenfeld wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128899/
> ---
> 
> (Updated Sept. 14, 2016, 10:11 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> First we remove the fallback code for a version of Xcursor that
> corresponds with an X server KDE doesn't even support any more.
> 
> Then we reverse the order of tilde expansion and deduplication, which
> before was essentially incorrect.
> 
> Next we do deduplication properly, using Qt's removeDuplicates function.
> 
> Finally we replace the ugly regex with the helper function in
> kcoreextras via std::transform.
> 
> This work here reflects the recent review and discussion that went into
> the nearly identical code in kde-gtk-kcm.
> 
> 
> Diffs
> -
> 
>   kcms/cursortheme/xcursor/thememodel.cpp 
> e0cb420b7787261d9b5a54b9c0d448d8dd65a988 
> 
> Diff: https://git.reviewboard.kde.org/r/128899/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason A. Donenfeld
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review99205
---




doc/kcontrol/cache/index.docbook (line 19)


shouldn't it be updated as well?


- Marco Martin


On Sept. 15, 2016, 9:09 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 9:09 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128914/#review99204
---




doc/kcontrol/filetypes/index.docbook (line 19)


kde 4.12?


- Marco Martin


On Sept. 15, 2016, 9:08 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128914/
> ---
> 
> (Updated Sept. 15, 2016, 9:08 a.m.)
> 
> 
> Review request for Documentation, Localization and Translation (l10n) and 
> Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> doc/kcontrol/filetypes/ splitted from kde-runtime master using 
> https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbook ismported as it was splitted
> 
> To be done next:
> adapt CMakeLists.txt, change dtd to kf5, 
> reapply one update done in plasma-desktop
> make co-installable, see https://git.reviewboard.kde.org/r/128912/
> remove this imported kcontrol docbook from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/filetypes/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/filetypes/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128914/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol-kio-cli-tools.output, same log 
> in kde-runtime master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol-kio-cli-tools.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/32f72127-aa97-4393-88e1-d830e35dbfe2__git-log-doc-kcontrol-kio-cli-tools.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128915: resize the view just after setting the containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/
---

(Updated Sept. 15, 2016, 7:05 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 8f10b73cc1054cdf8faddc01c304c7604c25a162 by Marco Martin 
to branch master.


Repository: plasma-framework


Description
---

when the view is in SizeRootObjectToView mode, the root object is resized in 
the event handler, that is too late at startup.
resize the root object right after having announced the new containment, so the 
view subclass can have the view resized to the proper size beforehand, removing 
an useless containment graphicsobject resize.


Diffs
-

  src/plasmaquick/containmentview.cpp 8517099 

Diff: https://git.reviewboard.kde.org/r/128915/diff/


Testing
---


Thanks,

Marco Martin

Re: Review Request 128915: resize the view just after setting the containment

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/#review99202
---


Ship it!




Ship It!

- David Edmundson


On Sept. 15, 2016, 10:57 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128915/
> ---
> 
> (Updated Sept. 15, 2016, 10:57 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> when the view is in SizeRootObjectToView mode, the root object is resized in 
> the event handler, that is too late at startup.
> resize the root object right after having announced the new containment, so 
> the view subclass can have the view resized to the proper size beforehand, 
> removing an useless containment graphicsobject resize.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/containmentview.cpp 8517099 
> 
> Diff: https://git.reviewboard.kde.org/r/128915/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

[Differential] [Closed] D2766: More config descriptions

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.
Closed by commit rPLASMAWORKSPACEec8b02a7c417: More config descriptions 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2766?vs=6733=6758#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2766?vs=6733=6758

REVISION DETAIL
  https://phabricator.kde.org/D2766

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/lock_logout/contents/config/main.xml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, hein, #plasma, mart
Cc: mart, hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2785: Fix panel spacer

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  > some time ago on old qt releases i noticed that the layouts ignored items 
with one of the sizes as 0 (even height for an horizontal one) does it work now?
  
  I didn't notice any problems, is there anything specific I can test?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2785

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128915: resize the view just after setting the containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/
---

(Updated Sept. 15, 2016, 10:57 a.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

when the view is in SizeRootObjectToView mode, the root object is resized in 
the event handler, that is too late at startup.
resize the root object right after having announced the new containment, so the 
view subclass can have the view resized to the proper size beforehand, removing 
an useless containment graphicsobject resize.


Diffs (updated)
-

  src/plasmaquick/containmentview.cpp 8517099 

Diff: https://git.reviewboard.kde.org/r/128915/diff/


Testing
---


Thanks,

Marco Martin

Re: Review Request 128915: resize the view just after setting the containment

[Marco Martin]

> On Sept. 15, 2016, 10:01 a.m., Aleix Pol Gonzalez wrote:
> > src/plasmaquick/containmentview.cpp, line 101
> > 
> >
> > Wouldn't it be better to pass the size with the incubation properties?
> 
> Marco Martin wrote:
> hmm, you can't access it for the item that you load with setSource i 
> think?
> 
> Aleix Pol Gonzalez wrote:
> Yes, I looked into it and it would be possible but only to whoever 
> constructs the object, as it's being incubated within the Containment.
> 
> It might be worth looking into though, as the values set there will be 
> initialized before the properties are bound. Possibly it doesn't even make 
> sense to have the item created before it has a view altogether.

that is internal behavior of qquickview tough, not really relevant there, 
unless you want to try to patch qquickview itself, which may make sense


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/#review99192
---


On Sept. 15, 2016, 9:20 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128915/
> ---
> 
> (Updated Sept. 15, 2016, 9:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> when the view is in SizeRootObjectToView mode, the root object is resized in 
> the event handler, that is too late at startup.
> resize the root object right after having announced the new containment, so 
> the view subclass can have the view resized to the proper size beforehand, 
> removing an useless containment graphicsobject resize.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/containmentview.cpp 8517099 
> 
> Diff: https://git.reviewboard.kde.org/r/128915/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

Re: Review Request 128915: resize the view just after setting the containment

[Marco Martin]

> On Sept. 15, 2016, 10:34 a.m., David Edmundson wrote:
> > src/plasmaquick/containmentview.cpp, line 137
> > 
> >
> > does it render this redundant?
> 
> Aleix Pol Gonzalez wrote:
> Otherwise it could make sense to statically have an `anchors.fill: 
> parent`.

I don't think so, as this is resizing the graphics object that is the instance 
of appletinterface, that is a different item than rootObject()


> On Sept. 15, 2016, 10:34 a.m., David Edmundson wrote:
> > src/plasmaquick/containmentview.cpp, line 140
> > 
> >
> > this if isn't very useful now.
> > If it was null, we'd have crashed already.
> 
> Aleix Pol Gonzalez wrote:
> Good catch. In fact this should also get outside the initial if 
> altogether. If graphicObject is nullptr it still should be set.

hmm, i would rather guard the access to rootobject above


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/#review99195
---


On Sept. 15, 2016, 9:20 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128915/
> ---
> 
> (Updated Sept. 15, 2016, 9:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> when the view is in SizeRootObjectToView mode, the root object is resized in 
> the event handler, that is too late at startup.
> resize the root object right after having announced the new containment, so 
> the view subclass can have the view resized to the proper size beforehand, 
> removing an useless containment graphicsobject resize.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/containmentview.cpp 8517099 
> 
> Diff: https://git.reviewboard.kde.org/r/128915/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

[Differential] [Commented On] D2778: Expose the banner sourceSize

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  In https://phabricator.kde.org/D2778#51900, @mart wrote:
  
  > patch in general makes sense
  >
  > but are you sure svg doesn't export a soucesize? (svgs do have a size in 
pixels in their root layer and qtsvg supports it)
  
  
  Of course it does, but it's a size, here we're not interested in giving it a 
size, we just should make sure it fits the banner.
  We could set a 5000x3000 size, but then we'd be rendering it too big then 
scaling it down.
  
  If you ask me, we should just make Kirigami enforce the look of the banner 
(despite the developer adding a strictly vertical image), then this property 
wouldn't be required.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2778

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

Re: Review Request 120563: Add support for installing .comic packages again to plasmapkg2.

[Andrei Amuraritei]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120563/
---

(Updated Sept. 15, 2016, 10:50 a.m.)


Status
--

This change has been discarded.


Review request for Plasma, Bhushan Shah, David Edmundson, Marco Martin, and 
Martin Klapetek.


Repository: plasma-framework


Description
---

This adds support for installing .comic type packages with plasmapkg2. This 
comes to help the comic dataengine port to frameworks, and permits the user to 
install .comic packages.


Diffs
-

  src/plasmapkg/plasmapkg.cpp 7d55d0f 

Diff: https://git.reviewboard.kde.org/r/120563/diff/


Testing
---

Apply patch, rebuild plasma-framework, compile ok. Then install a .comic 
package from kde-files.org Plasma/Comics with plasmapkg2 -t comic -i 
~/Downloads/garfield.comic. 

Expected results:

Install method:
plasmapkg2 -t comic -i ~/Downloads/92037-garfield.comic

pluginname:  "garfield"
-- Copying  
"/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" 
"/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop"
Copying metadata went ok.
Successfully installed /home/developer/Downloads/92037-garfield.comic

Remove method:
plasmapkg2 -t comic -r ~/Downloads/92037-garfield.comic

Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5"
Successfully uninstalled /home/developer/Downloads/92037-garfield.comic

Upgrade method:
plasmapkg2 -t comic -u ~/Downloads/92037-garfield.comic

Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5"
Upgrading package from file: /home/developer/Downloads/92037-garfield.comic
pluginname:  "garfield"
-- Copying  
"/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" 
"/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop"
Copying metadata went ok.
Successfully upgraded /home/developer/Downloads/92037-garfield.comic


Thanks,

Andrei Amuraritei

Re: Review Request 120563: Add support for installing .comic packages again to plasmapkg2.

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120563/#review99198
---



dropping this as comic packages are supposed to be installed with kpackagetool5 
instead (that's what knewstuff is using currently)

- Marco Martin


On Oct. 12, 2014, 4:05 p.m., Andrei Amuraritei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120563/
> ---
> 
> (Updated Oct. 12, 2014, 4:05 p.m.)
> 
> 
> Review request for Plasma, Bhushan Shah, David Edmundson, Marco Martin, and 
> Martin Klapetek.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This adds support for installing .comic type packages with plasmapkg2. This 
> comes to help the comic dataengine port to frameworks, and permits the user 
> to install .comic packages.
> 
> 
> Diffs
> -
> 
>   src/plasmapkg/plasmapkg.cpp 7d55d0f 
> 
> Diff: https://git.reviewboard.kde.org/r/120563/diff/
> 
> 
> Testing
> ---
> 
> Apply patch, rebuild plasma-framework, compile ok. Then install a .comic 
> package from kde-files.org Plasma/Comics with plasmapkg2 -t comic -i 
> ~/Downloads/garfield.comic. 
> 
> Expected results:
> 
> Install method:
> plasmapkg2 -t comic -i ~/Downloads/92037-garfield.comic
> 
> pluginname:  "garfield"
> -- Copying  
> "/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" 
> "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop"
> Copying metadata went ok.
> Successfully installed /home/developer/Downloads/92037-garfield.comic
> 
> Remove method:
> plasmapkg2 -t comic -r ~/Downloads/92037-garfield.comic
> 
> Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5"
> Successfully uninstalled /home/developer/Downloads/92037-garfield.comic
> 
> Upgrade method:
> plasmapkg2 -t comic -u ~/Downloads/92037-garfield.comic
> 
> Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5"
> Upgrading package from file: /home/developer/Downloads/92037-garfield.comic
> pluginname:  "garfield"
> -- Copying  
> "/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" 
> "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop"
> Copying metadata went ok.
> Successfully upgraded /home/developer/Downloads/92037-garfield.comic
> 
> 
> Thanks,
> 
> Andrei Amuraritei
> 
>

Re: Review Request 128915: resize the view just after setting the containment

[Aleix Pol Gonzalez]

> On Sept. 15, 2016, 12:34 p.m., David Edmundson wrote:
> > src/plasmaquick/containmentview.cpp, line 137
> > 
> >
> > does it render this redundant?

Otherwise it could make sense to statically have an `anchors.fill: parent`.


> On Sept. 15, 2016, 12:34 p.m., David Edmundson wrote:
> > src/plasmaquick/containmentview.cpp, line 140
> > 
> >
> > this if isn't very useful now.
> > If it was null, we'd have crashed already.

Good catch. In fact this should also get outside the initial if altogether. If 
graphicObject is nullptr it still should be set.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/#review99195
---


On Sept. 15, 2016, 11:20 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128915/
> ---
> 
> (Updated Sept. 15, 2016, 11:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> when the view is in SizeRootObjectToView mode, the root object is resized in 
> the event handler, that is too late at startup.
> resize the root object right after having announced the new containment, so 
> the view subclass can have the view resized to the proper size beforehand, 
> removing an useless containment graphicsobject resize.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/containmentview.cpp 8517099 
> 
> Diff: https://git.reviewboard.kde.org/r/128915/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 339 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/339/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 09:49:10 +
Build duration: 5 min 17 sec

CHANGE SET
Revision 4458f4d29fad0dd89e0cb9ff7fe1cc7c3a9f0c37 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/colors/org.kde.kcolorschemeeditor.desktop

Re: Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

[Raphael Kugelmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125416/
---

(Updated Sept. 15, 2016, 10:44 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 70e339f3d0d0aff16559f198ac4c6dc5f6c90111 by David 
Edmundson on behalf of Raphael Kugelmann to branch master.


Bugs: 328807
https://bugs.kde.org/show_bug.cgi?id=328807


Repository: ksysguard


Description
---

BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" 
(affected SensorType: DancingBars)

https://bugs.kde.org/show_bug.cgi?id=328807

Two issues fixed:
- crash during removing a bar Sensor
- wrong Sensors is removed
- labels are not set as expected after removing a bar


Diffs
-

  gui/SensorDisplayLib/BarGraph.cpp ecd6674ea4f66c3c061feb31c6a68e2e7abed885 
  gui/SensorDisplayLib/DancingBars.cpp 13c8a45f4f4ca9dd16f62cdf6295bcd6643d2a12 
  gui/SensorDisplayLib/DancingBarsSettings.h 
27df0666db53621ecddb2e4763b26509103f7381 
  gui/SensorDisplayLib/DancingBarsSettings.cpp 
6eb9c21b1670b028570e3826620b98e07eac266d 

Diff: https://git.reviewboard.kde.org/r/125416/diff/


Testing
---

Tested
- no crash anymore
- the remaining sensors are the one as expected


Thanks,

Raphael Kugelmann

Re: Review Request 128915: resize the view just after setting the containment

[Aleix Pol Gonzalez]

> On Sept. 15, 2016, 12:01 p.m., Aleix Pol Gonzalez wrote:
> > src/plasmaquick/containmentview.cpp, line 101
> > 
> >
> > Wouldn't it be better to pass the size with the incubation properties?
> 
> Marco Martin wrote:
> hmm, you can't access it for the item that you load with setSource i 
> think?

Yes, I looked into it and it would be possible but only to whoever constructs 
the object, as it's being incubated within the Containment.

It might be worth looking into though, as the values set there will be 
initialized before the properties are bound. Possibly it doesn't even make 
sense to have the item created before it has a view altogether.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/#review99192
---


On Sept. 15, 2016, 11:20 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128915/
> ---
> 
> (Updated Sept. 15, 2016, 11:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> when the view is in SizeRootObjectToView mode, the root object is resized in 
> the event handler, that is too late at startup.
> resize the root object right after having announced the new containment, so 
> the view subclass can have the view resized to the proper size beforehand, 
> removing an useless containment graphicsobject resize.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/containmentview.cpp 8517099 
> 
> Diff: https://git.reviewboard.kde.org/r/128915/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

Re: Review Request 128702: Use default weight rather than normal weight

[Jacopo De Simoi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128702/
---

(Updated Sept. 15, 2016, 6:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 663c87bc6f3881091c04beb3ce447922945cf14e by David 
Edmundson on behalf of Jacopo De Simoi to branch master.


Repository: plasma-workspace


Description
---

Honor the choice of a user that has chosen a custom weight (e.g. light)
as default weight


Diffs
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 
48a310052eead844c2d7dbc22ee924a971733881 

Diff: https://git.reviewboard.kde.org/r/128702/diff/


Testing
---


Thanks,

Jacopo De Simoi

[Differential] [Closed] D2783: Don't have a different OSD icon size for mute and for volumeBUG: 365199

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE31cac414ae19: Don't have a different OSD icon 
for mute and volume adjustment (authored by davidedmundson).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2783?vs=6750=6757

REVISION DETAIL
  https://phabricator.kde.org/D2783

AFFECTED FILES
  lookandfeel/contents/osd/OsdItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128915: resize the view just after setting the containment

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/#review99195
---


Fix it, then Ship it!





src/plasmaquick/containmentview.cpp (line 137)


does it render this redundant?



src/plasmaquick/containmentview.cpp (line 140)


this if isn't very useful now.
If it was null, we'd have crashed already.


- David Edmundson


On Sept. 15, 2016, 9:20 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128915/
> ---
> 
> (Updated Sept. 15, 2016, 9:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> when the view is in SizeRootObjectToView mode, the root object is resized in 
> the event handler, that is too late at startup.
> resize the root object right after having announced the new containment, so 
> the view subclass can have the view resized to the proper size beforehand, 
> removing an useless containment graphicsobject resize.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/containmentview.cpp 8517099 
> 
> Diff: https://git.reviewboard.kde.org/r/128915/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

Re: Review Request 128915: resize the view just after setting the containment

[Marco Martin]

> On Sept. 15, 2016, 10:01 a.m., Aleix Pol Gonzalez wrote:
> > src/plasmaquick/containmentview.cpp, line 101
> > 
> >
> > Wouldn't it be better to pass the size with the incubation properties?

hmm, you can't access it for the item that you load with setSource i think?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/#review99192
---


On Sept. 15, 2016, 9:20 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128915/
> ---
> 
> (Updated Sept. 15, 2016, 9:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> when the view is in SizeRootObjectToView mode, the root object is resized in 
> the event handler, that is too late at startup.
> resize the root object right after having announced the new containment, so 
> the view subclass can have the view resized to the proper size beforehand, 
> removing an useless containment graphicsobject resize.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/containmentview.cpp 8517099 
> 
> Diff: https://git.reviewboard.kde.org/r/128915/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

[Differential] [Accepted] D2778: Expose the banner sourceSize

[mart (Marco Martin)]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  patch in general makes sense
  
  but are you sure svg doesn't export a soucesize? (svgs do have a size in 
pixels in their root layer and qtsvg supports it)

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2778

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

Re: Review Request 128915: resize the view just after setting the containment

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/#review99192
---




src/plasmaquick/containmentview.cpp (line 101)


Wouldn't it be better to pass the size with the incubation properties?


- Aleix Pol Gonzalez


On Sept. 15, 2016, 11:20 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128915/
> ---
> 
> (Updated Sept. 15, 2016, 11:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> when the view is in SizeRootObjectToView mode, the root object is resized in 
> the event handler, that is too late at startup.
> resize the root object right after having announced the new containment, so 
> the view subclass can have the view resized to the proper size beforehand, 
> removing an useless containment graphicsobject resize.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/containmentview.cpp 8517099 
> 
> Diff: https://git.reviewboard.kde.org/r/128915/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

[Differential] [Request, 94 lines] D2787: Add support for resize only borders on Wayland

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  This change adds support for resizing outside the window decoration
  (e.g. setting borders to NoSide or None).
  
  To support this a new Toplevel::inputGeometry() -> QRect method is
  added which exposes the geometry adjusted by the margins provided by
  the decoration. This is checked in InputRedirection when finding a
  Toplevel at a given position. The logic for figuring out whether the
  event should go to the decoration or the window already handled the
  situation correctly, so no further changes are needed.
  
  BUG: 364607

REPOSITORY
  rKWIN KWin

BRANCH
  resize-only-borders-wayland

REVISION DETAIL
  https://phabricator.kde.org/D2787

AFFECTED FILES
  abstract_client.cpp
  abstract_client.h
  autotests/integration/decoration_input_test.cpp
  input.cpp
  toplevel.cpp
  toplevel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 338 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/338/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 15 Sep 2016 09:18:09 +
Build duration: 17 min

CHANGE SET
Revision 0efcc364f4d833b3b6ce4c9430f54e8f27f841f0 by Jonathan Riddell: (Update 
version number for 5.7.95 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Review Request 128915: resize the view just after setting the containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

when the view is in SizeRootObjectToView mode, the root object is resized in 
the event handler, that is too late at startup.
resize the root object right after having announced the new containment, so the 
view subclass can have the view resized to the proper size beforehand, removing 
an useless containment graphicsobject resize.


Diffs
-

  src/plasmaquick/containmentview.cpp 8517099 

Diff: https://git.reviewboard.kde.org/r/128915/diff/


Testing
---


Thanks,

Marco Martin

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/
---

(Updated Sept. 15, 2016, 9:09 vorm.)


Review request for Documentation, KDE Frameworks and Plasma.


Changes
---

add reviewer plasma + docs


Repository: kio


Description
---

doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
splitted from kde-runtime master using https://github.com/ajdruff/git-splits

Not included in build so far, the docbooks are imported as they were splitted

To be done next:
Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
rename ebrowsing to webshortcuts
reapply a few updates done in plasma-desktop
remove these imported kcontrol docbooks from plasma-desktop
adapt scripty to these changes


Diffs
-

  doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/cache/index.docbook PRE-CREATION 
  doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/cookies/index.docbook PRE-CREATION 
  doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
  doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/netpref/index.docbook PRE-CREATION 
  doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/proxy/index.docbook PRE-CREATION 
  doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/smb/index.docbook PRE-CREATION 
  doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/useragent/index.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128912/diff/


Testing
---

history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
master


File Attachments


git-log-doc-kcontrol.output
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output


Thanks,

Burkhard Lück

Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128914/
---

Review request for Documentation, Localization and Translation (l10n) and 
Plasma.


Repository: kde-cli-tools


Description
---

doc/kcontrol/filetypes/ splitted from kde-runtime master using 
https://github.com/ajdruff/git-splits

Not included in build so far, the docbook ismported as it was splitted

To be done next:
adapt CMakeLists.txt, change dtd to kf5, 
reapply one update done in plasma-desktop
make co-installable, see https://git.reviewboard.kde.org/r/128912/
remove this imported kcontrol docbook from plasma-desktop
adapt scripty to these changes


Diffs
-

  doc/kcontrol/filetypes/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/filetypes/index.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128914/diff/


Testing
---

history looks good, see git-log-doc-kcontrol-kio-cli-tools.output, same log in 
kde-runtime master


File Attachments


git-log-doc-kcontrol-kio-cli-tools.output
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/32f72127-aa97-4393-88e1-d830e35dbfe2__git-log-doc-kcontrol-kio-cli-tools.output


Thanks,

Burkhard Lück

[Differential] [Accepted] D2766: More config descriptions

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.


  good, still a couple of nitpicks

INLINE COMMENTS

> main.xml:34
>  
> +  Sets the fault to italic.
>false

"Sets the clock font to italic."

> main.xml:53
>  
> +  Whether the timezone is displayed as a code i.e "GMT" or full 
> text i.e "London".
>true

i.e.

> main.xml:10
>  
> +  Show option to shut down the system.
>true

"Shows an option" would sound better?  (tough i don't english enough, i may be 
very wrong :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2766

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, hein, #plasma, mart
Cc: mart, hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D2785: Fix panel spacer

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.qml:36
>  
> -Layout.minimumWidth: horizontal ? plasmoid.configuration.length : 1
> -Layout.maximumWidth: (plasmoid.configuration.expanding || !horizontal) ? 
> Infinity :  plasmoid.configuration.length
> -
> -Layout.minimumHeight: horizontal ? 1 : plasmoid.configuration.length
> -Layout.maximumHeight: (plasmoid.configuration.expanding || horizontal) ? 
> Infinity :  plasmoid.configuration.length
> +Layout.preferredWidth: horizontal ? plasmoid.configuration.length : 0
> +Layout.preferredHeight: horizontal ? 0 : plasmoid.configuration.length

some time ago on old qt releases i noticed that the layouts  ignored items with 
one of the sizes as 0 (even height for an horizontal one)  does it work now?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2785

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354250

--- Comment #33 from Kai Uwe Broulik  ---
I think so. That's why I pushed it this morning, tagging is usually around 10
to 12

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

[Fabian Köster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354250

--- Comment #32 from Fabian Köster  ---
(In reply to Kai Uwe Broulik from comment #31)
> When the session becomes inactive, clear all idle timeouts, so we don't get
> them delivered
> while we're inactive or just when we're about to become active again.
> 
> Depending on your setup, PowerDevil might be blocked on X before it gets the
> "session is now
> inactive" signal, so it still suspends when becoming active again :/ It
> should still make it
> a bit less likely (and works for me :D)

That would be great! Will this patch be included in 5.7.95?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 33 lines] D2786: [server] Don't send key release for not pressed keys and no double key press

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: Plasma on Wayland, KWin.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  This change makes use of the internal key state in better way. If a
  key is not considered pressed, no key release is sent. This can happen
  for example if the compositor grabs a key press (global shortcut) but not
  the release. The Wayland client cannot do anything with the release as it
  never got the press. Thus it doesn't make sense to send the release.
  
  Similar if a key is already pressed, it doesn't make sense to send
  another press event. This ensures that if the server sends in repeating
  key presses they are filtered out. Key repeat is handled on client side.
  Also if several physical keys send the same key code, pressing them at
  the same time won't send double press/release event.
  
  This change might cause regressions in KWin in case KWin does not handle
  the situation correctly. But that would be a bug in KWin which needs to
  be fixed there. If it causes regressions the bug might have shown in
  other situations as well.
  
  BUG: 366625
  FIXED-IN: 5.27

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  update-key-only-on-change

REVISION DETAIL
  https://phabricator.kde.org/D2786

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/seat_interface.cpp
  src/server/seat_interface_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Re: Plasma desktop/mobile initial setup

[Ivan Čukić]

Hi all,

I agree that the first-run wizard might be annoying. But if it was a
first-screen with options to have 'introduction', 'new features',
'setup wizard', I think it would be ok. Manjaro has had a first-run
screen for ages, I never found it problematic.

Plus, Martin had a few really nice points there.

> Beyond that there is also the old truism that if you need to explain to
> the user how to do common tasks then those tasks need redesign.

I think this is a fallacy. If you had a lumberjack that used an axe
for his whole life, and got him a chainsaw, without any introductory
instructions, he would just keep swinging that thing at the tree.

The fact that people are used to a certain kind of UI is not the
reason for you not to invent something new and better.

Cheers,
Ivan

[Differential] [Closed] D2033: Clear idle timeouts when session becomes inactive

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPOWERDEVILece8adacb35b: Clear idle timeouts when session 
becomes inactive (authored by broulik).

REPOSITORY
  rPOWERDEVIL Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2033?vs=6418=6754

REVISION DETAIL
  https://phabricator.kde.org/D2033

AFFECTED FILES
  daemon/powerdevilcore.cpp
  daemon/powerdevilpolicyagent.cpp
  daemon/powerdevilpolicyagent.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, oliverhenshaw, sebas, #plasma
Cc: sebas, oliverhenshaw, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354250

--- Comment #31 from Kai Uwe Broulik  ---
Git commit ece8adacb35b8897407d92d995f362a6aea644be by Kai Uwe Broulik.
Committed on 15/09/2016 at 07:15.
Pushed by broulik into branch 'master'.

Clear idle timeouts when session becomes inactive

When the session becomes inactive, clear all idle timeouts, so we don't get
them delivered
while we're inactive or just when we're about to become active again.

Depending on your setup, PowerDevil might be blocked on X before it gets the
"session is now
inactive" signal, so it still suspends when becoming active again :/ It should
still make it
a bit less likely (and works for me :D)

Differential Revision: https://phabricator.kde.org/D2033

M  +15   -0daemon/powerdevilcore.cpp
M  +8-5daemon/powerdevilpolicyagent.cpp
M  +1-0daemon/powerdevilpolicyagent.h

http://commits.kde.org/powerdevil/ece8adacb35b8897407d92d995f362a6aea644be

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Closed] D2775: Emit brightnessSupportQueried with the proper value

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPOWERDEVIL03717dc7388b: Emit brightnessSupportQueried with 
the proper value (authored by broulik).

REPOSITORY
  rPOWERDEVIL Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2775?vs=6735=6753

REVISION DETAIL
  https://phabricator.kde.org/D2775

AFFECTED FILES
  daemon/backends/upower/powerdevilupowerbackend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, bshah
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2783: Don't have a different OSD icon size for mute and for volumeBUG: 365199

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2783

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas