Re: Some suggestions for the usermanager

[David Edmundson]

On Mon, Sep 19, 2016 at 10:23 PM, Martin Bammer  wrote:

> Hi,
>
> I was playing around with extending and fixing some bugs in the
> usermanager. One
> of the bugs I would like to get fixed is setting the avatar for users.
> As I've seen in the code changing the avatar does not check for which user
> the
> avatar was changed. It always changes the avatar of the currently logged in
> user. Fixing this would mean either disable the possibility to change other
> user's avatar in the GUI (the easier solution) or to take care which user's
> avatars were changed and write the temporary files to the correct
> destination.
> As long as the home directories are not encrypted this could be done with
> root
> rights. In case of encrypted homes every user, which avatar was changed,
> would
> have to enter his password after clicking the Apply button. Not a nice
> solution.
>
> Yeah, we've got an open bug on that.
I've just made a patch for KUser which will allow us to get rid of saving
into ~/.face


> In addition the avatar is not set for the login manager. As I've seen in
> the
> sources SDDM is just ignoring the avatars in the folder
> /var/lib/AccountsService/icons. So adding this search folder as the
> primary
> source would be a good idea. Then it does not matter if the homes are
> encrypted
> or not.
>

SDDM has a patch pending for using AccountsService
It should be in 0.15


>
> Some additional features I would like to have:
> - Selecting user's groups, like it is possible in Mint.
> - An option to show the home's encryption key. Currently the user has
> exactly 1
> chance to write down his encryption key. Later he has to google how this
> can be
> done and has to use the command line for this. Not user friendly.
> - An option to easily enable/disable home's encryption. Currently only the
> first
> user who installs the system can enable the encryption for him in the
> installer.
> But for every new user who want to have an encrypted home the command line
> is
> needed.
> - Maybe also an option to choose the user-id and group-id for new users.
> The
> current implementation has IMHO a design problem: The first user gets id
> 1000
> (on Debian based systems, on RedHat based systems 500). The second 1001
> and so
> on. But what if we have a small home network where everyone has it's own
> machine, thus different users have the same id? Problems arise when
> sharing with
> NFS or when using external drives with a Linux FS. My suggestion would be
> to
> calculate hash values out of the user and group names to get the ids. Not
> perfect, but much better than the current implementation. But this is a
> topic
> for the base system and not for the usermanager.
> Here a screenshot how this could look like:
>
>
> Your suggestions are very welcome.
>
> Best regards,
>
> Martin Bammer
>
>

[Differential] [Reopened] D2747: Don't list raw containments in panels menu

[mart (Marco Martin)]

mart reopened this revision.
mart added a comment.
This revision is now accepted and ready to land.


  I think this should be reexamined.
  I was just asked why a 3rd party dock looking panel is not listed here.
  simple panels (potentially coming from ghns now) should be listed.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2747

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

[Marco Martin]

> On Sept. 19, 2016, 9:43 p.m., David Edmundson wrote:
> > The problem with this patch (which highlights a mix we have in plasma in 
> > general) is that it's mixing whether the screen is managed by the view or 
> > managed by the containment.
> > With this you're overriding the screen() method from containment, and 
> > manipulating things directly via the view.
> > 
> > The issue this has is that it almost certainly won't work on any 
> > pre-startup plasma scripts, where we don't have a view yet.
> > This current patch would cause a crash if used. That's why all other usages 
> > of panel() are guarded.

if the view isn't created yet, it should work setting lastScreen in the config 
file


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128950/#review99284
---


On Sept. 19, 2016, 9:28 p.m., Kamil Sołtysik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128950/
> ---
> 
> (Updated Sept. 19, 2016, 9:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=363592
> 
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=363592
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As stated in doc here: 
> https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Panels
>  Panels should allow to be placed on selected screen by setting value of 
> Panel::screen property. While looking at code I found out that this property 
> is read-only in code. Patch changes that.
> 
> 
> Diffs
> -
> 
>   shell/scripting/panel.h 0d70784 
>   shell/scripting/panel.cpp b9383df 
> 
> Diff: https://git.reviewboard.kde.org/r/128950/diff/
> 
> 
> Testing
> ---
> 
> Panel's position can now be changed by setting the property. Setting invalid 
> value causes no response.
> 
> 
> Thanks,
> 
> Kamil Sołtysik
> 
>

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128950/#review99285
---




shell/scripting/panel.cpp (line 189)


this can't rely on the order of qGuiApp->screens, but should use screenpool 
in shellcorona, it's the only place where you can find a reliable mapping


- Marco Martin


On Sept. 19, 2016, 9:28 p.m., Kamil Sołtysik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128950/
> ---
> 
> (Updated Sept. 19, 2016, 9:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=363592
> 
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=363592
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As stated in doc here: 
> https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Panels
>  Panels should allow to be placed on selected screen by setting value of 
> Panel::screen property. While looking at code I found out that this property 
> is read-only in code. Patch changes that.
> 
> 
> Diffs
> -
> 
>   shell/scripting/panel.h 0d70784 
>   shell/scripting/panel.cpp b9383df 
> 
> Diff: https://git.reviewboard.kde.org/r/128950/diff/
> 
> 
> Testing
> ---
> 
> Panel's position can now be changed by setting the property. Setting invalid 
> value causes no response.
> 
> 
> Thanks,
> 
> Kamil Sołtysik
> 
>

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128950/#review99284
---



The problem with this patch (which highlights a mix we have in plasma in 
general) is that it's mixing whether the screen is managed by the view or 
managed by the containment.
With this you're overriding the screen() method from containment, and 
manipulating things directly via the view.

The issue this has is that it almost certainly won't work on any pre-startup 
plasma scripts, where we don't have a view yet.
This current patch would cause a crash if used. That's why all other usages of 
panel() are guarded.

- David Edmundson


On Sept. 19, 2016, 9:28 p.m., Kamil Sołtysik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128950/
> ---
> 
> (Updated Sept. 19, 2016, 9:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=363592
> 
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=363592
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As stated in doc here: 
> https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Panels
>  Panels should allow to be placed on selected screen by setting value of 
> Panel::screen property. While looking at code I found out that this property 
> is read-only in code. Patch changes that.
> 
> 
> Diffs
> -
> 
>   shell/scripting/panel.h 0d70784 
>   shell/scripting/panel.cpp b9383df 
> 
> Diff: https://git.reviewboard.kde.org/r/128950/diff/
> 
> 
> Testing
> ---
> 
> Panel's position can now be changed by setting the property. Setting invalid 
> value causes no response.
> 
> 
> Thanks,
> 
> Kamil Sołtysik
> 
>

Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

[Kamil Sołtysik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128950/
---

Review request for Plasma.


Bugs: https://bugs.kde.org/show_bug.cgi?id=363592

https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=363592


Repository: plasma-workspace


Description
---

As stated in doc here: 
https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Panels
 Panels should allow to be placed on selected screen by setting value of 
Panel::screen property. While looking at code I found out that this property is 
read-only in code. Patch changes that.


Diffs
-

  shell/scripting/panel.h 0d70784 
  shell/scripting/panel.cpp b9383df 

Diff: https://git.reviewboard.kde.org/r/128950/diff/


Testing
---

Panel's position can now be changed by setting the property. Setting invalid 
value causes no response.


Thanks,

Kamil Sołtysik

Some suggestions for the usermanager

[Martin Bammer]

Hi,
 
I was playing around with extending and fixing some bugs in the usermanager. One
of the bugs I would like to get fixed is setting the avatar for users.
As I've seen in the code changing the avatar does not check for which user the
avatar was changed. It always changes the avatar of the currently logged in
user. Fixing this would mean either disable the possibility to change other
user's avatar in the GUI (the easier solution) or to take care which user's
avatars were changed and write the temporary files to the correct destination.
As long as the home directories are not encrypted this could be done with root
rights. In case of encrypted homes every user, which avatar was changed, would
have to enter his password after clicking the Apply button. Not a nice solution.

In addition the avatar is not set for the login manager. As I've seen in the
sources SDDM is just ignoring the avatars in the folder
/var/lib/AccountsService/icons. So adding this search folder as the primary
source would be a good idea. Then it does not matter if the homes are encrypted
or not.
 
Some additional features I would like to have:
- Selecting user's groups, like it is possible in Mint.
- An option to show the home's encryption key. Currently the user has exactly 1
chance to write down his encryption key. Later he has to google how this can be
done and has to use the command line for this. Not user friendly.
- An option to easily enable/disable home's encryption. Currently only the first
user who installs the system can enable the encryption for him in the installer.
But for every new user who want to have an encrypted home the command line is
needed.
- Maybe also an option to choose the user-id and group-id for new users. The
current implementation has IMHO a design problem: The first user gets id 1000
(on Debian based systems, on RedHat based systems 500). The second 1001 and so
on. But what if we have a small home network where everyone has it's own
machine, thus different users have the same id? Problems arise when sharing with
NFS or when using external drives with a Linux FS. My suggestion would be to
calculate hash values out of the user and group names to get the ids. Not
perfect, but much better than the current implementation. But this is a topic
for the base system and not for the usermanager.
Here a screenshot how this could look like:

 
Your suggestions are very welcome.
 
Best regards,
 
Martin Bammer
 
 

Re: Review Request 128948: Update shortcuts kcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/#review99283
---




doc/kcontrol/keys/index.docbook 


that part of loading/saving custom config schemes, even if isn't really 
something that should be in evidence anymore is still supported (buried under a 
menu in the bottom right corner)
i'm fine dropping this stuff from the docs tough


- Marco Martin


On Sept. 19, 2016, 7:35 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128948/
> ---
> 
> (Updated Sept. 19, 2016, 7:35 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> adapt to changes in 5.8
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/keys/index.docbook 27eab50 
> 
> Diff: https://git.reviewboard.kde.org/r/128948/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Review Request 128949: Add monitors for Linux memory infos dirty and writeback

[Pascal VITOUX]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128949/
---

Review request for Plasma.


Repository: ksysguard


Description
---

Add monitors for Linux memory infos dirty and writeback

A usecase can be the monitoring of datas being written to a slow storage device 
like a USB mass storage before umounting and removing it.


Diffs
-

  ksysguardd/Linux/Memory.h 2dbd6f2 
  ksysguardd/Linux/Memory.c 1bc3ace 

Diff: https://git.reviewboard.kde.org/r/128949/diff/


Testing
---

Works as expected in the ksysguard GUI application (system monitor).
Also, I use it with a plasma widget almost everyday since several months 
without issue.


Thanks,

Pascal VITOUX

Re: Review Request 128947: Update screenlocker docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128947/#review99282
---


Ship it!




Ship It!

- Marco Martin


On Sept. 19, 2016, 7:15 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128947/
> ---
> 
> (Updated Sept. 19, 2016, 7:15 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> bump date+releaseinfo
> new wallpaper tab
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/screenlocker/index.docbook 93cc42a 
> 
> Diff: https://git.reviewboard.kde.org/r/128947/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: RFC: plasma-framework IndicatorArea formFactor()

[Marco Martin]

On Mon, Sep 19, 2016 at 8:37 PM, David Edmundson
 wrote:
>> perhaps you are right, semantically they are two things, not sure what
>> could be used instead more "proper"(suggestions welcome), will think
>> more about it.
>
>
> Long term, a virtual hook for immutability?

but even  adding a new virtual isn't bc as far i know?

>>
>> also, what do you suggest for 5.8? trying to temporarly unlock?
>
>
> We can try it.
>
> This also works:
>
> applet->pluginInfo().pluginName()) {
> -applet->destroy();
> +QMetaObject::invokeMethod(applet, "cleanUpAndDelete");
>
> (in all 3 cases)
>
> But it's equally messy, and has an issue that transient won't get set, so I
> don't like it.

hmmme neither, i would rather go for trying to unlock temporarly (this
could be a problem for some enterprise setups tough)

--
Marco Martin

Re: A script/voiceover text for Plasma 5.8 video

[Ivan Čukić]

Mostly ok, I've made a few alterations.

One sentence I don't get is:

> Global shortcuts configuration has been simplified and can now be
> configured to jump to specific tasks within an application.

Cheers,
Ivan

Review Request 128948: Update shortcuts kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

adapt to changes in 5.8


Diffs
-

  doc/kcontrol/keys/index.docbook 27eab50 

Diff: https://git.reviewboard.kde.org/r/128948/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Review Request 128947: Update screenlocker docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128947/
---

Review request for Documentation and Plasma.


Repository: plasma-workspace


Description
---

bump date+releaseinfo
new wallpaper tab


Diffs
-

  doc/kcontrol/screenlocker/index.docbook 93cc42a 

Diff: https://git.reviewboard.kde.org/r/128947/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: RFC: plasma-framework IndicatorArea formFactor()

[David Edmundson]

On Mon, Sep 19, 2016 at 7:10 PM, Marco Martin  wrote:

> On Mon, Sep 19, 2016 at 7:55 PM, David Edmundson
>  wrote:
> > https://bugs.kde.org/show_bug.cgi?id=365967
> >
> > It's a bug in that weather applet that it's rendering outside the area it
> > actually has - and that needs fixing anyway.
> > Introducing a new form factor won't solve that - in both cases you have
> to
> > do the exact same amount of work to that applet.
>
> yes, just needs something for the applet to check (which at the moment
> doesn't have) i don't think it's fixable completely from systray side
> (most one could do, is clipping, which I would like to avoid)
>
> >> IndicatorArea formfactor would have a Mutable immutability°, because
> >> the systray itself should always be able to both add and remove
> >> plasmoids in itself even when immutable (even Systemimmutable) it
> >> could still hide/disable the ui to do so when immutable, but must be
> >> programmatically able to do so.
> >
> >
> > 365618 and 365569 are basically the same thing right?
>
> yes, same thing, entries not getting removed when locked.
>
> > You're saying we need mutability to be different in system tray
> containment
> > compared to it's parent. Sounds fine. +1
> >
> > But I don't see why we would tie that to the formFactor.
> > Semantically they're not remotely related, the only link is that the
> system
> > tray happens to need both.
>
> perhaps you are right, semantically they are two things, not sure what
> could be used instead more "proper"(suggestions welcome), will think
> more about it.
>

Long term, a virtual hook for immutability?


> also, what do you suggest for 5.8? trying to temporarly unlock?
>

We can try it.

This also works:

applet->pluginInfo().pluginName()) {
-applet->destroy();
+QMetaObject::invokeMethod(applet, "cleanUpAndDelete");

(in all 3 cases)

But it's equally messy, and has an issue that transient won't get set, so I
don't like it.


--
> Marco Martin
>

Re: RFC: plasma-framework IndicatorArea formFactor()

[Marco Martin]

On Mon, Sep 19, 2016 at 7:55 PM, David Edmundson
 wrote:
> https://bugs.kde.org/show_bug.cgi?id=365967
>
> It's a bug in that weather applet that it's rendering outside the area it
> actually has - and that needs fixing anyway.
> Introducing a new form factor won't solve that - in both cases you have to
> do the exact same amount of work to that applet.

yes, just needs something for the applet to check (which at the moment
doesn't have) i don't think it's fixable completely from systray side
(most one could do, is clipping, which I would like to avoid)

>> IndicatorArea formfactor would have a Mutable immutability°, because
>> the systray itself should always be able to both add and remove
>> plasmoids in itself even when immutable (even Systemimmutable) it
>> could still hide/disable the ui to do so when immutable, but must be
>> programmatically able to do so.
>
>
> 365618 and 365569 are basically the same thing right?

yes, same thing, entries not getting removed when locked.

> You're saying we need mutability to be different in system tray containment
> compared to it's parent. Sounds fine. +1
>
> But I don't see why we would tie that to the formFactor.
> Semantically they're not remotely related, the only link is that the system
> tray happens to need both.

perhaps you are right, semantically they are two things, not sure what
could be used instead more "proper"(suggestions welcome), will think
more about it.

also, what do you suggest for 5.8? trying to temporarly unlock?

--
Marco Martin

Re: RFC: plasma-framework IndicatorArea formFactor()

[David Edmundson]

On Mon, Sep 19, 2016 at 6:09 PM, Marco Martin  wrote:

> Hi all,
> I was looking at some systray-related bugs, such as
> https://bugs.kde.org/show_bug.cgi?id=365569
> and
> https://bugs.kde.org/show_bug.cgi?id=365967
> and it occurs to me they always have in common the same reason: even
> if I tried hard in the rewrite to make it less a "special case", it
> still is just that: a "special case" (ever having allowed plasmoids in
> the systray a long time ago in 2009 is still on of the design
> decisions i mostly regret but that's another story)
>
> what I'm thinking of, is having a new possible formFactor() value,
> IndicatorArea (why exactly FormFactor?because it's exactly that, while
> Horizontal means "can grow horizontally, constrained vertically, that
> would mean constrained both horizontally and vertically)
>

https://bugs.kde.org/show_bug.cgi?id=365967

It's a bug in that weather applet that it's rendering outside the area it
actually has - and that needs fixing anyway.
Introducing a new form factor won't solve that - in both cases you have to
do the exact same amount of work to that applet.

>
> So in that case applets would need to make sure to be square in that
> particular formfactor, like the weather that wants to eventually
> become non square in panels (and no, i don't want to allow non square
> icons in the systray.. ever)
>

> another difference would be (and that is kindof an hack, but at least
> it puts that immutability hack there and only there) containments of
> IndicatorArea formfactor would have a Mutable immutability°, because
> the systray itself should always be able to both add and remove
> plasmoids in itself even when immutable (even Systemimmutable) it
> could still hide/disable the ui to do so when immutable, but must be
> programmatically able to do so.
>

365618 and 365569  are
basically the same thing right?

You're saying we need mutability to be different in system tray containment
compared to it's parent. Sounds fine. +1

But I don't see why we would tie that to the formFactor.
Semantically they're not remotely related, the only link is that the system
tray happens to need both.


>
> Unfortunately as it needs changes in plasma-framework it would need to
> be a post 5.8 thing (how to properly fix 365618 in 5.8 I have no idea,
> except perhaps the systray applet itself trying to temporarly unlock
> plasma when it has to remove widgets, that would still be broken in
> systemimmutable case, but better than nothing)


> opinions? comments?
>
>
I don't object to the idea in principle, but the reasons you've listed here
don't support it.

David


> --
> Marco Martin
>

Re: New shapes and colors for Breeze mime-types icons

[Marco Martin]

On Mon, Sep 19, 2016 at 10:56 AM, kainz.a  wrote:
> Different shapes = different contend
> Different colors = different file types

I find the reasoning convincing.
Maybe will still need some fixes after being widely tested in the
flesh, but looking forward to see it live!

--
Marco Martin

RFC: plasma-framework IndicatorArea formFactor()

[Marco Martin]

Hi all,
I was looking at some systray-related bugs, such as
https://bugs.kde.org/show_bug.cgi?id=365569
and
https://bugs.kde.org/show_bug.cgi?id=365967
and it occurs to me they always have in common the same reason: even
if I tried hard in the rewrite to make it less a "special case", it
still is just that: a "special case" (ever having allowed plasmoids in
the systray a long time ago in 2009 is still on of the design
decisions i mostly regret but that's another story)

what I'm thinking of, is having a new possible formFactor() value,
IndicatorArea (why exactly FormFactor?because it's exactly that, while
Horizontal means "can grow horizontally, constrained vertically, that
would mean constrained both horizontally and vertically)

So in that case applets would need to make sure to be square in that
particular formfactor, like the weather that wants to eventually
become non square in panels (and no, i don't want to allow non square
icons in the systray.. ever)

another difference would be (and that is kindof an hack, but at least
it puts that immutability hack there and only there) containments of
IndicatorArea formfactor would have a Mutable immutability°, because
the systray itself should always be able to both add and remove
plasmoids in itself even when immutable (even Systemimmutable) it
could still hide/disable the ui to do so when immutable, but must be
programmatically able to do so.

Unfortunately as it needs changes in plasma-framework it would need to
be a post 5.8 thing (how to properly fix 365618 in 5.8 I have no idea,
except perhaps the systray applet itself trying to temporarly unlock
plasma when it has to remove widgets, that would still be broken in
systemimmutable case, but better than nothing)

opinions? comments?

--
Marco Martin

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 348 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/348/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 19 Sep 2016 16:32:14 +
Build duration: 9 min 26 sec

CHANGE SET
Revision 4185373fc2b8ec7a27f21b4db68ef7799ac34762 by hein: (Disable 
filter-bypass by demands-attention windows.)
  change: edit applets/pager/plugin/pagermodel.cpp
Revision d7d135fda4930d4152c11d5abbbc1ae34b3ec781 by hein: (Fix disabling 
launcher toggle action if launcher URL is empty.)
  change: edit applets/taskmanager/package/contents/ui/ContextMenu.qml
Revision cb7f58b14d800be7b6ddb65b7d772afa2325d825 by hein: (Pick up on virtual 
desktop name changes at runtime.)
  change: edit applets/pager/plugin/pagermodel.cpp
Revision 49131300b7e873c8d7455309025479d753039ed5 by Marco Martin: (Make sure 
to animate proper containments)
  change: edit desktoppackage/contents/views/Desktop.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 6 - Still unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 19 Sep 2016 16:29:24 +
Build duration: 9 min 23 sec

CHANGE SET
Revision 49131300b7e873c8d7455309025479d753039ed5 by Marco Martin: (Make sure 
to animate proper containments)
  change: edit desktoppackage/contents/views/Desktop.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1557/3774 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 624/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

[Differential] [Closed] D2814: Make sure to animate proper containments

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP49131300b7e8: Make sure to animate proper 
containments (authored by mart).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2814?vs=6818=6819

REVISION DETAIL
  https://phabricator.kde.org/D2814

AFFECTED FILES
  desktoppackage/contents/views/Desktop.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2814: Make sure to animate proper containments

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  phab/activityanim

REVISION DETAIL
  https://phabricator.kde.org/D2814

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2814: Make sure to animate proper containments

[mart (Marco Martin)]

mart updated the test plan for this revision.
mart added a reviewer: Plasma.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2814

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 57 lines] D2814: Make sure to animate proper containments

[mart (Marco Martin)]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  if the activity is changed again while the switch animation
  is being performed, the desktop finds itself in an
  inconsistent state, as oldContainment and newContainment
  values gets changed while the animation is running.
  this makes sure the animation is stopped and all the values
  are resetted if the containment changes before the anim is done
  
  BUG:352345

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  phab/activityanim

REVISION DETAIL
  https://phabricator.kde.org/D2814

AFFECTED FILES
  desktoppackage/contents/views/Desktop.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2813: Readability. Simplify overly complex code

[mart (Marco Martin)]

mart added a comment.


  the change itself is actually ok, but can we avoid further changes that 
aren't an explicit bugfix in 5.8 branch prior the release?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2813

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2813: Readability. Simplify overly complex code

[apol (Aleix Pol Gonzalez)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE89c34a853b64: Readability. Simplify overly 
complex code (authored by apol).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2813?vs=6815=6816

REVISION DETAIL
  https://phabricator.kde.org/D2813

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2813: Readability. Simplify overly complex code

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2813

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 38 lines] D2813: Readability. Simplify overly complex code

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We have a big case because the size depend on whether the panel is vertical 
or horizontal
  but it doesn't really bring much.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2813

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Accessibility at Randa Meetings 2017

[Mario Fux]

Morning guys

With some of you I already talked about this topic but most of you I missed at 
QtCon or elsewhere.

In short: I'd like improve the accessibility of our software and for this task 
I'd like to have at least some of you in Randa. But before we can continue 
with the details of the organization and how we plan to tackle this problem we 
need to find a date:
http://doodle.com/poll/x5ysdghp8s8d3cer

As we plan to close this date selection this Wednesday I need to ask for a bit 
of hurry. So please add yourself if you'd like to come.

Thanks and cu
Mario

[Differential] [Closed] D2812: Make sure the panel is within the screen's geometry

[apol (Aleix Pol Gonzalez)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE3bf1372dffed: Make sure the panel is within 
the screen's geometry (authored by apol).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2812?vs=6813=6814

REVISION DETAIL
  https://phabricator.kde.org/D2812

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2810: Fixed loading of the wallpapers in the activity switcher

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in switcherbackend.cpp:161
> "The requestedSize corresponds to the Image::sourceSize requested by an Image 
> item. If requestedSize is a valid size, the image returned should be of that 
> size."
> 
> source size isn't set which puts you always in this path

isn't the size of the geometry of the image Item?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D2810

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2812: Make sure the panel is within the screen's geometry

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  In https://phabricator.kde.org/D2812#52349, @davidedmundson wrote:
  
  > Normally:
  >  resizePanel() -> resizeEvent -> positionPanel
  >
  > Are you saying in your case, the restore() ends up in a different position, 
but because it's an identical size it doesn't trigger?
  >  Can you confirm that with qDebug before pushing.
  
  
  Yes, confirmed, resize doesn't happen as the geometry of the screen is the 
same.
  
  `Plasma/5.8` branch, correct?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2812

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Minutes Monday Plasma Meeting

[Sebastian Kügler]

Note: starting next week, we'll resort to IRC

Plasma Meeting minutes 19-9-2016

Present: bshah, Sho, andreas_k, jens, kbroulik, llucas, notmart, sebas

Sho:
* Fixed grouping for Wine apps in Task Mananager
* Fixed launcher toggle action in Task Manager context menu not being disabled 
when we can't produce a launcher URL
* Sorted out handling of X11 utility windows (_NET_WM_WINDOW_TYPE_UTILITY): 
Not shown on Task Manager anymore (again), still shown on Pager
* Fixed Pager layout regressions and optimized the layout a bit
* Fixed Pager showing windows in demands-attention state on all desktops
* Fixed Pager not clipping/eliding desktop labels correctly
* Made Pager pick up virtual desktop name changes in realtime
* Fixed Plasma theme / color group handling for icons in App Dash and Simple 
Menu system favorites area
* Fixed “Switch Window” desktop containment mouse action listing windows from 
other activities
* Big hunting session on eliminating unnecessary panel resizes slowing down 
Plasma startup
* Icontasks “DND is wonky” issues turned out to be Qt 5.6.x-specific
* Hover patch merged into Qt \o/ Will fix desktop context menu wonkyness
* More Neon Korean Edition testing, great progress there

bshah:
- Some research/PoC work for architecture change for Plasma mobile
- Experiment with newer sddm version (0.14) to replace simplelogin
- Working on debian based mobile images in addition to neon

andreas_k:
* mimetype icons updated, part of design update for 5.9 onwards
* taskbar svg is now also in frameworks

jens:
* bugthrashing guide in the works
* talking with wikimedia about prototype and testing tool
* started on appdach

kbroulik:
* Some fixes for notification (clear all context menu entry, limit 
notification popup size and scroll if neccessary)
* Added battery icon to lock screen and login
* More right-to-left fixes (plasma sidebars on the right side, window 
switcher, also massively cleaned up that old qml code it used)
* Fixes to task manager (improved mapping for mpris to window, media controls 
in context menu)

llucas:
* plasma 5.8 voice over will be done by chris from linux action show, should 
be available later today or tomorrow morning

notmart:
* fixed two (last-before-5.8?) bugs about plasma and multiscreen
** panel offset was resetted if the controlled had been open
** panels disn't know what screen they were in when the active screen changed 
(if only one screen is active, the same QScreen* will be recycled, that wasn't 
expected)
* some triaging
* kirigami: ongoing port to QtQuickCotrols2, most components now based on some 
QQC2 class
** still a lot to fix/change
** some things fit well (like drawers) some don't really fit (like 
SwipeDelegate)
** it's one a branch of the same components for now(mart/Kirigami2), will have 
to be made coinstallable somehow

sebas:
* OSDs in kscreen are now hidpi-able
* bit of cleanup here and there for the beta
* blogged about LTS 
https://vizzzion.org/blog/2016/09/lts-releases-align-neatly-for-plasma-5-8/
* fixed a build problem in kwin caused by a BIC and SIC commit to Qt (wow. :/)
* new bugs coming in after beta, keeping on top of that (good to see people 
test)

-- 
sebas

Sebastian Kügler•http://vizZzion.org•http://www.kde.org

[Differential] [Accepted] D2812: Make sure the panel is within the screen's geometry

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Normally:
  resizePanel() -> resizeEvent -> positionPanel
  
  Are you saying in your case, the restore() ends up in a different position, 
but because it's an identical size it doesn't trigger?
  Can you confirm that with qDebug before pushing.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2812

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 1 line] D2812: Make sure the panel is within the screen's geometry

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Whenever we restore, the position of the panel can be random, we need to 
ensure
  that it's placed in the screen boundaries.
  I could easily reproduce by having the a vertical set up where the primary
  persistent screen is below. Disconnecting the screen above would call restore
  but leave the screen in the same position (with very big Y) but with the new
  width.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2812

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2810: Fixed loading of the wallpapers in the activity switcher

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> switcherbackend.cpp:161
> +
> +if (width <= 0) {
> +width = 320;

"The requestedSize corresponds to the Image::sourceSize requested by an Image 
item. If requestedSize is a valid size, the image returned should be of that 
size."

source size isn't set which puts you always in this path

> switcherbackend.cpp:181
> +KIO::filePreview(list, QSize(width, height));
> +job->setScaleType(KIO::PreviewJob::Scaled);
> +job->setIgnoreMaximumSize(true);

why not ScaledAndCached?

> switcherbackend.cpp:191
> +if (m_requestedSize.isValid()) {
> +image = image.scaled(m_requestedSize);
> +}

is this needed?

1. KIO is set to scaled anyway, so will resize it.
2. the QML code can resize the image at an openGL level by setting an 
appropriate fillMode.

The above two will keep aspect ratio properly.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D2810

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Baloo maintainer required

[Vishesh Handa]

On Mon, Sep 19, 2016 at 11:43 AM, Bhushan Shah  wrote:
> Hey Vishesh,
>
> On Mon, Sep 19, 2016 at 3:06 PM, Vishesh Handa  wrote:
>> I've been steadily loosing motivation to work on Baloo.
>>
>> I've removed myself from all the bugs, as it doesn't seem like I'm
>> going to look at them. I no longer use Baloo or have a KDE development
>> environment. Therefore, it's not even scratching my own itch.
>>
>> If someone else wants to maintain it, I can help with the transition.
>
> Few days ago Boudhayan volunteered for maintaining it..
>
> See 
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037674.html
>

Thanks.

Generally, it's polite the cc the previous maintainer. Or at least
inform them in some other manner.

Oh well. At least it is being maintained.

> Thanks
>
> --
> Bhushan Shah
>
> http://blog.bshah.in
> IRC Nick : bshah on Freenode

[Differential] [Accepted] D2810: Fixed loading of the wallpapers in the activity switcher

[mart (Marco Martin)]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> switcherbackend.cpp:156
> +
> +void run()
> +{

could this have the implementation after the class definition, just for 
immediate readability?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D2810

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Fwd: Cron <lxr@lxr> ~/bin/update_kf5.sh

[Jonathan Riddell]

On Sun, Sep 18, 2016 at 06:53:32PM +0200, David Faure wrote:
> There seems to be a branch mixup for kaccounts-mobile...
> 
> --  Forwarded Message  --
> 
> Subject: Cron  ~/bin/update_kf5.sh
> Date: dimanche 18 septembre 2016, 14:56:33 CEST
> From: Cron Daemon 
> To: fa...@kde.org
> 
> Error updating kaccounts-mobile, removing from list of packages to build.
>  > Unable to perform a git checkout of origin/Plasma/5.8 to a local branch of 
> Plasma/5.8
> -


What is expecting this branch?

kde:kde-build-metadata logical-module-structure lists the branch as 
"stable-kf5-qt5": ""

It should be moved out of kde/workspace anyway, would playground/mobile make 
sense?  It's unmaintained as far as I know

Jonathan

[Differential] [Accepted] D2730: [Task Manager] Use Qt.binding for prefix

[hein (Eike Hein)]

hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2730

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Baloo maintainer required

[Vishesh Handa]

Hey guys

I've been steadily loosing motivation to work on Baloo.

I've removed myself from all the bugs, as it doesn't seem like I'm
going to look at them. I no longer use Baloo or have a KDE development
environment. Therefore, it's not even scratching my own itch.

If someone else wants to maintain it, I can help with the transition.

--
Vishesh Handa

Re: Baloo maintainer required

[Bhushan Shah]

Hey Vishesh,

On Mon, Sep 19, 2016 at 3:06 PM, Vishesh Handa  wrote:
> I've been steadily loosing motivation to work on Baloo.
>
> I've removed myself from all the bugs, as it doesn't seem like I'm
> going to look at them. I no longer use Baloo or have a KDE development
> environment. Therefore, it's not even scratching my own itch.
>
> If someone else wants to maintain it, I can help with the transition.

Few days ago Boudhayan volunteered for maintaining it..

See 
https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037674.html

Thanks

-- 
Bhushan Shah

http://blog.bshah.in
IRC Nick : bshah on Freenode

Re: New shapes and colors for Breeze mime-types icons

[kainz.a]

Executable
--
In general I think it's a good idea to have a gear shape for .exe, ...
files, but I have to have a look if it look good as it is now with the big
gear.

MS Office
--
the ms logos will be removed cause we don't want to ship app specific
mimetypes (exclude .deb, .exe, ... files). Also we respect trademarks

Different shapes = different contend

shapes should help the user to know what is the file content. therefore we
have different shapes for
- audio
- video
- images (pixel graphic)
- archiv
- disk images (vbox disk)

the idea is not to define for each file type a different shape. only this
view different content sections get a special shape. If it's no file from
one of the section the default shape was used.

Different colors = different file types
---
all audio files have the same shape and most of them has the same central
logo to separate different file types colors were used. In some areas like
images also the central logo is different.

The different colors were reviewed cause now we had a lot of e.g. green
mimetypes. app specific mimetypes like ms-word should get the color from
the app file for a better recognization.

So in the end the update is visible but with the same design language as
before.

Re: A script/voiceover text for Plasma 5.8 video

[Marco Martin]

On Saturday 17 September 2016, Łukasz Sawicki wrote:
> Hi,
> 
> Here is a  script/voiceover text for Plasma 5.8 video. Please check
> grammar, typos etc. It is heavily based on Plasma 5.8 beta
> announcement.
> 
> https://notes.kde.org/p/Plasma_5.8_script

looks good to me, tough it would be good if some native speaker proofreads it


-- 
Marco Martin

Re: New shapes and colors for Breeze mime-types icons

[Marco Martin]

On Sunday 18 September 2016, Alessandro Longo wrote:
> Hi all,
> 
> as written here[1] on KDE Planet I want to know thoughts on new colors
> and shapes for Breeze mime-types icons, specially from people involved
> in Plasma, since it's the main product that uses them.
> 
> Please reply to visual-des...@kde.org if you are subscribed there.

quick feedback:
executable: it's not really a "document you can open", so it's probably the 
one icon where it makes more sense to have a distinct shape like the gear

ms office:
indeed, trademarked logos should be avoided as much as possible, i would 
object putting their official logos in our repo for clear legal reasons.

I'm fine with the colors, tough i guess i'll have to see it in real life to 
see if it doesn't look too much "noisy" when a large number of files is 
visualized. similar concern for having a lot of icons with different shapes 
(like images, archives and videos) is true that helps to make a type more 
recognizable, but could also make a view look more messy...

-- 
Marco Martin

Re: SystemSettings See also links

[kainz.a]

2016-09-19 10:25 GMT+02:00 Marco Martin :

> On Friday 09 September 2016, kainz.a wrote:
> > you want to change the desktop theme from light to dark but with oxygen
> > icons. you can switch everything in the look and feel kcm and than you
> have
> > to switch to the icon group. with see also you go to look and feel
> package
> > see the kcm's from the group and on bottom a see also section with color,
> > window and desktop switcher, ... and everything that the look and feel
> > package change.
> >
> > mockup as example
> > https://share.kde.org/index.php/s/FKeKaxhx07q8K48
>
> how would it be done? information in the desktop file about other related
> kcms?
>
> --
> Marco Martin
>

yes that's the idea cause if nobody update the .desktop file it look how it
is now but if someone (me) add stuff than it show the see also section.
>From the idea something like the search stuff in the .desktop file.

e.g. in the Look and Feel kcm you can show ALL related KCM's in the see
also section.

Andreas

Re: SystemSettings See also links

[Marco Martin]

On Friday 09 September 2016, kainz.a wrote:
> you want to change the desktop theme from light to dark but with oxygen
> icons. you can switch everything in the look and feel kcm and than you have
> to switch to the icon group. with see also you go to look and feel package
> see the kcm's from the group and on bottom a see also section with color,
> window and desktop switcher, ... and everything that the look and feel
> package change.
> 
> mockup as example
> https://share.kde.org/index.php/s/FKeKaxhx07q8K48

how would it be done? information in the desktop file about other related 
kcms?

-- 
Marco Martin

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 5 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 19 Sep 2016 07:52:30 +
Build duration: 3 min 57 sec

CHANGE SET
Revision 4185373fc2b8ec7a27f21b4db68ef7799ac34762 by hein: (Disable 
filter-bypass by demands-attention windows.)
  change: edit applets/pager/plugin/pagermodel.cpp
Revision d7d135fda4930d4152c11d5abbbc1ae34b3ec781 by hein: (Fix disabling 
launcher toggle action if launcher URL is empty.)
  change: edit applets/taskmanager/package/contents/ui/ContextMenu.qml
Revision cb7f58b14d800be7b6ddb65b7d772afa2325d825 by hein: (Pick up on virtual 
desktop name changes at runtime.)
  change: edit applets/pager/plugin/pagermodel.cpp

[Differential] [Closed] D2806: Pick up on virtual desktop name changes at runtime.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPcb7f58b14d80: Pick up on virtual desktop name 
changes at runtime. (authored by hein).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2806?vs=6793=6811

REVISION DETAIL
  https://phabricator.kde.org/D2806

AFFECTED FILES
  applets/pager/plugin/pagermodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, graesslin, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2803: Disable filter-bypass by demands-attention windows.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP4185373fc2b8: Disable filter-bypass by 
demands-attention windows. (authored by hein).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2803?vs=6790=6809

REVISION DETAIL
  https://phabricator.kde.org/D2803

AFFECTED FILES
  applets/pager/plugin/pagermodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2805: Fix disabling launcher toggle action if launcher URL is empty.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPd7d135fda493: Fix disabling launcher toggle 
action if launcher URL is empty. (authored by hein).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2805?vs=6792=6810

REVISION DETAIL
  https://phabricator.kde.org/D2805

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2807: Treat NET::Utility type windows as SkipTaskbar.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE7dee461947ae: Treat NET::Utility type windows 
as SkipTaskbar. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2807?vs=6794=6808

REVISION DETAIL
  https://phabricator.kde.org/D2807

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/xwindowtasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, broulik, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2804: Add an ultimate fallback to WM_CLASS Class for AbstractTasksModel::AppId in XWindowsTasksModel.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE5e30fc609e76: Add an ultimate fallback to 
WM_CLASS Class for AbstractTasksModel::AppId in… (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2804?vs=6791=6807

REVISION DETAIL
  https://phabricator.kde.org/D2804

AFFECTED FILES
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, broulik, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2802: Make it possible to disable filter-bypass by demands-attention tasks.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE1c0593f8ec65: Make it possible to disable 
filter-bypass by demands-attention tasks. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2802?vs=6789=6806

REVISION DETAIL
  https://phabricator.kde.org/D2802

AFFECTED FILES
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas