D9275: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij added a comment.


  In D9275#207435 , @mvourlakos wrote:
  
  > > Would you please add a HACK so that we know when to remove this?
  >
  > You mean as a comment ?
  
  
  Yes, preferably with the Qt bug number and some explanation.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10490: Add a method to dbus interface to query information about a window

[Martin Flöser]

graesslin marked an inline comment as done.
graesslin added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> davidedmundson wrote in dbusinterface.cpp:193
> can you add:
> 
> if (m_replyQuery...) {sendError()}
> 
> otherwise if a user makes two calls without selecting a window inbetween the 
> first call will just never get a response

That's already the case. If we get into this situation the underlying 
functionality returns nullptr and thus error message is send.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10490

To: graesslin, #kwin, #plasma
Cc: davidedmundson, broulik, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart

D10490: Add a method to dbus interface to query information about a window

[Martin Flöser]

graesslin updated this revision to Diff 27318.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Remove unneeded comment

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10490?vs=27094&id=27318

BRANCH
  rules-detect-dbus

REVISION DETAIL
  https://phabricator.kde.org/D10490

AFFECTED FILES
  dbusinterface.cpp
  dbusinterface.h
  kcmkwin/kwinrules/CMakeLists.txt
  kcmkwin/kwinrules/detectwidget.cpp
  kcmkwin/kwinrules/detectwidget.h
  kcmkwin/kwinrules/ruleswidget.cpp
  kcmkwin/kwinrules/ruleswidget.h
  org.kde.KWin.xml

To: graesslin, #kwin, #plasma
Cc: davidedmundson, broulik, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, iodelay, 
bwowk, hardening

D10480: align checkable widgets in menu items

[Vlad Zagorodniy]

zzag added a comment.


  > Here: if you look at the last checkbox (folders first). The distance to the 
left edge is larger to that of the bottom edge, while before they were 
identical.
  
  Oh, I haven't noticed that before. To me, that's still fine.
  
  > So this really depends on what we want to align with what ...
  
  I'd propose to align check boxes between the left edge and icon/text. (or 
leave it as it is right now)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:ddd406dfd91c: [effects] replace old slide effect with a 
new one (authored by zzag).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=27190&id=27317

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/effect_builtins.cpp
  effects/slide/slide.cpp
  effects/slide/slide.h
  effects/slide/slide.kcfg
  effects/slide/slide_config.cpp
  effects/slide/slide_config.h
  effects/slide/slide_config.ui

To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, iodelay, bwowk, hardening

Does Breeze provide QtQuick2 theming?

[Ongun Kanat]

Hello,

I was testing a QtQuick2 application
(https://github.com/agateau/sfxr-qt). One thing I noticed, using dark
color schemes (i.e Breeze Dark) result in unreadable white-ish text on
white window backgrounds in QtQuick2 applications like [1]. Example
code in Qt docs also show similar behavior.

I wonder if Breeze provide QtQuick2 theming support. It looks like
some level of support is existing since buttons follow selected color
scheme.

Regards
-Ongun

[1] 
https://user-images.githubusercontent.com/3601965/36073061-64b79a6a-0f3b-11e8-9943-8fdb04b25aa0.png

D10563: Place toolbox in the top right corner of the screen

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> ToolBoxRoot.qml:143
>  function placeToolBox(ts) {
> +// if nothing has been setup yet, determin default position based on 
> layout direction
> +if (!ts) {

'determine'

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: cfeck, rikmills, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10259: [Look and feel KCM] Fix copying color scheme data

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6ab44dcb86b1: [Look and feel KCM] Fix copying color 
scheme data (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10259?vs=26399&id=27313#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10259?vs=26399&id=27313

REVISION DETAIL
  https://phabricator.kde.org/D10259

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: kossebau, broulik, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  > Would you please add a HACK so that we know when to remove this?
  
  You mean as a comment ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10563: Place toolbox in the top right corner of the screen

[Nathaniel Graham]

ngraham added a comment.


  Apparently Kubuntu has been patching this for three years. I only found out 
today...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: rikmills, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Kai Uwe Broulik]

broulik added a comment.


  > If and when this goes in, any chance you could land it for 5.12.x?
  
  Strictly speaking, this is a behavior change, feature, not a bugfix per se.
  
  > This would let Kubuntu get rid of a downstream override, and help other 
distros planning to package 5.12.
  
  They could have told us earlier that they're patching it… distros could also 
just apply this patch if they want to.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: rikmills, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Nathaniel Graham]

ngraham added a comment.


  If and when this goes in, any chance you could land it for 5.12.x? This would 
let Kubuntu get rid of a downstream override, and help other distros planning 
to package 5.12.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: rikmills, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10562: [Clipboard plasmoid] Improved barcode selection button

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7ef47a72bffc: [Clipboard plasmoid] Improved barcode 
selection button (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10562?vs=27303&id=27307

REVISION DETAIL
  https://phabricator.kde.org/D10562

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml

To: broulik, #plasma, graesslin, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This moves it out of the way of desktop icons and is also what Plasma 4 did.
  The code is adjusted to mirror the position for right-to-left languages.
  
  BUG: 390038

TEST PLAN
  The last time I tried this I had the toolbox reposition itself topleft again 
when it moved out of the way of a top panel but I cannot reproduce this right 
now, needs some more testing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10560: [Clipboard plasmoid] Support Aztec barcode

[David Edmundson]

davidedmundson added a comment.


  There surely needs to be some CMake change somewhere with the version?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10560

To: broulik, #plasma, graesslin, vkrause
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10562: [Clipboard plasmoid] Improved barcode selection button

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10562

To: broulik, #plasma, graesslin, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10562: [Clipboard plasmoid] Improved barcode selection button

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Right-align the menu to the button and keep the button highlighted while it 
is open.

TEST PLAN
  F5713320: Screenshot_20180215_223938.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10562

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml

To: broulik, #plasma, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10560: [Clipboard plasmoid] Support Aztec barcode

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, graesslin, vkrause.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This was added in Prison 5.42

TEST PLAN
  F5713298: Screenshot_20180215_223033.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10560

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  klipper/clipboardjob.cpp

To: broulik, #plasma, graesslin, vkrause
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7087: Add "Copy Info" button to the About System KCM

[Dominik Haumann]

dhaumann added a comment.


  One small suggestion to improve the clipboard code.

INLINE COMMENTS

> Module.cpp:256
> +{
> +auto clipboard = QGuiApplication::clipboard();
> +QMapIterator i(collectedData);

Nitpicking: Why do you declare the clipboard here, when you use it only 10 
lines later? :-) Better would be:

  QGuiApplication::clipboard()->setText(text);

So just one line at the end.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: Add "Copy Info" button to the About System KCM

[Dominik Haumann]

dhaumann added a comment.


  Thinking about it, what about this: The dialog already has all the QLabels. 
What you could do is something along the lines:
  
QString text;
if (!ui->plasma.text().isEmpty()) {
text += i18n("%1: %2", ui->plasmaLabel, ui->plasma.text()); 
}
if (!ui->bla.text.isEmpty()) {
text += i18n("%1: %2", ui->blaLabel, ui->bla.text());
}
QGuiApplication::clipboard()->setText(text);
  
  What you would gain is that the code - albeit maybe a bit verbose - is 
simple, easy to understand and extend, and all the copy-to-clipboard code is in 
one place. And it reuses what's already in the labels. The i18n() thing may 
still be problematic, but given the dialog itself already uses two different 
labels for the text, this mostly should be fine.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D10557: [Clipboard plasmoid] Split delegate into separate files

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The delegate is quite heavy with lots of seldom used items and opening the 
clipboard plasmoid takes a significant amount of time.

TEST PLAN
  - Plasmoid opens almost instantly now
  - Verified that single line and multi line text still shows properly
  - Verified that delegate height is correct in all cases (initially, multi 
line text, with tool buttons shown, image, list)
  - Unchecked "ignore images", copied image, delegate was shown correctly
  - Copied a couple of files, they showed up correctly, both when there's 
enough room and when it overflows "+n files"
  - Verified that clicking a delegate item copies it to clipboard and moves it 
to the top
  - Removing items from history still works
  - Generating barcode still works
  - Configured an action, copied some text with it in, clicked "run action" 
button, popup to choose action showed up and action could be triggered
  - Verified that tool buttons are created only on hover and only once
  - Verified that the fancy gradient is rendered correctly in both LTR and RTL 
mode

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10557

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/clipboard/contents/ui/DelegateToolButtons.qml
  applets/clipboard/contents/ui/ImageItemDelegate.qml
  applets/clipboard/contents/ui/TextItemDelegate.qml
  applets/clipboard/contents/ui/UrlItemDelegate.qml

To: broulik, #plasma, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7087: Add "Copy Info" button to the About System KCM

[Henrik Fehlauer]

rkflx added a comment.


  In D7087#207286 , @dhaumann wrote:
  
  > In fact, I wonder whether there already is a script or similar helper tools 
that give you this kind of system information. I currently do not remember, 
though... Anyone else?
  
  
  Do you mean `inxi -Fxxxz`? Surely that's material for a different patch, but 
might be a nice idea to integrate. It's more hardware related, though, less 
about software versions.
  
  I guess for a useful https://bugs.kde.org report the only thing missing is 
the KDE Applications version and some info about the graphics card + driver.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D10552: Keep item highlighted when context menu opens

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  and others excluding Kickoff :P

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10552

To: hein, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10259: [Look and feel KCM] Fix copying color scheme data

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Looks good to me but I don't feel confident enough to give it a shipit but if 
it fixes the unittest and works..

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixsettingcolorschemelnf

REVISION DETAIL
  https://phabricator.kde.org/D10259

To: kossebau, broulik, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7087: Add "Copy Info" button to the About System KCM

[Dominik Haumann]

dhaumann added a comment.


  I can see the reason for English text only. Then again, I think that @rkflx 
has a very valid argument as well. I do not know any other place in KDE that 
intentionally uses non-translatable text. That's why I agree with @rkflx to 
better translate this.
  
  In fact, I wonder whether there already is a script or similar helper tools 
that give you this kind of system information. I currently do not remember, 
though... Anyone else?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D9275: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij added a comment.


  In D9275#207260 , @mvourlakos wrote:
  
  > @mart I fixed this issue by changing these lines to:
  >
  >   113LayoutMirroring.enabled: Qt.application.layoutDirection 
=== Qt.RightToLeft
  >   114LayoutMirroring.childrenInherit: true
  >
  
  
  Would you please add a HACK so that we know when to remove this? This is 
because `Popup` doesn't inherit `LayoutMirroring` and bases the direction 
according to the locale used, exactly as in the Qt bug report I've mentioned 
above.
  
  In normal conditions, where language = locale, this is not needed. But in 
cases where they are different, the locale direction is preffered for `Popup`, 
and therfore this will be needed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  @mart I fixed this issue by changing these lines to:
  
113LayoutMirroring.enabled: Qt.application.layoutDirection === 
Qt.RightToLeft
114LayoutMirroring.childrenInherit: true

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  @safaalfulaij @mart we need to revert this...
  with frameworks 5.43 it reverses list items always!!!
  
  The issue is still present when the PlasmaComponents3.ComboBox is used in the 
Latte settings window,
  that is the items are not aligned correctly in --reverse mode

INLINE COMMENTS

> safaalfulaij wrote in ComboBox.qml:113
> So it is true even for LTR locales?

yes,
in my system with these settings the combobox list items are aligned correctly 
for both
LTR and --reverse

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10392: Don't trigger SwipeListItem's actions unless they are exposed

[Igor Cota]

icota updated this revision to Diff 27292.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10392?vs=27290&id=27292

REVISION DETAIL
  https://phabricator.kde.org/D10392

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: icota, #kirigami
Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein

D10392: Don't trigger SwipeListItem's actions unless they are exposed

[Igor Cota]

icota added a comment.


  @mart Only as a favour to you for the more elegant solution. Thanks!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

To: icota, #kirigami
Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein

D10392: Don't trigger SwipeListItem's actions unless they are exposed

[Igor Cota]

icota updated this revision to Diff 27290.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10392?vs=26783&id=27290

REVISION DETAIL
  https://phabricator.kde.org/D10392

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: icota, #kirigami
Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein

D10297: Add new "Tools" button above System Monitor's process list

[Nathaniel Graham]

ngraham added a comment.


  I think putting on that tab seems sensible enough because it's one of the 
default tabs, and the one that ksysguard opens to. Anybody sho'w such an 
advanced user that they customize their ksysguard tabs and don't use this one 
isn't actually going to need these tools in the first place.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10392: Don't trigger SwipeListItem's actions unless they are exposed

[Marco Martin]

mart added a comment.


  that's how i did it locally tough still need fixes
  Item {
  
id: behindItem
parent: listItem
z: -1
//TODO: a global "open" state
enabled: background.x !== 0
  
  do you want to push this yourself?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10392

To: icota, #kirigami
Cc: mart, apol, plasma-devel, davidedmundson, hein

D10553: Fix dash, enable dash settings, and card options

[Aditya Mehra]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:dbc370f8c72a: Fix dash, enable dash settings, and card 
options (authored by Aiix).

REPOSITORY
  R846 Mycroft Plasma integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10553?vs=27287&id=27288

REVISION DETAIL
  https://phabricator.kde.org/D10553

AFFECTED FILES
  plasmoid/contents/ui/DashNewsDelegate.qml
  plasmoid/contents/ui/DashWeatherDelegate.qml
  plasmoid/contents/ui/DashboardDelegate.qml
  plasmoid/contents/ui/DashboardType.qml
  plasmoid/contents/ui/DisclaimerCardDelegate.qml
  plasmoid/contents/ui/Suggestions.qml
  plasmoid/contents/ui/main.qml

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10553: Fix dash, enable dash settings, and card options

[Aditya Mehra]

Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Aiix requested review of this revision.

REVISION SUMMARY
  Dash improvements to mycroft plasmoid
  
  - Dashboard activation when mycroft is disabled or when conversation area is 
empty
  - Fix: Card settings
  - Fix: Dashboard respects Dash/Cards enable/disable settings accordingly 
falls back to legacy disclaimer
  - Rework: Cards menu look and feel to match system theme and use theme icons
  - Added: Seperate menu enteries for seperate cards in context to the card, 
cards can be individually removed or completely disabled from the card menu 
itself

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10553

AFFECTED FILES
  plasmoid/contents/ui/DashNewsDelegate.qml
  plasmoid/contents/ui/DashWeatherDelegate.qml
  plasmoid/contents/ui/DashboardDelegate.qml
  plasmoid/contents/ui/DashboardType.qml
  plasmoid/contents/ui/DisclaimerCardDelegate.qml
  plasmoid/contents/ui/Suggestions.qml
  plasmoid/contents/ui/main.qml

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10346: check for EGL_KHR_platform_gbm extension as well

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:8a2b9a014f7d: check for EGL_KHR_platform_gbm extension as 
well (authored by mart).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10346?vs=27228&id=27284

REVISION DETAIL
  https://phabricator.kde.org/D10346

AFFECTED FILES
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/virtual/egl_gbm_backend.cpp

To: mart, #kwin, #plasma, davidedmundson, graesslin
Cc: graesslin, garg, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, iodelay, 
bwowk, hardening

D10552: Keep item highlighted when context menu opens

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Now consistent with Kicker and others.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10552

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml

To: hein, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10550: Unbreak DND.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1b771cc9: Unbreak DND. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10550?vs=27279&id=27280

REVISION DETAIL
  https://phabricator.kde.org/D10550

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10550: Unbreak DND.

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10550

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10550: Unbreak DND.

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Fixes regression from 31bcd0ac9590 
.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10550

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml

To: hein, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10549: Don't crash if the cursor theme fails to create

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  If the cursor theme failed to create KWin crashed due to an endless
  recursion. There are two reasons for this fault:
  
  1. When the physical size does not exist we perform a division by 0
  
  which results in an invalid size going into wl_cursor_theme_load
  
  2. We emit the signal that the cursor theme changed even if it didn't
  
  change thus creating an endless recursion
  
  This change addresses both problems: it checks that the size is not 0
  and changes the handling for theme update to only destroy the previous
  theme if the new theme could be created and only emits the signal if
  things change.
  
  BUG: 390314
  FIXED-IN: 5.12.2

TEST PLAN
  Added a new test case which crashed with old code

REPOSITORY
  R108 KWin

BRANCH
  dont-crash-cursor-theme-failure

REVISION DETAIL
  https://phabricator.kde.org/D10549

AFFECTED FILES
  autotests/integration/CMakeLists.txt
  autotests/integration/dont_crash_cursor_physical_size_empty.cpp
  wayland_cursor_theme.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

BRANCH
  effects/slide

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D10346: check for EGL_KHR_platform_gbm extension as well

[Martin Flöser]

graesslin accepted this revision.
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10346

To: mart, #kwin, #plasma, davidedmundson, graesslin
Cc: graesslin, garg, davidedmundson, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas, apol, mart

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

[David Edmundson]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:53ed39aaa477: Micro-optimise screenpool event filter by 
caching xcb extension offset (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10538?vs=27270&id=27277

REVISION DETAIL
  https://phabricator.kde.org/D10538

AFFECTED FILES
  shell/CMakeLists.txt
  shell/autotests/CMakeLists.txt
  shell/screenpool.cpp
  shell/screenpool.h

To: davidedmundson, #plasma, broulik, jtamate
Cc: jtamate, mart, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Plasma sprint in Berlin, Germany: April 21st-27th 2018

[Eike Hein]

Hi,

I'm happy to announce we're going to have another Plasma sprint
in a few months, from April 21st to April 27th in Berlin, Germany.

Join the sprint to make all things Plasma even better in an
intense-but-fun week of planning, designing and hacking!

The sprint will be held at the offices of Endocode AG, who have kindly
agreed to host us this time.

More information is being added here:
https://community.kde.org/Sprints#Upcoming_Sprints

And of course the event is listed at https://reimbursements.kde.org/ for
your travel support needs.

See you there!


Cheers,
Eike

PS.: KDE e.V. is having a housewarming party at its new Berlin office on
the 28th, so you might want to stick around in town a bit longer!

D10259: [Look and feel KCM] Fix copying color scheme data

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10259

To: kossebau, broulik, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

[Jaime Torres Amate]

jtamate accepted this revision.
jtamate added a comment.


  F5713055: plasmashell_screenpool_after.png 

  
  Even the number of calls registered are less, now most of the time is spent 
doing the eventType != "xcb_generic_event_t".

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10538

To: davidedmundson, #plasma, broulik, jtamate
Cc: jtamate, mart, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

[Andreas Sturmlechner]

asturmlechner added a comment.


  > (so as to not conflict with kdelibs4's kdesu).
  
  I don't think you need to care about conflicts with kde-runtime at this 
point. There is no reason why on a Plasma-5 system the old binary should be 
present as it works like a drop-in replacement.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D10541

To: sitter
Cc: asturmlechner, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

[Henrik Fehlauer]

rkflx added a comment.


  Just tried the patch. I think for System Activity / [Ctrl] + [⎋] the button 
is fine (annoyingly with a slightly larger height than the combobox, but that's 
life…). For KSysGuard itself it looks a bit odd, why would it appear exactly on 
this tab page? I could imagine the menubar would be a better place.
  
  (Sorry this comes so late, I only reviewed in more detail because nobody from 
Plasma bothered so far. Ignore my comment if you want.)

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

[Andres Betts]

abetts added a comment.


  Looks good to me. I would change the hover animation. Most places that use 
star ratings tend to highlight all stars up to where your cursor is located. It 
gives the impression that you are also enabling the starts up to your location. 
If your cursor is in the fourth star, then also highlight the 3 start before it.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10500

To: ngraham, #discover_software_store, apol, abetts
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7087: Add "Copy Info" button to the About System KCM

[Henrik Fehlauer]

rkflx added a comment.


  And what if someone is asked in a forum or chat operating in a language 
different than English to provide those information? I'd say we should just go 
with the flow, i.e. what you see is what gets copied. It's already translated, 
just like what you can copy in Help > About Kate > Libraries, and everybody 
will understand "Qt" and recognize the version strings anyway.
  
  Therefore, my vote is on #2. Could you just get to the translation with 
`text()` dynamically?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D10500: Make the review pop-up a bit more user-friendly

[Nathaniel Graham]

ngraham added reviewers: apol, abetts.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10500

To: ngraham, #discover_software_store, apol, abetts
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10548: Improve app list padding under the header

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:89cf44b3e207: Improve app list padding under the header 
(authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10548?vs=27273&id=27274

REVISION DETAIL
  https://phabricator.kde.org/D10548

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml
  discover/qml/BrowsingPage.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D10548: Improve app list padding under the header

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-app-list-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10548

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D10548: Improve app list padding under the header

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10548

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D10548: Improve app list padding under the header

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Make sure the delegates don't touch the header. Looks cleaner this way.

TEST PLAN
  Featured page, before:
  
  Featured page, after:
  
  App list page, before:
  
  App list page, after:

REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-app-list-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10548

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml
  discover/qml/BrowsingPage.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  normal in Latte
  F5713010: εικόνα.png 
  
  needsattention in Latte
  F5713020: εικόνα.png 

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos closed this revision.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  merged with: 
https://commits.kde.org/plasma-active-window-control/d07bd170d39adab35b7861ab6c480286a4d0253e

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi edited the summary of this revision.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi added a comment.


  In D7087#207081 , @ngraham wrote:
  
  > Fine from my side. We still need to figure out the translation 
issue--either work to make it translatable, or accept that this output will be 
English-only. I'll let the other reviewers have their say on that matter.
  
  
  Ok.
  
  About the translation: for me the question was not whether or not we have to 
accept that the output is English-only; but rather if it is desirable to have 
bug reports where someone pastes non-English system info. I see three options 
here:
  
  1. Keep it English (which might be strange for non-English users) but will 
lead to pure English bug reports
  2. Make it translatable and if the order of the lines are the same for each 
language, someone who reads bug reports with that info pasted in, can figure 
out what each line means, even if it is not English
  3. Make two items: one is translated ("Copy Info") and the other one is not 
("Copy Info for Bug Reports")

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D10525: Only let the user write the first review if they've actually installed the app

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:e6c35b6d5c69: Only let the user write the first review if 
they've actually installed the app (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10525?vs=27271&id=27272#toc

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10525?vs=27271&id=27272

REVISION DETAIL
  https://phabricator.kde.org/D10525

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  In D10516#206606 , @martinkostolny 
wrote:
  
  > thanks!
  
  
  fatal: remote error: service not enabled: /plasma-active-window-control
  
  unfortunately I can commit, I get:
  
fatal: remote error: service not enabled: /plasma-active-window-control
  
  @martinkostolny feel to commit it...

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10525: Only let the user write the first review if they've actually installed the app

[Nathaniel Graham]

ngraham updated this revision to Diff 27271.
ngraham added a comment.


  Remove the enabled: part of this patch; will manually commit it to 5.12, 
since it has no string changes

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10525?vs=27207&id=27271

BRANCH
  dont-write-first-review-unless-app-is-installed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10525

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

[David Edmundson]

davidedmundson updated this revision to Diff 27270.
davidedmundson added a comment.


  change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10538?vs=27252&id=27270

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10538

AFFECTED FILES
  shell/CMakeLists.txt
  shell/autotests/CMakeLists.txt
  shell/screenpool.cpp
  shell/screenpool.h

To: davidedmundson, #plasma, broulik
Cc: jtamate, mart, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10544: Avoid cmake duplication

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fdd24e9f7ad3: Avoid cmake duplication (authored by 
davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10544?vs=27255&id=27269

REVISION DETAIL
  https://phabricator.kde.org/D10544

AFFECTED FILES
  shell/CMakeLists.txt

To: davidedmundson, #plasma, bshah
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10527: Improve "show more reviews" string and logic

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:47d77057ded5: Improve "show more reviews" 
string and logic (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10527?vs=27209&id=27268

REVISION DETAIL
  https://phabricator.kde.org/D10527

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

[Jaime Torres Amate]

jtamate added inline comments.

INLINE COMMENTS

> broulik wrote in screenpool.cpp:44
> Needs x11 guard

Shouldn't it be a #if HAVE_X11?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10538

To: davidedmundson, #plasma, broulik
Cc: jtamate, mart, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10524: Improve ToolBarApplicationHeader left padding and eliding behavior

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10524

To: ngraham, #kirigami, apol, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D7087: Add "Copy Info" button to the About System KCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Fine from my side. We still need to figure out the translation issue--either 
work to make it translatable, or accept that this output will be English-only. 
I'll let the other reviewers have their say on that matter.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27263.
mart added a comment.


  - less aggressive preload policy

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27169&id=27263

BRANCH
  mart/preload

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D10545: [KickoffItem] Remove wrapper Item

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:df0e74966623: [KickoffItem] Remove wrapper Item (authored 
by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10545?vs=27260&id=27262

REVISION DETAIL
  https://phabricator.kde.org/D10545

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffItem.qml

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10546: [Kickoff] Turn ActionMenu into a QtObject

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  `PlasmaComponents.MenuItem` is a QQuickItem, for whatever reason, I suspect 
for recursive enabled/visible handling, and with my patch it then complains 
about not having been placed in a scene.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10546

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10546: [Kickoff] Turn ActionMenu into a QtObject

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10546

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10545: [KickoffItem] Remove wrapper Item

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10545

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10546: [Kickoff] Turn ActionMenu into a QtObject

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It's not a visual item and the `PlasmaComponents.Menu` is also just a regular 
`QObject`, no point in our menu wrapper being an `Item`.

TEST PLAN
  Menu still shows up correctly, favorites action still works

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10546

AFFECTED FILES
  applets/kickoff/package/contents/ui/ActionMenu.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10545: [KickoffItem] Remove wrapper Item

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  There's a `MouseArea` with `anchors.fill` within an `Item`, just merge the 
two. There's no references to the `Item`.

TEST PLAN
  Launching apps still works, context menu still works

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10545

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffItem.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10544: Avoid cmake duplication

[Bhushan Shah]

bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10544

To: davidedmundson, #plasma, bshah
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  Things look bad when a bitmap icon appears in the tray... (e.g. Remmina) It 
seems `roundToIconSize` is necessary for bitmap icons.
  
  I think I am going to abandon this patch, as the necessary changes are simply 
too big:
  
  - all references to `marginHints` in the systemtray should be removed, and 
`spacing` used instead
  - `Units::roundToIconSize` has to be changed so it works on real pixels and 
not on density-independent pixels - now it breaks down on HiDPI screens
  
  I think no of these two changes are going to be accepted, unless someone 
knows why exactly these two things are implemented the current way.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: anthonyfieroni, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10522: Added vertical separator

[Alex Nemeth]

anemeth abandoned this revision.
anemeth added a comment.


  This change was submitted to supplement D10438 

  Because it was reverted in D10530  this 
change is not needed anymore.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10522

To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg
Cc: mart, zzag, mmustac, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10544: Avoid cmake duplication

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  All things we need exists in the top level CMakeLists

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10544

AFFECTED FILES
  shell/CMakeLists.txt

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: Plasma is very slowly

[Aleix Pol]

On Thu, Feb 15, 2018 at 2:13 PM, Christoph Feck  wrote:
> On 15.02.2018 11:24, Андрей Черный wrote:
>>
>>
>>
>
> Why are you running plasmashell multiple times? Fix your mess before
> bothering developers with it.

htop lists every thread separately I think. Mine looks more impressive:
https://i.imgur.com/EsiFdj9.png

I moderated this message in so he probably didn't see your answer anyway. :P

Aleix

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

[Harald Sitter]

sitter added a comment.


  Currently targeting 5.12 but I am not too sure that is an entirely suitable 
change. Input welcome.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D10541

To: sitter
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

[David Edmundson]

davidedmundson updated this revision to Diff 27252.
davidedmundson added a comment.


  guard

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10538?vs=27237&id=27252

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10538

AFFECTED FILES
  shell/CMakeLists.txt
  shell/autotests/CMakeLists.txt
  shell/screenpool.cpp
  shell/screenpool.h

To: davidedmundson, #plasma, broulik
Cc: mart, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

[Harald Sitter]

sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  as recently mused over on the plasma-devel list. nobody really knows
  why it's not installed to bindir and at the same time various
  distributions manually symlink it there because they think it is useful.
  from a scripting POV it certainly makes more sense to have the tool in bin
  as libexec may not be easily resolvable (32bit vs 64bit vs architecture
  triplets on various distributions).
  
  by default we'll now symlink kdesu to the bindir under the name kdesu5
  (so as to not conflict with kdelibs4's kdesu).
  
  this feature can be opted out of by setting KDESU_SYMLINK=OFF

TEST PLAN
  - cmake && make && make install DESTDIR=x
  - ls -l x/usr/local/bin/kdesu5
  - symlinks correctly
  - cmake -DKDESU_SYMLINK=OFF && make && make install DESTDIR=y
  - ls -l y/usr/local/bin/kdesu5
  - doesn't exist

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10541

AFFECTED FILES
  kdesu/CMakeLists.txt

To: sitter
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  With this new version the tray icons scale exactly like the application icons 
on the left (the "jumps" between icon sizes happen at exactly the same time).

INLINE COMMENTS

> anthonyfieroni wrote in main.qml:42
> I see it has configuration for icon size ? What about to use it?

The goal of this patch is to make the size of the application icons on the left 
side of the panel match the size of the tray icons.
Additionally, the System Settings -> Icons -> Panel icon size adjustment will 
affect the tray icons too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: anthonyfieroni, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10540: [Kickoff] Move RunnerModel to SearchView

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:30530ab36020: [Kickoff] Move RunnerModel to SearchView 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10540?vs=27249&id=27250

REVISION DETAIL
  https://phabricator.kde.org/D10540

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml
  applets/kickoff/package/contents/ui/SearchView.qml

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10540: [Kickoff] Move RunnerModel to SearchView

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10540

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10540: [Kickoff] Move RunnerModel to SearchView

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It's only used there.

TEST PLAN
  Verified that SearchView is created only once (conditional loader) and not 
re-created every time a query is fired
  Searching still works
  Invoking a result, jump list actions, and pinning a result to panel still 
worked

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10540

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml
  applets/kickoff/package/contents/ui/SearchView.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos updated this revision to Diff 27248.
pgkos added a comment.


  Cancel out the enlargement of AbstractItem by the tasksRow's marginHints.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10487?vs=27139&id=27248

BRANCH
  tray-icon-size-fix

REVISION DETAIL
  https://phabricator.kde.org/D10487

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: pgkos, #plasma_workspaces, davidedmundson
Cc: anthonyfieroni, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma is very slowly

[Christoph Feck]

On 15.02.2018 11:24, Андрей Черный wrote:





Why are you running plasmashell multiple times? Fix your mess before 
bothering developers with it.

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart added a comment.


  sooo, benchmarks:
  i tracked the time that occurs between mouse click and the return of 
setExpanded, which is reasonably near to the popup actually appearing (numbers 
consistent doing things more than once)
  this is done on a fairly fast machine, would be interesting to do the same on 
a really slow one, like the pinebook
  
  Kickoff: no preload, before incubator removal: 279 msecs
  Kickoff: no preload, after incubator removal: 211 msec
  Kickoff: with preload: 15 msecs (the first time still takes some tme to build 
all the nodes and texture, second time 0 msecs)
  
  digital clock (with akonadi integration which makes the graphics a bit more 
complex)
  digital clock: no preload, before incubator removal: 739 msecs
  digital clock, no preload , after incubator removal: 234 msecs
  digital clock, preload: 46 msecs (graphically quite complex, takes a more to 
create all textures, second time is 0 as usual)
  
  media player: no preload, before incubator removal: 148 msecs
  media player, no preload  , after incubator removal: 89 msec
  media player, preload: 0 msecs (graphics simple enough for texture creation 
to not register?)
  
  Clipboard, no preload ,  before incubator removal: 191 msec
  Clipboard, no preload ,  after incubator removal: 79 msec
  Clipboard, preload: 0 msec
  
  kicker: no preload, after incubator removal: 79 msecs
  kicker: preload: 9 msec

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D6609: [Kickoff] Allow sorting favorites

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Probably needs to be completely redone with activities-powered favorites

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6609

To: broulik, #plasma, #vdg, davidedmundson
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10480: align checkable widgets in menu items

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D10480#206782 , @zzag wrote:
  
  > Well, I could rework this patch to fix double spacing.
  >
  > Centering of check boxes would involve some changes in margins, which 
should be another diff, right?
  >
  > > positioning appears off with respect to the bottom of the menu, when 
checkboxes is present on the last item of the menu.
  >
  > Hmm, I don't see it. Could you please show where positioning is off?
  
  
  
  
  > F5710626: with-check.png 
  
  Here: if you look at the last checkbox (folders first). The distance to the 
left edge is larger to that of the bottom edge, while before they were 
identical.
  This is because margin width and margin height are different. 
  which in turn is needed for centering. 
  So this really depends on what we want to align with what ...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10507: Turn code.js into a singleton

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0d6792c4a7fc: Turn code.js into a singleton (authored by 
broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10507?vs=27151&id=27245

REVISION DETAIL
  https://phabricator.kde.org/D10507

AFFECTED FILES
  applets/kicker/package/contents/code/tools.js
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/SideBarItem.qml
  applets/kickoff/package/contents/code/tools.js
  applets/kickoff/package/contents/ui/KickoffItem.qml

To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10533: [Icon Item] Set filtering on FadingNode texture

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c05b1bdec790: [Icon Item] Set filtering on FadingNode 
texture (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10533?vs=27226&id=27244

REVISION DETAIL
  https://phabricator.kde.org/D10533

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10523: Fix warnings

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:b95460a4f831: Fix warnings (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10523?vs=27204&id=27243

REVISION DETAIL
  https://phabricator.kde.org/D10523

AFFECTED FILES
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/OverlaySheet.qml

To: apol, #kirigami, mart
Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10535: Fix whitespace

[gregormi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:50229e7ec3c2: Fix whitespace (authored by gregormi).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10535?vs=27232&id=27241

REVISION DETAIL
  https://phabricator.kde.org/D10535

AFFECTED FILES
  processui/ksysguardprocesslist.cpp

To: gregormi, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart