D10475: Make it possible to show the title despite having ctx actions

[Nathaniel Graham]

ngraham added a comment.


  Generally looks good. A few UI comments:
  
  - Let's use a hamburger icon as the default icon, rather than the three-dot 
icon. That's used elsewhere on the list to expose hidden actions; here, it's 
opening a standard drop-down menu, so let's use the more standard icon for it.
  - The button doesn't have enough right padding: F5737034: Not enough 
padding.png 
  - I'm not really satisfied with the presentation when the button has text, as 
seen above; there's no icon, and no downward-pointing arrow  to indicate that 
clicking the button will open a drop-down menu.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10979: missing return statement in trash applet

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  trash

REVISION DETAIL
  https://phabricator.kde.org/D10979

To: mvourlakos, #plasma, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Fwd: Re: kwin display issue on librem5

[Heather Ellsworth]

Forwarding these questions to the KWin and plasma-devel mailing lists.


 Forwarded Message 
Subject: Re: kwin display issue on librem5
Date: Wed, 28 Feb 2018 12:59:39 -0700
From: Heather Ellsworth 
To: subd...@gmail.com
CC: bhus...@gmail.com, Guido Günther , Nicole
Faerber 

On 02/28/2018 11:53 AM, Heather Ellsworth wrote:
> Hi Roman,
> 
> I've been working with Bhushan to get plasma mobile up and running on
> our prototype board and we're having an issue displaying the content.
> Attached is a photo (display_issue.jpg) showing the issue.
> 
> We can force the software framebuffer (export KWIN_COMPOSE=Q) to get
> proper rendering (good_display_forced_framebuffer.jpg) but we don't want
> to force this.
> 
> Guido pointed me to a helpful article:
> https://blog.martin-graesslin.com/blog/2016/07/why-does-kwin_wayland-not-start/
> 
> I tried the various tests suggested in that article and the nested setup
> works fine, there are no fatal errors, and trying on the tty worked ok.
> I should mention that in both the nested setup and trying on the tty,
> the mouse is not visible but is active because i can click the drop down
> menus and whatnot, I just can't see where the cursor is.
> 

It is also worth mentioning that I also tried the following
troubleshooting steps:

1. No kwin_wayland session running

2. Get the dbus environment:
$ env | grep DBUS > /tmp/env
$ cat /tmp/env
DBUS_SESSION_BUS_ADDRESS=unix:abstract=/tmp/dbus-haU84sg3bb,guid=12152191bb2d258c5030793e5a97015f
DBUS_SESSION_BUS_PID=1268

3. In an ssh session to the board, export the vars:
$ export
DBUS_SESSION_BUS_ADDRESS=unix:abstract=/tmp/dbus-haU84sg3bb,guid=12152191bb2d258c5030793e5a97015f
$ export DBUS_SESSION_BUS_PID=1268

4. In a tty on the board, launch kwin_wayland:
$ kwin_wayland --drm plasma-phone

5. In an ssh session to the board:
$ qdbus org.kde.KWin /KWin supportInformation

The qdbus command pretty quickly causes the kwin_wayland to crash with a
seg fault:
Segementation fault (core dumped)d the Wayland compositor die?1-HP
W2371d/6CM2140D0D") "HDMI-A-1-HP W2371d/6CM2140D0D"ty
"GlobalDnsConfiguration"d"e"/usr/share/kservicetypes5/kwineffect.desktop"

In journalctl, we see a piece of the stacktrace but not much:
Feb 28 19:34:05 pureos org.kde.ActivityManager[1268]: The Wayland
connection broke. Did the Wayland compositor die?
Feb 28 19:34:05 pureos org.kde.ActivityManager[1268]: Closing SQL
connection:  "kactivities_db_resources_3069980688_readwrite"
Feb 28 19:34:17 pureos systemd-coredump[1627]: Process 1572
(kwin_wayland) of user 1000 dumped core.

   Stack trace of thread 1572:
   #0  0xb6e5a964
n/a (libkwin.so.5)
Feb 28 19:34:18 pureos kernel: PM: Removing info for No Bus:sit0
Feb 28 19:34:18 pureos kernel: PM: Removing info for No Bus:lo
Feb 28 19:36:12 pureos kernel: wlcore: down

> That article also mentions running kwin on weird systems and I guess our
> dev board counts :)
> 
> So my questions for you are:
> * Do you have any idea what could be missing or causing the
> display_issue.jpg that could be fixed by exporting KWIN_COMPOSE?
> * Do you know how to make the mouse cursor show up?
> 
> Also if there's a better place to ask this (like a kwin irc or mailing
> list), I'm happy to redirect my questions. Once again, thanks for your
> time on this project.
> 
> Cheers,
> Heather
> 






signature.asc
Description: OpenPGP digital signature

D10973: [media controller applet] Support MPRIS services where CanPause==false

[Nathaniel Graham]

ngraham added a dependent revision: D10972: [RFC] Exposing slideshow to MPRIS 
controllers.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10973

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the clarification!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

[Andreas Kainz]

andreask added a comment.


  the patches you linked are for breeze-icons. They are fine and will work. 
Here we are in plasma-framework in the breeze plasma theme that is complete 
separate and in plasma framework the change didn't go to master.
  
  plasma-framework/src/desktoptheme/breeze/icons/network.svgz
  
  maybe @sebas can explain what he want in the plasma theme.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

[Nathaniel Graham]

ngraham added a comment.


  In D10243#217119 , @andreask wrote:
  
  > I'm that much confuse maybe someone can make a screenshot what should be 
changed the opacity was already changed.
  
  
  I'm confused too, since this Phabricator revision is open and in "needs 
revision" state, yet you committed something anyway: 
https://cgit.kde.org/breeze-icons.git/commit/?id=2a6192a4196a5977362fe03bdf6637530c47ec6f
  
  That commit wound up in KDE Frameworks 5.43, but the icon wasn't visibly 
changed. Because of the confusion here regarding the status of this work, I 
announced to the world in a blog post a few weeks ago that 
https://bugs.kde.org/show_bug.cgi?id=384018 was fixed in KDE Frameworks 5.43, 
only to be corrected by the wider internet once it was released and the issue 
persisted. Oops.
  
  This is why we use Phabricator: to make sure that proposed patches actually 
fix the issue they're targeting, and that their status is clear to all. If 
you're having trouble with Phabricator and `arc`, I'd be happy to help you out 
anytime you like. We also have high-quality documentation at 
https://community.kde.org/Infrastructure/Phabricator
  
  And finally: **what is the status of this patch?** Was it already committed 
as 
https://cgit.kde.org/breeze-icons.git/commit/?id=2a6192a4196a5977362fe03bdf6637530c47ec6f,
 or was that separate?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10975: [mediacontroller applet] Remove de-funct "General" configuration page

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:82b01d551b08: [mediacontroller applet] Remove de-funct 
General configuration page (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10975?vs=28426=28443

REVISION DETAIL
  https://phabricator.kde.org/D10975

AFFECTED FILES
  applets/mediacontroller/contents/config/config.qml
  applets/mediacontroller/contents/config/main.xml
  applets/mediacontroller/contents/ui/configGeneral.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

[Andreas Kainz]

andreask added a comment.


  I'm that much confuse maybe someone can make a screenshot what should be 
changed the opacity was already changed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

[Nathaniel Graham]

ngraham added a comment.


  That's the black "network connected" icon, not a red version of the network 
disconnected icon.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

[Andres Betts]

abetts added a comment.


  In D10243#217109 , @andreask wrote:
  
  > F5736934: network.svgz 
  >
  > sorry I'm not the maintainer for the breeze plasma theme and arc isn't my 
friend so I upload the svg file with the red color here. If someone want to 
have the ? in read than push it to master.
  
  
  What is the color HEX that you need for "?"?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10243: Improve visibility of disconnected Wi-Fi icons

[Andreas Kainz]

andreask added a comment.


  F5736934: network.svgz 
  
  sorry I'm not the maintainer for the breeze plasma theme and arc isn't my 
friend so I upload the svg file with the red color here. If someone want to 
have the ? in read than push it to master.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma kwin stable-kf5-qt5 FreeBSDQt5.9 - Build # 44 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20stable-kf5-qt5%20FreeBSDQt5.9/44/
 Project:
Plasma kwin stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 18:45:52 +
 Build duration:
2 hr 16 min and counting
   JUnit Tests
  Name: (root) Failed: 11 test(s), Passed: 109 test(s), Skipped: 0 test(s), Total: 120 test(s)Failed: TestSuite.kwin-testClientMachineFailed: TestSuite.kwin-testDebugConsoleFailed: TestSuite.kwin-testDecorationInputFailed: TestSuite.kwin-testDecorationInput-waylandonlyFailed: TestSuite.kwin-testInternalWindowFailed: TestSuite.kwin-testInternalWindow-waylandonlyFailed: TestSuite.kwin-testLockScreenFailed: TestSuite.kwin-testPointerInputFailed: TestSuite.kwin-testShellClientFailed: TestSuite.kwin-testShellClient-waylandonlyFailed: TestSuite.kwin-testXClipboardSync

KDE CI: Plasma ksysguard stable-kf5-qt5 FreeBSDQt5.9 - Build # 16 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20ksysguard%20stable-kf5-qt5%20FreeBSDQt5.9/16/
 Project:
Plasma ksysguard stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 18:46:14 +
 Build duration:
1 hr 57 min and counting

D10979: missing return statement in trash applet

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  The missing return was causing to set
  Layout.minimumHeight in not correct value.
  The issue was discovered when the trash
  applet wasnt working with Latte parabolic
  effect when it was in vertical docks.

TEST PLAN
  I made the change  and retested that everything works ok
  in the panel or in the desktop.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  trash

REVISION DETAIL
  https://phabricator.kde.org/D10979

AFFECTED FILES
  applets/trash/package/contents/ui/main.qml

To: mvourlakos, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 65 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/65/
 Project:
Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 18:39:02 +
 Build duration:
1 hr 48 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kcm-keyboard-iso_codes

D10975: [mediacontroller applet] Remove de-funct "General" configuration page

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  removeslippedinmediacontrollerconfig

REVISION DETAIL
  https://phabricator.kde.org/D10975

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 56 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/56/
 Project:
Plasma plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 18:39:07 +
 Build duration:
1 hr 41 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 169 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/169/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 18:39:00 +
 Build duration:
1 hr 21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kcm-keyboard-iso_codes

KDE CI: Plasma kscreen kf5-qt5 FreeBSDQt5.9 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20kscreen%20kf5-qt5%20FreeBSDQt5.9/12/
 Project:
Plasma kscreen kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 18:38:57 +
 Build duration:
1 hr 8 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

Re: Fwd: Re: kwin display issue on librem5

[Martin Flöser]

Am 2018-03-02 18:43, schrieb Heather Ellsworth:

Forwarding these questions to the KWin and plasma-devel mailing lists.


 Forwarded Message 
Subject: Re: kwin display issue on librem5
Date: Wed, 28 Feb 2018 12:59:39 -0700
From: Heather Ellsworth 
To: subd...@gmail.com
CC: bhus...@gmail.com, Guido Günther , Nicole
Faerber 

On 02/28/2018 11:53 AM, Heather Ellsworth wrote:

Hi Roman,

I've been working with Bhushan to get plasma mobile up and running on
our prototype board and we're having an issue displaying the content.
Attached is a photo (display_issue.jpg) showing the issue.

We can force the software framebuffer (export KWIN_COMPOSE=Q) to get
proper rendering (good_display_forced_framebuffer.jpg) but we don't 
want

to force this.

Guido pointed me to a helpful article:
https://blog.martin-graesslin.com/blog/2016/07/why-does-kwin_wayland-not-start/

I tried the various tests suggested in that article and the nested 
setup
works fine, there are no fatal errors, and trying on the tty worked 
ok.

I should mention that in both the nested setup and trying on the tty,
the mouse is not visible but is active because i can click the drop 
down

menus and whatnot, I just can't see where the cursor is.



It is also worth mentioning that I also tried the following
troubleshooting steps:

1. No kwin_wayland session running

2. Get the dbus environment:
$ env | grep DBUS > /tmp/env
$ cat /tmp/env
DBUS_SESSION_BUS_ADDRESS=unix:abstract=/tmp/dbus-haU84sg3bb,guid=12152191bb2d258c5030793e5a97015f
DBUS_SESSION_BUS_PID=1268

3. In an ssh session to the board, export the vars:
$ export
DBUS_SESSION_BUS_ADDRESS=unix:abstract=/tmp/dbus-haU84sg3bb,guid=12152191bb2d258c5030793e5a97015f
$ export DBUS_SESSION_BUS_PID=1268

4. In a tty on the board, launch kwin_wayland:
$ kwin_wayland --drm plasma-phone


change this to:

gdb --args kwin_wayland plasma-phone

this should give a backtrace when KWin crashes. Then we have a better 
idea on where it fails.


I would also suggest to add --xwayland for the beginning. It's quite 
likely that something in the session requires it and thus creates 
issues.


And you don't need the --drm. It's the default if no DISPLAY or 
WAYLAND_DISPLAY is set.


Cheers
Martin

KDE CI: Plasma plasma-sdk kf5-qt5 FreeBSDQt5.9 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20plasma-sdk%20kf5-qt5%20FreeBSDQt5.9/17/
 Project:
Plasma plasma-sdk kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 18:38:21 +
 Build duration:
1 hr 2 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma drkonqi stable-kf5-qt5 FreeBSDQt5.9 - Build # 13 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20drkonqi%20stable-kf5-qt5%20FreeBSDQt5.9/13/
 Project:
Plasma drkonqi stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 18:38:12 +
 Build duration:
47 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 152 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/152/
 Project:
Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 18:38:05 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)

KDE CI: Plasma bluedevil stable-kf5-qt5 FreeBSDQt5.9 - Build # 15 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20bluedevil%20stable-kf5-qt5%20FreeBSDQt5.9/15/
 Project:
Plasma bluedevil stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 18:38:02 +
 Build duration:
26 min and counting

KDE CI: Plasma systemsettings stable-kf5-qt5 FreeBSDQt5.9 - Build # 20 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20FreeBSDQt5.9/20/
 Project:
Plasma systemsettings stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 18:37:48 +
 Build duration:
9 min 39 sec and counting

D10975: [mediacontroller applet] Remove de-funct "General" configuration page

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Accidentally sneaked in in branch merge by
  47f30b0fc493a5ab4db5598ff0b4e13b22290b5a

REPOSITORY
  R120 Plasma Workspace

BRANCH
  removeslippedinmediacontrollerconfig

REVISION DETAIL
  https://phabricator.kde.org/D10975

AFFECTED FILES
  applets/mediacontroller/contents/config/config.qml
  applets/mediacontroller/contents/config/main.xml
  applets/mediacontroller/contents/ui/configGeneral.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 177 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/177/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Mar 2018 13:22:30 +
 Build duration:
4 hr 36 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.categoryargFailed: TestSuite.toplevels

D10837: bad textarea width for rename file if filename too short

[Painless Roaster]

painlessroaster added a comment.


  I do not have a contributor account. Please commit this.

REVISION DETAIL
  https://phabricator.kde.org/D10837

To: painlessroaster, #plasma, hein
Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10670: Reduce plasmashell frozen time

[Jaime Torres Amate]

jtamate added a comment.


  In D10670#210702 , @jtamate wrote:
  
  > Updated the summary and added a comment
  
  
  ping? I would like to use the same comment and commit message in 
https://phabricator.kde.org/D10669

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10670

To: jtamate, #frameworks, #plasma, mwolff
Cc: mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10762: Fix the build on armhf/aarch64

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> platform.h:29
> +// declaration, so we have to prevent the Qt header from being #included.
> +#define QOPENGL_H
> +

please also this one through the new header. Just move it into the main 
directory, then you can access it from everywhere.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10762

To: bshah, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10973: [media controller applet] Support MPRIS services where CanPause==false

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Currently the media controller only works with MPRIS services which support
  the PlayPause command. By the MPRIS spec this is an optional feature though.
  While most players out there support this, the MPRIS support in Gwenview
  currently worked on does not (would need some more rewrite of internals).
  Which makes the Media controller applet and/or Gwenview look broken :)
  
  To keep the current design with a central Play/Not Play button, this patch
  changes its behaviour depending on the CanPause flag:
  CanPause=true ->  show either Play or Pause
  CanPause=false -> show either Pkay or Stop
  That should stay close to what people need.

TEST PLAN
  Works with Gwenview patched with MPRIS support.
  Works with VLC, but might need more testing to add some work-arounds as
  mentioned before by broulik.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mpriscontrollersupportnocanpause

REVISION DETAIL
  https://phabricator.kde.org/D10973

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10938: Enable showing top level items in kicker and kickoff menu

[Sergei Lopatin]

lopatin added a comment.


  No, I haven't. Please commit it for me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10938

To: lopatin, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel updated this revision to Diff 28405.
Pitel added a comment.


  In previous revisions I used fillWidth = false but it is wrong because it not 
only prevents expanding but also it prevents applet from shrinking. So use 
Layout.maximumWidth = Layout.preferredWidth instead. Also after further testing 
I do not think the option must be restricted to icon version of applet only -- 
with full version (and Spacer applet) it allows you to align task on right side 
of panel which was impossible before.
  
  F5736447: Screenshot_20180302_144855.png 

  
  Note: By default the new "fillWidth" option is enabled, so no behaviour 
changes until user explicitly configures the applet.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10944?vs=28345=28405

REVISION DETAIL
  https://phabricator.kde.org/D10944

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/main.qml

To: Pitel, ngraham, mart
Cc: mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10890: Prepare for KIO KRecentDocument fix (D10863)

[Алексей Шилин]

aleksejshilin updated this revision to Diff 28398.
aleksejshilin added a comment.


  Diff against Plasma/5.12

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10890?vs=28397=28398

BRANCH
  prepare_for_krecentdocument_fix

REVISION DETAIL
  https://phabricator.kde.org/D10890

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/taskmanager/plugin/backend.cpp

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10890: Prepare for KIO KRecentDocument fix (D10863)

[Алексей Шилин]

aleksejshilin updated this revision to Diff 28397.
aleksejshilin added a comment.


  Rebase onto Plasma/5.12

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10890?vs=28192=28397

BRANCH
  prepare_for_krecentdocument_fix

REVISION DETAIL
  https://phabricator.kde.org/D10890

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/taskmanager/plugin/backend.cpp
  applets/trash/package/metadata.desktop
  containments/desktop/plugins/folder/foldermodel.cpp
  kcms/baloo/folderselectionwidget.cpp
  kcms/nightcolor/kcm_nightcolor.desktop
  knetattach/org.kde.knetattach.desktop
  layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop
  layout-templates/org.kde.plasma.desktop.emptyPanel/metadata.desktop

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10890: Prepare for KIO KRecentDocument fix (D10863)

[Алексей Шилин]

aleksejshilin added a comment.


  In D10890#215479 , @anthonyfieroni 
wrote:
  
  > So why you called hack, why no just add conditional compilation against 5.44
  
  
  Alright, I re-read the summary and admit that it's somewhat confusing. Sorry 
for that. I'll try to make it clear:
  
  - This is a workaround for a bug when items opened from e.g. Dolphin don't 
show up in kicker's and taskmanager's application context menus. It is caused 
by:
1. KIO KRecentDocument bug, which led to application name () being 
stored in recent documents DB instead of its desktop entry name 
(org.kde.). It mostly affects items which are opened from applications 
themselves. (The bug is fixed in D10863 , 
but not landed yet.)
2. Kicker and taskmanager cutting out 'org.kde.' prefix (in order to work 
around the bug above, I believe).
3. Items opened with KRun (which is what Dolphin is using) having correct 
org.kde. record stored in the DB. As a result, they don't match recent 
documents query by kicker and taskmanager and hence don't show up there.
  - The workaround is needed for Plasma 5.12 only as it depends on Frameworks 
>= 5.42 i.e. we don't know if the version we're running on does contain D10863 
.
- If it doesn't, we need to query for both  and org.kde..
- If it does, we only need to query for org.kde.. However, querying 
for both will do no harm either.
  - We need to fix Plasma first because otherwise kicker's and taskmanager's 
recent documents feature will break completely when Frameworks containing 
D10863  is released.
  
  So the plan (as discussed with @broulik on IRC) is to work around the issue 
in Plasma/5.12, then land D10863 , then 
remove the hack with cutting out 'org.kde.' in master (I'll do it in a separate 
revision).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10890

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

[Aleix Pol Gonzalez]

apol updated this revision to Diff 28393.
apol added a comment.


  Give the title some more space if there's no actions
  
  Someone please review the change

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10475?vs=28334=28393

BRANCH
  arcpatch-D10475_1

REVISION DETAIL
  https://phabricator.kde.org/D10475

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  tests/actionsMenu.qml

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D1231: Add Remote Access interface to KWayland

[Jan Grulich]

jgrulich added a dependent revision: D10965: Add screen cast portal.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, 
plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1230: GBM remote access support for KWin

[Jan Grulich]

jgrulich added a dependent revision: D10965: Add screen cast portal.

REPOSITORY
  R108 KWin

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:56
> +tasksModel.requestToggleMinimized(idx);
> +clients.push(tasksModel.makePersistentModelIndex(i));
> +}

This method does not exist, did you forget to commit the plasma-workspace part?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10019

To: davidedmundson, #plasma, anthonyfieroni
Cc: ngraham, anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, apol, mart

D10944: [taskmanager applet] Do not fill width

[Radek Hušek]

Pitel added a comment.


  Screenshots with Global Menu applet (panel contains Global menu, growing 
Spacer and icon taskmanager).
  
  Old: F5736170: Screenshot_20180302_112934.png 

  
  New: F5736172: Screenshot_20180302_112956.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10944

To: Pitel, ngraham, mart
Cc: mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10962: [Fonts KCM] Make font dialog modal

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This makes it consistent with the "Adjust all fonts" dialog and ensures the 
dialog doesn't accidentally get hidden behind the KCM

TEST PLAN
  Dialog is modal now, ie. stays in front and dims System Settings but I can 
still interact with the KCM since it doesn't exec

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10962

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart