Re: RESUBMIT: x11/xfce4 update to 4.4.0
2007/5/1, Markus Bergkvist [EMAIL PROTECTED]: Hi, I upgraded to -current and xenocara just to realise that xfce 4.3.2 is no longer working, it gets to the spash screen then it just waits there. I don't know if it something wrong with my system or what the reason might be. But I would like to test xfce 4.4.1, so I'm wondering what is the progress with your porting? Do you have a patch that I can test? Yes, as i said in my last mail, this patchset will work if you're still using snapshot ftp-packages (still gtk2.8 and glib2.10) I have to upgrade my gtk/glib install from source to the latest one in ports to update this patchset. Be sure to remove/backup your ~/.config before, and maybe remove xfce 4.2.3too (i have to work on the upgrade path, and set corresponding @conflict in PLISTs) If ppl are _really_ interested in testing this patchset (will only work with gtk 2.8/glib 2.10/vte 0.11 et al.), it's available here : http://gruiik.info/stuff/new/xfce4-4.4.1-patchset.tgz (tested only on i386atm, i have to upgrade my sparc64 to build it too) To answer ajacoutot@, i don't think the removal of textproc/expat and the use of xenocara's expat will have effect on this patchset, as expat is only present in WANTLIB and not in LIB_DEPENDS... but btw, i'm not a ports infrastructure expert, i have to check this :) Landry
Re: RESUBMIT: x11/xfce4 update to 4.4.0
On Thursday 26 April 2007 15:03:30 Landry Breuil wrote: Okay, btw i had a new full working patchset for Xfce 4.4.1 update correcting most reported bugs/glitches, but as Gtk2 has been upgraded, it's not compatible anymore so i'll rework this patchset with the new gtk/glib/atk/pango/vte libs. Beware as expat should also be removed from ports soon. Of course, make sure you're running the _latest_ current and xenocara too. It would also be nice if you could get feedbacks from !i386 archs (esp. 64bits). Don't worry, Xfce 4.4.1 is coming soon in ports, i'm working full-time on I will look into this deeper as soon as the latest ports tree changes are in. Hopefully xfce will will updated beforer 4.2 is out ;-) -- Antoine Jacoutot [EMAIL PROTECTED] CREA ISC - UMR7656 CNRS / Ecole Polytechnique 1, rue Descartes 75005 Paris
Re: RESUBMIT: x11/xfce4 update to 4.4.0
2007/4/18, Lars Hansson [EMAIL PROTECTED]: Another thing I noticed just now; startxfce4 adds /usr/local/share twice to XDG_DATA_DIRS: [...] if test x$XDG_DATA_DIRS = x then XDG_DATA_DIRS=/usr/share:/usr/local/share:/usr/local/share else XDG_DATA_DIRS=$XDG_DATA_DIRS:/usr/local/share fi export XDG_DATA_DIRS [...] I dunno if this is an upstream bug or a port bug but it's wrong either way. In fact it's not really a bug.. upstream is : http://svn.xfce.org/svn/xfce/xfce-utils/tags/xfce_4_4_1/scripts/startxfce4.in = XDG_DATA_DIRS=/usr/local/share:/usr/share:@datadir@ for us, @datadir@ is LOCALBASE/share.. don't really know if it's worth having a patch for this. If necessary, i can patch the file. Landry
Re: RESUBMIT: x11/xfce4 update to 4.4.0
2007/4/18, Lars Hansson [EMAIL PROTECTED]:
Landry Breuil wrote:
Okay, so with feedback from Brad, Christian Rueger and Lawrence Teo,
i've reworked some diffs.. thanks for the input on USE_BZIP2 vs
EXTRACT_SUFX.
I have some feedback on the previous patches so if you have fixed this,
just ignore my points.
Thunar: missing dependency on gconf2. It also looks like crap by default
unless xfce-icon-theme is installed. Perhaps it should also depend on
that.
Yep, i'll add dependency on the icon-theme.. forgot that (see
http://thunar.xfce.org/pwiki/documentation/faq) . But for gconf2, it's an
optional dependency to find available gnome-thumbnailers, and i don't think
it's a good idea to make thunar depend on it.. it can use its own built-ins
thumbnailers, and there is a separate goodies project here to be added to
the ports :
http://goodies.xfce.org/projects/thunar-plugins/thunar-thumbnailers
xfce4-session: need to have xfce-mcs-manager a a build dependency.
Okay, i'll add it
xfce-utils: the /etc/xdg/xfce4 folder and xinitrc script is missing.
thanks for pointing this out, i forgot to re-add the @sample to the PLIST
@sample ${SYSCONFDIR}/xdg/xfce4/xinitrc
Thanks for the feedback :)
Landry
Re: RESUBMIT: x11/xfce4 update to 4.4.0
Landry Breuil wrote: But for gconf2, it's an optional dependency to find available gnome-thumbnailers, and i don't think it's a good idea to make thunar depend on it.. it can use its own built-ins thumbnailers, and there is a separate goodies project here to be added to the ports : http://goodies.xfce.org/projects/thunar-plugins/thunar-thumbnailers Right, but right now it does depend on gconf2 since the port Makefile uses --enable-gnome-thumbnailers. If it shouldn't depend on gconf2 it should use --disable-gnome-thumbnailers. --- Lars Hansson
Re: RESUBMIT: x11/xfce4 update to 4.4.0
2007/4/18, Lars Hansson [EMAIL PROTECTED]: Landry Breuil wrote: But for gconf2, it's an optional dependency to find available gnome-thumbnailers, and i don't think it's a good idea to make thunar depend on it.. it can use its own built-ins thumbnailers, and there is a separate goodies project here to be added to the ports : http://goodies.xfce.org/projects/thunar-plugins/thunar-thumbnailers Right, but right now it does depend on gconf2 since the port Makefile uses --enable-gnome-thumbnailers. If it shouldn't depend on gconf2 it should use --disable-gnome-thumbnailers. Okay, i see.. by default, --enable-gnome-thumbnailers looks for Gconf during configure, and effectively activates them if Gconf is found.. i'll explicitely disable them. Landry
Re: RESUBMIT: x11/xfce4 update to 4.4.0
Hi ! Okey, so with more feedback from Christian Ruege, i reworked the update posted yesterday on Xfce core libs. I reverted the patches disabling gtk-docs, removed the unnecessary USE_LIBTOOL and EXTRACT_SUFX, and moved devel/libxfce4util to x11/xfce4/libxfce4util. All _new_ patches are here : http://gcu.info/~gaston/patches/xfce4.4.1/ Added EXTRACT_SUFX= .tar.bz2 to Makefile.inc, and new libxfce4util directory to other Makefiles.. to avoid conflicts, be sure to remove SUBDIRS+= libxfce4util in ports/devel/Makefile and ports/devel/libxfce4util. How is this move handled during an upgrade ? PLIST, distinfo have been regenerated, and needed patches updated. I'm working on a re-update of exo/thunar/terminal/panel/icon-theme new ports, with help and input from Christian. Comments ? Tests ? Landry
Re: RESUBMIT: x11/xfce4 update to 4.4.0
On Tue, Apr 10, 2007 at 10:00:39PM +0200, Christian Rueger wrote: Landry Breuil wrote: [...] Okay, so with feedback from Brad, Christian Rueger and Lawrence Teo, i've reworked some diffs.. thanks for the input on USE_BZIP2 vs EXTRACT_SUFX. I only updated core libs to 4.4.1 atm, which is a bugfix and translation update release.. working on the other ports in theses days. All the ports are built with USE_SYSTRACE, and the new SHA256 distinfo (snapshot from 14/4).. New patches are in http://gcu.info/~gaston/patches/xfce4.4.1 I added myself as MAINTAINER, feel free to discuss this.. i still have one problem for the 'general' Makefile.inc, i dunno if adding EXTRACT_SUFX there is the best solution, because only core Xfce libraries and apps are distributed as bz2, plugins and goodies are generally distributed as tgzs.. any hint for this ? Atm, i added EXTRACT_SUFX only where it is needed in the separate ports, on a case by case basis. I added USE_LIBTOOL=Yes to libxfcegui4 and libxfce4mcs, because imho they're needed for SHARED_LIBS version. Libs uses libtool anyway. What is the policy for SHARED_LIBS bump version ? only 0.1 when necessary ? rely on libtool output ? here for example, libxfce4mcs jumps from 2.3 to 3.5.. i've read http://www.openbsd.org/porting/update.html and didn't find info about it.. devel/libxfce4util : http://gcu.info/~gaston/patches/devel-libxfce4util.diff - patches/patch-Makefile_in is not any longer relevant. Nothing special here, only version bump.. we need this patch, to removing the gtk-docs Okay, but why removing html gtk-docs for the libraries ? vte/poppler/pango/cairo and friends still install them... - Why not move this port into x11/xfce4 too ? It'll be more 'consistent' with other Xfce libs... Again, what do you think about this ? i don't know apps others than xfce-apps using libxfce4util... updated version here : http://gcu.info/~gaston/patches/xfce4.4.1/devel-libxfce4util.diff x11/xfce4/libxfcegui4 : http://gcu.info/~gaston/patches/x11-xfce4-libxfcegui4.diff - databases/dbh and textproc/libxml are not dependencies anymore, byebye - don't know if MODGNU_SHARED_LIBS is still necessary remove PKGNAME, MODGNU_SHARED_LIBS, EXTRACT_SUFX add to Makefile.inc done - patches not necessary we need this patch Same question, why removing gtk-docs ? place ? I don't bother, i only want to understand why :) Other three patches in modules/ are not relevant anymore. @conflict xfce4-panel-4.2.3 for icons done, thanks for this.. how do you detect it ? upgrade pkg, PLIST_DB ? some icons moved from the panel to the lib in the upgrade.. updated version here : http://gcu.info/~gaston/patches/xfce4.4.1/x11-xfce4-libxfcegui4.diff x11/xfce4/libxfce4mcs : http://gcu.info/~gaston/patches/x11-xfce4-libxfce4mcs.diff - don't know if MODGNU_SHARED_LIBS is still necessary - patches not necessary s.o. updated version here : http://gcu.info/~gaston/patches/xfce4.4.1/x11-xfce4-libxfce4mcs.diff x11/xfce4/xfce-mcs-manager : http://gcu.info/~gaston/patches/x11-xfce4-xfce-mcs-manager.diff - nothing special x11/xfce4/xfce-mcs-plugins : http://gcu.info/~gaston/patches/x11-xfce4-xfce-mcs-plugins.diff - nothing special remove PKGNAME, EXTRACT_SUFX done, updated versions here : http://gcu.info/~gaston/patches/xfce4.4.1/x11-xfce4-xfce-mcs-manager.diff http://gcu.info/~gaston/patches/xfce4.4.1/x11-xfce4-xfce-mcs-plugins.diff the rest need more test and review i'm still waiting for more feedback.. updates and corrections for other ports are coming soon, and i'm working on little quirks (sound plugin not shown in mcs-manager, thunar crash on sparc64, etc..) Don't hesitate to try and comment. Thanks, Landry
Re: RESUBMIT: x11/xfce4 update to 4.4.0
Landry Breuil wrote: Okay, so with feedback from Brad, Christian Rueger and Lawrence Teo, i've reworked some diffs.. thanks for the input on USE_BZIP2 vs EXTRACT_SUFX. I have some feedback on the previous patches so if you have fixed this, just ignore my points. Thunar: missing dependency on gconf2. It also looks like crap by default unless xfce-icon-theme is installed. Perhaps it should also depend on that. xfce4-session: need to have xfce-mcs-manager a a build dependency. xfce-utils: the /etc/xdg/xfce4 folder and xinitrc script is missing. Terminal: extra dependency: iconv --- Lars Hansson
Re: RESUBMIT: x11/xfce4 update to 4.4.0
Another thing I noticed just now; startxfce4 adds /usr/local/share twice to XDG_DATA_DIRS: [...] if test x$XDG_DATA_DIRS = x then XDG_DATA_DIRS=/usr/share:/usr/local/share:/usr/local/share else XDG_DATA_DIRS=$XDG_DATA_DIRS:/usr/local/share fi export XDG_DATA_DIRS [...] I dunno if this is an upstream bug or a port bug but it's wrong either way. --- Lars Hansson
Re: RESUBMIT: x11/xfce4 update to 4.4.0
On Sun, Apr 01, 2007 at 01:15:36PM +0200, Landry Breuil wrote: Hi ! I know this has been awaited by some ppl, here is the update for Xfce 4.4.0, based on bsdmaniak's work (http://marc.info/?l=openbsd-portsm=117001449822494w=2). I've cleaned various things : mostly changes in WANTLIB/LIB_DEPENDS, removed explicit enable-startup-notification (detected by pkg-config, and in WANTLIB), enabled D-BUS where needed (important for internal communication between Xfce parts, modified some pkg/DESCR, and finally exploded the big patch ...snip... - port goodies/panel-plugins (http://goodies.xfce.org) and update existing ones once core is in cvs. Maybe create a x11/xfce4/goodies subdir ? Here's the first one, xfce4-mpc-plugin, a simple panel-plugin to control audio/mpd. http://gcu.info/~gaston/patches/xfce4-mpc-plugin.tgz Comments ? tests ? Works here @i386, i'm thinking about removing the libmpd dependency (a simple connection library is embedded..) I'd just like to add that Xfce 4.4.1, a bugfix release, will be released in a few days, so as soon as i come back from holidays i'll update my patches to this latest version. Landry
Re: RESUBMIT: x11/xfce4 update to 4.4.0
On Fri, Apr 06, 2007 at 03:20:21PM -0400, Brad wrote: On Sun, 1 Apr 2007 13:15:36 +0200 Landry Breuil [EMAIL PROTECTED] wrote: Hi ! I know this has been awaited by some ppl, here is the update for Xfce 4.4.0, based on bsdmaniak's work (http://marc.info/?l=openbsd-portsm=117001449822494w=2). I've cleaned various things : mostly changes in WANTLIB/LIB_DEPENDS, removed explicit enable-startup-notification (detected by pkg-config, and in WANTLIB), enabled D-BUS where needed (important for internal communication between Xfce parts, modified some pkg/DESCR, and finally exploded the big patch into several diff -uN patches against cvs, one by port. There is no such variable as USE_BZIP2 being used by the ports framework. That's a FreeBSD-ism. Set EXTRACT_SUFX to .tar.bz2 for example or just use the proper suffix with the distfiles, etc. does the right thing. I trust you, but USE_BZIP2 is in bsd.port.mk(5)... i'll change this in my diffs. Anyway, here's another diff against cvs, this time xfce4-systemload plugin has been updated to 0.4.2. Works here @i386, but i'm not really happy with the HW_PHYSMEM64 patch... http://gcu.info/~gaston/patches/x11-xfce4-xfce4-systemload.diff Tests, comments welcome.. Landry
Re: RESUBMIT: x11/xfce4 update to 4.4.0
On Fri, 6 Apr 2007 23:04:15 +0200 Landry Breuil [EMAIL PROTECTED] wrote: On Fri, Apr 06, 2007 at 03:20:21PM -0400, Brad wrote: On Sun, 1 Apr 2007 13:15:36 +0200 Landry Breuil [EMAIL PROTECTED] wrote: Hi ! I know this has been awaited by some ppl, here is the update for Xfce 4.4.0, based on bsdmaniak's work (http://marc.info/?l=openbsd-portsm=117001449822494w=2). I've cleaned various things : mostly changes in WANTLIB/LIB_DEPENDS, removed explicit enable-startup-notification (detected by pkg-config, and in WANTLIB), enabled D-BUS where needed (important for internal communication between Xfce parts, modified some pkg/DESCR, and finally exploded the big patch into several diff -uN patches against cvs, one by port. There is no such variable as USE_BZIP2 being used by the ports framework. That's a FreeBSD-ism. Set EXTRACT_SUFX to .tar.bz2 for example or just use the proper suffix with the distfiles, etc. does the right thing. I trust you, but USE_BZIP2 is in bsd.port.mk(5)... i'll change this in my diffs. Yes, in the OBSOLETE VARIABLES section with a description of.. USE_BZIP2 The framework will automatically detect the presence of .tar.bz2 files to extract. Anyway, here's another diff against cvs, this time xfce4-systemload plugin has been updated to 0.4.2. Works here @i386, but i'm not really happy with the HW_PHYSMEM64 patch... http://gcu.info/~gaston/patches/x11-xfce4-xfce4-systemload.diff Tests, comments welcome.. Landry
Re: RESUBMIT: x11/xfce4 update to 4.4.0
On Fri, Apr 06, 2007 at 11:04:15PM +0200, Landry Breuil wrote:
On Fri, Apr 06, 2007 at 03:20:21PM -0400, Brad wrote:
There is no such variable as USE_BZIP2 being used by the ports
framework. That's a FreeBSD-ism. Set EXTRACT_SUFX to .tar.bz2
for example or just use the proper suffix with the distfiles,
etc. does the right thing.
I trust you, but USE_BZIP2 is in bsd.port.mk(5)... i'll change
this in my diffs.
Yes; it's in bsd.port.mk(5) in the OBSOLETE VARIABLES section.
--
o--{ Will Maier }--o
| web:...http://www.lfod.us/ | [EMAIL PROTECTED] |
*--[ BSD Unix: Live Free or Die ]--*
