Re: weird error in review-board and post-review in windows
You can use post-review on a windows client without cygwin. You will need python and difftools on the client thought. By the way, how did you got sqlite to work on cygwin? On Oct 9, 12:45 am, Paulo Eduardo Neves [EMAIL PROTECTED] wrote: On Oct 6, 9:17 pm, Chris [EMAIL PROTECTED] wrote: On Oct 6, 4:58 pm, Paulo Eduardo Neves [EMAIL PROTECTED] wrote: I'm advocating the adoption of review-board in my company. The client and the server must run in Windows. Subversion is our version control system. I'm not using cygwin nor mingw. patch: malformed patch at line 51: \ No newline at end of file I've been experimenting with Cygwin, so I can confirm using that is a good idea :-) All I did was add the Cygwin bin path to the regular Windows path. Thanks for the answer Chris and Christian, my problem with cygwin is that I'll have to deploy the client in dozens of developer Windows machines. I don't want to force everybody to install cygwin just to have diff. I've tried unxutils links but it still didn't work. I've tried cygwin and the problem persists! Then I tried to delete the file where the problem is happening... and it works! I don't know if it will be a common error or just really bad luck. regards, Paulo Eduardo Neves --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Empty Diff
On Oct 9, 5:46 pm, Jeff Mickey [EMAIL PROTECTED] wrote: [..] When I look at /tmp/reviewboard.zoa6PK/tmpCk02zP , it's just an empty file, which leads me to believe that it' I accidentally hit send, here's the rest: When I look at /tmp/reviewboard.zoa6PK/tmpCk02zP , it's just an empty file, which leads me to believe that reviewboard for some reason can't connect to perforce correctly to get the original file. Also a lot of those file paths are incorrect, as they correspond to /root instead of /srv/reviewboard where they live. That may relate to the other errors I was getting (posted earlier in this group at : http://groups.google.com/group/reviewboard/browse_thread/thread/ccf52133b95a2e05/e3f824b06f697725) Thanks for any help. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Random Manual Server Upgrade Messages
On Sep 29, 5:25 pm, Christian Hammond [EMAIL PROTECTED] wrote: Hi Jeff. Sorry for the late reply, but I've been away from the computer most of the past few days. Obviously, that page should not be appearing every so often. If it claims that the path is /root/reviewboard, then we need to find out why it thinks that. Can you provide your settings_local.py file (excluding any sensitive information)? Christian I'm sorry for the late reply as well, for some reason I didn't get the alert that someone had replied... Anyways, here is my settings_local.py. I don't think it could be anything in there, and yes I removed sensitive information: - DATABASE_ENGINE = 'mysql' # 'postgresql', 'mysql', 'sqlite3' or 'ado_mssql'. DATABASE_NAME = 'rb' # Or path to database file if using sqlite3. DATABASE_USER = 'nope' # Not used with sqlite3. DATABASE_PASSWORD = 'nowayjose' # Not used with sqlite3. DATABASE_HOST = '' # Set to empty string for localhost. DATABASE_PORT = '' # Set to empty string for default. SECRET_KEY = 'SECRETSYOUDONTGET' # CACHE_BACKEND = '' TIME_ZONE = 'US/Eastern' LANGUAGE_CODE = 'en-us' SITE_ID = 1 # SITE_ROOT = /reviewboard/ USE_I18N = True LDAP_TLS = False --- And that's all that's in there. I removed the comments for brevity. I appreciate any and all help with this, as it's irradic and may be hard to track down. // jeff --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review error Unable to parse diff header:
Interesting. It could be that there's assumptions being made that confuse post-review when running inside the cygwin shell instead of a DOS prompt on Windows. The file paths look very inconsistent. One file is UNIX-style (/foo/bar), whereas the other is a mix of Windows (C:\...) and then partly UNIX. It's probably due to where we're getting these paths and how we're concatenating them. Can you run the same command in a DOS box and see what happens? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 9, 2008 at 5:45 PM, Amit Mokal [EMAIL PROTECTED] wrote: Hi I would like to thank you for developing review board. I am using review board with perforce. When I use the post-review script I get the error Unable to parse diff header: Running the script with debug set to True gives - $ python post-review.py 52004 svn info p4 info repository info: Path: milan.engdlp.symantec.com:1666, Base path: None, Supports changesets: True Repository info 'Path: milan.engdlp.symantec.com:1666, Base path: None, Supports changesets: True' Generating diff for changenum 52004 p4 describe -s 52004 Processing edit of //depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp Writing //depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp#2 to /c/DOCUME~1/ADMINI~1/LOCALS~1/Temp/tmpkWJo L p4 print -q //depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp#2 p4 where //depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp diff -urNp /c/DOCUME~1/ADMINI~1/LOCALS~1/Temp/tmpkWJoCL C:/dev/sources\Vontu9\dev\native\src\endpoint\Agent\DetectionCore\ExecutionGraphStatePool cpp +++ C:/dev/sources\Vontu9\dev\native\src\endpoint\Agent\DetectionCore \ExecutionGraphStatePool.cpp Unable to parse diff header: +++ C:/dev/sources\Vontu9\dev\native\src \endpoint\Agent\DetectionCore\ExecutionGraphStatePool.cpp My environment is cygwin. I am using python 2.5.1 diffutils 2.8.7 If I copy paste the diff command to the command line and save the output to a file I actually see a timestamp. However when the script executes the command the time stamp is missing. Thanks Amit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Using reviewboard with a remote svn repository
Hi Jennifer. The repository can be on any machine, as long as the server running Review Board is able to connect to it. There's no good way aside from posting diffs to check if the server is valid yet, but I'm planning to get to it before our 1.0 release. It's a much-needed feature. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 9, 2008 at 5:56 PM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: I'm running reviewboard on Linux and wondering if it's possible to setup with a remote svn repository (hosted on a machine in the same domain). Or does the repository need to be local to the reviewboard server? Also, besides trying to post diffs (which I'm having trouble with) is there another way to see if a svn repository has been added correctly? Thank you very much. -- Jennifer Cranfill --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 624 in reviewboard: Can't add inline comments from diff view discussion tab
Issue 624: Can't add inline comments from diff view discussion tab http://code.google.com/p/reviewboard/issues/detail?id=624 Comment #3 by gmueller: I have several comments about this workflow, which is confusing a lot of people. First, I don't think there should be a Review and Discussion tab in the dialog that you get when you click on a line in the diff. That's too complicated. And that Review link hidden next to the patch link is almost impossible to see. The diff page should detect changes like the request page does and offer Publish/Discard buttons at the top in the same way, and the Publish button should bring up the equivalent of today's Review tab, allowing for an overall comment and ticking of the Ship It checkbox. Finally, it should be possible to start multiple conversations on a single line, and have reply threads for each of them. And I think you should be able to add to those threads without leaving the diff view. Thanks! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
