Interesting. It could be that there's assumptions being made that confuse post-review when running inside the cygwin shell instead of a DOS prompt on Windows. The file paths look very inconsistent. One file is UNIX-style (/foo/bar), whereas the other is a mix of Windows (C:\...) and then partly UNIX. It's probably due to where we're getting these paths and how we're concatenating them.
Can you run the same command in a DOS box and see what happens? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 9, 2008 at 5:45 PM, Amit Mokal <[EMAIL PROTECTED]> wrote: > > Hi > > I would like to thank you for developing review board. > > I am using review board with perforce. > When I use the post-review script I get the error > "Unable to parse diff header:" > > Running the script with debug set to True gives > > ----------------------------------------------------------------------------- > $ python post-review.py 52004 > >>> svn info > >>> p4 info > >>> repository info: Path: milan.engdlp.symantec.com:1666, Base path: > None, Supports changesets: True > >>> Repository info 'Path: milan.engdlp.symantec.com:1666, Base path: > None, Supports changesets: True' > >>> Generating diff for changenum 52004 > >>> p4 describe -s 52004 > >>> Processing edit of > //depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp > >>> Writing > "//depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp#2" > to "/c/DOCUME~1/ADMINI~1/LOCALS~1/Temp/tmpkWJo > L" > >>> p4 print -q > //depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp#2 > >>> p4 where > //depot/Vontu9/dev/native/src/endpoint/Agent/DetectionCore/ExecutionGraphStatePool.cpp > >>> diff -urNp /c/DOCUME~1/ADMINI~1/LOCALS~1/Temp/tmpkWJoCL > C:/dev/sources\Vontu9\dev\native\src\endpoint\Agent\DetectionCore\ExecutionGraphStatePool > cpp > > +++ C:/dev/sources\Vontu9\dev\native\src\endpoint\Agent\DetectionCore > \ExecutionGraphStatePool.cpp > > Unable to parse diff header: +++ C:/dev/sources\Vontu9\dev\native\src > \endpoint\Agent\DetectionCore\ExecutionGraphStatePool.cpp > > ---------------------------------------------------------------------------- > > My environment is cygwin. I am using > python 2.5.1 > diffutils 2.8.7 > > If I copy paste the diff command to the command line and save the > output to a file I actually see a timestamp. However when the script > executes the command the time stamp is missing. > > Thanks > Amit > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
