Re: Thoroughly Confused via Installation

2009-03-16 Thread Christian Hammond
Hmm, the default lighttpd config file generated by `rb-site install` should
trigger fastcgi starting on demand. Even if you have to run it yourself, you
should be using the binary file in the site dir's conf/ directory, which
sets the parameters we need. Are you using our generated config, or writing
your own?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Mar 16, 2009 at 8:33 AM, Danny zematyn...@gmail.com wrote:


 Hmm - I'm not using apache, I'm using lighttpd.  There is no 000-
 default.  There is a default document root however.  But lighttpd has
 to have one in order to start.  lighttpd starts fine and is listening
 at the right place but isn't connecting to the reviewboard django
 site.

 I finally found that there is a command manage for rb-site and that
 I can start the site via:
 rb-site manage /home/azillia/webapps/reviewboard/ runfcgi
 method=threaded daemonize=false host=127.0.0.1 port=13000.

 So now the site comes up but there's an issue with the css and images
 not being found.  Looks like I need to change the media_url or
 something like that.

 Cool. Almost there.

 Danny



 On Mar 16, 12:12 am, Christian Hammond chip...@chipx86.com wrote:
  The guts of the application are in the Python site-packages directory.
  Unlike .php files, we don't need to install files inside the htdocs
  directory. As long as you have your new server config set up properly
 (which
  may require disabling the 000-default file if you have one, which sets
  /var/www as the htdocs for every subdomain), you're ready to go.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
  On Sun, Mar 15, 2009 at 9:55 PM, Danny zematyn...@gmail.com wrote:
 
   I must be missing something simple (I hope).
 
   Here are the steps I am taking to install latest 1.0alpha5 on Ubuntu
   8.04 with lighttpd:
 
   installed all dependencies
 
   sudo easy_install ReviewBoard
 
   rb-site install --copy-media /home/user/webapps/reviewboard
- specify domain, lighttpd, sqlite, and all others as defaults
 
   this creates a site with the following files and dirs in  /home/user/
   webapps/reviewboard :
-conf/  db/  htdocs/  logs/  tmp/
 
   This is where I am missing something.  Am I supposed to install this
   into an existing django app?  Or did something go wrong?  Or did I
   miss a step?  Where are the guts of the application?
 
   If it's in the docs I must be blind as I've looked over them many
   times.
 
   Any help would be appreciated.
 
   Thanks
 
   Danny
 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Problem with Subsequent Diffs

2009-03-16 Thread Christian Hammond
This is fixed in the nightlies. There's still an issue with interdiffs, but
they work, it just sometimes shows errors for the files not in the diff.

You should be able to upgrade to the nightly without problems. I'm look to
push out beta 1 soon, but I have house guests this week and won't be getting
to it until next week at the earliest.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Mar 16, 2009 at 10:09 AM, Gavin M. Roy g...@myyearbook.com wrote:


 Yes, sorry, this more accurately describes the problem.  If the
 exception wasn't clear it's 1.0a4.

 On Mon, Mar 16, 2009 at 12:26 PM, housemaister housemais...@gmail.com
 wrote:
 
  Hi,
 
  I get the same error when trying to view the Changes between two
  uploaded revisions; however viewing the diff of single revision
  against the repository works fine.
  But I'm also clueless why this happens.
  BTW, repository is subversion.
 
  Thanks,
  Stefan.
 
  On Mon, Mar 16, 2009 at 3:37 PM, Gavin M. Roy g...@myyearbook.com
 wrote:
 
  We're running into issues in the case of a review where once the first
  diff is done, the developer is attaching the revised diff for review,
  but we're getting the following error:
 
  Traceback (most recent call last):
   File
 /usr/local/lib/python2.6/site-packages/ReviewBoard-1.0alpha4-py2.6.egg/reviewboard/diffviewer/views.py,
  line 145, in view_diff
 interdiffset, highlighting, True)[0]
  IndexError: list index out of range
 
  Any suggestions on tracking this down?
 
  Thanks,
 
  Gavin
 
  
 
 
  
 

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Problem with Subsequent Diffs

2009-03-16 Thread Gavin M. Roy

Thanks, another issue being reported is:

The issue Wyatt and I were just looking at appears to be when you have
a new file, diff'ed after an svn add, then make changes and update a
new diff with the full add (including your changes) again.  What we're
seeing is that instead of looking for the differences between diff-r1
and diff-r2, it combines the two, so you have the full contents of
diff-r1, followed by the full contents of diff-r2 (looks like you have
the entire file duplicated in one file).  Not sure that's an accurate
description of what's going on, but that's what it looks like.

On Mon, Mar 16, 2009 at 3:01 PM, Christian Hammond chip...@chipx86.com wrote:
 This is fixed in the nightlies. There's still an issue with interdiffs, but
 they work, it just sometimes shows errors for the files not in the diff.

 You should be able to upgrade to the nightly without problems. I'm look to
 push out beta 1 soon, but I have house guests this week and won't be getting
 to it until next week at the earliest.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com


 On Mon, Mar 16, 2009 at 10:09 AM, Gavin M. Roy g...@myyearbook.com wrote:

 Yes, sorry, this more accurately describes the problem.  If the
 exception wasn't clear it's 1.0a4.

 On Mon, Mar 16, 2009 at 12:26 PM, housemaister housemais...@gmail.com
 wrote:
 
  Hi,
 
  I get the same error when trying to view the Changes between two
  uploaded revisions; however viewing the diff of single revision
  against the repository works fine.
  But I'm also clueless why this happens.
  BTW, repository is subversion.
 
  Thanks,
  Stefan.
 
  On Mon, Mar 16, 2009 at 3:37 PM, Gavin M. Roy g...@myyearbook.com
  wrote:
 
  We're running into issues in the case of a review where once the first
  diff is done, the developer is attaching the revised diff for review,
  but we're getting the following error:
 
  Traceback (most recent call last):
   File
  /usr/local/lib/python2.6/site-packages/ReviewBoard-1.0alpha4-py2.6.egg/reviewboard/diffviewer/views.py,
  line 145, in view_diff
     interdiffset, highlighting, True)[0]
  IndexError: list index out of range
 
  Any suggestions on tracking this down?
 
  Thanks,
 
  Gavin
 
  
 
 
  
 




 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



post-review potentially confused about different repository addresses?

2009-03-16 Thread Brad Taylor

Hey,

I've been trying to evaluate Review Board for my team's work on the
Mono Accessibility project.  I've got it all set up, and it seems to
be purring well, however post-review bails out with:

[mono] ~/build/uia2atk @ post-review
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)

I suspect this is because the RB server is pointed at the anonymous
SVN URL -- http://anonsvn.mono-project.com/source -- while developers,
such as I, have a checkout using the SVN+SSH-based URL,
http://mono-cvs.ximian.com/source.  The Mono project hosts these on
two entirely seperate servers.

I see that post-review has a --repository-url parameter where I could
potentially pass the anonymous URL, but this requires --revision-
range, so it doesn't quite seem like an appropriate fit.

Has anyone else hit this case?  Is there a simple solution that I'm
missing?

Thanks in advance,

-Brad
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: post-review potentially confused about different repository addresses?

2009-03-16 Thread Christian Hammond
Hi Brad,

What you can do in this case is to set your main repository URL to be your
anonymous path (which Review Board will use for checkouts), and then set
Mirror Path to be your developer SVN URL. When looking up a URL, it will
check against both of those URLs, and should find the developer one.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Mar 16, 2009 at 3:12 PM, Brad Taylor brad.tay...@gmail.com wrote:


 Hey,

 I've been trying to evaluate Review Board for my team's work on the
 Mono Accessibility project.  I've got it all set up, and it seems to
 be purring well, however post-review bails out with:

 [mono] ~/build/uia2atk @ post-review
 Error creating review request: The repository path specified is not in
 the list of known repositories (code 206)

 I suspect this is because the RB server is pointed at the anonymous
 SVN URL -- http://anonsvn.mono-project.com/source -- while developers,
 such as I, have a checkout using the SVN+SSH-based URL,
 http://mono-cvs.ximian.com/source.  The Mono project hosts these on
 two entirely seperate servers.

 I see that post-review has a --repository-url parameter where I could
 potentially pass the anonymous URL, but this requires --revision-
 range, so it doesn't quite seem like an appropriate fit.

 Has anyone else hit this case?  Is there a simple solution that I'm
 missing?

 Thanks in advance,

 -Brad
 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



exception after publishing review

2009-03-16 Thread Kimon

I've created a number of reviews with post-review and svn.  This
seemed to work fine.  Then I added a review group and and additional
reviewer and tried to post the review.  In at least one instance, it
said it failed to post the review (no sure it happened both times).

Anyway, now when I try to look at either review I get the following
exception:

Environment:

Request Method: GET
Request URL: http://hostname:8080/r/10/
Django Version: 1.0.2 final
Python Version: 2.6.0
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.markup',
 'django.contrib.sites',
 'django.contrib.sessions',
 'djblets.datagrid',
 'djblets.feedview',
 'djblets.siteconfig',
 'djblets.util',
 'djblets.webapi',
 'reviewboard.accounts',
 'reviewboard.admin',
 'reviewboard.changedescs',
 'reviewboard.diffviewer',
 'reviewboard.iphone',
 'reviewboard.reports',
 'reviewboard.reviews',
 'reviewboard.scmtools',
 'reviewboard.webapi',
 'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.doc.XViewMiddleware',
 'django.middleware.http.ConditionalGetMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'djblets.siteconfig.middleware.SettingsMiddleware',
 'reviewboard.admin.middleware.LoadSettingsMiddleware',
 'djblets.log.middleware.LoggingMiddleware',
 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')


Template error:
In template /usr/local/lib64/python2.6/site-packages/
ReviewBoard-1.0alpha4-py2.6.egg/reviewboard/templates/reviews/
review_request_box.html, error at line 47
   Caught an exception while rendering: Reverse for 'reviewboard.user'
with arguments '(User: kimonp,)' and keyword arguments '{}' not
found.
   37 :   /tr


   38 :   tr


   39 :td class=labellabel for=bugs_closed{% trans Bugs
%}:/label/td


   40 :td class=valuespan id=bugs_closed class=editable
comma-editable{% spaceless %}


   41 : {%  for bug in review_request_details.get_bug_list %}


   42 : {%   if review_request.repository.bug_tracker %}a href={{bug|
bug_url:review_request}}{{bug}}/a{% else %}{{bug}}{% endif %}{% if
not forloop.last %}, {% endif %}


   43 : {%  endfor %}


   44 : {% endspaceless %}/span/td


   45 :td class=indented labellabel for=target_people{%
trans People %}:/label/td


   46 :td class=valuespan id=target_people class=editable
comma-editable{% spaceless %}


   47 :  {%  for person in review_request_details.target_people.all
%}


   48 : a href={% url user person %}{% if not person.is_active %}
class=inactive{% endif %}{{person}}/a{% if not forloop.last %},
{% endif %}


   49 : {%  endfor %}


   50 : {% endspaceless %}/span/td


   51 :   /tr


   52 :   tr


   53 :td class=labellabel for=changenum{% trans Change
Number %}:/label/td


   54 :td class=valuespan id=changenum
{{review_request.changenum}}/span/td


   55 :td class=labellabel for=repository{% trans
Repository %}:/label/td


   56 :td class=valuespan id=repository
{{review_request.repository}}/span/td


   57 :   /tr


Traceback:
File /usr/local/lib64/python2.6/site-packages/django/core/handlers/
base.py in get_response
  86. response = callback(request, *callback_args,
**callback_kwargs)
File /usr/local/lib64/python2.6/site-packages/ReviewBoard-1.0alpha4-
py2.6.egg/reviewboard/accounts/decorators.py in _check
  27. return view_func(*args, **kwargs)
File /usr/local/lib64/python2.6/site-packages/ReviewBoard-1.0alpha4-
py2.6.egg/reviewboard/reviews/views.py in review_detail
  200. 'PRE_CREATION': PRE_CREATION,
File /usr/local/lib64/python2.6/site-packages/django/shortcuts/
__init__.py in render_to_response
  18. return HttpResponse(loader.render_to_string(*args,
**kwargs), **httpresponse_kwargs)
File /usr/local/lib64/python2.6/site-packages/django/template/
loader.py in render_to_string
  107. return t.render(context_instance)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
  176. return self.nodelist.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
  768. bits.append(self.render_node(node, context))
File /usr/local/lib64/python2.6/site-packages/django/template/
debug.py in render_node
  71. result = node.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
loader_tags.py in render
  97. return compiled_parent.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
  176. return self.nodelist.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
  768. bits.append(self.render_node(node, context))
File 

exception after publishing review

2009-03-16 Thread Kimon

(strange...did not seem to post the first time so I'm trying to post
again)

I've created a number of reviews with post-review and svn.  This
seemed to work fine.  Then I added a review group and and additional
reviewer and tried to post the review.  In at least one instance, it
said it failed to post the review (no sure it happened both times).

Anyway, now when I try to look at either review I get the following
exception:

Environment:

Request Method: GET
Request URL: http://hostname:8080/r/10/
Django Version: 1.0.2 final
Python Version: 2.6.0
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.markup',
 'django.contrib.sites',
 'django.contrib.sessions',
 'djblets.datagrid',
 'djblets.feedview',
 'djblets.siteconfig',
 'djblets.util',
 'djblets.webapi',
 'reviewboard.accounts',
 'reviewboard.admin',
 'reviewboard.changedescs',
 'reviewboard.diffviewer',
 'reviewboard.iphone',
 'reviewboard.reports',
 'reviewboard.reviews',
 'reviewboard.scmtools',
 'reviewboard.webapi',
 'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.doc.XViewMiddleware',
 'django.middleware.http.ConditionalGetMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'djblets.siteconfig.middleware.SettingsMiddleware',
 'reviewboard.admin.middleware.LoadSettingsMiddleware',
 'djblets.log.middleware.LoggingMiddleware',
 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')


Template error:
In template /usr/local/lib64/python2.6/site-packages/
ReviewBoard-1.0alpha4-py2.6.egg/reviewboard/templates/reviews/
review_request_box.html, error at line 47
   Caught an exception while rendering: Reverse for 'reviewboard.user'
with arguments '(User: kimonp,)' and keyword arguments '{}' not
found.
   37 :   /tr


   38 :   tr


   39 :td class=labellabel for=bugs_closed{% trans Bugs
%}:/label/td


   40 :td class=valuespan id=bugs_closed class=editable
comma-editable{% spaceless %}


   41 : {%  for bug in review_request_details.get_bug_list %}


   42 : {%   if review_request.repository.bug_tracker %}a href={{bug|
bug_url:review_request}}{{bug}}/a{% else %}{{bug}}{% endif %}{% if
not forloop.last %}, {% endif %}


   43 : {%  endfor %}


   44 : {% endspaceless %}/span/td


   45 :td class=indented labellabel for=target_people{%
trans People %}:/label/td


   46 :td class=valuespan id=target_people class=editable
comma-editable{% spaceless %}


   47 :  {%  for person in review_request_details.target_people.all
%}


   48 : a href={% url user person %}{% if not person.is_active %}
class=inactive{% endif %}{{person}}/a{% if not forloop.last %},
{% endif %}


   49 : {%  endfor %}


   50 : {% endspaceless %}/span/td


   51 :   /tr


   52 :   tr


   53 :td class=labellabel for=changenum{% trans Change
Number %}:/label/td


   54 :td class=valuespan id=changenum
{{review_request.changenum}}/span/td


   55 :td class=labellabel for=repository{% trans
Repository %}:/label/td


   56 :td class=valuespan id=repository
{{review_request.repository}}/span/td


   57 :   /tr


Traceback:
File /usr/local/lib64/python2.6/site-packages/django/core/handlers/
base.py in get_response
  86. response = callback(request, *callback_args,
**callback_kwargs)
File /usr/local/lib64/python2.6/site-packages/ReviewBoard-1.0alpha4-
py2.6.egg/reviewboard/accounts/decorators.py in _check
  27. return view_func(*args, **kwargs)
File /usr/local/lib64/python2.6/site-packages/ReviewBoard-1.0alpha4-
py2.6.egg/reviewboard/reviews/views.py in review_detail
  200. 'PRE_CREATION': PRE_CREATION,
File /usr/local/lib64/python2.6/site-packages/django/shortcuts/
__init__.py in render_to_response
  18. return HttpResponse(loader.render_to_string(*args,
**kwargs), **httpresponse_kwargs)
File /usr/local/lib64/python2.6/site-packages/django/template/
loader.py in render_to_string
  107. return t.render(context_instance)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
  176. return self.nodelist.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
  768. bits.append(self.render_node(node, context))
File /usr/local/lib64/python2.6/site-packages/django/template/
debug.py in render_node
  71. result = node.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
loader_tags.py in render
  97. return compiled_parent.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
  176. return self.nodelist.render(context)
File /usr/local/lib64/python2.6/site-packages/django/template/
__init__.py in render
  768. 

Re: Reviewboard CMSynergy

2009-03-16 Thread David Trowbridge

We're happy to include support for any SCMs out there, but it's not
realistic for us to implement support for cmsynergy or other SCMs that
we don't have access to. If you or someone else were to submit a patch
for a cmsynergy SCMTool, we'd be happy to include it.

-David

On Mon, Mar 16, 2009 at 8:18 PM, aditya vikram avik...@gmail.com wrote:
 Hey,

 I read a couple of posts about mapping cmsynergy to reviewboard concepts.
 Are you planning to have cmsynergy supported in Reviewboard? I'll be really
 looking forward as it as we use it as one of the few SCM tools (other being
 svn  cvs)

 Thanks,
 Aditya

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Issues in configuring the smtp server to send emails..

2009-03-16 Thread chandru

Hi guys,

I have en issue in configuring the smtp server.
basically we got a smtp server which can be access on the server which
runs review board..But we tried configuring with lot of times but we
failed all the time. This is very critical for me Can anyone please
help with some good documentation please.

here is the dump of the 500 on the board

gaierror at /reviewboard/api/json/reviewrequests/28/reviews/draft/
publish/

(11001, 'getaddrinfo failed')

Request Method: POST
Request URL:
http://light/reviewboard/api/json/reviewrequests/28/reviews/draft/publish/
Exception Type: gaierror
Exception Value:

(11001, 'getaddrinfo failed')

Exception Location: c:\Python25\lib\smtplib.py in connect, line 296
Python Executable:  C:\Program Files\Apache Software Foundation
\Apache2.2\bin\httpd.exe
Python Version: 2.5.4
Python Path:['c:/www/reviewboard/conf', 'C:\\Python25\\lib\\site-
packages\\reviewboard-1.0alpha4-py2.5.egg', 'C:\\Python25\\lib\\site-
packages\\flup-1.0.1-py2.5.egg', 'C:\\Python25\\lib\\site-packages\
\djblets-0.5alpha3-py2.5.egg', 'C:\\Python25\\lib\\site-packages\
\django_evolution-0.0.0-py2.5.egg', 'C:\\Python25\\lib\\site-packages\
\django-1.0.2_final-py2.5.egg', 'C:\\Python25\\lib\\site-packages\
\simplejson-2.0.9-py2.5.egg', 'C:\\Python25\\lib\\site-packages\
\pygments-1.0-py2.5.egg', 'C:\\WINDOWS\\system32\\python25.zip', 'C:\
\Python25\\Lib', 'C:\\Python25\\DLLs', 'C:\\Python25\\Lib\\lib-tk', 'C:
\\Program Files\\Apache Software Foundation\\Apache2.2', 'C:\\Program
Files\\Apache Software Foundation\\Apache2.2\\bin', 'C:\\Python25', 'C:
\\Python25\\lib\\site-packages', 'C:\\Python25\\lib\\site-packages\
\PIL']
Server time:Mon, 16 Mar 2009 16:06:40 +1100
Traceback Switch to copy-and-paste view

* c:\python25\lib\site-packages\django-1.0.2_final-py2.5.egg\django
\core\handlers\base.py in get_response
79. # Apply view middleware
80. for middleware_method in self._view_middleware:
81. response = middleware_method(request, callback,
callback_args, callback_kwargs)
82. if response:
83. return response
84.
85. try:
86. response = callback(request, *callback_args,
**callback_kwargs) ...
87. except Exception, e:
88. # If the view raised an exception, run it through
exception
89. # middleware, and if the exception middleware returns a
90. # response, use that. Otherwise, reraise the exception.
91. for middleware_method in self._exception_middleware:
92. response = middleware_method(request, e)
  ▶ Local vars
  Variable  Value
  callback
  function review_draft_save at 0x02489730
  callback_args
  ()
  callback_kwargs
  {'api_format': u'json', 'publish': True, 'review_request_id':
u'28'}
  e
  gaierror(11001, 'getaddrinfo failed')
  exc_info
  (class 'socket.gaierror', gaierror(11001, 'getaddrinfo
failed'), traceback object at 0x0285C800)
  exceptions
  module 'django.core.exceptions' from 'C:\Python25\lib\site-
packages\django-1.0.2_final-py2.5.egg\django\core\exceptions.pyc'
  middleware_method
  bound method LoggingMiddleware.process_view of
djblets.log.middleware.LoggingMiddleware object at 0x03387A50
  receivers
  [(function _rollback_on_exception at 0x01E046F0, None)]
  request
  ModPythonRequest path:/reviewboard/api/json/reviewrequests/28/
reviews/draft/publish/, GET:QueryDict: {}, POST:QueryDict:
{u'dummy': [u'']}, COOKIES:{'collapsediffs': 'True', 'rbsessionid':
'9299810472fd790cf909191c1e83e7d2'}, META:{'AUTH_TYPE': None,
'CONTENT_LENGTH': 0L, 'CONTENT_TYPE': None, 'GATEWAY_INTERFACE': 'CGI/
1.1', 'HTTP_ACCEPT': 'application/json, text/javascript, */*',
'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.7',
'HTTP_ACCEPT_ENCODING': 'gzip,deflate', 'HTTP_ACCEPT_LANGUAGE': 'en-
us,en;q=0.5', 'HTTP_CACHE_CONTROL': 'no-cache', 'HTTP_CONNECTION':
'keep-alive', 'HTTP_CONTENT_LENGTH': '6', 'HTTP_CONTENT_TYPE':
'application/x-www-form-urlencoded; charset=UTF-8', 'HTTP_COOKIE':
'rbsessionid=9299810472fd790cf909191c1e83e7d2; collapsediffs=True',
'HTTP_HOST': 'light', 'HTTP_KEEP_ALIVE': '300', 'HTTP_PRAGMA': 'no-
cache', 'HTTP_REFERER': 'http://light/reviewboard/r/28/diff/',
'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-
US; rv:1.9.0.7) Gecko/2009021906 Firefox/3.0.7',
'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest', 'PATH_INFO': u'/reviewboard/
api/json/reviewrequests/28/reviews/draft/publish/', 'PATH_TRANSLATED':
None, 'QUERY_STRING': None, 'REMOTE_ADDR': '192.168.23.121',
'REMOTE_HOST': None, 'REMOTE_IDENT': None, 'REMOTE_USER': None,
'REQUEST_METHOD': 'POST', 'SCRIPT_NAME': '', 'SERVER_NAME': 'light',
'SERVER_PORT': 0, 'SERVER_PROTOCOL': 'HTTP/1.1', 'SERVER_SOFTWARE':
'mod_python'}
  resolver
  RegexURLResolver djblets.util.rooturl ^/
  response
  None
  self
  django.core.handlers.modpython.ModPythonHandler object at

Issue 957 in reviewboard: UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 3: ordinal not in range(128)

2009-03-16 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 957 by i...@avalanchestudios.se: UnicodeDecodeError: 'ascii'  
codec can't decode byte 0xc3 in position 3: ordinal not in range(128)
http://code.google.com/p/reviewboard/issues/detail?id=957

Hi,

We're using alpha4 with perforce, and posting diffs with post-review.py,
hitting this error:


URL: http://reviewboard/r/296/diff/

Traceback (most recent call last):
   File
/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha4-py2.4.egg/reviewboard/diffviewer/views.py,
line 145, in view_diff
 interdiffset, highlighting, True)[0]
   File
/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha4-py2.4.egg/reviewboard/diffviewer/diffutils.py,
line 619, in get_diff_files
 large_data=True)
   File
/usr/lib/python2.4/site-packages/Djblets-0.5alpha3-py2.4.egg/djblets/util/misc.py,
line 143, in cache_memoize
 data = lookup_callable()
   File
/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha4-py2.4.egg/reviewboard/diffviewer/diffutils.py,
line 618, in lambda
 enable_syntax_highlighting),
   File
/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha4-py2.4.egg/reviewboard/diffviewer/diffutils.py,
line 431, in get_chunks
 a[i1:i2], b[j1:j2], oldlines, newlines)
   File
/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha4-py2.4.egg/reviewboard/diffviewer/diffutils.py,
line 265, in diff_line
 if oldline and newline and oldline != newline:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 3:
ordinal not in range(128)


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 953 in reviewboard: Diff viewer does not work on Mercurial ssh repositories

2009-03-16 Thread codesite-noreply


Comment #1 on issue 953 by sandeep.iitkgp: Diff viewer does not work on  
Mercurial ssh repositories
http://code.google.com/p/reviewboard/issues/detail?id=953

I had the same problem even though I was not using SSH. The problem seems  
to be that
reviewboard's support for mercurial seems to be based on a newer version of  
the 'hg
python API'. Hence the 'sshrepository' object has no attribute 'changectx'.  
Upgrading
to mercurial 1.1.2 solved the problem for me.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 954 in reviewboard: Download Diff should allow selection of line endings

2009-03-16 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 954 by grossag: Download Diff should allow selection of line  
endings
http://code.google.com/p/reviewboard/issues/detail?id=954

*NOTE: If you have a patch, please submit it to http://reviews.review-
board.org/

Describe the enhancement and the motivation for it.
On my Windows machine, if I try to download the diff from review board and
feed it directly in patch, patch fails because it can't handle the Unix
line endings.  I then have to find a unix2dos utility to convert it to dos
line endings.  It would be nice if the Download Diff button could have a
dropdown menu like Close, in this case letting you select Windows or Linux
compatibility.

What operating system are you using? What browser?
Firefox 3 on Windows XP Pro SP3


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 928 in reviewboard: post-review in subdirectories of a git (svn) work tree would result in broken diffs.

2009-03-16 Thread codesite-noreply


Comment #1 on issue 928 by vicaya: post-review in subdirectories of a git  
(svn) work tree would result in broken diffs.
http://code.google.com/p/reviewboard/issues/detail?id=928

http://reviews.review-board.org/r/756/

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 927 in reviewboard: Add guess-summary and guess-description options for those who use a dvcs like git

2009-03-16 Thread codesite-noreply


Comment #2 on issue 927 by vicaya: Add guess-summary and guess-description  
options for those who use a dvcs like git
http://code.google.com/p/reviewboard/issues/detail?id=927

http://reviews.review-board.org/r/755

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 936 in reviewboard: Add a way for a reviewer to only see the new version of the code (e.g. collapse/remove the diff)

2009-03-16 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 936 by keithhoffman22: Add a way for a reviewer to only see the  
new version of the code (e.g. collapse/remove the diff)
http://code.google.com/p/reviewboard/issues/detail?id=936

*NOTE: If you have a patch, please submit it to http://reviews.review-
board.org/

What's the URL of the page this enhancement relates to, if any?
Reviews

Describe the enhancement and the motivation for it.
Currently, you can only view the code under review as diff.  There are two
problems with this:
1.  Some users prefer only to examine the code as it will be post-review.
They aren't interested in the diff.
2.  Sometimes the code is line-wrapped so much it becomes harder to look
at.  It would be nice to be able to remove the diff (alternatively,
motivation #2 could be satisfied by collapsing the old portion of the diff).

What operating system are you using? What browser?
Irrelevant.  Windows Vista, Firefox.

Please provide any additional information below.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 935 in reviewboard: Add notification of a draft unpublished review to the top of the review page as well as in-line with the reviews

2009-03-16 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 935 by keithhoffman22: Add notification of a draft unpublished  
review to the top of the review page as well as in-line with the reviews
http://code.google.com/p/reviewboard/issues/detail?id=935

*NOTE: If you have a patch, please submit it to http://reviews.review-
board.org/

What's the URL of the page this enhancement relates to, if any?


Describe the enhancement and the motivation for it.
Currently, if you are responding to a review and slide up to examine say
the review description etc, you may miss the Draft Review. Click to Publish
notification.  Add this notification to the top of the review as well or
make it slide with the window.

What operating system are you using? What browser?
Windows Vista, Firefox 3.0.6

Please provide any additional information below.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 959 in reviewboard: LDAP authentication scope

2009-03-16 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 959 by kimonp: LDAP authentication scope
http://code.google.com/p/reviewboard/issues/detail?id=959

The LDAP server at my (very large) company would not authenticate with
reviewboard using LDAP.  The problem was the SCOPE settings used in
ldapo.search_s() in accounts/backends.py

It was set to: SCOPE_ONELEVEL
I changed it to: SCOPE_SUBTREE

This was in 2 places in backends.py (which is all of the instances of
SCOPE_ONELEVEL).

This was the setting used in our company's example script which is why I
tried it.

When I changed both instances is accounts/backends.py it was able to
authenticate properly against our LDSP.

Based on the following, I think this is a better value for this script and
likely to work with more varied LDAP schemes:
http://www.idevelopment.info/data/LDAP/LDAP_Resources/SEARCH_Setting_the_SCOPE_Parameter.shtml

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 873 in reviewboard: page not found at /review/r/rid/diff/X-X/raw

2009-03-16 Thread codesite-noreply


Comment #2 on issue 873 by ciaomary: page not found at  
/review/r/rid/diff/X-X/raw
http://code.google.com/p/reviewboard/issues/detail?id=873

We're also having this issue. Even with the 3/13/09 nightly.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 807 in reviewboard: Links from reviews do not link to the corresponding line in the diff properly.

2009-03-16 Thread codesite-noreply


Comment #11 on issue 807 by ciaomary: Links from reviews do not link to the  
corresponding line in the diff properly.
http://code.google.com/p/reviewboard/issues/detail?id=807

I can also confirm this is fixed with 3/13/09 nightly. Thanks!

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 961 in reviewboard: A comment box pops up if you click 'expand' in diff viewer on RB 3/13 nightly

2009-03-16 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 961 by ciaomary: A comment box pops up if you click 'expand' in  
diff viewer on RB 3/13 nightly
http://code.google.com/p/reviewboard/issues/detail?id=961

What's the URL of the page containing the problem?
https://reviewboard/r/2276/diff/#index_header

What steps will reproduce the problem?
1. Open up the diff.
2. Click to 'expand' code
3. An annoying comment box pops up that you must cancel.

This is on the nightly 3/13/09 nightly RB install

What is the expected output? What do you see instead?
Very annoying and strange behavior.

What operating system are you using? What browser?
RB server=CentOS 5. Browser=Firefox 3.0.7

Please provide any additional information below.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---