Review Board 1.0 RC2 released
Hi everyone, I just put out Review Board 1.0 RC2, which should take care of the major issues people hit with RC1. Please give it a try and report a bug if any major issues are hit. Full release information is up at http://review-board.org/news/2009/05/08/review-board-10-rc2-released/ Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Install Issue on Windows
I've tried to hunt around but cant seem find a simple answer to this problem. Im trying to install review board on windows and the guide seemed half written, i.e. i installed all the dependancies then it just says once you've finished getting review board installed you will want to create a site. After searching i found and followed this guide http://yuanyi-wang.blogspot.com/2009/03/install-review-board-on-windows.html which seems to have gotten me 99% of the way there now. I can get all the way to installing the site then i hit an issue, i get: Building site configuration files ... OK Creating database ... Unable to read settings_local.py. I've got mySQL installed and running (giving the root password to the installer for review board), apache is up and running as is memcached. The really odd thing is that it says it cant read the settings_local.py file but it creates that file itself in the conf directory of the site? Im running as the admin of the server as well so have full rights over the files. If anyone could give me a hint as to what to look at i really want to get this sorted, Review Board seems like a great tool if only i could get it working :) Thanks, Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Install Issue on Windows
Hi Chris, You need to grab RC2, which was released tonight. It fixes this issue. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, May 8, 2009 at 2:54 AM, Chris c.d.whitco...@gmail.com wrote: I've tried to hunt around but cant seem find a simple answer to this problem. Im trying to install review board on windows and the guide seemed half written, i.e. i installed all the dependancies then it just says once you've finished getting review board installed you will want to create a site. After searching i found and followed this guide http://yuanyi-wang.blogspot.com/2009/03/install-review-board-on-windows.html which seems to have gotten me 99% of the way there now. I can get all the way to installing the site then i hit an issue, i get: Building site configuration files ... OK Creating database ... Unable to read settings_local.py. I've got mySQL installed and running (giving the root password to the installer for review board), apache is up and running as is memcached. The really odd thing is that it says it cant read the settings_local.py file but it creates that file itself in the conf directory of the site? Im running as the admin of the server as well so have full rights over the files. If anyone could give me a hint as to what to look at i really want to get this sorted, Review Board seems like a great tool if only i could get it working :) Thanks, Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: perforce visual client tool
On 05/08/2009 10:48 PM, tom wrote: So, I've put together a python based tool for submitting reviews via perforce visual client's context menu - a wxwidgets based thing for launching postreview, basically. Would anyone be interested? Yes, I was recently thinking about hacking some simple GUI with wxPython together too. Although with SVN/git as VCS in mind (but that should really matter since the interface aren't that different)... If so, there's one improvement I'd like to make. Currently, it requires a settings file to know what the available users and groups are for the review, to create the drop down lists - I'd like to query the review board web application if possible to determine these (and the set of open review ids, too)... does the web application provide interfaces for retrieving this easily? Is this info something the future RBTools module might provide in a nice way? It should be possible through the API: http://code.google.com/p/reviewboard/wiki/ReviewBoardAPI Best regards, Markus --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: perforce visual client tool
Hi Tom, Yep, the API has the ability to show you the list of groups and users. I haven't personally tried this, but you might want to look at wxpostreview in our SVN tree and see if it suits your needs, or if it would work as a base for what you want to do. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, May 8, 2009 at 1:48 PM, tom december1...@gmail.com wrote: Hi, I'd like to contribute to this project, as I think ReviewBoard is a great thing! So, I've put together a python based tool for submitting reviews via perforce visual client's context menu - a wxwidgets based thing for launching postreview, basically. Would anyone be interested? If so, there's one improvement I'd like to make. Currently, it requires a settings file to know what the available users and groups are for the review, to create the drop down lists - I'd like to query the review board web application if possible to determine these (and the set of open review ids, too)... does the web application provide interfaces for retrieving this easily? Is this info something the future RBTools module might provide in a nice way? Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Install Issue on Windows
Hi Chris, We definitely want to improve the Windows install. The issue is that a lot of what we depend on isn't made to easily install on Windows. Plus we're really Linux guys and most of our users are installing on Linux. However, I know that better instructions would help with this, and I'll see about improving them. Review Board 1.0 RC3 will make rb-site easier to use as well, since we'll be providing an rb-site.exe that will be in the path, instead of making you run a script in Python. I'm not sure I understand your instructions. You commit, then want that posted for review, then commit the fixes based on that? That's a post-commit model, not pre-commit. Pre-commit would be where you haven't committed anything yet to the official tree, and wait to do so until your code is reviewed. There are users who use Review Board in a post-commit model, or post code to a branch and then merge when done, and have hooks for this. For example, see http://reviews.review-board.org/r/589/ Now, what most users do is use our post-review tool (part of RBTools - see http://www.review-board.org/docs/manual/dev/users/tools/post-review/) to post and update review requests. You basically just set it up and then, in your SVN tree, run: post-review Which will post a new review request, upload the diff, and provide the URL of the posted code. To update an existing review request with a new version of the diff, run: post-review -r reviewrequestid There's a section in the docs I listed above for post-review that explains how to set that all up and use it. You won't have to manually build diffs and upload through the web interface. Most (if not all) of the pre-commit and post-commit hooks out there make use of post-review, as that's the standard, official command line tool for talking to a Review Board server right now. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, May 8, 2009 at 7:48 AM, Chris c.d.whitco...@gmail.com wrote: Christian, Thanks for the help, not the easiest of install processes but i got there in the end. Im hoping this tool is just what we need. A quick question (as after reading the doc i thought this is how Review Board would work but im not 100% sure now), basically i was hoping to add some sort of pre-commit hook in SVN so that. User commits to SVN Pre-Commit Hooks that event and adds a new review request in Code is reviewed in Review Board Once code has been given the OK it moves into the SVN repository. Im a little confused about how to make this happen, i.e. review board seems to be asking for all these diff's as files etc, which seems quite manual. Is that how it works or am i just not understanding things correctly? Maybe i've had too much coffee today! Thanks, Chris On May 8, 11:24 am, Christian Hammond chip...@chipx86.com wrote: Hi Chris, You need to grab RC2, which was released tonight. It fixes this issue. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, May 8, 2009 at 2:54 AM, Chris c.d.whitco...@gmail.com wrote: I've tried to hunt around but cant seem find a simple answer to this problem. Im trying to install review board on windows and the guide seemed half written, i.e. i installed all the dependancies then it just says once you've finished getting review board installed you will want to create a site. After searching i found and followed this guide http://yuanyi-wang.blogspot.com/2009/03/install-review-board-on-windo. .. which seems to have gotten me 99% of the way there now. I can get all the way to installing the site then i hit an issue, i get: Building site configuration files ... OK Creating database ... Unable to read settings_local.py. I've got mySQL installed and running (giving the root password to the installer for review board), apache is up and running as is memcached. The really odd thing is that it says it cant read the settings_local.py file but it creates that file itself in the conf directory of the site? Im running as the admin of the server as well so have full rights over the files. If anyone could give me a hint as to what to look at i really want to get this sorted, Review Board seems like a great tool if only i could get it working :) Thanks, Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 1112 in reviewboard: AD Logins Silently Failing
Updates: Status: Fixed Owner: chipx86 Labels: -Priority-Medium Priority-Critical Component-Accounts Comment #1 on issue 1112 by chipx86: AD Logins Silently Failing http://code.google.com/p/reviewboard/issues/detail?id=1112 Fixed in r1959. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1111 in reviewboard: Sample apache configuration doesn't handle spaces in installed path.
Updates: Status: Fixed Owner: chipx86 Labels: Milestone-Release1.0 Component-Deployment Comment #1 on issue by chipx86: Sample apache configuration doesn't handle spaces in installed path. http://code.google.com/p/reviewboard/issues/detail?id= Fixed in r1962. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1110 in reviewboard: Review board installation doesn't create windows-friendly entries in Scripts
Updates: Status: Confirmed Owner: chipx86 Labels: Milestone-Release1.0 OpSys-Windows Comment #3 on issue 1110 by chipx86: Review board installation doesn't create windows-friendly entries in Scripts http://code.google.com/p/reviewboard/issues/detail?id=1110 I'll have this fixed in RC3. I believe I now know what's needed to generate .exe files for rb-site, but it will need some testing. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1114 in reviewboard: Incorrect email address generation for AD based authentication.
Comment #3 on issue 1114 by RDubrawski: Incorrect email address generation for AD based authentication. http://code.google.com/p/reviewboard/issues/detail?id=1114 Verified fixed. Thanks -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1110 in reviewboard: Review board installation doesn't create windows-friendly entries in Scripts
Updates: Status: Fixed Comment #4 on issue 1110 by chipx86: Review board installation doesn't create windows-friendly entries in Scripts http://code.google.com/p/reviewboard/issues/detail?id=1110 Fixed in r1967. A rb-site.exe will be provided in RC3, or in tonight's nightly. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1109 in reviewboard: Draft for outgoing review request found which I never posted.
Updates: Status: NeedInfo Comment #1 on issue 1109 by chipx86: Draft for outgoing review request found which I never posted. http://code.google.com/p/reviewboard/issues/detail?id=1109 Not being at IronPort, I can't investigate this at all. You'll need to talk to your administrator and see if you can figure out what happened. It could be that this was due to a bug in Review Board where if you typed the wrong change number, it would create a review request with that changeset info, but then error out (I believe). This would cause a draft review request to be created without you realizing it had happened. Every time we've seen a bug like this, it's been due to this issue. I believe there's a bug tracking this, but I don't know where. How old is the review request? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1107 in reviewboard: Changes in review requests sometimes show up as occuring 7 hours earlier than the actually do
Updates: Status: NeedInfo Comment #1 on issue 1107 by chipx86: Changes in review requests sometimes show up as occuring 7 hours earlier than the actually do http://code.google.com/p/reviewboard/issues/detail?id=1107 From what I can tell, that looks completely correct. The second one is saying it's 2 days, 11 hours ago, while the first is 2 days, 18 hours ago. The second one is more recent. What are you seeing about that that seems wrong? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1105 in reviewboard: Time shown in dashboard does not match timezone
Updates: Status: NeedInfo Comment #1 on issue 1105 by chipx86: Time shown in dashboard does not match timezone http://code.google.com/p/reviewboard/issues/detail?id=1105 What OS/distro are you using? What web server? Just to make sure, did you restart your web server after upgrading Review Board? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1110 in reviewboard: Review board installation doesn't create windows-friendly entries in Scripts
Comment #5 on issue 1110 by javier.ortiz.78: Review board installation doesn't create windows-friendly entries in Scripts http://code.google.com/p/reviewboard/issues/detail?id=1110 1084 is a duplicate of this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1105 in reviewboard: Time shown in dashboard does not match timezone
Comment #2 on issue 1105 by onkarshinde: Time shown in dashboard does not match timezone http://code.google.com/p/reviewboard/issues/detail?id=1105 I am using Ubuntu 8.04 and apache server. I restarted the web server multiple times. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
